From nobody Tue Feb 10 04:56:01 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1501497136934622.2856828461121; Mon, 31 Jul 2017 03:32:16 -0700 (PDT) Received: from localhost ([::1]:58613 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dc7zj-0003EI-EX for importer@patchew.org; Mon, 31 Jul 2017 06:32:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dc7ur-0007qA-40 for qemu-devel@nongnu.org; Mon, 31 Jul 2017 06:27:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dc7uo-0001zJ-BJ for qemu-devel@nongnu.org; Mon, 31 Jul 2017 06:27:13 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:57471) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dc7uo-0001yc-3F; Mon, 31 Jul 2017 06:27:10 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 5315442A9D; Mon, 31 Jul 2017 13:27:09 +0300 (MSK) Received: from tls.msk.ru (mjt.vpn.tls.msk.ru [192.168.177.99]) by tsrv.corpit.ru (Postfix) with SMTP id D9381B89; Mon, 31 Jul 2017 13:21:45 +0300 (MSK) Received: (nullmailer pid 5565 invoked by uid 1000); Mon, 31 Jul 2017 10:21:45 -0000 From: Michael Tokarev To: qemu-devel@nongnu.org Date: Mon, 31 Jul 2017 13:21:32 +0300 Message-Id: <4b5660e403c9cae998dc70b51288968655977896.1501496349.git.mjt@msgid.tls.msk.ru> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 86.62.121.231 Subject: [Qemu-devel] [PULL 13/25] m68k/translate: fix incorrect copy/paste X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Michael Tokarev , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" From: Philippe Mathieu-Daud=C3=A9 db3d7945ae extended gen_cc_cond() for cond [6, 7, 9, 10] but misswrote [4, = 5] target/m68k/translate.c:1323:70: warning: identical expressions on both sid= es of logical operator if (op =3D=3D CC_OP_ADDB || op =3D=3D CC_OP_ADDW || op =3D=3D CC_OP= _ADDL || op =3D=3D CC_OP_ADDB || op =3D=3D CC_OP_ADDW || op =3D=3D CC_OP= _ADDL) { ~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~ ^ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Laurent Vivier Reviewed-by: Richard Henderson Signed-off-by: Michael Tokarev --- target/m68k/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index ada2a91b64..be24355080 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -1321,7 +1321,7 @@ static void gen_cc_cond(DisasCompare *c, DisasContext= *s, int cond) case 5: /* CS (C) */ /* Some cases fold C into X. */ if (op =3D=3D CC_OP_ADDB || op =3D=3D CC_OP_ADDW || op =3D=3D CC_O= P_ADDL || - op =3D=3D CC_OP_ADDB || op =3D=3D CC_OP_ADDW || op =3D=3D CC_O= P_ADDL) { + op =3D=3D CC_OP_SUBB || op =3D=3D CC_OP_SUBW || op =3D=3D CC_O= P_SUBL) { tcond =3D TCG_COND_NE; c->v1 =3D QREG_CC_X; goto done; --=20 2.11.0