From nobody Sun Feb 8 14:33:30 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=us.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1577587767; cv=none; d=zohomail.com; s=zohoarc; b=FvqcCyGOR8/SN0cpsrYX7qgCO025WN8h70E/Bbp/AVOuT1giVzPVIrY/z3A9QWzZx6/VZnErxdn9GgJDGWu9w5WzZEhrpA2CTVtDHPxqTw66w23uVfKiO+Tnbwwc4kwPtud89+V1tX/cmX5We7FlaPtJ2pvzJkwgjJo2Qf536IM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1577587767; h=Content-Type:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=sJWvExv6uGdUcB2DeCLmJnKeoF+ApwOQG9Agr6xE9vc=; b=W9U45MSd3XkScrki71kR8Ci/A4aX6EwO2nVRXx1+h0OHgxea52DbabKis/t3+ursWZO3GBdvxIPHNu65lPlwYUO/RS2opoJXQHtTVKYfTgP/NM8QpVSZ5WZ0PF+5iN/F7bBmJ0MaDNqX1UVHJ7Ewx5enNFx4tWln7C7Ta6P8ubg= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1577587767872524.3127460605799; Sat, 28 Dec 2019 18:49:27 -0800 (PST) Received: from localhost ([::1]:48650 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ilOdy-0007K5-Rh for importer@patchew.org; Sat, 28 Dec 2019 21:49:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43505) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ilOdH-0006lA-Sp for qemu-devel@nongnu.org; Sat, 28 Dec 2019 21:48:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ilOdG-00067w-Q3 for qemu-devel@nongnu.org; Sat, 28 Dec 2019 21:48:43 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:1580 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ilOdC-0005w8-S7; Sat, 28 Dec 2019 21:48:38 -0500 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xBT2gPVP117453; Sat, 28 Dec 2019 21:48:37 -0500 Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 2x6441yh3g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 28 Dec 2019 21:48:37 -0500 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id xBT2iZbu120229; Sat, 28 Dec 2019 21:48:36 -0500 Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0b-001b2d01.pphosted.com with ESMTP id 2x6441yh37-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 28 Dec 2019 21:48:36 -0500 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id xBT2jDb4022216; Sun, 29 Dec 2019 02:48:36 GMT Received: from b03cxnp08025.gho.boulder.ibm.com (b03cxnp08025.gho.boulder.ibm.com [9.17.130.17]) by ppma04wdc.us.ibm.com with ESMTP id 2x5xp5q1bg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 29 Dec 2019 02:48:36 +0000 Received: from b03ledav003.gho.boulder.ibm.com (b03ledav003.gho.boulder.ibm.com [9.17.130.234]) by b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id xBT2mZwd55116262 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 29 Dec 2019 02:48:35 GMT Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 10E136A04D; Sun, 29 Dec 2019 02:48:35 +0000 (GMT) Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D61496A047; Sun, 29 Dec 2019 02:48:34 +0000 (GMT) Received: from mail.gmx.ibm.com (unknown [9.209.242.114]) by b03ledav003.gho.boulder.ibm.com (Postfix) with ESMTPS; Sun, 29 Dec 2019 02:48:34 +0000 (GMT) Received: from m01ex005.gmx.ibm.com (10.148.53.45) by m01ex002.gmx.ibm.com (10.148.53.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1779.2; Sat, 28 Dec 2019 21:48:20 -0500 Received: from m01ex005.gmx.ibm.com ([fe80::7d2d:476:2d5a:cb2f]) by m01ex005.gmx.ibm.com ([fe80::7d2d:476:2d5a:cb2f%9]) with mapi id 15.01.1779.002; Sat, 28 Dec 2019 20:48:20 -0600 From: "Marek Dolata - mkdolata@us.ibm.com" To: "qemu-devel@nongnu.org" Subject: [PATCH v4] target/i386: Fix handling of k_gs_base register in 32-bit mode in gdbstub Thread-Topic: [PATCH v4] target/i386: Fix handling of k_gs_base register in 32-bit mode in gdbstub Thread-Index: AdW98htrzEem9H8FS6K9td8fI3BiWQ== Date: Sun, 29 Dec 2019 02:48:20 +0000 Message-ID: <4afa19236529458282794f682dfac556@us.ibm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [9.16.14.37] Content-Type: multipart/alternative; boundary="_000_4afa19236529458282794f682dfac556usibmcom_" MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-12-28_08:2019-12-27,2019-12-28 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 clxscore=1015 suspectscore=0 mlxlogscore=999 phishscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-1912290025 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 148.163.158.5 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , "qemu-trivial@nongnu.org" , Doug Gale , Markus Armbruster , Paolo Bonzini , =?iso-8859-1?Q?Philippe_Mathieu-Daud=E9?= , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" --_000_4afa19236529458282794f682dfac556usibmcom_ Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Fixes: corrects clobbering of registers appearing after k_gs_base Buglink: https://bugs.launchpad.net/qemu/+bug/1857640 Signed-off-by: Marek Dolata --- target/i386/gdbstub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/gdbstub.c b/target/i386/gdbstub.c index aef25b70f1..572ead641c 100644 --- a/target/i386/gdbstub.c +++ b/target/i386/gdbstub.c @@ -350,15 +350,15 @@ int x86_cpu_gdb_write_register(CPUState *cs, uint8_t = *mem_buf, int n) env->segs[R_GS].base =3D ldl_p(mem_buf); return 4; -#ifdef TARGET_X86_64 case IDX_SEG_REGS + 8: +#ifdef TARGET_X86_64 if (env->hflags & HF_CS64_MASK) { env->kernelgsbase =3D ldq_p(mem_buf); return 8; } env->kernelgsbase =3D ldl_p(mem_buf); - return 4; #endif + return 4; case IDX_FP_REGS + 8: cpu_set_fpuc(env, ldl_p(mem_buf)); -- 2.24.1 --_000_4afa19236529458282794f682dfac556usibmcom_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable

Fixes: corrects clobbering of registers appea= ring after k_gs_base

Buglink: https://bugs.launchpad.net/qemu/+= ;bug/1857640

 

Signed-off-by: Marek Dolata <mkdolata@us.i= bm.com>

---

target/i386/gdbstub.c | 4 ++--

1 file changed, 2 insertions(+), 2 deleti= ons(-)

 

diff --git a/target/i386/gdbstub.c b/target/i= 386/gdbstub.c

index aef25b70f1..572ead641c 100644

--- a/target/i386/gdbstub.c=

+++ b/target/i386/gdbstub.c<= /o:p>

@@ -350,15 +350,15 @@ int x86_cpu_gdb_wri= te_register(CPUState *cs, uint8_t *mem_buf, int n)

       &nb= sp;     env->segs[R_GS].base =3D ldl_p(mem_buf);

       &nb= sp;     return 4;

-#ifdef TARGET_X86_64

       &nb= sp; case IDX_SEG_REGS + 8:

+#ifdef TARGET_X86_64

       &nb= sp;     if (env->hflags & HF_CS64_MASK) {

       &nb= sp;         env->kernelgsbase = =3D ldq_p(mem_buf);

       &nb= sp;         return 8;

        &n= bsp;    }

       &nb= sp;     env->kernelgsbase =3D ldl_p(mem_buf);

-       &n= bsp;    return 4;

#endif

+      &nbs= p;     return 4;

       &nb= sp; case IDX_FP_REGS + 8:

       &nb= sp;     cpu_set_fpuc(env, ldl_p(mem_buf));

--

2.24.1

 

--_000_4afa19236529458282794f682dfac556usibmcom_--