From nobody Sun May 5 17:58:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1561454718; cv=none; d=zoho.com; s=zohoarc; b=MwaMNVE9U3Vrd9xNgvc+DmS+9ZzE3sCNB8+bDnxEkRzrb3fJrdRu3tQOokWQdiGcq9yBaOdqC4fm/wcOeZI4q09gQDnbHOo+QzIXw6Fzp/z1ExPfvCLypV9F1EgRHood1aHtjjn1GAtn9GU5vm2AbhCzqqv+xkWzwVo9mfrzZcA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1561454718; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=9lGAcAg9fjR59KFRj/dFI9y0S6NbmPeBua+DQBsOvp4=; b=MIYV0iv2iRVbcpRf2gYDGolHXAEGDkr8JmbDP8JKVnVa/3kGFOytnw6WwpGC63MEVku090IPeq2e1DkS5QesSe0Bpmh3+hdjI1fAnrs8jphGqa+3jka1iy+giKxTWvKe2TsYLzS7FKUcSFfafKxRz8drT7zy7ayCLvDvruLngHI= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1561454718774563.5798333578788; Tue, 25 Jun 2019 02:25:18 -0700 (PDT) Received: from localhost ([::1]:57856 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfhhV-00073S-TI for importer@patchew.org; Tue, 25 Jun 2019 05:25:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41916) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfhgT-0006aE-DP for qemu-devel@nongnu.org; Tue, 25 Jun 2019 05:24:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfhgR-0003FY-LO for qemu-devel@nongnu.org; Tue, 25 Jun 2019 05:24:13 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:42631) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfhgR-0003EJ-DG for qemu-devel@nongnu.org; Tue, 25 Jun 2019 05:24:11 -0400 Received: by mail-wr1-f67.google.com with SMTP id x17so16971870wrl.9 for ; Tue, 25 Jun 2019 02:24:10 -0700 (PDT) Received: from ?IPv6:2a01:e35:8b6a:1220:e1dd:b35b:b1e3:d497? ([2a01:e35:8b6a:1220:e1dd:b35b:b1e3:d497]) by smtp.gmail.com with ESMTPSA id 11sm1980357wmb.26.2019.06.25.02.24.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Jun 2019 02:24:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:message-id:date:cc:to; bh=9lGAcAg9fjR59KFRj/dFI9y0S6NbmPeBua+DQBsOvp4=; b=q7y1GwRVVa0LzXcUlRO8JQK1ErNxBmmj8CoDRLQ3lCRnGT8TXDneQ6cEFH+tdJ5K+6 +EELmBImPpiBnR+XS+JsHpWXchZFgg4cSdXRooosWo0mshFM/Xc+dxdKIQJ60jpw0vk+ N4Mp0SW9C6zEp2SEtBfx06tj17BlCT7BqrVCbOaMikt/YhaE3sOuKxRBMK2m8vkgZhtV JuzLILA2E52jXxwdZgC/Da1vEUyrFVFt9ujfiEG/+BrINZdInxQd4aKkRModfkx7pdBS ryarE2Rke6pet0fqiQVrAT4xGaEw0ewdKgOhqONWzXqOy+blKSXaltdhFJu1J33RmsTu ILrg== X-Gm-Message-State: APjAAAVAaBk3SZP0HdZejNKdQgaV74+jm/dQXIGw9bralN9ODm0cxW4s x/MoX3kttRK1ryojm65rYv87LeQl7IM= X-Google-Smtp-Source: APXvYqw0a+e+c16+O6ocToIFxYsk21iz48+Wg3ha8wwpSmaAFhB50aowg0JRFKOZJSwrRZpFGNoBaw== X-Received: by 2002:adf:cf0a:: with SMTP id o10mr35802862wrj.37.1561454649038; Tue, 25 Jun 2019 02:24:09 -0700 (PDT) From: Christophe de Dinechin Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Message-Id: <4C5F8F98-D058-46A4-81E7-D9A5D4FEE2EC@redhat.com> Date: Tue, 25 Jun 2019 11:24:05 +0200 To: qemu-devel@nongnu.org X-Mailer: Apple Mail (2.3445.104.11) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.221.67 Subject: [Qemu-devel] [PATCH] Fix build error when VNC is configured out X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" In hmp_change(), the variable hmp_mon is only used by code under #ifdef CONFIG_VNC. This results in a build error when VNC is configured out with the default of treating warnings as errors: monitor/hmp-cmds.c: In function =E2=80=98hmp_change=E2=80=99: monitor/hmp-cmds.c:1946:17: error: unused variable =E2=80=98hmp_mon=E2=80= =99 [-Werror=3Dunused-variable] 1946 | MonitorHMP *hmp_mon =3D container_of(mon, MonitorHMP, common); | ^~~~~~~ Signed-off-by: Christophe de Dinechin Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- monitor/hmp-cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index c283dde0e9..038614da8e 100644 --- a/monitor/hmp-cmds.c +++ b/monitor/hmp-cmds.c @@ -1943,7 +1943,6 @@ static void hmp_change_read_arg(void *opaque, const c= har *password, =20 void hmp_change(Monitor *mon, const QDict *qdict) { - MonitorHMP *hmp_mon =3D container_of(mon, MonitorHMP, common); const char *device =3D qdict_get_str(qdict, "device"); const char *target =3D qdict_get_str(qdict, "target"); const char *arg =3D qdict_get_try_str(qdict, "arg"); @@ -1952,6 +1951,7 @@ void hmp_change(Monitor *mon, const QDict *qdict) Error *err =3D NULL; =20 #ifdef CONFIG_VNC + MonitorHMP *hmp_mon =3D container_of(mon, MonitorHMP, common); if (strcmp(device, "vnc") =3D=3D 0) { if (read_only) { monitor_printf(mon, --=20 2.20.1=20