From nobody Tue Nov 18 09:16:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=web.de ARC-Seal: i=1; a=rsa-sha256; t=1609167939; cv=none; d=zohomail.com; s=zohoarc; b=imdDy1Z7KL8pDl/wmPjn37YjFXw09Mo1L6/NnyxdNo4+edZ38MjkJaOC0hFtxTcuHRvH2kBhGhTYcpk3yZAEITEKOLu4YktfWGaaHbChDixnSOrh3d5gbqgkMN+bHiJW2oZMXMVIDC+OGvXcnIti+JMJHiwaez+SkXxlDl03hIU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1609167939; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=LYxBEDOiq6WwvsPlAB7VMHAGUuKX9SAL61JmhfDflJ8=; b=k2jSRPgFRcPKyc8PHiGeskPkYtla0P5P5frYafnjzNOnu//snq8f3JZPGYmoGxW/z8rVl9e1RMwrRM7YCIH+ZB3RjfX4oQPtBuedyEdwJem42ZndxQY70s/Qube9OkNcBqH7sDy/QFKx3oVh+Y3n6o503288KojUQaSo7+ca214= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1609167939003700.6900007123592; Mon, 28 Dec 2020 07:05:39 -0800 (PST) Received: from localhost ([::1]:39966 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ktu5a-0000dL-8Y for importer@patchew.org; Mon, 28 Dec 2020 10:05:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47756) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kttz9-00032O-6m; Mon, 28 Dec 2020 09:59:00 -0500 Received: from mout.web.de ([212.227.15.4]:59115) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kttz7-0006Zq-JB; Mon, 28 Dec 2020 09:58:58 -0500 Received: from gecko.fritz.box ([94.134.180.94]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MBjMO-1kjysh31kS-00CUF6; Mon, 28 Dec 2020 15:58:51 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1609167531; bh=xTxUnzjUnA38dyvVmkYbdHX7AdjG9X3ODr8poi3pd+k=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:In-Reply-To:References; b=osapwambrY5+EuJLAYoCEnCrDE4KwbxytPw65sUGxExvpzAKqnPjbT6ArBcPuENIK G6udYIgdLiKqwyMs7plTq+qaQbq89/sqSAVxPCiJW5Wp89DorOA1kjwV3S3oEZWSB4 XCH5Vh5UdeAJGbOqWz9VLtUYv8en5Bgfs/JB5IUo= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Date: Mon, 28 Dec 2020 15:58:50 +0100 From: Lukas Straub To: qemu-devel Subject: [PATCH v13 5/7] io/channel-tls.c: make qio_channel_tls_shutdown thread-safe Message-ID: <4708cdb2a270bc363d6de2d0b9ad74425ed0e2d1.1609166587.git.lukasstraub2@web.de> In-Reply-To: References: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/ZouMWtKK7q31XoOZfLk=Ud+"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Provags-ID: V03:K1:FS3mPOW/xfR9/6RJ1LbTyEDjnN7d0W+MxhW4iy6p7eeyZwtcKl+ FbJ5DKFBoePg8SYxzIlefXLbaT2AbwNOUyGVYtAJ+xjv/bX9dnl2mA8yCSVb71kTbIlPH5F UKUwMQgdHh6v8oo6nrO9euKbXpKQQnVJmbY9dfv/l0nglUYc0wgvO3LTl0Nq7fxjXay5gpc h4v8+HNkBXQLUBb5xB+MA== X-UI-Out-Filterresults: notjunk:1;V03:K0:f+ilFZRGpYY=:oa133+4ec7G8NksZOSap+E zWjOCxo0kpJXN5mFNkRhIzm7Nvsov4stMm4CTypRhSMub7p5YnKkYfNgjkdiEnecU7izDEPZY t8J77LbZuE2PEUtv3Uz1XR49LxdHj2ZO5Rja/E7oZrzxEwoElwfCbokCOLOTWG8i2udlZVjGT u4X7KOvOxbDziEImBiLJavhMiPVwk+PnezqMuf+nTV2kufWbGSciRnk7F4JLwaJbL/YIADYeC aPtjlKQ7LT8+dVRFieIFucsbEyRox6O/dLaa9hphsShGL5Hq39CupMKhSZovkWMJeMAtNFidE 3MdZ9DSPZZxt8qE5zK7tg5tPUxVIRAIVCz+/8Ir7vsCu3sKweJFKbqYMJoYR0t8MfU8vd1UIN JFVY3zan30fdfDwXZFhIFKq+1U2nIU+YImm2I75ur7mXPYUXhScKvHUm1Vkji7nFfdCm6pWEc IDtXzKL0MWX0oPz74+N2oL6o+BwP9wJRHZR0BUZ63CIdgwdCwcp4sbbRbKDuItD4N0eoJtlC1 V4heEZjRcJcBXdNqtBIyxzLb9rBG+iTIF64uVI07fFYQg1NWFC5AMSxnm5qCVN1OJO8WvVlwQ 8CVHwamy1PhEW+upqRvWjJJQW7JbqKocr+/fBx9JoWQeeXIzrYtjxWq2VJEbb+HUw9SBjOiB0 DyixDFpehuYsI0EtUJgD8rq0IMwXfyVq0yIDO/NEhch6nvqhYgSS+FlXfWRBwMqs3jF6XMbuk 21BXiA6f29zzWl/0BqHiSdMfGnmn/lVNoyVSDxJHV6Mtk6KMgwx5+4xbNzmwjIGRY0d0zUb2T wrKLO2XEjrPqQoao4g70aO3wfPn8qZEXNypOC3+vhnkCl36u/LaR8KfjSAuVSLgtVGop5w5ix 8Klzpw9YcORw3GqhYRo9D1TywFel2k4jI7XysSF5c= Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=212.227.15.4; envelope-from=lukasstraub2@web.de; helo=mout.web.de X-Spam_score_int: -9 X-Spam_score: -1.0 X-Spam_bar: - X-Spam_report: (-1.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SORBS_WEB=1.5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , "Daniel P. =?UTF-8?B?QmVycmFuZ8Op?= =?UTF-8?B?XA==?=" , qemu-block , Juan Quintela , Markus Armbruster , "Dr. David Alan Gilbert" , Max Reitz , =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau , Paolo Bonzini , =?UTF-8?B?TWFyYy1BbmRyw6k=?= Lureau Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-Zoho-Virus-Status: 1 X-ZohoMail-DKIM: fail (Header signature does not verify) --Sig_/ZouMWtKK7q31XoOZfLk=Ud+ Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Make qio_channel_tls_shutdown thread-safe by using atomics when accessing tioc->shutdown. Signed-off-by: Lukas Straub Acked-by: Stefan Hajnoczi Reviewed-by: Daniel P. Berrang=C3=A9 --- io/channel-tls.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/io/channel-tls.c b/io/channel-tls.c index 388f019977..2ae1b92fc0 100644 --- a/io/channel-tls.c +++ b/io/channel-tls.c @@ -23,6 +23,7 @@ #include "qemu/module.h" #include "io/channel-tls.h" #include "trace.h" +#include "qemu/atomic.h" static ssize_t qio_channel_tls_write_handler(const char *buf, @@ -277,7 +278,8 @@ static ssize_t qio_channel_tls_readv(QIOChannel *ioc, return QIO_CHANNEL_ERR_BLOCK; } } else if (errno =3D=3D ECONNABORTED && - (tioc->shutdown & QIO_CHANNEL_SHUTDOWN_READ)) { + (qatomic_load_acquire(&tioc->shutdown) & + QIO_CHANNEL_SHUTDOWN_READ)) { return 0; } @@ -361,7 +363,7 @@ static int qio_channel_tls_shutdown(QIOChannel *ioc, { QIOChannelTLS *tioc =3D QIO_CHANNEL_TLS(ioc); - tioc->shutdown |=3D how; + qatomic_or(&tioc->shutdown, how); return qio_channel_shutdown(tioc->master, how, errp); } -- 2.29.2 --Sig_/ZouMWtKK7q31XoOZfLk=Ud+ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg/qxWKDZuPtyYo+kNasLKJxdslgFAl/p8qoACgkQNasLKJxd slih0RAAiVvPtZzfGwM4vN9rQ9LxFQmfYTp5kmTEejWUBnhJk3uSk7DhpApXCPHY Jom3X5ZJMyXFJ5kDSbNWFiDT/HN4fKHiDnaJGFUt0kcFv6pmXdm42arZCordxYNR X5/F5IyePJmja8P3kKIYexg2n3DKKKmwxyEVyulWijqNZviL/W9btTHoMx9U3Oup +AhD18M9j37LYrAYd+u7IV+SPET9pFVkf1RLbJ/c2UdEsIr5lgAryvn2eA0iB7TB V7K4tdpp4imwSaDfmdxD6+nfLfomRePgln+R4Z8gBKV8l6e0uFh1ChaOHE/mGXCK Rb7LaPm+9b3ra2AvV3IEOznQgbVM14XR6vlduoaopgrM6KRE4r27UweD7JYrYdeD Jc5zFyxQu5OCv6mPb0h0oSuhKvm/UId2Cdvnf7cBLBjXeBY0tqym6P5JwfdsP1yG m6R33ugGrOj15I7FZzxHj32dzLNopz/9+tu16BwKFISXTRe9dYN/UP8vBcGaAQGz rKnR/e7mx2lmqdoWbW0uoKcXyRCxDpbCmzq5Jd/y7hV1QnyEPGDofDe6ayWtKINM 9hHRL2Wp5+e2rhUzzmTu+bnTf2XtWhAzOggygFY3Bb5JNghn2H3t5wTvqQEp8WvM KT+nkXcYAkFtqMNmB4swEe7TOSX7L4EZU7ja3HTSc39q/ta1d/0= =GA7G -----END PGP SIGNATURE----- --Sig_/ZouMWtKK7q31XoOZfLk=Ud+--