From nobody Sun Feb 8 16:19:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1496855420167444.6210354867212; Wed, 7 Jun 2017 10:10:20 -0700 (PDT) Received: from localhost ([::1]:45289 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIeTD-0003pT-Cd for importer@patchew.org; Wed, 07 Jun 2017 13:10:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34221) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIe1A-00020Z-Cz for qemu-devel@nongnu.org; Wed, 07 Jun 2017 12:41:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dIe17-0000rG-8f for qemu-devel@nongnu.org; Wed, 07 Jun 2017 12:41:12 -0400 Received: from forward14p.cmail.yandex.net ([87.250.241.142]:47377) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dIe17-0000q9-1C for qemu-devel@nongnu.org; Wed, 07 Jun 2017 12:41:09 -0400 Received: from mxback18j.mail.yandex.net (mxback18j.mail.yandex.net [IPv6:2a02:6b8:0:1619::94]) by forward14p.cmail.yandex.net (Yandex) with ESMTP id 01DBD2178F for ; Wed, 7 Jun 2017 19:41:05 +0300 (MSK) Received: from web26g.yandex.ru (web26g.yandex.ru [95.108.253.235]) by mxback18j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id 4k34opQNJT-f4UqDMfx; Wed, 07 Jun 2017 19:41:04 +0300 Received: by web26g.yandex.ru with HTTP; Wed, 07 Jun 2017 19:41:04 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1496853664; bh=TfGtqRQrsQCFllc74eDOBEptLas2IWC1zCLONA0/V8w=; h=From:To:Subject:Message-Id:Date; b=VxFVIaSRu7cQvPmLAJRmySt0ih9p0AlDX4OqOPnB8EkixFqxHbq3yOHVGkF70fBCl I4HFYynDykbKmbi+kr8gh/8BTmoZxWaAPcU2t+SWoc1yaIzCMoOu913cEysb2zDbbW VCeSxA6bNbMek4THhWBSLDYayTPZckEaE82bgazU= Authentication-Results: mxback18j.mail.yandex.net; dkim=pass header.i=@yandex.ru From: Aleksey Kuleshov To: "qemu-devel@nongnu.org" MIME-Version: 1.0 Message-Id: <4401421496853664@web26g.yandex.ru> X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Wed, 07 Jun 2017 19:41:04 +0300 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 87.250.241.142 X-Mailman-Approved-At: Wed, 07 Jun 2017 13:08:44 -0400 Subject: [Qemu-devel] [PATCH] m25p80: Fix WINBOND fast read command dummy bytes X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The original commit (3830c7a460b8252dc975f8115fdaed8c562d2d75) stated "Datasheet states that default dummy cycles is 8 so fix it." But since dummy cycles are handled in bytes it must be 1, not 8. Signed-off-by: Aleksey Kuleshov --- hw/block/m25p80.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 190573cefa..bf36159636 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m25p80.c @@ -793,7 +793,7 @@ static void decode_fast_read_cmd(Flash *s) switch (get_man(s)) { /* Dummy cycles - modeled with bytes writes instead of bits */ case MAN_WINBOND: - s->needed_bytes +=3D 8; + s->needed_bytes +=3D 1; break; case MAN_NUMONYX: s->needed_bytes +=3D extract32(s->volatile_cfg, 4, 4); --=20 2.11.0