From nobody Wed Nov 5 15:47:05 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 14968564400761015.8431723568023; Wed, 7 Jun 2017 10:27:20 -0700 (PDT) Received: from localhost ([::1]:45298 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIeUJ-0004ou-0p for importer@patchew.org; Wed, 07 Jun 2017 13:11:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60624) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIdwW-0005Wn-OY for qemu-devel@nongnu.org; Wed, 07 Jun 2017 12:36:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dIdwS-0006af-Ri for qemu-devel@nongnu.org; Wed, 07 Jun 2017 12:36:24 -0400 Received: from forward13o.cmail.yandex.net ([37.9.109.182]:41967) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dIdwS-0006Yk-G9 for qemu-devel@nongnu.org; Wed, 07 Jun 2017 12:36:20 -0400 Received: from mxback8o.mail.yandex.net (mxback8o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::22]) by forward13o.cmail.yandex.net (Yandex) with ESMTP id A3B652138F; Wed, 7 Jun 2017 19:36:15 +0300 (MSK) Received: from web26g.yandex.ru (web26g.yandex.ru [95.108.253.235]) by mxback8o.mail.yandex.net (nwsmtp/Yandex) with ESMTP id 45uo9imCvc-aEXq6Is9; Wed, 07 Jun 2017 19:36:15 +0300 Received: by web26g.yandex.ru with HTTP; Wed, 07 Jun 2017 19:36:14 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1496853375; bh=TfGtqRQrsQCFllc74eDOBEptLas2IWC1zCLONA0/V8w=; h=From:To:Cc:Subject:Message-Id:Date; b=c7uYjvJDAi2HA33ox31VrUPD3r0DmIn2K9wMMa7Lw2ubk6sTh35rTMm6ORebltckz W2Q5UXBmjq+/K75c9mDQ1g1AWEnCiH0ZxvIvJOwoKmLIJwH7rjekpIbfAQcAIuk/T/ PgJQc0RRMRABS0K5KgVwpI4ZCFWwOBCDJDUpkdUk= Authentication-Results: mxback8o.mail.yandex.net; dkim=pass header.i=@yandex.ru From: Aleksey Kuleshov To: qemu-devel@nongnu.org MIME-Version: 1.0 Message-Id: <4392061496853374@web26g.yandex.ru> X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Wed, 07 Jun 2017 19:36:14 +0300 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 37.9.109.182 X-Mailman-Approved-At: Wed, 07 Jun 2017 13:08:44 -0400 Subject: [Qemu-devel] [PATCH] m25p80: Fix WINBOND fast read command dummy bytes X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marcin Krzeminski Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" The original commit (3830c7a460b8252dc975f8115fdaed8c562d2d75) stated "Datasheet states that default dummy cycles is 8 so fix it." But since dummy cycles are handled in bytes it must be 1, not 8. Signed-off-by: Aleksey Kuleshov --- hw/block/m25p80.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 190573cefa..bf36159636 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m25p80.c @@ -793,7 +793,7 @@ static void decode_fast_read_cmd(Flash *s) switch (get_man(s)) { /* Dummy cycles - modeled with bytes writes instead of bits */ case MAN_WINBOND: - s->needed_bytes +=3D 8; + s->needed_bytes +=3D 1; break; case MAN_NUMONYX: s->needed_bytes +=3D extract32(s->volatile_cfg, 4, 4); --=20 2.11.0