From nobody Sun Nov 9 21:37:27 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1551896829687805.8080662913069; Wed, 6 Mar 2019 10:27:09 -0800 (PST) Received: from localhost ([127.0.0.1]:37412 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1bFx-0007Gb-8A for importer@patchew.org; Wed, 06 Mar 2019 13:27:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59757) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1b2J-0004pG-C3 for qemu-devel@nongnu.org; Wed, 06 Mar 2019 13:13:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1b2I-0006YU-0Y for qemu-devel@nongnu.org; Wed, 06 Mar 2019 13:12:58 -0500 Received: from fanzine.igalia.com ([91.117.99.155]:59311) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h1b2H-0005g4-K5; Wed, 06 Mar 2019 13:12:57 -0500 Received: from 87-92-21-153.bb.dnainternet.fi ([87.92.21.153] helo=perseus.local) by fanzine.igalia.com with esmtpsa (Cipher TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim) id 1h1b10-0004qt-Kg; Wed, 06 Mar 2019 19:11:38 +0100 Received: from berto by perseus.local with local (Exim 4.89) (envelope-from ) id 1h1b0m-0005OM-28; Wed, 06 Mar 2019 20:11:24 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=References:In-Reply-To:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=q8z3oYHnFRa8iSsLkXPgtwzmVq/P1j3Nd/Y2HnzMDxg=; b=UepWGjF7cgQtngIpREZWQDIigoNha5zOxQO6j1A9bXNTKsQsNAv5wDIrumoEwKp3wWi9xuEGHJ0o3YpDAz7NFtM6Ze488rEb1wzxRj803Ou1O+FPjS9DMzzi7wYeCcD7iNmxapS82XQOZic+2jq+1LhM/rXCbihrpu1BCtSwr576rJLEvcA7obvdSzUh/bRSJX7dYIE2m8LPfbgyBAUxLfCx9fgd9BdYFNL9QIuo/FvqzMz61tKTtbPRDwNEBKcssGXOz6UQDaWzyYVE0Cyh7+5cCszH8RlhKgHcwP8ewU2bGu/leoG/KWXh/KhhkUcID+0oy3Y+vpMRxRomMG5TNw==; From: Alberto Garcia To: qemu-devel@nongnu.org Date: Wed, 6 Mar 2019 20:11:02 +0200 Message-Id: <3f8b614194f300595b337b011a7be9427bbc533f.1551895814.git.berto@igalia.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 91.117.99.155 Subject: [Qemu-devel] [PATCH v2 02/13] block: Freeze the backing chain for the duration of the commit job X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Alberto Garcia , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Alberto Garcia --- block/commit.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/block/commit.c b/block/commit.c index 3b46ca7f97..ba60fef58a 100644 --- a/block/commit.c +++ b/block/commit.c @@ -39,6 +39,7 @@ typedef struct CommitBlockJob { BlockDriverState *base_bs; BlockdevOnError on_error; bool base_read_only; + bool chain_frozen; char *backing_file_str; } CommitBlockJob; =20 @@ -68,6 +69,9 @@ static int commit_prepare(Job *job) { CommitBlockJob *s =3D container_of(job, CommitBlockJob, common.job); =20 + bdrv_unfreeze_backing_chain(s->commit_top_bs, s->base_bs); + s->chain_frozen =3D false; + /* Remove base node parent that still uses BLK_PERM_WRITE/RESIZE before * the normal backing chain can be restored. */ blk_unref(s->base); @@ -84,6 +88,10 @@ static void commit_abort(Job *job) CommitBlockJob *s =3D container_of(job, CommitBlockJob, common.job); BlockDriverState *top_bs =3D blk_bs(s->top); =20 + if (s->chain_frozen) { + bdrv_unfreeze_backing_chain(s->commit_top_bs, s->base_bs); + } + /* Make sure commit_top_bs and top stay around until bdrv_replace_node= () */ bdrv_ref(top_bs); bdrv_ref(s->commit_top_bs); @@ -330,6 +338,11 @@ void commit_start(const char *job_id, BlockDriverState= *bs, } } =20 + if (bdrv_freeze_backing_chain(commit_top_bs, base, errp) < 0) { + goto fail; + } + s->chain_frozen =3D true; + ret =3D block_job_add_bdrv(&s->common, "base", base, 0, BLK_PERM_ALL, = errp); if (ret < 0) { goto fail; @@ -362,6 +375,9 @@ void commit_start(const char *job_id, BlockDriverState = *bs, return; =20 fail: + if (s->chain_frozen) { + bdrv_unfreeze_backing_chain(commit_top_bs, base); + } if (s->base) { blk_unref(s->base); } --=20 2.11.0