From nobody Tue Feb 10 12:58:55 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail header.i=@wdc.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=wdc.com Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1580519971779724.8295198182904; Fri, 31 Jan 2020 17:19:31 -0800 (PST) Received: from localhost ([::1]:34444 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixhRa-0000xj-Jp for importer@patchew.org; Fri, 31 Jan 2020 20:19:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57038) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixhI2-0003Ff-2A for qemu-devel@nongnu.org; Fri, 31 Jan 2020 20:09:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ixhI1-0006Yx-0N for qemu-devel@nongnu.org; Fri, 31 Jan 2020 20:09:37 -0500 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:17177) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ixhI0-0006JU-MS; Fri, 31 Jan 2020 20:09:36 -0500 Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 01 Feb 2020 09:09:02 +0800 Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2020 17:02:10 -0800 Received: from risc6-mainframe.sdcorp.global.sandisk.com (HELO risc6-mainframe.int.fusionio.com) ([10.196.158.235]) by uls-op-cesaip01.wdc.com with ESMTP; 31 Jan 2020 17:09:02 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1580519376; x=1612055376; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=HP2myi0QgHwUIpOeB7O6xthtCDeRYGykPyTEWPEw0LQ=; b=XxeFPRAhY2LDbWujIppa2bJk0JreIc2moBh3Mez4I2LDnmtfOhHHTYw1 SLZZGvu7nxfOvaGPKSZivPr+BwDjzRk1ZMcLJ8vwfkU/qOvDUkD3Qbvj2 3zxL0YozcvzJHN87Vd7hzJqwA1wc2VQ1kbgJA0AG3HhnpZWt1sQVLxor/ h9e7WdwIksb2c0b+kgVkP7PqsSK9m5tIHVq75ebTMVptKeqW0ccM00vb9 NJ9gTM+dU84L8HRRCmYQalak6OBNYV3xSMK+7XoGUBurrJwuebY1TjLlh YUMPYIEZCizTWJDWzd4zvQXdr/+rQfn0/m0Uc/DTE1IIm/9htGG8+nr28 A==; IronPort-SDR: lN30cGyZuVQ7mpcEV7Q1oPTWpDYim++jW3nP1LaITcWAS8ITa2n8sQH43kSZzCbfeCK/b83Tvj 04mFR7wIpctf3mJNc1XkShM195s5HkLBqDXkXTBw4jG99JeevUFo9K1+053G6dbruaiXq+Zpl+ FTEurI6c/3PH2K0MhG7wg8NCmUDUWF4djXnk6jh/66fNrjJgLCDN7u9JUJDDlwFs/SknsQcCMH 8JpWicXKvJTdZuKgKhQQlDNQhgIQZqT0++X2QBN7Ug5sXBCl8vFc9v4HHKzlmgTukfQWCBb0pJ 85E= X-IronPort-AV: E=Sophos;i="5.70,388,1574092800"; d="scan'208";a="128872472" IronPort-SDR: SH4U5irUBl8iSr+BCgBATsUlZVxknkH5gdQMhOuFqvU9FlsmkggWiii18Ud2QgT0C7HZ1z/nfB eP7wncLgfxX2yCpbTmELtywMimYx4o4rYg+4KMr+cSrEFmeJ7+RSG63Hrgf68G3TLWsma3CYYO P/lt0eU0rH/BNiuFFDfCG57s5W/5QHOAwKik1SZHvpNar9dF+nL46au7OduAMNHLbwU5an6lfH kMzSny3nbb2Xcx4t/rlWg0tPSrbpLWBEAYNzou9OyZjUjP209qPB5PQK3t7ngIGigpEDQSOA0v 4hmL1KyyJcR6HzE1hR4SM6TB IronPort-SDR: w1e74NtyrW72PcnIheDjkEHGG6wEHZr74YqLP9mKAC4WqllBLGmb9eHQiN8A74asKFd7Sb7DXG hDu0MPbIDK7bC6UayXrGuclRiHWtjY5U/dBtKSXaMBZFuYPXOqqcP+RTgLp7NsPtIEk05dKXsW IMDu7Qs0HVD520FcvQpoVOqV5OI1qb3O/YZW1OkK8Al6gvVXrfTkJwZIEiySIq95yJFlxLtx1I cTqjEpLVaIYXzCML88X3BB/rl6qXwamxkD3hMRaTyXnRFx0d7x23ksGZ6yGC7/c54YT7niL2DC ycg= WDCIronportException: Internal From: Alistair Francis To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org Subject: [PATCH v2 19/35] target/ricsv: Flush the TLB on virtulisation mode changes Date: Fri, 31 Jan 2020 17:02:25 -0800 Message-Id: <3ed3214f75740bfa9d101c7b67d8f5ae017e5d16.1580518859.git.alistair.francis@wdc.com> X-Mailer: git-send-email 2.25.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 216.71.154.42 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair.francis@wdc.com, palmer@dabbelt.com, alistair23@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" To ensure our TLB isn't out-of-date we flush it on all virt mode changes. Unlike priv mode this isn't saved in the mmu_idx as all guests share V=3D1. The easiest option is just to flush on all changes. Signed-off-by: Alistair Francis Reviewed-by: Palmer Dabbelt --- target/riscv/cpu_helper.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c index 3984a1f1ac..98017df33b 100644 --- a/target/riscv/cpu_helper.c +++ b/target/riscv/cpu_helper.c @@ -181,6 +181,11 @@ void riscv_cpu_set_virt_enabled(CPURISCVState *env, bo= ol enable) return; } =20 + /* Flush the TLB on all virt mode changes. */ + if (get_field(env->virt, VIRT_ONOFF) !=3D enable) { + tlb_flush(env_cpu(env)); + } + env->virt =3D set_field(env->virt, VIRT_ONOFF, enable); } =20 --=20 2.25.0