From nobody Tue Sep 16 05:33:16 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1756727815; cv=none; d=zohomail.com; s=zohoarc; b=BV1ni/5HxxRg5bF7C6cqi0/haruxIs+MuB3XMdIU/vZhBQ27UwSjjFP+3Gxbh9hZnu3B0RGQ1GyHDM8Ha/n6PhdLM2HlFjUhAXC9cmbgVVOVlubjD99XtzsB808Ki8U95Skl2yiYjtH7ELVeoiTCd8x3iODwNH+UJnT3Qk+9QGg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1756727815; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=akIEERgXs7+yZRZkR9zbLlIdfnSFTSvmgC+mcTcKDAw=; b=aGw7gtVnIeijD6bIAoYJ9vJoWLs+ysw45hbA+R2F3w6hFe4Ro+YjvjaKybdd0wO3ri23vyQkWbPlWKyw2TU9NIMir8AQF1sfkXStp04NCNTR+4m3UsqBxHFiw+hPnEp5HqRdOvzeU6oKcl+yZFc+nAQ7qd66unWe0EPq52sRLRU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1756727815432535.8841442764384; Mon, 1 Sep 2025 04:56:55 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ut31x-0004Jq-Nn; Mon, 01 Sep 2025 07:49:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ut30y-00023p-Hz; Mon, 01 Sep 2025 07:48:02 -0400 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ut30l-0001jF-5Q; Mon, 01 Sep 2025 07:47:57 -0400 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-2445805aa2eso43018895ad.1; Mon, 01 Sep 2025 04:47:41 -0700 (PDT) Received: from ktock.. ([240d:1a:3b6:8b00:750a:cb0b:f0f9:68f4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-249065a8036sm103038775ad.129.2025.09.01.04.47.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Sep 2025 04:47:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756727260; x=1757332060; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=akIEERgXs7+yZRZkR9zbLlIdfnSFTSvmgC+mcTcKDAw=; b=WuziJcNguo2eyLJhhzdkZHu0lXdb4H6OBiryDAXTgrYvr5ahpeh0EgY9PZTGfU+6QU H8R8FhaKitGpbaocnmYPwVl2K+0w000rw+oXrorTDLv6/ZNhgPsDxLq/4maVdBqMYuLE Y/nwR9LSsfbFijRzPxBL5od+t3q5Uwmh88I+5q4RpmyepUh7Il1wauH1IjfnnJRy2SA+ iDMf9rJ4iow5T4qvmmhI3h/FcE6AMdb3ZRoEpZuuCOo5EqvU7d9WoMQeljpqKqGoHZxw 1EjX2Z/m9tQ6uh+X+chw2DPpQS6gWiFfV0+c9cB8yF/yGhkeKhF5cpowKB4o5V2C8M3B tFDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756727260; x=1757332060; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=akIEERgXs7+yZRZkR9zbLlIdfnSFTSvmgC+mcTcKDAw=; b=h0xC//ekLpS9WKUigfvFp4quxFswlqs67oOzvRXgI7VhVhiS1oV3Ft0r8ZbbeA2JEU UN6tXFI0Ag3DQZM6VTLawPq90SPLcT0lplwiso7xMu8UySNP4EiJKJ5ewdAIRudUpCDS Z6VE41wwbgzHqXqvyoQ7cYF/5mpMsO5m2Qv6KKhwtF9KR1iosHzp4XlkKd8i1x7q1kla Mqqq/vmVqv06r2AfCgB7JDJR6FeQgYu9cnkgLr6KVTQ3PLkhKXvId8oZrbXKYjZJ33NN 3OQlsKE3sie2x16QycaFbyC6Di6hYGhLllx403QsxNLQ/aRCjNQTYt0eIx9k9A75xvX6 8tyg== X-Forwarded-Encrypted: i=1; AJvYcCU4oN3OYVUQChHXbviClvG+39XrJnVnzeKAcfXofTaxEvMB3EHnLiEMeuLZeAvjEqsWjPixwrLCmg==@nongnu.org, AJvYcCX51YMnr2dhTbJJgWzQjf2mTiEJsehBFa7Acya+bjKV6nEFvNvsEluMVSlI2YOpBAy8YH4rt3imQudFvg==@nongnu.org X-Gm-Message-State: AOJu0YyStQhLblZNldPKZFoEg1kdpoQKSEzXi3281H9xYCXrj72iaX18 3bRjgQFJbPPRlAgNWeGPHXOMXAgYoxVzsHz9TTaLo6UxFCjAFunqBQHC6VpFwg== X-Gm-Gg: ASbGnct3Q0MX6FolOn0jNEmbR0MR8ozloqqisR4Kq8OuVk9TzGTcjlwzyXDHbqzFhsG IjXENtjasRS+wPOl+YsA7iOwzxllQdh76s+KOhARdHWIa+VtpM0R85niAng0facV0bEskuCi1gh 0iqgrpn3YkPAeUdcSeZDMKXvj0VyK+dck1ICpbJTGobg8fAJ3zbFkn3kGbxjL6tKZdr9awtc/Or lxSqFpO9ylq9Mh7kQDG28FKAXRbBTUWhV5QTUVZRMEJaTv0RcBFUgURt+2AN0iaFEPPeau2m/NX nveJiaGTy7eE5v688txLxBXY3EDZcQDPSduBQYwRFldYdiU7VYL0/CY9cqfsebYOAc8gJAo/UQg UkWUQIFCKutKtZYXm+vH/S3ekE4nkwRoQRMIY2sp0u9M= X-Google-Smtp-Source: AGHT+IGoZH78ykrPnBnJb7ak2DPU5Ku0CRJtbTb5vWJ5yLQGCn6ko/d1/XgsT9gurpBWIb+vEU6nVA== X-Received: by 2002:a17:902:f78f:b0:249:1156:31f9 with SMTP id d9443c01a7336-249448e52c0mr95198285ad.21.1756727259789; Mon, 01 Sep 2025 04:47:39 -0700 (PDT) From: Kohei Tokunaga To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth , Paolo Bonzini , Richard Henderson , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , WANG Xuerui , Aurelien Jarno , Huacai Chen , Jiaxun Yang , Aleksandar Rikalo , Palmer Dabbelt , Alistair Francis , Stefan Weil , qemu-arm@nongnu.org, qemu-riscv@nongnu.org, Stefan Hajnoczi , Pierrick Bouvier , ktokunaga.mail@gmail.com Subject: [PATCH v3 24/35] tcg/wasm: Add mb instruction Date: Mon, 1 Sep 2025 20:44:26 +0900 Message-ID: <3db8ec74078663cbaabcc680e53f1d588f5f5970.1756724464.git.ktokunaga.mail@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::634; envelope-from=ktokunaga.mail@gmail.com; helo=mail-pl1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1756727817017124100 Content-Type: text/plain; charset="utf-8" This commit generates the mb operation. In Wasm, it uses the atomic.fence instruction as the fence operator [1]. TCI instruction is also generated in the same way as the original TCI backend using smp_mb(). [1] https://webassembly.github.io/threads/core/syntax/instructions.html#ato= mic-memory-instructions Signed-off-by: Kohei Tokunaga --- tcg/wasm.c | 4 ++++ tcg/wasm/tcg-target.c.inc | 19 +++++++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/tcg/wasm.c b/tcg/wasm.c index 793c1807c2..1cc2e45e77 100644 --- a/tcg/wasm.c +++ b/tcg/wasm.c @@ -566,6 +566,10 @@ static uintptr_t tcg_qemu_tb_exec_tci(CPUArchState *en= v, const void *v_tb_ptr) taddr =3D regs[r1]; tci_qemu_st(env, taddr, regs[r0], oi, tb_ptr); break; + case INDEX_op_mb: + /* Ensure ordering for all kinds */ + smp_mb(); + break; default: g_assert_not_reached(); } diff --git a/tcg/wasm/tcg-target.c.inc b/tcg/wasm/tcg-target.c.inc index e1ee2f6485..1d639561db 100644 --- a/tcg/wasm/tcg-target.c.inc +++ b/tcg/wasm/tcg-target.c.inc @@ -1116,6 +1116,11 @@ static void tcg_out_op_r(TCGContext *s, TCGOpcode op= , TCGReg r0) tcg_out32(s, insn); } =20 +static void tcg_out_op_v(TCGContext *s, TCGOpcode op) +{ + tcg_out32(s, (uint8_t)op); +} + static void tcg_out_op_ri(TCGContext *s, TCGOpcode op, TCGReg r0, int32_t = i1) { tcg_insn_unit_tci insn =3D 0; @@ -1931,6 +1936,20 @@ static bool tcg_out_qemu_st_slow_path(TCGContext *s,= TCGLabelQemuLdst *l) g_assert_not_reached(); } =20 +static void tcg_out_mb(TCGContext *s, unsigned a0) +{ + tcg_out_op_v(s, INDEX_op_mb); + + /* + * Wasm's threading proposal provides atomic.fence instruction as the = fence + * operator. + * https://webassembly.github.io/threads/core/syntax/instructions.html= #atomic-memory-instructions + */ + tcg_wasm_out8(s, 0xfe); + tcg_wasm_out8(s, 0x03); + tcg_wasm_out8(s, 0x00); +} + static void tcg_out_tb_start(TCGContext *s) { init_sub_buf(); --=20 2.43.0