From nobody Mon Feb 9 03:30:22 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1543591616206659.0270589751516; Fri, 30 Nov 2018 07:26:56 -0800 (PST) Received: from localhost ([::1]:33295 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSkgx-0005Es-3G for importer@patchew.org; Fri, 30 Nov 2018 10:26:55 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51504) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSkZa-0007S1-BY for qemu-devel@nongnu.org; Fri, 30 Nov 2018 10:19:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gSkZW-0006WF-CI for qemu-devel@nongnu.org; Fri, 30 Nov 2018 10:19:18 -0500 Received: from fanzine.igalia.com ([91.117.99.155]:53240) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gSkZU-00062T-52; Fri, 30 Nov 2018 10:19:14 -0500 Received: from [194.100.51.2] (helo=perseus.local) by fanzine.igalia.com with esmtpsa (Cipher TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim) id 1gSkYp-0007XB-5r; Fri, 30 Nov 2018 16:18:31 +0100 Received: from berto by perseus.local with local (Exim 4.89) (envelope-from ) id 1gSkYZ-0003eD-E2; Fri, 30 Nov 2018 17:18:15 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=References:In-Reply-To:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=+/4khAbQMeVy1KVoG0qdWT2tHAMnDkEkpa2xD6AjZPA=; b=g+61V9WMJp0caVBWAJaTxDy16ShEl1ppzHIb0O29+f9ga0ofqchUcMtaPu9AJfJj8BzckwXtt7X6yJ98yCyTfgiqH8GIvwSuBXuhW84L+Wb+zNp6Pou5vMVHmh/6CLKl0f+GYroLliEnAxbrlvHPb33xULn8B/Rjr8Y5b5udCpNxGCHWSbn6EJYyXSG6J6tlJTSkr9ntNGvHPCbQqF8eHaC1qyksH9kybKnuroFvtGCOavgPp6VCYdaBwrvn3+EGLcK6gl+Cm+zsAU4cCUHBl0HW2qkpu1BB9wOCOfB110y7RhtP6DYbDDqxVlinF49kXmiRLTVIAHFOIJrPd4VQhA==; From: Alberto Garcia To: qemu-devel@nongnu.org Date: Fri, 30 Nov 2018 17:17:40 +0200 Message-Id: <3a01a1e6b2d21077f92cb880c9f6600d278b4aed.1543590618.git.berto@igalia.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 91.117.99.155 Subject: [Qemu-devel] [RFC PATCH v2 02/12] block: Freeze the backing chain for the duration of the commit job X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Alberto Garcia , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Alberto Garcia --- block/commit.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/block/commit.c b/block/commit.c index 53148e610b..8824d135e0 100644 --- a/block/commit.c +++ b/block/commit.c @@ -73,6 +73,8 @@ static int commit_prepare(Job *job) { CommitBlockJob *s =3D container_of(job, CommitBlockJob, common.job); =20 + bdrv_unfreeze_backing_chain(s->commit_top_bs, s->base_bs); + /* Remove base node parent that still uses BLK_PERM_WRITE/RESIZE before * the normal backing chain can be restored. */ blk_unref(s->base); @@ -89,6 +91,8 @@ static void commit_abort(Job *job) CommitBlockJob *s =3D container_of(job, CommitBlockJob, common.job); BlockDriverState *top_bs =3D blk_bs(s->top); =20 + bdrv_unfreeze_backing_chain(s->commit_top_bs, s->base_bs); + /* Make sure commit_top_bs and top stay around until bdrv_replace_node= () */ bdrv_ref(top_bs); bdrv_ref(s->commit_top_bs); @@ -336,6 +340,10 @@ void commit_start(const char *job_id, BlockDriverState= *bs, } } =20 + if (bdrv_freeze_backing_chain(commit_top_bs, base, errp) < 0) { + goto fail; + } + ret =3D block_job_add_bdrv(&s->common, "base", base, 0, BLK_PERM_ALL, = errp); if (ret < 0) { goto fail; --=20 2.11.0