From nobody Sun Nov 24 19:36:05 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1721053183; cv=none; d=zohomail.com; s=zohoarc; b=kF2ZohM6Ym1wbxZIEDLbvzgQQSj1tVHvqqOECws0Fl4mHmotpIY5c9VZWdKjr6QFbWs0lnA9+Rn6fygg4fRbyYW1wqtd6QpOdioT4jLMrrBiokU6k0NIpJzqPhgGfZq/t3qEIxNXc8QcF+Z0jE+ZCooCiWmA/x4A79iJuiq2ooQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1721053183; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=X3XNF4/2RZbsMSlcuM1O06Na8UUNQlM0ICBTkZgeRoU=; b=igy82rV9yaAb9qGszcKQT/FcIq5M1Rl+xXY7gD6ODDThsQLS/SkNyADxJxBx/jrTkt9NUr9y34AHt7LO8WOKBEzBIQp5+/izEPl6F79h63D8d0NOgBEBvJO1CE5vyYyUS5051pFKgyeRmmL45+sAhxEttnf+4DhCefcomWMkoMc= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1721053183151877.8212243103275; Mon, 15 Jul 2024 07:19:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sTMXw-0005mv-I7; Mon, 15 Jul 2024 10:19:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sTMXu-0005mR-TW for qemu-devel@nongnu.org; Mon, 15 Jul 2024 10:19:19 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sTMXs-0000Tr-9Z for qemu-devel@nongnu.org; Mon, 15 Jul 2024 10:19:18 -0400 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4WN4635TZfz6K73h; Mon, 15 Jul 2024 22:17:31 +0800 (CST) Received: from lhrpeml100002.china.huawei.com (unknown [7.191.160.241]) by mail.maildlp.com (Postfix) with ESMTPS id 421691400CB; Mon, 15 Jul 2024 22:19:13 +0800 (CST) Received: from lhrpeml500001.china.huawei.com (7.191.163.213) by lhrpeml100002.china.huawei.com (7.191.160.241) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 15 Jul 2024 15:19:12 +0100 Received: from lhrpeml500001.china.huawei.com ([7.191.163.213]) by lhrpeml500001.china.huawei.com ([7.191.163.213]) with mapi id 15.01.2507.039; Mon, 15 Jul 2024 15:19:12 +0100 To: Salil Mehta , Igor Mammedov CC: "qemu-devel@nongnu.org" , "maz@kernel.org" , "jean-philippe@linaro.org" , Jonathan Cameron , "lpieralisi@kernel.org" , "peter.maydell@linaro.org" , "richard.henderson@linaro.org" , "andrew.jones@linux.dev" , "david@redhat.com" , "philmd@linaro.org" , "eric.auger@redhat.com" , "oliver.upton@linux.dev" , "pbonzini@redhat.com" , "mst@redhat.com" , "will@kernel.org" , "gshan@redhat.com" , "rafael@kernel.org" , "alex.bennee@linaro.org" , "linux@armlinux.org.uk" , "darren@os.amperecomputing.com" , "ilkka@os.amperecomputing.com" , "vishnu@os.amperecomputing.com" , "karl.heubaum@oracle.com" , "miguel.luis@oracle.com" , "salil.mehta@opnsrc.net" , zhukeqian , "wangxiongfeng (C)" , "wangyanan (Y)" , "jiakernel2@gmail.com" , "maobibo@loongson.cn" , "lixianglai@loongson.cn" , "npiggin@gmail.com" , "harshpb@linux.ibm.com" , Linuxarm Subject: RE: [PATCH V15 0/7] Add architecture agnostic code to support vCPU Hotplug Thread-Topic: [PATCH V15 0/7] Add architecture agnostic code to support vCPU Hotplug Thread-Index: AQHa1VIYzbBqk8ub30G0ZXbYzNwFGLH3waYAgAASi1CAAAR3IA== Date: Mon, 15 Jul 2024 14:19:12 +0000 Message-ID: <3848723ea2584b9b813c3d76e1e6dd59@huawei.com> References: <20240713182516.1457-1-salil.mehta@huawei.com> <20240715155436.577d34c5@imammedo.users.ipa.redhat.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.126.170.92] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=185.176.79.56; envelope-from=salil.mehta@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Salil Mehta From: Salil Mehta via Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1721053183975116600 > From: qemu-arm-bounces+salil.mehta=3Dhuawei.com@nongnu.org arm-bounces+salil.mehta=3Dhuawei.com@nongnu.org> On Behalf Of Salil > Mehta via > Sent: Monday, July 15, 2024 3:14 PM > To: Igor Mammedov > =20 > Hi Igor, > =20 > > From: Igor Mammedov > > Sent: Monday, July 15, 2024 2:55 PM > > To: Salil Mehta > > > > On Sat, 13 Jul 2024 19:25:09 +0100 > > Salil Mehta wrote: > > > > > [Note: References are present at the last after the revision > > history] > > Virtual CPU hotplug support is being added across > > various architectures [1][3]. > > > This series adds various code bits common across all architectures: > > > > > > 1. vCPU creation and Parking code refactor [Patch 1] 2. Update ACPI > > > GED framework to support vCPU Hotplug [Patch 2,3] 3. ACPI CPUs AML > > > code change [Patch 4,5] 4. Helper functions to support unrealization > > > of CPU objects [Patch 6,7] > > > > with patch 1 and 3 fixed should be good to go. > > > > Salil, > > Can you remind me what happened to migration part of this? > > Ideally it should be a part of of this series as it should be common > > for everything that uses GED and should be a conditional part of > > GED's VMSTATE. > > > > If this series is just a common base and no actual hotplug on top of > > it is merged in this release (provided patch 13 is fixed), I'm fine > > with migration bits being a separate series on top. > > > > However if some machine would be introducing cpu hotplug in the same > > release, then the migration part should be merged before it or be a > > part that cpu hotplug series. > =20 > We have tested Live/Pseudo Migration and it seem to work with the > changes part of the architecture specific patch-set. > =20 > Ampere: https://lore.kernel.org/all/e17e28ac-28c7-496f-b212- > 2c9b552dbf63@amperemail.onmicrosoft.com/ > Oracle: https://lore.kernel.org/all/46D74D30-EE54-4AD2-8F0E- > BA5627FAA63E@oracle.com/ > =20 > =20 > For ARM, please check below patch part of RFC V3 for changes related to > migration: > https://lore.kernel.org/qemu-devel/20240613233639.202896-15- > salil.mehta@huawei.com/ Do you wish to move below change into this path-set and make it common to all instead? diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c index 63226b0040..e92ce07955 100644 --- a/hw/acpi/generic_event_device.c +++ b/hw/acpi/generic_event_device.c @@ -333,6 +333,16 @@ static const VMStateDescription vmstate_memhp_state = =3D { } }; =20 +static const VMStateDescription vmstate_cpuhp_state =3D { + .name =3D "acpi-ged/cpuhp", + .version_id =3D 1, + .minimum_version_id =3D 1, + .fields =3D (VMStateField[]) { + VMSTATE_CPU_HOTPLUG(cpuhp_state, AcpiGedState), + VMSTATE_END_OF_LIST() + } +}; + static const VMStateDescription vmstate_ged_state =3D { .name =3D "acpi-ged-state", .version_id =3D 1, @@ -381,6 +391,7 @@ static const VMStateDescription vmstate_acpi_ged =3D { }, .subsections =3D (const VMStateDescription * const []) { &vmstate_memhp_state, + &vmstate_cpuhp_state, &vmstate_ghes_state, NULL } Maybe I can add a separate patch for this in the end? Please confirm. Thanks Salil.