From nobody Sun Apr 13 07:21:35 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7ACF14036E for ; Sat, 7 Dec 2024 08:56:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733561805; cv=none; b=OpN63L+v/O7wjxq61/YfXcv11AvgwwNbqg7OqZVL2lwgNd2UrpGSQoZrCiSsVBvwUN7kvxcoodNeREZWUN3tu2hQARX96vRlE7dfe9wis0JUQUbuCKlQlcRH4KX8h9XbB9UJCbfw3UQY+otp7zYHUU0GxArq4goK7K8jANyJLWY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733561805; c=relaxed/simple; bh=mtr3SAhcJul8SH7gyq7dWJqCajR+YSKyCDlfSYBqOeM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aRCv+q8l3xOEceJgMAx+S/5D8fxdVl43tN7H9WSIngTdCRV6adhANd//VtscUOZMyFQKS8byePp/RGsEg6dibXHZkm1gDASRhUwNX9TgsTFM2RdNYAuKsMJ2IA8sQKjfjtF/W0M4Ah94GumZdjgN/lXsD1lTaKVOWrb9OeWIW9U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hkEbqYwQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hkEbqYwQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21287C4CEEC; Sat, 7 Dec 2024 08:56:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733561805; bh=mtr3SAhcJul8SH7gyq7dWJqCajR+YSKyCDlfSYBqOeM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hkEbqYwQTY5uiu/lKTsURRYpI6v7GvZ6iFhzckZy7RZick0q/rDvJxR3bSigMr5cR RTD0U/pNBmoYoz8iPRayPb8t62jd9KI3dYcFsEhZN0jzPpDWr76LE0F7I2aWDrY8JU CZUqztGaZ3eKASBH5rXvmNgK2JjgBapdgCwm0ufZqvG1b+qYAKVq17GQH4YFtaG/iS 46j7CqGzLXjIyGKJ+eaqHZ3+1hCZf/Ho2SFTGDTu+uBWYwYA1ApSp8HsxOgoNf0lR6 arxajX6b7xz+ij71E9ba4KvvZnkNq7BIee+D6s4eatk8jcUlZ4mfNesDN9bOfgw5c9 tpLCVZC7IubmA== Received: from mchehab by mail.kernel.org with local (Exim 4.98) (envelope-from ) id 1tJqcF-00000005j4s-0Ihi; Sat, 07 Dec 2024 09:56:43 +0100 From: Mauro Carvalho Chehab To: "Michael S . Tsirkin" Cc: Jonathan Cameron , Shiju Jose , Mauro Carvalho Chehab , Ani Sinha , Dongjiu Geng , Igor Mammedov , linux-kernel@vger.kernel.org, qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH v6 06/16] acpi/ghes: Remove a duplicated out of bounds check Date: Sat, 7 Dec 2024 09:54:12 +0100 Message-ID: <3447853c8f174a8f2a1a0e8c029c73c403a85ba0.1733561462.git.mchehab+huawei@kernel.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: Mauro Carvalho Chehab Content-Type: text/plain; charset="utf-8" acpi_ghes_record_errors() has an assert() at the beginning to ensure that source_id will be lower than ACPI_GHES_ERROR_SOURCE_COUNT. Remove a duplicated check. Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Igor Mammedov Reviewed-by: Jonathan Cameron --- hw/acpi/ghes.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c index 29cd7e4d8171..5f67322bf0f2 100644 --- a/hw/acpi/ghes.c +++ b/hw/acpi/ghes.c @@ -404,9 +404,7 @@ int acpi_ghes_record_errors(uint8_t source_id, uint64_t= physical_address) return -1; } =20 - if (source_id < ACPI_GHES_ERROR_SOURCE_COUNT) { - start_addr +=3D source_id * sizeof(uint64_t); - } + start_addr +=3D source_id * sizeof(uint64_t); =20 cpu_physical_memory_read(start_addr, &error_block_addr, sizeof(error_block_addr)); --=20 2.47.1