From nobody Thu May 16 00:04:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1574146813; cv=none; d=zoho.com; s=zohoarc; b=I55CAYjQEflZlqvrFILnkxEgArnp54Hafx/v0ryqV6tvm0KUhZftwCU3HT9ugnom5tutwoZ53MpDoyMwwu+4pI8XG+rYh10HnbNgzsj5hIftJVzsi5hAfnvtGTKRxMmmCEA1lgBMdpDPXsYougrzJ+FVSScyMNKGOgf8f6/I9ZA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1574146813; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=mYldD00yIEz7t7G84CeJlJNi3FCJZU+pC6JI/oX1Rck=; b=nj/UEH9tfPyi13El3VIn7xphkYCYTEiruVKZsqiiUFVTlWlK6dpzEBcpVKvKq55RVJ0BBP6lrLWXlaHQDNO/Q7X5nwl61ymkKqIo/1iFsDVsjwObUfXWIaQ0miucIR2D1mlkQYRKpmTDUh7ZSiAanLz5ySg/jDkkyrXb3BhsUxo= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15741468134300.2078051984154854; Mon, 18 Nov 2019 23:00:13 -0800 (PST) Received: from localhost ([::1]:42132 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWxUa-0007Bt-Ui for importer@patchew.org; Tue, 19 Nov 2019 02:00:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38512) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWxTa-0006Zl-Rk for qemu-devel@nongnu.org; Tue, 19 Nov 2019 01:59:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iWxTZ-0000kX-QX for qemu-devel@nongnu.org; Tue, 19 Nov 2019 01:59:02 -0500 Received: from mailout10.t-online.de ([194.25.134.21]:57538) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iWxTZ-0000jX-G5 for qemu-devel@nongnu.org; Tue, 19 Nov 2019 01:59:01 -0500 Received: from fwd22.aul.t-online.de (fwd22.aul.t-online.de [172.20.26.127]) by mailout10.t-online.de (Postfix) with SMTP id 14F5A41D7029; Tue, 19 Nov 2019 07:58:58 +0100 (CET) Received: from [192.168.211.101] (VOcBk-ZEYhrR15P8gXfBXy982L1bOT5cKE+R-5oHwekIa1qieEwkYqn+c2oJHbWQM1@[46.86.57.145]) by fwd22.t-online.de with (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384 encrypted) esmtp id 1iWxTO-10MFdY0; Tue, 19 Nov 2019 07:58:50 +0100 To: Gerd Hoffmann , qemu-devel@nongnu.org From: =?UTF-8?Q?Volker_R=c3=bcmelin?= Subject: [PATCH] audio: fix audio recording Message-ID: <2fc947cf-7b42-de68-3f11-cbcf1c096be9@t-online.de> Date: Tue, 19 Nov 2019 07:58:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 Content-Language: en-US X-ID: VOcBk-ZEYhrR15P8gXfBXy982L1bOT5cKE+R-5oHwekIa1qieEwkYqn+c2oJHbWQM1 X-TOI-MSGID: e5905e3c-b204-49f7-83f6-affbfef475fe Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 194.25.134.21 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" With current code audio recording with all audio backends except PulseAudio and DirectSound is broken. The generic audio recording buffer management forgot to update the current read position after a read. Fixes: ff095e5231 "audio: api for mixeng code free backends" Signed-off-by: Volker R=C3=BCmelin Reviewed-by: Zolt=C3=A1n K=C5=91v=C3=A1g=C3=B3 --- audio/audio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/audio/audio.c b/audio/audio.c index 7fc3aa9d16..56fae55047 100644 --- a/audio/audio.c +++ b/audio/audio.c @@ -1390,6 +1390,7 @@ void *audio_generic_get_buffer_in(HWVoiceIn *hw, size= _t *size) size_t read =3D hw->pcm_ops->read(hw, hw->buf_emul + hw->pos_emul, read_len); hw->pending_emul +=3D read; + hw->pos_emul =3D (hw->pos_emul + read) % hw->size_emul; if (read < read_len) { break; } --=20 2.16.4