From nobody Mon Feb 9 16:19:09 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1565559275; cv=none; d=zoho.com; s=zohoarc; b=NQjkiz10qb+kZMfPTvsFVJP1ZYHUCH2cEf2lmZophNLL8gg43CcaHxbI3uij4fU8KHUyn/obJdSI5+AOLrv49y4RyJOQtW42uNlks/hIXlrWUaHi1x4b4D+OQTPDpVHS/GPHXP7FY9So93rxQvfnpY1LRzhqQ23I4eBVQK8QJMI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565559275; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=7q++hoQzXm3nhS2SIxZuShRe1Ev7mv/8X5OsvQ56vfw=; b=XUOkOVEvhM8/pOtzRygx7Rh6EBYKXYm3/MmVmxQ69F8qm66P1/hlQWamr9fvCxVolYB1cjNEjT7+BQZHfc5+yIYHXBRfPUApHGSRzrxlwNwE0WKZCZMmt5Ygf/oOYVBS10sHzQ4jBxgcB5weWfiFTY6MMak6kBF8nsp4NUbTc2g= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (209.51.188.17 [209.51.188.17]) by mx.zohomail.com with SMTPS id 15655592753083.094584807916249; Sun, 11 Aug 2019 14:34:35 -0700 (PDT) Received: from localhost ([::1]:41852 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hwvTq-0003bJ-6J for importer@patchew.org; Sun, 11 Aug 2019 17:34:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58189) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hwvSy-00020E-VY for qemu-devel@nongnu.org; Sun, 11 Aug 2019 17:33:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hwvSx-00046f-UK for qemu-devel@nongnu.org; Sun, 11 Aug 2019 17:33:28 -0400 Received: from zero.eik.bme.hu ([2001:738:2001:2001::2001]:55463) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hwvSx-0003yP-OC for qemu-devel@nongnu.org; Sun, 11 Aug 2019 17:33:27 -0400 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id 6B6A974C89D; Sun, 11 Aug 2019 23:33:12 +0200 (CEST) Received: by zero.eik.bme.hu (Postfix, from userid 432) id DEFC9749FDB; Sun, 11 Aug 2019 23:33:11 +0200 (CEST) Message-Id: <292e70a92b7fbfd9a4120d433dbdcfda4e5f6c3c.1565558093.git.balaton@eik.bme.hu> In-Reply-To: References: From: BALATON Zoltan Date: Sun, 11 Aug 2019 23:14:53 +0200 MIME-Version: 1.0 To: qemu-devel@nongnu.org Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2001:738:2001:2001::2001 Subject: [Qemu-devel] [PATCH 3/7] ati-vga: Fix GPIO_MONID register write X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Also update bitbang_i2c state when output bits are changed while enable bits are set. This fixes EDID access by the ATI FCode ROM. Signed-off-by: BALATON Zoltan --- hw/display/ati.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/display/ati.c b/hw/display/ati.c index c8fc62505b..699f38223b 100644 --- a/hw/display/ati.c +++ b/hw/display/ati.c @@ -564,12 +564,15 @@ static void ati_mm_write(void *opaque, hwaddr addr, addr - GPIO_MONID, data, size); /* * Rage128p accesses DDC used to get EDID via these bits. - * Only touch i2c when write overlaps 3rd byte because some - * drivers access this reg via multiple partial writes and - * without this spurious bits would be sent. + * Because some drivers access this via multiple byte writes + * we have to be careful when we send bits to avoid spurious + * changes in bitbang_i2c state. So only do it when mask is set + * and either the enable bits are changed or output bits chang= ed + * while enabled. */ if ((s->regs.gpio_monid & BIT(25)) && - addr <=3D GPIO_MONID + 2 && addr + size > GPIO_MONID + 2) { + ((addr <=3D GPIO_MONID + 2 && addr + size > GPIO_MONID + 2= ) || + (addr =3D=3D GPIO_MONID && (s->regs.gpio_monid & 0x60000)= ))) { s->regs.gpio_monid =3D ati_i2c(&s->bbi2c, s->regs.gpio_mon= id, 1); } } --=20 2.13.7