From nobody Wed Nov 12 06:51:59 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1568735560; cv=none; d=zoho.com; s=zohoarc; b=I3wVnK36mjkpLR+kVZEAvWfXUEcfj37Sob+nEmSP7KKZ/zWwC160GM+b1Q3Rz1v0dP/jU8Y6aUB7aRsFl1cG9mAAIKDhTwHrGNCYDT2micvzODUPF3kzItzPPrvcrgoanADEWfcKYg2pARjt/e4i+t2bMUujkCnGwQ73AuEPx24= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568735560; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=rOm6vjtOmdeglWX2rn8YPbw9eo0FPb8PfL0cTnRtwP8=; b=PW7/03TSdwfrARyvpjQX30ft9ISX8YmJGLMj/PDkwi44dJL/BUFUB+R9UYrEPq6YFkid7kmtyliYnwy6TqkNxZ04cSxZrQwx96ipfhMxmWuF4vtQiTtP7AhcHAobLrKujk51rMZwz3LBTi+0IkW9+3L4ZBZhhBIYNXw9r2Bi1Eo= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1568735560827225.75631795352626; Tue, 17 Sep 2019 08:52:40 -0700 (PDT) Received: from localhost ([::1]:47624 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iAFmR-0001GR-1b for importer@patchew.org; Tue, 17 Sep 2019 11:52:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37687) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iAFjm-0008Jf-3d for qemu-devel@nongnu.org; Tue, 17 Sep 2019 11:49:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iAFjj-00077f-MT for qemu-devel@nongnu.org; Tue, 17 Sep 2019 11:49:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42302) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iAFjj-00076c-HH for qemu-devel@nongnu.org; Tue, 17 Sep 2019 11:49:51 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0A1CD3D955; Tue, 17 Sep 2019 15:49:48 +0000 (UTC) Received: from angien.brq.redhat.com (unknown [10.43.2.229]) by smtp.corp.redhat.com (Postfix) with ESMTP id D9D0760BF7; Tue, 17 Sep 2019 15:49:46 +0000 (UTC) From: Peter Krempa To: qemu-devel@nongnu.org Date: Tue, 17 Sep 2019 17:49:43 +0200 Message-Id: <249a9ca557108397b313625593bc83f161f32a16.1568735079.git.pkrempa@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 17 Sep 2019 15:49:48 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH 2/2] qapi: Allow introspecting fix for savevm's cooperation with blockdev X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Markus Armbruster , Michael Roth Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" savevm was buggy as it considered all monitor owned block device nodes for snapshot. With introduction of -blockdev the common usage made all nodes including protocol nodes monitor owned and thus considered for snapshot. This was fixed but clients need to be able to detect whether this fix is present. Since savevm does not have an QMP alternative add the feature for the 'human-monitor-command' backdoor which is used to call this command in modern use. Signed-off-by: Peter Krempa --- qapi/misc.json | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/qapi/misc.json b/qapi/misc.json index 6bd11f50e6..e2b33c3f8a 100644 --- a/qapi/misc.json +++ b/qapi/misc.json @@ -1020,6 +1020,11 @@ # # @cpu-index: The CPU to use for commands that require an implicit CPU # +# Features: +# @savevm-blockdev-monitor-nodes: If present, the savevm monitor command +# correctly handles monitor owned block no= des +# when taking a snapshot. +# # Returns: the output of the command as a string # # Since: 0.14.0 @@ -1047,7 +1052,8 @@ ## { 'command': 'human-monitor-command', 'data': {'command-line': 'str', '*cpu-index': 'int'}, - 'returns': 'str' } + 'returns': 'str', + 'features' : [ { 'name': 'savevm-blockdev-monitor-nodes' } ] } ## # @change: --=20 2.21.0