From nobody Mon Feb 9 15:10:39 2026 Delivered-To: importer@patchew.org Received-SPF: temperror (zoho.com: Error in retrieving data from DNS) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=temperror (zoho.com: Error in retrieving data from DNS) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (208.118.235.17 [208.118.235.17]) by mx.zohomail.com with SMTPS id 1543592035120966.181354340428; Fri, 30 Nov 2018 07:33:55 -0800 (PST) Received: from localhost ([::1]:33334 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSknO-00051x-1u for importer@patchew.org; Fri, 30 Nov 2018 10:33:34 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51512) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSkZa-0007SB-Cz for qemu-devel@nongnu.org; Fri, 30 Nov 2018 10:19:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gSkZW-0006WB-C0 for qemu-devel@nongnu.org; Fri, 30 Nov 2018 10:19:18 -0500 Received: from fanzine.igalia.com ([91.117.99.155]:53245) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gSkZU-00062Y-4w; Fri, 30 Nov 2018 10:19:14 -0500 Received: from [194.100.51.2] (helo=perseus.local) by fanzine.igalia.com with esmtpsa (Cipher TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim) id 1gSkYp-0007XA-7B; Fri, 30 Nov 2018 16:18:31 +0100 Received: from berto by perseus.local with local (Exim 4.89) (envelope-from ) id 1gSkYZ-0003eF-F6; Fri, 30 Nov 2018 17:18:15 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=References:In-Reply-To:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=dgl0Y/tkCf6OXswtvwf5rQuqlmWjkTxTgj/7Pur5HyE=; b=TRW7Nf2jcjAv7GHmt//y5HpoNGnEDAvD7dFO6+/rGZdhUDf+m/1a+/FH7HvplVYcTpn57wOUwCNZx3H9KePrcyvCPyieqwZhGXjPaPo87EDti8PA30dGbV+RuY8ZahBKI3eZvUWE7HwCtMyRDw6LWhk5HQ7phZ9ew1KtlHSDwWgGX8pU5VEjKAM8n3f80QyIm+dHDJ+8vVmyWcZjLMN1TDLkHoTg0ZGyH88Oa0hXCz1rl7BFtCE3Qfns1Bze2pnS72fTJsIqb7A6tH3QGNxfT0Dv3NUNvmih6tRwXu1Qs6As/NpMa/1dc9ipu5sUyr9XUrVwY+TUkgu3IwsaUPnQFw==; From: Alberto Garcia To: qemu-devel@nongnu.org Date: Fri, 30 Nov 2018 17:17:41 +0200 Message-Id: <21ebfe2fbdefe991b4d2a367410c477085c3ac05.1543590618.git.berto@igalia.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 91.117.99.155 Subject: [Qemu-devel] [RFC PATCH v2 03/12] block: Freeze the backing chain for the duration of the mirror job X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Alberto Garcia , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Alberto Garcia --- block/mirror.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/block/mirror.c b/block/mirror.c index f746618224..944ece83ed 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -631,6 +631,10 @@ static int mirror_exit_common(Job *job) } s->prepared =3D true; =20 + if (bdrv_chain_contains(src, target_bs)) { + bdrv_unfreeze_backing_chain(mirror_top_bs, target_bs); + } + bdrv_release_dirty_bitmap(src, s->dirty_bitmap); =20 /* Make sure that the source BDS doesn't go away during bdrv_replace_n= ode, @@ -1641,6 +1645,10 @@ static void mirror_start_job(const char *job_id, Blo= ckDriverState *bs, goto fail; } } + + if (bdrv_freeze_backing_chain(mirror_top_bs, target, errp) < 0) { + goto fail; + } } =20 QTAILQ_INIT(&s->ops_in_flight); --=20 2.11.0