From nobody Fri Nov 20 20:38:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1794564057; cv=none; d=zohomail.com; s=zohoarc; b=lU1kvswrNMMvw6xRXa14JVQBOQNm6Y5g9ABw4GdsRI3Iy69cCUxBOZnRsRz6TAjHmPebHDmNJ9yJm8OoNy7yq95+EC7GkK8dj7cf1+jLeBHhIIFTwDoD2gcMyd67XLyxoVdfmoCjGtLBpqO1JYgJ3iz75Ei2XbYMpOp4mV2AKAM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1794564057; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=nVmYktA8t1eOd53iv0UrOPA7DSnRVRWaHMJpT2eQqDI=; b=P9BcKydKjTkOKG9YWBs0XQSo6Sy5RTP7KGZuQ4967UcBgYxxNG81gkZKuSv1hZi87ESMgEVuJLLiyYNU4yLZdbQNgE/q9JCNzM1zAizJkNfdRI8IsTVX8FVtQEHt5o5QktA+0PKOR2vEi3zZQAYzXYpCn5RrnttAdO+64v0xrHw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1794564057475892.3990824226515; Fri, 13 Nov 2026 02:00:57 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xRo3d-0007pA-TQ; Fri, 13 Nov 2026 04:58:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xRo3b-0007nW-9L for qemu-devel@nongnu.org; Fri, 13 Nov 2026 04:58:55 -0500 Received: from flow-a1-smtp.messagingengine.com ([103.168.172.136]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xRo3X-0004KM-Fj for qemu-devel@nongnu.org; Fri, 13 Nov 2026 04:58:54 -0500 Received: from phl-compute-07.internal (phl-compute-07.internal [10.202.2.47]) by mailflow.phl.internal (Postfix) with ESMTP id B7BF013821C9 for ; Fri, 13 Nov 2026 04:58:49 -0500 (EST) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-07.internal (MEProxy); Fri, 13 Nov 2026 04:58:49 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 13 Nov 2026 04:58:48 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm2; t=1794563929; x=1794571129; bh=nVmYktA8t1eOd53iv0UrOPA7DSnRVRWa HMJpT2eQqDI=; b=GbmEeW0Gywhzb36A9qe2N4oGRkWxL1B22wKVfqYL0EC80xLl sKixfRrOrAcpWAnRGgSoFJjTElkV3HGATBUSsryTgFlVmVWl9HerkSihfT8DfbTi r1guW0g2Ld3eALxxSyC+QOhUCmpuaYz9o7AcYWPmaKaP6xukJIiVYmipGcwDx8TU xWnrbNwflh18ZKf4CL2Am8h8b7bpmEtWJYL3BwtapZHIoeyEn0rXfciyci6LW5B0 p5XCwTQt9hSEYSE6hid48gOL8IxT1aiyq/ToeWeLgkeCeM12yT+wsJlkuds73jq7 sami+b10QtwWoiHNQpWBjAuty0wM9P7vSI9wRQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1794563929; x= 1794571129; bh=nVmYktA8t1eOd53iv0UrOPA7DSnRVRWaHMJpT2eQqDI=; b=V KuIwGzoXnjMcFZ0Cv626wG9gNsE3sjOjggpZTuHmkoyGZahyLiBlC/gE4XfkicOZ 864eroKe46SR2Inqnrlfg9fgjeCmN9Bg01PsuSm/3KTcD4edzgEHNLN6ZlYLiYtE 6QULau74wuNN2cqVbkHnwLNIdOAJDb8CU2vVSEukAon/EPzcGdiVemRfxaPWbGlu Hv2D3BAcIpEJ3iWHkXkbEYciFQQBviJBMCWdL8CIEjR1Z5gNVepl1ixs64/fVAlG ZGkK0c01bCIaHTHEIdV2cDqK4XGE/JnfKhVNicE4M7o2OALxnJEfQ8b0ianakPQH IzfV4gg95byJIE22gleqg== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=sign d=irrelevant.dk a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1794563929; d=irrelevant.dk; mf=PGl0c0BpcnJlbGV2YW50LmRrPg==; rt=PHFlbXUtZGV2ZWxAbm9uZ251Lm9yZz4=; s=fm2:rsa-sha256:E36WeUldzw5O9xmvPneH4k5EW+88/3y9t9zpMkquk3Oxrci iw48FcQvTXnBh1lLFEKCiOw27dv5sgkNMikINnLU5XeulPF8/cTZu3kFoNvK+0NQ /zysUIeFToUXd9CYtHx7HYE8hWKjEBGOloA5ukgrfhG2AQL2c+uskWqbhtfq/TTD loo3NfEp5V4AZGrnXU+UAkrSf7bAcmR3nkuElsvb+at0tt1VSmCrf7LliL13FuiF RxMSfHcPNCcaVva/Ip/vkg2MPJ5SR+Q3+RxHeQTIWTIvFBf7fp4dfj4SsjAoqONx 2yHFDKsjkanTIkBBsM3h1/eg5ieVmB+kU5D6/IA==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=mi-m=1; hc=12; hn=cc,content-transfer-encoding,content-type,date,feedback-id, from,in-reply-to,message-id,mime-version,references,subject,to; Message-Instance: m=1; h=sha256:3u6WUtEQAutfnDI64cIKqZxZsNFOhIJES/pL852DrvM=:H/MmiMwLsTOYRLtcqbbtct6AhL2xt+sRmnYl+/E/W58=; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGoW/r+HHkPvpDPhLJ23+QC4nYba1HxO91KJlnQiR9zkGCwEYw+hslx7rW1vDbE4+ kz5VFVK/snpzGpHFah5+BrQC5Odi347Kgy2Mlr5HAFrBCN6MezvbAWNNiSKcqirBY4p9YX Ku8dAAjbQsE4uZSQQ2Syh0wYsOxS/RAvnuRHNaXbbHga8A5xc+kCsfPUk9C/MLQ0RFzI+V 28Zx/R3JCwUdoXIA8xPHpDV9qjOGPp4XXUOEV6BJxGO/m3rCoWoHVH2BcSg1+XollOGVCj rAyb3zo9XG9yafFAn9+wIglY5hkk3wGupF0KxnPeauCJX1uNNPPE5qwh7TjjzAKlG28qE6 8s65zwI1GEr9/CFCQblC05kMRtq/ajGmzi49SzewJTjBID3zInbIsy3EBKHgBaoDvJGw5e fpxqD5ABdYcNSEqURabEOqk9NTRGbMCR9WC++bfdKcOxYlsIVDG20hh+SkkaOddsdD/HUR 3uVFhCVyGmfmP4uR2q10Q1gGQ8DwkxzgelZ9hu87qrb3kpUzrlG8+46R7578AueA779GI/ SY9gVou+lD6hLIk+0maSIR+3eliqyXIgjyxKtpHNjIx88Xun52lsA+XtSjEucTYsUdUYeo +KITeKsBcIKJceO4ed+qNEwmdfEJ2ADBzQMLUAfGmA+1WLhex7qG2JitkGjA X-ME-Proxy: Feedback-ID: idc91472f:Fastmail From: Klaus Jensen Date: Fri, 13 Nov 2026 10:58:38 +0100 Subject: [PATCH v2 1/3] hw/nvme: reject fdp.runs smaller than the lba data size MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20261113-nvme-for-rc-v2-1-e458fd0e12ca@samsung.com> References: <20261113-nvme-for-rc-v2-0-e458fd0e12ca@samsung.com> In-Reply-To: <20261113-nvme-for-rc-v2-0-e458fd0e12ca@samsung.com> To: qemu-devel@nongnu.org, Keith Busch , Klaus Jensen , Jesper Devantier , qemu-block@nongnu.org Cc: Klaus Jensen , qemu-stable@nongnu.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1088; i=k.jensen@samsung.com; h=from:subject:message-id; bh=iNIXmPlJnOBBz/SNrN6gqSNgOkoUEOj6CpNh7QXtGck=; b=LS0tLS1CRUdJTiBQR1AgTUVTU0FHRS0tLS0tCgpvd0o0bkFGdEFaTCtrQTBEQUFvQlRlR3ZNV zFQRGVrQnl5WmlBR3IyMzFWUXV6NWV3Y1liWWZERG8xTEJyOGowClV3d0hUVUpQK2orLzdxMFVx U2ZTK0lrQk13UUFBUW9BSFJZaEJGSW9NNnAxNHR6bW9rZG13RTNocnpGdFR3M3AKQlFKcTl0OVZ BQW9KRUUzaHJ6RnRUdzNwOTl3SC9SYjE5NjFxbUpNQmZZVWpCUHdsV1l3U1E4ZmIzd29OUFQ2Kw pvRGZ2NVJDU2NNMHY1RGNTUi9IWmxkU0szVzZpSTZmSkxmKzcwRE1aWWlBZ2NqUzJRVkF0L0R5T lYyVkd4Q0RvCkdtNWJGT3RoancyZVFjMXJmWGdxQTJPbVpMWEU5Tnh1RXVFQmhpSEZSRGVxVU16 Q3VSSi9WRW5YQitUVXRWNWoKZE15MEpBSXB1c3g4Q2hVa1M2eGpIM1M5dW1RT0tGWDU5eG00T21 3bXBMTzEvNmdvSUdBOFVEVjJoLy9RYzhoTgplUGY2RlRjQTZrMVp5R25qZUlRdk9qMHdsL0lLOD hFNk1WTnRLSnRLQmFUR2xJRnI5Zmtib21Da1Vwa3VOS1BDCnh6RTZRbE95NmZjOHNFRmFxYnVYN W81djNhMDFjenY2WTJFdlkwUlpMQVRGek9QZEcwOVo0cWZNCj1kcmY3Ci0tLS0tRU5EIFBHUCBN RVNTQUdFLS0tLS0K X-Developer-Key: i=k.jensen@samsung.com; a=openpgp; fpr=DDCA4D9C9EF931CC3468427263D56FC5E55DA838 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=103.168.172.136; envelope-from=its@irrelevant.dk; helo=flow-a1-smtp.messagingengine.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @irrelevant.dk) X-ZM-MESSAGEID: 1794564059648158500 From: Klaus Jensen The reclaim unit accounting in nvme_do_write_fdp spins forever if RUNS is configured to be smaller than LBADS. Reject such an invalid configuration upfront. Cc: qemu-stable@nongnu.org Link: https://gitlab.com/qemu-project/qemu/-/work_items/4520 Fixes: 73064edfb864 ("hw/nvme: flexible data placement emulation") Reviewed-by: Jesper Wendel Devantier Signed-off-by: Klaus Jensen --- hw/nvme/ns.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/nvme/ns.c b/hw/nvme/ns.c index 2ae26a9acbd0..37d45bb4d533 100644 --- a/hw/nvme/ns.c +++ b/hw/nvme/ns.c @@ -485,6 +485,12 @@ static bool nvme_ns_init_fdp(NvmeNamespace *ns, Error = **errp) char *r, *p; uint16_t *ph; =20 + if (endgrp->fdp.runs < nvme_l2b(ns, 1)) { + error_setg(errp, "fdp.runs must be greater than or equal to the " + "lba data size of the namespace"); + return false; + } + if (!ns->params.fdp.ruhs) { ns->fdp.nphs =3D 1; ph =3D ns->fdp.phs =3D g_new(uint16_t, 1); --=20 2.53.0 From nobody Fri Nov 20 20:38:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1794564007; cv=none; d=zohomail.com; s=zohoarc; b=e88tuicoZsMkRGR8laaBiePpe+x2tkVdsJw7JOwZoxvrAU+qxNfX5ofb4CkMnRxhcuJiQZBMVxo/0HdTA4vHLLzV2+Qm8fH7ZDQwzTiKvmUgc1kRODurbrBABkXlVPGToCAAj3QREZ/sG0o1+Mp0MDK7YtyxHxz6DiW/dJJuYSw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1794564007; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=21T89aWnyd5ZP0jdAEIu9QLYoM8VQxuyWsQVw7Tc8CU=; b=bnznPWe6Aytu0ulqysmQ2Ox8ofBcwVEZ2U1hFmvlKVPsMBpxv4i1I682NHVhPqFqDYcndbRPLncw8QXp2mgpdCskTFGr4BDQPtAazYeYG+zl6+XNWjS7bOybOijyILMoJt7DsoRtCWWjAyLWDSSfq1jgc0HPQJqm7b7zOhuzpAc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1794564007348123.22270065391149; Fri, 13 Nov 2026 02:00:07 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xRo3f-0007pz-UO; Fri, 13 Nov 2026 04:58:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xRo3b-0007ns-N0 for qemu-devel@nongnu.org; Fri, 13 Nov 2026 04:58:56 -0500 Received: from flow-a1-smtp.messagingengine.com ([103.168.172.136]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xRo3Z-0004Q1-V0 for qemu-devel@nongnu.org; Fri, 13 Nov 2026 04:58:55 -0500 Received: from phl-compute-10.internal (phl-compute-10.internal [10.202.2.50]) by mailflow.phl.internal (Postfix) with ESMTP id 3A7181382241 for ; Fri, 13 Nov 2026 04:58:51 -0500 (EST) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-10.internal (MEProxy); Fri, 13 Nov 2026 04:58:51 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 13 Nov 2026 04:58:49 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm2; t=1794563931; x=1794571131; bh=21T89aWnyd5ZP0jdAEIu9QLYoM8VQxuy WsQVw7Tc8CU=; b=QhzWoI7SLJhLUp+B8M5fuVbLUzpGZw3Opvgevtku1H9PrTWf qcT9rFEmAB1uoVB6NhYVahiwamMnVfl7SZpN1BdxEfByLtK5BLPRclrLiTTBfrjJ 8vSjHxxjHjOLNLrVyNPxIHF53S4Be36EAEaHtUAJWOG/rQLi1YJ7TqS30Q/vk41a d5RjiBiiCvSRD4uLh3Jcti3lTBxxqrGdmYMIjDHJKg/S0P/WGW5/haaTyjLo3k1W 997WBRXXrmro+QMcP1tuDmQeOEOpk6uRZs0yul4/ePUtjqSafYqllrxoX5/R+n3P vx7IViqLeK/tB7EtEomjmCai0TesJTVeDlcMEg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1794563931; x= 1794571131; bh=21T89aWnyd5ZP0jdAEIu9QLYoM8VQxuyWsQVw7Tc8CU=; b=r rGODUHNXoFbr3dJLgnj5yQbXPCVJll/XHRpEFw38j1OjzToGx1NZeiU6qqQbD+Ia tCRkxhch7za2qhqlyxT+UwhRDYKc/F5xEWRFPRRYjz8Mkk6Q+In/almpBre9jBbH fmbRaQWvYYYNwL1LhFDPwVCvKTpPdAkOGLZIvKcO8U9mDTL5uB+EIc8DLe6h2QMk DQ/7Qtga3IGYbWeEbHV2sh+XZNBi7M7EO6YQJsnprKKIvuAUTymwOgow3gdL2uCr pV//KwJEYlTlRrjeE48dpRvRmO22SCXcF4IxA/a47k5kEH0CCzAwytFzzpjo8SBV 7bIWUkUVFV/poX7SWeMkw== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=sign d=irrelevant.dk a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1794563931; d=irrelevant.dk; mf=PGl0c0BpcnJlbGV2YW50LmRrPg==; rt=PHFlbXUtZGV2ZWxAbm9uZ251Lm9yZz4=; s=fm2:rsa-sha256:bW3tsxvMngny3RPt2mIo4zqQnP14Yi8gmmiigXeFpw/KbjB drpsyRjLCd7e5eLb74MPEm9ZArSgIgu810BfOxxePu2R5EJumdpUSbwdfxXkMGUb I+ntNfVrea+7U4OBMhuJwR0w6Omcv2Ksai2kgk6znzWRU7WHJNvjjKElZBATz6HY amJtX8Q1UuamOyxa7NJaXrSsInitJ+vy9wLHx3tCMODAWx6zjJTus/7WjjVNP4ul EiZcrVBNqFsOLaQI+ctUGpluTTZ124IpgqHj5jWXvFIWSZfw91BMU5+uuKVtiJOR HLP+LRRKyAFiYDI4/EyD7eWLsu4m/RlLL+PIUvA==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=mi-m=1; hc=12; hn=cc,content-transfer-encoding,content-type,date,feedback-id, from,in-reply-to,message-id,mime-version,references,subject,to; Message-Instance: m=1; h=sha256:qra4ZDZs7mvzx6XigVwoCZbOD/AXXY1PRyhhkmDFXRI=:L3YslUKPbvG5anQS4sceAIfibWp5n69d5O1OwfBIW6w=; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGoW/r+HHkPvpDPhLJ23+QC4nYba1HxO91KJlnQiR9zkGCwEYw+hslx7rW1vDbE4+ kz5VFVK/snpzGpHFah5+BrQC5Odi347Kgy2Mlr5HAFrBCN6MezvbAWNNiSKcqirBY4p9YX Ku8dAAjbQsE4uZSQQ2Syh0wYsOxS/RAvnuRHNaXbbHga8A5xc+kCsfPUk9C/MLQ0RFzI+V 28Zx/R3JCwUdoXIA8xPHpDV9qjOGPp4XXUOEV6BJxGO/m3rCoWoHVH2BcSg1+XollOGVCj rAyb3zo9XG9yafFAn9+wIglY5hkk3wGupF0KxnPeauCJX1uNNPPE5qwh7TjjzAKlG28qF3 3daJ6bYwQxiMfjPRtPyHSA2OttYFqy/8LMuUoA88C9sL5eNL/6bxUbLXCrcd3/H38efDwP Xt3dLY/RTE6zjwZ9Gx2uBaH/CPoSalSP64mkemC+t2Da9J3A+ACbXiQW1ipAK6oY6bpqIc W2H3ODBQb4z6gKbRAAsV27rJO1lo3hQnQW/ioB1ug+iv0kR7MWFJWmEjeFO2AYVTeA77yE ukB7g6PEhvltWOaBhOMyMjfh8Bqqg4exCKVtgbGgiZXSYi8wLt3O9vyvxp5MqSllgN9OEl vZ0saHvBoDeRfcUK2nEdAVwgAVdWGhTACA6W/sq/NgGWrIwV9eVnELluQOBQ X-ME-Proxy: Feedback-ID: idc91472f:Fastmail From: Klaus Jensen Date: Fri, 13 Nov 2026 10:58:39 +0100 Subject: [PATCH v2 2/3] hw/nvme: fix fdp reclaim unit accounting MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20261113-nvme-for-rc-v2-2-e458fd0e12ca@samsung.com> References: <20261113-nvme-for-rc-v2-0-e458fd0e12ca@samsung.com> In-Reply-To: <20261113-nvme-for-rc-v2-0-e458fd0e12ca@samsung.com> To: qemu-devel@nongnu.org, Keith Busch , Klaus Jensen , Jesper Devantier , qemu-block@nongnu.org Cc: Klaus Jensen , qemu-stable@nongnu.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1088; i=k.jensen@samsung.com; h=from:subject:message-id; bh=hKQJNRCh2YoQgXpD9PI9ciotEpdMd9zKsUp/SeTUJdc=; b=LS0tLS1CRUdJTiBQR1AgTUVTU0FHRS0tLS0tCgpvd0o0bkFGdEFaTCtrQTBEQUFvQlRlR3ZNV zFQRGVrQnl5WmlBR3IyMzFXVDBkTlAxc21aZ1ZTQ2VZNjh0M0dmCkovV0Q3TGhxMWZVb1haYmp1 UUIvQW9rQk13UUFBUW9BSFJZaEJGSW9NNnAxNHR6bW9rZG13RTNocnpGdFR3M3AKQlFKcTl0OVZ BQW9KRUUzaHJ6RnRUdzNwK2d3SC9pWUpwSnd2aXRTQ3ZiRVl4SEZVMHEwWEtCek5IOE5ibzF2dw pVcUd1NG5jZ0RyVDRzWGJFUW9CSTJHbEwyREt2b2ZPOG5zMDBBZDgwWldXWEZHODl2ZEF6RGtse k4xOVM1S0FvCjZKUkFvVEZDNVE1NEl6OVU0V1ZzY3djV00zVHkzWklmR0krdy8rY1hBSXNEeWl5 RDdrMGpIMW9CZDNPNjc5N1IKNGM0QVdlNmpOVVhaQlpyZkNVekFQMXJRQjNKbkhWMW96RHo1YVZ EVjc0cU5menNBSGhzSXE2SEJpV2xDdHpvZQpzVjlaR1ZuREtkUUFPQ0wweXY5elZoMHVvV0Z5dF NueURXQ3J3bE9EdHZZU083bTFIY3Y0OWhwWHVaOGFuV2JhCkxERWdHWDBtdVBXbGNZYnNsUUc0Q 2pyOFFKQVl1VldDS2hvUUQvbEtzUVI0cjI1aUxBOElRNlJPCj15M2FBCi0tLS0tRU5EIFBHUCBN RVNTQUdFLS0tLS0K X-Developer-Key: i=k.jensen@samsung.com; a=openpgp; fpr=DDCA4D9C9EF931CC3468427263D56FC5E55DA838 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=103.168.172.136; envelope-from=its@irrelevant.dk; helo=flow-a1-smtp.messagingengine.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @irrelevant.dk) X-ZM-MESSAGEID: 1794564010811158500 From: Klaus Jensen nvme_do_write_fdp falls back to placement handle zero for a write that has no Data Placement directive or where the placement identifier is invalid. However, it then passes the invalid placement identifier to nvme_update_ruh which results in no update to RUAMW for placement handle zero. Reset the placement identifier along with the handle in the fallback. Cc: qemu-stable@nongnu.org Link: https://gitlab.com/qemu-project/qemu/-/work_items/4520 Fixes: 73064edfb864 ("hw/nvme: flexible data placement emulation") Reviewed-by: Jesper Wendel Devantier Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index 685cbc2f340c..a0d22dacedfa 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -3754,6 +3754,7 @@ static void nvme_do_write_fdp(NvmeCtrl *n, NvmeReques= t *req, uint64_t slba, !nvme_parse_pid(ns, pid, &ph, &rg)) { ph =3D 0; rg =3D 0; + pid =3D 0; } =20 ruhid =3D ns->fdp.phs[ph]; --=20 2.53.0 From nobody Fri Nov 20 20:38:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1794564033; cv=none; d=zohomail.com; s=zohoarc; b=YOeN1HztO1NjGEMi7hQHpFUbeWV6PyqeWsf5zS6GORCrvaCAfWDp/GhZJOdoIpX9PomnPjvkTNRwyWfBTCpQoAc5vcMiUgqkejnq4r1nVVfbX/6D5+21ynQ+OYUM8XUdZHmWIdtMROco2/MNM8i8rGR0cukzilXlVi1lq1Ua3uw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1794564033; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lvDx2zS5hnxkVV6y+Wp9xY6T21L02EKL57bJmmWL/QE=; b=UeUBzsv0MpDNJqgJ+gZ1kuiqsfJW+MIwZP1Y8h0SHCjUpqnw6WT5VynIIRhYejhI0NFCjia0POGru2br9N0OyO7dOgNLwu6s4UWaARQ9OtirT/aHPV/qzGcTW85nP07Xx+wys2VDIFovQ0sgJR4HqYrdMgbrVRCjZMPJqZH0hi0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1794564033602409.9687550250975; Fri, 13 Nov 2026 02:00:33 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xRo3o-0007sR-4r; Fri, 13 Nov 2026 04:59:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xRo3m-0007rt-Kw for qemu-devel@nongnu.org; Fri, 13 Nov 2026 04:59:06 -0500 Received: from flow-a1-smtp.messagingengine.com ([103.168.172.136]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xRo3l-0004W3-4r for qemu-devel@nongnu.org; Fri, 13 Nov 2026 04:59:06 -0500 Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailflow.phl.internal (Postfix) with ESMTP id D4D991382257 for ; Fri, 13 Nov 2026 04:58:52 -0500 (EST) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Fri, 13 Nov 2026 04:58:52 -0500 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 13 Nov 2026 04:58:51 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm2; t=1794563932; x=1794571132; bh=lvDx2zS5hnxkVV6y+Wp9xY6T21L02EKL 57bJmmWL/QE=; b=EerXxB+dzxTjGENFMJ0sI4QXIjOUCzWe0sXt+JRu4pqfxIA4 XR5si1I/VsXrDxyQ/n1XilFLjGdiHwAuyEI+z4J+rW8+ijLNmAiOirZpEMT4zC3W ruiDE9GJNCllFRWKcGqK3S8lIIbC3BoMkxiHoxK8+Cc3HS/RTBuZPEn41TCmh2q5 rvowmoiIaYNkShIWe49B6gg7jl8VmUkSBMy3+lNJuk9tZvexAr/SitUnptfuMoH1 afYdDmR+pQIHBums9kR7Fb2EN7ojSH4B+5FTotENhv+esFFXURx7b1fTheJyJXOB tvh6X5crV5jb0Ju3ierWqMyPVUFpbxWoJ5gTdQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1794563932; x= 1794571132; bh=lvDx2zS5hnxkVV6y+Wp9xY6T21L02EKL57bJmmWL/QE=; b=U w0vLvTq+ZBmNNWMLf+wQ5pIecfi7WMmmezHtxOisHAxA8aSLOJy/PnKo8veUDLyq FqS510PhcaTDV4nWXG+1ym81eeY1CKLTN+/56NRWH+XQp/BkuZDga7AaJ7dAXdU/ Uja+9PVKImFixoNyfwr9DTJjotUCw52NuJ8cnmpVakxP0lVkMFpbD1V6Mg1Jnknb 5WC8rQBvO8re98B/q/GIXAc6n+7PX5GSiyZBu0Y0rl3mtl8S8Eh9KjbOUNykDwL/ cYyTQ/BUwEXwaIVeQ7bbhRZ8T06rJaQA34dwPjTuvdk/z3HSKo2GlOskxvQN2bm7 wlAb2qzLEWeRoMVGCoeQw== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=sign d=irrelevant.dk a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1794563932; d=irrelevant.dk; mf=PGl0c0BpcnJlbGV2YW50LmRrPg==; rt=PHFlbXUtZGV2ZWxAbm9uZ251Lm9yZz4=; s=fm2:rsa-sha256:PXtLkkFt2hyxRHaIcgLs3uw3SOBzS/PZmEhG7Ola5ktSOd8 NkVpwktKp5+8UYf+HDHgeFlCBTs0Rz40AaQis+owuNjJKcblmgGYCB6IRFIydZgc btxGQFurMzmCUz/7I1gpBrqoOLx+Bn049oc9kos2gZGrjJCSsDD7CMKs79177GQo 1P0zW9NaHb4Raxc+TN/GBkaxs3UN6pcbsujYXe2Cx7ZExiqaZ25b1JTEV7pRgudW DUwn4TaqfUPdF3SGZOpfe8YmxtzXdtA2wGnMuHs6Zb6trA8xe5X09GEySYoX7A9G FdcL4P9dHMjK/5+2Dl5NTmy/Ew91kqMxJYr04oQ==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=mi-m=1; hc=12; hn=cc,content-transfer-encoding,content-type,date,feedback-id, from,in-reply-to,message-id,mime-version,references,subject,to; Message-Instance: m=1; h=sha256:myVBYRiy/F0UlvrbpLCc7KOKGyfCNrna/vWdVzzBZT0=:vQSgMx56b5PHsEtbFLH0UX/qr5zEnWHiUk3lJd3QrSY=; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGoW/r+HHkPvpDPhLJ23+QC4nYba1HxO91KJlnQiR9zkGCwEYw+hslx7rW1vDbE4+ kz5VFVK/snpzGpHFah5+BrQC5Odi347Kgy2Mlr5HAFrBCN6MezvbAWNNiSKcqirBY4p9YX Ku8dAAjbQsE4uZSQQ2Syh0wYsOxS/RAvnuRHNaXbbHga8A5xc+kCsfPUk9C/MLQ0RFzI+V 28Zx/R3JCwUdoXIA8xPHpDV9qjOGPp4XXUOEV6BJxGO/m3rCoWoHVH2BcSg1+XollOGVCj rAyb3zo9XG9yafFAn9+wIglY5hkk3wGupF0KxnPeauCJX1uNNPPE5qwh7TjjzAKlG28qay C+QjPJe/Np75Md2tpnWK8+BEEdpVQVYHjDFDAQ1XytaF/2TZctQjG01WQfUEcgc62OAYkE P3752o9da1xXzCUFm5mcutA++wUHbxu5sHXWjoH6iQGUBYaQ9fC1/eQE9Edmf+iaXJKB1P LJkgEeNyYwkG4jON1saB8RCw9v+c1gEbe3nPBniskMkeSAndXzD2e5Zc3V7V8MrIl55XPS 9bTYpNrGGYIXU/eiB7gMstizM/VQyhHOFh8G2FcjBw8ASugF9WQcRJgee7b0OG4AFoqx30 AdKYWecNgWajpOff2A+f6sOkk5GLLfk3YLXEdgGLkR1ixvIk+/j+6TS40wPQ X-ME-Proxy: Feedback-ID: idc91472f:Fastmail From: Klaus Jensen Date: Fri, 13 Nov 2026 10:58:40 +0100 Subject: [PATCH v2 3/3] hw/nvme: fix broadcast fdp events handling MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20261113-nvme-for-rc-v2-3-e458fd0e12ca@samsung.com> References: <20261113-nvme-for-rc-v2-0-e458fd0e12ca@samsung.com> In-Reply-To: <20261113-nvme-for-rc-v2-0-e458fd0e12ca@samsung.com> To: qemu-devel@nongnu.org, Keith Busch , Klaus Jensen , Jesper Devantier , qemu-block@nongnu.org Cc: Klaus Jensen , qemu-stable@nongnu.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1262; i=k.jensen@samsung.com; h=from:subject:message-id; bh=bZ6FSzTGekAUrxfzNnfqXvXj92ap8NZ8rnIXtCAZxwQ=; b=LS0tLS1CRUdJTiBQR1AgTUVTU0FHRS0tLS0tCgpvd0o0bkFGdEFaTCtrQTBEQUFvQlRlR3ZNV zFQRGVrQnl5WmlBR3IyMzFaQmFjQkExalNuaWM0VnpzVloycnNZCmhQVTZSSGpSdElKdjRabmtk dHpiVUlrQk13UUFBUW9BSFJZaEJGSW9NNnAxNHR6bW9rZG13RTNocnpGdFR3M3AKQlFKcTl0OVd BQW9KRUUzaHJ6RnRUdzNwMjNvSC9pR2p0OWdYcFJwZG5OdDMwNGlSR2p1SnVRalh3eEVsUGthRw oyUDBaMVNzdSsyTzloWTZtMXo0bWYzMTB3SXdvMlpaeTk4d1Zla1Qxbm9zTmo4bENldUhsZDBHR k1NL2ZkUmd2CnI1TVZMQ01GOHh1cWxpdjczYSswaXAyZUlwM21nMTNmTzFzMDYzZTBocytkbFh6 aG10WGN6WHJ4VkhEZFZac08KRHk3ZkJoa3BMbys1MUZwSTg2eXVlblpBM3k1L3oxZDAzUjd3TmJ VckZTN0IvcDhjRllIU3dUajFJV1cyNjdOVwoyNk8yQ2VmYy9pVzE3WkJaZW9MN0JHYWJVOVpxKz I4WmVnRGdROVllYnl0MzM1WFNlZGNFbWh0UzJxM0xiWUUrCnN3Wkx2VVBmTXdsZDZrZXZVZnphZ jErVUJzb3RHdVpWVGdzd1VMeEhBL1Nqc055WkIxeElTTEJXCj14MlIvCi0tLS0tRU5EIFBHUCBN RVNTQUdFLS0tLS0K X-Developer-Key: i=k.jensen@samsung.com; a=openpgp; fpr=DDCA4D9C9EF931CC3468427263D56FC5E55DA838 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=103.168.172.136; envelope-from=its@irrelevant.dk; helo=flow-a1-smtp.messagingengine.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @irrelevant.dk) X-ZM-MESSAGEID: 1794564035178158500 From: Klaus Jensen The Set Features handler for the FDP Events feature asserts that a namespace is passed in the command because the feature is namespace-specific. An invalid namespace is rejected prior to reaching the handler, but the "broadcast nsid" (0xFFFFFFFF) is considered valid and causes the assert to abort QEMU. Reject it with Invalid Field in Command instead as per the specification. Cc: qemu-stable@nongnu.org Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/4792 Fixes: 73064edfb864 ("hw/nvme: flexible data placement emulation") Reviewed-by: Jesper Wendel Devantier Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index a0d22dacedfa..71c24dc02b67 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -6636,7 +6636,9 @@ static uint16_t nvme_set_feature_fdp_events(NvmeCtrl = *n, NvmeNamespace *ns, g_autofree uint8_t *events =3D NULL; NvmeRuHandle *ruh =3D NULL; =20 - assert(ns); + if (!ns) { + return NVME_INVALID_FIELD | NVME_DNR; + } =20 if (!n->subsys || !n->subsys->endgrp.fdp.enabled) { return NVME_FDP_DISABLED | NVME_DNR; --=20 2.53.0