From nobody Fri Oct 23 21:31:52 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1792685115; cv=none; d=zohomail.com; s=zohoarc; b=VlMktw28zqwiCmEaddjLwc1yw0a29EBwQHFcBX/HQBzIJ4XOOrqww8zV/9nA9CuvIg6cdv2w0NeDUmiInHoR0ijeQb/R2+H+2VxSEjvj77zZQ0/wMEbrALRaFQb1WmOKrM3HLEgJM1ToaVnmJSqlr6LtHuSV+Ze154NX9+Y0nVM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792685115; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=3Nnu0hm4kGJFsI7Nj2ThtAJpHvK7Vb5XvPuwJZWLYBI=; b=EM0wOxQ9gZZkdVFvkQ93EiJ2BYTP3GH69A4QKvRpICPo7/i2sSvkWJZQjspZjxzgPHTQU5zK7gtSOo6iTP9eQYaSr2nt84a6f16S/lIiYNyuW7DXSIH8B4n+BdpS2v0R4NeVBNRhvvNAV+8CIHJAf93Rv5w2ZlMFjEe6gEzK0FY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1792685115308922.2458659035684; Thu, 22 Oct 2026 09:05:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xJvHX-0000al-4k; Thu, 22 Oct 2026 12:04:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xJvHN-0000Zw-0K for qemu-devel@nongnu.org; Thu, 22 Oct 2026 12:04:33 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1xJvHK-0003L0-Sk for qemu-devel@nongnu.org; Thu, 22 Oct 2026 12:04:32 -0400 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-4a1dfd49525so15828245e9.0 for ; Thu, 22 Oct 2026 09:04:30 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a210304cfcsm5692665e9.10.2026.10.22.09.04.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Oct 2026 09:04:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1792685069; x=1793289869; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=3Nnu0hm4kGJFsI7Nj2ThtAJpHvK7Vb5XvPuwJZWLYBI=; b=ECB//Jb4iRz4qyaE5wDBiOY9Pmb2SHToqVHz3EFZX02reng4AZKU8J59lwGQXRMEpv RapS1x+sm2i7FC1PUUWU8yw25pz0Sypp8zKDCSX/cO77EQjpj76IX5tc6Gg4kRzCYTcs 5uEBJa8ZGbs+Be0Z29Vz+qPwSIsjeSXbSQwxbWSAj61fo46eRLlLvsda213j0SofNu2r CI4uTq37t639j3AP5AppymaSpQFr5+It8EAgIRVMQFZnattxHHCrTpIRINafTV/sNNlZ BHokhlSnvjF0+jBh+9e/7ns+HRgWIEHFgqXWzu8MPc06QS+i7Hmt+iyIBOXyslCE3Det 8ZYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792685069; x=1793289869; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3Nnu0hm4kGJFsI7Nj2ThtAJpHvK7Vb5XvPuwJZWLYBI=; b=GV+yp9iuHQlVnS6l+86PE6CFCk/lEs+qS2TvCLvvwOarjKAGItxsGhSjBVa2jjP1UC IDAMMDDtUMBGq+5E1vl0oLEDZfBtwlnHwkouDEvvCDU4d83TYNLuVtdE7sgK6YO9VN8V kthS6DFzzrC5MpzCC7WEuRdVHN0+TvxSt8BYnPEm4HfwAvJZqIDvp0AZFch8yEui/krn JLrT3zUcRGcy5I1RCTRml9fzC023rrn6kMlInquNvhSFhQJy2/7DgToiLugM+m57tzAc dzMgsQ5sKwGWwaB6xIrcxyVqRjCfOyKni5xDsMu895SKx7qyFeVQK2zzo/blcMNvmkCa xGlA== X-Gm-Message-State: AFq9FYKxq8TLmccfjhsgyUFUvkkbuczh01lb8aBcqoq3Phx65VDpSn4H NQ1QvpH6VGam/GllduId6tdBwdiIscIofhV+5GWxjThy0Z0yhfSiqMH6sWD8aeon8+Et6WyZogi 9xX9BQ7E= X-Gm-Gg: AYBFou0W45owZqOwBWF81IkRxNzo6k/352q2yG4KcEfYwKIjw2eMWXjfBikKqnBArqR gjnv+v+dBMzL5nWks+/uMA6Kz+GRe1Kp2oOqVWeZPPeHD5dFqOANopnKu8M5fV5O2KLd9lGjmO+ 9fAG7Ms4NH1Ft346GThWvc6aMekdr9K2qBlUhJMvWeW3ZPeu1aOB3l1u8lZH/ER726Mz1StF2Tv +romOGNVdCYs6zPXG3sHt+mdjAmM2qhz7jjPSUVtkPj2TxdiPjTtVSSlBJGVU8jyXbOdrokxLdD UwEoTOluBXPhCM/WkT8rh0ctw3pa5X0roq+ot4Jm+tW1FaqI7u+ZDzbDfpCNveoaJJb9NpZKI10 WEsKYDqJFXiaLN4tvvKeM71DHqEuaP9Yz3fOXeoG4Le/j9647fesa22zle1xH1SknKRImU1vup2 AtkQSluMIhO/1O3omzarIxmdHgR1IFo13iBIqObSFqkRNE8m0p8fXy/DXGJXeNgosMx0Ja9zopF tB91/oPFSAyg/C/w1rAblOCN6XkvvpwWLg10Qn7m2SPNg6+8QkF43PK9Pj+EaFhdKakdHdBw163 lo0r7Wo+GzgLln8ANDsBK7W+/HP4h2gkmLKKt/+G0kDvV6JGNE+Qp2DxjMTq8BimisNLJVh2Cnf YjVxWFw== X-Received: by 2002:a05:600c:4f91:b0:4a1:d675:b031 with SMTP id 5b1f17b1804b1-4a1fdb1d82bmr122059135e9.6.1792685068873; Thu, 22 Oct 2026 09:04:28 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Cc: Jason Wang Subject: [PATCH] net/tap: Avoid "close(-1)" in net_init_tap() error path Date: Thu, 22 Oct 2026 17:04:26 +0100 Message-ID: <20261022160426.451919-1-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1792685118136158500 Content-Type: text/plain; charset="utf-8" Coverity point out (CID 1660042, 1660052) that some error-exit paths in net_init_tap() reach the "close(fd)" at the 'fail' label when 'fd' still has its initial value of -1. This isn't a valid fd, so while close(-1) will fail and we are ignoring its return value anyway, we should avoid it. (Compare net_free_fds() which has "don't close -1" logic in it.) Resolves: Coverity CID 1660042, 1660052 Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- net/tap.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/tap.c b/net/tap.c index d71e3dd1175..ea0ad084819 100644 --- a/net/tap.c +++ b/net/tap.c @@ -1245,7 +1245,9 @@ int net_init_tap(const Netdev *netdev, const char *na= me, return 0; =20 fail: - close(fd); + if (fd !=3D -1) { + close(fd); + } net_free_fds(fds, queues); net_free_fds(vhost_fds, queues); return -1; --=20 2.43.0