From nobody Fri Oct 23 21:06:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1792531216; cv=none; d=zohomail.com; s=zohoarc; b=h2cTPbbfl4V9cV848kYEJBzKsmuUbXNsoA+YDzWi9hwj6/t1yZ6zMAy71lPzf4q5stVWP4wmn49ZmhdmBmOoQofeaWK6rrRESSwKs8L+TfmyIylrVZBIw9p7w/nHLLeuOZDTTfakSk+4tosYzFZRGIeAjsqxGURHGMWwKooMOms= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792531216; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=c/nIjS2GzZ6W7FtfGE5EeGltb2q4XTYFs7kvQmKLBbo=; b=UiccFE2UERpWlR3vKmpHwCUAh8PksIr59eRJiy4TGiYCk232hqBmuJqvS7+6Gni6Rd4EWIwgl4XpxPsD0wJfbXWl35O7jwKGpzTkQgaJJ1lgSc97+UnAXKfynMZRKT7P+n0aX6V++cyDNzCeKVzXGGto1RqT79usRKPr5tfNolQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1792531216694915.0778505252117; Tue, 20 Oct 2026 14:20:16 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xJHFV-0001K5-GT; Tue, 20 Oct 2026 17:19:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xJHBJ-0000rn-JS for qemu-devel@nongnu.org; Tue, 20 Oct 2026 17:15:37 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1xJHBH-0002Yy-NO for qemu-devel@nongnu.org; Tue, 20 Oct 2026 17:15:37 -0400 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-48b0584ad71so40702f8f.0 for ; Tue, 20 Oct 2026 14:15:34 -0700 (PDT) Received: from localhost.localdomain ([2a01:7d0:d21a:4a00:39f5:8799:5de1:6dc6]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48e258424bcsm893150f8f.55.2026.10.20.14.15.31 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 20 Oct 2026 14:15:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792530933; x=1793135733; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=c/nIjS2GzZ6W7FtfGE5EeGltb2q4XTYFs7kvQmKLBbo=; b=sx8LzyxIdA5rh3VYh7WtgP9MZKYx66d7D0hZDPGZLZFGxe7VwL4DiuKKPlXOUG0C3k mgQ06eqVgGPLidhHZdqCBzpjIgWiTM9BXy2D+kOGIuHMzXsdr3fdshAMIEF7bCLEBdN8 9A7UtMjIea/kII7KJDgoPU1LRYxeb92WS/CEV2YOvaZcuhF1b2zDSSFOXlfHamroZuLN FD1ObnAKJv7T2zLr36NzDgka0dWMLKu374vBUQbrsbchLjcurqC6uyBbKZLrCNyCVM3n /A9DUJogkY2NytyC510ouEtvqd6atytQ0Vq7xLrcODBuWGNPOvdQqzR0bLedLJBaWyrH fYXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792530933; x=1793135733; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=c/nIjS2GzZ6W7FtfGE5EeGltb2q4XTYFs7kvQmKLBbo=; b=Uy2zcG8k3UeawCbkDKjgHDw3aR4MVbRnFU0jf4xjc249vrl2RngxX+Thg+bA9SwYR8 TO4D/6MAbU0aeI8OZCcLXKHqSSMC6C9N7YZarZamrEod2EV/bd3aV/E8cqyzcUpP4Ip+ WlvUroAVF7xz6XCs8VRYaXkx8LOiJcemRGt+tOY7gOYQ8PMByU0hNaTNSpoIP21y2zIO NVBI4g+FuNNtYycCD7DAO9tLskBSr09uQYDvdqH8RqhEc6XeXW2RQuWHB0Lc5QjnYRck v/2ZKrBV9E26vHq6KhSG8ybJqJyTuvoFSWSZ7lo1kNZTSjHt5xXzYsmlavl2RJTp8Zcq MC3g== X-Gm-Message-State: AFq9FYL4BEfr3vmig5m4iy4K4FLx1IlLfJgfFdQfO/mINN6534EdUnbp hNwL48rRSu2wFabiQPIJkMDjpIG2hfoRQvODokPwM+w5MInRT2YNS4DQQWacnWaEdkA= X-Gm-Gg: AYBFou27yapS2wBTc2AWTCmuFvL7x9EqRDAWM5F2Ue4xi7Pr/qPoNNTyEKO8fyZuiDD jtNwqLsxIBqJB11um3ER2fK9B0MX18ODrMt1y2UrVFkFk0A4zaiurAaRHzX9IudAoiqegESM2qG ntZjpcHbyp0uz0K8XVp5Fwh4FpBMRJOFXPiXkpyYyEfEk5razS2HnUAc7GIk4f5SnOjqNUbW0Le 9Suk4KCDekF2cowDl32YC8b2zqsEYpN0Yz33QNL4gbPAlOcPL7mXLHIHCX3OVJqW5HBgxbxGthV LDFUv7CIfzxyAyoyuAYvgSrG+tQU5IT3tSTje6FEfo+AYDNlxmPJSmbMlHe6o2qUJNIF0tUnZxf UIcjtHno7mz/0bs4EpA2cy6Zby+djTIO5BjSggU3hqZz+uPG06We9VKbgwsHfhjnCH+bax52Hdc s7dkBb8V2dBSB522z0+yDseawyOcoCi1PncnlglnPakGWR8NmAFGFlAstjNkJC6FCj78pxz+zBg wrpGsKf1cKzQWBo9olY1SVsDeugbJCunZ7IqXF0Nw== X-Received: by 2002:adf:ec82:0:b0:48d:f4b2:b29d with SMTP id ffacd0b85a97d-48e07fb62fdmr19664337f8f.53.1792530933202; Tue, 20 Oct 2026 14:15:33 -0700 (PDT) From: Manuele Conti To: qemu-devel@nongnu.org Cc: alistair@alistair23.me, peter.maydell@linaro.org, qemu-arm@nongnu.org, Manuele Conti Subject: [PATCH] hw/adc/stm32f2xx_adc: fix left-aligned conversion results Date: Tue, 20 Oct 2026 23:15:29 +0200 Message-ID: <20261020211529.99689-1-conti.manuele@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=conti.manuele@gmail.com; helo=mail-wr1-x42c.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FORGED_GMAIL_RCVD=1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 20 Oct 2026 17:19:44 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1792531217792158500 Content-Type: text/plain; charset="utf-8" Left-aligned regular conversion results must occupy bits [15:4], [15:6], or [15:8] for 12-, 10-, or 8-bit resolution respectively. At 6-bit resolution the result is aligned within a byte, in bits [7:2]. The current single-bit shift and 0xFFF0 mask both misalign the result and discard significant sample bits. Select the shift according to RES and keep the existing right-aligned sample generation unchanged. Signed-off-by: Manuele Conti --- hw/adc/stm32f2xx_adc.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/adc/stm32f2xx_adc.c b/hw/adc/stm32f2xx_adc.c index 50a04a0..e2dfc83 100644 --- a/hw/adc/stm32f2xx_adc.c +++ b/hw/adc/stm32f2xx_adc.c @@ -69,10 +69,12 @@ static void stm32f2xx_adc_reset(DeviceState *dev) =20 static uint32_t stm32f2xx_adc_generate_value(STM32F2XXADCState *s) { + unsigned resolution =3D (s->adc_cr1 & ADC_CR1_RES) >> 24; + /* Attempts to fake some ADC values */ s->adc_dr =3D s->adc_dr + 7; =20 - switch ((s->adc_cr1 & ADC_CR1_RES) >> 24) { + switch (resolution) { case 0: /* 12-bit */ s->adc_dr &=3D 0xFFF; @@ -91,7 +93,10 @@ static uint32_t stm32f2xx_adc_generate_value(STM32F2XXAD= CState *s) } =20 if (s->adc_cr2 & ADC_CR2_ALIGN) { - return (s->adc_dr << 1) & 0xFFF0; + /* 6-bit results are left-aligned within a byte. */ + unsigned shift =3D resolution =3D=3D 3 ? 2 : 4 + 2 * resolution; + + return s->adc_dr << shift; } else { return s->adc_dr; } --=20 2.41.0