From nobody Sat Oct 24 01:14:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1792332709; cv=none; d=zohomail.com; s=zohoarc; b=Ik0kjNa4C12a7jju2Dnk86huayuf4iv01OObJ5rzIVsIi5888TKL9Uz/0H10SbgsShAcaswW9urCJpcM3FZ8NkoQp/hG9y5q0a8Yl2oIFivlxU9vZyo0lyNTdzxlN5VF8ijgo/fPK3GKQEDBp4Bg5lCqrlHN5hnBjIRGjYOhQkk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792332709; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=K0UGJW5Rv06EbtkyisWOX7L9CvnlmTwxonH0Dbtr3Pk=; b=E3mV8LnFP+mVPiaVbCFpVHZxW4z4ZGXJdSRZ1PBGViQ0clEfVI4ypVSEwGHjw10yBUpWALFiAnmtR+8Ok+reataHZsKQqJgISQSP6JDCaWvm/Dj6q+zX+XpUUQAqhW4z90m893y7Ssk2t4S78PGWnrSr/l1lcHUPvcj8gws0Zu8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1792332709016879.6578048402887; Sun, 18 Oct 2026 07:11:49 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xIRam-0005lj-At; Sun, 18 Oct 2026 10:10:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xIRal-0005lS-0R for qemu-devel@nongnu.org; Sun, 18 Oct 2026 10:10:27 -0400 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1xIRah-0004z5-TY for qemu-devel@nongnu.org; Sun, 18 Oct 2026 10:10:25 -0400 Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-ccce6d9abfeso936858a12.1 for ; Sun, 18 Oct 2026 07:10:23 -0700 (PDT) Received: from dt-VM.localdomain ([101.204.150.66]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-89f57653ea9sm2949430b3a.32.2026.10.18.07.10.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Oct 2026 07:10:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792332622; x=1792937422; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=K0UGJW5Rv06EbtkyisWOX7L9CvnlmTwxonH0Dbtr3Pk=; b=EW0pKmN1iaL3/j3Eqrii+++eAn6tojJr5XbM50n3njxnv3vef0U7difU4DMUtSARAR KV9TB9AUmCiH3ttFisxm1Umo6o+3OcLcWM0ectYVwPiivMhlvH7GLbWyVJf36NX7ZhwA iG6YI0ZOxkoIPMCgAtTrWYSrtDz39d5n+3KqQVtWxYa6C9Yg/qsnS9Ofkyl12mq83o9u HQRSWwK8R5lKi8L0FF7sbhnVaC1U/XkcDE1RlWSLuXwSttn0Rk5TCHpATHCisG9oGxC+ 1KuXMqasM+vZRqIcWVj9uhQ8WurkcgKaPGLNjgiIcD90//ybXMRBwnJjZtV6Fy76NKgJ 98zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792332622; x=1792937422; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=K0UGJW5Rv06EbtkyisWOX7L9CvnlmTwxonH0Dbtr3Pk=; b=w3gOpRbPqzS6+c6nu5Flc6NuiIFGg2GCbtYerTAKWCEmdhCTU5P1Zn8so2dBdugIbU /7/OqWUryk8Xmsw1ZndaIW8JVAo2CJz0kAW1iytz/tLmqYvSgNZ+VH+65l4i4OhdX3I1 dz0pnbZjaxXrVmmuqJHSLMJQ6zlTmmFRVUgg4hyWK9UMPmTlFLEPY2kIkjaAmOc95ute rCeUew4jlqcuDZ98eBKhWOomyCI948vq3G8mddWYyyFoOqcsrO5eMYFziLoSqBFWuQlm mSlLXhSIoxJQuP+I3Lezbaa0LOKJfrL9S7jxsvqdNbapziO6gBN0Yd66weasgP+9BCgM LTNw== X-Gm-Message-State: AFq9FYJW/8VR1bHGL2gmdguftUIomvw3MGzTGzWe/HT2HUKduVKRyMb1 4aZfZKvNdrJIEbHQ0gxYGPTpWsg8P1PEHYXqnpSjIwvRMpCVBoBXB81baQ5mov1O X-Gm-Gg: AYBFou1lMn23c2oJRUf30cXEPKUPwMwYi6Jm3gMW3bdWBu04ZX6VvM8Hf2fbh7rtneW qEepl3j7qOUg6RgTzcPoBiCHHIeli0sPvKfPEO+rZ8h150i0eiXyysrwlqU0H1MyqqAb2ro4HrD Ns6QOlVt83g6DCefMjqZiWsgWSbg3MG+Uyo27zAzHCXhHTURq/B5dY/WH+ltgO1BcfCZ9zmpKw1 WSMhcoeFocrpzO0Jdvs4c8N9G4dE/hktNDfgj13B3gR0JZpDRgtrIJjsCn2+wq/ceC77LmC0Tt8 6dMfDdFEEdGD53W347JSnrtxBRmUCpVDf2qJZ1mCStFEkDXNUikZbF2DK8AtpQyLVtn59JHZS54 egQZECcw9tJTYrlWr8Xzlb8obIl/R6iZYLhaY6gvuicoN0O3uH4ctya7wIIXOjjbYha8ZGsAnzN 3chv9TolJDrYXeMQvNk5+rOI60OzMjS7N2U+ZZElb4Lr7zG+wdzhznhUhuEvh86MzOnlzXJAIEc VyGxMDGrUvNqD0usg== X-Received: by 2002:a05:6a21:4683:b0:3dd:a196:53a7 with SMTP id adf61e73a8af0-3e22614121emr3900144637.73.1792332622184; Sun, 18 Oct 2026 07:10:22 -0700 (PDT) From: Tao Ding X-Google-Original-From: Tao Ding To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, chao.liu@processmission.com, farosas@suse.de, lvivier@redhat.com, pbonzini@redhat.com, Alistair.Francis@wdc.com, Tao Ding , Alistair Francis Subject: [PATCH v3 1/5] hw/misc: fix calculating output address overflow in k230_decomp_gzip Date: Sun, 18 Oct 2026 22:10:02 +0800 Message-ID: <20261018141006.16398-2-dingtao0430@163.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261018141006.16398-1-dingtao0430@163.com> References: <20261018141006.16398-1-dingtao0430@163.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::52e; envelope-from=dingtaodtdt@gmail.com; helo=mail-pg1-x52e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1792332710076158500 Content-Type: text/plain; charset="utf-8" Use hwaddr for address calculations to avoid 32-bit overflow. Resolves: Coverity CID 1685515 Reported-by: Alistair Francis Reviewed-by: Alistair Francis Signed-off-by: Tao Ding --- hw/misc/k230_decomp_gzip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/k230_decomp_gzip.c b/hw/misc/k230_decomp_gzip.c index 0d8a3b2d2e..ac06cc1571 100644 --- a/hw/misc/k230_decomp_gzip.c +++ b/hw/misc/k230_decomp_gzip.c @@ -53,7 +53,7 @@ static bool k230_decomp_gzip_write_mem(K230DecompGzipStat= e *s, hwaddr addr, static hwaddr k230_decomp_gzip_output_addr(K230DecompGzipState *s) { return K230_DECOMP_GZIP_SRAM_OUT_BASE + - s->output.slot * K230_DECOMP_GZIP_BLOCK_SIZE + + (hwaddr) s->output.slot * K230_DECOMP_GZIP_BLOCK_SIZE + s->output.current_offset; } =20 --=20 2.43.0 From nobody Sat Oct 24 01:14:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1792332698; cv=none; d=zohomail.com; s=zohoarc; b=CVf2ROlBorv0UaQhMZGeD+QiDunyT5thqnxacVSXpF1l699IugSG948QYH7D65KtK1ceo0H3hhEpjHN6XHTLAddnvZNKCqNDQFvw07/qS7jIYcHNlrjZUHBvqUhtks4AxzPshKKArxoqAWNTVPzf/7vCXuOXw+Ac1FrXDLwfYOc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792332698; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=QJ2vmhNG/CjE3MDSpCuzv+6F5+re1f9SXvYAgJYl+7Y=; b=hthG1nR4oTI9bP4jNV8i9mhGfj9CeVAk3UBfIz94qLNZ5xpENrapqf89wgKHixM9D/lRzgTMUbAOYPvz8Dk53BGHq/2+K1XvAwU0xw4pmEWJ7HsJU79pJnaIZPQwZajP8+fKchIcnL/8ROH3DW8v7mi1yWiEMbAUjR44xfEHLLE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1792332698778496.7522769154508; Sun, 18 Oct 2026 07:11:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xIRar-0005nG-Ee; Sun, 18 Oct 2026 10:10:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xIRap-0005mY-6j for qemu-devel@nongnu.org; Sun, 18 Oct 2026 10:10:31 -0400 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1xIRam-0004zV-Na for qemu-devel@nongnu.org; Sun, 18 Oct 2026 10:10:30 -0400 Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-8a05b210703so222460b3a.0 for ; Sun, 18 Oct 2026 07:10:28 -0700 (PDT) Received: from dt-VM.localdomain ([101.204.150.66]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-89f57653ea9sm2949430b3a.32.2026.10.18.07.10.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Oct 2026 07:10:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792332627; x=1792937427; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QJ2vmhNG/CjE3MDSpCuzv+6F5+re1f9SXvYAgJYl+7Y=; b=J0Dq2QMg16mfIvb+KfdEgEGm5rHmhS0Md4pHomRIwprWY+DFtsqUO9mcUqogpiLBQn BO9aM9E96gOloGO9m9EdZdp6WX0raHZQRgP+rDoM25dm3+5uCENDIv95zYw9/AY+HYU6 T4goKhwZi0t9s6kF8sOK6K1AxkW/2kFLSkwGwJUimpsWoKt0h1yY7cODfeC9ZtR65rRV 1pR1umau/5VmlFkfU8tiGVhcMfNij+BD6GoAsg2OpPJIkcZrb6cArxjxwGnlN2M+jJTL N6dTBmoVhqZbdlkCrlYpiVyZ2C+BZ3kSbEgiWUiksf1V1k7WypNcoFTj2Uq/OhgNF8kT ioHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792332627; x=1792937427; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=QJ2vmhNG/CjE3MDSpCuzv+6F5+re1f9SXvYAgJYl+7Y=; b=kpePMTnGLrYmw6r4nEnb7KZMBLYFGL6lgztFxufI2a9V5Y6CfIIAFL0BuQEiAZjwR0 OikO9fPZLsKH74fenp5uQRTsmGfWI0XAEctZCjoyXA6mjkc6O77IlpK7fDbzrveyKLKc cXae7AlSY2NVTPdFD8iHpDOhaZr9p+AHQi0wIee532YJYPQ1FE9tfZkUMyrNGva23xG6 OCYRbkzp2rzvIEvod17aV2H41l0ZYUGj3DS5oPMn/RWYkhKDFqjMkmMG3YsGsWHS2XBc ChxGGE0VsdqOoFExREGjPUkF0c9IeA1WlPO4ZcoZpSwElRcM4FR7Ida1QNpUrNdue9JW 8hFg== X-Gm-Message-State: AFq9FYIlRuw5OHl4QK1/RZmYlHpPlZF6Bjbpx6bzzddrGfhMNKezPyOm zNL4FX1EUSIau3Ce3Y/cvcMSnCw9bW0P+D3oUMcVSNr5oXTi0ZYVAPKa5J936gk0 X-Gm-Gg: AYBFou3d3xrwn2zruB84ACxbRYmiFX3D6wEMf16dPYSGlw37AIvELYSgPBx9NdMEA62 e0FyN31/TxI7GoZpaWo4i0Xnla3q7VsZP5+OT9cBJVazYK2y/f+ztwhu+7nKL/pBeFfTqKxzvxs lZYrY2e5JvbX1KasrY5wcvWk1edX4P2hkrzF4NrzPZFXUkt0EZ/Quk+9ZUv7dpUu3WeDZk7leD6 lmJJEg70NLGWV4nkuAwz8hjbf917pwwTBtq3CanhKwU6EC1d1Noo3vGxOD9v7/Hbj+2KVjlTrNA OUXMZUw/woPOt7JX4NEQIm6oDKRy2bga3O8YHWfNPjPvt26KDaD6nrW/2X32cZYc+Y7qgIFdTfd 77ZAkZ2sGkkXcoNrq9Mp7gDNfPj2mpzPdZ6Khrb16zkL9M6yDjWSHLOYorD+xAapvCmzX+esks/ hIVUBnyVpfKDREICvmitROGg7q6uZFAuUqJrsli2eQEkDawcNOtqcyzLaODhcOewDlBR5EcKF9o KVAuBpF4GFcSWsy X-Received: by 2002:a05:6a00:4c99:b0:87c:b126:8e4d with SMTP id d2e1a72fcca58-8a04aa2a824mr3534421b3a.3.1792332626931; Sun, 18 Oct 2026 07:10:26 -0700 (PDT) From: Tao Ding X-Google-Original-From: Tao Ding To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, chao.liu@processmission.com, farosas@suse.de, lvivier@redhat.com, pbonzini@redhat.com, Alistair.Francis@wdc.com, Tao Ding , Alistair Francis Subject: [PATCH v3 2/5] hw/misc: fix calculating input address overflow in k230_decomp_gzip Date: Sun, 18 Oct 2026 22:10:03 +0800 Message-ID: <20261018141006.16398-3-dingtao0430@163.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261018141006.16398-1-dingtao0430@163.com> References: <20261018141006.16398-1-dingtao0430@163.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::432; envelope-from=dingtaodtdt@gmail.com; helo=mail-pf1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1792332699846158500 Content-Type: text/plain; charset="utf-8" Use hwaddr for address calculations to avoid 32-bit overflow. Resolves: Coverity CID 1685517 Reported-by: Alistair Francis Reviewed-by: Alistair Francis Signed-off-by: Tao Ding --- hw/misc/k230_decomp_gzip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/k230_decomp_gzip.c b/hw/misc/k230_decomp_gzip.c index ac06cc1571..da4dc6f954 100644 --- a/hw/misc/k230_decomp_gzip.c +++ b/hw/misc/k230_decomp_gzip.c @@ -59,7 +59,7 @@ static hwaddr k230_decomp_gzip_output_addr(K230DecompGzip= State *s) =20 static hwaddr k230_decomp_gzip_input_addr(K230DecompGzipState *s) { - return s->input.slot * K230_DECOMP_GZIP_BLOCK_SIZE + + return (hwaddr) s->input.slot * K230_DECOMP_GZIP_BLOCK_SIZE + K230_DECOMP_GZIP_SRAM_IN_BASE; } =20 --=20 2.43.0 From nobody Sat Oct 24 01:14:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1792332689; cv=none; d=zohomail.com; s=zohoarc; b=nypGNZNoSvA/7MRXMBiWuc63Pcf2aRP5Z4c/iJmUjIIuSASKy6bY3hKgHB2zaIALhhGb6nJBGa5S8H8q7bL2xYjxcR5kU4IBgB1DXP69O11bpopkJSwUjuo86Nf1kMvSaDOePnSD63JuoRU3uB07y9t4LBh4IwGfYHRiqeg/l/A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792332689; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=P6RinCIlj8umNB/ICCbnc+5KtiBXAHX73/C1WUV1Zkg=; b=HTthUfJ1rUT4oV4aG6wzZFJn/b3m1B1zWs559EYzUrpmva27Kwbrv7iUJOjVAH19f0ULIzuXU+WBeIo4F5hkeEpZrJ9PP1JKr442+2I2krWKChoJ1UZJk5i7NWnbZbID/ayQYYfxEmW8yWd5XFo1vsxtJJhvse4JF9Z7qo9GrDM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1792332689399113.43150548661663; Sun, 18 Oct 2026 07:11:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xIRaz-0005oM-S1; Sun, 18 Oct 2026 10:10:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xIRau-0005nX-80 for qemu-devel@nongnu.org; Sun, 18 Oct 2026 10:10:37 -0400 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1xIRaq-00050E-Pk for qemu-devel@nongnu.org; Sun, 18 Oct 2026 10:10:34 -0400 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-8a06454116eso120174b3a.1 for ; Sun, 18 Oct 2026 07:10:32 -0700 (PDT) Received: from dt-VM.localdomain ([101.204.150.66]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-89f57653ea9sm2949430b3a.32.2026.10.18.07.10.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Oct 2026 07:10:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792332631; x=1792937431; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=P6RinCIlj8umNB/ICCbnc+5KtiBXAHX73/C1WUV1Zkg=; b=LdoWo1LCMwZoKzLUAV6vEsl2kn+rXq1zjoY0FOI+LyqRswbOQbqlGQmZANW4qE8+lu pL6SLGNzN8fvzlUBrgeOeuWjg1YkqyMLHP1GpWACaHDEp2SGVlskrzvLMw89KgeQD+c8 CwvapPH1C/wmAcFUSJ5HzlmxF0fzHba48jT4HX/4kOmxrlhvEAJAfjuhmQaiCRVcppX4 UyQH5FYBtjw6VuA7OM4+rR0m90L0XU78/bOkdxh/QDIKSwSgZ6BmiOhE/wQZdK07Ihgn 3UAzejoBiuU2UkDcPTTpnFNN7kKz/xM/zbxd0f1NyPvkGeYNeDRGXjBWIfY64keX34in PaIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792332631; x=1792937431; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=P6RinCIlj8umNB/ICCbnc+5KtiBXAHX73/C1WUV1Zkg=; b=um5lICl419dHkk+1SO0fhBZm93KdDGlqu7tyXGruaIZ4bV6hGpIPQIPlaqgwOWbKN1 zL+Hc5UQhJX8TFIkMLlOPmZD8+dyKR1hv/gVaeM1AtqjSCYv8w1GoxjhvtNVccHNjzAp TWHaAhMrZNFoW0pcN16RAumbsf2b3g7gUb1RapBXhmo2cD6TZ5vlD0bZyGfcapju8Jav 7LsvpubKh99BjOFV/9yye8FjrD+v/saqoUAkbrB/rUTKH5FpxD4k5qUmI3XIBYenC5kC 7l7PMGLyW7Bj7kUirC8DUsZlZMul3H4VFIh+xgo5/QhJAkc3dW4inoaO0AAZ+a15hlud +6Yg== X-Gm-Message-State: AFq9FYL5JjS88FT9Ai/sebIz4if8uyiz9dxXuFgRjVmHg4WDnkrZ05bw IOCqEXiAk37mBvcWskonydrap1YMrq2wK+RtLO7AqQ1GRC39eBPGoVnszbM6o33J X-Gm-Gg: AYBFou2/woLToKNa5N/stOpmv3NZdhH2fURgV9aXUCycLGdKEXGCRGcXS6dotOTG0XN kQWTWHG0imNSA+ptW58b7rlxhm1rXCdLdgA9pPthY+bEFsVL7DgJnAEeBMHW9GvUK3NTGfkkOnM Pos5lN8WT1F/fkj65FFNC91kf83ZJb/BoLHdPgonuuA8mrrtWtj8m2Kih5YIdWUfrnvJQja0Nfg 5Rd9ldjbR5rRT478gTW+VKNPdUMq4rP8aWQoUBrNp3yiQVk3uUdEbqYRjb4jXCyxdMNk0xbop5T 8qAQCZT7b3Efp0EKeA/t8J6/t/a7GcPKgyy6pFGg2KJIr1swUEbYDmCirzyHpqzxgtB6UoDSsWQ wOGPrTweFv0z52ReW31K0jz2ZiwWoJnV9Q9lbIXFmP5Oi8H9NNaba87JFtmdb5IXg8A+rS/TWgj sfdSVhC/9bydoX3d3Lda/PluVfRol1dJD4Agl8nUyPUEneOVQbJ/4XAT2c7PJ/qR7VEug4uouEE iGn36bXZ33Mrj1r X-Received: by 2002:a05:6a00:348e:b0:89f:34c3:2031 with SMTP id d2e1a72fcca58-8a04cb24760mr3871978b3a.53.1792332631367; Sun, 18 Oct 2026 07:10:31 -0700 (PDT) From: Tao Ding X-Google-Original-From: Tao Ding To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, chao.liu@processmission.com, farosas@suse.de, lvivier@redhat.com, pbonzini@redhat.com, Alistair.Francis@wdc.com, Tao Ding , Alistair Francis Subject: [PATCH v3 3/5] hw/misc: use hwaddr for the k230_decomp_gzip input address Date: Sun, 18 Oct 2026 22:10:04 +0800 Message-ID: <20261018141006.16398-4-dingtao0430@163.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261018141006.16398-1-dingtao0430@163.com> References: <20261018141006.16398-1-dingtao0430@163.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42d; envelope-from=dingtaodtdt@gmail.com; helo=mail-pf1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1792332691882158500 Content-Type: text/plain; charset="utf-8" Use hwaddr for address calculations to avoid 32-bit overflow and address truncation. Reviewed-by: Alistair Francis Signed-off-by: Tao Ding --- hw/misc/k230_decomp_gzip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/k230_decomp_gzip.c b/hw/misc/k230_decomp_gzip.c index da4dc6f954..54303c0e7f 100644 --- a/hw/misc/k230_decomp_gzip.c +++ b/hw/misc/k230_decomp_gzip.c @@ -102,7 +102,7 @@ static void k230_decomp_gzip_finish(K230DecompGzipState= *s, bool crc_ok) } =20 static bool k230_decomp_gzip_load_input(K230DecompGzipState *s, - uint32_t addr, uint32_t size) + hwaddr addr, uint32_t size) { s->input.current_offset =3D 0; =20 --=20 2.43.0 From nobody Sat Oct 24 01:14:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1792332689; cv=none; d=zohomail.com; s=zohoarc; b=LZN5cSLV+LfVAYOu2e4ckWidJf4q+DlvRnZZYsgmNp5iiHlRn+DstopVv4S7f9TIKgIxb9GerZmYJSRzVkNI6QmQl+feGX2x0X2pZVZYFToBsNbJHEzgas5UUtEF6MUCfvDav5IINc/ZkIxpH46NNqXzQCgoRcnOuIV7lv3BlWQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792332689; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2Hj0eRrB32lGUpH16jwWWPrR4KRoNl92h2htBgfoO4s=; b=QIyM0Dqg05SyEs1/i6JAliA0E/rQ6lLTfgqHKN97THupthFYbR9j9XTYjfWLU1Kv3UsRB7JJN9P4XC1EljBGqKyFuKyMcaYazpEcmMB7VRIJkkyfLmqy/iD5tcypwC7mlERv0RXdfkAL0yIuKCRz++oaAriK5BuIDuAq4xfxxvk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 179233268952644.29958508975142; Sun, 18 Oct 2026 07:11:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xIRb1-0005pR-MV; Sun, 18 Oct 2026 10:10:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xIRaz-0005oB-K4 for qemu-devel@nongnu.org; Sun, 18 Oct 2026 10:10:41 -0400 Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1xIRav-00050g-0Z for qemu-devel@nongnu.org; Sun, 18 Oct 2026 10:10:39 -0400 Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-8a01cac8733so762966b3a.2 for ; Sun, 18 Oct 2026 07:10:36 -0700 (PDT) Received: from dt-VM.localdomain ([101.204.150.66]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-89f57653ea9sm2949430b3a.32.2026.10.18.07.10.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Oct 2026 07:10:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792332635; x=1792937435; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2Hj0eRrB32lGUpH16jwWWPrR4KRoNl92h2htBgfoO4s=; b=AZ8iuiOUc78dNjbNge+/eMTWjRmF6jYVANu3aLe88mcWEVm2bTYs20Ferk0yzRd9fA /LKSkL+9k0882+bsEh0KLEZDRXCmH0gy2I/qCQrUYW9V3VXhRuGT4CJ7dZYiNcVh7bch 2nH6NeJX1RGD1nwCMo3xk1E1w71k6b5m7xtUDSGBVtWqMunTRg879DezDBqh6QcA75xt GqpuS9w1yj/3qCB/UN0BQ4cTgXlmFhUZgqsMpxgezx1T91oF5nzjPmBId6N7YLu6FaMQ Ki78/Ti6Jm59o4NjikvmJHpmb6sjKdWx618RbPGK1swJbmo+jZXqVJ0jkeJTgESNK/Jl DKlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792332635; x=1792937435; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=2Hj0eRrB32lGUpH16jwWWPrR4KRoNl92h2htBgfoO4s=; b=KxarwLt2PqYqMwFaf/184zy4FA45gDOgE9Xfg6RR9fSLPC+GMJcBFIuKhEmK5MTVHQ gVGfyXi6vkIx3schqOb+SvGnQJ1QvyMZRT0iFdgIfrnW2djGF5mQ5IpkDM+JaJfnMrIb Ay5Fz1xfjhoQZV09lZQ9F+GEZh1DQ4y0O6apqXs6nxGz1HzEXdJir9iGbm8puKWi6pBL wk+xIEJ6G9klPQjhI/oQB4ZuOb1LAfrDfasGz2PEWxj9e3FFojg6CnjIBOqHRke2KudZ w2GQ4O0kd75n0qcQUAV4zi1o3WYy6U1T5IZXmgKGZhMlI8qGS2B2x7Uaij7s3G4sjMkm UEwA== X-Gm-Message-State: AFq9FYJ+wsijbx4QYCIyu2hYUCFwcqkiqoVQvyuCuygzyRgfeG5oEfPH vpx9ADkrYpEfj315+oZ9TRXoOhhvJfCWM4hzoy8a7sQii8CdYBsPWUBy1mXkozOF X-Gm-Gg: AYBFou3LjHHRlEBxbHJo9yVB7ZOoe3vlih9NsGFI/i45vqQNK96NYAFF1gVWJf0JTfE NRaFvpAp2zpue+orprLfB+FPvBQYyws0huoPSWq5qHkiRvX6fSUzxoCIAL//mBfeSRZwkdJyf9B /r46vBbkRhJBzu4KCcRYi/pPJOKZIqatSpsl2ngl5QL4Tl//t2hyit6aNloPf8mqE/Pz3XvyyK4 DiHDpERF0N1yp64fo/p0SG6p1EeGZ3ByAoH4Bf3FjIv76+izygCPwQvPOjmZeEMZgO43FQFRnRT yz0TTNAItQxuB206wPEH6B4k2H1tFat+dL3NmYnxGRb3+WKViVJJwKfeuzFutbnRZdiRjbY1gSH G5HQuRcj1h+F4Yc58SCJm0Njq8XTsSmmA7PMb5MZZxDmGmj9ysRzSWD/NtL6eieylfmET6aP/Ho dKmbiH16sLe+dzoDFJp/9SxkHizpy0maTE1rnSZlQ+6rQw127Ml3cG0LIMNmjwBRQX4iGwkwGPN Eux7btud79p5Dgn X-Received: by 2002:a05:6300:86:b0:3e0:e60f:2e5b with SMTP id adf61e73a8af0-3e226026bccmr3747606637.30.1792332635602; Sun, 18 Oct 2026 07:10:35 -0700 (PDT) From: Tao Ding X-Google-Original-From: Tao Ding To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, chao.liu@processmission.com, farosas@suse.de, lvivier@redhat.com, pbonzini@redhat.com, Alistair.Francis@wdc.com, Tao Ding , Alistair Francis Subject: [PATCH v3 4/5] qtest: fix k230_decomp_gzip test integer handling issues Date: Sun, 18 Oct 2026 22:10:05 +0800 Message-ID: <20261018141006.16398-5-dingtao0430@163.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261018141006.16398-1-dingtao0430@163.com> References: <20261018141006.16398-1-dingtao0430@163.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::430; envelope-from=dingtaodtdt@gmail.com; helo=mail-pf1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1792332691940158500 Content-Type: text/plain; charset="utf-8" Cast slot to hwaddr before multiplication to prevent 32-bit overflow when=20 calculating the SRAM input address.=20 Resolves: Coverity CID 1685516 Reported-by: Alistair Francis Reviewed-by: Alistair Francis Signed-off-by: Tao Ding --- tests/qtest/k230-decomp-gzip-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/k230-decomp-gzip-test.c b/tests/qtest/k230-decomp-= gzip-test.c index e80113fd28..249c8ae82c 100644 --- a/tests/qtest/k230-decomp-gzip-test.c +++ b/tests/qtest/k230-decomp-gzip-test.c @@ -46,7 +46,7 @@ static inline hwaddr k230_sram_addr(hwaddr off) static inline hwaddr k230_sram_input_addr(unsigned int slot) { return k230_sram_addr(K230_DECOMP_GZIP_SRAM_IN_BASE + - slot * K230_DECOMP_GZIP_BLOCK_SIZE); + (hwaddr) slot * K230_DECOMP_GZIP_BLOCK_SIZE); } =20 /* --=20 2.43.0 From nobody Sat Oct 24 01:14:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1792332708; cv=none; d=zohomail.com; s=zohoarc; b=JMkZnfI07/+jjHtb0mju7wVhRUhXiZzb+9hiSumSu+c+Vp6zE1sN0aFEBuXs4yLauaaip8KbBvfGRtO6X4BdRYncxaaDMHOBNjhCWTGZsk35k8nMTHxSkPdebk4DUMt9imAQEXiq37DqnhXVUARQlyMzQr/nB3DPym/FtYx3TB0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792332708; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=IWmaGYAhUbRIolbD7GEvcJTHQYZVhBb4kKhSSqPzT48=; b=lVaGf5swD6mg4/XyPcuz6f4mBqhVcfxmV/oCVlcvRpvUCcvz1TUa3Cj7OUILzA0/DohhgVndiJmORHM4wpXyTq9cTgXi6uo8ZROC73G3uO83iedZGLiUPv3mVC3sMzkU168c3oA+xrrmEs4rJeML/+JGnfgjPRbEU1DUIIcG+C0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1792332708040321.9183103562523; Sun, 18 Oct 2026 07:11:48 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xIRb2-0005pr-OJ; Sun, 18 Oct 2026 10:10:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xIRb1-0005pK-HG for qemu-devel@nongnu.org; Sun, 18 Oct 2026 10:10:43 -0400 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1xIRaz-000513-Cl for qemu-devel@nongnu.org; Sun, 18 Oct 2026 10:10:43 -0400 Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-8a05b210703so222532b3a.0 for ; Sun, 18 Oct 2026 07:10:40 -0700 (PDT) Received: from dt-VM.localdomain ([101.204.150.66]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-89f57653ea9sm2949430b3a.32.2026.10.18.07.10.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Oct 2026 07:10:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792332639; x=1792937439; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=IWmaGYAhUbRIolbD7GEvcJTHQYZVhBb4kKhSSqPzT48=; b=SNIC+QBnmXIHk5AWC0JtQ9NGVoZWUs1CJsiuagG1LT3Wx07qQFBnzYWPOpn9hk++wo 3ZJuVk5f/kdL+zfRCN15zhuN7iDg/j4LzjRttOnlF8OnYEChAxd58W/yMw48uk265Q6O 6cuyGqdsIYB+6EUYswfvpBgQ0fA8/iua6QJ/1MPKxy8NvvBG2fJMrp/kTjyXK7Ic0ucu faN8AHt7koyQcSBjg1zpPwkBaMCfn0GPZctaiW5Dj7H54+KcN+3wPChORDCGUt54obt0 zjQeM9AV1J/mJ33u1DK8ZmDzLoBuzDwfmXgXT/1X1FPaYzHGXxIeQXOkhFBAXrEx5swg ABVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792332639; x=1792937439; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=IWmaGYAhUbRIolbD7GEvcJTHQYZVhBb4kKhSSqPzT48=; b=MUenIAi/dSYdCV3UhPoobbYSLxG2SPvjVlUnqOsyiQ69uqDXvXOapXuKpyavkRihLT He5CIb2lLxkBDxE3LX9+FAY64xGdsL8aJ3R7xmCu5oTHFGr9DPV94Ws40iTXUPXT3cU5 f2QTE8rhCtG4xeuksanJBmbok9pDnT8FfsaEpoTvpHQEp7OAj+R1cL818G1s6DP7Uf/6 0y0CbUsYXBu33BTaPaZPAjRYg5PM4dED42/2T0RJwl9ObQwZ0j+BQbZ3kanDPMQlfFjl fn2tnlX4tv31aEfFDxdPkB3JIagIeWIf29gguEdEW8Lbrq56GLasUwMGuCmGQZuMw5X9 nK8g== X-Gm-Message-State: AFq9FYKDZl+2Iwz69osPgXe3puCZE3yzJ23r0qfZagySDeQ0TWuAZdQe PzhRxQrR2x58nIZd0mkiFu6jgurwIOiYDfcXdZxYYPMrqnX9gOABPBb7dsm0AwbH X-Gm-Gg: AYBFou1q9gDNbEhY2tck1Z5x8hsn7d3tRwjmevuj6hJCNF+FFtSGVO8dLVpOZOPuJ1W BOu2QjE7M9kxmacFarXKD8i801fzj3FVSwrtz/cZ/xYsQ9nNUW16AChj31fJHZou0nNG7+7wkjj eaXSB3ciMPt4rrUFZSWL1MUNkRWWNeAAoCllbQHPhziJQE8hTTI2RIbmQvpPoCeLRR3SKunca3g LF7jqkO8teZj1uzhijBBX+ufOT/PLN4Bi+OSvHPfUyQ0E813n/isit7VsM/IIbKhb/XnjFVJ7JD jWEf/krH7W0aDaTILwKEo40BoMwHVaPvwkZj7Lq8TLlEuZL5aBtkPJGa+APJc97o6F3IW2Zsb96 1UXzJ6cdg6DR/+4GmDOX1Cu3SCvVVCkbRlbCaU313w5flrSa6GKXUJh9tIVQ43dqCA9Rv2FrMTo M50268tq7N9t+p/lRJuVmC08muAMtdfXw5cXxwNqAt2tMJvtlozHILMYno+90GQp6VDGjNUWdtO knfjbY0gUhAmEEhVA== X-Received: by 2002:a05:6a20:c5aa:b0:3dd:a195:fa22 with SMTP id adf61e73a8af0-3e22606feebmr4232562637.71.1792332639458; Sun, 18 Oct 2026 07:10:39 -0700 (PDT) From: Tao Ding X-Google-Original-From: Tao Ding To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, chao.liu@processmission.com, farosas@suse.de, lvivier@redhat.com, pbonzini@redhat.com, Alistair.Francis@wdc.com, Tao Ding Subject: [PATCH v3 5/5] hw/dma: fix k230_gsdma integer handling issues Date: Sun, 18 Oct 2026 22:10:06 +0800 Message-ID: <20261018141006.16398-6-dingtao0430@163.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261018141006.16398-1-dingtao0430@163.com> References: <20261018141006.16398-1-dingtao0430@163.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42c; envelope-from=dingtaodtdt@gmail.com; helo=mail-pf1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1792332710070158500 Content-Type: text/plain; charset="utf-8" Separate global and channel register handling to prevent unsigned address u= nderflow=20 when calculating GSDMA channel offsets. Resolves: Coverity CID 1685514 Reported-by: Alistair Francis Signed-off-by: Tao Ding --- hw/dma/k230_gsdma.c | 84 ++++++++++++++++++++++----------------------- 1 file changed, 42 insertions(+), 42 deletions(-) diff --git a/hw/dma/k230_gsdma.c b/hw/dma/k230_gsdma.c index 7635cd19e8..bd6db9e64d 100644 --- a/hw/dma/k230_gsdma.c +++ b/hw/dma/k230_gsdma.c @@ -304,54 +304,54 @@ static uint64_t k230_gsdma_read(void *opaque, hwaddr = addr, unsigned int size) hwaddr ch_off; uint64_t ret =3D 0; =20 - switch (addr) { - case K230_GSDMA_DMA_CH_EN: - ret =3D s->dma_ch_en; - break; - case K230_GSDMA_DMA_INT_MASK: - ret =3D s->dma_int_mask; - break; - case K230_GSDMA_DMA_INT_STAT: - ret =3D s->dma_int_stat; - break; - case K230_GSDMA_DMA_CFG: - ret =3D s->dma_cfg; - break; - case K230_GSDMA_DMA_WEIGHT: - ret =3D s->dma_weight; - break; - default: - if (addr < K230_GSDMA_CH_BASE) { - qemu_log_mask(LOG_GUEST_ERROR, - "%s: not implement gdma at offset 0x%" HWADDR_PRIx - "\n", __func__, addr); - } - break; - } - - ch =3D (addr - K230_GSDMA_CH_BASE) / K230_GSDMA_CH_STRIDE; - ch_off =3D (addr - K230_GSDMA_CH_BASE) % K230_GSDMA_CH_STRIDE; - if (ch < K230_GSDMA_NUM_SDMA_CHANNELS) { - switch (ch_off) { - case K230_GSDMA_CH_CTL: - break; - case K230_GSDMA_CH_STATUS: - ret =3D s->channels[ch].status; + if (addr < K230_GSDMA_CH_BASE) { + switch (addr) { + case K230_GSDMA_DMA_CH_EN: + ret =3D s->dma_ch_en; break; - case K230_GSDMA_CH_CFG: - ret =3D s->channels[ch].cfg; + case K230_GSDMA_DMA_INT_MASK: + ret =3D s->dma_int_mask; break; - case K230_GSDMA_CH_USR_DATA: - ret =3D s->channels[ch].usr_data; + case K230_GSDMA_DMA_INT_STAT: + ret =3D s->dma_int_stat; break; - case K230_GSDMA_CH_LLT_SADDR: - ret =3D s->channels[ch].llt_saddr; + case K230_GSDMA_DMA_CFG: + ret =3D s->dma_cfg; break; - case K230_GSDMA_CH_CURRENT_LLT: - ret =3D s->channels[ch].current_llt; + case K230_GSDMA_DMA_WEIGHT: + ret =3D s->dma_weight; break; default: - break; + qemu_log_mask(LOG_GUEST_ERROR, + "%s: not implement gdma at offset 0x%" HWADDR_PRIx + "\n", __func__, addr); + return ret; + } + } else { + ch =3D (addr - K230_GSDMA_CH_BASE) / K230_GSDMA_CH_STRIDE; + ch_off =3D (addr - K230_GSDMA_CH_BASE) % K230_GSDMA_CH_STRIDE; + if (ch < K230_GSDMA_NUM_SDMA_CHANNELS) { + switch (ch_off) { + case K230_GSDMA_CH_CTL: + break; + case K230_GSDMA_CH_STATUS: + ret =3D s->channels[ch].status; + break; + case K230_GSDMA_CH_CFG: + ret =3D s->channels[ch].cfg; + break; + case K230_GSDMA_CH_USR_DATA: + ret =3D s->channels[ch].usr_data; + break; + case K230_GSDMA_CH_LLT_SADDR: + ret =3D s->channels[ch].llt_saddr; + break; + case K230_GSDMA_CH_CURRENT_LLT: + ret =3D s->channels[ch].current_llt; + break; + default: + break; + } } } =20 --=20 2.43.0