From nobody Fri Oct 23 14:31:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1792160472; cv=pass; d=zohomail.com; s=zohoarc; b=mbvV6JNldY3/5oOk0EDbuSCSfL/93CJXg/VrwVbORQJc44PyU9tFAqSw2tWUgY6+Cpy+A5ct+g9LIGktTCcoXWvruGBAjOYWnAuO9CXWljWQvhNxRKa7b4V5YhJlAFBTMIBKWnzKvelxIzcjs8UVrHfHKRhcKT4zadQRfPHFKhw= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792160472; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=aNlUrMr9q1rOFXLFDeaeQlVWwE1CMuX+2uDxxeomGuY=; b=FJ/YlgNebadqZtGs4wme197uNM3YfGMA+zIXCNKGoZTozs1bS25MjtVzEdlQvaeAOx4mEu4b42rLuzrG+SFD6w5sFDdmVKP65uotnTVQFLrAm40NPxAvkat84dTnHinTjwHgDZkhqcwPHrQZeYpp7NQR3xC2iUL1s1eDZn0y+xc= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1792160472562924.7532022118637; Fri, 16 Oct 2026 07:21:12 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1451967.1666800 (Exim 4.92) (envelope-from ) id 1xHinn-0008De-Td; Fri, 16 Oct 2026 14:20:55 +0000 Received: by outflank-mailman (output) from mailman id 1451967.1666800; Fri, 16 Oct 2026 14:20:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHinn-0008DE-Nm; Fri, 16 Oct 2026 14:20:55 +0000 Received: by outflank-mailman (input) for mailman id 1451967; Fri, 16 Oct 2026 14:20:54 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHinl-0008AF-Qf for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 14:20:54 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1xHinl-001AYp-7Q for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 16:20:53 +0200 Received: from [10.42.69.9] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6ad23282-bab6-0a2a0a5309dd-0a2a4509d31a-48 for ; Fri, 16 Oct 2026 16:20:52 +0200 Received: from [148.163.151.68] (helo=mx0a-002c1b01.pphosted.com) by tlsNG-bad1c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6ad232c3-be1a-0a2a45090019-94a39744248c-3 for ; Fri, 16 Oct 2026 16:20:52 +0200 Received: from pps.filterd (m0127839.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69GE5bUg3246539; Fri, 16 Oct 2026 07:20:41 -0700 Received: from byapr05cu005.outbound.protection.outlook.com (mail-westusazon11020087.outbound.protection.outlook.com [52.101.85.87]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4haxj93881-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 16 Oct 2026 07:20:41 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BL0PR02MB6547.namprd02.prod.outlook.com (2603:10b6:208:1c8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.23; Fri, 16 Oct 2026 14:20:40 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%4]) with mapi id 15.21.0522.016; Fri, 16 Oct 2026 14:20:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=aNlUrMr9q1rOFXLFDeaeQlVWwE1CMuX+2uDxxeomG uY=; b=cspCwhjaLFqhz6/xxAimuMhU2DquKw5pvWid1+BKnVWsw58+DSBeHl4bW f5wIxDifGU/kYcwXZ/aPHLdK86eeEh13ZU8XqmAusGUgj9V6mReattEZDDHOVrTL ryqzsVQAOOsiuB+yy0DwttdhgjBWevLFVQckbAstW5WN17sKXjzUzSqBf/Ky6xCE FUtu9fPqPvzJCF5viImex+dGyXTjxox1SJKWxm47tROSbdMZsZ15ROMq0UjPjpyP zChPV/ZTR3RklhcJcbDoYwpaAjD3DyJQW5ETYzvE9SWm6095w8ntrjApfVcKhb6t Cqz7d0+mfgRBP/uXNILIc6sz682wQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MKg9riRze/e1HBrgSUtIFXd9PGPb0fVZoy9ddQAVa1mgWnAlRmwLL169NjwpVHAzm6TiI038ew+vPlFYIbzpkX3nEZq05ebMCU9phQfM59lUD2PGPB+mR+ugsPPxw6v7TlXqLMt0+bbeEq5JhAI+xU4Oh6RGsNVNkiXGUxqP/9c7w5Aq06G6gIk37farIy3PU9hGWriUMbJFsn8RitycdSIzlsuPuP/ijRyA1DP1xqPthLSh1+n8720fxvuNfdoKzp8nMJbZOzo5hnehK/mrBXEDn0mtxF/ZVu3M0HEXOCv2N2NdPJC0f+rZ2V3m1Ersdu7FLdbIjdRzvK5HRbXr9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aNlUrMr9q1rOFXLFDeaeQlVWwE1CMuX+2uDxxeomGuY=; b=pl3RX1U4NzXPjPMqGZ6CPUBMMU4mRfiZuSYrdBxZ7FCMe1CNi2XGTk8NcL7iNh7XRgeBIkyQ3+2gton24Xn/c4L5GQc/cmaxnCHSD/pgKiAR9l+MoMmbV0YcYl97D0j5Q4bHxqiXtReBNSRbXW+SqJCovBDTGoJD4aG2ERcFwpXuTqw/o7A1S15d4kvGck9vub2moqqILYALFE+8dPXV4G/vE/vlc1u6WJR9W7IolnQyBXtYSlAYbA3j1lb5/047Mt0layQGxxqO0A07FAncPOQi3LKiz8AMxB/LxDibT02b2VTGOq0gV+Pp45hFuf2YGglClDd3SZmkyD/d4+g7Ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aNlUrMr9q1rOFXLFDeaeQlVWwE1CMuX+2uDxxeomGuY=; b=tZqiALdlKl1PYPpl8L0SncVWel9SZdUjyf23hU02lwuAokvoENsas1UkdfZAXtFDl+BsFWwfsH5amWw/g1VrBiT+ZTh0nlzO9EYL8gu5OhcAQ7TVu7nwhcCagLPskTs8UcYKNSHmGGCidHaiuYxAlzx86JdhlVum4aQnhUl3egX3Lw5Tf32OyoWtWzGHI9so1CvK4mdsmQ5yGC0sNZ/ckIiPro24vE8xSg/+dv5ECZP1fXQlFocvb6qZYep/gqi/pwknNPmdAkbPBxBqKpvZTgYQjxvPOtRY3pjNH7UGheG6CfMhtiK1kk9HRBdnB3QaEtPM2XDP7hkSR7bRW59pOA== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nutanix.com; From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH v2 01/27] i8259_internal.h: rename PIC_COMMON to I8259_COMMON Date: Fri, 16 Oct 2026 15:19:07 +0100 Message-ID: <20261016142031.1204281-2-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016142031.1204281-1-mark.caveayland@nutanix.com> References: <20261016142031.1204281-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR03CA0013.namprd03.prod.outlook.com (2603:10b6:a03:33a::18) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BL0PR02MB6547:EE_ X-MS-Office365-Filtering-Correlation-Id: 1e2b74c7-6b7b-4797-8765-08df2b90a7a5 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|1800799024|366016|22082099003|10067099003|18002099003|261009223027099003|56012099006; X-Microsoft-Antispam-Message-Info: vfuCGe7BHX2GPWG/Ox6careXF/FNvKLZreqbXiJeILS74sDTj77U3wTgJ4P6pi1uq/R94d2xJl2PM/BhtPxRR4DT4T9vBqWV4BrUNaPH+4nVkyDX/Rxnh4FPBrfcPWT3J1HSo2IlygixRC2Am2rbEEPvL44mhKOjoM8gOLPpbDVM9MN9kUzCos3afyybF2oPfJMvJF2h7eRFdUyz/jPIGkqbMs84Dyh8GOiIBCMqAy5/ZFDTPnKbT+jX4x020FNyIrPmfuaCGr4QJTDJpaOPcWpA+rtlD5AHcbWB7VNXPsApBGDxXpjqZF9lYidSBuKXlPGK+eHf+KIsz+hJLTsLgz0pqxF4XhWwCznYsVOYk2VFhEgKFqwRq5QZh1tc8gebShU5E4+o4qb+X5JaB34uWtf3MOLj5fFtJISh4ojKbnl4papmJXNmVVosJnZueUJuZv6fBf0rk4V+f0KRppZfyKw5G2vtQMIpDhAW0boWZqrj9mtTp2mVSwIx1UkINPAvcsAsdsLrmPx5KV385Ud8YhYIFQ54S1HKrxsVyyiusRKI/rraATky3RUufWS61HHUkjtih3/kjPea7E7rf1LETxj42d6EYvKQMqIbYPq7jrT0lAB1pjOQDbv5PQi6tZuPe0v2WojFQ3MEMWuZTaanrxFdZgFJh7i2TCTDkT87BsA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(376014)(1800799024)(366016)(22082099003)(10067099003)(18002099003)(261009223027099003)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5ZBg7NQxZFKeX/f+MimcRRmKqVXAxHCrK8eslK7WdXYSIMKTNXfIxBr+B2XG?= =?us-ascii?Q?4G+hA/0SlKxBqfBo4c6ufLPwzWjHU50CUSPbFh3bAT0pAB/DbrKgQqL9Y3mZ?= =?us-ascii?Q?GPkbhgPcCig0ClFLPR7qwmnQpptkIdRcwP7C78+Lwa994wuUjiXoK/KwVqGX?= =?us-ascii?Q?5DCrfLAzNXhUa9OfmFInOSrbxzVQEqBF87kZYdzkUpBAj4GaxoHMg59b4Dzu?= =?us-ascii?Q?0jxzW/pv/nVmzkHax/MVoHYcTEQ21G+uWSxNZRkxwqqLwTGfObX9/nFSWywb?= =?us-ascii?Q?pf6Hv7zII4KX2KaFXN9M5PBKdFoNANun9ZJHDNtEi++eahEeGStBdKEL0HvP?= =?us-ascii?Q?5ZL+Oo1HZEgf5ENc60Xt1FB7gu6zu9jv20bezwv+V4Y8M6gq/mJE9zMtzlXj?= =?us-ascii?Q?UjFeL7iIG1c0JQSqwG0OIpTi1yQfC7barIQP6FkP5r5gvh9N/VKOUVEzvnVa?= =?us-ascii?Q?lxuOve8y2S75EocVdd2wpLYNwRfrMv1nTbuLJ1fubFiUTagJR/9c/S7e0qUS?= =?us-ascii?Q?gs6Ddpk8WF0Pi9eB+o2DyfojipN7TfINFfqZjYNKkLgiEebs6MdYxdhYl8oh?= =?us-ascii?Q?ExFfFEMKFmrvSd5xf2sUp4kKYSqHhsk4cfNsNerd66o2167WzNzwqnGAGBtu?= =?us-ascii?Q?HuL7mr9FEbOBDDOYRq7VbtSuwb4V/jZHw1qVGxndsyc/mssG6P5iL0lamse4?= =?us-ascii?Q?KRYiXC1TxmsNX1zu4F03I8Rjh390ALfvAXLG+g9Ss4LvyhGr53eMu3GP1act?= =?us-ascii?Q?2ukmHOAW1heQRtbj/2/STNKLDsbIc/kYkGETwVlGNmUuFxDiZimn6wJjs999?= =?us-ascii?Q?br08/9bOA1H0pTrTAjHP5pzT0FPh28BVWlx4tYJKzceaEenG1eA0RAXmhEB6?= =?us-ascii?Q?aQFrkMxTu1ayfH2L0MxFXBAJcAEXV3owcGQNpOkBvxH0KmHu8dGWKP8fT6uP?= =?us-ascii?Q?XuI90HRX32VBq9HZrOEBA+TP+cIuijHak72kt9jUpBtNX5azeOMRdTEajgid?= =?us-ascii?Q?YNA+9LNL4tg3qNk0oM/3ney0ctGm+tcLUalXB8XRXeAFxyCNmApZOk6y4+xE?= =?us-ascii?Q?omBTmBwjgiia+vWLd0FN9+mcAvcHEnfpxiHL+MqNwUjmTXivZGOcy0LrS0VT?= =?us-ascii?Q?N8F3hEo/yyNscnL5DKU/wWfekFFXpEulQCGXfSWuFfViSNPIWgwAF2oW8WLM?= =?us-ascii?Q?T1u6pWvhXWEnwSNX2E0caNUCI0izPpfIjJhaUgQmqVfgVVLL0mAGsUAzxRtV?= =?us-ascii?Q?YvyGLnXTxMFGSjmH07O/0ajcoO51hNjWtVG+SUnxOcFdN3eCPqVekscj260E?= =?us-ascii?Q?UxuMr41FkV5FDrBHhWo+alMGG/C95FAlJpuEDsxkvQLrMu/YJmvArsD4geUG?= =?us-ascii?Q?y2pE85Y0x2OPs6Ir8hIxkAPhPRzci5euzbVtMX1BkrLp+i8xLTrxGXyeiJN4?= =?us-ascii?Q?gK9iXHZNPDamwEsd+pxu0tO9O75Mz+kJ59z5hpEiZr4XgGg4w/v5ZiHZs7fO?= =?us-ascii?Q?yROGjh7rKfJunNCYGrYllLgEb4iqg9VJODOfXdsSWKW0Ys1Cn9pPC9uo65zr?= =?us-ascii?Q?TkLMtlLC8Yx4/1i7mJCEMvWXpTTpKvP+6cxP/IV8m0zDq2RVNVCjr39eZLHo?= =?us-ascii?Q?aFCv2cJXpO/pc9ffBO8aRwqWNYJ9iBCwdwbJ4FEyXdghaukH7gcNMVz066ax?= =?us-ascii?Q?RqzxPEhuB7novliBiDKQhD/U57Bt1orOj2TnnM+QBj6kCSuZk5uHwW3xlmsn?= =?us-ascii?Q?M9c08PHhwZ47/O9nRRtJU2aZxUb1WuY=3D?= X-Exchange-RoutingPolicyChecked: WSG3TYjVdEmmWTJ4d+MgH4+Z41dH2oYJW2YCZgJCmMpoDJke9mv7orU4XaEWvkDnlK0jx1biO50Az1FC2qgjy8eDJWu/Xbp6H6dKdB1eNT5NZ+NLpCTK4MIqkq+fGkT/NGU18xkMcgfM6gob+8aocNiyaiU5ENnLOgN3bWihs3VyR1qTOQurqI6T5UF5YIptw7KwIfEjGI10I6qjACQoj6E+TbVj/9zyLKtV86AwSewBQLQz5qQM2NQpvzvnZTnzywlplYHIyZ2NgeK8QOf5z1r+c1S8ke2vTnfOmlp9/GWBjxzTBY6hotTZs0uTzxhwdGsU+WNba0/Mc5bIBbDWLg== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e2b74c7-6b7b-4797-8765-08df2b90a7a5 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 14:20:40.1628 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 87vnX4P5E9ZHpkBOg/bt9LTvqWW1r6NJY7y4RDFz0MuogB4ecP5XBwmLcVM7GlyY243LZhGyRo3o1996wezQoE2fsdA00qAufLLpXez3VJU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR02MB6547 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfXz14ILCBC0BDl QtqMrpaRK8JlXty0pi9Of2Eud92rUobb2RruQEe+3L3h7vmiWojRv89zxaJsXEpeVahhUQfk289 zSI28DK0k15rdk3q/HbfyqjN1djBgO4= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX8SxS9mCvK/FW hwBm1yZV38vTJR1xfG8g5hC2T9j+FIwvfkvUfFDH9KpZ6pdEEMpgcQamlp2x7e6IL2nTZnYshLk AdDjT+V77BvgTKC5Gk5yXEsgu4s/iDBLjh3+CZJbDDujeTduhxb2JC9aXnMutcMOhhgdkTnbFWr OgBsdjRaIP95TFJ/cnzf5HE8Eti3sl1ISCbWL0MvRftomBfaf0+eVZmLETSC5CDzLeJ/tHf5hEB IaBzPyvVvOJ4sgqoBdctqGUoJ0ZoKsDqqY14R/yT/UZCuwyOHwy2kVLIJZhtCgGG3DHUp2lli3g ht2a6/aMdrvdcMw4UsaHPltdRgAdgcQfsLuHfvt+Olrcq+aa9HHTq5tOeLzksH1EBaciJFpvTXI iYQhgbVjyfDoH5uY8drlAFtQp58Hnay6f8hNORWWywJvHviRBw+nKUgB4ydHYe8GeWFQZKrnjiG TVe09CMEoxhTzefhdUA== X-Proofpoint-ORIG-GUID: -MtB3VpxVJhtokg3paSY1HZSGp3V410e X-Authority-Analysis: v=2.4 cv=ItOL47/g c=1 sm=1 tr=0 ts=6ad232b9 cx=c_pps a=R61xy7Sxgg6fOHg0EL+J9A==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=660iZSQnnn4A:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=y4UcunY2MAxhM4LwGdWI:22 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=XF9Y1ugsmyLceZbb4BIA:9 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: -MtB3VpxVJhtokg3paSY1HZSGp3V410e X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-16_02,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-bad1c0/1792160452-BC8C9034-4AA43388/0/0 X-purgate-type: clean X-purgate-size: 6643 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1792160473299158500 Content-Type: text/plain; charset="utf-8" This is to emphasise that child types of PIC_COMMON are all instances of an an 8259 PIC. Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell --- include/hw/isa/i8259_internal.h | 4 ++-- hw/i386/kvm/i8259.c | 8 ++++---- hw/intc/i8259.c | 10 +++++----- hw/intc/i8259_common.c | 14 +++++++------- 4 files changed, 18 insertions(+), 18 deletions(-) diff --git a/include/hw/isa/i8259_internal.h b/include/hw/isa/i8259_interna= l.h index f9dcc4163e..54dc9036cf 100644 --- a/include/hw/isa/i8259_internal.h +++ b/include/hw/isa/i8259_internal.h @@ -31,8 +31,8 @@ #include "qom/object.h" =20 =20 -#define TYPE_PIC_COMMON "pic-common" -OBJECT_DECLARE_TYPE(PICCommonState, PICCommonClass, PIC_COMMON) +#define TYPE_I8259_COMMON "pic-common" +OBJECT_DECLARE_TYPE(PICCommonState, PICCommonClass, I8259_COMMON) =20 struct PICCommonClass { DeviceClass parent_class; diff --git a/hw/i386/kvm/i8259.c b/hw/i386/kvm/i8259.c index 66f37e1303..14029783e5 100644 --- a/hw/i386/kvm/i8259.c +++ b/hw/i386/kvm/i8259.c @@ -103,7 +103,7 @@ static void kvm_pic_put(PICCommonState *s) =20 static void kvm_pic_reset(DeviceState *dev) { - PICCommonState *s =3D PIC_COMMON(dev); + PICCommonState *s =3D I8259_COMMON(dev); =20 s->elcr =3D 0; pic_reset_common(s); @@ -122,7 +122,7 @@ static void kvm_pic_set_irq(void *opaque, int irq, int = level) =20 static void kvm_pic_realize(DeviceState *dev, Error **errp) { - PICCommonState *s =3D PIC_COMMON(dev); + PICCommonState *s =3D I8259_COMMON(dev); KVMPICClass *kpc =3D KVM_PIC_GET_CLASS(dev); =20 memory_region_init_io(&s->base_io, OBJECT(dev), NULL, NULL, "kvm-pic",= 2); @@ -142,7 +142,7 @@ qemu_irq *kvm_i8259_init(ISABus *bus) static void kvm_i8259_class_init(ObjectClass *klass, const void *data) { KVMPICClass *kpc =3D KVM_PIC_CLASS(klass); - PICCommonClass *k =3D PIC_COMMON_CLASS(klass); + PICCommonClass *k =3D I8259_COMMON_CLASS(klass); DeviceClass *dc =3D DEVICE_CLASS(klass); =20 device_class_set_legacy_reset(dc, kvm_pic_reset); @@ -153,7 +153,7 @@ static void kvm_i8259_class_init(ObjectClass *klass, co= nst void *data) =20 static const TypeInfo kvm_i8259_info =3D { .name =3D TYPE_KVM_I8259, - .parent =3D TYPE_PIC_COMMON, + .parent =3D TYPE_I8259_COMMON, .instance_size =3D sizeof(PICCommonState), .class_init =3D kvm_i8259_class_init, .class_size =3D sizeof(KVMPICClass), diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index 8f2aa1f0fb..52e24d333e 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -218,7 +218,7 @@ static void pic_init_reset(PICCommonState *s) =20 static void pic_reset(DeviceState *dev) { - PICCommonState *s =3D PIC_COMMON(dev); + PICCommonState *s =3D I8259_COMMON(dev); =20 s->elcr =3D 0; s->ltim =3D 0; @@ -387,7 +387,7 @@ static const MemoryRegionOps pic_elcr_ioport_ops =3D { =20 static void pic_realize(DeviceState *dev, Error **errp) { - PICCommonState *s =3D PIC_COMMON(dev); + PICCommonState *s =3D I8259_COMMON(dev); PICClass *pc =3D PIC_GET_CLASS(dev); =20 memory_region_init_io(&s->base_io, OBJECT(s), &pic_base_ioport_ops, s, @@ -418,7 +418,7 @@ qemu_irq *i8259_init(ISABus *bus, qemu_irq parent_irq_i= n) irq_set[i] =3D qdev_get_gpio_in(dev, i); } =20 - isa_pic =3D PIC_COMMON(dev); + isa_pic =3D I8259_COMMON(dev); =20 isadev =3D i8259_init_chip(TYPE_I8259, bus, false); dev =3D DEVICE(isadev); @@ -428,7 +428,7 @@ qemu_irq *i8259_init(ISABus *bus, qemu_irq parent_irq_i= n) irq_set[i + 8] =3D qdev_get_gpio_in(dev, i); } =20 - slave_pic =3D PIC_COMMON(dev); + slave_pic =3D I8259_COMMON(dev); =20 return irq_set; } @@ -445,7 +445,7 @@ static void i8259_class_init(ObjectClass *klass, const = void *data) static const TypeInfo i8259_info =3D { .name =3D TYPE_I8259, .instance_size =3D sizeof(PICCommonState), - .parent =3D TYPE_PIC_COMMON, + .parent =3D TYPE_I8259_COMMON, .class_init =3D i8259_class_init, .class_size =3D sizeof(PICClass), }; diff --git a/hw/intc/i8259_common.c b/hw/intc/i8259_common.c index 8ceb5841b9..e2f997e161 100644 --- a/hw/intc/i8259_common.c +++ b/hw/intc/i8259_common.c @@ -56,7 +56,7 @@ void pic_reset_common(PICCommonState *s) static int pic_dispatch_pre_save(void *opaque) { PICCommonState *s =3D opaque; - PICCommonClass *info =3D PIC_COMMON_GET_CLASS(s); + PICCommonClass *info =3D I8259_COMMON_GET_CLASS(s); =20 if (info->pre_save) { info->pre_save(s); @@ -68,7 +68,7 @@ static int pic_dispatch_pre_save(void *opaque) static int pic_dispatch_post_load(void *opaque, int version_id) { PICCommonState *s =3D opaque; - PICCommonClass *info =3D PIC_COMMON_GET_CLASS(s); + PICCommonClass *info =3D I8259_COMMON_GET_CLASS(s); =20 if (info->post_load) { info->post_load(s); @@ -78,7 +78,7 @@ static int pic_dispatch_post_load(void *opaque, int versi= on_id) =20 static void pic_common_realize(DeviceState *dev, Error **errp) { - PICCommonState *s =3D PIC_COMMON(dev); + PICCommonState *s =3D I8259_COMMON(dev); ISADevice *isa =3D ISA_DEVICE(dev); =20 isa_register_ioport(isa, &s->base_io, s->iobase); @@ -118,7 +118,7 @@ void pic_stat_update_irq(int irq, int level) static bool pic_get_statistics(InterruptStatsProvider *obj, uint64_t **irq_counts, unsigned int *nb_irq= s) { - PICCommonState *s =3D PIC_COMMON(obj); + PICCommonState *s =3D I8259_COMMON(obj); =20 if (s->master) { *irq_counts =3D irq_count; @@ -133,7 +133,7 @@ static bool pic_get_statistics(InterruptStatsProvider *= obj, =20 static void pic_print_info(InterruptStatsProvider *obj, GString *buf) { - PICCommonState *s =3D PIC_COMMON(obj); + PICCommonState *s =3D I8259_COMMON(obj); =20 pic_dispatch_pre_save(s); g_string_append_printf(buf, "pic%d: irr=3D%02x imr=3D%02x isr=3D%02x h= prio=3D%d " @@ -146,7 +146,7 @@ static void pic_print_info(InterruptStatsProvider *obj,= GString *buf) =20 static bool ltim_state_needed(void *opaque) { - PICCommonState *s =3D PIC_COMMON(opaque); + PICCommonState *s =3D I8259_COMMON(opaque); =20 return !!s->ltim; } @@ -220,7 +220,7 @@ static void pic_common_class_init(ObjectClass *klass, c= onst void *data) } =20 static const TypeInfo pic_common_type =3D { - .name =3D TYPE_PIC_COMMON, + .name =3D TYPE_I8259_COMMON, .parent =3D TYPE_ISA_DEVICE, .instance_size =3D sizeof(PICCommonState), .class_size =3D sizeof(PICCommonClass), --=20 2.43.0 From nobody Fri Oct 23 14:31:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1792160468; cv=pass; d=zohomail.com; s=zohoarc; b=QEaAsymZ4VNSdmnPMWxd2PytcvyvEEaus/oppu49N7ZNz82nmqUzcG/ZPgT86FVFntvK4h5rZ7pL5yfoKahCDdYTpsh1NOI00C+7D/5zPj33XejGpGNWqExBvxZ2BqQk1FEB9qtY4wlmlNxuMyp9v8VA+W8YtLbUN50MzUQZQpg= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792160468; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=TAOVXQJDaXE3btj5P/XXf0XEZfGBwKpBJnEaqxNFbRs=; b=RwnrS59NyoDccqQnBmxAebLdsxlRnYJ46RXDK7JJxpzq/ZLpWFAV5J7PbqxytFB8YAhLkTT0pJwsBtj9RHF0rd+W78DzMyvug4e0JyCOrngaudR7Dvl9Ur1pRFPuEPl15z0ozZtlnRmiPGGh6qCnYTrDXrUrA3G1YdCCU5SemT8= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1792160468468627.4568099046517; Fri, 16 Oct 2026 07:21:08 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1451966.1666793 (Exim 4.92) (envelope-from ) id 1xHinn-0008As-KH; Fri, 16 Oct 2026 14:20:55 +0000 Received: by outflank-mailman (output) from mailman id 1451966.1666793; Fri, 16 Oct 2026 14:20:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHinn-0008Al-HA; Fri, 16 Oct 2026 14:20:55 +0000 Received: by outflank-mailman (input) for mailman id 1451966; Fri, 16 Oct 2026 14:20:53 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHinl-0008A9-MA for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 14:20:53 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1xHinl-003A6Q-2r for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 16:20:53 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6ad232c0-2eae-0a2a0a5409dd-0a2a4507e8ee-4 for ; Fri, 16 Oct 2026 16:20:53 +0200 Received: from [148.163.155.12] (helo=mx0b-002c1b01.pphosted.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6ad232c3-b4ea-0a2a45070019-94a39b0c2d68-3 for ; Fri, 16 Oct 2026 16:20:52 +0200 Received: from pps.filterd (m0127842.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69GE4wu41681723; Fri, 16 Oct 2026 07:20:46 -0700 Received: from byapr05cu005.outbound.protection.outlook.com (mail-westusazon11020081.outbound.protection.outlook.com [52.101.85.81]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 4hberu10ea-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 16 Oct 2026 07:20:45 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BL0PR02MB6547.namprd02.prod.outlook.com (2603:10b6:208:1c8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.23; Fri, 16 Oct 2026 14:20:44 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%4]) with mapi id 15.21.0522.016; Fri, 16 Oct 2026 14:20:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=TAOVXQJDaXE3btj5P/XXf0XEZfGBwKpBJnEaqxNFb Rs=; b=PII3KCEs6b9uknvsrQvvbUIKHz+uvKGaJ2OAIubyuTiqv4VtS4Gvi6MAh m011D6ad+VnPzP9uGgZtl6FHCiyv4tSqu0OjC6U2Blw9u78ey7THFmfpW/AujUTn wcYl84HwZyS5scuQrXJ39EJsgZuGFp4X4FZFcWFFX4moDWOLphmeR3lk0mh29D1K cen65hlna5HEvPCgfZuBjPfB+G3zcfs7qdEeNr0kcwMtD1xYjT7DPmMQvZxQOrdq 9ov1Zdoj2Pc+wVjWYmMRmPVK6DJUeYew0x526X+CSIVGi/2VrQPw2tWC/S2dJghi ouFMTY/UgrCQ2drOjQ0QTxxqmjA7w== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=E2uZtbYRoNUMycwxNg1BURdihulFX69lRzD9kmcNqChVXMlydOQ9KIWcvz2SOQh5PCwYfabEb/+y/tSQN4BUbRu1GOSEXccGz2oypYejXGkikh03kLSjSIA14v9bR2E3tPbH9nrq7kgzK6AKgDo+IfS3dmD7UnCZUDofAKkqVo8FznbwLgnLFgSKBAteq9Xc3NXHTOE+kbcN3wuNKFCAek+TTQEu4UbJdlBei+E2KrCit+UvsnJ91OG+4+jAK4pJWMMtvJLi51W6GJ3knmxCE3oDlmW0PPSp9v0Hu1OvTP71zl/kIdP47L2Ii13zAUXHGHexyX5vqsPYV5yxv932kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TAOVXQJDaXE3btj5P/XXf0XEZfGBwKpBJnEaqxNFbRs=; b=OFbsDlbPP75OhbXl5H4RY71uqAZ991YUT1Z5GPE0YSdQtDCgEVEbIWYO5Z4pHM+MsPJqEgiWxdyxmjgN0ZA9CqSm2sfkHSt4Tif1wwb46LObHOo4hQuZprNGetmGc/hZfp+4vxm0uWez96KdJo2z4/zW4NguZi7onlUfAjcorjQfnnUovlBS6j6BTeGEb+4nTPv/ecURxNLcM5iou93c5eP/nY0nZ0jtjjUsdCVUJWo7GeLLiN4g1v5bIiqDhr8hOK/SPxEvj38LG/E8j3eDID4VmY4EEgELj1jfUfGWUkjEhj1UEkUJwpWy11kVRXirDyJEd3XYCcDisfY4/D525Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TAOVXQJDaXE3btj5P/XXf0XEZfGBwKpBJnEaqxNFbRs=; b=hJCiK9Cu37zSMnMpbb+9XUzNa0PuSg0xEPnLi2AsNL1oc/ra2SBBftT26VBxc77AkaewNxEi0RrRdz5hXvhAucTzoApPEhSCeQHswR/RlPtnYOK3mnHtURNrhPS3/TRwpQ/TJ/mGwp5rrIQ9/fAxWS3Ph8YPHwpbewiHOD7HZrF/S4z+rmLAnwAZiJxsc2EPgsjlI3iKpk/MU8rcHbWhh79JzxzoEPSwdQILfKmOq6pXkFP7ghBPke9Ov6nVBSbb8xg9XvDlf/eA0snR5EJuivGeaze992F7hvn6PdpjOCKvg0ID90zLTPZe3yZYgs2wMksKj4D7ZmQMPJcyHuw1lA== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nutanix.com; From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH v2 02/27] i8259_internal.h: rename TYPE_I8259_COMMON to i8259-common Date: Fri, 16 Oct 2026 15:19:08 +0100 Message-ID: <20261016142031.1204281-3-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016142031.1204281-1-mark.caveayland@nutanix.com> References: <20261016142031.1204281-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR05CA0076.namprd05.prod.outlook.com (2603:10b6:a03:332::21) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BL0PR02MB6547:EE_ X-MS-Office365-Filtering-Correlation-Id: 28d1c3fb-64e5-4032-39f3-08df2b90aa33 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|1800799024|366016|22082099003|10067099003|18002099003|261009223027099003|56012099006; X-Microsoft-Antispam-Message-Info: YzyiWF3i3N6f8bFTTLDJjKuoDLjx/DZb2LGxkVg3hZERzXjQTOtgBuxPoXN3EhXNFaovswFni/zdI+kb4uszQmRWVZqoqQTTxf8nb2+k9qLv9NGo+cgiOu7U2jbIg/uhMkTszngb98F/aN2tlW0YyDCJzvEpZu/I3HQtXeSrAwVa6wfTCAMVhOQK7bWHI0NM+L0aRPIf6QiuIr1H9Src+lvku8/khZmMGZvgmdIRiHCTDi/kG9UmYRZ5Qar3hvy+JZlp3HfelYKPvoJgoZWiXTyHDHmtSMPJdfYyworghe5kNAB3bq2Rw4DbeDM1xyaqD1j13JcvJaYL892dhTrJ2tQ106RL7h70apfTiulUDWBzWQUNBuRmfTkedigiEiEqmF9kVL/vF7WGQGITQJsGHDY21951bhUR8C0oLCshqlG3RcL9IkbNbY9VmjuMgOOfFjCzn2bG4/JRD+dexFLnxKsxuoUmNAZ7vkk5OuHNdYhVrSTWsxZfrhk/7KoLpt+x+6Ov0p9VXFfrMq/QkJpDSAOQcnRmoQypiQBVfpMO3J9TR3jxYcNGseR5OO8hSq/dgP8vsdpOA8k9cU3JXTmDhRkhsaUFC0X6Mt0O/jSoxons86bAxqoV8VhO9L9THLkgGwREyQs+kEz59+veQLNpoWwnt6dd93cfbfmXhzGKDtQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(376014)(1800799024)(366016)(22082099003)(10067099003)(18002099003)(261009223027099003)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3HAttB6FSeDceJrbHLuoI2B9VrdLnZFTlQVl+UuU77a8SrqF5xKQmpvXrz3j?= =?us-ascii?Q?D0ZilW8gY5Qwo2tXTXhSCpPflEb9ca6aj7iriQFIKLBFkYCh9mKH4BrPStfM?= =?us-ascii?Q?u099J6fgH2c6SbQPdoR/9tG4vFCcblqC9lNVE4TFfJ9DpJr6Qrvbtoo6Yjzb?= =?us-ascii?Q?Ca2+00Z/0VgLtErOlRwk1DInXuIi2F7HDA3X0QqwwQuQTxMDm9rIQxtEtTVb?= =?us-ascii?Q?CdZNrR7jX2qkCGvsOvbb59sGLs4qeBd63zYxWhw3xrxd3pkRyfv7hc1axrVM?= =?us-ascii?Q?CTbkRti6EODCZOzXixFf1OvIqp2bG3d9OJc2oTSIUnRS/dbNK+mxepufWFAb?= =?us-ascii?Q?WsXB+cwnjBn9GOAS5IQYobm3MQuoQauU8i9Q9R+qLxh1hXrDNKHNlKNStRbu?= =?us-ascii?Q?iU/S2hFs9WGbyCuD0/Es3qiD68CmdOJqN9qTH7oBTxcFcbG78kw6ob7EupzL?= =?us-ascii?Q?FNsNs9YXxR6i5lfin3eZJW7u0GTrKNMw5mK0Uivc1M420/C3Qy1kYqDLemRx?= =?us-ascii?Q?nGB7eWkP8EJDM7xifTB4Z937VuZyWnqSyDNqFPcZh7msSAnGIl8BGUCaWQJ2?= =?us-ascii?Q?LyhveSoK8Poya0ZNgYJut0VFQci6de9IOlv/YedLNgfU3+SzjC+eo7X/GrWm?= =?us-ascii?Q?88DqlwSm2YymHiDjXZwDHXgMkFphP5r3khE/3fJg663QmTID/HtIAB16G8CP?= =?us-ascii?Q?mkQa7b9z+M7ZlZ1wyBNZbGIES3Y5DURCbJ0KKWG5pTAQGcPeEynsCgUM0z40?= =?us-ascii?Q?nDldBpNZ39CD9JceFXTnYsb3fJmHr6vCEWk/97rLVZZu5DOGp09uF9qXNgLK?= =?us-ascii?Q?8C6qr3qNJn2ktUW9UKdMiiYoqc8bTvOGh/WDk57I6EOu5RBNbaxPx+kySnB9?= =?us-ascii?Q?pwry5QNZHaNPMFJu2M975cI+KRnxvqXkR9PruyXRwRtUWg8Ztw7PffzQ7yj4?= =?us-ascii?Q?Xc60Cp7g7h5vAMW20xp/zvOU+hLCXwanc4tY/IRiO7dSnFiOLqQkApVrcbkn?= =?us-ascii?Q?mp7KA3mqMrXcECfKw2rWEeHgQLCGjrfuoXMlWnC+1aCe3SwNOx/a1iSKsy8Y?= =?us-ascii?Q?y0z9/mXtAvTUFwCtfdhEtk7670sxqBzMhqPn5+eynoolzFzKJnPOK0GbCLTD?= =?us-ascii?Q?c41Oa2DmiTW/wlAV1vF6RKCKFvyMaog2UOxkUrFE1IAS9ZFF4fqjF8skwxmR?= =?us-ascii?Q?MLPUyBDHGcGK6ZCNT3bBtWNRGKvAbK2ozOwWe5Lzr98hzcoLKuBl4t20MUQz?= =?us-ascii?Q?4PjT229hJFAUPgu8LQAWIc2Kp33N9S213xJ+bD0QtHKkFPve2pX3/Rs88ZnD?= =?us-ascii?Q?GZCx/ZQn17cCgXcRXWbff2OAT7zOSPtzNqmFCqVb3kpxJ/yHOxIy8WHass2c?= =?us-ascii?Q?mzMyjOBIo2PXlw9JVBh7mMhPdYH47hFYSoO89HhHvgcfw0Spc+pz9g+Tb1/T?= =?us-ascii?Q?1OhIy21J0eH/VVaCeGkk7bWVES4v1iStrMGKTWiW74ZCd9Stf8pk3wCfB1+A?= =?us-ascii?Q?+d97sc9juI2buC205st4B8VZAiW7E5kVYARCWww3YWzkQNLw5t/Wo5tt+tG1?= =?us-ascii?Q?nm3/DH69wWJnqoAdFv4xamyHxqz2Yl5T7/FJnQ9jRjHbB6r5m4HgwNvPsgyu?= =?us-ascii?Q?WAZJd5M2BNiblIDUmc4X9Ppk043Q4oiQzxM4bzzulwVAVPG4q8cERef0W4tg?= =?us-ascii?Q?zqfyV60VqPhSsj44pvyR1+wcy5jHfPhdGLdQ/njaBk7dmVLTMdSrAiP2cZCD?= =?us-ascii?Q?FgW8p5Y+PNE+225BTocTzU6SYWMHbW8=3D?= X-Exchange-RoutingPolicyChecked: yftx1Ge/yZ5I+i4VqgkKQs9luZGpqONkQA08MAoQa9uN/T8QAK6eymfmfJVr0IC521tzjVGAWnDKcHi04Y6KlaVPpsjAfzU2YuMO/PekpWD5mdO8u4z4luF9qiorx2+8iwW7uie5wKdOFPN1uk5FeEVe3+VpcW8ynPKF4yNvUnfKS5JRGS5rSZNOniM0OSaCr4eMP1/RQqeVaGF5nD/lkYOqS1dIEOM4krRX3PKJcFcNEbRIaoRGapnA8tIOJd5JVFL+GHIqbO1wnF5rq6rLiY7sxa2w0EMh1S+94e51NAHxGOTwFjoMTd9I8P5VNXc7bENRojgC1TJADjTbVKidLg== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28d1c3fb-64e5-4032-39f3-08df2b90aa33 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 14:20:44.3820 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sFO74afNsbSXbyVnXIyOel+E/16QDQcShnDNiGWVrR1OBLaMYvHLd5VIgyvOnXoFjKYSs2aqq/BLEk5cjbHeGL7qh2g0PtjzoF/2+6HG9Os= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR02MB6547 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX8CLutU0OZCp9 h7uuhKI03jU8xNnPS5jiOz4HwA2wnmcNE7eWeeryjOQFvx/PHj/ZZGTsLwbOn6dDYne2QJDXzkR tyl/kt29NgL1NCavyXU+1M7eDdVvrUdh7aNAbbsTevqf4Mjve3d/9jloOnZRkLWxo3xhFVkyW2d zd0Yhh8KS9bep5VolRRalqpd1C8K/7XlD6uORaqU5x19Hu2TRq7n3unD2aeIA6HU0xUvEn8f8Ac 8PKg4362KY52b1iD1bBM4U2e9dCuxhFaGgalF+Osb0pdW5Pz+sa8OSczjAuInp+m08bJ/DzFfxD dl0MaB03fWqnyFUpiEYwjm/MScVWOpCQjRrOrPc3e6MfHRxhkO5dPmQ+2fp7prxHvSeiqysf6Bb XZ8T7TGrV5BdNIeYZohg/f3/RjcT5vRPLTxgpMFwmQGGCplcJ3shuBsiQGGocS3LHd6jOVOkbAM WkzFPHn4rLQU4n2YH1g== X-Proofpoint-GUID: junzSLCiSfPbYzo3Yv0gyQBxQV95Ygor X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX42bjrWxLeqn+ Cy3R0iDnohRKKzWTwT2O0f4klbJEXfAw/xfKuFYvDjemFFvDDddnTU2Io/1p1fWB5tFAHIHJ2R/ 3MJgkWnwgkycs7p+yHcfx3cqoAaM7WQ= X-Proofpoint-ORIG-GUID: junzSLCiSfPbYzo3Yv0gyQBxQV95Ygor X-Authority-Analysis: v=2.4 cv=KMLPn1Fo c=1 sm=1 tr=0 ts=6ad232bd cx=c_pps a=PrKk0R3FxLq9+u45pGB2Yw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=660iZSQnnn4A:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=VUi8bpU7OL1Oj2-RSIOF:22 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=xWlEjtkXqD840QCPih0A:9 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-16_02,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-ef75cf/1792160453-36AD8AE4-28C24BE4/0/0 X-purgate-type: clean X-purgate-size: 749 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1792160471193158500 Content-Type: text/plain; charset="utf-8" This is to emphasise that child types of PIC_COMMON are all instances of an an 8259 PIC. Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell --- include/hw/isa/i8259_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/isa/i8259_internal.h b/include/hw/isa/i8259_interna= l.h index 54dc9036cf..289d08b7d7 100644 --- a/include/hw/isa/i8259_internal.h +++ b/include/hw/isa/i8259_internal.h @@ -31,7 +31,7 @@ #include "qom/object.h" =20 =20 -#define TYPE_I8259_COMMON "pic-common" +#define TYPE_I8259_COMMON "i8259-common" OBJECT_DECLARE_TYPE(PICCommonState, PICCommonClass, I8259_COMMON) =20 struct PICCommonClass { --=20 2.43.0 From nobody Fri Oct 23 14:31:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1792160474; cv=pass; d=zohomail.com; s=zohoarc; b=NbZovzh8mdQoftXIuIp4ZCMCpesd+4J3PqwuKXGNHhiZh4+UzymqsFdm1OUclJrG09vXhFm5H3aOdDRqVmEdywR5wKfCynC9/KkTjcvvSPpDH4fr9f/4oOwHVItO4FDcbMj3X7GLmrE60k+ArQjWI0lnY9XjCHVFDMWJPuCbu+c= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792160474; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=NIlAnp4VAldnLceUySYWQNWAeTWWwprg269Vv5DQ4Tg=; b=HOBvENU933hv2PA4hO9p4uvwAXShPbtJwD1Ice4UvT0qM9WakvKNh8N5Rap2s72rtT7aZRVZPAu4M03zK3/kPcec2v3I3oZdxiTjSoR4DyKV4hQFXtPyQBUP1l7N5v/phX4gD0fNgMjgNMn+GSzglwndSoorHqezQDS9PmY82ec= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1792160474345778.8836809535363; Fri, 16 Oct 2026 07:21:14 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1451968.1666812 (Exim 4.92) (envelope-from ) id 1xHinr-0000Ci-6k; Fri, 16 Oct 2026 14:20:59 +0000 Received: by outflank-mailman (output) from mailman id 1451968.1666812; Fri, 16 Oct 2026 14:20:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHinr-0000Cb-3f; Fri, 16 Oct 2026 14:20:59 +0000 Received: by outflank-mailman (input) for mailman id 1451968; Fri, 16 Oct 2026 14:20:57 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHinp-0000BE-KJ for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 14:20:57 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1xHinp-001AYp-0g for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 16:20:57 +0200 Received: from [10.42.69.12] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6ad232c8-bab6-0a2a0a5309dd-0a2a450cb32c-0 for ; Fri, 16 Oct 2026 16:20:56 +0200 Received: from [148.163.155.12] (helo=mx0b-002c1b01.pphosted.com) by tlsNG-d25034.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6ad232c7-f479-0a2a450c0019-94a39b0cc74a-3 for ; Fri, 16 Oct 2026 16:20:56 +0200 Received: from pps.filterd (m0127842.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69GE4wvO1681736; Fri, 16 Oct 2026 07:20:52 -0700 Received: from byapr05cu005.outbound.protection.outlook.com (mail-westusazon11020076.outbound.protection.outlook.com [52.101.85.76]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 4hberu10eh-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 16 Oct 2026 07:20:51 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BL0PR02MB6547.namprd02.prod.outlook.com (2603:10b6:208:1c8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.23; Fri, 16 Oct 2026 14:20:50 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%4]) with mapi id 15.21.0522.016; Fri, 16 Oct 2026 14:20:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=NIlAnp4VAldnLceUySYWQNWAeTWWwprg269Vv5DQ4 Tg=; b=HO73wnsiTrg/yLKyFFRPwjkZ6FBrHf/du9JjfUW2Hv33SUUTYZctDbUBh oJmxTz0+fzgI563760BffRYVFFyfLl5wMfHQ2DR1w4ilmL1RVBb1J1R36j+HDWEn Ag0x6rsK699X1Yx4kGoQDlXsKRVHWAk7Dt1y3o1IJF7OfGyIFYw0aq6qp7UG5ejn qAD2HIiOUCXKFJtpbvMYgFUqw7WiOfonxiBGUeUwNF2/Za4rCeWHSZVqy8nt2ErT W9pLB7a99ppSknGs76fW2r5FSRrr3rCk9+E1G0KDOTEv4xoLTuu6J/iFitjji5X4 e9PJrbs/WuKS4idjUoGcsvBEbuIoQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oHc0q06T9rRmXvxShGiOPb/snPVXuCTujSJJDhimehRtn0xZNpvk/GSEjgS1pX1eYWHZnloR338groTC1wvfXzyzT/r7iFV7cdQingm9BECLeuK7tF+Ayt0/JD1MDhFy4mvZwESBQK6AWLu7kO4L84JBD3jDxoTBmHMlKvoWaqNjK67UnIpvZSfd8SwOGbYj2bak18yu/0X/gXCtVA+VGHhENIfRjvo8RBmtJiVoo5zNstUgN+WJyfBw5qNlp7sXKqwyCAxIcGZw2tElmFzpRKHNua/m3WWeAs0eEWyYkFHim1l4xUrFoDgJiGtW6nT1THNLbXqGyGI8intv/buvzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NIlAnp4VAldnLceUySYWQNWAeTWWwprg269Vv5DQ4Tg=; b=I8wTTqCMlDbA3NqpiNv69Vqn7OfC46SpQZTPh57hfLAHmd+gVs+64PkFphAUQLOHWv5qUFw8OAS5AeCJJOlSLkrTdqT3NNzVpNHiWsmiZ7/NnLBATZBiJ6SWXXRbQxHGPTfK7zPeN56SCp1CNeT+sYQzPgJN9/rvo3GxDwgUaWTJxQ6aiEVkIjISvRJZol15NBcs8Nsnm0NonS3H3pxOuMq1JajsRHSv8m7Vp5T2pRhgOeB946dGysk4MfDFJXBBPh0hd6eYTWG3Iv7mxoYyhegXuPhfBeR+5AUKCuImO9rtiXfYNVTm2o1J4QKCcdyLJA1Inf3r50DdxPXG2MQaHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NIlAnp4VAldnLceUySYWQNWAeTWWwprg269Vv5DQ4Tg=; b=GbIJEdRdZ7NX6yZWw2CTel3LputhFhILPxDvu+LDICpzEhChsjq/7VTdJbP0WRwxNBitxz1WRr8AdY1UU4xMEs5oeh+SCnFpvKxu3K22RhbZHrr7H2qWcEo0SATXwiSPBdEAdvvfCgE9I0ebvqPAjvsyFv7fGS1apdjuP6O27aUmAZALKWNqGSi12rjU/+oRpd3A1HLQNWWhNLLzNEAoK06zeumFI/aQuP8TDntiAXLj0Ez+sOkP9GP8yk191wGJh/nzj+9Y7YEw9bRtWx+wQ9c/JckWdM/j6WZrNdXQLoubcMvPg7r9M9ZdIMe0LW4+5o1gNk2QXYZmkBJy8239Eg== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nutanix.com; From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH v2 03/27] i8259_internal.h: rename PICCommonState to I8259CommonState Date: Fri, 16 Oct 2026 15:19:09 +0100 Message-ID: <20261016142031.1204281-4-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016142031.1204281-1-mark.caveayland@nutanix.com> References: <20261016142031.1204281-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR03CA0100.namprd03.prod.outlook.com (2603:10b6:a03:333::15) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BL0PR02MB6547:EE_ X-MS-Office365-Filtering-Correlation-Id: d7bfa6cb-4d4d-470c-2a14-08df2b90ad76 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|1800799024|366016|22082099003|10067099003|3023799007|18002099003|261009223027099003|56012099006; X-Microsoft-Antispam-Message-Info: Z+P3wcbxYQflMMVdqOSqvz61eLkdwyDhI7NLiLkxIOTs9NNreblc8MZxUd3kKkrnyOeyRMz3D+pDM/Ju1Q5pHLLxmnEVIfqARcSHsAaxKDW4Uvi7lozNsh9/JwsenKgW20WZyL1l7tVaGap72yp6QOlgjYMOw+6bJHgE3HR6T/gApXJoxrE1T6UnKn7t1PWu7s2eJu7jN5vbApHsxl7o0Ml1gnh+5TaIi+HYNPx674Ab3ooB4y66iqq6gsx0oNAUQsVgwKhBkvxFbvKMgBKq6hYVVbmOUfLHGcJgQCxc+cKIklthpzhWEYhFKmaTTk69/iG7MOGlnuuMg6M6q2hWV8ZbuE+in6bM1RLMiO05qUmwzUtwAuErRqSwz6M0cpJQew3dLrc23edGyrrttvjM3t2M1XR3PcCfhWXoVXgWEO4iSmVDKLW8GJW2ICjSJ86CTQSkviR3QU+H9K59EL+VcA2BW2UOpsvitXg3Sv42Zo1Dvb3dS9rSd2fnhOIUPr3VV/spAafzxuOranvo+m1CWzzUd83WFF/6yuMYkpuSXMVbpVkZ4tpz81BC+TbPgQfkThJ720WKo3fdtGQXCYmkdAIazRTrDnbL+D2Fr41wRiQwZq3B/sFofvQtFuaeLNITmOrwmh5nEsX6hM2J+7P/gh0+78X2rXEPcbkQyJI4m2I= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(376014)(1800799024)(366016)(22082099003)(10067099003)(3023799007)(18002099003)(261009223027099003)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4Ke1GC+wQLL2D9iJJYQAG+DH6VUD+0SNclBch/C/7cqUkOsFO9140U9lsjkX?= =?us-ascii?Q?wVng0gJdGLPQZIsSrTd5v7AmHKW4MaVW7LTnK7qmiFV/t+XAP2B0CqJDxaEx?= =?us-ascii?Q?WULvrGrYDQk+dvswecqSy91hF1ol4AjkP9pyekDH0TxWKMLf2JmCM42jHWXq?= =?us-ascii?Q?NHBofo9cAN9eUw6erKAq7tfrXuT01WmWIv+4qDIrLt3VMeUkDPFVq4xK/2n/?= =?us-ascii?Q?ukgREwaZGYIlgsZaEGBWb3RF+Mn1UQ8CpNIffLL+Nh+RlRbQrjiX1nv4NxRS?= =?us-ascii?Q?Zap98MxRcZi0pn+zloYyJ+bD6eutUZ8LNXq9MS67tEfl6AEtw7qSMGhu+n/M?= =?us-ascii?Q?QntfSya0iDxLVxeZQ05YrDWPdLl0Dmzms6EeHvHZUxb4L+EYONXnoi0WNq+C?= =?us-ascii?Q?cd/w6+hNKEw4R7WYtWRBF6MwsIxNrMDTbDQZqeeGbDwvQWNsfKEdw8FmCTJx?= =?us-ascii?Q?hNcw7Q45IJiP9zcLMrFnohk/DgJQyx6Tgn0M04NIWmwWtBktJ2MoH0ofyH31?= =?us-ascii?Q?ds8EMtX7jtOBDiyxKX72bhFu6ZXecEzdB+YlyBdNIzZLUdIpR9s5N9guIq0l?= =?us-ascii?Q?we89XKHE4Q3WHeObEba0p7MJ+QYdaPhwOSElkPnw2iFmKHDCNlVEpG6cYWAH?= =?us-ascii?Q?HLccyGpawjedIf3Rq/CHOPxgFxoRPFTGna+LJFFTTZIbTLenAxD8Vy9gTi+X?= =?us-ascii?Q?Qui214vYpYwcEHHOQyzMQK6T9cVx8nmfWT0sN27FAOAy4dJT1mHRXDPNFEPW?= =?us-ascii?Q?/iLR6S4X4Mh3xfB5yrmn++bdkI2V4P6Gj7df+l0dHaPReAdKIQwIZmUZLbm4?= =?us-ascii?Q?0qAmLnoL2xIwN3KtbbaceVeeX6OwMZ9RJCSLCpOaJvv4dY/dCBxSIvSz6FED?= =?us-ascii?Q?h5XJf7FdVIQIxxKW62CH9h3u1Edbm1S+iFRqz4KaIwwyez/H5HyKBz3nayb8?= =?us-ascii?Q?jJyK4mVPjv3xjpgUDZ816eMX7AaJIpyi7oaKGpEJaXbtGh11rioDBJMElHGb?= =?us-ascii?Q?g0C6Cy06hkAdjaOjEaMfRyGOsdLSnhOyiTprqOdcW1qZu1C6eX9Nf8XMGpfR?= =?us-ascii?Q?DL9MmMLlwqYThmsHftopbbpNDWmv8gunZ2zpTpqO8ZQDMs9ZY3DW8Rruu1CT?= =?us-ascii?Q?0pVXmTSmcTkIq2UpzN38NLbpwPo3e23fSW6yLJV6I+xYy2iPUw8rWxS3vTAq?= =?us-ascii?Q?5hspYRb9Cw23we3ZpjOczBuI8Tfu8hYlT+RWs7HCJ+gAkltvU2+0asgGhxSH?= =?us-ascii?Q?DT1ZPq5sZK8r9IyxrC2Nd+NiON6czMsMWgWC1W5nGbcUsdytNErHhf2hI0zg?= =?us-ascii?Q?mY1/iU3DpAxpAM6kaQIw2bUzk2IzdXB8E23F062zpoZpXTE1l7pWLToYtJnH?= =?us-ascii?Q?yfJw005XP679VmC1eiGmHhIsDuOsrXZINfY3fusELqKNSmcMtNw00ei1yANO?= =?us-ascii?Q?A1XiAXFWErv4zQt1oo7pWHATe3cC+bmML9YDmw8D9i4HCpeKIyh7I+57OORf?= =?us-ascii?Q?bixpXF+4vjJcv4WqvdHAjTbOr0fUnuqrSgJ/z7R7z48WKKTu9nEp1+R13QhE?= =?us-ascii?Q?Nn+e4RD7MpEfCMR9tF2dJt5fJnkDobcmkH9UWthTII1p1zm+xbdC2YgFZQ/j?= =?us-ascii?Q?ZkZO+ddarMiQLgViei+iSpF9o+X6JXek6qWm8u350lyL6JbpQrRs814s18br?= =?us-ascii?Q?eoAH/A8/XpySu7RMzpqO8fSKe5+lgjl1aua+4PROXtdve+U/YFoMeQIwXpeT?= =?us-ascii?Q?1FDtp/aCwLLNlJg8DGXFaZ2t0zNlqK0=3D?= X-Exchange-RoutingPolicyChecked: XKVztMYcPftvuNC9QR6uw4bIWDSiBBpdb+1ElYSE/zyxDlVBJ4p3p+8xJHgnELsRnjqCCNJquY6uX/SwjMlGwK2e855WIuBO8EYW9xcP76mlo+UkH8OQGFqTgWjhqpFyd9gBibPffnbuRiUY+oY5HxYeuETx1jJrhVmWevyx4lZTEfQNl3XMSbZFHm8iYCOyfuJ065CMrczvXg5lkfl66rUerPuT78srO9Vp2CBdYfN9ThVKithxc3697iMsbyOVycIR9FPUouulsJlIS4w50JfIcV47TQiZxBQ0g3zd+3aXKVbx0baGhbDM4eO85xvN+q0auvInJ1hWIQzW1l2W6w== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d7bfa6cb-4d4d-470c-2a14-08df2b90ad76 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 14:20:49.9984 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hXeTpwI14S6o9nztJogqIc+gNK+f0Fxt/r0EZOry+PCtfUagom8vCRX00RRj6KzcWunN/79B/VeHPyciZYZSpft/fNiCgU0YidrL5vFHlko= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR02MB6547 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfXyyGl4V7kUtc4 ERQSO2msQynlhrxlQUJtnVbAE11BtdcI3A1x4WZKDWZVOWZndtbNjmAOP5aRTjJy4Cbyo76HIa6 clYVcEtYc9aKWp5GHX5WszaLowa+Vv2DxUqk4h2BLL1yKnQUA9hR9hJoRa1FinN+bEyiJnkxJaZ mPUhssRyDlgi9aKZQZEqT865e6JlFcyv4P/otLj/8ouaWTJIV+UfftjHQchYM6N1Zq0dsUPKjdX qQnzKZJpBww97sA8IPTdJ9KLV968DNpGMSGuKBiMygb9LipVdb2Ny8cfmuUxxi2ZUEODtVGIezA YSMbQaTpxEnzuTzMohQcMD4HWwirzigmHYl3NvCwa/Tm7rqpqd+5eXpfF6EYMR1ytAeSkF3fY2j 2HdBBlY0hwYtmKl8PrPxivyil/wgwv99AqdqOEdNO687rXg+v2WQCK3v5TT4uevtvtqVu+dAzm0 lZkaHo574Fz5JzJFGBg== X-Proofpoint-GUID: lW-jekKSqD5MBh2xS0uEqkzVgoQyPVlA X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX/iFMH0fkz+Mm 8Z36LMaWKpT7kpsTU4FKUU6bUt8p2wJsWCnpMu0ac992mca2+7eF3AUXNKCyFeWZkSJaEB1Js70 9sz+87rMMN5JPXi48FlfXfH/Ap5Ty+E= X-Proofpoint-ORIG-GUID: lW-jekKSqD5MBh2xS0uEqkzVgoQyPVlA X-Authority-Analysis: v=2.4 cv=KMLPn1Fo c=1 sm=1 tr=0 ts=6ad232c3 cx=c_pps a=PU2v30DqrLDYHXTVxoobRg==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=660iZSQnnn4A:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=VUi8bpU7OL1Oj2-RSIOF:22 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=01ND9n3NiX1-kDoXiQMA:9 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-16_02,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-d25034/1792160456-5093EA5B-B420ADF1/0/0 X-purgate-type: clean X-purgate-size: 14398 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1792160475543158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell --- include/hw/intc/i8259.h | 8 ++--- include/hw/isa/i8259_internal.h | 10 +++--- hw/i386/kvm/i8259.c | 10 +++--- hw/intc/i8259.c | 34 +++++++++---------- hw/intc/i8259_common.c | 58 ++++++++++++++++----------------- 5 files changed, 60 insertions(+), 60 deletions(-) diff --git a/include/hw/intc/i8259.h b/include/hw/intc/i8259.h index 1f2420231f..1921a30371 100644 --- a/include/hw/intc/i8259.h +++ b/include/hw/intc/i8259.h @@ -3,9 +3,9 @@ =20 /* i8259.c */ =20 -typedef struct PICCommonState PICCommonState; +typedef struct I8259CommonState I8259CommonState; =20 -extern PICCommonState *isa_pic; +extern I8259CommonState *isa_pic; =20 /* * i8259_init() @@ -16,7 +16,7 @@ extern PICCommonState *isa_pic; */ qemu_irq *i8259_init(ISABus *bus, qemu_irq parent_irq_in); qemu_irq *kvm_i8259_init(ISABus *bus); -int pic_get_output(PICCommonState *s); -int pic_read_irq(PICCommonState *s); +int pic_get_output(I8259CommonState *s); +int pic_read_irq(I8259CommonState *s); =20 #endif diff --git a/include/hw/isa/i8259_internal.h b/include/hw/isa/i8259_interna= l.h index 289d08b7d7..7a2f9addaf 100644 --- a/include/hw/isa/i8259_internal.h +++ b/include/hw/isa/i8259_internal.h @@ -32,16 +32,16 @@ =20 =20 #define TYPE_I8259_COMMON "i8259-common" -OBJECT_DECLARE_TYPE(PICCommonState, PICCommonClass, I8259_COMMON) +OBJECT_DECLARE_TYPE(I8259CommonState, PICCommonClass, I8259_COMMON) =20 struct PICCommonClass { DeviceClass parent_class; =20 - void (*pre_save)(PICCommonState *s); - void (*post_load)(PICCommonState *s); + void (*pre_save)(I8259CommonState *s); + void (*post_load)(I8259CommonState *s); }; =20 -struct PICCommonState { +struct I8259CommonState { ISADevice parent_obj; =20 uint8_t last_irr; /* edge detection */ @@ -70,7 +70,7 @@ struct PICCommonState { MemoryRegion elcr_io; }; =20 -void pic_reset_common(PICCommonState *s); +void pic_reset_common(I8259CommonState *s); ISADevice *i8259_init_chip(const char *name, ISABus *bus, bool master); void pic_stat_update_irq(int irq, int level); =20 diff --git a/hw/i386/kvm/i8259.c b/hw/i386/kvm/i8259.c index 14029783e5..f10643a120 100644 --- a/hw/i386/kvm/i8259.c +++ b/hw/i386/kvm/i8259.c @@ -34,7 +34,7 @@ struct KVMPICClass { DeviceRealize parent_realize; }; =20 -static void kvm_pic_get(PICCommonState *s) +static void kvm_pic_get(I8259CommonState *s) { struct kvm_irqchip chip; struct kvm_pic_state *kpic; @@ -67,7 +67,7 @@ static void kvm_pic_get(PICCommonState *s) s->elcr_mask =3D kpic->elcr_mask; } =20 -static void kvm_pic_put(PICCommonState *s) +static void kvm_pic_put(I8259CommonState *s) { struct kvm_irqchip chip; struct kvm_pic_state *kpic; @@ -103,7 +103,7 @@ static void kvm_pic_put(PICCommonState *s) =20 static void kvm_pic_reset(DeviceState *dev) { - PICCommonState *s =3D I8259_COMMON(dev); + I8259CommonState *s =3D I8259_COMMON(dev); =20 s->elcr =3D 0; pic_reset_common(s); @@ -122,7 +122,7 @@ static void kvm_pic_set_irq(void *opaque, int irq, int = level) =20 static void kvm_pic_realize(DeviceState *dev, Error **errp) { - PICCommonState *s =3D I8259_COMMON(dev); + I8259CommonState *s =3D I8259_COMMON(dev); KVMPICClass *kpc =3D KVM_PIC_GET_CLASS(dev); =20 memory_region_init_io(&s->base_io, OBJECT(dev), NULL, NULL, "kvm-pic",= 2); @@ -154,7 +154,7 @@ static void kvm_i8259_class_init(ObjectClass *klass, co= nst void *data) static const TypeInfo kvm_i8259_info =3D { .name =3D TYPE_KVM_I8259, .parent =3D TYPE_I8259_COMMON, - .instance_size =3D sizeof(PICCommonState), + .instance_size =3D sizeof(I8259CommonState), .class_init =3D kvm_i8259_class_init, .class_size =3D sizeof(KVMPICClass), }; diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index 52e24d333e..45db87a2ad 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -52,12 +52,12 @@ struct PICClass { #ifdef DEBUG_IRQ_LATENCY static int64_t irq_time[16]; #endif -PICCommonState *isa_pic; -static PICCommonState *slave_pic; +I8259CommonState *isa_pic; +static I8259CommonState *slave_pic; =20 /* return the highest priority found in mask (highest =3D smallest number). Return 8 if no irq */ -static int get_priority(PICCommonState *s, int mask) +static int get_priority(I8259CommonState *s, int mask) { int priority; =20 @@ -72,7 +72,7 @@ static int get_priority(PICCommonState *s, int mask) } =20 /* return the pic wanted interrupt. return -1 if none */ -static int pic_get_irq(PICCommonState *s) +static int pic_get_irq(I8259CommonState *s) { int mask, cur_priority, priority; =20 @@ -101,7 +101,7 @@ static int pic_get_irq(PICCommonState *s) } =20 /* Update INT output. Must be called every time the output may have change= d. */ -static void pic_update_irq(PICCommonState *s) +static void pic_update_irq(I8259CommonState *s) { int irq; =20 @@ -117,7 +117,7 @@ static void pic_update_irq(PICCommonState *s) /* set irq level. If an edge is detected, then the IRR is set to 1 */ static void pic_set_irq(void *opaque, int irq, int level) { - PICCommonState *s =3D opaque; + I8259CommonState *s =3D opaque; int mask =3D 1 << irq; int irq_index =3D s->master ? irq : irq + 8; =20 @@ -154,7 +154,7 @@ static void pic_set_irq(void *opaque, int irq, int leve= l) } =20 /* acknowledge interrupt 'irq' */ -static void pic_intack(PICCommonState *s, int irq) +static void pic_intack(I8259CommonState *s, int irq) { if (s->auto_eoi) { if (s->rotate_on_auto_eoi) { @@ -170,7 +170,7 @@ static void pic_intack(PICCommonState *s, int irq) pic_update_irq(s); } =20 -int pic_read_irq(PICCommonState *s) +int pic_read_irq(I8259CommonState *s) { int irq, intno; =20 @@ -210,7 +210,7 @@ int pic_read_irq(PICCommonState *s) return intno; } =20 -static void pic_init_reset(PICCommonState *s) +static void pic_init_reset(I8259CommonState *s) { pic_reset_common(s); pic_update_irq(s); @@ -218,7 +218,7 @@ static void pic_init_reset(PICCommonState *s) =20 static void pic_reset(DeviceState *dev) { - PICCommonState *s =3D I8259_COMMON(dev); + I8259CommonState *s =3D I8259_COMMON(dev); =20 s->elcr =3D 0; s->ltim =3D 0; @@ -228,7 +228,7 @@ static void pic_reset(DeviceState *dev) static void pic_ioport_write(void *opaque, hwaddr addr64, uint64_t val64, unsigned size) { - PICCommonState *s =3D opaque; + I8259CommonState *s =3D opaque; uint32_t addr =3D addr64; uint32_t val =3D val64; int priority, cmd, irq; @@ -321,7 +321,7 @@ static void pic_ioport_write(void *opaque, hwaddr addr6= 4, static uint64_t pic_ioport_read(void *opaque, hwaddr addr, unsigned size) { - PICCommonState *s =3D opaque; + I8259CommonState *s =3D opaque; int ret; =20 if (s->poll) { @@ -348,7 +348,7 @@ static uint64_t pic_ioport_read(void *opaque, hwaddr ad= dr, return ret; } =20 -int pic_get_output(PICCommonState *s) +int pic_get_output(I8259CommonState *s) { return (pic_get_irq(s) >=3D 0); } @@ -356,14 +356,14 @@ int pic_get_output(PICCommonState *s) static void elcr_ioport_write(void *opaque, hwaddr addr, uint64_t val, unsigned size) { - PICCommonState *s =3D opaque; + I8259CommonState *s =3D opaque; s->elcr =3D val & s->elcr_mask; } =20 static uint64_t elcr_ioport_read(void *opaque, hwaddr addr, unsigned size) { - PICCommonState *s =3D opaque; + I8259CommonState *s =3D opaque; return s->elcr; } =20 @@ -387,7 +387,7 @@ static const MemoryRegionOps pic_elcr_ioport_ops =3D { =20 static void pic_realize(DeviceState *dev, Error **errp) { - PICCommonState *s =3D I8259_COMMON(dev); + I8259CommonState *s =3D I8259_COMMON(dev); PICClass *pc =3D PIC_GET_CLASS(dev); =20 memory_region_init_io(&s->base_io, OBJECT(s), &pic_base_ioport_ops, s, @@ -444,7 +444,7 @@ static void i8259_class_init(ObjectClass *klass, const = void *data) =20 static const TypeInfo i8259_info =3D { .name =3D TYPE_I8259, - .instance_size =3D sizeof(PICCommonState), + .instance_size =3D sizeof(I8259CommonState), .parent =3D TYPE_I8259_COMMON, .class_init =3D i8259_class_init, .class_size =3D sizeof(PICClass), diff --git a/hw/intc/i8259_common.c b/hw/intc/i8259_common.c index e2f997e161..17040bdb1e 100644 --- a/hw/intc/i8259_common.c +++ b/hw/intc/i8259_common.c @@ -33,7 +33,7 @@ static int irq_level[16]; static uint64_t irq_count[16]; =20 -void pic_reset_common(PICCommonState *s) +void pic_reset_common(I8259CommonState *s) { s->last_irr =3D 0; s->irr &=3D s->elcr; @@ -55,7 +55,7 @@ void pic_reset_common(PICCommonState *s) =20 static int pic_dispatch_pre_save(void *opaque) { - PICCommonState *s =3D opaque; + I8259CommonState *s =3D opaque; PICCommonClass *info =3D I8259_COMMON_GET_CLASS(s); =20 if (info->pre_save) { @@ -67,7 +67,7 @@ static int pic_dispatch_pre_save(void *opaque) =20 static int pic_dispatch_post_load(void *opaque, int version_id) { - PICCommonState *s =3D opaque; + I8259CommonState *s =3D opaque; PICCommonClass *info =3D I8259_COMMON_GET_CLASS(s); =20 if (info->post_load) { @@ -78,7 +78,7 @@ static int pic_dispatch_post_load(void *opaque, int versi= on_id) =20 static void pic_common_realize(DeviceState *dev, Error **errp) { - PICCommonState *s =3D I8259_COMMON(dev); + I8259CommonState *s =3D I8259_COMMON(dev); ISADevice *isa =3D ISA_DEVICE(dev); =20 isa_register_ioport(isa, &s->base_io, s->iobase); @@ -118,7 +118,7 @@ void pic_stat_update_irq(int irq, int level) static bool pic_get_statistics(InterruptStatsProvider *obj, uint64_t **irq_counts, unsigned int *nb_irq= s) { - PICCommonState *s =3D I8259_COMMON(obj); + I8259CommonState *s =3D I8259_COMMON(obj); =20 if (s->master) { *irq_counts =3D irq_count; @@ -133,7 +133,7 @@ static bool pic_get_statistics(InterruptStatsProvider *= obj, =20 static void pic_print_info(InterruptStatsProvider *obj, GString *buf) { - PICCommonState *s =3D I8259_COMMON(obj); + I8259CommonState *s =3D I8259_COMMON(obj); =20 pic_dispatch_pre_save(s); g_string_append_printf(buf, "pic%d: irr=3D%02x imr=3D%02x isr=3D%02x h= prio=3D%d " @@ -146,7 +146,7 @@ static void pic_print_info(InterruptStatsProvider *obj,= GString *buf) =20 static bool ltim_state_needed(void *opaque) { - PICCommonState *s =3D I8259_COMMON(opaque); + I8259CommonState *s =3D I8259_COMMON(opaque); =20 return !!s->ltim; } @@ -157,7 +157,7 @@ static const VMStateDescription vmstate_pic_ltim =3D { .minimum_version_id =3D 1, .needed =3D ltim_state_needed, .fields =3D (const VMStateField[]) { - VMSTATE_UINT8(ltim, PICCommonState), + VMSTATE_UINT8(ltim, I8259CommonState), VMSTATE_END_OF_LIST() } }; @@ -169,22 +169,22 @@ static const VMStateDescription vmstate_pic_common = =3D { .pre_save =3D pic_dispatch_pre_save, .post_load =3D pic_dispatch_post_load, .fields =3D (const VMStateField[]) { - VMSTATE_UINT8(last_irr, PICCommonState), - VMSTATE_UINT8(irr, PICCommonState), - VMSTATE_UINT8(imr, PICCommonState), - VMSTATE_UINT8(isr, PICCommonState), - VMSTATE_UINT8(priority_add, PICCommonState), - VMSTATE_UINT8(irq_base, PICCommonState), - VMSTATE_UINT8(read_reg_select, PICCommonState), - VMSTATE_UINT8(poll, PICCommonState), - VMSTATE_UINT8(special_mask, PICCommonState), - VMSTATE_UINT8(init_state, PICCommonState), - VMSTATE_UINT8(auto_eoi, PICCommonState), - VMSTATE_UINT8(rotate_on_auto_eoi, PICCommonState), - VMSTATE_UINT8(special_fully_nested_mode, PICCommonState), - VMSTATE_UINT8(init4, PICCommonState), - VMSTATE_UINT8(single_mode, PICCommonState), - VMSTATE_UINT8(elcr, PICCommonState), + VMSTATE_UINT8(last_irr, I8259CommonState), + VMSTATE_UINT8(irr, I8259CommonState), + VMSTATE_UINT8(imr, I8259CommonState), + VMSTATE_UINT8(isr, I8259CommonState), + VMSTATE_UINT8(priority_add, I8259CommonState), + VMSTATE_UINT8(irq_base, I8259CommonState), + VMSTATE_UINT8(read_reg_select, I8259CommonState), + VMSTATE_UINT8(poll, I8259CommonState), + VMSTATE_UINT8(special_mask, I8259CommonState), + VMSTATE_UINT8(init_state, I8259CommonState), + VMSTATE_UINT8(auto_eoi, I8259CommonState), + VMSTATE_UINT8(rotate_on_auto_eoi, I8259CommonState), + VMSTATE_UINT8(special_fully_nested_mode, I8259CommonState), + VMSTATE_UINT8(init4, I8259CommonState), + VMSTATE_UINT8(single_mode, I8259CommonState), + VMSTATE_UINT8(elcr, I8259CommonState), VMSTATE_END_OF_LIST() }, .subsections =3D (const VMStateDescription * const []) { @@ -194,10 +194,10 @@ static const VMStateDescription vmstate_pic_common = =3D { }; =20 static const Property pic_properties_common[] =3D { - DEFINE_PROP_UINT32("iobase", PICCommonState, iobase, -1), - DEFINE_PROP_UINT32("elcr_addr", PICCommonState, elcr_addr, -1), - DEFINE_PROP_UINT8("elcr_mask", PICCommonState, elcr_mask, -1), - DEFINE_PROP_BIT("master", PICCommonState, master, 0, false), + DEFINE_PROP_UINT32("iobase", I8259CommonState, iobase, -1), + DEFINE_PROP_UINT32("elcr_addr", I8259CommonState, elcr_addr, -1), + DEFINE_PROP_UINT8("elcr_mask", I8259CommonState, elcr_mask, -1), + DEFINE_PROP_BIT("master", I8259CommonState, master, 0, false), }; =20 static void pic_common_class_init(ObjectClass *klass, const void *data) @@ -222,7 +222,7 @@ static void pic_common_class_init(ObjectClass *klass, c= onst void *data) static const TypeInfo pic_common_type =3D { .name =3D TYPE_I8259_COMMON, .parent =3D TYPE_ISA_DEVICE, - .instance_size =3D sizeof(PICCommonState), + .instance_size =3D sizeof(I8259CommonState), .class_size =3D sizeof(PICCommonClass), .class_init =3D pic_common_class_init, .abstract =3D true, --=20 2.43.0 From nobody Fri Oct 23 14:31:10 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1792160506; cv=pass; d=zohomail.com; s=zohoarc; b=j5tmW+Un6fRwiLpp2XftchM6QGjvJMRju+GVFoU7pBA1Kd5vdUaJFyxNXsmhfq/xN/53TYDdn5hbJxxwR1SfvOBhQcZMRc3y+bsngafuIDBHqdjSk3wGT/DYkbhev6KN1umTRe1lEL+tOVRFcgIcOEp2n5YniJIlsOj0Lg7nWx4= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792160506; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=GTsNITGc20yNxz42lJwDN4eLhxBiwmVbhEf4oSGIBNQ=; b=iWS0/9K14+yPPjii+GN0kNxVfw/mrycyrLjU0MALLAKL4pqMqZZaTZ8ZxJ8iZtkpwn1HnWSo0ZdaZINPMPg+BOj8NcvV9n0zenegp/xCvQYQzgW58oFWbwzsYutU9Z00VZYXKVeb4gIgJpV20rMSuDithoAqeBc4wR7IJWkMpyo= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1792160506710900.7146446916912; Fri, 16 Oct 2026 07:21:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xHioF-00020y-0P; Fri, 16 Oct 2026 10:21:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xHio3-0001zo-DO for qemu-devel@nongnu.org; Fri, 16 Oct 2026 10:21:11 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xHio1-0006bq-6y for qemu-devel@nongnu.org; Fri, 16 Oct 2026 10:21:11 -0400 Received: from pps.filterd (m0127841.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69GE5C4r3215871; Fri, 16 Oct 2026 07:20:56 -0700 Received: from byapr05cu005.outbound.protection.outlook.com (mail-westusazon11020114.outbound.protection.outlook.com [52.101.85.114]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 4hb045k1ju-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 16 Oct 2026 07:20:56 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BL0PR02MB6547.namprd02.prod.outlook.com (2603:10b6:208:1c8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.23; Fri, 16 Oct 2026 14:20:53 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%4]) with mapi id 15.21.0522.016; Fri, 16 Oct 2026 14:20:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=GTsNITGc20yNxz42lJwDN4eLhxBiwmVbhEf4oSGIB NQ=; b=hZ2oksFO8APuCWu3L2f5zZ1k9deAuiZIgapHsDmMrlE8NiTfiIWpPOZQY Ef3fU2tAAmV6E2JwkbxJmJJE7ShhimwmA4VnMkrX/uwMkBagWmMrU4xE8VnKGSmr DhHuilXpwBMdWdY5YHaknc1KqujUUYwzKqoqZ47X/g4cge1BydpOH3yumjKK5l+k t1SMR3H/u+CRqpshdPQITsdT6dB3CFjbu7pKagSdytcLd0yPA/N0F/rKyG3rEhu8 UtOFniK7UyMOQ1Gs16xaftin6XCadW3V5LAQTM/Do1760Lo0HwlJs3/4Uck/55q3 WzIBvUtLhY8r797nkJH+UxHh+avSA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PKEeACrkX44kYQU0dcQ84lGgnuClF8L+IBVBGu2HyzojVWPm4rxhw5xuJZq3g7+INnq/rfHa4E4vHW2zP1kTVkcSS7K6T/HpMyH4qvN4btoLOus8ltFJJg0ydkLe5y281/cc0wA9vQ7KVtBvI1pToQLYLwLxJuI+a5XfsdVVCJ50L4Q3Mupxn94q8gdPbWG6872j7YNmK1ON8yZYGbqi/Fp5cqKRIK2/DbbWXLrNdtivEED4aL5o2mdu66MkQzvJEHGhBVGi0G+eEe4cq0RZMWiODZMmAr8dSoRmja24UQDnxWfmmJdg0Z8CDllmJEoP+RUi34kbqgXX7Ja/Pc4Ctw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GTsNITGc20yNxz42lJwDN4eLhxBiwmVbhEf4oSGIBNQ=; b=dDumQLZ9N6g0CS3d8bPRO3VFZpW2ovNJXvQzJO/83J655w8AZ4gW8ItRZDfHQ28qiTBAnUzmuoiDw7FGH38UBA7v/YTxGqlGYvStYxLIscKFcCeh0psuWgG5CknVxMNBSRIWJtFjyWPpD4IQiEeTs/yJ2yQFiZ7YJl0LAkngwlGfYfMQFnjfuzhQTohHhMdZYj4FedXeFCjpU6fQWPdgYrk22FVg/rS2UkmSeS8gDIrTZjS7xtdHEpxipdMnvCqH9AOxc5f/0l8nGsPFmaPOYNE74cfX/SvO8/d+jFARtxU1wnQ0P82QDTqsC4bIBG7pqxy47DDhofUGKo9LBXottw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GTsNITGc20yNxz42lJwDN4eLhxBiwmVbhEf4oSGIBNQ=; b=UqZsIhjwhwOZkRvhxCcZ86/OIGlVv1lQKzNe/uF5HkqZ6i9AZHwZuPiKWVGSqsg0DbQyR+VybK2ORsg7Q2MoZNO8c8InuSmpJtxcwP8Cjrt5kadZ8w9DeQtFhK7utS/nSRkjNfoAfOcKfsc1ziRbuMmdjxm8WtX6/qfopWGk+9ZXTTXCJ3eMdPKy5Lt99D6l74q/3M5xD10OqCJ1AmUDkYvOh+mngD0rpBiM3eueiUVRZJvyS5anKeixWwAIUXaAniAyuyrxlAIEdY8Kf5bcXc1ZXKR1ZBV9nbBToBqu0R23U9xDPk6pOelGmX2hpss1QkR4nbAMKkRPIqddVkSSuQ== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nutanix.com; From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH v2 04/27] i8259_internal.h: rename PICCommonClass to I8259CommonClass Date: Fri, 16 Oct 2026 15:19:10 +0100 Message-ID: <20261016142031.1204281-5-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016142031.1204281-1-mark.caveayland@nutanix.com> References: <20261016142031.1204281-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ2PR07CA0003.namprd07.prod.outlook.com (2603:10b6:a03:505::26) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BL0PR02MB6547:EE_ X-MS-Office365-Filtering-Correlation-Id: 70f51369-4cc0-490a-d509-08df2b90af86 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|23010399003|376014|1800799024|366016|22082099003|10067099003|18002099003|261009223027099003|56012099006; X-Microsoft-Antispam-Message-Info: QBuOvyghhHQYhQsGL5CNi6VJxInWJFeEjzSxT7EAlfKW01F3oYDAXk7Qu3j1Xzza7KCwdjbLHDA0FngJe+XqmreGwyJLQ6lMcOb7WkZFq7KLlxj71LnQJIYv3BzX3UVVebhzw6TCuXF4KdDbBXGwKP4XKJnrb+afksWmGJyokFqbmLYXBBahIJhz9qHSZx64KuZD3sQkVNZmtw4QqQKJBL//stfTMZbRtCYLRObFi/GzJGx3KK0R6RLTdXmZsyP+exzFFQYhRZn4SXdP7CvM5CTN6mSDAiwoNVOngNC+YppN9BD0Q6VfqiR539g+QkbMBJWx8pmCJHEtaFbYh5TOBvMJeaSWnqzBRbTV/xYBwTFeOYT6SuNH9tVzmDvPBZSs0jtND3Hu2ObTbnpYPBeP20QuO8XWAkTXgtotYn5wBdwolneHlmrc5Y6GcNnoLSuANr3AXBGZDCt43Fmpr8ruSoUazrcNtQRIGMFQqJbM6m2gCnd9yQlmo1BFUt529Pgd6p8vMNLNAZIOUrZZcRlRmDx4zRKLEpv6+prWZi5YkbHE7Abr4+4BSBU+DiawDYozeKQSpfKHyZ0tH8vue62z0OJO83HtiV5E+Cs2an1l6ez5Yquyqc8MFiKQj0k2n0Dj9KjXoinmmN8gvo5c3LKeTx8mAPFfPvyDX85eeCffkVg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(376014)(1800799024)(366016)(22082099003)(10067099003)(18002099003)(261009223027099003)(56012099006); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?43XnQQM6/1C87BLUYWuoOoaLBNR25c0BZAYdAXkBRFof88BPOAml5ddfLYfu?= =?us-ascii?Q?eR2LpBNF9O6kAcmz+CjBoGJH3ek13DJgml1c2YOAP1DyQt/ZphNBxiUferjJ?= =?us-ascii?Q?NnSQ9ULXj9QluNj9DNc9RsE/4SOrgNkB9whWhDGSfE3chovgg4Y/X9Yc0BT+?= =?us-ascii?Q?hD0jg+g6hdTQpYjbTVsQ9DwDGrN25bIx050DUqjQzTf4Cl2kTjV4Pu/tON1s?= =?us-ascii?Q?CE5oT+vLA2mjiUP8zH6GKUEmk9T8BSOgWIhEtBckCHPboRQSMqG8FHH6u5J/?= =?us-ascii?Q?8msoKnaLu+IOgmeoNYCmywYKvIvk7Y35w62/wUqfVtULsy4BeUxDp7G2dbr+?= =?us-ascii?Q?r6ANek/0fVgGMofvwgaXkzYWD2nhrVkjOhscA6xPRki9ZfClf99hHtrNXuek?= =?us-ascii?Q?6Et1IM8RDi6IWbzQsX1WM6UQRogNSxbff0dWsJ9Leae91H1VLWQGYN9GYL7M?= =?us-ascii?Q?diVEY9Fkg5wNk01Gpgr1cVkNjF3fdFENA6adOKfMESznb1UPbVNd2rsPMdw9?= =?us-ascii?Q?kvynp2EIZcE8FPz7FKw7C75FXEOVPY3BEK4P2hgNWMHxoqgqt2v4E/17eqQW?= =?us-ascii?Q?/TcwsP26k8EFxq2mn48g9f8+7kYfBnnr9lLUYhmgnmth4V4HxHoXWs8PZU/X?= =?us-ascii?Q?9SR0clQY6VCMeKileu53Nub5SSygZbP7h/KViUC9ZyjwRqqWxeq+OOeG7+qY?= =?us-ascii?Q?tYdfbAxPNGk4ruB0JVPBEnX1Dsg6KheF028bMivvwkmfrfFOjTC0PCdgTsQJ?= =?us-ascii?Q?JVpLOPIIQGDpXTEgtDws5CNXNfvxacRCFeIkDpzKCBVOQ/4ajSJYeZbsDFYR?= =?us-ascii?Q?yDVte9I2qMkBUFzlNRxT6hvZHCIW+GU0eYw0Rx9/X4FZCSD/mQNlM7P3EgOH?= =?us-ascii?Q?SBiWaqhaJzMMw6XsnuRM9iqpk61HJZMtgchjmgrkeENNxbivboXq5GmNQyHY?= =?us-ascii?Q?+D+I2lh1PLJQqqEtohWT1cKvHMQGkiVSymAofDNUHTDGqF8fNZdua6I0mW2y?= =?us-ascii?Q?hykcRf34chb+/ihTCyFyfXnd4S/rWlevcJ82lH9s0e+HVP6UHVSxMB/wfckc?= =?us-ascii?Q?D4k0VV3+Y1coNyojQR9tDq5fgHaQSCxoJs27YhxMP7N2w8IXynQB66BE1lc3?= =?us-ascii?Q?YqdKsxyZe7/RfrqZxQ3D2ftIKmOHpjO5MqFdm9bC2VYgHNP6sHRdsjaMLARp?= =?us-ascii?Q?PQVbTdJTYJVCPkjSK5wzEPOiP23JKg+NmOvGXOAiSzprNw5aI61naxyui/af?= =?us-ascii?Q?LKSR5EEt3Bv12+MVyzt6cM7aJ327mPmcyJPcQvOA0AFxqTH7DZieR06KrA+x?= =?us-ascii?Q?AtS8DF5OPD9ssw0xvOoYj36hDsLAvS3vXuWy83praN8qbA/cpekye5J/xhNq?= =?us-ascii?Q?uL60WgIBH2wAb76XvCMymYJ4anM2VdCntUpy98o2VkgfQBMe66omNN+uhR9g?= =?us-ascii?Q?s4AvMh3ddPEugUUDcA1cr5PRnCkD2hFP32kFMH1a3PXYC7QXIojBNqFJgVN/?= =?us-ascii?Q?hmJgIQb+LoXxupcGjBYtzZj0mznpOV6KKarJuUHy7BXf0Y3ldY9qT9EGxK4I?= =?us-ascii?Q?6QQr03cQ6NyJ0COiUqFMKVD4xAAl+ARL0bhIL68TdQE2+4Y01zi5zA/JJ0/+?= =?us-ascii?Q?Yp+SYND9OHP7EFDAesyU1yaAk/sMhtj6en4ImXt/WTHuVJzFtSbcFs10UbKI?= =?us-ascii?Q?aZyMrp6/ufJYS/b0jXSf4TE7KsO/IStJG+WH8Ncb4A/NaH7ph8j3+zj2UA9W?= =?us-ascii?Q?0TaNKoVfWwUCOBsJJPkJ2PDOTEOaqq0=3D?= X-Exchange-RoutingPolicyChecked: iwxKzO2JD8ypCN7bl7++cRKTqD/CwLWMwXHVWL8VPw6dfQDml1ycbbTRexWaL2o9AOqIHaatFK/5wbsJJoSAuDN/AOHQXghAB/SduTjoI29uQ5P79q/OVLv/ulvG77qbWnOAjsKbNH6McYtMSP7E2OrFZy8AI+dcdNYr9AAN3Ewp3I17wGCmPzcluhnobsQ7CcRm8QCXZdK2ObWB/sOk45Wev3pJ/i64D56zDNaX+MJeT+p2FaJAq6Xi1/Gyb9MbOaiPKOdTYLaYlXy5sqG0kt6fumLALOXxXRw+/BkAzS0UTVMmG8grEgGeY891zwBuU4T7w0h/rh5hJ2Yi2zvHBQ== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 70f51369-4cc0-490a-d509-08df2b90af86 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 14:20:53.2877 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oW3A3b4UVUpnLilZUn2yhOJFOh4z+ThO3xZfDhriDgXYFpVEm9iKQjYQIo3fwpwkR5W/pMO4dUP+7XtxJcvMPhe3WMpB2BlZF7CRNdSk8II= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR02MB6547 X-Proofpoint-ORIG-GUID: jvWUXxaD_Q9QsNvO7n45Qpegz4tyMhgo X-Proofpoint-GUID: jvWUXxaD_Q9QsNvO7n45Qpegz4tyMhgo X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX5gFwT7wyv44Y 2RH+du6E+zXblrUmRB2oFfAWzMVoNlMruBIw9HEMIhqKbbauq4tsP0UTlJyd91Qdntdi+m8Tgru yy8ee9DuMRjioHSZCtbntI+oHXXqTqPjONfNwMUIx5xmgTRcvt2RFBQSYcfiRZrf+PtKXPPMIwn 2iiYauxBvwYDLvulioSoiwb8tIo20nR2LKXWWbqHajaBHWWGpyC+85lerreAPuJDDSMgWAgWV0Y TsnDTfxQWTexFd8IR5X4K6Qk229MzBB/jSWfnbWHe2tGCT71jRA2uA0bU91waGH1viJcLZCdXO/ ZEeeP7iZigq218sGDQjhSVdxy/0AWjVB2dERYxGcH2pn8EDzQEs7bmtN/Nk6vLJM3DRS0lnXpdM 6vIH8LpPA9BgiW5ycm2VgWQ2nmqdbT0N7HGBPEoQE8vkMo373Ch5O+jwx8Wh32Erk3TT7Qi88iL SPlpHVrMadtsqCgL23g== X-Authority-Analysis: v=2.4 cv=V/ToQuni c=1 sm=1 tr=0 ts=6ad232c8 cx=c_pps a=0Uzpqe5Hikn09oORNzbshA==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=660iZSQnnn4A:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=jxMXjlTPpCISP5mWtjnE:22 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=qh9Ixq9Ib_qUO60TQ2wA:9 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX3xPpqpxDH2Ku SomnvFHplVFykTh7iX+tT2G2J/Poz+KvgiLvYhPvd+pb3oG0Ng5NylfgOO0znaawVpBeZruUghL s43RsF5Rs3hfgEEkFw7ITK+DS+9TW+M= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-16_02,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.24, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1792160507958158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell --- include/hw/isa/i8259_internal.h | 4 ++-- hw/i386/kvm/i8259.c | 4 ++-- hw/intc/i8259.c | 2 +- hw/intc/i8259_common.c | 6 +++--- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/include/hw/isa/i8259_internal.h b/include/hw/isa/i8259_interna= l.h index 7a2f9addaf..e039d6f067 100644 --- a/include/hw/isa/i8259_internal.h +++ b/include/hw/isa/i8259_internal.h @@ -32,9 +32,9 @@ =20 =20 #define TYPE_I8259_COMMON "i8259-common" -OBJECT_DECLARE_TYPE(I8259CommonState, PICCommonClass, I8259_COMMON) +OBJECT_DECLARE_TYPE(I8259CommonState, I8259CommonClass, I8259_COMMON) =20 -struct PICCommonClass { +struct I8259CommonClass { DeviceClass parent_class; =20 void (*pre_save)(I8259CommonState *s); diff --git a/hw/i386/kvm/i8259.c b/hw/i386/kvm/i8259.c index f10643a120..68607d721d 100644 --- a/hw/i386/kvm/i8259.c +++ b/hw/i386/kvm/i8259.c @@ -29,7 +29,7 @@ DECLARE_CLASS_CHECKERS(KVMPICClass, KVM_PIC, * @parent_realize: The parent's realizefn. */ struct KVMPICClass { - PICCommonClass parent_class; + I8259CommonClass parent_class; =20 DeviceRealize parent_realize; }; @@ -142,7 +142,7 @@ qemu_irq *kvm_i8259_init(ISABus *bus) static void kvm_i8259_class_init(ObjectClass *klass, const void *data) { KVMPICClass *kpc =3D KVM_PIC_CLASS(klass); - PICCommonClass *k =3D I8259_COMMON_CLASS(klass); + I8259CommonClass *k =3D I8259_COMMON_CLASS(klass); DeviceClass *dc =3D DEVICE_CLASS(klass); =20 device_class_set_legacy_reset(dc, kvm_pic_reset); diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index 45db87a2ad..547e86c5f4 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -44,7 +44,7 @@ DECLARE_CLASS_CHECKERS(PICClass, PIC, * @parent_realize: The parent's realizefn. */ struct PICClass { - PICCommonClass parent_class; + I8259CommonClass parent_class; =20 DeviceRealize parent_realize; }; diff --git a/hw/intc/i8259_common.c b/hw/intc/i8259_common.c index 17040bdb1e..ac8dc7cf00 100644 --- a/hw/intc/i8259_common.c +++ b/hw/intc/i8259_common.c @@ -56,7 +56,7 @@ void pic_reset_common(I8259CommonState *s) static int pic_dispatch_pre_save(void *opaque) { I8259CommonState *s =3D opaque; - PICCommonClass *info =3D I8259_COMMON_GET_CLASS(s); + I8259CommonClass *info =3D I8259_COMMON_GET_CLASS(s); =20 if (info->pre_save) { info->pre_save(s); @@ -68,7 +68,7 @@ static int pic_dispatch_pre_save(void *opaque) static int pic_dispatch_post_load(void *opaque, int version_id) { I8259CommonState *s =3D opaque; - PICCommonClass *info =3D I8259_COMMON_GET_CLASS(s); + I8259CommonClass *info =3D I8259_COMMON_GET_CLASS(s); =20 if (info->post_load) { info->post_load(s); @@ -223,7 +223,7 @@ static const TypeInfo pic_common_type =3D { .name =3D TYPE_I8259_COMMON, .parent =3D TYPE_ISA_DEVICE, .instance_size =3D sizeof(I8259CommonState), - .class_size =3D sizeof(PICCommonClass), + .class_size =3D sizeof(I8259CommonClass), .class_init =3D pic_common_class_init, .abstract =3D true, .interfaces =3D (const InterfaceInfo[]) { --=20 2.43.0 From nobody Fri Oct 23 14:31:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1792160490; cv=pass; d=zohomail.com; s=zohoarc; b=PkZypiPiHgw8I5y0tSwgmCqRyJK3jE0U1gn6FofcKcugCeMNk1W87G2M4itwtfDXF60rbJvFgaEx0uUqTGHTpKAfkp7me1D4HGtdIecXif3bwzMoRUuOaWN3KqR/rx1DyK8x8rLm2/dtPdFfTDoixOfVGM0fjyvLAiEa4a24cxU= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792160490; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=WF5AeoPHT0crPwuGB8Idx+PPfmDLai7p+PANfpaNO44=; b=DtOwJzbOFJ4ttYmB9nVBVLHlntPtMoYMxgN8BKNHWCQ133dcYCfN8AA2zJFMaoR2MJNT+4lmy48qLQn+Rmg/joLc3/bIOgk597Ugh5l7yKWHEkuyVKEw+0E5wZhMM4fcSR3AkEwe75WLluXXPAZoxI3zmP8gGP7p8Ez6Mf0ifrA= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1792160490313872.3562894104574; Fri, 16 Oct 2026 07:21:30 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1451971.1666821 (Exim 4.92) (envelope-from ) id 1xHinz-0000bs-F4; Fri, 16 Oct 2026 14:21:07 +0000 Received: by outflank-mailman (output) from mailman id 1451971.1666821; Fri, 16 Oct 2026 14:21:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHinz-0000bj-Bq; Fri, 16 Oct 2026 14:21:07 +0000 Received: by outflank-mailman (input) for mailman id 1451971; Fri, 16 Oct 2026 14:21:05 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHinx-0000Xp-Dl for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 14:21:05 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1xHinw-006Afq-QX for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 16:21:04 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6ad232ce-e002-0a2a0a5209dd-0a2a4508d45c-26 for ; Fri, 16 Oct 2026 16:21:04 +0200 Received: from [148.163.155.12] (helo=mx0b-002c1b01.pphosted.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6ad232ce-f659-0a2a45080019-94a39b0cd276-3 for ; Fri, 16 Oct 2026 16:21:03 +0200 Received: from pps.filterd (m0127841.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69GE5EQK3216017; Fri, 16 Oct 2026 07:20:58 -0700 Received: from byapr05cu005.outbound.protection.outlook.com (mail-westusazon11020140.outbound.protection.outlook.com [52.101.85.140]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 4hb045k1jx-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 16 Oct 2026 07:20:58 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BL0PR02MB6547.namprd02.prod.outlook.com (2603:10b6:208:1c8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.23; Fri, 16 Oct 2026 14:20:56 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%4]) with mapi id 15.21.0522.016; Fri, 16 Oct 2026 14:20:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=WF5AeoPHT0crPwuGB8Idx+PPfmDLai7p+PANfpaNO 44=; b=IL57ft5+FqXvY3lASfy/b5Yf1U5Y9lKzMVm06rQFaQVeQrAmTCszmOagB 5+F+qAXuhm+vsu3jyHh6fldauxCqc+GdJZa5jShG0rzaI0eeO60sTnTLdkCgLd42 twDTveUdh0Uo/vivPvThlNJD2wOQxGpvcw5jFoX/9NEg+j9vmMHswKK4QSo1M968 vE1Xu2nXxPUIH9JCgD0QTJyg6R4B5uDY6GJ5LAZ5hzYubKqcFtzMHCbWU85nMl9I yT9qKTtzsNll0PLLBqQjeXkFRGLnQlNS3/bwKBRTTsmMcUdOxGyxx3Cw6J5zxGlv qQew4dCNBauLE5unvN7SMOYt/Q1QQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dXL9dyRhNJ1+T+XDWaB9f9HfcMNGQyv7E7ahqh4vrjCTLVlqNnScEI4D3CAb3dPA5sFVW+WZL07hyPxY+5UdZJmvoMa4o6aATlMZzOr7hPsvRuBbG6wY9nIAQ2vVKR23otkxq7EXD81LgKPxP9NE3YVd0hpOkBVBjCAd6h+i5sPtXlQF/P4MDi1P9YPJXQfF9Kyu2I6snOw6UapI0XckWpmlJaRZI2KaORfWLOzRgTpg7ENf8SDdUsXrcmEv2KBTyU2OWKaRrhyfCadrF5cImV5aEJynk1nZ58w18M3qQ+EAeIzLgy415nOGa66OrkEMCImvYLqDRYrnYb3ARPMIHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WF5AeoPHT0crPwuGB8Idx+PPfmDLai7p+PANfpaNO44=; b=HhmrhqE0N7harBKkIghv9ieKYnnPbWB1LUIW8GFKIFglO0vXPDqpIonZ7qWgMEjU6HYMRNAKvwqxvrW32ho55ZQLYFv3IU4zbhQulhM173Kvdx4y/a9eAx91PFVNDhFoZtR8N6yQjllt0qbpfLwC7bAhil8u9mUeCUbqaXJZi3eP3oQsDkdnWF4n7xgzTf+gQDYUKvObUmOti4nR0WKxOgoLZd1FpXlxec/XA4Q1EvMR+eg50Is7TB/EQb5yKRHFh48Wlo65go+nFS6Ql1WUgSaKBvkLJsSdiroFO54ks1TKM0sfjoDC9aNQZ90Z+a93NgJPhjgPf45pSbn+mH5WuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WF5AeoPHT0crPwuGB8Idx+PPfmDLai7p+PANfpaNO44=; b=s8PQNfXLeRvFqPPtRUuYWa/R+2neOsbNcD6vUZ/LNgVQHg2w6dQcYQeMcXOB6O6GE+S0qOWRV+sGfc3NO1LbYHfgS4MFKR5G/3MyMWOVGE791j/X71q2ASbdXQePKA0SyXDP6Bp0s2dGWRVyJP9q0K9NFUWX1Ne0NDSQtmm1SKDe4IybsQXOdTsJbt7HVVGcmS1pbijs5Gic0SEJ09nMarJ7clG6Q6jBx557LAb7v75+Kf6nERpgYcerVf4WlEdOd2Rs0eH+cp0VHeTknz8R6dk826kv/GkNwqI6x/VDRYDLXrn23WgVSVcMIs6mfPPFziNOxfoLZI8fL8kZDbYexw== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nutanix.com; From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH v2 05/27] i8259.c: rename PICClass to I8259Class Date: Fri, 16 Oct 2026 15:19:11 +0100 Message-ID: <20261016142031.1204281-6-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016142031.1204281-1-mark.caveayland@nutanix.com> References: <20261016142031.1204281-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR03CA0341.namprd03.prod.outlook.com (2603:10b6:a03:39c::16) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BL0PR02MB6547:EE_ X-MS-Office365-Filtering-Correlation-Id: 4b7f2c11-d811-49dd-fa38-08df2b90b1c3 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|1800799024|366016|22082099003|10067099003|18002099003|261009223027099003|56012099006; X-Microsoft-Antispam-Message-Info: zgE61EnzlnJwmGbNnQcaYqrLejX9/l7Zf1FBzmVPf5ym5NN4+yf0fSiqrKQ8wVfhe535naiKK2iOU6MXjg5LAFGVtMpCcV12uEkHc18kDOYAUdeTgRP9Wh3f8gXpq66AfoOhWZq8q8YkXv17q3YegCO6uPEGIfFvK4YVoIQ2TCAc2aZ4jeGnoxKyDCZizyZUt0DuWyQzDm5A4HRaCaGC51AzgXxnCafg/+ktU0fwe85oifQw34VXhwVwNFJl93e9uzrxH3rUKmlL/SojQQGQzGaFy0NLDPXTI3OPnBOLYWShEW1reqjwSI+kjH8HPCOK3N2bXxGm+/FnvTm5Vf9z63Cy2TtWDJj78pCAQ7amTkd5D+DDHlsPXs59hSMRf1Fg8cZOinpO35stb0wDnUC4QdX8xy34LuBiU8I6pDj+LI5Ptzf5v3HqCT8otfno9IHV3vgUT2s8C5whc+ZeUssWWP4STL1fzghP7GGes0Iu1ZtUjUepE+oSIWfsLsA3y5ORv9PAFLt96jT8wRWhMQgFXdf0kECqXomeW6INMLlf8Aqr0m/kl9CAZkqFOjeKt+ANgvJUt2ldhqRv3PJ1+JL64x1MHxJcqm8Lxv/6eSnpSp0JTYR8N5qyAfamLPv4wHC9rmTnp3rQfa5hnRmqX/AWqi5BSqOqwdi0+s4LsqZ4q5o= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(376014)(1800799024)(366016)(22082099003)(10067099003)(18002099003)(261009223027099003)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/11Iwd8NePoOUtx0QFEWndPYBQH4iHjEfL7jwCwV33TNkh3S4sNGpkKkWZd1?= =?us-ascii?Q?alLehAJqCDFT0gmqeQL+RXWb9v8q7Tz8MOIn+Z5y649amLLkILoX77ptML+y?= =?us-ascii?Q?qRCgQqspgo29kINnWMly0P/7uJ+nmQ4vr12d5fMXZilnk59E8h5Sj06cC5dF?= =?us-ascii?Q?MZ9vLR9LXcpmhvEw92tBanVbzWdA8QKl7u3RjVrunEWxGe5uQXq5CXn4cbxd?= =?us-ascii?Q?ov7KsGrwrcnoMS7t/UMyh5TK9PzmZ/EXj28lF26ymKhahR6IWLtVhr6eFB18?= =?us-ascii?Q?QrLAglfT8U24e9hlA6OPhVCw5hOqwZp8V+6PBkovoGa8KdXGpCEvMuH8WLme?= =?us-ascii?Q?e2GvRRT/Ej9RpAXNdfFLeqWEBoxslmRq+byCfomccMgmvQR7Xz/0Dz1/Bm2H?= =?us-ascii?Q?a8P2sL8VUZU8zQJ/C1t23uRaX1BthILksia4JVhCDCPxWEkdnuIPrTGZYkUM?= =?us-ascii?Q?jVgXQY92drxRENIRTeLlcsLGTWiiODkr8Nphazj/BwpY7dQZaW7CjgUekxm9?= =?us-ascii?Q?ySbwN+YnOhcN9jgR7Ssu583olKrqIn1rQCWeKgth0e36LprsOoY0fNFFvJxf?= =?us-ascii?Q?xTrRBvATqwCZWT4XNwgwJOtRe2VBjN4JyhnSKCbZZjJzv5b/pICEWJS56JvB?= =?us-ascii?Q?zgdGcCCnl3/xTY4vdh7c+nLUie+aeid6NffEiM0eOgvpyjhbbZb1a9+m7Q9V?= =?us-ascii?Q?0o6OoHPoN3Y8DsjOJHHmLEZIUcVmjMdKZXtDenuW4BgBQGVck8w4NpZZ/nfD?= =?us-ascii?Q?GSHQke1zc0bj8V/jcxuy4kNzkI7rwUA7pXCh/5cCxGugVf7q7oZ3j5hgydi5?= =?us-ascii?Q?2vGL+3QUY+ZCQxcisy+zWicJBxgMkKjUXaqVCIrqJJZK24NiF8t8YDPCPklo?= =?us-ascii?Q?MFUurfJkHwAOX9Pl5us60v756LYoOvgpIZNw/5BHB2ONY7Tcv5j86cgDUHR3?= =?us-ascii?Q?lyvqxMI4L7RYyMguF5ohCqu7EUfiz2IkzJC3V1SLPjExp965UzMhAYxQ4XkP?= =?us-ascii?Q?07/ohivgAu9CRvTvlRv0w1C8Zz7Yfw8ZR+5GadUuh3LCfdvFHGNq6ZlJwtdc?= =?us-ascii?Q?iiuj0CELKIXiQkbrIpwqEKcz8cxFTxOum5mimqMqcPUJLkdKWHf/+rcdU4jJ?= =?us-ascii?Q?zWm1+1nE4/VbP5zG19c/phZj5N3dCQ0dWzmwaUvoMrqGEDDS5zinnXReaisM?= =?us-ascii?Q?uqZDToh2Yd7q09xDdFdVfoGAONrTLVext0fG8YUECKd0il4W38D7XabMP2Kp?= =?us-ascii?Q?enCAcH8sjkg2o9uNX3JA1RHiZLlWPzxg94pvCZiZ7ySfTkSzJjF7FXZ6a6LO?= =?us-ascii?Q?wKjluxmcIhK6f/+bmgOdBhI3VkD6DcKGIAo3PhdnEbZug3FbHeU/m9BH5W2B?= =?us-ascii?Q?gnhjI47ZXUieXIaNYgWzg4jvx1sVxxtsj5adcmDSnotaGiaX/WlL8vfHZH3S?= =?us-ascii?Q?SiTnZcdNRwdUmPibHH4YRfhNoHNcQfDzpJ3k04qtYgIS9RzdQ0A15cGC3g3P?= =?us-ascii?Q?cHh93pfKFAyEs921bJTg2tQ5Jlk+tUIarBc7kEwFnFDwc9+2YdsEnQxqXn2U?= =?us-ascii?Q?j+sxJ623XMSlFXimJiO0azLhjKTfB1Ca8G/npgqSQ5mHgGbe4HkIG2cmjKp4?= =?us-ascii?Q?IshruQlkq4RS9WQ3RTjqpxPR7HiI8buwetrSqqJTY/n26NxZfocRrLwbRVJw?= =?us-ascii?Q?mCJDCJtZYUOQIYEolY5OdmfAkufFGgKi4w5Z/W9JsRmtAIqGk2fNEBDLQ9zi?= =?us-ascii?Q?qCTG8A/CnWpoNzMzy7Yjx/NQZeUgNpo=3D?= X-Exchange-RoutingPolicyChecked: xkC7VepcR6NLCgyuIsbZYg3STBiuU4YbGSZDXNqxLrdgZcHVILD94rbTqCMHgR3yT+j/Tx/5e/nsuVviLO4gBGYeHu+atvCmUxayEcXpHIHxb/R48AS+cFg+tqm+X9qFZfp6TIAoy+ZcWE6WvwmhwMqMaSn2lQyhDPCSevZHOgnhYFpUASTX+GLK1wXG6Ls8y3LsW+kKgj7U/FN7ZRT+gRmMANsyH5ObQeb4eKR3tX9AGwGxEP+HLg1GqjlKPcbr6gPlCoWJqJ9k7J2/iVWL0GmEFCsaUNykw4hNvq56gmsk6NHoOJfeKUERI9a30qfCJor8z7t64Eaw1zRnfF53zQ== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b7f2c11-d811-49dd-fa38-08df2b90b1c3 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 14:20:56.8698 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Fqiy9Hf/UQwpDJouxNQwX6mLOohfndE/LCQXvVTLrx6AL9ntPfh8YAojms3Q0J8LZTuImQSnocX7LvdMTc9gVa8rb4kTvp1wt1+dpcqVxE8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR02MB6547 X-Proofpoint-ORIG-GUID: bv-vv57VaUbVt5VsAORtPjcAszYEGDPv X-Proofpoint-GUID: bv-vv57VaUbVt5VsAORtPjcAszYEGDPv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX6KLEHSq4fgdX LgM0nFwxOUvJjC+kVA4XLJQVViT147ljYYZ58SvoKiKYZN1t7R0PwlF2a19TQqVId7/wapEepPZ HsAeFkVEqZdLy6yg/DBNsKniYdfvKwuh+aHfr5lHkGupmVlUxcEfJWFQNBsNn9inDsrD4nBHKKl 6A+c8/T5hdteRbb4CLjKDa/gAr816mSVS8/56o+8nWB0wFeKVP36N5vt7FhCjCNJH0vi1sM4ZXA IhRtDPcZ4OIqchdefZUvuH3CnAct0TlpZjoyCgxBMqiDh9syJYfcb5t7dVokMHmS0Ww6aIs5nhv LMFEEaYoFwIeUAgW42UV2aQBHxm9Hyke1Bv+PrZyDAAtDzQPPwz9g2x01cycCYOBJBFFrbRv1hU 9mKt67NhfZSGl/PVF91yioTFbLwuake6ZBrFwNxFOCs/8FnrLwH9fwEeLWWH5aEtEfoeBLCXqmE XjJh5OjTW/PcwKYlt2w== X-Authority-Analysis: v=2.4 cv=V/ToQuni c=1 sm=1 tr=0 ts=6ad232ca cx=c_pps a=qT2ADiACooojDGKohgXUBA==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=660iZSQnnn4A:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=jxMXjlTPpCISP5mWtjnE:22 a=64Cc0HZtAAAA:8 a=VZfxMas_8fVelDOVPvQA:9 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX3IgsO0r50NJf cJdwP/Soo9Jh3cArSnNbNAVxNZPsJslTfYPliElJ1rzOCWb2Kfx1qzPxWoR4RjhzsYm8VJP9DXI LsbOlfhP6CuvPgPLdZuBX6Oa7nmD0jw= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-16_02,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-c1860d/1792160463-CC37587B-F1FE5293/0/0 X-purgate-type: clean X-purgate-size: 2287 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1792160491525158500 Content-Type: text/plain; charset="utf-8" This is in preparation for its use within a QOM type presenting a single emulated 8259 PIC. Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell --- hw/intc/i8259.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index 547e86c5f4..856075a754 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -35,15 +35,15 @@ /*#define DEBUG_IRQ_LATENCY*/ =20 #define TYPE_I8259 "isa-i8259" -typedef struct PICClass PICClass; -DECLARE_CLASS_CHECKERS(PICClass, PIC, +typedef struct I8259Class I8259Class; +DECLARE_CLASS_CHECKERS(I8259Class, I8259, TYPE_I8259) =20 /** - * PICClass: + * I8259Class: * @parent_realize: The parent's realizefn. */ -struct PICClass { +struct I8259Class { I8259CommonClass parent_class; =20 DeviceRealize parent_realize; @@ -388,7 +388,7 @@ static const MemoryRegionOps pic_elcr_ioport_ops =3D { static void pic_realize(DeviceState *dev, Error **errp) { I8259CommonState *s =3D I8259_COMMON(dev); - PICClass *pc =3D PIC_GET_CLASS(dev); + I8259Class *k =3D I8259_GET_CLASS(dev); =20 memory_region_init_io(&s->base_io, OBJECT(s), &pic_base_ioport_ops, s, "pic", 2); @@ -398,7 +398,7 @@ static void pic_realize(DeviceState *dev, Error **errp) qdev_init_gpio_out(dev, s->int_out, ARRAY_SIZE(s->int_out)); qdev_init_gpio_in(dev, pic_set_irq, 8); =20 - pc->parent_realize(dev, errp); + k->parent_realize(dev, errp); } =20 qemu_irq *i8259_init(ISABus *bus, qemu_irq parent_irq_in) @@ -435,7 +435,7 @@ qemu_irq *i8259_init(ISABus *bus, qemu_irq parent_irq_i= n) =20 static void i8259_class_init(ObjectClass *klass, const void *data) { - PICClass *k =3D PIC_CLASS(klass); + I8259Class *k =3D I8259_CLASS(klass); DeviceClass *dc =3D DEVICE_CLASS(klass); =20 device_class_set_parent_realize(dc, pic_realize, &k->parent_realize); @@ -447,7 +447,7 @@ static const TypeInfo i8259_info =3D { .instance_size =3D sizeof(I8259CommonState), .parent =3D TYPE_I8259_COMMON, .class_init =3D i8259_class_init, - .class_size =3D sizeof(PICClass), + .class_size =3D sizeof(I8259Class), }; =20 static void pic_register_types(void) --=20 2.43.0 From nobody Fri Oct 23 14:31:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1792160500; cv=pass; d=zohomail.com; s=zohoarc; b=A1bVLLLFfqRIsTFwVIxa5/INIAkM5kDsew7gM5BPSF7dnbsGflu1Bzwv5iosd08GZicIwcyO5cfzX5h75HPQ1J2as1XvcoTQc8FY8zXAW7EQluJAVDNoKE/xwpN/zqzNQnMBMpvnIy/UiBpBHQmg0/gYi67j3XFnswD5kPE2gX0= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792160500; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=VvBsGWO4glzVmPvokyxe2Nx7Um1RGGQAso/hL5pwNeA=; b=nsL9EMgf69TEq48/zy+jS6yF0kkoNxWkzqFVXc/rHywnvx4u5sR0G3Lo//sfkp7QhGpemDkaNEZgMavJecs4NrId7Bkp8nUlBSV9KBwsztg7quwW20q7udHLhfRud/ihZ9cq0N1ye1wW1cbZ5iF+fxuH/ApNOOZouuW4rRNYLPM= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1792160500282177.8766356122893; Fri, 16 Oct 2026 07:21:40 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1451974.1666839 (Exim 4.92) (envelope-from ) id 1xHio3-00018K-2o; Fri, 16 Oct 2026 14:21:11 +0000 Received: by outflank-mailman (output) from mailman id 1451974.1666839; Fri, 16 Oct 2026 14:21:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHio2-000187-VU; Fri, 16 Oct 2026 14:21:10 +0000 Received: by outflank-mailman (input) for mailman id 1451974; Fri, 16 Oct 2026 14:21:10 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHio1-0000sl-Sk for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 14:21:09 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1xHio1-00CcOg-9a for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 16:21:09 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6ad232b9-2eae-0a2a0a5409dd-0a2a450584d0-42 for ; Fri, 16 Oct 2026 16:21:09 +0200 Received: from [148.163.151.68] (helo=mx0a-002c1b01.pphosted.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6ad232d3-4cb1-0a2a45050019-94a39744a9f8-3 for ; Fri, 16 Oct 2026 16:21:08 +0200 Received: from pps.filterd (m0127839.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69GE5Trn3245884; Fri, 16 Oct 2026 07:21:04 -0700 Received: from mw6pr02cu001.outbound.protection.outlook.com (mail-westus2azon11022077.outbound.protection.outlook.com [52.101.48.77]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4haxj93890-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 16 Oct 2026 07:21:03 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BL0PR02MB6547.namprd02.prod.outlook.com (2603:10b6:208:1c8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.23; Fri, 16 Oct 2026 14:21:00 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%4]) with mapi id 15.21.0522.016; Fri, 16 Oct 2026 14:21:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=VvBsGWO4glzVmPvokyxe2Nx7Um1RGGQAso/hL5pwN eA=; b=FFg5CeVG+OKgNRMkGA8NQ4mFm0qcmaCJ4HnGoRwj5eEZde7P7+G20fEyU /mWhgUg7gEXT3SLg68G1pFb65F09eCOwr6Qfsz0hHYrw4aFFXsWttGwVoYXrVoBj 1GKkcHS7t169KEm/U+HikJ+lJuR1nLGsStPYN186Ddst8E2jVSLUFR1E1RtzxpPs I6OD5XGmiPWcKxOrgNmVb7nmI1cRqYuj3on9CY7Fdh2WaZ5oNAySsj4Gm00wco/p rrEfVOYfFTRGxSmCsGhoa9hjPv71FJ0R4RlIOTA8SD06WqatifltlR+yq+aSpdZc Jd+zMReC777biFzn1wEUBh8ggC85w== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tKCNWUkoAoZiZKq+siglnFjaXfbpqRYExET0dYXpe9AfAcV1n4N8su4hjs5Amu41KIRR0HxkVfx6cPaOIEnbtsPvZgeIZfnnCSk7LEgbPVywzqOpYdl+ayT3m2zOCDDCxaEcIeKZP1gCMIZ2I+Z+2wBeGt8o3/UAodAXcMqvtGeEbIBDfbR2xOVsFjXKtY2/FtYTDKiwGGMCd+Ml5Po/JOrzJS6DWT/Np16mqL2AoKIgQMQ9becGT+gGphnUg+oLxZQp4QY6+fLO1nm8J0N9IGEzNtkKOQps/iI+BZXUons/iT0h/zArRUtOMpztAjhB0ZcVNbKmyQXTWRBtZCTxPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VvBsGWO4glzVmPvokyxe2Nx7Um1RGGQAso/hL5pwNeA=; b=ZDfzwFPi3CIbDYj7rdZsOBle17mtKbunRbHjtYMCRCJK9+Hw/zhlVior/4dzj/b+6IWGnij4N9ZVZfMm+GKGEhaojxajp9LlQvCGJj82knOTks2ur7iNsWQKDfqxLLBwyk+3h7JYamG79yZR1enWhqKA8rAllLYK5Gftf7BSiIicfdAAERRPGdayM7Ly866fCgOI4b4z+lTmOpPD3YS5FsgrJHOMVv0W2aciw7QXt2GM6oSD9J25XVRYEA/C4TxTaWFg69WQanlkRT13LOamUEdh5htmAezEMf26huYCt3TJUey2U6UL4buqaXWWg3x8l4dNMTp5TT7vndRcZrM47A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VvBsGWO4glzVmPvokyxe2Nx7Um1RGGQAso/hL5pwNeA=; b=qhIsngsoencFWzN7xc9csW9t8OYrNZNe0pW9HBQQYN+1/+j9aNk3lJauF3lEEvF6TUI9dfEp3WT1E20N9KYzsWqDxXnEbu1/Jbt/WqWSnfXY21D6MqqEXS4JU4HgNXPeHLfXe/RXXMqimLUsZNKpubScBg6/0FeVqSBmIiF0NawBxGIvp7qyaOksdsV1h3nIBjbDf6JerFDCFnrl6PhcnBEP+TqnoJunzg+afC0C4bRPS1Wpx9EgyiIfZRh1nhbI5AMK/Lelkb7lNjezFNR9SzbEZYt0rQUbAw8cR5UKrtnbdWVTa0xxfMmJ+YvZU/bi6xvovEu3h9PD8p2DOL3YTQ== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nutanix.com; From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH v2 06/27] i8259.c: introduce TYPE_I8259 device Date: Fri, 16 Oct 2026 15:19:12 +0100 Message-ID: <20261016142031.1204281-7-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016142031.1204281-1-mark.caveayland@nutanix.com> References: <20261016142031.1204281-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR13CA0149.namprd13.prod.outlook.com (2603:10b6:a03:2c6::34) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BL0PR02MB6547:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d1b002f-fe0e-45a3-9c86-08df2b90b3de x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|1800799024|366016|22082099003|10067099003|3023799007|18002099003|261009223027099003|56012099006; X-Microsoft-Antispam-Message-Info: 3GkPqLbrJbMyvJCWksV3LqFG38XBys+LTPXEuPoe2KFgoh2BoOqokxN2pjfc32jGbxr1SHXpvTT93xOjIYDpy67p3fHlhUkwuKZ4DUuGHh0spl56hAsR/EfURNIeP12DXbTX6ueu7uHsQaU5iKSf74uzAHhU9ZCCbRbwMwUaKoefKSl1wPJ7PUPClaHrmfH+g4ZTCz01pGbpdkOHakaoyjB8bPah8AAFbveVw5yiHQ4EjWQbMj+L8mzyK66YGb/klntH7eDB+GC4Q3aWvu4CBwCplbUg6dEKiPS4M2oKk5xSr+09gljzCQSbFhZeJNvGPjH5iPe/3XLoS2qwphpLfOvBxCqDdNlbEkS+URLdAXWRRvgEaDLlyXgUj58caLNo+Dx975pEX9LJQAzVKXo/qg3KbJHkJxIcWC7kW2qHNdtmyJ1fZq5PIjGkMR8RTMUppBQcfB014qj00xBLM28UvyyoaMMgcQWyB8nx3aSiQpWtuY4JsVrDQsD+etXpj6BLfbLgBqJnDnfba0CgKwh5IYzzLCBYj0HlsahCI3c6Lgd1GvgPoWKxssNTQiPw+p2lDl0W7XGPbYSadqBtmSN1qvDcRFpi4+wR4kvVmJO3kQXe6rW5ykPglO3vdgZJcv6DhxeASB1ZvtgdUlLu4IG2Ssjrk8IPuEiq8r6KrmvJh60= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(376014)(1800799024)(366016)(22082099003)(10067099003)(3023799007)(18002099003)(261009223027099003)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QJ5F7sNAs3c5JqTMEVyFYm4LYEo/9iF8sWBPpKgb/xnKlcgaeewPCG4mL3U5?= =?us-ascii?Q?kodXdg0YHxfsPB+N2/RuHkWf8pqDCxwUFF5JMTiCSR0wU3kWX+Xw4sDlgFpN?= =?us-ascii?Q?CHi0PdvSxh4IA1YaqcdmRtDz83aYSI/5mCbiu1Q2Gne91zphqD2FPR0m0Mf9?= =?us-ascii?Q?0Ok0TIFJkR6T0gsMOiey7yzVYjb0L2jYlWkQHt4XfsJlRIn6Ou0QL2mlmKmh?= =?us-ascii?Q?sUlwCNM0DWFMweyvWQKZ08q7ZedL5n9Yc3Nq3u66xZS0+4emxVvsjaKpVfrC?= =?us-ascii?Q?0JiGVBNPp1Rrj4GVPG4ifuxxMZs07QrFdjEVt0m2l1UYnecgYiFjKssadrMs?= =?us-ascii?Q?AQ2xlPDY3BeC+gGhBAmxSR/48Ncq9itekO7mgTtElkoguk+XbnWp8VfGahXL?= =?us-ascii?Q?J75YsZqo2WlW1NmcNIcmAYE0a+s2g1MvaAp1pffej54Xgelc4vFU1CeUsJp5?= =?us-ascii?Q?Es+rURa2puuH7dW36nnj6fwsVfN6/hJ96Zp9pQwal99ZBnTTVsF2QHVhj+yo?= =?us-ascii?Q?f8iz6VUDYsGY+qFMxK6GNjYsb0Pp2SKdYlGQYiaWBYV0YyiIobVueg2uWbKw?= =?us-ascii?Q?1+qKx1mGYOHHSFXUAXveieh+PJOwCwAqGoYCOxPSvLQamRzbBkOSEwk76kRd?= =?us-ascii?Q?MPs7T+LJ3FbvomlTw+no9Ug6U9HZOVdMtwT7K3ohfvzKcZ3OdZrUz+R1YSE8?= =?us-ascii?Q?ZaNUjbwOe9krKnkOwvp33MlulxklPXeulpRzbD/KwawblSoXp7AQQe60aINW?= =?us-ascii?Q?Pne9QzGy96hmKwmUwvcV4jnhWj3NoM3BwR0aJrc5U65xPwOOvBF4d+jKmMuX?= =?us-ascii?Q?ezuxMAW8Uw8mbzy/CpmWoPJ3IaLKQZBOUmrNn4hUqwFA5LPtdHWemiMzMmDn?= =?us-ascii?Q?g8gfGya6PUbSkEO1QAMGYO4/fmF7pbJpEnPXaKcbbK9q/DhB7I/axZPbir8D?= =?us-ascii?Q?IX/lA6xt32/qqKiPjZ+AGd0OpuhAIiNP9f0n2XaePUHu8M6/3jgvUaawVQm+?= =?us-ascii?Q?xgt/G17c+4qRt/t582+bOFgQuQJN4cvyltSKDGldJ+1M7BvskEYOlWrjmbEL?= =?us-ascii?Q?HYueKl6nnbBJ+H4rMyAjsgPDfYh8fkaw+bd3ZSN4UKAMxVHXBTmVfMTs4Cz8?= =?us-ascii?Q?hsVOtSsz58tBr/dfOtgoKlCiqtqOrCfb6Wp/LKdZElVMMZXR8Q3LsKuZ+jtA?= =?us-ascii?Q?uw5bJZdV7zZXOgsHmFxVjZCFCUzB89kuu3lZIhlg0l7bL5xltwpU8uJdYoZG?= =?us-ascii?Q?5wXinSFfs/rD6qZzbmt410KB4XWEhq3D/tQk8o7bv8rHVCQFZjwSJqI/4lAq?= =?us-ascii?Q?piMquyBr7waT/4RFNJ0OwXTnVPTsulu4pSLN9ptppntBVrptF8agOjIcP3Mp?= =?us-ascii?Q?7iA+olLowLS5MJz82nTrlHDfmXOd56LMNS1jTO+Urvg62Km0VGWur4TinY3I?= =?us-ascii?Q?dSV/OzbJpXK9Gewnnn7I7EBokEdo4c2hZNcc6kqmg7lfqHy2EgwEf38ktozu?= =?us-ascii?Q?ZeI8l24zZn0tZZAJL9XfL/nfP3Gp8kbwW0gPOjPjnGKaBuJezL25/ipeY+M9?= =?us-ascii?Q?V0/zfMqVjbrEytfn2qLu5Y7St+Eh567jAjZurWOj9nMpLsFR6sMrhIKY1qc+?= =?us-ascii?Q?KTxXozB6xlduUx6jwzlaeaDY9m0xyBUVnSlfrg3oZ2EAUwuqov4aXCfJbu8g?= =?us-ascii?Q?miF0gBiLiU2DJfII5TVrIXyDH0zJ5fwoFIuff3hYl2lSqHyFoFSuw6ZmCMM8?= =?us-ascii?Q?IA0M7xylpcaGc1CiwTN3VlRMwnPrqoQ=3D?= X-Exchange-RoutingPolicyChecked: qjLX3P5CXEXXlU8Uwz/57+EqPtY4KBL8E++oocg053R5pna1KMQXkeNbS7nolwodKTrbnpG1R3cchwbrh7JMpalJuO3grk6vKJEFjBgmnKciI3BnAiLPtUpS1igIjZ0/QKm8fsY6L1kFw0xjOlBYRkRkQhij6Sr9mB+x++GGoKkrj6PhketIodXDvxgF2wtlhrFJTHCoy3y5j92xtt4afkkC+Qjo4AVqYOytpoXe5Da1UC1x9rUIrDiL1kMm6r+MthSAIGoyvaza63rCCER6LVPDigOT1sER2tW72kwXQOlbnQm6RNYoQRfJtQhbRa5RxZg9GRozDOCrY+kZiv2iRA== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d1b002f-fe0e-45a3-9c86-08df2b90b3de X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 14:21:00.5139 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yhqcFWdzDQb6aRlQ6kAFow20gkf/RPBHVZxncvFbwMVYou7vp9jYTR+gAWsxYWrVek0DUchQSHg6CvuBiMFeGswsKbyAmywxyJE/cm40Vgg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR02MB6547 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX4qJbuS5FJYjO zSY/FoEPEhFpcV3ct1RRsIlH81IhU2N4tO0faRHZ75ld3ilq6Ma4nbhIuHCWdZDxk1D4TeyrtMt mnruAXTZ1ebQoskZo7ts3HrQaMUJRZo= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfXymmzam89rSfM 9dXYgeNB90LA1Akbc8W+1L0sJMagiEPn1kKKmHHzDs7ZyRi/RyAi7knPCwic4+5iScGE3KyLmBb nA65dHbYtutlpegcXw7f16c9Uthsp8v7eu/6ZRo1c+uLlud8ZXnYse1R6ksp7xHlRxvLGkG8ib5 vfsaZb/N3JSrZgz/sxecpKCrP0AkdOjOumqYTQgs+hWJYKGa3IQyNztmOgnWann0627l12VvdKG 6v0duc/LO9y1d4RUWk2I1c3fQzOxmWmvPQJk05k4WsZcHbj4dezqwDt8StrY/x82N7cH9aHkoOu N0YSL5VZLQowisa6OsdwVZRqgCEW0W/U2D/Vyi5jOS5EdRHdPYDekg4/0CZGgR9oPTrEB8VfuED 7mY+5+3y6JW4UNDwsC7Jkxtcxor/3rVyW5etC9DOHez+wsVYTVesV2lyy7HaV2yKnztK6qZEle9 xKCkdxSVDQm8LolOMQQ== X-Proofpoint-ORIG-GUID: Mpch45Wwd0GRJIoTb_E0UajNookbBLbI X-Authority-Analysis: v=2.4 cv=ItOL47/g c=1 sm=1 tr=0 ts=6ad232cf cx=c_pps a=PNgX5FSHJLFuI9i88Gvv6w==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=660iZSQnnn4A:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=y4UcunY2MAxhM4LwGdWI:22 a=64Cc0HZtAAAA:8 a=RO_YwWr2CJXTu7lAkVcA:9 X-Proofpoint-GUID: Mpch45Wwd0GRJIoTb_E0UajNookbBLbI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-16_02,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-c201ff/1792160469-F60AA2A1-666F1589/0/0 X-purgate-type: clean X-purgate-size: 3892 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1792160501698158500 Content-Type: text/plain; charset="utf-8" This device represents a single emulated 8259 PIC and its associated class = and ensures that we can safely embed the device within a container device. Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell --- include/hw/intc/i8259.h | 8 ++++---- hw/intc/i8259.c | 33 +++++++++++++++++++-------------- 2 files changed, 23 insertions(+), 18 deletions(-) diff --git a/include/hw/intc/i8259.h b/include/hw/intc/i8259.h index 1921a30371..87ccd55a4d 100644 --- a/include/hw/intc/i8259.h +++ b/include/hw/intc/i8259.h @@ -3,9 +3,9 @@ =20 /* i8259.c */ =20 -typedef struct I8259CommonState I8259CommonState; +typedef struct I8259State I8259State; =20 -extern I8259CommonState *isa_pic; +extern I8259State *isa_pic; =20 /* * i8259_init() @@ -16,7 +16,7 @@ extern I8259CommonState *isa_pic; */ qemu_irq *i8259_init(ISABus *bus, qemu_irq parent_irq_in); qemu_irq *kvm_i8259_init(ISABus *bus); -int pic_get_output(I8259CommonState *s); -int pic_read_irq(I8259CommonState *s); +int pic_get_output(I8259State *s); +int pic_read_irq(I8259State *s); =20 #endif diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index 856075a754..81827f2734 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -35,9 +35,11 @@ /*#define DEBUG_IRQ_LATENCY*/ =20 #define TYPE_I8259 "isa-i8259" -typedef struct I8259Class I8259Class; -DECLARE_CLASS_CHECKERS(I8259Class, I8259, - TYPE_I8259) +OBJECT_DECLARE_TYPE(I8259State, I8259Class, I8259) + +struct I8259State { + I8259CommonState parent_obj; +}; =20 /** * I8259Class: @@ -52,7 +54,7 @@ struct I8259Class { #ifdef DEBUG_IRQ_LATENCY static int64_t irq_time[16]; #endif -I8259CommonState *isa_pic; +I8259State *isa_pic; static I8259CommonState *slave_pic; =20 /* return the highest priority found in mask (highest =3D smallest @@ -170,11 +172,12 @@ static void pic_intack(I8259CommonState *s, int irq) pic_update_irq(s); } =20 -int pic_read_irq(I8259CommonState *s) +int pic_read_irq(I8259State *s) { + I8259CommonState *cs =3D I8259_COMMON(s); int irq, intno; =20 - irq =3D pic_get_irq(s); + irq =3D pic_get_irq(cs); if (irq >=3D 0) { int irq2; =20 @@ -187,16 +190,16 @@ int pic_read_irq(I8259CommonState *s) irq2 =3D 7; } intno =3D slave_pic->irq_base + irq2; - pic_intack(s, irq); + pic_intack(cs, irq); irq =3D irq2 + 8; } else { - intno =3D s->irq_base + irq; - pic_intack(s, irq); + intno =3D cs->irq_base + irq; + pic_intack(cs, irq); } } else { /* spurious IRQ on host controller */ irq =3D 7; - intno =3D s->irq_base + irq; + intno =3D cs->irq_base + irq; } =20 #ifdef DEBUG_IRQ_LATENCY @@ -348,9 +351,11 @@ static uint64_t pic_ioport_read(void *opaque, hwaddr a= ddr, return ret; } =20 -int pic_get_output(I8259CommonState *s) +int pic_get_output(I8259State *s) { - return (pic_get_irq(s) >=3D 0); + I8259CommonState *cs =3D I8259_COMMON(s); + + return (pic_get_irq(cs) >=3D 0); } =20 static void elcr_ioport_write(void *opaque, hwaddr addr, @@ -418,7 +423,7 @@ qemu_irq *i8259_init(ISABus *bus, qemu_irq parent_irq_i= n) irq_set[i] =3D qdev_get_gpio_in(dev, i); } =20 - isa_pic =3D I8259_COMMON(dev); + isa_pic =3D I8259(dev); =20 isadev =3D i8259_init_chip(TYPE_I8259, bus, false); dev =3D DEVICE(isadev); @@ -444,7 +449,7 @@ static void i8259_class_init(ObjectClass *klass, const = void *data) =20 static const TypeInfo i8259_info =3D { .name =3D TYPE_I8259, - .instance_size =3D sizeof(I8259CommonState), + .instance_size =3D sizeof(I8259State), .parent =3D TYPE_I8259_COMMON, .class_init =3D i8259_class_init, .class_size =3D sizeof(I8259Class), --=20 2.43.0 From nobody Fri Oct 23 14:31:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1792160540; cv=pass; d=zohomail.com; s=zohoarc; b=FF+QCUHwUrIsdTM5QkEDq5by/1ZpByRztVIOQ0Id/Zzqma/BWLJPZUZJeFzbU3XALJJZZMFElqSyl/A+Rw+F0V54EviRlRjuIDYNFfEtOOLoe7fZiWHRmzvv0kIYypLYd4QOExXUD9VuA1mtzyGc8tnOdxooHXUA7gBktnFmAso= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792160540; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=svd63FWM8ezPOcqPD+qPN+weE2ncrsjkAO4QJk1oYwU=; b=nDLJUjmoN/IQt1RuTmFIzWbm7iXoqwlNZCL66KnWDOn/v8NBdtbNSKoKrFVlxYqPH2vm6LGvTFL6uJnKXnHxtSXq0dZeswN+fIZ2ZQvtSi3OarvhUKGfI1I51Gr+a/KZ/gKD2mHJiDbXhYDLbYBkkTTGQ3jXzshGOw3XFmjbYO8= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1792160540510152.23165752170303; Fri, 16 Oct 2026 07:22:20 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1452000.1666894 (Exim 4.92) (envelope-from ) id 1xHioi-0003pt-G1; Fri, 16 Oct 2026 14:21:52 +0000 Received: by outflank-mailman (output) from mailman id 1452000.1666894; Fri, 16 Oct 2026 14:21:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHioi-0003og-5Q; Fri, 16 Oct 2026 14:21:52 +0000 Received: by outflank-mailman (input) for mailman id 1452000; Fri, 16 Oct 2026 14:21:51 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHiog-0003Nr-Kb for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 14:21:50 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1xHiog-00CcZL-1D for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 16:21:50 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6ad232e2-2eae-0a2a0a5409dd-0a2a45019786-38 for ; Fri, 16 Oct 2026 16:21:49 +0200 Received: from [148.163.155.12] (helo=mx0b-002c1b01.pphosted.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6ad232fc-5984-0a2a45010019-94a39b0cf3e6-3 for ; Fri, 16 Oct 2026 16:21:49 +0200 Received: from pps.filterd (m0127843.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69GE5MK63333355; Fri, 16 Oct 2026 07:21:42 -0700 Received: from dm1pr04cu001.outbound.protection.outlook.com (mail-centralusazon11020128.outbound.protection.outlook.com [52.101.61.128]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 4haukukqe3-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 16 Oct 2026 07:21:42 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BL0PR02MB6547.namprd02.prod.outlook.com (2603:10b6:208:1c8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.23; Fri, 16 Oct 2026 14:21:04 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%4]) with mapi id 15.21.0522.016; Fri, 16 Oct 2026 14:21:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=svd63FWM8ezPOcqPD+qPN+weE2ncrsjkAO4QJk1oY wU=; b=DFydhXXBiNoUqUJ8fa1xVBvWZn45jOxUyFWbvXuqBUO0fdvZCf3XWv1PL eFFBLUQBZInJolYQZTw3u8WgIYHdwbnXuykvDbmmPawlx8emg8UAPc5zQ6uCzqTy n7dj1uWZ85fk2kPc8ZsI8XO7qMosj7UU2FNRMMO0cpMXYFRI9yxSW5gFJF/HYHN6 +5+cTZZ9c5y0fZdAsAMVxD9isPKrmApgvsLVcocmDf93FvbyLvfb3mfViKKchfSN rFAOMSr+MEJoTSFepiuTb5jKCoQyNsRezXvnu6tg5grRV9Wt4SsmIWsLGAFFjVcN fj0nQz+D9msvpO0LEwEHRpTjcQezA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dJ0Ucik/WbJY0ECp/LUc3fWzhj8cUWFFjcin+OgCR0YmMHD7DsZVQ2UUHcBdQq0emN2fRCmSSpdtvfyDtmMOGJP/ou6TlP2LsU/0KgzDGLCeuLVYfHLwP2cnYjwS6rvDXYBLN2yVsjq6us9AB218yN9Lzn4r31ioat7NQz7RoKX/8vwQ+NH/20fu1M9qGs8gceqTKqx7wTqrnbSWMm44fzfiCVaSPUEiegvNHm9CHidCkMDDu4J8TXbQVp6l2/Xb2RTcwtCzEF1kTasxdvbrIJmm6yOimYNFSNY4smRg0ccox1zPd8/g7j+QPQ2ksRE8bXuS2ec8MCKWGlywVK1I8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=svd63FWM8ezPOcqPD+qPN+weE2ncrsjkAO4QJk1oYwU=; b=Yvk6I8Tq1iBo0r3BddTE3JxYtR9XFAbTB7UydpJC7kd63X+C6Nt/LQU62UCI6KlBZ1qPwcqg9H3jRsvL/TfXMoxhwe2jYr1VZKTawYkkca8z4tE80QUjcsIo7ea5M8xu9wgm9OO0EyJ+aSf5wI1WDeRoal6L1N0NgSn9SfLeUVaBw2iqC0H01eHpZcK4/BiAZAikeagCVtAhK9hck5lbWGSZR6PHHmfK9IDAptVW8SJcnJ6ugYgUXvYlGew8x7EKY+gwpk41qT0p2iMPR12xvcNkvcHPAmXNPrpZROtqoVTiKosdEoXiDjwhkH19/7tXtXOnAEfVbBKXT32QzPSPrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=svd63FWM8ezPOcqPD+qPN+weE2ncrsjkAO4QJk1oYwU=; b=JSnxeOocyOfp+goIvlf9AdpGJ72Rl502rTC91odWNxpGGEErnpPyQn7J5jittPaMVzZeYe7aKdIGzGh741xGLYQc23lMSCcShHRz8DlC/Lt3O85RK/lFkkGC8XV2wrg8hXfjonHBAy9bOeeX8EZglenUBHZ9kHHijWcpMmirCKX+8i2OI0euo98zyOtx0tVU6/XErL19wMxJp6RvU5vC3i/6RDHpOcVv23PdpbMX4ks9N7ii50a70ZxWzvn1mFVCxo6r/HiiaorA+X4zeTXkp/ZPkuc0xtIA5/GvlW/zuDw1/FEBDROgIurkAM7/6O2bxyKBj8U7dppX4YOtlekafg== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nutanix.com; From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH v2 07/27] i8259.c: always use cs for I8259CommonState variables Date: Fri, 16 Oct 2026 15:19:13 +0100 Message-ID: <20261016142031.1204281-8-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016142031.1204281-1-mark.caveayland@nutanix.com> References: <20261016142031.1204281-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR05CA0062.namprd05.prod.outlook.com (2603:10b6:a03:332::7) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BL0PR02MB6547:EE_ X-MS-Office365-Filtering-Correlation-Id: a0948d43-d9bd-46f1-1fe6-08df2b90b640 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|1800799024|366016|6133799003|22082099003|10067099003|3023799007|18002099003|261009223027099003|56012099006; X-Microsoft-Antispam-Message-Info: CsPLnfRjLNbQMopmTB5fZvif67alPJET2IBzMxeK/7y9ajUh2S5hOxAdDlFH8AONFtQzPJJKvXex2k82jHLAZQw3RxwfzEFbUG9+FWvZ+qNKHP5qGOwPfIElYRZ4DkI2moelOLLLqKoHEL9WAozBPH2FRnGFd9c1BqJGV2ME60477zaKpx3H4L3fGKeJ63Qf2myZd4PJAOrirgfmhgSZJvRUL1UPJR2WAHhI23DddpeNBx/QibUo32e61C0k7/xlcdCifyfCyL2+7FLk4k769bbr1w8/S1IEGyOxtK+SHkTJlt6RtyuxPthmJZ7aNel53wSd6hk5hW6m3Pu40RiKZcYExEtd0XIRWuM8w/4RqCZ810GR4MjJVimTZ+m9kq3RW+lSqE2C4kisRqPc3b/+qwrpI2A3bjwa6SCowCrNYqUjYNVsbsDuty2/hZzhMGDdBY/6jBL44bjyNDCiV9wDv82fXhab6LAfYJlzLqiSQK8WYK7x6bG63E59MjsK1pPOUI7aOyKRbyTHPnjmlHAsp6M/U8U0uzrtsCSk33Zcz9/5or37gaGdl1dwnhwZ+o7Tboig0USqr4NcfJnEnHrpndpXNrsp0tUQOjZcNZpBTOJwDjxlqJfmi9q6WjMLNF0UWZ3xsBdZatvVHzp038RwKqbD4aW2EO2tlNLNIb7K0Ck= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(376014)(1800799024)(366016)(6133799003)(22082099003)(10067099003)(3023799007)(18002099003)(261009223027099003)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?O/jKcjRbR5fUNDIN/MvW+6q4t4e7YYHLJbmIdJAzy97Yyi7m6c7/2VLeQ/0o?= =?us-ascii?Q?9leS6I17V3AQGLBjpH3/1fnJ430E6lHWTtJKp1j2KD5XF1oETh1zVtHau9S8?= =?us-ascii?Q?+nHp3wwbSeb41FXUEhPr7lNENY/qfxIUx8JdJ05Nwft6F8hbr1DndwHAhozs?= =?us-ascii?Q?doInN2k5uOAFNe36GwsI8dmvCZavAgct5MiiE7j+S7fyy8RqttBjHi7aHx2T?= =?us-ascii?Q?EK+RotudVpUblYKmhQMtOTR/tpOeDqNHTWTVy37PUKvmCXIGKLR1+2F2cttK?= =?us-ascii?Q?j/VIKDQe24XMbDwdSlFNGUgG68E6xO5rhAzUrGc0+0E4KXT/eYPpUnLjaJyC?= =?us-ascii?Q?jrl4xOJUjAuv3C782U2m49yozAtEQIChS7tpRb0tT2dxRWjX2xTAXryA4cAU?= =?us-ascii?Q?iTtEZR2QNDMh3Jg+d5I93ZYANv0Qqa7EZwRo80kjNfCBvxHtZOu/NQFy0TFe?= =?us-ascii?Q?WODvlhGxgP9CWaEGT7yoYajMu1kXGXYR7GAAHY1zgN4AK5VEeOnXdV2ePuyv?= =?us-ascii?Q?7KJ5fAk9AGvoetDoEKppaODNJU4Z5zw9gWUyeR6FqYCEmzAk8C9jO4+0w0mC?= =?us-ascii?Q?fiRYJehbrZLAgoKf16fHCP0XGuj5hOD8lXVRrjtZFgXApOpc1HHE9ZAVYgvx?= =?us-ascii?Q?ylk6cP0wZa9wURIXR9i+fwkpG7kBHqAs5XMX8qcQDjNfnbnpCvWRdtfY6zZm?= =?us-ascii?Q?rQm8fESrctVxqPDVdf2XbVab0ITn5+eWXepmwT6VIzOuEw5BrZdWUQDU7vKW?= =?us-ascii?Q?lx8FdNTFcyCYBEW5lfolQiIYqKAewKygOsbqyinpW0becSdj6jGuEp93zoZh?= =?us-ascii?Q?2dzYtfglDhiB0LD6SXSfsbqVbvBb/Lcr1BhOTUAcHPPe5w3wsVy7kewcuYAw?= =?us-ascii?Q?vRAfGDfO7+5dpnerx91b0oBiGOxrf3WbvaIOi8+5KI3Fhh4/SYwA2nfymX15?= =?us-ascii?Q?do5BXm8JHHClEQ0wx8JGg7S5nzJuv+5u8rV/jY5LX3TCdTDBtwrYXNyCqD0f?= =?us-ascii?Q?MrdnQSV3gtGaQgkTMws+x91HkcPTQ4EJYvUtpI9RdBuM7gCIp21wLdzcoQBO?= =?us-ascii?Q?Xpha07eVzYURu8CzYICpV261TvlpfOyrdrHIdY3s+0QFKyFPea/jZISBPd5u?= =?us-ascii?Q?LRG22TitQKUUEr3elaB0255y+nhDhQrGygjUJEcb8mEfQ2cGyIE7gsvbhh//?= =?us-ascii?Q?Cvkwyo2daX6+HlGOxuqWt8QksVxdEDpSx8kuBAi2k420M2I/y3f5v+xTBTqE?= =?us-ascii?Q?n8F5UkBi7ohbJj2ZxevRZhN25K/XetmggQctmqmUaYWzstDgKLXupO/eE3ft?= =?us-ascii?Q?B/3qwbX9sLkK0BR5UZjecj70BXjEFEpoO+i7kQ/JdOeTbwTQVTyNTfAFyFHn?= =?us-ascii?Q?1CQahO6KncEqPQoFJtkwUtRf/I2wKbGoVZoJtRf90gTDbxrKqRQIhsfZAYG1?= =?us-ascii?Q?NOWiqb2mkeqMhDgP/GPoSJDEQjQAH8E7i+1AsxjugLgJt0+frUO4P7SXL6hY?= =?us-ascii?Q?Daq7f2HaS/+stxgq/8Z25eLQQCTJ+xkTvwUamUnllgJUlm/KwqTlhhuySo5Q?= =?us-ascii?Q?Aj44uE5aciOJBRUhT3s5KagH4FxzjmxtGw9uIJIMv1pO5HihqzDEQrnyHj7L?= =?us-ascii?Q?dk1HP2U3M7M5DwVSre0qFeNufEqjF5B/AfGScEfYS0FCuYGQodZmCbSLWajX?= =?us-ascii?Q?neWPy0KSR5oYgDQ2LNtoS17KgeOA2aq3nKh2S5Yl7vopaWELrav9qQjW55uw?= =?us-ascii?Q?tGp/VX8HwTqxCL20VFNixhp3K+ciVzg=3D?= X-Exchange-RoutingPolicyChecked: 3RmwBOUbmoSz3VvbiQIrTvYi5bO+PNuRB3mCZfCK+M/evEjtd6kjYh+8mubViB9JwbNaszNLNATFmBaYbgjd94EmLmDwvP3Mk4m9N7bb++uVGDQxOPtcYlRBkc1TdQ7DHhQO7Dk8ZmL8BNf8vy9lD+kT0wQRNEXSLGDXP/PsjnoDb8c8isnqbfK+8v+mcNopmcfL1ZYI5tVfFH9GXeTd+5ILOoc6W/IytK90+TB8rO+vblPucDso3KnVcCxSDel1d/saWveQOkb3hVBaMd/JrVFEoCsCrHWg4XbQYpSwYNN6UqTlbi01fjJeCFgARprWZkNdMvQTIS/9DgoAy8gy2g== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0948d43-d9bd-46f1-1fe6-08df2b90b640 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 14:21:04.7960 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: L0gNrThslOlyMy3F4yWg96d8cqINHthZU/l2H6CAIGukls3RXjLwBfmq3BsdpUJOi47TWUZZ5vQR3+n67ElXPCkNQ8vwv2uC7SLTZ1OpQfM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR02MB6547 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX4vZKa+1YxGZx WcMy5QS6sGzDmatkddoz7NiUeRUXowlbG3PjAcO12n1grwY17Cj/yAFZ+6epIBVLWuEvKKpNDYs f6KlZyUU6ULXlby5jMsGNdVDwqw1ntA= X-Authority-Analysis: v=2.4 cv=G+OJgNk5 c=1 sm=1 tr=0 ts=6ad232f6 cx=c_pps a=8h7WK4dQWB09CNKj11a7yw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=660iZSQnnn4A:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=dEe9Ve2bX-KnNSUMM2s9:22 a=64Cc0HZtAAAA:8 a=zV1iqHTY6MOlpgDiNWkA:9 X-Proofpoint-GUID: DFMP2JQtX8tPTSkUBfw37ybxcVl-xCMK X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX1L6/MWftkwbV JZ6u9Mrt/pOnKOgECdxkAYplWHEBqg4/D8QltC6dg7ObL5i7q+4xGYIh4zqssASgLJvu2zJY5dx +cOOfXBJjA+w+Y9zSDdc++SfUQvghzAHuamOm4lfg1bTBWSgbMQ8pqNl5tLEA9NA+GWXBHRwAgG lcTh6OdcyOCd35IDwiFSsocwJHNcUq47bLIUJH7ENjryOnn2aOU/QnJRD0jAoQCJr9RqkfKdayF GTjspUI1xna92rAXndJsDvagR2n+yNKx3E33Td3AvZjJq9T74/SoH5ViR4uJgUn+AKVJQs71trV Rv+PwSw0C8AwDZGiwGXvzlPX8lZKrbw3UiN9+emwmXYmFiGKDlCEl6FckJUtnEAoFmufqdW5AJC F4GPrnqVWnynN0tozHduYphH2B/LSV8axqxajX2/93XsQodydLwyoFe0CzS1eRlP1nVw07pZXwR 6MAptGL/YXFwY6oDYBg== X-Proofpoint-ORIG-GUID: DFMP2JQtX8tPTSkUBfw37ybxcVl-xCMK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-16_02,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-d62444/1792160509-1E664757-0AEE61DB/0/0 X-purgate-type: clean X-purgate-size: 12951 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1792160542547158500 Content-Type: text/plain; charset="utf-8" The use of consistent variable names makes it much easier to follow which fields are being accessed from I8259CommonState. Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell --- hw/intc/i8259.c | 192 ++++++++++++++++++++++++------------------------ 1 file changed, 96 insertions(+), 96 deletions(-) diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index 81827f2734..700412df74 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -59,7 +59,7 @@ static I8259CommonState *slave_pic; =20 /* return the highest priority found in mask (highest =3D smallest number). Return 8 if no irq */ -static int get_priority(I8259CommonState *s, int mask) +static int get_priority(I8259CommonState *cs, int mask) { int priority; =20 @@ -67,63 +67,63 @@ static int get_priority(I8259CommonState *s, int mask) return 8; } priority =3D 0; - while ((mask & (1 << ((priority + s->priority_add) & 7))) =3D=3D 0) { + while ((mask & (1 << ((priority + cs->priority_add) & 7))) =3D=3D 0) { priority++; } return priority; } =20 /* return the pic wanted interrupt. return -1 if none */ -static int pic_get_irq(I8259CommonState *s) +static int pic_get_irq(I8259CommonState *cs) { int mask, cur_priority, priority; =20 - mask =3D s->irr & ~s->imr; - priority =3D get_priority(s, mask); + mask =3D cs->irr & ~cs->imr; + priority =3D get_priority(cs, mask); if (priority =3D=3D 8) { return -1; } /* compute current priority. If special fully nested mode on the master, the IRQ coming from the slave is not taken into account for the priority computation. */ - mask =3D s->isr; - if (s->special_mask) { - mask &=3D ~s->imr; + mask =3D cs->isr; + if (cs->special_mask) { + mask &=3D ~cs->imr; } - if (s->special_fully_nested_mode && s->master) { + if (cs->special_fully_nested_mode && cs->master) { mask &=3D ~(1 << 2); } - cur_priority =3D get_priority(s, mask); + cur_priority =3D get_priority(cs, mask); if (priority < cur_priority) { /* higher priority found: an irq should be generated */ - return (priority + s->priority_add) & 7; + return (priority + cs->priority_add) & 7; } else { return -1; } } =20 /* Update INT output. Must be called every time the output may have change= d. */ -static void pic_update_irq(I8259CommonState *s) +static void pic_update_irq(I8259CommonState *cs) { int irq; =20 - irq =3D pic_get_irq(s); + irq =3D pic_get_irq(cs); if (irq >=3D 0) { - trace_pic_update_irq(s->master, s->imr, s->irr, s->priority_add); - qemu_irq_raise(s->int_out[0]); + trace_pic_update_irq(cs->master, cs->imr, cs->irr, cs->priority_ad= d); + qemu_irq_raise(cs->int_out[0]); } else { - qemu_irq_lower(s->int_out[0]); + qemu_irq_lower(cs->int_out[0]); } } =20 /* set irq level. If an edge is detected, then the IRR is set to 1 */ static void pic_set_irq(void *opaque, int irq, int level) { - I8259CommonState *s =3D opaque; + I8259CommonState *cs =3D opaque; int mask =3D 1 << irq; - int irq_index =3D s->master ? irq : irq + 8; + int irq_index =3D cs->master ? irq : irq + 8; =20 - trace_pic_set_irq(s->master, irq, level); + trace_pic_set_irq(cs->master, irq, level); pic_stat_update_irq(irq_index, level); =20 #ifdef DEBUG_IRQ_LATENCY @@ -132,44 +132,44 @@ static void pic_set_irq(void *opaque, int irq, int le= vel) } #endif =20 - if (s->ltim || (s->elcr & mask)) { + if (cs->ltim || (cs->elcr & mask)) { /* level triggered */ if (level) { - s->irr |=3D mask; - s->last_irr |=3D mask; + cs->irr |=3D mask; + cs->last_irr |=3D mask; } else { - s->irr &=3D ~mask; - s->last_irr &=3D ~mask; + cs->irr &=3D ~mask; + cs->last_irr &=3D ~mask; } } else { /* edge triggered */ if (level) { - if ((s->last_irr & mask) =3D=3D 0) { - s->irr |=3D mask; + if ((cs->last_irr & mask) =3D=3D 0) { + cs->irr |=3D mask; } - s->last_irr |=3D mask; + cs->last_irr |=3D mask; } else { - s->last_irr &=3D ~mask; + cs->last_irr &=3D ~mask; } } - pic_update_irq(s); + pic_update_irq(cs); } =20 /* acknowledge interrupt 'irq' */ -static void pic_intack(I8259CommonState *s, int irq) +static void pic_intack(I8259CommonState *cs, int irq) { - if (s->auto_eoi) { - if (s->rotate_on_auto_eoi) { - s->priority_add =3D (irq + 1) & 7; + if (cs->auto_eoi) { + if (cs->rotate_on_auto_eoi) { + cs->priority_add =3D (irq + 1) & 7; } } else { - s->isr |=3D (1 << irq); + cs->isr |=3D (1 << irq); } /* We don't clear a level sensitive interrupt here */ - if (!s->ltim && !(s->elcr & (1 << irq))) { - s->irr &=3D ~(1 << irq); + if (!cs->ltim && !(cs->elcr & (1 << irq))) { + cs->irr &=3D ~(1 << irq); } - pic_update_irq(s); + pic_update_irq(cs); } =20 int pic_read_irq(I8259State *s) @@ -213,81 +213,81 @@ int pic_read_irq(I8259State *s) return intno; } =20 -static void pic_init_reset(I8259CommonState *s) +static void pic_init_reset(I8259CommonState *cs) { - pic_reset_common(s); - pic_update_irq(s); + pic_reset_common(cs); + pic_update_irq(cs); } =20 static void pic_reset(DeviceState *dev) { - I8259CommonState *s =3D I8259_COMMON(dev); + I8259CommonState *cs =3D I8259_COMMON(dev); =20 - s->elcr =3D 0; - s->ltim =3D 0; - pic_init_reset(s); + cs->elcr =3D 0; + cs->ltim =3D 0; + pic_init_reset(cs); } =20 static void pic_ioport_write(void *opaque, hwaddr addr64, uint64_t val64, unsigned size) { - I8259CommonState *s =3D opaque; + I8259CommonState *cs =3D opaque; uint32_t addr =3D addr64; uint32_t val =3D val64; int priority, cmd, irq; =20 - trace_pic_ioport_write(s->master, addr, val); + trace_pic_ioport_write(cs->master, addr, val); =20 if (addr =3D=3D 0) { if (val & 0x10) { - pic_init_reset(s); - s->init_state =3D 1; - s->init4 =3D val & 1; - s->single_mode =3D val & 2; - s->ltim =3D val & 8; + pic_init_reset(cs); + cs->init_state =3D 1; + cs->init4 =3D val & 1; + cs->single_mode =3D val & 2; + cs->ltim =3D val & 8; } else if (val & 0x08) { if (val & 0x04) { - s->poll =3D 1; + cs->poll =3D 1; } if (val & 0x02) { - s->read_reg_select =3D val & 1; + cs->read_reg_select =3D val & 1; } if (val & 0x40) { - s->special_mask =3D (val >> 5) & 1; + cs->special_mask =3D (val >> 5) & 1; } } else { cmd =3D val >> 5; switch (cmd) { case 0: case 4: - s->rotate_on_auto_eoi =3D cmd >> 2; + cs->rotate_on_auto_eoi =3D cmd >> 2; break; case 1: /* end of interrupt */ case 5: - priority =3D get_priority(s, s->isr); + priority =3D get_priority(cs, cs->isr); if (priority !=3D 8) { - irq =3D (priority + s->priority_add) & 7; - s->isr &=3D ~(1 << irq); + irq =3D (priority + cs->priority_add) & 7; + cs->isr &=3D ~(1 << irq); if (cmd =3D=3D 5) { - s->priority_add =3D (irq + 1) & 7; + cs->priority_add =3D (irq + 1) & 7; } - pic_update_irq(s); + pic_update_irq(cs); } break; case 3: irq =3D val & 7; - s->isr &=3D ~(1 << irq); - pic_update_irq(s); + cs->isr &=3D ~(1 << irq); + pic_update_irq(cs); break; case 6: - s->priority_add =3D (val + 1) & 7; - pic_update_irq(s); + cs->priority_add =3D (val + 1) & 7; + pic_update_irq(cs); break; case 7: irq =3D val & 7; - s->isr &=3D ~(1 << irq); - s->priority_add =3D (irq + 1) & 7; - pic_update_irq(s); + cs->isr &=3D ~(1 << irq); + cs->priority_add =3D (irq + 1) & 7; + pic_update_irq(cs); break; default: /* no operation */ @@ -295,27 +295,27 @@ static void pic_ioport_write(void *opaque, hwaddr add= r64, } } } else { - switch (s->init_state) { + switch (cs->init_state) { case 0: /* normal mode */ - s->imr =3D val; - pic_update_irq(s); + cs->imr =3D val; + pic_update_irq(cs); break; case 1: - s->irq_base =3D val & 0xf8; - s->init_state =3D s->single_mode ? (s->init4 ? 3 : 0) : 2; + cs->irq_base =3D val & 0xf8; + cs->init_state =3D cs->single_mode ? (cs->init4 ? 3 : 0) : 2; break; case 2: - if (s->init4) { - s->init_state =3D 3; + if (cs->init4) { + cs->init_state =3D 3; } else { - s->init_state =3D 0; + cs->init_state =3D 0; } break; case 3: - s->special_fully_nested_mode =3D (val >> 4) & 1; - s->auto_eoi =3D (val >> 1) & 1; - s->init_state =3D 0; + cs->special_fully_nested_mode =3D (val >> 4) & 1; + cs->auto_eoi =3D (val >> 1) & 1; + cs->init_state =3D 0; break; } } @@ -324,30 +324,30 @@ static void pic_ioport_write(void *opaque, hwaddr add= r64, static uint64_t pic_ioport_read(void *opaque, hwaddr addr, unsigned size) { - I8259CommonState *s =3D opaque; + I8259CommonState *cs =3D opaque; int ret; =20 - if (s->poll) { - ret =3D pic_get_irq(s); + if (cs->poll) { + ret =3D pic_get_irq(cs); if (ret >=3D 0) { - pic_intack(s, ret); + pic_intack(cs, ret); ret |=3D 0x80; } else { ret =3D 0; } - s->poll =3D 0; + cs->poll =3D 0; } else { if (addr =3D=3D 0) { - if (s->read_reg_select) { - ret =3D s->isr; + if (cs->read_reg_select) { + ret =3D cs->isr; } else { - ret =3D s->irr; + ret =3D cs->irr; } } else { - ret =3D s->imr; + ret =3D cs->imr; } } - trace_pic_ioport_read(s->master, addr, ret); + trace_pic_ioport_read(cs->master, addr, ret); return ret; } =20 @@ -361,15 +361,15 @@ int pic_get_output(I8259State *s) static void elcr_ioport_write(void *opaque, hwaddr addr, uint64_t val, unsigned size) { - I8259CommonState *s =3D opaque; - s->elcr =3D val & s->elcr_mask; + I8259CommonState *cs =3D opaque; + cs->elcr =3D val & cs->elcr_mask; } =20 static uint64_t elcr_ioport_read(void *opaque, hwaddr addr, unsigned size) { - I8259CommonState *s =3D opaque; - return s->elcr; + I8259CommonState *cs =3D opaque; + return cs->elcr; } =20 static const MemoryRegionOps pic_base_ioport_ops =3D { @@ -392,15 +392,15 @@ static const MemoryRegionOps pic_elcr_ioport_ops =3D { =20 static void pic_realize(DeviceState *dev, Error **errp) { - I8259CommonState *s =3D I8259_COMMON(dev); + I8259CommonState *cs =3D I8259_COMMON(dev); I8259Class *k =3D I8259_GET_CLASS(dev); =20 - memory_region_init_io(&s->base_io, OBJECT(s), &pic_base_ioport_ops, s, + memory_region_init_io(&cs->base_io, OBJECT(cs), &pic_base_ioport_ops, = cs, "pic", 2); - memory_region_init_io(&s->elcr_io, OBJECT(s), &pic_elcr_ioport_ops, s, + memory_region_init_io(&cs->elcr_io, OBJECT(cs), &pic_elcr_ioport_ops, = cs, "elcr", 1); =20 - qdev_init_gpio_out(dev, s->int_out, ARRAY_SIZE(s->int_out)); + qdev_init_gpio_out(dev, cs->int_out, ARRAY_SIZE(cs->int_out)); qdev_init_gpio_in(dev, pic_set_irq, 8); =20 k->parent_realize(dev, errp); --=20 2.43.0 From nobody Fri Oct 23 14:31:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1792160532; cv=pass; d=zohomail.com; s=zohoarc; b=QCUf57S2ms6Q9eMJJWBXMgZeUAOe0hSJKnG/pwdDRWGy8kGfeglm0oEuG1ve7X9+8xjFBa24bAoj95VbqJPFMvCcGl5bMw2DgUemKt5JUQERKCYpQY8xki97kAZ0ZQkhpwBY8cy38jZ6m61ymlcpnsJg/WLl0qXvNXcfklfQhZY= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792160532; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=NJy3zo1QGJbOmTC9Nz3fMdmhP79c69OYBgxpmQByOzg=; b=CgzZ9RPpzNuxdGxoQ8IMTHFKQ6ebyMjv9w1eY5vnaAAFlJcBSyuQjiag/4iENJ8mmhnnJ3SklGNPpgtUDRSCTv8uT6tZMAkoBwNEEEyU5dqrGvuH5g+fQ8t37bLDkHlzANgXnC9k51ClUEoGWcIeMAuLC/NhFAdxrkAZvNpE5WA= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1792160532128416.89832083094757; Fri, 16 Oct 2026 07:22:12 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1451996.1666875 (Exim 4.92) (envelope-from ) id 1xHiog-0003Mk-CB; Fri, 16 Oct 2026 14:21:50 +0000 Received: by outflank-mailman (output) from mailman id 1451996.1666875; Fri, 16 Oct 2026 14:21:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHiog-0003Md-9P; Fri, 16 Oct 2026 14:21:50 +0000 Received: by outflank-mailman (input) for mailman id 1451996; Fri, 16 Oct 2026 14:21:49 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHiof-00038p-0D for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 14:21:49 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1xHioe-00BWwx-C2 for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 16:21:48 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6ad232fb-e002-0a2a0a5209dd-0a2a45039348-2 for ; Fri, 16 Oct 2026 16:21:48 +0200 Received: from [148.163.155.12] (helo=mx0b-002c1b01.pphosted.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6ad232fb-fae8-0a2a45030019-94a39b0cd794-3 for ; Fri, 16 Oct 2026 16:21:48 +0200 Received: from pps.filterd (m0127843.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69GE5MK73333355; Fri, 16 Oct 2026 07:21:43 -0700 Received: from dm1pr04cu001.outbound.protection.outlook.com (mail-centralusazon11020128.outbound.protection.outlook.com [52.101.61.128]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 4haukukqe3-2 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 16 Oct 2026 07:21:43 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BL0PR02MB6547.namprd02.prod.outlook.com (2603:10b6:208:1c8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.23; Fri, 16 Oct 2026 14:21:09 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%4]) with mapi id 15.21.0522.016; Fri, 16 Oct 2026 14:21:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=NJy3zo1QGJbOmTC9Nz3fMdmhP79c69OYBgxpmQByO zg=; b=0UeB+o5JVvwAIHNsTp/bwwTAtkbmqTIGkcCYXMH2oF1KW+5ZtE601mUbf qMQG/lFr05axS0orvAhw44yQStcy1KGyL5HxlFlAcsFNwHX6w8T0wE5RMpLMayAe 2gE2UwB4bicOnITPntqzbwyuU8PUbwcnm5UhZmA6OdTkPZcIPKvWR7Z3Bo9nUnCm a4T99fSM1vwjE/8beflO3TRDSbZLFOlvnlLqBmDl3fbwPYg04KceFfkOFelcLCxR hcd6Dfpt2qkU7FDyIbDhnGGa3Pz9nzwyOWOCFkLVv1uyzDP/Y47Ea3wPrWBZKF6u BylspXXHToL9ZADKs0+nOdbpQCJUQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MQ3oWxJwhM7Qpk5pMWpgYbfLduSldIv3x8R2T1mkLAyyS6/ikYmLeEp9UbbtmVFaPheDTzcj3XOILtIwr2ovjQvaofWaHS/3H4eaus2CamLxz3uK9wia/pGvbIyJp2+zXTkSc8E/qCkwslyOjy2yo98OFYY4Vr3BYKcAUSF2lG9KUGeZG+5NvdEmT0PSHr66FO3Jv8CNHVj2bmELoMgBz6v0N7fIF08Fb7luIEI2XqU7HymWNgK7duD/hgo6wTzBDoBbEPj1tgQWtnflyrkMDAE9vNGRBqarfUF4LwbVvHfcV8qYX6KeNyacLHFD4Ftt1ti5FfMvjyNioEPfmV0BVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NJy3zo1QGJbOmTC9Nz3fMdmhP79c69OYBgxpmQByOzg=; b=IzG/nmENbPwLD+VoOPjvLEJ0SJ9sH+72O3XIeiqFj7I82dzHBvVwOROi3242f9rYdV8NHQDwChw+CVjMf9vTQD8PdjeqO4XvGGA5FDMgQ+f4exx0byTsyspDHg7KpAi9Xe+G+L9mMHyUiL+5M98FXsl2zQoibOcY/Tw94S0yD9zZUshfgNPJ+Pn93bC6uRoUrOFospOrGr1PXs3d2L1qujYj1p+HmTl5GqbSHFEuK7jA70+UETWeY+TcejYOsKHZfzy45KkUQtqaeNM1bG+Ubmxd+CRhkLUAVgDe7LRhHVAzMM24b2wUV7lednYA9xOmYpjHBMXxygjjgilOaPrI1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NJy3zo1QGJbOmTC9Nz3fMdmhP79c69OYBgxpmQByOzg=; b=I2iXPb2qdYDyKMraw1+TUbpfz/Vm6rofJmMmNGTihDo4yOzenXaFZQ7wx66auG17++23dChhhLykwcEId/5NlrupudzQVWg7ufPWH22KQX+MnSxklcfPmL0A688oHbHoFa+xYLHj37LnJ+SOETLh3Ib7D00xfYuzFexJgl268mZ38Gyz/IhDmciCyF672jezrlU/QAeWTNVVMpEfnaGTbYqGSDRe31C3iZ7KPskfj5xAzL0x1rUFuNQ6tzsueXXDNqRK/mJEunouaCKVEbltLXIbkz7mZdhVEJIjwIjyuHS0RKp7t8Ek4CD5/BoBow4QnZI0tPZMYNwNzJFcaiaDSQ== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nutanix.com; From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH v2 08/27] kvm/i8259.c: rename KVMPICClass to KVMI8259Class Date: Fri, 16 Oct 2026 15:19:14 +0100 Message-ID: <20261016142031.1204281-9-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016142031.1204281-1-mark.caveayland@nutanix.com> References: <20261016142031.1204281-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR05CA0102.namprd05.prod.outlook.com (2603:10b6:a03:334::17) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BL0PR02MB6547:EE_ X-MS-Office365-Filtering-Correlation-Id: 33373cb9-e483-46b1-0bcd-08df2b90b90c x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|1800799024|366016|22082099003|10067099003|18002099003|56012099006; X-Microsoft-Antispam-Message-Info: dxG6F1OPyUm8vdw1mxIx9MuDKm2OlcMJbI25AM7B9M+3t0Ts+uTzQtoiJjWKT0lMHQap4rhfCMYxUpXMGuzdneGK2lJ0iVN9fJ54xR+W/PBEakxwkzI7cvpOb/2T/4ucWbc+zxUkbQCz3dRx2mq8DwDCVUlkHsP4siJk9TGE0NLXHT/F8S6s4mNF07yhJ+zu5TOAUseD2t1VYwfAtT1EGhdBsQoPcnHaojPAbaVJhbHc1bGuYhT9A5aBMMRN5s1LghuTEFkZmnuUGtifsPD6SWXbWHDwjw51A8dSlnvEis+32eD0d+5dz7Cg1z37u52zWN2nA3VqgCKVqvvro3uIFHLRwKE/x5NgdFy2U8uwuefzvEO6h7kq+OVxDG3s+hpUFIl+AvS3xyPPS185xzwMvgzQVZSbIZOnqbPhGPQFmipRE+JBVOmenm2FjYKdJtmRONNJiCw0s2xP8hRwH7eyQNOzXkhOcVufGBB8iiy8ISDDWmshSHZa2QmO59JHW2ulKjiSzkZNHXlz30cTfhjSLkxIS85z5BPh7r2kATOzXMitMAgvgzI7f7r0aPkLnF85Po6ieXXujWmCxNEfStf/beaoaxWpPKtDoyzpEnxCgzlUmRSN8kW5RXGHPW9rUIdWQWG4sCOAMm2LgqZHRdP0z0z3MucGqerVz9eSEmO1Rc4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(376014)(1800799024)(366016)(22082099003)(10067099003)(18002099003)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pcDceF1y/RcQWF4yFla/XU/ejOIMte8Prx3wjVSbkdgrgj18mrD+6jdv8CgY?= =?us-ascii?Q?/1JIPFwlRpW6lSX3379JnMSGrhBRXMczeSWmlag1qHEZ3xBzLeZH9iXdx+1m?= =?us-ascii?Q?0qLF0rC1KGS3u+04W+q86UDHTvCO0OZ/JFuiMRp/QH6CrupGzYlCHZXV0PxA?= =?us-ascii?Q?ARMIMTKgsvIsB99UqM9ltgXEU9gRelPiuLcnCtlVX12m+2P18zQoCCs82FXB?= =?us-ascii?Q?XR/o1oXIZGZgWS1RtSqAccKMrnTANu6eg346Ug2JRvnF5Wa274nnfqgi/+zM?= =?us-ascii?Q?B7QHFgNKfc3IabGNKAzp1d4CYLg5XspAdx2GmO+nWMK4D2tpPjtRe+Vp63NM?= =?us-ascii?Q?WYOFjwXoaNNEdXdXarf3syMar1duDnrZvNEk0FHOCYl5G5jOto40XzmgIcrr?= =?us-ascii?Q?ZjT/FH7IU4aQBU/oLr5aEXwLjt+X4E5A2ZGZdQ/+W4xskg8T8622HLDm3YEF?= =?us-ascii?Q?EfCnBE+EW4zQ6J+fDe/O1QxbaIpsW0TMUJ6ZSVEgQ7+a8UFIGMe+qU1i6xeu?= =?us-ascii?Q?oHugqOBca+rnV20r3ilpLotNEjbGZoB7o3jHJj7IbW92z63UIAiqnP9NVOUb?= =?us-ascii?Q?UrZ/+Ee3TCUezmrkHvaRp++xC32ArxaCDbf3CxT20mvaqaB5uS1nC1pLUP+p?= =?us-ascii?Q?JhRWFnFqmlJyzCBG395Fyterbr7cOF70PD7r1KyazwQH5KiAPV2RNpqrnTUZ?= =?us-ascii?Q?IYRGoj4y1Ze2XupTXP0GfI1zqE9Iofss/BeZEBFu4lBGWWNmE6ukG7Agi03K?= =?us-ascii?Q?pbiR1bEcJ0IeSI9RTG9rAPrqZKn2lUNmevKJX8qOBsDIFgnIXK1GwfW4318d?= =?us-ascii?Q?LDEExSJgurodf/3Gh+zml1kg6jnTHLUrPq7fAdQJJvHL/9cLPRuMOtuG1W8E?= =?us-ascii?Q?Y/eF1vERdnNzZS/hVvfPrZHXxPxxoFYH830NRU7fNL/S9PoVY5bMLOyWlF/c?= =?us-ascii?Q?oLRBJQ0QE/SbrvQW8WYSiNVV1fpmzGjtW7TqDgBAYZQoIcYUwEd4NfMLadMa?= =?us-ascii?Q?rN2XS3kznezF1sta0POCJ0Rdeu6BOtpNq0Gpuw7qahycWCxDxOOwxnN9MBAN?= =?us-ascii?Q?ksWpNVc6JjThKhIbXXDgHwXmscxKDp+O6CrjsJi1+ooZm+DGRA1cAKYzONE4?= =?us-ascii?Q?S5UFq351gU9WOGVb60vfIzox5oE/bDsBza/E9fxUgQLqvmRsRt9qrzgxTnqJ?= =?us-ascii?Q?EH6GpUPcbsPt/eXhhjhPFZgAjh5czDY+lWEKcTnvBrlEB1LxgjxdFlgcO3di?= =?us-ascii?Q?aiGPWDVL6s1xclxT4Zuqvfj/rKBIVsrxOsLKThDhhvD4ywaUwsgf+dMjBl5B?= =?us-ascii?Q?+jnDLBPPR+D6vkligq+Lc1VYtwZc7DUctVYElxa0wypN0r2n5pqjltXAm0yk?= =?us-ascii?Q?rfpxsDfxHIwely4/qsQvsYDhLZwuMcV4+qolQmQTxEZMwYsJ8pN4yFw9EMIS?= =?us-ascii?Q?os/jPxS13nKWwKXNjHu5z7OHoyS0j0ZOWhc/byY2gvYUZjqWzdsnEO1Tqoei?= =?us-ascii?Q?HkYcrZ4Yo6Kiz74BI8gpW8CKBxdOsuhcs+N+nOuUE1fLHFE/a5biS7TjTV2t?= =?us-ascii?Q?flDPgzzi3mnp3TaP76V5S1wNLH66FE9+XqJhVXQqzEHYr9/4JqooOLZwMyZd?= =?us-ascii?Q?BMG9sHAxTf+O3SIdv0aCDcE2Pt0SEA7GcZn+busKzf37o42qXkAykMUpve84?= =?us-ascii?Q?1kVW9+kvN/obYcpvS+EKiLkiPrRwQvObfSZxtivjMx/9I1GH7awawlrBvNQr?= =?us-ascii?Q?+yOzaD69YJu5rChT+Ca8ZtCxuDqSN0w=3D?= X-Exchange-RoutingPolicyChecked: DxotLSV1wYoOMBc6yNX2b498simAzzY/b6GkpptsQzuKxELPQuRJ02wq295wh3hh8TKont7wSBhaYdDxIc+bOsmsp9wkGJaXk4SRFSouNfpVj3MuIz6kP5QBsWy09kqS09vkJ+1W4yHeqhQVpzh3Sl95nTFxAOGEDqTnf8QObvz7VhHVfbHnUnxl7qNLG2hqhHTxikNu/d3HOnLNxgjfsKMPio2KfmKcGCJJHlr3//u8+cOGxERbTXF4nQJucRv0raynBZn++BADYcsiN2v1OpugnDx/zcp/oZoiY2k+Ut1A3hB09UnYArEJAYMhO6v/AFPGtpfRSmwMiVWTVkTtJQ== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33373cb9-e483-46b1-0bcd-08df2b90b90c X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 14:21:09.1562 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CcOVAGq0RjaA5g4auKjoAwpD9xleEjYgHUTzFzJQ7+04c9+1/V2ksSe3qPbRr/Z+gW1DzMCD5o/D/YtykahWcD13EAEINc6L9kUq+aVvAeA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR02MB6547 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfXxiTgefN9ZXso E1acuOb9DHwNv7amlXTdsEcnch3GkzsY4EdYT3XbVIq+oByaP4DnJptlx27VhvxQJc39ET3PSzd IbwxkHk7pE1bL39KP37WfIQcdPUXpaw= X-Authority-Analysis: v=2.4 cv=G+OJgNk5 c=1 sm=1 tr=0 ts=6ad232f7 cx=c_pps a=8h7WK4dQWB09CNKj11a7yw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=660iZSQnnn4A:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=dEe9Ve2bX-KnNSUMM2s9:22 a=64Cc0HZtAAAA:8 a=7JMAGyXtUfIWgoDCk_YA:9 X-Proofpoint-GUID: JM1mcf9Op2tkbYiwHg0N6XWVK3PZkNfT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX9yMTf9Ef71Z7 gNW1utxQvVR/cyIwy+GykxaPqdqS1s41f8t9rcG5KHv7/31ECDzXZmdrYsqPYWBPd0ETNY6xM5m iVhtF9vo0xiGtXtTIv9KRq1PpGan5Tcw+KZKlfsyTIHR1sOzISQ3aOIkwBdut/siD9WRC5KiBcY wnAOU0QyIJqhsJIq3VZUHnlvW1GR8iPIYQh6Qt5fr7Nw2ZcIg8XJ4JWUsW/rSswdlvo7dKbLLq+ hO08euZ5t5xsA9tmN0YloFjvKZqqL9+sBxKtz46U52g0QxvE0A/Oylq+055wUXRTCU6PD+n0ICV aTVu7rll7TpTVsIGbGQor8B8tFw60maHMlKJLTfMHgdQjCHmOFtL4iLHvzbtAvk0RAC02lmxSRp EqGoOmMuVXPgDwSAbUCffMb6bKG+tISizeCfabrUKelR+yi3b7cZyRoMhtwW12vSPcBEDgadGnr YTXFgIVzvp4Py3u5HTg== X-Proofpoint-ORIG-GUID: JM1mcf9Op2tkbYiwHg0N6XWVK3PZkNfT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-16_02,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-33051d/1792160508-6CADC4E9-9DD7B9B6/0/0 X-purgate-type: clean X-purgate-size: 2079 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1792160534336158500 Content-Type: text/plain; charset="utf-8" This is in preparation for its use within a QOM type presenting a single KVM 8259 PIC. Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell --- hw/i386/kvm/i8259.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/i386/kvm/i8259.c b/hw/i386/kvm/i8259.c index 68607d721d..85176dcf80 100644 --- a/hw/i386/kvm/i8259.c +++ b/hw/i386/kvm/i8259.c @@ -20,15 +20,15 @@ #include "qom/object.h" =20 #define TYPE_KVM_I8259 "kvm-i8259" -typedef struct KVMPICClass KVMPICClass; -DECLARE_CLASS_CHECKERS(KVMPICClass, KVM_PIC, +typedef struct KVMI8259Class KVMI8259Class; +DECLARE_CLASS_CHECKERS(KVMI8259Class, KVM_I8259, TYPE_KVM_I8259) =20 /** - * KVMPICClass: + * KVMI8259Class: * @parent_realize: The parent's realizefn. */ -struct KVMPICClass { +struct KVMI8259Class { I8259CommonClass parent_class; =20 DeviceRealize parent_realize; @@ -123,7 +123,7 @@ static void kvm_pic_set_irq(void *opaque, int irq, int = level) static void kvm_pic_realize(DeviceState *dev, Error **errp) { I8259CommonState *s =3D I8259_COMMON(dev); - KVMPICClass *kpc =3D KVM_PIC_GET_CLASS(dev); + KVMI8259Class *kpc =3D KVM_I8259_GET_CLASS(dev); =20 memory_region_init_io(&s->base_io, OBJECT(dev), NULL, NULL, "kvm-pic",= 2); memory_region_init_io(&s->elcr_io, OBJECT(dev), NULL, NULL, "kvm-elcr"= , 1); @@ -141,7 +141,7 @@ qemu_irq *kvm_i8259_init(ISABus *bus) =20 static void kvm_i8259_class_init(ObjectClass *klass, const void *data) { - KVMPICClass *kpc =3D KVM_PIC_CLASS(klass); + KVMI8259Class *kpc =3D KVM_I8259_CLASS(klass); I8259CommonClass *k =3D I8259_COMMON_CLASS(klass); DeviceClass *dc =3D DEVICE_CLASS(klass); =20 @@ -156,7 +156,7 @@ static const TypeInfo kvm_i8259_info =3D { .parent =3D TYPE_I8259_COMMON, .instance_size =3D sizeof(I8259CommonState), .class_init =3D kvm_i8259_class_init, - .class_size =3D sizeof(KVMPICClass), + .class_size =3D sizeof(KVMI8259Class), }; =20 static void kvm_pic_register_types(void) --=20 2.43.0 From nobody Fri Oct 23 14:31:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1792160525; cv=pass; d=zohomail.com; s=zohoarc; b=Fk2M2isxifuKhKh1lpgg+dNXCaHh5jZ3OtooeReOCyHWfOYplR4nSZx4Jigwq62cDsW7fYRHVBPyLhDNqWVkMZeWas30Q/OSiXR+Cweb1ToEn0J4PIp6UFQKIPKp8lpif9hZTKH8imND/PgsUWculRYYPgYtBIZPDRf1P+3kITE= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792160525; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=GoegeKV1vQWnIJ04Hn9BEfV8vtJcqN917AjDT75f7DQ=; b=OKk+BpJZ/YNS3gq/W1jC+F87j1BCyh0DJmKp6loAdNoQkmvqvclAPDcYPPmhqfccVv0t5rDyTTrCDswaOfIwjzMzfd7/g6QLw0iepqiZsMMw6UWIHPaTXsFR7+TDq5BWRetASbey+nhyglZw7Aeg1Oyj7VW6FxeL/7Y12cQEDQw= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1792160525103634.0267997770344; Fri, 16 Oct 2026 07:22:05 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1451997.1666879 (Exim 4.92) (envelope-from ) id 1xHiog-0003Pc-NF; Fri, 16 Oct 2026 14:21:50 +0000 Received: by outflank-mailman (output) from mailman id 1451997.1666879; Fri, 16 Oct 2026 14:21:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHiog-0003PO-HS; Fri, 16 Oct 2026 14:21:50 +0000 Received: by outflank-mailman (input) for mailman id 1451997; Fri, 16 Oct 2026 14:21:49 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHiof-0003Im-ND for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 14:21:49 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1xHiof-00Aqsy-3k for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 16:21:49 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6ad232ef-bab6-0a2a0a5309dd-0a2a45069fdc-22 for ; Fri, 16 Oct 2026 16:21:49 +0200 Received: from [148.163.155.12] (helo=mx0b-002c1b01.pphosted.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6ad232fb-195a-0a2a45060019-94a39b0ce3f0-3 for ; Fri, 16 Oct 2026 16:21:48 +0200 Received: from pps.filterd (m0127843.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69GE5MK83333355; Fri, 16 Oct 2026 07:21:43 -0700 Received: from dm1pr04cu001.outbound.protection.outlook.com (mail-centralusazon11020128.outbound.protection.outlook.com [52.101.61.128]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 4haukukqe3-3 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 16 Oct 2026 07:21:43 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BL0PR02MB6547.namprd02.prod.outlook.com (2603:10b6:208:1c8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.23; Fri, 16 Oct 2026 14:21:15 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%4]) with mapi id 15.21.0522.016; Fri, 16 Oct 2026 14:21:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=GoegeKV1vQWnIJ04Hn9BEfV8vtJcqN917AjDT75f7 DQ=; b=PO3i9xpGX1TOzmdZrEV5nXJdi6nzUdlsYwwkcjvxbM9nWDmdmVPX/MZ47 AksHWmsUggOWTCAMwmP9AcpLj7saq2zGKUbnIz/b1baFZ/6UdjDg3hzor0vBSeWn rxA7W/ARzxnQqKtpuVFun56LJ5TpJvX98zzLXyFeHAWO23a4vwhshrWrFmSGUMhm KJdxgakVCAmo5gCOA/KI4+bnV4tTNf2yXQxr7raT38dWri2A6H8YGOAP8PzzU4iQ z4ETgoyzz5QFKTZbyEd0AvtmuS/LW0wWcig172VPsfN2gsF7/0T02gVNw4jDDhsp KXp5xeKV4ezipTaOmkFWqvnQerPtA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vyJ5VwhEadg2rI007DWrqolri3EgkbHapZk3fft0T+85CuCt3BQJe5bZgp3r+0rVtkIrXr4ZO0I9tSjZ4R1UElt3eLMFBBCYRpR/b3P7gxrgDk7g74qZoMAjXZEjB38xjzPG/CQRxP/ImIY7EZzXvjOzjHKvU2S7CDn9Ihlewl3LRjp1MBcuNzKKWK/zseQRUDGFN6qQsB14DkWdwn7UQ5X9s9lHjApBIojfH9RR4ucJYuVxFk4+CvffQ3QdGDngEAG+4qHZBZbfYNENfpAMVs0B8GSGOtXMoH/rMJpE5Yb7QKOcxGdy+tisr0eZXwCch/2V0eLPmRNMqyuO7XRocg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GoegeKV1vQWnIJ04Hn9BEfV8vtJcqN917AjDT75f7DQ=; b=jeHKAMvJ3qg3vgUAL7644nZZd3D3qvTgv8iBsL1AXYl4gezPxuFkVmnLqRvNbwANBemVdKtubPNk4CRyLSzZ57zmpRUATegAgCV8Eq0rbWcbdqvvyNXhbqpRX6Jn9bdKdZXBqgyZM493GOVeIua4DLdWsIaIiIKBBa9fE2N2JvQnJEY+4MZitLL4DsV1Mez5LujOiFBs7wyH6A/Q6LwQzEbxaip4OHT1HtpoECwwPw8lYVOlrn2puP6Npweb3EjIVX5f8snpNjlAuNeyUt5g1nQ+CEENF7fwcoJPTWd5YzQQyLccQ+j+F7mn0luHKNqKRmTyrxQ4+aUn4HaG8JC6+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GoegeKV1vQWnIJ04Hn9BEfV8vtJcqN917AjDT75f7DQ=; b=YN7VZGP6TGvVDUYSvRIfKbeC1qrtr2D3pKkEDtS3zh7pdmG+SQXfKimWgPUMeNDrkmKy2MzG6+7nMO7FUpl4W27P7Sgyck85zMgUrMzFZ0tsgx5Q3qXH+36ix7Awo22+ZscxNYWrFAdmIY4nhkSe5E9dy+kgcK/MN34pyxsMYVeux2XxBL2Eh+r9vaX3N8JMzMPiVPlaOFzby4jhdjUYVNoSJEQJVUdEh0MGqw89MQYjWy6QfvUL/jrF2NoW44yzdbPaQJknnHuzs7TzA4+poFQSXkUPfRyrDDgh124VasdcLRqwvAr3oKXM8sdzWetZA9iZQg09JC/vttH6IN71aw== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nutanix.com; From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH v2 09/27] kvm/i8259.c: introduce TYPE_KVM_I8259 device Date: Fri, 16 Oct 2026 15:19:15 +0100 Message-ID: <20261016142031.1204281-10-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016142031.1204281-1-mark.caveayland@nutanix.com> References: <20261016142031.1204281-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BY3PR04CA0016.namprd04.prod.outlook.com (2603:10b6:a03:217::21) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BL0PR02MB6547:EE_ X-MS-Office365-Filtering-Correlation-Id: d4af9134-80a9-4191-dda1-08df2b90bc1d x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|1800799024|366016|22082099003|10067099003|18002099003|56012099006; X-Microsoft-Antispam-Message-Info: 6wzZgYk7PuMphndy/F2woKoOv9nP1MWvE10kvtiZuOV+gVX8eLRPPpffEB+3jSCXMHRi7TtYxEIt7hygNVS9fl/pBNHOHlp/YxafldPI203YevEZuYBiAaCEF4D8GBOvWI1ZmXbUG2CLEIw14cpcORjlEgppoFdNXn6bgmyFIK6P8Bi9kdIoewpfooRIdci2T4zjM7Zoqnbg3ocqFGec6anrZxf7qtoPjo3SK5/8Z9QL/57/Pe9Io3PyddHCW9ylUdEc80r/EFIZPQKdnHVri32TVqkl1tRl/pvuwTny+/doBOFjR4Qb3k3GuM+LqFU5E2XTWtHwIxlm9QioxrXJtRjlKP0h9B2gJvYUzaDmCGDCnC4gwoP75haVrZiC5sLsRlgwBUEWyYVaZsqthjgwLUWqLLT8tdtiUyNXtU4uqd1npWqJhOdYBqvv9fAxiPTy6qpflE+bvg7JSaGbgSpQOzGF3ctacvWCnx6zMXeVSWyNQNx0JWhCrcgeEbgVTUdZScqHCqrfZgCFNiISbHyPhQ/l8mwXkFw1hiI247Gm5PxmOlG4tgl4aH/Itr4z++zoJbgzYoPwlosWBs64CSOnFV54qdEECaybNBsJgWkORiD6biZc5nmB5N2BGDmednB5m/+Ns38eZeMQ9UxmTJFV4xFUm86LHgt0bTdrKG59tws= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(376014)(1800799024)(366016)(22082099003)(10067099003)(18002099003)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?L3Dy39C9AfgE0qsqPGISFIYWimHk0CIdjZc/ajr9LclCbxyudKowPcKJHk4q?= =?us-ascii?Q?lIbxTvvsPYwhQPOZcRzGp1DdHXVnxAHRt8/vQPqBLiBzrrTobTK4poQRAfrb?= =?us-ascii?Q?9nWYOrvLQAhBQ8RaccbCQJIYId580ARevtOn0EZEEJVWKjURUFv5Jfz4XIIO?= =?us-ascii?Q?h5LdxE2nTPK/kQPe7GLX8gM4rmIQ4NqWRXBKfIj79/q8HTBmjf2lTZWAUCk9?= =?us-ascii?Q?9Ndrbt+G6tQa8/IlnesafV6IL1WqJ2HcbeA3U9D7TJGn9IgAmNtQ5cdwTDvq?= =?us-ascii?Q?1iuM/J+SRmjHm6S9Q18zczCM7lvA7fuRUSg6B31uH9y5GlRFoiLFY/H5JbHp?= =?us-ascii?Q?NH7mpwlceFtqrFjT3g7/RsRp0CvS1qRqKFoLymtvqjhshWIQcipWrdIGI/b7?= =?us-ascii?Q?FYG1LHhmnon4eoV61WLCVK2S1yXHuE8EnKO5IM949Y82R6+gCvNr7MEj2zzK?= =?us-ascii?Q?5oGNJGKSMM/3rSVDXav3Td7GI2pUZ6vlPRtNeYBmSTIjLE2Z+RoX2zHZJCcZ?= =?us-ascii?Q?ilpD4gzjkT+nqtVpAcNGYXXMeWMvmONtuxj0dbobTOpHmlSvJ+Dm05/MLebK?= =?us-ascii?Q?3F9hKlLvvwDBKK0EXuJ8Bl8Pd+vU6iIc5AF0aNwofIwMBfWwPPG2qSBkACGs?= =?us-ascii?Q?fKyx22+ubrATQfRPcbOYsPHGBkKgY+9iflDwzgC4CXZAYSTuvXcxUYsVfPFv?= =?us-ascii?Q?6FP9r45CMdy1OzxwA21aOMjg17nExWwgrCmb2zo0SDKpaykOg7khyZT5C8Uh?= =?us-ascii?Q?EKvoZOK2OpcryvYrLg6TixRmUW8thYpTJ3W+Y+vMFWK0/r/azGS8ReOW9wP+?= =?us-ascii?Q?0XrIq4PMo0BHHpfiBptMnlVXBdCUjB1RdDo8TNYGB3Kj+W/eq/NZlKdcjAAo?= =?us-ascii?Q?+eLA8xPF2nXYDxPGkMdegQxKpsKaMWd3gIPC1nppzRP8sHmRb0rryyPDqPtT?= =?us-ascii?Q?ouFPKbpRmm0/BI7ppY1MrsH0XhEg/2qFgxXnNze+CRwW5MaQTpcNch82EezL?= =?us-ascii?Q?AqUJ2OPtOH0ShkEyXI0vCLDP0rkmKlE1vVz/7XtqRWVsx7ZfAJnHiFoGMlyI?= =?us-ascii?Q?HgFTY9HPuuWRpMgqevz85a2uoXhxLlO30nQPdErd+6Z4tOlGR0q8zJf7uyHN?= =?us-ascii?Q?uLrfbbaNhCHVJ7R+fX4ZSsNJoMdrl1V1wmYI7pwzpss8rvb9DxbbShv0f2iC?= =?us-ascii?Q?CVMjLgWagLipvfFB/tDFEqI9qFYgC05CV9hmdxizs9lIhDrdAx7zXDVBVEgz?= =?us-ascii?Q?FlkbidACdmY6DJDurvPQj9EMH5L8xNhz3MUo11WAwECH1vxXY/nIBDKhpoL1?= =?us-ascii?Q?9qaeWRzkOwCjXPbhZM55bym7S2245oobUutvZu/z5Ae3me/eGi3CdTS2sIrg?= =?us-ascii?Q?RQWaOxjdhSZH6cnTf+/TjJxWBQ0zoJyLLY2oR3D9YT6mJNqyo6mwzWI4o2VO?= =?us-ascii?Q?HGXJaQZYDDQwlgjMOLdYCiSJaFE6gOZH9rT5vEcbJmWsWoFAwY1+a+++xMnA?= =?us-ascii?Q?DbtomktxcKQIkBs28w33oOUqIgDOKaYP6tA5ulSmY4antesF2vfrjxIG0km0?= =?us-ascii?Q?yuhPjPWxm+q//ljb5GUW7Dm4Wg3pFxHfKnUXbkOPU14Mr+mSY3l9+qDr2WkQ?= =?us-ascii?Q?cBEM7DdLR0+DRhFHgfoR842bwtNiObl5ML4iRQgFwnP+iNM4Sn64op3zNZRh?= =?us-ascii?Q?dtMxiQO2NmLlahL8Gp4CZOa6+iZTBJm7hNESgsbvMDlPt8ltKqKlVbbB3o9k?= =?us-ascii?Q?QcOcqf41IDhCkvc5RxDXyGcYNsJIur8=3D?= X-Exchange-RoutingPolicyChecked: t0EHbI/OoNNPm8DBLS50qX7xNGxehClsCXhZFZ9B7bFVAo4t6C5WZaflV/3hVhbwpgZx5yTBuuJyH10GQMKxj4tSbsZjiT+QCcPsLX5iEsMYo2HzsZnKoinozdJ5GUH/ydAGNboEQWH1UyIJeBDVLkxwnd8Owvr8rr5TdZSf2G9q+f+PkeycsbZxnlm6bJlrqPZx4FhY56SHQxFPr4brkdTqeFwbwGLF0umU9YyjbXqQlBPaOMDHlWrZzjDMPHCOAWi0ZnQAEzZDBUmmC3KD6fNv2DY9CqQ17oQ75ZRskS7Z9J7ti9mcKadRL7TP1HjzCXpGPYuxY1fZvJhQdjDS9Q== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d4af9134-80a9-4191-dda1-08df2b90bc1d X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 14:21:14.2089 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: epsMdh+/Sx9avIERamq7GSCobqJB3Uow0q67GIRdNl88W4yr1hJLnwAOz7piTt0gaKynzORYhgcjNLfuvq8lCwvDOyYaHYq4ESVHYnC4Ldo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR02MB6547 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX621WD9LNx0pS W1bjqEBQov0diufXQjjhY4nBlWX3m4n28N1jhxeG3y16MX6mKbyHfjjuzPeLsjwRORSOyZ9oFou TS+GmEAcI2wUOhHCwC4zuDJBpyOk7C8= X-Authority-Analysis: v=2.4 cv=G+OJgNk5 c=1 sm=1 tr=0 ts=6ad232f7 cx=c_pps a=8h7WK4dQWB09CNKj11a7yw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=660iZSQnnn4A:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=dEe9Ve2bX-KnNSUMM2s9:22 a=64Cc0HZtAAAA:8 a=8xmoOu93QUavKZLLyKsA:9 X-Proofpoint-GUID: taTb4rykIkdH5mIPA0dCdcY5eM4jvn1m X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX5mc7USv2Y8K2 9s6sgKs/5Pi4qGk7abAHJQ8wbK4E1mbjIICW085REXWJwl74DqxTKQjF1+61FkXkeCKe3SKnoE5 roou4cAAzkedwxodrG571bOhokixvBXzRNU0IsUfPlryOM21E7Xhg0NPCzFqqrjsjAB3Dh2g19q +mBLYgvc55io8x0Zv0sWW6PfdnNHme9QmdvFnyM5aBFBY8X+wVkR18yq9jLNghJmRgC3LGCbfW8 Gkz2ZdwFLoCzOe157+AmRrNWAW9r3RpF9IauwWDlLns5Yzf6EDABwhJmnl0bjHymfgw07N8MOP8 WhBYREGs4ksPLewC2s7XexWEoVvT5R8SbdpIdsuiUbGCdUGNUNuV2klDdMUnMLDFym/m0IGwd/d 2ngroPV1UXaSa5Lyo6OzZDhIfvnQQpKnXBUqksX7CiGfaHE6xlmVS/1j9GgSHDOYqwHpp8ln1IT eLzCtk1/UI6YaNqZc+w== X-Proofpoint-ORIG-GUID: taTb4rykIkdH5mIPA0dCdcY5eM4jvn1m X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-16_02,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-16d1c6/1792160509-F72C677B-1A0DB23A/0/0 X-purgate-type: clean X-purgate-size: 1238 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1792160526176158500 Content-Type: text/plain; charset="utf-8" This device represents a single KVM 8259 PIC and its associated class and ensures that we can safely embed the device within a container device. Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell --- hw/i386/kvm/i8259.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/i386/kvm/i8259.c b/hw/i386/kvm/i8259.c index 85176dcf80..8ae5dd39b5 100644 --- a/hw/i386/kvm/i8259.c +++ b/hw/i386/kvm/i8259.c @@ -20,9 +20,11 @@ #include "qom/object.h" =20 #define TYPE_KVM_I8259 "kvm-i8259" -typedef struct KVMI8259Class KVMI8259Class; -DECLARE_CLASS_CHECKERS(KVMI8259Class, KVM_I8259, - TYPE_KVM_I8259) +OBJECT_DECLARE_TYPE(KVMI8259State, KVMI8259Class, KVM_I8259) + +struct KVMI8259State { + I8259CommonState parent_obj; +}; =20 /** * KVMI8259Class: @@ -154,7 +156,7 @@ static void kvm_i8259_class_init(ObjectClass *klass, co= nst void *data) static const TypeInfo kvm_i8259_info =3D { .name =3D TYPE_KVM_I8259, .parent =3D TYPE_I8259_COMMON, - .instance_size =3D sizeof(I8259CommonState), + .instance_size =3D sizeof(KVMI8259State), .class_init =3D kvm_i8259_class_init, .class_size =3D sizeof(KVMI8259Class), }; --=20 2.43.0 From nobody Fri Oct 23 14:31:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1792160533; cv=pass; d=zohomail.com; s=zohoarc; b=iLcq5IPFcGSYYHw4URbWx9rjydlOOyvNidFIZak5FXEWa6dqv1mPWoZnjuxU0Hnx0HwwjGOxbRz49bpuPGHyuItGPOzl5OHpwd74V68dSnUvv0aEoc0kxbM3cd+3CD4qsujBcaWi0LAfZZSKTVTRcV7hBzQeCSSIL5UhZ3nVJ6A= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792160533; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=rQp9h/2ajwF1qe/Mp8V/9gopdrz0ooiX8EYLWq59avk=; b=C0x4hMZLiblBG2DqkdS4Cawtw/qvvIdhRVSBs32U0qZv18+Gk4ukeR7WSYA5FuJNCSSITCDEHBuFJqO2EzufyVNPTkDuuCMVZ4PsE8Cs01Bs8X3ppv+KtKkyqjtaaAsIg9IcocgYNQbCEm+M+pnOlptLqmNRJsJHFhX/DBHCiHY= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1792160533257753.2358037310572; Fri, 16 Oct 2026 07:22:13 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1452005.1666920 (Exim 4.92) (envelope-from ) id 1xHion-0004ia-6H; Fri, 16 Oct 2026 14:21:57 +0000 Received: by outflank-mailman (output) from mailman id 1452005.1666920; Fri, 16 Oct 2026 14:21:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHiom-0004iJ-Vi; Fri, 16 Oct 2026 14:21:56 +0000 Received: by outflank-mailman (input) for mailman id 1452005; Fri, 16 Oct 2026 14:21:56 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHiol-0004dS-TC for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 14:21:56 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1xHiol-008oLT-9m for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 16:21:55 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6ad232fd-8faa-0a2a0a5109dd-0a2a4504a998-14 for ; Fri, 16 Oct 2026 16:21:55 +0200 Received: from [148.163.155.12] (helo=mx0b-002c1b01.pphosted.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6ad23301-b57f-0a2a45040019-94a39b0c156c-3 for ; Fri, 16 Oct 2026 16:21:55 +0200 Received: from pps.filterd (m0127843.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69GE5MK93333355; Fri, 16 Oct 2026 07:21:44 -0700 Received: from dm1pr04cu001.outbound.protection.outlook.com (mail-centralusazon11020128.outbound.protection.outlook.com [52.101.61.128]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 4haukukqe3-4 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 16 Oct 2026 07:21:44 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BL0PR02MB6547.namprd02.prod.outlook.com (2603:10b6:208:1c8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.23; Fri, 16 Oct 2026 14:21:18 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%4]) with mapi id 15.21.0522.016; Fri, 16 Oct 2026 14:21:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=rQp9h/2ajwF1qe/Mp8V/9gopdrz0ooiX8EYLWq59a vk=; b=BVZz4p1LerFy3PNcVvgEKNaK0AD0f/sJwbwBN0VGlptHvoB4A/PDV58bD w4Tsd/aPRMYJXc4hDGE2HStbESH5x2KsLd0W9/TERNPua+JbpHZYMbWFx6IoTt3P 7wS1nuqCDQz4p83TgP/xRbMEKnBrQVtAtqBAX9PmiMuzX0VhUzdQimiDFQswL1P5 lWnTPE45H28H3frpQejG4K+ZmzhI/CqMjO6qlTIHHTFvzZLRnBOOAnrvaNw5CGjE adUVX6fc86PvpHfDzEdyP1InzXvS4zJaBcpkreDtKXuACAD4oydhYNwrtdIVlkpS a/9b1t90S3fo0bJX+lAy/uV/3KdVA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ikSKsOyH1KWIZzeqXeHlCrbU2BfiT1YDv+POEnD/SHm1ZWRoJCy7lttTvW11l+J0XTQ0NlaIOLZ2dcDB6aR7aPBbexXQF11zc7nu3x/dS3yb93QIpRSqG/kewXYogFM9dvEs4Y8yF4aNTuqbxgZY4jwxFf452CHcsfy2f2jpT6zwZC3THu9Lhyrfd8GR+bPoK5yDc54S/q3CBs/uekIaLNoxITFiPs73d1mMR8H7gWQAl6BibgVY4/rE9DhV4IJIhc4y7DGPUBYJ4wHPET2Pl4R0Yl1FUcbBCB1x4gTbShBvZ7EXgtxYmWOZwKIMdUS74Zr9wtjH8iIdf+nnT6NWpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rQp9h/2ajwF1qe/Mp8V/9gopdrz0ooiX8EYLWq59avk=; b=a9OeALpQDl5dmw3N4/VmoN9IVzLuQzfolX9lbSUmn16DgJ21jdUY0mcv6mqCrfUDjSRqwKG/ZrOtB6PiCFivwygWpzCdCaHgQCb/6uoyLGfOPWQX8X/BdE4GkXQ024N+SVaXbigN2K5Kv0+COD7IDVZoS81lpH1H+JkQWOR7hMW4MI95sDlJarsefMBR4+1iE92ElUcY/oDrxNDm15zN3VlT1KzR23bWqJ0le5nLLWvbaUCwRjHUz8jsnzNWNH1T3NNXzgiV2gGs5blPgoyVaPmFvAN7UjF4XX50hzZBaPmOCFfi1bB8HSOCrKp0WvSgDGOP3PSe23WyF/FhAIpazg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rQp9h/2ajwF1qe/Mp8V/9gopdrz0ooiX8EYLWq59avk=; b=VznEc69NPcS/hroBaq+pElWN5lkMo2kNZflUhgByi2Ah7wY+etfxV5XzacT6tHv9ph4RmhPz65uUprnWPYsYh9JieJA2HUsQiiSckhmhRPMYIZNy75DFlM/x33hm50YRgDrXZFg3GoN6Q8ELYdS5Br9pKwMtDnfRwAZ0OUy4N/8uSdK+mrgPChB8AWUgGc8YjqPsAvK3Yudi1jXYjs3nMm7V/oXXdOBnoBd8KvxDG9ECqf0AL3G49S466ioi5wg0invRRjKrwhvcfQfXT5Kl1lADRNp1yy7mXFvm6wYoka7dPE8WAeCWcqcaLZZH336zaRN3rOv1RKze1xracAcTFg== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nutanix.com; From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH v2 10/27] kvm/i8259.c: always use cs for I8259CommonState variables Date: Fri, 16 Oct 2026 15:19:16 +0100 Message-ID: <20261016142031.1204281-11-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016142031.1204281-1-mark.caveayland@nutanix.com> References: <20261016142031.1204281-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BY3PR05CA0021.namprd05.prod.outlook.com (2603:10b6:a03:254::26) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BL0PR02MB6547:EE_ X-MS-Office365-Filtering-Correlation-Id: 9cb69322-591a-4a5c-8fa7-08df2b90be6a x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|1800799024|366016|22082099003|10067099003|18002099003|261009223027099003|56012099006; X-Microsoft-Antispam-Message-Info: h3+4dWHUokHciwAntrMGHlrzYxoniCNtGJhojn1OP2KW1Y1bWdTKXx5ScDBQfLlhnso4wQIbawdCq8zKzvI5B7EDS1ApL5e3Z6pjIdU8fn3QLx63JTJmnhCMDKLYMHmWBxHVF6p2aKPutiQuZH9gF+IoLPHp6LoRM2QOwuZerBW9WKHoJ0yfLhGl+jOdZ3fPn7ZsH6xA1y0DSnUpPLbybD+bHSbbrlw4Y499yWko3SahJezoOu36hIYvqOr/qzTHgsbAU85aYuUG7UXKjckp6TT+fV8empH1Alqxql2uMJTBCvQ2LHAlw1phneTxNtA0/7fzMv3Iu2XUzSfdglst9f0XIaZy/0azTrZD5++HWnTV2+5i3EIxi5VklDc2DbX0qdEvqOgL2ocZlU9j303xYfuG+7zvzOKmYqLYgMbV8yI/fBC2EvA3DI2W9x/JnG+ZjZBEieV2XZWeYnqdUHpAkgbe9EPWQ5qE3ZhdSVCOloES3r/shhEayPRicOrsQ4HHTObkyQtqeLOQQyHZFXtii4ND+Vx3niTVkcxAENeFQKIkgku/Kx4LdTB2F27OP6R3VhkqxY6euHpsilobpj3YR1H0s7C8tBYgGDXo+ErjGFe6XbP/FNyzwlYYsBnnBWdmm4+S9HBxnYoAyvAx9UBa2pE/TxbpxVL0/69sIvF5wtE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(376014)(1800799024)(366016)(22082099003)(10067099003)(18002099003)(261009223027099003)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NNNscgb8dKtq3S0Poi1usa9G+LKHgzUj33tSC84e/0gIx96JRQMEMuqoOTAy?= =?us-ascii?Q?0GSWHh7cpdgQOcrfOaxTez2I61HSOtyhhGUvDQeQbabkkauBVMaI2fhZfoD0?= =?us-ascii?Q?koppSNPTDsYgmDZbgx07CG5DGMHWGCvTXmYzqL7gs5wr4zgLKKDbrPUMH1xK?= =?us-ascii?Q?G/iQzUNmsreYD5Pgf6EWtkbEEVqD76vGEQm4kLTCs3w2PS/ItqyCKLFad/ju?= =?us-ascii?Q?fTPM7pDOX07kD9/tvgq93EOdfzn6u2eP/PgHPvLzBx/z+XQbgjsUP+0cu8GK?= =?us-ascii?Q?myF+l25/TlzL2C0akRlVHKaLXpkp2LitRQ8P28iDTwRk2SjQqmBxMFNr6TDR?= =?us-ascii?Q?c7Jz6nmB9HTpe3447t6GdfRAZzGv5V2vsq+ot9z5eUln1Pv1OHmsZZg1bBA4?= =?us-ascii?Q?SoBwpv+pV6DbTH4Lh8o4cQpBSG8p7cM5Oc53wB41YxfrPFk5ZLnzDGF7orUl?= =?us-ascii?Q?lrFvecS8EONdhsexHa+h4QJEJq++lygrEvyRyhuOCqjCrkMAQC9+LO/4XyhF?= =?us-ascii?Q?joq+045BeFhI23zT6aUTOapGgADsIp+nsZtdCRQgFUOCGsgGM/siVRsSnjkD?= =?us-ascii?Q?QuyEjG6fsENH+rCnl2jCMA42jQJCMXerDb00/C83MFtSpsGPHapiMWCKlw7e?= =?us-ascii?Q?t9sPdW3TpurhrtQTiY9xT8UjngjMVYbOw988DFjL4UvDJezZMNJjxixud+x8?= =?us-ascii?Q?f/0k2LGdn0xlEAmQlUo5CEX4qLtPtRyheM0V1XvxQDe07jX/04y2om0ajMzW?= =?us-ascii?Q?5cDuVcvQ1CNYlR0FJY2EHEELsJC+YJvEbTXE6/kLd2rYLVL7VuE8aP3oCebG?= =?us-ascii?Q?G1JAVcKMjzEzfc/RaJxPY5EfG/hUpXfwjpRzP5qJAsrp2LdkobUiF9X2dRtg?= =?us-ascii?Q?8VMf7zJO38zMFHyttEmXiL3kOtLwjOkOn3Lk0tMo8hN0EqlFj2lngvYVZfwx?= =?us-ascii?Q?fQOQ/Vd/Ivkx0swFKWaog6L7x85qvZbSm9RCunpsgM0y0mgP2OyGrZFOTNJy?= =?us-ascii?Q?egfyN2DFjWWnZU+pgn6GMk89271+I5eYuvKse3khL331JnEutdmOacPLjN7o?= =?us-ascii?Q?64vRGHeUnFxSd2fxXVAFT8BG33mjVNmryWFO3HvzMTDkFcjbeMjZ8VaNQiSg?= =?us-ascii?Q?mudWJ89Ps43XIWhbxxmaJT75V1GFcTCgssKST4uFdEd/upFm3aOAbTvpTG/g?= =?us-ascii?Q?eV+CCQ5u0j/R+9qi5U8xGvrCFDu31c8aPcwsiOims3xvfBF15yxmwOUsy6i5?= =?us-ascii?Q?FnoOvrwPosQjHB7vN3C5S6fu3PvhAtkATFtBmDDiS4N6Z2jQfvLOfbAqCMU1?= =?us-ascii?Q?x5UnN4JBXAi6BQINCXuPCGEYwU8G7/AzD45JfaaomOpCT5p2edcffJ1NFYgi?= =?us-ascii?Q?x1cWxz7Brpz9QZA44tdMwuQrx3ucSlzffOualulyvfLwYRsZ/PfrHqHXW+hT?= =?us-ascii?Q?sRCuoTED63bjcshY+eF7Kwi9+vzpQeIcl7wuAd/ndsCprrFA6Sr5KPxTwh25?= =?us-ascii?Q?IlSR5TLkcTp+y47J4EuawqpCzhHH909oCLyT9A8lTkfytkLq1syTT76SiZx/?= =?us-ascii?Q?25+tZO3x36xEd3kpP2qWDvvp8ThNn130By5WnsK6TvkBOuquDsMowa4TaU9Q?= =?us-ascii?Q?TwV9Op0Zl+Mf4hPyL8kVNdsv+yyTb37tGwO52F0wWEhVK6t2vnE4ZTQVPF73?= =?us-ascii?Q?d2t/6GMcc0qZ0NSfThgdyc+QlJnLYBp7+F4QUbvVkuY4dCr+g7iXvq4BA3dz?= =?us-ascii?Q?+pBVJ0R5rlEDJggfOSld+PS5FuRKAUM=3D?= X-Exchange-RoutingPolicyChecked: EOo56rIx5CTJC554u9DZf3LHzx3+epWkAPMfAn0AI4l4meQchYxu5+xkMC1dcBoHsk4/qLO9Hp/w5/K82Ds2EmTUOAN78SZROVskZP9I8eCHmRpaSCRsghZmyU2BCUwQ2Fl1FxW69Eu1Am9SwHdctCwyW62qoUGufQ+K3NbeIac3ZYlD3r6yu72xQDT+7PSkVwZU/XtYkesrnm1RsCObalDk15mRuSXkMtNH9eS0lhtQFfmcbhdNyCRRnxN0MJB8wfHxIYGZnuWusAq262qCrTXZvfLq4dK3vpcCoQ3oBMfiUuKRr/sZcUHKSdSz0Oe8TLnKqx7o/C5ETbOkkx8W6Q== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9cb69322-591a-4a5c-8fa7-08df2b90be6a X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 14:21:18.3323 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3CPyAiDUUj3XGCyDLiAftW8srhRxKFch2lhjINPQOssQd/1Ygqgp9Va3R4o9gqH42zrmSlmHAhHxi3GKPY0fCx08w+ZnvWbC+qBK1M9ERNI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR02MB6547 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX40ymsmU7s2WA AXr0jAkO/bJYaRKBZ7lluad81MvyyinZ6fRX5cdoQCubrtk9wnKx1CAyiuo1Sm94yk+EMPalN9A Evzao9IbwFiNEe7Sam1ykxV97zdhp2Q= X-Authority-Analysis: v=2.4 cv=G+OJgNk5 c=1 sm=1 tr=0 ts=6ad232f8 cx=c_pps a=8h7WK4dQWB09CNKj11a7yw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=660iZSQnnn4A:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=dEe9Ve2bX-KnNSUMM2s9:22 a=64Cc0HZtAAAA:8 a=zNa_6NNZsa7Vo5epgMYA:9 X-Proofpoint-GUID: 8JBZLFG7-_g7VBHSOCD5LHGfV5f6xg-5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX2hpyj0/o1IvH /0qzXsZN3qzZXIHhrPEUxfUHiefDS6Jz+cht86Au2RBZOtGpy7FKSeiaMkf5UGJJSBaW5aUzIhh zi5zZyD7jb+xyIn0EMFhSMdjh0L9nv2svTvofqG9okxJoCgXEIJss2lsWsxrUmedrzAN/8zCyZL fBpjpajLDjy+7KwSxfBbP9NG+6KbgwxM4JSidG2Z6arqG/R81cEC6FgQcSgAPOQl9a9EcnMI5v+ sKCv2A/JZF3Iu3KrBebyi+oNxTq8FjBbAGw8y8WIREWUroRPFthSlEBg5k15g6d9UgkEth9aAcG 9HRxHEzCI82COMWn+Lv6YmuZqj4Bbjx05s0a/mMBUgnY19nq8jQBOQn/0JS78wwbU6SpSSCIgvg 1jgZqwObweX6JbSSsEVIkOEFTQPoSyqzTUFHBRgBmV838BtKWSkoNidy2tughzYxIPRAvevW0BX 4OSAmtGIhP26mBsIFyw== X-Proofpoint-ORIG-GUID: 8JBZLFG7-_g7VBHSOCD5LHGfV5f6xg-5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-16_02,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-ebf023/1792160515-C30CDB50-118B43B8/0/0 X-purgate-type: clean X-purgate-size: 5245 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1792160536364158500 Content-Type: text/plain; charset="utf-8" The use of consistent variable names makes it much easier to follow which fields are being accessed from I8259CommonState. Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell --- hw/i386/kvm/i8259.c | 86 ++++++++++++++++++++++----------------------- 1 file changed, 43 insertions(+), 43 deletions(-) diff --git a/hw/i386/kvm/i8259.c b/hw/i386/kvm/i8259.c index 8ae5dd39b5..86b1ffea4e 100644 --- a/hw/i386/kvm/i8259.c +++ b/hw/i386/kvm/i8259.c @@ -36,13 +36,13 @@ struct KVMI8259Class { DeviceRealize parent_realize; }; =20 -static void kvm_pic_get(I8259CommonState *s) +static void kvm_pic_get(I8259CommonState *cs) { struct kvm_irqchip chip; struct kvm_pic_state *kpic; int ret; =20 - chip.chip_id =3D s->master ? KVM_IRQCHIP_PIC_MASTER : KVM_IRQCHIP_PIC_= SLAVE; + chip.chip_id =3D cs->master ? KVM_IRQCHIP_PIC_MASTER : KVM_IRQCHIP_PIC= _SLAVE; ret =3D kvm_vm_ioctl(kvm_state, KVM_GET_IRQCHIP, &chip); if (ret < 0) { fprintf(stderr, "KVM_GET_IRQCHIP failed: %s\n", strerror(-ret)); @@ -51,50 +51,50 @@ static void kvm_pic_get(I8259CommonState *s) =20 kpic =3D &chip.chip.pic; =20 - s->last_irr =3D kpic->last_irr; - s->irr =3D kpic->irr; - s->imr =3D kpic->imr; - s->isr =3D kpic->isr; - s->priority_add =3D kpic->priority_add; - s->irq_base =3D kpic->irq_base; - s->read_reg_select =3D kpic->read_reg_select; - s->poll =3D kpic->poll; - s->special_mask =3D kpic->special_mask; - s->init_state =3D kpic->init_state; - s->auto_eoi =3D kpic->auto_eoi; - s->rotate_on_auto_eoi =3D kpic->rotate_on_auto_eoi; - s->special_fully_nested_mode =3D kpic->special_fully_nested_mode; - s->init4 =3D kpic->init4; - s->elcr =3D kpic->elcr; - s->elcr_mask =3D kpic->elcr_mask; + cs->last_irr =3D kpic->last_irr; + cs->irr =3D kpic->irr; + cs->imr =3D kpic->imr; + cs->isr =3D kpic->isr; + cs->priority_add =3D kpic->priority_add; + cs->irq_base =3D kpic->irq_base; + cs->read_reg_select =3D kpic->read_reg_select; + cs->poll =3D kpic->poll; + cs->special_mask =3D kpic->special_mask; + cs->init_state =3D kpic->init_state; + cs->auto_eoi =3D kpic->auto_eoi; + cs->rotate_on_auto_eoi =3D kpic->rotate_on_auto_eoi; + cs->special_fully_nested_mode =3D kpic->special_fully_nested_mode; + cs->init4 =3D kpic->init4; + cs->elcr =3D kpic->elcr; + cs->elcr_mask =3D kpic->elcr_mask; } =20 -static void kvm_pic_put(I8259CommonState *s) +static void kvm_pic_put(I8259CommonState *cs) { struct kvm_irqchip chip; struct kvm_pic_state *kpic; int ret; =20 - chip.chip_id =3D s->master ? KVM_IRQCHIP_PIC_MASTER : KVM_IRQCHIP_PIC_= SLAVE; + chip.chip_id =3D cs->master ? KVM_IRQCHIP_PIC_MASTER : KVM_IRQCHIP_PIC= _SLAVE; =20 kpic =3D &chip.chip.pic; =20 - kpic->last_irr =3D s->last_irr; - kpic->irr =3D s->irr; - kpic->imr =3D s->imr; - kpic->isr =3D s->isr; - kpic->priority_add =3D s->priority_add; - kpic->irq_base =3D s->irq_base; - kpic->read_reg_select =3D s->read_reg_select; - kpic->poll =3D s->poll; - kpic->special_mask =3D s->special_mask; - kpic->init_state =3D s->init_state; - kpic->auto_eoi =3D s->auto_eoi; - kpic->rotate_on_auto_eoi =3D s->rotate_on_auto_eoi; - kpic->special_fully_nested_mode =3D s->special_fully_nested_mode; - kpic->init4 =3D s->init4; - kpic->elcr =3D s->elcr; - kpic->elcr_mask =3D s->elcr_mask; + kpic->last_irr =3D cs->last_irr; + kpic->irr =3D cs->irr; + kpic->imr =3D cs->imr; + kpic->isr =3D cs->isr; + kpic->priority_add =3D cs->priority_add; + kpic->irq_base =3D cs->irq_base; + kpic->read_reg_select =3D cs->read_reg_select; + kpic->poll =3D cs->poll; + kpic->special_mask =3D cs->special_mask; + kpic->init_state =3D cs->init_state; + kpic->auto_eoi =3D cs->auto_eoi; + kpic->rotate_on_auto_eoi =3D cs->rotate_on_auto_eoi; + kpic->special_fully_nested_mode =3D cs->special_fully_nested_mode; + kpic->init4 =3D cs->init4; + kpic->elcr =3D cs->elcr; + kpic->elcr_mask =3D cs->elcr_mask; =20 ret =3D kvm_vm_ioctl(kvm_state, KVM_SET_IRQCHIP, &chip); if (ret < 0) { @@ -105,12 +105,12 @@ static void kvm_pic_put(I8259CommonState *s) =20 static void kvm_pic_reset(DeviceState *dev) { - I8259CommonState *s =3D I8259_COMMON(dev); + I8259CommonState *cs =3D I8259_COMMON(dev); =20 - s->elcr =3D 0; - pic_reset_common(s); + cs->elcr =3D 0; + pic_reset_common(cs); =20 - kvm_pic_put(s); + kvm_pic_put(cs); } =20 static void kvm_pic_set_irq(void *opaque, int irq, int level) @@ -124,11 +124,11 @@ static void kvm_pic_set_irq(void *opaque, int irq, in= t level) =20 static void kvm_pic_realize(DeviceState *dev, Error **errp) { - I8259CommonState *s =3D I8259_COMMON(dev); + I8259CommonState *cs =3D I8259_COMMON(dev); KVMI8259Class *kpc =3D KVM_I8259_GET_CLASS(dev); =20 - memory_region_init_io(&s->base_io, OBJECT(dev), NULL, NULL, "kvm-pic",= 2); - memory_region_init_io(&s->elcr_io, OBJECT(dev), NULL, NULL, "kvm-elcr"= , 1); + memory_region_init_io(&cs->base_io, OBJECT(dev), NULL, NULL, "kvm-pic"= , 2); + memory_region_init_io(&cs->elcr_io, OBJECT(dev), NULL, NULL, "kvm-elcr= ", 1); =20 kpc->parent_realize(dev, errp); } --=20 2.43.0 From nobody Fri Oct 23 14:31:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1792160522; cv=pass; d=zohomail.com; s=zohoarc; b=ib96pv2CWxYPsBR6p68UrcGnF9grIFjHR3OGicPFJ5m2z4fo5ZF3DjHqtBqRfnBVjpqy6ZGDKehiDliZ4zNjtc6f98ePE0ruzKwcnwC4QVFL5+qs3lpzACMoAEwQsXu9lRAb67DeMJWjT5Isiir7H8DP8CD2MdvQMCjG0b4p9Pk= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792160522; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=dsWOAxmohqRbnu8OIkKy3L5qtCU9Q47z4B6UIej1IlQ=; b=SApX4FEBeAdbAjUK1V/QVE9vFRl8FGvEK1vDveY/NRQlONARr9lij1cP2DJcUAPbtDYjBC7PCuXyRd4jDMIFcBPDKJ5fVdaDvU498FLnvxXBbPA2ciRjr1YDYDVmK5MB20agoc1ZxBNGGE6AITu4QCIwuMeLAQKqx0F+tf5cLbY= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1792160522752274.99014704227557; Fri, 16 Oct 2026 07:22:02 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1451994.1666861 (Exim 4.92) (envelope-from ) id 1xHiod-0002s7-V3; Fri, 16 Oct 2026 14:21:47 +0000 Received: by outflank-mailman (output) from mailman id 1451994.1666861; Fri, 16 Oct 2026 14:21:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHiod-0002rs-Qf; Fri, 16 Oct 2026 14:21:47 +0000 Received: by outflank-mailman (input) for mailman id 1451994; Fri, 16 Oct 2026 14:21:46 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHioc-0002le-7O for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 14:21:46 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1xHiob-008oLT-KL for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 16:21:45 +0200 Received: from [10.42.69.8] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6ad232c8-8faa-0a2a0a5109dd-0a2a4508cb9e-22 for ; Fri, 16 Oct 2026 16:21:45 +0200 Received: from [148.163.151.68] (helo=mx0a-002c1b01.pphosted.com) by tlsNG-c1860d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6ad232f7-f659-0a2a45080019-94a39744f4b2-3 for ; Fri, 16 Oct 2026 16:21:45 +0200 Received: from pps.filterd (m0127839.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69GE60JU3247562; Fri, 16 Oct 2026 07:21:24 -0700 Received: from bl2pr02cu003.outbound.protection.outlook.com (mail-eastusazon11021116.outbound.protection.outlook.com [52.101.52.116]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4haxj9389v-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 16 Oct 2026 07:21:24 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by DSVPR02MB11424.namprd02.prod.outlook.com (2603:10b6:8:352::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.23; Fri, 16 Oct 2026 14:21:22 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%4]) with mapi id 15.21.0522.016; Fri, 16 Oct 2026 14:21:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=dsWOAxmohqRbnu8OIkKy3L5qtCU9Q47z4B6UIej1I lQ=; b=AfdKqOJTyzjIGYdIFwPAFG2Xi4UmhJE7JndCg+BzuwLe7aEZGoTbZdlYT U6tniKyQOnN6pIswCNok4bjy4X+lBcJm1uPk6qzVcraSjS7tdbA1zi/1hJFqud79 TyaJ6BjDeZIpoUndMV/UyWRcvGbzJxu8kpHa3vdn3sFgBN3Bs41Fec8TVK8CVvtJ z9Ksh/FarBYNVqEpdWV9G665L26ivP9QQAYBvstYdvvBJb7F51TdmXN23hYC9i06 LaC3uyl53VjCgg/YwwUtZlMTknQGgvdocZ3iLizKxjtw6B7BWI5aD1v6E1IableJ ZrbOwpZfHb8+OfxEvOVyFTnu1LN9A== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ISij/P50Ow7LetdTqfgnqY2l0S7UngSeXllVBUKQHxTs4QDl36kuJq993DQfjSI2aX5sd21VDynzcM2XI/WvngAVf0GQl3oBVcwi4frmp8jcY+5ez5601qQly61BoPeSNahm+jKVn3PNkoDLc1D8tJ/g8t/bzIuV7x5qHmGx0p8LzaiSWayBFIQ39nTc4V3FFrlXSAb2UZFS0XV3f4SmOYVKtjInYpiei1Wsx1ls4fhUCefB00wkcZehYxinnzzcIw/9F8Eq4tLrOiNErTbgt2brCkmpBRYlMnQX1fzsZeQIjU6z35SpCtx4DymFNb40lkQZyu+vJKrUsSK8u2yLbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dsWOAxmohqRbnu8OIkKy3L5qtCU9Q47z4B6UIej1IlQ=; b=Vx3xeHk/QJfQ7UwCt9DDHhFuq1AarygssVSzmZxQAKjZKkrbIFzZrtowxp7NSHDPiwouO83kh+7wH1Lx4zctzGwUn8p8I0pQK8fVzxT45dHGEkIaalM2/19oL2SNkon0i7lWZKrFBGYRWReivLxNensHGVtLgILjpyyLKSgqnEpd6wYr2vPQcuZeQ3CakWLWKaIbFQT8YZ/Br6Us+AVUpfu31Ia27LBUpnfZSlQ3ceU/ybwPKhDSYcWRIApkuPa2bQev/nmiLzABL7nfxua0BjsHgLo8kAsdChNTj10lR3l8i6IM5hVp+ywApEGxxAAmEircZTpsuCi/YSNRLW5vEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dsWOAxmohqRbnu8OIkKy3L5qtCU9Q47z4B6UIej1IlQ=; b=oP7bBQsxDXsiLiOQgJD/Ktqxq2cF7pfMFsFuxjh3FkIYXGcDqmcyzuj8qzSTK5wmXIH8cBXSBt2QXxNERVS8/7Rx7gkAihSmhhLyLMtRq30CJH13IzSMdjXKovRh+SrnjcmkYzmCA9vZyXSGf4nIIJrsygV9MJkmIXVeUN6Fr9n/bo/QzeIznwCrlIy3B0zVGZ14txuq4dnSHbooRtUVHrM9XHfPUhYU3VJkkxiD2leFB3UdQ2KnTJPrreZjlnf2YOjM/+uYefwIzNZqw42V7KMgSd109RHLuu8UP+sSSA/Ku6BiLWKPFrJn3BOCmyTVeERU2YffMARs+NV7iObJsw== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nutanix.com; From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH v2 11/27] i8259_common.c: always use cs for I8259CommonState variables Date: Fri, 16 Oct 2026 15:19:17 +0100 Message-ID: <20261016142031.1204281-12-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016142031.1204281-1-mark.caveayland@nutanix.com> References: <20261016142031.1204281-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR03CA0131.namprd03.prod.outlook.com (2603:10b6:a03:33c::16) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|DSVPR02MB11424:EE_ X-MS-Office365-Filtering-Correlation-Id: 1b07bedf-54ff-4e0a-fa2d-08df2b90c0d1 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|366016|376014|22082099003|10067099003|18002099003|261009223027099003|56012099006; X-Microsoft-Antispam-Message-Info: vYZjL7dvl3NX4wgj8lniT8Md1rmbV5fqYKMk+5QdammVoBiipmxVOapI5DbQIPD9GTUxew1h1+GqvWYK74squV3ureRbmLfzARMauLZiMjP89O6vPAZBukRhOyT1CUwmxFAUV8b00K+bf8u1iDXfJSiigKXxuqBSM/s8M6wMovba4qkjtvPLfyFrvikL//YpeNEs+6etv3hY+ZgFr0/yDWV/9yS2NipYdY27K630dINgoLOU7S+5ULsfx12MI+rDgA6YfbljfiPZ7WWxn/8wuerlr2GUblDZMJxGgxyTTgYIrgXS3rHFr8z+AnmP83e1r4mPaZ5SnT7YGCzALCeUZ/Jl0eoDUIuqg3n5Cc0mfbQPeKqFwQ0GoEU0+xhqk2JhuK8LvtzvtcvVCQIiElAXH25tvzjd9OvJudCiVTiSz7I90JnWwPp18F/PUTdlGyzgPVMipfjD2VLXwN9JDZWDUfrcWvbb9wRGmDDH+ZYGkIR2Zt668k3hszM+9ziGD5rVMtxy7gESq3xMu0G9qk8nj2HncsYdz4jrPvDRrY2NMsPWY8Z6s22ZJSQb+nspsxDgHdhlCWFjHhhd8O+a8aQB7r2ti2ZBzwSFmZvC8KFWqBCuHH2yTCI16QF8wqh0RaMnKgVSSr3vCUFZEpLZCAR8FW0wcJS/FbY8O1l4vCdOxic= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(366016)(376014)(22082099003)(10067099003)(18002099003)(261009223027099003)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/wMVCwbfMV1TvYqYxCZWLwkhGFgoJ0MKtJyntibnAsGaR3PC2PXF7n+fW7I4?= =?us-ascii?Q?LXHJmTPjeKdQNjRYUjVV6x12ZtOKNO0mQ7r53q8DBGPvTqQTMvWhDz7+WMOf?= =?us-ascii?Q?sfStaIkM9+mcKGwhzLlN+RH5kym6R2PxH1NIKk9kGjY71RNRAnXSjZr6d72x?= =?us-ascii?Q?WTKUw5Vxm3eAUlUfOWAWfT4le/vytRGpnIBunHPaepLNuvHfVetruk5Gca7r?= =?us-ascii?Q?+p8b3lQTxlFEPI/kG3hbqY+icPSi8+5H0WV2agR/HXhlUXHMcu6S5czXUMGu?= =?us-ascii?Q?q7BOebhO87jwZ0q98K8C3GjldUWGTyReTm9PzhDRr15dqXdXluszoiV4mmaJ?= =?us-ascii?Q?9GbjI5cTpKuCNBBg9xzFhrf3OToIkoTZHxh1Ku/O5TP87xuaUouRPFtKaqj+?= =?us-ascii?Q?ttvK2jlLmfD1usGXLzgglBWbcITL6SmiI4iwgmlKaOZ9DO1C9GCT5crnTPi7?= =?us-ascii?Q?xRgxHNOlFlnBCLsrslaGWRizPyL47JeiKbi3aU8H6Cl/67NRSfpQwAZOpQIC?= =?us-ascii?Q?IWmt/NoLfX2Od3IgXrx1fEdtH4uqt6dGZ726PTAzQ/u9xjjbqo1VoBNXHZGI?= =?us-ascii?Q?XSce6pJ+nZCyYr2jIdG4r50in/00LSM1y3TBL/2gM1+VD2oypv5qfIvRHHTu?= =?us-ascii?Q?P4UCs4H6VViXrMaR5x/q4CSXag0cqKWfY8nZdgGuCkzd1RaX5HHDZtBfMZmw?= =?us-ascii?Q?1a3/mTEHnhqe2aJsaRksJJZQy+cbss95cmk4wya2DamiweIZPGjiZObGny2u?= =?us-ascii?Q?Um+tuHT71hry2VD5FmHSXz45tpWVgAtB6q6qxIPW4ODeip0BRRU91z0CYZhx?= =?us-ascii?Q?0EfeIAEES3w0P3oCg73NR2aFqmaDuaxxUttef4rRGrWrQcQMH+j80I+tBbeR?= =?us-ascii?Q?sV40Gh8D9J/MjuD14vXns7AhbUndBYzs4aTjjKpHBdDOaFpiUzLVrenurSdz?= =?us-ascii?Q?2ifoi//TXbiutv+YevnKFXsNRigwOqtBaEt8/jGCvTouB7oOsP6nh273dtKi?= =?us-ascii?Q?fOKsiM9uz0kxiaHNWALWsV1Du7sOEgOc9yZSImQxxJ8PudETb5wvXn76+tsQ?= =?us-ascii?Q?CQOy+7tIqLU3tYqm/ekO8s3Gy2EClqzdQVDP9kePvnKJo0FrkJQseMU6tgrN?= =?us-ascii?Q?68EBr+GZjb4m5MgAooaQYqgrVrlmmffjs8DR0Xw+ey+D1ftNXe/9bNy65mT+?= =?us-ascii?Q?iQNN+giiBbWDjrCYpoLS8qMidWqrmEFXOKA6zd/UjH9TjISjrvuzS1QWfwXI?= =?us-ascii?Q?XtvOClPscP2MyAHPEcD52LHTRLnZpXU5e6fPdPTcS6ygWwTmdhd5u4qROo1G?= =?us-ascii?Q?ElgOngil2sQhyBOJ9yoXUPDDTT1v6TEreHBy2NvmJywOLGdbzPnA/7dHBByX?= =?us-ascii?Q?XRxd0dWpIyGCfIKK1x/Xw+fb5MuS+mmnlE7eCqnlnFPk6syLp/B/wLv8T1hN?= =?us-ascii?Q?BQJlVyvsb/AUrZt0ClTThZ0IMpR1xUKSbPMv1PkznmRXPaqTcLAemx83HuFc?= =?us-ascii?Q?nu2o4+zDPa0R5Z0PfwSJRqbaOh464KDRAoa7h/wuD0bXUcjJWZJ8aSAZX9IP?= =?us-ascii?Q?OucuMFSbYqOTVrUOKstdeaT7/TCMSgvBRzi+DsYr2oXk5YMttD01BkAg0/RF?= =?us-ascii?Q?y8bST6VCPnHIwYE+OFwBJ8DJGSXBEfAH+NS9Vj9CZXGgUoHPjoyivoVmTS/I?= =?us-ascii?Q?dBMGvDejRBls3CP57H7a5gUG3FhgY3XeVA3hzIYDureDlyCsZCTN1q/zPmSn?= =?us-ascii?Q?/AxS+Qc8SZVUcw/xuIwD9aCYGsIvOQo=3D?= X-Exchange-RoutingPolicyChecked: cQ70Z37VyagmqNCLYgPAW5hSXjKwLZWTBT6iHIhRvq8gusm84WjcyChirr462s0L9qxuSRmBmpt48N9yRg+sx1qyw7IMPdhUxwt67zeeDpgWe14tvtftnm8iKBKZN2yC1A3O4ewysKMfWJei7s/aFulI45kc32cXXp4ifpp/gTrF4nY58STP3BqhP6fLYRs2b+1BC0X+WWy/9jjR3qtP2bNgafTWAjPRBQt57gxK7upz7CEijKOJbMfySBBa4QKVtdVgEFsryx8dHHjj4fUtmcyfR3Pk60KFn0cTjPKKQ5jO5BPg2QaZqrmE9virWBW1lGm74OxU1pt6aqMxLbhJQw== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b07bedf-54ff-4e0a-fa2d-08df2b90c0d1 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 14:21:22.3596 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VssWmOWAkKQkuzpSL9/aeKqq2z+bVClEJOEUlZjbYivNtdu4XeJ0Wfz+AkXF0KYzlMdOS+LIrmsyQZqOSJnAH4+rkGBOUXT5e+HZ1ebEn60= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DSVPR02MB11424 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX214Jpu7KER7K IVCJ6vs3vorFa6AjXJM7jEVZWpYvQt7taaRPfnnZuQAr70RLWTauuUTEIhuz6aPJ+66mninQg5t aa8nQr3MJ5kKOnG07WV9WpntE0ldUls= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX8V7JcSpRk3of FWn69VnTgmDIUTvnH4NqcVk9uaSjuNnqPZyjlECjzt+GRML6WLEwDxfgw8tgaeScALEPy85ACrU Q+yMKDzV1VK6gVshfHYrtLqy8PXr96cLHisc1IYtLEAcDsXrC/GJG/QALtJo+6XfKWX/EPCMydL HzLGObYK5quOmsRyI4kkkTa7VSvs6uOBMqVdyfI92ogJuY7b6a27ZWy6Kq6yNw8nbkdOzHhYpLw Pq8c5sRzwH8XX7Q63bt/d4tn2NWveyVND+Qz0iavMytETDf4vn/XLJItnqHiew8XEnt6pLM/pDy qhRezVMxvzd+aeIpQ3jKhMWMIf4hfF/fJI36EYrg3KVTM5Crx5Mqwo3TiGJwGA5tWrEWq+WfeP1 /m3oOY/luuv8Rm4b9r0+grrnzMXp7AqHLoWepBYcL0fooFmnVZcvK0kaq2brFxxh0LlS/LUpRAC 4hs+0m6OSET5biSc6Eg== X-Proofpoint-ORIG-GUID: 9BijS6P-u8FfvluJ6mff_JSI0miuWALB X-Authority-Analysis: v=2.4 cv=ItOL47/g c=1 sm=1 tr=0 ts=6ad232e4 cx=c_pps a=LbO2ZyHrMbRaCxC771SosA==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=660iZSQnnn4A:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=y4UcunY2MAxhM4LwGdWI:22 a=64Cc0HZtAAAA:8 a=m1qT39pvC01PgN2II3AA:9 X-Proofpoint-GUID: 9BijS6P-u8FfvluJ6mff_JSI0miuWALB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-16_02,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-c1860d/1792160505-CDF4787B-5703AB7C/0/0 X-purgate-type: clean X-purgate-size: 5647 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1792160524141158500 Content-Type: text/plain; charset="utf-8" The use of consistent variable names makes it much easier to follow which fields are being accessed from I8259CommonState. Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell --- include/hw/isa/i8259_internal.h | 6 +-- hw/intc/i8259_common.c | 74 ++++++++++++++++----------------- 2 files changed, 40 insertions(+), 40 deletions(-) diff --git a/include/hw/isa/i8259_internal.h b/include/hw/isa/i8259_interna= l.h index e039d6f067..71fdd74266 100644 --- a/include/hw/isa/i8259_internal.h +++ b/include/hw/isa/i8259_internal.h @@ -37,8 +37,8 @@ OBJECT_DECLARE_TYPE(I8259CommonState, I8259CommonClass, I= 8259_COMMON) struct I8259CommonClass { DeviceClass parent_class; =20 - void (*pre_save)(I8259CommonState *s); - void (*post_load)(I8259CommonState *s); + void (*pre_save)(I8259CommonState *cs); + void (*post_load)(I8259CommonState *cs); }; =20 struct I8259CommonState { @@ -70,7 +70,7 @@ struct I8259CommonState { MemoryRegion elcr_io; }; =20 -void pic_reset_common(I8259CommonState *s); +void pic_reset_common(I8259CommonState *cs); ISADevice *i8259_init_chip(const char *name, ISABus *bus, bool master); void pic_stat_update_irq(int irq, int level); =20 diff --git a/hw/intc/i8259_common.c b/hw/intc/i8259_common.c index ac8dc7cf00..705a28ecbf 100644 --- a/hw/intc/i8259_common.c +++ b/hw/intc/i8259_common.c @@ -33,33 +33,33 @@ static int irq_level[16]; static uint64_t irq_count[16]; =20 -void pic_reset_common(I8259CommonState *s) +void pic_reset_common(I8259CommonState *cs) { - s->last_irr =3D 0; - s->irr &=3D s->elcr; - s->imr =3D 0; - s->isr =3D 0; - s->priority_add =3D 0; - s->irq_base =3D 0; - s->read_reg_select =3D 0; - s->poll =3D 0; - s->special_mask =3D 0; - s->init_state =3D 0; - s->auto_eoi =3D 0; - s->rotate_on_auto_eoi =3D 0; - s->special_fully_nested_mode =3D 0; - s->init4 =3D 0; - s->single_mode =3D 0; + cs->last_irr =3D 0; + cs->irr &=3D cs->elcr; + cs->imr =3D 0; + cs->isr =3D 0; + cs->priority_add =3D 0; + cs->irq_base =3D 0; + cs->read_reg_select =3D 0; + cs->poll =3D 0; + cs->special_mask =3D 0; + cs->init_state =3D 0; + cs->auto_eoi =3D 0; + cs->rotate_on_auto_eoi =3D 0; + cs->special_fully_nested_mode =3D 0; + cs->init4 =3D 0; + cs->single_mode =3D 0; /* Note: ELCR and LTIM are not reset */ } =20 static int pic_dispatch_pre_save(void *opaque) { - I8259CommonState *s =3D opaque; - I8259CommonClass *info =3D I8259_COMMON_GET_CLASS(s); + I8259CommonState *cs =3D opaque; + I8259CommonClass *info =3D I8259_COMMON_GET_CLASS(cs); =20 if (info->pre_save) { - info->pre_save(s); + info->pre_save(cs); } =20 return 0; @@ -67,26 +67,26 @@ static int pic_dispatch_pre_save(void *opaque) =20 static int pic_dispatch_post_load(void *opaque, int version_id) { - I8259CommonState *s =3D opaque; - I8259CommonClass *info =3D I8259_COMMON_GET_CLASS(s); + I8259CommonState *cs =3D opaque; + I8259CommonClass *info =3D I8259_COMMON_GET_CLASS(cs); =20 if (info->post_load) { - info->post_load(s); + info->post_load(cs); } return 0; } =20 static void pic_common_realize(DeviceState *dev, Error **errp) { - I8259CommonState *s =3D I8259_COMMON(dev); + I8259CommonState *cs =3D I8259_COMMON(dev); ISADevice *isa =3D ISA_DEVICE(dev); =20 - isa_register_ioport(isa, &s->base_io, s->iobase); - if (s->elcr_addr !=3D -1) { - isa_register_ioport(isa, &s->elcr_io, s->elcr_addr); + isa_register_ioport(isa, &cs->base_io, cs->iobase); + if (cs->elcr_addr !=3D -1) { + isa_register_ioport(isa, &cs->elcr_io, cs->elcr_addr); } =20 - qdev_set_legacy_instance_id(dev, s->iobase, 1); + qdev_set_legacy_instance_id(dev, cs->iobase, 1); } =20 ISADevice *i8259_init_chip(const char *name, ISABus *bus, bool master) @@ -118,9 +118,9 @@ void pic_stat_update_irq(int irq, int level) static bool pic_get_statistics(InterruptStatsProvider *obj, uint64_t **irq_counts, unsigned int *nb_irq= s) { - I8259CommonState *s =3D I8259_COMMON(obj); + I8259CommonState *cs =3D I8259_COMMON(obj); =20 - if (s->master) { + if (cs->master) { *irq_counts =3D irq_count; *nb_irqs =3D ARRAY_SIZE(irq_count); } else { @@ -133,22 +133,22 @@ static bool pic_get_statistics(InterruptStatsProvider= *obj, =20 static void pic_print_info(InterruptStatsProvider *obj, GString *buf) { - I8259CommonState *s =3D I8259_COMMON(obj); + I8259CommonState *cs =3D I8259_COMMON(obj); =20 - pic_dispatch_pre_save(s); + pic_dispatch_pre_save(cs); g_string_append_printf(buf, "pic%d: irr=3D%02x imr=3D%02x isr=3D%02x h= prio=3D%d " "irq_base=3D%02x rr_sel=3D%d elcr=3D%02x fnm=3D= %d\n", - s->master ? 0 : 1, s->irr, s->imr, s->isr, - s->priority_add, - s->irq_base, s->read_reg_select, s->elcr, - s->special_fully_nested_mode); + cs->master ? 0 : 1, cs->irr, cs->imr, cs->isr, + cs->priority_add, + cs->irq_base, cs->read_reg_select, cs->elcr, + cs->special_fully_nested_mode); } =20 static bool ltim_state_needed(void *opaque) { - I8259CommonState *s =3D I8259_COMMON(opaque); + I8259CommonState *cs =3D I8259_COMMON(opaque); =20 - return !!s->ltim; + return !!cs->ltim; } =20 static const VMStateDescription vmstate_pic_ltim =3D { --=20 2.43.0 From nobody Fri Oct 23 14:31:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1792160572; cv=pass; d=zohomail.com; s=zohoarc; b=QyupRMVePGB+E0Kn3gQF5wMS+Y0nmw1+g4+dN2osP0Vpfct9mO85sSXawuf69S54TFXZ5TNQat2J4D6BR8TM4XZf9Xmbh2K+n0oYn7Snn5L1lChrCjiQLsJwavaus+6rYdQzLNbTSVDCwZ0zWwoXh9EYqUNnWBl029y8w3G2bhg= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792160572; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=7wm8uo+H49sktKaMqKuuL2u6+/dMUEYN+P4+MkpQfKk=; b=LEwRobjK2RsmBHDqZODHxjmCULVTteDI59RPL89gozcb/k5IocPqGL7DEB5fzegIycN1w06SmeeaX878jRHa7JDY7FsljTZGhR3lKunTQlTSQfv+FaCTSMw+5QFsqRXqwk0o6GGt1YIFQQ4Dusdln1R5s18qxkSp9V+momQjnfE= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1792160572144147.92153481721073; Fri, 16 Oct 2026 07:22:52 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1452002.1666902 (Exim 4.92) (envelope-from ) id 1xHioj-00044Q-HN; Fri, 16 Oct 2026 14:21:53 +0000 Received: by outflank-mailman (output) from mailman id 1452002.1666902; Fri, 16 Oct 2026 14:21:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHioj-00043l-9y; Fri, 16 Oct 2026 14:21:53 +0000 Received: by outflank-mailman (input) for mailman id 1452002; Fri, 16 Oct 2026 14:21:51 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHioh-0003Xl-CP for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 14:21:51 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1xHiog-00BWwx-PE for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 16:21:50 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6ad232fb-e002-0a2a0a5209dd-0a2a45039348-8 for ; Fri, 16 Oct 2026 16:21:50 +0200 Received: from [148.163.151.68] (helo=mx0a-002c1b01.pphosted.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6ad232fd-fae8-0a2a45030019-94a397449984-3 for ; Fri, 16 Oct 2026 16:21:50 +0200 Received: from pps.filterd (m0127837.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69GE58qj3551722; Fri, 16 Oct 2026 07:21:28 -0700 Received: from bl2pr02cu003.outbound.protection.outlook.com (mail-eastusazon11021136.outbound.protection.outlook.com [52.101.52.136]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4hbmjc04x2-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 16 Oct 2026 07:21:28 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by DSVPR02MB11424.namprd02.prod.outlook.com (2603:10b6:8:352::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.23; Fri, 16 Oct 2026 14:21:26 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%4]) with mapi id 15.21.0522.016; Fri, 16 Oct 2026 14:21:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=7wm8uo+H49sktKaMqKuuL2u6+/dMUEYN+P4+MkpQf Kk=; b=J/ogjivdRZTBu4UWvb36VWwVIB4+Nb2Ybv5zPPmBlyolsmywEGDcFCfLq HbvsfBRFNVUrg6sxCvLVaRaURwFJlOj5V1mGIcfKB/ZELThlcGO+r1A96utJwhDS MZELg0v5MDbCWftRb118zf+gtJjUseYk65V6u8WQYwauhvIGfWzRnaKhTf8JsBDa AIu/cJwtPvtYhfzFZaY3wsFYHuwj+4qWNWQKVtM1byPU9jJCshUJlCfCS6UaMKfg uIUHWld/o862ZhdOQgFwrIHqYfCZN7KOR/U84mJbJPAxTQ/A6X6VGNvMLNgjdl8s YQQDskGVxQAV4bCwqq5Zk0cNzdbvA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=j5TgSb3bAmf8XW9YFkdXfORzdgb63mnvN5wHtPw1jAwvmVpKcNqZw86oHvbLNh4eqLTvd/YTJyLNV5Fyk2Zxty++YW/spW+gRxBWwZ6WB4tx76/fvLb1mnYkapNVWfgEvX/nd2UG/ZbcCI7M1sTmOKY3txE7pEDbeanRvN4l+PHmsBPcDQclV80+xoB9RMO6DrV+Dcf5tZlpSM2hMnXduwZvQhf5TYxMYdBmTyiu54mdtpJw4EN7BkVzVFe4b63zBpHaRkP/jLS0ofkBnrXkMemfthSZx0AoyT1jUkWbXZ9jW9tQZwwBrSp6/H/fqtt62y2oixvpXGvhdQe9Y0XRdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7wm8uo+H49sktKaMqKuuL2u6+/dMUEYN+P4+MkpQfKk=; b=h/IzCudwVqVesqmTmBDFuuVzplccrTV88pIKeWWSaVY14zuMRuurwVfiNdn4bRUFz0dRJfKw04p0QGZkEa27fxSl3Wa7MUYe9edDkrsUOOBbucIkYZJWoN+t+oCnjmFKYd76Qh4u09WXHqtuWRn8IsRIcKkMY2MWiE3T8VzkB8xpCuY11qrE982cCXp+zmwU6FvIoCI7uIx3VaM49seRp04aUW7+IRRlAhLc+7QhlaU2XRtI/vW//wsIymMFTZ3asoT82b+04xesXQnGGwkcnJKGrMX+dbagKUMGWMYtKyHEU+iJHbDsrOqk+SRtyvTCXIICz1Wc+QlYY54QTy8OiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7wm8uo+H49sktKaMqKuuL2u6+/dMUEYN+P4+MkpQfKk=; b=UE8se7vzaoge487CALbsKNnVea6zMYuJhom1LIrPDE5SZ2tvMWlMlR6uycnQLOpocyYe7PVdNKyhY+9EviO9FsCwijKWmsTNuLyVwUxKkDXLw8fGc++tvzS/ekadRWb6ijQxsWbKIkgr0pCOfHANXiJz+4CSg30C0tqeGfKW+Mxf364jQkjyIqkicn61WVZutrjz96z9Lq5qFm1/gCOps8oTQoN9MVhRIYIvM0O/9maNJ3GDjyT9OlnzJFwVusxtmsWB7XMivICQxo9ls7jS+kp0JlHOdHqjgKCMGQtC2F04jwmlnuFHsXM7kmsdMqb3+OFvN6j8yDT9h1L07PO7dg== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nutanix.com; From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH v2 12/27] i8259_common.c: use i8259/i8259_common prefix for functions Date: Fri, 16 Oct 2026 15:19:18 +0100 Message-ID: <20261016142031.1204281-13-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016142031.1204281-1-mark.caveayland@nutanix.com> References: <20261016142031.1204281-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR03CA0132.namprd03.prod.outlook.com (2603:10b6:a03:33c::17) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|DSVPR02MB11424:EE_ X-MS-Office365-Filtering-Correlation-Id: b081d4af-9d6b-46b5-1cd5-08df2b90c34f x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|366016|376014|22082099003|10067099003|18002099003|261009223027099003|56012099006; X-Microsoft-Antispam-Message-Info: 6J/TG061G/2Og8vvbzOPvbLMYwhw57cMd3mio4M+z9DHkpblpVyTGpKOaaAaJeJA1gFUOPxrMCMHPH8Ee+fCN5Fj6YUX7REqAqZ/F7nxOPv/nQsRSEGK4L2fTFSNutlRncdP1ewnf7iJ0wnkxbzZZT3qsIWnjdJmOwYpcQTZB4hQrJFJzNBSk8zr776iHGM4aID+O0kt6k4Cf34xoQo+hA53KXFFBZbdCR481HK8EiB8t/lQ0UD6q1fwNmx3hkNDcdLpED2stjfV+aDa4FgxRbAWXX1XmT7GNZpUY54+ZRDay5wHvUee953laCmyOF1I5tgNmrsM3XxYSlRA5zJDszzu0wGhPeVr1oS3qU1P7hiy1opHMZjPsGJZ8p6X/JfowOCDtpvGxx+W0Fq7VKX0RWQr8/6guZRN48Y7Wn9ZpBADIKhOcOhREJY3p/83w/mFq4uDKUFjSfdwBGZ2kxs00L4jIOn3daoFct0fZnhIBLjWAyh59tHSaTa7qtYg7+rzKNQ+x+EUndLAxF1SZeDw3wTG4mLA/4dPIYqfRyFZr3pigb3ZqSPz7+mZNQ2C9fHYEEXDK6xo8J+25HdDGdteSoaUacEKx+LVylUaaoxQNwn3R4+9+8zqn5m+0MSJk/RBypCkzngA2VpGIvPX0pVuKYSkyqk2O8kCZz4IUmwSrzw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(366016)(376014)(22082099003)(10067099003)(18002099003)(261009223027099003)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?whHHokDE7/7DBpY3oMtS4z9QBZf+XiU8oZShBVguabV7B5fG417/KKStXQ6M?= =?us-ascii?Q?6QjKyPI4xfHsLZh2IUSAQG5253x287XNcscJvrhlaALA/eaeBlR+cBc84XNB?= =?us-ascii?Q?VDfP5YqbawsuJUwo9niDToLB63OgOc4O7kNXZ80ysDM7aA0DBGZzMzoNzBYJ?= =?us-ascii?Q?piHDlT34KJ96wkonNp3mH375j07Rpiv+obwKmjvsv1FoCZMShtWvlg/ckm8s?= =?us-ascii?Q?Ple/RQUXAJb83TXGSFo9laLozZG4nIVtvR30rehvirco2hbMUU3TeFWAbYgH?= =?us-ascii?Q?mWbRw+0VXcIusPBWOdeFMUvmmn7RpN728+du9C5z1eHZl9U/MaJ6iTDsyrlF?= =?us-ascii?Q?mVL04r99jbU5QjPAOQ31BPHKJj16285Xt2l8uxvBYZ/aQ/I+0jXnWmu+6hWY?= =?us-ascii?Q?iM6UZrZLrr+muTFwK52r0EHxMF3xCaDbCcxWmAadjbAi/6ysABckfMsdIJEJ?= =?us-ascii?Q?82/iCvI71z+GAk/7ozLgIEI1spon/H6jJS+jZuUy9XqKL4eKf/NDrqNAiAkS?= =?us-ascii?Q?1UgF/a0NXUxx4FMOyDF3D6wmEUMWwKmooSY4mEup2rHYIFTbD0FuBWr4XKNB?= =?us-ascii?Q?tcqeHFufsRe5wsHwYtYZdMVP/KpeNNvYdwUBjoU36IjClc6yu14gCubJEYYc?= =?us-ascii?Q?KjCUtTVkc/JLQM/9QDxJu/994NhD4mBM7B+3X89KwkrrgaaMfkI4P3TbyyeU?= =?us-ascii?Q?LPGg+48eY24du3eXQYcKB/LjC8DcsSmZUQrt5MB2ojTytbtH8XdVnybkfWZU?= =?us-ascii?Q?5eccLw4bu1K7uwKy/Eoo2sL/5FuTGSaixt1dJZBptmEmEcKTEF9+AMBqyJOn?= =?us-ascii?Q?xJiL7ASt/awrqYqdH1Ck5uRbIQur+HG5XpEeKGSMmJaWLZQ69rEOIolFQgij?= =?us-ascii?Q?Hfb4hZGVh/Lk4J3ANK8dRMXReLwtWTEI4PKKqDoxURfXJmeHWdCqlmvlJbYn?= =?us-ascii?Q?1u3VNiOZTZBlr4nxC1vbe/mSnztEnCrrE3cwQUIdrfc4qCJCOKPBsqZcmF06?= =?us-ascii?Q?MDEvD1k8nMf244z0CI2fwKlRjfY/MLK8lOSOENEil7nhTygWCEi093NMhl9o?= =?us-ascii?Q?wqYCqTB7YngAhDIPmxxUS8dygbh8F/ldaez6mFs11EXWHNHygUmQ14MR9f+p?= =?us-ascii?Q?Ja8cIv+OUlXhvZXHjM38mREnrW+wHNQiinklHWpad3jmB0Yr4teZ+egKnd5Y?= =?us-ascii?Q?vcZe5cot4P7Yf23H5tkF7tqjNSlUh4RRHe3ejO1kY4St7Kpi4SmRliSPn82T?= =?us-ascii?Q?xMLtx9+ss22fkG4n8S91Lsnoojal5ii06hVnlgITwo4tBczDX/CY26Y3YxXN?= =?us-ascii?Q?GD+9HHfwfaZCshy6nXWzMBALK9NS4w1Q7re/8w9pjkYVM7q4yDLjnmWhkrcI?= =?us-ascii?Q?KdVNwBcOCNGt/tjSkgaghFI133Sg63B3gdY2jcl+sWdgKnYVshaThRZSvicQ?= =?us-ascii?Q?UualU/lCavbjMxRGGknHNcFyQqktcYJcxbu+GIzbKsoJMVUz0jDMdnKfVGTF?= =?us-ascii?Q?0JzUUncvfs9ldyqwJHfyr1exl3UQwy6QzOFTP06Vkn6/h0l1HyS330jEImxX?= =?us-ascii?Q?sSxRx/LWl8yYwumECS1U9LOl1ZVLULOtArgMAJijI/gRkTl25vrF34VFISjU?= =?us-ascii?Q?f8eqG3+wyklEiF/Mt9H3Oz3Gbjhg2qHL6oUqH1EvL11uqrm0fjxFnUSsosp/?= =?us-ascii?Q?V8vLiqYJGx911mPQ/0JXdAp4ONWA6nYH23ezshlTK3SIRZrAHITe54wcDjDJ?= =?us-ascii?Q?DlLJZMH60LrEAJrZOR1Q10uXTIm+/tI=3D?= X-Exchange-RoutingPolicyChecked: Q5mzRflAAdInlAeN/LzOtTWFtCgHz8OixnxKvVtQNDdzZH82R81JabFOwK0r6RL5xkGa20XJV3VpCx8DZ0YjJNu9aHuCCJrfrXB/wTVr5lduJYcfT46M37FZ/pZBQHxJWF11h3oYiSm7sAu1iAVe7GKs0x8TU/8B9/xN8XsSgZWe1+gTOQKDzw26NzOZ4YdiEUeSeLem/wqj8vsZoJPJddhf2TZeLozgktEPh/UUbVpzq4+zf1mkib1/2YXvAjLp0DzQ/2KFdj6MBlftv2Q4jBf5gbnZb6W/ZivDwT1u2PJ+hUMmpdt0LVpqEJcgHu0G5xArT803w9/Qk9IBiJaa5w== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b081d4af-9d6b-46b5-1cd5-08df2b90c34f X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 14:21:26.6435 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 52OWT8buigIxgYyDFQMwPj8EyFrppwTj4ARP8tWVxjoEWQsl1ScvYqWhcx3TVn2B+w8e8WXBqR1oGK7wmNwnWhQoFR4ihAQdvR/RBNQQ3Q4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DSVPR02MB11424 X-Authority-Analysis: v=2.4 cv=dasVTnXe c=1 sm=1 tr=0 ts=6ad232e8 cx=c_pps a=IN/ktsHfyviFoRwGlsjPrQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=660iZSQnnn4A:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=Ap8k9tRZuQ82DLYWQqG7:22 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=ox8dIxdxdu1w5TD4ToMA:9 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX51btV2DwH9hY M8zynJTNZG+RS0mBufpa0W+3R5crP3waGo/vLGsZD43SMUN1Rd8KPO2UqaNxOq7MYFF2f7k2wIr 7h1cea1cDtg179AmWM4PV2585UM+z2BWxt3iPEhuvUnbcjQz0iiwfYAVirSmvqcPIrleN/9aE1P L/sifSMTBqr4W/QhuNpf/eP1ACGo9CnI51CRmXReVltHL4Cd7uHDyqG5xU0xJAXFs83XFgG4RFK lG8PIELYqTNoLdj1z0w1TtTwQqvv2LH3E9v97RlFFqJ8yuD+ZM1Px+VWdvTE4fNehqXKHmUw5ih uMNvfrYT9t1Qw/faWnGoKfwY+Ygzpfwu7ts304em7u9E7thzCa0NclAOMillyK7x8H/45s8VOIK uEdBl1kLZOqDqGweQAlhILGAJDTNK8UgICegf4/SOrt3n+L4Sqa+8jJGezSg2E+fG8+qfJXjBLy FG3fwHP+n0vvaAtbaoA== X-Proofpoint-GUID: 0u_bCT4tLOdJGIP2w5C4kBHRxEuLytxp X-Proofpoint-ORIG-GUID: 0u_bCT4tLOdJGIP2w5C4kBHRxEuLytxp X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX064D9u/KYzOU +Ft0DmQL30uStHFS4B6VDS07oqAgwXMHH6RFk5xKWJ+I6/s266Zwcl/uZ6v9b+SrdeO5PlK8Twe QiJ0W3GyNMV8aLo0TP8ap2WLIPojRks= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-16_02,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-33051d/1792160510-6F2C84E9-72A6E749/0/0 X-purgate-type: clean X-purgate-size: 8111 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1792160573072158500 Content-Type: text/plain; charset="utf-8" This ensures consistency with our normal QOM-based naming convention. Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell --- include/hw/isa/i8259_internal.h | 4 +-- hw/i386/kvm/i8259.c | 4 +-- hw/intc/i8259.c | 4 +-- hw/intc/i8259_common.c | 49 +++++++++++++++++---------------- 4 files changed, 31 insertions(+), 30 deletions(-) diff --git a/include/hw/isa/i8259_internal.h b/include/hw/isa/i8259_interna= l.h index 71fdd74266..644508a44e 100644 --- a/include/hw/isa/i8259_internal.h +++ b/include/hw/isa/i8259_internal.h @@ -70,8 +70,8 @@ struct I8259CommonState { MemoryRegion elcr_io; }; =20 -void pic_reset_common(I8259CommonState *cs); +void i8259_common_reset(I8259CommonState *cs); ISADevice *i8259_init_chip(const char *name, ISABus *bus, bool master); -void pic_stat_update_irq(int irq, int level); +void i8259_stat_update_irq(int irq, int level); =20 #endif /* QEMU_I8259_INTERNAL_H */ diff --git a/hw/i386/kvm/i8259.c b/hw/i386/kvm/i8259.c index 86b1ffea4e..3a960e48e6 100644 --- a/hw/i386/kvm/i8259.c +++ b/hw/i386/kvm/i8259.c @@ -108,7 +108,7 @@ static void kvm_pic_reset(DeviceState *dev) I8259CommonState *cs =3D I8259_COMMON(dev); =20 cs->elcr =3D 0; - pic_reset_common(cs); + i8259_common_reset(cs); =20 kvm_pic_put(cs); } @@ -117,7 +117,7 @@ static void kvm_pic_set_irq(void *opaque, int irq, int = level) { int delivered; =20 - pic_stat_update_irq(irq, level); + i8259_stat_update_irq(irq, level); delivered =3D kvm_set_irq(kvm_state, irq, level); kvm_report_irq_delivered(delivered); } diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index 700412df74..97ecb77407 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -124,7 +124,7 @@ static void pic_set_irq(void *opaque, int irq, int leve= l) int irq_index =3D cs->master ? irq : irq + 8; =20 trace_pic_set_irq(cs->master, irq, level); - pic_stat_update_irq(irq_index, level); + i8259_stat_update_irq(irq_index, level); =20 #ifdef DEBUG_IRQ_LATENCY if (level) { @@ -215,7 +215,7 @@ int pic_read_irq(I8259State *s) =20 static void pic_init_reset(I8259CommonState *cs) { - pic_reset_common(cs); + i8259_common_reset(cs); pic_update_irq(cs); } =20 diff --git a/hw/intc/i8259_common.c b/hw/intc/i8259_common.c index 705a28ecbf..31bd663439 100644 --- a/hw/intc/i8259_common.c +++ b/hw/intc/i8259_common.c @@ -33,7 +33,7 @@ static int irq_level[16]; static uint64_t irq_count[16]; =20 -void pic_reset_common(I8259CommonState *cs) +void i8259_common_reset(I8259CommonState *cs) { cs->last_irr =3D 0; cs->irr &=3D cs->elcr; @@ -53,7 +53,7 @@ void pic_reset_common(I8259CommonState *cs) /* Note: ELCR and LTIM are not reset */ } =20 -static int pic_dispatch_pre_save(void *opaque) +static int i8259_common_dispatch_pre_save(void *opaque) { I8259CommonState *cs =3D opaque; I8259CommonClass *info =3D I8259_COMMON_GET_CLASS(cs); @@ -65,7 +65,7 @@ static int pic_dispatch_pre_save(void *opaque) return 0; } =20 -static int pic_dispatch_post_load(void *opaque, int version_id) +static int i8259_common_dispatch_post_load(void *opaque, int version_id) { I8259CommonState *cs =3D opaque; I8259CommonClass *info =3D I8259_COMMON_GET_CLASS(cs); @@ -76,7 +76,7 @@ static int pic_dispatch_post_load(void *opaque, int versi= on_id) return 0; } =20 -static void pic_common_realize(DeviceState *dev, Error **errp) +static void i8259_common_realize(DeviceState *dev, Error **errp) { I8259CommonState *cs =3D I8259_COMMON(dev); ISADevice *isa =3D ISA_DEVICE(dev); @@ -105,7 +105,7 @@ ISADevice *i8259_init_chip(const char *name, ISABus *bu= s, bool master) return isadev; } =20 -void pic_stat_update_irq(int irq, int level) +void i8259_stat_update_irq(int irq, int level) { if (level !=3D irq_level[irq]) { irq_level[irq] =3D level; @@ -115,8 +115,9 @@ void pic_stat_update_irq(int irq, int level) } } =20 -static bool pic_get_statistics(InterruptStatsProvider *obj, - uint64_t **irq_counts, unsigned int *nb_irq= s) +static bool i8259_common_get_statistics(InterruptStatsProvider *obj, + uint64_t **irq_counts, + unsigned int *nb_irqs) { I8259CommonState *cs =3D I8259_COMMON(obj); =20 @@ -131,11 +132,11 @@ static bool pic_get_statistics(InterruptStatsProvider= *obj, return true; } =20 -static void pic_print_info(InterruptStatsProvider *obj, GString *buf) +static void i8259_common_print_info(InterruptStatsProvider *obj, GString *= buf) { I8259CommonState *cs =3D I8259_COMMON(obj); =20 - pic_dispatch_pre_save(cs); + i8259_common_dispatch_pre_save(cs); g_string_append_printf(buf, "pic%d: irr=3D%02x imr=3D%02x isr=3D%02x h= prio=3D%d " "irq_base=3D%02x rr_sel=3D%d elcr=3D%02x fnm=3D= %d\n", cs->master ? 0 : 1, cs->irr, cs->imr, cs->isr, @@ -162,12 +163,12 @@ static const VMStateDescription vmstate_pic_ltim =3D { } }; =20 -static const VMStateDescription vmstate_pic_common =3D { +static const VMStateDescription vmstate_i8259_common =3D { .name =3D "i8259", .version_id =3D 1, .minimum_version_id =3D 1, - .pre_save =3D pic_dispatch_pre_save, - .post_load =3D pic_dispatch_post_load, + .pre_save =3D i8259_common_dispatch_pre_save, + .post_load =3D i8259_common_dispatch_post_load, .fields =3D (const VMStateField[]) { VMSTATE_UINT8(last_irr, I8259CommonState), VMSTATE_UINT8(irr, I8259CommonState), @@ -193,21 +194,21 @@ static const VMStateDescription vmstate_pic_common = =3D { } }; =20 -static const Property pic_properties_common[] =3D { +static const Property i8259_common_properties[] =3D { DEFINE_PROP_UINT32("iobase", I8259CommonState, iobase, -1), DEFINE_PROP_UINT32("elcr_addr", I8259CommonState, elcr_addr, -1), DEFINE_PROP_UINT8("elcr_mask", I8259CommonState, elcr_mask, -1), DEFINE_PROP_BIT("master", I8259CommonState, master, 0, false), }; =20 -static void pic_common_class_init(ObjectClass *klass, const void *data) +static void i8259_common_class_init(ObjectClass *klass, const void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); InterruptStatsProviderClass *ic =3D INTERRUPT_STATS_PROVIDER_CLASS(kla= ss); =20 - dc->vmsd =3D &vmstate_pic_common; - device_class_set_props(dc, pic_properties_common); - dc->realize =3D pic_common_realize; + dc->vmsd =3D &vmstate_i8259_common; + device_class_set_props(dc, i8259_common_properties); + dc->realize =3D i8259_common_realize; /* * Reason: unlike ordinary ISA devices, the PICs need additional * wiring: its IRQ input lines are set up by board code, and the @@ -215,16 +216,16 @@ static void pic_common_class_init(ObjectClass *klass,= const void *data) * code. */ dc->user_creatable =3D false; - ic->get_statistics =3D pic_get_statistics; - ic->print_info =3D pic_print_info; + ic->get_statistics =3D i8259_common_get_statistics; + ic->print_info =3D i8259_common_print_info; } =20 -static const TypeInfo pic_common_type =3D { +static const TypeInfo i8259_common_type =3D { .name =3D TYPE_I8259_COMMON, .parent =3D TYPE_ISA_DEVICE, .instance_size =3D sizeof(I8259CommonState), .class_size =3D sizeof(I8259CommonClass), - .class_init =3D pic_common_class_init, + .class_init =3D i8259_common_class_init, .abstract =3D true, .interfaces =3D (const InterfaceInfo[]) { { TYPE_INTERRUPT_STATS_PROVIDER }, @@ -232,9 +233,9 @@ static const TypeInfo pic_common_type =3D { }, }; =20 -static void pic_common_register_types(void) +static void i8259_common_register_types(void) { - type_register_static(&pic_common_type); + type_register_static(&i8259_common_type); } =20 -type_init(pic_common_register_types) +type_init(i8259_common_register_types) --=20 2.43.0 From nobody Fri Oct 23 14:31:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1792160516; cv=pass; d=zohomail.com; s=zohoarc; b=BEWywOThLSJo7/cs3UvpjjT6oYEcgrQ8z61lUGd5Fg1m+GVaJdOawMfRZHHu0EiLx80wn1/Gq3vIoOWWweNOrh9Aor0cqIt2xf+8t6WUyVzDkiIe7npWcgvI7rXy5tB7esFc2wOb4k1bKAjhc17q6HcVDLFvdDcSi7XKkhIg01Q= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792160516; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=+oPkk2OhFpF/vtiHULlP+3P3BHO9YE69TRweo9UeO9w=; b=NbexMMzjSYorq3yEWJoXryu9ya2Hzr9HV4p54e0P/bxlb4KV0r0JLVc0zhZggQ74h7A+7mUz/E78AnAH6XBnwrYKv4dT+gXZSemv3bM5plFc/1fvf558GKPF+Wifi53c+J3IGVZNYwIC6DLZxaEL9G0WNdQlkDehpOtLrqxNLXE= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1792160516055973.723911292915; Fri, 16 Oct 2026 07:21:56 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1451990.1666847 (Exim 4.92) (envelope-from ) id 1xHioX-0002RD-Ew; Fri, 16 Oct 2026 14:21:41 +0000 Received: by outflank-mailman (output) from mailman id 1451990.1666847; Fri, 16 Oct 2026 14:21:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHioX-0002R6-BV; Fri, 16 Oct 2026 14:21:41 +0000 Received: by outflank-mailman (input) for mailman id 1451990; Fri, 16 Oct 2026 14:21:40 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHioV-0002Or-O4 for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 14:21:39 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1xHioV-008oFu-4I for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 16:21:39 +0200 Received: from [10.42.69.3] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6ad232df-e002-0a2a0a5209dd-0a2a4503ea06-32 for ; Fri, 16 Oct 2026 16:21:39 +0200 Received: from [148.163.151.68] (helo=mx0a-002c1b01.pphosted.com) by tlsNG-33051d.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6ad232f1-fae8-0a2a45030019-94a39744955a-3 for ; Fri, 16 Oct 2026 16:21:38 +0200 Received: from pps.filterd (m0127840.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69GE5SsA3051509; Fri, 16 Oct 2026 07:21:32 -0700 Received: from bl2pr02cu003.outbound.protection.outlook.com (mail-eastusazon11021106.outbound.protection.outlook.com [52.101.52.106]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4hb7t19qru-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 16 Oct 2026 07:21:32 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by DSVPR02MB11424.namprd02.prod.outlook.com (2603:10b6:8:352::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.23; Fri, 16 Oct 2026 14:21:30 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%4]) with mapi id 15.21.0522.016; Fri, 16 Oct 2026 14:21:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=+oPkk2OhFpF/vtiHULlP+3P3BHO9YE69TRweo9UeO 9w=; b=nVHU/uZ/k6wzYeUzzKAhspVyR3gH4w8BxIgzOKadhg8ChwS5mHSCnAl79 MBQzKRDJMljEaBRYQ5gnUuwAHrLMbFzbPrFkefN0cg3NjdB+/9SfECp0cOpUNOM6 1OYt1UQZsFIQTvIpIrwdDTW9V7ASUY3BrhRxyzrQUP6WSqN4V+JaQs/ve3cIrhxD WnbNFhvQfNZXwzlppbczZVjU0vNTHhjPGggTVOxVklk/PKDSsnfu11R/CxrY72K+ wApPIZP6G8xJVkR3se+w5mD/i5cURAlLCoC/tDDm3dt923cLlhr7PlPeBgQvrbx3 qx40B8eOR2RCL2Aq7oVv5FolMjEDg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iHL4fRp+/OINWHJ2XUxKvMwx6O9MESv/01/vEyRCysHa6edqzgkZelYbuTiJKTDbcq7y6na8dJawDuTqNlnIvhizOn8ZhQ8KgmIuE3o2hEJ5c/T3mmG/WjaAqtijhxVvMEDg8yZ+JPfd83rOo441X8WTZs5feZUnF1eDTt60yAFxjf2BX/vTKzyEXF+y2+mqGnFEwZT80opa0nH3/GDpzwOt/P+dDm64Uwgw/0WUiJYrzQerHxM0GPSuUfIESGVbuW8Rn0OZjaTrxS8hpCyWG6E2AzQXj9JX+wihpUi88L8emHa/RxICguGoDlHj/bO7TzbNfwSY4wfdWkn0EEy23w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+oPkk2OhFpF/vtiHULlP+3P3BHO9YE69TRweo9UeO9w=; b=PWdKimvN5PReHp3RmfsZO9ZnFESQ2+HZWUcE9afABrRMAMx8PNmlBCIAtipgCPWylJa62CEUw3o1QHFRP0AhBK8ru4IotgjfLwe3+/lpnxvRPWfgNi5JGYUFnJM7Gxs1zKSrFdXMFM8enxgkyxDV3lQ/lUo8aSmw0D9O2/QXd39r8p0OlaFvJf/Am0C2UHkO3k8/c0Sm4LYwT0mWRFKoWYxptiU03aIBb2lClDvvHmTqSelEwzqa2inaQevlvyZGZxuegAb3T2QrO70bIlGoVuuIDBNznQTMHzfpM9fcBMLI/1Nv7vBG9t6M6Ww+rFI4LbWj9QUcEG2xP+RI3ziQTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+oPkk2OhFpF/vtiHULlP+3P3BHO9YE69TRweo9UeO9w=; b=UrmfkAlSEZ/mQMaGnQOXNlXd5Q1zXQszRTwXpaBZxn0IHHIrxmUsJA1vtAr46dolDVRYkpRXwzAx6H5x9VhqSbmQqdV5OzsRfYGhT4/Y4LFS+uuH8qSnO7IIu/9Y8obkTNSZHgW6RAw8OrfX6ekKii1delPjgMq5UsXAHQxziCPSxyIVjRW2HBsyPhiSFeGzEEQMMJoH/1/bLrvUJworA0q4RogLGzTTlr5Q17LOGbHi0mV9s10FLyqvIbq9VJDI7eqKMyBQTqcq5rFIdC9ccJ6jClCUDmfESY9tQ1yKR2NCCaxKNio1HA4ICFIHPLZkgASf+kmrONj1INSdNImuAA== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nutanix.com; From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH v2 13/27] i8259.c: use i8259 prefix for functions Date: Fri, 16 Oct 2026 15:19:19 +0100 Message-ID: <20261016142031.1204281-14-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016142031.1204281-1-mark.caveayland@nutanix.com> References: <20261016142031.1204281-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BY5PR03CA0028.namprd03.prod.outlook.com (2603:10b6:a03:1e0::38) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|DSVPR02MB11424:EE_ X-MS-Office365-Filtering-Correlation-Id: 424be368-939f-48db-7e1d-08df2b90c5ab x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|366016|376014|22082099003|10067099003|18002099003|3023799007|261009223027099003|56012099006; X-Microsoft-Antispam-Message-Info: j1Ex5O91InqcCLfAOdfnZU4BEzrn2pOGdARiJ7M/g0s8Ag6xhSp8ogu2HXCjkL0GuqRjCdMBghPmxhuqS3ARIyaa6+5zKKOCIrJ1lROev3QSovGlC+pxUx/STVyFHWUuFJUvpT1OsZfbm0qCtJGDqN5jxzQ4q4L9WYhXexUB6tKeY5cnh2KUjhVWI3hrASwqpgYe78LDDNddcWLK0n6YLWUGBW8kBq+zKgcCOSFrp2KwtZXw8lfrckVuLFurIlirkXiyqb+cISeqbLsuU4vgivmYm/xxO0W+67HUMHc513dMpvY5MDOcZ/kHbTKPRKs4bFFGIMsR5KVJj6jg5vEsz/KgOyiYFZcd5WRTtJME8iLQMbQfEaTlQYf8vIg3pgucBVxKQD4SVhtfm7i0sPe6LHYx8VI/DU3ri8HQv1jy88ol+a2Q86MyCwRQ6XKT4SFdG4rBwEK/oY6Udfo5wVYVDBBcJrpDuSaxj9u0uNCR4k+STINK/u8TTFLo4rbxl/BhZBIO5zM2uT4UsbQyJTnH1SR2UOeFiXv+kHZDX/Xqcs2y/5e/89+XB+sGGuTg/FuFelE3y5xeKdaV0spvwb5JmqH1uuW1k57CN/qZ+oG9PRbjbqzStCPxF3q2+lG9eOdw2XNrI+qu6lvMRyunp74yIGDGESEB6BQZjua0TPzw9l4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(366016)(376014)(22082099003)(10067099003)(18002099003)(3023799007)(261009223027099003)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bzOPBLTtIwyiMcfg77Cm9s85fmfW2S13q5SsJSA7HOm7GSNb1RNj0dUY2NXI?= =?us-ascii?Q?S7kmVZioK/SHqgzLwHNhsATFVaM5Nd2D5zdqBhTBr00YxPjtudShvMew0Nup?= =?us-ascii?Q?bypuwLBdRmtvjUpkuzf/5P9heVaqVnlEo5ykDFpviTXvmeHsdQrdlg14c8OF?= =?us-ascii?Q?1AG+QGczhLWDD/4ecf2oW4k7hND/t0KDVdy7E6cP6VUyFDqOkjE2Jp648wbk?= =?us-ascii?Q?5PgUSqlWMadv/KVm7rqcbPiq0v3eptQW3srlxx4jeYJE2qq//R4KifQiRph3?= =?us-ascii?Q?oHSo45xOJTEATVQu/ClASG8cKTObpVWGL/ixuYww8b65ji0eTcw2THzv/nDl?= =?us-ascii?Q?+o64H+cwfvt4hO22QNc5DlXQDzdo7eNs2BPpoSzDDXRdCJpDaAB/wT6lz0AC?= =?us-ascii?Q?ODC3spfxwQItFkduPl2e7CwW5q1PojKQNOSIjGJ5BqmDMsdZ2mEd/EUXX+b3?= =?us-ascii?Q?JiLL80Mx4lgTaYggkqH24OXntwFKH29XebfILL6kzsDYkrL0jGHkkNeYBn3d?= =?us-ascii?Q?ypxpLTTeJFXfyJfhkZu3Bf4NJ4KrZWIlN5ACbGPUaoIhoG46sm0ntkjOYPlO?= =?us-ascii?Q?C/EOPdbPJmBCv72hjTyAFpl/bf5AejnNiUsRpXE8sBcmugRJurX0xMQ4WU2Q?= =?us-ascii?Q?Whq/YLeJgWLUH02mdy/LzHTWmleQaB4ZwPcjmZbAmtbvaS6ZFd8Ykioyxjc3?= =?us-ascii?Q?fXyVa1XgAf6/+QJk4olhaZ4GhjCk+bWbzlbPM+uivg0JxKBNyKLuUp1j3KUs?= =?us-ascii?Q?xqOhXxvYc4rtPtKEQOMMZ3e3aQghVX1yEtGxi6hT1S/rmHeGxWXc5YZ/Rpoy?= =?us-ascii?Q?uPV2gFoewyVHiWl6/tH4sYve9luua/FSzony0MlW/WovewNjDsKEbzoeVFdd?= =?us-ascii?Q?RFqXntwAOUKRuM/SKngVWdwMpp3jDSpUaLe5E5hjOky8sZhNQfvteN9dBHZX?= =?us-ascii?Q?QT55ArMnYwrupmIUB+lO2KPwCwPZmQ/uYkVP/Whw5xlzmzZYLZ5d9oOoohaW?= =?us-ascii?Q?kGYN0TnXxB/N8ikDjpIiJkl/uUbzhoSj4cvAWh7aP8PRLuQhM785nAIEv8IV?= =?us-ascii?Q?8q48T4zF361dFaF0ca5w5Hdn9NwhwPChHvXwV5Aht8XrTe3m6Ee/SLgOhlTn?= =?us-ascii?Q?m9VEQ60mg8XOIoMIB1IF56c4E63y4WOD6CAt2hmTeGJbTz/YZTbZYn/4gJTD?= =?us-ascii?Q?lNZB9Y3mmQvbcR11+GLz/Pgre7jwn55C0pQIPKg/ZTvhJbw+irkdoZ4jJMo+?= =?us-ascii?Q?OcuWETkFK+3tUVeF/ENmLcAPdcH+ElBpDkOiZwaIYAbAPxg4M7CddTaDtcwI?= =?us-ascii?Q?ry3FLyt+93n17ZJIImgg1J8jNae4bUlBSPRoOdt3/Ejn3gSuMa7ievSgQMeg?= =?us-ascii?Q?GhfbcCilWoH4eevArMbDSCt6kjPtdqrEN/QGX3JdjDz2DktVJBK/tkgcPPHX?= =?us-ascii?Q?3+3CPYNGdIelkz5Do560R4ZCGuRrzEZpSyq9q3vAsgYqyz5EKClzyerM/FJ+?= =?us-ascii?Q?BWxL5MBMCxJfrZGkxdSJ4ifyf8rfqIuYt1U85RH8P7Xu2+o46qEbWHPMCFzU?= =?us-ascii?Q?6K+7+Eo3qw7gKRQISFO2RC5t4brvMDUm7Hqz1Qyx6kpVgPCkcEGlPfwjEIHb?= =?us-ascii?Q?3AtBolTazzn7IGIlSc54cUMm4MNMNbrzed9JjSBogGOADS4MJK0oLE9e3+Jp?= =?us-ascii?Q?JW6TGZ2r598AhemMLOOuKVRqk+6cH9yfVSm5zfX5UWYOslfqjQnQZ99O24/8?= =?us-ascii?Q?+P5dPu9juhNt6O+EZJPZmqbk8qk+/CU=3D?= X-Exchange-RoutingPolicyChecked: ZTFXE+YVpusadaHtyUigg0DjACaxaNZn+rHOeiozzG2YArW3SNpefYR71kUw+PhiNrjYAxc3ukHkT/fzdCH8hCQg1nf6zNmHXegEpCbcUDPNbMREYmCXNIzhuP9ByUQNywX3OTkewURfM7y7ohbRyifrUc8D2yesygD1o7hQm/YEtI2z7bFZqE4eCicLJu/HfMGxffL65vpalvC1p0KBPujAlyzSfOFBHdVe9kfAoYN5CYrUnHOHrPvu4V13uZB4ldZ12R5BqXWMJZNacGAz4asxy3XEmvz/CiepVCaXf0+hdwduY138Pqm8vf3EfHk0qwdIoxmEOkZrRZeU9N8vag== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 424be368-939f-48db-7e1d-08df2b90c5ab X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 14:21:30.4876 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bQ+cinOpoF33AbFzib4L3bWxfF14UWZTBSmJ0Yiuzql7kfcK8my6L9j/EHmB+8d49DzZaogJbW6vCgPcqrmDRHLsNUfqvSCE9WQT6RB9jYc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DSVPR02MB11424 X-Authority-Analysis: v=2.4 cv=LsYHWXdc c=1 sm=1 tr=0 ts=6ad232ec cx=c_pps a=8AR2Or5FcovIRbB7TUUKGA==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=660iZSQnnn4A:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=_-M8LpHI31CeLmyZm6wg:22 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=n0Z0T_akzs0uib7mm64A:9 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfXwF9U38xxOIQ3 IUmLvf8WR4oFzzCkPn2xth+5iYhBVTaLNJ7QnDJxeqqRAZNovMrPghDz+wiKoAIwantd5FUTLT5 5un6vuQxhtkEF+RwTntdAtXiTFxvMmc= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfXyBgXEhGivSi8 wYdxRL9AfQsEO3A7+YVYYmBkEFf32k1sVdGGEBi7852MEsSNyNOs0LnL9O1OjwnKsBM5Lxrcb9M BNQ+YVpNeVh9LJ1nAsQW2C4f1eBOF2Zd6N33+uLAP32fLUS8rD7Lmm3Syih9rcaUgVcB8pONbnk fDfivFr7xreWVk+jkbAUUm1sxby5Ubtte5A2HtHoa7Hg0WQTsTnW3DRLeo5DzbXZgarSQJ2Svyj pmmNFnyWHiJOz0Kq4uOa69GTf4edzOo6NlL9BwW80lurLmWYHIQtjptj1lUDenKx1myWEWF3VQ3 mHKYcojysKC5j784CKDN9Ii4lyQLE6kfXHja8f/ZHZI6G5kpqbIkK9u1kqs0zZItlnOcgt0Ky2K 2vJU9S/EvtoXe+0zpX/MSl6gZTWhV9bQ6A3OnOv+RTdiu+rsQdHeDWROK8OVnqK830CqArQuu7R TK+g2bU0Bcf0IDVDbmg== X-Proofpoint-ORIG-GUID: MQyD3F78r8y8kcFQafJ-1_OmIYvtdflG X-Proofpoint-GUID: MQyD3F78r8y8kcFQafJ-1_OmIYvtdflG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-16_02,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-33051d/1792160499-772F54E9-F16CC133/0/0 X-purgate-type: clean X-purgate-size: 11620 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1792160518182158500 Content-Type: text/plain; charset="utf-8" This ensures consistency with our normal QOM-based naming convention. Also update the trace event names for those trace events that originate from a single i8259 chip. Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell --- hw/intc/i8259.c | 104 +++++++++++++++++++++---------------------- hw/intc/trace-events | 8 ++-- 2 files changed, 56 insertions(+), 56 deletions(-) diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index 97ecb77407..4b34e5a649 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -73,8 +73,8 @@ static int get_priority(I8259CommonState *cs, int mask) return priority; } =20 -/* return the pic wanted interrupt. return -1 if none */ -static int pic_get_irq(I8259CommonState *cs) +/* return the i8259 wanted interrupt. return -1 if none */ +static int i8259_get_irq(I8259CommonState *cs) { int mask, cur_priority, priority; =20 @@ -103,13 +103,13 @@ static int pic_get_irq(I8259CommonState *cs) } =20 /* Update INT output. Must be called every time the output may have change= d. */ -static void pic_update_irq(I8259CommonState *cs) +static void i8259_update_irq(I8259CommonState *cs) { int irq; =20 - irq =3D pic_get_irq(cs); + irq =3D i8259_get_irq(cs); if (irq >=3D 0) { - trace_pic_update_irq(cs->master, cs->imr, cs->irr, cs->priority_ad= d); + trace_i8259_update_irq(cs->master, cs->imr, cs->irr, cs->priority_= add); qemu_irq_raise(cs->int_out[0]); } else { qemu_irq_lower(cs->int_out[0]); @@ -117,13 +117,13 @@ static void pic_update_irq(I8259CommonState *cs) } =20 /* set irq level. If an edge is detected, then the IRR is set to 1 */ -static void pic_set_irq(void *opaque, int irq, int level) +static void i8259_set_irq(void *opaque, int irq, int level) { I8259CommonState *cs =3D opaque; int mask =3D 1 << irq; int irq_index =3D cs->master ? irq : irq + 8; =20 - trace_pic_set_irq(cs->master, irq, level); + trace_i8259_set_irq(cs->master, irq, level); i8259_stat_update_irq(irq_index, level); =20 #ifdef DEBUG_IRQ_LATENCY @@ -152,11 +152,11 @@ static void pic_set_irq(void *opaque, int irq, int le= vel) cs->last_irr &=3D ~mask; } } - pic_update_irq(cs); + i8259_update_irq(cs); } =20 /* acknowledge interrupt 'irq' */ -static void pic_intack(I8259CommonState *cs, int irq) +static void i8259_intack(I8259CommonState *cs, int irq) { if (cs->auto_eoi) { if (cs->rotate_on_auto_eoi) { @@ -169,7 +169,7 @@ static void pic_intack(I8259CommonState *cs, int irq) if (!cs->ltim && !(cs->elcr & (1 << irq))) { cs->irr &=3D ~(1 << irq); } - pic_update_irq(cs); + i8259_update_irq(cs); } =20 int pic_read_irq(I8259State *s) @@ -177,24 +177,24 @@ int pic_read_irq(I8259State *s) I8259CommonState *cs =3D I8259_COMMON(s); int irq, intno; =20 - irq =3D pic_get_irq(cs); + irq =3D i8259_get_irq(cs); if (irq >=3D 0) { int irq2; =20 if (irq =3D=3D 2) { - irq2 =3D pic_get_irq(slave_pic); + irq2 =3D i8259_get_irq(slave_pic); if (irq2 >=3D 0) { - pic_intack(slave_pic, irq2); + i8259_intack(slave_pic, irq2); } else { /* spurious IRQ on slave controller */ irq2 =3D 7; } intno =3D slave_pic->irq_base + irq2; - pic_intack(cs, irq); + i8259_intack(cs, irq); irq =3D irq2 + 8; } else { intno =3D cs->irq_base + irq; - pic_intack(cs, irq); + i8259_intack(cs, irq); } } else { /* spurious IRQ on host controller */ @@ -213,34 +213,34 @@ int pic_read_irq(I8259State *s) return intno; } =20 -static void pic_init_reset(I8259CommonState *cs) +static void i8259_init_reset(I8259CommonState *cs) { i8259_common_reset(cs); - pic_update_irq(cs); + i8259_update_irq(cs); } =20 -static void pic_reset(DeviceState *dev) +static void i8259_reset(DeviceState *dev) { I8259CommonState *cs =3D I8259_COMMON(dev); =20 cs->elcr =3D 0; cs->ltim =3D 0; - pic_init_reset(cs); + i8259_init_reset(cs); } =20 -static void pic_ioport_write(void *opaque, hwaddr addr64, - uint64_t val64, unsigned size) +static void i8259_base_ioport_write(void *opaque, hwaddr addr64, + uint64_t val64, unsigned size) { I8259CommonState *cs =3D opaque; uint32_t addr =3D addr64; uint32_t val =3D val64; int priority, cmd, irq; =20 - trace_pic_ioport_write(cs->master, addr, val); + trace_i8259_ioport_write(cs->master, addr, val); =20 if (addr =3D=3D 0) { if (val & 0x10) { - pic_init_reset(cs); + i8259_init_reset(cs); cs->init_state =3D 1; cs->init4 =3D val & 1; cs->single_mode =3D val & 2; @@ -271,23 +271,23 @@ static void pic_ioport_write(void *opaque, hwaddr add= r64, if (cmd =3D=3D 5) { cs->priority_add =3D (irq + 1) & 7; } - pic_update_irq(cs); + i8259_update_irq(cs); } break; case 3: irq =3D val & 7; cs->isr &=3D ~(1 << irq); - pic_update_irq(cs); + i8259_update_irq(cs); break; case 6: cs->priority_add =3D (val + 1) & 7; - pic_update_irq(cs); + i8259_update_irq(cs); break; case 7: irq =3D val & 7; cs->isr &=3D ~(1 << irq); cs->priority_add =3D (irq + 1) & 7; - pic_update_irq(cs); + i8259_update_irq(cs); break; default: /* no operation */ @@ -299,7 +299,7 @@ static void pic_ioport_write(void *opaque, hwaddr addr6= 4, case 0: /* normal mode */ cs->imr =3D val; - pic_update_irq(cs); + i8259_update_irq(cs); break; case 1: cs->irq_base =3D val & 0xf8; @@ -321,16 +321,16 @@ static void pic_ioport_write(void *opaque, hwaddr add= r64, } } =20 -static uint64_t pic_ioport_read(void *opaque, hwaddr addr, - unsigned size) +static uint64_t i8259_base_ioport_read(void *opaque, hwaddr addr, + unsigned size) { I8259CommonState *cs =3D opaque; int ret; =20 if (cs->poll) { - ret =3D pic_get_irq(cs); + ret =3D i8259_get_irq(cs); if (ret >=3D 0) { - pic_intack(cs, ret); + i8259_intack(cs, ret); ret |=3D 0x80; } else { ret =3D 0; @@ -347,7 +347,7 @@ static uint64_t pic_ioport_read(void *opaque, hwaddr ad= dr, ret =3D cs->imr; } } - trace_pic_ioport_read(cs->master, addr, ret); + trace_i8259_ioport_read(cs->master, addr, ret); return ret; } =20 @@ -355,53 +355,53 @@ int pic_get_output(I8259State *s) { I8259CommonState *cs =3D I8259_COMMON(s); =20 - return (pic_get_irq(cs) >=3D 0); + return (i8259_get_irq(cs) >=3D 0); } =20 -static void elcr_ioport_write(void *opaque, hwaddr addr, - uint64_t val, unsigned size) +static void i8259_elcr_ioport_write(void *opaque, hwaddr addr, + uint64_t val, unsigned size) { I8259CommonState *cs =3D opaque; cs->elcr =3D val & cs->elcr_mask; } =20 -static uint64_t elcr_ioport_read(void *opaque, hwaddr addr, - unsigned size) +static uint64_t i8259_elcr_ioport_read(void *opaque, hwaddr addr, + unsigned size) { I8259CommonState *cs =3D opaque; return cs->elcr; } =20 -static const MemoryRegionOps pic_base_ioport_ops =3D { - .read =3D pic_ioport_read, - .write =3D pic_ioport_write, +static const MemoryRegionOps i8259_base_ioport_ops =3D { + .read =3D i8259_base_ioport_read, + .write =3D i8259_base_ioport_write, .impl =3D { .min_access_size =3D 1, .max_access_size =3D 1, }, }; =20 -static const MemoryRegionOps pic_elcr_ioport_ops =3D { - .read =3D elcr_ioport_read, - .write =3D elcr_ioport_write, +static const MemoryRegionOps i8259_elcr_ioport_ops =3D { + .read =3D i8259_elcr_ioport_read, + .write =3D i8259_elcr_ioport_write, .impl =3D { .min_access_size =3D 1, .max_access_size =3D 1, }, }; =20 -static void pic_realize(DeviceState *dev, Error **errp) +static void i8259_realize(DeviceState *dev, Error **errp) { I8259CommonState *cs =3D I8259_COMMON(dev); I8259Class *k =3D I8259_GET_CLASS(dev); =20 - memory_region_init_io(&cs->base_io, OBJECT(cs), &pic_base_ioport_ops, = cs, + memory_region_init_io(&cs->base_io, OBJECT(cs), &i8259_base_ioport_ops= , cs, "pic", 2); - memory_region_init_io(&cs->elcr_io, OBJECT(cs), &pic_elcr_ioport_ops, = cs, + memory_region_init_io(&cs->elcr_io, OBJECT(cs), &i8259_elcr_ioport_ops= , cs, "elcr", 1); =20 qdev_init_gpio_out(dev, cs->int_out, ARRAY_SIZE(cs->int_out)); - qdev_init_gpio_in(dev, pic_set_irq, 8); + qdev_init_gpio_in(dev, i8259_set_irq, 8); =20 k->parent_realize(dev, errp); } @@ -443,8 +443,8 @@ static void i8259_class_init(ObjectClass *klass, const = void *data) I8259Class *k =3D I8259_CLASS(klass); DeviceClass *dc =3D DEVICE_CLASS(klass); =20 - device_class_set_parent_realize(dc, pic_realize, &k->parent_realize); - device_class_set_legacy_reset(dc, pic_reset); + device_class_set_parent_realize(dc, i8259_realize, &k->parent_realize); + device_class_set_legacy_reset(dc, i8259_reset); } =20 static const TypeInfo i8259_info =3D { @@ -455,9 +455,9 @@ static const TypeInfo i8259_info =3D { .class_size =3D sizeof(I8259Class), }; =20 -static void pic_register_types(void) +static void i8259_register_types(void) { type_register_static(&i8259_info); } =20 -type_init(pic_register_types) +type_init(i8259_register_types) diff --git a/hw/intc/trace-events b/hw/intc/trace-events index 7512c6e600..003924ddb4 100644 --- a/hw/intc/trace-events +++ b/hw/intc/trace-events @@ -1,11 +1,11 @@ # See docs/devel/tracing.rst for syntax documentation. =20 # i8259.c -pic_update_irq(bool master, uint8_t imr, uint8_t irr, uint8_t padd) "maste= r %d imr %"PRIu8" irr %"PRIu8" padd %"PRIu8 -pic_set_irq(bool master, int irq, int level) "master %d irq %d level %d" +i8259_update_irq(bool master, uint8_t imr, uint8_t irr, uint8_t padd) "mas= ter %d imr %"PRIu8" irr %"PRIu8" padd %"PRIu8 +i8259_set_irq(bool master, int irq, int level) "master %d irq %d level %d" +i8259_ioport_write(bool master, uint64_t addr, uint64_t val) "master %d ad= dr 0x%"PRIx64" val 0x%"PRIx64 +i8259_ioport_read(bool master, uint64_t addr, int val) "master %d addr 0x%= "PRIx64" val 0x%x" pic_interrupt(int irq, int intno) "irq %d intno %d" -pic_ioport_write(bool master, uint64_t addr, uint64_t val) "master %d addr= 0x%"PRIx64" val 0x%"PRIx64 -pic_ioport_read(bool master, uint64_t addr, int val) "master %d addr 0x%"P= RIx64" val 0x%x" =20 # apic_common.c cpu_set_apic_base(uint64_t val) "0x%016"PRIx64 --=20 2.43.0 From nobody Fri Oct 23 14:31:10 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1792160589; cv=pass; d=zohomail.com; s=zohoarc; b=YMuBeaG/kQQxQnjI2RwgAsnEKrgNqFLlF/f5gXcSf8Z5g2pKcNGQxSPX4gOxPy44ratMxkiItIqhAMpb6Tm60rO/ULisRk8pXa8Y6kH8rkuji6e3KAwzZD8lLrysDnlsIyWS/LKbyCjuxTSjSXZlBSFwL7UKY1hrewvreN5Co1A= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792160589; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=q+TiuT29Lft1Lhctk/2jJK60T8JNvSJE91lHid7oU0g=; b=No4O4Nzb9vEGY/Er/r/Tpb9AdjuRSBhlbrTkIdJ3A1QEBPZDk1oATcuxlqK+KoIuX+ECVrB+A/yNezx5i5+nkuznfUYc4omnWmVmqjX4gaFYWpjkdfVy3M4jhgEJMOYVxNT10nLqjJbEB8QhdRxb/few7l6ITSn5wwBSAVW1H4o= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17921605895701019.7881978040588; Fri, 16 Oct 2026 07:23:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xHipe-0003Sm-Rs; Fri, 16 Oct 2026 10:22:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xHioq-0002pM-Rq for qemu-devel@nongnu.org; Fri, 16 Oct 2026 10:22:07 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xHion-0006jJ-TU for qemu-devel@nongnu.org; Fri, 16 Oct 2026 10:21:59 -0400 Received: from pps.filterd (m0127838.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69GE5GhJ3502681; Fri, 16 Oct 2026 07:21:36 -0700 Received: from bl2pr02cu003.outbound.protection.outlook.com (mail-eastusazon11021103.outbound.protection.outlook.com [52.101.52.103]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4hbg268s3f-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 16 Oct 2026 07:21:36 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by DSVPR02MB11424.namprd02.prod.outlook.com (2603:10b6:8:352::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.23; Fri, 16 Oct 2026 14:21:34 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%4]) with mapi id 15.21.0522.016; Fri, 16 Oct 2026 14:21:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=q+TiuT29Lft1Lhctk/2jJK60T8JNvSJE91lHid7oU 0g=; b=TAWdMoPoVJXiHI3OOR42lL2AyCbNBwCmxvkEmW3i7Y7aSKxheHc8bGMp1 1nIcEyTaOguDuvy8KSByACYbngWsMo4rhh9ckK8qvcM39G64ld9YvlmNRQ+4rdh4 FjhakINn2/o9m7EWhQNShbnznQtRahw2Qrz58xp7upFUnwvAaLY26l3Ij/RL16b6 SxZpgqpA5Cs4oCp4kUasDlmaitu7CbYfYyXs0dANmdphgdFgBVqKWRIZAJBKdOjN 7qoVK4LhkApVaYK+tfvSKk1rxBwNrGPtLeivZnEWZ8Odnzj9FSyZzlEWY36NXxcb Ne8oZq65uZboOtBAy2nbYWvBJFUlQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=h3OAY0B0cbBNUotLesPueiuIWnV2vbikSvA1Le8TasPCuScK5ZcPkcfOwkNTAq/T6DEUVDeWN/ADC58GRxcIgbE3pisqldz491XhXrKsEeFjPnfJssUmwsoRjM/ao0zE7CRhj7Evjkk7+q0YkW5R/9Ua1GzJkmtR3VOGbFA94dGbaUh0KBBUs1ttHnpg641qcupzzNL/pXjTXYonmXpT68Bvt60hkPwjj3G2vOwRIoKXZPv+uEByIblZKYFkINNDgo67SWffEUkxOFNYhtyJrqpvibpaTHVqxc+dCd3wxXEas67w7jCLeDo+CsA9NY+e5KwxdXZk28J2wbhqT1cJ1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q+TiuT29Lft1Lhctk/2jJK60T8JNvSJE91lHid7oU0g=; b=MkWFskghrWnjMkGxpj5UJi34zgAs4oGyviWLBFKg+j8Dq5FGVbnluEaThYlvYihaxMF7VbPHOyGkN98f6KHH5rXdmFV4ClQHiXRVfzSuBWe8jYO2LX6pHweEl8cVFjeKpJqthxvPk0vFSTlgeo7r5WyfNW1hB33aDwQFoGUdi80nLJAA7CLfHU0sIrEbSIbmHz8p9hL58chMJkMjGUdKEzCHR4SfDjk/YWFVZnRc1b1UsGUNIRut2RsupyHRsK7Bq/xO1+JxQLtPWa/wfQyh0s31sqOFXTHuyOPBdSYAriWchrvs/ZWUYUSTUL0NjNfuo4ZFVtl8cmOOKM6SAqaROw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q+TiuT29Lft1Lhctk/2jJK60T8JNvSJE91lHid7oU0g=; b=uOUgB2J7RPLQzsBBW1eB3iLNn3g918TC0FvKL/CPxRMe+G9udlSnogPCrgUOjwe8TsOEfXbEzbqEYHOI0bFWa5Br+wGOC/HEGL5oJVK7zMZE+4DwIW8dD3ovpN2SOGWzkf/dSWXqC+khDfCJTbcMfHxLvNJ/12jznVq6kgdv0pLxP/fKpmjfh89+aqNyx7VZJViEHInvALEJs3vCi5Us6SE1dpJ6JMElC/7HlffzEtLLgNn6EGDa+HmpedniHK+dpHwytggwIj8xqs0Qnsaeq13iILGk95AXc/YviOAqpSChDJk3mxWAuMQNVcFyzu61rpysdau4MjEyx6LQ7/DR7w== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nutanix.com; From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH v2 14/27] kvm/i8259.c: use kvm_i8259 prefix for functions Date: Fri, 16 Oct 2026 15:19:20 +0100 Message-ID: <20261016142031.1204281-15-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016142031.1204281-1-mark.caveayland@nutanix.com> References: <20261016142031.1204281-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR03CA0293.namprd03.prod.outlook.com (2603:10b6:a03:39e::28) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|DSVPR02MB11424:EE_ X-MS-Office365-Filtering-Correlation-Id: 69076bad-cc53-49cf-5817-08df2b90c81c x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|23010399003|1800799024|366016|376014|22082099003|10067099003|18002099003|261009223027099003|56012099006; X-Microsoft-Antispam-Message-Info: 0+v8Tnc+e/mr/zY1IgJID4aAB+V/eZ2UChJZVsr5kncGUoXC/ikK/wSA/4gbUW9xU+I9nyvhI1toMM+dmWZjddv3OyrKOQreWHt5Mxn3bboxSr66ax1AIROII6chjj1eUzSuL6jWm7wuf6ZT0OZEbCBuqt/kjHO+aLvrHdL2AndqAz1x/EEoUYqxfRTv6kPtujI9NCI4dzdyw1FSuAvw8RCgOoPl4OqFWD9yvj4QhZDMSa0MTLhZ8kRqYMsArymeaBKApAGOsn8q1zG1Kk8IatMJAAP3AhDitw2MCzgkAvB6/eCn217lgn6tJkT0dTFun6eajK1YtNQ1oAmkjFRZ3lHl9F8xNV6lggidz90V8XChmL7yCP5fPIN/efR+YXpcWa8gO4M7j9AWVyojAnzl+VN9u4wAK5XTCOsEkwr/nJ8X1CCz6r6m8FCe/0aeMIIEsRqqak48F24t8GMzZ8N4W2d+A4fqSrgxgEfXQ2fmcCg6vsxvof425aWPsiAr1jiMhg63AnLQfA922hIs4PGOsS5iipKhc14MKwggE10sLsnYHuuOhUJ48Uror1okYQ094MZW+9lsVPyCQQ4t2fEIZ4wCTrrLRwZEZD6ffQO5vvlE9RT+IIqEWZVY2DNe13tTphz9Xg4v9ow7X9rdhAIRKZ8XlOvv1Mc5G/lWuqt+RHI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(1800799024)(366016)(376014)(22082099003)(10067099003)(18002099003)(261009223027099003)(56012099006); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZtELg850ZJXBovopVYv9JjnMZ8QpowGqilFDmrlaHdKsB7OZHsvpEYM0cykv?= =?us-ascii?Q?b1wTUXyIdhkzrfVnfT5vzWhLXvPqRzQ/8+BZzRfN4V45XbK3hWLrCjB/WOMX?= =?us-ascii?Q?OOKXc/ADmMovrZKIl+ltjLtboC9641zt2qQ31PQskfV3b0gQvFkSKAoPPnuS?= =?us-ascii?Q?5VvgwJt97w5/OE6DY6FPkXKG0F29m3TNO4A4FJObnjDGohXlm+wWEbXEkJZ0?= =?us-ascii?Q?0cSjgTJlGMeVSNnxVKZHHrIG+hr8REVNWxMzkwNodAuNz/AqfUscn52NJUsK?= =?us-ascii?Q?ALFk5UWE0/DuqyXlYMtkdC9wouxreK5RNFtYlcsID48MD2rqFLWxfiiE6V+y?= =?us-ascii?Q?4YeP7GsIIzEYCLnCVV4Dj7imDFkLZZoxl7UDKPteT5lY/m7ag4vkXzpdp0wR?= =?us-ascii?Q?L1amlwBlouIsRIkQPInqqOaxABzkVz7zGPsSOP9Tq7NpRz5yOXeOfPZ7hZ3S?= =?us-ascii?Q?62BxNZ2jOtfgKM1XZ1eactKCfE4UZJHDCf3uWbE8DMUeLJ06o+y2OdSW+kG2?= =?us-ascii?Q?pmCHYcjEL3Eilzg5sEQrzdzhRu9zeAodFrGb30fpgLK84PYCF5Jh4PUi+BAD?= =?us-ascii?Q?5jNvIB8KN5u6XVwxolCPvAZOuPrePI1iWWJQHDZ5FpMlx/e+nLotcfs7tPCw?= =?us-ascii?Q?DMcrk7wJreFWLtihXV4MpbLNl+2SZ+OxPsAzXESp/k5BRma9qTmC4dhH0wva?= =?us-ascii?Q?ONxJLJgB5689MeAJg++0mr2jkle0CPu77twPRWmQ+TDXLAwUViLDZVFzPmx9?= =?us-ascii?Q?l/Mxz026gTAFTo3+DPVMY3uGNxhBdBjz8BWNEtJ88z/X9NrZMpkHo+cqf5kV?= =?us-ascii?Q?xzXcEQNdHWNsyzO1z9MlvSLdo1v0Hh6/ewyXUrfaANrJxppn3miC4qLb9KQH?= =?us-ascii?Q?zNldGAaauvcBU/Mjwc8tgCq0JIczKKqO4eTS3wfaTdJDI6TWUi7+Vkt9EDdo?= =?us-ascii?Q?3AfKbDuB1XhU/v1OcJ1AP4iMjdEXvwwAEyC4NuEJgm61wYUS30J0FR/pLgMe?= =?us-ascii?Q?kEXZg7MtM+Ufb+G3DQ0wIptCwGlu9IoW9yKKft/J8teGQE2J8rEPhDpZZmck?= =?us-ascii?Q?N2a9aZt2BAgu52N/v3lUbBgGX6TRF5YROBM7TdySKaZvpZLtqkn2UwLwNO6f?= =?us-ascii?Q?PqFBY4Zh3b3zXHKti8P06OWBS/40tTzf3XwLVvlL9XDfvOyXftkgEUwp4zlz?= =?us-ascii?Q?ijXdeF4tKVrGdjOqyclLZxU76fUqLc4XUZAxzldpSavhDqIrZoajB9eRosx5?= =?us-ascii?Q?Ywi7jfIkztiGPLOaP5jIVIC2+kypgwfb1himVnZrBfX72buPmQX4JgH89jjY?= =?us-ascii?Q?Z6XFcBoS+3kaTz4YiA9OQ9hwb/8lKjexXUZQQjxJZfWefiuql02TG05uFj0f?= =?us-ascii?Q?Oq710bEAPQIaqzxG96NQrpYBf0hgcjrfzDykcsFwB+lGfzLUeZD+yxtsjWHJ?= =?us-ascii?Q?yVvSlZ/mWPLR2hbScolnMaa3Zu1v4KIIOZ91BwyjoIddyZpXoeE/SUwCyZRE?= =?us-ascii?Q?Gmkt+URfUKGL7bzl0eaMZo0aPFTdIF0yRPSzyZBvAji22D2CAzlBCCvBBTrt?= =?us-ascii?Q?+bdEUrHJkIY18nqIHNY07NmDrfXNwIUJ6v3dDVnbMhibBMz+hYA5WHI8L32N?= =?us-ascii?Q?6D7x8TlNd6E3jl0/Q7YEIjmgJ+h5XqOylY7QD2Y3eB4TVnFRF0nxy+qTLcYq?= =?us-ascii?Q?OSDgu1hOQDyEnmJyy+Fzx56IaZlOtEKS7+hhfzyPP5nR2DMQYaQRBjzWGkYV?= =?us-ascii?Q?HPxK4YZUW3ddEZN/G9YLtbWZ+C0LfWg=3D?= X-Exchange-RoutingPolicyChecked: leXj+3WZvgvc9AgPwGdGo4jofV/rgPPQbfwVGc+R+tM/hIslsWCtrD7fO5LA6p0JRMFbPnis8nO60jmDpQqtuN/b9jZPN17IGO6rLEX+S3hxsuHMsz2nP+5ibcmU1FwBXX2pYvUvbdiUDZkpFU2xPJniAgzhEqLDKbfjNFg/bTudWvAv+DFtElYQwxc8IJ1sHrioct8jduNDKTHWIIQebZQqkOjs7tvuCEWE4/98kP2wHQrOBxU0Nq1Qx8K6RJf11bU7GKMNA2RU3o1sLDCoO0DcGgiy57BncCIT0HYofZVkpLLptFujO2JlJo2OMAMRXQmWWEATJa7GhcRfvTIuXw== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69076bad-cc53-49cf-5817-08df2b90c81c X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 14:21:34.6125 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5yzadlPVZTl/OsBDB1RyWeC7uVT9kdziyScrnfWyFTizZErd85d8fuUrAhX15dMgHvmuGMPNkDxyZrO5h4qEMt4mMBMRAG/SGnl5Nparcfs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DSVPR02MB11424 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfXxXsJu7r5mPbm HCKQBaOb7uJ9X9g4eBoQZ6JOuSgLtK1cPP1x59mOCjiub01jvVf5NZW2u9OkBKg0LvCBCpn3w9l zVH2M0LssVj7XvTKtpnkuSsoARl2I1M= X-Proofpoint-GUID: Aj3vd-vBQd-d2Fv7mFOaaFdhCoTt96YP X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX6KWC7WkBEWI8 v85l88tdXe4HuWDXV0irGxZ8eomsPpPIrggqG6Q0dfzHwhJ1VvLN7MZSPP9UD86f4Q3WNgeUUmU dIUfs6ft9t0BVaKsMZzQ2HB0NOgFUTiqcIN7u/Y4W8aIq/DuqF0LrdZAh4oRIEjb7q93C6kmf7F RqwxFnCT9FMcx7dO6KSPJayze7GMvG7iyRE2RL9Eus6gxaz0o0UUIilCkIXvipQolYAAlPdTIA1 7mH3KezkFhgYD2Q63ia7nC7m5a6DRa6qHcFOAi6sLVQKvAOXguwtcaYmPXKOspJz9WonXDzCopa nhBJXWrgEZvpP/SlMfy9UaeVbwanz/Dc7IJtEKjVtxUwDCMAh0ZXZpygJlCIg36HSdZWLIzHC3D jsJEXMzQP9VrRXk0wvyz1PczGJgwPJ5CmmJVrKSA134cV7LPbPNITe+CeSP/2wGbtRX83OLqhLL 7fw4M/PMy7LgtDAVaSA== X-Authority-Analysis: v=2.4 cv=G5OJgNk5 c=1 sm=1 tr=0 ts=6ad232f0 cx=c_pps a=yD2eIpN93qk0sgAC8tXY5g==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=660iZSQnnn4A:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=1L6crL_YRTbalZ11mEUO:22 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=b1AWVSNg6wsnrng390EA:9 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: Aj3vd-vBQd-d2Fv7mFOaaFdhCoTt96YP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-16_02,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.24, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1792160591414158500 Content-Type: text/plain; charset="utf-8" This ensures consistency with our normal QOM-based naming convention. Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell --- hw/i386/kvm/i8259.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/hw/i386/kvm/i8259.c b/hw/i386/kvm/i8259.c index 3a960e48e6..952f58be11 100644 --- a/hw/i386/kvm/i8259.c +++ b/hw/i386/kvm/i8259.c @@ -36,7 +36,7 @@ struct KVMI8259Class { DeviceRealize parent_realize; }; =20 -static void kvm_pic_get(I8259CommonState *cs) +static void kvm_i8259_get(I8259CommonState *cs) { struct kvm_irqchip chip; struct kvm_pic_state *kpic; @@ -69,7 +69,7 @@ static void kvm_pic_get(I8259CommonState *cs) cs->elcr_mask =3D kpic->elcr_mask; } =20 -static void kvm_pic_put(I8259CommonState *cs) +static void kvm_i8259_put(I8259CommonState *cs) { struct kvm_irqchip chip; struct kvm_pic_state *kpic; @@ -103,14 +103,14 @@ static void kvm_pic_put(I8259CommonState *cs) } } =20 -static void kvm_pic_reset(DeviceState *dev) +static void kvm_i8259_reset(DeviceState *dev) { I8259CommonState *cs =3D I8259_COMMON(dev); =20 cs->elcr =3D 0; i8259_common_reset(cs); =20 - kvm_pic_put(cs); + kvm_i8259_put(cs); } =20 static void kvm_pic_set_irq(void *opaque, int irq, int level) @@ -122,7 +122,7 @@ static void kvm_pic_set_irq(void *opaque, int irq, int = level) kvm_report_irq_delivered(delivered); } =20 -static void kvm_pic_realize(DeviceState *dev, Error **errp) +static void kvm_i8259_realize(DeviceState *dev, Error **errp) { I8259CommonState *cs =3D I8259_COMMON(dev); KVMI8259Class *kpc =3D KVM_I8259_GET_CLASS(dev); @@ -147,10 +147,11 @@ static void kvm_i8259_class_init(ObjectClass *klass, = const void *data) I8259CommonClass *k =3D I8259_COMMON_CLASS(klass); DeviceClass *dc =3D DEVICE_CLASS(klass); =20 - device_class_set_legacy_reset(dc, kvm_pic_reset); - device_class_set_parent_realize(dc, kvm_pic_realize, &kpc->parent_real= ize); - k->pre_save =3D kvm_pic_get; - k->post_load =3D kvm_pic_put; + device_class_set_legacy_reset(dc, kvm_i8259_reset); + device_class_set_parent_realize(dc, kvm_i8259_realize, + &kpc->parent_realize); + k->pre_save =3D kvm_i8259_get; + k->post_load =3D kvm_i8259_put; } =20 static const TypeInfo kvm_i8259_info =3D { @@ -161,9 +162,9 @@ static const TypeInfo kvm_i8259_info =3D { .class_size =3D sizeof(KVMI8259Class), }; =20 -static void kvm_pic_register_types(void) +static void kvm_i8259_register_types(void) { type_register_static(&kvm_i8259_info); } =20 -type_init(kvm_pic_register_types) +type_init(kvm_i8259_register_types) --=20 2.43.0 From nobody Fri Oct 23 14:31:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1792160528; cv=pass; d=zohomail.com; s=zohoarc; b=X/i391/ZpdTfIP9Fos3TmaRThiXCBFhar0b9CNKwL2LomDw/aq5Yg3gYmSOGbkHl4kwmkB1CVtdEnibv1Z5gY2is4XNhAlCZ3SkEYTZmRIb+Ivko1q0NyVSQG6MqEDSoGe3nA5aDynGOAl5O0QeTqty4f0NcjlZpRbdJp9TrndQ= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792160528; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=po3EEb9dG7/G0E+Na053cQN8h6xsnwFa0pjZGUjYeP8=; b=hCBNaR+hMyPk125kuEXdMInbxh58dDnE050Mc7Lb/qi7M0jsmFvoArZcBmff/HKGEG9ujLo28yG0gk1Ky++Db2z62z2kjRpN43N/E0Dxi+PULzWuJl5KIplJU7eIEj1B1x5WdorwteN/hYxlsMrFPIPSEMFsQaunqUPUrVlQlGw= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1792160528718440.92175160355896; Fri, 16 Oct 2026 07:22:08 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1451992.1666857 (Exim 4.92) (envelope-from ) id 1xHiod-0002pU-Mt; Fri, 16 Oct 2026 14:21:47 +0000 Received: by outflank-mailman (output) from mailman id 1451992.1666857; Fri, 16 Oct 2026 14:21:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHiod-0002pN-J2; Fri, 16 Oct 2026 14:21:47 +0000 Received: by outflank-mailman (input) for mailman id 1451992; Fri, 16 Oct 2026 14:21:46 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHiob-0002lO-Rk for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 14:21:45 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1xHiob-00CcVT-85 for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 16:21:45 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6ad232ed-2eae-0a2a0a5409dd-0a2a4504ac90-34 for ; Fri, 16 Oct 2026 16:21:45 +0200 Received: from [148.163.155.12] (helo=mx0b-002c1b01.pphosted.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6ad232f7-b57f-0a2a45040019-94a39b0c1980-3 for ; Fri, 16 Oct 2026 16:21:44 +0200 Received: from pps.filterd (m0127843.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69GE5MkL3333363; Fri, 16 Oct 2026 07:21:40 -0700 Received: from bn1pr04cu002.outbound.protection.outlook.com (mail-eastus2azon11020117.outbound.protection.outlook.com [52.101.56.117]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 4haukukqdw-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 16 Oct 2026 07:21:40 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by DSVPR02MB11424.namprd02.prod.outlook.com (2603:10b6:8:352::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.23; Fri, 16 Oct 2026 14:21:38 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%4]) with mapi id 15.21.0522.016; Fri, 16 Oct 2026 14:21:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=po3EEb9dG7/G0E+Na053cQN8h6xsnwFa0pjZGUjYe P8=; b=2jJAEPWMQRMdu3qolB1cjaxR+nOoo3Gh2CW0UE04Sm1XpwuH1L/dzEzzZ VSq0I/f5G5K13pttOGF/zoehiMcVwlyiPkh8GvVdQHKKV2NiqYct73WM5Pi6gi1Z 5SdZpF5wta9Jt0nBz2uvW/xcSv3+5lS3Nsc6+7+wh5FS4Iy46WQx1dsyNw6i/prG NgUWCdzyib7fEIqMymPYSwpOQ8ZXYxPdqfYIlm44muzv+kEMYpar3sDRjo6DNDug Pe1JkhnhLTE5Dv0CddL50nDw79ANNtrrmwAOfdXa/6ZuOL+APwwfLjLOJ+4fMCq6 JRWYfDU2LmpMetEZ1QIzcOqNVYfRg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QnvJlJFctGcQvO8cl6uWOJoAuobKE1xLc7mQeVPIxqY9jdwDUnigBwUfr/c0nKzV1fYGqnvxoyQZQ0K/q0tFPXxwjdRChgNJmIpSltAmAIDMNcYOscWzCj8MPOlcbAAGWoacLU2GVPrsUci/s4piMgUmNtDS/c7exmTdFosbpfNUTbAGSz7QKJikI4b2uixRRIrI0mU1+cxJ460zw56e7rCeABxPFPpJ4zEOiicZhl9NxA1rJbfZKaylFBsJSHAmfHzvj3C3a8NpW/+Ho58V56dXSrBHIbndQXR22c4xwnoTt0UYqvjJoko88RcXHF/qujlOkzZulXEoL6RMfTiSEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=po3EEb9dG7/G0E+Na053cQN8h6xsnwFa0pjZGUjYeP8=; b=iOc0FgQFXy5c/hXaoZzsiAXzx25XGFZG9fH6WB5ocRUZlBUN8FGcm1sZ2ZB87AKhASg1AcxuBSr88s5XPFoQySDfXF/WhfT3LnjQzlQUPRSWHtnL56CfIPbZEiLOoigOS+U4HiRap+IesJLT5VC1p13WMpGDQEH6ZgJeql5+5ED4VLGw5soyMH5Gv2IXzpPEGyeYeZsLBW0Nn1Ni+LIaGZ0lU6s+GXGkVSL5jmsYscfXsjSy4zun+ACcABRpRjc/7Y8cHFQO22lGGpaxBh9DVCfwkPImKKZdPgiE2ciFSrq8e1vD7gRnIlk58sw050mzLEH2R9tDHsAwk+yjYIbTjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=po3EEb9dG7/G0E+Na053cQN8h6xsnwFa0pjZGUjYeP8=; b=sziSnpcLOUroF99ADTaVORq+z5sMZNBaRHxHDh0/p78Xd02LC5lPS9asEykgvc+EiI/r01zNjVMTzqyfczZfCIXzv36uyjt1xJ/WbH9EDRjhgBRqEKcmWLSfHtRGjZT0B4vpZ0k85tTdW2TCGTDRYoqnodXprALjwBO2TWi8d8s1x/Nah+Sx/+Pbla91hcz8wpH5iUZ5fyInnv1m7JR3smbHlShix9rpQMdAEe6psvgTu36KrQijCV2zl+U0Cm4QHQ+kzIlUtPpu7N50wCVcd0rc4Jp1A0+9Y1pe+xjN5CI8JjkDS3Enuhggd2110dvDH6YJhwWT0iaUlRr4H9WSMw== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nutanix.com; From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH v2 15/27] i8259_common.c: convert to use DEFINE_TYPES() macro Date: Fri, 16 Oct 2026 15:19:21 +0100 Message-ID: <20261016142031.1204281-16-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016142031.1204281-1-mark.caveayland@nutanix.com> References: <20261016142031.1204281-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR13CA0204.namprd13.prod.outlook.com (2603:10b6:a03:2c3::29) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|DSVPR02MB11424:EE_ X-MS-Office365-Filtering-Correlation-Id: 476986ab-4b69-46fd-9f13-08df2b90cacb x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|366016|376014|22082099003|10067099003|18002099003|261009223027099003|56012099006; X-Microsoft-Antispam-Message-Info: kUXsU9uCBiee/u9yUypQJojr5dhQDxPRfDbnxbj581f0/R0bqlSPj7F9wJ3A7Hy8WLF4pIOWpf72fkVibc77sWxrGUmhH8I+RV9qug0+aM7TqFFlGwZEkeOh7Shj5LT0do239gaL5/Ydpf5tbcEQOeFkwFrtKosBt30DJ3Ja0sLCMbU5VGRAL/9HLjmMQkifUEldeCFrQmD+apIMWyNF03pCVCwKOUsdmzHpUum606N9AvxoO7n17QDo1r2/d2zPUwjy9q18RN3ItNdvuJV90i1qdbByd/50JPkRNDbdbIF/0ffTOF1RwdKyYhc6udi1fao4UOwGEtVlVkTS2Rw2UKt7T4KlUlWhLhabzfPj8XhQY2x6h91cnh3uo25Sm+JCkUtjN8NR39R/PkhZ2kxoCiKRm9nvQEgS2brIHSRKpfRuIuHC4wRSWxH7Tp9+1ED0f+aO1R6UNDCkH7h27vytOz0mJdmJQv0QZ0xw31mNpS0FDEqp28NKgPMxFbsmaxvbwW1bOgziZqnzh7VFZpMBgK320jO2WgF1ilclUrVQNiMgOyNO+tYUxDS7304f0a6DJrCbBZkQltqgibSXTZRRBP0Xnx8WxyOomov3RAEPyShZmM5/jnKMdm/gXH6Nr1RSFHRVUXAOTUiMzxVsMAbLM9p7A90R/OwJ2H6k5wm8HSU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(366016)(376014)(22082099003)(10067099003)(18002099003)(261009223027099003)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wdef5kK/dG0+2rn/O+kxgYfd5djpgLaQb0qIvOJ9zzAYA48TsviJePyLXqDl?= =?us-ascii?Q?yft1Xs3dXZUw3KtWylK4UAMCBcdobYZMvDqohHJayX3dsZXGglpA/SjWhHUc?= =?us-ascii?Q?GOHD6g7BsVz+Bxoj0r6k6oyFGbtY8roM4HWXWwkKzvBty/BhrTTO9CSetYr3?= =?us-ascii?Q?J1NPST35SgE3Vtn3tbBO08VNibRrWJzEskFCWmsV3bRb59yHT5Qr5H8HHiJ6?= =?us-ascii?Q?7S/gVDIeUxZzYiAkUhYXoeXaqwe4tHBX/+M1Qg6/EZO6MdkP+Zt6NU7hGbbD?= =?us-ascii?Q?VTdNL7IuTWzebkG5PxYW0y/Fy/NipL3ygXZSpu0VznQDl+HFJhpv+RiVB40r?= =?us-ascii?Q?1j+XK9Mqn+X9SGeil/gPpx9StQJB716dNoQW6X9m/Q+1LHLrahjTaNCksYjf?= =?us-ascii?Q?AboD2EbgvWSD/O9Rynv2NF8uFzBAWLeSqOl+JLT1Qf1j+99uJTJZ/qcrySSm?= =?us-ascii?Q?Iq0TSxOqaQuVzTpAWfJWrX+Tv0qd3OFv6ZRjx5sAaCyuz736dSgefWzKvLWs?= =?us-ascii?Q?Ws3E3ku9pT0DwSa3wZWZSVOctgccNbaCwnz1IZd3/5ZV/NbEiYrsX73TU3uJ?= =?us-ascii?Q?V+bTXHygpZZYD73108a0KVlA79jlLxTKS9PMcmT3bzN0Fs+Vh+ZVMx8Yt7gU?= =?us-ascii?Q?ZScz8d1eZthnKZ3+qzmPajd9PdSHNAlg8ZYpo4iaEqtu4sE8NrCtsm1oe4ei?= =?us-ascii?Q?hxKMr9dE7FK1vknqhQsshtSmh6NZv5YY4dOMl5ARJlCQM7kRC5rRrOQ9dz2I?= =?us-ascii?Q?772rsNIqVCjKDINbEYgoMl9c14oJ+9etc2YvyTwkXNUzpdqEjF6Q0xCSgHkR?= =?us-ascii?Q?U0dsVuRWGIGy1PsC4gXydNwAufKAyDIn2qnl66mFrQZ2VnGu2h13cpLmGnDV?= =?us-ascii?Q?p0hktMaEaDIrulhubmwRzM8wPjS5aMBzsF5dSbWs6YCeBFBtS/w+OYicLm2Y?= =?us-ascii?Q?NEUkPGeswETByCwfQJukZgB14SQWn4bpDqWSif2y5oghYcrdT0cKzmJs0ruw?= =?us-ascii?Q?+KJMoXbAp0IWk59hmpE4u+7Sh2Ya0pHFJUMbrk9jTH8BK9Vnn+ZXv2/cu22u?= =?us-ascii?Q?o/tCyN4iuLzWxJg5eKqGQNiBkQgYbJzGl3h6KSInjLwSPIAyM1BkvA3zYt/m?= =?us-ascii?Q?5Rwi3ghkYPYaEepE4/EV46qynofwTjDU9X/fGl5Kp/LFFnW4oq1JwItRjfZ4?= =?us-ascii?Q?J+90L5WAZ/usbNQkWTKRONis/mDsNSM8DY1A4sCs4bJESjmpWOvqgJkacWVt?= =?us-ascii?Q?1W8wLrFHKX9rl9XtNFbzgDS8CVfSdiPPzc0xvESPAjbFhqHn6o0UENZLDYyC?= =?us-ascii?Q?VDuil25XxE1zShSIT6gZRa8Fs35neleQq00leD6xlblRWBEH4ozimuwt3Fna?= =?us-ascii?Q?7s+NELzofG144BmQapZlyoKVTkPSJBMPr4y6KDSY1h019gTWVhdK0jsygA0a?= =?us-ascii?Q?YHmZnK7o7gmSWW081iTbif3Mu9JWKIT5GH2BuQfHuCdBRJxbSAPHM8c6oivC?= =?us-ascii?Q?0TGnBBCHbD9Op9jZCMK3aHt2kQtYdmHWoacp8IdPrFzgm/uDYDuhY4CxufUj?= =?us-ascii?Q?KwQpqY2x8uV2jCcLlcSSHsMp4X1NwqtwhutIVrZekJsrSlYU0gmwPTfKNh5Z?= =?us-ascii?Q?I5nhTQLBgaT/UgKYgbDhPNYJVLEZioWjgaNjMwzQq42BPaPnU8j6zOxa04S0?= =?us-ascii?Q?JEnTB2O6t0kAYtauBH4lwRT0iv1CQw99yTCm9GRB/s8zTNOH23a9eTDQBmqg?= =?us-ascii?Q?ReMeHs3fS/8HLYFhl+8fHRqgkn4yiTw=3D?= X-Exchange-RoutingPolicyChecked: oXKv5Ad3xuW1lHiWcGbKAa7M+f+qQeQH5OWe2ETqebJEtjDfvGu/UoaI6U4M4QCCLvcLqQ7EcKJB9vJd3Q2ImVRyeN8jzEoGvHff9njJNYXuaz+dxNV582EG0nQnUUOPBvVXbE+z1a6uTxEUpO2/WZdlmQirvtYcdrBZQcsHWl3d2TtmeTRZU9Yq8i+GsevtNeRMNOVxVAFsBCErv6YUQDWR0c2s2uXrHg0xMsgFoBNCP8Av0rBbj2zYNmDYrzFsSEJftUAmptn4CsR34YMTz5a4ErUuF72ZkthfpPitug54W0oZ4HF0LQccI4M+H/giOE7XBBnsdGUI7e9rDBJNhA== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 476986ab-4b69-46fd-9f13-08df2b90cacb X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 14:21:38.8585 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GvOtc1kbvibCdr/61CNNwIPrFakpYVwe1pXOX1hcGLXdRI2a7qeYEWZFES8s8TozCH/9okryVk5ECGWLgaLhFd9kjWUAwoVopoQbRP0sOjU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DSVPR02MB11424 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX6bSPqhh2e87O UbzdbsN8qYh2y5/IqMAedm9wl1qZhgfxCPjC4baXRFf4dtu8ocVDeSnNJcgZHPouGU4cBw6QGYM LmyqGMYncHf1QrR63WHTzQ4gA8nCDTM= X-Authority-Analysis: v=2.4 cv=G+OJgNk5 c=1 sm=1 tr=0 ts=6ad232f4 cx=c_pps a=v6Z6meDQFn3ji2zknzBGMg==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=660iZSQnnn4A:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=dEe9Ve2bX-KnNSUMM2s9:22 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=bPck6Z4TT5Um9jj7BtEA:9 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: ePNY4L1EQ_7rW3CuPYUeBCEX-HIJAeOU X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX070aBJZGe0w/ VCE5/KUF7DyzpieCvcRSV0GaLhRMW54g3bTWCmv5S2BvmAvbo9ttuJ4KKPGDKuZHyfekk1jezhM WO7MD8wIoC0qzWZqJaJQzLrI73kG6lo/ap4rKDXsp6+zdGb29WsOP23FJ6IV4OyO2H8G6yzkXS7 m1wWTuALFiQR9FCzTEN9o/ZKLktipzj968uz+yNBNiczg5oZRPXCBaVvZDoq3RySQSEDzQXbLQ+ jNEE+dx2SULy8JXqy85amkbYV0rRhu+2eC7IHBazLbwXfsbz9tEhJFDOUjMqWmuP9bo6K4QaYEr ntiJJ+8P8ILsXnDkFfO269BS69k/N4R3xhnf4AEX+DdYU/Ns8a/xuCrMjwVbmSQX+2KXzmq8h7O Tng56Vouq4wCYOLXT3FO2VQHaYtF97KYWEM8UQFyTQTUmPjfz84bBAnz3nD+ZLzCsAkfjyzzubS 8q232Lh/pLJ5QRV8+Ig== X-Proofpoint-ORIG-GUID: ePNY4L1EQ_7rW3CuPYUeBCEX-HIJAeOU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-16_02,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-ebf023/1792160505-C18D1B50-017E886F/0/0 X-purgate-type: clean X-purgate-size: 1595 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1792160530333158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell --- hw/intc/i8259_common.c | 29 +++++++++++++---------------- 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/hw/intc/i8259_common.c b/hw/intc/i8259_common.c index 31bd663439..09b761321a 100644 --- a/hw/intc/i8259_common.c +++ b/hw/intc/i8259_common.c @@ -220,22 +220,19 @@ static void i8259_common_class_init(ObjectClass *klas= s, const void *data) ic->print_info =3D i8259_common_print_info; } =20 -static const TypeInfo i8259_common_type =3D { - .name =3D TYPE_I8259_COMMON, - .parent =3D TYPE_ISA_DEVICE, - .instance_size =3D sizeof(I8259CommonState), - .class_size =3D sizeof(I8259CommonClass), - .class_init =3D i8259_common_class_init, - .abstract =3D true, - .interfaces =3D (const InterfaceInfo[]) { - { TYPE_INTERRUPT_STATS_PROVIDER }, - { } +static const TypeInfo i8259_common_type_infos[] =3D { + { + .name =3D TYPE_I8259_COMMON, + .parent =3D TYPE_ISA_DEVICE, + .instance_size =3D sizeof(I8259CommonState), + .class_size =3D sizeof(I8259CommonClass), + .class_init =3D i8259_common_class_init, + .abstract =3D true, + .interfaces =3D (const InterfaceInfo[]) { + { TYPE_INTERRUPT_STATS_PROVIDER }, + { } + }, }, }; =20 -static void i8259_common_register_types(void) -{ - type_register_static(&i8259_common_type); -} - -type_init(i8259_common_register_types) +DEFINE_TYPES(i8259_common_type_infos) --=20 2.43.0 From nobody Fri Oct 23 14:31:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1792160527; cv=pass; d=zohomail.com; s=zohoarc; b=XpFi5A965F/KP/JXLn5EJrXQNnu2cUFDFtQDt0xQkNZ7Xk3inFvmi2nKo5nW9cs2y4F+OTR7mkqL6swb7AFG43lfwsy2YUP71gV0c1mlAKsHZUwpHNZF6M1wDcheeOkAFutHYpW5EEP7/jlPly58/E8gT3NcPsS1sQuHgMtiAjg= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792160527; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=4Zzg/I05mP5n7TY2uFK7TpWDkHes0ZRgUzLc2R50k64=; b=QkufvvaEkzIrCJ0VgYuwFTD9h4SGCq/KZZT/Bib3ngvxHK2dsN97TtP1kAoHXV61bXlUb8ZHSHeKLaBD2dmTc6Ic9AqYE6Zav3AaY2j4c+UAWs3QRqneTjyLGbVKAtZzBBIkJJj8zhCf+leqfycnNHxUD4pAULu2hpR29EHXZE0= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1792160527848943.9742048325569; Fri, 16 Oct 2026 07:22:07 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1452001.1666898 (Exim 4.92) (envelope-from ) id 1xHioj-0003yD-2f; Fri, 16 Oct 2026 14:21:53 +0000 Received: by outflank-mailman (output) from mailman id 1452001.1666898; Fri, 16 Oct 2026 14:21:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHioi-0003x0-RX; Fri, 16 Oct 2026 14:21:52 +0000 Received: by outflank-mailman (input) for mailman id 1452001; Fri, 16 Oct 2026 14:21:51 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHioh-0003Uo-6w for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 14:21:51 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1xHiog-00CcZL-JX for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 16:21:50 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6ad232f9-2eae-0a2a0a5409dd-0a2a450a9e84-16 for ; Fri, 16 Oct 2026 16:21:50 +0200 Received: from [148.163.155.12] (helo=mx0b-002c1b01.pphosted.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6ad232fd-f2d2-0a2a450a0019-94a39b0c0e6c-3 for ; Fri, 16 Oct 2026 16:21:50 +0200 Received: from pps.filterd (m0127844.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69GE5mti3125736; Fri, 16 Oct 2026 07:21:45 -0700 Received: from bl2pr02cu003.outbound.protection.outlook.com (mail-eastusazon11021092.outbound.protection.outlook.com [52.101.52.92]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 4haysxu3ct-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 16 Oct 2026 07:21:45 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by DSVPR02MB11424.namprd02.prod.outlook.com (2603:10b6:8:352::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.23; Fri, 16 Oct 2026 14:21:43 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%4]) with mapi id 15.21.0522.016; Fri, 16 Oct 2026 14:21:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=4Zzg/I05mP5n7TY2uFK7TpWDkHes0ZRgUzLc2R50k 64=; b=BsVABufdpTHxVBf1rZmKW1YXMoJ8A+fOCwwFZKC1fWCsVLEH5lFWo3zSr uVI9oD/pv1P1pTbN4azkjHP8wHFNi0PKUoTVr7ZyGw+LfxKhDHTYFdT9yKgCR0Qb smMRV5mdJ22n8p/MbjVvliuG9xJzeCdq3pXWaK2xnoc0CQGAYX5OIzzT7FDCn9NT G/vYYtuXVCPx29BjVAo8ULIU+OmOQO6eQJmRoVGZ1b8yI7aOWQ2htw4yk3Q9SR7S WqZ7WfxqPTS9ToDIX7cNN3+bldqPrB7grerlc0WwkvZAIESaTloVWznnanXAQzeh KA3/UYtgp7pc5RzRAmmn00NMSgzYg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YGHkxAcfccQJNVMIybVsJ9qBmZUuevjH/rO/7X8kRukR3GCa8MFwxAVSHzpSJ/uFKE5RVGShZVP7Dih+bWq0eDE2l145VxyP5EyHQ6OSHC+bhGfrkqruaIvNX6MX3UfjhgOf64TiVx/qmEBt+AijS5WReDC3lClA/cr5qM9RnlsfzzaMTY5hmm5WcJwzZBtG0BLfAYfqmweiquRbWlomxjC4GHw+5l9U1Y2Pn+3akTbmROAKhmvebR+iJwLI6kMbM0xf0SL6r9Msosf8N5aW4HGkHZ5IGrnpzKH6a+NyFJoSTKyY0Y5Th9ehl4crOQ2km/OgbOX01CcHokmPJvAcyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4Zzg/I05mP5n7TY2uFK7TpWDkHes0ZRgUzLc2R50k64=; b=ZeE+TUJukb9eiofgDg0MbFlhBF+MTGPPSn9uc6c/NrYoeQO5Vv+SrvQe7vYl5luoASWtrmkqs0aOHKe8rwe38MJVUnsodHOg9uuO0kgejjP+CCgkA5vyjM40VS2+7XH78UeYjYvWGeqDl4e675QXySXYqCyU1R/NWUqbkAQUp5P74BOspvnvRR/NvLmDy3uu3RbmbetT3XKabE8+ttx3dQk+egxFMpp0as5eQ7THQ4LuHkTE5SfHhdzqRts5qVTwNd6tFkj0XaNFOVLHOesrbBg6COOPX1tgKPfq4JC/FrkljBQx/6xsnFmTsNWtJSR6T41GC78ozqHYI+PWJRM5Aw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4Zzg/I05mP5n7TY2uFK7TpWDkHes0ZRgUzLc2R50k64=; b=OzvHEovqkXOOdQeBpT8uql2t+FxpSZ/wJUB9b51bMzVPHEOENsxjFBSbxjb6fEdtw3YKbLJPL7WEYm9Qor5wAOURDK5+iGY51t7M1rGAtTm3ztvMyiuXktqLDVdEzeS8o3pt9+jwsaR05bmMkPoSMVwq3CxbsMdZGKaAgdO/pJj/DIdLNseft9k2H1dShNa+Bkea0gcKbxfczKLJXHBcZrxoi+9bRFH8pJPM27wW5JmaWgFDsCJ9WcPHX5SiFa3useom/m0X+MX9MJqfT40lDDyyVRe4hZXVs7OsRzbIut2SCeoX7BxDbSFOlw7cA2glf4jkFxXoNU7U5oAfEYGfTg== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nutanix.com; From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH v2 16/27] i8259.c: convert to use DEFINE_TYPES() macro Date: Fri, 16 Oct 2026 15:19:22 +0100 Message-ID: <20261016142031.1204281-17-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016142031.1204281-1-mark.caveayland@nutanix.com> References: <20261016142031.1204281-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR05CA0090.namprd05.prod.outlook.com (2603:10b6:a03:332::35) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|DSVPR02MB11424:EE_ X-MS-Office365-Filtering-Correlation-Id: efe637f3-c11b-48f1-5e43-08df2b90cd7d x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|366016|376014|22082099003|10067099003|18002099003|261009223027099003|56012099006; X-Microsoft-Antispam-Message-Info: 0i/zb9aaJBmuKkcpNLFyiGWoOfUDVXPUrOFIbzYZt2sMlml1U6Mr/x+NpPAYzBz0LEMu37SKjv8eDVI0ET3NhsGHu6bOAuvG0blpIXnVJ89Zm4F8Fg8yyoFFkHv0mqQKjXXiW3haIY464eIK+asOdoBMlJbJLpoEVRVLth072c/Ck3gKQ9BQ3SGhTa3LI4r5hIxf2jPugC4JsksMwsddqsujiCHcljlDi5sK5Rh0mdldvs7YYbYfrEOnqKB16cvazd5raeWwuTSarpRKP2dBKKK7G2n5IZZIJp3XJ5685N1AM5/7OQg+HXk5zFxG3lRiVxTjy5Uy+5hR+oIbkpsFS9KNKavKXZ501iipjqfgbe441ql1Ol5KfkUo6gYIp0bG+UeTTdu6NmaZfyr4Gn4CiuL2sutksq8SBcGmmrNZHEUnlypJftUbnqJuntQ7k5kusP7Yh22cra75EhZPDyFyKrUITGlkej5FLg/T4cGPXyScZQx6caXViGnirs8nzBzf766F6M3eLGBsOBvnnpqoN+EVsO3N1iKYK8f01HJEOv9PBSSUTPK2ZFLxbfomsO59Z/wmgAQBbspIqjs8wwBt5GFX9lHH+YFH+MMzd/A9n0HDz3dCTx4rYgra2gsMLJ9BRdaDWXpKRSuXOie4Y1fcBUQNmq0OBw/OQlyYFLHHvNU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(366016)(376014)(22082099003)(10067099003)(18002099003)(261009223027099003)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9Bg9Zq4TypHhRQYyEWrusTDlAeOEeQuIGIqUaNPPRAIvLThaJn194ByGBVmA?= =?us-ascii?Q?dy395nPr04eUuZUEh3tM2U9WXtcUTZ2yQ/E+svAakmQfUl/Z/Mlu/ykzP/99?= =?us-ascii?Q?XWv2GtE0DyaVboeuPdXsK3h5jAaj2MxzynfmowlkFEjDOKkgE7b0tKBEhL8M?= =?us-ascii?Q?5RvieXjl8WWjAbGgNiMnaWc6uSuUqQG7R/93gqS+wdrvGSCbvrhR3BwEJXOc?= =?us-ascii?Q?DnIMFiQaMgQASvGI5TSSEWswcgy+kzFXVM2W3h+X5e3aCCLG6gxLyDwWvMaq?= =?us-ascii?Q?bF9OugF+HU3UyVQk9zhVANnSWZfxdK5XemUJ3EkDRmfvwehJ46rs6LTfkMiG?= =?us-ascii?Q?cv7B/D3vy0cUsU/hbnvm3nnJftUMpkMP08r0NGQTqQTWje0/vSpbMenYDhP2?= =?us-ascii?Q?Nn1/tA4zAdyPPg2/xP9WTIRZrGItvulk+TuhZQOecqeKZhAP4LR2hZ0/Pw9d?= =?us-ascii?Q?YWYDkc9fooKYlvT62pAceas4e5Rz9gl0FSUzlsr/G22zMXqg1Z8rGfO60CXV?= =?us-ascii?Q?/c/D5BAicsc+96CEBbJffBO8IOw51/4vczW3t2UM8E757130/R8IsW1pkuiT?= =?us-ascii?Q?sFczHcG70j+jZGMVSTmMJge/qYaC9L/9fDIPxGcMRMqbttaFKHAEuK69FPOL?= =?us-ascii?Q?Dc/muYcT0Yj5a9qrh0bLlZYOwEL/xbLsCg44ZqHXrNsE6GcQFjq3gjl824tL?= =?us-ascii?Q?kH3ujyHwWnRQSxyyPt4hBS7tObc80IQ3l9iFRRsBBFyKeJVcGeMO97G8ieeH?= =?us-ascii?Q?2eoo8jNGw5j2PrD8utSP68uhvZJ9A4t6Ae2EaDO5/R5EXlcQx0AoL6x0B0Hv?= =?us-ascii?Q?z9dsOue82dXCT2mhSGw47UACMxrQPXSbpTOLlTLMPavbsoyBGPIzU8mNKTeq?= =?us-ascii?Q?bbQqD3G+Pbl4Z8oYdaROAoRThaX62VD88EpuAbR6nYvVWQrUsjF4rY6JAB2l?= =?us-ascii?Q?/LumFVPgRIpv4ucxzSDRnBs46Fa22Uhx4ZyHe0uU49S24YaAcR7LQfQrgzyy?= =?us-ascii?Q?zh0G5YrSAsoWoe816rsA46gUXKM9fteaKe5nC3t58eWExrr5tiqXbR+NCJm9?= =?us-ascii?Q?H8CdhmQhdWKTq1wtXp8dVk/DD7hwRkppHfcWf7tvMgb2fX5TTxnh/zKWuvsB?= =?us-ascii?Q?cBKpjuMyWNssGeZOVrK3N/gswCs97DrA0IaAOyYqrR5sr/JGAoNxj8mkKDqe?= =?us-ascii?Q?y15AVGn4G6J4e6Ngp0Cn3LdyBpUwmr96sTWtgJxUmOy4xOyFpMNMHAS8PL86?= =?us-ascii?Q?sQ4AvyVKNZjmxNGF0ComDcjgGHehmBwABp/Cd4myUJlLoXdtG+fZ7D8oGd+g?= =?us-ascii?Q?guDEodb5qW5lNVJ3Fd6LS5SWL2L8kfAUFGR1TS4FEhyo6sX7R0Fz5R1Qx8Ux?= =?us-ascii?Q?rbxWCop7GfWrKBAxVbNyJdDj6UlL5dZN2MT1mZ+0G0s+9AXQlS0XgeMgok0E?= =?us-ascii?Q?AsRm4tPBj7+nGkT3W9hKxuZK5ML4MdNQt8d2zo0y3/+ev05cpm7fv8KGJisi?= =?us-ascii?Q?MlA2KLdt2S2ChHWzwAB1L7SZTUnqCC3z6/dBebXwEuhjcZ61G1pZsF+txrLX?= =?us-ascii?Q?8qegUKh+jOTRNIQf3+Lk5kUjIMxYuqYY1LZkMBVEenDsAwEdkK8YYYG+km0o?= =?us-ascii?Q?AYw7UPQUeOpaR9FHvGNy7RMqnS4jfQehJjoXDUiMXgDof86B6q8Vx4zCpbpH?= =?us-ascii?Q?DPUxdWfPxohqwlO2bv3afRZH9Ok7SNqVzQKZqae9Md/g4wboDMHXVYhT4ks7?= =?us-ascii?Q?HSf6JKaktfCkzW30AgPsdRKSGOCpQgg=3D?= X-Exchange-RoutingPolicyChecked: 5KpNv3oTcIuLKBsuiGXD64zFMHPSc+b6zExmRDe9I2kDiI8URLo0T+RagjBVWkO2D1FwoszGBac+oy0u+TwEVnSh+ojPHFFnBMynguVkzceDEV00kDlVM2O2uA0Wop2gpNSpw5WEjQ5FgIAt+wgyKMs63cySH+pqEB6oLGPC//29g9EgOONkt/zjz8ecWj0K7d37XIxIhx71+0OgWThR+eVXZdnW4GbwJoRrRZsUQTpwhOVhfAqi2y3Sswi3Wl4CKuWhyLAlc5IAX5CtEY6vW4GABSDx1bMD4U/jlAz42yNgdHXXaiP7B8MmhjzjboiY5NbWpsE9FjDQ31/Vm++u4A== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: efe637f3-c11b-48f1-5e43-08df2b90cd7d X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 14:21:43.3944 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: F0VcqJqdL0OWWtDDq8d6tc2fKoOghENF7Vs+hszPvquvKWQpaqyGX7AtoPjPDasjWFlVPGEijAkZk6QtRON2a6tqUeWrzb4qhn+O4GQwEDI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DSVPR02MB11424 X-Proofpoint-GUID: 33B_WShAIV_5Zv9_CbVnyWwaMnhRYB2e X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX+zZ8o0q5uZ/8 82xBdkohUZVRrGmj1ob0L5VTNpzB90P5ylh6U2G/pUjEv9OH+EQxvdibvpT+8mAdnbOP1SM+QKl +FZIb4abPPEVXYuGJyDLtOltu90pEvx/6JI3W0o11aY7vNVBWyZp6Tpwkz0mDTkwwLwRugAX38r kxSVXua9wc2ZyxFErSf7g3PjUqJGFMRxcB4edKmXNqy0I4p04DyL+aeAqBK+xAU5e4k1ewzgsGQ RsT9EqYmV/YHSXibedNFZtqzdnKevn1iC+64r2t2pcAT7YPunmB+Mx9vxI4FjF1aS9S/jot1wlt YgRkN6lGE1fXjaP6WtF1MBbSvRUZH26Y3wDSuiY0RctbiRXUKWGR2A92KKLEar2s/AiR6wkVM8d zSpPUCclio/jYzdM6pQBLdGtPrAo/L1QVjPP4wr2QxgukwYWnRZLbwkELfSW93xKw2yWZ0dVB27 8H/f8TWnnnljdM8Y3Ig== X-Proofpoint-ORIG-GUID: 33B_WShAIV_5Zv9_CbVnyWwaMnhRYB2e X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX5hjKLYPA5mDq 16OwMFVQYRyVB1mLtzBl9b7Xe7JM3qykKEcPs43eCkfbM2IUYMBAK49Q+dszP5jAcwkD1SBCY70 jkra3oZefUTtTQCRmBWZPShc+FgMBnU= X-Authority-Analysis: v=2.4 cv=C/x8WgP+ c=1 sm=1 tr=0 ts=6ad232f9 cx=c_pps a=LITHeb8NCZqLQJh3dVn19Q==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=660iZSQnnn4A:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=0LlEyIVc8U2lsR7dKhuH:22 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=lKrOaJ4ZLGcPJhkerdAA:9 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-16_02,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-4011c0/1792160510-5A3DCCFC-C3576772/0/0 X-purgate-type: clean X-purgate-size: 1193 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1792160530340158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell --- hw/intc/i8259.c | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index 4b34e5a649..e5fa0f2e5e 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -447,17 +447,14 @@ static void i8259_class_init(ObjectClass *klass, cons= t void *data) device_class_set_legacy_reset(dc, i8259_reset); } =20 -static const TypeInfo i8259_info =3D { - .name =3D TYPE_I8259, - .instance_size =3D sizeof(I8259State), - .parent =3D TYPE_I8259_COMMON, - .class_init =3D i8259_class_init, - .class_size =3D sizeof(I8259Class), +static const TypeInfo i8259_type_infos[] =3D { + { + .name =3D TYPE_I8259, + .instance_size =3D sizeof(I8259State), + .parent =3D TYPE_I8259_COMMON, + .class_init =3D i8259_class_init, + .class_size =3D sizeof(I8259Class), + }, }; =20 -static void i8259_register_types(void) -{ - type_register_static(&i8259_info); -} - -type_init(i8259_register_types) +DEFINE_TYPES(i8259_type_infos) --=20 2.43.0 From nobody Fri Oct 23 14:31:10 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1792160588; cv=pass; d=zohomail.com; s=zohoarc; b=G1T8S0+Pev0SZVtr++jGE7kVHAmwHWA+tfxLX1Z4V4tJw8bgrxcxBQj9TZCti5wdy7C0hP7ELHq4QQnon4PZoQWI5KgDjx5/tY3O0bzXtvWsCHykHamRWPAv664nPL5k8qhdGeES6pNLYOmyYTurBJYhrAe2PnveNhF9IcolFCM= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792160588; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=YBENO+AVPrr9uTUjU0EffDFLvrFbeW1XWzcjaPVFV10=; b=HV43coHpGdt9GyuACc01dRv/RtRg3HcG5C9piJ9dKZVpU3Dzm8EPL7PcipNDuR/iGboiaiEfLbv762HRHM7bXYJuCwF7xc+MHn4AI/cTx+uDY8UsmUSMx+SMXOxgqDFaZSQzUPbq1LI0hxSXD7n8mxnATY+7Jus8ZbDBBAK9YTU= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1792160588087714.5805189003513; Fri, 16 Oct 2026 07:23:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xHipi-0003VR-R4; Fri, 16 Oct 2026 10:22:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xHip3-00030g-Fq for qemu-devel@nongnu.org; Fri, 16 Oct 2026 10:22:15 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xHip0-0006kK-KM for qemu-devel@nongnu.org; Fri, 16 Oct 2026 10:22:12 -0400 Received: from pps.filterd (m0127840.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69GE5JgU3050717; Fri, 16 Oct 2026 07:21:48 -0700 Received: from bl2pr02cu003.outbound.protection.outlook.com (mail-eastusazon11021076.outbound.protection.outlook.com [52.101.52.76]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4hb7t19qsb-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 16 Oct 2026 07:21:48 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by DSVPR02MB11424.namprd02.prod.outlook.com (2603:10b6:8:352::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.23; Fri, 16 Oct 2026 14:21:47 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%4]) with mapi id 15.21.0522.016; Fri, 16 Oct 2026 14:21:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=YBENO+AVPrr9uTUjU0EffDFLvrFbeW1XWzcjaPVFV 10=; b=TSIhQLVFGwj6fbaA2GdfaEKLqGVgRqEdQYGxp300ggbHy7PcJNF36ALIO 8Kd4PAh6T4R22BMy0DQ6GNKbNLDhUZ+CypbjVhr+L0Wp5qVfcCApA4gkiQn03HxT MTS3fjLQoBQlDVT0rCxL2p2ti8a2BHgzXic4+R12AmOJQzY7EaovPwCu0FQ/KDlx ysNAAxAjGMtSIJoc7SNXJxW3h2sszQDnfXe0MLJ0c128YVl7hOJqrNY7d2LM7yCJ i5XqjVJEonWVhoUKs8XZ0QeTGbq7gtmFnMEU5yyRxQCDCmnolWWtNUoeOKLRUCPw DSI4pkDBjrPpn3acu3Xd0ijLaLtmw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iMHEqxa+8VNhEJCJ3Vu+Q1OpgfTz2olpN3De7dgGD9ewTakFPJYJm1ocRfPK9tiFB4cQpjnol0T5GBGSPHtWAJMPHSzup6TPyuTnOj2Dbds1tsW2lIxiBYP30GXhBcksu2vm7FvrBoVZ+4tfggz35AKaCqyej9in3VWnhIgeQxJrUECa8WTbPcuoSbGaN9DbM/B0pbyDNP5YO82bx6kVvF00x3sJ///c8hQQU9pLYWKERxyw/e82/xX5XV2qux/0hACUOIAUgSXpc9tjnhUPHIOvlge5TwZnAiLLP4hM1n48j0qiUVpd8kH+2Cv6FJqR7pp/nYkC0Kx8eL37biAyMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YBENO+AVPrr9uTUjU0EffDFLvrFbeW1XWzcjaPVFV10=; b=BglMhNcHuYCZCe0SsbE+KVm0/E2mhQRza/YnYsV3adpIHnd1YG3fo4YomGR7SR5zTr+a+fHnAVaKXuRby1nDjEpT2+VFZHArVZ5VDDJxGTVkpxsEZeBNhWkzW9UpD+hzlwGM7ut1Srq09noWGPhZjDj3YtF5dTm2n4tnLsDDLTeefFxQ+7PtaciRvyL1m+s5IgaqlBgP1ji0U1xLVIWJNqDxPcgZI8WWJu26WSntkLeyaFiuN/9KiUvKRZA/QLsiSfkuD+HjVSV46NwBOEMJlide5WtRPK+zJ6E9OARIs+bJJUh8vM9vpxtiGEs2r4xGUZBmM9o0iZ863ZINETvKgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YBENO+AVPrr9uTUjU0EffDFLvrFbeW1XWzcjaPVFV10=; b=y0yc5k77mP1IFuLQhsLyjjrdwnjEpScLgla58rQL3fEV4pdKCVnyzAq9IntiqCTBs5zFLfhp5KJJHwThmSCswz4DPsFZTSxrD8MRGolYzDdfOaMDujvGMMwmhHc2MHE35KSiQ98u18KLCzeyCAWchAHQMC0tnUSHtEUne4v+4nVBLZwMp9lA3HGT7j9FV7JwqkBXrb7B9Il035dD+ETxj7uI5bOirF5lqxrcrumzHIhrIM09A/ZvHH+cWci0vAyUbhhHdrFN8TdIHle9OQ90kdW2HFBXisrHaYtavGdWEfl/y/Clp6tq8v32j/0api3YBj7BLjcT8uSovAw1zaYr5A== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nutanix.com; From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH v2 17/27] kvm/i8259.c: convert to use DEFINE_TYPES() macro Date: Fri, 16 Oct 2026 15:19:23 +0100 Message-ID: <20261016142031.1204281-18-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016142031.1204281-1-mark.caveayland@nutanix.com> References: <20261016142031.1204281-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BY3PR05CA0015.namprd05.prod.outlook.com (2603:10b6:a03:254::20) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|DSVPR02MB11424:EE_ X-MS-Office365-Filtering-Correlation-Id: e2ffdc3f-0a42-4cbf-f03a-08df2b90cfc8 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|23010399003|1800799024|366016|376014|22082099003|10067099003|18002099003|261009223027099003|56012099006; X-Microsoft-Antispam-Message-Info: ja5sO/VtfoyKEJpIDMNve6lZX4Osdl2tpjOhCf8e+pGPrwdsONADQ5148himFqhrYyPUgMhb5dMCKUI6zKXghrUNIwrxG6ZAxHp5+WuDgRYGfuIu8HlMO2lBQs6szRhYDl+l08iiWcpV8EBGhcXek8ARZLC+rivDOdktQh/dsE3KgtqPLegEIlsejdxckoeL5BpllqzPYQRNAx54OOyXysIW5zoEGIorTE1ydOClO9Wv52uemDBneFz2c13Ak2f7fZg4Oq0NEItpHWiBLQ8h95Swz9oJ1YoL2lCWtvBgwb4M5Npgbao8ve8bPoxu+fHJKxcseLxZKrrjfrBueYxH6y9sKv8BCgwmrXW2J28yffkGDVsqrBk5BDmMOyrwsRclDi8fVC2N57GDXW722evDoeiTdcnmgX3hJmQqowR4AJJQv+4fVb3mY1yR9dBbYLUAK1zxxklx8/W6nK6fvl4wLZUn1nigNIT8prDFwIs5g4Mja/VmkCyT/nOdZ3P53udeiltXFFmLkD6F822SBjh7U2Mlmntej7XFt/Cad9gR92SB3tke+zsKUbCBJsEsA4bw+ML/0QoCtqn/TYFGml3+1z9r4NUMJFtNAaRYd7Y3uTn/9r9YCxQ+1Vg8KdtOW3aX+rkkSlk5yYn+JNzXyB4NvMBxwvloQt5Ix+THxQxvsSM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(1800799024)(366016)(376014)(22082099003)(10067099003)(18002099003)(261009223027099003)(56012099006); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ydPtBzWaeJIqLY9DLlFLnielkCW67P+MlMaSU7uWuNl4YctqctVQyZyAueMM?= =?us-ascii?Q?SN2kYgOopkt29yeBiZCd0QYh+0LvvK2zoO1fJM0Lq1E/CLmYzQvBkpq56SOP?= =?us-ascii?Q?rljBYWPy6GiXlBANRrARHou0Xw8rD+pDo/aYf5ld7x5hAWucpMLP1qQ1yq6/?= =?us-ascii?Q?sBSgQ+QOpx2Pxzy+T6f7XoIBsRR7SCuR5uCPwoVD6awc6F6I4Ahh8S89K9Q+?= =?us-ascii?Q?mkZlqGJStSIrRxJi1Bv6rwACEN4jIiXJSp7sroA1SteGw0Odm/h1/wAMEPv6?= =?us-ascii?Q?NHyNERchJAbLxvXklnrzKQmgBgze+0hv+bB1MlL03zaQCW0NVACQeL5DMN4T?= =?us-ascii?Q?cUxcDahnpqM5CsDvG7wnjNR/dOfhYS9wbViBgz2F/XaCSdlH9X5DA2LuQgZl?= =?us-ascii?Q?EWJEslN+JN02xpvSVTAmiP29LpGc3Em5r8OAaQoXQ3rASBdDSOHreYHg08E/?= =?us-ascii?Q?MFDBpHySTQeVY2qc1/1QAWxD6v1ZNClOsb5oJsL3kb9y0ktIwf/F7jrpav1X?= =?us-ascii?Q?Id2CGZPqvuGJlnAS/9P9oDcyBkCdIce3Y4TXBy0xXIv6eYYzlDz2te6um/sI?= =?us-ascii?Q?k7E5b8lKZfiQiUZIc2K8oenCUPDIfba+aUQOdt6lBW2WS1wB79vpxHKkpnEi?= =?us-ascii?Q?ZlYZjzKyyqQeIKGl9eXXIIp8kDuvuAsQ2maMs8WG0cDwZu94Q4NnMWO8VwcB?= =?us-ascii?Q?fyD3hJSrHJOFX2X9aackhkbJMYxlAbSr0z5Ho6A/0hGbcTcsGc8VOrHGv4mP?= =?us-ascii?Q?FDwbKRbAKN584Uk45ckPPtSQ2oDNblBNaxFwc2HBcpIgDY2bMdZL2H2G/hvt?= =?us-ascii?Q?hsVsb2/oVE+4LairN1kDroAHpFHXYVEQ3xCcPWwiC+bA+zSis6+0URvar7Y1?= =?us-ascii?Q?wwm8LbOTrn+oTW0gh2xTChUD7o0+Y7cScbXt8hr6bHuWq4Ae40uJGLBI8BXw?= =?us-ascii?Q?PDC/h00Puh0lgxy1WBvMCsAZ3mY7bjc/TUh8J0Fe89wBDWnxbUqivns1/URn?= =?us-ascii?Q?6o+mATT3LH3E6ocP083yfibfiNKtFZEz73OzSWHImu2luBFgo2HPDs0NE/eM?= =?us-ascii?Q?Ysweho1B1yOzzUGM92EfjlcLexgw8noEEBO6xUNdS0/OCYfl90xP2f1eDph8?= =?us-ascii?Q?Y+vDGSHiGHLbZlIzsOG8CVxCoeDhoWSFq83pZsvg1C7rNcY2/wLLBdeedKjO?= =?us-ascii?Q?hg/MBRFJuDJPEJUwemMTiE+GUtMnMnKPyHM0N+C7RqeLZCCHCrGH7KOVLiUV?= =?us-ascii?Q?C7rXIRBw/qIMf+0NhOUV/o20RDV1heZn0r1aC4YF9BFO+LRHGtjfAu2LLBue?= =?us-ascii?Q?m2yIsF9EpTWwrwPBqRIa+dxfa7pCUVamwJkFbn/w3XHbF+O8ItDWk6fStD6p?= =?us-ascii?Q?aNDCvNB0YFk9WxF7lZBiRFfEJgA4beUpYbOZOYxXVd8sF7KfWF5TGfGsfQX5?= =?us-ascii?Q?xs6u6y/fiETVM3Fkdgi/1MqVGp2zbY+UBwxn5N3hiDVTW583yvvzJ5m6nQx5?= =?us-ascii?Q?WZ3K8U0uMVGVTPLOHTN4la+R3rCtz430DjOmjLBmRjgRw7XAwSsKGrwWYxCk?= =?us-ascii?Q?5Bm8Fo1Q8KK9fdxCdXP+JlrrHN8Xmjegte6MOO1iwY3JB0mXd85pQvI/jIQQ?= =?us-ascii?Q?TN1tv4w902aGNieprhCoAAAeE8jULMZZj/rsB7gisbnd3Y9y34vPh/2pUNrc?= =?us-ascii?Q?OpjrIkb9FIosOFqVmnXeeEYicWbsqKDiOpABzKbKCNKBcfZHTJsKKTwOlq0u?= =?us-ascii?Q?kO0bUi6XYLSIBsGyKiJ9mv7kLMJmNFQ=3D?= X-Exchange-RoutingPolicyChecked: oW95PpnVf1v7XGjQKtzJoiTtd/v+Gocblzb+QbMm7iZACz1vfgXD4U79ylsMJf6OilP6qyARQsFNTPTPWsMzGKZb6pgvhd/lQ+VshH2AuWTYkaFwjaT8j9X6F9lHRc4uQNbnlmJMOhu/q9N70seexaMH86iamo49BD4jcTzute+LJnQE6Fur50vtBGG58pRSRt/r8ZWAZ0Ic8MYC+YplqwJgTN/umTNRaQEH50ECtC5MScRgB/SPFGML3q7JpubE1o6/zt69/3LlT+yMzlJBhHf1YRgRCuqZmOGRDaPDlIzEJv2qElxUuSS44ObnkC/ahgCj0sfMFrFysjeQeseaMQ== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2ffdc3f-0a42-4cbf-f03a-08df2b90cfc8 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 14:21:47.2107 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vHckLfFReYsR/AF3V+lTmUedJhJT1JHx9nCIE5by1zI2ENTuRFo8+lwIvmgCKg6he5dutnSmXOsdUrVdgBjbA4nzgIT2FzL9wUg28z2MUFg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DSVPR02MB11424 X-Authority-Analysis: v=2.4 cv=LsYHWXdc c=1 sm=1 tr=0 ts=6ad232fc cx=c_pps a=iImJYxtVBKilH24NLj+lVw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=660iZSQnnn4A:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=_-M8LpHI31CeLmyZm6wg:22 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=CQnoaSmAlUSJywai4vEA:9 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX37bWWlROPu1x 4/kdC/xVyoUZXpB47kZQY4ujHZC9XdOY6IL9xs/rRJi2DinCUshhYa2zMWz7TsZLoQ9IKsXhiVN oePokq6KHoVdyYXZEK6Hu5BJ5dz35Oo= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX5//kecltZS4q Jl7T8Hocxhh1fQd0p/HLMSDlFSdqCEJM23MwFT/9fZE40DL6tQ3j+uRoStkCek4VoCsoR9DN4yo DlQeeiALDLlAtC5HNGlGnflXSa09QaDiEFZDroni5ygQmSMj4ZJKom4kQmI/fpy2uZpXwwlHrBj 3826A5/my23i/CdWYGV2wPAigpIQvL6eE5yANFMrmQ5YcoHB+Rhxh61F20MOceI1CpjDEalqNmd mgBreGk6OYXM51rDcpxGMTnAGKmQlr3T4qXv3+5oLxUhTplFYp5/CKg35fPH1OPmKDbTTVmbPuY W9RpsViTmvDpTllxyhjfn3WQz5Y6OBfOdzbNZDuUiIGvo0+MhSKfmGIHPQGjAyPYVLZ/A8XmPG+ ZVwJr1I5FOzqzhxuuEGN3aV//gP5L64Ir5ivwd9WZmlm0sMoTKBr2lpTdbSYptAQ9LlFjF/4ejJ Ucs8ttds2t1VkEkpCzw== X-Proofpoint-ORIG-GUID: IGZ_pgtczq3NalqMEMKPUJZ7An8LRvae X-Proofpoint-GUID: IGZ_pgtczq3NalqMEMKPUJZ7An8LRvae X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-16_02,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.24, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1792160589309158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell --- hw/i386/kvm/i8259.c | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/hw/i386/kvm/i8259.c b/hw/i386/kvm/i8259.c index 952f58be11..9ee23b5695 100644 --- a/hw/i386/kvm/i8259.c +++ b/hw/i386/kvm/i8259.c @@ -154,17 +154,14 @@ static void kvm_i8259_class_init(ObjectClass *klass, = const void *data) k->post_load =3D kvm_i8259_put; } =20 -static const TypeInfo kvm_i8259_info =3D { - .name =3D TYPE_KVM_I8259, - .parent =3D TYPE_I8259_COMMON, - .instance_size =3D sizeof(KVMI8259State), - .class_init =3D kvm_i8259_class_init, - .class_size =3D sizeof(KVMI8259Class), +static const TypeInfo kvm_i8259_type_infos[] =3D { + { + .name =3D TYPE_KVM_I8259, + .parent =3D TYPE_I8259_COMMON, + .instance_size =3D sizeof(KVMI8259State), + .class_init =3D kvm_i8259_class_init, + .class_size =3D sizeof(KVMI8259Class), + }, }; =20 -static void kvm_i8259_register_types(void) -{ - type_register_static(&kvm_i8259_info); -} - -type_init(kvm_i8259_register_types) +DEFINE_TYPES(kvm_i8259_type_infos) --=20 2.43.0 From nobody Fri Oct 23 14:31:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1792160538; cv=pass; d=zohomail.com; s=zohoarc; b=EEj+HjBRYNqZJoVPEPYBuH3TnvPRbdhaZ4r5/JyuabjzO8rV+xH9UKA29i1c2bZPti1hf4rkFScCmDHf7fMus6U9k+nkZKBne3LE0jcGt6bGqEHGwasVJ5wtN459ays891o9cfxiMQ5JjEZ8GXWwsbrqBxNmLBnegLnNHSlb4zI= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792160538; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Gc5sSKfDVB8R4X6fBb7T55UzLTmJFAUuEnah/iYPLcw=; b=IA/FvE7oRZMnCN1K/zQo8grkamUXFYkCmtvRmkxQIDPJjZZnPGzH3Q06Zllj8huzVoFK4RBJPH1Pnjxqfv5qBqDFOBLiZlWEKVtvawORTKnzn2bu48s0iGwo0fs98rzDsHEX4gvhuWHEJqxnKFMukEmqaSE265mnjy1klhjvmps= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1792160538979268.8264334061631; Fri, 16 Oct 2026 07:22:18 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1452008.1666938 (Exim 4.92) (envelope-from ) id 1xHior-0005Md-CJ; Fri, 16 Oct 2026 14:22:01 +0000 Received: by outflank-mailman (output) from mailman id 1452008.1666938; Fri, 16 Oct 2026 14:22:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHior-0005LN-6b; Fri, 16 Oct 2026 14:22:01 +0000 Received: by outflank-mailman (input) for mailman id 1452008; Fri, 16 Oct 2026 14:22:00 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHiop-00057H-V2 for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 14:22:00 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1xHiop-008oQe-BN for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 16:21:59 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6ad232fd-8faa-0a2a0a5109dd-0a2a4504a998-30 for ; Fri, 16 Oct 2026 16:21:59 +0200 Received: from [148.163.151.68] (helo=mx0a-002c1b01.pphosted.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6ad23305-b57f-0a2a45040019-94a39744ac08-3 for ; Fri, 16 Oct 2026 16:21:58 +0200 Received: from pps.filterd (m0127840.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69GE5JgV3050717; Fri, 16 Oct 2026 07:21:52 -0700 Received: from ph0pr06cu001.outbound.protection.outlook.com (mail-westus3azon11021114.outbound.protection.outlook.com [40.107.208.114]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4hb7t19qsm-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 16 Oct 2026 07:21:52 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by DSVPR02MB11424.namprd02.prod.outlook.com (2603:10b6:8:352::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.23; Fri, 16 Oct 2026 14:21:51 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%4]) with mapi id 15.21.0522.016; Fri, 16 Oct 2026 14:21:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=Gc5sSKfDVB8R4X6fBb7T55UzLTmJFAUuEnah/iYPL cw=; b=MB37VXHSoRoJROd2319RBofU8v8zOrE5cMwgjJZY4Sy0HrtClaheOvOW6 fHR4TdgWeAWUKAowxSfzDYDI8coEyvwrUgUhIia87VLObKI/3ijLfqPGPMRyW8Ag tMDSiOqRisj9snTvBWoWzEFP0D0MdsuZk8MzsBLv1qTQ7ZBiSu8ZKbTRMbCGJcdy sZFF66n0Jhgv8Nf/zng1XVsFW4ptRCFnU+9vO8RxyLhiuHITxgSWvMt3ddM35ola iGM5kwnk6VfuZu/Ws6Trpc7HlUQxoNM1uu5/gjoL7z0foYF4zsI3/3DvMFj7oX+Y 7ElCv9YnZ9pTJ1vetewP0q9LpSApw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HjLCjhB8bNps6sVgZELr1AUFpd+BaJ0RTVsvemYt3Irw/W2FyAzpHi/Fm5u2bJotK7LejMLXjHZtuodoUFBU1CnjpT5jsnqpQkrgO6MIsRbhnK/Z6dsbR46mdTtRCU1SFEn/townh1omYfLkUFi5WcEEAui8Fxjyh29vsveGan3d2TXHy5EZSlblmidmSZDoVpizckjZvDqkJR+J24EGPS+q8kIj9FzAJpKIudX5q096xUCGS3xHkaEmjpzATBgqewxFcp78GeGdNR9WFOUZLl8ORdrV/hCxX6M3dEwq17VlPLZWbK9UBKhQGwHz7x+R4FA5Gu7SnbpvduOcf2aW5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gc5sSKfDVB8R4X6fBb7T55UzLTmJFAUuEnah/iYPLcw=; b=MGryjAJHXdp4lyl+bKkbJEgQfvsS6+mjwvlNCKLNg7Nm54Qb5m+4p05AQElcaoK1zd8Xt2qcxnbajHu9YsrVbCGu73nfuUtP74JHrAKECnPt1cx618BE26nAXsQWVhcIB+O5g0efrsaJVCSyAnce3liTtS1NZbTf0RHKXIvf4vkAYesaDeGUE7XEECR4JdAQlWGObjTW+KOfgkLox3KwLyc2m1czSjunn0R1D1/aSyfdPJ6n9MpBnOrabdl9gj3Wu36o8RjIJ5Z3wwB7z7J2vh+gIDvvO/VODQWhDiO/Yg3oj3gQ/1j9JMQrHXd2nXHCu+euRhE+fVEt/HKR3jfgcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gc5sSKfDVB8R4X6fBb7T55UzLTmJFAUuEnah/iYPLcw=; b=t0TsMdOi3CFTPgargNj+Tt5Y8p52wGLrlWB91qpoF7AL3wVSm2dOswd4hr4k7fjMnNaMmTTpOLkppoOqdNzczHTsIrf1KQqqEm6h1vM2C5oYvDqOENs8Awt3IyEu0gVr6+yB58sdaihh1JFs6+VCXmXx3+JJLIH6yWWMKLCOTq2gHWiy42DbXaMvfd3C1933NJ3rPDiwlnlcMmQ4khTWZdrAHTTxTNzxJyYFmZMgx7xovZ1rToyd0aYHO/junK9jDyfa8eVBsUmeIlAcMCZxl94uWL4wrWjyU2xj+R29pIZpW6MzNE5zyOosFk0KXKsQdcMfT5htgsuwENzgZQRbFQ== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nutanix.com; From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH v2 18/27] i8259.c: introduce TYPE_I8259_PIC device Date: Fri, 16 Oct 2026 15:19:24 +0100 Message-ID: <20261016142031.1204281-19-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016142031.1204281-1-mark.caveayland@nutanix.com> References: <20261016142031.1204281-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR05CA0193.namprd05.prod.outlook.com (2603:10b6:a03:330::18) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|DSVPR02MB11424:EE_ X-MS-Office365-Filtering-Correlation-Id: 40dd7927-25c3-46ec-06f1-08df2b90d20c x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|366016|376014|22082099003|10067099003|18002099003|261009223027099003|56012099006; X-Microsoft-Antispam-Message-Info: 2im+Io+AjEikp8s9b09Eo20ptNbv2qAgRH8JvxbDddfqg+8T1gwyGmbkpd/afin+6hb9EhhAPqVixdWS9cP9Ih2tWY2o9DXXfqAGiw1qiQoxeygfUmusNTxLFYZU8SjdYEwZp2y5cXY1nMcRgvPuG1Ax4HXZlbLAX1e0LDlwnGwwWGeNfg9mmxMIN886khgsiWk9HtAj624hRodijrcqgCgtYN+yNH70Ac7+ADlKmFr7thR9zmVPLZhhX1iqKeW2qVtBalK/9BTJ49fYTnYZzfhzMUCspyrmNgbQSJPoFkcKD8Fxl1hyuQYnvlWNUzUUpZ8wqlKVCIA0IAZBzCzGWHgZ/dmuRiboJVRKf1eL+1NR/WhT8AXCw5V7FWzRHno5kEGtn1ZEpfgfepj62WA2ScMj5P8SxMTKApYPmBRKA6XL4fR2nX9j6adWiWQYpq36P4Z3h0tHhfbpKobnHzGYpg37azL6PfSyLAuEJbKbhpLIBhpv9RiXhAuDmqMtguKq89aB2TCCnAfJm1n+mV1MImniknKP6cwaUq959AxTDeu4n4oFyblzUoOH1SNnLdf06aJAITeErSF8DBTD96e+beGr9jWQpsoxdbaPPkDnwTtQsxg5obODAtJpSHeZDCMJym4vmRDu4XMccKqxXfopNrdgZ4lntEFDZuc8LdKGvj0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(366016)(376014)(22082099003)(10067099003)(18002099003)(261009223027099003)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?axns75zRaWZ7FU1rqabJ6Hd1iaxIv1f6aE3R5godDc0cObanGxaHbmSmrqnT?= =?us-ascii?Q?nyKeb6RMcV1XWcG0p1WdJ6cMrE5FFmZ6jzFEYQK1zdUI3ryurkgbMioFCgYw?= =?us-ascii?Q?hVTJm3jPJAZTXQiigSv1aHloS0lJg67F2WbKqX4BS8kzKvhbGOnqjwtwY1VW?= =?us-ascii?Q?EWD3MG+K1UeDIO2u+jg0kk//OarQomeeb+0loHCQ61Dyx1s9zp8qB03z+TjX?= =?us-ascii?Q?W/kYLy2dexNOCFh2gL4brgGW9XTNkj3/tv00tVig2n8C3dmyKNjFATYI2Q9m?= =?us-ascii?Q?1WEFtHxSsoik+jdT8my6mYbQ0l5XXfnQkJEDbdyoweqnWT4f95BcODstAU4J?= =?us-ascii?Q?5sQYONQDYSzwkxTX6v19xl5WEWApd2/FjDqBdL8/MVv/nSdJQiDgeHZ0z3xx?= =?us-ascii?Q?OMCMKPm8teX5BYNhlWZ5SPHQ4h+hj9IBdRxc8ZdRUkWoss/OnS2uv+u9H5ax?= =?us-ascii?Q?nLstFK7fXLbEBTVlNoddcQMDIZujBkBZO7/aEN+cNGiqz0zVWGw4/BhlgQbW?= =?us-ascii?Q?3wBbBwPADGUPuCz+FPUqfltabur4EELsCUagG/Z0+IsSRimKKKurJNtvzhmZ?= =?us-ascii?Q?UwLPEhEX674y6DsJAiaS6hZL5GjtSSSis9x2KodBKY546AIzQuLwzOW8cFWi?= =?us-ascii?Q?bXZZRI52OpaEnX4JlFzrQjjSmgoL591erE0ZzAArV/kCZKBHuOJJnBQkdysD?= =?us-ascii?Q?I5fg4vPDcAt/dIK+O6Y61SyjjEog778ZYHz4qK0YvM/6yyAQVUOaohMxxRMI?= =?us-ascii?Q?7RF/kJN+1UY/ayFyfaBR12lGxdJWbUnEQ+cSMj6JBM0lxL/u9BZhpdFMnaNM?= =?us-ascii?Q?hOPNm8CdrU2CIXMN1SegvEcokneV1n0wtLSxRRY8Gfi1RDRAFLXdAz/m6rBy?= =?us-ascii?Q?CNluauQ8l4ejuWFzhJtnrUGNRJKKaAl+MVLmd8rx3cpCT+NOw76g94zm43tx?= =?us-ascii?Q?zkCW4n4ITF7mvi8NdmUqcFnD1PJEA+yk+0vUiuSGoSpqx5EDsjGJKS4/n4M0?= =?us-ascii?Q?8ByCQYLtw+/Mn1mdBI1ROFiDvm3U1axXilQC1sdV78W/SnjSNA20zaFWgvQa?= =?us-ascii?Q?lvBMgb1t93iZB3sZGIV5tpVp+lDvs61z/AkIEUOEAWKKOxvlxbn3XfkFvAZ3?= =?us-ascii?Q?zD25Eowml4Bfa5qir9yRsZ/+bYtyy1JC0RofULtikNhdpBgMmPTU+5gEABW7?= =?us-ascii?Q?VhmE5IGORSDO2z5JTfn2olW25tXzSd5uSGxBE+FVP2YqbQ5QuB0zNTxR5RP0?= =?us-ascii?Q?bAZvEw8fDm2phlf+EYTFkrP1HvJUnyvL12i4Ql98G1o9LPJYLha8jAeBHMYP?= =?us-ascii?Q?l16S6HEhZzQv9RoSjkSprWTN0WXBA8lvUOEqg8RL7G2noXHuTSqXQqyVGJ8t?= =?us-ascii?Q?Y8QSt4+Xs6pmjp73BTvcNb/kRWQbv77NLFWaISC6ewyF7TRn49CaJSIkWaDd?= =?us-ascii?Q?tBFc//lu7mmcgbIDLw9QK/VuUaBs2TXEJAUNChWYMxvYC1k8kVTIQMA5B1+a?= =?us-ascii?Q?1dM5Wp7HDTj8yAw5+jFV7x306LMeSK48l1EgC8jec4uAAlWSmIaP3en6L2lB?= =?us-ascii?Q?ytvjtpIbaP48zf0nuYwqL1fKWMnRCJCbi/LAZp4xoT19gs19U2T5KgTrvE7s?= =?us-ascii?Q?DtWFYH6PoHSRpqFa41PtZBI69sMTLfVY8tADnqG1q9JtpWkocO9+LMiyp56z?= =?us-ascii?Q?mMZ0fLGaAboZTs86yHGocyzHggoSXUUtgBxuc0zC0DpEQ3IhywM9qGefqCTQ?= =?us-ascii?Q?ZhR/mYaeVwTP39UB8VrXIbzohh+1JFQ=3D?= X-Exchange-RoutingPolicyChecked: ha6Jy6ySwPaCxYTcItYdET/PKPPJN36B5JRytduoMyP80Rp5+zFLscs3TV7gPrOA71OL1c8WkwD3c2/MsV8X7T4+fHnRkw+rl2HG43cOEOgInhLuyFpHNS4G5i6P02PX/zv2TVWhgMFH4SXA3Eb9pRSfuVIkWwIap5HPB8kWw4eMfHJg20Pwp/WdxA+IKFX4g6Zh4stCwOii19d84NP/x+tJG5GQ8rWvzEuITVxHteNLLC3XJOiGzFsdVIME/zyI7UKxirhVjc5gvVWCB0Omshdz0VidCuUHLcz5mh7c2mZwybELDYy1s+HfTUlytIH/+382jvxVBNixauwHUQTaLg== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 40dd7927-25c3-46ec-06f1-08df2b90d20c X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 14:21:51.4039 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2Y4pF2uzMMK8b4BBDOwiQ2skdB3JUmYjSbzKnmXobHoV9jSd6JfGbz++NdB4nvDalDBgvMuAK15XcLOiWohS2w3JOu8U50DKsrDkDqRS+PI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DSVPR02MB11424 X-Authority-Analysis: v=2.4 cv=LsYHWXdc c=1 sm=1 tr=0 ts=6ad23300 cx=c_pps a=rSpWrHmMTF20an4ACDPPuA==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=660iZSQnnn4A:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=_-M8LpHI31CeLmyZm6wg:22 a=64Cc0HZtAAAA:8 a=0XGB6JmbSUb4YdcodAIA:9 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX3saVKKzDr71g tTSSiRWbg83XTUgAdAAnDMMqi5UwRSmBX5orLsRmTr4CyimvFM2+nQYNFqJ1qYvOp6ASoQXhcmg BOqnrh+gRgj+UGNJC+1yOLpIiQt+LUQ= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX/sLF6PR5ve2p tF4OJ830tBWd4jKr4C0tH6TE008zsyAiXw+EnebTneSD79wk1vQstD7dQn5oWPxyzNbOWWJFSQo sdAyAyuL4XVbCtth+sXwhQsTD4Phhn/oTKq0lociE8NgUurvWWMVoD0EUl+/AljL8TbLsznyKe4 1DQyI1T6ibPDF8xjDIkHr+Ru8V6gyebrZmUXQujiuPI+B9XVlLHnU/hVeDl+36dF1IL2K15Sc9+ RI7OaD63Zc16JFEw2HIkPS0Faf8R9BOilXzy7LA9msZDyhvW/2SFQXHm1AwE71LukzAx87r5REr Yjlv8pksRu6U/I1tycSa9RJXZ9K4gsKahSDPmDkMtQm1pMt+wqo5Cg3IljlbI0XebWjjymqKmOx rT0s7sEcyevEU2asQUVxa7jPTVejZu8IFcHWWRDVmzg6BdodEuIruKD/Gy0wDGTJcJbK0OCuZNV m7L43nRA9TsEoPuhr0A== X-Proofpoint-ORIG-GUID: Ne3dkg9vzRNzUPw3NtFIhLSjvSZ1uqSW X-Proofpoint-GUID: Ne3dkg9vzRNzUPw3NtFIhLSjvSZ1uqSW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-16_02,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-ebf023/1792160519-524CBB50-1D879E95/0/0 X-purgate-type: clean X-purgate-size: 5678 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1792160540529158500 Content-Type: text/plain; charset="utf-8" This device represents a PIC for an x86 machine consisting of 2 cascaded i8= 259 devices wired accordingly. Signed-off-by: Mark Cave-Ayland --- hw/intc/i8259.c | 133 ++++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 118 insertions(+), 15 deletions(-) diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index e5fa0f2e5e..bfe01067b7 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -25,7 +25,9 @@ #include "qemu/osdep.h" #include "hw/intc/i8259.h" #include "hw/core/irq.h" +#include "hw/core/qdev-properties.h" #include "hw/isa/isa.h" +#include "qapi/error.h" #include "qemu/timer.h" #include "qemu/log.h" #include "hw/isa/i8259_internal.h" @@ -51,6 +53,22 @@ struct I8259Class { DeviceRealize parent_realize; }; =20 +#define TYPE_I8259_PIC "isa-i8259-pic" + +struct I8259PICState { + DeviceState parent_obj; + + qemu_irq pic_out_irq; + qemu_irq pass_irqs[ISA_NUM_IRQS]; + + ISABus *isabus; + IRQState i8259_primary_out_irq; + I8259State i8259[2]; +}; + +OBJECT_DECLARE_SIMPLE_TYPE(I8259PICState, I8259_PIC) + + #ifdef DEBUG_IRQ_LATENCY static int64_t irq_time[16]; #endif @@ -410,30 +428,24 @@ qemu_irq *i8259_init(ISABus *bus, qemu_irq parent_irq= _in) { qemu_irq *irq_set; DeviceState *dev; - ISADevice *isadev; + Object *pic_obj; int i; =20 irq_set =3D g_new0(qemu_irq, ISA_NUM_IRQS); =20 - isadev =3D i8259_init_chip(TYPE_I8259, bus, true); - dev =3D DEVICE(isadev); + dev =3D qdev_new(TYPE_I8259_PIC); + object_property_set_link(OBJECT(dev), "bus", OBJECT(bus), &error_fatal= ); + qdev_realize_and_unref(dev, NULL, &error_fatal); =20 qdev_connect_gpio_out(dev, 0, parent_irq_in); - for (i =3D 0 ; i < 8; i++) { + for (i =3D 0 ; i < ISA_NUM_IRQS; i++) { irq_set[i] =3D qdev_get_gpio_in(dev, i); } =20 - isa_pic =3D I8259(dev); - - isadev =3D i8259_init_chip(TYPE_I8259, bus, false); - dev =3D DEVICE(isadev); - - qdev_connect_gpio_out(dev, 0, irq_set[2]); - for (i =3D 0 ; i < 8; i++) { - irq_set[i + 8] =3D qdev_get_gpio_in(dev, i); - } - - slave_pic =3D I8259_COMMON(dev); + pic_obj =3D object_resolve_path_component(OBJECT(dev), "primary"); + isa_pic =3D I8259(pic_obj); + pic_obj =3D object_resolve_path_component(OBJECT(dev), "secondary"); + slave_pic =3D I8259_COMMON(pic_obj); =20 return irq_set; } @@ -447,6 +459,90 @@ static void i8259_class_init(ObjectClass *klass, const= void *data) device_class_set_legacy_reset(dc, i8259_reset); } =20 + +static void i8259_pic_set_irq(void *opaque, int n, int level) +{ + I8259PICState *s =3D opaque; + + qemu_set_irq(s->pass_irqs[n], level); +} + +static void i8259_primary_out_irq(void *opaque, int n, int level) +{ + I8259PICState *s =3D opaque; + + qemu_set_irq(s->pic_out_irq, level); +} + +static void i8259_pic_init(Object *obj) +{ + I8259PICState *s =3D I8259_PIC(obj); + + object_initialize_child(obj, "primary", &s->i8259[0], TYPE_I8259); + object_initialize_child(obj, "secondary", &s->i8259[1], TYPE_I8259); + + qemu_init_irq(&s->i8259_primary_out_irq, i8259_primary_out_irq, s, 1); + + qdev_init_gpio_in(DEVICE(obj), i8259_pic_set_irq, ISA_NUM_IRQS); + qdev_init_gpio_out(DEVICE(obj), &s->pic_out_irq, 1); +} + +static void i8259_pic_realize(DeviceState *dev, Error **errp) +{ + I8259PICState *s =3D I8259_PIC(dev); + DeviceState *pri_dev, *sec_dev; + int i; + + /* Primary */ + pri_dev =3D DEVICE(&s->i8259[0]); + qdev_prop_set_uint32(pri_dev, "iobase", 0x20); + qdev_prop_set_uint32(pri_dev, "elcr_addr", 0x4d0); + qdev_prop_set_uint8(pri_dev, "elcr_mask", 0xf8); + qdev_prop_set_bit(pri_dev, "master", 1); + if (!isa_realize_and_unref(ISA_DEVICE(pri_dev), s->isabus, errp)) { + return; + } + + for (i =3D 0; i < 8; i++) { + s->pass_irqs[i] =3D qdev_get_gpio_in(pri_dev, i); + } + + qdev_connect_gpio_out(pri_dev, 0, &s->i8259_primary_out_irq); + + /* Secondary */ + sec_dev =3D DEVICE(&s->i8259[1]); + qdev_prop_set_uint32(sec_dev, "iobase", 0xa0); + qdev_prop_set_uint32(sec_dev, "elcr_addr", 0x4d1); + qdev_prop_set_uint8(sec_dev, "elcr_mask", 0xde); + if (!isa_realize_and_unref(ISA_DEVICE(sec_dev), s->isabus, errp)) { + return; + } + + /* Wire up secondary cascade */ + qdev_connect_gpio_out(sec_dev, 0, s->pass_irqs[2]); + + for (i =3D 8; i < ISA_NUM_IRQS; i++) { + s->pass_irqs[i] =3D qdev_get_gpio_in(sec_dev, i - 8); + } +} + +static const Property i8259_pic_properties[] =3D { + DEFINE_PROP_LINK("bus", I8259PICState, isabus, TYPE_ISA_BUS, + ISABus *), +}; + +static void i8259_pic_class_init(ObjectClass *klass, const void *data) +{ + DeviceClass *dc =3D DEVICE_CLASS(klass); + + dc->realize =3D i8259_pic_realize; + device_class_set_props(dc, i8259_pic_properties); + /* + * Reason: must be wired to the ISA bus via the "bus" property + */ + dc->user_creatable =3D false; +} + static const TypeInfo i8259_type_infos[] =3D { { .name =3D TYPE_I8259, @@ -455,6 +551,13 @@ static const TypeInfo i8259_type_infos[] =3D { .class_init =3D i8259_class_init, .class_size =3D sizeof(I8259Class), }, + { + .name =3D TYPE_I8259_PIC, + .parent =3D TYPE_DEVICE, + .class_init =3D i8259_pic_class_init, + .instance_init =3D i8259_pic_init, + .instance_size =3D sizeof(I8259PICState), + }, }; =20 DEFINE_TYPES(i8259_type_infos) --=20 2.43.0 From nobody Fri Oct 23 14:31:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1792160554; cv=pass; d=zohomail.com; s=zohoarc; b=bSmaS05unO8xhgzS+ZW/+yuURFjyJvMUCddmOL9dqLXBrGEspPfZXpx96MGj2ha9cYHQFQuEJR08iA6iZiIBN/M1Xz3tUjJSaAGQ7ANW/yF6cL17nHTNXHJQ/gJJ13iO4+o/VMQmLiUYn2LsTxa6YmaLKNHBA5fhf4cdrIYSX6o= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792160554; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=zJLaHMP800ZLe/QLftrXKhy1QBGER7Qp7toLitf2O64=; b=L9/D2voEa0l3DebIfkAo6CWVmmJVZ28CX81xXpASNemPHKUY4ZklFh3ySNnuC8wJfyR4Qq+o7wBs5s1r0ENEJ7WJcR3rrAwTsX+/dg9BmVEEktQOkwGEWuqqdB/cJY3mg0Gz+J8bDoyH6sCI7DyMGhEfeK/rzyXP/a/UuyikX78= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1792160554707779.4678795696108; Fri, 16 Oct 2026 07:22:34 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1452024.1666974 (Exim 4.92) (envelope-from ) id 1xHip9-0007Ev-Q2; Fri, 16 Oct 2026 14:22:19 +0000 Received: by outflank-mailman (output) from mailman id 1452024.1666974; Fri, 16 Oct 2026 14:22:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHip9-0007Ei-Lz; Fri, 16 Oct 2026 14:22:19 +0000 Received: by outflank-mailman (input) for mailman id 1452024; Fri, 16 Oct 2026 14:22:18 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHip8-00074V-AX for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 14:22:18 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1xHip7-00CcdC-NI for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 16:22:17 +0200 Received: from [10.42.69.2] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6ad23311-2eae-0a2a0a5409dd-0a2a45028bac-12 for ; Fri, 16 Oct 2026 16:22:17 +0200 Received: from [148.163.151.68] (helo=mx0a-002c1b01.pphosted.com) by tlsNG-720697.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6ad23317-6ca4-0a2a45020019-94a39744a8d4-3 for ; Fri, 16 Oct 2026 16:22:17 +0200 Received: from pps.filterd (m0127838.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69GE5N4R3502701; Fri, 16 Oct 2026 07:21:56 -0700 Received: from ch1pr05cu001.outbound.protection.outlook.com (mail-northcentralusazon11020115.outbound.protection.outlook.com [52.101.193.115]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4hbg268s49-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 16 Oct 2026 07:21:56 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by DSVPR02MB11424.namprd02.prod.outlook.com (2603:10b6:8:352::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.23; Fri, 16 Oct 2026 14:21:55 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%4]) with mapi id 15.21.0522.016; Fri, 16 Oct 2026 14:21:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=zJLaHMP800ZLe/QLftrXKhy1QBGER7Qp7toLitf2O 64=; b=CGCdnm8T99Lr0ZjgM2T9R6laORwrKoHUw0O0cZ/EblhDAIEBl+6NgXlRg QCtexDjQCT2Ky2mOYq/NqeRL0RLhTXhj1HE/Dn3GsvIsI15zG6o1jsbSq20J90Db 3seEuU4oKy3bPxRUDQqCMI28K/6/XNmORZS45suieULSjgguO6DYQWVYSP8TcUT/ F3qvn9f3GW2HKuRK6qMvVDwcXcAEIshz2pMsiATcstMCNgGnTKKhw3hUtJcjP7N8 XTPwMw+00XIk5XaOvOY1gBfZYTe7BcMCjjMKns2koT7nO/7qVjOkMWHLv8N8FsIg yH92yMqjM+K6GvPDKvJ1tY/+j+zeg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=msLAGvLrzh3XOHIHFv1gDlfjhqJQGeYmwiu70oCinv6TKfM2Az2Ppd+3nM71Z9Zv1WosBrwqbgGBjAYmmEzeDS67QECsZgh8+fy1ToY6ulAJ67HH0zZsqVeGQU/R46DdbfhW+srrfW7W32xDMIzSbTcy6Q6O8oB9IW5oTgnXNAkjIRjF/C9GIq4iL/FEueTgAsS6lOVtdV6WBDzrOn7KdN92hmdLkRRkNELLMFNFIXjNM/RjATxjoW9+oXoxLsN4bSRQb5zRRx7rebM+HgA4DfjPMfei4aG189z69xjbX8Gbi1yL1UYRpokXMHmh2YvRTtION/jxMSBBTnjC3aRCkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zJLaHMP800ZLe/QLftrXKhy1QBGER7Qp7toLitf2O64=; b=yPd9eUoxOEy5Ikxa+wR1cAvGtFz919fXRPRw38QK3hSCNkBJTwwoWddOBjXw5i5YoM1evXuVwxQPVrGSMEmERt9z3/RRtLW8GFJPtogl17Pw0UHUFF1sZRbd6rMVtHqilFGBSTWTLg/Zck/NiPWNKebgacHCrN0HFiM/Z/ukpduPv3k39GlG3wL3jmlEEHql3DXh4gVgfku5wwWJ5FzeMSu5RDjHJjkebwXqRmfuBqcwPXJs24CLm/SJFg9cg1uIS0qgTwwmdWGzn+0xqpcd5SBKqmxYZXAHu8PfgUtGnVknqH2CHhxbOMM9OM5BU+oZvEN88S+pwUAD9Y7sYqVliA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zJLaHMP800ZLe/QLftrXKhy1QBGER7Qp7toLitf2O64=; b=UTniDOq88F5464cVZKayfm9pbUK/veXSWQS12kzxnYyzv6ImU57rqtQnIog3T09LSarJV06cgeWJ7/Y4xHUyn5geHuf/FhxyMCSMuXrJA2bkYOmDOwskKtToHEo/wqrgTxYwgcFTV/4xV3emQRP6eBhQR3ialQ8t2bFSyQg1klEDG0DlMdj1iECTk2L22n8MyQFP8c9K1qhmRE04MUtu9NjwW2N3wNqf528QbTKiz15p63e+yQuPw4+YZcLp2Y9+yobdRFfdQUFK99YhKsxmWab8lAOuGryyGraEECfS7ZQ7VaPSilVkQXdrf5zBr3w2cN/mnCafY/9aAzIT35TsfQ== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nutanix.com; From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH v2 19/27] i8259.c: properly cascade secondary i8259 from primary i8259 Date: Fri, 16 Oct 2026 15:19:25 +0100 Message-ID: <20261016142031.1204281-20-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016142031.1204281-1-mark.caveayland@nutanix.com> References: <20261016142031.1204281-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BY5PR03CA0022.namprd03.prod.outlook.com (2603:10b6:a03:1e0::32) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|DSVPR02MB11424:EE_ X-MS-Office365-Filtering-Correlation-Id: 6186d3bd-a8a9-45a8-6338-08df2b90d49c x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|366016|376014|6133799003|22082099003|10067099003|18002099003|3023799007|56012099006; X-Microsoft-Antispam-Message-Info: J/AXQHDrD6uAKR1PJG5Rg9FAzcvcauy8cPdjHmbmrcaL8dUtuUWvXuDJ+W7PXZCqseSKxLN4L+zPJW+IlvA9BCCNFLqilOxaL9wU0b16ErH6xT3kEoyUiQlWezvJDTFBAcjPGbxS5UZM4gstL0fIFQkCBoG/RHv2qQ9yAqt51W8ukIxH8hu9oxMg28H3wzjwVpYjnbX+wTTmIEQcE8e5Zit+VDyKzsrTrh4CvzRWzPTz1CJm08ZM8NPzGddpO1k05MXf3SREpkvIJWzYpLFGyRLEQDknEaMP9OOZ1INJ8LOSR/dFPh/Gh+7CRyLVKXB0xlTrpWddqQmdsUwzG2Q6RkGHnDO6Rg+Vj9lNQANYuA+78DqRGzgPv+tozVrv4Tp76VmJGjjum8TA4GCKN1yoXXO7NtB5177sNidGxX2Dcx2AAVWq/dqdDmBcWvAD7+LpqHi5z58cI/Ltowh+5TOCe0Za1geAibMrA9yWY4RYsSP+7yXpfacB/qwVamoFra5+FSUQTg0s4p6amlPtq/DPGmdGL91QRgsw+jJMdOkEo4YdDb5layxx8Obd5sSYdBirNdStPtOsWR35xrjcPj0SMFL/ToeXkOdmzYG9oWgUgDih09ZnNraseM092P1uncPP+zOEHNcUXLy+t+AHeWmzUP2X151vng7+XBeDMAJPncc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(366016)(376014)(6133799003)(22082099003)(10067099003)(18002099003)(3023799007)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qDCaOc4q95Ron4SJodoCM/RrlFJa6t6eG6dz1yC+946HRC5eJhH/Nx5WMPtK?= =?us-ascii?Q?f17ryAzNVUvGINP0vRWFcP3eTEnr7CYFP/WzfEQ0ks3ZDGkCkFBDhX0XGH1b?= =?us-ascii?Q?qlI9Cz1qV6GSfxRu0SmlpI9j44TvaW2IN/ulcmMuRMnXyyGajMhz4iD/iXYj?= =?us-ascii?Q?IL+/ilh7X5Uyfq39IiWT/jHp+r99j+amIRPs4PvtpOnOAYHbw7wZB6DB0X9/?= =?us-ascii?Q?KYz2rHi2rydThqFDT1cPRfB+6hsX7PJaP/5apRqJOSKcQZ7V7aT67Q+cIZgJ?= =?us-ascii?Q?zh02C9SllytarMEPZlDvB1l5LRs9yqwXaO4nkn9prnpMywZwxDMnqXXkXS71?= =?us-ascii?Q?VQ80yWHR2peoWMNuwoI4ykK6bXhWd5d7Adr95uz5wuSkMUfO5oOuW04jftMM?= =?us-ascii?Q?bZ0bTumtRkr5aDCurfF8208vmZCo3QLaddL92nvXupV+bolhS/pvlRi+NER1?= =?us-ascii?Q?EdztLNOQacnu+l+6qYQRAOezreK2g+Tb7seNL74D9yLDOaDYrnkIJWZATnC4?= =?us-ascii?Q?cVNoDwrDIc2hzyU+K6SZ55dY/Zdx+LqWPpJ3kb4lKDXzWESRfUyLfJKCop2R?= =?us-ascii?Q?bUtZNYf6+GTHeQCImVdDdO/ZeYw/QPya2uaPrYxGjt8N8pvUJhxgkBkSzlYX?= =?us-ascii?Q?tYj0ZwCf4i5XI8pbNH63cvhVtUln0KaRAL9ETSXKSCn9PZO7RURoKa9PuLFg?= =?us-ascii?Q?2L/ZZOC0kjVR9GNpHfK0l9z/qkTXFqWrP9zgYdUHOtNiNfaOfOl7HvMG9Z2h?= =?us-ascii?Q?jFnBuAqgloT/33OX6dzJJwialCqy9JNQWRTZPuz/ctFPxyam4fIrnhVESHFy?= =?us-ascii?Q?OFxBuFVrZDDuyyj9lciIcBKzwlEdU9Ykhffk1vgFFKn5uJafHhqdub72khD5?= =?us-ascii?Q?/JmfP8FL1uuX0ztoQfPKyasIXjRGGfJ7CGWRzAY0XPSJ14i5LuPIhwf+8Yff?= =?us-ascii?Q?VXjLNHIcRz2nvR46xB/lcY9xJBmyafe1zpK2Rc9TS4tg+sP6XklsHqQ6cDbq?= =?us-ascii?Q?CfKgN/AsOfaiooiICEH6yHKlDurNdmzWrVMG1M8ri/qj8Nj6tguU/+2LmHgj?= =?us-ascii?Q?1hhOHmgFAuUP1wo/Hr34EBtIIiRXIJVQ9omlFafLvU9INpC9VReKiigRQHG+?= =?us-ascii?Q?s9LN4PkYa48fVdOVaXBmaNBX2K80mQNCT2zF6fkgPIG/0VPcZFNNqa3VF1dG?= =?us-ascii?Q?ZjB9mOI1Co6F5Z80JsImdZENaiOSuuQ+VAUJz6CyjsS5IAPbRmne/do7FUa0?= =?us-ascii?Q?I4KMIgeraCWLqNAunk6GAmWOLclI1oNPf8LDd0zj4gAuTBuS70aaz2cioLre?= =?us-ascii?Q?vTRaaIVTxi24O3I83n4Pa+iPbA3Imy/dHUvxR27b3+CXlWEqfC3uagdgjwFJ?= =?us-ascii?Q?56PSPEekq4G+27eMuCW7yYePCRUyEopvYYb1h2iA1DkJZrN6R2xx5tsWDlYz?= =?us-ascii?Q?/aaM3KhW4qb1JWIgC10AR9k/vTr2x6KDByooYlbqDOwUef0F5rZAcJKj4re3?= =?us-ascii?Q?i3d3dSGsq+P737fFJyD3A6/9hm3iQEunzAghXgKy+U5y5Wu5S4MijahSIPb5?= =?us-ascii?Q?SuNtta0L3YxTjqDpTIBWy0jQTZ+KcXQXkMTISa7R+dZPcb5yYXlmXbCW2zAr?= =?us-ascii?Q?yc/WUoxZ4njpNZ7E6OK48UODoBax7MGg5SU5Y3w0kA+j81BUYVLi18nHwoVk?= =?us-ascii?Q?nWPtbDYVygHWxCrIs6m4shyHukU0xHCNX50Dy7AqUmYdRG90r5W8t2XYC5Ji?= =?us-ascii?Q?1RgUcwfKXjxqCBm9GIHCBnytvgvO9xs=3D?= X-Exchange-RoutingPolicyChecked: enMb00uz3c9uBuBfLvVnTSaCmW1dQzaADCkaCkdOUvbSrns5Ytan6JtXLsIHpEI3PeWbCn5GEp7YaIQRf9vfFcAs3aacwGQqLhCPCXEfWstD3z14LNKahGCdF+OAg3mNJZHFcyECflhkxfS4lxV/aW57i0SoBM30x0OUDLVztQpmcCHXHX4vICWDIrDK+IQfdwDYm6WyOVCQ+onG3ZvQEBTXokM1oJDto+I9YqZPt0RvxqoM1PxYJSDtxi8WfVuScUYX/A/U0YdFgntZPJzgQQtyO2kIXchwKox3AICkWaA7Bl/+3VhNcaRnRZ11Tr/lxmwRLHk91F2PUpqrxi1HIQ== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6186d3bd-a8a9-45a8-6338-08df2b90d49c X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 14:21:55.3735 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QhlLLmABL68CLZAse4TMBcrNE4Hdkors8wv4Dgj/j2L5xjva7YNZ3mvyIK5N5+fhm+w0W408TB534a3AD/epNuQ9lA8ZF0Nrd/JkdoFtefc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DSVPR02MB11424 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX+8P3W4aKMO7z 8E9f6tmoqAhlaGkrNhbJuzr/AdlpzgKx7gzff03/cGroxhUfGyTgt0rs+vqsYa2IQHWfaLKnp0S oNCsriNZYo6PI+GDiytFiaMI1BV5YsI= X-Proofpoint-GUID: 29ctTzvAopVc6NTtCJX8QK7a7WYUy-h2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX65lhDD62t7Hr xQ8CbwW1SBdXUts7SrpEQX8yKSTlY0Jq2otTsQRPWuOf8OeFNqKq2ojdHU9OJDugkvubiB9efnJ XkmXq4fk5nGw/A7mCLBqnUh2PwKyFa5Z3v+xmsLtwLF6GwjI7/pdJErT2YRjBjwjpyFuGDaJgp5 NmNNTMd6VnjaAohH9hKc1URHSJ+KJCtYgYm3ANbBY6WAKOZhz1lSHbZBnl1PNaPkb5DRR7CtFH1 oyGOuzdEz/QO5CuXVC7gczJm9yOZk7LV+mpwkQ+osKN7C1pw5NvVReAjv+ricz9hN+tOFJ6qert to80CNMEZLacXoFzXI6fYtahCA+6xWlKipHezmXUbregG/6thoUK1oP8OKss1A05k4UbaGwmhIx OuqUFZo7QZLwUW2/R4/DRQuoQagVp5owmIdUP3/ZPQuHzfhAGu730p9Qeo6lsI3nEFDiSs1d2VI 0xd8l/5c4kte6Fem38A== X-Authority-Analysis: v=2.4 cv=G5OJgNk5 c=1 sm=1 tr=0 ts=6ad23304 cx=c_pps a=1UxUaKSOIsEpFYfBxZ3OzQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=660iZSQnnn4A:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=1L6crL_YRTbalZ11mEUO:22 a=64Cc0HZtAAAA:8 a=BYTbfossBeh0jvsGI5kA:9 X-Proofpoint-ORIG-GUID: 29ctTzvAopVc6NTtCJX8QK7a7WYUy-h2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-16_02,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-720697/1792160537-F1AAD2AC-24968047/0/0 X-purgate-type: clean X-purgate-size: 1060 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1792160556808158500 Content-Type: text/plain; charset="utf-8" Currently the cascaded output from the secondary i8259 is returned directly= in the pass_irqs[] array, instead of being connected to the relevant input of = the primary i8259. This is a bug fix since in a cascaded configuration on real hardware it is possible (although unlikely) that the cascaded input from the secondary i82= 59 can be masked on the primary i8259. Signed-off-by: Mark Cave-Ayland --- hw/intc/i8259.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index bfe01067b7..5f90edbe60 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -519,7 +519,8 @@ static void i8259_pic_realize(DeviceState *dev, Error *= *errp) } =20 /* Wire up secondary cascade */ - qdev_connect_gpio_out(sec_dev, 0, s->pass_irqs[2]); + qdev_connect_gpio_out(sec_dev, 0, + qdev_get_gpio_in(pri_dev, 2)); =20 for (i =3D 8; i < ISA_NUM_IRQS; i++) { s->pass_irqs[i] =3D qdev_get_gpio_in(sec_dev, i - 8); --=20 2.43.0 From nobody Fri Oct 23 14:31:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1792160555; cv=pass; d=zohomail.com; s=zohoarc; b=hmvNOyFAn2VeODjDh/2JWlvF4EIRkA/PPqQ/lbZ2JY53tmfVGjbvmRDPCxrpGlaX3EBmBZeUNKROH7vv86JuKYKp2RKJvPabKNAS02LQqgIX0f+st+Yv/P7l8+gvdJOwdSNOe5uVo39MDpXvk8hqDMTWd8mxYKIV1wgqBezhYc0= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792160555; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=TT4vyz58C9R4m1U1e99yPlvlvXTFk0taf+u089Nfdis=; b=KwcdyvQrV6tZ8tuqGuhoDpKxqvhbpaVK/9Jk6zrI7pfQ3NmcPg+ozDwPHpF3ouvolJMDvUge+91iSXhy6o632htahXQOuUxYNA8b/TMmSPMpE9QqZuBl8I73P4lFq37BgwqgPC+/mVEOwQBYhtTg89/Hh0/zkeYkFuYVAYGb4nc= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1792160555590846.0294044646911; Fri, 16 Oct 2026 07:22:35 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1452013.1666947 (Exim 4.92) (envelope-from ) id 1xHiox-0005u4-IR; Fri, 16 Oct 2026 14:22:07 +0000 Received: by outflank-mailman (output) from mailman id 1452013.1666947; Fri, 16 Oct 2026 14:22:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHiox-0005tq-FA; Fri, 16 Oct 2026 14:22:07 +0000 Received: by outflank-mailman (input) for mailman id 1452013; Fri, 16 Oct 2026 14:22:05 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHiov-0005oB-Ln for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 14:22:05 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1xHiov-00CcZL-2A for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 16:22:05 +0200 Received: from [10.42.69.10] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6ad232f9-2eae-0a2a0a5409dd-0a2a450a9e84-48 for ; Fri, 16 Oct 2026 16:22:05 +0200 Received: from [148.163.155.12] (helo=mx0b-002c1b01.pphosted.com) by tlsNG-4011c0.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6ad2330b-f2d2-0a2a450a0019-94a39b0c2f62-3 for ; Fri, 16 Oct 2026 16:22:04 +0200 Received: from pps.filterd (m0127841.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69GE5C533215871; Fri, 16 Oct 2026 07:22:00 -0700 Received: from bl2pr02cu003.outbound.protection.outlook.com (mail-eastusazon11021122.outbound.protection.outlook.com [52.101.52.122]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 4hb045k1nt-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 16 Oct 2026 07:22:00 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by DSVPR02MB11424.namprd02.prod.outlook.com (2603:10b6:8:352::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.496.23; Fri, 16 Oct 2026 14:21:59 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%4]) with mapi id 15.21.0522.016; Fri, 16 Oct 2026 14:21:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=TT4vyz58C9R4m1U1e99yPlvlvXTFk0taf+u089Nfd is=; b=NJv1XV6vJECxQ0/uQ+5ofclWrBaxeWlCvWPmLCHxFig7sAxjqn9j4AXtn zWCtxqCsRawOD5kGCprBJmog5XNiiEPGub33kshg/edyAljwVY/fQg6X3LEmpYBp FlEHyOO14vItoPTUMdjPj1Y2EbrDffWmnC+rdxmzyqsQfo23pIAokZT6caE26G7P YO0GzOzu+578gZqeqz7hRDGb+LGff5LWBKG2dx9N/ogdvAyTyypdSb7RBpoV/jFA 6rUZ7QNAt+/uYFaJJMjeFKdJoCElN4K8pQLQtOq0ZhsI1w6QlHRu/inWIj99YwC1 LQiGvcrIVPYEZUBaR27IuJgNJ6srA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MGip2RzjYkp/7/FJfuQb63oSNWemj7bV7U8A8o0YMzhB2L3k/yhoJRCOtFDblZjklyJXaGEkj9TaG2wAMRERc3MMp7gezWxeLQFrx6FleyzIS02+0jsOZ8UWS3mdvEL/815HRyH1T4mo3+iHeZmjB6FceNaWD081QUGMWv0GbkCZk11Jud/oOvM0qPfx2NQpVd0+JoxpbPG8wRsyVkbk4+apu2IxhhUtJqYBwliCcx95+z2IdgkiuB5RRz2OOP71pu1BuHembpLvNEc+7z+Z+nVhwmVEhX2BTrRbNkJ65d42Hf0X2h8c6QMtzKi7G/1/8gLeAeW6hw0CJfyUnRKlew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TT4vyz58C9R4m1U1e99yPlvlvXTFk0taf+u089Nfdis=; b=hGilYBgpzHkuduu8xMXMCTeIs2+h0a2w4VssgeNVykoGvye1MsBPPsecqYX+rYoLBAXRJmCiLjU5NqpmRUxxyVsNQJm79XVU0YkJPMoWJPv5BXq8AV2U7CMFXjhwLNyRou/xwzmlQUrscWfN3InUuKoN/y7JJXphZOnwdHLPdhiUSeViBYuzOEIrbhfCj+gmEuJlfP/OahWbWwEdTuf4mrJihBgB/Ud+0luYyMmVsPsBma5JslxF8lFzUbK8XohkzqTcicBL2lOeIxJRpZfUbJO+4GXKTYcdU92OjDcQ+KjQWjNaP0jBvNYr3iKpLr+4+v7WX6Dd1yLMAt/XpuSzWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TT4vyz58C9R4m1U1e99yPlvlvXTFk0taf+u089Nfdis=; b=k2q4UdFR8+PRLh+U3jw2pJ4Ze5RaOTA9t4Xk3DCY04oc4Fa3GngLNZLVzOlS9RxYtgW9pdUw+zaNS/+5rBLszp/M8ZE1nwzbxlIR5/TPYg06bzCgZzms7UcbwyC3KU2jX+ZzgYfvGk+AEch46+sAixQkn9rWKmzY/tFCEpo35cNG91Cm5veQuvCmeAsQglqIP6X2qAJiDca7OKBoa1+7ugo6ZEHTzxvSWK7oPO3h4Wc+RT+HIt77WyOUgAOx9i/b1azbYpkDKWl/gtMmaiBC7gwkTPhqEceYs5yEWz9JvpQ7Tw/FxUwaDaQ9oTv8jO74LS3X0REWR6G48c4f5cFVOw== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nutanix.com; From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH v2 20/27] kvm/i8259.c: introduce TYPE_KVM_I8259_PIC device Date: Fri, 16 Oct 2026 15:19:26 +0100 Message-ID: <20261016142031.1204281-21-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016142031.1204281-1-mark.caveayland@nutanix.com> References: <20261016142031.1204281-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR03CA0348.namprd03.prod.outlook.com (2603:10b6:a03:39c::23) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|DSVPR02MB11424:EE_ X-MS-Office365-Filtering-Correlation-Id: 5b33ccd0-7d4d-4712-3402-08df2b90d6af x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|366016|376014|22082099003|10067099003|18002099003|261009223027099003|56012099006; X-Microsoft-Antispam-Message-Info: st3Y09XUySP0rTGVtIE3kd4lyMb9QN4JbAun6ASEnooi3pLrdC5/h0Tb6tWTVqUy2gXKmLYU/eELEyi2WG2wUSGVu3CtB+6tNbFl83iqJ5lixcnLa/6zVeD6eOqYMXBWhrkbkbRgBSrVU7WYM0CpNhehK7zs6qgQnPLPNbvcdEjgMQIzacrLJ6zrLh5YeWkpO0r7M+InbJ68r05oQ09WVDgxj3v1QdVYa907Tx1N3LotFBBAO+O/ACAkM1yF6U+R5SMHsnmBb+zgsgSFihUC8rfVuaNuOv/eXqVXi6jYkh9k0RkoLX9/MWOBHP9KfhXQMavy6OMnikq8lj9JsqTs3oVWDBlBZS/w4Gvqd8aE+gTPCW+cuqqHH4O+1qx3jKs1YoKPVlD2w1zHCdHA9ldUAL9dU6mnjBcp8LnCYVrJ+Z/eQOr4U/wqNqvsIBt5npRo6sgsBmdRS+otL8PnJsPRk9S+XFc7shrPQaTh8Uf/7njJ1lPPXlcZapjWjZhsusGP81r5KqNw7u5mx3aj62egV3rNZ6VymMn3CbAxfnsw18cml+gAa9aKp+XkR/SJmj73LCTYgq87EYJdGt9JfPEpOY5ogqwG9kj2xbW6o2bmdj+OMjZynwPLfuiEFmXLAy+33AJcYRRY4abZOAaRZFMjec2yez3CrpKzpgr9lKpPKI8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(366016)(376014)(22082099003)(10067099003)(18002099003)(261009223027099003)(56012099006);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6nCdstLvjAiDqIXhzwXdlkFDWPMt2uSBrDddRSK4JvbipUR8IlG5T3h3Y6KI?= =?us-ascii?Q?cD2J5Oo1DcVhKhmGG6XhNDkos5K8esCz01cKWEfcBYMNZiIP53I75GHIlbMd?= =?us-ascii?Q?dhrnKTGWcE+b4UOOv4jAdIbhr5RMiiuoAzHXvEN9xb1nxYDlMrK2enzBJDC8?= =?us-ascii?Q?llMlhU60kgC/WnFggTErbg9/CGrCIkWZ2uWCfCkh3Fl9yUFkrObvikWHq6uf?= =?us-ascii?Q?Qt1X0KeQlcgRE/L6QnAd/W+Ydc0q0/RfckQECjBfPGDOVQQwM2SCay8M6bXs?= =?us-ascii?Q?um+K3ufmTMtqeLzCu/Na+rwEPzttyaLNlYAmwuVl1qLrnmyVtpE9RxghJOjW?= =?us-ascii?Q?a2zlbn68VxG7pZEgrPU3ns5zr+aWjaXzEuD9r9EFe9MYFmYSGvQdD2FOvoIg?= =?us-ascii?Q?CHjXjie5tnOH9g5cJMJkFzLNrOnbrqw76jJsWIbyZ7OFMbPc/1R2SnZdI8hn?= =?us-ascii?Q?Og7EUDdhMXOrzzVtr5p3T/l+yDFrRfDwuTHjEIcqRfhcLH32YyNXb7L6Z3CP?= =?us-ascii?Q?SyHagYI9wtVmGnqvBecjWtxFv4Yibc+O1eCmM8/3RJteTvQmp+t62mnQffSk?= =?us-ascii?Q?emOiQXtOcHsuHUaGa7kEHs7WLeWJAzb58yPbGMWvLEQGNoT7/ctxvue4NkRv?= =?us-ascii?Q?ZTPcuIHFM3ZIHtOwpZddxJVKD+esH1fgPFcmZ41MALzEavcfBZd5xZdTHYTQ?= =?us-ascii?Q?HfGui6yknldNvichw0gp2UU3QRS2V1yBZKo2ZuhbGnsljhaGr5kYlm/ftUBu?= =?us-ascii?Q?6ZVBz5fLz+9UrEvw6czSVNQRL42al284KKfvDjDGl/uu/6NDYA8FgzQvmWzO?= =?us-ascii?Q?pzvZ4fOQKb2HvNufJ5VcO4X8FJAH5CtD9A6ss5Fa0PV89S1nogMTDA5kGu2Y?= =?us-ascii?Q?5iwsdc14T7XUzWWc8bfaNs+nF8uNB+5g3UonWoOZ9q2GJg+9fttDDs1brPhi?= =?us-ascii?Q?tU90hMkIVUCNFt6xvbAY/DCmcG/z4CVtzmK7wPaCqrrffmMZVkhZG4NZdyYS?= =?us-ascii?Q?t4lhWJRjGEkVe9coHK8TUyMQZlOu9aSvf2Fmz63hDCX0cBZMOy/GhEZ4prGY?= =?us-ascii?Q?3E+hi9Plw1kwsTZmlPl2lpNIhiCdTRGcB3delEWKE6Zeax2zwn1e6yhZZ7s/?= =?us-ascii?Q?SFjPkvYQ0fo8nDkZer9/PnSf6MikX1X17RyGqzXwet//8vntsOUtcoBucLt0?= =?us-ascii?Q?EfKfuj5P7tEMRWMW8/Uf+Qzj7+4fo99hPU+G34wdirJheqinIe4WM1C7p3Wq?= =?us-ascii?Q?FdlIHMgV5ZNUnhlWdLLtw/T7Eo+VULX1nxIEQsNHPgf6wssr1CEKD5zJX4OP?= =?us-ascii?Q?pTalqUd+v4XAK3NWVNzHZDkrwT0lrl062VWWSVZL8D/QOJtspVrFO62TTlrE?= =?us-ascii?Q?eDRJO1tlsr6L0IAu3WXJfsL1qC7FXI/UalnklGahI/YWm9cDWKu49ZbH8oX1?= =?us-ascii?Q?yTcEyRHKSweNEk4Ce7GcC5rzgxwlGper0S6GfBHCSoLuINjIo2hgNgBAeU2e?= =?us-ascii?Q?paV//zFSqRFvrDsCjzSZhy/BcAQHGUJ6uhwAdDLGs/2GiqncFPh1kWeNsoVI?= =?us-ascii?Q?E//mzks2qyS/+16WIityz5FS2Mc+bSBPj9aw9EfQ/g55nxn2YrNjffVBFWUY?= =?us-ascii?Q?1cbA8k5M0284GQZiTtPxztnJPMyrdpQ7FQx6UI7eIsYMQtJ9hxBNwNGa8h+H?= =?us-ascii?Q?wJ0VLUIQlD4IQtEvHJHlggXaLf8uoouXZ3CDQRO1jmUyKtuC5E4vHccDGVJI?= =?us-ascii?Q?O1o7m0II2eOySLqmaOppPINmD95AGB0=3D?= X-Exchange-RoutingPolicyChecked: plOU72PLkQTm8IPZQ5ajnKGg+kubxYkS2GCPXXuHLwUHnPsdnVZTnuJB9GJJvqK0L3hvRrkcmygUk89Q3kp9g7Jn3L+OzQF2Wjwmd/8W6aqu5qCNLabtJ37XCnWIY2PPrK4dx+ZCErXs4xfBPcKitOrtxOghw3L7iXR0vXiLghb53YMIBhkl7fswjD1/GziLs9iE1aWUgkK7qRDvJxB6+eM3bZj8X5FznlYiKfQg35KJGXKJwGMLEvTUgL1S10hFgvRNPxgsPqGAUn9NbSvmmIeRKGyC6jqYPebsVh9UE19KdJWf4Qe2URJOtBIOb7JKm86bWXlNhe+Ew3ijgQtwXg== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b33ccd0-7d4d-4712-3402-08df2b90d6af X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 14:21:59.0394 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NR1V+MWUDCFiEQSbYafF8wt1R8lPh7D4pukupB58dxyOf6WKNyH//Pas3Io+D6jqN9/j/Ce8n/UtkTSdMD8NS6CMsgnLK7zlNBLDcaS9hhA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DSVPR02MB11424 X-Proofpoint-ORIG-GUID: viLeBcd4OMsDYg2Im6P29P1BHlplfyKA X-Proofpoint-GUID: viLeBcd4OMsDYg2Im6P29P1BHlplfyKA X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX/Hn4HD6mYvbp 35X333LTbTag4XOHZ2JbhTxWnD7TrH0jy8B1GVfMyCcG/ZZ97/fposnjclllN8RWwIIaQ35gDxT 5lj2GRUzl4pG4tOzyspR0HO0CYhW3IiJgeizuMHCql6tydf1C001UPcUbD+HTgZWRqqNgg3cF16 skICr50IvIlimqPAhZuAdmSFuCrFUygwYIDpMuKUEku6zd0TBeFPWE8WsWtbGBJ0pEGWD3jgoUr 7pGu4H+83Xm0yzfo5edCIPQBSpyv+J3Vu4FQqK3omyve5R35oHtRxmkgTZ0W+efD2Sy9CAh75eS HhZNli9dvjsUGFqVuujzGd3V4shcNvqOzDPn1wUeto9mjNxEK7cI6ItLTxugPpusbvrxeTYt7qC IE0xQzyzYLqlP4o/UhT1TH4iRTOGGoHjVBV+2A7AOiXvFM4L+NKa/ILLNHxs31vgCfRHzkbspdw ivBrEQEKCin5vT5XezQ== X-Authority-Analysis: v=2.4 cv=V/ToQuni c=1 sm=1 tr=0 ts=6ad23308 cx=c_pps a=83jsKCSeZiZisq1MDa3xoA==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=660iZSQnnn4A:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=jxMXjlTPpCISP5mWtjnE:22 a=64Cc0HZtAAAA:8 a=CV9Lyex1vB-al1NDbmIA:9 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX4/zgKiMZZSU3 ahNLmbBk4PfT0oIT0DlfbJ4U5zACHpT0KvJ3ucuwLNhBTsvSTwttkYLpcQhYVUXiPmf5/LnTP2h lnfiinCDUE0r82m965oJPNjxNuQ7Bpw= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-16_02,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-4011c0/1792160524-583CCCFC-352A2570/0/0 X-purgate-type: clean X-purgate-size: 4322 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1792160556797158500 Content-Type: text/plain; charset="utf-8" This device represents the KVM in-kernel PIC for an x86 machine. Signed-off-by: Mark Cave-Ayland --- hw/i386/kvm/i8259.c | 91 +++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 88 insertions(+), 3 deletions(-) diff --git a/hw/i386/kvm/i8259.c b/hw/i386/kvm/i8259.c index 9ee23b5695..c51738dd44 100644 --- a/hw/i386/kvm/i8259.c +++ b/hw/i386/kvm/i8259.c @@ -16,7 +16,9 @@ #include "qemu/module.h" #include "hw/intc/kvm_irqcount.h" #include "hw/core/irq.h" +#include "hw/core/qdev-properties.h" #include "system/kvm.h" +#include "qapi/error.h" #include "qom/object.h" =20 #define TYPE_KVM_I8259 "kvm-i8259" @@ -36,6 +38,18 @@ struct KVMI8259Class { DeviceRealize parent_realize; }; =20 +#define TYPE_KVM_I8259_PIC "kvm-i8259-pic" + +struct KVMI8259PICState { + DeviceState parent_obj; + + ISABus *isabus; + KVMI8259State i8259[2]; +}; + +OBJECT_DECLARE_SIMPLE_TYPE(KVMI8259PICState, KVM_I8259_PIC) + + static void kvm_i8259_get(I8259CommonState *cs) { struct kvm_irqchip chip; @@ -135,10 +149,21 @@ static void kvm_i8259_realize(DeviceState *dev, Error= **errp) =20 qemu_irq *kvm_i8259_init(ISABus *bus) { - i8259_init_chip(TYPE_KVM_I8259, bus, true); - i8259_init_chip(TYPE_KVM_I8259, bus, false); + qemu_irq *irq_set; + DeviceState *dev; + int i; + + irq_set =3D g_new0(qemu_irq, ISA_NUM_IRQS); + + dev =3D qdev_new(TYPE_KVM_I8259_PIC); + object_property_set_link(OBJECT(dev), "bus", OBJECT(bus), &error_fatal= ); + qdev_realize_and_unref(dev, NULL, &error_fatal); =20 - return qemu_allocate_irqs(kvm_pic_set_irq, NULL, ISA_NUM_IRQS); + for (i =3D 0 ; i < ISA_NUM_IRQS; i++) { + irq_set[i] =3D qdev_get_gpio_in(dev, i); + } + + return irq_set; } =20 static void kvm_i8259_class_init(ObjectClass *klass, const void *data) @@ -154,6 +179,59 @@ static void kvm_i8259_class_init(ObjectClass *klass, c= onst void *data) k->post_load =3D kvm_i8259_put; } =20 + +static void kvm_i8259_pic_init(Object *obj) +{ + KVMI8259PICState *s =3D KVM_I8259_PIC(obj); + + object_initialize_child(obj, "primary", &s->i8259[0], TYPE_KVM_I8259); + object_initialize_child(obj, "secondary", &s->i8259[1], TYPE_KVM_I8259= ); + + qdev_init_gpio_in(DEVICE(obj), kvm_pic_set_irq, ISA_NUM_IRQS); +} + +static void kvm_i8259_pic_realize(DeviceState *dev, Error **errp) +{ + KVMI8259PICState *s =3D KVM_I8259_PIC(dev); + DeviceState *pri_dev, *sec_dev; + + /* Primary */ + pri_dev =3D DEVICE(&s->i8259[0]); + qdev_prop_set_uint32(pri_dev, "iobase", 0x20); + qdev_prop_set_uint32(pri_dev, "elcr_addr", 0x4d0); + qdev_prop_set_uint8(pri_dev, "elcr_mask", 0xf8); + qdev_prop_set_bit(pri_dev, "master", 1); + if (!isa_realize_and_unref(ISA_DEVICE(pri_dev), s->isabus, errp)) { + return; + } + + /* Secondary */ + sec_dev =3D DEVICE(&s->i8259[1]); + qdev_prop_set_uint32(sec_dev, "iobase", 0xa0); + qdev_prop_set_uint32(sec_dev, "elcr_addr", 0x4d1); + qdev_prop_set_uint8(sec_dev, "elcr_mask", 0xde); + if (!isa_realize_and_unref(ISA_DEVICE(sec_dev), s->isabus, errp)) { + return; + } +} + +static const Property kvm_i8259_pic_properties[] =3D { + DEFINE_PROP_LINK("bus", KVMI8259PICState, isabus, TYPE_ISA_BUS, + ISABus *), +}; + +static void kvm_i8259_pic_class_init(ObjectClass *klass, const void *data) +{ + DeviceClass *dc =3D DEVICE_CLASS(klass); + + dc->realize =3D kvm_i8259_pic_realize; + device_class_set_props(dc, kvm_i8259_pic_properties); + /* + * Reason: must be wired to the ISA bus via the "bus" property + */ + dc->user_creatable =3D false; +} + static const TypeInfo kvm_i8259_type_infos[] =3D { { .name =3D TYPE_KVM_I8259, @@ -162,6 +240,13 @@ static const TypeInfo kvm_i8259_type_infos[] =3D { .class_init =3D kvm_i8259_class_init, .class_size =3D sizeof(KVMI8259Class), }, + { + .name =3D TYPE_KVM_I8259_PIC, + .parent =3D TYPE_DEVICE, + .class_init =3D kvm_i8259_pic_class_init, + .instance_init =3D kvm_i8259_pic_init, + .instance_size =3D sizeof(KVMI8259PICState), + }, }; =20 DEFINE_TYPES(kvm_i8259_type_infos) --=20 2.43.0 From nobody Fri Oct 23 14:31:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1792160556; cv=pass; d=zohomail.com; s=zohoarc; b=WZpeyNq2K/NBZz56PbVQpTwzw2hfTYxNh6b7tMeQc/yHOf44EiGNScXahYwKh+aAQaf6gNklujjTHEALYNWvULGwuODCzXy6yM+GhLbXgySj+UK77cjcv0h5LR20EF7a/MjIFFxpkdoejfBcE4fsYAbzawlJWs8Ii+ylxWhip1E= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792160556; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=aSoQnzPVPKCptsUfYQKIegr73fefTWafbQ2RSswwhKA=; b=Y04nizo40aYN1WjHnULhfWzJNunys3+xRKX0p9Whyqj6fhDX6Fh6k9INDxP06osCFhosSiOaTWo1+ZXJfk4HV3OGOfShJiJK7aZxuYJoypyXojJhDoZz1Z5N32923ig42pwbcbzOTI55PUWjKb996JgdSt9m0FT2qBo6r/sVGw0= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1792160556320237.23361435968036; Fri, 16 Oct 2026 07:22:36 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1452018.1666965 (Exim 4.92) (envelope-from ) id 1xHip5-0006gq-Gm; Fri, 16 Oct 2026 14:22:15 +0000 Received: by outflank-mailman (output) from mailman id 1452018.1666965; Fri, 16 Oct 2026 14:22:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHip5-0006gg-CU; Fri, 16 Oct 2026 14:22:15 +0000 Received: by outflank-mailman (input) for mailman id 1452018; Fri, 16 Oct 2026 14:22:14 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHip3-0006bf-RX for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 14:22:13 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1xHip3-00Aqww-7o for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 16:22:13 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6ad2330d-bab6-0a2a0a5309dd-0a2a4504e094-32 for ; Fri, 16 Oct 2026 16:22:13 +0200 Received: from [148.163.151.68] (helo=mx0a-002c1b01.pphosted.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6ad23313-b57f-0a2a45040019-94a39744a0c2-3 for ; Fri, 16 Oct 2026 16:22:12 +0200 Received: from pps.filterd (m0127837.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69GE5G7J3551949; Fri, 16 Oct 2026 07:22:08 -0700 Received: from bl0pr03cu003.outbound.protection.outlook.com (mail-eastusazon11022137.outbound.protection.outlook.com [52.101.53.137]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4hbmjc04ym-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 16 Oct 2026 07:22:07 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by IA1PR02MB9592.namprd02.prod.outlook.com (2603:10b6:208:3f5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.522.15; Fri, 16 Oct 2026 14:22:05 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%4]) with mapi id 15.21.0522.016; Fri, 16 Oct 2026 14:22:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=aSoQnzPVPKCptsUfYQKIegr73fefTWafbQ2RSswwh KA=; b=vkAco6d7o43f8AP4p16DppFGsnuJz4Wg0pFzvWt7LJmsl82vNRnGRaGR3 aqUytr8K6PTZVL6aM7zZ/maX3COHXMo702E06/XZiq4MJ0cmhAfudk60qvi4iVeB pYBRgHjqZNuMQFYFt2qqUMn0rn8fvORpeY4UN3ZeBopWReVh+P7qzPNJPWFEXQ89 bj07W4xMqMACBJ57Kcdh0VW8VaAQH/t2pnfPrBO5EK5xtstZnchFEBF2Veub7NQw kJWwjXqzlT47Ii+i0crAqGhkU4uN6OlOEMDIY9kbizSU/jP/65cNkeUYT3vFOoWa lzpRtsTgxdwuw23Z5NErB/bC7XSnQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KY7DLngDo8hpl0Anym4YXCv3s0cVTp7HY5x3nufUho94b2D1WdXCmu63chw+Qpx/bbGroJDhTTUYiw0mi7ihTWkZDw613QoKb+m2y5m/bAocf0s3GWSrHg5HS3Er7/y1hnvLqGJx6aEA3XXmtnM7pqxvmRXGQDkWMQOjf10sSwUJ7XxBFMc11mL4iy1IzOHV1F7U7YtcxM0VNNX7rmmjUsEpwzbIMrV1+2t748jw+Y1MDrayKqu+oB6RdBnbT5dJE2jyzgHANtFvvA09BgueMlAbE5sHBw4V0rZmZttmwnKVq4USx8iSlMHyjLFsgL6yroSV/mEigOcMvRHklyN/EQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aSoQnzPVPKCptsUfYQKIegr73fefTWafbQ2RSswwhKA=; b=hh6OVtxpLFTtSFFEKtZwcrSma5psJcQhPFZKhpA3DVRHFCieSldTtd183516qN1x4e17Qe7nnDxoPLxVPiOarLeBSTmU9xyjCUSvRWrmDtzBynbKL4rncndsKhHwZrgfg7VsGKRPtughWh+w1XlwxWESDGKoFP1J/q10tzEav26xn/vv1WSWm0hW9Cno0C4poTjvGIc7TqD4obhpvTpL1ydCY3zHfl0KLh3RNprzTRltuyB/PiczVw5q4SCdrPDl72fq8Ez3dRp9dWQyb307RG98KqNFNxI6maej2VPmIQVWrY6wkmG72t0MNXwQTbUwWh1UrekSDaRyg58ZiO4Ixg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aSoQnzPVPKCptsUfYQKIegr73fefTWafbQ2RSswwhKA=; b=SMuySsvMwJxnIw0Z6qAGvLJJ6YbPn82TtozZW3CY3wp88ZIzHqsUtuGQr5aXxCprKjdYF4Z0BxO/7qH/L0nid7MiCV/bcwwYdZYa1Q6Vs8rklrQ7hxBF4K0glz9y9ob1lrhHtB6+7l3kaV72QupfaCO1KWy2Atiz7AZbeg0v5CmoJVf8iTko4akWEENSVyWEn5peut0+rh2tq50OvSQdyzUzghz5XAG/Jb0vVmbRzP7Xi1A+jRm7VziwmxbR8RD2rlP86Igwzsy4L6mO5KPHW2JCSg5STc4ZpwHNGsh/JTY7QXz9MZmXbS9LU/ZlhbTjU/CrD7f2OCpKm1K8dhW5rw== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nutanix.com; From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH v2 21/27] xen-hvm.c: rename xen_interrupt_controller_init() to xen_i8259_init() Date: Fri, 16 Oct 2026 15:19:27 +0100 Message-ID: <20261016142031.1204281-22-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016142031.1204281-1-mark.caveayland@nutanix.com> References: <20261016142031.1204281-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR13CA0193.namprd13.prod.outlook.com (2603:10b6:a03:2c3::18) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|IA1PR02MB9592:EE_ X-MS-Office365-Filtering-Correlation-Id: b0553bcc-60bf-4ab2-f69f-08df2b90d94e x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|23010399003|366016|56012099006|261009223027099003|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: MnXqs3CIcxDGUcSn9MkKNbshtP4yfSjslKriu0p10v+WnKywAKuORuRjXOEi5TbKsrw43rjc4yolrMKvGD4zRX8OmkHA8dWdtE9jDGvhiIrFla5poISGjE5oyqOImdwUyf6lkt+VicRzCpokR3/GO2rhbrlg4fCDikK4BotKVKKD/LOaOEpCG3lm+YO20J8xFKjC8/ZS24eU5ukY91C5B8lvi3BqZGrdpusV98QrdeO0BZFTS1EyZbtAYy+UIlwijvwW79BQIPM66Loko7ibeX3AH+AOso/HrdRGA32xTDSpm42t3BSZRD0MEZPZa1ZNShhFYUxXPB3W81i3Tz3ra3/stph9CK6MtEjmb+vokt3lGUqfVD/29sP32yYIujSdRfKz0CNVesSILEEnRVHsyPOj5FaHWsEk+spmwaZgwTK3bWk1pGmGgRmAiZLpkdhVlZrBd2cJggUTP5C4ESczOscdVha+etpgLsOj3G+8I5M16oY4p5SIl7U39P0Bf5i6LZInUY7lAHCNwxigvgmqyxhCz58/E5kv8+pl3mou3TRpzPgM/Tc/0OnQO31e4KqyfrqL2eaCbh0l0QrkPFtSqVD+b4tuwKYimo1dgo7+UMBJO89tGZ4xMKhOXRSmvdHtR/HtXglK4ymzw096kgrApQKqx/QeH8k1ML6YygDknM0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(23010399003)(366016)(56012099006)(261009223027099003)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bXCUn+1o1IpiNx3jsc7l0PRyalnu65mP/DnQIJJwgljUysbkmsKnX33xuOfC?= =?us-ascii?Q?yHuCevbPnKBsIyQ3esBe8gmp51yeyfJDxZIeC+QW4fQeLWEHNfxg9Q78CNKQ?= =?us-ascii?Q?B7r+QGG0z6unSG5WON68pi5xuUr0FA/1PGkVyULgD8omkyEbXRz6WoFuFolb?= =?us-ascii?Q?qJTzpuaak32sNBL00MsbcL7RJFIlv7sA6IIJQRRG2jUwrLVLYLMCOzor3Hho?= =?us-ascii?Q?u6pfTYQXwH89Q5YIpAe/xQ6eoGtSQMKjS8wOv2zCWz5E5ZjOPl2zbXBBfjz8?= =?us-ascii?Q?scSRC1c+O9Q9b5bhZmwaL9gcgWPbwIFVmQy8tsLkuiyXn2/CXoM7MEaN6TJ6?= =?us-ascii?Q?ZeeZLobu3P/PZEKzvAuz77xTbw3+WyZXBrBm/xUs4cKD5BoSUv4mm+wKXIO7?= =?us-ascii?Q?k38cVoUQFKgpt2XNuSYcB0rG0DWADqWMJfHP5Nsjo4wKNUFMxfzxtYx8FGII?= =?us-ascii?Q?nQsDd4BAyQyc67j/1NorH7SWzRe33P3svoJKgbJP5P01hZiYsLi0pNr2yjsb?= =?us-ascii?Q?F0I3kOtoS1+M37gfC7LkT3xPdaUZWqGyGGxNirNJ3W3aF+EZd3GZMoyvHiKs?= =?us-ascii?Q?Ptm6VS4QHw7nMLgYtWoDAstyrEy9uf6MwZXCtI0bX1EFrZ+BmZDEmmkxF8K8?= =?us-ascii?Q?lCkalgV+PphvMMmfaltuN7+j7FrMgfWYqU6slgqKCYKLhHprpjTiswxJrfOX?= =?us-ascii?Q?GrCzC0zJKcCU1ewlaADh/DvIuDCDy4hy9jCA1d4OlRd9D4bNrlRzMj2eajXZ?= =?us-ascii?Q?6p0aa4XpMtvCAaq3PDkmTA6CYGK7KmuDbln8WIwv7gdusaP/x4jNe4RDC4vs?= =?us-ascii?Q?GA5B9uZ3qKAiurYrm/vf/iWVjTfv7V7Zng2np1fyh5Qs2RCt/dCCXTl0ESE+?= =?us-ascii?Q?atD+XYA8nqgc6D/6IFgdrjK8CXkdSVR9LsNQIUhYPNObRv7QxB6XXq0blQOh?= =?us-ascii?Q?v3UMfv86SB8u8R8UUaitzwKKkhxu07tDXgru3msMlJLFsn8mQAZCs0UbzJcI?= =?us-ascii?Q?o6mAAi5DWT+ZzsCheRHdhBJQMEWye32j74Km8eUFXHHaWw2CpP0gRcSAewhK?= =?us-ascii?Q?fxxE0YEBQeKjBLe/UckcWzBb+RR4wiT/NRO1Kxb928VopMaD0kR7YMxi+gnl?= =?us-ascii?Q?DmmwvLpvf3aIeiVt+vAZpy+Kjh6NYLx1X/gcdJT7yu7ZqmVW7sHZ1lCMOMUC?= =?us-ascii?Q?+EgJmV/iccb+jBv+y6/OCdVoemlDQFITFrU8SNxzx7bKO+jBts1eIYCJ+PLF?= =?us-ascii?Q?5vYHJUyGzGHaIesaGujT6/RbhoagF4KYIdlaegDX85A8+Bcrz07x99HpT69s?= =?us-ascii?Q?zP9iD2VIa0kC0JNBoqOE/zDJQdbThKIeBIcdlchbX5ebYW/z63BxBOJhLqDw?= =?us-ascii?Q?PDE6rDZcv8aA6IIVIlE3fBp8Nvj4bgw/Pvii5FHjDU9gKzQBWFPxOCNzwnuC?= =?us-ascii?Q?StCrqKEN0Hw8CcD4sudWSq8Q6K1GxrFotT7KMyhPcLx8uv6vVIsLOv0JFLK3?= =?us-ascii?Q?oHidki/KUujvhCPS1QsaiyubHiC3MtG204521fpYvhBQTGxGOjdAhXUNjS/C?= =?us-ascii?Q?ryTWZYMoZnIG7hLGL9/+ADlQUmDxYkzb8WbJ8la7MPL/3APYHShUqrgGFzxO?= =?us-ascii?Q?dCHVYkZfOLpvZ9hljJzeX5vflT+UvPh2DbA7h1nq7WQo/tKUkO1b3r7oUjnV?= =?us-ascii?Q?eJQ9QA9b8bumwCAhTjnK3w2VoGnlMKENxui0Vah6wBYHEK3XoH1qaiOBqpa0?= =?us-ascii?Q?vE5MBM28w8Mhyx0UjEtduRVfkBGsFb4=3D?= X-Exchange-RoutingPolicyChecked: FX0tCw4TYGJ3DRo4NiMp+yOdaNqqbhlrnQ4W/KagyussV6cUnhoDuRHYmHucmu+x+wepGaXR1ajxylM4pK2iNohKu5sq/lKp+uPvZKFs+kglyJYxBDshmENLW8xQElewONJ7kwsXKBmXpoBaCAY+r0TcrR0j7InZZ/eVkpem1CvDfBQ8fPVfUfi14u/2PQQQgA3vAHiRScHMtK2HsjI0jrNIzCnQay2vt5fyroSJBPSCsiBptwSeLmbwG06XqjDn4/Rr3K4ZP/aaAT15zq0gaLZHbwjDK/Rzp++kc86X1HRnYu5acsLkyeV+tVSWYHN7rep9C/5uaSO0A50N3Qceqw== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b0553bcc-60bf-4ab2-f69f-08df2b90d94e X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 14:22:03.5699 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qjhzjaMP7tW7a/EuJp5Cf6d9yXMFvXxigQHFmkHgyl+ipz+WTazTj5A+nUiPFreONEtfpkfZDi7f4LLW/Y1dU5t6c0+BVZRYaYD8Mk2V/P8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR02MB9592 X-Authority-Analysis: v=2.4 cv=dasVTnXe c=1 sm=1 tr=0 ts=6ad23310 cx=c_pps a=XMkfF010lpKDMmMg3xIHFw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=660iZSQnnn4A:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=Ap8k9tRZuQ82DLYWQqG7:22 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=ufYRZG4kn_nPcl-B8swA:9 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX/15dpH6RJmRN FwwoPyPOX9/HITiYv0s9SAmwea12y6nHOPs5WLCLqe0erKxYbp8kvaKvDmonRW9nBMy27QR5cpp pLmX0WxDwxxpvTRFOQcP1KNGBxi2ZevqpM19SsOBWCjehZZlT0CdnWHCaKiYsnRoDz9BdSOyvyD 6XNq25EMCAG9UogwsTganewXa6+4A1tpQP3Bqz2KqeTk6G/8frXa11djaaN5Z8gn3I/v6Q+Kcs9 8+VwVxwj9hS++aoqr8gbGiJ8FShG7CycbY8mTXYD1GBLfEqefjUkYCzBpJlDgRmp1lGblw/ppg2 EfG+iqu8hB26a+EH5U2LGOVeCGoWnapxo2RoUgPUPxvF1uHaB9LhGmd1AyZ3jzmwRlFu4rabM9f ymqM5jPohYRYSSqPTQgnT9noVTrWTwEXnnvpFVCp/dVWul2NdJiB28RxW24rb1v3na+FAUVrGir 80C+yw3HUImqwNsQoTA== X-Proofpoint-GUID: F0rQwAs9UDk2jRV65-XabXt6yg0qkyRR X-Proofpoint-ORIG-GUID: F0rQwAs9UDk2jRV65-XabXt6yg0qkyRR X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX9blZG0h6UF/c ZtyP8XTH5atsm/y8v1dyOVzlTTjp7YGXyiNfY3ng6hsNKHbmEloQbUmsnVsXlXzbTLWL4rpO90Y LxjyP0fF3j7XTtbulMccsqcJiJ0FKyM= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-16_02,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-ebf023/1792160533-520D5B50-AD54B149/0/0 X-purgate-type: clean X-purgate-size: 2252 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1792160556831158500 Content-Type: text/plain; charset="utf-8" This clarifies that the interrupt controller being modelled is an emulated i8259 implementation, and brings the naming convention in line with the in-built i8259 and KVM i8259 implementations. Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell --- include/hw/xen/xen.h | 2 +- hw/i386/pc.c | 2 +- hw/i386/xen/xen-hvm.c | 2 +- stubs/xen-hw-stub.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/hw/xen/xen.h b/include/hw/xen/xen.h index e94c6e5a31..ee4ed4f11b 100644 --- a/include/hw/xen/xen.h +++ b/include/hw/xen/xen.h @@ -42,7 +42,7 @@ void xen_intx_set_irq(void *opaque, int irq_num, int leve= l); void xen_hvm_inject_msi(uint64_t addr, uint32_t data); int xen_is_pirq_msi(uint32_t msi_data); =20 -qemu_irq *xen_interrupt_controller_init(void); +qemu_irq *xen_i8259_init(void); =20 void xen_register_framebuffer(struct MemoryRegion *mr); =20 diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 2d8c87b0e3..dbfd55de30 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1167,7 +1167,7 @@ void pc_i8259_create(ISABus *isa_bus, qemu_irq *i8259= _irqs) if (kvm_pic_in_kernel()) { i8259 =3D kvm_i8259_init(isa_bus); } else if (xen_enabled()) { - i8259 =3D xen_interrupt_controller_init(); + i8259 =3D xen_i8259_init(); } else { i8259 =3D i8259_init(isa_bus, x86_allocate_cpu_irq()); } diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index d3ce082e07..af3a90987c 100644 --- a/hw/i386/xen/xen-hvm.c +++ b/hw/i386/xen/xen-hvm.c @@ -112,7 +112,7 @@ static void xen_set_irq(void *opaque, int irq, int leve= l) xen_set_isa_irq_level(xen_domid, irq, level); } =20 -qemu_irq *xen_interrupt_controller_init(void) +qemu_irq *xen_i8259_init(void) { return qemu_allocate_irqs(xen_set_irq, NULL, 16); } diff --git a/stubs/xen-hw-stub.c b/stubs/xen-hw-stub.c index 6cf0e9a4c1..b3e27f0292 100644 --- a/stubs/xen-hw-stub.c +++ b/stubs/xen-hw-stub.c @@ -29,7 +29,7 @@ int xen_is_pirq_msi(uint32_t msi_data) return 0; } =20 -qemu_irq *xen_interrupt_controller_init(void) +qemu_irq *xen_i8259_init(void) { return NULL; } --=20 2.43.0 From nobody Fri Oct 23 14:31:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1792160565; cv=pass; d=zohomail.com; s=zohoarc; b=GuxJx1vcqvb77rNra00snp4W2g2E3Sf0PRGKcOH2Axz0OthG5JuvTbDuZ07zGOC/8DTsZCIUwRXgJY8Z/y+SisZXvgExbpGaBY79XXzRGHkelO8uhyWpQNzEGnHFqy+QIcRXsM8f70JtK19NG3YuXAjAtbf57TBKPgipxRqNKMw= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792160565; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=AbKFGCy6bi6Di+SjRTibND8oFXMooQqZd57pXAx9Hzs=; b=mPvm+4GTshpkbQFpfI711JOdWMSIOcaD9dQkcrhhsG7oGDwR1DMbdCBEnc83C6auOLWVPcfxOm1rMtZAMgqTa/m2R2sBIkMX7escbbQ3S6Z3j6YO3qj7DK8QC9xULwvW9iUtQFEnZAZiwIt8oNYzgQMMABajNjKhcbBfAO5bKk0= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1792160565858556.2170489602152; Fri, 16 Oct 2026 07:22:45 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1452043.1666992 (Exim 4.92) (envelope-from ) id 1xHipM-0000L0-NU; Fri, 16 Oct 2026 14:22:32 +0000 Received: by outflank-mailman (output) from mailman id 1452043.1666992; Fri, 16 Oct 2026 14:22:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHipM-0000Kr-K7; Fri, 16 Oct 2026 14:22:32 +0000 Received: by outflank-mailman (input) for mailman id 1452043; Fri, 16 Oct 2026 14:22:31 +0000 Received: from mx.expurgate.net ([194.145.224.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHipL-0000CK-99 for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 14:22:31 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1xHipK-00Ar0N-Lt for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 16:22:30 +0200 Received: from [10.42.69.7] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6ad2331c-bab6-0a2a0a5309dd-0a2a4507b77e-24 for ; Fri, 16 Oct 2026 16:22:30 +0200 Received: from [148.163.151.68] (helo=mx0a-002c1b01.pphosted.com) by tlsNG-ef75cf.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6ad23324-b4ea-0a2a45070019-94a39744421e-3 for ; Fri, 16 Oct 2026 16:22:30 +0200 Received: from pps.filterd (m0127837.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69GE5G7K3551949; Fri, 16 Oct 2026 07:22:09 -0700 Received: from bl0pr03cu003.outbound.protection.outlook.com (mail-eastusazon11022137.outbound.protection.outlook.com [52.101.53.137]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4hbmjc04ym-2 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 16 Oct 2026 07:22:08 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by IA1PR02MB9592.namprd02.prod.outlook.com (2603:10b6:208:3f5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.522.15; Fri, 16 Oct 2026 14:22:07 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%4]) with mapi id 15.21.0522.016; Fri, 16 Oct 2026 14:22:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=AbKFGCy6bi6Di+SjRTibND8oFXMooQqZd57pXAx9H zs=; b=bU5Vyd05eMr3Hu2NPbXOnfrUIiqH3TDDscLl/o0KZdhCeAEyf7U3Evdbs caNpomMWH3W3KRbDdtEqBS2R0mIe9V+n5Z1ZV00hQ8nb7TO41snecTq9AsklDNJm F9ayDGBJbvP2pc72lI5gpJGAbn4YLcfDB2a5WwUXMP/5Dv6Ht8qRzc8vPet/TPuV eQQwO+JWBnFuNJaOF1rvhS6B36X0u5AWlcuksDhdaLu0I9wuRflGblfPCsfbkPsJ hPHa89pO3Bbn3Gi4GHYHoXoHnBC9oA453y8hm0oGvl2FKT/4ft9h/AdrqVTTjJt3 IGmXte74XoQZk5fWmexEjQSRMmD3g== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xogJEyJAzhv2IVwibE+qP0EM1PhGPdmGP1nEEHDejLVFcbL8mP5/bDnOB3jqH60mPwBppJyiTHdiDvnq9qujdeUnO7qxw08l40VCQmDjm6P3NyiiJP5ftcbVuvsKNWWymGS3SOqioW1Fwp7w2M3Zzo0UXqdW4V+GlxHWXLugF/0z8Y8ZEB6lifQxuP32ldupxDwr4UcYwCOROG+3JMzdxEshXaaWky6OeYtStzY4cnDuIfxAOYu4vWS+tMmspLHmucvRlrIOFn1m5jC0bAeoFciq1cI5aRFaNAY/4NcwqQP0cYktj/jNn3jsYdAoJFjvERTG0b9/p3Wuols5v9fLTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AbKFGCy6bi6Di+SjRTibND8oFXMooQqZd57pXAx9Hzs=; b=uz2dV//ik4ZEcr6WnkuNIE1Hc9E2ke2aWQXVmVRaTsHZm8Atxd4nwqBq1YlwZ6mUQAjuHI41GQj0lMz1Q+Kg+TSfyzslQ4U7FI83CxD19F/KOGsOwmbzNtl7Y3t2fENLis/s+pv9QZf5RAe5k3JUQv57zJ6K0UyY1+n3xs/+ynrgC7imJivUihdOM8sO32dDwZD1fYUPmcGUAT4aftgfZcIVYF1AAWYxDUXvwWLIsViadYiNFA/kqw7R+2a3cQwLpTJboXJlYhSSPsT21ZYrY2N4OZqlUFEEwd+KUp9u5jp6+MZ68ti9ahWAwcoD6A6PDFnIAjeCEUcwHvRafru/5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AbKFGCy6bi6Di+SjRTibND8oFXMooQqZd57pXAx9Hzs=; b=TjReIKquWeQvqpCVVHUEMk9tQhiTEZhvMVC9NsklYjg49/waw+U6Cx+Sf/w7svTTqDAknJOHroQSwY3fSqPqzToOUpoE0fyR76eMhQcfp+/vlct08Rf+Kc+YXsOEHotql6A1VmxQS9QTMDFnj2qRHxu+pNMhScD+mfmhAKa5Xg+gDPMrqk28fYZUK8m0Ho2vQyalcaO1uhxhQbkfLnbrkvB31by0KDNRMrUDFezt5MAXK0Sz08I32SdQXx9IY+KMTYU2BKfsEPnYx+0lwLdS6um04tFLiulcg0Gox8Z+pdtkDdJSmKAi/czB9RElkVFEMSpmiuVqoKSVD5lO9Z5ctA== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nutanix.com; From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH v2 22/27] xen/xen-hvm.c: introduce TYPE_XEN_I8259_PIC device Date: Fri, 16 Oct 2026 15:19:28 +0100 Message-ID: <20261016142031.1204281-23-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016142031.1204281-1-mark.caveayland@nutanix.com> References: <20261016142031.1204281-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0P220CA0010.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:41b::14) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|IA1PR02MB9592:EE_ X-MS-Office365-Filtering-Correlation-Id: 10889001-150b-43e7-a002-08df2b90dbb1 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|23010399003|366016|56012099006|261009223027099003|10067099003|22082099003|18002099003|3023799007; X-Microsoft-Antispam-Message-Info: PkEVfLxaucb2zP1v959XIFKxe48X49VR79aG7G3NxBW2ltUani9cAL1AhaToC4Vy+SgEGLSfAtLYcLiyL0zU/bSMd6FITrWFQ87/riEK3ZrREu2iYtxMlhM2VdxASE3Cr/qpoL0SVWLgpZn2RfCHNXAEg+jsQXUpBBTDy1gAmUFx92dMuOb1G4nzrxQMvhFxyBl7qI1aL6VVMVaHjhOQMj/BK4AwpBJ1bQ6m7QfoYkU9k/a6x5ThP46hi/BTmqx+0ykMggUMEIi6w5wQfqKKaGdYx+L0L6BylhSPLiVDtr/QCNuxjB/JM6C3koMHaoaJ1rZyR92yv6orgkAhn2Idn+OIDxGv8MqTFO6Ka6P0s0NcvdbKo4XHDdoQh/tzWApLg3wHklNkEfSU6BCMLnquEACCbRloOHvrKMoVV/00V//rM8LaojEVx/plQPzJLtuHMFX/prLIx/LldurFx9xu4owIZmjlfAAsRttB2qZFU3R54E7CFn40ljnClHCcIgyr6xz8UFMojsk6Cd3lT2xnpXZU3qlze8Z9kERk97cpVC18/zYBsI7xjvL5W/rUUNP8kHs1uzp7W3YtRqEee7/wMPUfNDjpRKUutzBQ9uvd6OwHp7a6qEsAthpL5iQLkzZurqNeulWWokQNEHB5YIrIAEdIUgC+jvnQ9mHK/4iDM+Q= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(23010399003)(366016)(56012099006)(261009223027099003)(10067099003)(22082099003)(18002099003)(3023799007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ijjZV0wT+0F3kD/iYfXJzNcwpvhi4XLOJKV/zS5dOSp7gjoGUmCc5XAD5kyq?= =?us-ascii?Q?sja5VIJdc/0KS0N2PyF5foA4I3WZUAETsYc2nSBES0675oL/RG6Jxt5UNO3P?= =?us-ascii?Q?bdSDvr/gjFAIbLAe3nhoPofH/GMYMip0QmU2ePEORaiedxC3EumPRAObi6In?= =?us-ascii?Q?l5Z9yFBbddOCpi2nuLL9QGnruyLoqmZX4sZaj7K3QpKcgnQLC7S+n6PSFh+0?= =?us-ascii?Q?h8FjEC/dhQEEzVsUdJqUveZM+0OEEZ+SjmATbvf2YPA9hrG8WzQiKBt3lwVd?= =?us-ascii?Q?PegOZCtMfz4OgzZ3USReavsCfhiSCHia4aFPz/4/REaKYbtOA/ck6zukOp0B?= =?us-ascii?Q?fuuwaeTt2sWvnZiq2iYFsjdNadDf/KzHzod0R90RwW5ZUr6r1ZgTjzEAw330?= =?us-ascii?Q?9/y9Z1RJZvbWU6BDgdixQVp+WydNbcpS+tdUTiyWue+QV74qJbktFQYnpNs1?= =?us-ascii?Q?aQigsV18scR+sPzKGRtnXpu0h5vlRfv5X7Uo4MOCqiOta4xn+XNVur54h4Kw?= =?us-ascii?Q?UKBnSnztkI2IMjTJxA3d62jowecbfbIIH4WT49sZFjaeROq4a6lhfDb/4Fuc?= =?us-ascii?Q?YddQUgX+Bf5eynzZiH6BT+H5WV8k6C840ie8I24pdLWZvz6fX5JoJZHyi65J?= =?us-ascii?Q?HT9JuHqPjS36yotIstEyCeluN9MBzaQIhqDOjo8d9ZA6P5qK+LbtFPTxze3z?= =?us-ascii?Q?RL2+wL4eYDTJwGEZ6A9k0FHM1E0CKhe14dymiOoT2DLNyP6lCej6kLA+i1wK?= =?us-ascii?Q?y3IrrvPHIAfFKyGjvUmj8HOa8CWQggvQHScsXqTfKsSMJYEUMsdppjeocNWd?= =?us-ascii?Q?jGKIVY+orZjNziwkRWUwe8dqOxP8n26//iUN1JnW3N7ZcNL6gBDifvC9X+xe?= =?us-ascii?Q?vnKTs82+Dkuq4BIKtBAKhXcIHyUgZY5aPXBZKy19GUM+crr/QR1GFQ//P+kC?= =?us-ascii?Q?eHP2fGxD3VWFTcIU4mr0hactGwhukPDg0ix1Da3zi8LSYbm7BsCtUQb6f9Ot?= =?us-ascii?Q?QpCCqiQwm++ObR90LbrdfLjPNOF/XU9KRz4x1OGpzjdwVi+grZzW7Wo6MLyY?= =?us-ascii?Q?rAHw78pO5ufxHmrDu+lUTert6Ji7PMp335sQZ/3s4z182D94xjkX1gIJWdI0?= =?us-ascii?Q?8zNp6F0LNNpUalqG124WFX3fFVcQdr7TUHdmrjNz2/I8cwHcd3eOD13GZV6D?= =?us-ascii?Q?H7eCD5yDkhyqrNaooexYWrQpxa2OU/gFF5mTCSdg7betX/y0p3B0RnGWyCR9?= =?us-ascii?Q?ilpeG60/BPZyFMxb4Xbb1DiGL0MjIeFu0SeTbrQD66MnYVAoRYD7XlXtRBLo?= =?us-ascii?Q?TSfzgI8uh+eVXmDLyyEeBwyZGC7wgW4AFGbb+5gU3YpJ1tBX1mCRaPh6i/yq?= =?us-ascii?Q?9tC+V4l/D+L8Hd1o0TxJdo53qjsr7oiKV0Z/fMkiKEQKvOMPnZt1PwvupT0+?= =?us-ascii?Q?2XtvpjiXWH87du72Plpj+1eKutTKNqdNQA8vIgQNAFt/acJXW9N9mjTtnJMK?= =?us-ascii?Q?HozGSI9iX52z8912EHuvMILo9qXMKi9Pp5akf4+AkcQWq35znTsmf4t9l1YY?= =?us-ascii?Q?Rp2Hu0+32aqBiIa5A2n3aQcZBPcvvUHRkQJCqMDNDY+BYy81gHI3+f3Zxbxc?= =?us-ascii?Q?MFXjGXts3t5T4BXLB/H/ytzI5GwaVWJ1G4SJ6NbddJFuDxfuTmDvFttjjWrO?= =?us-ascii?Q?DeGEDIvfX1A8yN9BZJJ6FUoVylUvRr3BAfOkUTLDi4wnPzD8WBca1N32kdgJ?= =?us-ascii?Q?zBecfQoNUBAlufAr87n9UhrvTQm92Rw=3D?= X-Exchange-RoutingPolicyChecked: BErXZDCPp1FzU78zIdZzvW6AccKILXH6+PB6blu/JI++miUFsGymMw6tSymv84XI+8cNx/n+/h2IULaL40dXs8oFI64FsVkgPAGUKHerdZmr2fPiQNdNqbijc2c5P1q7S0GQWtunSoA6SAc5wKOQLrqpFhjRlG/j59H8P204rwcF8SUMAeMsUQydCZq0x8pgGFT75Rvo7YzrclX3G0y+TUVOk+O/fRhqWCeWPnzz9ErB1E5E6NZZW/hkbRyS0Lc1UGVocHZLZsPR/boIMDHzIjgBV4mUj+wAdoaTNhLW7yC50XZqkBHt7xwsyk6ZtnShkEnC/YhCkee0+jJA/y/qkg== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10889001-150b-43e7-a002-08df2b90dbb1 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 14:22:07.1990 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pWiDnBG3xRLj/QXoBXJhdXO0w66Ceh45x8wJ+IWIZ2CQUf3+COUcVTWyyY+OAS4tE3kNWTu7GTzPgVdvq9pMu+MoP0NgOUpUfnOHNqWGzUs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR02MB9592 X-Authority-Analysis: v=2.4 cv=dasVTnXe c=1 sm=1 tr=0 ts=6ad23310 cx=c_pps a=XMkfF010lpKDMmMg3xIHFw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=660iZSQnnn4A:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=Ap8k9tRZuQ82DLYWQqG7:22 a=64Cc0HZtAAAA:8 a=tqVLSPGIGyqkaOPIRdYA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX47XJvywn92Hn TjwBZsyJOG9namOQlbuGvDKkVNAs3V5QpMW//6T2jla9wOcEbt26QH5jNiux7C6gMLrWUNCi+WE XCXWgHGj4qI7hegQmsnfr6Rq4/EeW+IB4YidHe3NWG4AMCp36RBY97VJtB2vU42J3HxO8vdo7+8 EIpsyDPAC2Cv8KZ+8QPphS+kDn5fX/rz56sMH3Xs/90OyqbSAruDHT/nAzTzQ3TwYzM++mRbGXw TQJnO3QCPTlmjoH8gLek1OLEOguTU6xTobPKTYdokeV7YGbVvqsABUtfJvDBKSP3f4/x+qV3q5X ttJcBA+bjHLG5mZmd5HLwL8lwsz+jDh/Eqf4dF7fGYDs37l4wDV6Fwa8ZKsD8hPdsufgXqygGGG cj2tPGEYgPy9I2uy3798WMoLkExVZlqiqmtLleoY2wwT38I/DyIqD5JTHvB7ZWFDQnjffZ0p3Kr 3Jk2KKD6U802EGilKHA== X-Proofpoint-GUID: DkJIZ-r-yw6uhv4bJ7X1Ic5EhhPLUhqw X-Proofpoint-ORIG-GUID: DkJIZ-r-yw6uhv4bJ7X1Ic5EhhPLUhqw X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX/RR+ch8ahAsW P0M4q3nAJ9wYQZu1XCwr/Rx1+eONLzkEuQf0hHiud5TSEVZPyz3kE3Dr0JAK+nfUP0W0+eolY4S JF/sMkLncC6Hj3hbUx1VvRhAadJbV34= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-16_02,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-ef75cf/1792160550-A44CBAE4-FED90873/0/0 X-purgate-type: clean X-purgate-size: 2075 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1792160566895158500 Content-Type: text/plain; charset="utf-8" This device represents the Xen PIC for an x86 machine. Signed-off-by: Mark Cave-Ayland --- hw/i386/xen/xen-hvm.c | 38 +++++++++++++++++++++++++++++++++++++- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index af3a90987c..b2378fe3f0 100644 --- a/hw/i386/xen/xen-hvm.c +++ b/hw/i386/xen/xen-hvm.c @@ -13,6 +13,7 @@ #include "qemu/error-report.h" #include "qapi/error.h" #include "qapi/qapi-commands-migration.h" +#include "qom/object.h" #include "trace.h" =20 #include "hw/core/hw-error.h" @@ -69,6 +70,12 @@ static unsigned long *dirty_bitmap; static Notifier suspend; static Notifier wakeup; =20 +#define TYPE_XEN_I8259_PIC "xen-i8259-pic" + +DECLARE_OBJ_CHECKERS(DeviceState, DeviceClass, XEN_I8259_PIC, + TYPE_XEN_I8259_PIC) + + /* Xen specific function for piix pci */ =20 int xen_pci_slot_get_pirq(PCIDevice *pci_dev, int irq_num) @@ -114,9 +121,28 @@ static void xen_set_irq(void *opaque, int irq, int lev= el) =20 qemu_irq *xen_i8259_init(void) { - return qemu_allocate_irqs(xen_set_irq, NULL, 16); + qemu_irq *irq_set; + DeviceState *dev; + int i; + + irq_set =3D g_new0(qemu_irq, 16); + + dev =3D qdev_new(TYPE_XEN_I8259_PIC); + qdev_realize_and_unref(dev, NULL, &error_fatal); + + for (i =3D 0 ; i < 16; i++) { + irq_set[i] =3D qdev_get_gpio_in(dev, i); + } + + return irq_set; } =20 +static void xen_i8259_pic_init(Object *obj) +{ + qdev_init_gpio_in(DEVICE(obj), xen_set_irq, 16); +} + + /* Memory Ops */ =20 static void xen_ram_init(PCMachineState *pcms, @@ -760,3 +786,13 @@ void arch_handle_ioreq(XenIOState *state, ioreq_t *req) hw_error("Invalid ioreq type 0x%x\n", req->type); } } + +static const TypeInfo xen_i8259_type_infos[] =3D { + { + .name =3D TYPE_XEN_I8259_PIC, + .parent =3D TYPE_DEVICE, + .instance_init =3D xen_i8259_pic_init, + }, +}; + +DEFINE_TYPES(xen_i8259_type_infos) --=20 2.43.0 From nobody Fri Oct 23 14:31:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1792160566; cv=pass; d=zohomail.com; s=zohoarc; b=jULQR13tPjlYXSxyIAUXx3qgT5zNmEP9W0+aJewO9lMHg2kdhg3ZyMGi4Tu+m5cuuw5yFCJ28/h0E/bFZKBJS++IpgpPprPaiOu2resANVwbMVOQyWWz29BD6ETtiBp/uUeOkWAVDOHFdA7tze1l/9I6Zh29VEJmYF+HniDpXGo= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792160566; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=WyA/oexDigpjp1MqIVZSX3oyJADfec6ddFmZwK/KFs4=; b=Ao7eAp0bxB9pcn0JiajwxyCy1UyJ9BOCwPfDD/laLBIB+/0qoaaiyhuzoegkM4pL46OVu7CdGuVyj+zrI7aMAw8Wg4R2Csm4hfu4Ro19bolD+ctrHKh0/eRNpKU3pRIWB4TPzOMnSkjm3QWRUKMMTXvUT2zQ+DbvLLACkjQtNKs= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1792160566185595.2561201914029; Fri, 16 Oct 2026 07:22:46 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1452025.1666978 (Exim 4.92) (envelope-from ) id 1xHipA-0007Ig-7d; Fri, 16 Oct 2026 14:22:20 +0000 Received: by outflank-mailman (output) from mailman id 1452025.1666978; Fri, 16 Oct 2026 14:22:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHipA-0007Hy-0p; Fri, 16 Oct 2026 14:22:20 +0000 Received: by outflank-mailman (input) for mailman id 1452025; Fri, 16 Oct 2026 14:22:18 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHip8-00074x-Fq for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 14:22:18 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1xHip7-00Cce2-SS for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 16:22:17 +0200 Received: from [10.42.69.1] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6ad23308-8faa-0a2a0a5109dd-0a2a45018e7a-36 for ; Fri, 16 Oct 2026 16:22:17 +0200 Received: from [148.163.155.12] (helo=mx0b-002c1b01.pphosted.com) by tlsNG-d62444.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6ad23318-5984-0a2a45010019-94a39b0c31a0-3 for ; Fri, 16 Oct 2026 16:22:17 +0200 Received: from pps.filterd (m0127841.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69GE5DbC3215898; Fri, 16 Oct 2026 07:22:13 -0700 Received: from cy7pr03cu001.outbound.protection.outlook.com (mail-westcentralusazon11020083.outbound.protection.outlook.com [40.93.198.83]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 4hb045k1pf-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 16 Oct 2026 07:22:13 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by IA1PR02MB9592.namprd02.prod.outlook.com (2603:10b6:208:3f5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.522.15; Fri, 16 Oct 2026 14:22:11 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%4]) with mapi id 15.21.0522.016; Fri, 16 Oct 2026 14:22:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=WyA/oexDigpjp1MqIVZSX3oyJADfec6ddFmZwK/KF s4=; b=SBxmJgvx5xZXM3qjZUP5KnAN02qD8RBzw3oAeZHaq7E1Icr7c/Sndvj+c O6QU+pIPEH69DbM9JRbUnjcWPEYbY8E+tZL7swWVy9cP86RMI8DlUgsDG5n53tdr Q3SLeW5ncixnqym/jnelgNii03EU/bk7SeEm3FuH+yLABYFzVnIAYpmq9+7zYvXh Lm2EGWwdUanyabvx2zNE3koTCSdQzt2OYN/8C7DslpksLXRQUb9llQlKzE3VWrnk loLiEttlmvYwiom29lLCmGibTDeCjM94P+BoGPB0OgXERoYlc6srHqyf043EgrBD E+fnCFCZ//h1sL9fR64/nKhheYfNg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AVoPzWnpIdaOvUhn64na6QlOJ5cFty30Wmk98CA1tsurCXO+F1h8CXuHwTi3+YYfhXvQ3wo4SAotxxdBWFzOuqVx5g1h4FOKkm3l9QNAHt1S6wZRzlhEaQa4+4pNKMz925h7ZNbANCJH5NaljOpwQRl/W2Pa6GlwPHt7cPdZnsb4dA0pKoaxsQMUD5bhPhDjieAB/N/FnvA4AByZ4YZPiibhH1JnjsZ4i2magfN3FVm7cH0DlP9hIwznFrc5WP4vkmOD/5wh0ixFDBHcoP+arEfEJyyRkL86e6ks540BW5NferSlORzlFIvBqQE0dzImAtqGnBAMAT37A7r0dg+HOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WyA/oexDigpjp1MqIVZSX3oyJADfec6ddFmZwK/KFs4=; b=zOQThd3PwuSkIvrmMlZSSVdvXWJFHrnsz+fHvdRKEZGaG5ZqoTeXlfK86qOU/wlwVyAlyXpY/rXhHIoIBEczN7IKuag6F2QjsJjUopHXB7GM/QgiG0IQ4cHJOLu2LBAQfKUeU4zgZB7YX7hTISzJKswg4JIV6EPonB3dF2ChA0k+L9hzvP4S7wSmxUDeZfJhRg4C3p/Up3mU4Sh4+ivsZ966GC2uscFAIw2V99ieL6R03aPKTQhV7PlCPt+gyko0cBCfExXTCqRWji0avHCpmWMZmE+XgLF1n6LBDpghY/AdGOmm+C0shFEDvmafIoC72M/xlTBoL9M9n0jkU/HLxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WyA/oexDigpjp1MqIVZSX3oyJADfec6ddFmZwK/KFs4=; b=QByADjrZzoqlF1WdJ+gdYu3//EKAiqMoOYLBtloBwXw5yKGMrc7CC8RWnlND3LCj7ZP0s1kM9veoa4JNnFnUrrGbFRn1DaVaW3I2JLBI/409HcwXCihx/avbT62LH9vNm9suci305AqC5l1SPdrvdBjTEDjPKSeGMau+rcmXLK07wOCYmsvtdKyh06DxO0BlN2DVfUHJWwCJUxuh5M+q7+l33jvtbRagPi9k3/S4EceVGgK6RuDwDNPNrzogm5Xssugq6tzqPhZKO347Q5mxXnOXo5qGZnKSo53urj7CMYNoHxFHh7oj/olV627SqL/UMzje/3Ls/rYnuDTVVklTOw== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nutanix.com; From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH v2 23/27] i8259_common.c: remove unused i8259_init_chip() function Date: Fri, 16 Oct 2026 15:19:29 +0100 Message-ID: <20261016142031.1204281-24-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016142031.1204281-1-mark.caveayland@nutanix.com> References: <20261016142031.1204281-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR03CA0013.namprd03.prod.outlook.com (2603:10b6:a03:33a::18) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|IA1PR02MB9592:EE_ X-MS-Office365-Filtering-Correlation-Id: 96844c28-9ad4-4018-37fe-08df2b90de44 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|23010399003|366016|56012099006|261009223027099003|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: Q7COnebCsg3z83kVbwkzUKGDwsBFAcL3mJ/kaxmaWCJr3V9Simo4bEk1egT6rFoOqviGSHfy9gHtlHrsJrOnKSllimq9wx4w9YQxL60zTQFbVh17627fU5QcFyKjmc+DuuTQLPFzgSrq10PaUgeZWmY/dk6zTgY49+Av6lDH5aGO4HMmnBCytKyJf9KqhEuty/IZm0cc1TsQHLFcgg+MO2fs89CM8f0Qhy287Ie4PDz0GMHoDK7lM3s8uqIk94De37zhMADm0+D3Vrynhw1aunZAlxQtGxapg8mVsvFfTx4MHUGjkicttX9WNhLcN15AzrrS8LrwwtyR3rRWAOBgRV5QPtLm2bfwUmN1HztJ+lMmHkCVrTLv6xY0saqpqVnT/xNDbR/tinAuQRUehgb9sd3ba6RNZ9fvWKVCC1KBgM1LwhRi82SkXjUPrNTMM9lx4xohxqJr+e/k7k3I+CR9wDRAtMNxOIMcdvuwZjSL6K05qsvOXZ8GgAT+1IHd5QnsW7b3rZDAWx58ZBRaJJIwZMhE4dnyfcspPFUtZ3VgNCDfSWcejeHnN5fw0kEWp2fhAaF7DhJG5Tj6GwI1ojKXOUzwsnHXw097xu4z2b9UKhQiTR5IpKc1Ao94sonjqeh1hS6qFep8Z2yMHzJNNsAnVZ5OVcsX0pAemKSjmG/Sku8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(23010399003)(366016)(56012099006)(261009223027099003)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1r9g4g7/cBPL0WZlWW7OBB5FXXlA0THp1xxRcO6hZ7B8IdcLp3gpfWOcLnz8?= =?us-ascii?Q?ngqibE4sFm4rwLO2sBukq8SURqB2Wy6n9MHWObvH+apvhoT64qmKeOtBMfpS?= =?us-ascii?Q?t9pUEj8DC46PNrCXM1d2V2PRWJLTM0o7xFp5qbXT9eiyhcvnK8c/vmUi4ZJO?= =?us-ascii?Q?PGl5bVUXaa4Er5/UhCxl5FKzporPG1UUqKSP90LBJeW+rdQGRspOO9jUmIsU?= =?us-ascii?Q?sA1JrOQvaRjD7BUin6At8WOsBfZ8s5bgOAJb0plLVvXRsBULAF2OXQI6tCCX?= =?us-ascii?Q?8Xm36TF//AIFtUwYiPaNJpENDWDVsTElKN2+zroFafRCo+RGu/ei3nNq6cAu?= =?us-ascii?Q?sZfu6DYSoZm/CD8x1QtdRipHg/AV/2524X1umqpKZcTRuCZqMKnDqVXdXDPR?= =?us-ascii?Q?4vNWERVxULeJPdLoAskx8nKvq9hKFntCC3kcSNwLwaAAXcfKK9WMwDLwwKUw?= =?us-ascii?Q?9cug8fErEClOperNsqYEw/vuq+P3iIDDuDLbhXxtlovaeyGeqhSRIim0UXpn?= =?us-ascii?Q?I2oVbd+c0bgrT4qXRh7zH12NjiN6Who30kSYYTSEIZDILHQvfPVsA8+MNokb?= =?us-ascii?Q?OdAS7b6e24vAUHhap5Feendm0lXha1eGB/K0gtYUtkN2rPEewsv1TQtf7rVs?= =?us-ascii?Q?xTbWj1//EECcLao+y1yZ1Wihi7Q/573Dq8OGUZAskCuzx5RBphiPXm4LOM2x?= =?us-ascii?Q?ZkLqVT7Sxv3IwMQ005cTqdh+bm9zjq8i2ytEVqYr8WaJqI0b5xDCYHsMbrXF?= =?us-ascii?Q?XSbMH5IMaXhyvwogySRNnqAliVEJO83Kw8uSZPVOep3sv5fPOksMz8O6SBOi?= =?us-ascii?Q?va/iOyMo5uvE2y/1ogl2MVBfjYNRbOVzMDONrJKLEyuV/BI+aUtBDfEfYwCs?= =?us-ascii?Q?aFOkVr0JYoAx6pKW1f6EqDRLnyU95dLAx/s+EA+Vy3kAlo4+rwdSN7BNoNg1?= =?us-ascii?Q?BZtr8Hx9wwIlKNYXJIloxdX6EDOaeZwmYP8ZJwIVkRynLIR6twer6ZS3rHE7?= =?us-ascii?Q?r9EC2Y4L06SduUzfXMmt7q2G1oERONoqehWWdrQslJ7SFhGwBmObkEyOczZJ?= =?us-ascii?Q?Ps69sLYXJRrv64XyRPJss+HwQthMcpI3st0cycg3RXRSG2x5pZ2eiT/U5wzc?= =?us-ascii?Q?3JMkQawXmdLTBLguJoRWfp0oq7AO7RG936+ZdIQvmhNnERXXLYQc37qkUFDu?= =?us-ascii?Q?S7OHDss1xhXamxGqFkce183au3bw/i60eb4zhwDTZoays1QMsZ2Xrxh3W1Ix?= =?us-ascii?Q?5knRYCwAgvOfTlX5kkjQxxRmY5wvENyIXJ7loutIXlkDLirFEAB7w1K+Ntco?= =?us-ascii?Q?HK8i/TRio4HXDePVPRX3C5tauXStJY3I+3BYasnFSKO9TtcVzXCu3aNJGYYN?= =?us-ascii?Q?5BjIl1n2Uz6G2pTWdi/b9qiGDCoiQXnI8kiPzdYHpsle4iuus49TvzMtMZuY?= =?us-ascii?Q?MfrSvaZFoE4f4oFMB0pX1/mcdNdu7btxSBneNIZqNHmNvVFA4bPMDo4Cq8C/?= =?us-ascii?Q?OdeSGli/FyDkgoLBEoauMLCeOaKGnbE8nUu9oi2xweFj12R19cnrcPgbRfAB?= =?us-ascii?Q?T9GLHJ/8Gbh2h8DCbiS4IShW3F6mduMFKy84gHTdMJYtOcHo2i/GBk44vV6f?= =?us-ascii?Q?MwYFtOKwLhGC/mwpZ3xqKWFDX8rIn+hnY/V60eiXO7HFjjR8yVR6bv3vc5wp?= =?us-ascii?Q?O5IlQJGGHDVVnOUCmCFxM79XuUlo01hsG+yVwEHUBCTJv2NIo1p85Ul82DVM?= =?us-ascii?Q?3JS/hk413vHQ4wMmIs9vmlMYHkQLHtI=3D?= X-Exchange-RoutingPolicyChecked: 2K9/yUrrDwmP+mPI2UuTQITLmL1KV3A1zhiVxa16OUdzVxOr/9OjQoAlL52m/C8UQwBjto6JxLsBkDFynguyl0i2n7mhlXXHAFtjsqne1+QHnsUYpSOH69Qtxi69oYBcunI3I6MrA1QViFJkPGGhXeAaLULScw9GnCiBB1yNzMh34g7HnT4xuZWUQ3RmPortGyAGy4ofQhxMmPm3mFQ7KcXPjiffnQRfXOHa4tt+YopZL2kg9lY3J4eNPro/3XfNGi45wo9Edk/D42DUT7ksCJXhSUkVYSPC5P4CFm4pJl3idyWrP/wHFdf4nieyZYW8g+tUwuPSaQDSPnLk8tKYAA== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 96844c28-9ad4-4018-37fe-08df2b90de44 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 14:22:11.6876 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LvuMI4TcOTeJlGZ6HIK47l0hEBMv2k0KafEWGZIaGMhOpi7GvWAJKd3c+l0cDvC+gQhioPVSxkPDexMfsPd++Mc0eCXeFL8pDp5D5uMWPgY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR02MB9592 X-Proofpoint-ORIG-GUID: ZlJq7WZujRoX8SyiT5TdjBPyIii0Ju6W X-Proofpoint-GUID: ZlJq7WZujRoX8SyiT5TdjBPyIii0Ju6W X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX1roMPiOyHGdr O9iHYwYLy4F7IwiRCrbcCJYmmeiyI+aMzmFoDpgB3Y0c9gAIoHQ9/G8Myi/DSEewqNMWn9yjvW2 SjFA7jESMSjiaire3UQUe2tVlYUs7/fUHIFQF+QsFDjvfA28jBVcEU5xvb8rTXxtROVDYqbrBro Tlqt2vF3HuxZeCrWPWyJGm8rVNUI/1FSGLVuQngzu6PbbDxiVk8YH7WVNFSP/MJlPQQHlI5Tvqj 8lxgWGyd1R649A6ypjEfJx8iycEDgp1JgMLsWLwqEq9gnlcv9EGhlkDppzEnXT38nZ3mYFXwCoe a6BniUiEpRNMC/StsjRflaXXSkm9/Pmj1epcDOljpb/fRW4umU+IOoMDk01OKi5oMH4qtT9Eas2 k7hFD6ussMrN2IkNNXEPrXcmHr4Ga8V0C8kb1SIk+l5hMVnEhm7+WVuNXW83BrW8T6wPOYdoW7z gicH6EuJ5rasYxrbc4w== X-Authority-Analysis: v=2.4 cv=V/ToQuni c=1 sm=1 tr=0 ts=6ad23315 cx=c_pps a=N2BSJ/IBjBq6ipLGDtrT5w==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=660iZSQnnn4A:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=jxMXjlTPpCISP5mWtjnE:22 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=fn9E0C1quIHmE1dKZfwA:9 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX1bsxiAzDK1+J /G2VXPlINswXk0+wq0e/enWmDQO1yvfogtMVdu75wFHXJR1y8dm2Ul0qgIy+VIJmC3Rv5WA/FB6 FFXeRVtpOyVuTDlWHTLMN4YpTHZqVdg= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-16_02,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-d62444/1792160537-C5146757-FC8C2BF4/0/0 X-purgate-type: clean X-purgate-size: 1704 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1792160566926158500 Content-Type: text/plain; charset="utf-8" This function is now unused and can be removed. Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell --- include/hw/isa/i8259_internal.h | 1 - hw/intc/i8259_common.c | 16 ---------------- 2 files changed, 17 deletions(-) diff --git a/include/hw/isa/i8259_internal.h b/include/hw/isa/i8259_interna= l.h index 644508a44e..dd255fac24 100644 --- a/include/hw/isa/i8259_internal.h +++ b/include/hw/isa/i8259_internal.h @@ -71,7 +71,6 @@ struct I8259CommonState { }; =20 void i8259_common_reset(I8259CommonState *cs); -ISADevice *i8259_init_chip(const char *name, ISABus *bus, bool master); void i8259_stat_update_irq(int irq, int level); =20 #endif /* QEMU_I8259_INTERNAL_H */ diff --git a/hw/intc/i8259_common.c b/hw/intc/i8259_common.c index 09b761321a..5fa38fbc5f 100644 --- a/hw/intc/i8259_common.c +++ b/hw/intc/i8259_common.c @@ -89,22 +89,6 @@ static void i8259_common_realize(DeviceState *dev, Error= **errp) qdev_set_legacy_instance_id(dev, cs->iobase, 1); } =20 -ISADevice *i8259_init_chip(const char *name, ISABus *bus, bool master) -{ - DeviceState *dev; - ISADevice *isadev; - - isadev =3D isa_new(name); - dev =3D DEVICE(isadev); - qdev_prop_set_uint32(dev, "iobase", master ? 0x20 : 0xa0); - qdev_prop_set_uint32(dev, "elcr_addr", master ? 0x4d0 : 0x4d1); - qdev_prop_set_uint8(dev, "elcr_mask", master ? 0xf8 : 0xde); - qdev_prop_set_bit(dev, "master", master); - isa_realize_and_unref(isadev, bus, &error_fatal); - - return isadev; -} - void i8259_stat_update_irq(int irq, int level) { if (level !=3D irq_level[irq]) { --=20 2.43.0 From nobody Fri Oct 23 14:31:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1792160609; cv=pass; d=zohomail.com; s=zohoarc; b=hUWZfqt4paZBT0axZfJGRdKwevilGl9FgvaKnVPOlFnsGkDwJ/bCdJOSYMWf9Z/tdLwCpF1LIuZXCMTXOHn5HvDBulL/MARo/Kjz0oZ7FTWGI58n55pefHc8xzcZufdG8/9UU9A0ekLaDzqHaHWO9trR5jwcye7EpV+Sb0Nig3w= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792160609; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=ziHP+FkR99iqwYK3tusXaSde8vh37ejRC7j5NAZW7bU=; b=NE9Qxu50JtxnqVXDxOFCHUeCQhbUKAAhbhNa9ZS7MRabphhyQqn2CzYD8tnCOVW2d5k/C9CMoHPvsoHO/g2kGBrBgkcw+oQPAkQIFXhtvzpxyphNwiB6e2GDtf0Ig0Jlm4ZzIhjwH5fbuepyQWWx7xHOuUQX/Sr6AMly7zibhFQ= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1792160609462203.87081888482533; Fri, 16 Oct 2026 07:23:29 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1452072.1667001 (Exim 4.92) (envelope-from ) id 1xHipr-0002EA-1F; Fri, 16 Oct 2026 14:23:03 +0000 Received: by outflank-mailman (output) from mailman id 1452072.1667001; Fri, 16 Oct 2026 14:23:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHipq-0002Dy-T3; Fri, 16 Oct 2026 14:23:02 +0000 Received: by outflank-mailman (input) for mailman id 1452072; Fri, 16 Oct 2026 14:23:01 +0000 Received: from mx.expurgate.net ([195.190.135.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHipp-0002Cu-N8 for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 14:23:01 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1xHipp-006AtF-3X for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 16:23:01 +0200 Received: from [10.42.69.5] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6ad23337-8faa-0a2a0a5109dd-0a2a4505b660-26 for ; Fri, 16 Oct 2026 16:23:00 +0200 Received: from [148.163.155.12] (helo=mx0b-002c1b01.pphosted.com) by tlsNG-c201ff.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6ad23343-4cb1-0a2a45050019-94a39b0c2e2c-3 for ; Fri, 16 Oct 2026 16:23:00 +0200 Received: from pps.filterd (m0127842.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69GE58va1681992; Fri, 16 Oct 2026 07:22:56 -0700 Received: from dm5pr21cu001.outbound.protection.outlook.com (mail-centralusazon11021130.outbound.protection.outlook.com [52.101.62.130]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 4hberu10kd-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 16 Oct 2026 07:22:56 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by IA1PR02MB9592.namprd02.prod.outlook.com (2603:10b6:208:3f5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.522.15; Fri, 16 Oct 2026 14:22:17 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%4]) with mapi id 15.21.0522.016; Fri, 16 Oct 2026 14:22:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=ziHP+FkR99iqwYK3tusXaSde8vh37ejRC7j5NAZW7 bU=; b=BDJpZ+D5fl2bnzCge47aa3Kd1YMsIzH1CqzfKsH97l5o04uWQmmbrA13R 0Mf8g2tcxatYv+bIqISS5ToXhvQRlyzkkrKih7xgTVGt228e1ks3ugq6QUJfG7r2 X7Htt1UUiPGL7tNfDrzy9zer5mKsTBYux6Ql1wzNsFQzuMeC1tJzpqsCUdnZq88w K8a5uGCt5hAMOLRxO14HnugvQjRh0n40UqOkjPx2NaasMqGdDuyKbBuOxcwcOsSU 07CjAA1FnzI+eixe+E/tX0KtJtp3Qtbzd9nb7DYvjmJTQ8Awc70ZtWDXplllFfDH KgEVWt2gH+BoSK+uOSSmQ1BaI6mDQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Q2Rur7h1PDySYewi74qnmCGEGY3oIY0KIuXiQigUWMiNC7JNhAqmLGtB0bv2hxswK/tQLGHH72+N0Z7k2RMPDxFoF2PoHHYXSBO6zfhJ55qjs6zNdD4KRKDLM6H+pDmknD9I0EyWkDZwOOB9VQKbQW3ga2CIfj+3Oo7h9zjKF0APmVJ3R9GUWufKz2lSdzRgVX3MCPIIUoY7v+yPLRFiCflVPBBfpk2mfg23V71iCkwXR9tZ9XxdHFg07lvIJHDWdBevStK4zlF8TxwSezQzmhkNpRq5rxx4viv3gEsnxkajSsXVWNy+0cZySJ5jwRnh53AE2HWXJ8PypZHoDxEy3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ziHP+FkR99iqwYK3tusXaSde8vh37ejRC7j5NAZW7bU=; b=WpB6iVs4Avpd+5jpIQQROMTCKzHjxGtkTYT8yI8o9yCEnDVgk6TpMJlCDu7LophTU1X8Mwq8YtC92dQc4oCl1trxNhBmSkwEze9aG8FKuoZh47xenZ/RqHGrTQ57qlB6KwkjBJ0QV63s5JJJ5alnJe6GPPflDa+UIrT0wIvp+VGaeLsNkAbH4tkiZYmMK+yrUH3XrAYmCQ3jI+HUDUtef6hsCAbLazlKLnfCNeCpKPuoX1RLRSpH2tCzjj1NlvHh5LNtz4XmXezRjI+RLaT288jBwqREtazj5yQONT419f5pVLjZ1QgL1W1pf0KSfo5AUW1uylNlqsBYaWdSQeirkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ziHP+FkR99iqwYK3tusXaSde8vh37ejRC7j5NAZW7bU=; b=BR9T0uSbhJl3b67zhBEpFsQqhAC96UlwOWQtNoTOJFyt/poYWP0YHXbN9SX6rqEQ1/OPK+Z/Wd4YXVwhFL5oUjrmN/VPLSBvSUD3MShvPLDFY0ARi5vItnuu3uQIFBifxj8Wdkq/KVFQLtdhR7bORfpJYs7Bo10pMyJZO/lGkMf6GSt9c9/fRjkuzUxxYNpGOsZaYCx2dxRnDbiBSy8zqxDLTtuJwwxqVpyo/2k/r3K6uRovF0vJbP8NLeUS5/pJetrlUD5kdLVlKHpwEI0Rvnvn3ILYyNADsQPRWXcPpUMi6/zogQdzsLIsdQUAjxX4N9Glv5OgWdDu8zjnlQwaFg== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nutanix.com; From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH v2 24/27] i8259: move InterruptStatsProviderClass get_statistics() from i8259 to PIC Date: Fri, 16 Oct 2026 15:19:30 +0100 Message-ID: <20261016142031.1204281-25-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016142031.1204281-1-mark.caveayland@nutanix.com> References: <20261016142031.1204281-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BY1P220CA0023.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:5c3::11) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|IA1PR02MB9592:EE_ X-MS-Office365-Filtering-Correlation-Id: b9799841-b194-49b9-1fbf-08df2b90e172 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|23010399003|366016|56012099006|261009223027099003|10067099003|22082099003|18002099003|3023799007; X-Microsoft-Antispam-Message-Info: FTTeuAPqd5r9QrqgjwLPY4mU12Lzl2aiSSKnvQFxGAf+5PYcOfiCG0Eljkgn/q3NsosIqgrDf1BJw4DRho38E+OBM3Kc3CkPZ2vsSA6eUD6ZsytOa5aOOqirYQqgpiBvNLNGishjV63rCE+xPVVAhGBY/Bb5LqYeSD0f14zu3tQ92R3xADzN7bFrcZBFuVin6SxpqrdlckAo+9MEL1DHKo07Psu7+cCNSjrXJDQnhP00r3x+iIY3sKB23hUs95R7MWpORmpamOUEhSX0mH9tiGzIkNyQLRvP1VIKf6DysI0cTrkvCw0fGwihRGhKzVe6uV6FfZcgCTpmyacQfI83az/WLCDVf1qpnZLm4TBXFLywfqzym5Hw/JnC5y19qzRk40chxpDj8F+/6anPzRufElhduxuZPgSormDJo8XUvebVItt7SrcmaMTiKLgqvwHZ2D1Yezz5TsxCKjydXV+sQRbVvKth4g4hFpgQJzAu4Rhsc3lCDDf5E+kP3dBGbnyoyQnBntR7bCPWP01PXFnaegYAATuxm7EhImBCTm4Z0bBSr8FDqcQlkjoH+ymN1w5Zxtanebs2U/vXXDufT4it8JbuBKwuKFVVby5uPSNg9NLaZOHCxcPGVrs9YY60ATUqELRe+ZrjrjePbnb9VXo2suHZgmrQfTxalAlWBNBAv6k= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(23010399003)(366016)(56012099006)(261009223027099003)(10067099003)(22082099003)(18002099003)(3023799007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?C12UZidlEpEulCwXgv9ijkwPRRDqJOFaHppr0MORGZwmts7fLUKrTpTJzgmA?= =?us-ascii?Q?ot7Vb6ig6KJvWlbUf74udwe2H5AAmSwzEQRu3ZnHE0wry4nSOGqmqvzP9ymw?= =?us-ascii?Q?rfzFIbR1PAtctE70NTZ+b0KL8MBHfPmTQMAnGVq2lrj+7NHDV4xkStPZ7jtP?= =?us-ascii?Q?VoQGWlOSjbRhd+CYzJ1Hro/kb10q/LW88nrJdUNgaEsji9oFfXJ+v33VY3kZ?= =?us-ascii?Q?Ww69xKunOFw4V1HA7Iak/WaybSfvZdSdDvjUUDRjOIOepvDh3PQvxYh4w0lD?= =?us-ascii?Q?wj67orIkCZaBqOuQtnPJNZxHHL7sqhg/Y8O/sqHuyhZHU8lCIbdeb23QgMGJ?= =?us-ascii?Q?QqdZkhdmASkfCZEJHCi/TjIK0WFtnR/YfKtGXjzZa9wFXe0y4gEKMrACr22F?= =?us-ascii?Q?UduiD+zNpGUAM4sZgf3K0P7G8zzgZz6K6Np31My9ZW1qql+X1Z7fZ6O//nvg?= =?us-ascii?Q?0/6cvxS+ygvOign4+agu7uLpU/2DhHscXICclEJxiNXMTwvl/VDg1J431zbp?= =?us-ascii?Q?0q7ctcOW/nC55022c0LWeoLEYyhGRF18dynuj6MkWIo2TjS0rE00/ytlI1Wk?= =?us-ascii?Q?HS/UxDrnFrKhvgl9E/kdfu6lT3209h0b9EP4p/jLgamby4db79H3s4IoGq52?= =?us-ascii?Q?iKq8hYGUar/tEGWh/wO3epS89NuqVcIJRhj3nSBC0aRN8gou1d1TbQKpJU4B?= =?us-ascii?Q?mv4Xr3UnYzkCw8RYC58GgnsXSOXnJ5pyT24UGor4iPs++SXGQES+pI0F9lHE?= =?us-ascii?Q?XpC1CRDEC36rzbZa53uWfsQKYVsP13pCrg2UWuVOa4PsyN5ZO92Hw48hDlC0?= =?us-ascii?Q?e/C9V5Z/xIs3uejvMevmUC9Wq68+JPWB5Qf5tT5pZJHUq65sDPcbOuvA/SSg?= =?us-ascii?Q?1eHLeR0BxwGQ5lNkLx6ezI5uF6vdjMLudhH3L5FPJSOcxGNAGXSbGGbvqlRg?= =?us-ascii?Q?f/MYt4aqwElWkG1Tsxp4C37rGsUy4EnYHItzvAzK/DMtYmD8NWN7E18EHUM9?= =?us-ascii?Q?2fot5GZUqV8VbXag9WmYvxjqtqskKORMqtyoo+pExsI9iy1uB8KHfbxSKofz?= =?us-ascii?Q?k82pCVLBHPddjWdZTl5aIMBGFohXIZI09skWVxw0DST+xHlTULAyBje162mt?= =?us-ascii?Q?+Ie6pOcN/jZpLqhpgaPDD65A9tV7WobWtqOaf1zZGncwyIwKWTMo5idQfsC6?= =?us-ascii?Q?zHBPg3H63m2luYl1n8g4+tCYTlTbvJbZpCnXimR8gI6+grUhPDnysa4AtrNK?= =?us-ascii?Q?ndNfj9wAP0Aa2GfPF5/EEA8dN5XMBwgNb3Qw+GyWc+UiYsYozgaTx6rerBw3?= =?us-ascii?Q?IhHpQ+Fd4nzcxOaypjyL2buoaj7Wjer1TKxkZs0PE+sMvF0O0V1WmsO/fbFj?= =?us-ascii?Q?jNYq3wKvNWKsfXHZQN0A3p5H2ZfmY6t+deTN1el3sFghiIVAnbC1sZcDIO4I?= =?us-ascii?Q?Qh6tz9DXubruqr1/5Mxw27EkxKYXwofZztxbFTiaLLoj3HZCjTAlKASApRho?= =?us-ascii?Q?MhgStw4+wd3tm/WlIiu2aR8oCTFrCCZh/5IbxtwcYFfa5/ID/RKGE0M91D/s?= =?us-ascii?Q?yaquWwjYMp29isQJP/mRzM62Y+J6OU1BfzEjG0u6/t2l6xfR8640yuy3qyvf?= =?us-ascii?Q?QVH3RzRtkKwRV4b7HKU/Ljvlp1tvlQiXAasRUSU4y/jO2octB8yA5kPuM3pY?= =?us-ascii?Q?ayOkKwUHLl11Gf7yNFWFUD9mY/vmsE7DioU5SeSspeFd43Jk6FBcZXbFyEY2?= =?us-ascii?Q?9P8hte6JMNoCr3rPciNzmOd0FhDTUvg=3D?= X-Exchange-RoutingPolicyChecked: mf7gKKFnmPmPWbzvFh52vIJALLCO/UHqWtdDMQAgNpEE9JABVV7jS9k1hGym6+NJRSMcPg1a5S7IoKpxRlly6KABcvcSoHdoGGeQg/y8q+yRSuJKxP91O20EoNc0NXUGSPw3y80WZhiZUNQajUhtL6r8p7IiiCMJcLYv619qSC4dPQKbs221IvTSxqTKwrleZOORvfe4vkTkiDOgLYvPe9UuXNi0TeBjsLWkPDH4Tmso0sFookAA97ptgkS+PWRWF3ls71nz5A3e90q/qCIhYxoQD4wJ0l18yhSoPRIBTvhcLjrtp78LwhpY2oxg6+UeUWemHnR6cfkqUm0bty4hmQ== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b9799841-b194-49b9-1fbf-08df2b90e172 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 14:22:16.9635 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ieLJutlzFNfRUzut5ESdIcaQVqcqj3CFiJuI8Uy4cLVEwojcIrOfl/RCB3FoZLAePyyKdBnce5R4VyaoKt2LlBL9R+YhkTOlvzetyKWUgUQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR02MB9592 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX2981SBWjMKmu DIwJiERFGBNgOVJ/VkVUSwBB9h1D1eRv6Fah2NVAb+hsvikY4ovGahiYG/rDgREefRMjn6Hxlgm Hx1DqrSvKXVM6sVKFvOmNS6kKU1L6/OhEuwaXawsyT+rcLN8uB1pJCK0Hkk577x8UeTBfpwnRdC zc2FUJzBjs3OaldpUsLAKwy0ywvZZXsj2udfAsTT2uX61NLGCCy/GHOMXa7TQIJAKmZ45nDSK6M FabVNubmS3i87Muxo/eSG+p+Luq9icggtj8NDyt+LsOHmq3KVB0CryYW8WUdzY1E4oKrib8gmEf V3ebcPZ1PkzZNyUqy9MzVwXspCMHAXUj1RB1ZDkjHh8I2So5gJWPIwGX+h4gyQqmxpbtTEEhojV jCnZLcoqY4nteOvihhsVbntuclRcVBEiPGzmJaiq0DoWaO/7ok9wqKVchscvuCaMdSN2FbhhFyS XGBZevq8oK0QWeUIe/Q== X-Proofpoint-GUID: VXFWM2bAgemZzatva8USUijwobgDTMul X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX0f8IOizkHlZS 5qYHu6El3erG2hD/ldQNGVud2ZntCoM0jC9TngVQ/DkNhGdpY1A9NJeFjksMYcbQqc+/Evm9tn5 8u20PWtne1PpKpOz4/NHXcjXltLX4JM= X-Proofpoint-ORIG-GUID: VXFWM2bAgemZzatva8USUijwobgDTMul X-Authority-Analysis: v=2.4 cv=KMLPn1Fo c=1 sm=1 tr=0 ts=6ad23340 cx=c_pps a=7kgNGXaSmB15KJ6u7rEBag==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=660iZSQnnn4A:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=VUi8bpU7OL1Oj2-RSIOF:22 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=A7cMN0_0mIGH7w_oRUwA:9 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-16_02,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-c201ff/1792160580-F5CA82A1-FEFAA82D/0/0 X-purgate-type: clean X-purgate-size: 5964 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1792160611840158500 Content-Type: text/plain; charset="utf-8" The internal i8259 implementation has workaround logic for storing interrupt statistics since these are currently recorded at the PIC level (i.e. for all 16 interrupt lines) whilst being stored in the master i8259 device which on= ly has 8 physical interrupt lines. Move the get_statistics() implementation from the individual i8259 device to the containing PIC device in preparation for removing this hack. Note that this has a visible change to the "info pic" HMP monitor output since the na= med device displayed by "info irq" is now the PIC and not the individual i8259: Before (TCG): (qemu) info irq IRQ statistics for ioapic: 0: 68 4: 1 IRQ statistics for isa-i8259: 0: 68 4: 1 After (TCG): (qemu) info irq IRQ statistics for ioapic: 0: 47 4: 1 IRQ statistics for isa-i8259-pic: 0: 47 4: 1 Before (KVM): (qemu) info irq IRQ statistics for kvm-ioapic: 4: 1 IRQ statistics for kvm-i8259: 4: 1 After (KVM): (qemu) info irq IRQ statistics for kvm-ioapic: 1: 3 4: 1 IRQ statistics for kvm-i8259-pic: 1: 3 4: 1 Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell --- include/hw/intc/i8259.h | 6 ++++++ include/hw/isa/i8259_internal.h | 1 - hw/i386/kvm/i8259.c | 7 +++++++ hw/intc/i8259.c | 7 +++++++ hw/intc/i8259_common.c | 27 ++++++++++++++++++--------- 5 files changed, 38 insertions(+), 10 deletions(-) diff --git a/include/hw/intc/i8259.h b/include/hw/intc/i8259.h index 87ccd55a4d..d51a7fde32 100644 --- a/include/hw/intc/i8259.h +++ b/include/hw/intc/i8259.h @@ -1,6 +1,8 @@ #ifndef HW_I8259_H #define HW_I8259_H =20 +#include "hw/intc/intc.h" + /* i8259.c */ =20 typedef struct I8259State I8259State; @@ -18,5 +20,9 @@ qemu_irq *i8259_init(ISABus *bus, qemu_irq parent_irq_in); qemu_irq *kvm_i8259_init(ISABus *bus); int pic_get_output(I8259State *s); int pic_read_irq(I8259State *s); +bool i8259_pic_get_statistics(InterruptStatsProvider *obj, + uint64_t **irq_counts, + unsigned int *nb_irqs); +void i8259_pic_print_info(InterruptStatsProvider *obj, GString *buf); =20 #endif diff --git a/include/hw/isa/i8259_internal.h b/include/hw/isa/i8259_interna= l.h index dd255fac24..2807409eff 100644 --- a/include/hw/isa/i8259_internal.h +++ b/include/hw/isa/i8259_internal.h @@ -26,7 +26,6 @@ #define QEMU_I8259_INTERNAL_H =20 #include "hw/isa/isa.h" -#include "hw/intc/intc.h" #include "hw/intc/i8259.h" #include "qom/object.h" =20 diff --git a/hw/i386/kvm/i8259.c b/hw/i386/kvm/i8259.c index c51738dd44..b56e4fced4 100644 --- a/hw/i386/kvm/i8259.c +++ b/hw/i386/kvm/i8259.c @@ -223,9 +223,12 @@ static const Property kvm_i8259_pic_properties[] =3D { static void kvm_i8259_pic_class_init(ObjectClass *klass, const void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); + InterruptStatsProviderClass *ic =3D INTERRUPT_STATS_PROVIDER_CLASS(kla= ss); =20 dc->realize =3D kvm_i8259_pic_realize; device_class_set_props(dc, kvm_i8259_pic_properties); + ic->get_statistics =3D i8259_pic_get_statistics; + ic->print_info =3D i8259_pic_print_info; /* * Reason: must be wired to the ISA bus via the "bus" property */ @@ -246,6 +249,10 @@ static const TypeInfo kvm_i8259_type_infos[] =3D { .class_init =3D kvm_i8259_pic_class_init, .instance_init =3D kvm_i8259_pic_init, .instance_size =3D sizeof(KVMI8259PICState), + .interfaces =3D (const InterfaceInfo[]) { + { TYPE_INTERRUPT_STATS_PROVIDER }, + { } + }, }, }; =20 diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index 5f90edbe60..842507f9f8 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -535,9 +535,12 @@ static const Property i8259_pic_properties[] =3D { static void i8259_pic_class_init(ObjectClass *klass, const void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); + InterruptStatsProviderClass *ic =3D INTERRUPT_STATS_PROVIDER_CLASS(kla= ss); =20 dc->realize =3D i8259_pic_realize; device_class_set_props(dc, i8259_pic_properties); + ic->get_statistics =3D i8259_pic_get_statistics; + ic->print_info =3D i8259_pic_print_info; /* * Reason: must be wired to the ISA bus via the "bus" property */ @@ -558,6 +561,10 @@ static const TypeInfo i8259_type_infos[] =3D { .class_init =3D i8259_pic_class_init, .instance_init =3D i8259_pic_init, .instance_size =3D sizeof(I8259PICState), + .interfaces =3D (const InterfaceInfo[]) { + { TYPE_INTERRUPT_STATS_PROVIDER }, + { } + }, }, }; =20 diff --git a/hw/intc/i8259_common.c b/hw/intc/i8259_common.c index 5fa38fbc5f..684290fb2d 100644 --- a/hw/intc/i8259_common.c +++ b/hw/intc/i8259_common.c @@ -99,19 +99,28 @@ void i8259_stat_update_irq(int irq, int level) } } =20 +bool i8259_pic_get_statistics(InterruptStatsProvider *obj, + uint64_t **irq_counts, + unsigned int *nb_irqs) +{ + *irq_counts =3D irq_count; + *nb_irqs =3D ARRAY_SIZE(irq_count); + + return true; +} + +void i8259_pic_print_info(InterruptStatsProvider *obj, GString *buf) +{ + /* No information for i8259-based PICs */ + return; +} + static bool i8259_common_get_statistics(InterruptStatsProvider *obj, uint64_t **irq_counts, unsigned int *nb_irqs) { - I8259CommonState *cs =3D I8259_COMMON(obj); - - if (cs->master) { - *irq_counts =3D irq_count; - *nb_irqs =3D ARRAY_SIZE(irq_count); - } else { - *irq_counts =3D NULL; - *nb_irqs =3D 0; - } + /* No statistics for individual i8259s */ + *nb_irqs =3D 0; =20 return true; } --=20 2.43.0 From nobody Fri Oct 23 14:31:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1792160604; cv=pass; d=zohomail.com; s=zohoarc; b=oFvgvJXyBk8/bsur0m0qePwIPOFE7VL2ocf+TG+adaXlbqVNCOb5WQ8dOhm3fw6f920Vmh8V55ko/m2ghXdnUvHbXMQgI+eLHqlzuSDpvJyTfVIBlrWooh1YZ7D/V5vrxi7wuJ72F8Swnwl69k6RjLM04ntGEpBfW7YAdJVI5lI= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792160604; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=jAxNlriqZfbJNNZh+y/GFC7hgEb92Xvhe6az2crKpS0=; b=mFPWJGxhAAha77ndRJrmQSirFJizozXG2peTeGZzdrohL95sVy5zNDSrUPUIwTEwmH1/qtAX3omT4BAi1neAiKAPnVN5trJwqh1fhsJ2vlTuW4fSWv0tlgq66TYO63HjYYVPud8q7WgvhluRt9ZzGpgG6ZffS5nlwIXCcDGbWOA= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1792160604890165.26879619503325; Fri, 16 Oct 2026 07:23:24 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1452073.1667007 (Exim 4.92) (envelope-from ) id 1xHipr-0002Hv-AY; Fri, 16 Oct 2026 14:23:03 +0000 Received: by outflank-mailman (output) from mailman id 1452073.1667007; Fri, 16 Oct 2026 14:23:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHipr-0002FE-46; Fri, 16 Oct 2026 14:23:03 +0000 Received: by outflank-mailman (input) for mailman id 1452073; Fri, 16 Oct 2026 14:23:02 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHipq-0002DD-1c for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 14:23:02 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1xHipp-001AqU-Ej for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 16:23:01 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6ad23343-8faa-0a2a0a5109dd-0a2a4504970e-6 for ; Fri, 16 Oct 2026 16:23:01 +0200 Received: from [148.163.155.12] (helo=mx0b-002c1b01.pphosted.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6ad23344-b57f-0a2a45040019-94a39b0cae00-3 for ; Fri, 16 Oct 2026 16:23:01 +0200 Received: from pps.filterd (m0127842.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69GE58vb1681992; Fri, 16 Oct 2026 07:22:57 -0700 Received: from dm5pr21cu001.outbound.protection.outlook.com (mail-centralusazon11021130.outbound.protection.outlook.com [52.101.62.130]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 4hberu10kd-2 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 16 Oct 2026 07:22:56 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by IA1PR02MB9592.namprd02.prod.outlook.com (2603:10b6:208:3f5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.522.15; Fri, 16 Oct 2026 14:22:21 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%4]) with mapi id 15.21.0522.016; Fri, 16 Oct 2026 14:22:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=jAxNlriqZfbJNNZh+y/GFC7hgEb92Xvhe6az2crKp S0=; b=ZnUCfq5+A2Iq4n1KdTCb2rO/6hcXxvWJgoTuC3RQFuPOLMtUSSF3NDKFa qb2PM+l0wABic5Mv4xnN9FTsFLG4a9teuW9SIcKeisU4zdADEsXaiT2mUELLlqCI gNJ2zAA32tRhZcKyXB40LPqOtnU3S4U0cViKRqxZgoUQ6uIY51IArJ9CBAD2FX1v 36eYzuLna3R9JF+028TzIjjbK5ZPolRFefc6l+UEUbSTO0fQXoxTwBzMYqH/nFGO ILboWvDQc3wPzkusueuaQAHHa0uXIox20kP9KynJ6lg2qKYf4qFYCG7o5+5qQG7p D9a4gvQiQbQyhqrz61ZEoODcHWuGw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iKSUcP18zu/1uGyjB9EKXuVoZ2ybVXS+Mnh9rDoSFyeZNsJ3yJvELHbWgF51IHntKXmMmW4l6H7goAL7w0QldzBKbwdbWXzKPLg8LaiePrtFz+BNnnNxhrnO+PF/4lKbk+kvJcNdCMVamoXSFmZ4N56IIsLyVMRdkXbpBOeuMcuK5N3kgj9Ed0OaghpjAsV0mGGSX0O6tbbAutyOqxRY3190Jtnrmmr28Lc015TnXTmpMD3NecUASQCCtyFuLpvjEZF7lx2ZWmMON3qs8UbEQiDu45YCGRxF/g7yYO0N/y4/WfzUe+n7gNysifKDchzE9S7ZWp7dLH7NKucbBtxFSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jAxNlriqZfbJNNZh+y/GFC7hgEb92Xvhe6az2crKpS0=; b=t4sP95qA/MXB9AmHP66jy/q0trOYclSaTn8YeCZ9BdoxoWMC2KV/z2NAxzqX74RnZshKhWNUO2xACVibvCqtU5Qbr2UXCiKn3vG8AhGfkrqQsLAOwZ+onUFRdGXuHJHWrScSwWKUqxWHV1sW8RDVmQh8owZSJtk7xojEuOxuZ40EGY5OqV7JY68SUH9BqGuUeqfntJVzlwVi5z/rboEcYcFkH6+oWArD/WLu1onTIS6lklY62nm06gdf4GY+P/TI39vsV7wc3JrOgo+j8T44dDFS0nOPytWX3noqtRUzuutd6w6TfvBR0THzXqiUT+KLj6lh0sVLW7P/IZwA6j72xA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jAxNlriqZfbJNNZh+y/GFC7hgEb92Xvhe6az2crKpS0=; b=Xs6djbaPq4b430cIxciznJ9mkcsBy1bcpvFF8fekM2a/CktKADtBRFMXb/n3BqfUYYqIe5yipVuiCBdWrRMiNjt9gbmdfMtSqI2zaXIM1qzskxOkVNNv34QYAZFN8+/rDDJk6f/q5jLOpoiXf0R1FxLFw3ohZUCaJg4VGeNU/uYDyBzGs0PtDj/eRRWbl2j5FHca1Mu07NWtlaQM95xXZSTC2ER/c1xaGvWyQXXEiCZVRO+COW66bm2LL7MDrASLT4/SRXMpdE4DXmgW7iCC1lfq2r/dZzvuvDcJR+2vgE+ITL9V8RZQi8kpdE0rRYAjX1ieztz2ZDwsLPuVc/j6TQ== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nutanix.com; From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH v2 25/27] i8259.c: switch isa_pic from I8259State to I8259PICState Date: Fri, 16 Oct 2026 15:19:31 +0100 Message-ID: <20261016142031.1204281-26-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016142031.1204281-1-mark.caveayland@nutanix.com> References: <20261016142031.1204281-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BY3PR04CA0021.namprd04.prod.outlook.com (2603:10b6:a03:217::26) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|IA1PR02MB9592:EE_ X-MS-Office365-Filtering-Correlation-Id: 8507fdd8-39eb-45af-25d8-08df2b90e3da x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|23010399003|366016|56012099006|261009223027099003|10067099003|22082099003|18002099003|3023799007; X-Microsoft-Antispam-Message-Info: HA2YL7ronoArge5V8opli96wjP/ydTmWh3Pgzl89+DW+zbPYFMPh+7FKyRrsUD6HOLHRCi2GyksEL3kD5cVFG/7UDtT8sXHUJKb0Dh8xuybAXIUE0iBm4nWjQBR41hCZOkiw4AN6293dIeGHNiAP/IARitV6utsg986S23+FckICqKV1+ear7jQs7amm+qvHa11VkkacfHftB0WnkFJAqhKTQwbOnKR8T+ZGZn0sjAAb3YfXu7mjmt3FHVhJlwI9MM1xmStjNbCCwagH8bXx66dXQvUzxfOviS7VmCd6d0CAuTraGjC29gVUkZ2oVzhN5TaWM5VeqtRc6M0HsDk0euMXjGucwWIh48yxRNIkBH9kaKo5gEw5NyKi4hR+FIgis/zzZudhIDC3J9PQvhHbvZYpwrBA/isXzjlzR/9Xb3wtBdcOKojBsGBojB+tuLof281Pc+gFaej9YpijnIh/asy3PqkbQY1V+q4ry2oQkQq7aQlFWNCGxH5v6x/wTOtHlUEDq6VAQ5rw+/KEbrnDjcRKQskeegCbijXYHmzOvGsu2TTTPBzSy9YlPtSA37JoegQW1uZDxPAox0dZ/77zEHgtEkUV6Sf6cjWfiJfQeFHVw3hUNdMSKdZXp65JsfYrLY4gTmgt+9vKiW+e/FBZ6qOLorTXtXwBz3woxogL7yw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(23010399003)(366016)(56012099006)(261009223027099003)(10067099003)(22082099003)(18002099003)(3023799007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+jm7+nK+wXs2sRRra+e7vT3OGXJKkB7WpayiL0I8uIQ4exuEIJaKbTjZFPe1?= =?us-ascii?Q?WhJQNSOjjs/luUxCWTlRcvIQ/R+EZUTD7cqSJGlZ+JzNCW6CnWNBo3wd/Cn/?= =?us-ascii?Q?ruTh9Xq5pHkYMil2B96OJprSnafwHCKkmjCk5Dz25cvfQTvo8DtAziBGMn4e?= =?us-ascii?Q?It/He7KVB7P/P/pRrZ+cm/aZVvIzixksQpQ+2yubPDOPcjJAseZRNS3K76S9?= =?us-ascii?Q?jCiNovvYMoZiVYI9UT/OAHGHTq4tkaf8/27F93FWpHZgq7tk+1bhzz6pz+g5?= =?us-ascii?Q?tgTCWsg8465v22HmQzjDYYJZguRfsg2BAJpEfZnVV08hqNt1a9tHI7BDu0Yc?= =?us-ascii?Q?M5jAmODoPa7OLCNj7jreghrb/sJQe/L0aIzh7puFHqJNWgbev2moAj0fuoz9?= =?us-ascii?Q?oE7Up63L4KQicuOM/9G0n7sTwZUNnDYWfzIbqxNyI6ah2JJPZyrdjmGI15tu?= =?us-ascii?Q?ORSeC+lcuN00n9lxwYmxdUqUDJtAM9YQ8zYj2VbJpZLKmbJ+7kUd/M7OwjLE?= =?us-ascii?Q?1e6C3nk/de2PoNOEIrrtUvjf/GrBs2Q5mKjpnrbH2TGE6u8dnga7bmBdEpSL?= =?us-ascii?Q?nfTfnlwr9x9yK17jVEiLu6OgApwse4T3zz4yTVYFDWBEh27/nIjhjj+rO2Lz?= =?us-ascii?Q?iysDOMWFTCYKf8Xb876tWHZv5AMK/u22m74rLwjEo0+C/5oG5sGoLceXc0tv?= =?us-ascii?Q?f1iCfDvmLtquXDA9KKv1jB3YTLoMkJECGDaXVZDLbYGjN/GeXuFbr9DElLnz?= =?us-ascii?Q?zwu8t56PyAHH+C0v72Y8Uy7hIxZyxMuzet+93jLCWlhkldo2t3sFvfqPxAbk?= =?us-ascii?Q?/55uHUQ3+iwZBaM2H7IoGboQFmBbcKbdrjMUu4mZb5n4oLZ1HqzKyBZtXuLW?= =?us-ascii?Q?qHRgTmPBKuRCWD0Sl2CLQvx6twgD/5hkbjz4SUec9OgWzx4Y4es1dI49jGOv?= =?us-ascii?Q?Y1QjuLmkYd7OgroSmWZQQhlB6e8XSu+DaQYOTjKSNs9RkraDtzng447K3V+I?= =?us-ascii?Q?Qo2FeTvbVHEWgKuk1w2BoeCLqWFNoJipFcNtnHwfqwLwkjlncDzeQEJ9mDbv?= =?us-ascii?Q?7M+cIqVtOX1PpxAwq3E6U2NSwUOwPK4CeFVamdPh4MvW9UjAsnzq+pF2Aw2y?= =?us-ascii?Q?HGj1OREj/x0JuWXI2Sv95QdzfV0XvCXo0blMRNUf2FXvCPZvY1gjBLQYUsia?= =?us-ascii?Q?wfsV0t/PPsqY/6mc7iB+soMgEv+mauk82DNPkjg27Wr+AZkfKC1GnFzWk0kC?= =?us-ascii?Q?7LRKdB/bOl2cAFS2CrzKu3B7HzXWAixLE8p54rtRhP+Whzx+HNv6YTJuvGuO?= =?us-ascii?Q?DMpeZwx8P2hOA/7HsoDCyGR8IX0HdbG1yFdjDbx67/yaB/Pp6EfRunW5pj3B?= =?us-ascii?Q?Y8X0iQvuDcfhS8SdRBBSbhE6Dd85nusw/AmOR9GxWwLfN80fadv8p+HvzK9A?= =?us-ascii?Q?UAqDH5iv66eYMQLsPyr4z8n7H0PxOxcEdoCN21MsELXseT9hqoeuwC9gUzHU?= =?us-ascii?Q?MIust7z9eEOP5snOvi2FzUPdqp1ce7GQkwfmaDCHBcUELO2Ze12C/5q7vkF3?= =?us-ascii?Q?asz+KxszXW0y7PKZ68QVsmwCK2IFCMpKmoQkqsvpa0diLgN7260ya9Q4oIW4?= =?us-ascii?Q?j7iFOW+9UydEQGCblrydigpugi5pxT1mW4wH2VkaoM0OM7GP5TAvGJ4eU60Z?= =?us-ascii?Q?Gi6b+cZe8Cga91hA2CATac23XtjFseEMRKDuYwpuJ6VO/4HHxITbT+e4wusk?= =?us-ascii?Q?xUL0GIWWJZIUbDWMG8z9EtsEyJjEOPM=3D?= X-Exchange-RoutingPolicyChecked: zplCb1zP+VSYxU+vOXUkf4ksEwgjwMb3uf90fRFCMxRbeKMGaJRp8/gWMNv4anNfZV806rgSDNx3mgmEdE+oNMfsvBT+0Njj8xtAKaRGjKTlM5YIUfJdMlvaWJi+QgzAGxgOyJZAQbaUF78GQ2ZEp2PddCEhTQ74pOEeOhwSI5aoAwxl9PT8397D93dA3glL7PNVnQN9xnRHQrjNi+vLy0pDON2P/OvcilFXr0iq3rurTeqEXXIVrgUMz/IMYCMX/AmjfbM9a3xDfith1IP4a0xNDludgitA8YY+lzOeafvSBvTEEceeFAYDhNQ/f4O2nW/8FVzEIBJgzdYd6lPtWw== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8507fdd8-39eb-45af-25d8-08df2b90e3da X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 14:22:21.1185 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 125Qq7YV8ktJ9cm9iMm5PZCfdBsuJQDxii9lAXEqq1Jn5yqDGvBAPIJtV9RK9dwc9A/mCnaG4Wvy2eGrNc6+kGTQls8vgquLojS9zTvqGKs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR02MB9592 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX7EF6kXHjhQAu +8jaIHFOl+WsvQn9Orb5l0HJc0zQ5oHS646VaDAn/nFJopzOGsEn8ZgnP13xNB3tIJzc/5rz4xL kjueZlIQ/MKnz/mM5h0nm2MzlYIuix034oIzPMRLEAM4Z4/hJBip3cV4jO+WIwuKiy7RfsAu37n mEEt2OnqK3e4nPRPa81XEALsOheMKcJtJIxfmdZ5EyK09/7GmUczE5wgSrHANMBIqUjRuAUOeNU fkqReeG0IpsQdx1pLHGPhAvYzut4np89/GJ13oo3m0WKz0MXkT19EYINZu46LK5XFGg8lnqMQxx jFevMsxAQIi8He5VQ6oPXzMGEIsg4P7yVp7u0XaOqKbQQMTmnyPWxrUupcDo5vyP00GO7MZV3p7 rvgSPbSBKovcYEvtiEZsU9khhxKx8g5xlId//Q7UC8UTmqCBa2PJBI5wDTu9zwrTpwTCmenGuql NB8OI5igpXJ4/kAxzpQ== X-Proofpoint-GUID: vRTbztpDPxhynNLAonNftkGjlZ0Hv4Yk X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX/Mn5Jy+mzL75 OeE/ldX0ZM2GmQOFTsapE6TaJjeT4xRQsiEfwUBtHROD4ggthYadkqclClnPpSiMG8QPPvQVs+G 9s8syAusa1NIiTBfKk7KJIxPWXLswLw= X-Proofpoint-ORIG-GUID: vRTbztpDPxhynNLAonNftkGjlZ0Hv4Yk X-Authority-Analysis: v=2.4 cv=KMLPn1Fo c=1 sm=1 tr=0 ts=6ad23340 cx=c_pps a=7kgNGXaSmB15KJ6u7rEBag==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=660iZSQnnn4A:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=VUi8bpU7OL1Oj2-RSIOF:22 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=Re7Oh-p8VE-n4k5LXTMA:9 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-16_02,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-ebf023/1792160581-C2CCFB50-DF39ADE5/0/0 X-purgate-type: clean X-purgate-size: 4546 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1792160605774158500 Content-Type: text/plain; charset="utf-8" The isa_pic variable exists to allow the output to be fetched or read (fetc= hed and acknowledged) from the x86 PIC. Since this can also contain a cascaded interrupt from a slave i8259, switch isa_pic from I8259State to I8259PICSta= te and update both pic_get_output() and pic_read_irq() accordingly. This has the advantage that a i8259-based PIC device contains its own inter= nal reference to both the primary and secondary i8259s, and therefore it becomes possible to completely remove the slave_pic variable. Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell --- include/hw/intc/i8259.h | 8 ++++---- hw/intc/i8259.c | 34 +++++++++++++++------------------- 2 files changed, 19 insertions(+), 23 deletions(-) diff --git a/include/hw/intc/i8259.h b/include/hw/intc/i8259.h index d51a7fde32..4922f88d5b 100644 --- a/include/hw/intc/i8259.h +++ b/include/hw/intc/i8259.h @@ -5,9 +5,9 @@ =20 /* i8259.c */ =20 -typedef struct I8259State I8259State; +typedef struct I8259PICState I8259PICState; =20 -extern I8259State *isa_pic; +extern I8259PICState *isa_pic; =20 /* * i8259_init() @@ -18,8 +18,8 @@ extern I8259State *isa_pic; */ qemu_irq *i8259_init(ISABus *bus, qemu_irq parent_irq_in); qemu_irq *kvm_i8259_init(ISABus *bus); -int pic_get_output(I8259State *s); -int pic_read_irq(I8259State *s); +int pic_get_output(I8259PICState *s); +int pic_read_irq(I8259PICState *s); bool i8259_pic_get_statistics(InterruptStatsProvider *obj, uint64_t **irq_counts, unsigned int *nb_irqs); diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index 842507f9f8..7c9ce2315a 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -72,8 +72,7 @@ OBJECT_DECLARE_SIMPLE_TYPE(I8259PICState, I8259_PIC) #ifdef DEBUG_IRQ_LATENCY static int64_t irq_time[16]; #endif -I8259State *isa_pic; -static I8259CommonState *slave_pic; +I8259PICState *isa_pic; =20 /* return the highest priority found in mask (highest =3D smallest number). Return 8 if no irq */ @@ -190,34 +189,35 @@ static void i8259_intack(I8259CommonState *cs, int ir= q) i8259_update_irq(cs); } =20 -int pic_read_irq(I8259State *s) +int pic_read_irq(I8259PICState *s) { - I8259CommonState *cs =3D I8259_COMMON(s); + I8259CommonState *pcs =3D I8259_COMMON(&s->i8259[0]); + I8259CommonState *scs =3D I8259_COMMON(&s->i8259[1]); int irq, intno; =20 - irq =3D i8259_get_irq(cs); + irq =3D i8259_get_irq(pcs); if (irq >=3D 0) { int irq2; =20 if (irq =3D=3D 2) { - irq2 =3D i8259_get_irq(slave_pic); + irq2 =3D i8259_get_irq(scs); if (irq2 >=3D 0) { - i8259_intack(slave_pic, irq2); + i8259_intack(scs, irq2); } else { /* spurious IRQ on slave controller */ irq2 =3D 7; } - intno =3D slave_pic->irq_base + irq2; - i8259_intack(cs, irq); + intno =3D scs->irq_base + irq2; + i8259_intack(pcs, irq); irq =3D irq2 + 8; } else { - intno =3D cs->irq_base + irq; - i8259_intack(cs, irq); + intno =3D pcs->irq_base + irq; + i8259_intack(pcs, irq); } } else { /* spurious IRQ on host controller */ irq =3D 7; - intno =3D cs->irq_base + irq; + intno =3D pcs->irq_base + irq; } =20 #ifdef DEBUG_IRQ_LATENCY @@ -369,9 +369,9 @@ static uint64_t i8259_base_ioport_read(void *opaque, hw= addr addr, return ret; } =20 -int pic_get_output(I8259State *s) +int pic_get_output(I8259PICState *s) { - I8259CommonState *cs =3D I8259_COMMON(s); + I8259CommonState *cs =3D I8259_COMMON(&s->i8259[0]); =20 return (i8259_get_irq(cs) >=3D 0); } @@ -428,7 +428,6 @@ qemu_irq *i8259_init(ISABus *bus, qemu_irq parent_irq_i= n) { qemu_irq *irq_set; DeviceState *dev; - Object *pic_obj; int i; =20 irq_set =3D g_new0(qemu_irq, ISA_NUM_IRQS); @@ -442,10 +441,7 @@ qemu_irq *i8259_init(ISABus *bus, qemu_irq parent_irq_= in) irq_set[i] =3D qdev_get_gpio_in(dev, i); } =20 - pic_obj =3D object_resolve_path_component(OBJECT(dev), "primary"); - isa_pic =3D I8259(pic_obj); - pic_obj =3D object_resolve_path_component(OBJECT(dev), "secondary"); - slave_pic =3D I8259_COMMON(pic_obj); + isa_pic =3D I8259_PIC(dev); =20 return irq_set; } --=20 2.43.0 From nobody Fri Oct 23 14:31:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1792160604; cv=pass; d=zohomail.com; s=zohoarc; b=fdCdyQiqmMApln0NP1Ljq1R4xNFtlJ8izOjLOIBZ/3uImNd1vOC5Eza+0p2dNWAOEYVRZvko6VsxYluF4R51ryCnZFGJMZlFccPxEHto/nS2nlwgTisCeO1gwsuH6vFaAZyu+M+bbLxXOhRciwE11jCXLUEr1OrlqIyrmia5cLo= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792160604; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=TF9awKXkBCrr4rHv9LgEquEb3ahubq6gRo9qNTd7tjc=; b=TthAIceIcj72tSnN+ZN+z+LEqlQ2+jTbfenuV4C2xRUsGTal+Sc/EUJAEmOKJcKNLBw5kc3OpjakDxWXOx9tUTUUbTI91K6RK0QqxO1eY6OKG/mV1Gs1l3f2ufgpMSwFBj77XE0yQi36gdigUbtMFc3IidxfWAZ1nHzP/3vWoH0= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 179216060416542.00236477493422; Fri, 16 Oct 2026 07:23:24 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1452075.1667028 (Exim 4.92) (envelope-from ) id 1xHipv-000351-VU; Fri, 16 Oct 2026 14:23:07 +0000 Received: by outflank-mailman (output) from mailman id 1452075.1667028; Fri, 16 Oct 2026 14:23:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHipv-00034l-S9; Fri, 16 Oct 2026 14:23:07 +0000 Received: by outflank-mailman (input) for mailman id 1452075; Fri, 16 Oct 2026 14:23:07 +0000 Received: from mx.expurgate.net ([194.145.224.20]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHipv-00030c-36 for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 14:23:07 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1xHipu-00BXCg-Fv for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 16:23:06 +0200 Received: from [10.42.69.6] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6ad23348-e002-0a2a0a5209dd-0a2a4506d20e-22 for ; Fri, 16 Oct 2026 16:23:06 +0200 Received: from [148.163.155.12] (helo=mx0b-002c1b01.pphosted.com) by tlsNG-16d1c6.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6ad23344-195a-0a2a45060019-94a39b0c3e8e-3 for ; Fri, 16 Oct 2026 16:23:01 +0200 Received: from pps.filterd (m0127842.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69GE58vc1681992; Fri, 16 Oct 2026 07:22:57 -0700 Received: from dm5pr21cu001.outbound.protection.outlook.com (mail-centralusazon11021130.outbound.protection.outlook.com [52.101.62.130]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 4hberu10kd-3 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 16 Oct 2026 07:22:57 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by IA1PR02MB9592.namprd02.prod.outlook.com (2603:10b6:208:3f5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.522.15; Fri, 16 Oct 2026 14:22:25 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%4]) with mapi id 15.21.0522.016; Fri, 16 Oct 2026 14:22:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=TF9awKXkBCrr4rHv9LgEquEb3ahubq6gRo9qNTd7t jc=; b=tJMUcPaf9dnYYkuxtxuAqABVClHLGL/F6VcPg7NBoAMLwgtG9oTrthHbr Bv2TjaCgy+00Q/Q93VqwErApr3pMJhALR+i+26xp+gcH8ETdfB4PQllt3sN4CaZH kosV4xsyyTI5PCqcWbcBlN1N4jsVfr4lTt4FfAcBgIaLZKeaVMZ73pss4jn1zNzC 0SNRojgoqoUTMPqbW+nF+N0iqGYAyPoa8OOTgA4wi0X3TfYQSGE2fOyYbdr7wbU0 KcQdcRU7LP5w0VHynR1Ina4SIoG5NgoAf/+QUnt0GPquwoL1uFktl+Up62tjnwgR GzNd1P1eN1344gSfawRt3msUj2c2Q== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mEsJUnkoqwM1Gm4DJQ+PrIDD0PLPeJepLVkK2Ks+Xg/Mw2c5i1OEsVliUAt19Fx+tFSlSzwrNwlNa4uPiObXw1QS0AP9R7/WeKryqGC8P1OsFloJ64fxiddeoMkywEDCKoLGmvf9o6/igZbVJkaaW4E/3GhEh+fL87aN01bfHfwiLn3Kc4z5I47Vlkyh7b6btWkssgcAH9vl+5ChdXLmu08eCEslmDCo9A6+QHaKHylc56i9u3swCgLtAUAgNdZfNDqumyicj+N1dKJFrTItMhZI4CpAEC6Qcu84FKyAmMdlYqHZfBQSthDUzsZHPGDEKogq9zCeqcC1qiywXq1Giw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TF9awKXkBCrr4rHv9LgEquEb3ahubq6gRo9qNTd7tjc=; b=MtV4fKv+XLOHEDbSc2QiirjqW7tXUC9Nm8vrFVZEP79/YKU9GO8zUGbhDur5QeblnCIdy+8ZjZmA/Hdfy28999H28hsYJfhVOdokHNx7txuMZQd8u6bz5LcXblNZ4VnYFral8k6qIs7dgJYf+Ipcs73yvKMH+dxOaYT27tGQ9folNkfMaSNtrS3z1TDRLWUqbkuwbz5uvK3cAbeZOUNkl50DHlNRJb+fWzswtmLNO18lTDetsffVDbC1fPQf4RDVHtvNBi/+A0liNs5QuOzPt6NRtU8XUigg3xeNBioDe0fJbY/1IQNclrVLoZfLl5ApLDaC0WEZ0+Zyf3XBcugpZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TF9awKXkBCrr4rHv9LgEquEb3ahubq6gRo9qNTd7tjc=; b=hEltSo+/aKMEBK4Uy8SMG4KSfVuBjCu+qcuYDPPrJDJS9agUola3AhNLBG91fJ5F5k6nG0zD5UqhSnY8oYJC4WtL1EYszqJiVISP8KcIxLTH2D5cxcW6a0T1VTOUmev4D0D7EX1R62SW42jkdbEZt8MgaHBns3LphxArN7snxYeJmzj1IAz6HyDx2SldBFboLgBei6Bx/kGvNfPyF8KN5GB8n6UE8d2T/9PPrb+yJo7w9e64AhjTYa8iXnnV7LkcJ4Zkkkh/LlPytwAokYqAchmUq19Ge9+vgVpnPl+xb/M/vkaxPc+ZN9A4EkQ5MBK912HGG+r0V2ze88t339V6mg== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nutanix.com; From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH v2 26/27] i8259_common.c: remove static irq_count and irq_level variables Date: Fri, 16 Oct 2026 15:19:32 +0100 Message-ID: <20261016142031.1204281-27-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016142031.1204281-1-mark.caveayland@nutanix.com> References: <20261016142031.1204281-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR05CA0162.namprd05.prod.outlook.com (2603:10b6:a03:339::17) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|IA1PR02MB9592:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c00dfc5-7523-4ce3-3569-08df2b90e63f x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|23010399003|366016|56012099006|261009223027099003|10067099003|22082099003|18002099003|6133799003|3023799007; X-Microsoft-Antispam-Message-Info: 9ZmbQiGv3cuWgyNi6qCP8N+vlRBk7bujvyzZ47buzxCZc836nqPn7j9E0WWJN1uiS3uM+R9my/U/xbQT7VmTHOoJOdX9BpqtyEXMKehjvgo2Bj6o3scLFmuz9n+HTXcwdchjXVHUtXr3RX3Xb51TpdETFH7lhaCvPGQavZdljjHtx6zAKXQeWTnSkin1WOTAMZx4CH+fq4Zvmh4fP2nzPk7kNf2dyyU7iw0bETz70Y6NYdSwLfPaY7rRFrS6k9Ijjpr+Nrr3tnwkYc88ypRC8gLGm/M84+Z/8eRsCwtXEfxBczvLJ2zDeJnGCmnpwq9lTRhdojrKzS4bYMNlkr3aitaxfqPjzeglmOabmwO4Zm3eyeVrwU1bcYwZG3qZDwPQUWGcLqTV113nxSngftR9SRibjyVGAtx+HNLk9E7NhTrg366uywsqGgnhwU7kGMxyR/sB9z3ohj6D18WYqdA9Rldme2n8EeMWLeLCiL0Sx8egsVn+bKm5zSdPXC8rLoQWE0/xAhuoRHVBCP11qGltFAqQZWibTc9demyhqzMf6/AQO4csPvRVd4N9+Ptr+p+4XayJx7/SYgEcsfh5TGi85kwbjtTrweF1SkOYMJNc/VR6OyZgn5V8aAF1sOOCBSGLVLgobrLlwyBRUWOQ8xnY2kPuVfKSnDGo4XVXZZSIUXo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(23010399003)(366016)(56012099006)(261009223027099003)(10067099003)(22082099003)(18002099003)(6133799003)(3023799007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fJj2t8g9LTrxgl4qgQjn0YBZV2X9c47xWHkL8xAS4rE5KY/3Ht7bocPHbLlT?= =?us-ascii?Q?vt6/67wVCCAJd4bOVWyFtDe19ak6xcU6kR1b/0I9W41Bd2Tx9Czkb+22WmGD?= =?us-ascii?Q?Fit/XpURJJxcmKuxQTtW4Gt22wlgjr3P6hh914NEdWjihUxgX86tlrCZGQOp?= =?us-ascii?Q?V2TUXYuvhCaHIyV1edZUl/UV4HROyoPQAVv60DVEPGPnOevRYgFmir5Lwv74?= =?us-ascii?Q?SB8OlOnrNV2MryME81jFZ6S21lcehgY5C0RfzSKSw6MnCvTisZNbHnkrCLlX?= =?us-ascii?Q?vfJFADr/e2a5P8VAetDasjjXgSSEVAXDtFsTiFJ+0a+/i2TRiIc84Y1H5Q1G?= =?us-ascii?Q?Amon87Mw7zKSzcFABusi+46oxTtTpWbNW17ozy4Np+jtP9n/MDlfIY3yaKLm?= =?us-ascii?Q?9xKgEnf1ws/S6ykAGJkvgJX4K2htWGQK4mrQLxoVp4LkB9Y0qzADgiwN9icJ?= =?us-ascii?Q?D94JVhiQ/j0xIkPDBjA6sKfMiMBgWUKYOzh7yFGzuLRY+lXcS6/uX9Z+VpD7?= =?us-ascii?Q?6h2HJBJ3sw6rXVSQuB2We9fRAaHu4T7Z1NqgIsVTSxGkHIikgyedObJ7vpN/?= =?us-ascii?Q?OC2c2cOQIE2bbqHD/CkwQS9SjEF+Z52B8Tk6VAaU19IEbzKexEjoqYgya/Z1?= =?us-ascii?Q?AN+Xic7uMdZAdw7iuh+1S4HN1qaz6P9A/PwcC+K/iP/AiyIUPjMhjBAIVQHy?= =?us-ascii?Q?mIAETV3fkt+MoXQBIz0G4AcRe+OhrZzpUU8hofGGRfxf0dWoGgyfBSGWrf4W?= =?us-ascii?Q?ejL2wB0XYDgceg1YRRsx0qSrDGttugzKpOJTRxQ0Cv+vezEmAy++lFvV1R6w?= =?us-ascii?Q?YW0UviZp41NbeM8pIuXT3sxCZv0BLjHDc6Q/Bjz1F8myziItI49d3yl66idk?= =?us-ascii?Q?jHUgib6zBF0GPa9sGCIWqp3hvF6d+6h3qNngTGL6/zLEkGDc0jktUS8qMxmq?= =?us-ascii?Q?zl+OyVudG2StqB6ZuL2vHR5PRc914o9mtwKMY/rXPAh8au4ifKqaAeArtjlB?= =?us-ascii?Q?0pj90eEEOhR3NqxPHjYKkYXAwUcIh9FjIZJsY4aTEZRYR1ZpEPrWQW8ejRBM?= =?us-ascii?Q?JSzvpsSjLpGsbKBwNJ//9Ls1agSjGbd8vcgQX0g8hdLavW/quyyQBsoU1rLm?= =?us-ascii?Q?DP51rOnfEpoRmsdsDlSA/PDiu3YtVh97VTn/hJ7yej9VOp/yLG0QoolcC5Nl?= =?us-ascii?Q?vmPEaHW/tjsWaX7LhWAWcvfvrWqFYoXwNRSSUcQVIjHX4K2CODourvrL4ah8?= =?us-ascii?Q?uonPkMdrA1b0KM06bzlvRbyrbwH2JPUcPrzJXDYkbTMRP3PWlzSzaGVTVnRP?= =?us-ascii?Q?fS7riqdm9f81gkaU10IYSm1axr0RyAsjdd4eT101h04yxjmvlhukQ7KiyKdL?= =?us-ascii?Q?N+51/2d1Xytgevx9WoAgSPZxQhkmgvWW5CPdMY5d0+fdT+KgeV3xKKQDZUHY?= =?us-ascii?Q?MiWGKjmbXjub96TnM/sOvKlfbMY3nhGTcrdKgwPk44ZkqOa8KUlGVyNh79Pr?= =?us-ascii?Q?+yULlxYhVQidu2Xr0SK1Ai8RyKr3Oq2fCjnryfWz8Kpo8YsxV4qE8khth+kv?= =?us-ascii?Q?zaYDpQto+EfmBi9DcbuPHTHCdQhYRS6s246QFPqmJTZJY+bdxyY8q0CZH68J?= =?us-ascii?Q?VaYPmB9/rby7yZ3zuLT2JioYoWj47fwRqAuvEjNiD/K3IFn8oU17fV/rq/MZ?= =?us-ascii?Q?jTpnDHG09X6DmJ2saROleSNj6Kcg4GZ7j5WUol7qy9KJMxiTUSekQA50yRYN?= =?us-ascii?Q?0FejQANGWJTHNPeBHmcYRavTQBTbrqU=3D?= X-Exchange-RoutingPolicyChecked: ToTsIdLdPu29YiBOWdz9b1IK0wHmCk0LLd84KpJKU8YiY2eFqDs/k+Pm7em4gyfVi8B+l4RiAK18P8+lAFcTX86UEjrZNuLELDph/o5Sqk7lJnEvAHvyTqjHjZTEe+0W0SjT9UqThf2ZEG2wjrCTu0Ts2MN9X/DycMumPK2R5SmOlCdwNg56uz9kG8SzyUQnI4pxWmviJdQSwzYjLeeFDOiRcdLk6X4DNXaJ2F19hycp9Higrnb6CXT1/QOxkeFZ3ilYtjYUMzQ74W2AsYdtKN29g44+2aiM923ggtuOMgDSAUIp0QRevt4mPHb0pv28LbpC0Xbckd5NxGE3xQ5sRw== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c00dfc5-7523-4ce3-3569-08df2b90e63f X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 14:22:25.1030 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: W7ZIgA8+QgO4ZFtLAcGxZvXwArbWnfXVAiL7ZXxlweJaHc/fndExXdihApKPTshXm0e0SXi8jPlPNXIv2Zjku+69Szl/mnQ3niutsatol7w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR02MB9592 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX/D/nIcdkaZDv YP0NUURKP46e6NPB3wzpdcyCcqJLLsKsdtRlL1HOoQIMYzJ69/+D1JXBgfqkKADeN/OTLEHt6bu jfa/RROWioJu6I9UrAv8Cprku6hBCCjdidcIvg26YtBnZxA/74N8azj3svwfxc92VnqWySjJz6L 8Rc3uyyQF6EPrnMq8HRRyav0vbZ7P733u+7fuF7q/z1bP9YrAxqnEGuLFf5Ub1NO5O53D0JWeTO jLfQzuvQ26o3rkm/RLhRNnlkqrPh0yCP2cbS3YArGXYPyYSUvfDSyu9jfgWVgeWYsLIpCQuniGz wNaFZFuP/7KkjO4Yo5FetB6pIcrXGGVUq21umxZT24I6a6fZytMLZUa9JhKrAb4WsxcztKZp74Q cEXeWwRj6I7nIbD0BQfnYqJIfLLJmCF4eYkTJjVGhZRGBe3i0HkzhKk8xnGAXXdZpEJ11dDOUP8 ebgLMh6ybkGu+bv2nww== X-Proofpoint-GUID: ImplHB_Y0D1bMyUUQs9ecSG5PfgMSRir X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX3jc8FpGTCmyi QYqBZiqXjH0SP04CYYaR50G5tNNvB7EHqjGBmTTWTo+/3O0XCEAp033tmWwqMsfoB+ygfaPnO4H EHNFFbzSxOEaDInLAWf4V+7s75tAXmI= X-Proofpoint-ORIG-GUID: ImplHB_Y0D1bMyUUQs9ecSG5PfgMSRir X-Authority-Analysis: v=2.4 cv=KMLPn1Fo c=1 sm=1 tr=0 ts=6ad23341 cx=c_pps a=7kgNGXaSmB15KJ6u7rEBag==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=660iZSQnnn4A:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=VUi8bpU7OL1Oj2-RSIOF:22 a=64Cc0HZtAAAA:8 a=m9Rx451XjQ6kX_1OFlEA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-16_02,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-16d1c6/1792160582-1ECC577B-CE72AD47/0/0 X-purgate-type: clean X-purgate-size: 7334 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1792160605814158500 Content-Type: text/plain; charset="utf-8" Adjust the parameters to i8259_stat_update_irq() to allow passing in pointe= rs to the irq_count and irq_level arrays, and then move the arrays into the corresponding i8259 PIC and KVM PIC devices. Doing this allows the statistics capture logic in i8259_set_irq() that hand= les incoming cascading interrupts to be removed. Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell --- include/hw/intc/i8259.h | 3 --- include/hw/isa/i8259_internal.h | 3 ++- hw/i386/kvm/i8259.c | 20 +++++++++++++++-- hw/intc/i8259.c | 40 ++++++++++++++++++++++----------- hw/intc/i8259_common.c | 21 +++++------------ 5 files changed, 52 insertions(+), 35 deletions(-) diff --git a/include/hw/intc/i8259.h b/include/hw/intc/i8259.h index 4922f88d5b..42d6f992ac 100644 --- a/include/hw/intc/i8259.h +++ b/include/hw/intc/i8259.h @@ -20,9 +20,6 @@ qemu_irq *i8259_init(ISABus *bus, qemu_irq parent_irq_in); qemu_irq *kvm_i8259_init(ISABus *bus); int pic_get_output(I8259PICState *s); int pic_read_irq(I8259PICState *s); -bool i8259_pic_get_statistics(InterruptStatsProvider *obj, - uint64_t **irq_counts, - unsigned int *nb_irqs); void i8259_pic_print_info(InterruptStatsProvider *obj, GString *buf); =20 #endif diff --git a/include/hw/isa/i8259_internal.h b/include/hw/isa/i8259_interna= l.h index 2807409eff..e0002843a1 100644 --- a/include/hw/isa/i8259_internal.h +++ b/include/hw/isa/i8259_internal.h @@ -70,6 +70,7 @@ struct I8259CommonState { }; =20 void i8259_common_reset(I8259CommonState *cs); -void i8259_stat_update_irq(int irq, int level); +void i8259_stat_update_irq(uint64_t *irq_levels, int *irq_counts, + int irq, int level); =20 #endif /* QEMU_I8259_INTERNAL_H */ diff --git a/hw/i386/kvm/i8259.c b/hw/i386/kvm/i8259.c index b56e4fced4..3e65b243cf 100644 --- a/hw/i386/kvm/i8259.c +++ b/hw/i386/kvm/i8259.c @@ -45,6 +45,9 @@ struct KVMI8259PICState { =20 ISABus *isabus; KVMI8259State i8259[2]; + + int irq_level[ISA_NUM_IRQS]; + uint64_t irq_count[ISA_NUM_IRQS]; }; =20 OBJECT_DECLARE_SIMPLE_TYPE(KVMI8259PICState, KVM_I8259_PIC) @@ -117,6 +120,18 @@ static void kvm_i8259_put(I8259CommonState *cs) } } =20 +static bool kvm_i8259_pic_get_statistics(InterruptStatsProvider *obj, + uint64_t **irq_counts, + unsigned int *nb_irqs) +{ + KVMI8259PICState *s =3D KVM_I8259_PIC(obj); + + *irq_counts =3D s->irq_count; + *nb_irqs =3D ARRAY_SIZE(s->irq_count); + + return true; +} + static void kvm_i8259_reset(DeviceState *dev) { I8259CommonState *cs =3D I8259_COMMON(dev); @@ -129,9 +144,10 @@ static void kvm_i8259_reset(DeviceState *dev) =20 static void kvm_pic_set_irq(void *opaque, int irq, int level) { + KVMI8259PICState *s =3D opaque; int delivered; =20 - i8259_stat_update_irq(irq, level); + i8259_stat_update_irq(s->irq_count, s->irq_level, irq, level); delivered =3D kvm_set_irq(kvm_state, irq, level); kvm_report_irq_delivered(delivered); } @@ -227,7 +243,7 @@ static void kvm_i8259_pic_class_init(ObjectClass *klass= , const void *data) =20 dc->realize =3D kvm_i8259_pic_realize; device_class_set_props(dc, kvm_i8259_pic_properties); - ic->get_statistics =3D i8259_pic_get_statistics; + ic->get_statistics =3D kvm_i8259_pic_get_statistics; ic->print_info =3D i8259_pic_print_info; /* * Reason: must be wired to the ISA bus via the "bus" property diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index 7c9ce2315a..8b1dd57849 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -64,14 +64,16 @@ struct I8259PICState { ISABus *isabus; IRQState i8259_primary_out_irq; I8259State i8259[2]; + + int irq_level[ISA_NUM_IRQS]; + uint64_t irq_count[ISA_NUM_IRQS]; +#ifdef DEBUG_IRQ_LATENCY + int64_t irq_time[ISA_NUM_IRQS]; +#endif }; =20 OBJECT_DECLARE_SIMPLE_TYPE(I8259PICState, I8259_PIC) =20 - -#ifdef DEBUG_IRQ_LATENCY -static int64_t irq_time[16]; -#endif I8259PICState *isa_pic; =20 /* return the highest priority found in mask (highest =3D smallest @@ -138,16 +140,8 @@ static void i8259_set_irq(void *opaque, int irq, int l= evel) { I8259CommonState *cs =3D opaque; int mask =3D 1 << irq; - int irq_index =3D cs->master ? irq : irq + 8; =20 trace_i8259_set_irq(cs->master, irq, level); - i8259_stat_update_irq(irq_index, level); - -#ifdef DEBUG_IRQ_LATENCY - if (level) { - irq_time[irq_index] =3D qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL); - } -#endif =20 if (cs->ltim || (cs->elcr & mask)) { /* level triggered */ @@ -224,7 +218,7 @@ int pic_read_irq(I8259PICState *s) printf("IRQ%d latency=3D%0.3fus\n", irq, (double)(qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) - - irq_time[irq]) * 1000000.0 / NANOSECONDS_PER_SECOND); + s->irq_time[irq]) * 1000000.0 / NANOSECONDS_PER_SECOND= ); #endif =20 trace_pic_interrupt(irq, intno); @@ -456,10 +450,30 @@ static void i8259_class_init(ObjectClass *klass, cons= t void *data) } =20 =20 +static bool i8259_pic_get_statistics(InterruptStatsProvider *obj, + uint64_t **irq_counts, + unsigned int *nb_irqs) +{ + I8259PICState *s =3D I8259_PIC(obj); + + *irq_counts =3D s->irq_count; + *nb_irqs =3D ARRAY_SIZE(s->irq_count); + + return true; +} + static void i8259_pic_set_irq(void *opaque, int n, int level) { I8259PICState *s =3D opaque; =20 + i8259_stat_update_irq(s->irq_count, s->irq_level, n, level); + +#ifdef DEBUG_IRQ_LATENCY + if (level) { + s->irq_time[n] =3D qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL); + } +#endif + qemu_set_irq(s->pass_irqs[n], level); } =20 diff --git a/hw/intc/i8259_common.c b/hw/intc/i8259_common.c index 684290fb2d..3bafd81ea7 100644 --- a/hw/intc/i8259_common.c +++ b/hw/intc/i8259_common.c @@ -30,8 +30,6 @@ #include "migration/vmstate.h" #include "qapi/error.h" =20 -static int irq_level[16]; -static uint64_t irq_count[16]; =20 void i8259_common_reset(I8259CommonState *cs) { @@ -89,26 +87,17 @@ static void i8259_common_realize(DeviceState *dev, Erro= r **errp) qdev_set_legacy_instance_id(dev, cs->iobase, 1); } =20 -void i8259_stat_update_irq(int irq, int level) +void i8259_stat_update_irq(uint64_t *irq_counts, int *irq_levels, + int irq, int level) { - if (level !=3D irq_level[irq]) { - irq_level[irq] =3D level; + if (level !=3D irq_levels[irq]) { + irq_levels[irq] =3D level; if (level =3D=3D 1) { - irq_count[irq]++; + irq_counts[irq]++; } } } =20 -bool i8259_pic_get_statistics(InterruptStatsProvider *obj, - uint64_t **irq_counts, - unsigned int *nb_irqs) -{ - *irq_counts =3D irq_count; - *nb_irqs =3D ARRAY_SIZE(irq_count); - - return true; -} - void i8259_pic_print_info(InterruptStatsProvider *obj, GString *buf) { /* No information for i8259-based PICs */ --=20 2.43.0 From nobody Fri Oct 23 14:31:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; envelope-from=xen-devel-bounces@lists.xenproject.org; helo=lists.xenproject.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1792160608; cv=pass; d=zohomail.com; s=zohoarc; b=mwd/rLoQQRfDugyZPs+FgOiFNdk2Obg+Vehd2O6zNUAUc7PFtq7xlZK4USkU5k3tVDur+lg+keklVTKp2mmK6d8qf2NFjVFrMyalN4MIA1dEcc8QAXBTeJb+u5odYiank3hp4GUgM76DJGEgYzNAaIPb2nZ5erkASdKz9+blJlU= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792160608; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=SZiLewJ31Wd7JJfgU0jxATyKUq9AnyFgswSLPaZDyF0=; b=J9F5xVnJt04vtV0wLSdE78szxh0IMeRTwmYI1UBgbKlW6rCBc3DLK9bwUbnZQGYYeGwRWtlEgGWoXCjwPxP56ZSwbbQm39lcoN21SXZaHWMGBjWmRHuGWgcSVLO4QXmxv0Hy36+A5emRmKR/WTM1sR1zkhZoalwRCCze/p1Yd8Q= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) by mx.zohomail.com with SMTPS id 1792160608710657.5428877492471; Fri, 16 Oct 2026 07:23:28 -0700 (PDT) Received: from list by lists.xenproject.org with outflank-mailman.1452074.1667019 (Exim 4.92) (envelope-from ) id 1xHips-0002ho-In; Fri, 16 Oct 2026 14:23:04 +0000 Received: by outflank-mailman (output) from mailman id 1452074.1667019; Fri, 16 Oct 2026 14:23:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHips-0002gh-Eq; Fri, 16 Oct 2026 14:23:04 +0000 Received: by outflank-mailman (input) for mailman id 1452074; Fri, 16 Oct 2026 14:23:02 +0000 Received: from mx.expurgate.net ([195.190.135.10]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1xHipq-0002Dj-Oj for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 14:23:02 +0000 Received: from mx.expurgate.net (helo=localhost) by mx.expurgate.net with esmtp id 1xHipq-001AqU-5H for xen-devel@lists.xenproject.org; Fri, 16 Oct 2026 16:23:02 +0200 Received: from [10.42.69.4] (helo=localhost) by localhost with ESMTP (eXpurgate MTA 0.9.1) (envelope-from ) id 6ad23343-8faa-0a2a0a5109dd-0a2a4504970e-8 for ; Fri, 16 Oct 2026 16:23:02 +0200 Received: from [148.163.155.12] (helo=mx0b-002c1b01.pphosted.com) by tlsNG-ebf023.mxtls.expurgate.net with ESMTPS (eXpurgate 4.57.1) (envelope-from ) id 6ad23344-b57f-0a2a45040019-94a39b0c3e22-3 for ; Fri, 16 Oct 2026 16:23:01 +0200 Received: from pps.filterd (m0127842.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69GE58vd1681992; Fri, 16 Oct 2026 07:22:57 -0700 Received: from dm5pr21cu001.outbound.protection.outlook.com (mail-centralusazon11021130.outbound.protection.outlook.com [52.101.62.130]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 4hberu10kd-4 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 16 Oct 2026 07:22:57 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by IA1PR02MB9592.namprd02.prod.outlook.com (2603:10b6:208:3f5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.522.15; Fri, 16 Oct 2026 14:22:29 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%4]) with mapi id 15.21.0522.016; Fri, 16 Oct 2026 14:22:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Authentication-Results: eu.smtp.expurgate.cloud; dkim=pass header.s=proofpoint20171006 header.d=nutanix.com header.i="@nutanix.com" header.h="Content-Transfer-Encoding:Content-Type:Date:From:In-Reply-To:Message-ID:MIME-Version:References:Subject:To"; dkim=pass header.s=selector1 header.d=nutanix.com header.i="@nutanix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=SZiLewJ31Wd7JJfgU0jxATyKUq9AnyFgswSLPaZDy F0=; b=XAtNRB/9LSRLQ03Evxm/7s0T6/VsRJo6Xx3cbP+NLbFo08mklCBriInnO /lfqsNeYQnmHZQcve4Hs1b7Fn+d9x+/v2qoTmTUCxlQ44J4PAiJbPcCveQNXtVXA XAil/ZGye+7QwwhqO5LcNpTkBZBC4KhSYsVsXCGI8LSYTND2hLG80DbVIpSSZWmO kI3CvWG4dh+LhakNiXaRUPzhF0/Dl4K3oNq9W/JotyuktMlCn6FBD43641JJREjG IsX/zBbIVM/73riqjkEac+jnpm6XOW9u2A4CPEWjphwjJrdsEh9HZfWyGclgowl8 XZB0Aq8Xzp6VDoKDt7lCMOwv8y+CA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KDmQFU+jWLuGzDPNr5gN9ie3gVpdRgnyRHRuF+4UNXkN+IP5OSHmFR+5fTYafYio8JI69JEMq3FRDvXETKwRA+r8E7bN5YCVzbATbebQSW257CTmeAtW67wHm3p/kx7EJy5ol1JlVo/Fr21/DsWsKGfvvOYLk11xzejVHbHpI7MuJ7PmcYaaOED1HkBWMK+7kr45NnTRHRMsf0A3clHjXduUaRtfC4MYn9Rt78MA/UmT1S4cCPm2n0sj4LGhRHK7kcjOk37w1rxSxb8t9+zKtvugvC0GZ4JT6doF5xyfKvbF6CwQtneYM+2KAhoHFCP3jwr2619YEdn77AWaaJWzYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SZiLewJ31Wd7JJfgU0jxATyKUq9AnyFgswSLPaZDyF0=; b=o36nG7aSfMKv3U0ayxnLRCurwYs3C1OgVmZv5MUoZ04PilzzQAzxZa56/dHdRtbI2AOPUgvvGDbzbtcKDEylakQfvTONaU/tc3DkSqz10x0j1vYzzp7Fmg45lztBnbKUFaf9wg3P1760zpZ6F/AdJa+UGICnYonE18nFHPRdN+kih/6o1LS/Aw2L1TpzhkOjSC8VsL/MFiJ3QpCSDOkH404jwCiDsenGc6BPjgwEUW6REdhaOVsZvzLjwLdybmWbLh7duCwa83d5Qh2rxY8eF8xRgQaOQqrLOdoUjiPoV650OKreg+aWT13DbazxjB9jWNEuX08onmZRqKOgZNPZXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SZiLewJ31Wd7JJfgU0jxATyKUq9AnyFgswSLPaZDyF0=; b=VoibuK915YUUpdymE5LbUi3QQtpUMzJayNz93x8fpaui2J457C8XvP3j5DDu8fc4H8s90tkhZbbPHTq2L/UE5N6mmj7zV7GIrgikuwvHG6MuJd0Y4l2dPMxfKgiu3ZgnA30IConpGLUMV2ofE4E0ZgMR87FQtyfyVTpXNYUKaxvra3M7ptTHJW5ijSA5fPvZMaXdZLKUf5vqF0eoiDha5O2kCnAyIJv6anV++LWuhJarxHc9S381etHyp3YXiD4Ec0L+YhUbbVCtATpsI0wTxGgSqV5fPGi/gbyshhOswDYVLnCN+kRjVkEt7iXzvvNuNme2JIqMCxcFw3znFfoiaw== Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nutanix.com; From: Mark Cave-Ayland To: pbonzini@redhat.com, richard.henderson@linaro.org, mst@redhat.com, sstabellini@kernel.org, anthony@xenproject.org, edgar.iglesias@gmail.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Subject: [PATCH v2 27/27] i8259_common.c: add missing 0x prefixes to "info pic" output Date: Fri, 16 Oct 2026 15:19:33 +0100 Message-ID: <20261016142031.1204281-28-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016142031.1204281-1-mark.caveayland@nutanix.com> References: <20261016142031.1204281-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR13CA0103.namprd13.prod.outlook.com (2603:10b6:a03:2c5::18) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|IA1PR02MB9592:EE_ X-MS-Office365-Filtering-Correlation-Id: 6da20008-61b1-4057-26ab-08df2b90e8ec x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|23010399003|366016|56012099006|261009223027099003|10067099003|22082099003|18002099003|3023799007; X-Microsoft-Antispam-Message-Info: FIXPZHn6f3jc0f0EDgqQ5Fx9lhzvlYuJavuykZrk/DJJt8fOUwijRpXVrvd3p/y4TGT7s84MGF7wJrN699RoTzipG8ZQvFSeelkqixINSnK9Oby+i0LRKWFXo8TJ4fm6UtJ86B2kPj0flW7c+LyvyUoUOaABh9Od1MkcZiXIFNIehJAixdyDxG2JEIWAUGluVweXMgO9akHOZpCiyS7uyRCNoGg6f3APWUKfJfLCKJsIlioDEjq6XtXH60YQBmgmU4q02xm7g1EMlstwpN7EgOJDBvPon6bUNELeCKTzlodxxKntxyIC6pFNOw/LCo9eTijHhg5kq0+IzpOVF9L8rD7GEvrpJj7w4woJi24TiC6i+fb+bPIWFfdf9//1ukXEhOPFBY6xHnnlQlQ3CYAjiMM10Iqtbx66HCujLjwxu6G9wLvJ5vqjXc1gbS4pNf9bKGwN7RHq0cJVBsFyq1DCSmejqo5QfDaTX24av+GrbfnEMKdtGp+bURLvCKlZPNdi0eJTErvamRLFZZeqeFIMB6pydlX4Q86ik0BE+9H6qWU2oW1MUEVmI6Z9P65morTY4iSVVHF5oey3RSZ7w8dOxBaf3MMvFOC9yAifGktbL4rlO96zJ2k/4GzuC9kuXERa5vGo+e287UgACyFhuwaerlVxn1k27kuxmr9jK33e4RY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7159.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(23010399003)(366016)(56012099006)(261009223027099003)(10067099003)(22082099003)(18002099003)(3023799007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?i0kBk5vysg6PjFV+f7Gey2WQubxq9Op0SvUN+j8rEVFGcgf7NHUCjuEA1Sh5?= =?us-ascii?Q?ONwepzBCBC5GpfXPPytTRXCuBBxIaEoEeOzdHK+D30xhbVwQbyC0PRyD7rMi?= =?us-ascii?Q?/6KPsqY+7MpQ8a//fi8gnLE6CGQp7h4Im4HdzYaZh5j4xySuaFYE1Z4IMtj+?= =?us-ascii?Q?1pzXseygcEnyOfT/YJARVhvmqHZ9F+O4/gQb1KDIsNx+fmgICd8Izia/WQo3?= =?us-ascii?Q?qxbUG6VTsxJ74t5skfXIoExfJ7ETOkjmS72LgMXcKKmBH/8/2Y96hyrK4pW7?= =?us-ascii?Q?nIP1TFVShk0fJekzyusomnVNG6YhuCJUOkqdl9GoCqU8Y/LY8qWLjo24Z7gt?= =?us-ascii?Q?cZzDs3XGbUWCwq1JUD8J8KEcaYP5snuDTonzaQKA1qAWmif51L+k/1CKuYhx?= =?us-ascii?Q?zZqCBKyZTmpLWTmIl4cgNEO0VwmHv/5SypubkiYNVKm3512m0bBsRnxsDeB4?= =?us-ascii?Q?ohGJsUwO7LIIvbWFRvNBVLIUxkBcIf7Hfpe80xkwY/enSNI9myRm3GzAv/4N?= =?us-ascii?Q?/eTsiZVqj4CceFmMAEmPVRC32IQ9xBRpKq7pYPrS+VVdHkeOJ6jAq1z5jUA6?= =?us-ascii?Q?ACAowWX9TnIakwpquvGWZa/QpahjsD8ou2pu4gwpS1N0WJ2Sfyd3FhFSQZE8?= =?us-ascii?Q?tHkHa9LDHfmTvOsRFMd4lWJ9Yps9plQy2S/Uk8ZeeegtlzA1pNHz/muqJCwj?= =?us-ascii?Q?R/2iyS0gPe1+KKxu/tVDh7FLO886rdB7ZAwm21Qjf2+aC2z4cFzMuFFbFsJ1?= =?us-ascii?Q?g+kJNhTIWWkAMBltkhlVvPJRtHbRaQXx06ZWXVdtvhbIRhWyDjlpU25Jcsu4?= =?us-ascii?Q?Ab7oDXXH1jqony/gBMMaIQ1gIYuZrZYSYuI9Q2ajQk0cSdIxx8TD6oYzemfD?= =?us-ascii?Q?qmS4ZTv+uhad0eoCoUnfu0xX6tgO/+inq0WDQMRs/azg3bekl8nPoyvd6CBN?= =?us-ascii?Q?bCV3FixCLlJ5JBsTLCBgJGRqZChjbhOV+RMMflKbqdkayrzbXms/ri5TbJVN?= =?us-ascii?Q?no5JAylAwhJu7kxAFIHTb3mPRWp7ApsX9GUecx+Lah217mfLHeTHiejzE/so?= =?us-ascii?Q?tIH2JPuFO4Fz+eWYKXe1f2unRYxSRihqZ0/MGifPIvryDvZTfVERryjJhr6U?= =?us-ascii?Q?OuBQzW8l6FTmOlLki6NZd0AUv5ma+G+UVGfbi19wLKRZxvJYAQhdODSEIKCY?= =?us-ascii?Q?a2Pzksb9yBPwuPN4O2C7kpE5DK86Zxy0fjvNLOpnpwdg4fWkcMzkx1+ZA3+T?= =?us-ascii?Q?02WCFj1fJ5RDqUzDH0Vd3nva7SHbbfUAOnTK7H5BKDueU+7Jy+tE9i35h/gR?= =?us-ascii?Q?mZtpoAMvePchY86FXIiVDgM45BTYQmVKBfrbTS7leYdLXMkG3oqA00Pa1xLw?= =?us-ascii?Q?5+vvfMeeIjWSN+XDnNXgG8a6KU+tdfnRGeR5B62T1/X3XU6TaDTDI2UHwD8t?= =?us-ascii?Q?q3apAU0ShpsYIRZEf/dUjNTM1Hnz+nJ3JE05KMvJ5NJKRIUMOEMAyZrKGwhO?= =?us-ascii?Q?rlmFxegnmlBdXBFsb6pGz682+droXz+Ln7X0lVNHxIMUwdHf0H3UIwKsmNnZ?= =?us-ascii?Q?VQ/Wu9ZEHHYKH1I/t3m333bHQTf9GJCm7CX1uNxEAFnqZwBGIWoupfMwprxv?= =?us-ascii?Q?fgG8VfHPOC52DgDh/JiFTdECJUXR7cceCPcxzlM0dAXomAPgVWzzr88FnGNH?= =?us-ascii?Q?VJGHlR1ilgYWlDxmmfAqhw9QrHFOZcIBHdmJ8AWcv6J7ZtwYVEjuX0YxE53Y?= =?us-ascii?Q?Vlb4/2KYg3zm4Es+PP/LhpKy0GOzUm4=3D?= X-Exchange-RoutingPolicyChecked: upbk43FOKl9RXBZgd4sSBFX76SvGasDL59kvThl3M/iLw+g7/yc9RNNqYx6Il+Pw4KK5SEbvrUs9kqit8NDMVEUIbBlcGVlOahzw96RnYIF6FeVWXam/2k9PkIj6a5QP5HDTBrXOvtfArguBdr4lsz4ladOajOMplty6zS0LKJR04HhXTvgizdRFF71IPnneSN6bzR0hervRPG/3IAqiRrhPaKiAf4hRZC3Tsjb90zHfHUOCKKbbq2iqh7aAhCkMIQXaTJalL6xKhDwp4SQdGlX13NTOmHnwhSg2NqlwuJ833eOE8b3y7kVaP83wSdhljMrYxP2KOZMkC4rSs53Cag== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6da20008-61b1-4057-26ab-08df2b90e8ec X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2026 14:22:29.5906 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WYPBHOgi9gnMQp/jgWB0Jpb4tf2n7WISnoQoCBgMkfHzHvNB0OOBcyiYIaV6ImUzraoDtXhRIfAlKadBhGlGLNM7PgPywB4lMmB6Pblxf3k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR02MB9592 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX7qrY6gitTAs9 VapZWxXlZuelrHbwqkUK90x0MZDii/S7wzpBob6W1cru26x+LVIg/+17vXOGE43K1sQiKT7UPO5 1HTdnWKAWXBefeb0yb8cMa2NOVmx4YhFJjTnhbxCBcKxeLszw1DQPttVbx1tKvoqjx/8FC2fB9C KsZ2Z/uIv5ubnc34nijf/3LHDtM4icE9i7IRDM3fXgBZKMYrDLW1wR82Crsvzjmwg2qnNQ0HX3+ 9Mq0G1Yf9+I3kGznrC+ie71mQVQ2I7btiXaeqlLDyZb5T/qR6dKvE6RfsLiyBx7pGfvrgLFV4tc 2WQ+hDlJ0/VWJIyNhC6h/KJrGN9ECtP5ln4GIdjpDtSb9yp5AARdKGhpltJXykFUp09WCLJLpuv WQudX24+6+LXiexAUKFlgXPGEcLDNWQ1a7QCD+HK8Om+7mWAP58K0gPhn2UktcRfWMfi+87wd4w aUHHS6xZw1M08lXhwQA== X-Proofpoint-GUID: I-RwfBOGEqXMbL-VfK8yVZj1OoVcTCjg X-Proofpoint-Spam-Info: AW1haW4tMjYxMDE2MDA1NyBTYWx0ZWRfX9yaRnql/fJq3 ESvlONZoYb2Z9Z7tifo6PRlUtdLMEKtoGfQ/7AuJXnpA7sob9c5TNRoQOfihGhlkHf1rVBjb2X2 OLjX3xtOO77fBC+ZzJRUzlh2d2MQYTQ= X-Proofpoint-ORIG-GUID: I-RwfBOGEqXMbL-VfK8yVZj1OoVcTCjg X-Authority-Analysis: v=2.4 cv=KMLPn1Fo c=1 sm=1 tr=0 ts=6ad23341 cx=c_pps a=7kgNGXaSmB15KJ6u7rEBag==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=660iZSQnnn4A:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=VUi8bpU7OL1Oj2-RSIOF:22 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=4lKoNvaWMPz1F08twPcA:9 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-16_02,2026-10-14_01,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-purgate-ID: tlsNG-ebf023/1792160582-50CDFB50-C07CC4A2/0/0 X-purgate-type: clean X-purgate-size: 1201 X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1792160609740158500 Content-Type: text/plain; charset="utf-8" This indicates that the specified register values are being output in hex. Signed-off-by: Mark Cave-Ayland Reviewed-by: Peter Maydell --- hw/intc/i8259_common.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/intc/i8259_common.c b/hw/intc/i8259_common.c index 3bafd81ea7..ee325a659a 100644 --- a/hw/intc/i8259_common.c +++ b/hw/intc/i8259_common.c @@ -119,8 +119,9 @@ static void i8259_common_print_info(InterruptStatsProvi= der *obj, GString *buf) I8259CommonState *cs =3D I8259_COMMON(obj); =20 i8259_common_dispatch_pre_save(cs); - g_string_append_printf(buf, "pic%d: irr=3D%02x imr=3D%02x isr=3D%02x h= prio=3D%d " - "irq_base=3D%02x rr_sel=3D%d elcr=3D%02x fnm=3D= %d\n", + g_string_append_printf(buf, + "pic%d: irr=3D0x%02x imr=3D0x%02x isr=3D0x%02x = hprio=3D%d " + "irq_base=3D0x%02x rr_sel=3D%d elcr=3D0x%02x fn= m=3D%d\n", cs->master ? 0 : 1, cs->irr, cs->imr, cs->isr, cs->priority_add, cs->irq_base, cs->read_reg_select, cs->elcr, --=20 2.43.0