From nobody Fri Oct 23 14:30:36 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=canonical.com ARC-Seal: i=1; a=rsa-sha256; t=1792169989; cv=none; d=zohomail.com; s=zohoarc; b=PphKjexiQUPDJDXwRHL6Q8YqgdmeLLngly6z2wGVXZB320r7+WNR2ULw3tgwIill03hMfB7diLZkApS91HzUrsmny0G6VTAUvF50R1pI9hFFiKb/RqtP5ruiqlPYq/XDdgxMsp6tPd2Qrv8Rj5y+XA/SP9RqUmhZ4zRSixyCEI4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792169989; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=kJmMc1isr6JqKVmGnKacr5dqB9sK1nWZcd15GvDcKN8=; b=eOBcmk7XJmQw+azlurQyOWp6c60kz7wNVyqqujXKpiYjDhqiTK3K2UkY2Ot8yaalNZn4oLJXm2d3llYxod/GvVSNuPNXgFQBERCZIQWJ+Zv/qweM3kJoqwJhkENx0UKTKw6l6mLdMXh+r6w4SqrcsPmqVcaeq7QHrrdPRMxd8iU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1792169988991723.9497781676405; Fri, 16 Oct 2026 09:59:48 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xHlGf-00084q-QO; Fri, 16 Oct 2026 12:58:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xHlGV-00082S-Qz for qemu-devel@nongnu.org; Fri, 16 Oct 2026 12:58:45 -0400 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xHlGT-0005ju-No for qemu-devel@nongnu.org; Fri, 16 Oct 2026 12:58:43 -0400 Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id B0AB93F28F for ; Fri, 16 Oct 2026 16:58:38 +0000 (UTC) Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-879b1d03d5fso1512637b3.0 for ; Fri, 16 Oct 2026 09:58:38 -0700 (PDT) Received: from [127.0.1.1] ([2600:6c45:3000:1420:26da:25ea:7a28:6e4d]) by smtp.gmail.com with ESMTPSA id 00721157ae682-8b0e58ad1b4sm12193167b3.18.2026.10.16.09.58.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Oct 2026 09:58:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20251003; t=1792169918; bh=kJmMc1isr6JqKVmGnKacr5dqB9sK1nWZcd15GvDcKN8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RBHHoCLyGPPKon0PPgF5y9e7WShel0BSA2+oGZOrDvxSk8MFME92lOVNksW6VCpYK s1DPmdJtQOzBByOlkjYYtnhvO0Ckzf6JvBeVFgfdKgDayzp/u2ylDXj9e5btU4TBJG GlJPDeNjlVOpdnQko+3VKhYQj0cpiHTjBeMVVyrBeI4weTbyDl+lOb4cojM0GV2J29 y/be+cYg3mXE7DkaeKA30VJ/qCrOLe2lqy6Ql0kGPQ5HzRXkBPBaiYV5mpQqWu0EXE RQJufmDR8PfHi3mZGzHQArBQIynE/WT/UNyri9dtqNxT7xub1FQUE+nF16wePNcXdd i+IW7q6GvmxzqOeyL9q6IJba7AwaELE+VVO1M4bz7gAikAAAsQ6Uk33kFjK/RhDhWp NMmNuq3YLztI3grX8Q7tjhb/mi9XwWTbzBgk3kI1Q+OURpwa5j4gfaNNBo/o79136n 8HUJkH1usnAVd2INOXzQdX+b79dh5EMTTdOlb3FJQsNZDxBPV7g7at8ez/gIWK1gdZ mrKYQ3G4nY+4Dffd8fbnvwQEnjAdrce3VgAHiSsGqGy3nmOs2DEMbeBqxHHa5zTRxp mL1GxTxJKVc3cSTGLL5t9FqZDMTnDnvoG6Yg9RpeBLQWCllUyYAQ25zmJqT7uqYyk9 bSfY2R8VuTLsMxQg/jEPLcs0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792169917; x=1792774717; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kJmMc1isr6JqKVmGnKacr5dqB9sK1nWZcd15GvDcKN8=; b=OLsoIiyxSZwLfkhhWSxR+Oe6KTdOGbSFH1RfLKcsvDIKEXgRRj1BK+oWiGys3Xy9mt p/JBwElpAZhilfj4Y3Bna9LddbbLm/6q/a0fHK1IBSriKa1C4ULt7UWa13vJ6jVsIZpC 3YnHMCMyTsJ/KZZK97WYeVjmWFhwFihXWGMDLf0vR5ioEUvAzsZd+Gryncu3KnQqkpTP kySw1Mb95SATGurqYTm7rOKxVgnqgdDeJws/U5tSERV6RYya77eLJACKiMZx/i2KoKeq uVhl+PSX8cOf5Ujwwa6rfxtFHrshplzlXs5xPFQs1Mj9nkfe6L3DAPRYGe07fbpEsTk8 XuKA== X-Gm-Message-State: AFq9FYIg/BMgtmz9EWIekRm/vxgRC0jHki9eTb05FXYgauGowhRAZFxZ scX3il57Z/1mEd/GTwdLRGV7yABdPrEsUtDD2jk7rENZjxEGvOU2E/Sk6sqvpvuJkMTAHVDCmue /7jPwNSzb6HrMkAGoyobFnqb2Qjn2wYghQXwrVMISmDgnSRxYuyMk7zNoZNZDMnIj4E0wHffn X-Gm-Gg: AYBFou3y4/OqXkZseZsXucI/TpXXVDzKvbh54PBsruXZgxKjkgbhqCrCoCyQIWfI3Fh W+HIslMfFhLxxkOe04C0S/sOReHxxmtsZ1cUQ9LL9umax62TeG22En8XjpxXzJIj0u4pP1NBC+j k/gV1ProrIKYPeJVD4obQ8ER0xOoD9B/3ZjBLibOBmm517IDnw7RT7njCMCeXqxVplO3B3Iy4bK 8yXV+WfNb/xlluIoUEhZuFb486hUqwhlWEuePk0o9ImohHvpeCLEv9yubPZ+1K2nScLFP5eerrB 7pwcWVmyUhmGiMe9g0OpIJSTC6RzDx3FE4PvjMWThs64DvqRhocztqch61fk3coeZqKhL1zIGM7 0FKAcWsC+hQCNERiLCUmoJcfbOWu70wOgCQcYCf3bmuVVYYw9mxcrqQ== X-Received: by 2002:a05:690c:7107:b0:8b0:e10d:1971 with SMTP id 00721157ae682-8b0f205669bmr2407547b3.6.1792169917608; Fri, 16 Oct 2026 09:58:37 -0700 (PDT) X-Received: by 2002:a05:690c:7107:b0:8b0:e10d:1971 with SMTP id 00721157ae682-8b0f205669bmr2407467b3.6.1792169917127; Fri, 16 Oct 2026 09:58:37 -0700 (PDT) From: Wesley Hershberger Date: Fri, 16 Oct 2026 11:57:51 -0500 Subject: [PATCH v5 1/2] util/coroutine: trim sysctl's max_map_count newline before parsing MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20261016-set-default-pool-size-v5-1-719e9e4d3f9c@canonical.com> References: <20261016-set-default-pool-size-v5-0-719e9e4d3f9c@canonical.com> In-Reply-To: <20261016-set-default-pool-size-v5-0-719e9e4d3f9c@canonical.com> To: qemu-devel@nongnu.org Cc: Stefan Hajnoczi , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Kevin Wolf , Hector Cao , =?utf-8?q?Alex_Ram=C3=ADrez?= , Wesley Hershberger X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1540; i=wesley.hershberger@canonical.com; h=from:subject:message-id; bh=b86ZQcF9Hg5f4iMTF56xzgWjaMTuxnTtIpZIS+Pz1NM=; b=owEB7QES/pANAwAKAfkogKziOh25AcsmYgBq0le5itqR6q4DESuN2V8n218GC5ntnhKGe1o1G 0v39rOfBdSJAbMEAAEKAB0WIQQsIHxFLwpehxEbQ8r5KICs4joduQUCatJXuQAKCRD5KICs4jod uZROC/9Q1m3zjdknM2Mpk7+aMciG6xy8IgODifZAi4UmBaNC0hzzTw3Lm40WGbUyiXZaXrsTUYu 1u1518n99dnHdUxlVOuJxbI698q1vr6ZkO8MwdvyzN6yhza9mB47vY7EyQDoeb8fhiuN0c/Ep/S 2nKZ4aUAWeq4L40bCXqXCkORDDTrwyztToLXP5b/Tzvs3FQ7+yF9la7kY75QSYX4f0gRT8AoSuL HWUiPNxSLchSUVsFk4o4wZh4qcaAsGKfAWHSQxyvPv7wGHE6h5rtfzDn73XP+avpf5jiqH5NuVS gfildsykd+MTN5jMD8piPCH5kUjlkY6KKhM+NCFBjWcVFeUJ/raGkTv1AtjEq8WKBqCjmdIYstK g9HmEFI2gMofzLyuTIgOdDp8TxdR4exjepV58mN4pcV93iy37yJfkcdw+ZDzpdGtgTKuKLPwgTZ 3Bl/jwIBrnM6Dea+scZy3yWF0Vw8LHHMNiHaN6N9zIbr9VBWaKNheCUGQbwB9By1o1VA4= X-Developer-Key: i=wesley.hershberger@canonical.com; a=openpgp; fpr=2C207C452F0A5E87111B43CAF92880ACE23A1DB9 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=185.125.188.123; envelope-from=wesley.hershberger@canonical.com; helo=smtp-relay-internal-1.canonical.com X-Spam_score_int: -45 X-Spam_score: -4.6 X-Spam_bar: ---- X-Spam_report: (-4.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.24, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @canonical.com) X-ZM-MESSAGEID: 1792169990783158500 From: Hector Cao Strip trailing whitespace from max_map_count before passing it to qemu_strtoi(), allowing the strict full-string parse to succeed. Otherwise, qemu_strtoi() fails to parse the string and returns -22, making the global cache pool cap size set to UINT_MAX. Fixes: 86a637e48104 ("coroutine: cap per-thread local pool size") Signed-off-by: Hector Cao Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Stefan Hajnoczi Signed-off-by: Wesley Hershberger --- util/qemu-coroutine.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/util/qemu-coroutine.c b/util/qemu-coroutine.c index d17135f585a..5af61995437 100644 --- a/util/qemu-coroutine.c +++ b/util/qemu-coroutine.c @@ -374,8 +374,12 @@ static unsigned int get_global_pool_hard_max_size(void) * VMAs. */ if (g_file_get_contents("/proc/sys/vm/max_map_count", &contents, NULL, - NULL) && - qemu_strtoi(contents, NULL, 10, &max_map_count) =3D=3D 0) { + NULL)) { + /* contents has trailing newline, remove it before conversion */ + g_strchomp(contents); + if (qemu_strtoi(contents, NULL, 10, &max_map_count) !=3D 0) { + return UINT_MAX; + } /* * This is an upper bound that avoids exceeding max_map_count. Lea= ve a * fixed amount for non-coroutine users like library dependencies, --=20 2.53.0 From nobody Fri Oct 23 14:30:36 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=canonical.com ARC-Seal: i=1; a=rsa-sha256; t=1792169992; cv=none; d=zohomail.com; s=zohoarc; b=Ze1gk4tx2rDBeu01JlzjvlGyFwX89nYJih83AWynOG7Z+jIOUZT1Cz49c9lWX6sfL6lFxEK5OypP5ol++emAxKG4fIpwQxzIawRLWy8vhmzy78395TLCOhaQ5yKIbNNe82VPTAyNd1kSOkDapUVrqIgueTwR+iSfnVMd3E7SJeY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1792169992; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Uxep4lAMFTJMpmjQLfgum4WJqUhVTQg6C/p5qA8d+B0=; b=mllkt9Exr4OjwiD1lDgLGSgIuOqRPtiDzXX26WAFfo6goxan8GcBv90eh0LUNI6AbDij0A27w/MNHF88hMIPa6A/Ulivh5DMtLtIYTJ5jN+h0QMJb+sypSo4+4nkR/QUDT5K+RDauYxfDtEqDcl5d3OejnL1/cD4lNLSbQtLUVE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1792169992052658.6817090458791; Fri, 16 Oct 2026 09:59:52 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xHlGg-00085Q-RK; Fri, 16 Oct 2026 12:58:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xHlGX-00083A-Lb for qemu-devel@nongnu.org; Fri, 16 Oct 2026 12:58:47 -0400 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xHlGT-0005k6-Np for qemu-devel@nongnu.org; Fri, 16 Oct 2026 12:58:44 -0400 Received: from mail-yw1-f197.google.com (mail-yw1-f197.google.com [209.85.128.197]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 92DE13F982 for ; Fri, 16 Oct 2026 16:58:40 +0000 (UTC) Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-8acc7fe346cso1336957b3.3 for ; Fri, 16 Oct 2026 09:58:40 -0700 (PDT) Received: from [127.0.1.1] ([2600:6c45:3000:1420:26da:25ea:7a28:6e4d]) by smtp.gmail.com with ESMTPSA id 00721157ae682-8b0e58ad1b4sm12193167b3.18.2026.10.16.09.58.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Oct 2026 09:58:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20251003; t=1792169920; bh=Uxep4lAMFTJMpmjQLfgum4WJqUhVTQg6C/p5qA8d+B0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AJa5xkK1IfMQObbMZjP2gaTSitpYUtxtxFOzjfnOfe+mIPRwKTwkvqTmUbOyhKpEi RNEUa+KvtaKhHyCG6ojkePYmxPV78M7gEjPy2/LhW2wI2aLNfoU9hLvDGweVUOSx8k FmZ1vY2pIiMlFsV+FqxMxgYEU2mzsvQ4Oas3+s5TeHP/RD6qUf+gtlQaUxd/jw3/9b ODXV/cL00aD5uR6N8qtzW+dxZ9tTL4SCfzssCuIPUh18U6l9hq16sIbAxl0NRDNQEL CKcFUsRTR4d/cld0CNjz0ktCzRn5DXuWgI9o/qKLxRaV/W3hDTvhMRyAeYokjQZK0F ejFOgEGtZodzA31zE/gL55WVIW1Q6orG/dwXpFwfS3o7Hy5OKD5T+1eoszr4RKb5aW WpEui8wNVeMow5ZzkgchtEnbuGA5TK+InXRV2gKQPcHxTAd653fmsnHZMG4cnTM3Gv YsnQmWJiqMz9Syyqbje26m4c59YAcVhgVATkWXuT8wbTM+R5vYwpJZTKrRX6zyu4OF zl5vkPvyJvHtRa71RlSNCHCaDi+fDy7EvN6BoNWxp8FBpXAVxNWDRSoGiCesZut3jo 3T9KYD8nnTs5PkXNAN9++gAfJJ6ZWUmMneOf8/D8rPQgxoOL/IpRdKUb0oXeC0NW0I iNXvNk4YxOutAb0c43zp6fmc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792169919; x=1792774719; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Uxep4lAMFTJMpmjQLfgum4WJqUhVTQg6C/p5qA8d+B0=; b=GCXbufFn0GumY6y0fskY4mt2uouH1LMfnecmaBwqGRHMBSqVmXEQKVFfmXu78UVnay C7V6EWYv/PXY5f+4JYTraDDjKTsPkVhUf/4t9/NGyj+YrEzzQhhwwuUYdoIi689iWgsQ tBdqRPIt31E7G5esyroCzBbPDaW735eefcr5qhUFTmd2o7zTtcjrpS62fjenXuvxrIeb h0sNxEpjX5x2d5JBSVCvWDqhlryZbFtT4Ejr3pKqHITNjLIFetAQxQMm5+43gft/dSJf tmhozZGwhvuEjmr3GhR5yAkKyRyP+9aFEK23b2r30SMfVRwNznqhAfYb2yoQS67De1X/ sgvQ== X-Gm-Message-State: AFq9FYJjdpHH20Zi5g/n7ShePkvg82V92I5ereRIxngnsNeodTMqlKlL ZfZQHJgHzjyW8UAzDNd/KKtUef8rLsbAyd6jto4LeoTyQ2pA+ducl8/nQgi/Y337lC/gc6w8oKc S/HfkKmH6NWGiO3XhM/UGh020Ma4fu97w3SzD6C7NjNUWtcbuTUUea4IzHU0bkMElChNHrM7V X-Gm-Gg: AYBFou0PMYNKXOyAlhiu/0pqmYTL97cCOqJcY1LvWSSl/NOk7Uj2RavlujR1I4DKbzZ hEIWspwnChA5BaEyghWu/OQGAbhuOmQz8RZIIvoOjimwi46QaEdoUX61Uzf9Iv3hQ1xwbdnKmMU 0TXCkfcxDo4NtVEHQ8BPJ97/i/Z62N1XSdPXpGnXm1oaQmDzlzXs0V5TOdKcloI4df0Rj9spx36 DX6WdClOKlqiE2hnsnWq8heee924FhGZyrhm9BwiTEzPFBNAx5kKMOVCY0oi1yZYe+AsAlaPBey cUFBFgrf9eq4OIM4T0MUV4AggfRtyZKfNIzutDgHhcNXaDi4WRXUBZRCYevsvwLphCF1vWylxnh 4NLX8rK4LOock/cO7yu/ZN2uhUvEp7ATzhIBbzt2w1POlfAmKII2yGw== X-Received: by 2002:a05:690c:6604:b0:88a:4770:c2e9 with SMTP id 00721157ae682-8b0f214735dmr2952187b3.14.1792169919192; Fri, 16 Oct 2026 09:58:39 -0700 (PDT) X-Received: by 2002:a05:690c:6604:b0:88a:4770:c2e9 with SMTP id 00721157ae682-8b0f214735dmr2952077b3.14.1792169918771; Fri, 16 Oct 2026 09:58:38 -0700 (PDT) From: Wesley Hershberger Date: Fri, 16 Oct 2026 11:57:52 -0500 Subject: [PATCH v5 2/2] util/coroutine: Reduce default idle pool max size MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20261016-set-default-pool-size-v5-2-719e9e4d3f9c@canonical.com> References: <20261016-set-default-pool-size-v5-0-719e9e4d3f9c@canonical.com> In-Reply-To: <20261016-set-default-pool-size-v5-0-719e9e4d3f9c@canonical.com> To: qemu-devel@nongnu.org Cc: Stefan Hajnoczi , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Kevin Wolf , Hector Cao , =?utf-8?q?Alex_Ram=C3=ADrez?= , Wesley Hershberger X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=4042; i=wesley.hershberger@canonical.com; h=from:subject:message-id; bh=7S4rtSqSrMu1r94QRHzeGQHLhS2L8aSAcTCaxlCaCjM=; b=owEB7QES/pANAwAKAfkogKziOh25AcsmYgBq0le6TRvLrfeLPZLMIo4vdq+LzfsokrgbCPjmU 1u3pol+PzGJAbMEAAEKAB0WIQQsIHxFLwpehxEbQ8r5KICs4joduQUCatJXugAKCRD5KICs4jod uUNxDACGkrxMRIY3zID/Sjo0NxBUGMjzZDqmhTQVIfyNxTf74pp42qHwmccvpF6O9o7plwCbkfz QwlUetUVo5VVVjKEmPs9EP+U2Csd3gH6yleqVYzJ78tYlcXkHsKYM3fDHK4rqxhufkwMP29zl88 Qusxky+M0k2sO+p5iTcOpW/4eMXXFGi3rUVYY+TKGkRXOo1F82F0HsqbcZCtLBbKoL60IZDYp+0 BQ2RSvvkQI7Yzhz32qCufX9pvETsQCWMABIv8FQDFjicr9WCV8VRGwDP+qUotUdeIPHO7ltH3rW Q/SyPrUSWmD2p2bkJ8IymwfD1/EdnH+HvhCAubpzmR2+51p0FfboAJUR0b9SlM9QamAyabXhUYy EYBNGKsQy6aoxqla373Wxcl0tqfH4iKXZumMpcfyNdvK/wh0utC8SH2CC9J3sxIrsthD1eEGzkq 9TfQciiy3g4eaeuFnqINYC/TI3yvEGfEtGdgzTWjDIf05BXlcICOcrtjbkrXUBP6KpL0o= X-Developer-Key: i=wesley.hershberger@canonical.com; a=openpgp; fpr=2C207C452F0A5E87111B43CAF92880ACE23A1DB9 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=185.125.188.123; envelope-from=wesley.hershberger@canonical.com; helo=smtp-relay-internal-1.canonical.com X-Spam_score_int: -45 X-Spam_score: -4.6 X-Spam_bar: ---- X-Spam_report: (-4.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.24, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @canonical.com) X-ZM-MESSAGEID: 1792169994619158500 If g_file_get_contents fails (AppArmor, etc), use a more conservative default max size for the idle coroutine pool. This avoids any possibility of the failure described in 86a637e48104 unless the host kernel is configured with a lower-than-default vm.max_map_count. This change is motivated by a discussion of backport risk: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/2168803/comments/8 Fixes: 86a637e48104 ("coroutine: cap per-thread local pool size") Suggested-by: Daniel P. Berrang=C3=A9 Reviewed-by: Stefan Hajnoczi Signed-off-by: Wesley Hershberger --- util/qemu-coroutine.c | 73 ++++++++++++++++++++++++++++++++---------------= ---- 1 file changed, 46 insertions(+), 27 deletions(-) diff --git a/util/qemu-coroutine.c b/util/qemu-coroutine.c index 5af61995437..fc9ed66f475 100644 --- a/util/qemu-coroutine.c +++ b/util/qemu-coroutine.c @@ -361,42 +361,61 @@ void qemu_coroutine_dec_pool_size(unsigned int removi= ng_pool_size) global_pool_max_size -=3D removing_pool_size; } =20 -static unsigned int get_global_pool_hard_max_size(void) -{ #ifdef __linux__ - g_autofree char *contents =3D NULL; - int max_map_count; +/* + * include/linux/mm.h + */ +#define DEFAULT_MAX_MAP_COUNT 65530 =20 - /* - * Linux processes can have up to max_map_count virtual memory areas - * (VMAs). mmap(2), mprotect(2), etc fail with ENOMEM beyond this limi= t. We - * must limit the coroutine pool to a safe size to avoid running out of - * VMAs. - */ - if (g_file_get_contents("/proc/sys/vm/max_map_count", &contents, NULL, - NULL)) { +static unsigned int get_max_map_count(void) +{ + g_autofree char *contents =3D NULL; + unsigned int max_map_count =3D 0; + if (g_file_get_contents("/proc/sys/vm/max_map_count", &contents, + NULL, NULL)) { /* contents has trailing newline, remove it before conversion */ g_strchomp(contents); - if (qemu_strtoi(contents, NULL, 10, &max_map_count) !=3D 0) { - return UINT_MAX; - } - /* - * This is an upper bound that avoids exceeding max_map_count. Lea= ve a - * fixed amount for non-coroutine users like library dependencies, - * vhost-user, etc. Each coroutine takes up 2 VMAs so halve the - * remaining amount. - */ - if (max_map_count > 5000) { - return (max_map_count - 5000) / 2; - } else { - /* Disable the global pool but threads still have local pools = */ - return 0; + if (qemu_strtoui(contents, NULL, 10, &max_map_count) =3D=3D 0) { + return max_map_count; } } -#endif =20 + /* + * Read from /proc might fail due to mandatory access control (AppArmo= r, + * SELinux, etc). Use the kernel's default in that case. + */ + return DEFAULT_MAX_MAP_COUNT; +} + +/* + * Linux processes can have up to max_map_count virtual memory areas + * (VMAs). mmap(2), mprotect(2), etc fail with ENOMEM beyond this limit. We + * must limit the coroutine pool to a safe size to avoid running out of + * VMAs. + */ +static unsigned int get_global_pool_hard_max_size(void) +{ + unsigned int max_map_count =3D get_max_map_count(); + + /* + * This is an upper bound that avoids exceeding max_map_count. Leave a + * fixed amount for non-coroutine users like library dependencies, + * vhost-user, etc. Each coroutine takes up 2 VMAs so halve the + * remaining amount. + */ + if (max_map_count > 5000) { + return (max_map_count - 5000) / 2; + } else { + /* Disable the global pool but threads still have local pools */ + return 0; + } +} +#else +static unsigned int get_global_pool_hard_max_size(void) +{ return UINT_MAX; } +#endif =20 static void __attribute__((constructor)) qemu_coroutine_init(void) { --=20 2.53.0