From nobody Thu Oct 22 19:23:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1791799974; cv=none; d=zohomail.com; s=zohoarc; b=iIFan+qxFG0bXx11CjJri5bELUQMW5XOmSygtFm4j5p6a+C2fhsDDmCcc+i+4eN1Hpng5xQSWV6MXnCQkhuybIxBX0CqAq/fduDAaF6HLGPbhazCKyguaUL5a9VGxsCV/2VVPPNdNy5SEgcsE4fjgdPINQl1o6mM8QLDzYN2+0A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1791799974; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+ZBjrXnt7O3rGxeMvln+JI2KQkcDn982QMSpt3d7j5g=; b=ewKfeZhuQ58nkFXdKbNgCltqX8FhjEH70WlzeVQ6e2+KyseuEWkAACoJCMWgyNs9y1xoCXQdUOAp1B368FvqWZPU9POO2MlsbAu6d897heeZkuyVWXrvwfU5X7rgWH2SEaykUIQh9XNAhX/ty5eufR38VlpDyJgafjKF8PhWZJA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1791799974892116.57510639180339; Mon, 12 Oct 2026 03:12:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xGD12-0004cs-UG; Mon, 12 Oct 2026 06:12:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xGD0e-0004aE-Ef for qemu-devel@nongnu.org; Mon, 12 Oct 2026 06:11:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xGD0Z-00030F-7k for qemu-devel@nongnu.org; Mon, 12 Oct 2026 06:11:55 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-282-RhV86F72O9mPz_BL3T4TJQ-1; Mon, 12 Oct 2026 10:11:47 +0000 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D5DFC18000A3 for ; Mon, 12 Oct 2026 10:11:46 +0000 (UTC) Received: from berrange.csb (headnet03.pony-001.prod.iad2.dc.redhat.com [10.2.32.114]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2459A472; Mon, 12 Oct 2026 10:11:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1791799909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+ZBjrXnt7O3rGxeMvln+JI2KQkcDn982QMSpt3d7j5g=; b=May4TJE8iM1GdmQLluz40J6hsQz5n3uzeJv9dx4Mc/mZSAPpvq3MrdZrG0lTZo2QEMyu41 MBiasu1FfL+xbjS7bpB5IbKH6/8Ebg9PDYdhMuNW8vgowlPMMqlPj7EY5a2hwv/uTnxQjK NF8EfOxkztkOnRoc2SoWg5fHeauaOpE= X-MC-Unique: RhV86F72O9mPz_BL3T4TJQ-1 X-Mimecast-MFC-AGG-ID: RhV86F72O9mPz_BL3T4TJQ_1791799906 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH] seccomp: really fix blocking of setns/execveat/unshare Date: Mon, 12 Oct 2026 11:11:44 +0100 Message-ID: <20261012101144.58085-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.24, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1791799976432158500 The previous fix for setns/execveat/unshare mistakenly copy and pasted the clone_args filter, which is inappropriate for these syscalls and had the effect of weakening the seccomp filter. Fixes: f33fb19cab (seccomp: fix blocking of setns/execveat/unshare) Fixes: https://gitlab.com/qemu-project/qemu/-/work_items/4671 Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- system/qemu-seccomp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/system/qemu-seccomp.c b/system/qemu-seccomp.c index 3889d48b4f2..cd2c1b0b747 100644 --- a/system/qemu-seccomp.c +++ b/system/qemu-seccomp.c @@ -250,12 +250,12 @@ static const struct QemuSeccompSyscall denylist[] =3D= { #endif #ifdef __SNR_execveat { SCMP_SYS(execveat), QEMU_SECCOMP_SET_SPAWN, - ARRAY_SIZE(clone_arg_none), clone_arg_none, SCMP_ACT_ERRNO(EPERM) }, + 0, NULL, SCMP_ACT_ERRNO(EPERM) }, #endif { SCMP_SYS(setns), QEMU_SECCOMP_SET_SPAWN, - ARRAY_SIZE(clone_arg_none), clone_arg_none, SCMP_ACT_ERRNO(EPERM) }, + 0, NULL, SCMP_ACT_ERRNO(EPERM) }, { SCMP_SYS(unshare), QEMU_SECCOMP_SET_SPAWN, - ARRAY_SIZE(clone_arg_none), clone_arg_none, SCMP_ACT_ERRNO(EPERM) }, + 0, NULL, SCMP_ACT_ERRNO(EPERM) }, /* resource control */ { SCMP_SYS(setpriority), QEMU_SECCOMP_SET_RESOURCECTL, 0, NULL, SCMP_ACT_ERRNO(EPERM) }, --=20 2.56.0