From nobody Thu Oct 22 19:22:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1791572398; cv=none; d=zohomail.com; s=zohoarc; b=cbcJoyZB0gJW8GMw61E+6UavdLuogyWHjIA0+7vP8xyHh8i2/kM8hzUJ+Y3Pig8Aic3jZ8h50dpOleOgELBIXS+UOUf6juW+uzU2ebTTzgncgRJ+Se1BSIRfwppQW5yr5YEZkQDyN6Bmcf3wK5PlYFoFFr+VgCVr7GGPO9FnfLU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1791572398; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=iCZO7dLO0jFn2JYfOSJgyjIDhn7OqYcujdICk5TLzrA=; b=Zp6n1ANQ+SJoZ3W3rbjd/SFiAxXzDNRAr3J4h4/tgd7rUB/QwWvDno3Bk6UjyvETzFQAVF846LqdTCcjIBnZHPOtll/9ApY59Lw0JHPrgl8cB/Znlc7V0qGTPuGPjy7Yxsfm1npAaPy/mndBZ10JtYU/9JdLADYpkaK2UEexvuI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 179157239798164.45883424392082; Fri, 9 Oct 2026 11:59:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xFFoD-0002rd-TF; Fri, 09 Oct 2026 14:59:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xFFnr-0002op-2n; Fri, 09 Oct 2026 14:58:47 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xFFno-0004aY-IL; Fri, 09 Oct 2026 14:58:46 -0400 Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 699HaBAo699778; Fri, 9 Oct 2026 18:58:40 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4h74terd6p-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 09 Oct 2026 18:58:39 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.11/8.18.1.11) with ESMTP id 699H8FtM1142919; Fri, 9 Oct 2026 18:58:38 GMT Received: from smtprelay01.wdc07v.mail.ibm.com ([172.16.1.68]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4h6udd2epr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 09 Oct 2026 18:58:38 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (smtpav06.dal12v.mail.ibm.com [10.241.53.105]) by smtprelay01.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 699IwbYe5505934 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 9 Oct 2026 18:58:37 GMT Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 35B6358059; Fri, 9 Oct 2026 18:58:37 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7FB2F58043; Fri, 9 Oct 2026 18:58:36 +0000 (GMT) Received: from li-d664314c-3171-11b2-a85c-fa8047ef35bd.ibm.com.com (unknown [9.67.47.107]) by smtpav06.dal12v.mail.ibm.com (Postfix) with ESMTP; Fri, 9 Oct 2026 18:58:36 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=iCZO7dLO0jFn2JYfO SJgyjIDhn7OqYcujdICk5TLzrA=; b=AIr8pXZXhBlIaJaI+6aZPnXosCjb9RFkL AVRqSnVtX6RvtJWYkioJTZjZp71yc2m06d+/WwlRfGrHjJ1EUyTepcbOu9btParM jdqPCZpByIgo7vH3o5wIYzSoYplNipGgSKsw06f49HuIv0MZQwxaEslniQr0TGRX Sd/3FBPmIjZ3gix3t02dZ5YbaXQeMtpaTfOKtddpBEYTINpTg8s3Rwaac3htCbIy i4R73mUSDXVD1JG5Vbb2g6+5JCGlPA6qh9iWFBQvAwYwHHMCgAzVvQ/Ctdyi1sJx x3G2HTrbXPl2wCTbKMVvaI4EIcTrUrvuUJrHeLijNWs82OaSr7lFw== From: Collin Walling To: qemu-devel@nongnu.org, qemu-s390x@nongnu.org Cc: Hendrik Brueckner , David Hildenbrand , Richard Henderson , Ilya Leoshkevich , Cornelia Huck , Eric Farman , Matthew Rosato , qemu-stable@nongnu.org Subject: [PATCH v2 1/2] target/s390x: externalize feat dependency array Date: Fri, 9 Oct 2026 14:55:58 -0400 Message-ID: <20261009185559.144750-2-walling@linux.ibm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261009185559.144750-1-walling@linux.ibm.com> References: <20261009185559.144750-1-walling@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDA5MDA3NCBTYWx0ZWRfXzmqTj4EneL3V XEUCxrK47kn7LgKnzkCYIzKuLVwBfpLl/ggadiIz8KjV2wZ5IwT9yNoI2k6PWcwF6PtydkoDgcM YESKeSCaOh6f4n6L2WY/eazc/kvypiY= X-Proofpoint-GUID: B9Ecr48wVmH-b3LdVLFfIybeMhwX3zfR X-Authority-Analysis: v=2.4 cv=P42vFSAu c=1 sm=1 tr=0 ts=6ac9395f cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=660iZSQnnn4A:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=U7nrCbtTmkRpXpFmAIza:22 a=VnNF1IyMAAAA:8 a=J9yxhjP8jEmLe4H_R3sA:9 X-Proofpoint-ORIG-GUID: B9Ecr48wVmH-b3LdVLFfIybeMhwX3zfR X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDA5MDA3NCBTYWx0ZWRfX8gL90xG79ale 1pg7Xg9Von2JmO7xYSHxwb9hGYU3ruxgIahJ+wvclITGCxrbzoZFTLOHxit7HtPC+6CE6q8osYb 5akbsFMyJbpocmf3fH3gvIhRTiRUH3i0ZwvmJI9BlAkpG59Aj6V9hqpuvQ/Ym00BbF/BYDaLpDI YhlUOee0GvLDUAOl2AOUgqF923RvHrFLPRqqFsArVeGSXgqso/nobZkf4y2JKcDlTDXTHUtEVF6 8UNceS9HcrC/3lOCsrISV8aYJGkERfK6WevT6QeUcvH4cstRYDOqMO4wcF3boLFKYu83pPA180D g3qQnARNAtpPK8Velw1UdYqRnZwStj9nvsqrHQuHtQ8qDjcVGYDIDUhCJ4i8eVt9CWr/EsWvrcP YG5MRF67SQzlfvCRymbl5rcvtnmzLEI7ItQZzQy823alwTgnCAx1sBugofTJnStpZjQiKWmYjoI 36+0xyUNM4dRAJWijQg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-09_05,2026-10-09_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 suspectscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 clxscore=1011 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610090074 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=148.163.156.1; envelope-from=walling@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UPPERCASE_50_75=0.008 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1791572400120158500 Content-Type: text/plain; charset="utf-8" Move the feature dependency array (dep[][2]) from cpu_models.c to cpu_features.c, rename the array to s390_feat_deps, and externalize its length. This will allow the array to be used between both files. Signed-off-by: Collin Walling Reviewed-by: Hendrik Brueckner Reviewed-by: Eric Farman Reviewed-by: Matthew Rosato --- target/s390x/cpu_features.c | 126 ++++++++++++++++++++++++++++++++++ target/s390x/cpu_features.h | 4 ++ target/s390x/cpu_models.c | 133 ++---------------------------------- 3 files changed, 135 insertions(+), 128 deletions(-) diff --git a/target/s390x/cpu_features.c b/target/s390x/cpu_features.c index c634e741236..20f9947c7be 100644 --- a/target/s390x/cpu_features.c +++ b/target/s390x/cpu_features.c @@ -223,6 +223,132 @@ void s390_feat_bitmap_to_ascii(const S390FeatBitmap f= eatures, void *opaque, }; } =20 +const int s390_feat_deps[][2] =3D { + { S390_FEAT_IPTE_RANGE, S390_FEAT_DAT_ENH }, + { S390_FEAT_IDTE_SEGMENT, S390_FEAT_DAT_ENH }, + { S390_FEAT_IDTE_REGION, S390_FEAT_DAT_ENH }, + { S390_FEAT_IDTE_REGION, S390_FEAT_IDTE_SEGMENT }, + { S390_FEAT_LOCAL_TLB_CLEARING, S390_FEAT_DAT_ENH}, + { S390_FEAT_LONG_DISPLACEMENT_FAST, S390_FEAT_LONG_DISPLACEMENT }, + { S390_FEAT_DFP_FAST, S390_FEAT_DFP }, + { S390_FEAT_TRANSACTIONAL_EXE, S390_FEAT_STFLE_49 }, + { S390_FEAT_EDAT_2, S390_FEAT_EDAT}, + { S390_FEAT_MSA_EXT_5, S390_FEAT_KIMD_SHA_512 }, + { S390_FEAT_MSA_EXT_5, S390_FEAT_KLMD_SHA_512 }, + { S390_FEAT_MSA_EXT_4, S390_FEAT_MSA_EXT_3 }, + { S390_FEAT_SIE_CMMA, S390_FEAT_CMM }, + { S390_FEAT_SIE_CMMA, S390_FEAT_SIE_GSLS }, + { S390_FEAT_SIE_PFMFI, S390_FEAT_EDAT }, + { S390_FEAT_MSA_EXT_8, S390_FEAT_MSA_EXT_3 }, + { S390_FEAT_MSA_EXT_9, S390_FEAT_MSA_EXT_3 }, + { S390_FEAT_MSA_EXT_9, S390_FEAT_MSA_EXT_4 }, + { S390_FEAT_MULTIPLE_EPOCH, S390_FEAT_TOD_CLOCK_STEERING }, + { S390_FEAT_VECTOR_PACKED_DECIMAL, S390_FEAT_VECTOR }, + { S390_FEAT_VECTOR_PACKED_DECIMAL_ENH, S390_FEAT_VECTOR_PACKED_DECIMAL= }, + { S390_FEAT_VECTOR_PACKED_DECIMAL_ENH2, S390_FEAT_VECTOR_PACKED_DECIMA= L_ENH }, + { S390_FEAT_VECTOR_PACKED_DECIMAL_ENH3, S390_FEAT_VECTOR_PACKED_DECIMA= L_ENH2 }, + { S390_FEAT_VECTOR_ENH, S390_FEAT_VECTOR }, + { S390_FEAT_VECTOR_ENH2, S390_FEAT_VECTOR_ENH }, + { S390_FEAT_VECTOR_ENH3, S390_FEAT_VECTOR_ENH2 }, + { S390_FEAT_INSTRUCTION_EXEC_PROT, S390_FEAT_SIDE_EFFECT_ACCESS_ESOP2 = }, + { S390_FEAT_SIDE_EFFECT_ACCESS_ESOP2, S390_FEAT_ESOP }, + { S390_FEAT_CMM_NT, S390_FEAT_CMM }, + { S390_FEAT_GUARDED_STORAGE, S390_FEAT_SIDE_EFFECT_ACCESS_ESOP2 }, + { S390_FEAT_MULTIPLE_EPOCH, S390_FEAT_STORE_CLOCK_FAST }, + { S390_FEAT_MULTIPLE_EPOCH, S390_FEAT_TOD_CLOCK_STEERING }, + { S390_FEAT_SEMAPHORE_ASSIST, S390_FEAT_STFLE_49 }, + { S390_FEAT_KIMD_SHA3_224, S390_FEAT_MSA }, + { S390_FEAT_KIMD_SHA3_256, S390_FEAT_MSA }, + { S390_FEAT_KIMD_SHA3_384, S390_FEAT_MSA }, + { S390_FEAT_KIMD_SHA3_512, S390_FEAT_MSA }, + { S390_FEAT_KIMD_SHAKE_128, S390_FEAT_MSA }, + { S390_FEAT_KIMD_SHAKE_256, S390_FEAT_MSA }, + { S390_FEAT_KLMD_SHA3_224, S390_FEAT_MSA }, + { S390_FEAT_KLMD_SHA3_256, S390_FEAT_MSA }, + { S390_FEAT_KLMD_SHA3_384, S390_FEAT_MSA }, + { S390_FEAT_KLMD_SHA3_512, S390_FEAT_MSA }, + { S390_FEAT_KLMD_SHAKE_128, S390_FEAT_MSA }, + { S390_FEAT_KLMD_SHAKE_256, S390_FEAT_MSA }, + { S390_FEAT_KMAC_HMAC_SHA_224, S390_FEAT_MSA_EXT_3 }, + { S390_FEAT_KMAC_HMAC_SHA_256, S390_FEAT_MSA_EXT_3 }, + { S390_FEAT_KMAC_HMAC_SHA_384, S390_FEAT_MSA_EXT_3 }, + { S390_FEAT_KMAC_HMAC_SHA_512, S390_FEAT_MSA_EXT_3 }, + { S390_FEAT_KMAC_HMAC_ESHA_224, S390_FEAT_MSA_EXT_3 }, + { S390_FEAT_KMAC_HMAC_ESHA_256, S390_FEAT_MSA_EXT_3 }, + { S390_FEAT_KMAC_HMAC_ESHA_384, S390_FEAT_MSA_EXT_3 }, + { S390_FEAT_KMAC_HMAC_ESHA_512, S390_FEAT_MSA_EXT_3 }, + { S390_FEAT_KM_FULL_XTS_AES_128, S390_FEAT_MSA_EXT_4 }, + { S390_FEAT_KM_FULL_XTS_AES_256, S390_FEAT_MSA_EXT_4 }, + { S390_FEAT_KM_FULL_XTS_EAES_128, S390_FEAT_MSA_EXT_4 }, + { S390_FEAT_KM_FULL_XTS_EAES_256, S390_FEAT_MSA_EXT_4 }, + { S390_FEAT_PRNO_TRNG_QRTCR, S390_FEAT_MSA_EXT_5 }, + { S390_FEAT_PRNO_TRNG, S390_FEAT_MSA_EXT_5 }, + { S390_FEAT_SIE_KSS, S390_FEAT_SIE_F2 }, + { S390_FEAT_AP_QUERY_CONFIG_INFO, S390_FEAT_AP }, + { S390_FEAT_AP_FACILITIES_TEST, S390_FEAT_AP }, + { S390_FEAT_PTFF_QSIE, S390_FEAT_MULTIPLE_EPOCH }, + { S390_FEAT_PTFF_QTOUE, S390_FEAT_MULTIPLE_EPOCH }, + { S390_FEAT_PTFF_STOE, S390_FEAT_MULTIPLE_EPOCH }, + { S390_FEAT_PTFF_STOUE, S390_FEAT_MULTIPLE_EPOCH }, + { S390_FEAT_AP_QUEUE_INTERRUPT_CONTROL, S390_FEAT_AP }, + { S390_FEAT_DIAG_318, S390_FEAT_EXTENDED_LENGTH_SCCB }, + { S390_FEAT_CERT_STORE, S390_FEAT_EXTENDED_LENGTH_SCCB }, + { S390_FEAT_SIPL, S390_FEAT_EXTENDED_LENGTH_SCCB }, + { S390_FEAT_SCLAF, S390_FEAT_EXTENDED_LENGTH_SCCB }, + { S390_FEAT_SCLAF, S390_FEAT_SIPL }, + { S390_FEAT_NNPA, S390_FEAT_VECTOR }, + { S390_FEAT_RDP, S390_FEAT_LOCAL_TLB_CLEARING }, + { S390_FEAT_UV_FEAT_AP, S390_FEAT_AP }, + { S390_FEAT_UV_FEAT_AP_INTR, S390_FEAT_UV_FEAT_AP }, + { S390_FEAT_PFCR_QAF, S390_FEAT_CCF_BASE }, + { S390_FEAT_PFCR_CSDST, S390_FEAT_CCF_BASE }, + { S390_FEAT_PFCR_CSDSTG, S390_FEAT_CCF_BASE }, + { S390_FEAT_PFCR_CSTST, S390_FEAT_CCF_BASE }, + { S390_FEAT_PFCR_CSTSTG, S390_FEAT_CCF_BASE }, + { S390_FEAT_INEFF_NC_TX, S390_FEAT_TRANSACTIONAL_EXE }, + { S390_FEAT_PLO_CLO, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_CSO, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_DCSO, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_CSSTO, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_CSDSTO, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_CSTSTO, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_TCS, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_TCSG, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_TCSX, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_TCSO, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_QCS, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_QCSG, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_QCSX, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_QCSO, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_LO, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_DLX, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_DLO, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_TL, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_TLG, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_TLX, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_TLO, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_QL, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_QLG, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_QLX, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_QLO, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_STO, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_DST, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_DSTG, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_DSTX, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_DSTO, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_TST, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_TSTG, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_TSTX, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_TSTO, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_QST, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_QSTG, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_QSTX, S390_FEAT_PLO_EXT }, + { S390_FEAT_PLO_QSTO, S390_FEAT_PLO_EXT }, + { S390_FEAT_SIE_ASTFLEIE2, S390_FEAT_STFLE }, +}; + +const size_t s390_feat_deps_len =3D ARRAY_SIZE(s390_feat_deps); + void s390_get_deprecated_features(S390FeatBitmap features) { static const int feats[] =3D { diff --git a/target/s390x/cpu_features.h b/target/s390x/cpu_features.h index 421978faa40..8097b219599 100644 --- a/target/s390x/cpu_features.h +++ b/target/s390x/cpu_features.h @@ -57,6 +57,10 @@ typedef struct { int bit; /* bit within the feature type area (fixed) */ } S390FeatDef; =20 +/* Tuple of features[][0] that depend on other features[][1] */ +extern const int s390_feat_deps[][2]; +extern const size_t s390_feat_deps_len; + /* use ordinary bitmap operations to work with features */ typedef unsigned long S390FeatBitmap[BITS_TO_LONGS(S390_FEAT_MAX)]; =20 diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c index c41d629d680..c30ea2df175 100644 --- a/target/s390x/cpu_models.c +++ b/target/s390x/cpu_models.c @@ -440,137 +440,14 @@ void s390_cpu_list(void) =20 static void check_consistency(const S390CPUModel *model) { - static int dep[][2] =3D { - { S390_FEAT_IPTE_RANGE, S390_FEAT_DAT_ENH }, - { S390_FEAT_IDTE_SEGMENT, S390_FEAT_DAT_ENH }, - { S390_FEAT_IDTE_REGION, S390_FEAT_DAT_ENH }, - { S390_FEAT_IDTE_REGION, S390_FEAT_IDTE_SEGMENT }, - { S390_FEAT_LOCAL_TLB_CLEARING, S390_FEAT_DAT_ENH}, - { S390_FEAT_LONG_DISPLACEMENT_FAST, S390_FEAT_LONG_DISPLACEMENT }, - { S390_FEAT_DFP_FAST, S390_FEAT_DFP }, - { S390_FEAT_TRANSACTIONAL_EXE, S390_FEAT_STFLE_49 }, - { S390_FEAT_EDAT_2, S390_FEAT_EDAT}, - { S390_FEAT_MSA_EXT_5, S390_FEAT_KIMD_SHA_512 }, - { S390_FEAT_MSA_EXT_5, S390_FEAT_KLMD_SHA_512 }, - { S390_FEAT_MSA_EXT_4, S390_FEAT_MSA_EXT_3 }, - { S390_FEAT_SIE_CMMA, S390_FEAT_CMM }, - { S390_FEAT_SIE_CMMA, S390_FEAT_SIE_GSLS }, - { S390_FEAT_SIE_PFMFI, S390_FEAT_EDAT }, - { S390_FEAT_MSA_EXT_8, S390_FEAT_MSA_EXT_3 }, - { S390_FEAT_MSA_EXT_9, S390_FEAT_MSA_EXT_3 }, - { S390_FEAT_MSA_EXT_9, S390_FEAT_MSA_EXT_4 }, - { S390_FEAT_MULTIPLE_EPOCH, S390_FEAT_TOD_CLOCK_STEERING }, - { S390_FEAT_VECTOR_PACKED_DECIMAL, S390_FEAT_VECTOR }, - { S390_FEAT_VECTOR_PACKED_DECIMAL_ENH, S390_FEAT_VECTOR_PACKED_DEC= IMAL }, - { S390_FEAT_VECTOR_PACKED_DECIMAL_ENH2, S390_FEAT_VECTOR_PACKED_DE= CIMAL_ENH }, - { S390_FEAT_VECTOR_PACKED_DECIMAL_ENH3, S390_FEAT_VECTOR_PACKED_DE= CIMAL_ENH2 }, - { S390_FEAT_VECTOR_ENH, S390_FEAT_VECTOR }, - { S390_FEAT_VECTOR_ENH2, S390_FEAT_VECTOR_ENH }, - { S390_FEAT_VECTOR_ENH3, S390_FEAT_VECTOR_ENH2 }, - { S390_FEAT_INSTRUCTION_EXEC_PROT, S390_FEAT_SIDE_EFFECT_ACCESS_ES= OP2 }, - { S390_FEAT_SIDE_EFFECT_ACCESS_ESOP2, S390_FEAT_ESOP }, - { S390_FEAT_CMM_NT, S390_FEAT_CMM }, - { S390_FEAT_GUARDED_STORAGE, S390_FEAT_SIDE_EFFECT_ACCESS_ESOP2 }, - { S390_FEAT_MULTIPLE_EPOCH, S390_FEAT_STORE_CLOCK_FAST }, - { S390_FEAT_MULTIPLE_EPOCH, S390_FEAT_TOD_CLOCK_STEERING }, - { S390_FEAT_SEMAPHORE_ASSIST, S390_FEAT_STFLE_49 }, - { S390_FEAT_KIMD_SHA3_224, S390_FEAT_MSA }, - { S390_FEAT_KIMD_SHA3_256, S390_FEAT_MSA }, - { S390_FEAT_KIMD_SHA3_384, S390_FEAT_MSA }, - { S390_FEAT_KIMD_SHA3_512, S390_FEAT_MSA }, - { S390_FEAT_KIMD_SHAKE_128, S390_FEAT_MSA }, - { S390_FEAT_KIMD_SHAKE_256, S390_FEAT_MSA }, - { S390_FEAT_KLMD_SHA3_224, S390_FEAT_MSA }, - { S390_FEAT_KLMD_SHA3_256, S390_FEAT_MSA }, - { S390_FEAT_KLMD_SHA3_384, S390_FEAT_MSA }, - { S390_FEAT_KLMD_SHA3_512, S390_FEAT_MSA }, - { S390_FEAT_KLMD_SHAKE_128, S390_FEAT_MSA }, - { S390_FEAT_KLMD_SHAKE_256, S390_FEAT_MSA }, - { S390_FEAT_KMAC_HMAC_SHA_224, S390_FEAT_MSA_EXT_3 }, - { S390_FEAT_KMAC_HMAC_SHA_256, S390_FEAT_MSA_EXT_3 }, - { S390_FEAT_KMAC_HMAC_SHA_384, S390_FEAT_MSA_EXT_3 }, - { S390_FEAT_KMAC_HMAC_SHA_512, S390_FEAT_MSA_EXT_3 }, - { S390_FEAT_KMAC_HMAC_ESHA_224, S390_FEAT_MSA_EXT_3 }, - { S390_FEAT_KMAC_HMAC_ESHA_256, S390_FEAT_MSA_EXT_3 }, - { S390_FEAT_KMAC_HMAC_ESHA_384, S390_FEAT_MSA_EXT_3 }, - { S390_FEAT_KMAC_HMAC_ESHA_512, S390_FEAT_MSA_EXT_3 }, - { S390_FEAT_KM_FULL_XTS_AES_128, S390_FEAT_MSA_EXT_4 }, - { S390_FEAT_KM_FULL_XTS_AES_256, S390_FEAT_MSA_EXT_4 }, - { S390_FEAT_KM_FULL_XTS_EAES_128, S390_FEAT_MSA_EXT_4 }, - { S390_FEAT_KM_FULL_XTS_EAES_256, S390_FEAT_MSA_EXT_4 }, - { S390_FEAT_PRNO_TRNG_QRTCR, S390_FEAT_MSA_EXT_5 }, - { S390_FEAT_PRNO_TRNG, S390_FEAT_MSA_EXT_5 }, - { S390_FEAT_SIE_KSS, S390_FEAT_SIE_F2 }, - { S390_FEAT_AP_QUERY_CONFIG_INFO, S390_FEAT_AP }, - { S390_FEAT_AP_FACILITIES_TEST, S390_FEAT_AP }, - { S390_FEAT_PTFF_QSIE, S390_FEAT_MULTIPLE_EPOCH }, - { S390_FEAT_PTFF_QTOUE, S390_FEAT_MULTIPLE_EPOCH }, - { S390_FEAT_PTFF_STOE, S390_FEAT_MULTIPLE_EPOCH }, - { S390_FEAT_PTFF_STOUE, S390_FEAT_MULTIPLE_EPOCH }, - { S390_FEAT_AP_QUEUE_INTERRUPT_CONTROL, S390_FEAT_AP }, - { S390_FEAT_DIAG_318, S390_FEAT_EXTENDED_LENGTH_SCCB }, - { S390_FEAT_CERT_STORE, S390_FEAT_EXTENDED_LENGTH_SCCB }, - { S390_FEAT_SIPL, S390_FEAT_EXTENDED_LENGTH_SCCB }, - { S390_FEAT_SCLAF, S390_FEAT_EXTENDED_LENGTH_SCCB }, - { S390_FEAT_SCLAF, S390_FEAT_SIPL }, - { S390_FEAT_NNPA, S390_FEAT_VECTOR }, - { S390_FEAT_RDP, S390_FEAT_LOCAL_TLB_CLEARING }, - { S390_FEAT_UV_FEAT_AP, S390_FEAT_AP }, - { S390_FEAT_UV_FEAT_AP_INTR, S390_FEAT_UV_FEAT_AP }, - { S390_FEAT_PFCR_QAF, S390_FEAT_CCF_BASE }, - { S390_FEAT_PFCR_CSDST, S390_FEAT_CCF_BASE }, - { S390_FEAT_PFCR_CSDSTG, S390_FEAT_CCF_BASE }, - { S390_FEAT_PFCR_CSTST, S390_FEAT_CCF_BASE }, - { S390_FEAT_PFCR_CSTSTG, S390_FEAT_CCF_BASE }, - { S390_FEAT_INEFF_NC_TX, S390_FEAT_TRANSACTIONAL_EXE }, - { S390_FEAT_PLO_CLO, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_CSO, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_DCSO, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_CSSTO, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_CSDSTO, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_CSTSTO, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_TCS, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_TCSG, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_TCSX, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_TCSO, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_QCS, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_QCSG, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_QCSX, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_QCSO, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_LO, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_DLX, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_DLO, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_TL, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_TLG, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_TLX, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_TLO, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_QL, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_QLG, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_QLX, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_QLO, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_STO, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_DST, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_DSTG, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_DSTX, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_DSTO, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_TST, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_TSTG, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_TSTX, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_TSTO, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_QST, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_QSTG, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_QSTX, S390_FEAT_PLO_EXT }, - { S390_FEAT_PLO_QSTO, S390_FEAT_PLO_EXT }, - { S390_FEAT_SIE_ASTFLEIE2, S390_FEAT_STFLE }, - }; int i; =20 - for (i =3D 0; i < ARRAY_SIZE(dep); i++) { - if (test_bit(dep[i][0], model->features) && - !test_bit(dep[i][1], model->features)) { + for (i =3D 0; i < s390_feat_deps_len; i++) { + if (test_bit(s390_feat_deps[i][0], model->features) && + !test_bit(s390_feat_deps[i][1], model->features)) { warn_report("\'%s\' requires \'%s\'.", - s390_feat_def(dep[i][0])->name, - s390_feat_def(dep[i][1])->name); + s390_feat_def(s390_feat_deps[i][0])->name, + s390_feat_def(s390_feat_deps[i][1])->name); } } } --=20 2.55.0 From nobody Thu Oct 22 19:22:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1791572398; cv=none; d=zohomail.com; s=zohoarc; b=nVHc8biRVp7yzSztyZgeeyekjtxgy2W33YD93M8XuBGBO5rq8g804Xm4Zby72KENI4MRtWR00X1AAIDDk/S3vivpLg3nQKFouYJGFXqThRtbEI0WOyNIAA3JCRaJAZlAsDuCuVgVHVhgagtoxyDllor7YWt6XJaGWss3dMCZfoU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1791572398; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XTgachXJghq3xU0So1EXy42s8xYtRBFJ+MwRqwFqImI=; b=nO1y0k8sEhrzuEyozrnQLb/hmHJ2QpQwGwz4iPUbUHodqjS8N2UCGNaq16pBunJA1VAT5Twvn14Ey2dQHRHiPaBgCTCI6Ag8+f96VLwMBMqB8TRBTaKTUmPi3o45bMyZuV4/mtLd5dPZ73+cSVgEzFuF8n11XIb0niUq0owZJp0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1791572398446992.6345302656401; Fri, 9 Oct 2026 11:59:58 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xFFoB-0002qg-PD; Fri, 09 Oct 2026 14:59:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xFFnq-0002of-Au; Fri, 09 Oct 2026 14:58:46 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xFFno-0004aZ-Eq; Fri, 09 Oct 2026 14:58:45 -0400 Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 699Ha3oq3714668; Fri, 9 Oct 2026 18:58:40 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4h74terces-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 09 Oct 2026 18:58:40 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.11/8.18.1.11) with ESMTP id 699H8FpW1206662; Fri, 9 Oct 2026 18:58:39 GMT Received: from smtprelay02.wdc07v.mail.ibm.com ([172.16.1.69]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4h6hsnmbeh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 09 Oct 2026 18:58:39 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (smtpav06.dal12v.mail.ibm.com [10.241.53.105]) by smtprelay02.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 699IwcAL20644524 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 9 Oct 2026 18:58:38 GMT Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ED5DC58043; Fri, 9 Oct 2026 18:58:37 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4EAD05805E; Fri, 9 Oct 2026 18:58:37 +0000 (GMT) Received: from li-d664314c-3171-11b2-a85c-fa8047ef35bd.ibm.com.com (unknown [9.67.47.107]) by smtpav06.dal12v.mail.ibm.com (Postfix) with ESMTP; Fri, 9 Oct 2026 18:58:37 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=XTgachXJghq3xU0So 1EXy42s8xYtRBFJ+MwRqwFqImI=; b=Yo7ye//YYmfGuAtdflmitB9QdjkrQfRqP KYvaa6JCXZa6RkgqLuRBiaLWIKsgqyf0qKRItyUIdBK5U1FzKjg28cetd5j4CLCA adaSFxPBNhKuHqeBRd+URl/mv92y3bM4nXIErXb81U82/vQdw+h1yZQDw5kxUPLK yZpM3Vntk2w1PY1ycYqHspI7tZhoLTFuKBrNfRhikHzVgOhZH0mkZgzKT7Krke4j zC+hr1gMV/9O2JysrV269lZPVkkJhTHcOyuhNMr1p/kwt/GJwNTPnuYImXBQ09P2 ZNd1aeVbohXPumyRqgRWXpBu5JiR8vpcrEO/Crmg+foGvrOTK5Jtw== From: Collin Walling To: qemu-devel@nongnu.org, qemu-s390x@nongnu.org Cc: Hendrik Brueckner , David Hildenbrand , Richard Henderson , Ilya Leoshkevich , Cornelia Huck , Eric Farman , Matthew Rosato , qemu-stable@nongnu.org Subject: [PATCH v2 2/2] target/s390x: mark feats dependent on deprecated feats as deprecated Date: Fri, 9 Oct 2026 14:55:59 -0400 Message-ID: <20261009185559.144750-3-walling@linux.ibm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261009185559.144750-1-walling@linux.ibm.com> References: <20261009185559.144750-1-walling@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: gSaCyZmuYla3klXgEQqZccAIVmaFJjAT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDA5MDA3NCBTYWx0ZWRfX9jT07htpEnhw bQ1rl7FmTYbNq5RHercILTfM+g+86Noan1SpnjqBgD1VFIvQGJlnxOJTlSAsYQa1IWZwUkhpw2j G3CzuT2c+r8GQpOvRN63Mx+ejcVGRy6zdSCbyCfjx++zjgbxAAMtgH5YBk/YRnKzwj6weRE5Z5B Y+/jGsOR5dzmO6wJ7tV+tvMTtoJQbv5+qFwVgPPD+7K3/k0fEjGHazYIzjME3niTJIx8ULwkgNN KWqAORsrwpLDiuCPU6RKe8uPYIvrj/euV6Pxpcw++PVZKP5dCjSpRzEylaOCFlRmkf53DJylgxn 5A72w90u16ARIPkbRq1VA2y/J6BvgAcOjhSQ3tNJi+i7FWD0qJD9fbwSmIsKMM9q6UV7J2UVAdn ycoPE3S8z1OJirR9AcZdoS18HDh0mgWeeBGnErBxUXMZNlv19MM6KP6GDEu+NECDu0Qpz2P0qBs /aqfHJbksDlHNLzEbGQ== X-Proofpoint-GUID: gSaCyZmuYla3klXgEQqZccAIVmaFJjAT X-Proofpoint-Spam-Info: AW1haW4tMjYxMDA5MDA3NCBTYWx0ZWRfX4BPbPmpWqBto FYEN0O1dUYKsoSYXndhgZnlHvZhbKs9mFvSv7AA5k8IbErsR+7dFY9J8FXkhG7X0oX+HiNdSt8C /xbPlYdWoNi2E6ZO5HYucL1mR+HmqLk= X-Authority-Analysis: v=2.4 cv=Nf1zRGD4 c=1 sm=1 tr=0 ts=6ac93960 cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=660iZSQnnn4A:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=VnNF1IyMAAAA:8 a=YJGIzY42qjv8PvxFfY0A:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-09_05,2026-10-09_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 priorityscore=1501 clxscore=1011 malwarescore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 suspectscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610080000 definitions=main-2610090074 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=148.163.158.5; envelope-from=walling@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1791572400141158500 Content-Type: text/plain; charset="utf-8" There are certain CPU model features that depend on other features that are flagged for deprecation. For example `ineff_nc_tx` depends on the `te` deprecated feature. If a user defines a VM with the current list of deprecated features disabled, the following warning occurs: warning: 'ineff_nc_tx' requires 'te' To alleviate this, add these "dependent features" to the deprecated features list. This allows the user to see *all* features that should be disabled to ensure a successful migration to a host system that may not support certain deprecated features. Fixes: 6e55b32d45 ("target/s390x: flag te and cte as deprecated") Signed-off-by: Collin Walling Reviewed-by: Hendrik Brueckner Reviewed-by: Eric Farman Reviewed-by: Matthew Rosato Tested-by: Eric Farman --- target/s390x/cpu_features.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/target/s390x/cpu_features.c b/target/s390x/cpu_features.c index 20f9947c7be..babee7f5bac 100644 --- a/target/s390x/cpu_features.c +++ b/target/s390x/cpu_features.c @@ -360,10 +360,23 @@ void s390_get_deprecated_features(S390FeatBitmap feat= ures) S390_FEAT_TRANSACTIONAL_EXE }; int i; + bool restart; =20 for (i =3D 0; i < ARRAY_SIZE(feats); i++) { set_bit(feats[i], features); } + + /* Mark features that depend on any deprecated feature */ + do { + restart =3D false; + for (i =3D 0; i < s390_feat_deps_len; i++) { + if (test_bit(s390_feat_deps[i][1], features) && + !test_and_set_bit(s390_feat_deps[i][0], features)) { + /* Restart in case set features have other dependencies */ + restart =3D true; + } + } + } while (restart); } =20 #define FEAT_GROUP_INIT(_name, _group, _desc) \ --=20 2.55.0