From nobody Sat Oct 24 00:33:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1790826303; cv=none; d=zohomail.com; s=zohoarc; b=FLvJrbZDiZpUOp7+hbzBJgAN2eweqiuKbfy4d6wnkCJaTbxwCTCJItvwcFxy8vlJLHCGf5P3qh88XudSpeIQRF/hFed64FqfM9ON3h6KMSD/aBzhZ7yto/0Ny40jKlDF9n3R3fXveEUdBmyLgw450cVNtmwwiWY7Osg0TSzGGmg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1790826303; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=BhUe709SE/yREJSv4luWIhgYYagp305FisiQ5h0HuUs=; b=lHWLssuqlXu9CZDS/2lK3Td4WD4x2WJXg05VQIa+fZeT3+KfEFi8Il9On7NyKbIBsVfaw8J+a7D1BonH92F6MDldlqs2PiplINlU5gQDW9BUBTP3mGjiHqi27H07qCgWHwvt77fon3y2zXyvWaPfxySzjWdgHE5iFMf26eTYJ1Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1790826303718507.79807129848325; Wed, 30 Sep 2026 20:45:03 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xC7i8-0001pG-Mt; Wed, 30 Sep 2026 23:43:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xC6S2-00063E-QT for qemu-devel@nongnu.org; Wed, 30 Sep 2026 22:23:14 -0400 Received: from mail-pj2-x0f.google.com ([2607:f8b0:4864:39::f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1xC6S0-0002Py-3V for qemu-devel@nongnu.org; Wed, 30 Sep 2026 22:23:14 -0400 Received: by mail-pj2-x0f.google.com with SMTP id d9443c01a7336-2d90ba1d807so47025305ad.3 for ; Wed, 30 Sep 2026 19:23:11 -0700 (PDT) Received: from dt-VM.localdomain ([175.152.37.254]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e300b8fd4csm3943635ad.80.2026.09.30.19.23.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2026 19:23:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790821391; x=1791426191; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BhUe709SE/yREJSv4luWIhgYYagp305FisiQ5h0HuUs=; b=SmMQShdo9V23ihXKv08wvg8u6X7gY6UYaOUJUTYNZpfnffiNOb31gf44fpvO8tn7gW K1xMid2Dc71tr0K3MIK9IhQAvK0cwkghgo0fSCgnNLYGd1Bdb1zwjGHgtxQaUcviKys3 1bvu7wPjZtqGWtId2u8LChURxsPDRYhrdee6D/5YgXGBckatVZkw7w1tCAD48CxhOjPd IniCuZ3txltWlGAb7uSRpAPj9YEtMVeC+qK8wdPgq1VsQkZxdPIs2lICVce6DrRiZHyN 7jL8bPYzoUfqvkLdh2VO3f1pOl4dBrkMkSXAD0n9YI2iOA+EKGJY5dEH0NLAeYrR+24q jKQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790821391; x=1791426191; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=BhUe709SE/yREJSv4luWIhgYYagp305FisiQ5h0HuUs=; b=CixdWJRO/cJVmPZ97J1eE7O4RlN3OOF+5cdsn/cuAW5ZLHeGhD7Uz+Ju8jgoXmkmtQ keXRdu0Fgb5U3OuagifzJitQBt1hU4KS6scbxpZopksaQZxrufjFzPKSnKO9GWMkswNV Iuvckgq/ZfEnCX7xc55h/aqY6J3lnI1ijboSxVOjjsadjzPcRBvz65gRaglmd7Cf9caP 3yjUcvGiqfe7UImw4NedfHRFcnj/AWP+MdzkK0Xl6nSPbq9+u0SojvQGSieuadsK1lFX SKjGBfeE8TY5QpNLlheyW/0d9Okpdw0TR4of/VlOBu/VeQkd7D6T2r/jwhXCqmAnZWdE NhRQ== X-Gm-Message-State: AFq9FYLcbcLVt0MF5A/s2LycTIqGstjpfMX3mHJh94yE8AlUelb64y6g nV/BKLmHbVwfiuB4NCs9+F0yTfU41+rqVh8YzS1Y81NfqlqFGL613tr0oODhd5nKjuI= X-Gm-Gg: AYBFou2e2i9NGvEnJAl3MmCvMBeou4rHmfEi7zsAJ5wV/Z5cGqkqg9mBOXznqf2GJKC XS7ko2Rg0QUlelcpAIfRd1DwRhp+m5jz6ma6tCvFK6hgX7f2muFXz/jzDbN9swyDXRksh3Y9VmQ oPG4z82Glema02gifWqmqx6W5Cr/YC6TsEw5hkfVQsYcvmzcBup7xLDelhyka8P+uLAzI/yM8oW ABQzr+K6Uo2fNznZ2iFKsNfdnWx+l1Bgcg6q43jkm2hW+LoK2YET/Q7q7p8MCTzjA7NzHG8lb+b Z6jjrwYN0HWCbUDKLa26EeI+966FvWz9GzcHp28QXD+EPHLtW3CfeVIdWSTmUxa/e5AsZ2uZJng EOSmhTU67OC5XGH8wpCal15HSBMb3kRc/JrDtFWND5IolClB9uzQjJt3kcBndkZiBIoSNi5twmu 7IgQmqWLeaD1LM1tS3raEvogiQc6IhDAXHjcAPHgTqrFlCr4XkFj8cLQ4K1pX/IV0LsZQIKZecr XG/3JHupfjcm+EqOA+kpUvoDQ4= X-Received: by 2002:a17:903:2283:b0:2dd:c100:a5de with SMTP id d9443c01a7336-2e2e4b9ea03mr26256215ad.50.1790821390656; Wed, 30 Sep 2026 19:23:10 -0700 (PDT) From: Tao Ding X-Google-Original-From: Tao Ding To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, chao.liu@processmission.com, farosas@suse.de, lvivier@redhat.com, pbonzini@redhat.com, Tao Ding , Alistair Francis Subject: [PATCH 1/3] hw/misc: fix k230_decomp_gzip integer handling issues Date: Thu, 1 Oct 2026 10:22:21 +0800 Message-ID: <20261001022223.8633-2-dingtao0430@163.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261001022223.8633-1-dingtao0430@163.com> References: <20261001022223.8633-1-dingtao0430@163.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:39::f; envelope-from=dingtaodtdt@gmail.com; helo=mail-pj2-x0f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 30 Sep 2026 23:43:53 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1790826306587158500 Content-Type: text/plain; charset="utf-8" Use hwaddr for address calculations to avoid 32-bit overflow and address truncation. Resolves: Coverity CID 1685515, 1685517 Reported-by: Alistair Francis Signed-off-by: Tao Ding --- hw/misc/k230_decomp_gzip.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/misc/k230_decomp_gzip.c b/hw/misc/k230_decomp_gzip.c index 0d8a3b2d2e..54303c0e7f 100644 --- a/hw/misc/k230_decomp_gzip.c +++ b/hw/misc/k230_decomp_gzip.c @@ -53,13 +53,13 @@ static bool k230_decomp_gzip_write_mem(K230DecompGzipSt= ate *s, hwaddr addr, static hwaddr k230_decomp_gzip_output_addr(K230DecompGzipState *s) { return K230_DECOMP_GZIP_SRAM_OUT_BASE + - s->output.slot * K230_DECOMP_GZIP_BLOCK_SIZE + + (hwaddr) s->output.slot * K230_DECOMP_GZIP_BLOCK_SIZE + s->output.current_offset; } =20 static hwaddr k230_decomp_gzip_input_addr(K230DecompGzipState *s) { - return s->input.slot * K230_DECOMP_GZIP_BLOCK_SIZE + + return (hwaddr) s->input.slot * K230_DECOMP_GZIP_BLOCK_SIZE + K230_DECOMP_GZIP_SRAM_IN_BASE; } =20 @@ -102,7 +102,7 @@ static void k230_decomp_gzip_finish(K230DecompGzipState= *s, bool crc_ok) } =20 static bool k230_decomp_gzip_load_input(K230DecompGzipState *s, - uint32_t addr, uint32_t size) + hwaddr addr, uint32_t size) { s->input.current_offset =3D 0; =20 --=20 2.43.0 From nobody Sat Oct 24 00:33:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1790826306; cv=none; d=zohomail.com; s=zohoarc; b=QHA1EUswlaukviRQDOQn45x0ug3/2TyCXiLVR7ERfLE6PZ8ZCahgONSv/lCUuYIEm/GDk4G3VtIhC3/3AJOSnmFgvskQB29pteWU9IMcnHjDxEkOrm/NhXCcJ6mQugy/Oi/R0nk9x7c0708wwIahA0RjS8xAxDPgT5rHZ2LNE7Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1790826306; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=TIs43LA5OkZmPBJSryEHekZ6UeGCUX1x7+EpWHMxO8Y=; b=f8Xo/fHCdO649l/SiuZAg2fdH+hFv67RvUSICTylZXMvN97HDEVXWVWBS7ciW6ntBb7lfvgKTUhIt+9lML5aQ2tVkgFpJqh1Kvab7ExQmNRAZR+pxC+QEz/Gyn6qVTBvRo91Pb6AcVIQ4G2EA7GCpKn8m1NL5N8LAKK2o2qw4ts= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1790826306075962.0990997663022; Wed, 30 Sep 2026 20:45:06 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xC7i7-0001ow-P7; Wed, 30 Sep 2026 23:43:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xC6S5-00063t-D1 for qemu-devel@nongnu.org; Wed, 30 Sep 2026 22:23:17 -0400 Received: from mail-pj2-x2b.google.com ([2607:f8b0:4864:39::2b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1xC6S3-0002QN-9n for qemu-devel@nongnu.org; Wed, 30 Sep 2026 22:23:16 -0400 Received: by mail-pj2-x2b.google.com with SMTP id d9443c01a7336-2e2d2bbcab2so9326525ad.2 for ; Wed, 30 Sep 2026 19:23:14 -0700 (PDT) Received: from dt-VM.localdomain ([175.152.37.254]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e300b8fd4csm3943635ad.80.2026.09.30.19.23.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2026 19:23:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790821394; x=1791426194; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TIs43LA5OkZmPBJSryEHekZ6UeGCUX1x7+EpWHMxO8Y=; b=i190B1yLD2jhR2kEwgJFcfjEaXjRDI1CQmojMwYdBEMGVwJrHuZemJ86jxGVH1fC9L TS0BLulBazn/vkk+Tm3/hSXg6J6swtNQI1KUXXB9oBFKIIKuflCAkECEI0VFfXCpmFQC GImCryHCi/2kft2IIVQwzNLk3P0iW0IECjfNTSQrAwWdYp9RdOkfXZHAI7k1u3qwS2yb GSKwNiF0nkmmbHdYeqzbtqANhnKgqZebSiQiTFKINSwYl6CFsqdyrxCh7VHDmvatGMYd HVAMk+v++DNhePGlpgm9ajpDNRQds9oggRSYRrzOYY+zNHhc7H40dyY+BUprsNJm1SMJ Zu8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790821394; x=1791426194; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=TIs43LA5OkZmPBJSryEHekZ6UeGCUX1x7+EpWHMxO8Y=; b=tKybNo72ZQ/ciwGtLNyXVcf8gPQ4i9LLBFaTDlHEs1I4+7ZS6Erp2VGSFfTZTuTx9Q UumCVXmQvgZzvkiZJ1cQ8Se6ZeatKuLdlH72Z3+YuiIwrEed0rM2DqjpaLEdcy3+Fgsi zWVHNfdwi4B0zmRZUwJJXSvuc5qhegMz5ABFC6Af75dVLF+duwpXdpG38qbtvSQmZJRQ HQ/rpGa41X7NdyvmYly2W+e4zWf5Slmh9+8DKDGZgZlvqj9BlO3CVZAbJw6uEWK2KHIl To/YgEeIR99GzHg6/vFSjsqRPFjxcB/2EQcu29uGjRNZWjSHlKuHbmyWEujZ0jh2WK9K 13yw== X-Gm-Message-State: AFq9FYLGHdb9VrTuoOfGqyYav0vDnaWx4tQb4d8Lm1SZO5sTXJK+zwmQ wbd3lpxoL1RPe2rHA6plRYEe4ZN5VRAWOVsEf27ONIu3d7qbv3HpLcCGjKtCgbmqb4Y= X-Gm-Gg: AYBFou1oTQ9Vu1OI0UhHLf6sDRmEIvr6NaxNL0alz3xhuIujQFSfmRbWW8sQ6DdpI9G jDpiQl8fuWkCHZnZQGBQgl0lTV13MUMjEl714lJdktCor+8nbQKWMuQWimOI0xDd7i55D7bQdgR FZEQoCUjHh4an8q5k8/ckoxMahKzdHaWSUfgygAhA9JvSxbggxGPafKRwO5NjzdNM6elcDinm72 TJkWQVwRldUww0ox8dykQhmQb8q+oykJd1FPV3b3j2DV8Ehks2xkOMLGebLPtLUesweFPyEMAfU VCuTKcx3uR+nsDVdUXgxm89xFU12Mi+AndqYuU9fGQ0Hkdgj8F2kF2quqGUFrUgI+ZWOIe2rr7o zTSZeRekUB2m9augEu4kuwyCKMO8yXBJ74lPqY2yTL8j0ocGnJ1uZZvqI5IHvcOZf8XVezp4Gnb CWyAOwrNKB6rkiUphXjJiFm3Twsq4DQiv8tzsO4z8/Ej0lPhzPt9sxzciKg4/iyZjLe3tCg5QhN eOWQ3837Un18vQp X-Received: by 2002:a17:903:32c3:b0:2df:8a60:67f7 with SMTP id d9443c01a7336-2e2e4b5c568mr24910375ad.12.1790821393888; Wed, 30 Sep 2026 19:23:13 -0700 (PDT) From: Tao Ding X-Google-Original-From: Tao Ding To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, chao.liu@processmission.com, farosas@suse.de, lvivier@redhat.com, pbonzini@redhat.com, Tao Ding , Alistair Francis Subject: [PATCH 2/3] qtest: fix k230_decomp_gzip test integer handling issues Date: Thu, 1 Oct 2026 10:22:22 +0800 Message-ID: <20261001022223.8633-3-dingtao0430@163.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261001022223.8633-1-dingtao0430@163.com> References: <20261001022223.8633-1-dingtao0430@163.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:39::2b; envelope-from=dingtaodtdt@gmail.com; helo=mail-pj2-x2b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 30 Sep 2026 23:43:53 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1790826307392158500 Content-Type: text/plain; charset="utf-8" Cast slot to hwaddr before multiplication to prevent 32-bit overflow when=20 calculating the SRAM input address.=20 Resolves: Coverity CID 1685514 Reported-by: Alistair Francis Signed-off-by: Tao Ding --- tests/qtest/k230-decomp-gzip-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/k230-decomp-gzip-test.c b/tests/qtest/k230-decomp-= gzip-test.c index e80113fd28..249c8ae82c 100644 --- a/tests/qtest/k230-decomp-gzip-test.c +++ b/tests/qtest/k230-decomp-gzip-test.c @@ -46,7 +46,7 @@ static inline hwaddr k230_sram_addr(hwaddr off) static inline hwaddr k230_sram_input_addr(unsigned int slot) { return k230_sram_addr(K230_DECOMP_GZIP_SRAM_IN_BASE + - slot * K230_DECOMP_GZIP_BLOCK_SIZE); + (hwaddr) slot * K230_DECOMP_GZIP_BLOCK_SIZE); } =20 /* --=20 2.43.0 From nobody Sat Oct 24 00:33:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1790826304; cv=none; d=zohomail.com; s=zohoarc; b=JD9UxXYHT75gyhZt9YmItRn5rpPx2cpCi5j7YyoAPREULmx2LHD3SqV1GFsMKLTIu6y61Yn7OBimdTlEzBm/573FriXcD1zZuwqCZn9JqeBwBrbZkbt6lNPQAR7hDG6MntsgJQVPBpUAaY1T534CkDNxbZ89Wf47A+RmAFiYYwU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1790826304; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=rKmdNyUIBVdIPme0GHxqMjMQ/2Bke/GwQXMJS1f1SKg=; b=ZeNaaPq9CbMNElzwj90DFRBtVC+MpbVG8GLrYfbn15fjVlEuMetnsLIxzwPMhnfKS0W1JM9swz7Vbg9kyidMVWxd18+TRPYKKEhOzn1dQPpS6ur/BLCnEXMzm0HimQyr6chuey7n8jkG6bMOWaNX+RyuAGjFM5wK1FxCFsBWNSo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1790826304098104.52367946451761; Wed, 30 Sep 2026 20:45:04 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xC7iC-0001pf-Bl; Wed, 30 Sep 2026 23:44:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xC6S8-000652-W3 for qemu-devel@nongnu.org; Wed, 30 Sep 2026 22:23:21 -0400 Received: from mail-pj1-x102c.google.com ([2607:f8b0:4864:20::102c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1xC6S7-0002Qu-7u for qemu-devel@nongnu.org; Wed, 30 Sep 2026 22:23:20 -0400 Received: by mail-pj1-x102c.google.com with SMTP id 98e67ed59e1d1-3a02551822eso189571a91.1 for ; Wed, 30 Sep 2026 19:23:18 -0700 (PDT) Received: from dt-VM.localdomain ([175.152.37.254]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e300b8fd4csm3943635ad.80.2026.09.30.19.23.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2026 19:23:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790821397; x=1791426197; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rKmdNyUIBVdIPme0GHxqMjMQ/2Bke/GwQXMJS1f1SKg=; b=BmEUPzXQrugFIpSH9b0b9F7F/W3qpazdBP7RyqtiEgRXUws8Ks0MmjwledsxwlUoUD 4DSRENscP+Dc9iORuitiXZJ160BDfnPbpxb/M64ZP9RJtfISMgP8EvY0gj8hVLM5EAX5 F40tlkggbi1maUNkhhFMn4WFih5ueeZE80cUN9Ls2lAxanJZ3g1orqbxB9EZHgJdPrhs TV+UUejZgAxqzDuVeG0K/QCn17qCr2/bHpBWv1ZUXPQkJWvByV5f6YPUkNUxHgm3jUCP NWhut3HT8Px/bK3j4evvDeI2zVe9ErhKv3d3sw+bDaHW81SYHYjq+1SGxSlTKHakgBOg NwgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790821397; x=1791426197; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=rKmdNyUIBVdIPme0GHxqMjMQ/2Bke/GwQXMJS1f1SKg=; b=OLNVnsHCm63I7jYB8S0M1Dw0fGPyMBirXKNKewMchD+v/5QoGIX/INNO/VE72ScqD0 cMby08DX+Y12XlUYyKsysip3wL+Jix68Y3O9aJOWt6q3UQt8Emsa6N4LZB+W20GEAi7o fxqgbc0RG1ECQCpc4a1Hm46Oxr92qrXO8cAGwBvN9dyalEqXjA9jrZJmgphJcpuCr2lg cGB3sat/5VaAzVETz+LDabJIan0Qwp/DzYQUpE3AKiEXe4A/uc8wkorDEgCrzpc3ORTj mBDSLA1gysB8F3FoCeGrv5ugXZOFPQ54w0TXXg42upzJnpAlSqvrFK31ijP2UGMkVLAb s4fQ== X-Gm-Message-State: AFq9FYLYu4LLnh84Cb8mQsafaEeqpFbLf0g0/RqkcqR4IobyOrSSsBjv ntOxGiqk1DHXpYYfQpPvyFvcBhrR0E5dmJPxTrbJWYLuZW2tDP75hEzc9bPyJz7inVM= X-Gm-Gg: AYBFou1sUdiEgrs7/XjF7603m1q6d/9gSeAqqpT9iTIoJ7ovOpviJ3kBZxQtUIZHVxM kSaY9UaBW/DNxuFuXoRFbgPHpx1v8oC+xtvYKGrrAtQc42YOSFTBnKWDgBItkd2PIfQtJ9UlhP0 TuLVKeNWiN6vctRsoN5ZoJP7aRCOckXphDjfqviRXCCyJDFmcciOTg0VG7qQ+eqPJiGVDLgrYhN p8TX0qzorvi3l5CZ5XSfA8LdZONCXs2vGWrHkTVXSiA97zNJcBans1dN9QVF5kwMPunYcaqxQgh dU4MdwNQPNdOUB/eLsLA3i5WAngosCQqOYlRoEi8o/eVh4KH51T7qwe8RoVcz3PvquQfpidYvhh KQw2ZXnVNa1MHAxKSAvaclDS8gjKnfasMLU3BtT3yQkqkjHWLPJ2HPSbL/ZDokz/WYO6IyEcJVZ 6JDo+Bvm60E61HLiSDj6lvWsg3eAw752cjq44Y8ninLSKaq8cA+EtCUtVVNzb7csErCcsPukdyy LO11HbofbipmZ3j X-Received: by 2002:a17:90b:3c47:b0:39e:4c97:ce09 with SMTP id 98e67ed59e1d1-3a4f3b9821amr925227a91.42.1790821397245; Wed, 30 Sep 2026 19:23:17 -0700 (PDT) From: Tao Ding X-Google-Original-From: Tao Ding To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, chao.liu@processmission.com, farosas@suse.de, lvivier@redhat.com, pbonzini@redhat.com, Tao Ding , Alistair Francis Subject: [PATCH 3/3] hw/dma: fix k230_gsdma integer handling issues Date: Thu, 1 Oct 2026 10:22:23 +0800 Message-ID: <20261001022223.8633-4-dingtao0430@163.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261001022223.8633-1-dingtao0430@163.com> References: <20261001022223.8633-1-dingtao0430@163.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102c; envelope-from=dingtaodtdt@gmail.com; helo=mail-pj1-x102c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 30 Sep 2026 23:43:53 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1790826306591158500 Content-Type: text/plain; charset="utf-8" Validate the address before subtracting the channel base and use hwaddr=20 for channel calculations to prevent unsigned underflow and truncation. Resolves: Coverity CID 1685516 Reported-by: Alistair Francis Signed-off-by: Tao Ding --- hw/dma/k230_gsdma.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/dma/k230_gsdma.c b/hw/dma/k230_gsdma.c index 7635cd19e8..e9a7877e54 100644 --- a/hw/dma/k230_gsdma.c +++ b/hw/dma/k230_gsdma.c @@ -300,7 +300,7 @@ static const VMStateDescription vmstate_k230_gsdma =3D { static uint64_t k230_gsdma_read(void *opaque, hwaddr addr, unsigned int si= ze) { K230GSDMAState *s =3D K230_GSDMA(opaque); - unsigned int ch; + hwaddr ch; hwaddr ch_off; uint64_t ret =3D 0; =20 @@ -329,6 +329,9 @@ static uint64_t k230_gsdma_read(void *opaque, hwaddr ad= dr, unsigned int size) break; } =20 + if (addr < K230_GSDMA_CH_BASE) { + goto out; + } ch =3D (addr - K230_GSDMA_CH_BASE) / K230_GSDMA_CH_STRIDE; ch_off =3D (addr - K230_GSDMA_CH_BASE) % K230_GSDMA_CH_STRIDE; if (ch < K230_GSDMA_NUM_SDMA_CHANNELS) { @@ -355,6 +358,7 @@ static uint64_t k230_gsdma_read(void *opaque, hwaddr ad= dr, unsigned int size) } } =20 +out: trace_k230_gsdma_read(addr, size, ret); return ret; } --=20 2.43.0