From nobody Sat Sep 26 19:13:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=tachyum.com ARC-Seal: i=1; a=rsa-sha256; t=1790278356; cv=none; d=zohomail.com; s=zohoarc; b=U8eQI8wC9peeuj3b0QS/VKJ29Vx9Yin9QNAl4pgnsd3CGxr9cQdAcd7GpnrKPZGRCgTy27UFEQen1zBsG3m/mgvtfUa/f0mlogvCwTyAbsWmTS7KBdN9R0iYxzd9YdoGVq2+31U0m6F+fzTXTRPjpZkX+oJQqsPvh4/58dCFRiM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1790278356; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1Nt/0FljGm5mDWhohruSEr958TFWudjl79VZnSSYC2Q=; b=EW2udsTbrEmKq1zA1PdvRFmoNzTeR65+fzc1CrOAqO3gAeGHbZO0Qnm78npI/GTLjYn457MbacMoTfHD+7m69FNhZU8HbIDwmv1IFTGpKfI53PZgeWLr9HVTq+zweVjruCRpP3E7XB475uxgxTLkl4MdNbZJZFZzoIeRiE/HiFo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1790278356005511.9600053729415; Thu, 24 Sep 2026 12:32:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x9pAj-00010t-1c; Thu, 24 Sep 2026 15:31:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x9pAh-00010k-9e for qemu-devel@nongnu.org; Thu, 24 Sep 2026 15:31:55 -0400 Received: from mxa.tachyum.com ([66.160.133.173]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x9pAf-0006m4-Ou for qemu-devel@nongnu.org; Thu, 24 Sep 2026 15:31:55 -0400 Received: from mxa.tachyum.com (localhost.localdomain [127.0.0.1]) by mxa.tachyum.com (Proxmox) with ESMTP id 2D5D61E267D; Thu, 24 Sep 2026 12:31:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tachyum.com; h= cc:cc:content-transfer-encoding:date:from:from:message-id :mime-version:reply-to:subject:subject:to:to; s=dkim; bh=1Nt/0Fl jGm5mDWhohruSEr958TFWudjl79VZnSSYC2Q=; b=dcNy3kJFS0lvrwl7O/zUmtk woaexS5UXsJSsk3TuvS/z4yK0ybSoDOZdILr3/YYX7q5Dm2HcTiwg7GSJBp7j+fa tmgVKE/M3iyzVYMBULW7T7dn8GJ1yOve3bR3yMkbjvOPr2CV5MfCVyWVg00WrTHR 6aZjFKi/4ZQy8HDhg42qMpMo4G6X3uCgm2tuTHgQTxVy4z685qelhXPftSebvc/x u85BtIKJR4vItflvwss4BNFEoFoFUMv5lVt2hpmy/QO2yzGqkLQh9V9KedSQpzzY 24CpJtbw3zxYNaY2TFqfumgPQG6tmwFsd1jedwk8rH0XcSET8vGXivTp7edS2jw= = From: Michael Morrell To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Helge Deller , Laurent Vivier , Igor Shevlyakov Subject: [PATCH] linux-user: report EINVAL for a misaligned mincore() start Date: Thu, 24 Sep 2026 12:31:43 -0700 Message-ID: <20260924193143.2062533-1-mmorrell@tachyum.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=66.160.133.173; envelope-from=mmorrell@tachyum.com; helo=mxa.tachyum.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @tachyum.com) X-ZM-MESSAGEID: 1790278359966158500 Content-Type: text/plain; charset="utf-8" From: Igor Shevlyakov mincore(2) rejects a misaligned start address before it looks the range up, so a start that is both misaligned and unmapped is EINVAL. Here lock_user() runs first and fails, and the call reports ENOMEM instead. When the range is mapped this changes nothing -- the host syscall receives the misaligned pointer and answers EINVAL by itself -- which is why only the unmapped case is visibly wrong. Caught by glibc's misc/test-errno-linux. Signed-off-by: Igor Shevlyakov Reviewed-by: Helge Deller --- linux-user/syscall.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 9f454502cb..a878feedf2 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -13051,7 +13051,17 @@ static abi_long do_syscall1(CPUArchState *cpu_env,= int num, abi_long arg1, #ifdef TARGET_NR_mincore case TARGET_NR_mincore: { - void *a =3D lock_user(VERIFY_NONE, arg1, arg2, 0); + void *a; + + /* + * The kernel rejects a misaligned start before it looks the r= ange + * up, so a start that is both misaligned and unmapped is EINV= AL, + * not the ENOMEM that a failing lock_user() would report. + */ + if (arg1 & ~TARGET_PAGE_MASK) { + return -TARGET_EINVAL; + } + a =3D lock_user(VERIFY_NONE, arg1, arg2, 0); if (!a) { return -TARGET_ENOMEM; } --=20 2.43.0