From nobody Sat Sep 26 20:50:28 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linux.alibaba.com ARC-Seal: i=1; a=rsa-sha256; t=1789725507; cv=none; d=zohomail.com; s=zohoarc; b=Q9qHvWIYm3BWaxLoXqI18p1CexfYfWf+V6Q1Oqor5uKWUH3A5HIgYKppjF7b978RMarB0lWrtlaF4ZGwaCSS04KXMp2PszRPDYBU2iVPv9n2QAxqN8MlmyuQP898bKqFT4mjH6Y4PwJQTOh4lfY8Nrhm9sTTss9jpvb5+Dcr6VQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789725507; h=Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=t6B3Hmi6/wt4BzgK76LeXSgNmOywanfs4/UuSOxIqd8=; b=DiamMWWBjFpp3UKDSAzwZVKgDP2I3OPcCrK5sFX/CIW40c4dwJPjUS5JKv1mCWIVBAkAT4lDVzBWnlXmouXgiOYtLTpGhN/nBgJCxixO+fBbB8ijaHwa418gEhH7UsxNC+3t4w/Pr13dVjqOwIfxmRy6Vta2Yw3Wk9YVHHfQ8bk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1789725507645710.7926962425338; Fri, 18 Sep 2026 02:58:27 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x7VLn-0001l2-Bi; Fri, 18 Sep 2026 05:57:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x7VLk-0001km-Mq for qemu-devel@nongnu.org; Fri, 18 Sep 2026 05:57:44 -0400 Received: from [115.124.30.130] (helo=out30-130.freemail.mail.aliyun.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x7VLi-00061c-0U for qemu-devel@nongnu.org; Fri, 18 Sep 2026 05:57:44 -0400 Received: from localhost(mailfrom:guobin@linux.alibaba.com fp:SMTPD_---0XBAzfrM_1789725439 cluster:ay36) by smtp.aliyun-inc.com; Fri, 18 Sep 2026 17:57:20 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1789725440; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=t6B3Hmi6/wt4BzgK76LeXSgNmOywanfs4/UuSOxIqd8=; b=Kkd6GqjmhElHA/zrDqWOH+RqrWA8COdNQks7d/eJgttbNm/+vkTgXbVBYNukQ60U5jpev9wp4XCfwL0H0RndV71ULqiBacKatgzAXeB+4ISUjSOxbOI2qzme1UjsHXw5Uxxc4Ry/KQYz4p6eUbPwCksYJ6LX94h0Ik3A8tqT47A= X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R101e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=maildocker-contentspam033037026112; MF=guobin@linux.alibaba.com; NM=1; PH=DS; RN=1; SR=0; TI=SMTPD_---0XBAzfrM_1789725439; From: Bin Guo To: qemu-devel@nongnu.org Subject: [PATCH] hw/usb/canokey: validate endpoint number in canokey_handle_data Date: Fri, 18 Sep 2026 17:57:18 +0800 Message-ID: <20260918095718.33745-1-guobin@linux.alibaba.com> X-Mailer: git-send-email 2.50.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 115.124.30.130 (deferred) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=115.124.30.130; envelope-from=guobin@linux.alibaba.com; helo=out30-130.freemail.mail.aliyun.com X-Spam_score_int: -166 X-Spam_score: -16.7 X-Spam_bar: ---------------- X-Spam_report: (-16.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linux.alibaba.com) X-ZM-MESSAGEID: 1789725509393158500 Content-Type: text/plain; charset="utf-8" canokey_handle_data() takes the endpoint number from the USB packet (p->ep->nr, guest-selectable 1..15) and uses it to index the fixed-size ep_out[] / ep_out_size[] arrays of CanoKeyState, which hold only CANOKEY_EP_NUM =3D 3 entries. A forged bulk-OUT transfer on any endpoint number >=3D 3 therefore reads a bogus length from past ep_out_size[] and writes guest data through a wild pointer read from past ep_out[]. Validate p->ep->nr against CANOKEY_EP_NUM and return USB_RET_STALL for invalid endpoints, before any array access. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/4481 Signed-off-by: Bin Guo --- hw/usb/canokey.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/usb/canokey.c b/hw/usb/canokey.c index c3baedac2c..91dd886761 100644 --- a/hw/usb/canokey.c +++ b/hw/usb/canokey.c @@ -189,6 +189,11 @@ static void canokey_handle_data(USBDevice *dev, USBPac= ket *p) { CanoKeyState *key =3D CANOKEY(dev); =20 + if (p->ep->nr >=3D CANOKEY_EP_NUM) { + p->status =3D USB_RET_STALL; + return; + } + uint8_t ep_in =3D CANOKEY_EP_IN(p->ep->nr); uint8_t ep_out =3D p->ep->nr; uint32_t in_len; --=20 2.50.1 (Apple Git-155)