From nobody Sat Sep 26 21:37:04 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1789484640; cv=none; d=zohomail.com; s=zohoarc; b=PQV5zk79dclJ4v80Fxdeh6Ki0QZg7dQ1sSPch01EZbOsPf6DBViaP7OmoKvRUtnwitBE85akS2+WYZ/iNli1IK/JhCTKWF7A7AJLB7HgJyy97eJOIVOKaiBRsubZoOt8mM7EwAod7TbggUC16yNRSzaGctIKynMgHjqIP9IZ5yY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789484640; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=CgKk1faJYIh+LtPfleUaw9NjernxztxGAamFfM7vvBs=; b=MZezShniE4/+8ezN93h01IGNofwkAwuOwxB9TQaHOSbNzbpH9kyDrv4oTfYRc3dMPXYF1oDRGd6Y3wGyqPSVezqDczzfnJ+QniqI7hUyTrN8YjuTmXqweB/Xmb2Ak0OFLW/rttxFr5kDIXmGYEPupwoA/PPepI2PmTbMB4qxNFw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1789484640197639.5419013310184; Tue, 15 Sep 2026 08:04:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x6Ugt-0006yZ-Me; Tue, 15 Sep 2026 11:03:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x6UYw-0003gk-Ou for qemu-devel@nongnu.org; Tue, 15 Sep 2026 10:55:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x6UYu-0005gm-Aj for qemu-devel@nongnu.org; Tue, 15 Sep 2026 10:55:10 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-569-_UmHChufN72jeRUA6QnLOw-1; Tue, 15 Sep 2026 10:53:42 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 67A78195D003; Tue, 15 Sep 2026 14:53:41 +0000 (UTC) Received: from aagbaria-thinkpadt14gen6.raanaii.csb (unknown [10.47.238.83]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F35F83003EF5; Tue, 15 Sep 2026 14:53:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1789484104; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=CgKk1faJYIh+LtPfleUaw9NjernxztxGAamFfM7vvBs=; b=S6K0+fi7HLSIzF5LqpIBKjqPLbGoTnwpIaWW22++24iYu8BrCyll1twxhmwk7gVduWslz1 DldnXBo+CT0D9w1t96bcBAGhxORW0RLWedsbR+/or/dTkMtaVB/TJMiISjFp+naL5SjIHj SNNuVz3BDSpTqqLC7vuirJwwTZf4ezo= X-MC-Unique: _UmHChufN72jeRUA6QnLOw-1 X-Mimecast-MFC-AGG-ID: _UmHChufN72jeRUA6QnLOw_1789484021 From: Abed Agbaria To: qemu-devel@nongnu.org Cc: kkostiuk@redhat.com, michael.roth@amd.com, Abed Agbaria Subject: [PATCH] qga/vss-win32/install.cpp: remove orphaned VSS provider service Date: Tue, 15 Sep 2026 17:53:20 +0300 Message-ID: <20260915145320.215663-1-aagbaria@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=aagbaria@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 15 Sep 2026 11:03:20 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1789484644257158500 Content-Type: text/plain; charset="utf-8" COMRegister() probes the COM+ catalog to decide whether to unregister first, but it is the SCM that blocks installation when a service of the same name is left over. If the COM+ application is gone and the service survives, install fails with 0x80070431 and never recovers. - Check the SCM as well as the COM+ catalog in COMRegister(). - Delete the provider service in COMUnregister() and at the DllUnregisterServer() call sites in DllRegisterServer(). Signed-off-by: Abed Agbaria --- qga/vss-win32/install.cpp | 88 ++++++++++++++++++++++++++++++++++++++- 1 file changed, 87 insertions(+), 1 deletion(-) diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp index 5b7a8e9bc5..0e4f2ac009 100644 --- a/qga/vss-win32/install.cpp +++ b/qga/vss-win32/install.cpp @@ -241,6 +241,89 @@ out: return hr; } =20 +/* Check whether the QGA VSS provider service is registered with the SCM.*/ +static bool QGAProviderServiceExists(void) +{ + qga_debug_begin; + + bool exists =3D false; + DWORD err; + SC_HANDLE manager =3D OpenSCManager(NULL, NULL, SC_MANAGER_CONNECT); + SC_HANDLE service =3D NULL; + + if (!manager) { + errmsg(GetLastError(), "Failed to open service manager"); + goto out; + } + + service =3D OpenService(manager, QGA_PROVIDER_NAME, SERVICE_QUERY_CONF= IG); + if (service) { + exists =3D true; + } else { + err =3D GetLastError(); + if (err !=3D ERROR_SERVICE_DOES_NOT_EXIST) { + errmsg(err, "Failed to open service"); + } + } + +out: + if (service) { + CloseServiceHandle(service); + } + if (manager) { + CloseServiceHandle(manager); + } + qga_debug_end; + return exists; +} + +/* Delete a QGA VSS provider service that COM+ no longer owns.*/ +static HRESULT QGAProviderRemoveService(void) +{ + qga_debug_begin; + + HRESULT hr =3D S_OK; + DWORD err; + SC_HANDLE manager =3D OpenSCManager(NULL, NULL, SC_MANAGER_CONNECT); + SC_HANDLE service =3D NULL; + + if (!manager) { + hr =3D HRESULT_FROM_WIN32(GetLastError()); + errmsg(hr, "Failed to open service manager"); + goto out; + } + + service =3D OpenService(manager, QGA_PROVIDER_NAME, DELETE); + if (!service) { + err =3D GetLastError(); + if (err !=3D ERROR_SERVICE_DOES_NOT_EXIST) { + hr =3D HRESULT_FROM_WIN32(err); + errmsg(hr, "Failed to open service"); + } + goto out; + } + + qga_debug("Removing service: %s", QGA_PROVIDER_NAME); + + if (!DeleteService(service)) { + err =3D GetLastError(); + if (err !=3D ERROR_SERVICE_MARKED_FOR_DELETE) { + hr =3D HRESULT_FROM_WIN32(err); + errmsg(hr, "Failed to delete service"); + } + } + +out: + if (service) { + CloseServiceHandle(service); + } + if (manager) { + CloseServiceHandle(manager); + } + qga_debug_end; + return hr; +} + /* Unregister this module from COM+ Applications Catalog */ STDAPI COMUnregister(void); STDAPI COMUnregister(void) @@ -251,6 +334,7 @@ STDAPI COMUnregister(void) =20 DllUnregisterServer(); chk(QGAProviderFind(QGAProviderRemove, NULL)); + chk(QGAProviderRemoveService()); out: qga_debug_end; return hr; @@ -286,7 +370,7 @@ STDAPI COMRegister(void) } =20 chk(QGAProviderFind(QGAProviderCount, (void *)&count)); - if (count) { + if (count || QGAProviderServiceExists()) { qga_debug("QGA VSS Provider is already installed. Attempting to un= register first."); hr =3D COMUnregister(); if (FAILED(hr)) { @@ -499,6 +583,7 @@ STDAPI DllRegisterServer(void) g_gProviderVersion); if (hr =3D=3D (long int) VSS_E_PROVIDER_ALREADY_REGISTERED) { DllUnregisterServer(); + QGAProviderRemoveService(); hr =3D pVssAdmin->RegisterProvider(g_gProviderId, CLSID_QGAVSSProv= ider, const_cast (QGA_PROVIDER_LNAME), @@ -515,6 +600,7 @@ STDAPI DllRegisterServer(void) out: if (FAILED(hr)) { DllUnregisterServer(); + QGAProviderRemoveService(); } =20 qga_debug_end; --=20 2.55.0