From nobody Sat Sep 26 21:37:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1789436505; cv=none; d=zohomail.com; s=zohoarc; b=kI/ftuC54ls9VWh3keHra7O1tXiF5+pMiYKBf7fW7yrBV3gITVe1ZHnpDuryeJ4gfHmgHiNRvfOGCz8/lFcc04XLIoMUe79g/cEJJ16tUwwfFcTBIWjZL7T7COAAnChBZC9pe1W6Xx59ZG3yrMQNmzwb2XufJPr1gpgjM+op6QM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789436505; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=HNq3g4tfFW2/BMyA45iK7whUuFTibZ5zcf0Ca4+nyL4=; b=D3NXx08wk8PHzTWIYD5jDC1fTB4wpl4OKlb2o+UVtcqNy4LxBwc7Gva3Hb/9M5wsRTIx3Z4CC3Dqx0kUQXwor+/q8mdg/XRSyxDZ4VORhEC9NbFCrmNhNgOPJJDVbRjicGSBb9XhEdJ0DOwHKTlZPOY2tfzZSrVWhjh4KKmZD/U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1789436505828178.00779911866164; Mon, 14 Sep 2026 18:41:45 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x6IAm-0007v2-Tx; Mon, 14 Sep 2026 21:41:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x6IAk-0007uB-N8 for qemu-devel@nongnu.org; Mon, 14 Sep 2026 21:41:22 -0400 Received: from mail-pj2-x10.google.com ([2607:f8b0:4864:39::10]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1x6IAj-0003Z7-1q for qemu-devel@nongnu.org; Mon, 14 Sep 2026 21:41:22 -0400 Received: by mail-pj2-x10.google.com with SMTP id 98e67ed59e1d1-396ccda24afso2159838a91.3 for ; Mon, 14 Sep 2026 18:41:20 -0700 (PDT) Received: from stoup ([2603:800c:7900:ed00:c119:8717:353:53c6]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33ba4fb3ddasm26351702eec.30.2026.09.14.18.41.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2026 18:41:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1789436479; x=1790041279; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=HNq3g4tfFW2/BMyA45iK7whUuFTibZ5zcf0Ca4+nyL4=; b=qcadIg+42/j7m5mHNupBsGXF+sqOc0kK1r/riqtVcARSbKeJMP1n57fJfPwTKCaYxC qac0puPz5s0/kjMiAM28uoWsIsu1Iegpcvr3T7j2S7Za4VS9teZA94WFuZItRVDRx9Gt HR7d95vPUSHJ+kOkNd4YFbZIGba/NfGn+b3OM2F1FJuga8843pHqfJ7+lClmFDbpC6r/ oz3BFLh1/IXAT7ufY0qb4UGqcdqGYdND2b6t8hkeZUQLkza2/8S/3bJTTCT0CrEb5i3A 9HUubBuLyw0/jy1/S+Jt+s/u+pwOTEqA/pmWcYnNcCuMK7kC/I3pzV9f282Rx7hIEJXb SMIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789436479; x=1790041279; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=HNq3g4tfFW2/BMyA45iK7whUuFTibZ5zcf0Ca4+nyL4=; b=zcEfadWtGn2kZEXb+KM8Dra1jNBreXsH/yChgrs7as9donJpqt+JiIsoTDeuHepgZk 00v4fAjpv9Ju9AncxKfXLhpPhHwbXzYgGm/edbYyc7agV+Z2PIZPGaUBNCkkrbUFviT7 ICS/QCOhd6WBXkI/Cd0NVFO7rVA96pN+HJt2yro1MGNmxRunCLIRxZwZUOByxsbfBUn4 pahoMA6xd9SDAdge2qHUGWfvWbXHt74InN3MU1dtCmdoEEWTxwTMz3hC9sjwGCqoHDNd q0sMRK1gvaPlxhHusrZUdxpzTLiCyuL+y0usZU82vC/d5fUm1C0DFK52Sdwrf4xNXq5/ rABQ== X-Gm-Message-State: AFuF++m0xel7e6wRHd5sp7MOHj4RnjKaVjwE8x6PRwC6ozijigaE+KpX 2qM2tLbzrQQsWJN2nR77JOSGiW7Ch8ba0U62QshV0wFQhIjYOYG5SIAHnjN2RRPpVvzNbkEP1RI 1i6Mx X-Gm-Gg: AYBFou0j5ctUziulCanhN7tTm2FJIOB3yW6ukr2/Neb6ckYGkZXAd8l+GhgoJZuGJwr /0MCBQBLFp0tgUzRdQWS0GZWsIAu9oCoMA6RhfLfBHDl6jqqzmmPNOYFoPLNAvcYeDrRNnDX5Dt ysvU6hjyb2+AYZph+uLhy86FgEKRauGGcBwqOa537Hay9n6JwoFD3mmtbzNQaW1TvGaImU+baTY EgY3lq+XHHHfhIB+SYRmQlzxls9VTTuEAgSKZang9dehdItJB3lz3kHgEfOExvSOY7Ja5w3WFso CPm6oPCPZ1/57hqyyNcoA2VRKSf16+9Gg+/6nl8MgAkUTDrt3pFSAq0UhmY9Cq3vaQUyY3ngMUA D1l9bNGzr5bnyIs1mG6eSFmCx3CEkXG7/m9ciDbryFKkiLNGUKdgg9LNHqzjUspGEPUOaKea+pi 7yjknB4y4Fi2fHyqeHfWhCF4HyQYLIlXBCxp7NiSB6sSWnlj82vsKgQixiS4ESs2mbF5ZO41tfn Eh91g== X-Received: by 2002:a17:90a:d444:b0:39e:126:e9c9 with SMTP id 98e67ed59e1d1-39e0126eb27mr2651228a91.18.1789436479299; Mon, 14 Sep 2026 18:41:19 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, qemu-stable@nongnu.org Subject: [PATCH 1/2] tcg/optimize: Fix fold_multiply2 vs 1 Date: Mon, 14 Sep 2026 15:41:14 -1000 Message-ID: <20260915014115.1809286-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260915014115.1809286-1-richard.henderson@linaro.org> References: <20260915014115.1809286-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:39::10; envelope-from=richard.henderson@linaro.org; helo=mail-pj2-x10.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1789436509957158500 Content-Type: text/plain; charset="utf-8" For muls2, we returned from fold_multiply2 without finish_folding or any other mechanism to update value tracking for the rh output. We might as well do this via fold_shift, which will also mark rh as having all copies of the sign bit. For the movi paths of multiply vs 0 or mulu2, we're better off tail calling to tcg_opt_gen_movi rather than explicitly returning true. Cc: qemu-stable@nongnu.org Fixes: c9349965ce4 ("tcg: Optimize INDEX_op_mul[us]2 for 0 and 1") Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/4448 Signed-off-by: Richard Henderson Reviewed-by: Jim MacArthur --- tcg/optimize.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index d291c844ca8..bd91220650b 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -2213,6 +2213,7 @@ static bool fold_mul_highpart(OptContext *ctx, TCGOp = *op) return finish_folding(ctx, op); } =20 +static bool fold_shift(OptContext *ctx, TCGOp *op); static bool fold_multiply2(OptContext *ctx, TCGOp *op) { swap_commutative(op->args[0], &op->args[2], &op->args[3]); @@ -2253,15 +2254,13 @@ static bool fold_multiply2(OptContext *ctx, TCGOp *= op) /* The proper opcode is supplied by tcg_opt_gen_mov. */ op2 =3D opt_insert_before(ctx, op, 0, 2); tcg_opt_gen_movi(ctx, op, rl, l); - tcg_opt_gen_movi(ctx, op2, rh, h); - return true; + return tcg_opt_gen_movi(ctx, op2, rh, h); } =20 if (b =3D=3D 0) { op2 =3D opt_insert_before(ctx, op, 0, 2); tcg_opt_gen_movi(ctx, op2, rl, 0); - tcg_opt_gen_movi(ctx, op, rh, 0); - return true; + return tcg_opt_gen_movi(ctx, op, rh, 0); } if (b =3D=3D 1) { op2 =3D opt_insert_before(ctx, op, 0, 2); @@ -2269,20 +2268,18 @@ static bool fold_multiply2(OptContext *ctx, TCGOp *= op) =20 switch (op->opc) { case INDEX_op_mulu2: - tcg_opt_gen_movi(ctx, op, rh, 0); - break; + return tcg_opt_gen_movi(ctx, op, rh, 0); case INDEX_op_muls2: op->opc =3D INDEX_op_sar; op->args[0] =3D rh; op->args[1] =3D rl; op->args[2] =3D arg_new_constant(ctx, tcg_type_size(ctx->type) * 8 - 1= ); - break; + return fold_shift(ctx, op); default: - g_assert_not_reached(); + break; } - - return true; + g_assert_not_reached(); } } return finish_folding(ctx, op); --=20 2.53.0 From nobody Sat Sep 26 21:37:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1789436529; cv=none; d=zohomail.com; s=zohoarc; b=GhuVkJkt/XACg23JbGe/nxvVCsgV92LIrW3Stp/FGYkA8vbW6ySfoRIcPRh9e7VjwZYqlgHGisslaSshOVqO1ypE+c8jihMHP45CK/SkBo8k871x4zje1NMbwCdrLV9qPHGYZvDJ6cAIdT29L0UEZkc3OLpSnl11ubzQmAZ3xAo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789436529; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=MTqvBlEdbcDqKk+fC43xO2LCg7KVbS59qcAWR+HYP6E=; b=D1bQOdRttoMdZTYSgWiutWV5L9ydNe+1YMHWdcict0hAdu0ynLw87ZI+gXHg6JoUsmiAqagoThj+5lalyMFthKvRp7X9xK12Lk1I8OijE11P9PUIMYxFO7040DSIUL/p/mZ/gJe0/O8QBOWtdQpLx+agSuoPl5svfz/4DvS1Tco= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178943652892713.53148351870459; Mon, 14 Sep 2026 18:42:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x6IAn-0007vi-BM; Mon, 14 Sep 2026 21:41:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x6IAl-0007uY-SY for qemu-devel@nongnu.org; Mon, 14 Sep 2026 21:41:23 -0400 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1x6IAj-0003ZJ-Vu for qemu-devel@nongnu.org; Mon, 14 Sep 2026 21:41:23 -0400 Received: by mail-pj1-x102e.google.com with SMTP id 98e67ed59e1d1-383b4a3755fso4167826a91.3 for ; Mon, 14 Sep 2026 18:41:21 -0700 (PDT) Received: from stoup ([2603:800c:7900:ed00:c119:8717:353:53c6]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33ba4fb3ddasm26351702eec.30.2026.09.14.18.41.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Sep 2026 18:41:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1789436480; x=1790041280; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MTqvBlEdbcDqKk+fC43xO2LCg7KVbS59qcAWR+HYP6E=; b=Yjsb3RGHDnSBtgYG/Q3fn87GJ7OIyz3pw8j/cWAjuOC757ycXaE+BsYlDFwM3ZJuHV LO5FY8J8OKvQKV3RQ8+uVJ0YxE1OvIdi1O3pPX38NusxsbWNGFaISgFnNzWcXz5ZP/OB Jz7JZv1wtMXuLRaSs21zzWp3lh7FVIfSpA8r+d0hqqpb1ZQm6gIBsHNpksKVnzfDhMxD oAShjWWepzDasVKQqMaH/gUh3kwoZfj6ie1kjmXm1p5xdOzbmvGbWPgM0zcATgzbDCh6 NLI9xBdXnCW8q6cdDlnAhfF/Iw698kyV1KhLUcYfUW6hEbab0sPrr6elqJBJjkZ7zoZV sCFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789436480; x=1790041280; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=MTqvBlEdbcDqKk+fC43xO2LCg7KVbS59qcAWR+HYP6E=; b=HWdxK4F3+VY1Y91BvxbxU9dldOdfeHzrAQxXl7Q/y0W/E3/INFYElqXrHjJ5rTZcTo XI/z81TveXWR4WgyaBBPX9zdIkl05opyYeVzNewQDzOp5Qs3Twdl1ufj5teRgoMaayFc KhqVW6lRnlkmFlq3hDIwE4k9tIyrS4Grogu4W5w3w4kfEr+aD0Bz6dpSExQtPUQHyhpT 8jVrimpkyHSAto9+DdRhnx601Vn8XE7el7UtggjgLwp/PNd/0HW8TkT+v2EJAgf59OXi KfPWUzBuo+HGcEqMmFajnzfMj2cWDZtqgzIiq1iuzidiBfYfduIeqXiO2/rXzvfY0B1P qkmw== X-Gm-Message-State: AFuF++k0GIWbSZUnuHJNsNDjDAfzC6XH7Y4d1hP8PQz+gBFVgFlWEtms oJoqZu93rUgapeHR0s6rSQhMA8VHTw3DBfj/tCGN7LaFBLKp79H0C9G0AU2CRbHQzawLfmXVvI0 KnbKbtY8= X-Gm-Gg: AYBFou1LxYH0wodjIY9MoLg6TZAPYPShFkLfgd4k1qstxlUlWNnIp+QLvSBIgaJ1vrK wHZoXTspPPQ8Wkr/6cwSvYhShZAqedqXET+Uahj6dIUoC0lgVLaxJUhn2yeKID+gG7SGNn+5OBE NWuV7oN0jftzfSeYHShb/abcvk+fpYPJbJ3TwaiIG2mOzclEK1FM95sl3nVZWRoOcolSPb6DClJ ES1QXfJ13k3PWRR5x/+3j//7EThNvV9AfQyHm4hFr/K2T+vzTTCi6RtzXhdQdr++7Zb/+lyhG97 cNO5bWvvDNi8VnrgnpjxdW/ygp8ZP2nA4Orb8ly0ur7cIsqqtgTua/CtGN2xDg7pDnHxZjI5RHF 9A82aezS3ZIUXRRxAgm63wjkcgJcznVCRoTLAVGB1XbRgu+s3Izbucbcma3W5nwGKyto4y5idVt 3qRs7N12AECKIgajYGXd/Emfr9iaf5BxhIkQiqFyMGGsxy2wCjIX3r9/w9Au7lTn7H6bfzDUjlK qZIbA== X-Received: by 2002:a17:90b:2809:b0:396:d27b:89b9 with SMTP id 98e67ed59e1d1-39debfa956bmr11362318a91.10.1789436480462; Mon, 14 Sep 2026 18:41:20 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org Subject: [PATCH 2/2] tests/tcg/arm: Add regression test for #4448 Date: Mon, 14 Sep 2026 15:41:15 -1000 Message-ID: <20260915014115.1809286-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260915014115.1809286-1-richard.henderson@linaro.org> References: <20260915014115.1809286-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102e; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1789436530869158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: Richard Henderson Reviewed-by: Jim MacArthur --- tests/tcg/arm/issue4448.c | 51 +++++++++++++++++++++++++++++++++++++++ tests/tcg/arm/meson.build | 1 + 2 files changed, 52 insertions(+) create mode 100644 tests/tcg/arm/issue4448.c diff --git a/tests/tcg/arm/issue4448.c b/tests/tcg/arm/issue4448.c new file mode 100644 index 00000000000..180ff4029a2 --- /dev/null +++ b/tests/tcg/arm/issue4448.c @@ -0,0 +1,51 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include +#include + +/* Signed 64-bit product, constant operand first then second. */ +#define SMULL_CONST_LHS(k, x, lo, hi) \ + __asm__("mov r0, #" #k "\n\tsmull %0, %1, r0, %2" \ + : "=3D&r"(lo), "=3D&r"(hi) : "r"(x) : "r0", "cc") + +#define SMULL_CONST_RHS(k, x, lo, hi) \ + __asm__("mov r0, #" #k "\n\tsmull %0, %1, %2, r0" \ + : "=3D&r"(lo), "=3D&r"(hi) : "r"(x) : "r0", "cc") + +/* Unsigned 64-bit product, for contrast: this one is folded correctly. */ +#define UMULL_CONST_LHS(k, x, lo, hi) \ + __asm__("mov r0, #" #k "\n\tumull %0, %1, r0, %2" \ + : "=3D&r"(lo), "=3D&r"(hi) : "r"(x) : "r0", "cc") + +static int64_t s64(int32_t hi, int32_t lo) +{ + return ((int64_t)hi << 32) | (uint32_t)lo; +} + +static uint64_t u64(int32_t hi, int32_t lo) +{ + return ((uint64_t)(uint32_t)hi << 32) | (uint32_t)lo; +} + +int main(void) +{ + static const int32_t values[] =3D { 1961612, -1479053948, -7, 0 }; + + for (unsigned i =3D 0; i < sizeof(values) / sizeof(values[0]); i++) { + int32_t x =3D values[i]; + int32_t lo, hi; + + SMULL_CONST_LHS(1, x, lo, hi); + assert(x =3D=3D s64(hi, lo)); + + SMULL_CONST_RHS(1, x, lo, hi); + assert(x =3D=3D s64(hi, lo)); + + UMULL_CONST_LHS(1, x, lo, hi); + assert((uint32_t)x =3D=3D u64(hi, lo)); + + SMULL_CONST_LHS(0, x, lo, hi); + assert(0 =3D=3D u64(hi, lo)); + } + return 0; +} diff --git a/tests/tcg/arm/meson.build b/tests/tcg/arm/meson.build index 1b491cea026..5c2af2189c5 100644 --- a/tests/tcg/arm/meson.build +++ b/tests/tcg/arm/meson.build @@ -39,6 +39,7 @@ tests +=3D { 'expected_output': 'fcvt.ref', }, 'pcalign-a32.c': {'cflags': ['-marm']}, + 'issue4448.c': {}, } =20 # Vector SHA1 --=20 2.53.0