From nobody Sat Sep 26 20:51:35 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1789135663; cv=none; d=zohomail.com; s=zohoarc; b=mFmfn+yixA3rGK+2a/bAiT5hW9xkDTjwKgLn6E3l7WMZ9oq0ZXzbA0u/kKdWg3Qp6jLI+1VEss4dq59NrpJDcjYHvu00G0nIHY8Zk6BHjmQBGSejzEXiv96BWqvvPkvBpPvey/hokk0OmmgGWOVvcD8Ld8hqdggoIjSxFBtsUsg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789135663; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=DoYNu5oPHfKNnMPt0Xd+s4AwpaGV12EV3XyvYqejq48=; b=hzb/+QTxvlp0W25WGUW9qwPPTnWwuoHSQ9qoLJ5I/d0xfI+WmQ+4kOVxfXvh/tUgjGJWOgSXu/HFU9gz55Oiq5K/HhzPc6s4NG1HSk0/OKxmRWj6iDvw8Zk7FvML/slboMdJ+22usvxasgFg70L4E/EqHNxlKzpYVCj8L7goACc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1789135663424382.3632779984989; Fri, 11 Sep 2026 07:07:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x51u8-00041N-FY; Fri, 11 Sep 2026 10:07:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x51u6-000419-J5 for qemu-devel@nongnu.org; Fri, 11 Sep 2026 10:06:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x51u4-0001na-J5 for qemu-devel@nongnu.org; Fri, 11 Sep 2026 10:06:58 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-607-Fq8gnOZqMCygvHMhHiufLQ-1; Fri, 11 Sep 2026 10:06:53 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 88CF719539B6; Fri, 11 Sep 2026 14:06:52 +0000 (UTC) Received: from localhost (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 44BE5180034C; Fri, 11 Sep 2026 14:06:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1789135615; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DoYNu5oPHfKNnMPt0Xd+s4AwpaGV12EV3XyvYqejq48=; b=bsM8RxBqv+HfQVdNvupJXFJejYUrhMQfai38NWtcwGS43ITCu7JbClNUAwUbCmaz6w74+V Ai46Pc2WaujOS83+qz2J//PmjNnzsk4xolErhccPGpu4h98Qd6YUuHSfwDcC+KhFYZqauN cwjxpezj18Py4kwFw18vdwDqfJRL4Bk= X-MC-Unique: Fq8gnOZqMCygvHMhHiufLQ-1 X-Mimecast-MFC-AGG-ID: Fq8gnOZqMCygvHMhHiufLQ_1789135612 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: mjt@tls.msk.ru, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH] virtio-gpu-virgl: guard new_blob with VIRGL_VERSION_MAJORS>=1 Date: Fri, 11 Sep 2026 18:06:45 +0400 Message-ID: <20260911140645.56094-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1789135667468158500 From: Marc-Andr=C3=A9 Lureau virtio_gpu_virgl_resource_new_blob() is only called from virgl_cmd_resource_create_blob(), which is guarded by VIRGL_VERSION_MAJOR >=3D 1. Fixes: d814b44636d0 ("hw/display/virtio-gpu: introduce virtio_gpu_{simple,v= irgl}_resource_new()") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Brian Cain Reviewed-by: Michael Tokarev --- hw/display/virtio-gpu-virgl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c index 1c9380e2a6d2..f45571060fea 100644 --- a/hw/display/virtio-gpu-virgl.c +++ b/hw/display/virtio-gpu-virgl.c @@ -324,6 +324,7 @@ virtio_gpu_virgl_resource_new(uint32_t resource_id, uin= t32_t width, return res; } =20 +#if VIRGL_VERSION_MAJOR >=3D 1 static struct virtio_gpu_virgl_resource * virtio_gpu_virgl_resource_new_blob(uint32_t resource_id, uint64_t blob_siz= e) { @@ -335,6 +336,7 @@ virtio_gpu_virgl_resource_new_blob(uint32_t resource_id= , uint64_t blob_size) =20 return res; } +#endif =20 static void virgl_cmd_create_resource_2d(VirtIOGPU *g, struct virtio_gpu_ctrl_command *c= md) --=20 2.55.0.543.g5ebe2ebe4ea8