From nobody Sat Sep 26 20:52:11 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1789124240; cv=none; d=zohomail.com; s=zohoarc; b=a9os8u0oD3EsUsaHVGqmhpd+VcX5Dz0LClqbbRQh7qsXZx6YO3X09kT8cXWdLWfBwVWUSsvE2l+wclVdwxk/tolLUhgNyXOUnMw0+D2zxfbsCeOXOJF2IjMCdVxWbC3s/aFTj56EfnDizYfjdDuzZ/czVhCXZpf7uns856EX1cg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789124240; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0U8lqbgZxoqnnxxEIm5sa+IrwNYDVDCy/p86rJsU4OI=; b=RVaxwKKzaFFCl9Gf9GdNn5vXV6ZJI0Qov1Lrl6sAuBdrmBW5ALATnZej3W5nlZTXOAZPtOWRtWrDl8mPd0q1P/LHxacQjwYqhT831DJAlo44TG/7L80knb8B/tIuADveSXHBgfKn+UBy63N8pHMRLSBIo6NZsbb0o/Zdl5PcVvM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1789124237859458.1908072978829; Fri, 11 Sep 2026 03:57:17 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x4yw9-0004Z7-9u; Fri, 11 Sep 2026 06:56:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x4yvx-0004WE-0O; Fri, 11 Sep 2026 06:56:41 -0400 Received: from isrv.corpit.ru ([212.248.84.144]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x4yvu-0003CT-JV; Fri, 11 Sep 2026 06:56:40 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id EE1D81D3B83; Fri, 11 Sep 2026 13:56:02 +0300 (MSK) Received: from gandalf.tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with ESMTP id B73E9425DFA; Fri, 11 Sep 2026 13:56:35 +0300 (MSK) Received: by gandalf.tls.msk.ru (Postfix, from userid 1000) id A4EBE40F0B; Fri, 11 Sep 2026 13:56:35 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tls.msk.ru; s=202602; t=1789124162; bh=WA+3nlkepq+aZOxTW85cJBlOrW3GGvA+ikUW6COdVzc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=PaL1GgG3QL6t4BXcv+0yL7h2rovPxS8zm7okWhXAij2d6DF89jyilZKclmzaIfDFO uyIlBD+AuYs5whVzhHmqmxDsYMwlghRM+Z2ihD+1ciAV9xZ0PUu1KuHark3xrUdKZj gl3jh770wwg87HOQo3wt0l04SwWElFneN1Lb4+pKEAYPG6NBHmDUtkleNY3eKk9IOt P+PMVgSqsfl0b3cSOdLfPU8V2K/ge2IJ0oxoJjdvdZLFP/fFNnbMuJjVqTQfuZeF+e P4tp7gUIVnMQSmfTfusnLoafUKWsmjG1Oovb8ufAk5QHiY0w8DKG+5qqXGLy017brm jmKxz6PKLCV7g== From: Michael Tokarev To: qemu-devel@nongnu.org Cc: Rohitashv Kumar , qemu-trivial@nongnu.org, Michael Tokarev Subject: [PULL 1/4] qapi/net: gate user/vde/netmap netdev backends behind their CONFIG symbols Date: Fri, 11 Sep 2026 13:56:29 +0300 Message-ID: <20260911105635.955937-2-mjt@tls.msk.ru> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260911105635.955937-1-mjt@tls.msk.ru> References: <20260911105635.955937-1-mjt@tls.msk.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=212.248.84.144; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @tls.msk.ru) X-ZM-MESSAGEID: 1789124254188158500 Content-Type: text/plain; charset="utf-8" From: Rohitashv Kumar Their NetClientDriver enum members and Netdev union branches were unconditional, so query-qmp-schema advertised them even when built without CONFIG_SLIRP/CONFIG_VDE/CONFIG_NETMAP. Gate them, and guard the matching NET_CLIENT_DRIVER_USER/_VDE case labels in net/hub.c. Signed-off-by: Rohitashv Kumar Reviewed-by: Markus Armbruster Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- net/hub.c | 4 ++++ qapi/net.json | 19 +++++++++++++------ 2 files changed, 17 insertions(+), 6 deletions(-) diff --git a/net/hub.c b/net/hub.c index b53a4cc872c..1d1710a198b 100644 --- a/net/hub.c +++ b/net/hub.c @@ -299,12 +299,16 @@ void net_hub_check_clients(void) #ifdef CONFIG_PASST case NET_CLIENT_DRIVER_PASST: #endif +#ifdef CONFIG_SLIRP case NET_CLIENT_DRIVER_USER: +#endif case NET_CLIENT_DRIVER_TAP: case NET_CLIENT_DRIVER_SOCKET: case NET_CLIENT_DRIVER_STREAM: case NET_CLIENT_DRIVER_DGRAM: +#ifdef CONFIG_VDE case NET_CLIENT_DRIVER_VDE: +#endif case NET_CLIENT_DRIVER_VHOST_USER: has_host_dev =3D 1; break; diff --git a/qapi/net.json b/qapi/net.json index 85c78710fe8..bb626005a82 100644 --- a/qapi/net.json +++ b/qapi/net.json @@ -922,9 +922,13 @@ # Since: 2.7 ## { 'enum': 'NetClientDriver', - 'data': [ 'none', 'nic', 'user', 'tap', 'l2tpv3', 'socket', 'stream', - 'dgram', 'vde', 'bridge', 'hubport', 'netmap', 'vhost-user', - 'vhost-vdpa', + 'data': [ 'none', 'nic', + { 'name': 'user', 'if': 'CONFIG_SLIRP' }, + 'tap', 'l2tpv3', 'socket', 'stream', 'dgram', + { 'name': 'vde', 'if': 'CONFIG_VDE' }, + 'bridge', 'hubport', + { 'name': 'netmap', 'if': 'CONFIG_NETMAP' }, + 'vhost-user', 'vhost-vdpa', { 'name': 'passt', 'if': 'CONFIG_PASST' }, { 'name': 'af-xdp', 'if': 'CONFIG_AF_XDP' }, { 'name': 'vmnet-host', 'if': 'CONFIG_VMNET' }, @@ -949,16 +953,19 @@ 'nic': 'NetLegacyNicOptions', 'passt': { 'type': 'NetdevPasstOptions', 'if': 'CONFIG_PASST' }, - 'user': 'NetdevUserOptions', + 'user': { 'type': 'NetdevUserOptions', + 'if': 'CONFIG_SLIRP' }, 'tap': 'NetdevTapOptions', 'l2tpv3': 'NetdevL2TPv3Options', 'socket': 'NetdevSocketOptions', 'stream': 'NetdevStreamOptions', 'dgram': 'NetdevDgramOptions', - 'vde': 'NetdevVdeOptions', + 'vde': { 'type': 'NetdevVdeOptions', + 'if': 'CONFIG_VDE' }, 'bridge': 'NetdevBridgeOptions', 'hubport': 'NetdevHubPortOptions', - 'netmap': 'NetdevNetmapOptions', + 'netmap': { 'type': 'NetdevNetmapOptions', + 'if': 'CONFIG_NETMAP' }, 'af-xdp': { 'type': 'NetdevAFXDPOptions', 'if': 'CONFIG_AF_XDP' }, 'vhost-user': 'NetdevVhostUserOptions', --=20 2.47.3 From nobody Sat Sep 26 20:52:11 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1789124263; cv=none; d=zohomail.com; s=zohoarc; b=Ks+rQ3UjqI6csHFY6iuwnWllOHgHGCVSncZ8drplmBnjqQGvP3Fz2l9SJmCAz/iH8jhggAzvbTxkaetgT+dorhin+1YdFP8hmg/OVsXy/28Vx7d8YIzfOX/l8V8kh+tSexR1yJ5fckV5cWqVe3xX0JGVTVVEcTr9Vqof4D5x5Jg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789124263; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=6Y2npsdh1QwzRBH1+9YtPNR9oDGFIIuzH7J0YS6zF2c=; b=UzLMYnYC5F3h4uR+qrmRaa/NK4/60ZaGS0lvwqBAnfI4WsIWWMkbA9akO/reES6f2x5udTp/kWQSWOLDbC76pWTfjO70YGl5tbWUwNvXDp1gb+7JR3J+wSGS0QAtkN8GK2JORIw+XhhLs6xowsdR92GFpLf56A7FvjjV+B7kocs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1789124263838874.0034343668468; Fri, 11 Sep 2026 03:57:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x4ywM-0004im-2g; Fri, 11 Sep 2026 06:57:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x4yw1-0004XC-1F; Fri, 11 Sep 2026 06:56:45 -0400 Received: from isrv.corpit.ru ([212.248.84.144]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x4yvz-0003DD-IU; Fri, 11 Sep 2026 06:56:44 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 06F211D3B85; Fri, 11 Sep 2026 13:56:03 +0300 (MSK) Received: from gandalf.tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with ESMTP id BBFC2425DFB; Fri, 11 Sep 2026 13:56:35 +0300 (MSK) Received: by gandalf.tls.msk.ru (Postfix, from userid 1000) id A6F2C40F0D; Fri, 11 Sep 2026 13:56:35 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tls.msk.ru; s=202602; t=1789124163; bh=hLcmD1nmUPBX5BQlN8Z5O1fvPMOSUinE+2Mp1l7qTuM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=bvuKDQkTvCZ8JuDjdGd3/UM/MkKNlmoXwn49E6j4wi/XZwpEJ5Ufb3xHn9O+x7JE2 WEssdlL90sG2GiwV6teSlJSNBNwNxDSmtBxHl+l4bKPhM/5GSPQ7cN2TPCLFTKBk2Z JOrW9S4Tivrx17Y9uoylDIDY1wxJiaCg9eItMnO8+J/YcrHmbPK1FI2aBErsGZa+TD nTrgVq+5h56zM2TXPktbz0bq4jvmVx0WVnv9I/sHzZ5s3JFRsicYJB9HQLbHwYhpeL bil1wdSHjrBfF7r+j9coQZswBxd2AIAaEyxf0O0AS1J79Z/3tw30x8wy6DsX49TuLG ULxiBJ0xHmuPg== From: Michael Tokarev To: qemu-devel@nongnu.org Cc: Zhang Chen , qemu-trivial@nongnu.org, qemu-stable@nongnu.org, Michael Tokarev Subject: [PULL 2/4] qapi/misc: Fix missed query-iothreads items Date: Fri, 11 Sep 2026 13:56:30 +0300 Message-ID: <20260911105635.955937-3-mjt@tls.msk.ru> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260911105635.955937-1-mjt@tls.msk.ru> References: <20260911105635.955937-1-mjt@tls.msk.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=212.248.84.144; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @tls.msk.ru) X-ZM-MESSAGEID: 1789124265580158501 Content-Type: text/plain; charset="utf-8" From: Zhang Chen The example is incomplete: it misses members @poll-max-ns, @poll-grow, @poll-shrink, @aio-max-batch. Messed up in commit 5fc00480ab1 (monitor: add poll-* properties into query-iothreads result) and commit 1793ad0247c (iothread: add aio-max-batch parameter). CC: qemu-stable@nongnu.org Reviewed-by: Markus Armbruster Reviewed-by: Stefan Hajnoczi Signed-off-by: Zhang Chen Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- qapi/misc.json | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/qapi/misc.json b/qapi/misc.json index a21ba61b96e..baa50cc8449 100644 --- a/qapi/misc.json +++ b/qapi/misc.json @@ -123,11 +123,19 @@ # <- { "return": [ # { # "id":"iothread0", -# "thread-id":3134 +# "thread-id":3134, +# "poll-max-ns":32768, +# "poll-grow":0, +# "poll-shrink":0, +# "aio-max-batch":0 # }, # { # "id":"iothread1", -# "thread-id":3135 +# "thread-id":3135, +# "poll-max-ns":32768, +# "poll-grow":0, +# "poll-shrink":0, +# "aio-max-batch":0 # } # ] # } --=20 2.47.3 From nobody Sat Sep 26 20:52:11 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1789124244; cv=none; d=zohomail.com; s=zohoarc; b=I93E5IODkh9kq+VGF2CWNXl++I5jqwl3zQsnD9jBHCZDftx5HALtvhkIlP4ga9R3ip+6XWrvkeGwc00miZXM+PFNIiIZlz9dafCQDs4ZROwOxNFWi8+XXCqACNA/PM5M+hBrsmFsiGypoEfQBh0NG8vsv9qe+zmCSSQhHSKB1Xw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789124244; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=bqKBfiX7vQX5lQGFPZNZFTVXG1uVe0m760waCSboFyo=; b=Y1eKAwhtw1cHlsdNtiiCIrfbPi+8+v9OKcPYPWBYJW14vuAsOd8TzTmk0AqClkw043EM2iHHwskgK+aKk25svjz6W5VtppurLQR1qIYXbAeKK9CAqBnJhpoRBqyl/oV29F1SUl5jbmie+BEhqHenbrrFb5ULiJSjW1Pnazx/Wz8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1789124241171263.8040241058825; Fri, 11 Sep 2026 03:57:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x4ywF-0004eM-Iy; Fri, 11 Sep 2026 06:56:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x4yw0-0004XB-OQ; Fri, 11 Sep 2026 06:56:45 -0400 Received: from isrv.corpit.ru ([212.248.84.144]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x4yvz-0003DC-7N; Fri, 11 Sep 2026 06:56:44 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 017FF1D3B84; Fri, 11 Sep 2026 13:56:03 +0300 (MSK) Received: from gandalf.tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with ESMTP id C0584425DFC; Fri, 11 Sep 2026 13:56:35 +0300 (MSK) Received: by gandalf.tls.msk.ru (Postfix, from userid 1000) id A92C240F0F; Fri, 11 Sep 2026 13:56:35 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tls.msk.ru; s=202602; t=1789124163; bh=8Dn8wSbp5vyXbsqBaW4WnTRu/xhtPvf5vHXkpm4K8vs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=mhnCJqiHiTVlUDuWwPp2Z+QQUlNvtEWhAnceED4TN2tsl+Uxv7rEOmAJV4XvjYQod QeT8PY/gbINZ1+wDb8d0fWL9NwYMugNPMhVFKx+W8iyGB7TkDcUNqK6kCrXPsIMZ4u sgl2OIruCYKqVbZdzBfIJakFqzrCXwPntvkDHZge+MuLnMVIFIaU74SlttGDlZKTRc AEF2q9h8B7IenWAfkrxAlYUyCUfnCbR592AmTHyZvHn1RASDjakO2aZyCV+VsLxgwL YYQ8jPiDzMpaa9VKclTtb6DEH2f/f1mI4lhPjKh6WSvA0zeoC1QQn0qSGx6M+W8mox PdoQuaiYizj+A== From: Michael Tokarev To: qemu-devel@nongnu.org Cc: Thomas Huth , qemu-trivial@nongnu.org, Michael Tokarev Subject: [PULL 3/4] util/cutils: Use qemu_isdigit() instead of isdigit() Date: Fri, 11 Sep 2026 13:56:31 +0300 Message-ID: <20260911105635.955937-4-mjt@tls.msk.ru> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260911105635.955937-1-mjt@tls.msk.ru> References: <20260911105635.955937-1-mjt@tls.msk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=212.248.84.144; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @tls.msk.ru) X-ZM-MESSAGEID: 1789124254223158500 From: Thomas Huth When building QEMU for NetBSD ("make vm-build-netbsd"), the compiler complains: In file included from /usr/include/ctype.h:100, from ../src/include/qemu/osdep.h:123, from ../src/util/cutils.c:25: ../src/util/cutils.c: In function 'do_strtosz': ../src/util/cutils.c:245:61: warning: array subscript has type 'char' [-W= char-subscripts] 245 | if (retval =3D=3D 0 && *endptr =3D=3D '.' && !isdigit(endpt= r[1])) { isdigit() should not be used with plain "char" variables since these can be signed and isdigit() could be implemented as a macro that uses its parameter to index into an array. Use our wrapper qemu_isdigit() to fix this problem. Signed-off-by: Thomas Huth Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- util/cutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/cutils.c b/util/cutils.c index 96c80d4d429..91ddadfd15a 100644 --- a/util/cutils.c +++ b/util/cutils.c @@ -242,7 +242,7 @@ static int do_strtosz(const char *nptr, const char **en= d, */ double fraction =3D 0.0; =20 - if (retval =3D=3D 0 && *endptr =3D=3D '.' && !isdigit(endptr[1])) { + if (retval =3D=3D 0 && *endptr =3D=3D '.' && !qemu_isdigit(endptr[= 1])) { /* If we got here, we parsed at least one digit already. */ endptr++; } else { --=20 2.47.3 From nobody Sat Sep 26 20:52:11 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1789124264; cv=none; d=zohomail.com; s=zohoarc; b=ihycpiJ4ZTinnAe3jN4AsTuOktjpHgCuWLQTLU5NAzEr/xosJVdmbPpgCU3AhKQ8/mz8hhQhc//5gTGWGaV0laBZ8nqpaTW5FKv2SE9hQHO+dghGdVWL4pXnGW/jKAFODc1TESkzZpRW18TKN+PTdn5cD/ckLRBAu+PwEFgEeE0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789124264; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+PAi58FbrPoaoLw4A7Ui2awoGmaiwXSwOUZiVN0W0uo=; b=VNxbr5R4C8UKKT1FTz5SU/NJVWbGdokDejIPLoFmsho9/T+k6tSjvtx8kst0p/tgDSv0tiZF05qc/BH3aX1z+PI7CkS8vhkovloAH3LBJidoOf6k7t3437Oyuh5uHkeX3pg+gabuNDi8cArjzlGpJQK9pa1RTALTF9qEDRJae8w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178912426258075.01314737011285; Fri, 11 Sep 2026 03:57:42 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x4ywE-0004dL-WB; Fri, 11 Sep 2026 06:56:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x4yw3-0004Xb-PC; Fri, 11 Sep 2026 06:56:49 -0400 Received: from isrv.corpit.ru ([212.248.84.144]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x4yw2-0003EB-6D; Fri, 11 Sep 2026 06:56:47 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 079A61D3B86; Fri, 11 Sep 2026 13:56:03 +0300 (MSK) Received: from gandalf.tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with ESMTP id C4F61425DFD; Fri, 11 Sep 2026 13:56:35 +0300 (MSK) Received: by gandalf.tls.msk.ru (Postfix, from userid 1000) id AB59F40F11; Fri, 11 Sep 2026 13:56:35 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tls.msk.ru; s=202602; t=1789124163; bh=Xl5CqXqwDmrK0Vxv+IS0O+njx9A89LCKWKuO1tRaWrM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=yLdgSMeK2IOLkv6JAycagxQtJURhWVNbdh+z8QrEd2mQjSsC/TdajjPI+tiBa/+Zn SvfTth2NoiMse9p3XMgW0UXKRHOC8+yI+cW1/DqiAWTqF3P+hLAqT69geWgVdXyaz1 bzoC/ZjGaiHaUtaD0Jfy5cwd5jNDA/cGd//nwZPFSBSJakY9ax+bhr9AuAnmZTDzpJ uy94lIN0VWt7dGHMbKQkqWDWA+T3jNqwOsYu78imrEFNw3fg4vnVlCDJn/W3vS82dE uk2Bv8jGIsylG7Lg6ZIwjac17kIMBXaqs3EwxJ+hq8zvSoSHmiKAYioU/qx1OmPFoD TTPpPetKSqmTQ== From: Michael Tokarev To: qemu-devel@nongnu.org Cc: Thomas Huth , qemu-trivial@nongnu.org, Michael Tokarev Subject: [PULL 4/4] hw/ppc/vof: Use qemu_tolower() instead of tolower() Date: Fri, 11 Sep 2026 13:56:32 +0300 Message-ID: <20260911105635.955937-5-mjt@tls.msk.ru> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260911105635.955937-1-mjt@tls.msk.ru> References: <20260911105635.955937-1-mjt@tls.msk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=212.248.84.144; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @tls.msk.ru) X-ZM-MESSAGEID: 1789124267514158500 From: Thomas Huth When building QEMU for NetBSD ("make vm-build-netbsd"), the compiler complains: In file included from /usr/include/ctype.h:100, from ../src/include/qemu/osdep.h:123, from ../src/hw/ppc/vof.c:12: ../src/hw/ppc/vof.c: In function 'path_offset': ../src/hw/ppc/vof.c:150:31: warning: array subscript has type 'char' [-Wc= har-subscripts] 150 | *at =3D tolower(*at); tolower() should not be used with plain "char" variables since these can be signed and tolower() could be implemented as a macro that uses its parameter to index into an array. Use our wrapper qemu_tolower() to fix this problem. Signed-off-by: Thomas Huth Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- hw/ppc/vof.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ppc/vof.c b/hw/ppc/vof.c index fa7b73159a0..873e967f1e4 100644 --- a/hw/ppc/vof.c +++ b/hw/ppc/vof.c @@ -10,6 +10,7 @@ */ =20 #include "qemu/osdep.h" +#include "qemu/ctype.h" #include "qemu/timer.h" #include "qemu/range.h" #include "qemu/units.h" @@ -147,7 +148,7 @@ static int path_offset(const void *fdt, const char *pat= h) if (*at =3D=3D '/') { at =3D strchr(at, '@'); } else { - *at =3D tolower(*at); + *at =3D qemu_tolower(*at); ++at; } } --=20 2.47.3