From nobody Sat Sep 26 20:00:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788845527; cv=none; d=zohomail.com; s=zohoarc; b=Q8Uk6NOSjL3eV1gX/n2kK1ekBuEmAzCn5gXYf8u5vhNeB0YpqQXaBIhsLpc9k9gjdc5SSVYREOwFL1L0nL/qxltPPK/dr3qQOaPX6eUcGG6Etl1ST+boj9r+C9DuVLJwC6HeHDAq/UBZjvF7LUO9OoeM0Q0SyeQUvA5HkiZZAOk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788845527; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=mLudrC7uymn4v//8KlFkJEa88Kz+y3kmymC0vccj4fE=; b=eoPZjH0byjLdwN++X4Y2h4HVLmOrq1B1fBI2bCFHJasnArIS33cNn8yJdsI73RE6PSSaM2/MOaQuPHKe2bZtmozoWL4ntegBDZhjKgDPPtKOYEQYjivXVwfAouIBRtWt7+mDAfDGtzxmyGd+8wLecWQLJI/xK2xifx/WXoq8N8s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788845527524392.12000489670845; Mon, 7 Sep 2026 22:32:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x3oQU-00046r-2d; Tue, 08 Sep 2026 01:31:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3oQS-00046V-LP for qemu-devel@nongnu.org; Tue, 08 Sep 2026 01:31:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3oQQ-00054m-P7 for qemu-devel@nongnu.org; Tue, 08 Sep 2026 01:31:20 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-YM5wOWf2OQ6w94V_fmXsDg-1; Tue, 08 Sep 2026 01:31:10 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 38556182A101; Tue, 8 Sep 2026 05:31:08 +0000 (UTC) Received: from corto.redhat.com (unknown [10.44.48.19]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C4FA11956049; Tue, 8 Sep 2026 05:31:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788845476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mLudrC7uymn4v//8KlFkJEa88Kz+y3kmymC0vccj4fE=; b=ZHYgqizmh3OZzeE9h1Y0zJzqr85cbkj0ymVG59MvVCvb3ITI5RCnZcMnIHwn2tX696uV3A iEBQL7Nv4zr1tIeYtWismteypMyUWSR/vq0isJ7woNDcjicPlHJgVpCf/l8QfjdlPWPc+s pC8jyX5BI+jFOvMa4ouRUufiuWHjIU4= X-MC-Unique: YM5wOWf2OQ6w94V_fmXsDg-1 X-Mimecast-MFC-AGG-ID: YM5wOWf2OQ6w94V_fmXsDg_1788845469 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-devel@nongnu.org, qemu-arm@nongnu.org Cc: Peter Maydell , Steven Lee , Troy Lee , Jamin Lin , kane_chen@aspeedtech.com, Andrew Jeffery , Joel Stanley , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Christopher Boker Subject: [PATCH] hw/misc/aspeed_hace: Fix OOB read in has_padding() Date: Tue, 8 Sep 2026 07:31:00 +0200 Message-ID: <20260908053101.1149625-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788845534478154100 When total_msg_len equals total_req_len, padding_size is 0, making pad_offset equal to req_len. The subsequent padding[pad_offset] read accesses one byte past the buffer. Return false early when padding_size is zero. Fixes: 5cd7d8564a8b ("aspeed/hace: Support AST2600 HACE") Reported-by: Christopher Boker Signed-off-by: C=C3=A9dric Le Goater Reviewed-by: Jamin Lin --- hw/misc/aspeed_hace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/aspeed_hace.c b/hw/misc/aspeed_hace.c index 8de05a9d98b3..bf8af710335d 100644 --- a/hw/misc/aspeed_hace.c +++ b/hw/misc/aspeed_hace.c @@ -225,7 +225,7 @@ static bool has_padding(AspeedHACEState *s, struct iove= c *iov, uint32_t padding_size =3D s->total_req_len - *total_msg_len; uint8_t *padding =3D iov->iov_base; =20 - if (padding_size > req_len) { + if (padding_size =3D=3D 0 || padding_size > req_len) { return false; } =20 --=20 2.55.0