From nobody Sat Sep 26 20:01:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788778142; cv=none; d=zohomail.com; s=zohoarc; b=SUbr6LGlQFaxWcDRe/vVJo8YFYGvbPU1n4EupjdneNx15AqNmdE3uL7eq9SiEsq0bE3WmqowLR/QsA8lPFd3g6KkrAef1ayYKfTbp5dA+szEikyXZ2XMq2pvtYSeASRGqn/KnVuNKP/SWVrKtb84k3ML+Inu92YrP/XG8z8zN3k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788778142; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tYfRNwV9tAgaeheG+Znb5EegaaSAbYL3kCuEkRWtyjU=; b=CyjJ+qnvf+ITDTu0G5yFIZARGMdqW8SA7SxMlfX3B5ALstx5DW7fnARN+DoqducnEdZpx5FSQv9kkTmA/B9GRkeH28tPwxxEdUc1ZNWQe3uGjhsemptdxDs5W20BcXQYIqYjMEUvpLIifJXjTrCyUlbysZ+sDPdKFSWQRCmBuWc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788778142731382.248647753805; Mon, 7 Sep 2026 03:49:02 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x3WuC-000639-Sc; Mon, 07 Sep 2026 06:48:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3WuA-000616-Uq for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:48:50 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3Wu9-0007ZH-3f for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:48:50 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-117-7if3p-4AN2qRfzUNKxPtMA-1; Mon, 07 Sep 2026 06:48:46 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F3EC6182A11E; Mon, 7 Sep 2026 10:48:43 +0000 (UTC) Received: from localhost (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5EA4526C; Mon, 7 Sep 2026 10:48:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788778128; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tYfRNwV9tAgaeheG+Znb5EegaaSAbYL3kCuEkRWtyjU=; b=YUlrFF5aD0y4Pj4zkeCAjrnB9QB9YZmAx5QrVDSG38o/EN/UbVmoolPJvtmDO8kMs8c9Mm MjiSprHGwLOeO9zCfQkfVywbEpCbbeYz5m25HF00PmbAEqSaTw/ODYSOn/Ro+Tg4pbERxj ZMRl0+YXhgZdnGC8T4ahwK2EF2+7IEk= X-MC-Unique: 7if3p-4AN2qRfzUNKxPtMA-1 X-Mimecast-MFC-AGG-ID: 7if3p-4AN2qRfzUNKxPtMA_1788778126 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 07 Sep 2026 14:48:25 +0400 Subject: [PATCH 01/17] qga/installer: preserve VssOption registry value across upgrades MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-qga-v1-1-86456ad356e2@redhat.com> References: <20260907-qga-v1-0-86456ad356e2@redhat.com> In-Reply-To: <20260907-qga-v1-0-86456ad356e2@redhat.com> To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk , Michael Roth , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=3679; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=mtOKKpdNUw3uUnSWCflHT7P06kecXY08t1ekbENlSYw=; b=owEBawKU/ZANAwAKAdro4Ql1lpzlAcsmYgBqnpaApQU+WoY9Lb+KVl5jFyGMVHrVF1Ttmbysj /Ztx7KjmCyJAjEEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap6WgAAKCRDa6OEJdZac 5X9RD/DIexN3tycUt18PvY3VjXsnUjzKdsLm8GVhzw4rrgadoiDkwHcOplZVUHmlYFx6gAQl1O8 DOdgFC7+gkBgSQxbBf9vD5oug4jNATDEzVxAmWiq6w8fj9SuHjs1aN8uWAbSw28Yb3XiSuDeSTf qZqp4+Bq/Pb2cdZqRdkxg29/THNyC1+P70uve9YDjFPllR9RFp9pi5Kq97j7QB99ucNdAJvgPcE pOGd72cS7uapAU+DkSPZoYsP11NuA2P6v8xtMF1bl/T2XfoJsFlWkOIUdDUnJvdbkyyuLuW0n6t HLvfByJkc49opX8uzHhc32InEkR6vs/E4pv1ryZzSEEa/PsG/gK+ZY9CXH/mLSIhNSso+blIafA TOYPtm6UM+mZy5ddSlJUAuIbzpjbPNXAzaS7sa9x9AwynMTepkPv5KuwShSkyvikgV4PHNEVOsU 5efgaH01nca1tvIUozkoTlOcrj9AHAmBZI8piAfdp9Yg9NvljLEmBUgNOwVW8nrwVv/0wf+r+XZ YqtCgYdAAs2eFP5xUY9lCCjiVa94Xjku5erA66yZxSYk+uIAFlsQticjnG5Xey9Rp/NKUpMXgeW fgDqANpqJ3Q4+BVuRrhWLe001/54CyN6ziwsy5RzhfmisAGnIEJLP1n0aE+Qhvvz+WY9tDHVQjN WWlOerPDQapw= X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788778144567158500 The VssOption registry value was unconditionally written to 1 on every install, overwriting any administrator customization. Additionally, it was created even when VSS support was not being installed. Move VssOption into its own component guarded by the InstallVss preprocessor conditional. Use a RegistrySearch to read any existing value into the VSSOPTION_VALUE property (defaulting to #1 for fresh installs), and write it back via MSI property substitution so admin customizations survive upgrades. Update the registry_entries component GUID since its resource set changed. Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/2919 Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Kostiantyn Kostiuk --- qga/installer/qemu-ga.wxs | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs index 32b8308728dc..5be19b211ccf 100644 --- a/qga/installer/qemu-ga.wxs +++ b/qga/installer/qemu-ga.wxs @@ -31,6 +31,15 @@ /> 1 + + + + + - + @@ -122,11 +131,16 @@ + + + - + + + @@ -167,6 +181,7 @@ + --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:01:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788778248; cv=none; d=zohomail.com; s=zohoarc; b=SxMcFCMbfxH6+7fqd+BrvHpfmJlvFMbkYpMIENfk1I1gTHg80/KMt56M5sTLJsADah6ahn7hR8+T5NPhSVmRwS+NpHMwyws1k88n2DVI+874PfSMsxDO6NYfE92ZBzcb/s9khmN9xkNAX4uJA/6CFM1UnOgqKroqXvrL410V4VM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788778248; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=dQnp3Mz1B09gp9VQlo2nPfiEstnHQLr+FEq8i0YUZwo=; b=CsOWu75rN262IHtwLiJDk5Ag4yWG7XflOB5M4wgS6jSUbng1KyNZ3Elrf4g4H/Rzin23qh3UfAcwpXBT8/xImD2hobmss8MDqR+mobK6idzThO4dkoQT+2udidy4LrRZK3JwdjUoha94tFZEA+r2PxPq+6KP4t24g59+4cLCQbM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788778248212134.12729977695153; Mon, 7 Sep 2026 03:50:48 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x3Wvm-0007Qs-Bb; Mon, 07 Sep 2026 06:50:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3Wvc-0007Q9-0b for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:50:22 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3Wva-0007xT-Cn for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:50:19 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-67-UEUI-p1bME6vzF4kmhGVbA-1; Mon, 07 Sep 2026 06:50:16 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 91BFB1800DA1; Mon, 7 Sep 2026 10:50:15 +0000 (UTC) Received: from localhost (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 71FBC180034F; Mon, 7 Sep 2026 10:50:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788778217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dQnp3Mz1B09gp9VQlo2nPfiEstnHQLr+FEq8i0YUZwo=; b=P4fIygROJtKqa7CueRkDRAJU+mIlYxRB9FzjbRxqFATU8RNKTa+uvqR2D6iW1Qo46NkRmT zyqubTL0E+1ipxMVuMJROlE+dxpwJp2W7Jp4JZFevtfzP/IMbvkMJODGlHhLsO8SrDfg/r xU8WWVwYntpNsyWuTWkmaSxDygYjYnA= X-MC-Unique: UEUI-p1bME6vzF4kmhGVbA-1 X-Mimecast-MFC-AGG-ID: UEUI-p1bME6vzF4kmhGVbA_1788778215 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 07 Sep 2026 14:50:00 +0400 Subject: [PATCH 02/17] qga/vss-win32: fix race condition in COM Release() methods MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-qga-v1-2-86456ad356e2@redhat.com> References: <20260907-qga-v1-0-86456ad356e2@redhat.com> In-Reply-To: <20260907-qga-v1-0-86456ad356e2@redhat.com> To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk , Michael Roth , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1620; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=gCx/Di7WKMkbWKj6aE6B9CpxBklB9tL44A3DelTcsfw=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnpbjCeLijl9csgdzCW5SJS1zE9PzaABsvPZdM W97V/g33BOJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap6W4wAKCRDa6OEJdZac 5fIXEACnA72mc4xx7Xc+Vm81PQcD3OEmS7ZVMraKDNmaoT/3kD5X+TmQgTXk4ddtQgJVkT11OKI 0cUIHFqRX8aSsOZHjc3sdtp47kZrgvzz2fOyglzNgwgjXLx7gXiLGOPs8uhHCBDs2/CbKxljfHd WV/E3s9KgjTmDglIy07FEBlMly2+AmKvSONsZGrpL+SsZVtU0xg4ULWb+KgP1o609shQYVYppJv F58H0jOBWKxBYE1ISH6BcD3EicexNB5fK49/Ci4/UWioktDHllQE66Vq5UXvrqWXOU65ROTF3/M MY5vtQwgnsw0wkENO+wxYc/rDQ9T0n+i4CxUVLJcQv8ceqoT09uqfugb1n2sgrgcBjdnrDSrzMm TDf+o0LKlgOKkr5vxiyU0r76WHC3qEv3kvI9siqg0CrLhG9EoZ0nNErg8Rth9CYPUgHzfWJQxoJ 4nOd0K+6MnXv5OZmwyiZJFkE0a7b0hLajW394ITP43j/hIc3KIuj5MOuY/S+O+13MwaaPA7oUyJ NzwHnQI8QYGwXfSxhlXDACZTADk/32vErLtp/vja8lXb5Xc1AYLynZLp+OH5LopvgKpjU6p9bTe jsXRl/k0ylr6tjqIsbGFMxPjothO2GP5W2+MjNj6SnLYsReerg9mlyO8ilm0vYuI26v0qDOXqs4 jcaNT4SmZIza4rg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788778253227154100 All three Release() implementations checked the member m_nRefCount after InterlockedDecrement instead of using the local return value. In a multi-threaded context (vssvc), two threads decrementing concurrently could both read m_nRefCount as 0 and double-free. Fixes: b39297aedfab ("qemu-ga: Add Windows VSS provider and requester as DL= L") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Kostiantyn Kostiuk --- qga/vss-win32/provider.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qga/vss-win32/provider.cpp b/qga/vss-win32/provider.cpp index 2b5c6f8e8ecd..79906dcc24ae 100644 --- a/qga/vss-win32/provider.cpp +++ b/qga/vss-win32/provider.cpp @@ -108,7 +108,7 @@ STDMETHODIMP_(ULONG) CQGAVSSEnumObject::AddRef() STDMETHODIMP_(ULONG) CQGAVSSEnumObject::Release() { long nRefCount =3D InterlockedDecrement(&m_nRefCount); - if (m_nRefCount =3D=3D 0) { + if (nRefCount =3D=3D 0) { delete this; } return nRefCount; @@ -244,7 +244,7 @@ STDMETHODIMP_(ULONG) CQGAVssProvider::AddRef() STDMETHODIMP_(ULONG) CQGAVssProvider::Release() { long nRefCount =3D InterlockedDecrement(&m_nRefCount); - if (m_nRefCount =3D=3D 0) { + if (nRefCount =3D=3D 0) { delete this; } return nRefCount; @@ -477,7 +477,7 @@ STDMETHODIMP_(ULONG) CQGAVssProviderFactory::AddRef() STDMETHODIMP_(ULONG) CQGAVssProviderFactory::Release() { long nRefCount =3D InterlockedDecrement(&m_nRefCount); - if (m_nRefCount =3D=3D 0) { + if (nRefCount =3D=3D 0) { delete this; } return nRefCount; --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:01:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788778246; cv=none; d=zohomail.com; s=zohoarc; b=ZFewcNRgTl/QBdLgw/1WDjh1uJEELabiEzQJ2lZQxlTcADdgokXREAzhxXxzlIAXaur2zjk4Ukx4MhFVeEP+KE/wqws2MP8bci+JrQN8jtEpmaPk3Wj2z6SOOKYzmlDUDtmGen9PJCRuP/wH1ASLlZpFgBbH5iMXBHk8QNta4fc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788778246; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=LAn9LXQ/71U5VFwcq/jTJlZ5CbT4GlJECNd20vWIhew=; b=VpnkezG7Yu0SRtT9wvxB6vT3uJVfSZNGxnmKKGHkyMvRutOeAWnvVUeER57YVYlE8CZGN0t6il3yQa/BdunSWz+NZRIpuKkDZIzuWZPMPtVsdp6/nG+O4rJ2RyOPKVuGf4OymdPXwM7QuoVMnCuMJ1DrvrTl6Yr1PcOblJbFF34= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788778246279181.977544413621; Mon, 7 Sep 2026 03:50:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x3Wvo-0007Re-QD; Mon, 07 Sep 2026 06:50:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3Wvi-0007Qb-Kh for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:50:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3Wvf-0007yF-QD for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:50:25 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-319-fS58Uq05NuaVHqaVb4vt9w-1; Mon, 07 Sep 2026 06:50:19 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DC6BB19540DB; Mon, 7 Sep 2026 10:50:18 +0000 (UTC) Received: from localhost (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E3D371800598; Mon, 7 Sep 2026 10:50:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788778223; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LAn9LXQ/71U5VFwcq/jTJlZ5CbT4GlJECNd20vWIhew=; b=Z3PBRZnyTOhoCRcaAdKRyprPFA6j7XU7r8uUJv2h57XwrGCXWeDBSF6GUTZHQkktczQPiq aJFVz6WfEEAtfMrGYxDRj7gpKn2r3cwZN+ChRubCYJQZkcIdplLukk7mpqccZjMeNkROIG 7z36If0J4kbeFzsXV8w3WqodrrnNBcE= X-MC-Unique: fS58Uq05NuaVHqaVb4vt9w-1 X-Mimecast-MFC-AGG-ID: fS58Uq05NuaVHqaVb4vt9w_1788778219 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 07 Sep 2026 14:50:01 +0400 Subject: [PATCH 03/17] qga/vss-win32: pass valid SERVICE_STATUS to ControlService MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-qga-v1-3-86456ad356e2@redhat.com> References: <20260907-qga-v1-0-86456ad356e2@redhat.com> In-Reply-To: <20260907-qga-v1-0-86456ad356e2@redhat.com> To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk , Michael Roth , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1148; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=sx6g589gOMK4C+r61jCesMHXiLnlP3zeTmUtl0johFk=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnpbj8uIlZRS8aujOLEZUe1jgSNgJT/ECW21f4 z/4qxZuUDCJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap6W4wAKCRDa6OEJdZac 5XnmD/wMybTDFHh+XYgHaitcnJ/bi3EYGdV1F4IsiRocQyftNN3BILxc3tpDgSExTMnHHUi3OF8 psD8scGrKMrGTyaoN/w9PJFSG3MqS84/ZKYiDb9ZI8Vxf/fPPL70l855HVHzYWENVjLhuItWoYF lfuYH6/P4EBt7zMZAsQzWr8YcXyoGPhZNJ0y+8pXWcnqxoDDYuJwxnqVTUMbbJHtDBogAMMsrIK sxJjsnyCv3xdBHgjIpwfE+h8kYkd51uPu9lzs6ezt8DyU8mgTi8i363+Df+tthMu8R8qBRhpwRf R08ZIpFqF5ayjTo0tbflwHJurYQ1+JhPTBUJpJpxzam0voh+isCgzBZndEEzZ0So0II8a+IfF4O E7WJCnwybPu0lq773OiY7aP+8sy0nY6pGVMURxv07CTqT70lecYGlIqwRCdYFFTJlTcHxhyHrFH vNzcG9BVLjsbCX7K8HdZnkPmk76Msb0FGikoWRUcVnEAyKTjWNe0cNrgtX6mPoEv1rlIm0pK9B5 Mc3Jq6zr45wJK+9p7Zd8kxsV3WpEmoe0vgZE6Zh+X4xjA+j6uBXwWhc+w7Gv3r+Q1EUJMn3QhtB TvDmBiKsPevOE9EWv1yVMNhAwz6XwlETVprq+0KqL8URcBBowCT9W7GpziB028tHEw6Odn0uqOX SowxrrIT/sT7OPw== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788778249171158500 ControlService requires a non-NULL lpServiceStatus parameter ([out] vs [out, optional]). Passing NULL is undefined behavior per MSDN and can crash on some Windows versions. Fixes: 917ebcb17027 ("qga-win: Fix QGA VSS Provider service stop failure") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Kostiantyn Kostiuk --- qga/vss-win32/install.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp index 5b7a8e9bc529..f89658d277e9 100644 --- a/qga/vss-win32/install.cpp +++ b/qga/vss-win32/install.cpp @@ -572,6 +572,7 @@ namespace _com_util /* Stop QGA VSS provider service using Winsvc API */ STDAPI StopService(void) { + SERVICE_STATUS status; qga_debug_begin; =20 HRESULT hr =3D S_OK; @@ -590,7 +591,7 @@ STDAPI StopService(void) hr =3D E_FAIL; goto out; } - if (!(ControlService(service, SERVICE_CONTROL_STOP, NULL))) { + if (!(ControlService(service, SERVICE_CONTROL_STOP, &status))) { errmsg(E_FAIL, "Failed to stop service"); hr =3D E_FAIL; } --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:01:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788778327; cv=none; d=zohomail.com; s=zohoarc; b=agCbUxfmy2ooAlZ8za2Mu8Fl4oVdg/Tm5GCKH5o6UARnVZ0pgRmWSTX/doC5HaIvCh64QvWYmOzlyYc4HsVPMwbEsVHdcLDppdJd/kC+mcmuw58Jvt+WTvEwx8vyujWqBG52De5qMMWhAjbzJ7O9f4hyEyJljPCbb4V4Qn3GBik= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788778327; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=zyDsh9SevbYPGzB/boZkuul1T2heGOdmaDahaKqiWZI=; b=gwURQ+tI7LGPiT+QGsW5gksEdStJOlXbuGH8kFitznGniszBB2CHGjyf1my36bZCNuRGuH3Hl9W1iDjxkddeXB0dfXUSKco2ANZMq28TOdj25jnI4mzVrUb2LB/nEVZvQ2cle9Fl88mpRfVH4TqiQwSU8tlsjDHtmEY5sgnCyAk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788778327778937.2306008402713; Mon, 7 Sep 2026 03:52:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x3Wvs-0007Sg-8j; Mon, 07 Sep 2026 06:50:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3Wvl-0007Qw-MR for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:50:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3Wvk-0007yf-6R for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:50:29 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-662-4NcIJlNBOQiDX6fOEVF6Uw-1; Mon, 07 Sep 2026 06:50:23 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 874F81801363; Mon, 7 Sep 2026 10:50:22 +0000 (UTC) Received: from localhost (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9CEFF1800598; Mon, 7 Sep 2026 10:50:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788778226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zyDsh9SevbYPGzB/boZkuul1T2heGOdmaDahaKqiWZI=; b=QqZG6AjwvdxjZ5pr2f4sLAXhTy/kwwizs4E8TsyhsrelPguYDuxhC4TXoFEMySm3Aocewf ecjiefJYxe7j3fjXk3QLRFVaX82K3snGsiqUaswZrzRa1cE0NXPq3/GxpD3AgDFyonu78c uJP+mN43zbRy2tNWxoeWdiHY2NQyer8= X-MC-Unique: 4NcIJlNBOQiDX6fOEVF6Uw-1 X-Mimecast-MFC-AGG-ID: 4NcIJlNBOQiDX6fOEVF6Uw_1788778222 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 07 Sep 2026 14:50:02 +0400 Subject: [PATCH 04/17] qga/vss-win32: explicit NULL/zero initialization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-qga-v1-4-86456ad356e2@redhat.com> References: <20260907-qga-v1-0-86456ad356e2@redhat.com> In-Reply-To: <20260907-qga-v1-0-86456ad356e2@redhat.com> To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk , Michael Roth , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1371; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=ALhvlXO+1Llv2C3knfUSD228WJ0mqMnPVTvXeYx6N5U=; b=kA0DAAoB2ujhCXWWnOUByyZiAGqeluPIzxVLpvUAiTl32uxnsRGjPOAOIA4jYc8AFooh6ueeU IkCMwQAAQoAHRYhBIepvZM/h8YG0nb2Ldro4Ql1lpzlBQJqnpbjAAoJENro4Ql1lpzlbJEQAJIH AEp6tOWfagyZ/BHeWolqTBPPJ7KDHNCrzXERwjLXooxtxpYcvQLbnyHIIgb00qYX5Bif5wvxjo9 QI9XR36mfQn1m6D9YgNP7q13H+oS5IjwIxep5hshzv/icZe+FdDwow10IDlPacQb97UPhtHgm5O UaPBrocJ7gWS4sjAufuBnQADoLTwEqd6f2Xztcf7K7puxD1leZGveVLnHqstAcJU5BcKK9WTd7s 6ZkIp8n4Un9krcnDnmecZQ4UBQtm1rXqcCgL5V5etcZJowOqfng4OLDTqAsuDdWqg5jxULcQJ9W q0NG9Zp4Pag06DFbmGkJpTGmvpK1KL087Jy2i1b89kEHuDTRD+nB6c2uTwygeIUv+69UTL7mPt7 h43xJ8sIQxJeR98WGMB0tuFiYfcSxtzAMbP0cdV3RwPVh48t3IbUbPRwwMD549K9eC1NZptL+Di a0pAK6as1aAWc3gpfy0uyqyeayhBQImUid1kJwt6JFHMpxm2lMn2qrUCGDHvwl4cZfJKlxfv6lU 9JCPLVS/gog86dahm1e/dej6o0wz4O9NRHb5GdZcEq0Y1gG5dhJtsKHDIuqNEIXycic+mKxL0vW 3Tu4bkbrpjLPYkAA+MvXqRZj36/v+mWGU16QOkhmYZqLxyJRkcR75P28wqDNh2nV+ULNXzY1yVy 8qHQI X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788778329344158500 We use -ftrivial-auto-var-init=3Dzero, but static analyzers don't.. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Kostiantyn Kostiuk --- qga/vss-win32/install.cpp | 2 +- qga/vss-win32/requester.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp index f89658d277e9..12b045e2074f 100644 --- a/qga/vss-win32/install.cpp +++ b/qga/vss-win32/install.cpp @@ -61,7 +61,7 @@ static void errmsg(DWORD err, const char *text) =20 static void errmsg_dialog(DWORD err, const char *text, const char *opt =3D= "") { - char *msg, buf[512]; + char *msg =3D NULL, buf[512] =3D ""; =20 FormatMessage(FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_IGNORE_INSER= TS, diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp index 493ecd57172a..52176d751274 100644 --- a/qga/vss-win32/requester.cpp +++ b/qga/vss-win32/requester.cpp @@ -170,7 +170,7 @@ static void AddComponents(ErrorSet *errset) unsigned int cComponents, c1, c2, j; COMPointer pMetadata; COMPointer pComponent; - PVSSCOMPONENTINFO info; + PVSSCOMPONENTINFO info =3D NULL; HRESULT hr; =20 hr =3D vss_ctx.pVssbc->GetWriterMetadataCount(&cWriters); --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:01:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788778310; cv=none; d=zohomail.com; s=zohoarc; b=PwBj/QtEQvzvytcYXYcSODy6xzt2qOZ1VLyrYCeIsIQEVm+nmE9pOAghrgA94CX1y+jTOkt8wqPp9ATeAWnyuikLMruUDX8V3aJBoaaVeEueTYDLD7O6cQFaFhJ0rz/0aCxZi+xwfu0bxSnyaFF4BbQdbZPPQVRt5DuEYGDboCU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788778310; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Toh31Rw69egT0854wqDAVm+yhGtWA8fsAJaccWZ25cQ=; b=EDLRZ6iwV5ZMQxtRnfHgLzO19NnapIu25bWOd5+aiGf7xCszJJ9BQop/fzZj5YPoqgt1eOQW4s28wRcawhLMvmbESUB6Ei0lK++zCB0Uver2/v7WZhTMYUgTLujILziwMLhkf7p4ekrhZ7EE4PgozqOgT1XruvW+6OTkhyPitlU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788778310060710.6445233111806; Mon, 7 Sep 2026 03:51:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x3Wvs-0007Sl-Qi; Mon, 07 Sep 2026 06:50:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3Wvm-0007Qx-6Q for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:50:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3Wvk-0007yp-De for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:50:29 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-175-ZbSaJ2kFOF6fVB-AFmJPQA-1; Mon, 07 Sep 2026 06:50:26 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A29CC1828B0A; Mon, 7 Sep 2026 10:50:25 +0000 (UTC) Received: from localhost (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D95621800765; Mon, 7 Sep 2026 10:50:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788778227; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Toh31Rw69egT0854wqDAVm+yhGtWA8fsAJaccWZ25cQ=; b=GKYNfJz7hFJ30cUABpGL6LjjxZ6Fq0N/CqAmfvLIsAVEes+tLrL9RiMRis6PfFOFfjKEEs JKZmMWkN/pa24jO5ISgLkiSqmGvBpQzDmlFs0lCVbZN1QhyiXUwQVGrjl4GAKGBWt9DxCD clbFgOMxrlcniTu4uoxqwUMbOKPL+HM= X-MC-Unique: ZbSaJ2kFOF6fVB-AFmJPQA-1 X-Mimecast-MFC-AGG-ID: ZbSaJ2kFOF6fVB-AFmJPQA_1788778225 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 07 Sep 2026 14:50:03 +0400 Subject: [PATCH 05/17] qga/vss-win32: free bstrWriterName in outer writer loop MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-qga-v1-5-86456ad356e2@redhat.com> References: <20260907-qga-v1-0-86456ad356e2@redhat.com> In-Reply-To: <20260907-qga-v1-0-86456ad356e2@redhat.com> To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk , Michael Roth , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1269; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=qsyeB9WMifPywy5eAWsirxV4WtfDe5THehX8modYEYM=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnpbjuUEueVIE0FsNU91fgdXZBLlgx6Ue/4QvG 1qyBlH4BZKJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap6W4wAKCRDa6OEJdZac 5fL/EACIQ414v5NXL8BZIqZxT1TOJA2YjjRRoNGEovtCnxjG8Roxz+Fw+g+7lc5No/Qxhs89E3K G19nECATKFOOtep3fztvpNL2KngoE+b6Uf1QKBGWl3XmKeiqAB+W5YAAnd94LCPQCuXIshjOgZZ lUHV3zs49ADpqY388KRbdkBrYSXyoPrYFE32iJIt357VOEyfE5s2otKvS3KyugOyioE998CtPrB v8q1WUCtNN4U6Vxb6ksVBhHGc8ZHnMeDvwsEBTvDlJGViGeVp7WCGBHQ+IWlUZBSpLXfQVNcYBI sWxSJin4u/qXP6aKyyjbkKct3PqHvjFEGlgmULbNhuSmTFy1TSQvOic9bkfTPu0t+Lafb11iMaz UYU7Wz59XBWbEHt3R9XfDJ6pOOXQq8MXs5p7ekVRS9/HDfALDuwpc7IViX0z6MuJMwTbJQd2+yN AxS4xD51tbE8M5S4kW/dnA9H7ziORCGV0JsbtPgO8BNjQ7OWb1s2PrXgeivtpsjOmB8oGocvNci Bhf1Ks5m+MY0TNJsxzIWdKLJPPrkfRtnlqJwL65sciGUUZT338Du3mlABJmdVNlud16sekyr6Ov lg+AYQ1e0+9DutkSZZXlnc2EMy6I9uxiBT1WAJmQ+hg9jLw8ghp4hD/IrzXjWO9CG86NeEe8rEx x5tyxR4+42TGuQA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788778311438158500 bstrWriterName is obtained from GetIdentity in the outer writer loop, but freed inside the inner component loop. When a writer has multiple components, the second and subsequent iterations operate with a NULL bstrWriterName. If an error occurs in those iterations, the error message passes NULL Move SysFreeString(bstrWriterName) to the end of the outer loop where it belongs. Fixes: b39297aedfab ("qemu-ga: Add Windows VSS provider and requester as DL= L") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Kostiantyn Kostiuk --- qga/vss-win32/requester.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp index 52176d751274..b9269acb5b8e 100644 --- a/qga/vss-win32/requester.cpp +++ b/qga/vss-win32/requester.cpp @@ -230,11 +230,11 @@ static void AddComponents(ErrorSet *errset) goto out; } } - SysFreeString(bstrWriterName); - bstrWriterName =3D NULL; pComponent->FreeComponentInfo(info); info =3D NULL; } + SysFreeString(bstrWriterName); + bstrWriterName =3D NULL; } out: if (bstrWriterName) { --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:01:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788778347; cv=none; d=zohomail.com; s=zohoarc; b=GdaMV+KM5cfE59NHyEs/F7AKaHiqynHun+wuTPjKoRP/Pms2NU4NBB1UfCupdKO/cuIvuHmpZoApnAngS1jw8ejhPUmrlhZ3TmpgCyNpeo1ogSkcjsE62iGqCVca30yUAXMgGngoPBGrIFSwOBy8GC6o1Bm7j3vBI2N5fFjalJE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788778347; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=qBkpBlDF1/WyOSTwBP3AO4eRPfM8j2PH9gxozKjXdJ0=; b=gcdE/02w+ACzIdWRdrYzHgIzqqUjtNyfNqixRU47dqwCp7MACte41CNp7kPQY7T2MbVoEQWWsXVib3efesGmK654BCd6zZU7HSLcOxeK9ZMA9sTPvOIdXxa0CiKuoAFPUCiwoaHpHXT88OZWUK22nDWJxIwULkF9xqNoADEHljM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788778347990754.7526887902792; Mon, 7 Sep 2026 03:52:27 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x3Wvr-0007SI-O8; Mon, 07 Sep 2026 06:50:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3Wvp-0007Ri-Er for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:50:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3Wvn-0007zV-V2 for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:50:33 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-25-Zl8_28IPOoCDgFUzZW_7vg-1; Mon, 07 Sep 2026 06:50:30 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5B15019541BF; Mon, 7 Sep 2026 10:50:29 +0000 (UTC) Received: from localhost (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8F70618005AC; Mon, 7 Sep 2026 10:50:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788778231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qBkpBlDF1/WyOSTwBP3AO4eRPfM8j2PH9gxozKjXdJ0=; b=GLosgvepDVJxkc6eg09rj3Q3D4cziYf3VeNx6qDbnr9BIVgjXbhRrzZ5YlzKfjXQK6Qu5h /tJXxcVlIIZFcEC7JCwVHSoZV475CLRAtejAg38HL5nFZ1LhBwJJ3Uan/z45d1AVFEtfRG m5HtKVYOecX9cNYn9OYzhlidc4pD3GA= X-MC-Unique: Zl8_28IPOoCDgFUzZW_7vg-1 X-Mimecast-MFC-AGG-ID: Zl8_28IPOoCDgFUzZW_7vg_1788778229 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 07 Sep 2026 14:50:04 +0400 Subject: [PATCH 06/17] qga/vss-win32: pass character count instead of byte count to volume APIs MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-qga-v1-6-86456ad356e2@redhat.com> References: <20260907-qga-v1-0-86456ad356e2@redhat.com> In-Reply-To: <20260907-qga-v1-0-86456ad356e2@redhat.com> To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk , Michael Roth , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=2051; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=ZD0/7tpVdeRuw6ZXemEgNAdRCybVIjmkKDSXJhLrI0Q=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnpbjYMmCGLX/nEwP/XJDyUJXGPhIxa3w61Prt LsK/Xc2e4aJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap6W4wAKCRDa6OEJdZac 5e1RD/9GiTN1hfQDLO/Dpbz8S4ygbxF0lRyk6Gn8q1t494WujAElNqcRqmzI7WTDgGqUsULhw8t LTc7El5cRco6eHGWCyopQiVstvu9ecuj8wASqh6C7xCfNEh8F8N5Q31zrVwct1nqu52sf+9jNq8 /a9+Jl68OorasL7KICrx0Y5glT4BSnsD6DlktxZ+bR9pvyJ9ICYMKLAFPk/kpC7iyMDV0s9aWlh VBGZrQOuxm1K0bVCLIkd6llE3q1lMBPRLYdQWWWZ3FVEmiFM+fu7CZIDqw9ORlDZPL1WZ0QFD66 Ir5W8/UC3C4T9grHt7DcTAe8v4XF3zbXCUbMRqxxVH4nWxRTf39c/TMcdumS2qdgCB02Cm5EaiB P3lpJSOzYGhzSh8lNnl1sYS0cHFp41J3m6EtTjDzO1QMs1ZeBL5Uqp4hdbDdVzNnveG9WX7IHW/ vKZn4E4J/bhY1TiqWVe5xbsPAAcb+ACRa3mh2L9Wc+UpaOvXIh2TLu4RfjwAPedmHrpsyn7eqBF LkAfpcAmW3drWIophPl2a9Ac3OE1cjzx9kv8fpHf1QQXpQ9LrUm9RPUztR1/Fhl2Xo4p0IiKRL6 uzprMUtr2ZuXJ91mc9tlr4SRvJIbcYIfUeL3W1yCne3qy+D68kFQmOKJaNMu6anrBAnt8Rkx9hl +xW55Z07peTIaQQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788778349482158500 FindFirstVolumeW, FindNextVolumeW and GetVolumePathNamesForVolumeNameW expect a buffer length in characters, not bytes. Use ARRAYSIZE() to pass the correct character count. Fixes: b39297aedfab ("qemu-ga: Add Windows VSS provider and requester as DL= L") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Kostiantyn Kostiuk --- qga/vss-win32/requester.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp index b9269acb5b8e..1fd73312bab2 100644 --- a/qga/vss-win32/requester.cpp +++ b/qga/vss-win32/requester.cpp @@ -432,7 +432,7 @@ void requester_freeze(int *num_vols, void *mountpoints,= ErrorSet *errset) } =20 if (!mountpoints) { - volume =3D FindFirstVolumeW(short_volume_name, sizeof(short_volume= _name)); + volume =3D FindFirstVolumeW(short_volume_name, ARRAYSIZE(short_vol= ume_name)); if (volume =3D=3D INVALID_HANDLE_VALUE) { err_set(errset, hr, "failed to find first volume"); goto out; @@ -447,7 +447,7 @@ void requester_freeze(int *num_vols, void *mountpoints,= ErrorSet *errset) WCHAR volume_path_name[MAX_PATH]; if (GetVolumePathNamesForVolumeNameW( short_volume_name, volume_path_name, - sizeof(volume_path_name), NULL) && + ARRAYSIZE(volume_path_name), NULL) && *volume_path_name) { display_name =3D volume_path_name; } @@ -459,7 +459,7 @@ void requester_freeze(int *num_vols, void *mountpoints,= ErrorSet *errset) num_fixed_drives++; } if (!FindNextVolumeW(volume, short_volume_name, - sizeof(short_volume_name))) { + ARRAYSIZE(short_volume_name))) { FindVolumeClose(volume); break; } --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:01:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788778338; cv=none; d=zohomail.com; s=zohoarc; b=UE8VV2vmOHL46s0WdQrX16YdDAZkRR8BDJuJmAX+BZ8XRYtQUTq0peujNQQS1FqN0OsnujvoQQfopU8g2Q6yGl6ixdOK5xZ2SMHYu+L7jbF9XdBMCSfxnqbXlImn34jdeR9O9dWvCPaUyiWLrXHgHH12t4A+gvbyOapDmyhKrIg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788778338; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=fDPaDZ31rXmHOi4fEYTXZA0sNPkfrX0n1+as2Wbnawc=; b=kdfzAiFvoZV7H0CMj88+B0t1dqoTuDnJIMk2uWrzW3gnJodFBHnAqFBku6zwQlRchbx5EoUfPeI2JsUwympzayiXecDKYk6r8FxCyh82KJmiw74v3/5DlEr3f7nAbii+Va/22pl9qrJOelqc5yUYGkwZmkOmjdavRr5xUCWSrBs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788778338386167.21800644375378; Mon, 7 Sep 2026 03:52:18 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x3Wvu-0007TR-J3; Mon, 07 Sep 2026 06:50:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3Wvs-0007Sq-Tj for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:50:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3Wvr-0007zu-F8 for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:50:36 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-347-I6jBpeCiP4KItiagv0kGXA-1; Mon, 07 Sep 2026 06:50:33 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9DC1F195399F; Mon, 7 Sep 2026 10:50:32 +0000 (UTC) Received: from localhost (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9D57A1800598; Mon, 7 Sep 2026 10:50:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788778234; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fDPaDZ31rXmHOi4fEYTXZA0sNPkfrX0n1+as2Wbnawc=; b=JQQg/RSPcgVSoOikd8zOM91fPy5nBTAm07805/r5+qV1OQJZyzy7a7LrcneUoMFpcUUlaW s+gnSphMm6CDAsS31i6zAjWAKKPEhO4ycZVwWMIV1zZonkqUKpXDVtQuIwR4HrS2KqeAHC GwAZgO8XtqrIVmiG7ZbYbVMDrg8DAEI= X-MC-Unique: I6jBpeCiP4KItiagv0kGXA-1 X-Mimecast-MFC-AGG-ID: I6jBpeCiP4KItiagv0kGXA_1788778232 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 07 Sep 2026 14:50:05 +0400 Subject: [PATCH 07/17] qga/vss-win32: allow pceltFetched==NULL in IEnumObject::Next MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-qga-v1-7-86456ad356e2@redhat.com> References: <20260907-qga-v1-0-86456ad356e2@redhat.com> In-Reply-To: <20260907-qga-v1-0-86456ad356e2@redhat.com> To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk , Michael Roth , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=888; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=sE3uIFGnEo4hDRu1e/HgY1dit7ftoN+pRaba1ze+UZY=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnpbjatGdmfNhg8dk8K+UsOmg89Aryca2kLT6E JnW0Xm5loqJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap6W4wAKCRDa6OEJdZac 5TchD/4luzFxN/sMu0OndOhwyl4bMDDFV0owffYYZMOuJUojhXtOsu9N/+Nm68dxw11NxMazG25 +Ke/0Kx1FgrzEwvCgqI1YlGqUhlN6QxNb8CR//cKwRwDcMm0C0TZL7pDKIc75OLC8Yg5DSWmtKj b15EJOvp7tDgWKIR+hMxr/TK6+/3N8PSGyOoNoZCGdI/mBpeeM9zJS1ByPuCHyu2sil4tuszD5Y QnP4/5GGu3xmqf1Pj44x2KHmKySLy54oVdfq/7QLKibMP86hqucrAZI2VyHBgSwwCRZPEbrZxCE mLYow+nYnHNjNTaav6YnQfduqDo+yAuXNffKqI8MVBgIgsOL/o+wzZ11SlPEi8fiH0lLPsS6WRz OD28HDmtTpLsbbDF0Jv0aOuPzajIoIBe062HHgrDUy8ISnzX39hX8IGfohquvatvGuPxtyHIOTk GBDH6wMcmtSXNI9sp55R31PQv3esNu9X0BY7jrEhasDb68zRAXfkgCo5hPMAWRDoyU1Yvp7v1Q0 nqWXwBVjiFUiCvbD+sk5bF6beLp9R12PSOhjmAelibYuHfdAjzmpaOlMNoTB9PRqHhxi0j5YPW4 dJksjfJYEQnHzrDRkZ47w0h4GTiHxzVeW/JiritNX6mm4TxTZXPY9zT7QS6BhHezC9uYWOWnFhp KTVbvWVGWGsF3gQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788778342518154100 The COM IEnumXxx/IEnumUnknown::Next API allows callers to pass NULL for pceltFetched when celt is 1. Guard the write to prevent crashing. Fixes: b39297aedfab ("qemu-ga: Add Windows VSS provider and requester as DL= L") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Kostiantyn Kostiuk --- qga/vss-win32/provider.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qga/vss-win32/provider.cpp b/qga/vss-win32/provider.cpp index 79906dcc24ae..377571b94881 100644 --- a/qga/vss-win32/provider.cpp +++ b/qga/vss-win32/provider.cpp @@ -117,7 +117,9 @@ STDMETHODIMP_(ULONG) CQGAVSSEnumObject::Release() STDMETHODIMP CQGAVSSEnumObject::Next( ULONG celt, VSS_OBJECT_PROP *rgelt, ULONG *pceltFetched) { - *pceltFetched =3D 0; + if (pceltFetched) { + *pceltFetched =3D 0; + } return S_FALSE; } =20 --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:01:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788778306; cv=none; d=zohomail.com; s=zohoarc; b=PDDrR3WXDiXvQD0Mpg4SaKBMAfLVTraBZHBNlDiOgXScsG5lhnbHx3H+SuhgbDiTx9U2meOxfgfDOgD7RAm0R55VQAyrXbtOThNZbGbizPm/i5u0tKBNAON7lMV5PcR+IC/Zw9ni5Tzw0BclVRGyI0kBsN/pyRo3B0f3Or7x37I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788778306; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9SDEgsKrneUTjzP9rpa9htRqpgtiaPsTwDGZ0OeRxWY=; b=Xvkz7T1ThHS1j/iI/yvot40jbVvtL/s1mkNjZCCgbV6YNOmiju9LdbrItywSU2UjtEId4IK2wsf1EVURJrJ3wS+rgvL3GD407zkDCBVLqjARcENB2iaYdc013tBgvntHD0/k1T1h5Qd6Q3rR6vdKJrofFBQ5cwtiCeE/vJ59xZ0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788778306470677.0918968482073; Mon, 7 Sep 2026 03:51:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x3Ww6-0007b3-DL; Mon, 07 Sep 2026 06:50:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3Wvx-0007VL-KE for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:50:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3Wvv-00080L-Rd for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:50:41 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-668-eecZnx3wM7Ct-G-HQCo7Vw-1; Mon, 07 Sep 2026 06:50:38 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 189711954AE4; Mon, 7 Sep 2026 10:50:37 +0000 (UTC) Received: from localhost (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 199F83000223; Mon, 7 Sep 2026 10:50:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788778239; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9SDEgsKrneUTjzP9rpa9htRqpgtiaPsTwDGZ0OeRxWY=; b=J9j4SItHNNVVQWtn6JlpwHCJI8B/Mo7Es3N/ytSdYI68fNGOqA4IFCs4Mbnu3HRUYIxh3o bUdOEAM34tk0gOpRj2ocyX40s7v5LJbENfkDKK37rFKDVtGxFJj9RlevEtMCBji+R2xhdS iBAE1tczMLiQm4Tbetx1jQEqaI9X+sw= X-MC-Unique: eecZnx3wM7Ct-G-HQCo7Vw-1 X-Mimecast-MFC-AGG-ID: eecZnx3wM7Ct-G-HQCo7Vw_1788778237 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 07 Sep 2026 14:50:06 +0400 Subject: [PATCH 08/17] qga/vss-win32: return an interface pointer for IID_IUnknown MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-qga-v1-8-86456ad356e2@redhat.com> References: <20260907-qga-v1-0-86456ad356e2@redhat.com> In-Reply-To: <20260907-qga-v1-0-86456ad356e2@redhat.com> To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk , Michael Roth , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1119; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=0aYrIKGtm/kXJExFjJ3h2ZPtuJa9+ErLTo3d1cGeSh4=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnpbjLM2ZhsRJt+kJhNTMBEpWXcMYeujqLSC6O iMD34dh02aJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap6W4wAKCRDa6OEJdZac 5dx+D/4qHdXewMfi51+VmxXyYXeZzUgQNkTLcW/7fDJ2e1ImQlVSlPCCY3qlVXUWqwOFVevNVCQ pzLUTtcioFuz1jxcKi5bwOS3iQ6W64/BxavvvXZkFXeYxzpudXkDXAxeO4FufU8MdA2WI+FoJoV qq3ZjxnusCKoM87SozkZgCc5m5JXM9h+W955ViJEe6Du6oDDPvHbh76dCnT4RLj25iRaPewPhvp FlWb3yCER9HbFPQn2/ogfjW7P5ptW5sLcoXUN+8wDcEm2lSKqiUBLZigkxsrGoyRNOcsQKLU8O+ g0Kkrfwh1duf1vvQzybsS7bvCqOAlw1c7uxT52al3/5+7OjMa9lfZGQq7C4nvnw0lu+JYO+3L08 pwTp/K0V0quEVzN+2vsm0JV3GlSaHJFAl1LpubAM1XwAOYZIMYUQgwXOhmEk3WheeVaJqwZb2NB rsjCrd7yUSVJ1Rsf/mM09mxDv9tHxLZ3mzr1ypdZumKVXEcB8MsoLNjL20crikclgDGsHGyTiMH 21SwE0nEtyNYOckOm3wd9qc9NVCbsRe4SNTfHquzHlNzqyWzIeO3WL5f4I/qiYSbkI4UFDhR54h 1n+VLckGn+J8ULM7Xi4AdgPhld1McBxMh/qkCv0hBe3+MQ9mCIrX1VYtKCHXittde/p+a4Eq3cN 9J8IX0n0Kdb25Zg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788778309419158500 CQGAVssProvider implements three COM interfaces, each with its own IUnknown base subobject. Returning the complete object address for IID_IUnknown relies on IVssSoftwareSnapshotProvider remaining the first base class. Return the IVssSoftwareSnapshotProvider subobject instead. This selects the canonical IUnknown identity without relying on the complete-object layout. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Kostiantyn Kostiuk --- qga/vss-win32/provider.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qga/vss-win32/provider.cpp b/qga/vss-win32/provider.cpp index 377571b94881..44c3c74bd2f2 100644 --- a/qga/vss-win32/provider.cpp +++ b/qga/vss-win32/provider.cpp @@ -212,7 +212,8 @@ CQGAVssProvider::~CQGAVssProvider() STDMETHODIMP CQGAVssProvider::QueryInterface(REFIID riid, void **ppObj) { if (riid =3D=3D IID_IUnknown) { - *ppObj =3D static_cast(this); + *ppObj =3D static_cast( + static_cast(this)); AddRef(); return S_OK; } --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:01:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788778285; cv=none; d=zohomail.com; s=zohoarc; b=i0Sp1qYC9X48wDJbZTLEpV+m4c+mzooWOekbiULgbexx88jYDct1l6fxSQ18/ZHiIP/ZN6SCVENw0Pv22oU4PpuVbapgbNtODSLVjNodxs9N6ee3LoUlcwOAYTCtysk+zLIXrpuaO5y6pw+jPuS1QFdiMgtgZUb10WFJN6VHMRM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788778285; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=yIsDQ7SF4Y5V/f7VhC/dfF80nAzeJReiUN4a4Q0MiRU=; b=mJfYB/8scbXYcKEJOjnDBgOK9WqSipGdvU8yfyvJo0G5pDZqoo32K2VfxB6foKwFhxfNYpwvwxzn98yMNFCmURrnyE5+jFYyqptAt3UlPGu2FdMA0/JT9zpUqosM1wJVuGaWv5KgNF5jDBI7jqh42vItldExFgXZPfwx6Fmtfkw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788778285020674.7679975054128; Mon, 7 Sep 2026 03:51:25 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x3WwB-0007hz-99; Mon, 07 Sep 2026 06:50:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3Ww2-0007bR-QO for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:50:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3Ww1-00081A-CX for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:50:46 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-479-0IyGKdFZMXupR1ZI3IPoLw-1; Mon, 07 Sep 2026 06:50:41 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5E9911944B3D; Mon, 7 Sep 2026 10:50:40 +0000 (UTC) Received: from localhost (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 65FF5427; Mon, 7 Sep 2026 10:50:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788778244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yIsDQ7SF4Y5V/f7VhC/dfF80nAzeJReiUN4a4Q0MiRU=; b=OoqAwDEIDbkOdO0pLQ0riQX0pYvaqPubYL9DFyDbEe5Me6P7F+1GJWSKLdX/2y6zrX/y01 57hjGYZFar2TLaWtXFVu2ju9S/K/pmK64aRsQkpy9jSPTqwqp3AB9jV9uuJ2xnro5HYRVy J8rNG2DqWy3HmJAecHkiDlMepfbyCL4= X-MC-Unique: 0IyGKdFZMXupR1ZI3IPoLw-1 X-Mimecast-MFC-AGG-ID: 0IyGKdFZMXupR1ZI3IPoLw_1788778240 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 07 Sep 2026 14:50:07 +0400 Subject: [PATCH 09/17] qga/vss-win32: use GetLastError() after FindFirstVolumeW failure MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-qga-v1-9-86456ad356e2@redhat.com> References: <20260907-qga-v1-0-86456ad356e2@redhat.com> In-Reply-To: <20260907-qga-v1-0-86456ad356e2@redhat.com> To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk , Michael Roth , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1094; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=LzkJ1faH8qS1b7Va7YhYWJzWvojAW35layjF1nwooOg=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnpbjZR5JjNXdbELL6MgPCE7oq1V1xOtaG5xS2 NQDFAoVQMqJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap6W4wAKCRDa6OEJdZac 5UNND/48jmkjO4iDiCjQu+kJDzDndPvrPjr5jBmqkaFJoORf4AEHGAhR6MuwWW/+jmmXmJ50uKc 71p+uylRXKweYPIc93dA3f5kewCChz1Hlk7ce5/dml4r9c7M1owpAzaxhRb9+QcGW2XJ+UHQwGF oOaDC/s6xwU8dvKgWi1xEXd1TDgY8xGLqu2+8Cc1/hE205hbIxxNrMpstw2AeSR8QRVMnscp8OR A0uXTT9Ykc3EWdROfHyl6jEP+pHNKvkUKJh/TIjyPad+ZQgigqJYJ8/r/W24mowu8YecSN7egiH RXf/6lmjBkDn6/SCrNT0qo0rN8sGgrwQz1NF/KszXF8BnnhtqDntwkoHMOKrgbL9v9DrC+lOTUI 8lnDuyUfzNSaPE5HHxlC2Zh3PBjXi6iie++VFeWc5vcqNG0ErM0Ay4/Kgc7oCLtB+svshYwodpm C1uFQHeU1BPwpQS5cZ8GdzR9PlBg0B1Lt6h/RlQFSsNZJTcL6YRkyFJKA1gVNpfiimG0faYOd6E nXYRVZTXALx3SZPEh2drwsVUsm2Zh+RruUFW528Ju/kCJIs+rTP9nKmcss4cHX7n/pe3cHYV8PI +FcY3ZZuBc/Xvo2ZAC5R2XvQ2iXEGdEG1ltfRtsopaWXtDh0GsRYvDR3SMAM6cMfI2C/8isCltd cLxYNbWxW7tD47w== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788778287127158500 When FindFirstVolumeW fails, the error was reported using a stale HRESULT from a prior SetContext call instead of the actual Windows error. Use GetLastError() to report the correct failure reason. Fixes: 0692b03ee135 ("qga-win: add support for qmp_guest_fsfreeze_freeze_li= st") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Kostiantyn Kostiuk --- qga/vss-win32/requester.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp index 1fd73312bab2..d7907c230656 100644 --- a/qga/vss-win32/requester.cpp +++ b/qga/vss-win32/requester.cpp @@ -434,7 +434,7 @@ void requester_freeze(int *num_vols, void *mountpoints,= ErrorSet *errset) if (!mountpoints) { volume =3D FindFirstVolumeW(short_volume_name, ARRAYSIZE(short_vol= ume_name)); if (volume =3D=3D INVALID_HANDLE_VALUE) { - err_set(errset, hr, "failed to find first volume"); + err_set(errset, GetLastError(), "failed to find first volume"); goto out; } =20 --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:01:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788778258; cv=none; d=zohomail.com; s=zohoarc; b=luQhH8+tyoZFhS81J50vJOAEhwOUhkoDHsK+L7WVt00dvdkC1DF9dhvJMFxyo9EuiFp7Q5U/qgYRjL7/OyMDDeax4G6uJ6CXDnD/GYBJJPzO7gyHgaoqU+rpp84UvFCrYRPHNCiVyw9U37xfoZz4t6IMnGHWkaMzN4/0paBWhBM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788778258; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=N5XLuA/DaZ16/oHm1JbndQR+5uaembUXJMCN9FVfTk8=; b=ZRgA3MtuHL1OEzgnAKmVuR5H1zrcuEbL6hvNM6VHSJQVQaGtzyPz2le8IioyAoH0kFCVMomjF7Vy+2BW7Me7IEWXWBgWOJVOCSQjiT1Mrw4aEIh3KiQM05VgNnBc5oEDJR5/xlL09meqjzgy6WYW8E2zHybk8VtEPBXUyJWLx5o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788778258619204.71175875639676; Mon, 7 Sep 2026 03:50:58 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x3WwC-0007le-B3; Mon, 07 Sep 2026 06:50:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3Ww6-0007dt-Dw for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:50:50 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3Ww4-00081k-Ok for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:50:50 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-217-xWt9yh3gOTWOttp3J4cyoQ-1; Mon, 07 Sep 2026 06:50:44 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E9FC319541A0; Mon, 7 Sep 2026 10:50:43 +0000 (UTC) Received: from localhost (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 22A2A1800257; Mon, 7 Sep 2026 10:50:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788778248; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N5XLuA/DaZ16/oHm1JbndQR+5uaembUXJMCN9FVfTk8=; b=KAKfHHWTwm6wh+ct1JhLxkdkeYVSc7a7mamdLbK7s/UF/2YFl6pXx/WIADZUNf6InzHvpd vU7bklEbpQgcsXpkkM36t/VYkpNSznLQVXCHjlDcc/cPb75JAjxcKTbgGKaS64a/p0/rgD doEfYIN4Mw1OvW8bWhoCG2BhWTyArTw= X-MC-Unique: xWt9yh3gOTWOttp3J4cyoQ-1 X-Mimecast-MFC-AGG-ID: xWt9yh3gOTWOttp3J4cyoQ_1788778244 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 07 Sep 2026 14:50:08 +0400 Subject: [PATCH 10/17] qga/vss-win32: guard CloseServiceHandle calls against NULL handles MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-qga-v1-10-86456ad356e2@redhat.com> References: <20260907-qga-v1-0-86456ad356e2@redhat.com> In-Reply-To: <20260907-qga-v1-0-86456ad356e2@redhat.com> To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk , Michael Roth , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=959; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=nIIKdQW59ljnqDumnnb7RBfT3LgkJf/UzhFaeYI2fNI=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnpbj7DTk1J0uVNJi0jy4YWbGISsKlQBhQ1Cxb xBbQIHLTY6JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap6W4wAKCRDa6OEJdZac 5ZF1D/4mDp7I1709CBhQCHy+kwpxksJoKmXvG09AsHSidA+yzYmMqvuJbQghxi4CCRcNetfNCW1 foA1qBs0cKGmQw+f07gSLLZLET8zcfq+JwxmuapdDL8GCCA/8loewvAWzwi8C8mop6DfZN7P1BC l3S2stDag3WIN1IyPhYvJuHJgoW2fMbrxUsEmIam+H3xG43nAuOnTacE97uPijlW22Iez/sXp2z 4qOYhNWLoqjWhHG6oHbIiapHSRGoscSC6QNkWgP4/AbpBC/A3rECTVH0D3fKST+OHPWdSgU07A9 9IVuLUa7XbcvUoan5RoVmMjE4BvE7z66U1UuCDvrGiZcliy1eOwRh/qIsl7SkhV/cnZ+x8kwqnd hZTX3P7d1b1FdEhK/kVS1SGwa0B5oxVVIL9Wd2L8N+VKoktuBaJUXY3nauateyC34l0ME21HqxR 6obD7V4plac0E7Mm0vEMyf0Kgd/eysLKlEnM28OGGdpF7vfLRO++6UPz0yXo5LdcNA/4NrkUJ61 lUxvYxtt998Nt2OD5dQlV3/t+oHXQlJwo1I0m/z1VyWUv4Gsfbpq+NNg1vRfGnAltKrQbY9r1Zt nEugRr7JbIWds20nrdMmYHZWBC12T+gclVDi8fgGGgIgsHA3gpBHlJlGVA60XTAb1GU9WLTenpq Z42wfBoaCkVAODg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788778258978158500 StopService() unconditionally calls CloseServiceHandle() on both the service and manager handles in the cleanup path, even when OpenSCManager() or OpenService() failed and the handles are NULL. Fixes: 917ebcb17027 ("qga-win: Fix QGA VSS Provider service stop failure") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Kostiantyn Kostiuk --- qga/vss-win32/install.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp index 12b045e2074f..9e8db79c122c 100644 --- a/qga/vss-win32/install.cpp +++ b/qga/vss-win32/install.cpp @@ -597,8 +597,12 @@ STDAPI StopService(void) } =20 out: - CloseServiceHandle(service); - CloseServiceHandle(manager); + if (service) { + CloseServiceHandle(service); + } + if (manager) { + CloseServiceHandle(manager); + } qga_debug_end; return hr; } --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:01:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788778293; cv=none; d=zohomail.com; s=zohoarc; b=YEwbhr6/S4g1Ho+JLfc4CkakUfcvoygv415th59cBjc5pS4pqsgJ5GnuTNi7nfEhs35dysbfExQmkBuwJFxiF/uY0FvqjOLATm1b33HZOwfUpsPOzO+4ysjMpR02/VcIZdoejgZFk2Rx2fYcg6jb26oezljsAaI0FWNiYB7D7A0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788778293; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ST0fyxzJrNhhEnLARHNRMF08O5d8Q0ORWVDRaq2tVSY=; b=Mvjo3lhRFKxlXVj3ifderH2xHACZzO4vuGUsIlZ7Ntx9I+Q8zHrTpP6mA5oHeeN7RdFUdq1nbcljdpob1e+rWUCdNrQxg783uTTtKqilRtTcge+XZa7XAs4K++Bm9sABCsYKEoHVc/nEWrOENiyAiaJkKA4iUx7I34q7jup/AhU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788778293314132.22220731712935; Mon, 7 Sep 2026 03:51:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x3WwD-0007oG-5L; Mon, 07 Sep 2026 06:50:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3Ww7-0007gI-Nt for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:50:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3Ww6-00081z-6D for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:50:51 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-150-aY9AYc7LOWq-lYKFlDuDqw-1; Mon, 07 Sep 2026 06:50:48 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2C8C218052C1; Mon, 7 Sep 2026 10:50:47 +0000 (UTC) Received: from localhost (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 321FE1800348; Mon, 7 Sep 2026 10:50:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788778249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ST0fyxzJrNhhEnLARHNRMF08O5d8Q0ORWVDRaq2tVSY=; b=gF5FP71A6DCXdWPMQD6gqktLZxxMCQTx6k/hpZ3L7TLkCmh45ULd/niP9cY9VsWHWfXb0J 8hry0Y2M3qHCqEiEAskptEaCHiz6ZX115c5m1R4hEvOV/Rh+6CGWUY9jlCtnAxlYH0Z6Fo 2WlvprEtuEmbJv8kzlEbC7X5eRbaiHI= X-MC-Unique: aY9AYc7LOWq-lYKFlDuDqw-1 X-Mimecast-MFC-AGG-ID: aY9AYc7LOWq-lYKFlDuDqw_1788778247 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 07 Sep 2026 14:50:09 +0400 Subject: [PATCH 11/17] qga/vss-win32: avoid CRT calls in DllMain debug logging MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-qga-v1-11-86456ad356e2@redhat.com> References: <20260907-qga-v1-0-86456ad356e2@redhat.com> In-Reply-To: <20260907-qga-v1-0-86456ad356e2@redhat.com> To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk , Michael Roth , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1198; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=64B+Bikb2SGpjZ5/w751HOhMYINM9fWlaj0840TMvBI=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnpbjxC8GjeDh8/r6d/kfMN2KBvl3mxko8n64f nxEfSWxhKWJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap6W4wAKCRDa6OEJdZac 5U9BD/0dkfDj1FXwJBiYzXvqbBiZUR9RIq+dDLYpkiwZrwj4HctrDlFkgAm8aAGWPqh3tcJnxFd kFzYxblfo0tqoMqm1R0swMfOQKI6VedoHiXZzpq8NzKDp455Qn2vKxGSww2UQxrJHeEdtnsvJ+8 036o65e87IvFvz+5yKOVz6Z32L1Z4dxXEYNVsb4ayFUklFtvW/qFulhIaNw9ckW4WjQbnAQgEi4 m4fmRYyOaQgnNd+K9U/UBDHKtZ17jQx6rm4Uv4tpzd3pYhH0mowFQvbq4D6oxgIya5XQ1PTl3/A LIo3+f5SIhabuRLZrirmlGaD6x8fpSzNg3Rstp/Ud5kP26OkE6b50JboSPcKTBeCVRQszcBzJzH ZlYIkn/NKGMXkzL5xYsNeqBP4GsokxtA5HFmq13WWb8LqY3/N4xgYMMxUTuObWKkE0E2QhEJaRb Rv+4jvakPyntPJSQVt9Z15acEB6D4xomAEBMPn+LubQTdz/k9uiaWDum7MARF9naGLC9wP+BsQ2 9ggyD3zvcLskGVLm/CfdaA1BoCqIAPjqqLp7gNGNDV9Ii7CsE2oymtALf73QZMcfNqGjuINqEPR jn500p42Iu2oS48nIkvXbiCmiUZy73EIVti/Zxgo3uGx45/ZfCMybReFX2owyDvRnnLwQI6RnTT yQ72g8ZlJa9Wupg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788778295856154100 qga_debug() uses vsnprintf, snprintf and fputs while DllMain holds the loader lock. CRT I/O can deadlock under the loader lock. Replace with direct OutputDebugStringA calls, which are safe to call from DllMain. Fixes: 61df91b33caf ("QGA VSS: Add log in functions begin/end") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Kostiantyn Kostiuk --- qga/vss-win32/provider.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qga/vss-win32/provider.cpp b/qga/vss-win32/provider.cpp index 44c3c74bd2f2..1c8eb236e57f 100644 --- a/qga/vss-win32/provider.cpp +++ b/qga/vss-win32/provider.cpp @@ -536,11 +536,11 @@ BOOL WINAPI DllMain(HINSTANCE hinstDll, DWORD dwReaso= n, LPVOID lpReserved); EXTERN_C BOOL WINAPI DllMain(HINSTANCE hinstDll, DWORD dwReason, LPVOID lpReserved) { - qga_debug("begin, reason =3D %lu", dwReason); + OutputDebugStringA(QGA_PROVIDER_NAME ": DllMain begin\n"); if (dwReason =3D=3D DLL_PROCESS_ATTACH) { g_hinstDll =3D hinstDll; DisableThreadLibraryCalls(hinstDll); } - qga_debug_end; + OutputDebugStringA(QGA_PROVIDER_NAME ": DllMain end\n"); return TRUE; } --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:01:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788778315; cv=none; d=zohomail.com; s=zohoarc; b=l1cDCGvxWgHUq3EFHxd0IxggKuILZxVhLMxOZ1ddtyzQxnHwc5ejhCB8XvHIYKSIz1jMidxsg1RiP+TKnIky4KqoNXiPYpI6wjqsyeOz4WZ8m42CS6f+A7GcZhtY/NjRYfZ1laeNu4audTHDJaOhcKULJN8W44mdYf4YBot1UQ0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788778315; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ZrExPs7bOq8tj4VvBwHFcJsTajfD4s909vC9Z8FOml8=; b=HbnKjJxopK0kEC8XG0Q1AhIdC29IsbUttUeLP7pWQc/y8tTsUoWdfWbyMz1lzJOINQbTRuiEJzMHoywb1RVzOEEq72EVezLWGuzYAcxpPswCl1B8Sp571vI83vQtyeyY3lHEggOQwpUKCOwsXwNP44cTvpSxTs8bi7ooA1IH2Tg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17887783153408.507196811654694; Mon, 7 Sep 2026 03:51:55 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x3WwE-0007r8-7Z; Mon, 07 Sep 2026 06:50:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3WwB-0007j2-Iq for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:50:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3WwA-000831-5g for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:50:55 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-369-55irehISPOafVjcoc2PZzg-1; Mon, 07 Sep 2026 06:50:52 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0343D19541BF; Mon, 7 Sep 2026 10:50:51 +0000 (UTC) Received: from localhost (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E4F761955F0E; Mon, 7 Sep 2026 10:50:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788778253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZrExPs7bOq8tj4VvBwHFcJsTajfD4s909vC9Z8FOml8=; b=ODWB15OZP6tL5CWiHlKAL8vHybv37MzGzfJW/+34bP3jeVXkjx0fHkiE7TaX7WwofRzEKb WRh35bzRviepeBMUcdfwYNJEGuhDdXyqPMZgWmloA908W3Ms1WPZ8K7RDOs9txED2wHdPH Pr0gAvY47GTb7RUUR748cYvevNW9COY= X-MC-Unique: 55irehISPOafVjcoc2PZzg-1 X-Mimecast-MFC-AGG-ID: 55irehISPOafVjcoc2PZzg_1788778251 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 07 Sep 2026 14:50:10 +0400 Subject: [PATCH 12/17] qga/vss-win32: evaluate err_set() macro argument only once MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-qga-v1-12-86456ad356e2@redhat.com> References: <20260907-qga-v1-0-86456ad356e2@redhat.com> In-Reply-To: <20260907-qga-v1-0-86456ad356e2@redhat.com> To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk , Michael Roth , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1633; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=F+avZ2Kt2HJKvLGVcPhZxW5Nm9d4tEv8XwcL+4zbh8Y=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnpbjruAJ9DkcspTsSbjWX0XH8DdNJwdNVW0Tt digUWPigbGJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap6W4wAKCRDa6OEJdZac 5cAbD/98Q1J0pzqC3Oj5iT60mL49jh/g+D3SOqJX3/nzAC1SSinPJZhpxdilsk3jaFyCGI7ANKn sKL/dCJCj59Y61N51ILStBooEDFUIpPDnJyIAsn0VM57pBnNZeWJfh6W4xClvKzgzvxe59B5Smu 9jaKt/PErL1kT3sCjbkVXfB3Kx6DF+wSB1vINKLUzdvVs9tqbskBV5nr5YJHKpTuz2ZzzPUUbCM f6Zkfv2dT9DTX9U8oKB86ngJqzHAQgDBvu2Bzqn5n6B9H4i01yNA5UUPJNmhLRVsr9fEhXLObQT wK7RyshQKpYKw+b43xk9MB55A3/yYA+Qj13Ga0cuZR3NgkApcbG+qi/lZ589IDYShs8LMShgyhp Fs165OJv/oA/QOSSVVUCmYEeVNouClASMEWBuhrKTeogXoherVt17pL0JnUDc4eGDBGaHU7+6tH LCzjHAmwtZgBcGcEu4gMoysLZctsnDun+O1tKp5oU/qPyoNbu1yH2X0vyyKMxr3XByAXYeZSzQ3 cAPNxools1VJ/b1QWya9kaio9WaN1rMeCZ3m0hmqIza1ZYtn6zTSJeEMby/QTGXgZkiiUqXTtFO vQr/AE0iF604MGbYwQ7aHAJz8Yl5ADCnvcD6UYIaffuHwGKmNDl0Dv4a1vVviV30rUH4CdTObed rZLQspHA+sTBuHg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788778317270158500 The err_set macro expands its 'err' parameter three times. When callers pass GetLastError(), the Win32 error code is fetched on each expansion and may change between evaluations, since the intervening function calls can reset the thread's last-error value. Capture the argument in a local DWORD once and reference that throughout the macro body. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Kostiantyn Kostiuk --- qga/vss-win32/requester.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp index d7907c230656..e3a15f83bf90 100644 --- a/qga/vss-win32/requester.cpp +++ b/qga/vss-win32/requester.cpp @@ -27,10 +27,11 @@ #define DEFAULT_VSS_BACKUP_TYPE VSS_BT_FULL =20 #define err_set(e, err, fmt, ...) { = \ + DWORD _e =3D (DWORD)(err); = \ (e)->error_setg_win32_wrapper((e)->errp, __FILE__, __LINE__, __func__,= \ - err, fmt ": Windows error 0x%lx", = \ - ## __VA_ARGS__, err); = \ - qga_debug(fmt ": Windows error 0x%lx", ## __VA_ARGS__, err); = \ + _e, fmt ": Windows error 0x%lx", = \ + ## __VA_ARGS__, _e); = \ + qga_debug(fmt ": Windows error 0x%lx", ## __VA_ARGS__, _e); = \ } /* Bad idea, works only when (e)->errp !=3D NULL: */ #define err_is_set(e) ((e)->errp && *(e)->errp) --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:01:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788778275; cv=none; d=zohomail.com; s=zohoarc; b=RXVLo5raFJgGvBkqM4w9wGolPRSghgX/yPZXpM0Y0EonoRHTBa1AOBfnc2uuPy9hczKWUXBo5OL/fqawAJUJUO1qxSkN9DwMj2GCb4i2G7xsU3G3j/YfIBDXzL6WLFuGARKVjjykqbuM1sCmoRv3ZVJ65VCKMQ7aj6i7bb6K9QY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788778275; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1tAvx3fmlomjyknVZ/2aqsXF2G4mK66HM/0sUPy2ung=; b=l/feT0Z1KNBkXBEMM2bwKb9gHExFGo9wuFe3x/inuX2rho5TgDBdrWCpAlbAfSCq1uKGhLjSp7UBnX83LCbs6SsCiCn8Mt0ul4Vqfo0tmrysxj3Hft53Os9JzuYS/kPm69PyD7DpK+hzx8MWSr/JzINhfvWs8sbhoegikZPG4y4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788778275870104.18736678798666; Mon, 7 Sep 2026 03:51:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x3WwK-0007yI-8b; Mon, 07 Sep 2026 06:51:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3WwI-0007uP-93 for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:51:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3WwF-00084G-0M for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:51:00 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-396-Jm5hikytMEuusSXGfXoplA-1; Mon, 07 Sep 2026 06:50:55 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3C18B19541AA; Mon, 7 Sep 2026 10:50:54 +0000 (UTC) Received: from localhost (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6932C1800348; Mon, 7 Sep 2026 10:50:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788778258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1tAvx3fmlomjyknVZ/2aqsXF2G4mK66HM/0sUPy2ung=; b=DFgDjPNmFcPMUJ9w97rYWX7K5uAzLqrheBH47+IacKyPSSbBHwFHWpdmPBrgODXN9rCbca VyWD14tebZ1honEU/bEGcMA68nJ01hijx09C/tGKuYo7fLRakHR+/DxD5EUFsfUnPb/EUn qJQSN9+yX/i39VZb2xsPzgm9LY7bm3g= X-MC-Unique: Jm5hikytMEuusSXGfXoplA-1 X-Mimecast-MFC-AGG-ID: Jm5hikytMEuusSXGfXoplA_1788778254 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 07 Sep 2026 14:50:11 +0400 Subject: [PATCH 13/17] qga/vss-win32: report QueryStatus return value on failure MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-qga-v1-13-86456ad356e2@redhat.com> References: <20260907-qga-v1-0-86456ad356e2@redhat.com> In-Reply-To: <20260907-qga-v1-0-86456ad356e2@redhat.com> To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk , Michael Roth , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1225; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=ZtWeh7L52SviWsbhYRcGSL4GUIIW3vpBmGQ7tNQKqWM=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnpbjnHvIdg1nqgR0wVFm/3md70K777Ky83lpJ RbhQBz7sGeJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap6W4wAKCRDa6OEJdZac 5XkFD/0emNTE+vkhDXNPesDaVWYW5cmvtPt6XXpfY44Nwc4s01YPnMHUvPiJxPFSBG9e7wxm1GH xMAfsOltpr/EaFBWN96uLSmt25LAnkyd87mV7/E89Avmn9jWfzmf1RGTVeubqoGvI/f9DD7XuVG DSYvIeqoDQ6q1AjfLf8kusZa+0A3HuXk30RBfkJx8q6qNg74t/xAmu545ox+65Ah/efwML5FvZd EN6Kylwrty6xK7x/JKEwPNh0I60EX1x6OciC+hsWKV/VyCNeB0A0NB3T3JSiHqSn6zXfragsSr9 037QxvghA8iFNWPS17wXRRPvwU/VsJkTpmvPkCE/O2JElkePCDY+EozTIYi3a4ECITU+IZombgS eS9r7+p4dG4Zl/GB8AMflS4ZH7yJYyKC8qHVljoyg/OH+c0oA4Rs3j5ArX348aXK47aaw5+TA3T zRpYPgXf9rgneEk3CkhTqplWIn9qh0vbKSjMoGbzZCf027eFZ2iMKb9ukHAiKiRruVRQa8e3PvB Nnr7PzRwt98FBAXSK/zv9aiSBUlvSS8U1fvi/PZ93SR/9nnuAxCecLLPO8i07D25zfjyg2NDT22 vkDp7str3b7uGz3ig3QBihz90bvbHBeTmCkPDmGXWPeGeyki0uMvONbh7+HZePoghZEDSJ+Ppda T8p6QB7GI1N9rsg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788778277126158501 When IVssAsync::QueryStatus fails, the error was reported using its output parameter `hr` rather than its return value `hr2`. Since the output parameter is not guaranteed to be written on failure, this could report a stale or uninitialized HRESULT, masking the actual error. Fixes: b39297aedfab ("qemu-ga: Add Windows VSS provider and requester as DL= L") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Kostiantyn Kostiuk --- qga/vss-win32/requester.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp index e3a15f83bf90..b3daa060ac01 100644 --- a/qga/vss-win32/requester.cpp +++ b/qga/vss-win32/requester.cpp @@ -506,7 +506,7 @@ void requester_freeze(int *num_vols, void *mountpoints,= ErrorSet *errset) for (i =3D 0; i < VSS_TIMEOUT_FREEZE_MSEC/VSS_TIMEOUT_EVENT_MSEC; i++)= { HRESULT hr2 =3D vss_ctx.pAsyncSnapshot->QueryStatus(&hr, NULL); if (FAILED(hr2)) { - err_set(errset, hr, "failed to do snapshot set"); + err_set(errset, hr2, "failed to query snapshot set status"); goto out; } if (hr !=3D VSS_S_ASYNC_PENDING) { --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:01:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788778348; cv=none; d=zohomail.com; s=zohoarc; b=OE/jEabMQvzptHpKDMI54ijerkcPyeyh3D01/ifTEv1vgpzjvm3WhbUmezMGAPU+mcrvfPmaWrKfTld6SdCes1WlX2rtMg02PH8RwcFfMUCl0eT0VOKy3DhxpEIvv+1hFwdlxI5whsAKVPLWKuJlPeD/ZytFOWGbYQ3WW1926mU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788778348; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=119JB0pzddz3lH7H96fc4hqRlml0NBoWi3OznF7v1yg=; b=JZBnXZuKGqTUINNmu43yvo4Ryq6VbS2ajijIaRo3Y551MyGLoGuRood26OWbtRqnXVaoWTOPuUmbC29U0xB4mem563+oDlaH/1Qf9oGGjP3hagzs0pnyL4EIpgPX2fFmqU5bzPEfYJLMzHRYq7pxaJRK/UeOuxL+c0w9GFd3ENg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788778348735133.46499702781136; Mon, 7 Sep 2026 03:52:28 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x3WwL-0007zH-3E; Mon, 07 Sep 2026 06:51:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3WwJ-0007xR-I9 for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:51:03 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3WwG-00084s-Rc for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:51:03 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-12-r_HsIT_8PKuQrxUKgp8A3A-1; Mon, 07 Sep 2026 06:50:58 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D6F3B1944B3D; Mon, 7 Sep 2026 10:50:57 +0000 (UTC) Received: from localhost (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DE1B3180034F; Mon, 7 Sep 2026 10:50:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788778260; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=119JB0pzddz3lH7H96fc4hqRlml0NBoWi3OznF7v1yg=; b=AG287qbQOVlH/MXrFArsJWxKmh0teSMkBjc8ZBuB7/OjigOxpZxEQjw8ZuI4MafS1kvZhL WxIuV8EdNOUKLHVD3Nyz575+4UK63yBxNKe91sT2TxVpt2FGM1qM6f35eu+eYEuu38MCSR ULgjURg1jw/1gsFoVfM+GxKEQwZXw4w= X-MC-Unique: r_HsIT_8PKuQrxUKgp8A3A-1 X-Mimecast-MFC-AGG-ID: r_HsIT_8PKuQrxUKgp8A3A_1788778258 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 07 Sep 2026 14:50:12 +0400 Subject: [PATCH 14/17] qga/vss-win32: check GetLastError() after FindNextVolumeW failure MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-qga-v1-14-86456ad356e2@redhat.com> References: <20260907-qga-v1-0-86456ad356e2@redhat.com> In-Reply-To: <20260907-qga-v1-0-86456ad356e2@redhat.com> To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk , Michael Roth , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1347; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=hDm2EFFMYfEJHwEi8h2bx5hGHEjQtbbglyBl0/mRBAM=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnpbj1f36UQjvGjixEqmdKSE6uCY477C5ei3Qe tBO15Z0ngaJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap6W4wAKCRDa6OEJdZac 5c9iD/9/UlfgB7TczIKS41ufsDzvWwf3Db9l1miNlBJ06S5uUt/e801udPVsNsr5U1cUZ16jpvL sJFUtuE7YfrHL75PY/dthwZdCyd8ubHLOx2FLwzvpgKr+MArW4rk0bItEKAhxwhvbF+g8i4CsWF vh1dgvUfxrezGb7xfsaXuUTYWNlR7RLWYOnTkKjO6GmlRyXHNKZxjemgIQ8I3eIomhOt5P4ncF4 F7cCPImxHZZ2g1B9o3RH7WAfNdk36RZCzHt3v1xZljpFuYKoLBor7bXInYwdxUdBEdxTwoCFtdx GsIRvVBBBbXgg2wRZT5JlGrlZxf70aAOlXlbhUETv7rKz5AySeg1Kz1ZjRqwPHJ77+qpjSdWEO1 2uiv31vPyn3rT3nR5hPaNbuTMOIHbbBbiUV9KyuG7APsipcROlInaAc/E4rU5mb44jfrUhf5s+z 4y3sUrFySMMvKEQiTh/0BA9R+zuqRbRpY/OS48ko5j6kWTxflITH50uuhpX9xmt06R1D9zFOMwX V9YD6Fk+Ya8gQtvPZINoeZs1ZTFFf3g4RkeKqhEGTCbxK3YBCVK68C9jgACjtWaXxBnWQ/52Xdj n2ArnCZM1X6xYFollzrr4UgXQJgxOwp5UzX5Ju3IOGNdhpJhz0ZpnOfMEfF/yDyPNfO5Wj946K3 TXc7KznRxLS2/+w== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788778350626154100 FindNextVolumeW returning FALSE can mean either normal end of enumeration (ERROR_NO_MORE_FILES) or an actual error. The code treated both cases as end-of-list, silently skipping any remaining volumes on a real failure. Distinguish the two by checking GetLastError(). Fixes: b39297aedfab ("qemu-ga: Add Windows VSS provider and requester as DL= L") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Kostiantyn Kostiuk --- qga/vss-win32/requester.cpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp index b3daa060ac01..f14c47f9f7a9 100644 --- a/qga/vss-win32/requester.cpp +++ b/qga/vss-win32/requester.cpp @@ -461,6 +461,13 @@ void requester_freeze(int *num_vols, void *mountpoints= , ErrorSet *errset) } if (!FindNextVolumeW(volume, short_volume_name, ARRAYSIZE(short_volume_name))) { + DWORD err =3D GetLastError(); + if (err !=3D ERROR_NO_MORE_FILES) { + err_set(errset, err, + "failed to find next volume"); + FindVolumeClose(volume); + goto out; + } FindVolumeClose(volume); break; } --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:01:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788778347; cv=none; d=zohomail.com; s=zohoarc; b=EX0ec5+N62658c9fRJURIoljFTVwQB+Zb/Cbm95l18rSf3VXaPm37ow4KXUN2Hx4Mg5zB3vmhJdCtchkUeDPjTHcMCFCVUZR85moTSFkGCdnL5tcheHKpO9qcxrbVmVkYYLwdlODc3GsqSiEu1RPE4CwsxV6PdSDBb5a0YTcHpQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788778347; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=55d5+Bk/PPCECwITaJI+af3wS9ezo/MiSarVcMf/BVY=; b=S4l7yBstR9rXcWOnc8wUCXGu57GonGCDVSBcC6SigZM1WjorC7XbFZOndP5ljIm1S4MqirPTzsxNiHwIeEs3c7YW+G7D4wHwE0eS5qXg5dfp9X73u65hkaiPBR+YKAp7CkdiHbKkL7+ZQeeyjVHOqB82dCwFT27XGYntbI2fxds= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178877834794374.67718000206833; Mon, 7 Sep 2026 03:52:27 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x3WwN-00080I-0k; Mon, 07 Sep 2026 06:51:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3WwL-0007zd-Da for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:51:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3WwJ-00085p-U3 for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:51:05 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-288-imP93Zr1OLCmGq-Y196Hvg-1; Mon, 07 Sep 2026 06:51:02 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2E4B91954AE4; Mon, 7 Sep 2026 10:51:01 +0000 (UTC) Received: from localhost (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 33CE21956042; Mon, 7 Sep 2026 10:50:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788778263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=55d5+Bk/PPCECwITaJI+af3wS9ezo/MiSarVcMf/BVY=; b=YV1M8UwYPTQLPY0ePA73M6IxK64qz9zh0IBsvrEDR+nuTTaipLdh2ZcFWD+7y91kx3eYCh C2a6FoWMsQ5YawE3mQ1fngnYhg9qhfBpz01UoiNp9tmJrBGFiEle38nO869UTuQNsMWDJ6 zIObYRtoRUdGsFYLE3zxeGjuhUuSNsc= X-MC-Unique: imP93Zr1OLCmGq-Y196Hvg-1 X-Mimecast-MFC-AGG-ID: imP93Zr1OLCmGq-Y196Hvg_1788778261 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 07 Sep 2026 14:50:13 +0400 Subject: [PATCH 15/17] qga/vss-win32: initialize *num_vols at start of requester_freeze MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-qga-v1-15-86456ad356e2@redhat.com> References: <20260907-qga-v1-0-86456ad356e2@redhat.com> In-Reply-To: <20260907-qga-v1-0-86456ad356e2@redhat.com> To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk , Michael Roth , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1083; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=YvAZ7FyAYlgMnFp2aEC5hIldna5HU3GCZJ5PQBv+yaw=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnpbjspH3rUiMk3NLpunctZRhA43qR1L4f7f5j 0Jvn/GqcMqJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap6W4wAKCRDa6OEJdZac 5eIXD/9JTVlPev1fTyk4rpKtrMGUXZ4+rFeiR2PWxKMH0kB+g3yiW1smsfBbZX4hq05T2IfuW9L x6GeU+EPhqwn3wlGFit3/wS240OeP8GxEIadIhfP7Uzx/C2k1z0OnAg7rczx9ey0+EFCVvClE+i +NNVUP70EoQpYWHCGem5HCYbnd7oj/yu6L9ZvLQgSpxsLtarB4mrpLHo4xE3pf0RJwBAjgDsD+D /M9qePhxhoaZWBrWHxQJxeIhQc7N25L9APrEgtCVpWL1CLwp4wlawRHtinRsEGn8pw7NMxFRDf6 cJUU0ohXVUlIKpuuCKQq22Ogged6njlmjlOqGgIbdk+Z6QKQRTrM3NtcxTqngG6ublt5lAM3MZo 1SBixf2AavyACjorgwHvpjSkJuUxVZmaruInAaH3T9b0WWJIqLmwgCJMjb92K8irlxamgkcYiXq hjCO50sj3JkJweNNuLyCPSyno1P0prWYr0jK7G7MEprW+xp/ZnPPzfQ8sUtdteSZzovZr/kA8JW +SGeN3Eop7k3hs2d/Kr8j1U1h9vTo5envcfiauisHzAx49KiAvj7HkkLbY0MRJ871xoXWRxQQ1F ksuSJ8v0+uJmX0kY1MH+0+7E0Ip1EnodmbNnXzGryh3h3YXA4jhCsn4634fxpW/bAfB72TPnkC7 YwDLYthiVdKVXhg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788778349613158500 Initialize *num_vols to 0 at the top of requester_freeze() so all error paths and zero-volume early exits return a defined value to the caller. Previously, only the already-frozen path and the success path set *num_vols; every goto-out error path left it indeterminate. The sole caller is qga_vss_freeze(), which already sets *nr_volume =3D 0. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Kostiantyn Kostiuk --- qga/vss-win32/requester.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp index f14c47f9f7a9..d36a90c17d1d 100644 --- a/qga/vss-win32/requester.cpp +++ b/qga/vss-win32/requester.cpp @@ -306,8 +306,9 @@ void requester_freeze(int *num_vols, void *mountpoints,= ErrorSet *errset) int num_mount_points =3D 0; VSS_BACKUP_TYPE vss_bt =3D get_vss_backup_type(); =20 + *num_vols =3D 0; + if (vss_ctx.pVssbc) { /* already frozen */ - *num_vols =3D 0; qga_debug("finished, already frozen"); return; } --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:01:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788778317; cv=none; d=zohomail.com; s=zohoarc; b=ipZ44UCGPf9RL/Al7oQHt+Cu5MSGd4KwWbVHsMDX9EzqhxBuJ32f6WvQphNiZinvQpNiNFIe4vxQmaGq9kGRGnWwz2jQWDG+UF2hVZ1guy5ds13HRC2TL9lvQ6i8kSnVN5LR15XqoDirI48pPJvPC4BXONsSDctI5to0N/STxyY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788778317; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=w+SRw7UcH1546WE65q0XEC2VXWIMBqYaxAJQkKqKw50=; b=Cxf6gTsv8dbxBx8V2FV05M9tJilUyT3DgSvLdHxzynwsxluAWfg7kMQkHwp7RORI+jCUbZLU6AAIOPtAStnJK9C36lbvLZNbOpI72HoS9Lf82Pi0YDBFSRRkddhcMnCjmH88b8o4i5AOrdbjDMUIrpyWjrROKEc0QLfAKSJikz8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788778317613958.3337426395063; Mon, 7 Sep 2026 03:51:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x3WwR-0008DL-39; Mon, 07 Sep 2026 06:51:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3WwP-00086H-G0 for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:51:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3WwN-000874-LE for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:51:09 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-196-NSVi0bMSNTS52z-tGwJlKQ-1; Mon, 07 Sep 2026 06:51:05 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C50501944B3D; Mon, 7 Sep 2026 10:51:04 +0000 (UTC) Received: from localhost (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E42901955F0E; Mon, 7 Sep 2026 10:51:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788778267; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w+SRw7UcH1546WE65q0XEC2VXWIMBqYaxAJQkKqKw50=; b=E2YTxQP60hS4yYxZYOT6lq1O6DwpbWBRKveuSgASNMY37bdq8i6Tk6B0+FFQeBDSy204gm j1Lhrk9Q1ZlDyfHFLnaqAkJdt5tDFqwxrCY6/pJdHpFJRUrp/JpQsMk882ft8+8sTWUSFW j85kWMWmw59UJIVLksSZEx1l/ZHKLJc= X-MC-Unique: NSVi0bMSNTS52z-tGwJlKQ-1 X-Mimecast-MFC-AGG-ID: NSVi0bMSNTS52z-tGwJlKQ_1788778264 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 07 Sep 2026 14:50:14 +0400 Subject: [PATCH 16/17] qga/vss-win32: restrict access to freeze/thaw synchronisation events MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-qga-v1-16-86456ad356e2@redhat.com> References: <20260907-qga-v1-0-86456ad356e2@redhat.com> In-Reply-To: <20260907-qga-v1-0-86456ad356e2@redhat.com> To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk , Michael Roth , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=4106; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=LRDuI5i1nUeueI+PO1nmHqnehsgVgtFuyXYJTZ0rMgc=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnpbjX/Xi0tKat+ZjPXuo+r1bcTKyY2nauWPiL /jpIw+RpP+JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap6W4wAKCRDa6OEJdZac 5X/YD/0V7+AtWgaQ1zJEXAHH7Xu0nAlPX3Qt6qosYnUvgTk8SKbieA+qn/Kf7gcxWFe0lMFyKT3 u2CYgpzYJY32teFgtsGTxC69BOt1MIKujn8uMyh1k4tUuDPDyeetwb7wMKpR8uxezuWGl1u4k9b eIzs6L01I50bw8N3rv/PA0VI1YS+dCpbTl894qrsCZ1SdgQ0NCbXU9lhGChKsKx3jmS56SV6HdE Xw7PEE9bEYC2lHQSH4LPXbdMsgWZ8NkONuUnwQBM25iA8MEVeUHMMU6E6z2CEpRUHkN/i754Sw2 ncTGjmo8THGd1+JUtICarUBaoV4E4CYfZ1pNyxh6ix1K3B7Z3TulONI1Nd8W3bB9nQapB1gHiNY d8jsBhwP6pwuX8VO4tTRJOXnzCm1NtUegqJtFUtBWedP/Gz/B+cIQLye5eAy4iDOvX9P6rMK+o8 J6M1qWDTV/RZiqA2nD39MWsEEhj87DlTQ4c2uHJ/VhjFfvSeVEXTkHbWMOtM7h3dlYTiRdh30OX 3acfMwXiOO8GvH7N/sc1QJa890FgApb5JssDgtgWTktZ/4+/KTxUouJ1I4CP4doZDbSysxhBm5h oO2VbkvMKBoZHLvdJREpkDj8brlWNhEdHXnW4u3856quuJJN3wS6466yhFFevw+bnkFXvBKJBC6 lM+Kve8836621jA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788778320207154100 The freeze, thaw and timeout events were created with a NULL DACL, granting unrestricted access. Any local process could open and signal them, allowing an unprivileged guest process to trigger a filesystem freeze or premature thaw. Replace the NULL DACL with an explicit ACL that grants EVENT_ALL_ACCESS only to SYSTEM and the built-in Administrators group, which are the accounts under which the VSS service and qemu-ga operate. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Kostiantyn Kostiuk --- qga/vss-win32/requester.cpp | 52 +++++++++++++++++++++++++++++++++++++++++= +--- 1 file changed, 49 insertions(+), 3 deletions(-) diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp index d36a90c17d1d..1b0155c691ef 100644 --- a/qga/vss-win32/requester.cpp +++ b/qga/vss-win32/requester.cpp @@ -17,6 +17,7 @@ #include "install.h" #include #include +#include =20 /* Max wait time for frozen event (VSS can only hold writes for 10 seconds= ) */ #define VSS_TIMEOUT_FREEZE_MSEC 60000 @@ -298,10 +299,14 @@ void requester_freeze(int *num_vols, void *mountpoint= s, ErrorSet *errset) HRESULT hr; LONG ctx; GUID guidSnapshotSet =3D GUID_NULL; + SID_IDENTIFIER_AUTHORITY sia_nt =3D SECURITY_NT_AUTHORITY; + PSID pSidSystem =3D NULL, pSidAdmins =3D NULL; SECURITY_DESCRIPTOR sd; SECURITY_ATTRIBUTES sa; + EXPLICIT_ACCESS ea[2]; + PACL pAcl =3D NULL; WCHAR short_volume_name[64], *display_name =3D short_volume_name; - DWORD wait_status; + DWORD wait_status, aclResult; int num_fixed_drives =3D 0, i; int num_mount_points =3D 0; VSS_BACKUP_TYPE vss_bt =3D get_vss_backup_type(); @@ -313,9 +318,48 @@ void requester_freeze(int *num_vols, void *mountpoints= , ErrorSet *errset) return; } =20 - /* Allow unrestricted access to events */ + /* Grant access to SYSTEM and Administrators only */ + if (!AllocateAndInitializeSid(&sia_nt, 1, + SECURITY_LOCAL_SYSTEM_RID, 0, 0, 0, 0, 0, 0, 0, + &pSidSystem)) { + err_set(errset, GetLastError(), "failed to create SYSTEM SID"); + goto out; + } + if (!AllocateAndInitializeSid(&sia_nt, 2, + SECURITY_BUILTIN_DOMAIN_RID, DOMAIN_ALIAS_RID_ADMINS, + 0, 0, 0, 0, 0, 0, &pSidAdmins)) { + DWORD err =3D GetLastError(); + FreeSid(pSidSystem); + err_set(errset, err, "failed to create Administrators SID"); + goto out; + } + + ZeroMemory(&ea, sizeof(ea)); + ea[0].grfAccessPermissions =3D EVENT_ALL_ACCESS; + ea[0].grfAccessMode =3D SET_ACCESS; + ea[0].grfInheritance =3D NO_INHERITANCE; + ea[0].Trustee.TrusteeForm =3D TRUSTEE_IS_SID; + ea[0].Trustee.TrusteeType =3D TRUSTEE_IS_WELL_KNOWN_GROUP; + ea[0].Trustee.ptstrName =3D (LPTSTR)pSidSystem; + ea[1].grfAccessPermissions =3D EVENT_ALL_ACCESS; + ea[1].grfAccessMode =3D SET_ACCESS; + ea[1].grfInheritance =3D NO_INHERITANCE; + ea[1].Trustee.TrusteeForm =3D TRUSTEE_IS_SID; + ea[1].Trustee.TrusteeType =3D TRUSTEE_IS_WELL_KNOWN_GROUP; + ea[1].Trustee.ptstrName =3D (LPTSTR)pSidAdmins; + + aclResult =3D SetEntriesInAcl(2, ea, NULL, &pAcl); + if (aclResult !=3D ERROR_SUCCESS) { + FreeSid(pSidSystem); + FreeSid(pSidAdmins); + err_set(errset, aclResult, "failed to create ACL for events"); + goto out; + } + FreeSid(pSidSystem); + FreeSid(pSidAdmins); + InitializeSecurityDescriptor(&sd, SECURITY_DESCRIPTOR_REVISION); - SetSecurityDescriptorDacl(&sd, TRUE, NULL, FALSE); + SetSecurityDescriptorDacl(&sd, TRUE, pAcl, FALSE); sa.nLength =3D sizeof(sa); sa.lpSecurityDescriptor =3D &sd; sa.bInheritHandle =3D FALSE; @@ -551,6 +595,7 @@ void requester_freeze(int *num_vols, void *mountpoints,= ErrorSet *errset) } =20 qga_debug("end successful"); + LocalFree(pAcl); return; =20 out: @@ -559,6 +604,7 @@ out: } =20 out1: + LocalFree(pAcl); requester_cleanup(); =20 qga_debug_end; --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:01:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788778327; cv=none; d=zohomail.com; s=zohoarc; b=OoPbRo6ap1OlV6sDvTYw57Z51PPGY66K9RBmg3zC0F3p3QYqQzaTlSJvhyw3ujSb6FDfUXp6wyAyy0avqjfrAZXgb59CTu5KtLTMWjHHdGhGqIj7rTy2sPYXtOy2JPg0lZugmEThp0a33X0p+7uBEpGcX0iC5OczllCqedLHauI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788778327; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=h0jBAoZco2Pw7ebgEfbs0MFsImo3zclsxLCDcavDFZ0=; b=NZVRHtJf8BGqQlllhW49EEuUYQsr1/8eoVHUU+ctS193p3DFB+QQMVbQMfOT2Ca5O1sA64efcDzYccSWL/KyOBIqPWbQ1SF7ynt2iLqjmWnxjSRJkuDVFntwlzCV5X2QyD0EWmDknVeaxlMobmYxwEXzn2EzmugBH+CFc4O4qSo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788778327842188.09304844965834; Mon, 7 Sep 2026 03:52:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x3WwV-0008Ns-4g; Mon, 07 Sep 2026 06:51:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3WwS-0008Ig-82 for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:51:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3WwQ-00087u-MC for qemu-devel@nongnu.org; Mon, 07 Sep 2026 06:51:11 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-57-Oh0y8IIjNd6EDBfChLoBCg-1; Mon, 07 Sep 2026 06:51:08 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DF7C219541A5; Mon, 7 Sep 2026 10:51:07 +0000 (UTC) Received: from localhost (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1FA8E1956042; Mon, 7 Sep 2026 10:51:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788778269; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h0jBAoZco2Pw7ebgEfbs0MFsImo3zclsxLCDcavDFZ0=; b=OTGqU75WLmGvrg8B4h5RQSNOos3AcPSMSG3lv+Mz3fKAHMKmih6/zThv7ADJABjdhP0mFn sVnHfV2GMOnDi8n3wow7S8Rjz+e1ojp7TxXM9qKyKu/lcDHv63jeXx++V0jiOD8ba2m4jI /sA2DnivR/yzmzYCSW/od9Pum8bKdG0= X-MC-Unique: Oh0y8IIjNd6EDBfChLoBCg-1 X-Mimecast-MFC-AGG-ID: Oh0y8IIjNd6EDBfChLoBCg_1788778268 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 07 Sep 2026 14:50:15 +0400 Subject: [PATCH 17/17] qga/vss-win32: log to file during COM+ registration MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-qga-v1-17-86456ad356e2@redhat.com> References: <20260907-qga-v1-0-86456ad356e2@redhat.com> In-Reply-To: <20260907-qga-v1-0-86456ad356e2@redhat.com> To: qemu-devel@nongnu.org Cc: Kostiantyn Kostiuk , Michael Roth , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1531; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=zmGVWRNVdoiU4ZZZJbZEQc9IKxgrcgzEcalOujMBcmQ=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnpbjSsP6qfmhknoDFgwsU1dAk6QBcwO7KAFmv 5YsVxDADZCJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap6W4wAKCRDa6OEJdZac 5eHMD/0cFX7ixWJx+Wx8e20uxonfBCYLjkHWVMwQuhp5thvMrgxmC+QQxrbmxfqHIvuYYYul7eg iMDn+6iqYS+jMQcZr/uMmfTKTLuwyUBn4N9cZIZeGNvt3TlS8QEyDi4nJoeoFAKEOpAvmEpgKpQ Yy5Td2qFkrwKMRM3CYCEThD0IFQMoODoH2l+tKb5aO3hAA9dppBCH0KfV8Mo/2Aoj3TpDo+0c0R n0vZNDFFr0C/5myGalrsozz/KU7QI9tvJcyrsIGZd5c9u/4vdDtAmkRylqogtHozVXg2U7SX01n P8Tdn3iBOS1b/kR9O9dOn5CVEQrO/DpAw7yYj0vqv5fg8nT50DaztlXY3v72LWKRp2jpu+ZcbwZ ATsBb/G7dBxNDqY44dun9q4VpARAJqTervHoioB5dcmtIr9Ukv6kQSIUQCOpzXBnY5Sja4Zv+mq xnbt7EAr7T24mHSU7gsnPJHESMZWim/hi+QPDIFWfECARxgobPPwTpWHLOVU74QImhu/NZV9bFl bKzmgKuPAwn7Qur+LRr0xDpRcntdJyCrIUq1eC68qMoOXQdScBLWQ8R2zWj94QUu2jcOmagwDWa /mAQ+I9L2wPcLbNu1XypKLxevKyTTOWpFAVfXgFZt11KMW4SPJ7iR3TsqhzJ6qA0PpuXwuXG6li GGPYIwgIKW5Gc7Q== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788778329343158500 COMRegister and COMUnregister are invoked both from the MSI installer (via DLLCOMRegister/rundll32) and from qemu-ga -s vss-install, where stderr is typically not visible. Redirect stderr to %SystemRoot%\Temp\qga-vss-install.log so that qga_debug output is captured for post-install troubleshooting. Suggested-by: Konstantin Kostiuk Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Kostiantyn Kostiuk --- qga/vss-win32/install.cpp | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/qga/vss-win32/install.cpp b/qga/vss-win32/install.cpp index 9e8db79c122c..09d94edd4f53 100644 --- a/qga/vss-win32/install.cpp +++ b/qga/vss-win32/install.cpp @@ -241,10 +241,27 @@ out: return hr; } =20 +static void qga_vss_open_log(void) +{ + char path[MAX_PATH]; + UINT n; + + n =3D GetSystemWindowsDirectoryA(path, sizeof(path)); + if (n =3D=3D 0 || n >=3D sizeof(path)) { + return; + } + snprintf(path + n, sizeof(path) - n, + "\\Temp\\qga-vss-install.log"); + if (freopen(path, "a", stderr)) { + setvbuf(stderr, NULL, _IONBF, 0); + } +} + /* Unregister this module from COM+ Applications Catalog */ STDAPI COMUnregister(void); STDAPI COMUnregister(void) { + qga_vss_open_log(); qga_debug_begin; =20 HRESULT hr; @@ -260,6 +277,7 @@ out: STDAPI COMRegister(void); STDAPI COMRegister(void) { + qga_vss_open_log(); qga_debug_begin; =20 HRESULT hr; --=20 2.55.0.543.g5ebe2ebe4ea8