From nobody Sat Sep 26 20:00:46 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788786879; cv=none; d=zohomail.com; s=zohoarc; b=kxWsUADFY8Sjq8CSX7JgCinQjlJJ1W0Au+gn33AbRFr1zdnPlZEh4+awvZ702UiaejwZ5zbZ352V5yKiO8Fbjr3TOhbRS0sU0kRPbujaSf0XCRL9ldF+Vk0GozHsfvnNtDQiRybQ8k2Mq7schYDdiSBBt/WA09w6tL42f1MTuSc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788786879; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lhF+LPeY+OhWtZ9Geb9k4VAyQa5iXbXu/6wp/DbPS44=; b=m7ms/uAD4a2ZMf7vAXpZt2KpkHIVqHzOqDIg2isinJ3WQlgsqCAyhe3q9AQzgbqTuQTLBFvfWaWHqyZR0iLC6tgoU1E0o3eucMK0zJdkOqC0hD31+R0efx4ooaGaz3mtKgngDa7tG/3x31de1XtXEV8/BzUyvpxhjbFp6nye4yM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788786879392527.8690366441613; Mon, 7 Sep 2026 06:14:39 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x3ZAy-0004AF-Pf; Mon, 07 Sep 2026 09:14:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3ZAw-00047T-SL for qemu-devel@nongnu.org; Mon, 07 Sep 2026 09:14:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3ZAu-0006Qv-Uh for qemu-devel@nongnu.org; Mon, 07 Sep 2026 09:14:18 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-575-YHoJYyqqOBeamVSfpbveXQ-1; Mon, 07 Sep 2026 09:14:11 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 05F871955D7D; Mon, 7 Sep 2026 13:14:09 +0000 (UTC) Received: from localhost (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 48A001955F07; Mon, 7 Sep 2026 13:14:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788786855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lhF+LPeY+OhWtZ9Geb9k4VAyQa5iXbXu/6wp/DbPS44=; b=i4EOXIh9Ign++x5YkhMER/+DElpefaNfo5l3pDSWWk6zD/FP3bMP0ddDeltQzp7mpuZWQ8 YjtFPQs8DVg4h6oCIQTkRji2wrKfHFVJebWoRexf1dfTGgPqJFXeWFE/UK8nW8TXV2HzYM xlsqlogoTE8okDwe7m9uStOTGiEomeQ= X-MC-Unique: YHoJYyqqOBeamVSfpbveXQ-1 X-Mimecast-MFC-AGG-ID: YHoJYyqqOBeamVSfpbveXQ_1788786849 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 07 Sep 2026 17:13:55 +0400 Subject: [PATCH v3 1/9] tests/functional: replace HMP with QMP MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-nohmp-v3-1-c11e7d0d3d7d@redhat.com> References: <20260907-nohmp-v3-0-c11e7d0d3d7d@redhat.com> In-Reply-To: <20260907-nohmp-v3-0-c11e7d0d3d7d@redhat.com> To: qemu-devel@nongnu.org Cc: John Snow , "Denis V. Lunev" , Fabiano Rosas , Laurent Vivier , Paolo Bonzini , qemu-block@nongnu.org, Peter Maydell , Thomas Huth , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Aurelien Jarno , qemu-arm@nongnu.org, Halil Pasic , Christian Borntraeger , Eric Farman , Matthew Rosato , Cornelia Huck , qemu-s390x@nongnu.org, =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Glenn Miles , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=4336; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=wRP0TTU7tHgaAz5ePxRNTdw8coJZsHYYMWkGMZmWUDw=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnriXqpm8t6dRjU2H+9fKTGG5Aox2fIJkJm2PB +geu4U89RSJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap64lwAKCRDa6OEJdZac 5XKUD/9naAU5Hv7O5qygDUwAEtbGyF/vOErv8EQ+Z6pDcfgcXgjmcWGVPzaDy58yJbceOTcZ3xt CNeHHWOkUtJjOkGvSXRiFgJW0gWoAXKzIvehmFrlHXh4VJn8jS1zRXohdn8Od6FscgrlDr8/lnR /q3vRu60xAMgZ8nN/c0tApdKbgqpe3NZSnzd4YK9Lu8esAtDPRSTIWbDe+HpgbO66VO6fEFJlgg Cz0uzM+V+6z1OQfC5oTSHgRJ3j0pv02ArlHkvKvigpNeV5LGTpwuCf+vpRsdUVa7JsAJgwVSHhG Vsta1zgDbi0qxdBnF1K9keza/S5emFwZv3rnocUD3tODhMf5rZVR8gGI38ZX6x1fMM0SlJsdWjz J0RZ65lnTeiUQRGWwGP1UQMB5g5CCsVPT6R31uQ1QmOBXvOyUo/NDFUeezz+voS3KmLaa5c0sgP 6viNGfcraVZ1+w5wAGIf/+FoSj3IQyXt+iGZB8DMhKiEojirdaIfAdpe1zJqIwnWZH2eByhpZLn 2fvZ0+8fMiq0hNnVq12CLHArGeX36WCYUIgOFdXucUq4ajOAde2PYNTcgF74cIAmasDnHcSv8BP 4BNw24cAs5fmZip1hSXrnOyIuN5roduMWsZxuEvWV8MrTbJThbckt2rB8gMesJRxSnRR2N9SqJ7 qgW7cWh1FrS20sQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788786881462158500 Replace HMP with QMP equivalent. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Thomas Huth --- tests/functional/arm/test_integratorcp.py | 13 ++++++++----- tests/functional/m68k/test_nextcube.py | 11 +++++++---- tests/functional/mips64el/test_malta.py | 13 ++++++++----- 3 files changed, 23 insertions(+), 14 deletions(-) diff --git a/tests/functional/arm/test_integratorcp.py b/tests/functional/a= rm/test_integratorcp.py index 23ae919359d5..b79e81393547 100755 --- a/tests/functional/arm/test_integratorcp.py +++ b/tests/functional/arm/test_integratorcp.py @@ -14,6 +14,7 @@ =20 import logging =20 +from qemu.qmp.qmp_client import ExecuteError from qemu_test import QemuSystemTest, Asset from qemu_test import wait_for_console_pattern from qemu_test import skipIfMissingImports, skipUntrustedTest @@ -72,11 +73,13 @@ def test_framebuffer_tux_logo(self): self.boot_integratorcp() framebuffer_ready =3D 'Console: switching to colour frame buffer d= evice' wait_for_console_pattern(self, framebuffer_ready) - self.vm.cmd('human-monitor-command', command_line=3D'stop') - res =3D self.vm.cmd('human-monitor-command', - command_line=3D'screendump %s' % screendump_path) - if 'unknown command' in res: - self.skipTest('screendump not available') + self.vm.cmd('stop') + try: + self.vm.cmd('screendump', filename=3Dscreendump_path) + except ExecuteError as e: + if e.error_class =3D=3D 'CommandNotFound': + self.skipTest('screendump command not found') + raise =20 cpu_count =3D 1 match_threshold =3D 0.92 diff --git a/tests/functional/m68k/test_nextcube.py b/tests/functional/m68k= /test_nextcube.py index d917cf5424fe..f3d92034b127 100755 --- a/tests/functional/m68k/test_nextcube.py +++ b/tests/functional/m68k/test_nextcube.py @@ -9,6 +9,7 @@ =20 import time =20 +from qemu.qmp.qmp_client import ExecuteError from qemu_test import QemuSystemTest, Asset from qemu_test import skipIfMissingImports, skipIfMissingCommands from qemu_test.tesseract import tesseract_ocr @@ -39,10 +40,12 @@ def check_bootrom_framebuffer(self, screenshot_path): break time.sleep(0.1) =20 - res =3D self.vm.cmd('human-monitor-command', - command_line=3Df"screendump {screenshot_path}") - if 'unknown command' in res: - self.skipTest('screendump not available') + try: + self.vm.cmd('screendump', filename=3Dscreenshot_path) + except ExecuteError as e: + if e.error_class =3D=3D 'CommandNotFound': + self.skipTest('screendump command not found') + raise =20 @skipIfMissingImports("PIL") def test_bootrom_framebuffer_size(self): diff --git a/tests/functional/mips64el/test_malta.py b/tests/functional/mip= s64el/test_malta.py index 163bbaf5ca36..3b6d53799616 100755 --- a/tests/functional/mips64el/test_malta.py +++ b/tests/functional/mips64el/test_malta.py @@ -11,6 +11,7 @@ =20 import os =20 +from qemu.qmp.qmp_client import ExecuteError from qemu_test import LinuxKernelTest, Asset from qemu_test import exec_command_and_wait_for_pattern from qemu_test import skipIfMissingImports, skipFlakyTest, skipUntrustedTe= st @@ -154,11 +155,13 @@ def do_test_i6400_framebuffer_logo(self, cpu_cores_co= unt): self.vm.launch() framebuffer_ready =3D 'Console: switching to colour frame buffer d= evice' self.wait_for_console_pattern(framebuffer_ready) - self.vm.cmd('human-monitor-command', command_line=3D'stop') - res =3D self.vm.cmd('human-monitor-command', - command_line=3Df'screendump {screendump_path}') - if 'unknown command' in res: - self.skipTest('screendump not available') + self.vm.cmd('stop') + try: + self.vm.cmd('screeandump', filename=3Dscreendump_path) + except ExecuteError as e: + if e.error_class =3D=3D 'CommandNotFound': + self.skipTest('screendump command not found') + raise =20 match_threshold =3D 0.95 screendump_bgr =3D cv2.imread(screendump_path, cv2.IMREAD_COLOR) --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:00:46 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788786964; cv=none; d=zohomail.com; s=zohoarc; b=kvvukncclZ7Kvjmx24jbi+tzHiGv0W1IrGKxn2Deu2CxobG/IGY3w7+zpJ7BDmCF6mXCzjCRArpWZ1O5TKr56tyArD/afqmJMD2lcbWKslfvI+rWcFaiUZZRDSquAJo5pLiOSzZy0tR0mzjPypNN7UgCblE6urY4SIIYiCUoweE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788786964; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=40LyvCDlaHAQHcMLKYj1Q0OPDSPjXdpYRkudFHr+oJg=; b=AMVmeG/kag/g9zOOHzpazWlcmw4dTjWucps2bERM69Xz5b7EoHWcUZmblHIET1Q91nrIzlqgCBfog0q4KZmFHQQJusmohrHixva/x2k/S+sWtSW6D+4R4FRiAwxO8z3GNqxuHc+R12VxNVEu0sNUiNg0Cxx02ZA1Dan+IobSJbg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788786964295281.36745788043186; Mon, 7 Sep 2026 06:16:04 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x3ZB6-0004Eu-Rn; Mon, 07 Sep 2026 09:14:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3ZB1-0004Bn-4v for qemu-devel@nongnu.org; Mon, 07 Sep 2026 09:14:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3ZAy-0006Sc-0U for qemu-devel@nongnu.org; Mon, 07 Sep 2026 09:14:21 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-626-asm5YBFWOtyy4sATIx_WoQ-1; Mon, 07 Sep 2026 09:14:14 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 956371801204; Mon, 7 Sep 2026 13:14:12 +0000 (UTC) Received: from localhost (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8DDDF427; Mon, 7 Sep 2026 13:14:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788786859; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=40LyvCDlaHAQHcMLKYj1Q0OPDSPjXdpYRkudFHr+oJg=; b=eKD67JEvA/9bVUuLH2iUEhKS0MyQlGLJtUPHNTOyfV7g/Y9o8pDr7ByyjoLB8AWP+/bfls yIcKtR1EB/0jW6uR+plLx/Jdcy0KoIepC0avJcgKpl5SWUIY1rxtXez50lfjO2WHCtUzkL O4SQFl11x3u6AoPDrK3K63f/8f0WaA0= X-MC-Unique: asm5YBFWOtyy4sATIx_WoQ-1 X-Mimecast-MFC-AGG-ID: asm5YBFWOtyy4sATIx_WoQ_1788786852 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 07 Sep 2026 17:13:56 +0400 Subject: [PATCH v3 2/9] tests/functional: add skipTestIfNoHMP() helper MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-nohmp-v3-2-c11e7d0d3d7d@redhat.com> References: <20260907-nohmp-v3-0-c11e7d0d3d7d@redhat.com> In-Reply-To: <20260907-nohmp-v3-0-c11e7d0d3d7d@redhat.com> To: qemu-devel@nongnu.org Cc: John Snow , "Denis V. Lunev" , Fabiano Rosas , Laurent Vivier , Paolo Bonzini , qemu-block@nongnu.org, Peter Maydell , Thomas Huth , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Aurelien Jarno , qemu-arm@nongnu.org, Halil Pasic , Christian Borntraeger , Eric Farman , Matthew Rosato , Cornelia Huck , qemu-s390x@nongnu.org, =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Glenn Miles , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1108; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=DKQeIhpML80zf1OYVo6I9MFIu0Q4mYbkgHIMXRWzZK0=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnriXvXuNuE2r07k76snHZGQN5739WyicgZ8C0 wdG0Md/1N+JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap64lwAKCRDa6OEJdZac 5X2vEACYh79+Ck3EpGOncVLJJCNpn4W7hckd1cEQJMYFOXAfjeBr4LPDeTNCnTX6bMtOP3tLdzA YigY+EFA+go3RSkQud1+XIPVFRXeZL0hPIc0wL6E5RwBi3CQH8drP///c7AENivtGlroFujMz0r Df6iBczceFMArxcIAPlo3H4l0FiDJnTr9/KNaLCdIFOHgT1rZ7suPUthwZVxoR+rx4K/wKikshZ iPVIcFAz5Bn92AK6yU/uV9v1BM+z7zo7ysFVr68G7ONk4qv6gJ1WVpuM3mvt61ZP5aj/tU3Ygnu fH2O+u49GG7MLWagHa0+9EHV4W/KA242joS9njKTH3XlLVcn4Q7yj/b5bUmuYYbiMgp7C6CMvgt JrzfK/5cyUotlidMSSRDLAVyVC9DPqHyOX83idaYZpkozBBebXcMzf5TiHrsLAiywzCdPUkpMAS /wiwg7uGOm8Q/ZC8IsFHTxoQjYg+QDkfkmFOSJiO5H6hX+H2S3AO2WAF7EUuYE8lAsVWxBE72FL qth3xKuROTvoUlDPt+ump+n8ndjqSNKY3QZrCiNgf1w/k6fm8xB3A/9rX+Raq1TGgcEQl5jYA5V vJ9wVRiq3gIJZbBvxfB4ozjUj8i9S+T1Nc1w1JLtpXir6ArrSo/jG0/F///ZzJRTT6sGjXVcVT7 YU5wILWfIQMjm6g== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788786965648158500 Reviewed-by: Thomas Huth Signed-off-by: Marc-Andr=C3=A9 Lureau --- tests/functional/qemu_test/testcase.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/functional/qemu_test/testcase.py b/tests/functional/qemu= _test/testcase.py index 69d3d06cc0e3..bf2dc1dc101c 100644 --- a/tests/functional/qemu_test/testcase.py +++ b/tests/functional/qemu_test/testcase.py @@ -369,6 +369,12 @@ def require_accelerator(self, accelerator): self.skipTest("%s accelerator does not seem to be " "available" % accelerator) =20 + def skipTestIfNoHMP(self): + commands =3D self.vm.cmd('query-commands') + if not any(cmd['name'] =3D=3D 'human-monitor-command' + for cmd in commands): + self.skipTest('HMP support is not available') + def require_netdev(self, netdevname): helptxt =3D run([self.qemu_bin, '-M', 'none', '-netdev', 'help'], capture_output=3DTrue, check=3DTrue, encoding=3D'utf= 8').stdout --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:00:46 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788786999; cv=none; d=zohomail.com; s=zohoarc; b=bdDV5jxicitPCBo/fhMItKF5RHS1RMM/VrXrR0sWXIAEmQJtiMjW9fOoUxew/xZT8HRUT1zBoAgDmvdCzREhWmxwn0SJLqPSzxV1f9ao08YXC7aNQxxcI/9PRQ7NTPGOg0+MPjx9Lqz0pmmzb3j8NBC8LIPn1Usn8C3HNlqal4g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788786999; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1p7jtalzlLyhCAYc3MxC7WWwgcA0LpGHOMMDNN/DBTg=; b=FNHa7q6LjnLZUGzONzcNDe7uHiq7SichfvhGODvuTfIzcMxnQE5cKnGOM4RVwLEitl9z920iGiLECgdL4R4tZ4A7UjiIR7Av431/fSIt/cBaQVDp9QpIKD3SGYGmJ/ifdASRTy/Rx3zmwpkiaTRBclylaS0iNDYHpcWyU1MsrJw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17887869995861008.8713617282406; Mon, 7 Sep 2026 06:16:39 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x3ZB8-0004GU-Oy; Mon, 07 Sep 2026 09:14:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3ZB1-0004Bp-7o for qemu-devel@nongnu.org; Mon, 07 Sep 2026 09:14:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3ZAy-0006Sm-8s for qemu-devel@nongnu.org; Mon, 07 Sep 2026 09:14:21 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-688-7EeU7Lw0M8GeMlUjwCZ7nQ-1; Mon, 07 Sep 2026 09:14:18 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D3A471954238; Mon, 7 Sep 2026 13:14:15 +0000 (UTC) Received: from localhost (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D474A427; Mon, 7 Sep 2026 13:14:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788786859; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1p7jtalzlLyhCAYc3MxC7WWwgcA0LpGHOMMDNN/DBTg=; b=J8GNOD6yc4Xvt2lgvjlRM4i8AMMyfO1nl2YiQutl5M2seuZ6Rsu00rz9SfASxLEClYNws7 e/D4G5d33OPmBgslWgQpN0SFGLJw87RbDAlNFkgT5jpAX+25oZ43TOy4o05WOjRthm6DSj yGF+lurbord0PsxYShDnuHJdGg948jk= X-MC-Unique: 7EeU7Lw0M8GeMlUjwCZ7nQ-1 X-Mimecast-MFC-AGG-ID: 7EeU7Lw0M8GeMlUjwCZ7nQ_1788786856 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 07 Sep 2026 17:13:57 +0400 Subject: [PATCH v3 3/9] tests/functional: skip some tests that require HMP MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-nohmp-v3-3-c11e7d0d3d7d@redhat.com> References: <20260907-nohmp-v3-0-c11e7d0d3d7d@redhat.com> In-Reply-To: <20260907-nohmp-v3-0-c11e7d0d3d7d@redhat.com> To: qemu-devel@nongnu.org Cc: John Snow , "Denis V. Lunev" , Fabiano Rosas , Laurent Vivier , Paolo Bonzini , qemu-block@nongnu.org, Peter Maydell , Thomas Huth , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Aurelien Jarno , qemu-arm@nongnu.org, Halil Pasic , Christian Borntraeger , Eric Farman , Matthew Rosato , Cornelia Huck , qemu-s390x@nongnu.org, =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Glenn Miles , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1529; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=c8qgPpmZ3XLl9uO8pUVbfyeeb4zTdwm0KeCmlMQU5BE=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnriXUyIoQ4RFCIcynTuStlQLJ7RHtw6y5XZTH e9teC/wh8iJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap64lwAKCRDa6OEJdZac 5XIAEACKxFXv4vn6pB0LQW6YGimEQCFSpe8kz0H7QKtrrquP6Oaor1Tnvs13RnJk38IOQ+64E/n ZT/YfCguvyX7oSTX4GqajwwgpBXXqnMkuLLE+V4aAHn4HmwoWOTWA7cQXnC+PjwzYmLSCnkfxC5 Xxu33Q99L50gYfsrlSUNAI+3elEL0oSeiZNKglwBdz7zBIDqbyJVb36qLxDkI4z+4YhCXWidmOj NhfA2yA1xpF9bEk+9TY8XXHwwb6a3huSM0uxwTmMpqfZpowrgKeuIQErabmIC2bfshLnY0vs5UX JVkiniBfMVu3scy6XjlQQI45gvlEduBCi2D6OX+wj936zL5JiK/OOT/0UMdLSjCdcTCtimHYhSd eb4wBg+5n0N93LRXNrtrt99tLxmH40RB/HSQGuPS123FABwR84SPuKdxhxzp1Dbjc73WR2redft kxuPhuoraetcM83gRp5iqYcLJ3ZqG8t0yWAqTACa6/DD4sthaqy9ZkVCRTVS8vzDdzbAYqmDXrV Dmbt8LsH+K+XzlHQSRqW3tO5R0MG4b0wY8G8wBPUlYlfeEz0kQL+jJRHz6LZnmdOOrOiUUIK66n 8bRQSXXqfwTgvyG7Jrhb7EVw73KxpI0+EoRwsP5DeQ467oVPz/qCKj0tr9vHjB5dKmuyp8eH2x3 dcvA4kkBoMP2mlw== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788787003556154100 Those tests use "info registers" command and cannot be converted easily, for now skip them Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- tests/functional/m68k/test_nextcube.py | 1 + tests/functional/ppc/test_ppe42.py | 1 + 2 files changed, 2 insertions(+) diff --git a/tests/functional/m68k/test_nextcube.py b/tests/functional/m68k= /test_nextcube.py index f3d92034b127..e7fca50292b6 100755 --- a/tests/functional/m68k/test_nextcube.py +++ b/tests/functional/m68k/test_nextcube.py @@ -28,6 +28,7 @@ def check_bootrom_framebuffer(self, screenshot_path): =20 self.vm.add_args('-bios', rom_path) self.vm.launch() + self.skipTestIfNoHMP() # FIXME: QMP x-query-registers =20 self.log.info('VM launched, waiting for display') # Wait for the FPU test to finish, then the display is available, = too: diff --git a/tests/functional/ppc/test_ppe42.py b/tests/functional/ppc/test= _ppe42.py index 53958a7938d1..a9c154f67328 100755 --- a/tests/functional/ppc/test_ppe42.py +++ b/tests/functional/ppc/test_ppe42.py @@ -72,6 +72,7 @@ def test_ppe42_instructions(self): self.vm.add_args('-device', 'loader,addr=3D0xfff80040,cpu-num=3D0') self.vm.add_args('-action', 'panic=3Dpause') self.vm.launch() + self.skipTestIfNoHMP() # FIXME: QMP x-query-registers self._wait_pass_fail(self.timeout) =20 if __name__ =3D=3D '__main__': --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:00:46 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788786999; cv=none; d=zohomail.com; s=zohoarc; b=D2kUOVg/L0VbMp3rWyFQl0p0UdtzlmETy5JUFMgwni7L8QYL+l7eZjQ+lI9mw/UarYgPrm2HEbjS12NIh5yCuLT95AqSi/+uGVdz1yLY/nmitA6iklE3rP4stI1GHH4CXZqCpruf4Xl2PZFfWN2g20dqK1X35Ll5Sy0DuH7Kqqw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788786999; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=62mvN3+6Ik4rJgbtSXh3PbCH0A6py8ADyiqg0AkiFTs=; b=B2xzWL7DhzGHC6gAxvb6dd2ljobkrcb3xDWU+Loo/0YHs7r38j455o9S/Cplg7X2Z/SBzX3ewq23Y8uWfeFFzXD1gkPHdNLR5pyMdMwyYYttAekeeOOBnGZRSEwLN9RKx3y11eG1O41x13NEdgkqrHcswfjtQS2qab1PKd3g810= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788786999777496.9796895235778; Mon, 7 Sep 2026 06:16:39 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x3ZBd-00051i-TN; Mon, 07 Sep 2026 09:15:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3ZBL-0004lL-K8 for qemu-devel@nongnu.org; Mon, 07 Sep 2026 09:14:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3ZBJ-0006Zg-BY for qemu-devel@nongnu.org; Mon, 07 Sep 2026 09:14:42 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-121-HSNUZ_GjOa-4QEOK_vldYA-1; Mon, 07 Sep 2026 09:14:31 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 684421954AE0; Mon, 7 Sep 2026 13:14:19 +0000 (UTC) Received: from localhost (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9657F1955F06; Mon, 7 Sep 2026 13:14:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788786879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=62mvN3+6Ik4rJgbtSXh3PbCH0A6py8ADyiqg0AkiFTs=; b=Yxxe98J9Y35gfyWErNYJnvkbPLqjiGRloZcwYEcQPUDR0GcvM7qCGlMXJsQi5vAGnT0H5D J0B6drPP/FHIHOphWp2KsA4pXAjwLWZHPE2IOCBAd3Gc3/46XnPncvstBCx+lI3YYzPd4k X+ccNy/YazsUdYU99vGW2rgOEwaJHq4= X-MC-Unique: HSNUZ_GjOa-4QEOK_vldYA-1 X-Mimecast-MFC-AGG-ID: HSNUZ_GjOa-4QEOK_vldYA_1788786859 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 07 Sep 2026 17:13:58 +0400 Subject: [PATCH v3 4/9] tests/functional/s390x: use QMP for balloon MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-nohmp-v3-4-c11e7d0d3d7d@redhat.com> References: <20260907-nohmp-v3-0-c11e7d0d3d7d@redhat.com> In-Reply-To: <20260907-nohmp-v3-0-c11e7d0d3d7d@redhat.com> To: qemu-devel@nongnu.org Cc: John Snow , "Denis V. Lunev" , Fabiano Rosas , Laurent Vivier , Paolo Bonzini , qemu-block@nongnu.org, Peter Maydell , Thomas Huth , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Aurelien Jarno , qemu-arm@nongnu.org, Halil Pasic , Christian Borntraeger , Eric Farman , Matthew Rosato , Cornelia Huck , qemu-s390x@nongnu.org, =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Glenn Miles , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1417; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=090HS6zLuSEZTINBqsIWMEfBWo0e9Nx0kELk6Jj7tAY=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnriXrUSpL4DQNyuUbQOvO1FhBmFAi0kYCJrVG +PF2DlajRaJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap64lwAKCRDa6OEJdZac 5dbWD/9seRKQBe//1mKwGDdX3edyT6T0eCwZwt7+XMBsz7QvcQp8fGwrzWtWK3QKvhPfZTClXPI yqx1mZG6rlV1RaLMorbiBa7aXMDJEJP1BF6JMsPL+FEF2qxkEyLH5lrcsMUzEkqZZ9b/Jdor5GW k/fl8W6dFFxusZr9BVr3R9V/OUuCqMsTa72e/btmR+9Mj/ABxPtHiAJ0xvj7OgnZoU16KPek6nD 7k7qSdzsDb8cysgHfAvLVjth0JnHgXSIxtYwEZ31VYVrQMy6CLMEPNy7f9YZvUv2kOw5ru2GZEJ kA/82PwZhBSwNmWR508k1op9bxir/cJfT5lfxfyZAItLSYXv+nqQaqZ0zCHWlv+M6uVKEnFli5s QcFArUXENDxOYe8A9VkzNYbWnpPpJuSXa5nu4gpuo1wzt5xhaVrmWl5smgICXCEJH1qyvdCGNsy 6UPPEWOlsoJgJAsMLmlp4QkP8aRxrQnSM0FVJ65neeHgKec3UrQQL3JaU6hPzjzm1HXwcUtvI/s mNp5jPNVjuz+FnWf1qsb5eZmBd99aGiBYfvrY4PLI1S/lkcAPPd465i3FqmFVQzFBYalrWkptqL GMIWIRdrQAMo5x8njaxgSjpVQX7xvZEyULGxRNksDtKroaHV2vPdRXzuGE2Fei6x5FSiM+KICaN WYnQmj3V0qyyWaA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788787003459154100 Unit is changed from megabytes to bytes. Reviewed-by: Thomas Huth Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- tests/functional/s390x/test_ccw_virtio.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/functional/s390x/test_ccw_virtio.py b/tests/functional/s= 390x/test_ccw_virtio.py index 1d4958bbe293..f816b1e201a1 100755 --- a/tests/functional/s390x/test_ccw_virtio.py +++ b/tests/functional/s390x/test_ccw_virtio.py @@ -162,10 +162,10 @@ def test_s390x_devices(self): # test the virtio-balloon device exec_command_and_wait_for_pattern(self, 'head -n 1 /proc/meminfo', 'MemTotal: 115640 kB') - self.vm.cmd('human-monitor-command', command_line=3D'balloon 96') + self.vm.cmd('balloon', value=3D96 * 1024 * 1024) exec_command_and_wait_for_pattern(self, 'head -n 1 /proc/meminfo', 'MemTotal: 82872 kB') - self.vm.cmd('human-monitor-command', command_line=3D'balloon 128') + self.vm.cmd('balloon', value=3D128 * 1024 * 1024) exec_command_and_wait_for_pattern(self, 'head -n 1 /proc/meminfo', 'MemTotal: 115640 kB') =20 --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:00:46 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788786909; cv=none; d=zohomail.com; s=zohoarc; b=TUXzGNVp6TjiQ6ndB+GtcjEkmfTwljRhDeqWgwxVypv+N3y6msRTZgEmsy7W/4knttraOXeOjNLJl/pN2Brcp7/osDOE1isfg5xaDyuAI+RTrj+ik5+xELbjmCrILYO1ixIJhQj7AzYvcs9suahEVB5L4BT71WfOBux9cyXn6Pk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788786909; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Pw8oM7XvTZ8UrOcsyDmNklaQrGBxEBQh+OPjYQaTMXA=; b=DTQJO2KFtM5gBnJyU9xyUUDaGnPoHAwB7BLUJ+Gp5fZHHpU4GB4vTTAUo+bfYU2rK46d/6Gtq0baLAlL7bGehLd/vZ0u+XUwQnU20dsfQB5UUImbL9/KDD4qSxdMpDMj9gHE7yK72j6y8iA7eRzVHzFMtEAyLpVf3CdvpygjnDo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788786909688619.080907722582; Mon, 7 Sep 2026 06:15:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x3ZBC-0004Of-MS; Mon, 07 Sep 2026 09:14:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3ZB7-0004GA-RZ for qemu-devel@nongnu.org; Mon, 07 Sep 2026 09:14:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3ZB6-0006Ur-Dp for qemu-devel@nongnu.org; Mon, 07 Sep 2026 09:14:29 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-645-LYzyo8GAMNubhkpZBvJncQ-1; Mon, 07 Sep 2026 09:14:24 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A3A1118052CD; Mon, 7 Sep 2026 13:14:22 +0000 (UTC) Received: from localhost (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B5123423; Mon, 7 Sep 2026 13:14:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788786867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pw8oM7XvTZ8UrOcsyDmNklaQrGBxEBQh+OPjYQaTMXA=; b=BQYaFfRtDiDqZ3t5nYHGQ8lZ8XNT20atLzVaL8brOpi1amb3Duk9tGUsVMilHBubd97W9E 2kA/Jd1xTrxHgGo7KyXsT1RRvxO+tVLAvkWnSMKE1+4rxznIiBtIcYPsolf/DwO70YVpSo v6BsgBJLMbLj+6PLfNEUYjHT+jyDi+g= X-MC-Unique: LYzyo8GAMNubhkpZBvJncQ-1 X-Mimecast-MFC-AGG-ID: LYzyo8GAMNubhkpZBvJncQ_1788786862 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 07 Sep 2026 17:13:59 +0400 Subject: [PATCH v3 5/9] tests/ahci-test: replace HMP usage with QMP MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-nohmp-v3-5-c11e7d0d3d7d@redhat.com> References: <20260907-nohmp-v3-0-c11e7d0d3d7d@redhat.com> In-Reply-To: <20260907-nohmp-v3-0-c11e7d0d3d7d@redhat.com> To: qemu-devel@nongnu.org Cc: John Snow , "Denis V. Lunev" , Fabiano Rosas , Laurent Vivier , Paolo Bonzini , qemu-block@nongnu.org, Peter Maydell , Thomas Huth , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Aurelien Jarno , qemu-arm@nongnu.org, Halil Pasic , Christian Borntraeger , Eric Farman , Matthew Rosato , Cornelia Huck , qemu-s390x@nongnu.org, =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Glenn Miles , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1418; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=tLrFlT/tcpYg1fK592+t5TVWs+WZQ4KtzWrEIWmaBQ8=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnriXc5LBDgVtbRkRFePpShWWIeLUbC2OeKKV3 ZhZa5PYU+uJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap64lwAKCRDa6OEJdZac 5XcMD/9/GCmU93V7jB5BV2PvDd5SZsGfXacd27sSJFRRaVZRDRSvWYCNAofPYDmGv6qdiT9bupk AjGM5M21NJ6lRZoQXbI59pzAQZhA1xVVW4oXwafLyvUPJIMkXdWyzYQMKi++Gz4r5YGXmalPk2J pfTGpAVhsfxxinOoB82y7Rih9544vN6h5a8v1T9OngE/9gf4+jzEPsghyCVq5/gyHF2Ejp1BkWC LslAN5zjextgdPDwNBpiM6OCNuV5F7MuzDSBZTAjoYlBiBFl7R2CA+TWuoHhuSE0t17htENuDLd 2GedE2IZBhfZKaujjPzP1ju2Tk1uYA+KvE1WutipxUBsJDbRWzrc829HMHfsHq5RsrRdtPOZ3d0 hTVkrmGd3jpcJClOY3oqM+Zzl6WmkALRuDQ6SPprbqYrTX/M4Z/TfMk9g21ZsVXfelCKafuAuWp MuREqiSqoeYPwlHCFuvltIG666noYYbBoIBosEbpxwEJ3378tWyfc9T8moFGEjtfawE9G2RXfbw 8TQWMmLo3I/Dqyw9NAZePOP0MNAVpE541ZJxv4YQbGIceFucDsZOVZnYK9LRY5U8gwF7J70PM4X pqGN9MnD1VJqM5qUT0oS8hanNupn7CL+J8qdYDnNUk+JWIYEiraskTZ1Yc+2v3U1CkU/prB+0Wq SgRAzmyGy9tdssw== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788786914171154100 Use qemu-io command instead. Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Denis V. Lunev --- tests/qtest/ahci-test.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/qtest/ahci-test.c b/tests/qtest/ahci-test.c index 3406ca884fb4..eb8d23999738 100644 --- a/tests/qtest/ahci-test.c +++ b/tests/qtest/ahci-test.c @@ -1900,8 +1900,7 @@ static void test_write_engine_stop_in_flight(void) ahci_io(ahci, port, CMD_WRITE_DMA, rx, AHCI_SECTOR_SIZE, 1); =20 /* Suspend the backend write so the first sector stays in flight. */ - g_free(qtest_hmp(ahci->parent->qts, - "qemu-io drive0 \"break write_aio wr\"")); + qtest_qemu_io(ahci->parent->qts, "drive0", "break write_aio wr"); =20 cmd =3D ahci_command_create(CMD_WRITE_PIO); ahci_command_adjust(cmd, 0, ptr, bufsize, 0); @@ -1911,7 +1910,7 @@ static void test_write_engine_stop_in_flight(void) /* Drop the command list while the write is still outstanding. */ ahci_px_clr(ahci, port, AHCI_PX_CMD, AHCI_PX_CMD_ST); =20 - g_free(qtest_hmp(ahci->parent->qts, "qemu-io drive0 \"resume wr\"")); + qtest_qemu_io(ahci->parent->qts, "drive0", "resume wr"); =20 /* Round-trip through the device to confirm qemu is still alive. */ ahci_px_rreg(ahci, port, AHCI_PX_TFD); --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:00:46 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788786962; cv=none; d=zohomail.com; s=zohoarc; b=jcxNvzAEeLAHN90m9mwRBmpmjrzm/7LxCiHml/JbmcPeAqlk9Cfl9yG0nVQDdIUWYl+iT8z1tg1AGtN91UsPS4BoQF/pU0ouWY+XdzV7lADzGxJjkEEeJMLT7YPGqnbACN6yigt7ej2qR/r4ACfx1FarnwxhfqsGTAmeKgmBmhk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788786962; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gkIrdElfeW1EwKlyXLCMJxCcIAp+LN1RtWIxRrsNopg=; b=eclBrwGtlK/DlGzBufgZJcx87WMLoG6AmnneX6O0SNvFO88f5e9G8DwzX2uv+fjuP9zMJZRIzksQ8e9dftXMooo1w1+RiCa2OWqxyV7Vs/294BSeZoxaIcqc3CNxoFUIUDNF3wBWmBhOrG/Obqx+xOCptVftRNDgnGEviVXvNAg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17887869629191005.4146678759305; Mon, 7 Sep 2026 06:16:02 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x3ZBH-0004e7-W5; Mon, 07 Sep 2026 09:14:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3ZBD-0004Rp-Ct for qemu-devel@nongnu.org; Mon, 07 Sep 2026 09:14:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3ZBB-0006WZ-07 for qemu-devel@nongnu.org; Mon, 07 Sep 2026 09:14:35 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-607-OX5vrTA3MDeeJ3BHAWp2_g-1; Mon, 07 Sep 2026 09:14:29 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0FA171800EC7; Mon, 7 Sep 2026 13:14:27 +0000 (UTC) Received: from localhost (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A17AC30001A2; Mon, 7 Sep 2026 13:14:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788786872; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gkIrdElfeW1EwKlyXLCMJxCcIAp+LN1RtWIxRrsNopg=; b=C192MzzdEh3Z2vv8mXvVzhkQBxFQUtwCdDa8qvFlLTABgWM+EVuE1TqgDSTf25a9XTMUFO uvTOo1R34pu7QUBuZDI3WAKsi8IisyG2MEAb+e+U2Qz7kVcgWxoM8xphtVAJSEnrPqhiv8 zrSBWX5eEVaZx+IzffiibasNZBQYo4I= X-MC-Unique: OX5vrTA3MDeeJ3BHAWp2_g-1 X-Mimecast-MFC-AGG-ID: OX5vrTA3MDeeJ3BHAWp2_g_1788786867 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 07 Sep 2026 17:14:00 +0400 Subject: [PATCH v3 6/9] tests/qtest: add qtest_qmp_job_wait() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-nohmp-v3-6-c11e7d0d3d7d@redhat.com> References: <20260907-nohmp-v3-0-c11e7d0d3d7d@redhat.com> In-Reply-To: <20260907-nohmp-v3-0-c11e7d0d3d7d@redhat.com> To: qemu-devel@nongnu.org Cc: John Snow , "Denis V. Lunev" , Fabiano Rosas , Laurent Vivier , Paolo Bonzini , qemu-block@nongnu.org, Peter Maydell , Thomas Huth , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Aurelien Jarno , qemu-arm@nongnu.org, Halil Pasic , Christian Borntraeger , Eric Farman , Matthew Rosato , Cornelia Huck , qemu-s390x@nongnu.org, =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Glenn Miles , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=2759; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=h9iGsvL7MMHY6Qm8hZ2uOnGK9+m0yedLi5VjofxU7do=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnriXLGSEC4p0WfK+IOfmjT8Molq4mpgNKgKfg +IgbFzUOoqJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap64lwAKCRDa6OEJdZac 5XPAEACiQRJAO1OYVGPHTORO4Q8uzkQnuEeF0R9K7F9p3ojIwhIgcbb03POsUeEp/OQ9eNewJu5 9Xs8N/JHb7IkdIMvvpJHNqkFT7OdGPSQ3Z2QxwpvnIpBmfRr2Ion4KQnMzOOdJQBsBtt3yjvrSd OzPuY+DHgK4sNEVlAyZyNv2wD5AjUZducj2E0FAVXNg+wlw502c1wOON3tuapWIOsB02N57o/3N yqJB6T9XASIzKXdYUMEp3albXjBNswyTCKj62KPVkInYFJfqi0qQb+vlNToUiooNmdW46ipOcDm DqAw9lCxaO5P9GJkw3b55823E7viXNnFGDWbI+aLEPK1HFQ+9FMZrgOXAZfz+1jhQGYADgpjL9K Rv39NlqIUoap7NrkYBKIygkMoiauwJx3kEA23Mpz3H1GHCrsZYWbUwX1NR/vCjSWEkK4xrz7Vps fIlcGYJypkM7TbL7lnPDGRzWX44baKUai8Dy9WJdl2PqtK2ZOHq8IQq9HK/kNuoRwo2WFQpmVDw fTx96qHraZNggrP7sfDZXg2icQbjnkI1yqVHgU6U2GTmfrCZWQG4EDPSDNvMl7nXFczCxNH2K2w O/CCraN7FXXgJ60DgyI3bmTVyrgEQfwjN0wqjlsFfS8wMCyh7GBpfZgNyxgr+WFLjFUl64+Wppj mUw2RXlPWCSSChw== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788786964205158500 Add a helper to wait for job conclusion, used in next changes. Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- tests/qtest/libqtest.c | 37 +++++++++++++++++++++++++++++++++++++ tests/qtest/libqtest.h | 11 +++++++++++ 2 files changed, 48 insertions(+) diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c index 28bb72bfaecf..370f79a3b6fb 100644 --- a/tests/qtest/libqtest.c +++ b/tests/qtest/libqtest.c @@ -984,6 +984,43 @@ void qtest_qmp_eventwait(QTestState *s, const char *ev= ent) qobject_unref(response); } =20 +void qtest_qmp_job_wait(QTestState *s, const char *job_id) +{ + QDict *response, *data, *error; + QList *jobs; + const QListEntry *entry; + + for (;;) { + response =3D qtest_qmp_eventwait_ref(s, "JOB_STATUS_CHANGE"); + data =3D qdict_get_qdict(response, "data"); + if (!strcmp(qdict_get_str(data, "id"), job_id) && + !strcmp(qdict_get_str(data, "status"), "concluded")) { + qobject_unref(response); + break; + } + qobject_unref(response); + } + + response =3D qtest_qmp(s, "{ 'execute': 'query-jobs' }"); + g_assert(qdict_haskey(response, "return")); + jobs =3D qobject_to(QList, qdict_get(response, "return")); + g_assert(jobs); + QLIST_FOREACH_ENTRY(jobs, entry) { + QDict *job =3D qobject_to(QDict, qlist_entry_obj(entry)); + if (!strcmp(qdict_get_str(job, "id"), job_id)) { + g_assert_null(qdict_get_try_str(job, "error")); + break; + } + } + qobject_unref(response); + + response =3D qtest_qmp(s, + "{ 'execute': 'job-dismiss', 'arguments': { 'id': %s } }", job_id); + error =3D qdict_get_qdict(response, "error"); + g_assert_null(error); + qobject_unref(response); +} + char *qtest_vhmp(QTestState *s, const char *fmt, va_list ap) { char *cmd; diff --git a/tests/qtest/libqtest.h b/tests/qtest/libqtest.h index 58491ca53ab7..f06e061d214b 100644 --- a/tests/qtest/libqtest.h +++ b/tests/qtest/libqtest.h @@ -398,6 +398,17 @@ QDict *qtest_qmp_eventwait_ref(QTestState *s, const ch= ar *event); */ QDict *qtest_qmp_event_ref(QTestState *s, const char *event); =20 +/** + * qtest_qmp_job_wait: + * @s: #QTestState instance to operate on. + * @job_id: job identifier to wait for. + * + * Wait for a QMP job to reach "concluded" status by consuming + * JOB_STATUS_CHANGE events, then dismiss the job. + * Asserts that the job completed without error. + */ +void qtest_qmp_job_wait(QTestState *s, const char *job_id); + /** * qtest_hmp: * @s: #QTestState instance to operate on. --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:00:46 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788787009; cv=none; d=zohomail.com; s=zohoarc; b=OQwYfK1xoo8VWVgyY8DbUOfKy2KBNV+v4WUU6t1/H9EhiRUre897wYAYBZbeyMZuHbUbpAB46VOd4Qr2T8R4UjoU2Ept1+JUxWzjQgXr0XX+3DImkV1wMdTPN7rK8egJQ9cyTwmnyTAezcZ2GNFdfvXkKfuQZ0t88wESjPUgkNw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788787009; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=aoHiToUGAMMc7R5tO/URvtcB1gdA7zvemloBOxAK2DI=; b=SqfZvvytqVwNDo8/blpDGvoZojVP0n4/XIhXDfZLiPjFnA8eiFkYiE9l3H+MGZbmDnNFO4CNnlBBuT1IuX7Az1gX977o6vo3tzXWd5kbpe1W69+IUcX66HNpvVuYe7s5Wb0Rg8nxjWkzl5ANwOBAIRPpsXQ4tc+lYYmoIlKAsjk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788787009589831.5016634216096; Mon, 7 Sep 2026 06:16:49 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x3ZBI-0004gY-NH; Mon, 07 Sep 2026 09:14:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3ZBG-0004YV-Eb for qemu-devel@nongnu.org; Mon, 07 Sep 2026 09:14:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3ZBE-0006Xf-Q0 for qemu-devel@nongnu.org; Mon, 07 Sep 2026 09:14:38 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-687-ngI4UzHXPceQ6iyR-MDQOQ-1; Mon, 07 Sep 2026 09:14:32 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A5C3D1955F1D; Mon, 7 Sep 2026 13:14:30 +0000 (UTC) Received: from localhost (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 62C39423; Mon, 7 Sep 2026 13:14:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788786876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aoHiToUGAMMc7R5tO/URvtcB1gdA7zvemloBOxAK2DI=; b=cqtDd2Vu7J0B72aMdY42wH2bam0+n60KEt/1yl6ilKn7yWq69rZPnXIVsS4QhC2zHjtVPE MZHdCbEfEygUwBMpiWTM0j5W1RcWRJEUNFFYgmmDP+y4bPnqbKfkUfx89hhlcWEZlrItD3 eepqe6fMwxtQQdn781DgtTU4aZ6Z+6I= X-MC-Unique: ngI4UzHXPceQ6iyR-MDQOQ-1 X-Mimecast-MFC-AGG-ID: ngI4UzHXPceQ6iyR-MDQOQ_1788786870 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 07 Sep 2026 17:14:01 +0400 Subject: [PATCH v3 7/9] tests/ide-test: convert to QMP MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-nohmp-v3-7-c11e7d0d3d7d@redhat.com> References: <20260907-nohmp-v3-0-c11e7d0d3d7d@redhat.com> In-Reply-To: <20260907-nohmp-v3-0-c11e7d0d3d7d@redhat.com> To: qemu-devel@nongnu.org Cc: John Snow , "Denis V. Lunev" , Fabiano Rosas , Laurent Vivier , Paolo Bonzini , qemu-block@nongnu.org, Peter Maydell , Thomas Huth , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Aurelien Jarno , qemu-arm@nongnu.org, Halil Pasic , Christian Borntraeger , Eric Farman , Matthew Rosato , Cornelia Huck , qemu-s390x@nongnu.org, =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Glenn Miles , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=2957; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=bnu0nsKu9/3amglgx/1TloBIQkah/oVYczwxwKZZtsQ=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnriY0PUf6M8fi7Yo84q5+2kn/3saU3J0Z0lc+ QnhKk/C2sWJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap64mAAKCRDa6OEJdZac 5bLRD/oDURKyg/Z+/r3WqZ2c/V+Et9BhE9UmWNm0XgliwVW2IC4U4iBd05/dc5Jdr5IWYJxxKOb VGIrvAeOL6f+PmWlf4r4zk+jmExysQ4eR/okI2hsi1/m93ZkFo+Y0vs2JbkkDy8aufUNoekEVo6 ZYQaSYP4EgIAikqpffI8jS1heWLVDQs7KB/q0sS1c4QRHRz/71DCCGS2J1g3T+ej30/9MDW0KnA m+EBjkPeikVEwuFfrqDgcRSyOc6SxLL6Cvls5e+Dd+0DY+ju0FW1RNHOzLxSwVRAUkk1LaTbyo4 todxqaV10bfzMq0M/v/SyTJZCfXPrCUBuQff2kL9neiX4uyN5PTk/aTllm0heaesruzlq5U3UbX N+Q1WrOrA5PIZ/hJsRhvdU9SqqTGF4dFgV27AH+upGrG+P2PlGRuc+357wDA2jdmHNttCkfQlSo tQl+nDRa6flu+l/ykEG1+bQGlRESlERqo8CMXvSOxsm1yiJdlrNeFtSNCZBT8VDI9o54Rwpq8CT O9nFcCUdqZoEzloh4nWGgO9s/rfKtlWWgrvky/NtM+SMtIa9eIXB2vCU7e5Xk0q0JztEQ9nqAtB hDB1/MeM0HU/rWDFAm/tVhQ17rfh5CQiNf9uy5W2jdBwzwaFWJAHyHiQKoS+Vn8clPWPs5tUSZa 3c69NPN3yzR7PMA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788787013483154100 The QMP command is explicit, specify both the vmstate and devices. We use the helper introduced previously to wait for job completion. Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Denis V. Lunev --- tests/qtest/ide-test.c | 37 ++++++++++++++++++++++++++++--------- 1 file changed, 28 insertions(+), 9 deletions(-) diff --git a/tests/qtest/ide-test.c b/tests/qtest/ide-test.c index 895fec6d0806..cf109b079982 100644 --- a/tests/qtest/ide-test.c +++ b/tests/qtest/ide-test.c @@ -1345,11 +1345,34 @@ static void ide_prepare_markers(QTestState *qts, QP= CIDevice *dev, ide_write_marker(qts, dev, ide_bar, 63, CHS_MARKER_DEFAULT); } =20 -static void ide_hmp_quiet(QTestState *qts, const char *command) +static void ide_snapshot_save(QTestState *qts, const char *tag, + const char *vmstate, const char *device) { - g_autofree char *out =3D qtest_hmp(qts, "%s", command); + qtest_qmp_assert_success(qts, + "{ 'execute': 'snapshot-save'," + " 'arguments': {" + " 'job-id': 'save0'," + " 'tag': %s," + " 'vmstate': %s," + " 'devices': [%s]" + " }" + "}", tag, vmstate, device); + qtest_qmp_job_wait(qts, "save0"); +} =20 - g_assert_cmpstr(out, =3D=3D, ""); +static void ide_snapshot_load(QTestState *qts, const char *tag, + const char *vmstate, const char *device) +{ + qtest_qmp_assert_success(qts, + "{ 'execute': 'snapshot-load'," + " 'arguments': {" + " 'job-id': 'load0'," + " 'tag': %s," + " 'vmstate': %s," + " 'devices': [%s]" + " }" + "}", tag, vmstate, device); + qtest_qmp_job_wait(qts, "load0"); } =20 static char *ide_migration_status(QTestState *qts) @@ -1455,10 +1478,6 @@ static void test_migrate_chs_snapshot(void) char marker[9]; int fd; =20 -#ifndef CONFIG_HMP - g_test_skip("HMP not enabled"); - return; -#endif if (!have_qemu_img()) { g_test_skip("QTEST_QEMU_IMG not set, snapshots need a qcow2 image"= ); return; @@ -1480,13 +1499,13 @@ static void test_migrate_chs_snapshot(void) /* Snapshot taken while the default translation is in effect */ ide_read_chs_marker(qts, dev, ide_bar, 0, 1, 1, marker); g_assert_cmpstr(marker, =3D=3D, CHS_MARKER_DEFAULT); - ide_hmp_quiet(qts, "savevm s0"); + ide_snapshot_save(qts, "s0", "hda", "hda"); =20 ide_set_translation(dev, ide_bar, 8, 32); ide_read_chs_marker(qts, dev, ide_bar, 0, 1, 1, marker); g_assert_cmpstr(marker, =3D=3D, CHS_MARKER_CUSTOM); =20 - ide_hmp_quiet(qts, "loadvm s0"); + ide_snapshot_load(qts, "s0", "hda", "hda"); =20 ide_read_chs_marker(qts, dev, ide_bar, 0, 1, 1, marker); g_assert_cmpstr(marker, =3D=3D, CHS_MARKER_DEFAULT); --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:00:46 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788786988; cv=none; d=zohomail.com; s=zohoarc; b=MKzuPmri86e1BwmlxCcr9DFVO0MDIF70RaQWrZHK6KAaFgA3bPPIYGjUBfK4qnGcoq2uOGJAzj/ENFQuHfkKfZvECVT3ClZsFFAKAmaKUhyDrQZwfiItgkwj4in6ZKDN8KAW8NpuYc4tgOPECHeEnC33ho340dd0RdIoJ1pmtxw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788786988; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=cr17daom5ZIwPL1Jm52XNja1f8W6vz7SjHDPV0FRzto=; b=WI5VUWXhUA5DVe7VFKY9zWF9zFfjnzpj7Qgcq6t7ogpMtX5vo7VF7Y5fb5BgLzRvPAeV3Kj2K1GHR1nvejq0r7RhL3Lt3kbqXVE/UjI00v9u6kwcBCX3uiKsZLDomzs0i+zjlQfApb4Ri8PutfqUxi9VM2lKVPdXdK/4cAtUgoM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788786988025296.71774771066634; Mon, 7 Sep 2026 06:16:28 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x3ZBe-00056X-PF; Mon, 07 Sep 2026 09:15:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3ZBL-0004lS-Pv for qemu-devel@nongnu.org; Mon, 07 Sep 2026 09:14:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3ZBJ-0006aI-7u for qemu-devel@nongnu.org; Mon, 07 Sep 2026 09:14:43 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-163-_D3_7q06OtuGTCyig4Sddg-1; Mon, 07 Sep 2026 09:14:36 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2859E19540EA; Mon, 7 Sep 2026 13:14:34 +0000 (UTC) Received: from localhost (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 538F41956049; Mon, 7 Sep 2026 13:14:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788786880; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cr17daom5ZIwPL1Jm52XNja1f8W6vz7SjHDPV0FRzto=; b=cbbvtIF23QIf1B4assJKPhpANJMYtXqKDREfKadCe8OdlB0WTkoH7N78N0UC+dq/UQT01L RafnpLymGfzrN8hVfdrGXJ1CyfEj+aIbSWFUFfBXHcjZdajryKkS/sdWhXQoOa0ZBmSLvF V0Sw0lw4THBq1um6wvLL0Wchk8W0TIE= X-MC-Unique: _D3_7q06OtuGTCyig4Sddg-1 X-Mimecast-MFC-AGG-ID: _D3_7q06OtuGTCyig4Sddg_1788786874 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 07 Sep 2026 17:14:02 +0400 Subject: [PATCH v3 8/9] tests/drive_del-test: compile out HMP-dependent tests when !CONFIG_HMP MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-nohmp-v3-8-c11e7d0d3d7d@redhat.com> References: <20260907-nohmp-v3-0-c11e7d0d3d7d@redhat.com> In-Reply-To: <20260907-nohmp-v3-0-c11e7d0d3d7d@redhat.com> To: qemu-devel@nongnu.org Cc: John Snow , "Denis V. Lunev" , Fabiano Rosas , Laurent Vivier , Paolo Bonzini , qemu-block@nongnu.org, Peter Maydell , Thomas Huth , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Aurelien Jarno , qemu-arm@nongnu.org, Halil Pasic , Christian Borntraeger , Eric Farman , Matthew Rosato , Cornelia Huck , qemu-s390x@nongnu.org, =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Glenn Miles , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=3999; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=nELlHO8Wk8s5vJ916Mup0ugCUbfnyL7FDxtNlquSMtI=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnriY5ksk5tlMx9HxnK7ZP5j7BgAd7gphBwgJw 1JSb8WaMOyJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap64mAAKCRDa6OEJdZac 5eQ8D/9/nJeQ5dhyvSePSs8YQ2/dq2K4Jw599gFL81MDr6kKXKvv8yVeyqBtNL0kR5uq7MGyOx4 Fzh4JAJsr5oZPqSgiC6A2nBdUgt7Awv9/xCCfc2H87RB7Cf4lWH8wE+NLNd8IP5yPoTfZm0qil7 fZTowNQz43vo8QSYmJDIRDwIvX+abYTh5zFvF8JYPCzFlGTec/Q/aNwy3srWmQmqpWFW4vn8lod SHeTrR0C1rw4oh7HKPOOJ8obT/ASnuJAb7PqSTxvzscaMuHCG5ticwikOFClHb5KDFqI6CAmTsH GZCuZwhG/6TZfHpie0kpHO6WLsP8IcvIvz7gMWsttfO0ol/kXbwDCGkL0dotWz0nZD2842/QHNs s8cuaseITwMEbC7aC0eQ8NADxU8R7d3u/CIDiupXMGmg0azMoEBIrgaGsM+fVzvYRLbYeFdGJG7 VjxHIi3+NUf3kaTmRHWhE51yW9g9+U4shQ+UQangR1IvzKYzrEkRaiCYhy54az3N0vZbGaY8OwK aKeE2AmBQq585R9sp8P2J+XOqSvRmdGnnyy87Z9hF93uIkuVtpxgxYSVnnR5wc0mOtz+AA9+Z8o AXeOGaBLpbgJNRlZZih31drVAiGUgCMEoSZ4sBc6MauGClvBmyrVtA1o0eJr4Fa/kHPX3E5SqFm frDstZYrPtwhO+g== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788786989875158500 The compiled-out functions are actually testing HMP-specific commands and behaviour which operate on the old "drive" concept. The QMP equivalent for block-driver nodes are already tested. If HMP goes away, those tests should go away too. Compile them out. Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- tests/qtest/drive_del-test.c | 47 +++++++++++++++++++++-------------------= ---- 1 file changed, 22 insertions(+), 25 deletions(-) diff --git a/tests/qtest/drive_del-test.c b/tests/qtest/drive_del-test.c index cc52c2d87936..cbf94d5b9f0f 100644 --- a/tests/qtest/drive_del-test.c +++ b/tests/qtest/drive_del-test.c @@ -87,6 +87,7 @@ static void blockdev_add_with_media(QTestState *qts) g_assert(has_blockdev(qts)); } =20 +#ifdef CONFIG_HMP static void drive_add(QTestState *qts) { char *resp =3D qtest_hmp(qts, "drive_add 0 if=3Dnone,id=3Ddrive0"); @@ -117,6 +118,7 @@ static void drive_del(QTestState *qts) g_assert(!has_drive(qts)); g_free(resp); } +#endif =20 /* * qvirtio_get_dev_type: @@ -165,13 +167,9 @@ static void device_del(QTestState *qts, bool and_reset) =20 static void test_drive_without_dev(void) { +#ifdef CONFIG_HMP QTestState *qts; =20 -#ifndef CONFIG_HMP - g_test_skip("HMP not enabled"); - return; -#endif - /* Start with an empty drive */ qts =3D qtest_init("-drive if=3Dnone,id=3Ddrive0 -M none"); =20 @@ -184,19 +182,18 @@ static void test_drive_without_dev(void) drive_add(qts); =20 qtest_quit(qts); +#else + g_test_skip("HMP not enabled"); +#endif } =20 static void test_after_failed_device_add(void) { +#ifdef CONFIG_HMP char driver[32]; QDict *response; QTestState *qts; =20 -#ifndef CONFIG_HMP - g_test_skip("HMP not enabled"); - return; -#endif - if (!has_device_builtin("virtio-blk")) { g_test_skip("Device virtio-blk is not available"); return; @@ -227,17 +224,16 @@ static void test_after_failed_device_add(void) drive_add(qts); =20 qtest_quit(qts); +#else + g_test_skip("HMP not enabled"); +#endif } =20 static void test_drive_del_device_del(void) { +#ifdef CONFIG_HMP QTestState *qts; =20 -#ifndef CONFIG_HMP - g_test_skip("HMP not enabled"); - return; -#endif - if (!has_device_builtin("virtio-scsi")) { g_test_skip("Device virtio-scsi is not available"); return; @@ -259,6 +255,9 @@ static void test_drive_del_device_del(void) g_assert(!has_drive(qts)); =20 qtest_quit(qts); +#else + g_test_skip("HMP not enabled"); +#endif } =20 static void test_cli_device_del(void) @@ -416,15 +415,11 @@ static void test_device_add_and_del_q35(void) =20 static void test_drive_add_device_add_and_del(void) { +#ifdef CONFIG_HMP QTestState *qts; const char *arch =3D qtest_get_arch(); const char *machine_addition =3D ""; =20 -#ifndef CONFIG_HMP - g_test_skip("HMP not enabled"); - return; -#endif - if (!has_device_builtin("virtio-blk")) { g_test_skip("Device virtio-blk is not available"); return; @@ -450,17 +445,16 @@ static void test_drive_add_device_add_and_del(void) g_assert(!has_drive(qts)); =20 qtest_quit(qts); +#else + g_test_skip("HMP not enabled"); +#endif } =20 static void test_drive_add_device_add_and_del_q35(void) { +#ifdef CONFIG_HMP QTestState *qts; =20 -#ifndef CONFIG_HMP - g_test_skip("HMP not enabled"); - return; -#endif - if (!has_device_builtin("virtio-blk")) { g_test_skip("Device virtio-blk is not available"); return; @@ -479,6 +473,9 @@ static void test_drive_add_device_add_and_del_q35(void) g_assert(!has_drive(qts)); =20 qtest_quit(qts); +#else + g_test_skip("HMP not enabled"); +#endif } =20 static void test_blockdev_add_device_add_and_del(void) --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:00:46 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788787007; cv=none; d=zohomail.com; s=zohoarc; b=KjkOMw0DiB+qT2JKqxo/Im5buYJgisHw7asSR3xxta8ygDXrNEFHXuG7pitPUtFLyBy1vuNopveUOsO3ANWYzI3BSmDaXmKU82siWLqz0OOqkZqavSMMz3wi62cs374At0/C9TjuUCNEwCFFIHxaXCsxDgKwoNPIY3H+flIAOfQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788787007; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=vLNU8deII2YV/Np0anR9mXTsHZWaHsyFpOSn0YczNCY=; b=JoJwFfjc4WYxjHjJCY0hOr5Kre2qhj+c7pzQCBTsJDACF3mp6DwZFSSmfrRsvfXcH+Ncs70qbstWwuNHvvIUzBaTkUQjCQ2hJQrUPdK4uyQKIHXC62KJQiDi3mbo+pLmmF+lu2xQoZ31xs4pTdY5fECs7ouNUWeWRv73qXhnLfY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788787007936420.16893109096134; Mon, 7 Sep 2026 06:16:47 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x3ZBf-00059K-CF; Mon, 07 Sep 2026 09:15:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3ZBS-0004oj-4l for qemu-devel@nongnu.org; Mon, 07 Sep 2026 09:14:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x3ZBN-0006bm-Le for qemu-devel@nongnu.org; Mon, 07 Sep 2026 09:14:49 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-348-bQCOLrmBPAmEUJ9UsJydQg-1; Mon, 07 Sep 2026 09:14:39 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8A46C1954AE0; Mon, 7 Sep 2026 13:14:37 +0000 (UTC) Received: from localhost (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5E5F91956044; Mon, 7 Sep 2026 13:14:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788786884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vLNU8deII2YV/Np0anR9mXTsHZWaHsyFpOSn0YczNCY=; b=JDTCQ2NTX9fQ4OWTmEKP2lAmlZUB8qcwcMWd6eX8i2gKTpEcTCABT2naIJ9OUvXFy7/4Bi arwx4NS/SvFnrze2VohK/Gf6H2zoAh5IGja5cGggf+eZLnfsFyrURCd4rbdYw6CxTuTNR1 eshsc5NyJeQutLJh6W2o0Moq+rjq3Tg= X-MC-Unique: bQCOLrmBPAmEUJ9UsJydQg-1 X-Mimecast-MFC-AGG-ID: bQCOLrmBPAmEUJ9UsJydQg_1788786877 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 07 Sep 2026 17:14:03 +0400 Subject: [PATCH v3 9/9] qtest: compile out HMP helper when !CONFIG_HMP MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260907-nohmp-v3-9-c11e7d0d3d7d@redhat.com> References: <20260907-nohmp-v3-0-c11e7d0d3d7d@redhat.com> In-Reply-To: <20260907-nohmp-v3-0-c11e7d0d3d7d@redhat.com> To: qemu-devel@nongnu.org Cc: John Snow , "Denis V. Lunev" , Fabiano Rosas , Laurent Vivier , Paolo Bonzini , qemu-block@nongnu.org, Peter Maydell , Thomas Huth , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Aurelien Jarno , qemu-arm@nongnu.org, Halil Pasic , Christian Borntraeger , Eric Farman , Matthew Rosato , Cornelia Huck , qemu-s390x@nongnu.org, =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Glenn Miles , qemu-ppc@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1572; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=Xa0/LC6u8sESL2zvgI9W3vBYiovc4bTzR3MiwSE4zLE=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnriYFdxCxVJrms6n297kkOV79mUx0r1631Aqu gJGPXXGZQqJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap64mAAKCRDa6OEJdZac 5QifD/4uBSsWz1T/mipf8zo+3g7fr6YcKTvyaJsKNFLIJ+SeeAMoSDnSi0fBw1THJfmlTZrWbJ8 fVNn4Xkp9dj7hxJFAK5LHWFH21F19PqcCtn9/T4JzO0WoD1ypeJOUaFwdabKaZp+JK2srSA4Ljq tb2djvvuw5/FsN+ENFUr27hbDVpFlUpxuXJwMK1qmPoAofh3adzdgwmTzxUmgqvczKm0o/s8fVy e7/IT8faGw1aDKOTg4nR13gxAtfkop2bm58mi6SAiog2rVtW9fdcTkBM1OpgIAJg6qXlruHAy+2 RhlfJFGCInFs1VTolRYicgyywI/mW702OL1oLT0mgIyvwdh/75GOqAWNqaLmuZV0+WKR0qqrwJy +7FsCpnBjLzdbXhDwj/P2iHtA9fU+S3euozFgJwCW/ZLj/qdtWev56RXFHsWxnvKFvwU+vWMNMv oAI8FepNXZzpgBvZ1i9hwWXV6F/GPVemesJOVHEw44YRbir7DLR7J2yjgd/7XRaJCeh46FTl6p+ 9YIV/Ql4/eYlvNzMT5Y14y3BTbabToVI8ifwdFX2awWHqdXuWL7uDYuxiqbBPgKagxXDH1+5TRi uP/z0dXuk6jsBbfglpR2VY9j5cT5bdbT/lDl1yzAseWOe+Ow+X6EUoJf2MAWJJKH4Sgd5c+wpa2 /dTrCKfmR0S3itQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788787009978158500 This should help prevent introducing HMP tests inadvertently. Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- tests/qtest/libqtest.c | 2 ++ tests/qtest/libqtest.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c index 370f79a3b6fb..05d884761540 100644 --- a/tests/qtest/libqtest.c +++ b/tests/qtest/libqtest.c @@ -1021,6 +1021,7 @@ void qtest_qmp_job_wait(QTestState *s, const char *jo= b_id) qobject_unref(response); } =20 +#ifdef CONFIG_HMP char *qtest_vhmp(QTestState *s, const char *fmt, va_list ap) { char *cmd; @@ -1048,6 +1049,7 @@ char *qtest_hmp(QTestState *s, const char *fmt, ...) va_end(ap); return ret; } +#endif =20 void qtest_qemu_io(QTestState *s, const char *device, const char *fmt, ...) diff --git a/tests/qtest/libqtest.h b/tests/qtest/libqtest.h index f06e061d214b..20982d3fe8dd 100644 --- a/tests/qtest/libqtest.h +++ b/tests/qtest/libqtest.h @@ -409,6 +409,7 @@ QDict *qtest_qmp_event_ref(QTestState *s, const char *e= vent); */ void qtest_qmp_job_wait(QTestState *s, const char *job_id); =20 +#ifdef CONFIG_HMP /** * qtest_hmp: * @s: #QTestState instance to operate on. @@ -434,6 +435,7 @@ char *qtest_hmp(QTestState *s, const char *fmt, ...) G_= GNUC_PRINTF(2, 3); */ char *qtest_vhmp(QTestState *s, const char *fmt, va_list ap) G_GNUC_PRINTF(2, 0); +#endif =20 /** * qtest_qemu_io: --=20 2.55.0.543.g5ebe2ebe4ea8