From nobody Sat Sep 26 20:02:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788684937; cv=none; d=zohomail.com; s=zohoarc; b=SjqMRXtz1ZNp3+bc34i6qIfwa7THEt337MEFeesiM1OWQLVDFffJP+D6Klup9Hk/i+Pe6sylsyPgpmLZj7xAKaMHSjUdhKnR+KyvDsl9RIbVopYy12BPI1ZREYmFlXgnEZRg4fNu5IM97BxSe15ehNjGxE2rG7/dXojTYVHLVH0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788684937; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=4f5Z2LkVc6py1w60vXSvnjw7X6VX7rH9O/0eXx9/3+4=; b=EDkkbRYkeSRluSqJ7/NRrdry+k4aJnCGVxcJR/6oQqgFQ1yX8AJAdRWJbxQ4eoB0VKv3WIpllIQLBLo15Ped8WDjgYeqe+papQzi/vWzrfBqcopg7zORlautyfnNMlEJFvgIDSEAd0lv5z9T9m1PsSTIFU/sVcrwmn75EHogdPg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788684937784928.8468256318579; Sun, 6 Sep 2026 01:55:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x38dY-0002Cx-Ko; Sun, 06 Sep 2026 04:54:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x38dW-0002Bv-RN for qemu-devel@nongnu.org; Sun, 06 Sep 2026 04:54:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x38dV-0000k6-DG for qemu-devel@nongnu.org; Sun, 06 Sep 2026 04:54:02 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-284-t8cS4YIfO-SKGlMhtZ-bnA-1; Sun, 06 Sep 2026 04:53:57 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6F0891956040; Sun, 6 Sep 2026 08:53:54 +0000 (UTC) Received: from localhost (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 657E81956042; Sun, 6 Sep 2026 08:53:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788684840; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4f5Z2LkVc6py1w60vXSvnjw7X6VX7rH9O/0eXx9/3+4=; b=PKrFbrHkaAJ2yS/atOagjevcVvfeq4BJdnk5h+OYnCSP2Di0NDBm48a8fwaPGvPY6Afe7W UqnIhCAQGCaAzUzgkIGN+PBINZsbxujFqkD+NllBGYk4A14RH4p2y/IjNZb62Avu7dQMsZ 7PzhqYBRntr1MaB+YGUit+S1pcp42sU= X-MC-Unique: t8cS4YIfO-SKGlMhtZ-bnA-1 X-Mimecast-MFC-AGG-ID: t8cS4YIfO-SKGlMhtZ-bnA_1788684834 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sun, 06 Sep 2026 12:53:33 +0400 Subject: [PATCH 1/9] tests: fix qemu:func-hexagon-linters MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-nohmp-next-v1-1-2b21e63974f3@redhat.com> References: <20260906-nohmp-next-v1-0-2b21e63974f3@redhat.com> In-Reply-To: <20260906-nohmp-next-v1-0-2b21e63974f3@redhat.com> To: qemu-devel@nongnu.org Cc: Brian Cain , Pierrick Bouvier , "Michael S. Tsirkin" , Stefano Garzarella , Paolo Bonzini , Zhao Liu , Peter Maydell , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, Ani Sinha , Gerd Hoffman , Fabiano Rosas , Laurent Vivier , Jared Rossi , Zhuoying Cai , Christian Borntraeger , Jason Herne , Richard Henderson , Ilya Leoshkevich , David Hildenbrand , Halil Pasic , Eric Farman , Matthew Rosato , Cornelia Huck , qemu-s390x@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1664; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=NLhLcoKyivTY8mRtFMa1LO0BDK310UULp9uJ4cn/vqc=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnSoYqTwrsZS++8CPlP07v7ShliTIgOUzU7/d8 Z7NtY8NWQqJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap0qGAAKCRDa6OEJdZac 5dJRD/9X4KOJTJCqrnkaCQ39svDlUdvMb87z4tI70g0NBjvIjPMxSwib+yPECuKkd90483BibGV AW1SPLqgTnZ1x4+JOfT7xC5IWS76D5Uu1Nrku/k2KQj9ugkVHUJDONpSc7kSswipj1KP/YGC8wU 4zpjhLliwuAD6ijaEbUrYBRVEDkSe91CZJcfd1Ot320W+8W2Fj1P5bTrjzzHJ9r+PLkGGVrhQjQ 37w5k8uSFMvqjaERSgEZ36NSjGB+TbDnTvztqBPrEmV03g9V8Fk/WdRNXcuI1v7AlZ/l6e/8fZZ fA4WRh5QoBetzun6l2tMKNie2WK9c43ZN17zO6AcaykJ0qgkaC10g6DieLy9nei3vGAncohpdCO 5FMxrvZDlNKtBp/STuq8kU3cYLWzW5YBCEmvV4rlcHLClEvOhtADKnktEm/Fh2oHSzLIIyLzBzm 3lHZJC2yOISJVjc2lh0uDRbZuL5UOKzqLnWJIEwprFF3g7ZEdl4OCHswYnLpUll2wN6ZvA2zPfi dsLS+ncEEV1YjWu2WETORujZklE2EKHEFrpRgjHzEIUxWM/j23GdBk64oVIkk1fkRCek6cc652M pe0drBztNWEffVzNJdY2muhZ5DsEYAlb1si4zn/a7nfuiSiRolQE22QARcDzHF0CsIkZ7PM3VTP hVw7NJuJn/nG7QQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788684940089154100 Fix pylint W1514: unspecified-encoding Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Brian Cain --- tests/functional/hexagon/test_systests.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/functional/hexagon/test_systests.py b/tests/functional/h= exagon/test_systests.py index f36e015f5021..4b0546e7ad30 100755 --- a/tests/functional/hexagon/test_systests.py +++ b/tests/functional/hexagon/test_systests.py @@ -65,14 +65,14 @@ def test_fopen(self): import tempfile # The fopen binary has a short cmdline buffer; use a short path. dummy =3D os.path.join(tempfile.gettempdir(), "qemu_fopen_test.so") - with open(dummy, "w") as f: + with open(dummy, "w", encoding=3D"utf-8") as f: f.write("valid\n") self.run_exit_zero("fopen", "-append", dummy) =20 def test_ftrunc(self): """ftrunc truncates _testfile_ftrunc from 6 bytes to 1 byte.""" ftrunc_path =3D self.scratch_file("_testfile_ftrunc") - with open(ftrunc_path, "w") as f: + with open(ftrunc_path, "w", encoding=3D"utf-8") as f: f.write("valid\n") # Sleep 1 s so mtime change is observable time.sleep(1) @@ -83,7 +83,7 @@ def test_ftrunc(self): def test_access(self): """access checks R_OK|W_OK on _testfile_access.""" testfile =3D self.scratch_file("_testfile_access") - with open(testfile, "w") as f: + with open(testfile, "w", encoding=3D"utf-8") as f: f.write("valid\n") self.run_exit_zero("access", "-append", testfile) =20 --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:02:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788684940; cv=none; d=zohomail.com; s=zohoarc; b=Vtiug+8SRHj6a+CtQqhXbbkU2ypTRVEnUfEHDaD2vQYp0yp2oPEtoV414OXm/Yz3B6wm0AMf93Ib5MBQ8s70AuDu8V0IkUvsuV0TNkkOjsXhjkpZWhcsLYul608dNkxfW8SdbRNyIqOvkpaiFzhRJhTp9Y6p00rmNqYg+9JOkDE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788684940; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=TGP6x3h6YYJwclrpDRPnifXfRsYBwd4ztRbxKciLjog=; b=gP9lXOT4G4O9SEa1LGXod+Sj0gceWayQTD/N61GzR/yPl7u3+IhqNl32M0w+4hnWCCZXfKCjxrgdI6yVT1iTsIVM3wS3vM5G4fkuzNFJtpQdzbenLpUpEf4yygGkgC8PdyxmhVbBds5B707LtIaYJG6EMvvYzPH1vKZ+WfqDGcE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788684939959238.83178711763765; Sun, 6 Sep 2026 01:55:39 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x38dc-0002Eo-Sy; Sun, 06 Sep 2026 04:54:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x38db-0002DU-Do for qemu-devel@nongnu.org; Sun, 06 Sep 2026 04:54:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x38dZ-0000kh-SK for qemu-devel@nongnu.org; Sun, 06 Sep 2026 04:54:07 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-711-757ye2BWNxKPaMNEbZrdhg-1; Sun, 06 Sep 2026 04:54:00 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3CB1F18052FC; Sun, 6 Sep 2026 08:53:58 +0000 (UTC) Received: from localhost (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3EF341956042; Sun, 6 Sep 2026 08:53:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788684845; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TGP6x3h6YYJwclrpDRPnifXfRsYBwd4ztRbxKciLjog=; b=c3vKIhHCNjJLJYiF0eKIKU1tWcvFrpI8CAB9rSJ1m8SyHnWJYA+luyZKfrMtvzGFOXjs3g pi7MUcMHehSef5LrQirvYrWBtOZNWlbZmlpiwuQ8806jPB2oFaWgNKNfQ2VZdlTgCqODhD W/mczoQPlDsSxtQOaf/EQAc+vkwYr0k= X-MC-Unique: 757ye2BWNxKPaMNEbZrdhg-1 X-Mimecast-MFC-AGG-ID: 757ye2BWNxKPaMNEbZrdhg_1788684838 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sun, 06 Sep 2026 12:53:34 +0400 Subject: [PATCH 2/9] tests/test_vhost_user_bridge: skip when running ASAN MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-nohmp-next-v1-2-2b21e63974f3@redhat.com> References: <20260906-nohmp-next-v1-0-2b21e63974f3@redhat.com> In-Reply-To: <20260906-nohmp-next-v1-0-2b21e63974f3@redhat.com> To: qemu-devel@nongnu.org Cc: Brian Cain , Pierrick Bouvier , "Michael S. Tsirkin" , Stefano Garzarella , Paolo Bonzini , Zhao Liu , Peter Maydell , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, Ani Sinha , Gerd Hoffman , Fabiano Rosas , Laurent Vivier , Jared Rossi , Zhuoying Cai , Christian Borntraeger , Jason Herne , Richard Henderson , Ilya Leoshkevich , David Hildenbrand , Halil Pasic , Eric Farman , Matthew Rosato , Cornelia Huck , qemu-s390x@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1854; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=d3v8wDpl6ZpnpLjDUpJFM+2TuIyDJb7L4WPUBwqWyqM=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnSoY9/k9w5PImLk+LNUNu1WVYh96sp1l3/KU6 UkrsdNS3xiJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap0qGAAKCRDa6OEJdZac 5cjSD/9NiuPcABUIDCCnz8FfEvP7DWl5GvKODFUcbf58XQyPSXcDzyorEcg5bBSuZtMEQgfk+0E jQfihJfjG2z34XFLotlvXZw2jY+35pZWlNsk423YkdEaZA5xCaZ84X1UcsaUKY4pFwGEWfWXj4i dLe5SGg2b/LsmpXHk6KsG9ACX1ZTiILC+byTaKWn/MGux5+P+ZNe0x5ozKf82lKnwHVWO1HeBcw +6GvU2peDFqv7YdEa04eBaYVELxycZOjUVHD+iHjaa3i9L2H6KxqzgygfNARfyq5zIzFDQqcHwp 51RpbnOig+2Cp/dtC5KohddckgCzwIhHIjka6BkSAfZ5E5wZVKAYI3OEOwe8NsVEVvWGh6aD1vZ xziNm/6US+LE/APpUBOtNT0sIKvdcnBnbaDYaBgFyDsIz4vjU6O3qkAWT88BvSon0UWnlaIj3Ls NGi4L9vsLbnjnzj+zy7TV4U+0uYICmVsnLIKMjEsLMsAIR217GCGW7mkJWEsEA1U4UT9L/e/wgc +PMiErYHQOm/OTIAB4AmoPfN2YzO5cuYHm8a7yBfS02NpSrB7EmiWFS7eu/0+TCXzhCSP/ZenPT EYJIwx2ZYNUlfusg/Rw4CM8wNrKSrFe2kUJavmgjZOPhabm1Zj+6Zt5do7fySH2kV0S4WtMKS95 kYqH0G9J9qElkDQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788684942076158500 Running vhost-user-bridge built with ASAN with stdbuf dies: =3D=3D2431898=3D=3DASan runtime does not come first in initial library list= ; you should either link runtime to your application or manually preload it with LD_PRELOAD. Signed-off-by: Marc-Andr=C3=A9 Lureau --- tests/functional/x86_64/test_vhost_user_bridge.py | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/tests/functional/x86_64/test_vhost_user_bridge.py b/tests/func= tional/x86_64/test_vhost_user_bridge.py index c36c62542053..5fedf61c5e72 100755 --- a/tests/functional/x86_64/test_vhost_user_bridge.py +++ b/tests/functional/x86_64/test_vhost_user_bridge.py @@ -73,12 +73,25 @@ def configure_vm(self, ud_socket_path, lport, rport, ho= stfwd_port, tftpdir): "-netdev", "hubport,id=3Dhub1,hubid=3D0,netdev=3Duser0" ) =20 + @staticmethod + def _is_asan_linked(binary_path): + try: + output =3D subprocess.check_output( + ["ldd", binary_path], stderr=3Dsubprocess.DEVNULL, text=3D= True) + return "libasan" in output + except (subprocess.CalledProcessError, FileNotFoundError): + return False + def assemble_vubr_args(self, vubr_path, ud_socket_path, lport, rport): vubr_args =3D [] =20 if (stdbuf_path :=3D which("stdbuf")) is None: self.log.info("Could not find stdbuf: vhost-user-bridge " "log lines may appear out of order") + elif self._is_asan_linked(vubr_path): + self.log.info("vhost-user-bridge is ASan-linked: skipping " + "stdbuf to avoid LD_PRELOAD conflict, " + "log lines may appear out of order") else: vubr_args +=3D [stdbuf_path, "-o0", "-e0"] =20 --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:02:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788684938; cv=none; d=zohomail.com; s=zohoarc; b=SnJ9l76DIAqSBWAPBaWTdqEoRW+wFCRFcAUArVMbheLMuvhko0YyZ4FSP5I1c7gv6qQ1IdmCqFr9CB21VV2v8q80ecPUg2C5NcKLFzm0dj5wNZk9aRUPGy8iErwXfpLSxjcrevKHbp9BHACTg0PKxnPWfVF0AgapeczclvycngY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788684938; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Vst5j4QPIcKrnpicAI/fXe4jkP6szpQ/0rL49li+K+4=; b=T79+EMDjvnZrUg1XMsaeqLjF8Ha+3tqdbE8zxj+mDqrwd7Hqwmu2t3omRxV/mykEeYxuUpvF77Kvod+lQvlikNedSGAefmd/pVCusnBjpNpsB7+wEYMc2p2CmKs+JNFj8P/mKgrPuJJxgfwJpcDsRo/8e0VsOADIdiWHbMGAU7k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788684938028746.6448306398297; Sun, 6 Sep 2026 01:55:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x38de-0002GK-Ep; Sun, 06 Sep 2026 04:54:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x38dd-0002FN-O2 for qemu-devel@nongnu.org; Sun, 06 Sep 2026 04:54:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x38dc-0000lA-4F for qemu-devel@nongnu.org; Sun, 06 Sep 2026 04:54:09 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-99-EPc8slb-NY20ki3Ou5gLPA-1; Sun, 06 Sep 2026 04:54:04 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 99583180121A; Sun, 6 Sep 2026 08:54:01 +0000 (UTC) Received: from localhost (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 919901956042; Sun, 6 Sep 2026 08:54:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788684847; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vst5j4QPIcKrnpicAI/fXe4jkP6szpQ/0rL49li+K+4=; b=bWSTBIfSKtoR6V1NM3+1aC1bPgSpa/eFwrQxGQXdamlbkgBYNYMKQndwk1UqTxl1e1u8yU 4jrkuTW93IdRNLdv7Lu6bHMiwbYRxk+gNRDWm5NJ48hvxhYGVCvFbINUaMML6fMcuVRGj9 wckh1u8PF3seOjaX2BxTEYCgZ2DVXQ0= X-MC-Unique: EPc8slb-NY20ki3Ou5gLPA-1 X-Mimecast-MFC-AGG-ID: EPc8slb-NY20ki3Ou5gLPA_1788684841 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sun, 06 Sep 2026 12:53:35 +0400 Subject: [PATCH 3/9] hw/misc/bcm2835_powermgt: free wdog timer on finalize MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-nohmp-next-v1-3-2b21e63974f3@redhat.com> References: <20260906-nohmp-next-v1-0-2b21e63974f3@redhat.com> In-Reply-To: <20260906-nohmp-next-v1-0-2b21e63974f3@redhat.com> To: qemu-devel@nongnu.org Cc: Brian Cain , Pierrick Bouvier , "Michael S. Tsirkin" , Stefano Garzarella , Paolo Bonzini , Zhao Liu , Peter Maydell , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, Ani Sinha , Gerd Hoffman , Fabiano Rosas , Laurent Vivier , Jared Rossi , Zhuoying Cai , Christian Borntraeger , Jason Herne , Richard Henderson , Ilya Leoshkevich , David Hildenbrand , Halil Pasic , Eric Farman , Matthew Rosato , Cornelia Huck , qemu-s390x@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1395; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=aiXkdc63nsKgNhTc5ZS/RmEpq+MeWtxUvxktNtqDyD0=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnSoYzhb/L70apQJE8iQq8eM39G226x6BUkqvW q9VGGL9p/OJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap0qGAAKCRDa6OEJdZac 5c1MEACOhfNx10f74ac2I+4Pv+FmWZIHK8oPoePNAWDuX0pWDVH+Jvye+5Fjb+6SngjTSlw9Mmf l7/QK2Bpv5Qi01t26rdcPXO5VsieeuQH8B6KI5VXMQmqaJ0zWVneWmOVSdrrHe+5jzBF0vjs7o5 yFMvtVU291SZdbVO6+c17SUXTUgK/PCgc+i415uiJ0y2qNX0kRWMi7bdw8/U8IGNxAw0OT/flMg 2keFetx5xR4fqIPJofijES0fnpV3Ka4cWD1TNGn4wSepx22KtmB1+nk+be0I2oB9P4vjGtTcX91 bOt6Qow1yDIkcUpRcRjkKXUdFrNCQm4JqhvLyXvt2+3jD8t9+ucrEZIXOAo5Ictii6LPoo7Po9K lBE9se9elWCGrEZB1aKm92NK/oTH/xJoPkvNTOYXf1hw9m/0kKmds0i1coy/mpI8Ov7c3MnuJHx DY+mAXZfu+bNbXtsw260xOaP6uco+azl+8XpSn9MQ6yQncNtWxCcMtyzNc7kc6Bon+2fCtZrnF8 Cd6kOpO+oL1vV0aZTm2JwOeDhmbzI/b6B9aWZb0U9RUlvnmr/0oYeumjl9HMn4921pwMs52b7Da rNKw1OH8mKiUkxFAyEzgdqPzlqKWZ55S2jhJxK/oQI5YaF7BPAAWawIoVReRQ49egsMdDQvC8MG OVLJVo8NC3t5/mg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788684940180158500 The wdog_timer allocated in instance_init is causing ASAN to report a leak when the object is destroyed (e.g. during qom-test and device-introspect-test). Add an instance_finalize handler to free it. Fixes: 21fcfb604608 ("hw/misc/bcm2835_powermgt: implement a real watchdog t= imer") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/misc/bcm2835_powermgt.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/hw/misc/bcm2835_powermgt.c b/hw/misc/bcm2835_powermgt.c index 7b01be48bb7f..1de5a55a4f5b 100644 --- a/hw/misc/bcm2835_powermgt.c +++ b/hw/misc/bcm2835_powermgt.c @@ -152,6 +152,13 @@ static void bcm2835_powermgt_init(Object *obj) bcm2835_powermgt_expire, s); } =20 +static void bcm2835_powermgt_finalize(Object *obj) +{ + BCM2835PowerMgtState *s =3D BCM2835_POWERMGT(obj); + + timer_free(s->wdog_timer); +} + static void bcm2835_powermgt_reset(DeviceState *dev) { BCM2835PowerMgtState *s =3D BCM2835_POWERMGT(dev); @@ -177,6 +184,7 @@ static const TypeInfo bcm2835_powermgt_info =3D { .instance_size =3D sizeof(BCM2835PowerMgtState), .class_init =3D bcm2835_powermgt_class_init, .instance_init =3D bcm2835_powermgt_init, + .instance_finalize =3D bcm2835_powermgt_finalize, }; =20 static void bcm2835_powermgt_register_types(void) --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:02:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788684862; cv=none; d=zohomail.com; s=zohoarc; b=gT3S1juGYgo3j1KIHf6I/B0ra+nK6c8E5xF2RY/A4ApdLShbXP/vDcbM00GJkZgbfJDjzz5w+y0+HqcK/BdgCA20qEY15OBYmJ/lxleEDpCTrDtyrZ65r7/8Tzcz7ghC+2iKvfmDK0iVqlrBUrGSsFgxvNJsGIWkJrokJGs2+Rw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788684862; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0km4qjkAFcD4lhaicMDtebzytg/5UCP+NpNlTDCWCO8=; b=Na0xqj4p55/QqgySpKBDnlQe+lpJnpXhkLRJMDkJ4GxFkp0kc7cDnM+YE/6H+L7c4h4sbN3ULFfWJo0oa4gvInB7xix12ANLReyBUnruxrkSaxBFntloSBndQCyVgLXZhsqqb+H6m+Y0fG3ubjGC+0XhtQXv8EpH/WcQHAaP0lY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178868486281069.23596817002658; Sun, 6 Sep 2026 01:54:22 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x38dj-0002I2-SC; Sun, 06 Sep 2026 04:54:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x38dh-0002HO-RQ for qemu-devel@nongnu.org; Sun, 06 Sep 2026 04:54:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x38dg-0000lz-Fw for qemu-devel@nongnu.org; Sun, 06 Sep 2026 04:54:13 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-586-w5NnExbfNNa-aBZFMRYcwg-1; Sun, 06 Sep 2026 04:54:08 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DEFB11955DD4; Sun, 6 Sep 2026 08:54:05 +0000 (UTC) Received: from localhost (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 193C730002EA; Sun, 6 Sep 2026 08:54:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788684851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0km4qjkAFcD4lhaicMDtebzytg/5UCP+NpNlTDCWCO8=; b=I9yT124Cqh6z2AXPD6e0DTGdXNjZZQwzMEtVcUhIeTmoZzu7DQniCrZJwgsSCm8Z1QYv/d KKmR6VY+ygUF7zcmBo4hnSC2UuoWul5XxIE8m+U/R3Rf8wu+JFTVzPobzokmazIhEgF5Ga zE5rhXQu/4PirKdKGYq/G9xqKffHiI8= X-MC-Unique: w5NnExbfNNa-aBZFMRYcwg-1 X-Mimecast-MFC-AGG-ID: w5NnExbfNNa-aBZFMRYcwg_1788684846 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sun, 06 Sep 2026 12:53:36 +0400 Subject: [PATCH 4/9] tests/launchupdate-test: correct g_auto usage MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-nohmp-next-v1-4-2b21e63974f3@redhat.com> References: <20260906-nohmp-next-v1-0-2b21e63974f3@redhat.com> In-Reply-To: <20260906-nohmp-next-v1-0-2b21e63974f3@redhat.com> To: qemu-devel@nongnu.org Cc: Brian Cain , Pierrick Bouvier , "Michael S. Tsirkin" , Stefano Garzarella , Paolo Bonzini , Zhao Liu , Peter Maydell , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, Ani Sinha , Gerd Hoffman , Fabiano Rosas , Laurent Vivier , Jared Rossi , Zhuoying Cai , Christian Borntraeger , Jason Herne , Richard Henderson , Ilya Leoshkevich , David Hildenbrand , Halil Pasic , Eric Farman , Matthew Rosato , Cornelia Huck , qemu-s390x@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1159; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=gdbpATPGnLOldGstBztdGH7CDvsOnIVMYXJ0fAL0KlI=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnSoYNG3KIJu29yJqCfs2RgASqkrv2dBAI987P Zs1G67BmaSJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap0qGAAKCRDa6OEJdZac 5X4gD/9WsoVvFff5maI6Sf/FqnPc3gvAMx4gq2QQSrhGiL3fdgyOPHMvP1RRvyNZCy53EGCzbkL 7M/cDoCOi+zXHu4W1lVLb6fuWT8K11TaIflSr56YX9M18ozFgGjYwmD3ThLs7LjnrGUJDbb1KT+ e0GG2g6ZAdO2Sy2wBmNDjymANksOgD13b22geucUpjptJgfFFNL2+Mb6wpF/NwfaHOLyzeXBrSo T9/KNsvqL+QZOJCcNa5uLkiKDZ31Ejrh7+jjiFTkLxzlodbsyvAhtZX6zXExeQ73KmMZhLlnHba JfTcypHUiyQ44On+XTdbHjY573bxZM3BMjNCq+5w+jfTOwL9QqNeqkzANxg/hEDMS7YRL6sHXeE TuntvSWbGIIPFYsvlYySykSGbYXmTrEzApEp8MxKVN9qtKlXNgxY6/RYTggAHMatFMourHmBOWw MRskBjHs8F61J9xDBcHw5KYe4sKzXZWwIEOlU3qv9CLscy9hwUofad4pniNd6jEIvq4UGzyFDsD MDt72tiVJyqT0sJqhXjn/g+zt8RB+BzNo4QS9Bac96HjEUtYQDJK8mNFgkRZMyC/+Gz8sQ219MF AuFERsNMpDpZ5M4Y1edNzQ5rEMNwtzU3P6Fe+v4j1zKmFxp64Ss3E8b3Oo2qQ758ctpbcRKia8u Z01+ZwRh0atVAXQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788684864400158500 g_free() isn't the appropriate way to release those types. Fixes: 0b70c6ce7b31 ("Add functional and unit tests for the vm-launch-updat= e device") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Peter Maydell --- tests/qtest/launchupdate-test.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/qtest/launchupdate-test.c b/tests/qtest/launchupdate-tes= t.c index 225c843df5b9..ed007cdce29f 100644 --- a/tests/qtest/launchupdate-test.c +++ b/tests/qtest/launchupdate-test.c @@ -192,8 +192,8 @@ static guint32 match_string(char *serial_f, const char = *exp_out) { GError *error =3D NULL; g_autofree gchar *f_contents =3D NULL; - g_autofree GRegex *regex =3D NULL; - g_autofree GMatchInfo *match_info =3D NULL; + g_autoptr(GRegex) regex =3D NULL; + g_autoptr(GMatchInfo) match_info =3D NULL; gsize len; guint32 count =3D 0; gboolean ret; @@ -214,7 +214,6 @@ static guint32 match_string(char *serial_f, const char = *exp_out) g_match_info_next(match_info, &error); count++; } - g_regex_unref(regex); return count; } =20 --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:02:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788684931; cv=none; d=zohomail.com; s=zohoarc; b=cRNBNIJE+4Tj5VmFGK3V7g/bt6jNAkylIG8Eu/GvyALClH+yA4iHilvonFmTo+1FZttqUdj1BsqsfWq3TEj+JbcA2BJfCpFCZaa2q6Zv25NKcJ4RWFKnVAM4NUCsg6UdFf5oOAjq9qh09HDY9QAJfc5AqnynQobE3n0RxNU+fvc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788684931; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=JHplSF0uv9FiqiAOekaEuFDuITCtR35X5p8OCNEkDU4=; b=hQCTdd0yvWa8fgfAfZeQOVrfuhSRVJfWte6frzOW4LOqfDjDt3HxfNtx9+u5XH5TdwlOQbFoYZSFoJqW3f6sI9fsel7g/kn5LbGgGjT5yckL/lwI5dcpoq6Mb2NFU+Pgr+a9s/cxUlbbFfHbMOhrHwkBCqPkBkPUAElUXQVgbd8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788684931926992.31498502571; Sun, 6 Sep 2026 01:55:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x38dm-0002Iy-Su; Sun, 06 Sep 2026 04:54:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x38dl-0002Ib-SA for qemu-devel@nongnu.org; Sun, 06 Sep 2026 04:54:17 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x38dk-0000mb-7y for qemu-devel@nongnu.org; Sun, 06 Sep 2026 04:54:17 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-690-puCfoicMOO62ykvfd6_SLA-1; Sun, 06 Sep 2026 04:54:12 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D3FF81954234; Sun, 6 Sep 2026 08:54:09 +0000 (UTC) Received: from localhost (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4D47C1800598; Sun, 6 Sep 2026 08:54:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788684855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JHplSF0uv9FiqiAOekaEuFDuITCtR35X5p8OCNEkDU4=; b=TPwb01J97Jddb4qLj0pOYOJRH2yBQapnpsUl9ChcVTwClBqog+vyomZx8ikaFH9R0aofpO txnutkJPTpdNT2TVbxhlMX/v7gZdovMWIpf6ydvzaQ8n08XuhNQFFgtRoDxfwHE+HVvBTN CXKLMWKa1GA1fRouKfBTiLUwplAPPJU= X-MC-Unique: puCfoicMOO62ykvfd6_SLA-1 X-Mimecast-MFC-AGG-ID: puCfoicMOO62ykvfd6_SLA_1788684850 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sun, 06 Sep 2026 12:53:37 +0400 Subject: [PATCH 5/9] tests/launchupdate-test: correctly release qs MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-nohmp-next-v1-5-2b21e63974f3@redhat.com> References: <20260906-nohmp-next-v1-0-2b21e63974f3@redhat.com> In-Reply-To: <20260906-nohmp-next-v1-0-2b21e63974f3@redhat.com> To: qemu-devel@nongnu.org Cc: Brian Cain , Pierrick Bouvier , "Michael S. Tsirkin" , Stefano Garzarella , Paolo Bonzini , Zhao Liu , Peter Maydell , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, Ani Sinha , Gerd Hoffman , Fabiano Rosas , Laurent Vivier , Jared Rossi , Zhuoying Cai , Christian Borntraeger , Jason Herne , Richard Henderson , Ilya Leoshkevich , David Hildenbrand , Halil Pasic , Eric Farman , Matthew Rosato , Cornelia Huck , qemu-s390x@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=3090; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=KV3NOMsdSPu91AOYmgCOfD8KeD0yoFJPlKPZaUobNYo=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnSoYF2ZdHROn+xfabhY+IDnwOoIL2tZfqvF7P pQCbBdjYHOJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap0qGAAKCRDa6OEJdZac 5WKFD/9XYOrtNOdlsmxZeylVk44Tmlg0QTw9+nIqKWHeCK/MPX/lVH3bXaG4pUwGwT7J9Fl8aWZ DZTK6ynC0M59OkjOpgn+A1eaixm0cw4CrvWlXLjZpjeaHoCBP1TQlgGDbnzFsDJNvCLLJ/ON9q7 /3xy6bNPSkNFH0jSkw4WK8ytI6elcBU1TOv8oOKu2CCn4qWEcde+Q165LDf7MpMt+gyAZNYptZy JTnnJmYrAq0eSVqrB2dRGsNd8itdgKBQ2oKfXxviulB2gMatkDj07AsuKaSRMQCfQkMIrGJuDar aTSjXl5iM95K6Us9b1Shpj4qJ7jFD2PHEadZXeFZWrd63EaPQYfOrqaGM1cnJx5rlAxUxMOhEUi y0WY6M9ZTtDOtbGmvc+Qh8LYHwkjWF7hFzvJwcn2F+wQTLMOOtRJ4o2AOV3VugcMGaVaT3i8wvE 9ZKf13S0hR9XIPDJg8GHG/3pAHxmNJgP45ec5c8mXKK3tQSgqIuxAm/Qnz4wT7xSPvNjOV7LVVw x78XAOBewMu9yN9QUp2dlR+wzh/aSSPfvbX9vSdn9Go02jq0RsFu+DyWSd7ETqFDq561i9X7Hj7 0yWLc2VKHMGSBP7+lhlUc/tDC+t1+ztMiMjN4Gu+0lBAoMaJpuwfopnubrgivcB/11KQ0VBvJMz KZLY/uk3lQfVQKg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788684934076154100 QOSState must be released with qtest_shutdown(). Fixes: 0b70c6ce7b31 ("Add functional and unit tests for the vm-launch-updat= e device") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Peter Maydell --- tests/qtest/launchupdate-test.c | 14 +++++--------- tests/qtest/libqos/libqos.h | 2 ++ 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/tests/qtest/launchupdate-test.c b/tests/qtest/launchupdate-tes= t.c index ed007cdce29f..12a09079ae91 100644 --- a/tests/qtest/launchupdate-test.c +++ b/tests/qtest/launchupdate-test.c @@ -51,7 +51,7 @@ static void test_vm_launch_update_capability(void) static void test_vm_launch_update_disable(void) { QFWCFG *fw_cfg; - QOSState *qs; + g_autoptr(QOSState) qs =3D NULL; VMLaunchUpdate launch_update; uint64_t control; size_t filesize; @@ -95,13 +95,12 @@ static void test_vm_launch_update_disable(void) g_assert_cmpint(VM_LAUNCHUPDATE_CTL_DISABLE & control, =3D=3D, 1); =20 pc_fw_cfg_uninit(fw_cfg); - qtest_shutdown(qs); } =20 static void check_error(void) { QFWCFG *fw_cfg; - QOSState *qs; + g_autoptr(QOSState) qs =3D NULL; VMLaunchUpdate launch_update; uint16_t status; size_t filesize; @@ -149,6 +148,7 @@ static void check_error(void) status =3D le64_to_cpu(launch_update.status); /* should fail with LOAD_FAIL since it was not IGVM format */ g_assert_cmpint(status, =3D=3D, VM_LAUNCHUPDATE_LOAD_FAIL); + } =20 static int64_t get_image_size(const char *filename) @@ -326,7 +326,7 @@ static void test_load_igvm(void) size_t igvm_sz; size_t filesize; QFWCFG *fw_cfg; - QOSState *qs; + g_autoptr(QOSState) qs =3D NULL; VMLaunchUpdate launch_update; =20 if (!trace) { @@ -456,8 +456,6 @@ static void test_load_igvm(void) close(ser_fd); guest_free(&qs->alloc, gaddr); pc_fw_cfg_uninit(fw_cfg); - /* qtest_quit() kils QEMU, first by sending SIGTERM, then SIGKILL */ - qtest_quit(qs->qts); } =20 static void test_set_ctrl_once_and_reset_to_host_igvm(void) @@ -475,7 +473,7 @@ static void test_set_ctrl_once_and_reset_to_host_igvm(v= oid) size_t igvm_sz; size_t filesize; QFWCFG *fw_cfg; - QOSState *qs; + g_autoptr(QOSState) qs =3D NULL; VMLaunchUpdate launch_update; =20 if (!qtest_has_machine("q35")) { @@ -585,8 +583,6 @@ static void test_set_ctrl_once_and_reset_to_host_igvm(v= oid) close(ser_fd); guest_free(&qs->alloc, gaddr); pc_fw_cfg_uninit(fw_cfg); - /* qtest_quit() kils QEMU, first by sending SIGTERM, then SIGKILL */ - qtest_quit(qs->qts); } =20 int main(int argc, char **argv) diff --git a/tests/qtest/libqos/libqos.h b/tests/qtest/libqos/libqos.h index c04950e2b19d..b2d02825a9af 100644 --- a/tests/qtest/libqos/libqos.h +++ b/tests/qtest/libqos/libqos.h @@ -42,4 +42,6 @@ static inline void qfree(QOSState *q, uint64_t addr) guest_free(&q->alloc, addr); } =20 +G_DEFINE_AUTOPTR_CLEANUP_FUNC(QOSState, qtest_shutdown) + #endif --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:02:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788684908; cv=none; d=zohomail.com; s=zohoarc; b=Hk1B2iGnwPA1chw0Ub01zGRmDcI1ZW0xMeGDfNs6MQVGo+C4d5m9XAIYatk03xpZgRzrLMGMHUu4bwQzQwcRvFLjMJ4NFXHbq85rnHzLoTxuVq+jadjObi631+5QOJT7tdFwMdqOWOERsRFAS1UsN0VYoSlko5pBTMAn8DFRiq0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788684908; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XhdwYKD5g6XfDYLPQ0d6PKc21CSZ/GdTRYAvPQnoFM4=; b=H3wR4NFBI+MX19gRw0N0GCwPax7mqOM0rxOpilk5WDwNiImB223E7IJwwyGpNjr02aZCq/INjAOblBTMx7fGWZBmpCMWPBDIlmyqsECWvX6fRjk1Tp/UE3kFNHHAVd2Zyxbpy5OjB9gm7frSEU2wjWATgERTqAn9R6cCClmY6No= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788684908385263.99499926588305; Sun, 6 Sep 2026 01:55:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x38dr-0002SV-Vm; Sun, 06 Sep 2026 04:54:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x38dq-0002Oi-G9 for qemu-devel@nongnu.org; Sun, 06 Sep 2026 04:54:22 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x38dp-0000nA-00 for qemu-devel@nongnu.org; Sun, 06 Sep 2026 04:54:22 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-439-oSuwYy-zPBqRk-zFCBSi6w-1; Sun, 06 Sep 2026 04:54:16 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6AD4C1954234; Sun, 6 Sep 2026 08:54:14 +0000 (UTC) Received: from localhost (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 928E41955F05; Sun, 6 Sep 2026 08:54:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788684860; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XhdwYKD5g6XfDYLPQ0d6PKc21CSZ/GdTRYAvPQnoFM4=; b=G01SruP8xrdx+nFYUwTxRN5YsrvzeogpdA4pvYUF1umB726L4eRATaqaMN8QFXFwVPaISo 57B7D3UrLId4q7Pjn7ICxBbYdG4edINdbg9HYVLyRHDHua2OeHh9RK6WO8k4o6kexDYaPW Hsx5rtlcDd4aTkBQZvHm5ch+/3IQTRA= X-MC-Unique: oSuwYy-zPBqRk-zFCBSi6w-1 X-Mimecast-MFC-AGG-ID: oSuwYy-zPBqRk-zFCBSi6w_1788684854 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sun, 06 Sep 2026 12:53:38 +0400 Subject: [PATCH 6/9] tests/launchupdate-test: fix fw_cfg leak MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-nohmp-next-v1-6-2b21e63974f3@redhat.com> References: <20260906-nohmp-next-v1-0-2b21e63974f3@redhat.com> In-Reply-To: <20260906-nohmp-next-v1-0-2b21e63974f3@redhat.com> To: qemu-devel@nongnu.org Cc: Brian Cain , Pierrick Bouvier , "Michael S. Tsirkin" , Stefano Garzarella , Paolo Bonzini , Zhao Liu , Peter Maydell , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, Ani Sinha , Gerd Hoffman , Fabiano Rosas , Laurent Vivier , Jared Rossi , Zhuoying Cai , Christian Borntraeger , Jason Herne , Richard Henderson , Ilya Leoshkevich , David Hildenbrand , Halil Pasic , Eric Farman , Matthew Rosato , Cornelia Huck , qemu-s390x@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=654; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=tvMkFreeH/Ejxl3IdLA0EASIl9I59BW58yWeShIj8SU=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnSoZY4pm21hFaA3Sc++5/rTbCbG8MEWWVRsT4 aaMw/OvM22JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap0qGQAKCRDa6OEJdZac 5TAtD/4qzJm8UIVSGwLpCvQb0Wnt+ASjcnKn35WzT8b7LciqKNPEhMD3PRNIgHJwru2XLZBxSiW 7Ej2BxLkA9CRdXnsvBBN8YgJhVXW6EqaKLpqVA6METdDguPEXtJo6nMkPnPY/hStnl1A4NMdjCi hf8/2npMmakzv8FOouoIOVPnZy0OFrjJSjFWVGvsBTAsvspVvqM4nRvtvlO6u0c3TvWRcLwhMrH H3siNFA3LjHAIcNFsyv0wXgQW3lq69z8TNBLMAtZOWNd1k3YljQu+V7q1Re053RZ4/ieFfEb7D+ dnMTlYTKaa8R1g2O94bPV3wITDhY9gwk1xqZgkZPdaUXdAmE1L6c14uUXVLKLjpqJA/a8ZChkbc 5t3LXwvkNsxlXA3R9q3EoY+6XFO3dvStJFRhSA1wbW4hftP0XbL/b7dR5J/3L1Byera0H5NHRmt xt+ijidIrAOVrxfDaMSyW1YKQJKWZTHvqy6proSlHDTVstV0O7A+MvAhthPlEdpXBGn3+A0QVem Bz1PMJ+ieh5RPo/LAR5BzaHEeQI1/HjaOJx6Nin0w3Y8Xle0hC8Gs3Bu3e04v1CijXKSUtAbTBb jLzrdKuq35C3Zv0uzZArG5LluL69iMT6mS6aLh7Llb5wRrDvBBNnJo2mcaJ5T647x4g18PC+izK Og/q5Jzyfu5RgVQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788684910025158500 Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Peter Maydell --- tests/qtest/launchupdate-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/qtest/launchupdate-test.c b/tests/qtest/launchupdate-tes= t.c index 12a09079ae91..beec902caa6a 100644 --- a/tests/qtest/launchupdate-test.c +++ b/tests/qtest/launchupdate-test.c @@ -149,6 +149,7 @@ static void check_error(void) /* should fail with LOAD_FAIL since it was not IGVM format */ g_assert_cmpint(status, =3D=3D, VM_LAUNCHUPDATE_LOAD_FAIL); =20 + pc_fw_cfg_uninit(fw_cfg); } =20 static int64_t get_image_size(const char *filename) --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:02:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788684920; cv=none; d=zohomail.com; s=zohoarc; b=i6Fy90egGRivPNhFQ7WflIAKV5vo2JZhE7TVnZ4vxWq192tCNDz7Hv0FMKH6osIhpaMxInrc7j6wQBnz3Cux5lMg9/G/QvXKwQl6yzolFZx4tegBMMvKPU4C99quBkjhlOm+rXcg04ddR7fNtYOQoRGa5chA/f7BkRNoe9KUYto= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788684920; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=uo1vyG+VFq3hO/+8bOAZhuY/jMoCwIibajRfx3GTxbM=; b=SBDZl8GCNT5saKRtTcik32WydLcJukdFOGsz4+pZ4ctYCowsbLP2tbRyUQ8B6tBKCk+2kEQPlXKgP2YFywdNvon1Z90onyDW/+NdsftMuP1bpqolbNzj49ehiMm28KzhsoWcz5RdkuGEgYdjXu1hzUdgizJ+41whrYiI5E7fHMU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788684920077898.6762620195708; Sun, 6 Sep 2026 01:55:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x38dw-0002V9-TS; Sun, 06 Sep 2026 04:54:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x38dv-0002Ug-Os for qemu-devel@nongnu.org; Sun, 06 Sep 2026 04:54:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x38dt-0000o0-Sn for qemu-devel@nongnu.org; Sun, 06 Sep 2026 04:54:27 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-136-ITnTRN5iOh2hRsihoY2kcA-1; Sun, 06 Sep 2026 04:54:21 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1442E1805A20; Sun, 6 Sep 2026 08:54:19 +0000 (UTC) Received: from localhost (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 14ED61800767; Sun, 6 Sep 2026 08:54:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788684865; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uo1vyG+VFq3hO/+8bOAZhuY/jMoCwIibajRfx3GTxbM=; b=QbNITsqEuKZbsDkhFzFFA0FlpQ4nXOPtVNRFceS7PohwAt314rDF/RB/wMYqXNm6fAKx3s JGYo+pIHGEUCeetuLx9Gs0KKiQvf58CTl577N4TxQJX5vFcL/67RIj/ZUv9apAoD6hodMd hMLQtZo23PJmzbLsifxeVyy3RBB9eC4= X-MC-Unique: ITnTRN5iOh2hRsihoY2kcA-1 X-Mimecast-MFC-AGG-ID: ITnTRN5iOh2hRsihoY2kcA_1788684859 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sun, 06 Sep 2026 12:53:39 +0400 Subject: [PATCH 7/9] igvm: release found memory region on success MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-nohmp-next-v1-7-2b21e63974f3@redhat.com> References: <20260906-nohmp-next-v1-0-2b21e63974f3@redhat.com> In-Reply-To: <20260906-nohmp-next-v1-0-2b21e63974f3@redhat.com> To: qemu-devel@nongnu.org Cc: Brian Cain , Pierrick Bouvier , "Michael S. Tsirkin" , Stefano Garzarella , Paolo Bonzini , Zhao Liu , Peter Maydell , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, Ani Sinha , Gerd Hoffman , Fabiano Rosas , Laurent Vivier , Jared Rossi , Zhuoying Cai , Christian Borntraeger , Jason Herne , Richard Henderson , Ilya Leoshkevich , David Hildenbrand , Halil Pasic , Eric Farman , Matthew Rosato , Cornelia Huck , qemu-s390x@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=821; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=nyQcpX2O2JaBarZgpXAo4ALUM2REr/Vy7wrbwXQjNBc=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnSoZv5Ptq2a/g08nt+tp4yi2WH6V8BkJT3mCc V9ZLjhaHLaJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap0qGQAKCRDa6OEJdZac 5Ve3D/915jbscrwaxltqZJ5WmWsXTcy5Mf9/x2rRx4SLVYOH2vGknFhI/LJUwQ57PhQsOyJEwHT XoZw8k93odPRlSSOKz1stT0XKTIlakDKeUlq7WHVaZrkXP2lvuOW+NECPDBCmCEcKdG3gCayqpW sSEqHOzUCxVxFZsZowfw3K9OKNavuadBschHBbvJboX4dkccgvdekP9BfbU0NXux/pQSHG24dYq I44BUfoUme2f+uY/JbDQCgUlx0jI+/SFa+CDNL/G6h+sgfR4fvWveCXxDZBX5R6iHJ65deOO3GP KJAEllWCAUuEqqZpju06SwrI5MliaILHhxRxtne3rMzhkLGZO1eNYXz8foas6MC5AYiGz6X2jBm PZdpVNDyiic0w8Y+HV74yBJ/Ck05Kr6fa7oyroQBCiW0SMBy9l2XfobMZ+yycrsUjVbQoIMiHx1 k3Esi1KGHoK5MCEShoOwiHc4nHfksbLlLDX8T7KtcfKi202LTJQ9jOABanDSqcdGYkX9fGdcP1a MavOIn6VkJuJj6GyeUu7fe3/K5tXX8ohbZ+xRdkGsa1z1ab6Yg3/BCaDyDu1h3zDwpw7ij6fg6z DaEj8Z9DmqZFKaoGd2zbCSBIy3+HBpxbiJGWyQPQgQ8WjAs+JD/Qc4VK3B3huj+uAnSEAzxwtfg z6L/0b56FvxuSYQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788684922011154100 Not only in error paths must the mrs.mr be released. Signed-off-by: Marc-Andr=C3=A9 Lureau --- backends/igvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/backends/igvm.c b/backends/igvm.c index 7b7bdc72b75b..784a56504e77 100644 --- a/backends/igvm.c +++ b/backends/igvm.c @@ -236,9 +236,9 @@ static void *qigvm_prepare_memory(QIgvm *ctx, uint64_t = addr, uint64_t size, return NULL; } =20 + memory_region_unref(mrs.mr); gpa_region_size =3D int128_make64(size); if (int128_lt(mrs.size, gpa_region_size)) { - memory_region_unref(mrs.mr); error_setg( errp, "Processing of IGVM file failed: Could not prepare memory " --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:02:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788684944; cv=none; d=zohomail.com; s=zohoarc; b=FPDPgSLRaJpDU4qLbE9RAEmCWfmi8Wm6EQccryON2Sa+0rIs3oGNnvUs+rbKXP6eTTLJwFHlGJtJp1QEpteFllxocCmf0q/liTM6eInI6xOXuuSl+lpE0Z59tMaAqrFw7J8ltECDTGFS30ffW91wtoWpD//G1AjsXWCx01rEX2Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788684944; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=eACu3XVhakesEFnMk7YDIWx08rU69DJZpdOJmnuy/Nc=; b=eRVLBaOTXZk6NIwejLP3jyMlf8bu+ohTSEgd0jy8ZcUrQsc3z7MCqYkeKqR62SdynvWOdSw9/7rg3trLcAqwZtGwCi2CWlY6YI4EBcm04MZmvdwst2GJf9zcLvK39ZEONE0IhFHn4+cW1xr56AM5uKGnrZR0XZRzkDHkvMQO1YE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788684944743805.6214834500479; Sun, 6 Sep 2026 01:55:44 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x38eA-0002bl-5h; Sun, 06 Sep 2026 04:54:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x38e8-0002bM-Tu for qemu-devel@nongnu.org; Sun, 06 Sep 2026 04:54:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x38e7-0000or-31 for qemu-devel@nongnu.org; Sun, 06 Sep 2026 04:54:40 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-407-ObLBghIPPm2Z3Ni1N0PZFA-1; Sun, 06 Sep 2026 04:54:25 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BBE7B1955DC9; Sun, 6 Sep 2026 08:54:22 +0000 (UTC) Received: from localhost (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D188E1800598; Sun, 6 Sep 2026 08:54:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788684878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eACu3XVhakesEFnMk7YDIWx08rU69DJZpdOJmnuy/Nc=; b=iQjuYLEDdlbSonpTA+vkv7OiBQkYbClAU9wDijaZgrRAoKxEBHHshtrNChVVdu2LMxrfpA Jl2g9AWzLjdD0gEyGX1JL/tcq9nUA6+Eu+YuW1oiMXjAudZM4GoOrjpVaw/R+7In0TGWPo guxKWiG+C9chov0I4uLVdrEjvw0OcAQ= X-MC-Unique: ObLBghIPPm2Z3Ni1N0PZFA-1 X-Mimecast-MFC-AGG-ID: ObLBghIPPm2Z3Ni1N0PZFA_1788684862 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sun, 06 Sep 2026 12:53:40 +0400 Subject: [PATCH 8/9] igvm: make IgvmMemoryRegion a QOM MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-nohmp-next-v1-8-2b21e63974f3@redhat.com> References: <20260906-nohmp-next-v1-0-2b21e63974f3@redhat.com> In-Reply-To: <20260906-nohmp-next-v1-0-2b21e63974f3@redhat.com> To: qemu-devel@nongnu.org Cc: Brian Cain , Pierrick Bouvier , "Michael S. Tsirkin" , Stefano Garzarella , Paolo Bonzini , Zhao Liu , Peter Maydell , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, Ani Sinha , Gerd Hoffman , Fabiano Rosas , Laurent Vivier , Jared Rossi , Zhuoying Cai , Christian Borntraeger , Jason Herne , Richard Henderson , Ilya Leoshkevich , David Hildenbrand , Halil Pasic , Eric Farman , Matthew Rosato , Cornelia Huck , qemu-s390x@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=6365; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=U38GR/ghKbLAYVNdtkRcH421VnYU0/FYIBBHHUs5IuY=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnSoZ8W2H9SCIVECiVjSbfaZcLMOFZ6F7sVlRm bd2+Wvgh9CJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap0qGQAKCRDa6OEJdZac 5RbOD/9IAnkl+lykvEZzYCL1K47f3QG2MMehmraMOQRvSjQihz6xRvT9MaGD0hg/1B3JLqr/Q9n +OyuUDNMOGe7PbopvKBFruwMN+6ImDw0Wo/ds+YBqGITFKbrZO+wDNSsd4gXWvFZvbRIXC16Lke S9fL6gJNddpt2IghuvoAvvQ9nxaiCerN8bg4MJZkirnNLFW83ziN7E3WrwNRNNpjSPTkxpLdtFN any+yerqxG0H2vrYyEzBERBNCPEE9xWfmy1qiYiaLKqe2lbG3Mm7BwePjRgEnQPZRdPFzZ3+6sZ TyR2DFEpe9/FvTMMeXmgOC25ohKGZgucAaD7hXXciqd0FMUqMWszXkQULVjpH2E7svgPMMFOBlj D1TqaTMI1yKgYd9PSZZcgahAkhTfC4aX/PHVLdfxPKH+bLcEXR1q4EYBJslOQawujXY0J/bYQXP uDF30eiPSI8itJIEwy6XvQLblRmF1EFyQCw1FWaegqUm8i4xaKDpj7vswUPlWBc9u4RjDCDeFXS 0PuR71Qhj5thOKWcmVV16Nwy5K3NB9iakVdyIpyUkiXgJwHPZXWSYmt0i6/PceSfS6C1cotLu9X knwM8BChjCGtrbAdRVFszD9XFtXAA9cjab/fiRSYZBvJlxQcYQMQ+puYv7NdqpvUxJdxcL6KzxP +qs9DrXcM1KArcA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788684948439154100 Make IgvmMemoryRegion a QOM object, embedding MemoryRegion, and use it as the region owner. The IGVM list and memory subsystem can now hold references independently, and QOM frees after the last reference is dropped, fixing leaks reported by ASAN while running tests. - object_unparent() is no longer needed, children are automatically unref - switch to memory_region_init_ram_flags_nomigrate() as other helpers expect a DEVICE Signed-off-by: Marc-Andr=C3=A9 Lureau --- backends/igvm.c | 97 +++++++++++++++++++++++++-------------= ---- include/system/igvm-internal.h | 9 ++-- 2 files changed, 64 insertions(+), 42 deletions(-) diff --git a/backends/igvm.c b/backends/igvm.c index 784a56504e77..6cd192f2f5ff 100644 --- a/backends/igvm.c +++ b/backends/igvm.c @@ -35,6 +35,12 @@ #define IGVM_VHT_OPTIONAL_BIT (1U << 31) #endif =20 +struct IgvmMemoryRegion { + Object parent_obj; + MemoryRegion mr; + QTAILQ_ENTRY(IgvmMemoryRegion) next; +}; + /* * Bit 31 of the variable header type indicates that the header is * optional and can be safely ignored by a loader that does not @@ -221,10 +227,13 @@ static void *qigvm_prepare_memory(QIgvm *ctx, uint64_= t addr, uint64_t size, int region_identifier, Error **errp) { ERRP_GUARD(); - IgvmMemoryRegion *imr =3D NULL; + g_autoptr(IgvmMemoryRegion) imr =3D NULL; Int128 gpa_region_size; + g_autofree char *region_name =3D NULL; + uint32_t flags =3D 0; MemoryRegionSection mrs =3D memory_region_find(get_system_memory(), addr, size); + if (mrs.mr) { if (!memory_region_is_ram(mrs.mr)) { memory_region_unref(mrs.mr); @@ -247,36 +256,29 @@ static void *qigvm_prepare_memory(QIgvm *ctx, uint64_= t addr, uint64_t size, return NULL; } return qemu_map_ram_ptr(mrs.mr->ram_block, mrs.offset_within_regio= n); - } else { - /* - * The region_identifier is the is the index of the IGVM directive= that - * contains the page with the lowest GPA in the region. This will - * generate a unique region name. - */ - g_autofree char *region_name =3D - g_strdup_printf("igvm.%X", region_identifier); - imr =3D g_new0(IgvmMemoryRegion, 1); - imr->mr =3D g_new0(MemoryRegion, 1); - if (ctx->machine_state->cgs && - ctx->machine_state->cgs->require_guest_memfd) { - if (!memory_region_init_ram_guest_memfd(imr->mr, NULL, - region_name, size, err= p)) { - g_free(imr->mr); - g_free(imr); - return NULL; - } - } else { - if (!memory_region_init_ram(imr->mr, NULL, region_name, size, - errp)) { - g_free(imr->mr); - g_free(imr); - return NULL; - } - } - memory_region_add_subregion(get_system_memory(), addr, imr->mr); - QTAILQ_INSERT_TAIL(&ctx->cfg->memory_regions, imr, next); - return memory_region_get_ram_ptr(imr->mr); } + + /* + * The region_identifier is the is the index of the IGVM directive that + * contains the page with the lowest GPA in the region. This will + * generate a unique region name. + */ + region_name =3D g_strdup_printf("igvm.%X", region_identifier); + imr =3D IGVM_MEMORY_REGION(object_new(TYPE_IGVM_MEMORY_REGION)); + if (ctx->machine_state->cgs && + ctx->machine_state->cgs->require_guest_memfd) { + flags =3D RAM_GUEST_MEMFD; + } + if (!memory_region_init_ram_flags_nomigrate(&imr->mr, OBJECT(imr), + region_name, size, + flags, errp)) { + return NULL; + } + vmstate_register_ram_global(&imr->mr); + memory_region_add_subregion(get_system_memory(), addr, &imr->mr); + object_ref(imr); /* for the list */ + QTAILQ_INSERT_TAIL(&ctx->cfg->memory_regions, imr, next); + return memory_region_get_ram_ptr(&imr->mr); } =20 static int qigvm_type_to_cgs_type(IgvmPageDataType memory_type, bool unmea= sured, @@ -1118,14 +1120,33 @@ void qigvm_cleanup_memory(IgvmCfg *cfg) { IgvmMemoryRegion *imr, *tmp; =20 - QTAILQ_FOREACH_SAFE(imr, &cfg->memory_regions, next, tmp) - { - trace_qigvm_cleanup_memory(imr->mr->name); - memory_region_del_subregion(get_system_memory(), imr->mr); - vmstate_unregister_ram(imr->mr, NULL); + QTAILQ_FOREACH_SAFE(imr, &cfg->memory_regions, next, tmp) { + trace_qigvm_cleanup_memory(imr->mr.name); QTAILQ_REMOVE(&cfg->memory_regions, imr, next); - /* this triggers MemoryRegion cleanup */ - object_unparent(OBJECT(imr->mr)); - g_free(imr); + object_unref(OBJECT(imr)); } } + +static void qigvm_memory_region_finalize(Object *obj) +{ + IgvmMemoryRegion *imr =3D IGVM_MEMORY_REGION(obj); + + if (imr->mr.container) { + memory_region_del_subregion(imr->mr.container, &imr->mr); + } + vmstate_unregister_ram(&imr->mr, NULL); +} + +static const TypeInfo qigvm_memory_region_info =3D { + .name =3D TYPE_IGVM_MEMORY_REGION, + .parent =3D TYPE_OBJECT, + .instance_size =3D sizeof(IgvmMemoryRegion), + .instance_finalize =3D qigvm_memory_region_finalize, +}; + +static void qigvm_register_types(void) +{ + type_register_static(&qigvm_memory_region_info); +} + +type_init(qigvm_register_types); diff --git a/include/system/igvm-internal.h b/include/system/igvm-internal.h index 9e9fa1d9afdb..625d2f9a9f83 100644 --- a/include/system/igvm-internal.h +++ b/include/system/igvm-internal.h @@ -18,10 +18,11 @@ #include "system/confidential-guest-support.h" #include =20 -typedef struct IgvmMemoryRegion { - QTAILQ_ENTRY(IgvmMemoryRegion) next; - MemoryRegion *mr; -} IgvmMemoryRegion; +typedef struct IgvmMemoryRegion IgvmMemoryRegion; + +#define TYPE_IGVM_MEMORY_REGION "igvm-memory-region" + +OBJECT_DECLARE_SIMPLE_TYPE(IgvmMemoryRegion, IGVM_MEMORY_REGION) =20 struct IgvmCfg { Object parent_obj; --=20 2.55.0.543.g5ebe2ebe4ea8 From nobody Sat Sep 26 20:02:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788684911; cv=none; d=zohomail.com; s=zohoarc; b=BzRRV1cSxPjT/OintBqXNaxcfKcdUwzANeL+jFiuVBccucnReezQxIuEcrrmIP9PppTWu7hkPwYDEdat5pv+sriWEjtbM9NMG0Pma54nvCcZtqmgbxQnOcRkoqqI2pVlz6shOnyIzpW9AycqP5FbuU9TcTj32EWMNCUL7A1ali8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788684911; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=MlOzefOMyFIYin8lnPxCAKgI3I17CqTz3mHT4Btd4VQ=; b=XcxYCFZC3vhe4EGsocqdrgOOnC8SyRdhq1SG7CM94qOPV5vqlYxwFJczXzDNIWN9PiCYcLBiULrrphrxUWVgyumigFqh010ex+xMoNSin70w/iYSFuhCpKgZH1OwulLvNp4P1Kuk7NJGdgySsM/WbNhjchxJIctsZj78yyto2WE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788684911582394.50924434833814; Sun, 6 Sep 2026 01:55:11 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x38e4-0002Zj-3N; Sun, 06 Sep 2026 04:54:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x38e3-0002YP-35 for qemu-devel@nongnu.org; Sun, 06 Sep 2026 04:54:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x38e1-0000oT-Ky for qemu-devel@nongnu.org; Sun, 06 Sep 2026 04:54:34 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-478-CM2PUJlxMcOYobfVR1V-Wg-1; Sun, 06 Sep 2026 04:54:29 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8AD2918011EA; Sun, 6 Sep 2026 08:54:26 +0000 (UTC) Received: from localhost (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1ADE230002EF; Sun, 6 Sep 2026 08:54:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788684873; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MlOzefOMyFIYin8lnPxCAKgI3I17CqTz3mHT4Btd4VQ=; b=UQaTkPIWsMUXkRNtPaBMnUQ9bwmYGhplicmVR+lhDF2+6dG4glb5cCj6HMDFMqU6JjhGwh QJmPJ6UimkCwe/FwoXRqvQcxv7c3YYLy+/CQtY5VItzZVoHEuH6U3Yjs6Q+/aVKMpHwTCg /2fsdvCjjaWOHVKSNbQQwOLuXeBxrpY= X-MC-Unique: CM2PUJlxMcOYobfVR1V-Wg-1 X-Mimecast-MFC-AGG-ID: CM2PUJlxMcOYobfVR1V-Wg_1788684866 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sun, 06 Sep 2026 12:53:41 +0400 Subject: [PATCH 9/9] hw/s390x/ipl: fix short SCSI loadparm buffer over-read MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260906-nohmp-next-v1-9-2b21e63974f3@redhat.com> References: <20260906-nohmp-next-v1-0-2b21e63974f3@redhat.com> In-Reply-To: <20260906-nohmp-next-v1-0-2b21e63974f3@redhat.com> To: qemu-devel@nongnu.org Cc: Brian Cain , Pierrick Bouvier , "Michael S. Tsirkin" , Stefano Garzarella , Paolo Bonzini , Zhao Liu , Peter Maydell , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, Ani Sinha , Gerd Hoffman , Fabiano Rosas , Laurent Vivier , Jared Rossi , Zhuoying Cai , Christian Borntraeger , Jason Herne , Richard Henderson , Ilya Leoshkevich , David Hildenbrand , Halil Pasic , Eric Farman , Matthew Rosato , Cornelia Huck , qemu-s390x@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1774; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=bIdpGVAkPWhL6iCZ6lwgkzBd3NrpzsxJLuDajQEJb08=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqnSoZ9BWKtdg14kuD7L52A3Yq38D3WnaWC8RzL 6Nv+J+eKl6JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCap0qGQAKCRDa6OEJdZac 5SNIEACwDQ7QCTE+tiPha8vJ+E1Sh6Tu4NLwIAwOJgAd0kWAJVxiDXazng7m43jX4e1DRuRrs/e g8YX7sAoj6aPpEkB0Zc7JBAC3sHcq0QzOsKK1sKaCGwiJinKwa337eXRUOMhixmGiXgRTqVC6dB RNQg9z4jZWWL3zFsPfqZDjLbno7dftad0e0R0sLiwD7rxrb5kezqafZO6uOT0QR3Lz382z4HgR2 a+YX0woMlrq++Q9tIdf/tGKIhMR95l6UnzFhHw2btgQDvN1bw3TLznqcZKHSzGTLhFdZxwOj/cm O5y++S3C719rR9TnSI4zrjy5hCneyobWpYr9He3sSl2tEnvs1ajlmJ5VOAly2MTXrEBGS/w3J/s 6GqnpwzeGiMUe6PXdpjL0DAnEz5W6dSLK66Dr2UMZQ2zLIvpwFrCn+FP9Qc0JvvZ4CZ6jFPuZhv U4cXBf0vZkbBuI2DXo42hBUhMtBRJ26Ofwm5uZeVJ6hMQFZ+DEWnNuS2fJeJSiqwmdneo0EUXUr TiZhlpPEYevJNWS+aBH0cwgXa8JCamUFptxRGg617eylXPVGvCvEVK2+jcsLtENN+14xttamvbm OlyXV0Zabl8jGE51SOHksqqcypYep4lJwUU8s42ul20k9MQ/9G86Hrv7geu/iorvcdxUHFJ3Y7m ydKm2ygW5/dtGrQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788684916656154100 s390_build_iplb() initially points lp at the eight-byte CCW loadparm array. For SCSI devices, it can replace lp with a variable-length string returned by object_property_get_str(). The following memcmp() still reads eight bytes. ASan reports buffer-overflow on value "3", when running test_scsi_loadparm func-s390x-boot_4k test. Check the fixed-size CCW loadparm for the 8-zero before the SCSI property can replace lp. Fixes: 429442e52d94 ("hw: Add "loadparm" property to scsi disk devices for = booting on s390x") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Eric Farman Reviewed-by: Jared Rossi --- hw/s390x/ipl.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c index d59ed36c7839..e249d50b1ce3 100644 --- a/hw/s390x/ipl.c +++ b/hw/s390x/ipl.c @@ -549,6 +549,11 @@ static bool s390_build_iplb(DeviceState *dev_st, IplPa= rameterBlock *iplb) if (ccw_dev) { lp =3D ccw_dev->loadparm; =20 + /* If the device loadparm is empty use the global machine loadparm= */ + if (memcmp(lp, NO_LOADPARM, 8) =3D=3D 0) { + lp =3D S390_CCW_MACHINE(qdev_get_machine())->loadparm; + } + switch (devtype) { case CCW_DEVTYPE_SCSI: sd =3D SCSI_DEVICE(dev_st); @@ -583,11 +588,6 @@ static bool s390_build_iplb(DeviceState *dev_st, IplPa= rameterBlock *iplb) break; } =20 - /* If the device loadparm is empty use the global machine loadparm= */ - if (memcmp(lp, NO_LOADPARM, 8) =3D=3D 0) { - lp =3D S390_CCW_MACHINE(qdev_get_machine())->loadparm; - } - s390_ipl_convert_loadparm((char *)lp, iplb->loadparm); iplb->flags |=3D DIAG308_FLAGS_LP_VALID; =20 --=20 2.55.0.543.g5ebe2ebe4ea8