From nobody Sat Sep 26 20:52:33 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788178242; cv=none; d=zohomail.com; s=zohoarc; b=czd+pKEHZlOka9b739NMv8AJxpqEuLrdQSICxcDTQwUYvMoT+OWzk9AC0GsMORByqt5tLJQgZ6UKfhkMO3lZHLidkMEAthUnubr2Z6NDYwQiHq3GkCco1oNpw889j1CO32KFtj5srtnVB7K6LfKJKzGoXMXcSExIsQt1e16c2wo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788178242; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=DJ71f/qdz5KdKJQdojfsIPvBEJrUWyb9Ya2HTj9ykp0=; b=gTrwJ96bUX0P2RdZShajucS1O3hRBHxiqQieZuPeMZYsBD4ubUXiBqkN1YEPoRykSrsOu2H0rlEqnYGXaNHzL+itp4jDWR18S/hYzpDfTlVGy4wVfHnFxOd+OOoXe6SjBwIKEKlbVC5DkxrriFqADIdQTuKRwdBOdmXixfghn1A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788178242722495.1029358816983; Mon, 31 Aug 2026 05:10:42 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x10qI-0007SM-18; Mon, 31 Aug 2026 08:10:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x10qA-0007RG-2Q for qemu-devel@nongnu.org; Mon, 31 Aug 2026 08:10:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x10q8-0002u3-HD for qemu-devel@nongnu.org; Mon, 31 Aug 2026 08:10:17 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-649-HKQSGJwaO7WCE4cgarthlA-1; Mon, 31 Aug 2026 08:10:13 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F327A180AEAD; Mon, 31 Aug 2026 12:10:12 +0000 (UTC) Received: from localhost (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E2F301955F03; Mon, 31 Aug 2026 12:10:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788178215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DJ71f/qdz5KdKJQdojfsIPvBEJrUWyb9Ya2HTj9ykp0=; b=eAWwOWEJCXDnp1xkMUQ9xvZcdXnojuU/gJONJ9k+bcqPjTxSqS4S8DLvKtxXAD6epwyN1x B5fKbHFq3IMu+7I8mmY8zVosvqnMg2j7J72D48Xo6bg86Ou/HZ+86JUhxkTaasfsWmHRvh mKCOzVirnjvNtBqHnp/s8/2A9bY4hxA= X-MC-Unique: HKQSGJwaO7WCE4cgarthlA-1 X-Mimecast-MFC-AGG-ID: HKQSGJwaO7WCE4cgarthlA_1788178213 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: zycai@linux.ibm.com, berrange@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH] crypto/x509-utils: propagate the error Date: Mon, 31 Aug 2026 16:10:09 +0400 Message-ID: <20260831121009.2810804-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788178244874154100 From: Marc-Andr=C3=A9 Lureau Propagate the error when qcrypto_x509_get_pk_algorithm fails, instead of falling through to return 0 (success) with *errp set. Fixes: e8317c4c9f68 ("crypto/x509-utils: Add helper functions for DIAG 320 = subcode 2") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Zhuoying Cai --- crypto/x509-utils.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/crypto/x509-utils.c b/crypto/x509-utils.c index 34cbfca26bff..edcc44de80d3 100644 --- a/crypto/x509-utils.c +++ b/crypto/x509-utils.c @@ -319,6 +319,9 @@ int qcrypto_x509_check_ecc_curve_p521(uint8_t *cert, si= ze_t size, Error **errp) int curve_id; =20 algo =3D qcrypto_x509_get_pk_algorithm(cert, size, errp); + if (algo < 0) { + return -1; + } if (algo !=3D GNUTLS_PK_ECDSA) { return 0; } --=20 2.55.0.543.g5ebe2ebe4ea8