From nobody Sat Sep 26 20:52:10 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788178218; cv=none; d=zohomail.com; s=zohoarc; b=frqJNHY2Q+MUj+3UPyr5+3O/8nQAtxgJIlmrSIua11yI2L0kogoi4doR2ViygkE7Vs9w82HlgcPuG5vx/3K9nCTU6AegR5AuJW4sE81NDu2xPbB9PJxna2TsZVL0Ld1T9Jt2ShIeCE3qRxaeOMANfIf4DpM8hRPAIizjX7PsvlI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788178218; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=27PWzbAAe+3thWfdEgHVJHj43DTleRMLb89kWOmDVRo=; b=dTLRRXhNdXWBLiP+u/hYRhkv9WZ/JpQcirOpYDR2sUBzPY0P61klfjKyeWnqFtgILVuvidrlXWM2njDCDa7tA9++r1th1sOjsYyAhqHTJk0++9KhHtxui8JQdcn+gFVFUrg0sJXenuXGz/F7IGU/MG3InszlCZPRf5LDxBc9664= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788178218226501.76364504093374; Mon, 31 Aug 2026 05:10:18 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x10pa-0007AD-Sm; Mon, 31 Aug 2026 08:09:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x10pU-00079K-Gj for qemu-devel@nongnu.org; Mon, 31 Aug 2026 08:09:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x10pS-0002ev-Lp for qemu-devel@nongnu.org; Mon, 31 Aug 2026 08:09:36 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-357-ZFnyx2xZPyq1vygG8XcOwA-1; Mon, 31 Aug 2026 08:09:31 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7B53C19776AC; Mon, 31 Aug 2026 12:09:30 +0000 (UTC) Received: from localhost (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 743DD426; Mon, 31 Aug 2026 12:09:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788178173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=27PWzbAAe+3thWfdEgHVJHj43DTleRMLb89kWOmDVRo=; b=OZDRyB6RQ9s9H8TuHLebuHcRb9CquzZ/wQlbF/9oFLy8Auw+3O3KoMti95uJYRvJyRsvgB yUqbH7qDvRaRV3HKyjHGdd9D+7ZrGhA5e0sFebGU3vQqCOf6ecyLgs98J0xrB3WCe8lDNx TzmPznZTpq4qcdrCrqq7hBngbdDfsHk= X-MC-Unique: ZFnyx2xZPyq1vygG8XcOwA-1 X-Mimecast-MFC-AGG-ID: ZFnyx2xZPyq1vygG8XcOwA_1788178170 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: zycai@linux.ibm.com, berrange@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH] crypto/x509-utils: don't double set errp Date: Mon, 31 Aug 2026 16:09:26 +0400 Message-ID: <20260831120926.2809313-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788178220672154100 From: Marc-Andr=C3=A9 Lureau qcrypto_x509_get_ecc_curve() already sets errp on failure. Fixes: e8317c4c9f68 ("crypto/x509-utils: Add helper functions for DIAG 320 = subcode 2") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Zhuoying Cai --- crypto/x509-utils.c | 1 - 1 file changed, 1 deletion(-) diff --git a/crypto/x509-utils.c b/crypto/x509-utils.c index e4767f98384e..34cbfca26bff 100644 --- a/crypto/x509-utils.c +++ b/crypto/x509-utils.c @@ -325,7 +325,6 @@ int qcrypto_x509_check_ecc_curve_p521(uint8_t *cert, si= ze_t size, Error **errp) =20 curve_id =3D qcrypto_x509_get_ecc_curve(cert, size, errp); if (curve_id =3D=3D -1) { - error_setg(errp, "Failed to get ECC curve"); return -1; } =20 --=20 2.55.0.543.g5ebe2ebe4ea8