From nobody Sat Sep 26 21:37:56 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1788012958; cv=none; d=zohomail.com; s=zohoarc; b=bHN6qazy0tljAQmtV9F16MzNz0jprE5q9CszJixrtVPsWs5+33pJN/OqlRfjbdfuaSPFYYdpfmFWkXHRiHE1GOOviWhbWs1+2zXJRQCOqGAzHsM9XRmU79AwCbFPIMk2z6GoK+6zttKv5Bec9ZLQx7Wu4gRxriblDz3iErFz5wE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788012958; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5MeeeDTacSpu27Iq1eZBWJAfOaWwmn/9mODx1GaTsuA=; b=HzFgvbP0dF2LVUCFWRM5vrLZbyJddHMgmlW/2Cya8y7ytr/vKLtWUZIWfwKb3G1ojK7Mw/D3yQ/R9VsJZD1DkVW3wk9ptn9h+Kq7GuNnveEBoLVOrRHfxp5luBclYeNMJ28kef1AZSKVp5xFohAGT4WtKI6x3keeThrr+McGX+4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1788012958369666.1862400307051; Sat, 29 Aug 2026 07:15:58 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x0Jps-0000yQ-GS; Sat, 29 Aug 2026 10:15:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x0Jpq-0000xw-JZ for qemu-devel@nongnu.org; Sat, 29 Aug 2026 10:15:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x0Jpo-0003yR-BQ for qemu-devel@nongnu.org; Sat, 29 Aug 2026 10:15:06 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-sTC2PIYZMHifnEHMackO_g-1; Sat, 29 Aug 2026 10:15:00 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4D45A1956096; Sat, 29 Aug 2026 14:14:59 +0000 (UTC) Received: from localhost (headnet03.pony-001.prod.iad2.dc.redhat.com [10.2.32.114]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 553021803A40; Sat, 29 Aug 2026 14:14:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788012902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5MeeeDTacSpu27Iq1eZBWJAfOaWwmn/9mODx1GaTsuA=; b=OL39VH3tYXQAbHc4txh132KwkuZcrcxfssmBa7F2WbEvHO1rdKTylCqeFbxo/DzYFZR9yI wGaYT+NMPXAuTlk6wHtbMPWYabzpvwbjNfUgFfbtA4zo4bLjcIG+gMrdfoIChkTbTT/QBW XRp+U+vffnOv8x1dosLhN5E3m9dr2SM= X-MC-Unique: sTC2PIYZMHifnEHMackO_g-1 X-Mimecast-MFC-AGG-ID: sTC2PIYZMHifnEHMackO_g_1788012899 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: akihiko.odaki@gmail.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH] ui/dbus: fix cursor race, copy cursor data Date: Sat, 29 Aug 2026 18:14:47 +0400 Message-ID: <20260829141447.1677081-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1788012960791154100 From: Marc-Andr=C3=A9 Lureau Eleminates the undefined behavior where virtio-gpu's memcpy() overwrites the buffer that an in-flight gvariant still references. Fixes the data race where the GDBus worker thread calls cursor_unref() concurrently with main thread. Fixes: 142ca628a733 ("ui: add a D-Bus display backend") Signed-off-by: Marc-Andr=C3=A9 Lureau --- ui/dbus-listener.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/ui/dbus-listener.c b/ui/dbus-listener.c index 2e2f6ba4183a..aca802cb11cb 100644 --- a/ui/dbus-listener.c +++ b/ui/dbus-listener.c @@ -896,16 +896,18 @@ static void dbus_cursor_define(DisplayChangeListener = *dcl, { DBusDisplayListener *ddl =3D container_of(dcl, DBusDisplayListener, dc= l); GVariant *v_data =3D NULL; + size_t size =3D c->width * c->height * 4; + void *copy =3D g_memdup2(c->data, size); =20 ddl_discard_cursor_messages(ddl); =20 v_data =3D g_variant_new_from_data( G_VARIANT_TYPE("ay"), - c->data, - c->width * c->height * 4, + copy, + size, TRUE, - (GDestroyNotify)cursor_unref, - cursor_ref(c)); + g_free, + copy); =20 qemu_dbus_display1_listener_call_cursor_define( ddl->proxy, --=20 2.55.0.543.g5ebe2ebe4ea8