From nobody Sat Sep 26 21:37:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1787845451; cv=none; d=zohomail.com; s=zohoarc; b=BXkPES6uU636DiTV0LbEZPUPQVX5+oepk/n0qzhBrjZ2wsH+uk5bp1zH97GC8AKLvqaSrTWDcA3IMSjYxCFQi3rETeTuS+wopGN2icoIarBse8JxGbLvKHWNpM9l4wl7kdfEhvI2Fxww46r+hW/pV32NZdSQxDy5AZ73+SbYZxo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787845451; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+mX6A4o/0nrBGPuneaxlEe/s9qiuccqTUnHZG1ZQz9Y=; b=LZHhvPx9tsFYirA0yDifpymODkao9SCM5Wf7odAmcbzpbZvyfMjX4XXkwPHSdqRKI6Taqx1/Q4k7xI+DJZfbTQCDzXBIHg+UUiX81dB6ohyHA853MkWvmM1Zea0eF5H78q1ORRc1g8j4zPueRtARKbbZb+tjeSPBJ5fCJpQof2M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1787845451618303.112001971326; Thu, 27 Aug 2026 08:44:11 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wzcGs-0008FT-80; Thu, 27 Aug 2026 11:44:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wzcGr-0008F2-7U for qemu-devel@nongnu.org; Thu, 27 Aug 2026 11:44:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wzcGp-0001k2-8O for qemu-devel@nongnu.org; Thu, 27 Aug 2026 11:44:04 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-516-JEeeDipyP363AmfHUG2QZA-1; Thu, 27 Aug 2026 11:44:00 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 67475195DE4A; Thu, 27 Aug 2026 15:43:59 +0000 (UTC) Received: from localhost (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 648A91955F70; Thu, 27 Aug 2026 15:43:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787845442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+mX6A4o/0nrBGPuneaxlEe/s9qiuccqTUnHZG1ZQz9Y=; b=NmL6voSfFBX+6n4lNqHAaKmV3Z40Ob1mQTddRF7ZnnhKRXdGSmR633mPfNj+f5plDR6mL8 DbR+EdiOZwbVTwjrS4PXdD+wT2Nv+EYp+O0F2AeQ1GGNxEwrpUN67eOKFENSS7tR0pXxuC feJPGGWWIW5hDsgwyJeSjJglH8RaZvA= X-MC-Unique: JEeeDipyP363AmfHUG2QZA-1 X-Mimecast-MFC-AGG-ID: JEeeDipyP363AmfHUG2QZA_1787845439 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: akihiko.odaki@gmail.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH] virtio-gpu/virgl: free BHs and timers on renderer reset Date: Thu, 27 Aug 2026 19:43:55 +0400 Message-ID: <20260827154355.3346449-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1787845453343158500 From: Marc-Andr=C3=A9 Lureau virtio_gpu_virgl_reset() does not free the bottom halves or timers allocated by the previous virtio_gpu_virgl_init() call. A subsequent virtio_gpu_virgl_init() overwrites the old pointers, leaking the previous allocations. Fixes: bd9258917fbf ("virtio-gpu: Destroy virgl resources on virtio-gpu res= et") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Akihiko Odaki --- hw/display/virtio-gpu-virgl.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c index 0b79aef8d1f5..8bf6417c6514 100644 --- a/hw/display/virtio-gpu-virgl.c +++ b/hw/display/virtio-gpu-virgl.c @@ -1425,6 +1425,7 @@ void virtio_gpu_virgl_reset_scanout(VirtIOGPU *g) =20 static bool virtio_gpu_virgl_reset(VirtIOGPU *g) { + VirtIOGPUGL *gl =3D VIRTIO_GPU_GL(g); struct virtio_gpu_simple_resource *res, *tmp; =20 /* @@ -1443,6 +1444,11 @@ static bool virtio_gpu_virgl_reset(VirtIOGPU *g) =20 virtio_gpu_virgl_reset_async_fences(g); =20 + g_clear_pointer(&gl->cmdq_resume_bh, qemu_bh_delete); + g_clear_pointer(&gl->async_fence_bh, qemu_bh_delete); + g_clear_pointer(&gl->print_stats, timer_free); + g_clear_pointer(&gl->fence_poll, timer_free); + return true; } =20 --=20 2.55.0.543.g5ebe2ebe4ea8