From nobody Sat Sep 26 21:37:04 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1787673030; cv=none; d=zohomail.com; s=zohoarc; b=by0Iu4pk6QAygb0vaLrYWRQcQLUlD3H/GxGfm7NdHPIqtgMMrLUhp09MnMK6LvQY0xZXTPCRH98sad+KNx/oWHmxu9FYr5JwByZM3nNnds4CQsWDnYQ6SDbfMdKMlEbPCtFc9Bp2wDrdpF0ATyz3psobCP7wMSxdPJWtZ+a+PmA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787673030; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=QFiP7cYJs6osMWTZPzSxL6YtBHQtAPVaGS3ZceAg6zI=; b=IDDqcxmQ5i9eUjWoqiNaJHqVumOCk2yfYXLo8nCYKMN7Z4m/9N3W7TmNmh/0t9LS0VmVX3rZtnCLHGyDsYooPCx03D7fyyRPGyL29DTW0cEGmrgNRl9PNaGQEHjPd6CHHzFMbxcqxwUKD6ZRQPISIY75ZStMH7BGJ0W1I0VQxbw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1787673030252470.5339628959151; Tue, 25 Aug 2026 08:50:30 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wytPb-0001LC-Li; Tue, 25 Aug 2026 11:50:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wytPa-0001KL-4q for qemu-devel@nongnu.org; Tue, 25 Aug 2026 11:50:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wytPY-0006br-F1 for qemu-devel@nongnu.org; Tue, 25 Aug 2026 11:50:05 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-414-TSyV5UPpNcyNko7SFHzezQ-1; Tue, 25 Aug 2026 11:49:32 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0012D195604C; Tue, 25 Aug 2026 15:49:00 +0000 (UTC) Received: from localhost (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9B3AB434; Tue, 25 Aug 2026 15:48:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787673002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=QFiP7cYJs6osMWTZPzSxL6YtBHQtAPVaGS3ZceAg6zI=; b=hVLuMZPWx8wC78gC4Tis0J65x3QaN5s+skCRVL6fUQBpeSj0gF2gncQcB7c+xm7CRbpnBP 0xg2DyWwy6W3XaCaR616vBlwkao3awafg4lu4NWE+ZBSyf9skOoHvNKac2hCjDZrcbTQdm tkHRAyOky/a89GphcECLNJUPyGMttTA= X-MC-Unique: TSyV5UPpNcyNko7SFHzezQ-1 X-Mimecast-MFC-AGG-ID: TSyV5UPpNcyNko7SFHzezQ_1787672952 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Fam Zheng , Paolo Bonzini , "Michael S. Tsirkin" , Stefan Hajnoczi Subject: [PATCH] virtio-scsi: set dataplane_started to false upon failure Date: Tue, 25 Aug 2026 11:48:54 -0400 Message-ID: <20260825154854.263819-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1787673032920158500 Content-Type: text/plain; charset="utf-8" Commit e24a47c5b73e ("virtio-scsi: do not use vring in dataplane") set dataplane_started to true when virtio_scsi_dataplane_start() fails. This is likely a typo since dataplane is not functional after failure. The non-ioeventfd fallback is broken because dataplane_started is true after virtio_scsi_dataplane_start() failure. As a result, the following assertion failure occurs when a virtio-scsi device exceeds the open file descriptor ulimit when setting up notifiers (eventfds): $ ulimit -n 104 # exact number can vary based on QEMU version $ qemu-system-x86_64 -M q35,accel=3Dkvm -m 1G -cpu host -smp 14 \ --blockdev file,node-name=3Ddrive0,filename=3Dtest.img,cache.direc= t=3Don,aio=3Dnative \ --blockdev file,node-name=3Ddrive1,filename=3Ddata01.img,cache.dir= ect=3Don,aio=3Dnative \ --device virtio-scsi-pci,id=3Dvirtio-scsi-pci0 \ --device scsi-hd,drive=3Ddrive0,bus=3Dvirtio-scsi-pci0.0 \ --device virtio-scsi-pci,id=3Dvirtio-scsi-pci1 \ --device scsi-hd,drive=3Ddrive1,bus=3Dvirtio-scsi-pci1.0 qemu: virtio-scsi: Failed to set guest notifiers (-24), ensure -accel kvm= is set. qemu: virtio_bus_start_ioeventfd: failed. Fallback to userspace (slower). qemu-system-x86_64: ../hw/scsi/virtio-scsi.c:1017: virtio_scsi_reset: Ass= ertion `!s->dataplane_started' failed. Aborted (core dumped) Cc: Paolo Bonzini Fixes: e24a47c5b73e ("virtio-scsi: do not use vring in dataplane") Buglink: https://redhat.atlassian.net/browse/RHEL-193328 Signed-off-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/scsi/virtio-scsi-dataplane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/virtio-scsi-dataplane.c b/hw/scsi/virtio-scsi-dataplan= e.c index 95f13fb7c28..bcb6e441335 100644 --- a/hw/scsi/virtio-scsi-dataplane.c +++ b/hw/scsi/virtio-scsi-dataplane.c @@ -230,7 +230,7 @@ fail_host_notifiers: fail_guest_notifiers: s->dataplane_fenced =3D true; s->dataplane_starting =3D false; - s->dataplane_started =3D true; + s->dataplane_started =3D false; return -ENOSYS; } =20 --=20 2.55.0