From nobody Sat Sep 26 21:37:04 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1787661781; cv=none; d=zohomail.com; s=zohoarc; b=hWLMG+IM3zh9ZAXgkeKt4CV23S2Il/BN7076mosgV9CI1NFUlBwvZGwi1Ifb0KSpB+uzpHV64B1S3O+3rSph6IoobXfBHLDPAEtXnryhWNyOhacmLT/af+bMuaHmiObdkOY5VqqxOuBn3o8wg17uYgHKmI1q+xvBmcIR0dB5HTY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787661781; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tAuwrbquIP3Kxb5YoLyWvJc/gbwvQ3FjLeU93AzdOQs=; b=fFMuBcQ4oQ3s41+3GBKekGqbIqc228QbFXGlOFKNBGIH9XBCLur0rr+yGnrQBLuBWkWDYYYeqds1L1L6XWW5ha2aALStx5eeM/LqKSNiSxQrU+zoYytniwLco/bQHiME5ah4eSiSnsMQoDk/fnkmucZlB2/yqHuBBp2ORCHzaK4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1787661781536241.62507295831608; Tue, 25 Aug 2026 05:43:01 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wyqTn-0005LY-L3; Tue, 25 Aug 2026 08:42:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wyqTl-0005LD-TD for qemu-devel@nongnu.org; Tue, 25 Aug 2026 08:42:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wyqTk-0005oW-6V for qemu-devel@nongnu.org; Tue, 25 Aug 2026 08:42:13 -0400 Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-332-j2cbq4mcN4GCURV5DoQ5fA-1; Tue, 25 Aug 2026 08:42:07 -0400 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2d6f73d0f89so7609745ad.0 for ; Tue, 25 Aug 2026 05:42:07 -0700 (PDT) Received: from rhel9-box.lan ([106.219.132.56]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-2d676761c1fsm26759265ad.16.2026.08.25.05.42.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Aug 2026 05:42:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787661729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=tAuwrbquIP3Kxb5YoLyWvJc/gbwvQ3FjLeU93AzdOQs=; b=KVQcxJEfzJvLR3GIxD4+8BawW/IBPa9Gb3OW9azWg+svrXabs0XlYAd+RbK1C7teK3qaeE OSdD1mtKeR0yjOsLVswXRGJesIsosvP++AkNmEGxtq5m6a5HsjcS5xLC7PQVcIb5TfHi5Z AbCWFHaqQ9HyFr0KtYYwXBFJEVI1y7o= X-MC-Unique: j2cbq4mcN4GCURV5DoQ5fA-1 X-Mimecast-MFC-AGG-ID: j2cbq4mcN4GCURV5DoQ5fA_1787661726 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1787661726; x=1788266526; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=tAuwrbquIP3Kxb5YoLyWvJc/gbwvQ3FjLeU93AzdOQs=; b=X10lqCEbTi/48UoR4hfN2TeanAydvtNDHmJ7P0X7ZUTA7PQbNxKttSvn4hFteXlmzy VKxyTYVa4XZsUcOsnZJ+0sG3xKk7h6DjKMuV0fGR01cLYmrt1x2OsjaZGX589R3ae/eX tLEiBNrXk6GA0aw/Tw5qsNHGFAHpDRW5YS7Sk0daAZH5M1yysHjozVTmS81wnKPknP8B GPaa4LnhC8BEM5aZaJpubNcB+wsAZJkzVl2jNKRgNTqmPmkHZm5LnXWCzSbIJiuNh8Rq nI9sVxqYGo24JSMEtXE2otGacaKzb6J0Qk1HSjByw3S5jAMgrFLNWWRDJ5SY2OE9J3Rx frsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787661726; x=1788266526; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tAuwrbquIP3Kxb5YoLyWvJc/gbwvQ3FjLeU93AzdOQs=; b=NGFx3Vsd1G8p4bRN6CBoIPkLCsS4Q/NGVkzt66Sz65iv8W1o2BiHfYQdfFukfu76Lr Nwc6WqQUUf6CAeAABjNjrcJRrusbM7sHDyjG4Hy7j6wkDYvhLXI31MqJa4wAeFWdzfLy umQlh2SAj/CtSFuiVju0+T6rlAWd6UawlLYiZvNfEudDFqpiIo0GyPXwSGp5E5IDe+qK t9bR6/A2ES5DXeMihXJDZ5YE8p+A+4877ZT5ZD02tJipA8zg0wu/zonCrA7yBzPMFE+a 2SdaEyDa323WoMI7O3II7xtKmjw49pcuHiarc2VCe08E8tTIPy02kQUsy4pEXeItpG3x ZIOA== X-Gm-Message-State: AFuF++mUp8xEui775BgTa5t5q3HmpN5LRSwKeYgx+h8GLX26CwzXEN/j 2GdyBmNergBLKKZDbO2ABR4loEkZXNRTLHzPAvORq62F3S2iOSAAX31adAy2HLokPvAIdiDl4qT m2nI+5b9qSsvCemuQD/dVn3yRxKEyWi826FalMrkI9jUf3e7e0aeAFSB4 X-Gm-Gg: AR+sD138GIlmp/1GXq7xFOEqtBxoeqR+SMS8W/cG4o58XWXpm61B5yvSH5qQNdCXmsq oC6ntAYJS3JwUe/xOG11a3f0Aww19xhmHBPJVeZfySU5OOFjL8vqxSbJa5rHc13xhssdKKkeEAH xrdk8wuDfMBk7BLkCrrwU7N/eDCtidoY+VNui6spk94QVkp0tg/5hkWd+VTZF4+3JOpJ0YVCNAF 15CuCLgWywgFbL4VfAk0RirWk4M39eFRgTAXrJ5WvIK2iafQ1POZTWg91IH4J1sKKiB4mwwtaU6 HUUTNNu+MH9DCWQlVfLkRvQUfxTgIW2Q/p8zNe4HvwRqoB/uhJZWnIyxUNa0OwvsD535YxpjZEo /8PBu9F5oYEdh5V0NuEJCbPwtfQDDki4oRw== X-Received: by 2002:a17:903:32c3:b0:2cc:777f:d67c with SMTP id d9443c01a7336-2d6dcc248c5mr112795605ad.13.1787661726130; Tue, 25 Aug 2026 05:42:06 -0700 (PDT) X-Received: by 2002:a17:903:32c3:b0:2cc:777f:d67c with SMTP id d9443c01a7336-2d6dcc248c5mr112791275ad.13.1787661724159; Tue, 25 Aug 2026 05:42:04 -0700 (PDT) From: Ani Sinha To: Ani Sinha , Gerd Hoffman Cc: qemu-devel@nongnu.org Subject: [PATCH] hw/misc/vmlaunchupdate: do not clear control bits upon fw-cfg select op Date: Tue, 25 Aug 2026 18:11:39 +0530 Message-ID: <20260825124139.6900-1-anisinha@redhat.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=anisinha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1787661784134158500 Content-Type: text/plain; charset="utf-8" The control bits define the behavior of the interface and clearing the bits upon reading or select operation will break that behavior. For example, aft= er CTL_HOST_IGVM is set by the guest through a write and then subsequently, if= the guest tried to read back the values from the fw-cfg interface, the read wou= ld clear CTL_HOST_IGVM. This would break restoring the host IGVM upon subseque= nt reset. Fixes: 30688c02a76e50e4 ("hw/misc/vmlaunchupdate: Introduce hypervisor fw-c= fg interface support") Signed-off-by: Ani Sinha --- hw/misc/vmlaunchupdate.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/misc/vmlaunchupdate.c b/hw/misc/vmlaunchupdate.c index afa2d278ae..847d2d963f 100644 --- a/hw/misc/vmlaunchupdate.c +++ b/hw/misc/vmlaunchupdate.c @@ -41,7 +41,6 @@ static bool vmlaunchupdate_supported(void) static void init_vm_launch_update(VMLaunchUpdateState *s) { s->launch_update.capabilities =3D VM_LAUNCHUPDATE_FORMAT_IGVM; - s->launch_update.control =3D 0; =20 if (s->disabled) { s->launch_update.control |=3D VM_LAUNCHUPDATE_CTL_DISABLE; --=20 2.42.0