From nobody Sat Sep 26 21:37:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1787551205668582.4900973207094; Sun, 23 Aug 2026 23:00:05 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wyNhN-0000fM-HA; Mon, 24 Aug 2026 01:58:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wyNgT-0008Vx-2F for qemu-devel@nongnu.org; Mon, 24 Aug 2026 01:57:30 -0400 Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wyNgK-0004Eo-57 for qemu-devel@nongnu.org; Mon, 24 Aug 2026 01:57:20 -0400 Received: by mail-pg1-x533.google.com with SMTP id 41be03b00d2f7-c966b9ee9cbso2157805a12.1 for ; Sun, 23 Aug 2026 22:57:10 -0700 (PDT) Received: from donnager-debian.. ([180.150.112.50]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8520f03b494sm1583474b3a.33.2026.08.23.22.57.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Aug 2026 22:57:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787551029; x=1788155829; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:sender:from:to:cc :subject:date:message-id:reply-to:content-type; bh=SAnDMWJL1YbwFQMDLM1WCNCMfPxewQfgUk+BYKKeXhQ=; b=sOeG/Hmlz0CBBFAAy1xbmmfSivvkYNkJeKN5+i+mbwaOVfHFMtSNUF0BIMeAlKquQ1 VCDf1/gHbtZzsBUoxnMSRnkuoosl2VaSOFwuH8/lI/P6or2tMWpSy1EQdYbcCxwXM1Js hy0QUWOXFowcafYKMja++vUvAuwNcXfjGuhuI/tOqtC5X56CHZek8GwXM08QF4Jvp/HO olZde+kVeeDlqV5jIJn9FRrBaIO1yUvoxdkGhRoH2PgxTi4qU/7tzpYLx//LJFm2AtTq n35at8X/t9c+6bxtIVH1AoIqkxIaHeFg4xTCPg9hJz3zXWUIJ2/Ar5xApwFueiNq0lNn SrjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787551029; x=1788155829; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=SAnDMWJL1YbwFQMDLM1WCNCMfPxewQfgUk+BYKKeXhQ=; b=g2tiLc9g85OdJ7ywcq6MR4nHNFqB405n9bljKwKkBRsj+PEVVRCyLy7ib3DQ0hSnYl rfhFqIIbAkbWI7tjRDjgoqBwsxB8rl8UuTXc2wJeDnuuSWF8n338GE27ClbZEGgS73jn zzkSmowz7VB/v955ABWBlW9QDZuGMedb753Qd3PR498YhZPBLPqpq0np6CLHmPzrINr+ pi10gS15VX9PVuW3K0DZ2RQK4cHaZY6eQyARSSMv77jKIsvfPzd6mcJgYAu9uCDmwDNR VRZRl2+OMcdIi4mgWN1Rg5pcrC4IuZeEBspFsLCrb37Ss+D1qF5qRdDpb+pomNqF+1IR RetA== X-Forwarded-Encrypted: i=1; AHgh+Rp15U5WJ/DXCqE4dQd6nQOHyAiGvqKC2Q53P365+j3TVgRQSO3Srx2hOYGr7EBg7tTOIrkQuTdsJz8P@nongnu.org X-Gm-Message-State: AFuF++kNse9za3/EJX8ftq+cg4obHXx5eyFEA2zbSGcnOiFiZHXpnZ6N Um0lJm4GPIGKsDg+roYgwnbpF1TZfjnp03Bjo13TsOI6zdBIK51BLB3O X-Gm-Gg: AR+sD10Jat2W4GSHY/IlYs5OO91JOZ9cVcWWH22CgJdcPv8FzXl5WnAPtuUYXGLEdDP mZow2Xyz+gDCT1Jkn9xKHTws+3jDIUAsVbKoknRJZnLvGJHiQhxfgD7yWWxAIZnHPLWsNYe4rFQ lV0O+CspFNK1GAt9FlL/K1U8A1cgIIbmuCRt5xOwudhYaiwCFaCxLKWRX3YdKIAmfm73xVNFIbc c40tNv/tM/QhfiGCA9HrnX73c8YVK87f581D7dMfXgNTph0Oxyk8m0Df4Lm9AfAszrVQRTeTJRi OAyg932WsSBDKi4krBcJd14lhhUvhkU3Hs+NGvBJQmK6mhfaVXhDCEQQSi7kUhclPgGnSJyrUOz KN63pHALt8mvF/UWuEjBdX9OuAbuqBKLTViiPvMvnxiDiQz6YltxT1+1dJbi/vRdLuhxqNXkHEk DO7L6dDv1q5ULoDQaFA/rxoVyoif4BOeEiEKZGzaHTwTJNbSpDcqh6hy18PkNuCwQiirEEo85y7 mANZZPVM0iXtEykPQTAjqNHTmreUGFLDKni13VAbPDyhiv7KcX3sIgoXAxqih0qGsPJM+mR036p 9NzUuYHxoqPpbZPhoAHgGA== X-Received: by 2002:a05:6a00:8014:b0:84c:4b58:2cec with SMTP id d2e1a72fcca58-8520ba2fd59mr29263795b3a.15.1787551029064; Sun, 23 Aug 2026 22:57:09 -0700 (PDT) From: Joel Stanley To: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , Daniel Henrique Barboza Cc: Weiwei Li , Liu Zhiwei , Chao Liu , Nicholas Piggin , Anirudh Srinivasan , Michael Ellerman , Portia Stephens , Niek Linnenbank , Peter Maydell , qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 1/4] hw/riscv/boot: Make RISCVBootInfo const where possible Date: Mon, 24 Aug 2026 15:26:37 +0930 Message-ID: <20260824055642.41098-2-joel@jms.id.au> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260824055642.41098-1-joel@jms.id.au> References: <20260824055642.41098-1-joel@jms.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::533; envelope-from=joel.stan@gmail.com; helo=mail-pg1-x533.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1787551209175158500 As with riscv_load_firmware, take a const pointer in functions that reads the structure without writing. Suggested-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Joel Stanley Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Portia Stephens --- include/hw/riscv/boot.h | 6 +++--- hw/riscv/boot.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/hw/riscv/boot.h b/include/hw/riscv/boot.h index 4e7bd9a225ef..d23f45d78077 100644 --- a/include/hw/riscv/boot.h +++ b/include/hw/riscv/boot.h @@ -50,10 +50,10 @@ void riscv_boot_info_init(RISCVBootInfo *info, RISCVHar= tArrayState *harts); void riscv_boot_info_init_discontig_mem(RISCVBootInfo *info, RISCVHartArrayState *harts, hwaddr low_start, hwaddr low_size); -vaddr riscv_calc_kernel_start_addr(RISCVBootInfo *info, +vaddr riscv_calc_kernel_start_addr(const RISCVBootInfo *info, hwaddr firmware_end_addr); hwaddr riscv_find_and_load_firmware(MachineState *machine, - RISCVBootInfo *info, + const RISCVBootInfo *info, const char *default_machine_firmware, hwaddr *firmware_load_addr, symbol_fn_t sym_cb); @@ -71,7 +71,7 @@ void riscv_load_kernel(MachineState *machine, bool load_initrd, symbol_fn_t sym_cb); uint64_t riscv_compute_fdt_addr(hwaddr dram_base, hwaddr dram_size, - MachineState *ms, RISCVBootInfo *info); + MachineState *ms, const RISCVBootInfo *inf= o); void riscv_load_fdt(hwaddr fdt_addr, void *fdt); void riscv_setup_rom_reset_vec(MachineState *machine, RISCVHartArrayState = *harts, hwaddr saddr, diff --git a/hw/riscv/boot.c b/hw/riscv/boot.c index 5e2dfa091a13..4ac0b8ef6581 100644 --- a/hw/riscv/boot.c +++ b/hw/riscv/boot.c @@ -91,7 +91,7 @@ void riscv_boot_info_init_discontig_mem(RISCVBootInfo *in= fo, info->ram_low_size =3D low_size; } =20 -vaddr riscv_calc_kernel_start_addr(RISCVBootInfo *info, +vaddr riscv_calc_kernel_start_addr(const RISCVBootInfo *info, hwaddr firmware_end_addr) { if (info->is_32bit) { return QEMU_ALIGN_UP(firmware_end_addr, 4 * MiB); @@ -151,7 +151,7 @@ char *riscv_find_firmware(const char *firmware_filename, } =20 hwaddr riscv_find_and_load_firmware(MachineState *machine, - RISCVBootInfo *info, + const RISCVBootInfo *info, const char *default_machine_firmware, hwaddr *firmware_load_addr, symbol_fn_t sym_cb) @@ -348,7 +348,7 @@ out: * The FDT is fdt_packed() during the calculation. */ uint64_t riscv_compute_fdt_addr(hwaddr dram_base, hwaddr dram_size, - MachineState *ms, RISCVBootInfo *info) + MachineState *ms, const RISCVBootInfo *inf= o) { int ret =3D fdt_pack(ms->fdt); hwaddr dram_end, temp; --=20 2.47.3 From nobody Sat Sep 26 21:37:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1787551152543778.9051303905953; Sun, 23 Aug 2026 22:59:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wyNgu-0000IV-08; Mon, 24 Aug 2026 01:57:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wyNgT-0008W0-K1 for qemu-devel@nongnu.org; Mon, 24 Aug 2026 01:57:30 -0400 Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wyNgN-0004FX-2Z for qemu-devel@nongnu.org; Mon, 24 Aug 2026 01:57:24 -0400 Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-8487214ad2bso4104827b3a.1 for ; Sun, 23 Aug 2026 22:57:15 -0700 (PDT) Received: from donnager-debian.. ([180.150.112.50]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8520f03b494sm1583474b3a.33.2026.08.23.22.57.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Aug 2026 22:57:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787551035; x=1788155835; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:sender:from:to:cc :subject:date:message-id:reply-to:content-type; bh=5w0zTlYONzeGW1r7MUxxRRSGYvKItq3LTMlmC3GgUzc=; b=Q9jPr5EOuwGgJibDBM5PDQoIdz8V2XWd443tlg9jROeAyfpP2ZY3unu7+N29dyJ17Q ntqdV/DGql5zr3lx/cp/WXCXr9GZPCDAwVbGeI01b98A7BP22JtjD83Hqphtv1GeclS2 wVjM9pkNX3u3vrL/TlGPwokholV7NtyFzQl3w3lilG48xTqX7O3ViBVjkCRH+RcJBfPV yjNDLJfNb2Qw02Fq6axGyWtnyIWCTmNQG7slz+HH0g9pz/B88/2rpkVkLqNhHLyMjdHI MXTrd9ZBB2u7TrGXfvFi3nQ/IfJ24pxSCu1tfV0x4tEVSn4tMvy6P+iPBMaqDPchOiQs iNKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787551035; x=1788155835; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5w0zTlYONzeGW1r7MUxxRRSGYvKItq3LTMlmC3GgUzc=; b=cL0CXMsEDhetJmFQ1xLDCLp2kPFbcyL1QEhFkH+vTMmclwMcq7dI7QiF58vNPmdQjt KvcIsOftXp0fzqmodxRPDlgynk++pyi6wo7kZ0zjPYd7IwHcITLMcjuRiicK/C/QRf4B O5es+YORk/MJz/3N+ZKmwem6i3f/gOFfY5Sf1sae7aki2nC1PZlIuI8e96BD7G+2MF09 etYRhQsHg8jxaVruadpeBSVDcNiPs/RWM2xJh9dZRCxzbyhO0skoH3uNoXHcDtl4QX9u /vVti/SlO+Z8ar2RPAc9gzyn5RrAXUltZZcbAJDfSx8fSM+O0aj5EeIEnFCLAaBHeXoZ NsYQ== X-Forwarded-Encrypted: i=1; AHgh+RpV6ytVjXBYnqj1HY/gtM/iLqY4yKLj5XlVP/Tj1hd13wtS+ZnxkijWtkz/6awR7908OIXQTQOi0DOu@nongnu.org X-Gm-Message-State: AFuF++n4uq4zMSr16XFEZgdb8ACbW2G6xtH9HVu8Ng0QwjfuJ1YbDh9k 9bscgA2J1d/wXGXZj4hyQpQ+47Er0qnH8+sGpihZliSF2LEtU3VQ12AK X-Gm-Gg: AR+sD12P4tBdOtKXhIKyfgQo+B2Cz/g9Zp1H0smo8v9SdZALWOD4kjWkf0fFh4wnIef 7VC4XRdMuBfgpLw9Z/fDOVhaBqje6mMho9qbNUhRUVlQZXE4fDirzrDUEYcVCQO6hPjuoRvp6BT RxMhKDh0bGaTHVRm4k4VwZkzeyN+fPARFli9grRmQCHn46dQmJWsyhM8ukYtkCtDArLak4Wyxql +8WEoWUs0M8r1mzSDCbv+BttUCcvV1dGX+RFyv09E40WzrrFDsTK13xRMX9vvmcwqDLFBCPZhhH oDQ+f4zR3OE7QFLByHylhOcGRDuK3hhdoxi10+E7mm4j4wg71VJtOlCOYFfYPeimMWf3ZEzXwTy 9YmhTbdpLlxo+8mdIBXOfmjeinmdso2kkiUGg+ZRm+4Ztxtw8/0HC2s9HWYcxU/VWo3eV6vS1Bj 4v3W57utQUsh4yN9B2JLGu+mA/TJYHmQJ6DnShZfFvpC200zkrQLemDGaON5ZYX2NpwnmA4COsq 4NJZV8U+FUxrs1GkYI8l36fJdAiObT2S8Etpx1VbCy6ACr0AQ2C+NcraF2WY82xptdfrDh8mj8d ERv3r8wIrz1mL8yVs2+MqQ== X-Received: by 2002:a05:6a00:7497:b0:851:fb36:a702 with SMTP id d2e1a72fcca58-851fb36a9f2mr34795777b3a.9.1787551034897; Sun, 23 Aug 2026 22:57:14 -0700 (PDT) From: Joel Stanley To: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , Daniel Henrique Barboza Cc: Weiwei Li , Liu Zhiwei , Chao Liu , Nicholas Piggin , Anirudh Srinivasan , Michael Ellerman , Portia Stephens , Niek Linnenbank , Peter Maydell , qemu-riscv@nongnu.org, qemu-devel@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 2/4] hw/riscv/virt: Use hwaddr for IMSIC device tree address Date: Mon, 24 Aug 2026 15:26:38 +0930 Message-ID: <20260824055642.41098-3-joel@jms.id.au> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260824055642.41098-1-joel@jms.id.au> References: <20260824055642.41098-1-joel@jms.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::430; envelope-from=joel.stan@gmail.com; helo=mail-pf1-x430.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1787551155320158500 create_fdt_one_imsic() hard codes the top 32 bits to zero. Instead take a hwaddr and populate both the high and low cell. Suggested-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Joel Stanley Reviewed-by: Alistair Francis Reviewed-by: Portia Stephens --- hw/riscv/virt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index d58656f70d1b..b91d5066d8ad 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -383,7 +383,8 @@ static void create_fdt_one_imsic(RISCVVirtState *s, hwa= ddr base_addr, g_autofree char *imsic_name =3D NULL; MachineState *ms =3D MACHINE(s); int socket_count =3D riscv_socket_count(ms); - uint32_t imsic_max_hart_per_socket, imsic_addr, imsic_size; + uint32_t imsic_max_hart_per_socket, imsic_size; + hwaddr imsic_addr; g_autofree uint32_t *imsic_cells =3D NULL; g_autofree uint32_t *imsic_regs =3D NULL; static const char * const imsic_compat[2] =3D { @@ -403,7 +404,7 @@ static void create_fdt_one_imsic(RISCVVirtState *s, hwa= ddr base_addr, imsic_addr =3D base_addr + socket * VIRT_IMSIC_GROUP_MAX_SIZE; imsic_size =3D IMSIC_HART_SIZE(imsic_guest_bits) * s->soc[socket].num_harts; - imsic_regs[socket * 4 + 0] =3D 0; + imsic_regs[socket * 4 + 0] =3D cpu_to_be32(imsic_addr >> 32); imsic_regs[socket * 4 + 1] =3D cpu_to_be32(imsic_addr); imsic_regs[socket * 4 + 2] =3D 0; imsic_regs[socket * 4 + 3] =3D cpu_to_be32(imsic_size); --=20 2.47.3 From nobody Sat Sep 26 21:37:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1787551123624386.98732908764566; Sun, 23 Aug 2026 22:58:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wyNhD-0000Rn-16; Mon, 24 Aug 2026 01:58:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wyNgW-0008WM-1e for qemu-devel@nongnu.org; Mon, 24 Aug 2026 01:57:32 -0400 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wyNgR-0004GY-Hp for qemu-devel@nongnu.org; Mon, 24 Aug 2026 01:57:26 -0400 Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-84e0688b859so489257b3a.0 for ; Sun, 23 Aug 2026 22:57:21 -0700 (PDT) Received: from donnager-debian.. ([180.150.112.50]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8520f03b494sm1583474b3a.33.2026.08.23.22.57.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Aug 2026 22:57:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787551040; x=1788155840; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:sender:from:to:cc :subject:date:message-id:reply-to:content-type; bh=0trJunRyXAgIv25VNMRcfKRxyzdPShngFatEy4Vfc4c=; b=iD5Nx+ZxOescJHnz63y9To8zBmR6tw+frduSqRyaj1mrpISOeUp0HBTjEcrHSRPfH8 CulY+/gK5arTwLfenJ9Y9WB8aR1NNAX3K5yUKivPjHzkfx7SNwfZmhoCBuiIKSo8QcEz k2qNiB/Zr0NdRXECfwGMIUPgr21FXY+8sBtyF719zOEjOhChJysOCGVZL/64N1YSKWfo ILRn2wA5c/tnMmhwhjTDrz3z8mdXANwyQxW7e0B9sRzPkcLosnaN9mUX5hpFSIxARgSt qkQacv1XdSMfgoQcEtp7gokCN7aVereq3TQoEE6/3c4yP1otHKgdVmkQqPNCluzhDEkx BAtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787551040; x=1788155840; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=0trJunRyXAgIv25VNMRcfKRxyzdPShngFatEy4Vfc4c=; b=a9DqvStEBKX158Og3akovnr0QVgAAFidbZ2w80CLr3adLQmmaC2gTUPxber7L5YWhL D/03pF1+1IGIo4RQ/MqoMNQz5vBtOHI/+wraaZxFxQyycvk9pEJ8SdFpmZbu7/+Grubh jTh4z9T/SLCzqcD/VmoP+ReDW3p86nNC2Ujab2QTraD/vGiECduCblLqk1fGQfI1v7iy ZX/oxZroRBMhqMqwBWRigaBmUGkoGr9cKS9A2g/j8OJRjGmnf76/3I4WW5ExDvKTmKn1 ZLuX5KJSLovVNxG3sXUXni+EcdejNCEAqjB3n1ox1Gwuaqtm9QU1qnxboe4x0ijCaKZF DHyg== X-Forwarded-Encrypted: i=1; AHgh+RrKn/H4pwRZh+lMbwB4x8og/Dkg8PqIFo98Po8/zmkOxQ2eRRQ7wxheI2agSlhnwMRHageqv08ljWLC@nongnu.org X-Gm-Message-State: AFuF++nblBnCC1QzBA9p7+j8H4Y31UxvC0sLrxbc0US173DsnpBbQbkV YS035w09BTr4EycBtMkwIl1Ciu+Hc0GIvQrPDcMMEURWaX7ZgAR0x9PT X-Gm-Gg: AR+sD12GalrA3j3SZf+FChCtcvepZ5DQqfppJ1ys4kESx2BNQyh2TDeavodOCzjZI04 4DlEoQFNFAgjncynKs5HHvxmBbjM36sEfb8kx3StcsTjrBhPwJgi7BZewW1aCXj+RoydikvDH38 xdom+IBEfSfsX6lTpA+BIoUdnxxalPOMLz8z5n9Wv3NMELu6libM/HylHCz3GZ0s8JaQ106YuFg sH/FFTepz64nA4GxIMsA2ALqmwmmaDcG4NHRg344an5PJNEtGXhZPG0kwVkZ473UAnADLeBkS+o 7YtC/NqyQCCTDyKDZqOxlP02XCSL1iQqPciJIMEJuP85u5YvFMA1QnIrbiTixqzEQdbGZAEfOAt ryW9LjimJfL0i7MtK440SBGPbGWnfFaE176TAzSWkMB+v34Bnn/iz10dwFNQzcY7L/xhqbgEQ9y /q2I+WA+g19+9LLqnkq474R5Z3t2cqZmDDtbYW6AcuZ34Og0cAm4Bdq/ZvQ8SEd50aY7znxgJgs AvLIENRl6L0CFUBBkZoWy++vmDsJvJ522dALYlfj7eu4bBrFgITUpP1EExI0UWv9xLOKzzb15wS ao6qOyZPfP/mUosOa/SuPw== X-Received: by 2002:a05:6a00:4098:b0:847:8449:2bb6 with SMTP id d2e1a72fcca58-8520b9460c1mr25940893b3a.4.1787551040279; Sun, 23 Aug 2026 22:57:20 -0700 (PDT) From: Joel Stanley To: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , Daniel Henrique Barboza Cc: Weiwei Li , Liu Zhiwei , Chao Liu , Nicholas Piggin , Anirudh Srinivasan , Michael Ellerman , Portia Stephens , Niek Linnenbank , Peter Maydell , qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 3/4] tests/functional: Avoid unnecessary removal of scratch files Date: Mon, 24 Aug 2026 15:26:39 +0930 Message-ID: <20260824055642.41098-4-joel@jms.id.au> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260824055642.41098-1-joel@jms.id.au> References: <20260824055642.41098-1-joel@jms.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42e; envelope-from=joel.stan@gmail.com; helo=mail-pf1-x42e.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1787551128933158500 Files written by uncompress() and archive_extract() are placed in a temporary directory that is cleaned up when the test exits, making os.remove() redundant. Drop it and the unused os import. Suggested-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Joel Stanley Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tests/functional/arm/test_bpim2u.py | 11 ----------- tests/functional/arm/test_orangepi.py | 9 --------- tests/functional/riscv64/test_sifive_u.py | 4 ---- 3 files changed, 24 deletions(-) diff --git a/tests/functional/arm/test_bpim2u.py b/tests/functional/arm/tes= t_bpim2u.py index 8bed64b702fe..9192a2fbec45 100755 --- a/tests/functional/arm/test_bpim2u.py +++ b/tests/functional/arm/test_bpim2u.py @@ -5,8 +5,6 @@ # # SPDX-License-Identifier: GPL-2.0-or-later =20 -import os - from qemu_test import LinuxKernelTest, exec_command_and_wait_for_pattern from qemu_test import Asset, interrupt_interactive_console_until_pattern from qemu_test import skipBigDataTest @@ -54,8 +52,6 @@ def test_arm_bpim2u(self): self.vm.launch() console_pattern =3D 'Kernel command line: %s' % kernel_command_line self.wait_for_console_pattern(console_pattern) - os.remove(kernel_path) - os.remove(dtb_path) =20 def test_arm_bpim2u_initrd(self): self.set_machine('bpim2u') @@ -86,9 +82,6 @@ def test_arm_bpim2u_initrd(self): 'reboot: Restarting system= ') # Wait for VM to shut down gracefully self.vm.wait() - os.remove(kernel_path) - os.remove(dtb_path) - os.remove(initrd_path) =20 def test_arm_bpim2u_gmac(self): self.set_machine('bpim2u') @@ -133,9 +126,6 @@ def test_arm_bpim2u_gmac(self): 'reboot: Restarting system= ') # Wait for VM to shut down gracefully self.vm.wait() - os.remove(kernel_path) - os.remove(dtb_path) - os.remove(rootfs_path) =20 @skipBigDataTest() def test_arm_bpim2u_openwrt_22_03_3(self): @@ -174,7 +164,6 @@ def test_arm_bpim2u_openwrt_22_03_3(self): 'Allwinner sun8i Family') exec_command_and_wait_for_pattern(self, 'cat /proc/iomem', 'system-control@1c00000') - os.remove(image_path) =20 if __name__ =3D=3D '__main__': LinuxKernelTest.main() diff --git a/tests/functional/arm/test_orangepi.py b/tests/functional/arm/t= est_orangepi.py index f9bfa8c78d99..09780236553f 100755 --- a/tests/functional/arm/test_orangepi.py +++ b/tests/functional/arm/test_orangepi.py @@ -5,7 +5,6 @@ # # SPDX-License-Identifier: GPL-2.0-or-later =20 -import os import shutil =20 from qemu_test import LinuxKernelTest, exec_command_and_wait_for_pattern @@ -65,8 +64,6 @@ def test_arm_orangepi(self): self.vm.launch() console_pattern =3D 'Kernel command line: %s' % kernel_command_line self.wait_for_console_pattern(console_pattern) - os.remove(kernel_path) - os.remove(dtb_path) =20 def test_arm_orangepi_initrd(self): self.set_machine('orangepi-pc') @@ -97,9 +94,6 @@ def test_arm_orangepi_initrd(self): 'reboot: Restarting system= ') # Wait for VM to shut down gracefully self.vm.wait() - os.remove(kernel_path) - os.remove(dtb_path) - os.remove(initrd_path) =20 def test_arm_orangepi_sd(self): self.set_machine('orangepi-pc') @@ -140,9 +134,6 @@ def test_arm_orangepi_sd(self): 'reboot: Restarting system= ') # Wait for VM to shut down gracefully self.vm.wait() - os.remove(kernel_path) - os.remove(dtb_path) - os.remove(rootfs_path) =20 @skipBigDataTest() def test_arm_orangepi_armbian(self): diff --git a/tests/functional/riscv64/test_sifive_u.py b/tests/functional/r= iscv64/test_sifive_u.py index 54a0f9c64845..6bf5be15f93a 100755 --- a/tests/functional/riscv64/test_sifive_u.py +++ b/tests/functional/riscv64/test_sifive_u.py @@ -10,8 +10,6 @@ # # SPDX-License-Identifier: GPL-2.0-or-later =20 -import os - from qemu_test import Asset, LinuxKernelTest =20 =20 @@ -49,8 +47,6 @@ def do_test_riscv64_sifive_u_mmc_spi(self, connect_card): self.vm.launch() self.wait_for_console_pattern(pattern) =20 - os.remove(rootfs_path) - def test_riscv64_sifive_u_nommc_spi(self): self.do_test_riscv64_sifive_u_mmc_spi(False) =20 --=20 2.47.3 From nobody Sat Sep 26 21:37:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1787551193938836.8632804630512; Sun, 23 Aug 2026 22:59:53 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wyNh0-0000JM-Vt; Mon, 24 Aug 2026 01:57:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wyNgX-0008WQ-Kp for qemu-devel@nongnu.org; Mon, 24 Aug 2026 01:57:32 -0400 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wyNgV-0004HZ-9i for qemu-devel@nongnu.org; Mon, 24 Aug 2026 01:57:28 -0400 Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-84e507b079dso1794502b3a.0 for ; Sun, 23 Aug 2026 22:57:26 -0700 (PDT) Received: from donnager-debian.. ([180.150.112.50]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8520f03b494sm1583474b3a.33.2026.08.23.22.57.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Aug 2026 22:57:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787551046; x=1788155846; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:sender:from:to:cc :subject:date:message-id:reply-to:content-type; bh=xOKtZQG0hnTTR9GYt3EONXbWo75FyZ9WOPDuoAjiEYU=; b=lUIqycGs/vL2DIKJdH5FGo0KYOM8JRJNJGCIYA2Vsectedvz9az727j4uOWVcZJW0+ uo/7XJMEdktyCaLyno08MxC+nZ4KeTqXncIkn2/kgK20jSONDZxbr0zlr82+UkeXMup6 JbalU3Rhcpf0rQ+3+BYhoOC0mWlbOr0aThSVkJbkjBpeIPI4V4KuvAEvbLlr8ht7EssO Y3Zc5Yxo6m/ngjhe9Shx0HOxt9WEH/QoB8xKc0IudaLG4cs+yn0Wx7FDYpGQ9tk57v9Q VAGS2ita89/X8hNZtZQvI0I3tcKAGVgnrQnwONlRKeEM4BlfdKDumk8srjOLOVpz1uDM v8VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787551046; x=1788155846; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=xOKtZQG0hnTTR9GYt3EONXbWo75FyZ9WOPDuoAjiEYU=; b=fgxPpTVRBPgQLqa7ge4ebTiwSBOfGSbvVnQWFK9yHvfBdDG6BvxCAAope8pAQJFYJB N1R0uBPylczB3/7ObCiTZGPyOO3wKmeIiJSgf2PdfVrV/3GXyTTLsM4limS5I2ejmiS3 4QpkGR7B+ita1w8ckKaM5b2AT0AYeL+Amjr9NOUPOnpqfYiggQBkd/WZykddVEQPCVHA OaDDAnJYFDNHKr7jfcYk9Tj5NxeebSL+GXKRg0w/Kf/MJVTZfBPAkqckLSbG+Bmiuo+U sg+yRkd6XWUTFO8gGkIje/J27el+oNoVo4uKF05wUtPNeMVo4FwGwnI/QQqqCmrl0gz8 fccQ== X-Forwarded-Encrypted: i=1; AHgh+RpO3K3E8IKEJUw0C5zdVpj8vwvfVC8wOIiCkCwBG5PVm+WLuvWQyisS/sFrZ0fLybpSAPr+ghgL20Ko@nongnu.org X-Gm-Message-State: AFuF++lWlhTtMkvYy4YY9B/8GOKrECoRiaREeAg0h+8WIWlpThhGnhAY ZpfN2CpUh7UtQ1vX/w9NPbHa5Z5mdr+tzk5Pd5bNWKExvKzq287bN/eI X-Gm-Gg: AR+sD10VnhA3G6PaIuTNDcMn9G3YILnX8KyT+N3cFV5V2nYpjMCk7TQYgQR1qycXnva DY/1fbwrpHUEdIexAevF5eusTDoLtOmPIAwz/k0vsOASl+l7b/X589VjNw9+IDZjMWrT24k9wHq TrJMTdP9elo3ySGyW7W/Vqu+S2s1DWzNYRrFLo6Dj4EUcKvuYPfatJQPuxUujEF0J+t03rTzjPH UhmWPYzDzgpdUTnnnIYOyi/rl7fV15aaoVIhp/2cIP8v3ZgKi0F1JEKOrgDTANYtMtpamboOO8U kqD4+XimOd98MIyXQ4Rr3oOQc05jKjEvTZGhjQgwqmQWoUT2xr0T+uszAf10uXdqU9Qm0PCfkp8 bSc3ufqIgghW1SJL16krRG5Ax6Ovh/50s18IjuleKN8l94vz+uddHxqYi75O0048E/iiKdI+ep7 etEeTM6+6nXTnMUOdQo16c9NXiDQKmrYcKhwOHB8fGZejZZXNq0fNnNJJDYGNa51M7d9POFswyc inib9cVbi6C1uIyZC8MdZIOlAxGwBDlJXW31n39bUC2tJFumKsFEEb7Gqsfy2QDdeQyNsfazB+1 hjKsJ0SJGWHCgbgcqjjRrA== X-Received: by 2002:a05:6a00:6ca2:b0:845:e7ee:eae7 with SMTP id d2e1a72fcca58-851f9a2f1edmr43185672b3a.5.1787551045688; Sun, 23 Aug 2026 22:57:25 -0700 (PDT) From: Joel Stanley To: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , Daniel Henrique Barboza Cc: Weiwei Li , Liu Zhiwei , Chao Liu , Nicholas Piggin , Anirudh Srinivasan , Michael Ellerman , Portia Stephens , Niek Linnenbank , Peter Maydell , qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH 4/4] hw/riscv/atlantis: Document QEMU-only I2C device tree nodes Date: Mon, 24 Aug 2026 15:26:40 +0930 Message-ID: <20260824055642.41098-5-joel@jms.id.au> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260824055642.41098-1-joel@jms.id.au> References: <20260824055642.41098-1-joel@jms.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42f; envelope-from=joel.stan@gmail.com; helo=mail-pf1-x42f.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1787551197042158500 The QEMU only I2C devices have a comment next to them, do the same for the corresponding device tree entries. Suggested-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Joel Stanley Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/riscv/tt_atlantis.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/riscv/tt_atlantis.c b/hw/riscv/tt_atlantis.c index d808bcc11c34..82f087c836da 100644 --- a/hw/riscv/tt_atlantis.c +++ b/hw/riscv/tt_atlantis.c @@ -356,6 +356,7 @@ static void finalize_fdt(TTAtlantisState *s) aplic_s_phandle, periph_clk_phandle); } =20 + /* I2C peripherals: qemu specific */ create_fdt_i2c_device(s, 0, "dallas,ds1338", 0x6f); create_fdt_i2c_device(s, 4, "ti,tmp105", 0x48); } --=20 2.47.3