From nobody Sat Sep 26 23:03:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1787149980; cv=none; d=zohomail.com; s=zohoarc; b=Nz7qZ5djKTkJwqcDCXXqwVP/7D6f7k18fd1dc1WtMe3gEeMcBM73KiwB1JUecOFLglUuwUk1OnGssvbh8i1+AIN9rvHj+0kw4+/EmHw6Rp/iyWYp4LclKQed99ZhA7URl6eWmUZIq8LX9VhpYH2pLhGXoSXUinqJ17hmAeAVnGk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787149980; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=FF5kL1FyiD1AooB8mhW4SKAh54+sIPWAsaZd53Ev258=; b=OlGJ9IbV4s4vVJPWUM/BOX9FJNbztMGTvzHBKwesudDagtXIvmKuSR4iEtF5f/ZYM8tnPrerstjjg+vVpSyQUd3ass1UkMihk0/0UgxvceQ2Ac3LRXszjxzr03yUOu7UaqH9GRkcVIfIFQc+7WBOFITqQjp22Erd717n2X85Cs0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178714998039239.90937135036427; Wed, 19 Aug 2026 07:33:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wwhKv-0003hy-AA; Wed, 19 Aug 2026 10:32:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wwhKq-0003gY-FP for qemu-devel@nongnu.org; Wed, 19 Aug 2026 10:32:08 -0400 Received: from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wwhKo-0003HF-Rr for qemu-devel@nongnu.org; Wed, 19 Aug 2026 10:32:08 -0400 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E034784B59; Wed, 19 Aug 2026 14:31:56 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C1474362E; Wed, 19 Aug 2026 14:31:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 6OQ7JFu+hWqxCwAAD6G6ig (envelope-from ); Wed, 19 Aug 2026 14:31:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1787149921; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FF5kL1FyiD1AooB8mhW4SKAh54+sIPWAsaZd53Ev258=; b=Zu4BWku3jYbqVefuF3pU1+RJF6+KzRlqrKxKaAfjbk30WmwNXzs379SwlzhU1G/vpD8tFj RJSxRkYV8Y6IIMCRaCn2ZcMZ863GJxTv9AMsVWpeH/Usa2ViNn3Me+tQ6r+eeD18fb8NMA uwhq3Z6665LSZt/SBoaqd64EfXDzdeY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1787149921; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FF5kL1FyiD1AooB8mhW4SKAh54+sIPWAsaZd53Ev258=; b=gSBejkA2see8RBjUzS3830oY/KG9L7PfnEoDhb1wfoFinxYATzo1frw5RZSuE+LCRwiY+2 U87CaNh9lT3jGaBQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=PwARcqDz; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=nJ8oI1cJ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1787149916; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FF5kL1FyiD1AooB8mhW4SKAh54+sIPWAsaZd53Ev258=; b=PwARcqDzhTtdsRhJ7zlJlZ7tYkgky3/OeaJBbv7RLiY4UsqzuPY6VYod8p3xC1U2sVoogs eTEFkNiSYMxFF7vJSef3EfvEAJC7N4wvwKKSivAC9HuBf5tsJA1PbQsjyy1jMxDF8ii3Qs WDVSlHX6oe9E4qRlqN+01KZF0LW/Lug= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1787149916; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FF5kL1FyiD1AooB8mhW4SKAh54+sIPWAsaZd53Ev258=; b=nJ8oI1cJYrrbguS45LEkdR1slQKGMxG1tUKQLL5z16WaSKDckPC+4eXmCY7SABUIsy38yb M8Doz2sLuvD7WxAQ== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Amit Machhiwal , Anushree Mathur , Aditya Gupta Subject: [PULL 1/4] tests/qtest/libqtest: Use GLib functions for proper const correctness Date: Wed, 19 Aug 2026 11:31:49 -0300 Message-ID: <20260819143152.1541266-2-farosas@suse.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260819143152.1541266-1-farosas@suse.de> References: <20260819143152.1541266-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.01 X-Rspamd-Action: no action X-Rspamd-Queue-Id: E034784B59 X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; RCVD_TLS_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:mid,suse.de:email,suse.de:dkim]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:1; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) (identity @suse.de) X-ZM-MESSAGEID: 1787149981865158500 Content-Type: text/plain; charset="utf-8" From: Amit Machhiwal While commit e68da5b7a2cd ("tests/qtest: fix discarded const qualifier warning") addressed the immediate strstr() warning by making 'found' const, there's still a room for improvement: getenv() returns char *, but environment strings are semantically read-only and should be treated as con= st throughout their lifetime. Replace getenv() with g_getenv() and strstr() with g_strstr_len() to maintain const correctness from source to use. This approach: - Uses g_getenv() which returns const gchar *, matching the read-only semantics of environment variables - Employs g_strstr_len() for consistent use of GLib string functions, aligning with QEMU conventions - Eliminates all const-correctness warnings with strict compilers Tested-by: Anushree Mathur Reviewed-by: Aditya Gupta Signed-off-by: Amit Machhiwal Signed-off-by: Fabiano Rosas Reviewed-by: Richard Henderson --- tests/qtest/libqtest.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c index c33c799c92d..bec37c71b8c 100644 --- a/tests/qtest/libqtest.c +++ b/tests/qtest/libqtest.c @@ -2151,8 +2151,7 @@ bool mkimg(const char *file, const char *fmt, unsigne= d size_mb) =20 bool qtest_verbose(const char *domain) { - const char *log =3D getenv("QTEST_LOG"); - const char *found; + const gchar *found, *log =3D g_getenv("QTEST_LOG"); =20 assert(domain); =20 @@ -2178,11 +2177,11 @@ bool qtest_verbose(const char *domain) * QTEST_LOG=3D,- (only false for domain2) * allows other separators, except - and + */ - found =3D strstr(log, domain); + found =3D g_strstr_len(log, -1, domain); =20 if (found) { /* reject options given twice */ - assert(!strstr(found + strlen(domain), domain)); + assert(!g_strstr_len(found + strlen(domain), -1, domain)); =20 if (found > log) { ptrdiff_t i =3D found - log - 1; @@ -2196,7 +2195,7 @@ bool qtest_verbose(const char *domain) * If filtering out a specific domain, all others are * enabled. */ - return !!strstr(log, "-"); + return !!g_strstr_len(log, -1, "-"); } } =20 --=20 2.53.0 From nobody Sat Sep 26 23:03:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1787149977; cv=none; d=zohomail.com; s=zohoarc; b=NMv9dQF0WPNh2m3xDrfkPAS8/2x0WW4PopL4AoYI+jegtC+6BPxUiXACXKfhf9EJY90dELNXj+j8Jy53uREjjxI+F5gDciAboXIJaIcfooY+sGBnyYfS9ReX0NZ2Uq3o9w/Jlnlp4c7/HOam1RdtUhESHbwr+h9UJHqZHuLY8fU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787149977; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/A0nU/P7Yc24bwJ8lp9JwwJwRJ3s8sFbEn1jDR2sPXQ=; b=helXYgkoFssjO43E1ecYkCWaL+GAnqvWMotszOFkHhJyFnIqSw9BiEDjDGfJNRMTkFZ+ZUur8K95w6ZiJd1chnBCrQ3xmMs8r6bHDpJR0OBBsaL0IieeM1kEgUPWBL9WGwQPZU8qbQXNDw/Wal/+2CqvLol4nhYpm+IwriVQqR8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1787149977381768.0310494099638; Wed, 19 Aug 2026 07:32:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wwhKv-0003iI-T8; Wed, 19 Aug 2026 10:32:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wwhKr-0003gk-ES for qemu-devel@nongnu.org; Wed, 19 Aug 2026 10:32:09 -0400 Received: from smtp-out1.suse.de ([195.135.223.130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wwhKp-0003IK-PW for qemu-devel@nongnu.org; Wed, 19 Aug 2026 10:32:09 -0400 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 071FF84B99; Wed, 19 Aug 2026 14:31:58 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 41976364F; Wed, 19 Aug 2026 14:31:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id cN8UBV2+hWqxCwAAD6G6ig (envelope-from ); Wed, 19 Aug 2026 14:31:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1787149922; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/A0nU/P7Yc24bwJ8lp9JwwJwRJ3s8sFbEn1jDR2sPXQ=; b=T/5dCxP0QXokfhlXcZW7bZeHZCchdnUaNdRmra57G2Q4+mPf5IyPrlG95iHqJpFH/T5vXs uTI9upj2eVXddmprcvcXGpchtT1F8w/3uKorhXKlCMhSYt5P2tW2k66q6yAtosStSpDYkw +NkYkTIMrQxIlK5S96MCwkcW24rFWbY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1787149922; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/A0nU/P7Yc24bwJ8lp9JwwJwRJ3s8sFbEn1jDR2sPXQ=; b=kQoR03ZUes0IXgdCjVeC4xmp3G2mtndqr//hqK6rzIdKJGkfnCb0dNwxPq1CERdWcS82Z7 1A8B/wEwnYop1sDw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1787149918; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/A0nU/P7Yc24bwJ8lp9JwwJwRJ3s8sFbEn1jDR2sPXQ=; b=z+q8F+qx70PgcfAcRwWCR1g5zWhdXHqC7ddRfFSfQIxt4GWFSElqjz7BKIQ8rppYnhF2zm zbF74xuYtSva+UF2FKZbYzlWoIUb106+zJiEtFLFioyRrfmRdiS8ZtGWQzy145BrkQCW/j LHhtFQFYSMoyqBzWsDbdei84K9IlaGc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1787149918; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/A0nU/P7Yc24bwJ8lp9JwwJwRJ3s8sFbEn1jDR2sPXQ=; b=VKMyCc+TsG1D1UR0reYu5azsenlk+LalY+UT3KmwRqDZLUrnnKJg9rTWF3IIjyZUhSef+C vNlBKuP5dwDCEJBA== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Rohitashv Kumar Subject: [PULL 2/4] tests/qtest/device-plug-test: skip pc tests when 'pc' machine is unavailable Date: Wed, 19 Aug 2026 11:31:50 -0300 Message-ID: <20260819143152.1541266-3-farosas@suse.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260819143152.1541266-1-farosas@suse.de> References: <20260819143152.1541266-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.80 X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:mid,imap1.dmz-prg2.suse.org:helo]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=195.135.223.130; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) (identity @suse.de) X-ZM-MESSAGEID: 1787149977808158500 Content-Type: text/plain; charset="utf-8" From: Rohitashv Kumar test_pci_unplug_request() and test_pci_unplug_json_request() use "-machine pc" on i386/x86_64. When QEMU is built without the i440fx/pc machine, these fail with "unsupported machine type 'pc'". Skip the x86 case when 'pc' is not available. Non-x86 architectures use the default machine and are unaffected, and x86 unplug coverage is still provided by the q35 variant (test_q35_pci_unplug_request), which already guards on qtest_has_machine("q35"). Signed-off-by: Rohitashv Kumar Signed-off-by: Fabiano Rosas Reviewed-by: Richard Henderson --- tests/qtest/device-plug-test.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tests/qtest/device-plug-test.c b/tests/qtest/device-plug-test.c index 2707ee59f63..650956fa114 100644 --- a/tests/qtest/device-plug-test.c +++ b/tests/qtest/device-plug-test.c @@ -65,6 +65,10 @@ static void test_pci_unplug_request(void) } =20 if (strcmp(arch, "i386") =3D=3D 0 || strcmp(arch, "x86_64") =3D=3D 0) { + if (!qtest_has_machine("pc")) { + g_test_skip("Machine 'pc' is not available"); + return; + } machine_addition =3D "-machine pc"; } =20 @@ -107,6 +111,10 @@ static void test_pci_unplug_json_request(void) } =20 if (strcmp(arch, "i386") =3D=3D 0 || strcmp(arch, "x86_64") =3D=3D 0) { + if (!qtest_has_machine("pc")) { + g_test_skip("Machine 'pc' is not available"); + return; + } machine_addition =3D "-machine pc"; } =20 --=20 2.53.0 From nobody Sat Sep 26 23:03:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1787149981; cv=none; d=zohomail.com; s=zohoarc; b=D/7kuCjwNv2ZT6mVjJAjp5pLr5s5D+WgEGAFYtFijLw7MoSziZkoJ6wOocSxkpx6qTEuWNEOcAFEVsUryI0o9EF72DtHPNPMLx0a2xbBazB1UCZlukFBct5/uiTaoTZStYqCPZNNRAX+6Fr5+79bDNf+kPwmVvwhHNO+s3kfH10= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787149980; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Ly7UAqOYXvW24/xTtAu8cZg0rCpiUgjtaQRMOzhomvs=; b=b6Ic7MqnBg01lFjGm/GX0Hz17J6Xg3+NVQ5AxNxwOrgjc5oLiopUrZaGw2fL8MDc/Ngn7k5EmxRTQItdKL1jLHZGThQQCrHlO9W+s05CRCNz+J1Nxix5CsVBbbu5vUswJOil5Y/jkjhKuaTP+4xbT1+GxckrkfovNob0P2CPe/4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1787149980992934.0227613421847; Wed, 19 Aug 2026 07:33:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wwhKv-0003iF-Pj; Wed, 19 Aug 2026 10:32:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wwhKs-0003h7-BO for qemu-devel@nongnu.org; Wed, 19 Aug 2026 10:32:12 -0400 Received: from smtp-out2.suse.de ([195.135.223.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wwhKq-0003JK-KL for qemu-devel@nongnu.org; Wed, 19 Aug 2026 10:32:09 -0400 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2CC903EA4; Wed, 19 Aug 2026 14:31:59 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5D256367A; Wed, 19 Aug 2026 14:31:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id KFLFC16+hWqxCwAAD6G6ig (envelope-from ); Wed, 19 Aug 2026 14:31:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1787149923; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ly7UAqOYXvW24/xTtAu8cZg0rCpiUgjtaQRMOzhomvs=; b=c87HiQNTxm2cHJe4yG369fCVkaazOw9Cmnrf7w5kjBYe44mH2N4r6HWYa/LDCLrdImYyY6 MXxUALUkZH45tBOUryfsOKfdQSHnUl7QoQrUVCAcmsGW0gQUBwXHqw1VXFAoJRfAhqrn1z 5Ce7hxlSIZRCnCchCxxjd0pkH552T+U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1787149923; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ly7UAqOYXvW24/xTtAu8cZg0rCpiUgjtaQRMOzhomvs=; b=B3IJIB2MLrCSLenGeuSYPxZLzcHeIFqyFVxFuT4NkzJiwZa9jxZg9TRVO5RY4+ut0pbREQ 6R/HQecdino0hqBA== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1787149919; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ly7UAqOYXvW24/xTtAu8cZg0rCpiUgjtaQRMOzhomvs=; b=HUUVG9L837hADOxaNlx7J3GWb8PrgCeYeiRmK60rR/A4Np/XnnhHEwY6lmAwYCshTrwM3K V0sINev1JuEKM24D+AWI9TVC4SLDNoJiKWsk6A/3Qn6claNL4n/+sUIWHKkMf5pcdr1Zr3 KO/EzBIQljRhJa1Sm/9vTtDjne1yTtM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1787149919; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ly7UAqOYXvW24/xTtAu8cZg0rCpiUgjtaQRMOzhomvs=; b=yRM12a3ojpBKNJpwGd48Gx9d+4p3SWmkuZ9fz6T88NUFXjXmjiPOxkfde2Bdw5QJQ+ujke ej0GXsKuT2BQyuCg== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Rohitashv Kumar Subject: [PULL 3/4] tests/qtest/drive_del-test: skip pc tests when 'pc' machine is unavailable Date: Wed, 19 Aug 2026 11:31:51 -0300 Message-ID: <20260819143152.1541266-4-farosas@suse.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260819143152.1541266-1-farosas@suse.de> References: <20260819143152.1541266-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.80 X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:mid,imap1.dmz-prg2.suse.org:helo]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=195.135.223.131; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) (identity @suse.de) X-ZM-MESSAGEID: 1787149981846158500 Content-Type: text/plain; charset="utf-8" From: Rohitashv Kumar test_cli_device_del(), test_device_add_and_del(), test_drive_add_device_add_and_del() and test_blockdev_add_device_add_and_del() use "-machine pc" on i386/x86_64. When QEMU is built without the i440fx/pc machine, these fail with "unsupported machine type 'pc'". Skip the x86 case when 'pc' is not available. Non-x86 architectures use the default machine and are unaffected, and the corresponding _q35 variants already cover x86 under qtest_has_machine("q35"). Signed-off-by: Rohitashv Kumar Signed-off-by: Fabiano Rosas Reviewed-by: Richard Henderson --- tests/qtest/drive_del-test.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/tests/qtest/drive_del-test.c b/tests/qtest/drive_del-test.c index 30d9451ddda..4c32da594a4 100644 --- a/tests/qtest/drive_del-test.c +++ b/tests/qtest/drive_del-test.c @@ -258,6 +258,10 @@ static void test_cli_device_del(void) } =20 if (strcmp(arch, "i386") =3D=3D 0 || strcmp(arch, "x86_64") =3D=3D 0) { + if (!qtest_has_machine("pc")) { + g_test_skip("Machine 'pc' is not available"); + return; + } machine_addition =3D "-machine pc"; } =20 @@ -332,6 +336,10 @@ static void test_device_add_and_del(void) } =20 if (strcmp(arch, "i386") =3D=3D 0 || strcmp(arch, "x86_64") =3D=3D 0) { + if (!qtest_has_machine("pc")) { + g_test_skip("Machine 'pc' is not available"); + return; + } machine_addition =3D "-machine pc"; } =20 @@ -403,6 +411,10 @@ static void test_drive_add_device_add_and_del(void) } =20 if (strcmp(arch, "i386") =3D=3D 0 || strcmp(arch, "x86_64") =3D=3D 0) { + if (!qtest_has_machine("pc")) { + g_test_skip("Machine 'pc' is not available"); + return; + } machine_addition =3D "-machine pc"; } =20 @@ -456,6 +468,10 @@ static void test_blockdev_add_device_add_and_del(void) } =20 if (strcmp(arch, "i386") =3D=3D 0 || strcmp(arch, "x86_64") =3D=3D 0) { + if (!qtest_has_machine("pc")) { + g_test_skip("Machine 'pc' is not available"); + return; + } machine_addition =3D "-machine pc"; } =20 --=20 2.53.0 From nobody Sat Sep 26 23:03:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1787149970; cv=none; d=zohomail.com; s=zohoarc; b=IsnLvna2EE4DhFJ4kVXElbOIeihnL//4b9H2a4oCFKleXi2rS3woN9HaoPKD8QykqyKxVFkVL8uKdgwn/PvZ6oehM0ySwd0kRZZykuKd9bZtu/+UU2Essr9+svpJRFpYgQ+KvEVsMYEeAaZHH1zYyIG93mkBX/JMnvfkoOQjtKo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787149970; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=H80qvGXCvNWhn31tHxLxkNway/KVCqWkaPtSTxj3eqk=; b=HODtOLZLVJfMnsQdOWCc0AxEtCTtnuFwZ4c3zJDoGoPdbAwyfBePrz79kEL5S8Q2XizzE9RzwC7jRT1fEec0WuRbyFRCUaczqOMfEp0hqJeSglSMP80OAXvFghEHNBz5zoZmvL1rlscyW9YiWNt8HkVu5ZghA24neMttxJ4pkVs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1787149969987526.6209303624887; Wed, 19 Aug 2026 07:32:49 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wwhKw-0003il-GV; Wed, 19 Aug 2026 10:32:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wwhKu-0003hI-9f for qemu-devel@nongnu.org; Wed, 19 Aug 2026 10:32:12 -0400 Received: from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wwhKs-0003KV-Fx for qemu-devel@nongnu.org; Wed, 19 Aug 2026 10:32:11 -0400 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 402A084BA3; Wed, 19 Aug 2026 14:32:00 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 775D6367B; Wed, 19 Aug 2026 14:31:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id gBMtEl++hWqxCwAAD6G6ig (envelope-from ); Wed, 19 Aug 2026 14:31:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1787149924; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H80qvGXCvNWhn31tHxLxkNway/KVCqWkaPtSTxj3eqk=; b=Hz4WoT2xM8GYjs2Zhs68NdDm/WGWRlaHIt/cRWUOKn30D2fThmR4qUrw2lCKq4x7S/SfPN Bj0uJYjyMLhPWRChlPqMoenMptZ0DIFovcUGDPWCAIAG21rBiz/Kyvu+V9jNz+3+NAPc1G RgXCJ+nInNWutwZZpgE8LL4GYGlBMqw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1787149924; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H80qvGXCvNWhn31tHxLxkNway/KVCqWkaPtSTxj3eqk=; b=C0XBSBiLyxKyt04SGb6WzolJbhuD3iR4GpuUkvLAEEryRdrYHf9bMCkl1RTiil4mtGmyoh Idj85EYFMOq3kQBg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1787149920; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H80qvGXCvNWhn31tHxLxkNway/KVCqWkaPtSTxj3eqk=; b=OuiDaWwqkgyqAKWNuj4LgGedR3c5wtmOR1HJD+LdznyKo5XaS6mwbD7IED55/Bh7IiWPtt nOv0daaoGWtgk9M/lV24SQHPJTZIsFy7WqHpumlHF8+soGImlQ+Nzg+A+DmtU2oa7gbGzd hNkSizQXHqoUyxYXcrOtJw47wChAYJ8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1787149920; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H80qvGXCvNWhn31tHxLxkNway/KVCqWkaPtSTxj3eqk=; b=0AGTNrWPw3HOVyWI9lGvEUh+cEmiZx05WIZcmUm205ASvs/eEA4Xng4wKJlo4HjYeXB8kJ F4HOGa856VF4ikCw== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Rohitashv Kumar Subject: [PULL 4/4] tests/qtest/pxe-test: skip per-row cases whose machine is unavailable Date: Wed, 19 Aug 2026 11:31:52 -0300 Message-ID: <20260819143152.1541266-5-farosas@suse.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260819143152.1541266-1-farosas@suse.de> References: <20260819143152.1541266-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid,suse.de:email]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-Spam-Score: -2.80 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:1; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) (identity @suse.de) X-ZM-MESSAGEID: 1787149971826158500 Content-Type: text/plain; charset="utf-8" From: Rohitashv Kumar The x86 test table mixes 'pc' and 'q35' rows. When QEMU is built without the i440fx/pc machine, the 'pc' rows fail with "unsupported machine type". Add a per-row qtest_has_machine() check in test_batch(), mirroring the existing per-row qtest_has_device() guard, so rows for an unavailable machine are skipped while the others (e.g. q35) still run. Signed-off-by: Rohitashv Kumar Signed-off-by: Fabiano Rosas Reviewed-by: Richard Henderson --- tests/qtest/pxe-test.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/qtest/pxe-test.c b/tests/qtest/pxe-test.c index a3f900fbea3..e85dec5a4e1 100644 --- a/tests/qtest/pxe-test.c +++ b/tests/qtest/pxe-test.c @@ -108,6 +108,10 @@ static void test_batch(const testdef_t *tests, bool ip= v6) const testdef_t *test =3D &tests[i]; char *testname; =20 + if (!qtest_has_machine(test->machine)) { + continue; + } + if (!qtest_has_device(test->model)) { continue; } --=20 2.53.0