From nobody Mon Sep 28 00:10:04 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1787144544; cv=none; d=zohomail.com; s=zohoarc; b=fCJDja+2vo5rwIr45ZkBjJb5iGlKH7RZMSSZfmaJ1hg9veEIf8WnRr0F+8ZbFlmllo2OydlYzchUJPMLuLJxyHnwafTZLsLUaYHolodHaz9iu6thsFSfJSM93+ekQyZ02B8xhDuv9WWKSnpWBrCBv16+e/1QNn50lq+DKPITx48= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787144544; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=zlP7EkHcWTHqkw1EMJy6AYNxGBeaLX/goTg/6PGgEEQ=; b=YOs+74kHK8C6QtuKOaKtJxLgLMrPZ6pssVMMeSbILcfeXGz03Fa68iPtGfHjBKl3UWWkBSi1iyhIc/rHrG9sO+bzviSpPmSyDWsLoAerD7uu9em4xfaDDeSzzwmM+1uMZbFCCj9YnUujr/rDnc+9xKwkmeECQluPn3rom2+an38= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1787144544147182.17060690576557; Wed, 19 Aug 2026 06:02:24 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wwfvo-0000hB-Rb; Wed, 19 Aug 2026 09:02:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wwfvl-0000gx-3O for qemu-devel@nongnu.org; Wed, 19 Aug 2026 09:02:09 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wwfvi-0001ZJ-Kj for qemu-devel@nongnu.org; Wed, 19 Aug 2026 09:02:08 -0400 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67JD0EjP693386 for ; Wed, 19 Aug 2026 13:02:05 GMT Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g4yfmb90f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 19 Aug 2026 13:02:04 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-38e22137fb3so1858849a91.0 for ; Wed, 19 Aug 2026 06:02:04 -0700 (PDT) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d5c1ee476bsm23377015ad.75.2026.08.19.06.02.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 06:02:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=zlP7EkHcWTHqkw1EMJy6AY NxGBeaLX/goTg/6PGgEEQ=; b=IMbdb/TeuDWSSYSFvMDciptMggKTbWnwY79KRh /klmc6HFLsZ8QB9REqNUDu7B2RWcaUiVhTn5FDkwoMRifRkmeH6vhdGERQdBXUNu pp1A9ZmW4qcFRGzQJhBr6kxRMwsLhTXL2fwdRW0dDXgp0tO9EPRi6NBZIVEa2ULR 1gdHo/fa7fkTPhFpR8IMJa2zVgYv5K2GTazJEKvDlIaSxRabgl31dhxg0B7BQep5 +/JHpCLvFvkESxd3brojh6ufM6TuH/3fnBFRv+YZ9uUKk33z1VNTnp0QluH8RdJb FEqa5YBaD84Jhl4U8CqYqd5Cin3LgFpNHprnO0y6bxerjyfQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787144524; x=1787749324; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zlP7EkHcWTHqkw1EMJy6AYNxGBeaLX/goTg/6PGgEEQ=; b=OomYjW98gVE761UlnA6QCezUanJOplklyqY5fgctrEhXhn4s+NG5GLYrVv3IsHYbMM 0Yo8UEeRhFX5aHEekiZDjRNkaN2ay+KWLtt+wbQUyjGx2+CulRA5xlV+GbpxTxWdkM9P l4MAr8bZgOLTCKQ3pG684VYl/jm3P5FKyx6Tf+rUe3oipykLfCHOydpAVga4/GsHAAZz +v0NhKlW8nK5zMUvVzwWC9uaY073ZyADDoCuVGSwMZGrI2FZbQx7QQdUGZ09qASfwUbk cobc7YTNUWHJbdK2Hyrzrp05lt8yEQ4P7KT8ukbBJJk+zF6qvlA4QKd19l4kxbVKBGdX EIig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787144524; x=1787749324; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=zlP7EkHcWTHqkw1EMJy6AYNxGBeaLX/goTg/6PGgEEQ=; b=ofbtk/yWpXKRqINYmyYvbxgNSD25RAEbSRHJdq7D+hVfGSCjOVtTY17ThM0HQyO/fA JltwQxLrNtRihv6S2C43Mtac+fKSVK7z0T08o/7YyUN6OtwhM0r30RteFluM9bIQtwQR k+IDpV0IwHowD10nKxco3tRwiRiGtZxoThuomHsR0LeNOap8e1qEf19S4+F2tPvg0yV3 Y2RtaecSD9pY6+yiYk3WqdG4vw97yeHSTJpbVh3IWwVBvF+/HceqTwALQKFkifzODwus M4owEZAH5AzKOCWR9abPnwYlkexUIPUZPT84l1pe/UYX758SdESt/P3EhKYqDIPGSz5E rFSw== X-Gm-Message-State: AFuF++m8uM/CyQdCsbHXiIA15QaPOx+yaJSi+ERzTIJlW7SyLAiy//Zr VIrwHwyJj3JKXK+G+EvPs4xlkMe2pA+b5RYlDo62CBGP21YgwakO8XNQvQZXJV2WiadmXP45HFf 6TrQ/sJqhQjv+XMd8jWtFGicOAUoXqRkpj1hZqMG2iosOoqfW+KNxcnz2MD7VYz7W7w== X-Gm-Gg: AR+sD13HFPZf9A1jEoCUgNuX6FpOHDudcJuT6V5t7TnrNZHv90dJxwBg7rrHoIDHqSo PACtHwTM/K4retS/8R0TVrkz1+SmRieUZ1bW9OVc5ziDqIRRu10Od3Tq7paB1Cn3BvOx86GXZSz B8fZo4y7KriZFkqXJP6cHLa+kDH47rGgigBnaSwqG+Z2AS3EHLToBdj7tIFZBPu+vHN1IsYMcvj mA2Gq0BnC6sAcxfBVNmkIMpIET5E6V3VZ30WvKV64r54VKcO9aifEBKmf12wp1f5TpUFy48A1E0 5YVlmxG4YSAAn4inf3+sfB4ckrnYKRR3ShQzMFDVrBawTzhu6P6w9VPLlfqdbT4yB8fpdxVvDRD 0HcwlBoSpMbsUmVtjKgU3yW/Kn8MKykJTuBDyi1t/vlyRk7DH X-Received: by 2002:a17:90b:3b41:b0:38e:4114:d8c7 with SMTP id 98e67ed59e1d1-3958049908amr8542379a91.0.1787144523897; Wed, 19 Aug 2026 06:02:03 -0700 (PDT) X-Received: by 2002:a17:90b:3b41:b0:38e:4114:d8c7 with SMTP id 98e67ed59e1d1-3958049908amr8542233a91.0.1787144523312; Wed, 19 Aug 2026 06:02:03 -0700 (PDT) From: Brian Cain To: qemu-devel@nongnu.org Cc: Pierrick Bouvier , Brian Cain Subject: [PATCH] hw/hexagon: decode an empty TLB size field as 4KB Date: Wed, 19 Aug 2026 06:02:01 -0700 Message-Id: <20260819130201.4067696-1-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: g2KAQ2VmvPKvZk7GdvhHQcVub0QnU0kq X-Proofpoint-Spam-Info: AW1haW4tMjYwODE5MDEwMCBTYWx0ZWRfX2QWaXIPT4RnV C7+xt8TvCMHCz2i/tI9IH5hG4rCJ51Hh+yoop02trm/TlEgi2XL2xU/c2tHEHZX90RZPu6tlgLQ nsLdU0fqFGTnoN9yNltszdY8Mvmdk2o= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE5MDEwMCBTYWx0ZWRfX6PZ+/kot6BeW AuF+xUxiXXpxsLYMo6HIAsLCSi5zbO97yyHanS9SaSXOLZIy/TEuZ2J/28FcAQ+fO/g+6rfk86Y 0PzSNy1asNHfSM+SwcmDSD7SBECDGJyJ5vfxSS2Q7rZg5f43BLHVQ6+UCKO9Xgp/1P2+zxqnmip olVtZ9/eJdNr0efsHpdhh351N22ZFycUdLHXqwayF8nG/qXBH6Fq9/woyDFvnZ2ox038L9Gg8oH Jy+WLgJpClsjpgKcqNUcUWpn4lq4idxl1BHrhU1Q3KoJel0FTTaR+RnNybdy7wRTRTMiFy1okHn IKSxXrxX8PNHWglMmu9GgZa96MDLW1kielltJUL/MFJBVzFvrPJYRcSKqPxDnyzynVKPuvh2VHs YgTJgyhyBSbaGryleOAsZFXukXr3omG/muC9m2iofWI/+6M/rPY230OF1OXMg98yU+63UpK/tQh a3KtBIVjiBUMA54gcMw== X-Authority-Analysis: v=2.4 cv=aNrAb79m c=1 sm=1 tr=0 ts=6a85a94c cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=41wnHuTSjj-I1xIrTVIA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-GUID: g2KAQ2VmvPKvZk7GdvhHQcVub0QnU0kq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-19_03,2026-08-19_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608190100 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1787144545278158501 hex_tlb_pgsize_type() decoded a TLB entry's page size by scanning for the lowest set bit across the entry with ctz. A guest TLB write with an empty PPD[9:0] size field but any other bit set caused an assertion. Signed-off-by: Brian Cain Reviewed-by: Pierrick Bouvier --- hw/hexagon/hexagon_tlb.c | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/hw/hexagon/hexagon_tlb.c b/hw/hexagon/hexagon_tlb.c index b6d4aff389e..aaa0b94fccd 100644 --- a/hw/hexagon/hexagon_tlb.c +++ b/hw/hexagon/hexagon_tlb.c @@ -69,8 +69,6 @@ static const char *pgsize_str[NUM_PGSIZE_TYPES] =3D { "1G", }; =20 -#define INVALID_MASK 0xffffffffLL - static const uint64_t encmask_2_mask[] =3D { 0x0fffLL, /* 4k, 0000 */ 0x3fffLL, /* 16k, 0001 */ @@ -82,19 +80,25 @@ static const uint64_t encmask_2_mask[] =3D { 0x3ffffffLL, /* 64m, 0111 */ 0xfffffffLL, /* 256m, 1000 */ 0x3fffffffLL, /* 1g, 1001 */ - INVALID_MASK, /* RSVD, 1010 */ }; =20 +/* + * The page size is encoded as the position of the lowest set bit of + * PPD[9:0]. Bits outside that field belong to the cacheability and + * permission fields and must not take part in the decode. An all-zero + * field denotes the smallest page, matching get_pgsize() in the reference + * simulator. + */ +#define PGSIZE_FIELD_MASK ((1 << NUM_PGSIZE_TYPES) - 1) + static inline tlb_pgsize_t hex_tlb_pgsize_type(uint64_t entry) { - if (entry =3D=3D 0) { - qemu_log_mask(CPU_LOG_MMU, "%s: Supplied TLB entry was 0!\n", - __func__); - return 0; + uint32_t field =3D GET_PTE_PPD(entry) & PGSIZE_FIELD_MASK; + + if (field =3D=3D 0) { + return PGSIZE_4K; } - tlb_pgsize_t size =3D ctz64(entry); - g_assert(size < NUM_PGSIZE_TYPES); - return size; + return ctz32(field); } =20 static inline uint64_t hex_tlb_page_size_bytes(uint64_t entry) --=20 2.34.1