From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891595; cv=none; d=zohomail.com; s=zohoarc; b=N8tyJrsVR0s6cKFHtmcFmtJgHNT/a2Oa1ok1/NFf+S+JcgREq2WwF85TI5HrY94H9XJQd3lwwbNpUrFnF3MFEGvQCPdBR2zN2zL8sj7b+EnPEYzvDPfCQTzhTk61915pparqrG3ujjRnMae+qCmb8INglXR8fEg64MqR1vUKn7U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891595; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=g4REnGqu8ycIztFn7FSAwvmzN93LAzmsn5+R5Xus7/M=; b=m2xf1wge+p1PIkNxts9Yo0fyDaXYbxvTniYzkutxt9WFdk3+azDzPuscABxK4GLCmdPGGSPRH0/+CH5xvD52ynDnw7ntpiqi2oqZMTiw1J2g7qCpi1uMCD+KUb8Q4xo5uTO0JFnTg0jN6xO5uOqenM0rQP5ip1OMZV5gNtr0GIc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891595679884.6323457491454; Sun, 16 Aug 2026 07:46:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvc7y-0000NC-9G; Sun, 16 Aug 2026 10:46:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc7n-0000BC-3k for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:46:12 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc7k-0000bP-Hy for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:46:09 -0400 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDlKgO3215381 for ; Sun, 16 Aug 2026 14:46:07 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghfbn3q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:46:07 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-936d067836eso255733785a.0 for ; Sun, 16 Aug 2026 07:46:07 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499960fef95sm62372555e9.1.2026.08.16.07.46.05 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:46:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= g4REnGqu8ycIztFn7FSAwvmzN93LAzmsn5+R5Xus7/M=; b=R7KyYi/66giORQFv BSVKts61J9D/3I2nJDoyELtIxdsrIlqkwry0L3m2gtDOeDGmn1OXox+5f8zScx+3 rb6Xub/q49Vu57diNLdIcRUfMt28EG+Uz/Hb5xmSm0vawbgz4j4rGQzqbxPasJZ4 BhrPWI9J7FJWCQ34IJv/5yGqroUvAUwZnfTWWurtf1bDyABXn/n+hUwe80RQfuUW vdLLg4aR7l+dKBjZKs4D5o9wEmHdxz6dWDjEIUX5wfpxE09zanNp3dzzSuWDh6G2 KSA8SmmAn4Uf32219IFTWehuB94L7MT9A6VpJHkH9ezYFZJSHcJXNjA1Qja2ORVG cd7cBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891567; x=1787496367; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=g4REnGqu8ycIztFn7FSAwvmzN93LAzmsn5+R5Xus7/M=; b=MlCT/ocZQ87b7bDmEcf1E5zXDjP2j6ZHGOowZTRB1vLvHNKXHislX3Jy3pFQEAv1b/ sjyTFcN07zvvHDwnRYduddbdOHs/f7ffo7gPjJNwl5US+41EMi22VOJ2zxDliY1MbhWr oVJwye9HPanrktF9ZHUUJeoeQHq8gRMbyQEMS3Suo2Ts9kKQbwqjHYDTBe0P3lj52S3d LxTFDMK/+0FSi5bYGGYAscBNqf4LQv8g1LK7+IOZmKCkJ0XiBP7uPJaWHfDVAmIqH1kX XgFSP7Xo2cJbpTAQxGF/I5FSflUit9BYEZfij3q/XMW7MoZQ1XUuHaOoRhg3PP3uq8wf +hkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891567; x=1787496367; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=g4REnGqu8ycIztFn7FSAwvmzN93LAzmsn5+R5Xus7/M=; b=YhDtmIJ9ntqEMcHPSkyk20HyerWLK8R0mZ/8uPtTTP+bfNwKMBL2ovwBi7cgj7tXqA mFaaVmouI+BEuv93SGLJqc/MG3L6hMZsPEcZZJpZvKWPtIYjfXmddmdErSd0m44rK9Bt PMg6re6gA0GQRmPm8JZB2+9k0sC3zw3qYv0MGrcKABOIui2X5Nw+bCIdWLfUnzwJvyWk usQFrSf9CFvpWWKHtQvFfp0UgMtX6eNpv2J/D4xcJyQ9oaqou+EibUhqsI6QKRPPCg67 7P0Uw9vC8S63Ja8SliH4h2+KW0vCNYnD1Ele/zd7iUuYBvMBuw1L2B16hfLqaNN/hvEB No0w== X-Gm-Message-State: AOJu0Yynz51vh0q3z21k3DByMVmjjV3zHYrFk5JMSxM6ORqg+ivg76Oc Ocwo6MXg6N8m4OXr6eHp6spY5ZwHVBw5Y5bSH7J9RjY03fZg+mXHZ081n/a7vVRP7VkAjEDgFGF ou6z/YdN9oDS3lxFgtFpPZi828ni3rO/Xd+QkbZUEy2XDCg+wtQZar7/u8Jl+3T3+Bg== X-Gm-Gg: AR+sD10sZRFlh3AUW3bYs2LW/5fAOGcaa+UKdi+PlkO4CQIM/rBwieZRiG+byeEuhoP neMd0NaaR56NZpbISax3lGWdATN2WpS/+Jvw4TkYZwgwx9Z4R5dhLmv/6OWu5t7sPtBWUW/PR0w 32MXIVI8UGJEVGlG8eSoKgEMfHmMnEnpOABnyTDL1+9EcplHERLJXG23YLMp7bnyhLiYbsVXK8Z sqgOmUJTsUBySLlV31bO+oiPkbUvIlaqVxi8fIYHEm8g6reU4nC5fBuluK1eBfs/Hg4h3oDvJdq DPynB6SfA6753+Vjp2eztXaDcIcbdUVgQPx9qn0blNbuC+ondgeh+Ngdlex97sryW2dDWF8J9q6 WDSlWhufpbsTMzn7eBKjvArKUz2J5mOXBVRJURrFoLw== X-Received: by 2002:a05:620a:8812:b0:936:d2a2:5fe with SMTP id af79cd13be357-936d2a24ffemr2037459985a.6.1786891566975; Sun, 16 Aug 2026 07:46:06 -0700 (PDT) X-Received: by 2002:a05:620a:8812:b0:936:d2a2:5fe with SMTP id af79cd13be357-936d2a24ffemr2037455685a.6.1786891566437; Sun, 16 Aug 2026 07:46:06 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 01/56] hw/qdev: Remove DEFINE_PROP_DMAADDR() and 'hw/qdev-dma.h' Date: Sun, 16 Aug 2026 16:45:00 +0200 Message-ID: <20260816144556.69009-2-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExNyBTYWx0ZWRfX/DKFBFnBSJPT BbGpWLp58EvqtEITNklLwH34OgnGEDwr96p3TD/faNaYwwYajwdIewVbt5nEAKW97zokqBwlX/h dmOjgHJbGZlTnXUjha1mPlYqRPlaw+k= X-Proofpoint-ORIG-GUID: Fd9QdIiNFeh4YOvqT4L9ZNidi92P9U-4 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExNyBTYWx0ZWRfXz0Tu7rG5Fd0C YH9XtCHe6UDDpwJevgQe1SkXaXV75UIDxMEqM2FYqgmzBZD9LFJC/+032HwqcyIeNfhhuyw1DbH GNJgXX1vKpUqqQzKbFc8z7qnpd8RMSiKMwwtdXyF6jc52e7anXpvEtmeUm8gc7VRdatTT/5xQGm SnpbTXvvXVEslh278PnKbKXfkpwt6wuQYOM5Gt5iopgCMhPK6uQSX8bqmO671eToo1Q2XJXazZ2 h9uCJiycxttgh3WSO0sf6TbW6HraS7B6vwzMWPsnSHqjE+OKSWTnkPqSsRPKT/0zgWJm2BTVooi Q7Z9Q0WBy5C0yJNutIpfGICK5nwRuKwKALbK9YuNtbGzWa7H6igtZu0l4cxod59Ru37OF5Xazmf Hr0X55Jh84T6t5wXj8b1q+l2SFXXlKgaN53HQuELfEtb/I4eFtMGuhNPUaAlnrbMmImZP3HcR97 y/W7caGWsBZjKB0HQrg== X-Proofpoint-GUID: Fd9QdIiNFeh4YOvqT4L9ZNidi92P9U-4 X-Authority-Analysis: v=2.4 cv=I/dVgtgg c=1 sm=1 tr=0 ts=6a81cd2f cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=KKAkSRfTAAAA:8 a=20KFwNOVAAAA:8 a=EUspDBNiAAAA:8 a=ofTg0gqHf28Bx6alXq0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 malwarescore=0 adultscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160117 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891597843158500 From: Philippe Mathieu-Daud=C3=A9 DEFINE_PROP_DMAADDR() is only used once. Since it doesn't add much value, simply remove it, along with the header defining it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Markus Armbruster Message-Id: <20230203145536.17585-14-philmd@linaro.org> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/core/qdev-dma.h | 16 ---------------- hw/usb/hcd-ohci-pci.c | 1 - hw/usb/hcd-ohci-sysbus.c | 3 +-- hw/usb/hcd-ohci.c | 1 - 4 files changed, 1 insertion(+), 20 deletions(-) delete mode 100644 include/hw/core/qdev-dma.h diff --git a/include/hw/core/qdev-dma.h b/include/hw/core/qdev-dma.h deleted file mode 100644 index b00391aa0c3..00000000000 --- a/include/hw/core/qdev-dma.h +++ /dev/null @@ -1,16 +0,0 @@ -/* - * Support for dma_addr_t typed properties - * - * Copyright (C) 2012 David Gibson, IBM Corporation. - * - * This work is licensed under the terms of the GNU GPL, version 2 or late= r. - * See the COPYING file in the top-level directory. - */ - -#ifndef HW_QDEV_DMA_H -#define HW_QDEV_DMA_H - -#define DEFINE_PROP_DMAADDR(_n, _s, _f, _d) \ - DEFINE_PROP_UINT64(_n, _s, _f, _d) - -#endif diff --git a/hw/usb/hcd-ohci-pci.c b/hw/usb/hcd-ohci-pci.c index 18b58f5fcbc..70c9e9ac4f5 100644 --- a/hw/usb/hcd-ohci-pci.c +++ b/hw/usb/hcd-ohci-pci.c @@ -25,7 +25,6 @@ #include "migration/vmstate.h" #include "hw/pci/pci_device.h" #include "hw/core/sysbus.h" -#include "hw/core/qdev-dma.h" #include "hw/core/qdev-properties.h" #include "trace.h" #include "hcd-ohci.h" diff --git a/hw/usb/hcd-ohci-sysbus.c b/hw/usb/hcd-ohci-sysbus.c index 1a2cf29bed8..4f51eebccb2 100644 --- a/hw/usb/hcd-ohci-sysbus.c +++ b/hw/usb/hcd-ohci-sysbus.c @@ -26,7 +26,6 @@ #include "hw/usb/usb.h" #include "migration/vmstate.h" #include "hw/core/sysbus.h" -#include "hw/core/qdev-dma.h" #include "hw/core/qdev-properties.h" #include "trace.h" #include "hcd-ohci.h" @@ -61,7 +60,7 @@ static const Property ohci_sysbus_properties[] =3D { DEFINE_PROP_STRING("masterbus", OHCISysBusState, masterbus), DEFINE_PROP_UINT32("num-ports", OHCISysBusState, num_ports, 3), DEFINE_PROP_UINT32("firstport", OHCISysBusState, firstport, 0), - DEFINE_PROP_DMAADDR("dma-offset", OHCISysBusState, dma_offset, 0), + DEFINE_PROP_UINT64("dma-offset", OHCISysBusState, dma_offset, 0), }; =20 static void ohci_sysbus_class_init(ObjectClass *klass, const void *data) diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c index c4a9741bd42..23990115abe 100644 --- a/hw/usb/hcd-ohci.c +++ b/hw/usb/hcd-ohci.c @@ -34,7 +34,6 @@ #include "hw/usb/usb.h" #include "migration/vmstate.h" #include "hw/core/sysbus.h" -#include "hw/core/qdev-dma.h" #include "hw/core/qdev-properties.h" #include "trace.h" #include "hcd-ohci.h" --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891643; cv=none; d=zohomail.com; s=zohoarc; b=aFJP/bwuiDIprivQue5gqSg1LuqYrY/HJSY+K5gDhfVs0FZ702rL9O21507Pw7BJinR7q/EOZAsVcI2fuSf+84DCvxWEBxGLQtReK8KQctFp+wAKD7LpFo1tcAT00IcncFxkALWISlwl0d7G5D2xgYWdatDYzyiNk9KME5JyxoE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891643; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=1BHIiwaFAj5R5XVpPcwZSL5X+s5GtQyu0jdUw18Odrk=; b=SX5S45vV88DA+OxABG8hGX7R3z5kvnZTupC2t1QEftu5nEKvPJ9TA71fl1lt5QO9xtObGsNtVn0E5ZKTNOv/S1NjJbf3Xr0ZUuagLhU2QeDd6KNoZ4CHanx5MRdTNQX/vh8qiMgFyg+PZuCTFp3ccV2z3u6tusA4PTzunhEEfIg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891643512691.5614904301123; Sun, 16 Aug 2026 07:47:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvc7y-0000On-Qm; Sun, 16 Aug 2026 10:46:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc7v-0000Fy-MV for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:46:20 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc7u-0000cB-5w for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:46:19 -0400 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GEMGIE4022409 for ; Sun, 16 Aug 2026 14:46:16 GMT Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghnum76-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:46:15 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-930edb4362dso244010585a.3 for ; Sun, 16 Aug 2026 07:46:15 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49996109652sm70670065e9.4.2026.08.16.07.46.13 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:46:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1BHIiwaFAj5R5XVpPcwZSL5X+s5GtQyu0jdUw18Odrk=; b=IEPGL8duskCEStUR Q+4Fc5uHF4t1f4Dhf7Zj4NPuz8SnaflMKY4zYLZFOjKRSWwSGX5j/LD8Qnm27sLJ eTshI3JLt8cfif3ZXDPKAo3L9Yg4sJtN0MWg0+NLcyB6HdhHj2vVPujxxRINJB/9 MgM4otKoY0Xr6TKKgAo/SE01u9t9B1d0/qWnBQ2bXPFn4msxQhvxn3ERg9hPkrY/ 7BcUJ1Vh+9mSvFqVWvwHWTzwPWI6sbQrfZ20crquJV/n/0DRc7m6WS9r/OEK6fo8 bocgort9iU0KZ+AQOAECOZ9S1V5lOensuW6oQTMyPOGxSTrjZfmQ8S1PuDdDCabi la+Ywg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891575; x=1787496375; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1BHIiwaFAj5R5XVpPcwZSL5X+s5GtQyu0jdUw18Odrk=; b=Si8OE/OyBUWOj2MBrr9Oy9+o6f+eG4B+tp1JeHYuscVBlf/NRQml8tdq/MC7FLqM4e fNBlD+ilMLvsCNswoYgZ4uVaj5GDvGq9tYZjkyb0tuF+5RzB/nk6VyEROAWkI6aZrbX8 LFxQ5a8HF2mUhCUiFRrFzZuVS1UzMUQPVXUAjZ0TwfcuuYtRfLpQZBSafJcp1srnuagJ xBLCDvDuDLUrVJAdKa0gqnJ9Yib+e70yygxFjVhJtvkqXbkmOKocAXgspzJE3gfCyL2f T6LkLdst6pA7lAbfQsG422Ri+gT4iigfrMLuQi5rk3E6BjQkuP1XfXSpMWkRxSfH2IG+ GPog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891575; x=1787496375; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1BHIiwaFAj5R5XVpPcwZSL5X+s5GtQyu0jdUw18Odrk=; b=gFAn5aF6K9Pdj5UBy2IJ2ExQdgNPhhRysSYlrtB8iD1ykzeOjmYWu5qLJ14FOrShjR IhgNG3ZDgFmoOdODr9O3TP/L0Mr2EV2pyJLLJ+Q9+vG6wdHu2BuJ03E4AFAkdp/6auLy I7MbyHsViNc7ZQf72F9NgGxzOcQobNFqTPZvuGHWa0sB8pQEj7xaVDehJb3bVWlgx2cg 2lq9Mnt8P1i+pMijwe2q2g8uCmlv+AR5HpYS5Lk7dOKzHvd1uKfldmf60AUfV+/LCV2J WayXECHEOQLDcUzWfyB4M44s3bmVGdgpuqfPVLKploAQ37zkOmjx9mzka08EfF3J0/ji /wGQ== X-Gm-Message-State: AOJu0Yz9LYYe5eSXzIyJCJ11lsTqMvn20JM6POwvS4oWpWSynzGKzCaH DHRnMEQIJqQyj9OKCVfuyjhv+Cc+ukDDL8w6t1NetYIHo4nuPtVzJpXv1L6ERCXFUXjl/ryFLJB zBvVg52sAxUeFP5hPdkqX8rfiK7+1vgCz42MHoNNFHEcZ5EnrG3osz891iGgjlwZHMQ== X-Gm-Gg: AR+sD13BuvAsyev50UNlZNlGk0vTf+RViyKkWdAb5fKcfXbzyxMGE5IpW7HpjhPeNgE GvwdM72i6vCrtynH8Vyt2Ic3VeebKTdVlArvE63XwoFGnb2Pgbjfn2l+ffHCr29UVy+bglXR4n2 c6KExgtkzqPPDHxJJux2vHLOwxg3j3G8pSjg/BtoaBfNkqpFYn2ON++k0Dy97r/ITBV4bYJvD7X 4J5bq+4YeiPmFvtxoeOeUzyWEdU66qfRZKGRxi9FSG7HReK3wr9uqUiWKsber5145zxA2xC0p7i xp4Kge9tDJreH0T0b8QpQoW/ZETpKUMYmEBnsoomRCfwfIleX4KmOOLmlRU7hAQ68dcH0bBRJCh gA4YTlQRTSecYgIJWj+3EHRjYATwdSffPHWbEl1EzUQ== X-Received: by 2002:a05:620a:3f4c:b0:936:cddf:3df1 with SMTP id af79cd13be357-936d234552emr1385910485a.44.1786891575235; Sun, 16 Aug 2026 07:46:15 -0700 (PDT) X-Received: by 2002:a05:620a:3f4c:b0:936:cddf:3df1 with SMTP id af79cd13be357-936d234552emr1385906485a.44.1786891574731; Sun, 16 Aug 2026 07:46:14 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 02/56] hw/mem/nvdimm: fix "size" property typename Date: Sun, 16 Aug 2026 16:45:01 +0200 Message-ID: <20260816144556.69009-3-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExNyBTYWx0ZWRfX0UQguwuUDGCk 7yWO8Y0UhNFg7ckMRA5DpdczxL26tzNsWGsWgm9l4e88b3jl+V2O7g/toMIAktJ/VZfqDCSPxmV 1GTY6QUoM0XDmT8eOXQM7h6DzupFJkVfdq55JIv7Dpp3nIhu6D7HbV4BjKv1d85AQQ7y+XiQIp7 pIad5kHpp+ymlpHc8OU2gFulH/TlQViSVcl8kAbTB4NgsjbSkpwng8hqrxPCyOGBpl1EvPlba2/ Kt1LjVHpwopeFZ79gtFcBkuIEtHjGbq5reiOfB2I7cjSMwWxX2+N7aimmT9CAZudAyUqIsjyAyW K+3XzdYTzqMnVSTlmzJJ8CMIn5VIz5JUEsKELxChc7dKj3wbBkM+v+8n7xs5fISveJYLYdLfvCk e+1+PaHcrCSHsFG8I8pTuwjrgfzbNDDRVC1oBOY17qq5z3Fdw96UN7RleqIGAq81c5YORM85miX 3i0AJabKQnvqBqEFFbg== X-Proofpoint-ORIG-GUID: opBa1at4W7StoQM-fseTSfklslWbEw-M X-Authority-Analysis: v=2.4 cv=QN5YgALL c=1 sm=1 tr=0 ts=6a81cd37 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=20KFwNOVAAAA:8 a=EUspDBNiAAAA:8 a=__lbXBbGMqqOeBtyAPwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExNyBTYWx0ZWRfX/zKZN8sEz3WU vrONt9Eq+hHROehOtqI09V3z44zfwQuIghVFjGCVSl0wqtQXTWQFZBtatbgzId1t6EowbEEFWaw Q6T8RNjagr5OFoLauLl6DnT1633EJEs= X-Proofpoint-GUID: opBa1at4W7StoQM-fseTSfklslWbEw-M X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160117 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891643978158500 From: Marc-Andr=C3=A9 Lureau The getter/setter use visit_type_size(). Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20260616-qom-qapi-v2-30-cc9396b9c18c@redhat.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/mem/nvdimm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c index b7032525271..cf8a4d8c5f2 100644 --- a/hw/mem/nvdimm.c +++ b/hw/mem/nvdimm.c @@ -99,7 +99,7 @@ static void nvdimm_set_uuid(Object *obj, Visitor *v, cons= t char *name, =20 static void nvdimm_init(Object *obj) { - object_property_add(obj, NVDIMM_LABEL_SIZE_PROP, "int", + object_property_add(obj, NVDIMM_LABEL_SIZE_PROP, "size", nvdimm_get_label_size, nvdimm_set_label_size, NULL, NULL); =20 --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891610; cv=none; d=zohomail.com; s=zohoarc; b=F7RbrAKbfx/rUbswj3hSw4ct7KAgOI+UP+1/AeroPjNi6y1fG3n5mmjpoQDQgLqzNTLuI7uTbqDuFsyrM0X6qcMEX3ZozreICJCpqe9vTO7z3NEoGcyJXCoow2Q0T1KXU46jIJPRPvJQ1g5/ZZpIezvORbIYWvqJrvsZVXzDSBk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891610; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=pjqjEaxVB/QtFB2VMgo2UyEK8yOL34JHeDLHC/YsL7k=; b=C2akTfLtrmcQYY6Lx7cakhLstPw4Mcl/rbB7H2SmPe/0dpjNftNN2i3VNUbeWfAP2pN+cumFQGSmGIDvn8PUUT8NgpxwIJrF2G+H5QY4Bzw7I97ztXebCrBp8xNfFqO1VoRNqvmrps4l5PPgFaLS/fUDPQubyY0dE4diCXngeHE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891610396429.6465591050153; Sun, 16 Aug 2026 07:46:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvc83-0000Uz-N7; Sun, 16 Aug 2026 10:46:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc81-0000S5-QB for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:46:25 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc80-0000d9-DD for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:46:25 -0400 Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDknKW3532396 for ; Sun, 16 Aug 2026 14:46:23 GMT Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghf3md9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:46:23 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51c1c7f135bso45089361cf.0 for ; Sun, 16 Aug 2026 07:46:23 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49996113beesm49816055e9.11.2026.08.16.07.46.20 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:46:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pjqjEaxVB/QtFB2VMgo2UyEK8yOL34JHeDLHC/YsL7k=; b=Fvy77fYtb6gUgv6t a1a9irisdTHVLbVY/5WTYxWcpmi+zTese5zCm91G1nHMf7ghBXri6HDxeZ7rqy3q SOSp6yh5mPftM5XJySbd4vr+k3DMgvzgw/Ou021L5yTyHRa+aidKCKJ5RbxSxW1C T5Y4lIYlsO5YEHq1XPKZLNy2JUPZ2eoxlqFpUzT6lfBMrJs4UNScJ9L5UM+KldsP GzDCTr+ohvmfiVsOgljUehdtKD5vvM+iz8qO7uozGwa4ogdWa3Zatiue8etMXdVI kTQS5Yu8X/DOCFIoH6/0vVQo8T4OfC0Un7jek08Txs8qicgOENLY1eeO0dV8mvE0 NT5Qbg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891583; x=1787496383; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=pjqjEaxVB/QtFB2VMgo2UyEK8yOL34JHeDLHC/YsL7k=; b=cqg/U7xvNNK36IbisE9aWilrvia6h6tKvM3LjdBZl57jEQmd1OjXHa7haMBKsnad4w mAVJV3mbOZ5BQIOL4G6ZckhaAZVuRaICyRsOm9LXqzCi62D+89hn2MCf/wxaYJ5d/+eO TWIEzS+IvaF/XMq/VHr4p/S11mQSSYf9P2Tf3LdTgHFmsT6mXJCEkRrz6unIyJiQn2Nl o7ltwIpjHJmaLdxyEP0gXJeKN78e7Qh8Ke3uxRSbjsVQdehBgfSIpGRfqxxr2uYrRXgi 6CbVi3SPhj80+nDnpaa6yl+I5KpKn4bX6pHhKerQoGQCCzqjWpltAJPFTrj/qRbAWKWp Zv9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891583; x=1787496383; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=pjqjEaxVB/QtFB2VMgo2UyEK8yOL34JHeDLHC/YsL7k=; b=JFBwEHYt4m3E1JAYti7bFhLk1uyNlhA1amQsm5UDkIDn0Px+aHC59BcEhIVem9wQli DZnNgwau1ri67IzEmzhVEpshGwDm7qVU/53Y3vD8+/86yFCXr8Mh+BIIOQyQqPnCjpLw Z57fdNvmc87KhN4fm5jHOB7BWe7HfQIJWwRLPtwX/yQWVpDesMl6xwJHwwlckJY3qyhF tH2oaY4YnDI1BIojJIMbx+yLHZXQpJ/X3RUrkDwMv6P6X6xIY5JVFPQVpRbLJkc/tsZt R1iXbszAd4Bl3oyDYg8hmgPXjdV1wcytlSe91iqepiEw/FyUJzoQbgC+sF7OQ3i8SWOu fx5Q== X-Gm-Message-State: AOJu0YwEwiorbWEy3mey7eEFOJAwZt1WEE8NX+gm/noHdBIug8F2hsod QssWHBWtrNnxIUbSeXz051j9t5XMUJiOGauB+RwHVgiLmKrcbpBWqi6Bu1R2fN1Q0olpoR9vDi0 zmsPYyew1e6eCtxvN0V+CHRkvgCIr1Lt63bForXID/O3yZuc0wbwOJV7MhISeymrfBg== X-Gm-Gg: AR+sD1094PyMz57QiSMuPj6oFYGi32yzXIbcg9MjttNfQzjUpbMr4SJ+enyJECvsb+z JLnSrCvAeh7aTOf6Em6tkzSt8evNJPdsWiOH38U+/BVGIrh/2ZvNB2cnRPpfnReKwp/IYUYO/gY Cd7C59Ca4IELLHYOKs8iaZC/M/pxHEj3SC0xpt9T9UCu+j4wWID/HG2qsc3wms3seSsjVpQ/Ny5 V5LECWNoyYtcd9Pm6M+VEzDmkKhMyDt0v+02+c7x5Mtd5cP0JQvTLv55/59R9sDq1g14sqFvNW9 pC6G8UoDbpPu6+/r4ljgdjyqfBci1wvoiN5tQ83rK6bYnDJ8AN07NcZ2wXdav4tzr+bDmxN4c2s dM7BXM8xSlFH1kYjKwv7T297UuC2iXTU5TIopF5AoBQ== X-Received: by 2002:ac8:6546:0:b0:51e:47a4:4851 with SMTP id d75a77b69052e-52d8530dbb8mr222684711cf.8.1786891582004; Sun, 16 Aug 2026 07:46:22 -0700 (PDT) X-Received: by 2002:ac8:6546:0:b0:51e:47a4:4851 with SMTP id d75a77b69052e-52d8530dbb8mr222684431cf.8.1786891581619; Sun, 16 Aug 2026 07:46:21 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 03/56] qdev: Make qdev_is_realized() take a const DeviceState * Date: Sun, 16 Aug 2026 16:45:02 +0200 Message-ID: <20260816144556.69009-4-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=QsVuG1yd c=1 sm=1 tr=0 ts=6a81cd3f cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=Xuiavk7DDv2jdHKTz3wA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: GdPDKxgppUDeriJowm92Se_vm5uxKJ0F X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfXwJMuveqi0sE0 TQYT41jdArwvbtJ2NzVJfN0r0IIBT9eWuZaEaYfc+E3X8F8ZZE2c3lVJUZEpoMLEgatrfJc9GrX rDCNmgBT5tm8hc5XyXi7Zqs18QALC4kJXJm1NPN1/8mSIu4AguQ7SzgusT/03Yd3LjZYQMPfO+N vx2UZtWg6xQZRFmSTUFmrWoh0Tv8U1sACa4vq9TA2DicFGofdHVMvms4RwMTUPgijsDTf5+vmMn eHPcMZu2yxrCQhV/XmWMOohXmCPsU7Qtr53asw/TxiYiOoBSdJ8e8lSJ1teOarOuEmhqPz93Dy5 TmOYWMvKiA1/pvds/rdgrFy6VGoJlzfkGyPaYYn+LbHSbmUHwZgApnTp8GD69zp3n/r8KbrSPmM kDla0RXoTwv1s79/rIM9hhJOYbcx+YfEcIIKPmdGAyv6Qolg0rmVbkPiEvguWGB4m3R0bS7TOOe mqXdQ9mPAvodeveBALQ== X-Proofpoint-ORIG-GUID: GdPDKxgppUDeriJowm92Se_vm5uxKJ0F X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX538lrCnfWbRw Yd/h1r20VgYZgPhsRXJEVysl72FQm7B8SivrjeOm4ShLDrO14BHRF1NjlPjevl4t81IePrVZPMd iCdY9FD2PlBbhzCF1se6OXkrW74m5Xo= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 priorityscore=1501 adultscore=0 bulkscore=0 malwarescore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891611874158500 From: Akihiko Odaki qdev_is_realized() only reads DeviceState. Make its parameter const so a later caller with a const DeviceState * can use it. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20260721-qdev-v3-2-d2e226fa002e@rsg.ci.i.u-tokyo.ac.jp> --- include/hw/core/qdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/core/qdev.h b/include/hw/core/qdev.h index e1476223411..37f7d335519 100644 --- a/include/hw/core/qdev.h +++ b/include/hw/core/qdev.h @@ -437,7 +437,7 @@ DeviceState *qdev_try_new(const char *name); * Context: May be called outside big qemu lock. * Return: true if the device has been fully constructed, false otherwise. */ -static inline bool qdev_is_realized(DeviceState *dev) +static inline bool qdev_is_realized(const DeviceState *dev) { return qatomic_load_acquire(&dev->realized); } --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891608; cv=none; d=zohomail.com; s=zohoarc; b=SChgP81WHeg2ODw/2A1x5qRWu4JpLylgROUAFWJAVcDH/hePY48ctz+qetbnKZKObljT79j7mbdfJzyAl8DObr6SbC9n2eFT0O9om1EDcu1h78jANfxf3k3Hryk7U5VoxVhAjFzVFfkYcpQeNzbmZjOSlQjhSVKZAGNvnR+e1vc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891608; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=PyVVkPq+vWQ95qLp+r7QgINem/ADI6tAGQamAcld+mg=; b=VJPJUTcmgk/UmEfdnf3QFkg5bIuQh3eZY4TrKEiy8MkPAr5QIxhGu2qgGRofeAhv2UZNixowNR8oQ2xR++PNhIaKWpGKsvLEUvhFF+rQxjk5pGycQeN27s1Ies+4BmRKl5kAFemdSKzJpJehYIAIpYUFQQ8O9MqgSAeaDuYZVCg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891607936943.9890234527029; Sun, 16 Aug 2026 07:46:47 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvc8A-0000be-66; Sun, 16 Aug 2026 10:46:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc89-0000ax-BF for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:46:33 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc87-0000dh-SA for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:46:33 -0400 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDknIH3631363 for ; Sun, 16 Aug 2026 14:46:31 GMT Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghekpxq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:46:30 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-92e5e38fbc5so270100385a.2 for ; Sun, 16 Aug 2026 07:46:30 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499877d5548sm172078745e9.1.2026.08.16.07.46.28 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:46:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PyVVkPq+vWQ95qLp+r7QgINem/ADI6tAGQamAcld+mg=; b=keSBYE+45ot9tHzg 93AvPgZhoWk2OiB2nMiI19hffISLLMpOxXXtQPc407LjDgLqK56nAZ/tm+NH0tHd r2fRCk68m4ma+BXrc+tqgZffquEwTalf56dQWs74IouwiLwbxXhewRZsro+yRX05 fjp8ixt8/YxkLZiOdq+yNkLLW3UIPG+bUiT/bAKWmB5ndGyhpL96StxRZmZ9vQro NZxejAzpS2B7kt35tSPVnuOBW1I3IEn2nj/Dp0DhtAQkMgl0METpAOBlAu1ygR+1 jYi39AaJmH5q4cBUfrx55DkELDOYTz9bvm0feIHEyq/8xyHmSFGVgT2koOLEBhik DUCECg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891590; x=1787496390; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PyVVkPq+vWQ95qLp+r7QgINem/ADI6tAGQamAcld+mg=; b=I6K5x8g9qVtlRGyWgBikzuAB+oA6NZPz5IwATogrEuindwz/w5SU2LUzkd5/DQA0Pw 5tfRDe8P/UdjE+IgoroKS8YNvk7fHTQei4QaFutrnJm4+3MWehd+wJ4n7i3qwFQIPemK 20HmAVN/EbwR6sOhdI3LpR8s2TRscECo7Btnfd6zOxvlfwW3GhCiSM34XnNKyN3WD0+5 dQQ3vB8iTp3SbnoYzYIYWMAqInlkoY3XVVm0H20SGVaQD/K9MSCnqFdRu8NbkRD/qutK SlgpKrsSjE3KBGK4Ur4JoI+4Qbl3zLF4ASxZqmcloVveabheQgS3h5qmSYuuZ0O3pLKv yNWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891590; x=1787496390; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=PyVVkPq+vWQ95qLp+r7QgINem/ADI6tAGQamAcld+mg=; b=N83Mly5oDcmJigLizAvy2uDbbcsVJCnJaX6xu0N2W+hPWDNJPH4BIuHGEhIBT+G/e9 z1egumj0CPUIcXSjp4I+9nXd2NiMzIpXfRdDgXyM8O0R433vVa0zUW3j9AH3TS6kbjgL DLLH+9rN+uwOiYRdAwCWst671/7pUEP8okV6OxFQjbXhz/zxWrjV1l/+u3A1t5rPhc8D TD+qAw1mzABwRHTIr3fF0G/opvGW/P7SwpOkLedjKdpsKKzJPzIG+rwXiArYyInYQa7D q+HsU5007wcQSwNLf2Fs6HTJKhFf5lUr0a16yWM9b3/jGe8uEl1WrUstjYUqWVsJanNB iX/A== X-Gm-Message-State: AOJu0YzJ/Zbcwdk7fs+B++iSNZU+xCGL/DLm9UsEZ/9SH9L4WPKIOsXK pxde/Ucnc1CqOuKtwXHmatmkwl2GFQeWFz88qI73KMrTebbysvcdpRyHLPb8nb41ca3ZKvnYSF8 1iI823ksMwmi/SyaLSQwtaD/S/H9gbXQ8k5jqwtqRFkcB6yERaBMBaWfUxKmaLyV5uw== X-Gm-Gg: AR+sD13/SRRQvGXcjsH3voQ6I/ocDbE3siEd3n/X49KN1jkBDHX1T1Nep72AoyzH++Q 4aAsiuj0vU/0vLQRUNkBTW20V7nVIts7cym55klXlG/Un6YOVd0FGlBZOr8NgOHATJ+3cCiMMFa 206zupVLRWTMcANFH7JsNfxhLh76rvZ29IHCacUWPJuGRJk88mOElw+7ykSTUMfDcwIR1Knz//m 2z1+PM680YMdG81EVloDSY7kTCRHYQwct5b7GcjK+WVt2ZjpXS/4UoBdZ2Hgt5nIEDuZdPUQRrC qoq52ZB7UtjVdxlwQOv8lLx0B73W8Vsazv7nPh8xb7slOokNtnLz5U0x7seAgeBdOD79JLwQ2Xy QVueDNh1+qoNsqBkh5MAzkieQdkrW2atKCT9V0cxofA== X-Received: by 2002:a05:620a:6f88:20b0:936:a407:98bb with SMTP id af79cd13be357-936d2278950mr1451679685a.9.1786891590284; Sun, 16 Aug 2026 07:46:30 -0700 (PDT) X-Received: by 2002:a05:620a:6f88:20b0:936:a407:98bb with SMTP id af79cd13be357-936d2278950mr1451676385a.9.1786891589673; Sun, 16 Aug 2026 07:46:29 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 04/56] hw/hyperv/balloon: Use qdev_is_realized() Date: Sun, 16 Aug 2026 16:45:03 +0200 Message-ID: <20260816144556.69009-5-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=EKc2FVZC c=1 sm=1 tr=0 ts=6a81cd46 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=uRxLgUfnyXHAhkBXUOAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX8mrfyjssQk9i 5tJcsdHe7G2pd21DY7NKaeLbk0eWNshjYUBqNeQxRyeAq4xKFPGRgapAUW18gnjr+i2jjWcOx7b FiRX3SdYnPOCBPQ1MdpYhlodLKqEdkc= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX5OnFhoLG+aM7 FwKeEMHKUyXBOu2+ybFr4OONNYCkPUACMqcyAkzORmPQya0JlgpyG7f4JQczTuSq1ecrOgO+GIa z7Zmz2nj/TauvE0bSIjruPM9apU24NAGMNVX3NLwo2/d2E1+fn6/GN5gbugfB6Q1thkvT0Uec6X iv8v8kTytOeBxwphPihsbuNEBAxtlWO+8meojO7uQSAtrNWToUsFXjB1lKIwNwj4q9KpA2TiBnc BArNBJCv7R4V/w3wSBJYpQQ5B4mti/07Ds9FbP1P0XAwXQbfGkbWyZeJYhdBZzm1+wqmxZh9pXN UmnorYFeILhwcGHO+yKNwe5Y9tXVxQjgYbDLbeCUa9PvePbdXSnjEH0/DRwELHiWMJqYpo5HLdQ TQJJyhCydQwU0VPU9qY8tmlGxmOYTxZOxjdRG+ln+zoeVSfxhqdF6A6N32sTF38lamuDWYgAo6U XOZAMgToKv+3NcX8/Dw== X-Proofpoint-GUID: wJWaFOjwTrFTVCtFb5Pj3901i6oqBNwr X-Proofpoint-ORIG-GUID: wJWaFOjwTrFTVCtFb5Pj3901i6oqBNwr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891609911158500 From: Akihiko Odaki DeviceState fields should be accessed through qdev helpers rather than directly. Use qdev_is_realized() instead of reading DeviceState::realized directly. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20260721-qdev-v3-3-d2e226fa002e@rsg.ci.i.u-tokyo.ac.jp> --- hw/hyperv/hv-balloon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/hyperv/hv-balloon.c b/hw/hyperv/hv-balloon.c index 9dd759f11e8..b8664a246b4 100644 --- a/hw/hyperv/hv-balloon.c +++ b/hw/hyperv/hv-balloon.c @@ -197,7 +197,7 @@ static int build_dimm_list(Object *obj, void *opaque) =20 if (object_dynamic_cast(obj, TYPE_PC_DIMM)) { DeviceState *dev =3D DEVICE(obj); - if (dev->realized) { /* only realized DIMMs matter */ + if (qdev_is_realized(dev)) { /* only realized DIMMs matter */ *list =3D g_slist_prepend(*list, dev); } } --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891622; cv=none; d=zohomail.com; s=zohoarc; b=j716tmGGAbdPycAyu6eobIbntffLSOFdgwAf8UxHWiiGmQix2kbsprHIbP/pidwkymH8xzy1GQBHVlSq7ZjEw+PNSWKQcg1cK6uq3uo2qHO+PXlhHIncgyL8ALbH8EyMEM1e/juQQLJ2UK5VAvjafq74f5K2xZEIBr8a4XcexCQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891622; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=eS7FJd0/KrECC4g3ko1OcyrpwaFR6JN+bKkTPyN7QGs=; b=FsBLWj9jwwalPDvhPpiSzu3iVbDNIlcsUOYvD7IHd04wnaQZF4yjzgf+57l0UmDJzsDaoTaQxzNzQH22qSqmIL+GEPAZfGu2dveGINti6wtzAdkNGB6sFWZcONottZ843ScMEAJIBrTWOFGULPSzA/3spSsoJ2fZW8Ye3crBueg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891622408198.69680929809408; Sun, 16 Aug 2026 07:47:02 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvc8I-0000fn-6Q; Sun, 16 Aug 2026 10:46:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc8G-0000fa-Kk for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:46:40 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc8E-0000eB-V4 for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:46:40 -0400 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDkqSL3448447 for ; Sun, 16 Aug 2026 14:46:38 GMT Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghk3mp4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:46:37 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-936d067836eso255755085a.0 for ; Sun, 16 Aug 2026 07:46:37 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48294e70f8asm15871664f8f.11.2026.08.16.07.46.35 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:46:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= eS7FJd0/KrECC4g3ko1OcyrpwaFR6JN+bKkTPyN7QGs=; b=Et7mgn5qNLD7IUbb dH1/V2It5I0vVeCFqARigOLbRA4rMQHEATUyRpeTJ5nhnOOH4jp648NCRA84qQIN YyPr0UsE6TMCpFnNlvoY2KKlxWBAmBPLqA8H/6aNCRieE+dXP3KLdLXz3YUjpMdE jVxgcniwWPZFFq80QPGqCizqe9vEyRryIEKoEifNJUAElmibSxONH9XW0t7CVM/V eWWy0GGBLFDce2X73IPsv9xACD/s/DUPGtbsUPfEAdxDUQ8COYKTlxvB2tCKjkFx zBHRgDy2KakfR8eHQ0E/TsCOD95b1I1jJNIqK7XxfYCufE3ORKYCFD5saw8mwH3c MSuiqA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891597; x=1787496397; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=eS7FJd0/KrECC4g3ko1OcyrpwaFR6JN+bKkTPyN7QGs=; b=QHb2aLEApbPQaj9pN3iTyySRfZWSYz1kaMfjK8vflh4KGOBSF8HwiF95BsI4Erzshv jbVjZBdhhs2L4lgLtTtwFp3ojBAXaNY9yKPxFPFOopsFE9KYiQ03c9sWAC/zKK3+5vSS afY+80CAPH2jvr+Y4fckBmzQCPvnfrkJgYs3g4K0LoIc2gRjneQr9UfGPkIW9Pv5sPCP Dz40clJC0Aa9bcvA40OZlqMqI5/9NVtpxOHfrj6DCcTAT6aEIf0ur+smDijYxaG57Xto XMy6BH1GF2Z2YF+n6/KR9hQn5/0b2itU3+V3cwUmeXl8VpsJ0Tuymmjg0E/N5YjBZ2Av L4sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891597; x=1787496397; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=eS7FJd0/KrECC4g3ko1OcyrpwaFR6JN+bKkTPyN7QGs=; b=WiELp1LZZR+9ZxP/pKN4kBARu7lEUKTmyGCWWko1SqmfiQVF5AyKhpa9D5PA893G8T I37ArXu2m8MeUx91bWrAl24hk0Iv9iqXD4x3Y38/6ivwlnRlnkCOWqF/NEmi8R/RPEZ9 84MrrVgauqteLy70VmTD7D8AE4ptuYnwpK8kQlw+7YtmpMk1LB7ZzUdJSwCIsWu5kPRO wO8zFPlfJZIoCs8NNHEwlDQSwgRO+cjhgmwXVFuU5El1BQot2E9Q3qBHEkjeVdeySiiw yG+nx0eFCr5ONQXyqU2ZAHCCBQQNwvxST51uuuTeQ+21aw23fcbia4f+mDLZjlV2mjHS 5ikg== X-Gm-Message-State: AOJu0YzftSsUJfYlFbfqsyCmSltjt8v1z5g3Ok+GmLRe2uY5gGZ2BRyb etPF6EkUfRoAC6GjXuT58OF6AuH+4pRglPpO4Xie5Vjdw4zFsZJezjYCNd3nwqzkfnMVvw8Wlbb ZM+6oQGGzTNqiY+XDeh5/DmuuXwHqKF51MUVrX5tiXE/JCnFRHNgfw01k6TsHuCx0YA== X-Gm-Gg: AR+sD13LxsN3xg2DBZ8XBF6jnAbd8SQQ+GTQpRdpc3k1aohzlRjdHCyBUfCXTJMnEDx t/ZtO+0sBliydkWt4s7pkspjM9x8Rc6/FnxfA+z7LL23HzQ8s1BGgOIu2egVIEh6xI3CN+ojvkY a6tzW9iA4dePvlgpkqWJK+fYKf/30q0tUKFg+GCyfeH5EEZN8yPuQxCz0EKLjYKBBI5RW/GEo1s mL+cgYYDhhuIZjMpbzcbMVR1NOHPeLYIKfJ6+P8Wf/0fvBR3GRoqGOpvLay9N4paEJqzzDfN613 rncPyXjCVBGgRuI2zCgoGFNDSyIjXgOgxavI/K1qECp7DJkQwFhy3DS6NqddFGKDc+ivJDTaPnZ ACeOls1djwOQOqUuFE25ht77Q05fhTtNbOq42LIH5GQ== X-Received: by 2002:a05:620a:408c:b0:933:ada:c3b2 with SMTP id af79cd13be357-936d2382749mr2009148085a.34.1786891597105; Sun, 16 Aug 2026 07:46:37 -0700 (PDT) X-Received: by 2002:a05:620a:408c:b0:933:ada:c3b2 with SMTP id af79cd13be357-936d2382749mr2009142885a.34.1786891596488; Sun, 16 Aug 2026 07:46:36 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 05/56] hw/intc/apic: Use qdev_is_realized() Date: Sun, 16 Aug 2026 16:45:04 +0200 Message-ID: <20260816144556.69009-6-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfXxdMka1zYFqPW qBJdEDklBSLy6Qh9QeVaOxg60uaDAO7HGYzPCnO1FZdG8lZezSnmr8LZwbbPzdBmNpWmcpHox+/ WC85lY/Ku8QQmcjW9qbMoyhvAsxK+bo= X-Proofpoint-GUID: AaNUQeyumpKvX68ArsvNrkMefH3O0VEN X-Authority-Analysis: v=2.4 cv=f+14wuyM c=1 sm=1 tr=0 ts=6a81cd4d cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=uRxLgUfnyXHAhkBXUOAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX2Dx/KYxeUXyI f49xQ7FxxSzSLKiBD05GItiV8gOBVMVHV1AD/M414cEgyhJ9okCyHcqLMXy/apJI06z5YC45kwB 5awf9cnd/nvqLMcwO6xBZKXJ0aZdlkqusAm5t7FLbByaN/kAcHutMAs+gUTrF91Qjw6mtAArEpI tFnX9yhw9AvTcNeHxJC0w73WDqt1VZmiqpoPU2O6EyJWUVd7lMvOpFJ6sAjrTuGzVKcS09JV5F8 hH3HxnaMYjRWOdi98sQfKkKX7oB0dG+ciTbu1yv3Lo9+top/qekcEtVvKVGONXLugzuxZIHCQmW SrnRpMsU4dXQbIKFns6IeWHWvechHhBpkX327jxNDFz8V1i3qLd+6onF584joFR26miXJu/J+bv uM6fTgHmcVDPA+aXJX6Ff0Z7KaBq3n/j0Hy/NUIRzJeuYX1RwmQIgfSZuhYqZV3DL81aPFSnbIV QsYQ/K5jJDLA18LYeww== X-Proofpoint-ORIG-GUID: AaNUQeyumpKvX68ArsvNrkMefH3O0VEN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 suspectscore=0 bulkscore=0 phishscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891624051158500 From: Akihiko Odaki DeviceState fields should be accessed through qdev helpers rather than directly. Use qdev_is_realized() instead of reading DeviceState::realized directly. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20260721-qdev-v3-4-d2e226fa002e@rsg.ci.i.u-tokyo.ac.jp> --- hw/intc/apic_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c index 49c03a5bcee..0f0f37d4573 100644 --- a/hw/intc/apic_common.c +++ b/hw/intc/apic_common.c @@ -424,7 +424,7 @@ static void apic_common_set_id(Object *obj, Visitor *v,= const char *name, DeviceState *dev =3D DEVICE(obj); uint32_t value; =20 - if (dev->realized) { + if (qdev_is_realized(dev)) { qdev_prop_set_after_realize(dev, name, errp); return; } --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891641; cv=none; d=zohomail.com; s=zohoarc; b=DhDnA4QhX9NLOlqZ6ZCJ/JQGB+BIkiBZvG266pp6RwOqOT7ciWpWtlNLD57vBkFeLxw9+BqirL7Ft5kyMJNxp/DbwrL6aIVdWUO9lB32MevydKSchm51zF6LLvDBG1rB5WkWrB1AX6J/XTJaWAD7rmIoN6S0fXMlV5k2004XLJo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891641; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=7Ha+GMiwFB7MMVYOPKKxOSDbK4itG+KVW/54HtjPNhc=; b=CqG701BabnmB3uY0i4LB9HkjkhwqOgQQqKt92N8ywkUTS4H5tt9U8mob9Yu4fy4H96cX3htINlNARSeI1NYxYdgQi42RrcDYxB9SQWAvWZXnaN6YCO2IMlf3opw5W7uIQt/quFGn5y2SqgcF52PRjQFebBrfKyaJTENY1C/BzdI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891641757861.8194043596375; Sun, 16 Aug 2026 07:47:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvc8Q-0000sW-Sc; Sun, 16 Aug 2026 10:46:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc8P-0000p7-3F for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:46:49 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc8N-0000ep-FA for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:46:48 -0400 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDlh9J3227987 for ; Sun, 16 Aug 2026 14:46:46 GMT Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g322q996b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:46:45 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-8ec3314f65fso25855406d6.3 for ; Sun, 16 Aug 2026 07:46:45 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f2b1d90sm25781096f8f.22.2026.08.16.07.46.42 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7Ha+GMiwFB7MMVYOPKKxOSDbK4itG+KVW/54HtjPNhc=; b=Y5rNNaq9UMywerhy cSE+MgmkFX+BcYwwm717a+qm1JcLcBHO3MV6XFBcOKuld6NrRHLpM4TGaK+LXntg +tH2cQ6eIPHfvloH1Zxb9dos3gmSPL8XuFT2lPvRglgiWyAg38qm26N15WusPFid 3dT3I9kKsmxF3tQyiSYlUWi7Qa5rs4QYn2FowBukJ0tGqXUC9BZNk8RfSW6F7vLh DLbqbqJ+miOEasvrGL8uMhEiaND2o+8Fwl12VHYPGmyp/ryaSgFT6PBpHa64KSBc 8MZ4zejgIulr/coXWKmlmoBuC1YfOalHccUV8oCxNuT25T5YR+bHlv6C89Evq5vD IC+ZYA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891605; x=1787496405; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7Ha+GMiwFB7MMVYOPKKxOSDbK4itG+KVW/54HtjPNhc=; b=EjMm3WEHq6Wi9wiZr4j0AyoRxtCiT2eVuJugNzsdsiwAdVo0jvy8FBnrbRiPqB6v/P GSblWZ6bZu2sxyktIot/kjmxISRBvqhbtJUaYhHcSW4EB+OAAh9h8zG1CVbfImVpLGUr vW264hjgEHtueIQ1tTiPRkN2n0FtiVuex+NpvTZvENvIp6CiHblYXIrI3Qnf+5rZMNwV wHTrh70ydqbBNIwtYdTv5uL1Kor1FGwr++LnPTiTT/LbiEvrBkSZXlqtOTmrmPLUGfNu olPRuJTvrJjlEBC+n64i82UCctD3mtfcANM/3/DHG9Z59FWlo76HxBnS4OjC5T/2drgh keWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891605; x=1787496405; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7Ha+GMiwFB7MMVYOPKKxOSDbK4itG+KVW/54HtjPNhc=; b=KrBHwT8GlMn8t+2VM4hfyFNhpNdi2KjkeDSX+Ki+IU+40lWSgrIQ6KoxcqvxxlPw9O 2P3jtQi0JODr7XtDi/x1aDPZUhsno9H6yyqjjYozqQ71P1HMTkokKacWFOktHURZZKEs GXJvDNk8TcavFHsLZab7W/qEjru3qMbpLpkrYNlZMr7+2pzqllbZzMAHhVI35x7PlJcF yUBp1ulnWD00BHFTpvpL2teKcUvXfwSdBAU3kRA1J6HAwWTnaLeedRcz3neOXgLSnQQ2 0Il2wApKxWck8UIGlh0HKoxwLSxa8UuCnon4KUNs6pKxXYUAgd+zfQhlFwRyJlxf7wiC DUdA== X-Gm-Message-State: AOJu0YyRMhsxBcRr78X5mx/ZTqlm5681yb5rGytPCacgVGhR1j3Z3jc4 QJ9HY4KblxT+H1Al9O8p6ozPlqJAn77JDq7VGEvyNJpSI8K18NtHVCHRH/6v88y1w/N64q49huD OK6881K6v9418Yl/sWYZqyNagZpodZxY/O7F/wVcm1R3tT7UskS1ROUlt1wKG0fHWxA== X-Gm-Gg: AR+sD13QjJjqCOAdWYaNOdlzyELmUg/HEJcZRh//5NyITtu9Cs7TVocECY+g1QQpzhZ zvLlUY7PTgBmarhqKcwuVvm6dGU7K9ZWrik5vMqHUEv5zXv5fss8lp71MOyvCsg8uQCLIYCfwe1 8nVgwnFkXazsrGfjrT6Aor/LEdd9ayv6U61dCqNEtuc2jPjbaDMRThNZn4NIKFjzhWSqMNXCbVF azNOaUR/dwL+osXJDr3hRJ9QSoZYAswttHEUSi+EzRxHkP7eQ1Mdb4t0h+b/ABHe2eQ6vFfSTgM 7aL4+zXYyk5wRtws5VYS9AXLB2cbHGlmNra/PKa745yeOZ2gMPsDMyO5VVqFIAvPTjafDvBpbwD QS+rPTsvX5VyEvFSOBoOMEfwog35w+9itBi89veLj/A== X-Received: by 2002:a05:622a:4809:b0:51b:f857:cf82 with SMTP id d75a77b69052e-52d8530f238mr210927931cf.8.1786891604815; Sun, 16 Aug 2026 07:46:44 -0700 (PDT) X-Received: by 2002:a05:622a:4809:b0:51b:f857:cf82 with SMTP id d75a77b69052e-52d8530f238mr210927551cf.8.1786891604282; Sun, 16 Aug 2026 07:46:44 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 06/56] hw/mem/memory-device: Use qdev_is_realized() Date: Sun, 16 Aug 2026 16:45:05 +0200 Message-ID: <20260816144556.69009-7-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX8YmvM00OTQRj I77JHyuvnKAcpwYH5L3WzHrWmkssCVBx3RrZhQyBsmtHUmF9irHmMNRzkhmiziiwO01G25dybx3 xvWfl7m1O0Dcf5CoKMf5rhfy51hZhDE= X-Proofpoint-GUID: MGy-sBY3DYTJf8d6GvXuxAOL__D1w-6I X-Authority-Analysis: v=2.4 cv=C5PZDwP+ c=1 sm=1 tr=0 ts=6a81cd55 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=yA7JfjU0G8p-xxjCkkIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX5u8EHJiRpIAS Xi5id0N9o3F+tkoLbkb6K6Slw3ugR9UWoFRAz8YfIZX/7hjufObKnfNXMib1owvxPE4heTaMLr+ Zj0AM+ikRJ5fahlzRIoxDKxYHhqQlnWvJ2K75B+zVnKtTmOglfIb8RKqkEHwK/pdlOw53jQbtrR CPJaBsouilKzh7954wkB+LjZLQ9fGpjx3EZRuXr6GkVoR7z1e/jKbTr/eSmLkXY371BUuMS3QaW 9X9yiN7Q8yc21RVJKjVVPq3ARu/hboEZAIIRDZk0tq8oK38+nDO7oELvAvmtgcz914pFbWhF6Tg FO2iDFCXbP759vmpvuGGE0PapTyQ4lrMXV82gtmG3xzHxsz5PPg0nBCwTznmsEVLA0n50PoyIal xH8Y9ho/2N9YbhIMxWIHpZ2XeK1/xNFdRyaZX7x461VWKb/uEg7DkjlY2+Nm0R4NUGMLCS/zJat 8IUKZ7Y2SZ/RtzLPOgQ== X-Proofpoint-ORIG-GUID: MGy-sBY3DYTJf8d6GvXuxAOL__D1w-6I X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891642228158500 From: Akihiko Odaki DeviceState fields should be accessed through qdev helpers rather than directly. Use qdev_is_realized() instead of reading DeviceState::realized directly. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20260721-qdev-v3-5-d2e226fa002e@rsg.ci.i.u-tokyo.ac.jp> --- hw/mem/memory-device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c index 9cf82b84cf4..24bebfb6b31 100644 --- a/hw/mem/memory-device.c +++ b/hw/mem/memory-device.c @@ -59,7 +59,7 @@ static int memory_device_build_list(Object *obj, void *op= aque) =20 if (object_dynamic_cast(obj, TYPE_MEMORY_DEVICE)) { DeviceState *dev =3D DEVICE(obj); - if (dev->realized) { /* only realized memory devices matter */ + if (qdev_is_realized(dev)) { *list =3D g_slist_insert_sorted(*list, dev, memory_device_addr= _sort); } } @@ -326,7 +326,7 @@ static int memory_device_plugged_size(Object *obj, void= *opaque) const MemoryDeviceState *md =3D MEMORY_DEVICE(obj); const MemoryDeviceClass *mdc =3D MEMORY_DEVICE_GET_CLASS(obj); =20 - if (dev->realized && !memory_device_is_empty(md)) { + if (qdev_is_realized(dev) && !memory_device_is_empty(md)) { *size +=3D mdc->get_plugged_size(md, &error_abort); } } --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891690; cv=none; d=zohomail.com; s=zohoarc; b=gQwFngVu1ycSUWJbu+SzfK4WxhQd4obXlJ6o4jHjHCyGB1mXMJkIoPvRiSXIfAL/ZZgEhmD5sUhJiAYlVVpuCF+caZ/DjV/qw0OJXGSVJa7Wh1o1QkieHGfMqEbcS/VCiqP9icIq434Nwb9+J/rS8HHDv5U4lNwT/Ru2/EkZijU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891690; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=XikjnrTT90zrVsPEvEW/wZIr9/0JdX62eGxESnceHS0=; b=I+oyn+2begeMcFfITGO/c2ZFTz6XSdpEbQe3yy3yrluzYDHbGMPmbXb0hTbcW48zt2U31JJ7KzOUhyuOgFj6QnMaIaGGzmTO6gYDb/vcPwODpko/PDG+9SS08o7yGBoWiY5EBDH0OKD8gLv9OyunMwoNq6kkq7WOHzY2CuTG9tI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891690738135.84410028122943; Sun, 16 Aug 2026 07:48:10 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvc8X-0001c4-2W; Sun, 16 Aug 2026 10:46:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc8V-0001R8-Gd for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:46:55 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc8U-0000fD-3F for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:46:55 -0400 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDlLpG3951389 for ; Sun, 16 Aug 2026 14:46:53 GMT Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghnum83-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:46:53 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-92e820609d9so245034385a.2 for ; Sun, 16 Aug 2026 07:46:52 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49996128cffsm47237265e9.15.2026.08.16.07.46.51 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:46:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XikjnrTT90zrVsPEvEW/wZIr9/0JdX62eGxESnceHS0=; b=IjvbVK69mRrIw7iw bvK7c7MFdxANatZsorH1pNPPdlXtPQxhr+6ll0uC5o7q3iL89OLBLrRIa7+A5T8F lbXzinifmj5VY62gDEttulG3Rx/zXqHI6Vhvv97iTDYmIbGcDhJxSW+fT82BhRwk uJ5GxDUtMzZbsRuQV255v7hbtAsDIvtU1tdKasOypIGkaFIxDwtdYBggER3qP9Kg whzeFdY3efWx0B5l9AeYNj/n0zxBcgrZcjpinyL8aKCEtxBVXqV7/2PDbOYQJJ4T jH8BbVdFCUk7BNCiXUkIY4i/2BdU4RbXCN2k57R0wUCj4ZudNaldZnoGwRsTp7Y4 o+T/kw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891612; x=1787496412; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XikjnrTT90zrVsPEvEW/wZIr9/0JdX62eGxESnceHS0=; b=PnU2QryMjlx71Dptuc8CL7D0JuPP43Xi80SQ4UJGpZ0rr3/O2KLyfcb+NaJBWQLbqy RIBqEA65dhbjdr6WIl6w1D/9f+AgxA/eY/dzM2oP3PXX4PawddmpJg94DA4ewkZScoqC /lohcwQaSSIPECnN7Z5Z7OsSguWSWT6zIranb7DoUd+vXqs3L5mngyNYiK2tBJJcGz0c qiLspCClDLr2pESWtkCF1LaudzX5l5y/k6F31LjBq9xACFnLPunTeUicmFHsc/ZH0+7N rqMAVai9XCPyAdt8GYDM2gKQL+JEdLIS/bv7jz21oH5crdEPVJvEA9xR2w8RCx4gnNM3 +gog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891612; x=1787496412; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XikjnrTT90zrVsPEvEW/wZIr9/0JdX62eGxESnceHS0=; b=RVx0qV9Bc9v38Rb1s6Dh4IgrRms2baYQEICE+9yYVP74dUpLx33Kc5wBelNS9XpVRj 5UfsluaqSYT1D1gx82kQPx1o7JRi0FCRphcEAm4FI2/8frQcmt/VklMSwt6Pm0flbC11 Qv5z+JZLRfaU8BwOE8Z9QvM4346sf+KZd3P/UjfqDAmk+sedkWASC6v890pVOLKuSiP5 TnporYvYZuu48tVy3aliLjfjHpIk9Btf/pFVaDwGjOOXx9x26MoEraDmw1cGZDcZg+YV sSxSbcxpqG4AnI0WsusiOyFxmwAJ0QgQga6LTSox/+Jmyc5MysovybPAGwVw3Pvoa54z fT5w== X-Gm-Message-State: AOJu0YwS44dnIJ9i8chAE161wFDQ6STFBzL3iRrqFve+OjYI3jfjcYkr bqmZNIiTQiQnMnuMBArKbB4Xh2JpMJ7OE24xd2gRDHyhF1t4D96N10EWkfECz0U22YVIYjsOco0 kuc9vz1FUPnFHHHvd2Jvf8Q0cXUNjPwDEDQE7MYk3W2+70GbjpubEX+axtIvpABWRgQ== X-Gm-Gg: AR+sD11Hvf7WmPL4OqzHhNH9Lq6GZ7hSodgnjdrhRs9IK0GFuN7C6R1N+1J0VrYqeS1 Hjpihhy1z/SjeQQn7NhgwhpZIT9rCHn8dMREhKFkZIoFi3Glotr9xxU3QXW1TzpTn5h7FA7820N jt2sRWN6MdnbvMI8ZFgnW4F3NI/FPqqnJen5bNue3bvqtPOi+nxw6hEsYM5VSrf/TPk6oS1S9b5 cGYlcJLxWbp8o0J9ecqaHTVS3v/ihlp/a6oBGdihHhTcwljzgear++4if0foqitc3FGinAZwsc0 Svckvwe8ZQgDwvofVjcgjgkDtn3qFGWkcyzlUQPAXVBYElODBL1dxmHgLfDrKyMTko9gR5Us+MO TOL22UXzQpKrpgt6FN51ze1VJfkqg8JwNclwSor6siw== X-Received: by 2002:a05:620a:8325:b0:92e:e376:cf97 with SMTP id af79cd13be357-936d23c6b7amr1697144985a.44.1786891612359; Sun, 16 Aug 2026 07:46:52 -0700 (PDT) X-Received: by 2002:a05:620a:8325:b0:92e:e376:cf97 with SMTP id af79cd13be357-936d23c6b7amr1697142585a.44.1786891611958; Sun, 16 Aug 2026 07:46:51 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 07/56] hw/mem/pc-dimm: Use qdev_is_realized() Date: Sun, 16 Aug 2026 16:45:06 +0200 Message-ID: <20260816144556.69009-8-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfXzsVV7vtarhYi 1ZJqiSXOsAhm7Buv4GLGnj69WGrEH/RSD57W/iWNEAALZx7vP142vEQTFgMFCaZcME9Hbi1OwI2 F5jUSJ/APbP/WyVv/14isI0GcLTuJ2o4FHAWnrrkoBkkssAn7ghLV7Qo8p+vYDIn0al3ZlJJkvf BlequqEe9MWma4O6isHqtw5o+ciHfYAZIttlqvT3Y1H56rzxskcZ2UxUAUfkyR+0a+uAeunkAWo c9MKPIkZ7q1IMLyOjTkMoJ2657w7f2RLjqOYDB5luLaqqbFqjZUGacK1C4xxddwCgnRKAI1DGqh LMQMiBs2BPwqK5gK3rsQRNd9dXtTY17BNJAgruGA1epfaFADT1HaA68CM4NwygmfrmyxnOEy5lV PNfL+Ej6Y7tV9dgRzFGCpTZJUswdKzec4216nmUrc+FB9VkOYiU+B6HqZauD0+Ih7gQxhZ7NSWh ChMi9n3Dhl3Gj3ry0fg== X-Proofpoint-ORIG-GUID: K5inoFZueQ7aT8fLeDX-uetrEctzYNgR X-Authority-Analysis: v=2.4 cv=QN5YgALL c=1 sm=1 tr=0 ts=6a81cd5d cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=uRxLgUfnyXHAhkBXUOAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX+aQUKO37h/cD 15b1AuMBKj6M8qnaLimCeKu6SXt/jMc0+///+NjTZQCMICnky6KlNp3VJCYKf7MoYwXhchYjBKy 8EiqQvMTukw6VZgAmBxblP+v5CqkQ7o= X-Proofpoint-GUID: K5inoFZueQ7aT8fLeDX-uetrEctzYNgR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891692174158500 From: Akihiko Odaki DeviceState fields should be accessed through qdev helpers rather than directly. Use qdev_is_realized() instead of reading DeviceState::realized directly. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20260721-qdev-v3-6-d2e226fa002e@rsg.ci.i.u-tokyo.ac.jp> --- hw/mem/pc-dimm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c index 3efe47f499a..68862926ee2 100644 --- a/hw/mem/pc-dimm.c +++ b/hw/mem/pc-dimm.c @@ -103,7 +103,7 @@ static int pc_dimm_slot2bitmap(Object *obj, void *opaqu= e) =20 if (object_dynamic_cast(obj, TYPE_PC_DIMM)) { DeviceState *dev =3D DEVICE(obj); - if (dev->realized) { /* count only realized DIMMs */ + if (qdev_is_realized(dev)) { /* count only realized DIMMs */ PCDIMMDevice *d =3D PC_DIMM(obj); set_bit(d->slot, bitmap); } --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891650; cv=none; d=zohomail.com; s=zohoarc; b=YTV6ejuWZuhBjlmOWxQ0tCxi5GRACluD9rVpqGtxNdpXF+3CPnA5PYpDV/WXuUYqTE8DY324Efj50fMmNuIgpMs6G/8Tg/JmnAzuEJ8gcFa9BWvFLsYa2UPGoe6aOxuc8x2QoDLe9kCfdbkv8jhUIiAxHU1x/Bw9oct3cAeGwjw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891650; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=F1o0vnS4K1J5CTBWre/XReXN3J0PT4Fz7RBqYUYDRoQ=; b=d+lR2EBS3XH/sn7YJfZd+E8RR1yHMcwwpMqKWK2SVty/G/TzWrqsVpZv6wAoRwtkbZc8nunrpR+2FMsFcTVPO7nL5ji+6EHudC9bdBSbJ3pRQoB7/kF5Z+59HElQ/IY863GFz5VuaNMrhxXx01vWH/FUYj4fGrthA4MyI2zNst4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891650160444.3280238820696; Sun, 16 Aug 2026 07:47:30 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvc8f-0001ya-J1; Sun, 16 Aug 2026 10:47:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc8e-0001y3-6l for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:47:04 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc8c-0000gC-GF for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:47:03 -0400 Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDlbU92761832 for ; Sun, 16 Aug 2026 14:47:01 GMT Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2h9gkh0n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:47:00 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8f0f45415cfso25628836d6.2 for ; Sun, 16 Aug 2026 07:47:00 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4999610e18fsm45234755e9.8.2026.08.16.07.46.58 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:46:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= F1o0vnS4K1J5CTBWre/XReXN3J0PT4Fz7RBqYUYDRoQ=; b=X5O9OS2JazrusWVU nyW9De2enRhZcWJJviZQvy++fcRLaO+IAX8+AmKgeda/kVgtku7oVoGt04ppnpX+ IEcx589jpPdD33B5PAjiDlNy5TNb7+vU1nqq3n4kvTAxYlmYQW6+mmD/iAO2k+Uc w1VuOjMAj3lcSl58ueAr0MRZNB33a0KvG9kjvjDdsuURFNRShAh7FZU85GGMsmkI dYusrngAFhreFosfwRlujvrDbyUJ6vawHjMbVz0H60QDVknx3SiJwljYCOWtLFys K2F7pxxrkpdrnPJciD4Z8myowXezELIYZV6yY1gHMKuFIJRk3bnePTjlE+oNeoA3 4X8hbQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891620; x=1787496420; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=F1o0vnS4K1J5CTBWre/XReXN3J0PT4Fz7RBqYUYDRoQ=; b=aawyFptfFatiCyc1ceHiDR2XQTCh0pcwk3eiJw62W5KgPNGyY2pf0oiZE4Hz2NUHYL qMmgyt3lm3GYP5MYgQCh3jvjIYNQWn+gJPFu4ldn2eTCJhYiA52NI6MfU2ox7Ay+pCr9 xjtqDg//VccIu1cEeXw+d9ktIwqGGywSh15kndWqD+28efXax1Vh0BwfmadT1tVw7KVT KC7Mw9V3MTHf7hZcSwgwfio4ZwLhAynIsgyLNnzdDpd8wX1kdIpTs/Ne7imLaykfL/Oe HqAjM3r6SPec8qkVPUewvHAuqdLeGpd5RsY4giVNIfEfT0SgDA69nrIkDLt3IGrntoyv 0htQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891620; x=1787496420; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=F1o0vnS4K1J5CTBWre/XReXN3J0PT4Fz7RBqYUYDRoQ=; b=fuMbHephU5DYtKf9nWo5xfKsi+o0LEn+iLJSXSCN29fnHWXy7XgLJWhjEAuDJUZQUC ADxr2Nx6br6OclGmiD7ucHv5x0Ww8ipHG+ImHn6xBzsAkzRXebWpEgVJif8Gp2FSQk9z EjRYupuKvysu1UZ5YHaP5RKu4wKVCyZaq7KCIyPZoG0JQCjkBnzXV1xW9lC0jyMLR5NN TEtHIPKzyJmmcqtbevocJH2/2dH0a9YjO4rI/k+jWeoVf591syPBvJlknBAq+uN911i4 YQK5qhSVUDga8U3swLJHgqGUOna9f5bIRJL7TfVtQYJjIX5OEyUMXrebpZhtxCWUq/W5 tiSQ== X-Gm-Message-State: AOJu0Yw2p9ooyF31r226olcEPGTdI3z3YtMiuD5kwHK3B2Y3wMnzrBuw wD6bu1/ZjUlowgdWaltK/a2CTbBzXVjnhKR1dJwzqeckbc1Nbtox1lY5Bgeqoqg1/TshX+/P5cs 01CVzkOjf7ANbuBPe5f4igmEx40W9OahveiO8PUtmcrGv0IBXs9cIMsFstpggd8lqKw== X-Gm-Gg: AR+sD12yrujVhQxAt6Hbf46sStMdDhcIFo96ywkevI8B3C+cVjlE2hrRvKG4lJOGnRG 5TIKZlH8yinodpl9xmA16dj4/6fjbBHbBX4APH4Oqszi60E2/1CuseA8OlBxCDR5zd+Xn0/t/vo G+0UHcbL39s8i9SS1ccgNrgnX3KBeaEYY8bcyRIRGkJyj7WlRV1jWvoquCFUk9Jj1WK5nKcZvxl NXQTFN0m0tKQRttfKjddIwT7ACjiby0fDRosSMbp3y56c0hRJb5NPdTkwPHZJnXJtoA4RU9lajj tAVJlUZ4ot/RNbIY37uIcxjX3ktWE9d+7dAqO+t5da8Aj16o0kt4CGL+yyBcHIJOmIF9QWvkE4W QM9beAyrkmKeuDLpdZOfyWDmcv5ERb9Cd19CRVch5Iw== X-Received: by 2002:a05:620a:170f:b0:92e:603f:1f20 with SMTP id af79cd13be357-936d2145adamr1574470185a.2.1786891619892; Sun, 16 Aug 2026 07:46:59 -0700 (PDT) X-Received: by 2002:a05:620a:170f:b0:92e:603f:1f20 with SMTP id af79cd13be357-936d2145adamr1574468485a.2.1786891619463; Sun, 16 Aug 2026 07:46:59 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 08/56] hw/nvram: Use qdev_is_realized() Date: Sun, 16 Aug 2026 16:45:07 +0200 Message-ID: <20260816144556.69009-9-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: uvJvuTtzaZ2T3K4G_TpG5QGrFFArVrZ8 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX1TOvPFg+tMbx 2puscaK/Y0oClEWX6/vh1eblRc4+8nW4ycDTpcecTCNiJYwf0mXAcgpdz8DMVt85twS5GpoSp55 ki0EA73pBVnrNa8iEAhNAjAXc2FD1EI= X-Proofpoint-GUID: uvJvuTtzaZ2T3K4G_TpG5QGrFFArVrZ8 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX+cr1UuaqLzOX rmZ4kLCOPcqZqM40dnp8Qr/YcdAElS0G0jYSsaI8PS1/a45ye50zx6P1O1jzk0faJA+8uqyuhPY 2t50s3/gLVT/5o5+2glUfADqvNniQDl3dzCVkgXOV79tUX+61Gn+HY3OqYhM48/2VNX0Dx/V0D5 4giKz8ClleMaEdlUGYUdmnBcVALxdKZom/+ayR3AQF3B0Msq0EyBx3JK2nZD7p+/LZhaOuJ9x/q X1UaKb6+IJZOC3dYqcr7N07Cc0HzEVwgeoM58coip5VANmiR/u3Cf/GW392JlMUwE9w0hhPkJKL OMQRFCDPv9ivkvIXPfsJOVLrtdMP74YS9nWZos0RHuJWhCRSyy4/wlJ/DCKn1MJ6OlVWkHxCD2Q 3obYCrjZx//RxEgkPtRoLiS8/jvdmdTktsZMUcOG3qjEWK3zP4e1Z/+Y8I8/+BNRgok5YG0KXO4 uD/8W0wH1gjJP7Q4grQ== X-Authority-Analysis: v=2.4 cv=XM4AjwhE c=1 sm=1 tr=0 ts=6a81cd64 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=uRxLgUfnyXHAhkBXUOAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 phishscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891652074158500 From: Akihiko Odaki DeviceState fields should be accessed through qdev helpers rather than directly. Use qdev_is_realized() instead of reading DeviceState::realized directly. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20260721-qdev-v3-7-d2e226fa002e@rsg.ci.i.u-tokyo.ac.jp> --- hw/nvram/xlnx-bbram.c | 2 +- hw/nvram/xlnx-efuse.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/nvram/xlnx-bbram.c b/hw/nvram/xlnx-bbram.c index edfb592a5ec..e336874bdef 100644 --- a/hw/nvram/xlnx-bbram.c +++ b/hw/nvram/xlnx-bbram.c @@ -468,7 +468,7 @@ static void bbram_prop_set_drive(Object *obj, Visitor *= v, const char *name, qdev_prop_drive.set(obj, v, name, opaque, errp); =20 /* Fill initial data if backend is attached after realized */ - if (dev->realized) { + if (qdev_is_realized(dev)) { bbram_bdrv_read(XLNX_BBRAM(obj), errp); } } diff --git a/hw/nvram/xlnx-efuse.c b/hw/nvram/xlnx-efuse.c index 1a9650ba128..03c9fbc0d07 100644 --- a/hw/nvram/xlnx-efuse.c +++ b/hw/nvram/xlnx-efuse.c @@ -233,7 +233,7 @@ static void efuse_prop_set_drive(Object *obj, Visitor *= v, const char *name, qdev_prop_drive.set(obj, v, name, opaque, errp); =20 /* Fill initial data if backend is attached after realized */ - if (dev->realized) { + if (qdev_is_realized(dev)) { efuse_bdrv_read(XLNX_EFUSE(obj), errp); } } --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891689; cv=none; d=zohomail.com; s=zohoarc; b=egKALXiY99i6xd7vrE+uSt11rtb2ODesxc0ik3nGBKRMkf/R+WE45TDkJxaH++WZ35DcvPeGQCZVGiBJPykqzeU+8iE7nFvp7t6Skxm+Z4qSD/WtO44qBJc6BryZ9N/juJ6kEqutNmZq4V+TzOGHbRyu07kMjRt4ChOY+LKhf+E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891689; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=ueiXCUBV4BeC382azPN6x+rhQstqJgU1/MI1GdQZNgw=; b=brcKpmuW08SjmKftrW/yZho19e0FYqtH1cMG5LXyGQib7m2Zx13cxVGGZwgfDq52Qhl2NYtgIA5uwjMVuiByORzjh+NUnLlMPyVMYJtYJXdlvQuOMU6yyf0hwZj/WZvxB0ohqmncDzFM5+Rq134LLgUBpxW0Piv4ehP9N/p+bWI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891689309937.4172206463396; Sun, 16 Aug 2026 07:48:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvc8m-0002Ft-Hp; Sun, 16 Aug 2026 10:47:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc8k-000265-Ql for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:47:10 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc8j-0000i7-3q for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:47:10 -0400 Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDkn912760476 for ; Sun, 16 Aug 2026 14:47:07 GMT Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2h9gkh0v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:47:07 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51bf321d786so36976981cf.1 for ; Sun, 16 Aug 2026 07:47:07 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4999611b043sm73665515e9.12.2026.08.16.07.47.05 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:47:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ueiXCUBV4BeC382azPN6x+rhQstqJgU1/MI1GdQZNgw=; b=T6Qaf7hyV2P/XV7t Lm642ElAvFjDuySPzUgDhzBJpZvZnm/8ZgcRoMUoZRi+dvsEjtaiWfmaStCf7hcc 8ZnqfAeBiybxqe2AU0g1lnWYCaC+yE31wpygf7FC+OPti+LdBxtJLBWcAQnjE1kr aj0ux+D4YgttEmLLJcXJ9vdt50/3wSNXWuTvmIKdSmu5/Uu2qqd2wCS4Itm8pxeF al8bzgPeEbMRiv6fD/KRivxLdwnf10eR/MaI8LSbSYdIVBulQc7B0GV5cNFDdIXI qyyK/WhOyAKJDSWbLfkI6Wbb22YvYLEh0DqzwWzxCyDNh2Xo+dUUQrkopswdnf1F xkp5IA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891627; x=1787496427; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ueiXCUBV4BeC382azPN6x+rhQstqJgU1/MI1GdQZNgw=; b=IypwdJoDBrrFWW1/o2LqAvv2NjHg89b90b98ydObbXMe6aXqdjhhxRMFWOrrmbQbth M0/st3u3jTTnCjgezpyfA6jsERlmwLWu+86orA6r8ksBWMU+BCHax4/s/MuFmx1cscfo ZzKQPDLnJNsA3wzLuaG1jmrjoM9f8S813RSWUbCwnj05lH08CeRnqo6dSoBTP/cSjlMB SqkPJxdVTV3j1wOX1ETqvTBVZyX9XcUDHJWt8iwmRgroi9Vch5aLRLMyKtYtVS5V4r2y C2hRDnW/81JJE0M8MrS7FqwTOgJOqB+KeqK7VsGZuK88rDXuRlx1F/TYJMTz1cMGPC93 v1Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891627; x=1787496427; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ueiXCUBV4BeC382azPN6x+rhQstqJgU1/MI1GdQZNgw=; b=n/Gb26G0xkw0au4pPH5dK+qtQ0+IhgJ3mgL0imDLoDfSiTCEKPDtuCWXc2/JKi9vid ekC512MiwgCWdna++d1nuENtm0SpEKS4ejjV/c678dns1YuZTQXwNSjWRzt4XYKHUZvk aC3iItWbUsixlgbqqENHRw9eVhhiw1yPX2O1eeoWE6a2h/jtGrvx5ZhQ09wX2+vJohaz zmyQY7t7WvrHK9WXWzLnV6M2Yzhs8wBHmdfXLOsd2CE4C6/4zufgE8BltC03Y03tm0eb kFIFb+8JSVk/nyJ9i5cQsVLKy3GHBw96VsHR9B5f8rCcXvuWNilY8cCZrEyK+QPwVgEl aeFg== X-Gm-Message-State: AOJu0YzrdwaTSi4Xru4oasDRxAivYdsZjhy1JrUZXaN3J8gHy3/tf+2s QHiTgRlqT9tsv+kIdvM1ym8LsYNVwPxy43RPi/OGJiljLhrCs3ZLYWSdPZaDflCnGa/MW6LBZEN 6xvfJSH7pmIYC1ARKAO12IQf7QKBVjinHjJBskfL/cmsDq6KdU5Knz1MozWjeqAkf2A== X-Gm-Gg: AR+sD13FONHnepxgXLNZznF17Endo4QZEiTU6x2kBaMnIH+lGnmNOIxyRXp6Yp/Yn0o yQegLxfunNIA9wKc90ylqWDCg8pD063X6T6ZHWiHtdPzgrtElhcBQjkgTyL6pVOywG9kg1MPUSi DpB1cP/emmGii28BmxkfRyaEY3e9wyWV/YX6evK623XD4bNwGfTGtaYdbTj7TZuntKjHc7Du5NZ lVeynButfMzklwXXYDmX5j8/MTfgHRZDQUIkskSMQS4eQSgFOKafBiDV3OJoDVfwJZ477h/Wd9A zDE5p8cpd2Gu+knjYDmd9iTOYB8RfdB7pNu7k8L9p/YPdg9NJfRxUoGdB+w/dLMpDjLSFNgNN/O OmqYSGVQr52B8mDTKh5LBGPy57qKgR9F74wBedtXynw== X-Received: by 2002:ac8:5f10:0:b0:528:1478:e1fc with SMTP id d75a77b69052e-52d854a4899mr190269491cf.34.1786891626674; Sun, 16 Aug 2026 07:47:06 -0700 (PDT) X-Received: by 2002:ac8:5f10:0:b0:528:1478:e1fc with SMTP id d75a77b69052e-52d854a4899mr190268981cf.34.1786891626144; Sun, 16 Aug 2026 07:47:06 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 09/56] hw/ppc/pnv_xscom: Use qdev_is_realized() Date: Sun, 16 Aug 2026 16:45:08 +0200 Message-ID: <20260816144556.69009-10-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: ixbPm3E8CFPtSJ1OGVNaDM99bQ2LdTEd X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX0SxJqagSEoiB n9TOSik1GxlxeFIcGCvIoW4s42+wj0Vt0bzZuv6WiLjcmwETYUFEyiIX+ykfNBsoe9qWjphS4e7 C2Dywi/pU2b/AjKcp84X+/FWdeHQqUE= X-Proofpoint-GUID: ixbPm3E8CFPtSJ1OGVNaDM99bQ2LdTEd X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX9uShXWQyJhME BkhWX++0XIUzqOiccQ9p0CGz1D9LHfeoZquH0pfWoltvgC+YVAOjQRPXvk43AcOlq7k2+KuNqLh Zom9lrk5jx60LF8aJNj4mBsa0S+eSfjsoHGNQPeZ9u7DRHMcFIwyPEvcKKVHw3k7xdfbEMWf7KC xtKRYvQ3n6XxgsxJgsOxVjaZaNAEpEDxWj3EuGoH0Q7UdsBs1zjCsEALurJ7htH77VDElYF6Q7W 9ercN5Ez3yuHnpym7lLOiMkw/zg/30Cis8SeR5GBxVKolxyq3rRFkwySpn0ckjC5hp/6HBaCfnW ZKobtxGHeq4gnS+gJd+rGB814kpuOAAOSb8fKAH1YMKtOFZGVKPu94qqcZBmStO8fAd2vGiXLGx UdIkdqroPZyWmkfGUwDacF/LaNxQyDqWu6RNT/RVGzB5eJCTvdXUAyeggX5HF/ipaOfozW28M1Y 5Z+rtKbvH69uBueayrg== X-Authority-Analysis: v=2.4 cv=XM4AjwhE c=1 sm=1 tr=0 ts=6a81cd6b cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=uRxLgUfnyXHAhkBXUOAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 phishscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891690236158500 From: Akihiko Odaki DeviceState fields should be accessed through qdev helpers rather than directly. Use qdev_is_realized() instead of reading DeviceState::realized directly. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20260721-qdev-v3-8-d2e226fa002e@rsg.ci.i.u-tokyo.ac.jp> --- hw/ppc/pnv_xscom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ppc/pnv_xscom.c b/hw/ppc/pnv_xscom.c index dc1ffc6c014..7af722584e2 100644 --- a/hw/ppc/pnv_xscom.c +++ b/hw/ppc/pnv_xscom.c @@ -253,7 +253,7 @@ static int xscom_dt_child(Object *child, void *opaque) /* * Only "realized" devices should be configured in the DT */ - if (xc->dt_xscom && DEVICE(child)->realized) { + if (xc->dt_xscom && qdev_is_realized(DEVICE(child))) { _FDT((xc->dt_xscom(xd, args->fdt, args->xscom_offset))); } } --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891654; cv=none; d=zohomail.com; s=zohoarc; b=RXzx5Dvr4du8Wwjkn8VNthjWVAUVt4v6d9MShPSEVdss0mPlrpx9+QLY/xz4FH7cUIC3XL5GcZouhtcQ+DIKQWVM/+Keuve5iTVCPVQiUWCRmJ/T2Z4v7LlCcsFkWJnEZDv7yyNWwaxTkUt39Ujv0PTZ6789DyiTqTsnLRss8TY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891654; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=xLTsNF4Soh7q8ru9VGONHPuB7j85hRYLW7glkBkqV5Q=; b=A80xrQxfSDdJDfsQMGnVAJ9ZpC9JhrYSVOKtqkkq98ZvaF9sQH26GbkJIA9JazWqhRP44VrW2YY/fPnOprh6GnDoZhmLRMfBOdHA93aE/Tq92CyfIMGE4fBBL8aZTJWQQ2a5mpdXyU4GEJVSFzwx5duxA2EzRfxrxYUKp7Pdo28= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891654053123.18047949450988; Sun, 16 Aug 2026 07:47:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvc92-0002zH-63; Sun, 16 Aug 2026 10:47:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc90-0002yY-48 for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:47:26 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc8y-0000jn-F5 for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:47:25 -0400 Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDki2W4142901 for ; Sun, 16 Aug 2026 14:47:23 GMT Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghwkkb0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:47:22 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-52d7b3adda4so25645181cf.3 for ; Sun, 16 Aug 2026 07:47:22 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f2c0a75sm24564583f8f.25.2026.08.16.07.47.16 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:47:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xLTsNF4Soh7q8ru9VGONHPuB7j85hRYLW7glkBkqV5Q=; b=I9xrfZxnz7O1Yz6P NYc+XP+2IWOCUYB4cKFz/f8dpA3yy18eY/CUGhbG+OjosN7Jhh3pKmVpy7KrmXA4 vX5HS2Y/xcZcQDmH/fDeKRISOrUUPYKyWc2PqGKNqmDgL2xw78DKaQbrG72pWnLD 3hdKE9gnLauvIehw4q854p/JUlIgFN8wd9Y1xLSBDE0CREL5A688WB+KAExn63zk Xc0SUCmVAqhuTUYPc7WzviMXqZbrTAob8n7spsqzySReFwONST1ZO5GHjB/+1UFN QLVr/YCIZrPyj2l1+7V+cizqdmGjljXmuOuaBgrrnaZ7GLMLz/iF8vR3ZZFl2TSJ GfW6RA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891642; x=1787496442; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xLTsNF4Soh7q8ru9VGONHPuB7j85hRYLW7glkBkqV5Q=; b=E16NIW0m9ZPnWPZ9rsdUh+YlywpD9izugtxtxHNXX4ED638i4IgJuvAknFm4m1Hfi+ CdPkisdH7OOwSS+yLe6FJdjFnlL+zfvNzX+YEE7NMgQGn6oQngypN/0mG4Hye/lP6kMC X7tR2BWpVcB9BPf7n1gI7gD9P1ihLxpi7+0+vaXmae9/85lJFNY/6Xm2007KNY6iZWru 5JL68mEd5SP1OrrXEN8IVnvyQyOoEyvWg4kI0G5NZenRFxlu7I+lazZpIitBMtjvaczz qAtfuCf05WZ2eZDRhJ0WHRmMNPawfOg8XIKV6xTiTY7/r5Eyt8fFSpFnbaILttwAG0mz 6m9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891642; x=1787496442; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=xLTsNF4Soh7q8ru9VGONHPuB7j85hRYLW7glkBkqV5Q=; b=HjQNkq2GEgtXi4usuaQCwWfO0FEkVNL5X7aWp5SqA2E8jez89GW2oN/T5NGcyfpcGJ 4tC928Ex9C0Qk+cSXcpzCqA83nU/NZlwE3WqFr+5Lq4WjJ9e7uVHrPbnOXDJ1SdBIi5N f3OBZRW7gp5ZOz+vjP23nX+++Nnn+f3VGDI/R3RhL45hxJCO9zRp5uSKbmbwnwaaUDJn 3k0Y3xrMjzSHb7p0hGX4YSQ35kIixZIV8DWdbsVXcr4goFipo+EtS3CuT3UJ9MXEDag8 uVGVOOKcm9NNT2jw/Tzdw4qiInp3J4qea86p6jdZiZBj1EmKaWZH0nnQA/CSr6PsZIca mjzg== X-Gm-Message-State: AOJu0Yy4yFNaggN3mJZpg4gSOcZ/d9jnzbSo54ZBMYbQuLI6cMG2XxdK V4R2wpq6UyJnzg/gy5gTSS2P6t97gXvhYfgnoiX1NQlpcVvsdycxZodzByNRp2OYj3B2ZAHXfyr i2HSKDj9q9AotPQYdnHeN4TilSxg5gSLYTcxJLlXrYb4EFSYmQXRI4KImVX2OpSrL6w== X-Gm-Gg: AR+sD12dOwQgMH3IklrJH8CFweBu7m+cBarh6P1MwkDjjJAWGstG5eT2eLZQgGQR5ct k55brQ7JtO+hetQwT27Jn92551aYjJ+bfC2AkE2joW0dhTdlRVHLw9R5jnFMkv6aSrr5YnkqGpp D0uvJ2pOb3RVk5+8rN24IQvxhjEYByB/gXUGgc5PGJdQ1RX/Ee8e9es8xuVG2PlaLDQwyigpnj9 p9SpqPFNFmTVKfaDzPn+rcBhjUpxWOZ6ozVCMb1jDTxG0tYW9CJNDdMBECvTbtTSIaWHNZdzGGp sMJZixwmjaVlpBih6QSAusFRlQnivKt6Ir+ZKHEp+PjQfL0C9oZGCL4yG0DD0x3kvQsoz1se1Bb iVXhjOxB2mf0CxcCLbLAQruW2rtPZ37KQK7jZo6Ubdw== X-Received: by 2002:a05:622a:2308:b0:528:3882:3869 with SMTP id d75a77b69052e-52d85341082mr209639491cf.13.1786891641796; Sun, 16 Aug 2026 07:47:21 -0700 (PDT) X-Received: by 2002:a05:622a:2308:b0:528:3882:3869 with SMTP id d75a77b69052e-52d85341082mr209639131cf.13.1786891641377; Sun, 16 Aug 2026 07:47:21 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 10/56] hw/vfio: Use qdev_is_realized() Date: Sun, 16 Aug 2026 16:45:09 +0200 Message-ID: <20260816144556.69009-11-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: jcpDGOAYd2TtYB8DGPmVp1XimWvClCt_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX0Cbgr2jWAkRh ub4Jl4n7dsPo1xrOUNdgovCcZFbPrFZNlELiXfwJluMB8uT5lGVtisoIVUxYKe5B+n0WaGfTQWP /W4psTSGfvYVrwfOBSbbSF7RqRdwenklw6Fx7B8U0oZVmoWIX2wPBzwdw4jjyoG3rvgoGKvUxQS hnMsTNFTNqHkH+l4SO6eIPYCejglBdiI4N6KRrNgLlsVna+nlvTR15NHnnp5roN8S2Sloi5mG6h ua/ZGyI8uf1OAzvIBhlESmTJ3nndiNJNw8jYdLsyviKiR1b1dmoGP+pcaFmv4ziZrPmKdx8te3U JHlqn5DUwzwN8X5iQDjwFJmEFsudnODzOJ2HtF6ti/bn+XoLoz6/BMJ1Qp9YPEzF6GK+q7SCbAm ZbgKa7ADkHdMEHgvR+jIoqrK64CUdrl0Ey6AYJ8DL0sb2uekfWmJwKjKr1+slr9tkSRyTM9C3Dx PGe4jQyibJmTHeLIaLA== X-Proofpoint-GUID: jcpDGOAYd2TtYB8DGPmVp1XimWvClCt_ X-Authority-Analysis: v=2.4 cv=DdknbPtW c=1 sm=1 tr=0 ts=6a81cd7a cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=bExcGYys6cyJo6IKf0YA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfXzmc/sld7HpPG Pz9MLXOm9kA8liecTMVrBQ4sWCjZ4os3u1J6ts9tOINC1xnEymTZG+zKwCadbHTK0elPzfNhcA1 1adcCw+EX4NsFcUif5mNeWG8OWCkaUM= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 priorityscore=1501 adultscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 spamscore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891656039158500 From: Akihiko Odaki DeviceState fields should be accessed through qdev helpers rather than directly. Use qdev_is_realized() instead of reading DeviceState::realized directly. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20260721-qdev-v3-9-d2e226fa002e@rsg.ci.i.u-tokyo.ac.jp> --- hw/vfio/container-legacy.c | 4 ++-- hw/vfio/device.c | 4 ++-- hw/vfio/iommufd.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/vfio/container-legacy.c b/hw/vfio/container-legacy.c index d301b27aa65..7ac7b372145 100644 --- a/hw/vfio/container-legacy.c +++ b/hw/vfio/container-legacy.c @@ -1075,7 +1075,7 @@ static int vfio_legacy_pci_hot_reset(VFIODevice *vbas= edev, bool single) =20 /* Prep dependent devices for reset and clear our marker. */ QLIST_FOREACH(vbasedev_iter, &group->device_list, next) { - if (!vbasedev_iter->dev->realized || + if (!qdev_is_realized(vbasedev_iter->dev) || !vfio_pci_from_vfio_device(vbasedev_iter)) { continue; } @@ -1160,7 +1160,7 @@ out: } =20 QLIST_FOREACH(vbasedev_iter, &group->device_list, next) { - if (!vbasedev_iter->dev->realized || + if (!qdev_is_realized(vbasedev_iter->dev) || !vfio_pci_from_vfio_device(vbasedev_iter)) { continue; } diff --git a/hw/vfio/device.c b/hw/vfio/device.c index 1a7f8088aad..4f119596336 100644 --- a/hw/vfio/device.c +++ b/hw/vfio/device.c @@ -59,13 +59,13 @@ void vfio_device_reset_handler(void *opaque) =20 trace_vfio_device_reset_handler(); QLIST_FOREACH(vbasedev, &vfio_device_list, global_next) { - if (vbasedev->dev->realized) { + if (qdev_is_realized(vbasedev->dev)) { vbasedev->ops->vfio_compute_needs_reset(vbasedev); } } =20 QLIST_FOREACH(vbasedev, &vfio_device_list, global_next) { - if (vbasedev->dev->realized && vbasedev->needs_reset) { + if (qdev_is_realized(vbasedev->dev) && vbasedev->needs_reset) { vbasedev->ops->vfio_hot_reset_multi(vbasedev); } } diff --git a/hw/vfio/iommufd.c b/hw/vfio/iommufd.c index 6ff668d2597..242644aa001 100644 --- a/hw/vfio/iommufd.c +++ b/hw/vfio/iommufd.c @@ -829,7 +829,7 @@ iommufd_cdev_dep_get_realized_vpdev(struct vfio_pci_dep= endent_device *dep_dev, =20 vbasedev_tmp =3D iommufd_cdev_pci_find_by_devid(dep_dev->devid); if (!vfio_pci_from_vfio_device(vbasedev_tmp) || - !vbasedev_tmp->dev->realized) { + !qdev_is_realized(vbasedev_tmp->dev)) { return NULL; } =20 --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891715; cv=none; d=zohomail.com; s=zohoarc; b=U3VNggaGDXI9aaJ+osZtTT8trPuN3palxp/RGEotrC3ltAvZijDYhqCOGNbc3x3IbCPpVMgNpTI8UMtWtpIxh+ulvRl9fl0uRzAwwQVyg1UQrRE2ezWTHwrd3OG7htd6B7MsvUsnaTrtfDzXxh3rMo08JuQf76nuFpBPxcdMk1I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891715; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=A9CsrQSlCyNXcPkrVRh5064XGBYvXQzeGZdmRaiZdAw=; b=gfN7pSf+v1IhP0Rzk4k63lAtKtCvT/i8s+YO7nwzscm82fIrZ7A1kdeARD0Av3gpZLsuaJlM+jqTV1V0x4INb4W9Y351uKlTis7hkqqwDGF51aggHlYRZguWTjlT9S7Kgj2JZcCSs9nx7N40qiLtn39u/bkubJfXdzrPDpLTHPs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891715362797.6611511476962; Sun, 16 Aug 2026 07:48:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvc9n-0003eV-Ij; Sun, 16 Aug 2026 10:48:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc9E-0003UZ-Uu for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:47:44 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc9C-0000m7-Sz for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:47:40 -0400 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDlJuO2399156 for ; Sun, 16 Aug 2026 14:47:38 GMT Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghq3nmh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:47:37 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51bf321d786so36981341cf.1 for ; Sun, 16 Aug 2026 07:47:37 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499877d7974sm146752755e9.1.2026.08.16.07.47.31 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:47:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= A9CsrQSlCyNXcPkrVRh5064XGBYvXQzeGZdmRaiZdAw=; b=Xs0tpe4e6d4x2Dlx ZwgOOTU/cMCMSU0oR8ixC3Qc9Eec+uv4sh2CXJ3oyMRskYm5W5eaCOhO1AtS63Nf X/1oSBq8Li5HIt+mry6rvWRI45BVCNCrBRgiG1qEY3vIAsHUupuiYd/TMPExjb5u VSTcJekg70LnTX8Zigwg7BK8GsRWLJWq9ucjs76Hz92JsP8oHiisp+R6ahyv00OM 8qQNvWBZVmDQ0EtQKrvZon6POdfRxUPEdDDcmwlHX+nbbY19WQjWY6+EsTKjYQUn zW7sr1XbfoO7GD+GOsIxn3ptfzIht6kwRS1Rd3LCvMONi3hHHLQL6WkyF0iR3PeW mDX2Rw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891657; x=1787496457; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=A9CsrQSlCyNXcPkrVRh5064XGBYvXQzeGZdmRaiZdAw=; b=i5dpMgB8XvJuZ4siQVo1LHkPNudvJkTa0mStRC+XkHKrIypEY5PN/PasIje9IqMYt6 2fERTvC8FKoAFTa+Qcyh4VmDJJqlYlzRc7IRe2Q/0XqQKbiLn55TXK91vnQ33ZEu+kI2 Xt7d4mk39vNAs7xbNZ/p1utsX+G2YGtIRERnqGw+5rbIwDz1uPbzxZTrHlI3G3iPoMjV eF3Yzb/pfA7sSlQWdADfH9/li/0KLUWbSxuKplo/0aGaLJR77t+XUqtBpg9XoitQbC5Y zOJuUusXb60xMcZwE5tiWl3cnsnpJqWraN8G2Lho65ulDnqFLRhC+AxYXVK/Kb82QpXJ I06w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891657; x=1787496457; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=A9CsrQSlCyNXcPkrVRh5064XGBYvXQzeGZdmRaiZdAw=; b=MREGsEet/yxhEgNYgbadHUpmcqiL8BuYVtrn3g+uY6NJPLc2Zns9QQLhCcs5p55N/t JzzsdwoNpSFrqS6oQlWa0RW+6X7coGkJY7tMbNTtjGgEst+9KO/eOM05xFVi9MVR5vWm ehsBpV5AXq/0cq6TRjk6TzJkOj2iIZnAMrLjWRO2VX26vDRvX4fol/imnJ5HGit09VG0 LqCmpbyfUtw1+q0LwKuVZjrLI8QZfzEWNGh9JDtPVRIrs+6vlNy2FgZ56y5L7l/Jyjw+ wtkUtSkkaR2Ww8iLQFHLeE3dE7clO0v8rTxYAIudd39YwSI+5EvrXbzThVUiCOyR2gLt ZD5Q== X-Gm-Message-State: AOJu0Yz+68g5+wFy/YKLsRyvw1kRMr7Skx3MOAT/QmLQPn7fo8tlf7MG rusQXrJOlunfI0Va+0NQnX/0NCfYX+I1CpBtFHpsHX5NA1uhxYQjLLcBgkxWl/tgBbIYMgf86bd LU/9o6u46M0q+Yt1MKrntzsXUCpgajZDXvV2NpzvZTrLCfU1401eeGDY8CTNcOO4m8g== X-Gm-Gg: AR+sD12ppJOEg4crTi2y/VmKbznsQ1BP+zQ7DmNJRv2odxcBOfF2/7DgDNWoze8qsU3 W6TZYjigGQM5aK0RS/SAmFsp+qKOH8Z+pJNJCyWjwgovc8DBB6JFiFgbrodF4mjZjn8P/zwnlUs DkbLBk18ze4gdz3bJib9cpqSBepgzYZbKl7Wj87FXKyrk+OTVysVjUN4K65YLFa1cjhXyBtkre0 yFz1LHHKmK757J2QycHXWTJmNj3PIoVP2e8kYb66hW/UqgGibVCkz+6DX1pgKtzTsg3vRDXQKPE vMYYqKJ9ZK8IdqG6PmCDRWGZonVs14FTsccAw0wkBn8Uji488vT1LuzgcaAS42E+7BvviekZ1Dv +JSYlELEjWYHbkrzBj6JETR/dzgJc7KDPV1MTmuRy7A== X-Received: by 2002:a05:622a:40cb:b0:528:38b1:b539 with SMTP id d75a77b69052e-52d8535038fmr211116711cf.10.1786891657154; Sun, 16 Aug 2026 07:47:37 -0700 (PDT) X-Received: by 2002:a05:622a:40cb:b0:528:38b1:b539 with SMTP id d75a77b69052e-52d8535038fmr211116421cf.10.1786891656702; Sun, 16 Aug 2026 07:47:36 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 11/56] hw/virtio/virtio-mem: Use qdev_is_realized() Date: Sun, 16 Aug 2026 16:45:10 +0200 Message-ID: <20260816144556.69009-12-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX4SH8JMbb/PdK gLtXd/D+AjMDWrLHWa/hvF/e6EezSanZMZglf3CixuCWHNSDxytgWw+krlnGCZ24YOJHNh1WaGm +/kU2nYOPbKR6mWqnOb8YEHZsNBxwHPGE2uU+nHMrm4bSiPplN2w3VloSO+y+Ekg7rIR2Bcf2Yu A2MUpACBa6J4nWk86kMo2stPCep20bYnTy1L0xQ0+dhUB9KXefTL4ZkgWyFSG2UTEL3JA5kypXW RvtEuU/UQj9GaS89nLy7XNZa+2XcZgO7HSXCGwRsJxpexU4XQzS94dfR7HGmXdLEPlIgC3cxbdj EIVs82PLQwmkZnT1savtdsU1S2HBzJ1QToypom+JsfWb2+aEQD3+0AVoIxL1AErnyAr/L8tX7yn 94BMF22wU2MetxhG7YKGDMmeCpWgqH4gWf40apIbGbPSDdlgVVrOVuGloHJ/0QKj+usi8yiBuOI drg860rrI19o8P4D6SQ== X-Proofpoint-ORIG-GUID: okZA1IRwjFg7eMb6VrNAuDUuE6Hjvtn2 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX0PHXH2/e8Avq kaKFa+kP2fpE3jYzKytpCP6F/SqvK+FBTmgVtQGCoU/df8IZ9CQ+nU8MT1UoQFBVtyVX91Z8p8E U+vnUGH5dvSIwkFhZZHr6ghdufaS00M= X-Proofpoint-GUID: okZA1IRwjFg7eMb6VrNAuDUuE6Hjvtn2 X-Authority-Analysis: v=2.4 cv=dvHrzVg4 c=1 sm=1 tr=0 ts=6a81cd89 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=uRxLgUfnyXHAhkBXUOAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891716301158500 From: Akihiko Odaki DeviceState fields should be accessed through qdev helpers rather than directly. Use qdev_is_realized() instead of reading DeviceState::realized directly. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20260721-qdev-v3-10-d2e226fa002e@rsg.ci.i.u-tokyo.ac.jp> --- hw/virtio/virtio-mem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio/virtio-mem.c b/hw/virtio/virtio-mem.c index 35e03ed7599..7130ed852d9 100644 --- a/hw/virtio/virtio-mem.c +++ b/hw/virtio/virtio-mem.c @@ -1453,7 +1453,7 @@ static void virtio_mem_set_requested_size(Object *obj= , Visitor *v, * The block size and memory backend are not fixed until the device was * realized. realize() will verify these properties then. */ - if (DEVICE(obj)->realized) { + if (qdev_is_realized(DEVICE(obj))) { if (!QEMU_IS_ALIGNED(value, vmem->block_size)) { error_setg(errp, "'%s' has to be multiples of '%s' (0x%" PRIx64 ")", name, VIRTIO_MEM_BLOCK_SIZE_PROP, @@ -1507,7 +1507,7 @@ static void virtio_mem_set_block_size(Object *obj, Vi= sitor *v, const char *name, VirtIOMEM *vmem =3D VIRTIO_MEM(obj); uint64_t value; =20 - if (DEVICE(obj)->realized) { + if (qdev_is_realized(DEVICE(obj))) { error_setg(errp, "'%s' cannot be changed", name); return; } --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891709; cv=none; d=zohomail.com; s=zohoarc; b=UsyDBBO0OEelQpQCXkuowYqyKL0tnVYkSawbM4QGySyruQH9U8vPezxAGxGZ48hLW/KcNizKWGx8tN7WLYBsoYjFkRpvvYlxEbOKcl/jJXepzMybBF0in4sumy/muNPUds5tcqd1FjXUJBfyzborOhhq+NYn2gk/s/XbpPvtQG0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891709; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=WsyTyGLBE911i8ZCFz6dOwdHRKi55jh7LQC39nPa/5k=; b=Mv7hUEm0hjgyPwo7CshAxMB9W2Z6uo3rrDY1Ix7UdT+cCZaVaXcumcMI0ZVucq/lPWrktIKJyAsUoL8L04tt8ynDTzyWLyjwKnKKqpK73BJ7tyOdLOr5YbyBkoajDsHA/7JM5MGf8o9bR3pj6mEnDaxDKS2+OlbUvlQBUpxjVZU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178689170995935.518175828830636; Sun, 16 Aug 2026 07:48:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvc9w-0003ok-6T; Sun, 16 Aug 2026 10:48:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc9M-0003bD-EC for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:47:50 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc9K-0000n1-Nf for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:47:47 -0400 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDl3b9481605 for ; Sun, 16 Aug 2026 14:47:45 GMT Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghfbjw7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:47:45 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-92e5e38fbc5so270150985a.2 for ; Sun, 16 Aug 2026 07:47:45 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f219e12sm22741435f8f.10.2026.08.16.07.47.42 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:47:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WsyTyGLBE911i8ZCFz6dOwdHRKi55jh7LQC39nPa/5k=; b=D1UM/pOIi0UrZd13 Ko2ipJQjh9AsNaxngJPphrsT+bzE2jo/cRo9iEmU4w7oq93PGJhsSwbz8TwHoBjO BrkrZ8A538f5RXlh2GkWTBwoUpuXM8EHUew9b4Zc/Mz/Uv26Fr+VGqKQgw0NHcFk b8g6i7CffSWAhFm0wk9IjfdDATigTYP+vH0EL6sNtgwKy0SCu2TfqjB+wVVPsrHM o7N28mUiSDLJ3yKSnxTrm3i3YPu0cSnaLERifL8SJ09pkG2Jr7JFZtVO5SLonLaR VZWnQhUlX4af0ga7eqK26QD3iNqSBDMo8xs9udRLAn5qghEOuWRRaSucKqNXiohP laB23Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891664; x=1787496464; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WsyTyGLBE911i8ZCFz6dOwdHRKi55jh7LQC39nPa/5k=; b=ITLVJglXCYJr6QWILxh7hUuODyIR6MiU5YJ5mJkzhBp09zEPFA37KEjbx+siaqTHkQ LFgM/fTwIpgsNBLHUy9o2zgWEAxsmxAOtx1XPN20wxi1+/P5YGa2dwKHnXFdBjVhvq4R ise+VJp01bTdw8MsHDcL2T7WlXQXABS7yw18Jq1mylHnaVXc7BffGQoD8cw2JYMHB92l fSYqRUmEuXVdUetlyUnEmBl4lIxvGFTGQQaBHJ7aLzQhFHqcfGNm3pbH5XfDNeKPQbh7 88dNem6qdVfxqRTkLsZWi3GNW1ObqgRqlubzTo3qX0SRPcdvr7llAh8T7XsMKy8sLvro WYaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891664; x=1787496464; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WsyTyGLBE911i8ZCFz6dOwdHRKi55jh7LQC39nPa/5k=; b=HH+1ewp9vh1NGvVBemEvpUn1tnzJDTG8D3aCwc3w9XMQuNpU6QN3y/d2tFshRgzBIs FrvK0gy4FTV4PTWBzEotw1rcn0JYmtsmggUlBaEO+asVFPJYblhbU4z22DdEvMGr2fzm ROClycE1EwNUVjRHh9XXg7tA2I1wwHFvONCbyoxTcP73X4tCZval4LbPQbHHTeVaIuA2 yh+YZeX9psVrJw+9Z+J5+8yeNv9zDHpyKwyeZt22qrmSVBKF2DB4iPFvZN8qPUp107Zw aeOLfEF8JMvhBESa9ITjz2w/wrBDC2iiSJ4m0j7Dx8iLc/boXwW8sVshA5oF/8HJw9u2 Qt5w== X-Gm-Message-State: AOJu0Yz49Tu9dJQqimE9ZqxApArXvURFi/RWohOHU5tl8oRHer2Itkp9 dD+RTfRQXLxvRC1nOQs+oqYOl5CF8NLNsk9bRD5YhVDVs4xwH610Hbq2wgh44boDb4ZMmOIoIc8 WSWQsdOU9pL+z1vnhNpSdo7ycGNJnpzRw02ZvPNzuoT4VmunMFEE+47QOCx/6mNwTjA== X-Gm-Gg: AR+sD1072xLCt2O29GA8E+uT6vFzQYaCq1RlDAjC0BqEv8cW+/+tIUIWfuX94UPjJAq uJbpr2/dXb0gcZT5N1EeyT0SvmmPPF20Lr3WQiCX1DBuTSvuO+iM5z3XEBNcZLhEBdsXktcY/go xytv1D+6hFwsmNvjHsEpH2Ss8HZ3ekuBhm45+QWpJ8/YWjsKoF/tHQw8IaXoyZqZKuXjJmXHoL6 ToUMnqT5fy1jT7F/tRrAaNeiEpMexQWsqqmDCrZslU2fT1fDlaKj4ksmEe7Y6V5RmmhkP1huU3C TbYe0Dl8PnU/CDTDcG1JQx+cbf8JQuqa793J9hSIge+WF58CLnHIR8Pp77Q+ZdLJMylQlt3+C4F 049XS3y2hXEc1G3mFDAhTCggt6SKsZVWwbSqEfYlqHw== X-Received: by 2002:a05:622a:1a81:b0:51c:f3:34df with SMTP id d75a77b69052e-52d8551ef50mr191582851cf.30.1786891664258; Sun, 16 Aug 2026 07:47:44 -0700 (PDT) X-Received: by 2002:a05:622a:1a81:b0:51c:f3:34df with SMTP id d75a77b69052e-52d8551ef50mr191582581cf.30.1786891663776; Sun, 16 Aug 2026 07:47:43 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 12/56] hw/virtio/virtio-qmp: Use qdev_is_realized() Date: Sun, 16 Aug 2026 16:45:11 +0200 Message-ID: <20260816144556.69009-13-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=OZ6oyBTY c=1 sm=1 tr=0 ts=6a81cd91 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=uRxLgUfnyXHAhkBXUOAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: pTo0UbK_e1YQ6swyfML6BEn7jJLFU8In X-Proofpoint-ORIG-GUID: pTo0UbK_e1YQ6swyfML6BEn7jJLFU8In X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfXz4QPilqCyaQj fBQnRFIg5Gg5Pn4NmXyMQK3UOvOHCC8/DUsCYIHbXC/8RPsIFkmNqefHN0wOVkID2CQIs6DFdlS FU4l9ICwm6aP1mtzBjM4LU+uayavWk8= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfXzYuCiEbD7qf2 W7nZrqpZnftB0+Tq9I8d2NPskABXoyXycEq3m+k9F53sdM1C97xGmwH99RsZqknFEV9CyOsOc3I bWgNQ4sSoaAaUqfpXbpvTWGoQy68r5lK7opJACX7gQkyz0MLDDAokH8rKrsPQV/G7O6bFvga/dL 5NnhDZhYSypazI9ugIEQqcH3279tOLJl6NsnBxmu/BlGvrcPJQtcRjWMalk1sWAGvDqNTulmzGu uYP0MRluJ7z41MzuMGZh83xzgNSFFJVTfsUQXGO+H0YzcC3rLbjIlBWtYlwkatGqslffdltOFDQ J7ver8nqMO2azlc1jv2091cu/XYFP+1dQVQEX+OukUoTLz2InSC1iCnOBkxPxNjiX/J4vzMlfH1 CmrUvqzpKSs5UiM7Nf+gHPTE9ekUFU+yeMgpYHzdp0o2WkzR+PWC1fdzVwI7Mw0px21LRk+E4il MaV2N0zk2TwS8jcslbA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 malwarescore=0 suspectscore=0 spamscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891710204158500 From: Akihiko Odaki DeviceState fields should be accessed through qdev helpers rather than directly. Use qdev_is_realized() instead of reading DeviceState::realized directly. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20260721-qdev-v3-11-d2e226fa002e@rsg.ci.i.u-tokyo.ac.jp> --- hw/virtio/virtio-qmp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio/virtio-qmp.c b/hw/virtio/virtio-qmp.c index 57cc03828c2..5aaeebdd96a 100644 --- a/hw/virtio/virtio-qmp.c +++ b/hw/virtio/virtio-qmp.c @@ -659,7 +659,7 @@ static int query_dev_child(Object *child, void *opaque) { VirtioInfoList **vdevs =3D opaque; Object *dev =3D object_dynamic_cast(child, TYPE_VIRTIO_DEVICE); - if (dev !=3D NULL && DEVICE(dev)->realized) { + if (dev !=3D NULL && qdev_is_realized(DEVICE(dev))) { VirtIODevice *vdev =3D VIRTIO_DEVICE(dev); VirtioInfo *info =3D g_new(VirtioInfo, 1); =20 @@ -688,7 +688,7 @@ VirtIODevice *qmp_find_virtio_device(const char *path) /* Verify the canonical path is a realized virtio device */ Object *dev =3D object_dynamic_cast(object_resolve_path(path, NULL), TYPE_VIRTIO_DEVICE); - if (!dev || !DEVICE(dev)->realized) { + if (!dev || !qdev_is_realized(DEVICE(dev))) { return NULL; } return VIRTIO_DEVICE(dev); --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891715; cv=none; d=zohomail.com; s=zohoarc; b=a1Er9j2WM6Kyu+U9UJn3IdPLmvMuVbLw04pzBM26FPnzunNjG7dhd1xeniIxyDGoVbIFRN6UfTLiGlma11zwASrdYBXjvbc+N0w6s78IFbx0Q7odcehNqy54qCjnaWlIhMBXD858CdQMwKM5/rXHQ/1bta347BJPMJzLMi/cNRM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891715; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=OKyYdzYjIVu56aOdfxczS6fQps4NfMHVNbL21hnnE00=; b=Wx4n8OQ7h9qYWxNRVDQjTAbhZA6kVWeym/e52R0bIiNRIMXv3fmWbQ4mZuyGIxQFs4fyiPG8Dhrrfoi3MVnO/c8rkVM+Tt080S6yPNh6cAq0MI7A+2Uj6zc208dDJU86BBMDRYb48ktkBeffYd7nOocTgaodVAbV/+EEWOIf71c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891715434435.9528863477326; Sun, 16 Aug 2026 07:48:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvc9y-0003rW-9Q; Sun, 16 Aug 2026 10:48:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc9T-0003d3-43 for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:47:55 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc9R-0000nZ-Oz for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:47:54 -0400 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDkuOJ3631485 for ; Sun, 16 Aug 2026 14:47:53 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghekq1b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:47:52 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e62e3459fso233043685a.0 for ; Sun, 16 Aug 2026 07:47:52 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4998ac6afe7sm128306665e9.3.2026.08.16.07.47.49 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:47:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OKyYdzYjIVu56aOdfxczS6fQps4NfMHVNbL21hnnE00=; b=JIzIFSQ5oYm6G0+d c8u4E9AcNkOw9OxFfy7eQpfNH6PiMc5SfDr9oCsBBLeUdrxOgsTJds2c3Bc89yob BEWLrZIzqWbM/o+9RNdHT5khZvOdZiMo9pX2/TCFeS3n4DvF5yNAr+Sb6E5AfWhE W9kg8ikDLxlTzYseoDhJNU8DKMN3zMes4C77isYXMKHTVebNx4hnN07OQCRN/fRv TYqg2e4KaG+bQXcPtE42S6Ho3+4oLkYZ6YMslBNv4Q/6QzclTVowPvcPLb0Uc3zZ Xe32HLexC1tFqh9wkGRKXetB+9+3kxu8o0HUno1a/NlBDmymHF6g13OH16iBbnjN 9fb1CA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891672; x=1787496472; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OKyYdzYjIVu56aOdfxczS6fQps4NfMHVNbL21hnnE00=; b=C5Mf1u6w7FRlt2UA1cdbyGGyohemTBOR77LobUcQJ26+y51JEH1pM8BG2W2gW8btDo e+u5/hssRCGcD4C+EDcHFe2FTqGB0SSyQpEMs5U1zjQ/DYAQf7urKAakJqKJBTheefeZ IRT6F47JolZNZgiLU7VFVlVMV5UouCTp0t0Arn+25XSqBO4Xk8V8bTd/v22SiEkM12qi zF0C5xukByZ0S07zm4/365ncy6QqSmIt94FtN7qxl+pqZESfXavGtxqqXKKAxvgfefzB tYCNBQLE75jloDBkbrBRKRydPT8uMgWd5/Xe6yLxgovQvaV66y+Fo8syVyFhifc/Z7SJ wYsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891672; x=1787496472; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OKyYdzYjIVu56aOdfxczS6fQps4NfMHVNbL21hnnE00=; b=LcX16YQT53mp50nDGVW82PcbqhtAjelhmlJijYTGOtuv8vuig4INY2HnQVpeG/ssvX jNWRx5ZvfSe8UtRoWn/w0jreEUDF47hbgsmyPVpgAVyrEK34C0/NJtFPL4W8fRD6dNhz hw0Y7brbcSm5taY6cBv1xsh87/41LBTnE7YofB2U6HLYyJ7N+XalhD0INVwbEfza0rof j1+3Du9cQdMyiJ24PoA8IICiUQT6YM+WcysQ3gt4+hUUv4NQAu8QefqOMHsWlzFYwjoE xdl0uGGp6d3Fyr/l7imCznYq9RUJp+OCNSnW0DXM22CSKUhU3irYq6s9lgMHBlcIGa3l u44A== X-Gm-Message-State: AOJu0YwA3gbZ9/WrA6fNBTupHIPpRii/c66DKDB6kkokBLeC6DEYeeid iJqVqFvGdVaGL/x/jtjsJe3hLDXDjBuruewxc1RTihz1sOsBMM+1NaC8VF7BSidd3mezva5UOJk f1R2uhMEMfP5gj2A/Iltrnfh5t6MbMxEDXZRsBmrIiKzKlmhQp2sCnJftv6H7QmkBjA== X-Gm-Gg: AR+sD12/yC8NONBerrHSQxuSAbrphG2XnArETRtvFBa7wEBDy0WYlcykf1swehPJVRy 0A9P4cRPAIoQ90xAnzgNWeDK9pt05tCxlrBqTsB80/BfOTAqShbdHixDBvwnGc3wpZT65SUXJcL 93Age78y+y8uegL6ZWW/zJXlfK/Z1UJ7u9i/bCRUI7jez/EoG4xmp/J2mAnnl1tQ0O89oUWlCHk h3B3NCfegcd4VCbohoLxnmBzU1StG3DtKdZ/mGU2lr8VxQLajaNarajxwnRPC81OOH4CaZ/eT2H agzig0NvkX440oM4FGlQaNy1X0/kDINxOUCcJMiJdbYibvfu4CacrmomHB/EYmJBVaSAvswE2S4 m8/vavN/Y/v32eqlbGjD/cK3VBEc7F+43NF0onqYVbQ== X-Received: by 2002:ac8:5949:0:b0:516:e0eb:d7d with SMTP id d75a77b69052e-52d85439fc5mr212723831cf.27.1786891672249; Sun, 16 Aug 2026 07:47:52 -0700 (PDT) X-Received: by 2002:ac8:5949:0:b0:516:e0eb:d7d with SMTP id d75a77b69052e-52d85439fc5mr212723391cf.27.1786891671810; Sun, 16 Aug 2026 07:47:51 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 13/56] target/i386/cpu: Use qdev_is_realized() Date: Sun, 16 Aug 2026 16:45:12 +0200 Message-ID: <20260816144556.69009-14-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=EKc2FVZC c=1 sm=1 tr=0 ts=6a81cd98 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=XWD-wEe3UW7fOdRgLHAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX0jJCtWPQ8rlo jn6iiy/jzOX5RBOZeuTaUJLsJMtOJ5PKat8MghKOCSiXzghDSaql6sdmSQEACrHFwe4CZMZ81si wyUAXnCxqKxAMKYR7/ujIpyEH46Il3I= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfXwF6uluuhxNmw KRLNxOEIDdD9MhP6X4b4F7bKelUrG0TZK6KpZaBxfJTCZLtNrVCTvFmkk/+APy6HQOWw4y+c9ic GL055mW8H5ZcYCJ3D4Em8gE490F2BaKnani15qQ/l3FWS6VJIY2zZun6mSEhKhMZ0FRSOjzZWjv yg/+TF9iFa0G8y82t0hyQqQywABM/5sKaE+jbyIijech6z1Q596YwneR7tyRyx69OYm7mRAa2x4 s5H0tfXcOgFwhMS9wvgw8tVillwHqhYFJOoS9b5mpCODV2o/GhF+nsiv9/1tHhfmpjFr46fwEkU WUB87/kCaxiNJIQbkJudEz/hXBc2LFMHAAYJQCxuo5Rzo2Q7gGlAwXA5sFxEzhM5buEd4PKtoCJ 9IoE8+zp19Ki3DXUGmsYgbxWTkyH29xOc4hN/4B5OOcU/RDvwhIlrlBnLynMjB9QNWweW+TyOsJ NVAnQboESxHyNQJowTQ== X-Proofpoint-GUID: okomQRWGkQFqgVfSGrYAkgvsw0vZhyym X-Proofpoint-ORIG-GUID: okomQRWGkQFqgVfSGrYAkgvsw0vZhyym X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891716280158500 From: Akihiko Odaki DeviceState fields should be accessed through qdev helpers rather than directly. Use qdev_is_realized() instead of reading DeviceState::realized directly. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20260721-qdev-v3-12-d2e226fa002e@rsg.ci.i.u-tokyo.ac.jp> --- target/i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 5805d33ab92..7a2c3cf358d 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -10387,7 +10387,7 @@ static void x86_cpu_set_bit_prop(Object *obj, Visit= or *v, const char *name, BitProperty *fp =3D opaque; bool value; =20 - if (dev->realized) { + if (qdev_is_realized(dev)) { qdev_prop_set_after_realize(dev, name, errp); return; } --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891761; cv=none; d=zohomail.com; s=zohoarc; b=JujNkDIgg8qsGIEaL9OOzgr/N2xC3iXmm2m94xWrfiTmirolL2TnAVJb/gCaD8EpWR+mK4sPn7QutVJcaLbA9VscbHuixHlyiUh1gXvFH0ZpI6hVVeYnDGakjpltU41HpJH4zUTUqftHLQ3rBVNM4a0tYfaUfi6UZh9/yE7Bx08= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891761; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=W6XLpQEYOSu8dtevCqvevES5FCDZtbRvU20Y1amii/U=; b=CcqqXz90hf3HdlZrTEWOmYBT92Jlm2kdr5eM3fdOILE6ZHw/cMVJsTGTNSAPPrgxaseK2bdNCN3WopP7uL6K9dYGUM2THZImlMc2YJeHip3EH79eiAdMQoZF8RvgKZ7aNQOEUq8KEGHzVaghzrNlMME4tDLClVqDuSjy34xNC6c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891761699430.18754065344626; Sun, 16 Aug 2026 07:49:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcAQ-0004If-Bb; Sun, 16 Aug 2026 10:49:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc9b-0003ep-7b for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:48:07 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc9Z-0000oR-Nb for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:48:02 -0400 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDl0EX3214626 for ; Sun, 16 Aug 2026 14:48:00 GMT Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghfbn73-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:48:00 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c1a97644aso30644611cf.2 for ; Sun, 16 Aug 2026 07:48:00 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49996127629sm48348565e9.14.2026.08.16.07.47.58 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:47:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= W6XLpQEYOSu8dtevCqvevES5FCDZtbRvU20Y1amii/U=; b=NYRka8RSspKu0iHt X1aOmkIZiSKjXbxyWek9FmzhKmZU5dkEuy2folU5W2hIQKKY/doPvAAnWIBrM7mz UJTOFMw77uV6p27CSurQrL9/RQTxB7r6mJxdmVxbXTgJqoWiV+uHq8aejOMSE+KL xNCK8CtPFG6ZnG53TKAei6Ay2FnCZRxLQceW0ZsW5z5h7iGKba1EYnp6FwbUir4E m6fOz9apUaSiiYKH059P8ng+Z5sD2HDMIF+2IKohTsef3vg4mNuqhTs5tjN+L2F3 JGzULR4yJILjPd/0/2uh/3mRvw5sVdGkoEHeIFmp3s99kFIYVAWggNHZO+nYIcJd q6EnLg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891680; x=1787496480; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=W6XLpQEYOSu8dtevCqvevES5FCDZtbRvU20Y1amii/U=; b=WhXR4eUngpCK+eETwNNhmDgBaFvYC0IRuKqIcmI54DRAurGNUuzFZvGLosZVCGZd6O pslDK2xpt6wD6bvm3vN8bxDcv1AHqkOtiNZTX/7Poy0jUpENJkOsxHy5A9nTx4R0aV9k IV58yR4kp5NqlYitAfRKuvkCA9023F2QdLdltZv6w+OEl+jIRvBvFU+1sTvGejadZHOF 5yGhlbAFxTqj+XDtCf16CYnaXKwO/G4lUUWGJ4NnHet96byrk+iOS2RnOCCyeLmKXAXO eBQp8Ih8dMF+MWto8botkawdVKeYk/zRK6qcB18nf47eCt7PvQzaOTOeQRTScy6nqIYQ y9WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891680; x=1787496480; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=W6XLpQEYOSu8dtevCqvevES5FCDZtbRvU20Y1amii/U=; b=n4DVEKdMBH30ksYaFHFU3uz50ExRI9iNPqXlV9Y70gekI/Q8EPZu+fFVIo0Xi+7Isx 3wPHSH7Zdm9lsbgbJjhKY7hI6ORQj0E/og8ATfNzF6YdC9wm4tAU1LUssvpHgWm72gCc yB03ZLCaiV47m3Ysst4TGzRC87DvHFd3U17/O24nWAQloZjNGnHsxc3wkNLNnC5cPcZR oEfwFgLc+I6ZMRZnyTQlH/MKiPTiBJ0DHE8qHJ4RJBCGbwmEwy4MTSNtacln7JvvPGn7 l+u6to19YWN89abUoKjVDGeZHOiZXKmgzF3GV5NuL2TjwzzegBhpWIsF92Ni2Q3T2aYm fc7w== X-Gm-Message-State: AOJu0Yy6Xmt0IjXQFw7HaiCIEoz1TREjxtr9c6Sc2Dhku80TVTCtFMl+ Cdeg3mpScs6TyXz3Q5W4TgwIBKkvKG43uE0E++xHsoDbd2wJzPZWrKqvR4I6bq6ZqTQTjLM6jBQ oW+vaxeQiMrLDG+9JF1gTwrzPFU+CI5cslBtC57XXYE5nmL0GDeI2bK8NAktq/N5vAA== X-Gm-Gg: AR+sD12v7LJbl++S9qsvn4g2SfPOnt/mrJRpXW3x6fGO3Hxz5JIEdpUl/59IUk1V+jB qh7QHgXVCwJKCevH+v1rWMpJGym9TB6xp4PAsaAbJPiFnSvBmqGoF4jQHNHojWQqSwOt9rGeXRm W6/N4oGUS7XSgh9WoW9UykYFU8jp9XX6aVVEDDyjGPF+VFg/rnBb8C98swNaoODKIOolS0uvTP7 mdvDgfGDVBmrqQ0UzkA5cm3v9nKjH1JM8VPlUPC+mmY75lgvEgP9mK7FihufmkoglAl+LJPCkW+ mvuQbYp6dTK3D2z0PuNJzHTo5s6f3CEZpLNI2UgDf1PG2sMPru3mBd865MT1KrBgDdHkthMiNed lxar7iAug39dgvQ+9r6lPPm3Uj316sadA6da6EqN8BQ== X-Received: by 2002:a05:622a:905:b0:51b:fb4f:afdc with SMTP id d75a77b69052e-52d853d001dmr211400891cf.11.1786891679903; Sun, 16 Aug 2026 07:47:59 -0700 (PDT) X-Received: by 2002:a05:622a:905:b0:51b:fb4f:afdc with SMTP id d75a77b69052e-52d853d001dmr211400681cf.11.1786891679511; Sun, 16 Aug 2026 07:47:59 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 14/56] target/s390x: Use qdev_is_realized() Date: Sun, 16 Aug 2026 16:45:13 +0200 Message-ID: <20260816144556.69009-15-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfXwzYPhHdvdGtr DKCrIoyTIbCopN270sLx1JplfpU/VtNMXXPiRgwEdpnwo56hRYJ6oBIwejHBNq2pKZWaz9pm5PE rcAu2ion6rC5zctTRsJP0/3RdVL6OaI= X-Proofpoint-ORIG-GUID: 2WFKqP7-DUjAU15LVmn9J79eeciZjSdS X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX1xFVL8VOtPn7 PsB2IEumGzAKi9r6r/L0uGS3axB0IevKiyZ40TmeHstUfHByNUOzSH7BP2FyPQ7UdiGv0PAzgYY +W/TTEOrobc2IKGS6Sz15NdJI3lQ1XQXu53KGSJUkCKjsAMrZNcLxg4zep2ZbzLo9Iexlj45RRA MYKMo66Hf2debtVO+FlN4gD0F+V8wGhrVinR4hX3/MznMheYg2d76j+nNN/tLrPZn/7deShU1iB CCIT5VJBk6/QChUPcpoZcfYZ8xF0rWUG7P350OZKluAe50DN1fGaJUn7g3SL8p7cl514UCYbnV8 fNeRP5wrucz0GQPqRmKI+RkA0jhMAAvBzyl9xfN04673DT5eNxkDV5Q57132heoskDZ7cBNUWSV mgzTvj0BlnBSkU94dajM4aM3xiUR0rKeG1SC0f+ZbaMPOlgiJN8Dtl6GA9VspshLe5iDd4cxiA6 8TVJ9S89vvknlCBMmJg== X-Proofpoint-GUID: 2WFKqP7-DUjAU15LVmn9J79eeciZjSdS X-Authority-Analysis: v=2.4 cv=I/dVgtgg c=1 sm=1 tr=0 ts=6a81cda0 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=uRxLgUfnyXHAhkBXUOAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 malwarescore=0 adultscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891762389158500 From: Akihiko Odaki DeviceState fields should be accessed through qdev helpers rather than directly. Use qdev_is_realized() instead of reading DeviceState::realized directly. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20260721-qdev-v3-13-d2e226fa002e@rsg.ci.i.u-tokyo.ac.jp> --- target/s390x/cpu_models.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c index 2dd9aac8078..f292af7ad01 100644 --- a/target/s390x/cpu_models.c +++ b/target/s390x/cpu_models.c @@ -714,7 +714,7 @@ static void set_feature(Object *obj, Visitor *v, const = char *name, S390CPU *cpu =3D S390_CPU(obj); bool value; =20 - if (dev->realized) { + if (qdev_is_realized(dev)) { error_setg(errp, "Attempt to set property '%s' on '%s' after " "it was realized", name, object_get_typename(obj)); return; @@ -770,7 +770,7 @@ static void set_feature_group(Object *obj, Visitor *v, = const char *name, S390CPU *cpu =3D S390_CPU(obj); bool value; =20 - if (dev->realized) { + if (qdev_is_realized(dev)) { error_setg(errp, "Attempt to set property '%s' on '%s' after " "it was realized", name, object_get_typename(obj)); return; --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891815; cv=none; d=zohomail.com; s=zohoarc; b=l+lP4iLoXK/5gjP2ZEB7xUpIU7Qux2IMOl+wRc6t5m3okLZwVblRDHQP7LV3az0ZdsMZXgtVctgjeay94e91ZnauAu/+64t7L1uQjw0xykFDc4jjRF+k7Lxwf7AzhhhwvW09GhXUkP6w+bXumfFCy9d/5chdWK1MUiGKfZVtQ0Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891815; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=4urKzUAK7zcqqmt/YphZ0AATkO45ouEjNEl3ivUIsm0=; b=aPp4YIx+5Dp6JJFf1m5oRgcbUDQ80eAkCS88VDEjQLk4b03FSRrUQke9W8HiRmqTQp2hyfwQxoTXEa9CQLA2L8H7QFUaD7L/4BHEXrniqTCrA9M9RCJdXQxvvKJd0NLesW80BEJMsPuBFA1yvHx/ZZL1E/xecI+cqWAcO7cxbMU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891815242956.5510419273421; Sun, 16 Aug 2026 07:50:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcAl-0004dK-SE; Sun, 16 Aug 2026 10:49:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc9i-0003o5-N6 for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:48:15 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc9g-0000op-PD for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:48:10 -0400 Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDl09k3532565 for ; Sun, 16 Aug 2026 14:48:08 GMT Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghf3mfq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:48:07 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51c1b4d961dso23443381cf.1 for ; Sun, 16 Aug 2026 07:48:07 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4999611bf65sm47666255e9.13.2026.08.16.07.48.05 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:48:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4urKzUAK7zcqqmt/YphZ0AATkO45ouEjNEl3ivUIsm0=; b=aQ2+0lkhFxQISUk4 28D1/autiS/GZE1S/AT1eFJhgxYvEIBGJtD1R3pyT1n+cuhk2Tzf4Sd3fKc6Ss+N AMNVtkUimbHlvyF1ssdS4Lqm8wn55G4KPDqU7Crfz73LQt3Z1PPTU/+Xv6PqJu6Q kcddA/OXxIHqg7UkCOVLB+Y3mrqt0OHIOZTI0frD0Ou+pJJkLqU6LgELQUPQ3lmG iIvyuN8t2xeP+C2DzyRGHyIGvdTuVR/e0LonkP9nZSPdtJhWoPH6+Xo1Xl0RSVCx cvQCtMrtfng9DN3gU4yvBexjuJZ/IwgKv8eLIsVPUnjRWZCKQiBqY/nWM3Wst8wv q9Mu2Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891687; x=1787496487; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4urKzUAK7zcqqmt/YphZ0AATkO45ouEjNEl3ivUIsm0=; b=Pm+0+j8m7TTYVPW0VpkphRUk4QAyTTzGfs/BU1K8eTPfctrFVk/xnjF5lTHFm3Dc3s YTUCQs9Xht9VhJyRIuvO1CAygiL9loUR21AZEEneKDvphXrfp80Y8n/0H6DMglcHTAgM WXPMSGJI2Shin+5yzQznLK5IKKgrrZg2LewPtc8mCXmW/rTCjyYV5AJHE8bQiJSX2PY3 9/m53v2TGU5C8Uz6Edy66IuyFq2iDFuRqRZc/+B2OqCBi7wcd8sCUYd6e+vObJSCkuht 8p0DTyvRsDHPtXlzXwkBlDOYi4VgKIjUm3Czej0685v3HW5SJylONDleIHYfZq0tfMm7 bBKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891687; x=1787496487; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=4urKzUAK7zcqqmt/YphZ0AATkO45ouEjNEl3ivUIsm0=; b=IZkTbWUK8oxrq+qAGrobAgETvepyCNQ5iUZhK9ApP4JmTu+/A2XFP16DHw9Pkz8sVL ooL728YUhDKrni55fMACgrga/imdGLOys11nBic7huwJP38K21FeCK3D2ngT+WcXCr82 6ZS/O0bQEsuUCRAZ8oXMTZKGyqY9Lq3nIvfGEGSeLHi08kz/EfzLlJg6kW7EUKgrVLmP UfwFr6Ba+QhQXEq5biIebFZzMBdZQpeEf6EsgjE4a0HeXPyjjDH6sShgZE+xmcdDP6G7 6rbm80T3ppeZH9X6ZBIKo83rSdTDo8vuMIUlV+uOO8K9bdK78z6+0ynhw0S9t7Am8dpY DIQA== X-Gm-Message-State: AOJu0YxwhXdVHaAVF7n14ctE+vSJIkJsMFkkuo6bDmahe05lTgqvc4+O voBSeS2Rl0DwnVf3uPR8Fyt0KNFoEOT2c2FxkPWnlH6WV8oUt0zcKi9t3ECplAbODWzZs09x9+z Y3GWXkf+KRLH07GiBHj0nd/sDAh4leTK4Oq6VcVYzLLPwVBgEWobCrQ4s1zimjBqp6g== X-Gm-Gg: AR+sD12KBhYJ0qsh+vButEOGbJMFZYUUE09ipv04bEr/MugzVOn1CVetVbVWWi+qI6m CVb4Cytr+NLLBwoXzKQs32gDl/TAr415oJYVtPkqc05BMdzQH3usaKF+cTHgdJFbFGiMAklNIUR 6fXhdeE4kYE8WOSwSQa119Qe4gPN2VpbTAmQ3cpV2x549kXFLABmc/IXX6IdircHI1Also+MsRj tuFORVK9Psm5KxVm6vWz+NL4BY8UnxKfr3SL7MfGoFPE93Yi2G76N9L8yjWS1SuqhvUQqgqMDpJ b11FVXS11uDnLqEoquyQDt+otZr/vhH5rgq7GqQopHmUuYRC0EqlKo0WeaF7U5jGA8b58UgEv3E iRq8AZlQUgBxSHJ9eRLvjR65dVFD+QzTVTz8IXlBszQ== X-Received: by 2002:a05:622a:250a:b0:517:c65c:4987 with SMTP id d75a77b69052e-52d74baa1femr319052291cf.22.1786891686869; Sun, 16 Aug 2026 07:48:06 -0700 (PDT) X-Received: by 2002:a05:622a:250a:b0:517:c65c:4987 with SMTP id d75a77b69052e-52d74baa1femr319051921cf.22.1786891686398; Sun, 16 Aug 2026 07:48:06 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 15/56] hw/qdev: Parent device before setting parent bus Date: Sun, 16 Aug 2026 16:45:14 +0200 Message-ID: <20260816144556.69009-16-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=QsVuG1yd c=1 sm=1 tr=0 ts=6a81cda7 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=jOmSDqYlwVm5XPtxtUUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: 26-2n9bmBylwry_-kh1TAdPBiO6TFrzd X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX+8FvqX0A7XCd HNYI8VdPN0FkeaONvHLyY+Lo/WwIdPrMEp4jcAv9Gje4KIiy9QeRcPdiPrH/LQfztqaA8Np2ew1 qjx5iz3bkvTCinVsxC0lDNkvdvyNIL/Jr9+6qWk7W92vFCMdvCphjqTKjltlceo+FAA0Qgz2XRq oEz4RjFsOTUAyA/g7W4L18XpLTSD1/26YoV3piIifuHrxzj3rdoX/gEB4dlKU3ZcX6bXHbOoqNH cDeqgbrSiLLZlPfc0HIrn4cukLsmu+EioBvRfaDi+4zxKJ/Hn+4OgQuL1q0N9fBQbp9ZaBRXSqw 39PTSrrT121IFf3BJ8/LPa86lHYpkxfGmZlnqFYeT7p9w9zIG6RRLwTmDHSAngUyzSqLsN8mARz Ltcx0eG8sDSNFou5fKVMmHQHYNl5qNKetr/YhR/eAZc0g9dLTEtz58WKUaCu2ELV4QUEDnihauZ ZvYdo+iLAtN1wEZpHEg== X-Proofpoint-ORIG-GUID: 26-2n9bmBylwry_-kh1TAdPBiO6TFrzd X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX12y+v/rNTrRK +2aL7WEhZ9eKCNw/Orf79u3P/PTXjPMu5GtLUOLbOyZbfIhZeSLU7Eg5kDylmsY7ew7M71K+lW3 lYJedniPKTjgevJ6Gtz/eBQyc+saLgs= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 priorityscore=1501 adultscore=0 bulkscore=0 malwarescore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891816642158500 From: Akihiko Odaki Commit 9940b2cfbc05 ("qdev: New qdev_new(), qdev_realize(), etc.") says "device state 'no QOM parent, but plugged into bus' is dangerous". In such a case, unrealizing the bus will hang in bus_unparent(): while ((kid =3D QTAILQ_FIRST(&bus->children)) !=3D NULL) { DeviceState *dev =3D kid->child; object_unparent(OBJECT(dev)); } object_unparent() does nothing when its argument has no QOM parent, and the loop spins forever. However, that commit did not completely eliminate such a situation. When the device is not parented, device_set_realized() lets /machine/unattached parent it, but it happens after setting parent bus. Therefore, any failure between the two operations can leave the device in a dangerous state. qdev_realize() at least asserts that the device is not already realized and prevents one realization failure pattern, but it is not comprehensive. Besides, it will trip with a command line like the following: qemu-system-x86_64 -M none -nodefaults -nographic \ -device ipmi-bmc-sim,realized=3Don Eliminate the dangerous state by ensuring that the device is parented before calling qdev_set_parent_bus(). Also, stop asserting that the device is not already realized in qdev_realize(); it is broken and no longer serves any purpose. Fixes: 9940b2cfbc05 ("qdev: New qdev_new(), qdev_realize(), etc.") Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20260721-qdev-v3-14-d2e226fa002e@rsg.ci.i.u-tokyo.ac.jp> --- hw/core/qdev.c | 51 ++++++++++++++++++++++++------------------ tests/unit/test-qdev.c | 13 +++++++++++ 2 files changed, 42 insertions(+), 22 deletions(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index e2aab3d1fc6..0b0f2f47fa7 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -264,17 +264,43 @@ static void device_reset_child_foreach(Object *obj, R= esettableChildCallback cb, =20 bool qdev_realize(DeviceState *dev, BusState *bus, Error **errp) { - assert(!dev->realized && !dev->parent_bus); + static int unattached_count; + bool unattached_parent =3D false; + + assert(!dev->parent_bus); + + if (!OBJECT(dev)->parent) { + gchar *name =3D g_strdup_printf("device[%d]", unattached_count++); + + object_property_add_child(machine_get_container("unattached"), + name, OBJECT(dev)); + unattached_parent =3D true; + g_free(name); + } =20 if (bus) { if (!qdev_set_parent_bus(dev, bus, errp)) { - return false; + goto fail; } } else { assert(!DEVICE_GET_CLASS(dev)->bus_type); } =20 - return object_property_set_bool(OBJECT(dev), "realized", true, errp); + if (object_property_set_bool(OBJECT(dev), "realized", true, errp)) { + return true; + } + +fail: + if (unattached_parent) { + /* + * Beware, this doesn't just revert + * object_property_add_child(), it also runs bus_remove()! + */ + object_unparent(OBJECT(dev)); + unattached_count--; + } + + return false; } =20 bool qdev_realize_and_unref(DeviceState *dev, BusState *bus, Error **errp) @@ -479,8 +505,6 @@ static void device_set_realized(Object *obj, bool value= , Error **errp) BusState *bus; NamedClockList *ncl; Error *local_err =3D NULL; - bool unattached_parent =3D false; - static int unattached_count; =20 if (dev->hotplugged && !dc->hotpluggable) { error_setg(errp, "Device '%s' does not support hotplugging", @@ -493,15 +517,6 @@ static void device_set_realized(Object *obj, bool valu= e, Error **errp) goto fail; } =20 - if (!obj->parent) { - gchar *name =3D g_strdup_printf("device[%d]", unattached_count= ++); - - object_property_add_child(machine_get_container("unattached"), - name, obj); - unattached_parent =3D true; - g_free(name); - } - hotplug_ctrl =3D qdev_get_hotplug_handler(dev); if (hotplug_ctrl) { hotplug_handler_pre_plug(hotplug_ctrl, dev, &local_err); @@ -627,14 +642,6 @@ post_realize_fail: =20 fail: error_propagate(errp, local_err); - if (unattached_parent) { - /* - * Beware, this doesn't just revert - * object_property_add_child(), it also runs bus_remove()! - */ - object_unparent(OBJECT(dev)); - unattached_count--; - } } =20 static bool device_get_hotpluggable(Object *obj, Error **errp) diff --git a/tests/unit/test-qdev.c b/tests/unit/test-qdev.c index 20eae38e03f..77c3eee7171 100644 --- a/tests/unit/test-qdev.c +++ b/tests/unit/test-qdev.c @@ -78,6 +78,16 @@ static void test_qdev_free_properties(void) object_unref(mt); } =20 +static void test_qdev_double_realization(void) +{ + MyDev *mt =3D STATIC_TYPE(object_new(TYPE_MY_DEV)); + + qdev_realize(DEVICE(mt), NULL, &error_fatal); + qdev_realize(DEVICE(mt), NULL, &error_fatal); + object_unparent(OBJECT(mt)); + object_unref(OBJECT(mt)); +} + =20 int main(int argc, char **argv) { @@ -90,6 +100,9 @@ int main(int argc, char **argv) g_test_add_func("/qdev/free-properties", test_qdev_free_properties); =20 + g_test_add_func("/qdev/double-realization", + test_qdev_double_realization); + g_test_run(); =20 return 0; --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891809; cv=none; d=zohomail.com; s=zohoarc; b=LMH7QIx6+C2uSULbpLL6bCHe9W6A6/qSkpIEYFffMHuy+IBd5wlmghaQoBzbNmz6oh5DjgfruxkpmBaHDFq81ThRR5bCGkB/wC5A+fkAGY9Wf/Zii8cAHdQTW1mh1Cd0eH5QBZCPH17AjfWM8HNfDU4M5n1+1J8JBTGydVomMHA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891809; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=78vNviaIAMo9FvczfotLXJJ4EhmR6DTr8heZBxnjUrA=; b=LHGI6qQw3XzEpMOkn9PU/8jF9p4V39WpRRnm5dlxiDp46O2OaTc37yEbMY7wzoH4FvI35AUF2Wmmpp7Em5jDSOfcb3XtXQwRi01Tva3ASAwIDSv1wt3NfggXu1UrcGpl7EF7JjHpKA1KElmVhGDfieTArJV+klEGx2G6OSJDOYY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891809357578.4982157205934; Sun, 16 Aug 2026 07:50:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcAp-0004uK-4W; Sun, 16 Aug 2026 10:49:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc9o-0003ov-Bb for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:48:20 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc9m-0000pG-UF for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:48:16 -0400 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDlFNS3449940 for ; Sun, 16 Aug 2026 14:48:14 GMT Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghk3msk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:48:13 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-52d8243f1bcso26270561cf.1 for ; Sun, 16 Aug 2026 07:48:13 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49996176b8asm45651385e9.11.2026.08.16.07.48.12 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 78vNviaIAMo9FvczfotLXJJ4EhmR6DTr8heZBxnjUrA=; b=VJSw3syvGZeLh8+F 6lxAMXIY4jXxs47KUL+z7OBj7dzLSvuIX4ZnD19Zjwd9YvPDqbxeMQBAClx9EMEl XiPDcIPA1IJvQRAkzytadp3juB+TbSGaGeNCYtYC7WawzW2IXsJibRn9V++a6+dy Yx4OwznCCwDwh7fDo1laonWxSSb7Z6PGSqC2IBcKS3zZfQedTBjSUtf+UgCjUFAp TduQCS12D7pii49Dhm4/AGA82MVfSXY8ZOgE4i5lWy9hysMNOEbm2HXf7PNVOny+ IgkXQ8raONBuDTyjafSN6sVq3Y2AMVwJznjh86MrCUV2vQoeSxqFpxdWhAj70GFH YwNlgg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891693; x=1787496493; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=78vNviaIAMo9FvczfotLXJJ4EhmR6DTr8heZBxnjUrA=; b=Vi8lwx1QmYGTQh5131BgeMeqVJXHihk2f/zHi3xy0yamSa4+MJnlIOx38j9apDNR4m hi9Cq/OgmrHDdfw1/Fk2akbLVO9Xbtl9hXeqe0r2o9MzEfp9Hv2aq9sjNu9588bR+poI /dzoXBe6e+Mv1KndqIrwjDjlbbbzrc+NlihByEZsekPNAO/MEEtT5cjyyonAEYsCdh5W oy1xVIehRVfKCPVjpVtxNhEjenlnXyZRsYSSG8otP8il99KwtHPKd+EzLsd1Q7rebbgb mxosLSvyoRPgGxvs/1PZdSSsk4S/mUYR9NrwKqTrlQv8ppRLIUDWrgZelYCNZXC+qR8m ThZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891693; x=1787496493; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=78vNviaIAMo9FvczfotLXJJ4EhmR6DTr8heZBxnjUrA=; b=bNEXl7TXcvlPsWGbXbZPCjYGsdyM8w57rCz5/jGft6b5MvW3QPrEJahVnbHi9Z1OJ7 RCsHIr+Y/2X6l51TEqDay755HnJ7BrIgGQelhuTi/wNJnIDEPP8pr8Bv8precfdX0LXw dlq/EtRu/ATlruq8jXa3EVNGCXHtLqImwZlJ2SD7NVmPDqs1dUHelFKvR0AswPvPSuvU wq1ICqr072/tPyMOBwr6ANnANQpJbyYoUwjie7DoeALCFkxmZhON52ihtgH6V0aHoOvf AIRt3mbJ0Lidq2xBgi2c0woOLWb3GApta+6QTZ9p1JlSlNVQ/tbEEvZV3Yotvbjll8Q3 MUxg== X-Gm-Message-State: AOJu0YwNoyJxVRk6xyeE640mQEvdVzWrCNsQV0YvunFpGZDGL8xAvv9V pyDVc4f5MPg7eY173Olnwhof1zi7vitKeEpM+uhDebX8PQCpAnt9f4bH6ZSmkbqy0j0tQA8HPMA hWKE2BAJUWLPFQBQzB/V7Kb6P/JnpkvNmOgkJMbSef7ttdbP6Qcz880SfrqtWqihH2Q== X-Gm-Gg: AR+sD11Ga/u5tXU6NC9Eg7MVSqnE9U5RcOSjj+bTv0twMBTnXsrdFvkrRzkhb4ln43M HzXggnXBNy+Bmay7SgTSKUXGgFMOnBIPy6FIPsXgefIqO1tB4qD5WVfOq7DychDPjnfl1pkfmHe k9/HfgulybBkQvWDvSnQsUIpGu+VjPdU7AI2LcvM+amFwF017LrIVuBzx9HlqnQMtSbrxgHuh1W mBCx89q7DsENKNNh6gkiIZMLjYre9g/uA2BkDJ4smE5sum0e4c25aJylwRSZwZWObLDci4fSM+N P+ftx2ncS+yJX4JU7/JJyigMTmjsT/IP7Z7i6HTnYxb1+p/ao62k6dMFMVtxUVqfz01deCE0mE4 ETtosAvEYhyzgT1fFDWfzu9+DcGuufz6mfXfHEAP9Dg== X-Received: by 2002:ac8:5991:0:b0:51b:fb5f:b263 with SMTP id d75a77b69052e-52d74a356eamr245378861cf.4.1786891693472; Sun, 16 Aug 2026 07:48:13 -0700 (PDT) X-Received: by 2002:ac8:5991:0:b0:51b:fb5f:b263 with SMTP id d75a77b69052e-52d74a356eamr245378611cf.4.1786891693075; Sun, 16 Aug 2026 07:48:13 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 16/56] hw/i386/pc: xen: reinstate the "xenfv" machine alias Date: Sun, 16 Aug 2026 16:45:15 +0200 Message-ID: <20260816144556.69009-17-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX8GrLx0hCgD5Q JbuYL9ZL8SvoKJ1aKiQ2P20H62XXiMLrQPm+wQIeeAyjPDfoRCwZ5NqTo9bY+0pMiumtA0g7eU8 8udmMEQ4gVPXE71SbGaAVgNYumutC9U= X-Proofpoint-GUID: LyPLNaLWZxK_G-ZbRX_LOpyBdAo8ziio X-Authority-Analysis: v=2.4 cv=f+14wuyM c=1 sm=1 tr=0 ts=6a81cdae cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=iox4zFpeAAAA:8 a=69wJf7TsAAAA:8 a=20KFwNOVAAAA:8 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=VkxhiMxS3_JPjbmP7UUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=WzC6qhA0u3u7Ye7llzcV:22 a=Fg1AiH1G6rFz08G2ETeA:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX8USxbxIM2o/p 1Mbp0PPe+c4cFoCmo+ERJJ2DbW8TSGHVrv2N8+tVUR+iQsnvoz3PgudwSP1paReaV8/eCsoxRPw LYG6OAMdOCNNbE3AreTqIW4KAcCfbMA51LYTrWSa3BgJGxsXZYpbWXKvJ78t3Wl4GALzPNLBa88 jJMiGok7h+mGaMmTIljzwijZj8rMJNIArJVl4+Uksm102kVzG7HmQBHoTD8oIpPqsjzO+dzQtCY eggttQlfWolMLNbL+g8M3LjqdV9XbxLzw40FCCG4KCJDVttVEUnn7Hpq3w2yPNyFqjHqeIJIaAz ja1cIWj8269Keb0d/7r+Kz4mxDoF+gAXJ3h+/4wk1gpWk/6cEADfy863jhBIEizxQSlXYKYD3oE bRnAmYa0YNvXZLjTClKTzZ+tmQnYjpjSSF1lIX8pYKg1FHMaewqbSAXooeNNkkRNPmbBaMhj8W5 FBosgwT1vG4EUjVsPCw== X-Proofpoint-ORIG-GUID: LyPLNaLWZxK_G-ZbRX_LOpyBdAo8ziio X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 suspectscore=0 bulkscore=0 phishscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891810557158500 From: Dario Faggioli Commit 7d2778dea32a4924a469f1cc5767042c8f5b4eea ("hw/i386/pc: Remove deprecated pc-q35/pc-i440fx/xenfv 3.1 machines") removed the Xen machine type that was providing the "xenfv" alias. As a consequence, since the tools are apparently relying on such alias, we're getting this, as soon as one tries to start a Xen (HVM) VM: qemu-system-i386: unsupported machine type: "xenfv" Use -machine help to list supported machines Reinstate the alias and let it point to the only Xen machine we still have. Cc: qemu-stable@nongnu.org Fixes: 7d2778dea3 Remove deprecated pc-q35/pc-i440fx/xenfv 3.1 machines Signed-off-by: Dario Faggioli Reviewed-by: Daniel P. Berrang=C3=A9 Acked-by: Stefano Stabellini Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20260730162238.3308286-1-dfaggioli@suse.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 223a19cc4bb..a929cc4decd 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -667,6 +667,7 @@ static void xenfv_machine_4_2_options(MachineClass *m) { pc_i440fx_machine_4_2_options(m); m->desc =3D "Xen Fully-virtualized PC"; + m->alias =3D "xenfv"; m->max_cpus =3D HVM_MAX_VCPUS; m->default_machine_opts =3D "accel=3Dxen,suppress-vmdesc=3Don"; } --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891774; cv=none; d=zohomail.com; s=zohoarc; b=NfrXdrPRw73tWrVViDQvUKUzz+ZQDKGclXQl7161UOBxKK6boraXAnpGmDnS98Wyq0zuWXzM0agkex2mAzqzZp1IYguyo4JiAwkh4hiX4/2NjXoPFl/ZXJlu43zzedMLvmC25geuPXXTGztUoNmGUsGR2hcMMHHSUQkla4KK76w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891774; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=a+WcWjDtr6Aqfvb7rgsLeTX+z7O13m3aV0M2b3rFLZE=; b=Q9d5YkRUZW9L+M0dx8jawO0VMYoNgFjNYH/4SbxcfsoA/TCGLS2aPVlr4jG41Y2qUcpmdG1ubzsXPKM0cCh2VlHYEMuRrMHprtxnpQFQfdLJ4gdf41BzpDUs32DqPdw4r8QFvBkicEdeQady/Wc4Fw6kEk6zBOhtAZ7UtFdssvk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891773995876.313384769385; Sun, 16 Aug 2026 07:49:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcAn-0004gT-1b; Sun, 16 Aug 2026 10:49:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcA2-0003zd-EP for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:48:32 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvc9y-0000pl-Ge for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:48:28 -0400 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDmMA13633961 for ; Sun, 16 Aug 2026 14:48:24 GMT Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghekq1y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:48:23 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-52b4f6ac06aso49068561cf.1 for ; Sun, 16 Aug 2026 07:48:23 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f2b1fb7sm24526763f8f.17.2026.08.16.07.48.22 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:48:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= a+WcWjDtr6Aqfvb7rgsLeTX+z7O13m3aV0M2b3rFLZE=; b=ZSqBE0VrkZ8vRrpm IYGJrWBeya/29axMK0CQN053zRGJKVIT4Ekoxx3U8+38XCNEN4i96zd5IcUEG30j MBWX8XcNAydtA3/guWngASU7DMb48F9bn0M79h1938vBynV2XT1lot5ge4KeQYV+ 2TEUiXpKeVrEtfvNEpze6QiskZLDFFqC0Rl/nk5P/23ToiW2nOc/nZthqWpZzsfk teNdXLsDuHthnLt38fNye5k+dOVHUipzWWnI70b1QrSPF5Exqt9pa94JcqraQl7x uOnCqjzoFp1L5GtVrBfIDGgBuRp2OAKYMFJWoo4LXsjah5YLnOQ0D2WuJdFjA0te VibJcQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891703; x=1787496503; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=a+WcWjDtr6Aqfvb7rgsLeTX+z7O13m3aV0M2b3rFLZE=; b=LC26JNdrD4/aNgo5XYo4OBefTsJKDhzNdgJ+mpswhkCfVMXacVGBdV+zRLqmPfR1uJ w4+MIFN9S6o6vHsx1P5S5DJApf3d5gMNeY9kvkjphc1BmhfnxWSeRufGQzJhpbKvitZA SjDqoGtkHXh/+PnONAHKXwoLqiyMBHHdnS8dd532xrBNUvosLu0DspYBt1ebMtdB19fa JR96IP6YH4+D1etFOoEQYMOK4Zvag/Sle+U2dYNshiJGLsW5UD1+Rj8Clf1TW6wOV6wv 0nYBqU5ZWbweyRKKgrBPYC6MRs11jxlCR/ryeJi1IJDYNVWpoezKCdsxiO8WTWD2a6v1 2r8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891703; x=1787496503; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=a+WcWjDtr6Aqfvb7rgsLeTX+z7O13m3aV0M2b3rFLZE=; b=hgQUwoz+bICx7Xq7HemHpR9pdbYncxpLx5IHvpBoZAH09DnBemCjftlGpxZ6unNU/z U7e6WG0PDahasuZZ1HK/kSG/5Nx23T8OhRFGebPvX4gFnuYuPX8odfRYakqKKE1eMxbk EeCnVlYtJnym5+axmzZAEndrORabAZPc1ZX0MzF8eaVQPzoT/cnwRwQZFXnnDyphkCuZ DqyFYEc3dI1IuJvQ3tgD5K50KXL1RzXjMkmifF7iIUiCMD7YD/Y2Z4fR47TJ98ezcsl6 3iFR7TcQwpa27aR6y1KcFnZrWYoiZvf0+qkdc+mgRFuaXfV8T/23q1U8HC5RnSdGOyZh /ozA== X-Gm-Message-State: AOJu0YywnKAPwydY26M9vmjLnMVwTxXe0zhARS4TZqMOdSI/q6MpKHW9 F6Y+eeogBcTbhXk5fZl0lOWNflciLU5WGrcN2QUOBHAPo9pM+NyvM/D8lUTzjEnV1NaBKlvh0Nf SkuIT/g6fuR21CAuNrzyVe0gk/B2riwQ9Lm42bVXMzp+oPZRw2ziWL5kKGRmuVxtNsw== X-Gm-Gg: AR+sD12QsGZWh5ilwdrPdNIYqxDinNfzoTFcn+U8FjGqi1Bw6dAhiUUy5P7BLs1LTLK pLMxntYgFY5H2u/5e8hKq+0q0ji2xfXSiCpYgM++yvNKy4T24IER0jfrJfEB1jECxVdJ1dkfvdX Hi6tBSY6ztkOrODgAZU4k5xPQUiKXNhuTeHeje+T3ufZk3W+FX39MKC3f4dmJTLzgDi32oiJM5Z ysPrPReaSaKMknPyzW8myACo7UlVPrHNg/KwBYfd4dMZ8d/k20KIfpMdpPWSM7zuVy2HhEC0Nqo e06cN/QF2Go2aASJ7oH/fVAGU1axsNA8X1vXNlCg2JxsF+7Td7JqAdb5ShdkI8DNkj0cRrqp6w/ dhhnYOhbFhZEGEkF2p3799BK47PPT/OP1ARPkcC7/tQ== X-Received: by 2002:a05:622a:1a88:b0:51c:51e:661c with SMTP id d75a77b69052e-52d8543f3c0mr200751061cf.25.1786891703473; Sun, 16 Aug 2026 07:48:23 -0700 (PDT) X-Received: by 2002:a05:622a:1a88:b0:51c:51e:661c with SMTP id d75a77b69052e-52d8543f3c0mr200750801cf.25.1786891702972; Sun, 16 Aug 2026 07:48:22 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 17/56] hw/net/rtl8139: Fix handling of VLAN tags on incoming short packets Date: Sun, 16 Aug 2026 16:45:16 +0200 Message-ID: <20260816144556.69009-18-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=EKc2FVZC c=1 sm=1 tr=0 ts=6a81cdb8 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=p0WdMEafAAAA:8 a=KKAkSRfTAAAA:8 a=FRSEYCzRAAAA:8 a=EUspDBNiAAAA:8 a=RxFCA_QbULDqiWA6Y9gA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=cvBusfyB2V15izCimMoJ:22 a=H4N_Y-AU75W7NKDNhZlT:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX5kuzTRClWW6C CvuyV73k3WHGxqDdzP74BplWy3fuT2Pem+3t7BDNMo34JzUvoFHxMmOSr6p7e+DjCvmwDk+5l3X bSS6ktSJ7bHuccqvrgS8fDyvFo6RBtw= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX+R0o2Ycjx9qs 8Q+WPiUHXnVe0DfXmpd6wwI4YdDD2AJMQUgFkA03ZNuw4baWMmg+SPWZN52tfl48tnFamf7aZVM J4glkYY2x77kSogzfZxXwyROziIZkkt0FlHNT6z/Vh0Q1S80OlPXl9s1pjW4ZnEk40ascAJCtSU KgB5iknKQt1GfDMfG0AnnjXFx1XeyJpltEf39F9HeaYv7yfSHh1KVjzYtJpJGlGASNI3rmGkfnG Nf/Yn18Nt33PZOOKyGQLQoIzZOoUyNuGzFuAt09Y4YmagZUAqEPcNlPPqqsM4oOxZ6ZOeoAQesf TWzBreb4fkr4KUQl31O7TKFhCOrfRiPuwtdN5imHk4XUJRHuSaNimul816x8VaFWlqoDVpe/Ptb 1YhNeuPn3AcnzxqyhSWnxghcooRSi4NyIla3M9zq8d9RXR3wTeOjODxng4YKpwsCHX2Q76EnQNc sQ2N85yZl/I1U6fJCgg== X-Proofpoint-GUID: 5QvN0APf8r-sICTdkTDTx2iBB6PgNE95 X-Proofpoint-ORIG-GUID: 5QvN0APf8r-sICTdkTDTx2iBB6PgNE95 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891774539158500 From: Peter Maydell The rtl8139 receive code handles VLAN tags in incoming packets by copying the VLAN tag to a special field in the receive descriptor, and copying only the actual payload data to the receive buffer. This code tries to ensure that it pads out the payload to at least MIN_BUF_SIZE bytes. In commit 63b901bfd30 we removed the main "pad short frames" code from this device because we switched to requiring net backends to do the padding. However we didn't notice that this broke the VLAN tag handling, which relied on the old code making the buffer at least MIN_BUF_SIZE + VLAN_HLEN bytes so that it could copy MIN_BUF_SIZE bytes into the receive buffer even after removing the VLAN tag. The result is that the guest can make us read 4 bytes off the end of a buffer by feeding itself a suitable short packet in loopback mode. The old behaviour is actually not correct, because the IEEE802.1Q standard says that the minimum ethernet frame size remains 64 bytes including the 4 checksum bytes, and so when a tag is present the payload data only needs to be 56 bytes. (A bridge implementation can choose to pad tagged frames out to 68 bytes, but it doesn't have to, and so all devices have to correctly handle incoming tagged frames that are 64 bytes long.) The RTL8139 datasheet isn't very communicative on this topic, but there's nothing that suggests it adds extra padding on receive that didn't exist in the incoming packet. Drop the last remnants of the padding handling from this device; this avoids overcopying into the guest when we receive a short VLAN tagged packet. Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3518 Signed-off-by: Peter Maydell Reviewed-by: Bin Meng Message-ID: <20260731093618.2961031-2-peter.maydell@linaro.org> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/net/rtl8139.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c index 424af73a18f..2b61c171f2a 100644 --- a/hw/net/rtl8139.c +++ b/hw/net/rtl8139.c @@ -778,7 +778,6 @@ static void rtl8139_write_buffer(RTL8139State *s, const= void *buf, int size) s->RxBufAddr +=3D size; } =20 -#define MIN_BUF_SIZE 60 static inline dma_addr_t rtl8139_addr64(uint32_t low, uint32_t high) { return low | ((uint64_t)high << 32); @@ -1007,10 +1006,6 @@ static ssize_t rtl8139_receive(NetClientState *nc, lduw_be_p(&buf[ETH_ALEN * 2]) =3D=3D ETH_P_VLAN) { dot1q_buf =3D &buf[ETH_ALEN * 2]; size -=3D VLAN_HLEN; - /* if too small buffer, use the tailroom added duing expansion= */ - if (size < MIN_BUF_SIZE) { - size =3D MIN_BUF_SIZE; - } =20 rxdw1 &=3D ~CP_RX_VLAN_TAG_MASK; /* BE + ~le_to_cpu()~ + cpu_to_le() =3D BE */ --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891774; cv=none; d=zohomail.com; s=zohoarc; b=mD9xLujr+XZB+936QnixkwHcBgL4v89H+b1/5HnPVflDkeSbjZ5qY/LXmPO75xjdGwMi/lJeRkaIoYHFFKUHZ2JA+5IuTUgWzbGzk41urZXtei8WurEOAUbIgN7GKVwzBIU0OVq94wLwty5QEGlxCJvrRND6uOEFoAkKf/EPurk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891774; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=/4700RvMPhJAVGgde3qZkacZXDpDTVmcTdrCQSF011U=; b=hzZbJyFD/wN369uuI2ong1D2XrEuCNqqYo5IUISa4cVvOjaMum6eEP+IU5u2CwMdKyIvRUxh1K1ws1GLuqeS4fiJIq8Vx9syQsVh+tDyitNu4D0DoYQYTymieSV5MosJC1UpuSfeHJfgr5uo0ClGQ2M5dsMh+eqf/16Qo45+6es= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178689177484760.85421148055855; Sun, 16 Aug 2026 07:49:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcAh-0004Xu-Gx; Sun, 16 Aug 2026 10:49:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcA8-00047I-0N for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:48:38 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcA6-0000tb-GF for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:48:35 -0400 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDklSh481355 for ; Sun, 16 Aug 2026 14:48:31 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghfbjxc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:48:31 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e53b8a302so268917185a.1 for ; Sun, 16 Aug 2026 07:48:31 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49996100082sm79612655e9.2.2026.08.16.07.48.28 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:48:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /4700RvMPhJAVGgde3qZkacZXDpDTVmcTdrCQSF011U=; b=oa/6DtcCAPphvVxl bIULBBhp9TDqzKiXeT6mlkhL0HzZd9WdGmYilQOrOD/BipNbwBapLkBCUL+5UO35 v+GLK5759Kx7NU0A5V1UvneMvvW8Y+38PQH7f56q5iwmjL7EbCSG+EO8lnRfgp8u KiFiQt5QDROJmi7LJ++630ta+LXtpMH4IGVUP6j5IxjZiT0nJCo7cgku+Sc15Bn7 3AG3KEohRPAAf0de651FuYckQUoZB8iNxWsUgT1wotA5CtYZ03dAVSldXt9LLYyS 1dH0PjTGKUpOt9p6KSC89JxNsA5avz/ws7PX8OuMogyLFygNo/zpdMiBVibDA3HB fpQTsA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891711; x=1787496511; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/4700RvMPhJAVGgde3qZkacZXDpDTVmcTdrCQSF011U=; b=VTbwIpwAD/BDZnmQ/rlFdnjNr55tuOQZoz/Sy/6oOEPloa+ORfKMskFYvzuFtd+SDX 0NXiwZmK5I1h0LYOcjrr5y70tFxmH37RKGkKMmE9+nudlFjRXHbajxF1Gr777Ky58jzo VcLkMGh2Z8E/qoxxu10Uuc+0F1MTKJ79BVm3vNNStlZZb05AMXIsCFW9zKkWGNQbf6dC Dlmw3efMiwILGgWFDqVqm2wLNdjXoqwNA98wRStKGUc0sbdnbE1QRdF4F28JJUJlCC0H 4Ply9GvqWVHG/6/5JaKtznbeAcrVIC5gChZifdyqqUQAk00DFnueOFSsGZgyBe1jp72e KbnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891711; x=1787496511; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/4700RvMPhJAVGgde3qZkacZXDpDTVmcTdrCQSF011U=; b=PUk+KhVTvW0zBLqAyN2pFnN+IHe4H7fpo7rXLPkXoi86A2gnkAj2DYru6/0e0gGLnw 8L/9td/FBV/dpqGBRx281a3RBltuNnAtslk2dXS0QGcKmN+xRWy44SJ9aZJA/ra36sZB VmFmJHz7w5wjzT61tDWXNCgehR5etVQLwDs0WhPUOWPEh04eWS7xksdeXW289O9oLZR2 r+jo5/wKMLkv3ALiyfYwzx3Q6rM0ES0bE+pUKlSAZSurrNXVG6xqIzjO45yfjq55q24g uhcG/c3HIDGxVDrrScF7IUoHq20/zYmCS92AMSaf1Zg9hLirTJpUQsZFr0BoCql8LRrv 0aIg== X-Gm-Message-State: AOJu0YycsZjvyPipk9SZpKfQ4fjSXN+4MwWfv6jeP5tZr0sf+akGrRBT qprOd9VcxaW7ZXdBVwi7Uu8DNWByt4a+eX85EGNuTrRQMn4/zzjk6nUZn3A4aXyg5ACwjotEEr4 vpVhm9t/wDZEzMYzPqL93uKbmvthBN7Kd0hkV2sUgZ32EQ39w6IUOdPXQhDcZ5Ia7Qg== X-Gm-Gg: AR+sD13qd7vrmDifKekXYmWX+hfmEVptaV7GA8lnOisBUJeu5d4UZv0idLlzeXq1Cbp jjhslOCY5RXQVcvgZmXoUedRXLZuXB01c8CrBoC1Byfx+4gv+hiI0GPT/Ed37ncPgubhJOu+pRa kmp/qU83YHAMK487qEdglupJHh02qhnAetOB2zgSufOi2D0xUVi/WCBGk3zcKrtelYeYocpe4AZ kRxvjcg6WJ/4x40MOsDOyUn/oEsc213rtfJ5hWTyj7sXV92t6bNqr+JqHEUFNmKsYcLdFnoqkn1 ADxB8FOX7WWpo7R2pVEKah9gwPezYcwNlll+y55kHXLaZX9++jCce5gI5fbOj0je57mHCMOUw5C 6Dsp/fnS59FAKlNlyyD7679cpSoNxUlGBBOCe2pr1cQ== X-Received: by 2002:ac8:5ccf:0:b0:528:22:8c61 with SMTP id d75a77b69052e-52d854f3ce2mr212906621cf.38.1786891710745; Sun, 16 Aug 2026 07:48:30 -0700 (PDT) X-Received: by 2002:ac8:5ccf:0:b0:528:22:8c61 with SMTP id d75a77b69052e-52d854f3ce2mr212906231cf.38.1786891710291; Sun, 16 Aug 2026 07:48:30 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 18/56] hw/net/rtl8139: Send whole of vlan-tagged packet when doing loopback Date: Sun, 16 Aug 2026 16:45:17 +0200 Message-ID: <20260816144556.69009-19-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=OZ6oyBTY c=1 sm=1 tr=0 ts=6a81cdbf cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=KKAkSRfTAAAA:8 a=69wJf7TsAAAA:8 a=pGLkceISAAAA:8 a=FRSEYCzRAAAA:8 a=EUspDBNiAAAA:8 a=OYC5cIGrZyd7Z81vqYIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 a=Fg1AiH1G6rFz08G2ETeA:22 a=H4N_Y-AU75W7NKDNhZlT:22 X-Proofpoint-GUID: V_D4tMZKDVWfo3_Zo2crV9GXQUacQqfO X-Proofpoint-ORIG-GUID: V_D4tMZKDVWfo3_Zo2crV9GXQUacQqfO X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX2p24J9xUODeO dJz9NsQDXGGqqUYQ0Us28ofxjWcTBdBKmatGh2A2XuPbkHKLRTyl1g1IIvlJ9w0vXWFNAXhhIee Y1WxxKZlAc3WIjWxhmu7eOSOKlvpE8w= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX7ljguofgVddt Dtcrxzr7aAU5bSHOh2oGha2gbKOH82fPC9MV7gCYZ9G7oomKXb63+WMyPKSFaQdyMKuyT9s6u8T tZeVcvjwU2yYE5DdFLtFXS2SlLwzy+d7IVLDkvm/p1KcuXS5gJsu3hjf6l/Vd9AfTtKGyNIS9c4 L1zh7ToouFcvmZhAT0Kt06bB8YY5Ze72QR9lTJ9SbFFTGYgvx9vd+DXBobtt089tYvNS1hBqRlV 0AsOXR+wVGineGL+m8K6DiQRPocXoak85477n8001Lr86ZmsFE//uyed5gmzdCLW1VD+MFVfuqn aUlsTrCy/h/dwmiRJwPPLX26eMRtRJcKWb6KSvsv94GfcWi5n1RqTOve+5nRp1zU8uI7AbShv/3 BBpPS2xVg6H0sND7zKSHNOuoacbE4eYr8aq7id95uEb2FtE1sxV5rsy3kKK4w96DBBryrhDz06d ty9ttsGEu7vEpBad/IQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 malwarescore=0 suspectscore=0 spamscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891776450158500 From: Peter Maydell In rtl8139_transfer_frame(), if we are transmitting a frame over loopback then we do this by calling qemu_receive_packet(). If we have an iovec rather than a simple buffer (which happens only when we're sending a packet where we are inserting a vlan tag), we have to convert this into a simple buffer first using iov_to_buf(). However, when we do this we forget to also update the 'size' local variable to the size of the new simple buffer, so we will truncate the packet by 4 bytes (the size of the vlan tag). Correct the logic so we don't truncate vlan-tagged packets when sending them over loopback. Cc: qemu-stable@nongnu.org Reported-by: Bin Meng Signed-off-by: Peter Maydell Reviewed-by: Bin Meng Message-ID: <20260731093618.2961031-3-peter.maydell@linaro.org> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/net/rtl8139.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c index 2b61c171f2a..16479284eea 100644 --- a/hw/net/rtl8139.c +++ b/hw/net/rtl8139.c @@ -1765,6 +1765,7 @@ static void rtl8139_transfer_frame(RTL8139State *s, u= int8_t *buf, int size, buf2 =3D g_malloc(buf2_size); iov_to_buf(iov, 3, 0, buf2, buf2_size); buf =3D buf2; + size =3D buf2_size; } =20 DPRINTF("+++ transmit loopback mode\n"); --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891821; cv=none; d=zohomail.com; s=zohoarc; b=geTsJyBisjaYYUmRXKCu5Nng5MjpbnyWDCSc4lloGAa2Ux6MW7ZCypQ9BpWMJ46yZt7pUb+EIpp7Mgk7y9ZqKcJB9EA4g/F5wgK064gsCxyJX8VPUhIVBNO7MdyZgKlR708uMLwhJMAHiSJsU3nvgbCRUCuePxK6oASu/1q44UM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891821; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=mJ52XJEm/Ufrioi10sFwL6GNYhnPWGnTfcMAWm7npzw=; b=PBy603OXUL9BIH2DcbNsNO6fufvCfEhiK8IbCTXYbuH3DnaOsbLI6M1kWvSNt3Gt4FaEIzYxUMRtsGCPTqWMK4oZJFHLSv9yWJqCCbYKtZHZ3/cjKWw/gLx6Tsz0209P2hIU99C90Czve7PqVj+8aE7O/x00O0fbTPgyBmldkUI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17868918213411014.0457749234645; Sun, 16 Aug 2026 07:50:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcAm-0004et-KY; Sun, 16 Aug 2026 10:49:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcAH-0004HD-KF for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:48:46 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcAE-0000wa-9q for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:48:45 -0400 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDkkFD3609380 for ; Sun, 16 Aug 2026 14:48:39 GMT Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghfuk22-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:48:38 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-936cadb0e8bso220330085a.0 for ; Sun, 16 Aug 2026 07:48:38 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49996108141sm46894005e9.6.2026.08.16.07.48.36 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:48:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mJ52XJEm/Ufrioi10sFwL6GNYhnPWGnTfcMAWm7npzw=; b=HZpowZd8psKDf4Ws pMVaUphwlYVjhTzKzkfNNeIlJFzPS1q+gF1im4b06GfAPg45h5r0Ba3pU2oTLFDb PFK90QS8AJmygU3v9Sen4Cpq3WgN5J5NH0jwO8cRLXc8feM9krlfvd13RXIWAf5u 7ZBbllU9TESWyzZ/vDPdYD4B8H1Yqhm8OqdvPaj0c8UGIGoD7D+/xF34jPNYZTOI cePqitKI9AjIv1f7+hJWUsGIuw+LOatIFZC4Ls9hjJpPt4zDegfG23D0b87FwnQF wfdzDhNlQqdzX+yJ2zmPavCBKEbB6vIhz5uFlZqRFACexWtwFFWiiH3MoLEh2ThR eeLHqA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891718; x=1787496518; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mJ52XJEm/Ufrioi10sFwL6GNYhnPWGnTfcMAWm7npzw=; b=eVIT0LRKk9VVQRG013TwmhlSXbK2hl+lEic3xdcRnBh8atqa8VpistW0K5DbbsMAgk a/t//nzEBVDN1UDQhzdD08r4Hwk+K9tGeHPl6vegvMuFKsFm21kMQYLSPjRNeSK40Zrf d/+4AwoFUZamoswrV1n1DCw06GJkkwNkCSscTOBBYnBMQgugOBPi9wJ6B0F/ShzAt3Fl fWcz7XBApi7GpQXzQCutqdWCGXBk1evwGS92/pAtOmmNLaHu/gIkmOjAj2Zfy1us/7qa zckX0Y1amjfP2ijAQ63Jhfwp1RW1btCVoUPh+Vx577gvagZV9yzBG9zSsx4zG0viISO0 1jTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891718; x=1787496518; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=mJ52XJEm/Ufrioi10sFwL6GNYhnPWGnTfcMAWm7npzw=; b=HA/F/LcCR9N9TFToRasoDnxIoUIiSDRX5X1gZqri/0ZDOmbkMq3DhJwdwWqxEf1W3Z QzMqskbYFhwtKHUR5ad5jhjoVKrZAG4/EKc5eY/8IFf14QwwokMBtzW6ngt88kXGmoeK PN4VbpO1gs2JN2YYEP+D8ngd2cYlNODEjfH4+++icg6TshT+UEfaVV4XsX8YiwjuWwYp +j70k7+Iee5Rrcu5M9K8uZMm9SZFO43NKm6BUEoKaTqh12Fs+ilZbI+KwTwf5GuPPRbI ny1zB6JLNNX98R4qfpdG1GWe6c2PloHgnOJopUFNIsGdfx6G3w4pFy7FsRk72jJJabMj HK1A== X-Gm-Message-State: AOJu0Yx8M18BdExrT56Cn1c2LGez/hQ856BRMivuE6w/JHLzu2I7G2D+ tClyMYxa2WG4TI27E/FvWFKSNdmhRNFRzOBwsaBalOlkIuRfbgdzhpxM214P3+sCp2AaEHsmX+T luv6RMjljEwYrb7tKJkAiywDWo8/EKS/7dV6mSNs/ynlC85HQrdzvvdhjWrGdNuNbiQ== X-Gm-Gg: AR+sD11gt8PwfwVxyy9glAZ1JB6dxnR1iAXreugBQGwHXEQnL+AGzrC7zEJItgDFaYX oipm99+q7+cu3NjkeV1pU1bG+TeuyVD/ZPa/+NDJZB2L0HE9soin48GUS/vW9jTpXK/g49gle6g DlR8pWQn6bKK0+DnUv5Tl9GfD5UqQccaZiRrc5mQw5kyF+DfR9+NM28Bd68e6nemRXcF8jqUkmp 2iP6vYnNtsS8NMwzVjH6S+x5YnxK8FrOFdZeAmhvyRNfECRjZAwtpKQEFKE/RFS9TxGRTPW+1Ot wgV+etCUt9jrxkqvQFDIpKQ3wXAZk0MqtFtAIBNwkfhWQG8oISkM51IeIq2D4UZZ4EztN4KZYu3 GsAbF9hG811TM/UZ0k4949umLfqmkxgSL0yCUMf2q1g== X-Received: by 2002:a05:620a:2941:b0:936:7a4e:db1 with SMTP id af79cd13be357-936d22e985amr1944916385a.23.1786891717778; Sun, 16 Aug 2026 07:48:37 -0700 (PDT) X-Received: by 2002:a05:620a:2941:b0:936:7a4e:db1 with SMTP id af79cd13be357-936d22e985amr1944911585a.23.1786891717085; Sun, 16 Aug 2026 07:48:37 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 19/56] hw/block/pflash_cfi01: Restore ROMD mode after migration Date: Sun, 16 Aug 2026 16:45:18 +0200 Message-ID: <20260816144556.69009-20-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX6ScCrEoqOO44 wCdNqiHbx8aHDkzbiDrH3R5DZNv5xJAX0cdrKHbgjhAatlDLrH8CRKz067wktSja84Vwph4UzI/ hzFbmkXqnAa3lzPLF2AMsF8EKXVuCgU= X-Proofpoint-ORIG-GUID: wlDgjguj5PzaMOMh3gxYtvnAqE9HaneI X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfXxVdYFWzO2yfG tD2ZDI97OR7uouHczb1MXifDZpE4wW16H6dcYDDo9Pt4NaDe2A24HL+jCG7EyKtOOTG6qBHHzWQ +urRUtOYViXTUo9z8+dXe4P7uUjEnHpZ5fseJXniJdMssE3UsJ0LO3bTUoNTkY0F5VmwhBweZoo TAUMNimYb01Ystr55PtO0tn1zUvu/NZeGueZrtG/YpRxACgNOv1by254/Ls6gMBqZcn45XoLUgQ cZ5mpRsqurq9aEfgyeGMlGSkqgoA0zB8k3tDUHhgFDI1TASxL05e6rMu5nyjAdTCHGz0rRuM3tq Z2L8WiAHyCEmZ3LLhl7P+7SbCaMgNo+bHe+OR3nBhC/duYquy2RgjKGmWXAUC18QgGUXskDfxZA 989z6nx1J2523ohmzOYA9C7Zzhp+lY0fRY4eyy4OQZLoA/ybjkVBY01eCi7EPd5jMLiM32pD/U0 T0wYTLMHKQ6ZfcnUkKQ== X-Authority-Analysis: v=2.4 cv=TMJ1jVla c=1 sm=1 tr=0 ts=6a81cdc6 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=p0WdMEafAAAA:8 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=SRrdq9N9AAAA:8 a=69wJf7TsAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=Ri07d896u8T7sB93P0wA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=Fg1AiH1G6rFz08G2ETeA:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: wlDgjguj5PzaMOMh3gxYtvnAqE9HaneI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 phishscore=0 clxscore=1015 bulkscore=0 spamscore=0 suspectscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891822604158501 From: Bin Guo pflash_post_load() did not restore the ROMD mode of the memory region. Although cmd and wcycle are migrated, the destination retains the default ROMD =3D true from realize. When the source was in a non-array mode (e.g. ID read, cmd =3D 0x90), reads on the destination bypass pflash_read() via the ROM fast path and return raw storage bytes instead of the command-specific response. Derive ROMD from the migrated cmd/wcycle in pflash_post_load. Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/4042 Cc: qemu-stable@nongnu.org Signed-off-by: Bin Guo Reviewed-by: Peter Maydell [PMD: Including review comments from https://lore.kernel.org/qemu-devel/CAFEAcA-P6RH7nJK0KQ1H8576ULFA7nocB0Ekhh= Zf6Rw3g0WCag@mail.gmail.com/ Confirming that this is correct is a bit tricky. It relies on: * when we set romd mode to true we also set wcycle =3D 0, cmd =3D 0 (which we do, in reset and in the mode_read_array code) * when we set romd mode to false at the top of pflash_write(), all paths out of that function either go through the mode_read_array path, or else update pfl->cmd to something non-zero * nowhere outside pflash_write() udpates cmd or wcycle except for the "clear them to 0 and set romd mode" places This is almost but not quite true. In pflash_read(), the default case for the pfl->cmd switch sets wcycle =3D 0 cmd =3D 0 but doesn't change the romd state. Luckily the "this should never happen" comment is true -- there's no way to get a pfl->cmd that falls into the default (except for being deliberately fed a bogus value via inbound migration). ] Message-ID: <20260803041808.58174-1-guobin@linux.alibaba.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/block/pflash_cfi01.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c index 5b9ddb20b18..a13b91967ed 100644 --- a/hw/block/pflash_cfi01.c +++ b/hw/block/pflash_cfi01.c @@ -1030,6 +1030,16 @@ static int pflash_post_load(void *opaque, int versio= n_id) { PFlashCFI01 *pfl =3D opaque; =20 + /* + * ROMD mode is not in the VMState; derive it from the migrated + * cmd and wcycle. Only (wcycle =3D=3D 0, cmd =3D=3D 0x00) is read-ar= ray. + */ + if (pfl->wcycle =3D=3D 0 && pfl->cmd =3D=3D 0x00) { + memory_region_rom_device_set_romd(&pfl->mem, true); + } else { + memory_region_rom_device_set_romd(&pfl->mem, false); + } + if (!pfl->ro) { pfl->vmstate =3D qemu_add_vm_change_state_handler(postload_update_= cb, pfl); --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891786; cv=none; d=zohomail.com; s=zohoarc; b=jmBg5fP03zG6vWUW8gwTE5TOhybpJ00ffjjl8U+ex+CBo8ZI6anwZpqu1WhY/UVJVATZrvl85xrsv5YdcegBRKKwBYAfIBT7srgLQxS00UvBWrPiQvQ1yGm8zSr8C41cmWmU0pk9NW7ciqBUK9S2AvBII40OVv44PMPhGWgsRbo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891786; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=k2vztmyd+ito8pBxnQA32kIPy6gCaOEGn0qxtiZeRd4=; b=QLxkPuyE2KyVcDv5e3t3GXhaNhVNy2oBrSZcOM5q5yS1UZQ5IC5rLtn15AzOmkfscLWs9JA1jl5teHABmi0RkQwzOPUmbfAiB+CuerVGvCTkKR3VDnHFPY7rJDtj7NX/OlZj5a38ZEy6cGrhWnZiwJtYJuyeyXz3HfALZMnYaEk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891786407528.8456031387606; Sun, 16 Aug 2026 07:49:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcAo-0004sO-BZ; Sun, 16 Aug 2026 10:49:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcAO-0004Wm-BQ for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:48:54 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcAL-000116-UT for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:48:51 -0400 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDmShb3952895 for ; Sun, 16 Aug 2026 14:48:48 GMT Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghnumar-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:48:48 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c1d7886cdso51118021cf.1 for ; Sun, 16 Aug 2026 07:48:48 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499960ff072sm71369665e9.3.2026.08.16.07.48.46 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:48:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= k2vztmyd+ito8pBxnQA32kIPy6gCaOEGn0qxtiZeRd4=; b=QCy7qtI9E2Qei7hf iPoI3PrvhInWhreFAzVc179Xl+8G/NBJ4D/XJjvMOPrCVNucrPSvCyyHq4YDPutl WKVl6kzD1n8Y5ZrYfBIi8whMK2BIdeQ4mxIsrvmGFnDEG8GlN6D/rW3lc/VxSPRY LSnUiy0IInAjN+exB6PJ62pXSYWRmNrc5XBgNKn4/K07Xiqyj0uy4XQG6BZl3pmj 158O702ZT47ukYKaixC4oJoCWGGZmT6ojxprqdLM3AlvOeF8DCQAzc5ORDjQB2Tv +CUVB9M4UQ8T+Kp1rPyJdxzz+CsSd9HiaDJuikVhmKYzzNIL0TIrWA+iBHxPx1qZ TXUREA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891728; x=1787496528; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=k2vztmyd+ito8pBxnQA32kIPy6gCaOEGn0qxtiZeRd4=; b=Xift5/2hzFetn7kQtzqVcA1eIhmwS7UUvn9SrqTPDjssBjYExVDWpXwmnTPBWB5fB7 aOsbPVNnCcBvTtR2AChlSXCPSMhZqn5FKfX2vqr1tFZKLpiuJobwZrJGVoVIeCHgwFTJ IT3iL0Opn6C6/IUvWhMEzKq23qWm+hSq9iMhhaX8ZZsylSx5erioTlwHEUnVBCNsL0xo Y5K+ARiLjmCIkgT1MMZ6tFShKboKbJXDinpC6cJtje0GIJFoPfnArkZzq+0JtlSu0YPz tgjy/N06PBrCpVkGG9RfOrXua7w8LfYh4TN9ZvJINmr+Qy0ANR/NOI3/RCwjAVbwS3em phvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891728; x=1787496528; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=k2vztmyd+ito8pBxnQA32kIPy6gCaOEGn0qxtiZeRd4=; b=h9tDBq/uAFheiiX1fPP59DzOAorFS8mT1rKd9C0+vspyibDQEj7qMYjIyUc6L10OPV hxaFp4e4MQJ3MlFiDVc3mssvqas7XL3MH0rggTkWiDDKvo5DXfkrwYADM1QNG1v2B248 Pmt0+V2CQrKwb1MHmnKHiN07HH52qAGqzPsqjIbL5EePDis2inYG0fmqljLhaQIa/Cpd K6VudsGCgYgU10eP319nkxCIOrjyQ7n6gDPCw4mcjStiaDU62vbsBZ4bj7etoxpCYQSI Dwi/L5xAgw/6Jaybcb5ojORvt7oPFHnfLOJhkTp8/UhztC2alBoX0kddGaPTHh1HCPKx cLwQ== X-Gm-Message-State: AOJu0YxoK0382SmqHapWTv+5+Y2c4hMJuyBOokO8j9X3SpMgvulxSQl4 l/ki/9nPssUJE+7NScRF0LjcJmp7rvVNDC7YSJOUyFD7NA1/tROTDlTsGDZKlRkqm7NRuiyNC0B +EgqV0tepe8kkSxQs7pWGeVTYwQ9FoOxSK0dcD7WdAXTAJYSV43WM1bQBRdM74w+97g== X-Gm-Gg: AR+sD13mvAj72FzqRv+ECKiG3VXnwoOJpb5VkpSiiDfz6C84SN67GTopfGdlze9HeHx AX9lfe8zPViR4av80VxsCtv6mhlbFmCnbiwELT3NEV4xG4XehRfzirKXZ+lMwJ/AIv9MWN5195j EvPGG8fOvd/k+rqkelI48xtwAZ2zp6GXl13W81HMvMTcwNbhUvWZ8Ulp/vJo5lO+YPNaAHe7YQg JDw5gmHkycE7DW4zPYFL0B95vg6YvKQBwpwHFIsl60Jc0O6tbOikU88+N2HFPbNe+kGAPnNwiRP JjuE7y/sLBG2vtNulnR4bcrNWTfK60HRq683zgfOlfEM172jbX8gDoVZ3Np2CWZAyyNkxdksV+m qvWr0jUSTC6wkjEqyghVejeolLCSxToEab+Wx1FAr+Q== X-Received: by 2002:a05:622a:4819:b0:52c:cc14:ff63 with SMTP id d75a77b69052e-52d854d0e0dmr222118991cf.37.1786891727868; Sun, 16 Aug 2026 07:48:47 -0700 (PDT) X-Received: by 2002:a05:622a:4819:b0:52c:cc14:ff63 with SMTP id d75a77b69052e-52d854d0e0dmr222118721cf.37.1786891727475; Sun, 16 Aug 2026 07:48:47 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 20/56] hw/nvme: add SPDM_SOCKET Kconfig dependency Date: Sun, 16 Aug 2026 16:45:19 +0200 Message-ID: <20260816144556.69009-21-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfXyTs/kg6rVkzZ P4ZeYAwGgxoxpqELlQnxRWqiH8Nx31VMEvnsJFanpS/OLE4tGqrJiTfQdRX/1ShMF8gtI3EEQrs +qRGKOW9xGTTAVxO3aAKUZSe27MtvMkGHeFuc4/uWKH2FGFNluPmyVwrBMhAPKkr3dgxZfEoqpM IKz3n7seY0kAb/hYZ4WIHxYbfpQchNTmAJfUesKd7bQCq4o/UFY5XNa3Qk7MG/90xCxw1JJar8m JoreLmj9qJThw+9QK6wmdP19vLfIhlSwM7PQK55ePZWMItfD/4Q7aEHY2h5lp/VrMKSu+agWCiq 7CP+h8thxiT/FEoJ0mn9bUI8FPi0D1VgLAlFLHEDCgoNS5hEmdMA1kSrj2mTQNaqJYjqAwx6JrB KGygNAiVS0Io+HdN0tRDXuKGYzO5ouN+kymUNyxUw0tcz2e5DmMsUhKyhUUexP/yRxLwCyRmakJ Puy9iDMS3Vgz/tqq68Q== X-Proofpoint-ORIG-GUID: 35bYeeuYFzO2CUO0tEPAHayTmVFkIavp X-Authority-Analysis: v=2.4 cv=QN5YgALL c=1 sm=1 tr=0 ts=6a81cdd0 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=20KFwNOVAAAA:8 a=hD80L64hAAAA:8 a=EUspDBNiAAAA:8 a=XpcZagfQ2RrtaB3tMhQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX4k4G7u3ZEyuC c3fE4GLczv+D0xIY9oYZ4CzsMsf9RDHwDtmrjNGEyKx6o8r90tvWEVsEmIXyvvKj5LUdg0yhZVL rvwNQVpJ5y5RpcMBOgRZOTgU1d+hhNE= X-Proofpoint-GUID: 35bYeeuYFzO2CUO0tEPAHayTmVFkIavp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891788469158501 From: Stefan Hajnoczi The NVMe emulation code unconditionally calls spdm_socket_*() APIs. Add a Kconfig dependency to avoid build errors when NVME_PCI is enabled without SPDM_SOCKET. Fixes: 4f947b10d52 ("hw/nvme: Add SPDM over DOE support") Signed-off-by: Stefan Hajnoczi Reviewed-by: Klaus Jensen Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20260810214846.76805-1-stefanha@redhat.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/nvme/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/nvme/Kconfig b/hw/nvme/Kconfig index cfa2ab0f9d5..cfeeed64cd7 100644 --- a/hw/nvme/Kconfig +++ b/hw/nvme/Kconfig @@ -2,3 +2,4 @@ config NVME_PCI bool default y if PCI_DEVICES || PCIE_DEVICES depends on PCI + select SPDM_SOCKET --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891804; cv=none; d=zohomail.com; s=zohoarc; b=fOAEXvWZtQrO5hoFpgTZDIpMXX/apiJGnum4sjycojlVaIRg/6WJIhU100vSKAxw21tuyBGwa5tVD2Spe1dWXp8STdjxis4jTfSOqJW0n7yd1oHGX5G+QcWS54ksklnRPw7X8R1FousyVUgbsFRidJYZvDuqI+coxh/+N55gxIA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891804; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=MvCTXi7xvNIZeLKyy3ZEPwPDWV5CvBy8bU0QqBY+PNY=; b=kxiO12rJXGpCRlfWSmp7vGq/Aygi2J1E1Z9Vy3gbcRxcVJKC9GVmsq8hVyOU193eqjaJQak3EHqaiKCO2chwMFyc9VSAnxoSMcm6A5uxrcnWyLYylUmqJMGCc6/uUg59MwyF4ftzA3WjyduskPq0QyL28QMKXlmZsrAR1xRKQwY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891804156196.31900356116546; Sun, 16 Aug 2026 07:50:04 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcAm-0004ec-C3; Sun, 16 Aug 2026 10:49:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcAY-0004YE-0x for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:49:07 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcAW-000121-LY for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:49:01 -0400 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDlSwT3632271 for ; Sun, 16 Aug 2026 14:48:59 GMT Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghekq2w-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:48:59 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51c19493ac2so27605811cf.1 for ; Sun, 16 Aug 2026 07:48:59 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f2b1f90sm23386241f8f.18.2026.08.16.07.48.57 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:48:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MvCTXi7xvNIZeLKyy3ZEPwPDWV5CvBy8bU0QqBY+PNY=; b=NTihcudTgJeUn0A7 t3n4/JguRYs1hXDpGe7yYH+nWqgNQUY42Soiw9ac5dQSmRGHkJnitkeD1EU/sXNN SpLB3Ib07mkC3mvvI9wnIldecWeDByQdZ56YIevNAlCX6guaH4kU4g5VRKAHQhg6 litv5YUc+YUyFPUrN/MqoqqR/0pEEJbBdviaQYKaDCx+UM8+O/yChooPYtngPAFP Ujcj3bGipO7tIkpCVTApWKkCmFeVGyanWC0HtqsNKs+2rOtajocLAzVjCH6hq8er nmxsAUyh0dFhyPuZZFgFJF1TIU+FsE9JiqbV3XgGxz2C2PiXZFbpvKZF5Y14ouR9 5Dz4Wg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891739; x=1787496539; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MvCTXi7xvNIZeLKyy3ZEPwPDWV5CvBy8bU0QqBY+PNY=; b=YMERcfG+SJDsNHQs5t/S1ChZBOB2MhLuR+ZlE9p9ob/mCzy+ZR3YZyr4IRlx9zH4C8 QVG70om5YS4a9tXwqoLM/6teY2hcGQs5x5me5WzGmaWiuB1kG0coSWFPwDAr4f7s9yzB gty4rujZi5eqEiAKuCZi0GcBnYd+/j+TIm3RgWoXgM88CIRtqKZvHZzS/LwMxjwGC+aK tIQml7yQJCcdwzCUniR0TU3bv9d14gB3XPTYqxfRDjsmR8ZXwUKG2WIMyR0ddDUHonAW gegJRcYW2RKTcZoOG916FmaTGALxQdWpu8bPb2MGvKWbOJCtQRPKEVguxvPBhDoDkgRI Ja/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891739; x=1787496539; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MvCTXi7xvNIZeLKyy3ZEPwPDWV5CvBy8bU0QqBY+PNY=; b=ea6kEq/8GbczFvY6o/CIRSxpajtWrwlln190VdNTAXpaNZ0sAp48mPdIfCfWY2QIdS BTFxc8prfO7PUoFPlzRLqwfyA/lV+9n0TaqkUazbnqblNKBycVNeen0PIf02AIabsEli O2cdDT0vuuD3WiJnix9JRauLX2PP1ClBNUsI97CUkPnAlaMa1nvrz2czkiAJcAx/4vTY MKUhqaYDeWf/y2N1ekw3zwbSzQ3bakrWdeEVrR7j6VLk8L9nbdo0XChz9aF1QIIiMfLJ N5O3hlwanwYOw/VNcpC4RfCJzqr/LN59PHJf6ZsHOyxny+cntiaPofIYdoT2hwz6Aq9o 0c8A== X-Gm-Message-State: AOJu0Yx7IW8RBTPagvPalMuk9fp/2gN22dbrhX0sX99rilWMaZ14HmpY m7d/NDTnXP1N8/cfa7VIQLq5WKH379mJmEcrvJunb7cJ7er+Y5ShhbdACKTrtmRExB5dkpAon7e Fiy85Omv4vO9b2XoHonUWIZQzhv7G/kRBWDoVAEZSZEOPkGjsIb6OAX74thQ5UQYwag== X-Gm-Gg: AR+sD12A8J2qZhVTbPpUHSvhKKydljL6Ti7X1l/VkEAAZtBOBbL04vsa6e5dwLradkp Ui5YnEyWwn0UkWXsJU4TY8ScwOJy+dp00tvh9veLC2Tm8irLKapMvLgzurfJNXMqfkqfcl4L5o+ F+84T7GED7FVzaHFwCSDHFgPnPeuky3oEYKY7/A4eMHXKZIpECeAPb+3lvqOFqxsq6POh0TJTck QdnF7BNFZNJS+KgqLs3m7jp8arF5mNYbrX9F+Okx4v7C3Bz48+BwYZDoT4LfwQ3kCiT469EXF56 zm0rzfzpSrNrz+RsNigQiEj3a16697Z/UO6kfB8t4hEqs3A0TWcj3jzcO+Ph8E80yAJ3zMtVNIq VhdLs5NxtybFStRJHnb8Az+TQdpxeK5+qSnIgWYRiew== X-Received: by 2002:ac8:6f0a:0:b0:52b:4e1f:940e with SMTP id d75a77b69052e-52d8537bb2bmr218358981cf.1.1786891738982; Sun, 16 Aug 2026 07:48:58 -0700 (PDT) X-Received: by 2002:ac8:6f0a:0:b0:52b:4e1f:940e with SMTP id d75a77b69052e-52d8537bb2bmr218358661cf.1.1786891738554; Sun, 16 Aug 2026 07:48:58 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 21/56] hw/cpu: Correct CPU_GET_CLASS() comment Date: Sun, 16 Aug 2026 16:45:20 +0200 Message-ID: <20260816144556.69009-22-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=EKc2FVZC c=1 sm=1 tr=0 ts=6a81cddb cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=snbnvTbt-5-dSQZ-83gA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX3yCcsTJx7EiN ycPDjmdXp2uNZkUlcG9SbxAk3xEgZfgBjl/wBQ1wO1QCP5sqrnHYJUqIxgp41cwE+rzVQaQhoVE jSmyUKvQg2qyJkes1Pj0uqzprZIRlRs= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfXz+jugkVA5r4H 8I1qxIvgsDZCvEPTwx2EZzSjItEJ/D2P3Meyguv5rmxL4TmbOisqMywNDQQvBVVRcPjQwxi/J5S fMhFVhV2xzvzmgT4GGfvBaxgj1KMO/RSCE4kP8trR6JyFyuwmxjboLynmcrVCOHaGhzKRiWOfTD +jKZ7HPeDDNdnDzp5rxCELhvGZE7qF7jzuthNCg7rGmRNGsGaAoCOFHUcyHV768fb6EhXK9pj0W 6oCuZXnRTEeYD9Ck1VQY/XaMHppTW7u8riX0G7JZC0JFBcxYjt3omlHIgcyg++BFXbp3O6gr8uF SFLFral/KPmSfHjtHIA/VrORm3C6AlxexmPZVejQLnd+ZP7RXgh6PM0Ic0gHIZ62F3Jvj/vllQM sWF2YKBZf3fO8zEPHvdgDmBoVSgI5YyGIS7Q5DgJeI21rwEOBSTsOM/2seQsAReZrML5/GvxoWT ib+wQfxyZsZ4cp1gXMg== X-Proofpoint-GUID: E6bPS8aZ_z0GXen4rZ-h7oMi_u-UJuMZ X-Proofpoint-ORIG-GUID: E6bPS8aZ_z0GXen4rZ-h7oMi_u-UJuMZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891804529158500 commit 0e86d7a71e8 ("cpus: Cache CPUClass early in instance_init() handler") renamed cpu_exec_realizefn() -> cpu_common_initfn(); update the comment. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20260811183410.22428-2-philmd@oss.qualcomm.com> --- include/hw/core/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index b54035fb13b..c5064a5449b 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -60,7 +60,7 @@ typedef int (*WriteCoreDumpFunction)(const void *buf, siz= e_t size, * expensive given the eventual call to * object_class_dynamic_cast_assert(). Because of this the CPUState * has a cached value for the class in cs->cc which is set up in - * cpu_exec_realizefn() for use in hot code paths. + * cpu_common_initfn() for use in hot code paths. */ typedef struct CPUClass CPUClass; DECLARE_CLASS_CHECKERS(CPUClass, CPU, --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891809; cv=none; d=zohomail.com; s=zohoarc; b=QybYnn9D3KXgAQiOULZFH8Hcw2EWVc9PnYxfPQfuMDriDzcQF3trorYZask1p/VbgzUHhF4qTUirhSBXcSHV8vLkNtsLX9u+4v/lGjUXbJKWKc+7oEzzR7phu/zkXawkcPp61ZguNw8w9DiNTPGXctBZzpExGki/t648NPiBItA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891809; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=YuWFBrxiGzUvfPEtcY0H/fClp/z0hLFGaXj5dBbppCM=; b=X2pQdhqbbSdzUSLAT2WlVb61CaiaCZTaZsU6oHHw+zg/kxIIhUkEqPZPLUwtLTTv80zXtZsdgEpPlFyBEIuvOIPxz+tzX06rxXEjfWjILX13isEyLk+ZDaz/n2fmx9sGbuA8ca4NpCAbancD3E3cnP6XANWDz/8UjbHyk4fn9Tk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891809427909.13985161465; Sun, 16 Aug 2026 07:50:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcAp-0004xL-IR; Sun, 16 Aug 2026 10:49:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcAh-0004Za-Hu for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:49:15 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcAf-00012W-Dq for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:49:10 -0400 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDl48D3449783 for ; Sun, 16 Aug 2026 14:49:07 GMT Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghk3mtx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:49:07 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c1b4d961dso23446171cf.1 for ; Sun, 16 Aug 2026 07:49:07 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49996128cffsm47386945e9.15.2026.08.16.07.49.05 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:49:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YuWFBrxiGzUvfPEtcY0H/fClp/z0hLFGaXj5dBbppCM=; b=HyZoUVpXbWk0h0Q8 ttEclAOjI3uYVajYOWaOv0M4YndX66tW/+nSdS/zfGdtbBjgJusGC/VYQlPZ1DyJ BsB1hbUnMPYV0pPz/B0nw/aaluxky8SJXbdw7++Myxm9+/BWCSY1MPObSf2N3SCV kOqvPjv8CBWzJJ0h9po0KOAjmbeY/PwHQsO3MZb1DaFJYX3UAFQ68frrRQ6a5DPc jdeKwc3n048tNdDL5YE14N1NTZtgeYn0lnam5776iVX2oxeuWv6ncj8iBippXkdF tO2Cn3EbW2M35iKtEzHgaqszot70JkvPmkL3WDAcpVabCNCWfWBnGBW+xeDOBcLW Bb8l1g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891747; x=1787496547; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YuWFBrxiGzUvfPEtcY0H/fClp/z0hLFGaXj5dBbppCM=; b=FgZ87zsOo/v45NJK6lSULqZIWj/uca6TFVpdTj1DafWs+w1Asw89032L7hQzsdjn0g ykDMwPMyiDuxMol0+AApFJ5bpDoVg3UU+T9tpUktdz5Q3vLmwRqQI5+PBfVu8c6aHBRU 8dCSjDPmKTZBD087i+vt+mPDq/DZG+AZSRg3tx0ek/K4VGHi4xw3Pht6WiyinC/IkMKj QktrEA0q7I4uXlJ5fCqA3v/qzFXPWrbh9hvAeDA2+IBiV4jRSH/ihd6aHz9O5Q2+G5K5 9x0yY2VzweZhj4afjvW8e1v+0vBhpuoLmCwMfH3uIn02v2NXn2FLkOZ/8VHiibnCa7OG +X5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891747; x=1787496547; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=YuWFBrxiGzUvfPEtcY0H/fClp/z0hLFGaXj5dBbppCM=; b=n387iVynkpZCdt1bX8iQQ8H4JgQz9wh/goYNzTk7SvWCa585C7HTue0y6JN56tSqLE mdlCfsQ8V3H3918wvNQ3N/Mc28NIPlo7ygg4O2HM3UDMwZQeePCTHIFyEMx4K/Hj9V1J U+guUM9hdLi1CoQjUUVh3bBlJP/ZwxnbQ/snVgIUrQjMpMIylpII0ELkBrDj3MxSAA6b cKgPdzGmqaXgR4k1PCwzqP308EVCt9pujFWmeo15jK02IQa26W2BeXAJJVc2BHj4EJP0 J0I2u5WX14ECJ/PF+On52aHpBHLhpvNcEYiOV3UJTsqWqjkZeDIwjS6FS9SbjJqdsNhp TgUQ== X-Gm-Message-State: AOJu0YxlsOAww69LpfprjFG0+l64IuVnsT8LLsftkzqaOGQEL5cWV7Xq KzFlBipGCJM/+Lt7+LgrG2bJxMqZcG7u9LEXlPazU5adavA91hV+uinscUkIxjZt28mV1l25PaN 4CDReBlvOf7tOqYfKtAI+8Oyde+n9S0ntZ182BKV/61lX7R22zCIPh6A2AdLEKwwGHA== X-Gm-Gg: AR+sD12n2CwAhqt5lEta/Y6tJDU5IsER79fXazjlraKWj+NaEi35ITSbd5tuUOv5+k+ WsCEEDPUMZ0i/MH9zfA2fnskQnk1tL471BBJv6hH4YAIgq3kguJJLve8v0hF81FG0ZYxhWaJfoO K1uC2qM5tk5ie4KX+/xZHVNGoomkG2pZ/fakQMUD5Hr15wSpahu8fFKu9Ql/snBDX072Rf63kNo M2wvHiDXZtmgIl7DIJHO2pCVLluaNJKuIIJ94dM5Dsp6jJSZJ9pLHXCjY0U1puxdGCAoJc3IpbC P1BeghFL4Vda9enmZAXGSKfc/BfH4ieosLxusa/zhuY2DEMkbYONA2MakhIXDGw4Lwr6a3332UY Th2HO61B/t4oeAoTr/uQdfIkN/Wrepj9f0LZCnfxgTg== X-Received: by 2002:a05:622a:4c89:b0:51c:291:82eb with SMTP id d75a77b69052e-52d74b40a81mr283272301cf.14.1786891746980; Sun, 16 Aug 2026 07:49:06 -0700 (PDT) X-Received: by 2002:a05:622a:4c89:b0:51c:291:82eb with SMTP id d75a77b69052e-52d74b40a81mr283271991cf.14.1786891746581; Sun, 16 Aug 2026 07:49:06 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 22/56] hw/cpu: Include missing 'qemu/accel.h' header Date: Sun, 16 Aug 2026 16:45:21 +0200 Message-ID: <20260816144556.69009-23-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX9eNrK2ds2V3u tdn93KPsqg3Lj2HF9nML1DiKGluyYyzwMOk63IH4GotkSREPf5BPBB4oe1hIu5hrYkGPQkgC9LU XmDd0kg6yCYoea0wVDUwLPcyWsA8efw= X-Proofpoint-GUID: MTdKgU4eCdfnB5O5EHI_ebpU0KVvGTAg X-Authority-Analysis: v=2.4 cv=f+14wuyM c=1 sm=1 tr=0 ts=6a81cde3 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=dLWNzQe4hjyqgpnSovcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX24b2Pe3lHlOw scw4ORwc4HdJ/edhXYMZy6Z8p1VdVd6s26Xc/y2Z2kUfggCDM3EPO95yXtxA3011aq122JFnRNG mQnl13YpquuHdX1ZMgzR5eUJniW4nMTgQG0Bmookm/wy7iFRET7ilhE/u6+QQKYMvvO5x4RDZ71 nJiD08v0mh+g7Wg11l/9ciHBNmZ0CyMr490Id2oKAVo5PtZWzq9pzqwSGR0QkMIId7VajFtz8v7 FBPzYI+0JsyZ1IvHgc0cN8bX82XDBTKQgiSiWkJ2MYbtwIeuUy9Gf9SfP9dNsD2eCvD7tCIyvam SMBXRhvRQ+ua/IS4R064S98HWRV9ksPKHGjTCHYvpxpXzKOTqGrW5J6NL5zOjzLanTwRe2Kkagf dZZb8qi0Wxa3J3z07JyotnkXwQdxB/GDvk06s9RZzK48yTqwnLLrOKo6xBMmgBJKXdJPqJe6r3c 42eKi14kI1FKebBT9lw== X-Proofpoint-ORIG-GUID: MTdKgU4eCdfnB5O5EHI_ebpU0KVvGTAg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 suspectscore=0 bulkscore=0 phishscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891810550158500 From: Philippe Mathieu-Daud=C3=A9 cpu_common_realize() calls accel_cpu_common_realize(), itself declared in "qemu/accel.h". Include the latter, otherwise we get when refactoring unrelated headers: hw/core/cpu-common.c:233:10: error: implicit declaration of function =E2= =80=98accel_cpu_common_realize=E2=80=99 233 | if (!accel_cpu_common_realize(cpu, errp)) { | ^~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20260811183410.22428-3-philmd@oss.qualcomm.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/core/cpu-common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/core/cpu-common.c b/hw/core/cpu-common.c index e314f916f84..8c9ff25e04a 100644 --- a/hw/core/cpu-common.c +++ b/hw/core/cpu-common.c @@ -23,6 +23,7 @@ #include "qapi/error.h" #include "hw/core/cpu.h" #include "system/hw_accel.h" +#include "qemu/accel.h" #include "qemu/log.h" #include "qemu/main-loop.h" #include "qemu/lockcnt.h" --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891779; cv=none; d=zohomail.com; s=zohoarc; b=lj1SUmdAGzNe3b5xbTeNy1Gx+j2/Ri2dkxYjz9SddK1XVAjjGrOq5kDl54ZYWeanZVyIMnAIqXnW6ItAEfwbBya3UdYYU8sw0eDJfwyrL232+BoJ3kfetzEj/b0RPAiYvOihMqH7+n2jlXt50sSGdKfVOzUyVfLm+Mo3FLYZstQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891779; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=fylwWBOb4eq+QCeRtYTXtDQS9okWQ8UEKVzFr5dTOhA=; b=HMvxnn5cvyhanFLCOjTks5yDslEFMCHf0RpDyu8vWlKN7/f33Dc/W9TfGW6lUzahrQn70sR1Nb2RO1+mYC+37aeCIWFLw7h0eNmLFpIwcdrBjzpgpujJf3J25yytA+jSk19H872dnHVivUvOU0E1nXubXUd8mXE7uU4fwpLsdJo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178689177990121.481668256677494; Sun, 16 Aug 2026 07:49:39 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcAu-0005Es-HF; Sun, 16 Aug 2026 10:49:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcAp-0004ym-Qr for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:49:19 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcAn-00015m-VW for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:49:19 -0400 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDlLhA3450025 for ; Sun, 16 Aug 2026 14:49:17 GMT Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghk3mu7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:49:16 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51a8db414c7so37409051cf.0 for ; Sun, 16 Aug 2026 07:49:16 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f2cd7ecsm24527480f8f.36.2026.08.16.07.49.12 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:49:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fylwWBOb4eq+QCeRtYTXtDQS9okWQ8UEKVzFr5dTOhA=; b=OUkW8O6xCA/9i4vU MIhng9xcisqWQo0EvoGvvplfszJrvDtP+4BezrjRXk/rgMBfb9TDvVffGkljbdEH 7f04aFBlnRzX4uxN1pJbLtNmply6YbiWpoEXLmc4pviEo7ec4f1PvlMKJNmQUIpv D4bdk/sSXcTvgwJYMmYh2nCOJ+T/xMcYrCq4ZcOSGHQhIDYlBmFF3aGF62Jsq2aD mm3KYAuWdOla4Y/woPwwiqwg6ySZ/cKX8KUuO2HXPNrj/m7Xruy51H/n2hNXM8mr ihTdaxfieRwJ3xIb+aadG+wEERBaaEKErpIQzAfGQRIIuUH7clQco2BylkrvvZHO TBFoIA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891756; x=1787496556; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fylwWBOb4eq+QCeRtYTXtDQS9okWQ8UEKVzFr5dTOhA=; b=f1V68rr9hhJbUobmiG9Y3u1PmRvQPOn+P42+WFOnMlwRs/11Zgnf+B2pnNyePP7ahv ri40NGirbjG/7pZbOavcRMO0hH91fzJsMIhPxGXTZPL6GnGqlmWbNkkIHM8K38+3/1lD FqgkykaLakHEJLsvJ1I6rl0VJGekE3WCVgAGXy3ms5Q+pEcSyhQWseQsBBv+HZ857rbo 3iM9FwkABk8KS9SXCYEz8b3biOGyUA533ZdgvtuXNH4/8Fs6+3ZODZfJBxUk6M83qTdZ xt/yCAkjKTrJv4HLHnEn3kpfbbgYlhEHICBGle2KPERGJRmgCVM7eVN9G6AIi4dkIuGO /6iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891756; x=1787496556; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=fylwWBOb4eq+QCeRtYTXtDQS9okWQ8UEKVzFr5dTOhA=; b=Lsu0uRd9xRpQppd/kMyDzEG3Z9kq7yhuAJWY+b11ClMlTxV+D7KET9QjPNUMLy+Rl4 56qnIu31Zy7ZLcMjDC4WqmpZEXKD6i/7oih0MB8Y2l4hklmdgCb8G2JGzuo86qU/RBc7 FnSgHeXW2bLTE2lqwu25YVikqzqQoO8huCyzy/uJRKql/hMpS2xSj6VOzT9yFBIGv2aZ NZu8m4IGOU376+4kzlBL42GedPpowzh40SP1eclLlUB6moYlAOS2tx7jAkYbzHTRTP1N wPA0hOB6xOc8R9fGJ/1FFkqSSS3VAsTl76P7cdjvfsTc0Zg2EnkhNmBtwwjn2J3ZZKMo fFLA== X-Gm-Message-State: AOJu0YxJ3pgxX1TQOxZK6wo3GELiStHo/oP5/KsUypvqSYjMvX9JdmhV G/HmHjEV2VuDXXTDGnYfjAuzti5837bRCF/fe1LMCeYE1PkYkTgTLmBg8HjOI+0UMb8HxwcPruJ 4iY45EGvKZX7NVx1qJ4LE07leaTkhw5Tayaj42Mg5FGTkstuXw2OPCXPQiPm4XuAqBw== X-Gm-Gg: AR+sD11dReWIq28LdY7ZmlPMQNKgz+QuIbX98aO4XHNKYXD7rUVamnAoiTc4b1DalUB wbqHbe903N2GLfSp1Ez2rcspuwYJia0CqMih2oBTSaPYWdnmlIK0ENwevH1DxI+frK/mXsmecLr STdQtz3vBL7E7nOSNnFkm5ZlBYb15ym0t83k9Du1ufyg3NmRbNJ3nnY2oK9ARPkZcENPD3h4Kue mwthowP3OpJmYsdqeM08yQm38+jHnnjsjxPbL7bXO87IdkY9ly/65PIs6UuWZI4KsOUsxHBSFID h1IyaaZy1HFB1hHYHzpAtkhbjrn9E4h7tDMmR5yVSdgHDLlAXOeReyUmHjpDG8dXA2GTkyzCXDj 5zfqFUcMFvJ0N5LYP5Vrz//gGs+eOaYQmGZm1K1lVrw== X-Received: by 2002:a05:622a:258c:b0:52d:9a3f:85bc with SMTP id d75a77b69052e-52d9a3f954fmr105178381cf.18.1786891756094; Sun, 16 Aug 2026 07:49:16 -0700 (PDT) X-Received: by 2002:a05:622a:258c:b0:52d:9a3f:85bc with SMTP id d75a77b69052e-52d9a3f954fmr105178091cf.18.1786891755653; Sun, 16 Aug 2026 07:49:15 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 23/56] hw/cpu: Move internal declarations to new 'cpu-internal.h' header Date: Sun, 16 Aug 2026 16:45:22 +0200 Message-ID: <20260816144556.69009-24-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX2QA5hV844L8j /ezB0aY+GXd138KalaVYC+saBjr8ycuv4bUBNMeGusGxBUkMV30En1JjgPmYnD+4UmveFXNTH/F w1qJtk7wBQy56G5QpJgOi9GEGr0qNok= X-Proofpoint-GUID: h1XO6CJ-vXkg1MoyMofU_dp8EtjYhjht X-Authority-Analysis: v=2.4 cv=f+14wuyM c=1 sm=1 tr=0 ts=6a81cdec cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=S56xvJB5AAAA:8 a=QyXUC8HyAAAA:8 a=FTwMDBjRCo8fwpzlDxYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=cvBusfyB2V15izCimMoJ:22 a=MH9Ivq0PDQRhlrFuIVvX:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX4+k0O3YI7esz sAwq+F/z69jR2WGTohNScvL0XFRELamCxA4abJCh9jK3bUEftFzZUVswXSRUGelEpaSMtMsIR3u EjomxtGjB0SMqzdZEwRx/Lf6RF7e6JbzbHJiq/oAOYOieMEBVsou3G2RVlg9tS+sRQQMeqBUrXs 0df2m4YZ286pTUD+AwB8JHaK0wlLbqr1x/7BoGZtD22QQnofgKuFmaCFUQpcVhRWH9tFkZUkTl9 lvLRem0NUvrG8ItPADHWcuM6xwwbd3+iNFiJmD+plFKs0RtXAhAH1TJamCWPQS4Yn9x7XKY60Vg iIlX2+vDuQEv956t4JTwuvCKEqSBuNMirv0RKIkiVH2n7lK0p0bq136mou0gKAvvr4l2o9wEa0A 5uh5b3INGmN22/AvUBevWw6UI0A+Qpg1EBu+kOnEMQD6/ih+ozlK/g/XyliZcPvWFQbFnbTXOc6 P/ogxkwp5QQlDbhZUQg== X-Proofpoint-ORIG-GUID: h1XO6CJ-vXkg1MoyMofU_dp8EtjYhjht X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 suspectscore=0 bulkscore=0 phishscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891780582158500 Some declarations are only used within hw/core/, in particular by the 3 cpu-{common,user,system}.c. Restrict the declarations scope by moving them to a new "cpu-internal.h" local header. Rename cpu_exec_initfn() -> cpu_exec_init() because we usually have the 'fn' suffix for handler, not API entry point methods. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20260811183410.22428-4-philmd@oss.qualcomm.com> --- MAINTAINERS | 1 + hw/core/cpu-internal.h | 22 ++++++++++++++++++++++ include/hw/core/cpu.h | 6 ------ hw/core/cpu-common.c | 3 ++- hw/core/cpu-system.c | 3 ++- hw/core/cpu-user.c | 3 ++- 6 files changed, 29 insertions(+), 9 deletions(-) create mode 100644 hw/core/cpu-internal.h diff --git a/MAINTAINERS b/MAINTAINERS index f249be744e9..c296dd5abfd 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2093,6 +2093,7 @@ Machine core M: Philippe Mathieu-Daud=C3=A9 R: Zhao Liu S: Maintained +F: hw/core/cpu-internal.h F: hw/core/cpu-common.c F: hw/core/cpu-system.c F: hw/core/machine-qmp-cmds.c diff --git a/hw/core/cpu-internal.h b/hw/core/cpu-internal.h new file mode 100644 index 00000000000..ae6a31bca2d --- /dev/null +++ b/hw/core/cpu-internal.h @@ -0,0 +1,22 @@ +/* + * QEMU private CPU interface between user / system modes) + * + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ +#ifndef HW_CORE_CPU_INTERNAL_H +#define HW_CORE_CPU_INTERNAL_H + +#include "hw/core/qdev.h" +#include "hw/core/cpu.h" + +void cpu_class_init_props(DeviceClass *dc); +void cpu_exec_class_post_init(CPUClass *cc); + +void cpu_exec_init(CPUState *cpu); + +void cpu_vmstate_register(CPUState *cpu); +void cpu_vmstate_unregister(CPUState *cpu); + +#endif diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index c5064a5449b..6490fb070f2 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -1178,12 +1178,6 @@ G_NORETURN void cpu_abort(CPUState *cpu, const char = *fmt, ...) */ void qemu_process_cpu_events(CPUState *cpu); =20 -/* $(top_srcdir)/cpu.c */ -void cpu_class_init_props(DeviceClass *dc); -void cpu_exec_class_post_init(CPUClass *cc); -void cpu_exec_initfn(CPUState *cpu); -void cpu_vmstate_register(CPUState *cpu); -void cpu_vmstate_unregister(CPUState *cpu); bool cpu_exec_realizefn(CPUState *cpu, Error **errp); void cpu_exec_unrealizefn(CPUState *cpu); void cpu_exec_reset_hold(CPUState *cpu); diff --git a/hw/core/cpu-common.c b/hw/core/cpu-common.c index 8c9ff25e04a..17d76580930 100644 --- a/hw/core/cpu-common.c +++ b/hw/core/cpu-common.c @@ -39,6 +39,7 @@ #ifdef CONFIG_PLUGIN #include "qemu/plugin.h" #endif +#include "cpu-internal.h" =20 CPUState *cpu_by_arch_id(int64_t id) { @@ -326,7 +327,7 @@ static void cpu_common_initfn(Object *obj) QTAILQ_INIT(&cpu->breakpoints); QTAILQ_INIT(&cpu->watchpoints); =20 - cpu_exec_initfn(cpu); + cpu_exec_init(cpu); =20 /* * Plugin initialization must wait until the cpu start executing diff --git a/hw/core/cpu-system.c b/hw/core/cpu-system.c index 14eb4ed87f8..8a9f2fcea84 100644 --- a/hw/core/cpu-system.c +++ b/hw/core/cpu-system.c @@ -30,6 +30,7 @@ #include "hw/core/sysemu-cpu-ops.h" #include "migration/vmstate.h" #include "system/tcg.h" +#include "cpu-internal.h" =20 bool cpu_has_work(CPUState *cpu) { @@ -188,7 +189,7 @@ void cpu_exec_class_post_init(CPUClass *cc) g_assert(cc->sysemu_ops->has_work); } =20 -void cpu_exec_initfn(CPUState *cpu) +void cpu_exec_init(CPUState *cpu) { cpu->memory =3D get_system_memory(); object_ref(OBJECT(cpu->memory)); diff --git a/hw/core/cpu-user.c b/hw/core/cpu-user.c index 25aa25ad240..c2cb00a85d3 100644 --- a/hw/core/cpu-user.c +++ b/hw/core/cpu-user.c @@ -11,6 +11,7 @@ #include "hw/core/qdev-properties.h" #include "hw/core/cpu.h" #include "migration/vmstate.h" +#include "cpu-internal.h" =20 static const Property cpu_user_props[] =3D { /* @@ -32,7 +33,7 @@ void cpu_exec_class_post_init(CPUClass *cc) /* nothing to do */ } =20 -void cpu_exec_initfn(CPUState *cpu) +void cpu_exec_init(CPUState *cpu) { /* nothing to do */ } --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891774; cv=none; d=zohomail.com; s=zohoarc; b=kAH2ojflXH2sCNMoKmbhHNrrXH/T2vImHO+Agcz0NcrvjTt1//7WasMb9sOdLMEowGUBCWe024Gj6DC0LrAV/sO86NIUhBVLw6jHJ1IgZXnoZk9y5Pi7jPPrA38zOBCHBHdRwiw+E0EAp/RZ0L3aWmfnYUlG3LPO5kH347/VYfg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891774; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=tKpuyMGaRViAw5qqhhwkzkOnY6rea4H8ljzLpjQo2I4=; b=h7GVXzSuVUmP8LajXYE2JbaeOqqVgvaCbLGoQ7gE32u7pdoMd16h3JkmEItlKjdqlsQjL03b1aO/mSuZwLNs7JLv9KALiXAV7wg/LzXVgtrPW4U+FEqYGEBHouNjI+zNS/5q3CaUOOlOGGspz2/D6h7z9XISh6jxm+oJ5lze+9U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891774421711.1573442393229; Sun, 16 Aug 2026 07:49:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcAz-0005QG-3E; Sun, 16 Aug 2026 10:49:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcAw-0005L2-LW for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:49:26 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcAv-0001CF-1S for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:49:26 -0400 Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDlt9p2762112 for ; Sun, 16 Aug 2026 14:49:23 GMT Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2h9gkh4f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:49:23 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-52827090cc5so34231661cf.0 for ; Sun, 16 Aug 2026 07:49:23 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49996109652sm70956165e9.4.2026.08.16.07.49.21 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:49:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tKpuyMGaRViAw5qqhhwkzkOnY6rea4H8ljzLpjQo2I4=; b=HjGbKygzYkLYg/tk 7TkY7zEUMk/giTYozobXmNeCwPPDr/vWTDSrpWwmMyeEezdhpgjwPFA1SDZ0M9rv G/9E4hDynh6h79h8GkzfxPmDcfJzSKXOexK6iHh1wIiE3FJaOEicsfuaxqypEigD oMnlv7mUqlF3Qn4jdskwhsOGX6yIx6T+9qf07x/2cXb+0plK2+wbsFUUtCO3K0/F eWwNsEM/exgKqw/H50PnxT4kDLnTB3WfrKptP3TI9Pg/MgSDaREjqWOxjX8eGYuo uyUOzflzKO0PRYGSOKxeYzxB+o6gDywyet31ctCkelnOXgM/ODEezJMla18a3ga4 DP+xbA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891763; x=1787496563; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tKpuyMGaRViAw5qqhhwkzkOnY6rea4H8ljzLpjQo2I4=; b=d0XNMkfF4aDFZCyJ/2EfJmTVDFqaDUJ7jYaV/dKxPzjt+PTI1mNq8V6d8n7QY5BIC6 SNZuRMw8oNGPEMvuxDh6JnjBbNAluAfWXW8Am7NXaLIWliUy5uRyhz1qQm1lpjRBFtTx uQHGipAZGfT6mHceXnAZfXuKSuoSg/V81dZ1wKgBOHihEjIDAzQeKYCPYh4vk6kIlwsR Zxzuj+zpWpFmFEGDvMB1Xqthfa0uFbpi/ZPgxIXzdNXKgRMEOh0jr2/JIrwiOZ/RNHga urpbUMhRqGpVAQWyvQPHEurWk6P4cWfUcCTXc446a5Cdv/zldf927u4dq5pK74gMe+ff /FVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891763; x=1787496563; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tKpuyMGaRViAw5qqhhwkzkOnY6rea4H8ljzLpjQo2I4=; b=UDho6A28IVTjuKt3kZSLcpxu/+1BtCsTdvpReFlWXyg1En6bYBoHLOgrqylcp2FQTM t6N9h60R3nnjcVku/NhA68Lq6ZY9tw8BEQ8pDH5XjaiDiKYRo1pjm/kyXE/fqMvjeUCN nVDy8fKGWoE3H2xN+desrI0ynWkYFUNydd1ixgYWLMw6htd96+zN6UFtz7ZqzLHHaUib Rd3Or9UKx6rdu2Vmvnm7yrTiPzJfI685tnvtPxaRLOZURIksgY72EhV8GV3MmNxtaRZd f5ACndd+GvBFRgmMfNU7BZhGib6QqQpAvHdAYOjbKu4KqBcmwpgXRIoV8ndKjoBmN1vH VPmw== X-Gm-Message-State: AOJu0YyR5AfAnH0J3SybeXKQEsc3mTuaQk6seb4ueJm8r3EDCxDDAT94 lTgJq2FEH144H7yNd1J7JsZ7XzeW18f+HP163N9R49KdkUklY9AcgkwUnitH8ODgWdvL0X0x48/ JhVS9sqCxRvfkq638/IKxBelMFH2lVkQTk60FrznWIvsS3FIJ4V4KKlQ1tm+ODKyNlA== X-Gm-Gg: AR+sD10GYXKsB6qd3DfPu00yYI2UBMDC1RicvQ/c4PRuvcKeie46I03jPuqyueFB/jq NNDLKEqN0OcZWPNejlyE+9WPHdCWJIbX9xJ/3jyQuzrgVPkReLFipRucfnTvDFtvdU9lI2cB3qR hu+8s1QkzmSpHN6ka0VdQ8+fgiegxhSjD4mSncrfjpmjSNIP5UdpdO4KF8qDcBLZl9ZUa6A/dBd QWmt7umoYopxY1DtzqLhCOkSPtPq3+kqxlG/zT1hkSnD5OSn5Hz7euv6nRs0euSmeo8lJqr7JuE EiIQvFOMXw2YG47tH9cFoUcq+2grhGxBPkzbzGVs9DQt0zEmkiGf6oUceL1eBXTJ6/rOGi48YZ3 EdygYu9FrlhntQI6n5NVS3xTZFJxPdtYeuStnBDY1QA== X-Received: by 2002:a05:622a:4cc3:b0:516:d83d:b28 with SMTP id d75a77b69052e-52d74b6ea9fmr288160951cf.17.1786891762715; Sun, 16 Aug 2026 07:49:22 -0700 (PDT) X-Received: by 2002:a05:622a:4cc3:b0:516:d83d:b28 with SMTP id d75a77b69052e-52d74b6ea9fmr288160671cf.17.1786891762284; Sun, 16 Aug 2026 07:49:22 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 24/56] hw/cpu: Rename cpu_common_realizefn() -> cpu_exec_realize() Date: Sun, 16 Aug 2026 16:45:23 +0200 Message-ID: <20260816144556.69009-25-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: UGdzGIHBf_vpAs4UjWhXwQClvYxV2WTt X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX1wBqPNlecteO UUehQrckMgRZhrnXZDA9S+6uGrvNrHQlCtTOkB8tmEWanHwt96jZwYxRRQeomFRokWalldV3XsR voldOXrIYgAdXPunMpdnJbQYvRWuluw= X-Proofpoint-GUID: UGdzGIHBf_vpAs4UjWhXwQClvYxV2WTt X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX1ziwRzmB6CoM mENp5I7+wvy3TdVj//aybzYMjD6lCrmorSk5Xo/ctnBsvTdYA9gH5Jn9OROb4rWmzB8OfBIM489 rbhya8eahZBA//fT5mA4nULrGXRiYIvD9OSABgYS4kY3r4knMBiqUZEW+x5QWTm9QhiKFopnkDZ gh/wsNzlE/3+NPQcZqM5sDxDSNhKSfoz47T98S3HwevwW87npvdYzfY1rAby5oGHdB+HVD8Maxr Sg4Vpj2jxw1CW8AIfMeMd1OOnEzOQClhz7k42NDaHZUxFzlV/IAaoagOGq4ACQeaT2fKRGA2pkI cawEeskNIY2BSZF4ZvjmwUfsiYA/E66dy66wfI+ZFXcNp8yI+kU2+aH1weptjfrpc3js0aGzEO2 qFCzw/XEPViYIC3UUA3xmQoP0XX8Qw2pVlrrOsAzy9bYGVIuYdBd1wHc2NU4hN7QvJki5GHAuI3 hkstff6ym8IDms95F5g== X-Authority-Analysis: v=2.4 cv=XM4AjwhE c=1 sm=1 tr=0 ts=6a81cdf3 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=xWu8-Agft_6X_INOG6MA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 phishscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891776449158500 Keep cpu_common_*() pattern for publicly exposed common methods used by target code. Use cpu_exec_*() pattern for internal ones, mostly to distinct between system / user mode. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20260811183410.22428-5-philmd@oss.qualcomm.com> --- hw/core/cpu-common.c | 4 ++-- target/i386/kvm/kvm-cpu.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/core/cpu-common.c b/hw/core/cpu-common.c index 17d76580930..33e349d4402 100644 --- a/hw/core/cpu-common.c +++ b/hw/core/cpu-common.c @@ -246,7 +246,7 @@ bool cpu_exec_realizefn(CPUState *cpu, Error **errp) return true; } =20 -static void cpu_common_realizefn(DeviceState *dev, Error **errp) +static void cpu_exec_realize(DeviceState *dev, Error **errp) { CPUState *cpu =3D CPU(dev); Object *machine =3D qdev_get_machine(); @@ -379,7 +379,7 @@ static void cpu_common_class_init(ObjectClass *klass, c= onst void *data) k->gdb_read_register =3D cpu_common_gdb_read_register; k->gdb_write_register =3D cpu_common_gdb_write_register; set_bit(DEVICE_CATEGORY_CPU, dc->categories); - dc->realize =3D cpu_common_realizefn; + dc->realize =3D cpu_exec_realize; dc->unrealize =3D cpu_common_unrealizefn; rc->phases.hold =3D cpu_common_reset_hold; rc->phases.exit =3D cpu_common_reset_exit; diff --git a/target/i386/kvm/kvm-cpu.c b/target/i386/kvm/kvm-cpu.c index c34d9f15c7e..e164cef2036 100644 --- a/target/i386/kvm/kvm-cpu.c +++ b/target/i386/kvm/kvm-cpu.c @@ -63,7 +63,7 @@ static bool kvm_cpu_realizefn(CPUState *cs, Error **errp) * host_cpu_realizefn() * kvm_set_guest_phys_bits() * check/update ucode_rev, phys_bits, guest_phys_bits, mwait - * cpu_common_realizefn() (via xcc->parent_realize) + * cpu_exec_realize() (via xcc->parent_realize) */ if (xcc->max_features) { if (enable_cpu_pm) { --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891807; cv=none; d=zohomail.com; s=zohoarc; b=Bjq26KvZOkLh8YmMDWzsEfCfzUkjoLfm/smWwQ4jNy5rvWZLYaxrVKW2UDJ/TEjI8Yb/Ay9KATRZ+AzStqIRtZuQ6egt1U1AcIzzW2yaeNihieJyr8D48+nczT5Zs8zO9do908sPA1PlVGQ8XuqB6vYuHxQJjV3qzitVHZXOWHQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891807; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=5IiCecDbbvfrsNYqbdW15H4G8X7FiNxVC2HhAQiQbN8=; b=TQGzA5l2CHQ4hHOL+jAVSyOBPrLmgJlxleLCl50M6dE+M4IaulzWlLnCPLc5wCzRci0wp2gPqQ2wYJyA/JHsO0+N+dQqfscXazGpdY2YIcto3LFKtR7KsLdOR6uSZg1boIKZDN/OyhnTSXCnAhHMABHfa/v10dFCzmgoDFjpr84= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891807654332.19271761651044; Sun, 16 Aug 2026 07:50:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcB6-0006Uh-86; Sun, 16 Aug 2026 10:49:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcB5-0006Jf-2K for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:49:35 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcB2-0001He-Gf for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:49:34 -0400 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDkmJk3226335 for ; Sun, 16 Aug 2026 14:49:31 GMT Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g322q99ab-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:49:30 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-52d7b3b6aa2so26920621cf.1 for ; Sun, 16 Aug 2026 07:49:30 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f2c1307sm25375501f8f.27.2026.08.16.07.49.28 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:49:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5IiCecDbbvfrsNYqbdW15H4G8X7FiNxVC2HhAQiQbN8=; b=mQm0mp7CJoOINkpB pH9Iu8SDw77NA5lk9jXlKOwGAwtw8hfK8F+XzUxq3q7BXagezbKCJmO+mk2a1SuQ 76i/IG7NqOF/u6X71PfcjOuSSeHax5CmZkFJisrUB3hj5O3KUtsP3HWXZHsxc9m1 LydM88OFTTVZzaiDYodvS7CCXMaHPE44I9LDC3WoP+exsSs4hrrFMU5ShjDkwLPw CFKLY8pjVjfFt1qEQPTJjPW6qyaOsTgiMRf921C0c9Joi6R7hxLhEqgb1gw2U9tI W8efj1in3NviYWcdCnoOZv5ydvuzt03h535+Jo6jiEQW/Y7SOYDml9DuA5cqSdzN as5zig== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891770; x=1787496570; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5IiCecDbbvfrsNYqbdW15H4G8X7FiNxVC2HhAQiQbN8=; b=Wyr8guJq15fUhCSwuNIURsmB2/dWtbjGhnlDzqrvunjF5J4p1A7m8epiCPcml18Bmr iWXKRdXmvIMcRTspBs3hGMByUrpppX92+IEffCcNq+YUvnvSB57fEAFD6LCwzItb4eMB XFnHx13whwtGVG9rwWDOp+n1r+Q0uC9fkXdKXFUCts7twYICVr6AP+6uzSbn2HXz3bZR wI0LiP1WiGWWGXS05H9xDiyLrCDRVO0eUbxmltrM0d+VXPILC6zk7F8riCCmJavmyYCq MC3qjY4a2n1uiZzy86a4XC5JqOny4fv8/lmN3JfNKZjrmldzJm0v3OnedH3PEofYPc5m K5Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891770; x=1787496570; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5IiCecDbbvfrsNYqbdW15H4G8X7FiNxVC2HhAQiQbN8=; b=f24uW9SYh7q8E0eXc4xhUzrqt3CU1ADhTBKWhJziUJ9Lk6YOyL6BlnR0rKHK/jpHyU Pziv94QeTWIuH7VrB+c9wsdyEIrY1x6s9y/ARJAEDU94WWvzMjyKNtMX5V4lh5QIDU+Q y7IiZKT+jk3+DsWZZQKRSIUyPgs11FZtV6/cF7f3oK2jlI+JYSYfzwQ8KtxPCLzzFujG r+R2lIdo+nZM5a5vqcVlU2/rprSrJiUIBpGhe0tkSt85CRVoRhrPjuezXZ+mx46rrwHg 9a6+46X8nXUQ1yrItYNFwr/kgbA9/X7pr4NC0H3DU2eLp8KbBpy/gpeke2fo/xMKVZBh PRQg== X-Gm-Message-State: AOJu0YyoGW2BZp/OO5icG137Yeupo70US/cN7r3Jp2roxF3ryGUZA3KN vsEwIJ1SoOvKuCb5EipK5nBJL7MNdO9ZlWtF8mLe27ORH2R0z12cd40SpOJvoBC+elZeRMM1BhF dQ+g7P5xfDjAdVehPq/oA12yiy4/qeHAZQ4/IiEWYDE/EabjicoMAxAJGmm1WlMlWMg== X-Gm-Gg: AR+sD13E38+pDehk+jT7qH3z47anwX2pdwhUZY0LNjNfneE1xGuUpgQqVt+vgisTTLi O9PPU3eKSnX6H799SgoTvoZ635FBJAEg+OGTl6u2OSVtiKGxUhOo0ewXSxBHG+nJEunZUCuRpFr 093q8wCCq3DF6xy/zTvZPHAiDspYIpjbSeHGhDl2a9PzzQhsCoYdDMwDO6wZx7V2t9CEMvV1vOy CZK6AkVyJ0c0xKWQp1bA+uzgDoywc4k/b7q9LJyArvpaq6XTKi4EBIYsUaJWUHDD9Sq153GHfNJ PEVDcvHvO7cSe993PHKXvjG1f3u2Zt8uN86eXYg+wh2aMigvGB8NFVRnnhq56Jlxd5nx6PQ9v1G GHJErF59TBuYb1Vl8Fp9h4EbZI/u+Lyeoo1e1vw+UgQ== X-Received: by 2002:a05:622a:5143:b0:51c:2633:9ddd with SMTP id d75a77b69052e-52d85583de7mr226925681cf.41.1786891769746; Sun, 16 Aug 2026 07:49:29 -0700 (PDT) X-Received: by 2002:a05:622a:5143:b0:51c:2633:9ddd with SMTP id d75a77b69052e-52d85583de7mr226925301cf.41.1786891769085; Sun, 16 Aug 2026 07:49:29 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 25/56] hw/cpu: Rename cpu_exec_realizefn() -> cpu_common_realize() Date: Sun, 16 Aug 2026 16:45:24 +0200 Message-ID: <20260816144556.69009-26-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX/uGaUNiNftpt 5pyYgf44NwI59EM258+7c8yEj+F07h/J3h0IL0/n6GrqQzVV9UZxJOpfDhthmR0lzvvTdY2nhuk HqXhznd244mKdJrjhG/k6e5NMxMPgfM= X-Proofpoint-GUID: KFku-wx15G0SshgyJNnQ7oc4odd7omy4 X-Authority-Analysis: v=2.4 cv=C5PZDwP+ c=1 sm=1 tr=0 ts=6a81cdfb cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=V_ZmIUVNQuF7PYEw5wMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX67BGv8fEf6CV khHY8NtI54MBOKt1duW8fHTmpwSKuU7cOrcSAHVLO54sjlx/WcMiOcWnxSXKhT2u+4wE0kR1j2E eKjlE1i21aTLkKk2E/RT3IHu8NMwSoMXCEREKfNqFIZjqTWwhqr/YBLXZnUVb2VkEui5zVagZSj wOuUZByG585FOpk6QTHRaBSkhN5yPv6Qz3HtlYWfzqxS2ZLf4yq3zavZ0bcdG8XZG2m/fJDD/1w wwOu0ta7MLQbkYgFLX4nj+s7D6yjP4CqzPLQjJRIit3wtcoLwYH/otP3z1qF5FfjhTMcG3/Oh9k 7FLi6IDs17WWszDXznM+4FFzUPWgtACbpS/nGmVT96UnLR7Y28r3k34lhm/UsRu4Ae3t2YS4sHI xWqqZNAHBz/Bs9qsWXRJHpQhQjrJT49Mjf6SfCztsvWGgZlPJP2/G+kmMPgWWK0dLZxYPvTL2ok lAerzk8DY4JGyiGaYJw== X-Proofpoint-ORIG-GUID: KFku-wx15G0SshgyJNnQ7oc4odd7omy4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891808604158500 From: Philippe Mathieu-Daud=C3=A9 Keep cpu_common_*() pattern for publicly exposed common methods used by target code. Use cpu_exec_*() pattern for internal ones, mostly to distinct between system / user mode. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20260811183410.22428-6-philmd@oss.qualcomm.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/core/cpu.h | 3 ++- hw/core/cpu-common.c | 2 +- target/alpha/cpu.c | 2 +- target/arm/cpu.c | 2 +- target/avr/cpu.c | 2 +- target/hexagon/cpu.c | 2 +- target/hppa/cpu.c | 2 +- target/i386/cpu.c | 10 +++++----- target/i386/kvm/kvm-cpu.c | 2 +- target/loongarch/cpu.c | 2 +- target/m68k/cpu.c | 2 +- target/microblaze/cpu.c | 2 +- target/mips/cpu.c | 2 +- target/or1k/cpu.c | 2 +- target/ppc/cpu_init.c | 2 +- target/riscv/cpu.c | 2 +- target/riscv/kvm/kvm-cpu.c | 2 +- target/riscv/tcg/tcg-cpu.c | 2 +- target/rx/cpu.c | 2 +- target/s390x/cpu.c | 2 +- target/sh4/cpu.c | 2 +- target/sparc/cpu.c | 2 +- target/tricore/cpu.c | 2 +- target/xtensa/cpu.c | 2 +- 24 files changed, 29 insertions(+), 28 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 6490fb070f2..7b7cf330cde 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -1178,7 +1178,8 @@ G_NORETURN void cpu_abort(CPUState *cpu, const char *= fmt, ...) */ void qemu_process_cpu_events(CPUState *cpu); =20 -bool cpu_exec_realizefn(CPUState *cpu, Error **errp); +/** cpu_common_realize: CPU DeviceRealize common handler */ +bool cpu_common_realize(CPUState *cpu, Error **errp); void cpu_exec_unrealizefn(CPUState *cpu); void cpu_exec_reset_hold(CPUState *cpu); =20 diff --git a/hw/core/cpu-common.c b/hw/core/cpu-common.c index 33e349d4402..732e32fade2 100644 --- a/hw/core/cpu-common.c +++ b/hw/core/cpu-common.c @@ -230,7 +230,7 @@ const char *parse_cpu_option(const char *cpu_option) return cpu_type; } =20 -bool cpu_exec_realizefn(CPUState *cpu, Error **errp) +bool cpu_common_realize(CPUState *cpu, Error **errp) { if (!accel_cpu_common_realize(cpu, errp)) { return false; diff --git a/target/alpha/cpu.c b/target/alpha/cpu.c index 0c35067b202..12e86021663 100644 --- a/target/alpha/cpu.c +++ b/target/alpha/cpu.c @@ -117,7 +117,7 @@ static void alpha_cpu_realizefn(DeviceState *dev, Error= **errp) cs->tcg_cflags |=3D CF_PCREL; #endif =20 - cpu_exec_realizefn(cs, &local_err); + cpu_common_realize(cs, &local_err); if (local_err !=3D NULL) { error_propagate(errp, local_err); return; diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 787e4dc7ab2..77aa78f00e2 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -1891,7 +1891,7 @@ static void arm_cpu_realizefn(DeviceState *dev, Error= **errp) } #endif =20 - cpu_exec_realizefn(cs, &local_err); + cpu_common_realize(cs, &local_err); if (local_err !=3D NULL) { error_propagate(errp, local_err); return; diff --git a/target/avr/cpu.c b/target/avr/cpu.c index 35912192126..f8409f32ab9 100644 --- a/target/avr/cpu.c +++ b/target/avr/cpu.c @@ -131,7 +131,7 @@ static void avr_cpu_realizefn(DeviceState *dev, Error *= *errp) AVRCPUClass *mcc =3D AVR_CPU_GET_CLASS(dev); Error *local_err =3D NULL; =20 - cpu_exec_realizefn(cs, &local_err); + cpu_common_realize(cs, &local_err); if (local_err !=3D NULL) { error_propagate(errp, local_err); return; diff --git a/target/hexagon/cpu.c b/target/hexagon/cpu.c index 0ddd898e6e9..7067e5b70f7 100644 --- a/target/hexagon/cpu.c +++ b/target/hexagon/cpu.c @@ -457,7 +457,7 @@ static void hexagon_cpu_realize(DeviceState *dev, Error= **errp) HexagonCPUClass *mcc =3D HEXAGON_CPU_GET_CLASS(dev); Error *local_err =3D NULL; =20 - cpu_exec_realizefn(cs, &local_err); + cpu_common_realize(cs, &local_err); if (local_err !=3D NULL) { error_propagate(errp, local_err); return; diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c index a68152f9682..07b49e51326 100644 --- a/target/hppa/cpu.c +++ b/target/hppa/cpu.c @@ -181,7 +181,7 @@ static void hppa_cpu_realizefn(DeviceState *dev, Error = **errp) HPPACPUClass *acc =3D HPPA_CPU_GET_CLASS(dev); Error *local_err =3D NULL; =20 - cpu_exec_realizefn(cs, &local_err); + cpu_common_realize(cs, &local_err); if (local_err !=3D NULL) { error_propagate(errp, local_err); return; diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 7a2c3cf358d..e5ffb10d156 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -10164,7 +10164,7 @@ static void x86_cpu_realizefn(DeviceState *dev, Err= or **errp) * These may be set by the accel-specific code, * and the results are subsequently checked / assumed in this function. */ - cpu_exec_realizefn(cs, &local_err); + cpu_common_realize(cs, &local_err); if (local_err !=3D NULL) { error_propagate(errp, local_err); return; @@ -10179,7 +10179,7 @@ static void x86_cpu_realizefn(DeviceState *dev, Err= or **errp) if (cpu->guest_phys_bits =3D=3D -1) { /* * If it was not set by the user, or by the accelerator via - * cpu_exec_realizefn, clear. + * cpu_common_realize, clear. */ cpu->guest_phys_bits =3D 0; } @@ -10188,7 +10188,7 @@ static void x86_cpu_realizefn(DeviceState *dev, Err= or **errp) /* * The default is the same as KVM's. Note that this check * needs to happen after the evenual setting of ucode_rev in - * accel-specific code in cpu_exec_realizefn. + * accel-specific code in cpu_common_realize. */ if (IS_AMD_CPU(env)) { cpu->ucode_rev =3D 0x01000065; @@ -10201,7 +10201,7 @@ static void x86_cpu_realizefn(DeviceState *dev, Err= or **errp) * mwait extended info: needed for Core compatibility * We always wake on interrupt even if host does not have the capabili= ty. * - * requires the accel-specific code in cpu_exec_realizefn to + * requires the accel-specific code in cpu_common_realize to * have already acquired the CPUID data into cpu->mwait. */ cpu->mwait.ecx |=3D CPUID_MWAIT_EMX | CPUID_MWAIT_IBE; @@ -10230,7 +10230,7 @@ static void x86_cpu_realizefn(DeviceState *dev, Err= or **errp) * Note that this code assumes features expansion has already been done * (as it checks for CPUID_EXT2_LM), and also assumes that potential * phys_bits adjustments to match the host have been already done in - * accel-specific code in cpu_exec_realizefn. + * accel-specific code in cpu_common_realize. */ if (env->features[FEAT_8000_0001_EDX] & CPUID_EXT2_LM) { if (cpu->phys_bits && cpu->phys_bits < 32) { diff --git a/target/i386/kvm/kvm-cpu.c b/target/i386/kvm/kvm-cpu.c index e164cef2036..da8d77ade06 100644 --- a/target/i386/kvm/kvm-cpu.c +++ b/target/i386/kvm/kvm-cpu.c @@ -57,7 +57,7 @@ static bool kvm_cpu_realizefn(CPUState *cs, Error **errp) * * x86_cpu_realizefn(): * x86_cpu_expand_features() - * cpu_exec_realizefn(): + * cpu_common_realize(): * accel_cpu_common_realize() * kvm_cpu_realizefn() * host_cpu_realizefn() diff --git a/target/loongarch/cpu.c b/target/loongarch/cpu.c index fb03424ffa8..cb07f15110f 100644 --- a/target/loongarch/cpu.c +++ b/target/loongarch/cpu.c @@ -704,7 +704,7 @@ static void loongarch_cpu_realizefn(DeviceState *dev, E= rror **errp) LoongArchCPUClass *lacc =3D LOONGARCH_CPU_GET_CLASS(dev); Error *local_err =3D NULL; =20 - cpu_exec_realizefn(cs, &local_err); + cpu_common_realize(cs, &local_err); if (local_err !=3D NULL) { error_propagate(errp, local_err); return; diff --git a/target/m68k/cpu.c b/target/m68k/cpu.c index 9ad3057d91c..ce2707dee5a 100644 --- a/target/m68k/cpu.c +++ b/target/m68k/cpu.c @@ -389,7 +389,7 @@ static void m68k_cpu_realizefn(DeviceState *dev, Error = **errp) =20 register_m68k_insns(&cpu->env); =20 - cpu_exec_realizefn(cs, &local_err); + cpu_common_realize(cs, &local_err); if (local_err !=3D NULL) { error_propagate(errp, local_err); return; diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c index a97c92a7b68..389a5124b12 100644 --- a/target/microblaze/cpu.c +++ b/target/microblaze/cpu.c @@ -251,7 +251,7 @@ static void mb_cpu_realizefn(DeviceState *dev, Error **= errp) int i =3D 0; Error *local_err =3D NULL; =20 - cpu_exec_realizefn(cs, &local_err); + cpu_common_realize(cs, &local_err); if (local_err !=3D NULL) { error_propagate(errp, local_err); return; diff --git a/target/mips/cpu.c b/target/mips/cpu.c index d72044aef61..669c7d99bb7 100644 --- a/target/mips/cpu.c +++ b/target/mips/cpu.c @@ -544,7 +544,7 @@ static void mips_cpu_realizefn(DeviceState *dev, Error = **errp) } mips_cp0_period_set(cpu); =20 - cpu_exec_realizefn(cs, &local_err); + cpu_common_realize(cs, &local_err); if (local_err !=3D NULL) { error_propagate(errp, local_err); return; diff --git a/target/or1k/cpu.c b/target/or1k/cpu.c index ea29b2e01fa..66c00c0930c 100644 --- a/target/or1k/cpu.c +++ b/target/or1k/cpu.c @@ -170,7 +170,7 @@ static void openrisc_cpu_realizefn(DeviceState *dev, Er= ror **errp) OpenRISCCPUClass *occ =3D OPENRISC_CPU_GET_CLASS(dev); Error *local_err =3D NULL; =20 - cpu_exec_realizefn(cs, &local_err); + cpu_common_realize(cs, &local_err); if (local_err !=3D NULL) { error_propagate(errp, local_err); return; diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c index f404c7e549d..b07e9c3ff9c 100644 --- a/target/ppc/cpu_init.c +++ b/target/ppc/cpu_init.c @@ -6921,7 +6921,7 @@ static void ppc_cpu_realize(DeviceState *dev, Error *= *errp) PowerPCCPUClass *pcc =3D POWERPC_CPU_GET_CLASS(cpu); Error *local_err =3D NULL; =20 - cpu_exec_realizefn(cs, &local_err); + cpu_common_realize(cs, &local_err); if (local_err !=3D NULL) { error_propagate(errp, local_err); return; diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 5a82e6563bf..23b5023dd37 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -1226,7 +1226,7 @@ static void riscv_cpu_realize(DeviceState *dev, Error= **errp) RISCVCPUClass *mcc =3D RISCV_CPU_GET_CLASS(dev); Error *local_err =3D NULL; =20 - cpu_exec_realizefn(cs, &local_err); + cpu_common_realize(cs, &local_err); if (local_err !=3D NULL) { error_propagate(errp, local_err); return; diff --git a/target/riscv/kvm/kvm-cpu.c b/target/riscv/kvm/kvm-cpu.c index 495cb42dc89..97069bf597a 100644 --- a/target/riscv/kvm/kvm-cpu.c +++ b/target/riscv/kvm/kvm-cpu.c @@ -2006,7 +2006,7 @@ static void kvm_cpu_instance_init(CPUState *cs) * We'll get here via the following path: * * riscv_cpu_realize() - * -> cpu_exec_realizefn() + * -> cpu_common_realize() * -> kvm_cpu_realize() (via accel_cpu_common_realize()) */ static bool kvm_cpu_realize(CPUState *cs, Error **errp) diff --git a/target/riscv/tcg/tcg-cpu.c b/target/riscv/tcg/tcg-cpu.c index 4af5cd9c731..9e3cc87f8a3 100644 --- a/target/riscv/tcg/tcg-cpu.c +++ b/target/riscv/tcg/tcg-cpu.c @@ -1304,7 +1304,7 @@ static void riscv_cpu_set_profile(RISCVCPU *cpu, * We'll get here via the following path: * * riscv_cpu_realize() - * -> cpu_exec_realizefn() + * -> cpu_common_realize() * -> tcg_cpu_realize() (via accel_cpu_common_realize()) */ static bool riscv_tcg_cpu_realize(CPUState *cs, Error **errp) diff --git a/target/rx/cpu.c b/target/rx/cpu.c index 20b188c24cd..9b8473d71cf 100644 --- a/target/rx/cpu.c +++ b/target/rx/cpu.c @@ -147,7 +147,7 @@ static void rx_cpu_realize(DeviceState *dev, Error **er= rp) RXCPUClass *rcc =3D RX_CPU_GET_CLASS(dev); Error *local_err =3D NULL; =20 - cpu_exec_realizefn(cs, &local_err); + cpu_common_realize(cs, &local_err); if (local_err !=3D NULL) { error_propagate(errp, local_err); return; diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c index c074e12ba2d..641ea96c8ea 100644 --- a/target/s390x/cpu.c +++ b/target/s390x/cpu.c @@ -249,7 +249,7 @@ static void s390_cpu_realizefn(DeviceState *dev, Error = **errp) } #endif =20 - cpu_exec_realizefn(cs, &err); + cpu_common_realize(cs, &err); if (err !=3D NULL) { goto out; } diff --git a/target/sh4/cpu.c b/target/sh4/cpu.c index 763424695c6..ad2ec28c1b7 100644 --- a/target/sh4/cpu.c +++ b/target/sh4/cpu.c @@ -250,7 +250,7 @@ static void superh_cpu_realizefn(DeviceState *dev, Erro= r **errp) SuperHCPUClass *scc =3D SUPERH_CPU_GET_CLASS(dev); Error *local_err =3D NULL; =20 - cpu_exec_realizefn(cs, &local_err); + cpu_common_realize(cs, &local_err); if (local_err !=3D NULL) { error_propagate(errp, local_err); return; diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c index 13ebb122a38..1bc14b586bb 100644 --- a/target/sparc/cpu.c +++ b/target/sparc/cpu.c @@ -892,7 +892,7 @@ static void sparc_cpu_realizefn(DeviceState *dev, Error= **errp) /* Default NaN value: sign bit clear, all frac bits set */ set_float_default_nan_pattern(0b01111111, &env->fp_status); =20 - cpu_exec_realizefn(cs, &local_err); + cpu_common_realize(cs, &local_err); if (local_err !=3D NULL) { error_propagate(errp, local_err); return; diff --git a/target/tricore/cpu.c b/target/tricore/cpu.c index 472c24ae32d..96e2817dee7 100644 --- a/target/tricore/cpu.c +++ b/target/tricore/cpu.c @@ -99,7 +99,7 @@ static void tricore_cpu_realizefn(DeviceState *dev, Error= **errp) CPUTriCoreState *env =3D &cpu->env; Error *local_err =3D NULL; =20 - cpu_exec_realizefn(cs, &local_err); + cpu_common_realize(cs, &local_err); if (local_err !=3D NULL) { error_propagate(errp, local_err); return; diff --git a/target/xtensa/cpu.c b/target/xtensa/cpu.c index 2015a4e3d0d..7c25b9ab707 100644 --- a/target/xtensa/cpu.c +++ b/target/xtensa/cpu.c @@ -257,7 +257,7 @@ static void xtensa_cpu_realizefn(DeviceState *dev, Erro= r **errp) xtensa_irq_init(&XTENSA_CPU(dev)->env); #endif =20 - cpu_exec_realizefn(cs, &local_err); + cpu_common_realize(cs, &local_err); if (local_err !=3D NULL) { error_propagate(errp, local_err); return; --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891843; cv=none; d=zohomail.com; s=zohoarc; b=TXn2z1jz7nEL2KcnoE4/AAr+224MW/+6FlLMbXDFcRbm8JHGp30r5mEjq53YDn1xc/8jw/6EC9r6gLahEQCvXxfGW0KmblQVJMJzlFG727T0PUPmogn5RZ1S7vUX3ZcCT9aqvZbdycS2dqCLBvNZshMAaX0Eq3KBbSedsST2VmM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891843; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=RssthFJr3Lbp/3ckbKRAPHpFj/rb8+pnvpVX35IpDPM=; b=jG/0fMuOXm5EKORCC1Utiz4zUP9Eqc84NTM5rRgA57pe8tIaQWEiQpAlo7yolUK1wGVpzWebM699/4eVXbORI/Ewn7BJTWWUpEejV6dswUGGkwn9O1L/5beKcaNEEKHLFqGJNt5P9O5FxR+LCG7jAwl6lnEg21wsDj7NeeZOB1U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891843661790.3129683788402; Sun, 16 Aug 2026 07:50:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcBF-0007i9-35; Sun, 16 Aug 2026 10:49:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcBC-0007Jp-EK for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:49:42 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcBA-0001JV-Mc for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:49:42 -0400 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDkopd3609470 for ; Sun, 16 Aug 2026 14:49:39 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghfuk3p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:49:39 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e5fc4c7e9so334233585a.3 for ; Sun, 16 Aug 2026 07:49:39 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4999610e381sm72825185e9.9.2026.08.16.07.49.36 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:49:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RssthFJr3Lbp/3ckbKRAPHpFj/rb8+pnvpVX35IpDPM=; b=LvNpfLJ524odi3gY L5Xuwt1MLHu9DaAZ5+YsNOjAod1W3hr298o3SjIVUZy0GraZB1IW/OkcAEUF3JqL woY2RyfUGY24Es+yebFypxqONDoO3eS4evh0/XbKBvWFtmET5VWhd1erdR6fCEad lXgu67hh5LN7jseyhp7VxdqH5swbCj5pM26TzL7Lo3cnijvMgEzcKGDULhJhWivj Vm9p5p3yc4hiwMOSB5KnJuKJtSUCQrbnPY+WDMYNldmoAGXAc4MHATw8jd5EXKOw LoIXKPczSC6mHmr0g4ywu1QeJa/qMw3TSOTsA9kbO8KzlVY4ScsQ2XEg+YB/kxgn /TPA2Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891778; x=1787496578; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RssthFJr3Lbp/3ckbKRAPHpFj/rb8+pnvpVX35IpDPM=; b=RslRkcWHqKKjXao0FHZH+fSRa+55TtodJl6prFkbTHmcSXrs4NiikjWAl2qLC7F7IZ Pcu0qQahnAffdMiHPdbSMytj2+s5w7ZwDEDAgJAUtbUiPYODe6aJo6XMh0/YChYWsCf0 yB0cYok1cBUa/OFxfOFtxizFI8NWOLJRpY8in2euRdUclylaYx4GBeKxvqbrDxD7eMmF RnQaPi4i8r4D8+0XaszKdTad5ftnULGg7xgKsf6fEZBDNGhlL6uAjCtiPBkY/UDpeQYJ hFSdOyOEjjNXih70krLChJ2Ar+lo8ukLCaUq/seSgHnaz8Se7QjXo/RpemQWOzgI0Gxg q9wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891778; x=1787496578; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=RssthFJr3Lbp/3ckbKRAPHpFj/rb8+pnvpVX35IpDPM=; b=Bj8TFU3C3WBtSndOiG55muYtGpWy2OikLDr8Xy7R7HShLR1LR7W9w5juGiJoTmjQqP A2n0uT3qP1S1NQoFlGtfKcMaQCHZsMTPPbw0ezrWNsGojSLc4Pi+qICPUukVaYD5R6q1 oV2zWv/3LDc/14ZvAMhMuN0SGXcFakFmjZ6zKGd4g5txRBAbSkp8Pa1lZRS8dyTAbJDK OUEwQE0Yo6OuL7dK4eQ/IdUaSxHLl60bArqED2JGy7curevqdCqu0Z+RRtkO9hA18ErS 9s+R4MA5as7PgNG6Zi3DCnqz11KEVxsXVKan0yevQtanEVdkd5jXAbOpYEFdd7XriuP0 N8AQ== X-Gm-Message-State: AOJu0Yybz0lFcRoGQX6Flb62UYSv72KSG8BDBmPKJzevcdaYVNsZE7g0 kNFqE+QZJW7IIfGABAP9z2qhGoMQFbVI52sXHnC64sm4olyTxePfzxNQ/90NPogGTbbG7SCXYDA 5PoISQPvI89Ok89VjeCQ/5x0wGDTYwprVep18KnPlDWDacGMG9/FiW+uYH3WPuYNZzw== X-Gm-Gg: AR+sD117Y/I3Py5WGU5sXUFOSDjkG9v6H/Craq5n9pRVlNuF+UWFeOZVzimqCuHOPNH gS4pYbtizcxy/u+aVXx/zaikTcfiJfZ2CJMtfkNMY2xfvhxiy25WjD0UFcFDJGQcNkHq/atBnbT w6DtaVlagVPRrZ33XxlTRHkUB51XkWJFayFGdGAIRHesLVfeW+7yhINU+y6eNBh3ZxafD/qqNfv OEiHW3boU2Refe5tLs3G6mEgoLtfGHceR0PI6Lo1QizLIBeGhe7sd91tvRNMusPB388/JN/Kz78 zULm7uFczYY+ergDM5OI1E/MAqadBLW+CZ6c+nplPVfz7jlgaoUejIiM8CQ3BsKzp/c6cr8gDKq z82Zm3uYkVj/2sGRgtLVR1MTFRPPB3rKFjQKiviKEnw== X-Received: by 2002:a05:620a:800b:b0:936:41fe:2351 with SMTP id af79cd13be357-936d22e74f3mr2236372085a.30.1786891778143; Sun, 16 Aug 2026 07:49:38 -0700 (PDT) X-Received: by 2002:a05:620a:800b:b0:936:41fe:2351 with SMTP id af79cd13be357-936d22e74f3mr2236368185a.30.1786891777646; Sun, 16 Aug 2026 07:49:37 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 26/56] hw/cpu: Rename cpu_exec_unrealizefn() -> cpu_common_unrealize() Date: Sun, 16 Aug 2026 16:45:25 +0200 Message-ID: <20260816144556.69009-27-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfXwYGJ0FUkwSt1 /MYMO/oyYr1nBD3oVvJIpJYKbwnqzWh1bE8XdNjRoC2Ps/wYDuiWqkqTs2aewoQN9NnC83UL6Oh rNXV2iZH2ZcKKjI42DaMmuHAQVmR29c= X-Proofpoint-ORIG-GUID: B5x3FLBWGoTgDxXuwQNEtGQHUWkKRcEy X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX/7qhWyFjqCg3 EOUg3IqbWm9Fm2/dtL+LM0rQNN+ZpdDThmS+u+5beZWH0TlIF0ETR70JvyF0VCD0rdwp34VXaBd NMG5I80IMlL9OSDm/BPoZ0xPMmAaPdf0Rinjjmrjy/ZWzloOtj+P841VT5XgpYugGK7ID8DZKwv JuO3BMU4A8dwoFO7Nof6OvxdAVPFufdFJnio9AeppoCxOWSYUMKV0h6CPiyMhCK/mN/zYkn+loI XM9ng082JmKpzXGm+ITh83GsssK+RnxOxO2C/iTN1ibh3J2UqtSKJqKAAT7r4eX4E9DLYuBtn0H hmpOI9AsUZZZHzXAtHmMG8tNY7CDAcHcuyMdTtXjEEiKKBUWffGkend4rhU/kp+oWXGZ4TSinhS wYun/RUU5qgBt9hgmIiiOXfiim9qie5roKm8/+mSUvtNJ7aOZLP7a0yxngrkebSP2bFCRFkhc+F YeqJDlFHT3LOJFQP43A== X-Authority-Analysis: v=2.4 cv=TMJ1jVla c=1 sm=1 tr=0 ts=6a81ce03 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=snbnvTbt-5-dSQZ-83gA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: B5x3FLBWGoTgDxXuwQNEtGQHUWkKRcEy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 phishscore=0 clxscore=1015 bulkscore=0 spamscore=0 suspectscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891844639158500 Keep cpu_common_*() pattern for publicly exposed common methods used by target code. Use cpu_exec_*() pattern for internal ones, mostly to distinct between system / user mode. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20260811183410.22428-7-philmd@oss.qualcomm.com> --- include/hw/core/cpu.h | 4 +++- hw/core/cpu-common.c | 4 ++-- target/ppc/cpu_init.c | 2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 7b7cf330cde..81af7b9ee1a 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -1180,7 +1180,9 @@ void qemu_process_cpu_events(CPUState *cpu); =20 /** cpu_common_realize: CPU DeviceRealize common handler */ bool cpu_common_realize(CPUState *cpu, Error **errp); -void cpu_exec_unrealizefn(CPUState *cpu); +/** cpu_common_realize: CPU DeviceUnrealize common handler */ +void cpu_common_unrealize(CPUState *cpu); + void cpu_exec_reset_hold(CPUState *cpu); =20 extern const VMStateDescription vmstate_cpu_common; diff --git a/hw/core/cpu-common.c b/hw/core/cpu-common.c index 732e32fade2..59cd489b713 100644 --- a/hw/core/cpu-common.c +++ b/hw/core/cpu-common.c @@ -284,10 +284,10 @@ static void cpu_common_unrealizefn(DeviceState *dev) #endif =20 /* NOTE: latest generic point before the cpu is fully unrealized */ - cpu_exec_unrealizefn(cpu); + cpu_common_unrealize(cpu); } =20 -void cpu_exec_unrealizefn(CPUState *cpu) +void cpu_common_unrealize(CPUState *cpu) { cpu_vmstate_unregister(cpu); =20 diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c index b07e9c3ff9c..e3a1075aad3 100644 --- a/target/ppc/cpu_init.c +++ b/target/ppc/cpu_init.c @@ -6956,7 +6956,7 @@ static void ppc_cpu_realize(DeviceState *dev, Error *= *errp) return; =20 unrealize: - cpu_exec_unrealizefn(cs); + cpu_common_unrealize(cs); } =20 static void ppc_cpu_unrealize(DeviceState *dev) --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891818; cv=none; d=zohomail.com; s=zohoarc; b=eHHCL5vnI0IJOZYEKNKHqBIGwuc6Z/04aGbhGzJyl6DmfuIfDpuBccCAV0xedLfO3yV6bNBbjXbKbutHfMRgQCQ6gkklzlxUA7BAmJwdNmNyTa+lpx+3V1lFxo8MtW06W36t74FKoono17YMnmyaEwZcIrtaLSOK0n7Aez79cLs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891818; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=XvmSsw6RFZVExmETaa1Y4Yhn6lHhVX5/670/OVLoUdM=; b=I+jR1JJtEKgNAOpuW90FWiNIZJfwtlZ7BzPPTUePhloHg7ZLH9jG3PIsQe8r/tRqQVzA48Dr76arbdtE/ZFRh8nlrhB5+k36uw4vHZOxAwjM7alAwyxtbs0yO397oqEtIkJxjQm64lkNiD6+Q0d1ZKMn0w2hVziMvWiLuEcj3W4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891818500994.795886020318; Sun, 16 Aug 2026 07:50:18 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcBg-00005q-7U; Sun, 16 Aug 2026 10:50:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcBO-0008Ge-5V for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:49:56 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcBM-0001MI-Im for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:49:53 -0400 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDklPj3226330 for ; Sun, 16 Aug 2026 14:49:51 GMT Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g322q99aw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:49:51 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-52769fc3f2eso32724381cf.0 for ; Sun, 16 Aug 2026 07:49:50 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f229681sm21097763f8f.16.2026.08.16.07.49.48 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:49:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XvmSsw6RFZVExmETaa1Y4Yhn6lHhVX5/670/OVLoUdM=; b=EKqxcIk5OwS/0eRX 2kJHuc8RL052+qDF95jZnPpsOVGXm8ONDqM39Uap2KBqj2puldd7onotOurUpbB6 H731qFls5luX/3TdGBKT9Ox55JuzuzxnKzLlVn83M66P7PqM0x4nZ+CNr02Qio/o KERyqZjqf4vU58AcW5kHPczG3ofIqWQVtd525Dm7KyD5W/Kg5vDY7L83/SMG78U/ GdUUFB5XfCurJKoRzAuWaydQqhNo0rjh9bT9exBuQAI+ixj7jww4PylvlA4hZ2Ow e4ZHzh7fA+/6PBORdi0AYKNamfwTkKszxTcyTx702/aHyuZ1Qdq8n9zqGz/wdb/b 9x8nbA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891790; x=1787496590; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XvmSsw6RFZVExmETaa1Y4Yhn6lHhVX5/670/OVLoUdM=; b=Lw6gnl5yatyg0KnSePqZnQhX8EKsQwbVE5hcGeDdbpAf6LrJPKUd+g4kBXYkt8VT9h j3v1z7MzPTWu8sTEUCKZIVmi4ro9GoDYea6PdkpvZWPakpVMl66FFbB6BqSYHainggtA fWp06lr8Be4jJz0GtAIbaXAscBV37Q1la3hb3UOUZArasTT+rYFULR4ku7v7LN1eSQCL yMPTMnIXlkmGHR7NyPNEkfbctnweVQvOCuqFYWwKMJi7wF92E8Wq+kX7I1TsAhL5LzKN pcUJ5034wuSDaP4+u1686KHB2jUsRWW8rh0SsNDfapt3WY+mbt7eicT0lFmwrRKYJ849 Va2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891790; x=1787496590; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XvmSsw6RFZVExmETaa1Y4Yhn6lHhVX5/670/OVLoUdM=; b=rDl9Lxn4UYghKPzVfgp8pceMVNyv8fTFRzNp6LrL50LaPVdbxkGCavkwBx/K7rhEDo E99FFlCSMD4jEIxAJ1zjH2rwJebYvEuCt9pSjUgSgxT2j0B6ZCtWPgGpfJBARJwWu5pF E7U2OYAmzL62Tvl88E4bQCzVeoRd1hjgrigFcSsJCaHSohvuO+/aVjRMLbVqqcRy7qd7 VhEqRU3UB4ZosQiGe/qbE07sOhS/s40Dp63+he4J8Rz4jufsS3qBCZo7+4FWlR1pi5Gq EQmwcVRFtpjXzAoUWz9kF47apPF9DrSQnvMTBfgfj33gV1jVXa/aPEgswgThhONik8Qf sv0g== X-Gm-Message-State: AOJu0YzRT0Mq1wRoco1t6GMKrXw+xt5RKsVYWySHHQNNnkFRNTXnpGK6 dTazMAVYtNcAeN0stE/W0Ht8RPF7YFj2Ai/Jv81MvCeHahqu76O9VDXU79GmKD/YEIafWUojWLc xmO/aTvK0QiQdF8yauZxI0EIfIXKjka+lI5E/8KaaLpPQr3bbO3A70llfezAidxXKhA== X-Gm-Gg: AR+sD13cyfeIiXDfVmZGf3AqOGtiq5Q/mR3g2GL1rPVgJyL3pi/AtXeJhJglBRuBN4G /r1euHvL/iSTj6fc10ap0bPHmmVXzWW/JmU0FlmSEyCxrhi84ipd16iO3md1xV0AsYUI1QYYSb7 Ze7CXZt/fZCjOnyZeSLYC3nX60xcT5/ioH5XQjLxDxjuXm5IVQcPKChD8v+NwImboMeDZLnAjN/ qnmfMzEbQ9p39lYTNzYBiMPpwT/5bQvgBdV5nKNO73Fnu99e5zeZGBnuBXPiorIGWfcZujDGVT4 Alqx1j+SZIHoknlHDr4NQzBpt02oCj6AwsDe5Uzotb9BzfWuLDDfvy4uq5TqQlq3EeDZ/d1sIsk Loj+bWEsV3oXHZ1ywBILwlNYniBRXCxB4xvfC90v6TA== X-Received: by 2002:a05:622a:908:b0:51c:1a17:eba0 with SMTP id d75a77b69052e-52d852f1f15mr223845451cf.2.1786891790165; Sun, 16 Aug 2026 07:49:50 -0700 (PDT) X-Received: by 2002:a05:622a:908:b0:51c:1a17:eba0 with SMTP id d75a77b69052e-52d852f1f15mr223845121cf.2.1786891789772; Sun, 16 Aug 2026 07:49:49 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 27/56] hw/cpu: Extract cpu_exec_realize() out of cpu_common_realizefn() Date: Sun, 16 Aug 2026 16:45:26 +0200 Message-ID: <20260816144556.69009-28-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfXwrzuDvTynYfA FIAQt2hhx9War9cl2rwZoacp594m9cTVTcTNNBJDAwZI7qpfUcuDjwFay9xaqPJxicS9xBZC7Xo tpBATI8D1ktMXWeHtNP/nkEcfPrrVBw= X-Proofpoint-GUID: OALFlbVPOirW5hIy64ehpNawzjN8pFqx X-Authority-Analysis: v=2.4 cv=C5PZDwP+ c=1 sm=1 tr=0 ts=6a81ce0f cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=3ZqzEhZVOs4yraokUgkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX+ejxq+MTTtEx 3VuNF5HCAsu/WTiSlREMWvxKw3k7q9Oall33J8+UX8sZCszfRrdZrrmub081V/wDUo8bLkpkRfI Bme/arP45LIT5gTLkgt0FPlNhX3A+5lA8l1BcFOwKOxCDD1xABu7nnCKhhNRB74/65rrEBqDCZZ n8YPHMXYoFnTWqPI1oL4iRzYslu1xO0hADrofzVvOSatQL3WWcma2k+e/tSOpBdB8ta5Def00nB rFUhyMXKZAgMwG3Ar/o4x9glVE2YVoCmBApa3NbffNmSrN1BRfaPbFejLiTvD5zRbkXJRldcq7H /HQRUuWC8a6BdH15LMHxamM41bX8PU4FM3oBPE7AwjBf8fb8FeM8PE5H+xtxQPGMnlbwkny45UB MNJSB4HrP0/SrwnP9pG+7/TXoia6CkgiCl6mmzUhK655nqZTsEPWdamy7wZauqJDRjsWsr+spnO cMCDaLFwki98jgFnpsw== X-Proofpoint-ORIG-GUID: OALFlbVPOirW5hIy64ehpNawzjN8pFqx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891820557158500 cpu_common_realizefn() contains code only used by system mode emulation. Extract it to a new cpu_exec_realize() helper. In the next commit this helper will be moved to cpu-system.c where it belongs. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20260811183410.22428-8-philmd@oss.qualcomm.com> --- hw/core/cpu-common.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/core/cpu-common.c b/hw/core/cpu-common.c index 59cd489b713..cd7c8763cf5 100644 --- a/hw/core/cpu-common.c +++ b/hw/core/cpu-common.c @@ -246,9 +246,8 @@ bool cpu_common_realize(CPUState *cpu, Error **errp) return true; } =20 -static void cpu_exec_realize(DeviceState *dev, Error **errp) +static void cpu_exec_realize(CPUState *cpu, Error **errp) { - CPUState *cpu =3D CPU(dev); Object *machine =3D qdev_get_machine(); =20 /* qdev_get_machine() can return something that's not TYPE_MACHINE @@ -264,10 +263,15 @@ static void cpu_exec_realize(DeviceState *dev, Error = **errp) } } =20 - if (dev->hotplugged) { + if (DEVICE(cpu)->hotplugged) { cpu_synchronize_post_init(cpu); cpu_resume(cpu); } +} + +static void cpu_common_realizefn(DeviceState *dev, Error **errp) +{ + cpu_exec_realize(CPU(dev), errp); =20 /* NOTE: latest generic point where the cpu is fully realized */ } @@ -379,7 +383,7 @@ static void cpu_common_class_init(ObjectClass *klass, c= onst void *data) k->gdb_read_register =3D cpu_common_gdb_read_register; k->gdb_write_register =3D cpu_common_gdb_write_register; set_bit(DEVICE_CATEGORY_CPU, dc->categories); - dc->realize =3D cpu_exec_realize; + dc->realize =3D cpu_common_realizefn; dc->unrealize =3D cpu_common_unrealizefn; rc->phases.hold =3D cpu_common_reset_hold; rc->phases.exit =3D cpu_common_reset_exit; --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891831; cv=none; d=zohomail.com; s=zohoarc; b=fnzzU4ojJRj0Vs6X1c37XS8Nh1MZJtbLl/DJhi27CJpGQR2EorRuXGwhbWakEDtuLXUrQiCe3x0Lx/lxiFrjTW/nF1gnwzFzIRyxZOGlmAzTldJeBCVw2zo+UDMJqZLrcyRrzR6zizlNNAfaVhjxr9kz2UhHCzZSF5AsHUvAyaA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891831; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=54GFn1ok6djl80fazqWH76nah0qW2Xxhm2gnp1sqOFg=; b=cfDwef6EKsZFL8x6ZxJsFlsRui0P3zBVzZI4SHQDQkf3y5/d2btp6vpUrOxMuNPouoPHCufIQd6aqlaEvor50mI9+d9yZugVI7qNWLArHZgfza3gjiGiv8E4NrUYeLyKGKRMCJH+M3zMRmvDoJ+A7J2o+//HRWfR6O2K2INQodE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178689183198994.52099710272603; Sun, 16 Aug 2026 07:50:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcBl-0000Tz-RO; Sun, 16 Aug 2026 10:50:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcBV-0008Ot-D9 for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:50:04 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcBT-0001OD-La for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:50:01 -0400 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDmShe3952895 for ; Sun, 16 Aug 2026 14:49:58 GMT Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghnumcs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:49:58 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51ebdfceddcso29892151cf.3 for ; Sun, 16 Aug 2026 07:49:58 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499961098cdsm66580045e9.6.2026.08.16.07.49.56 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:49:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 54GFn1ok6djl80fazqWH76nah0qW2Xxhm2gnp1sqOFg=; b=EGyq3SpHirBzlK2Z PAUaR0t+N5FANOmyOuSMaIl8b1tnpRuwyR08axjFgVgL7c2KVLkdI43lB4qjLzKS joZ5chihqbvH3/mhtIv48QEplkTEV8oiYxIeZlyd4vWMciUnvc3lHg+/yLPEtieL T0aBsdSQnpA9qbsONCDEEizzLCiQwwYRJH7XkiX7Ko47aKlpWiGR7sZuKNAQ4xTb MpBkpDhYpjPdgz012auTCFCxyYaS0XGe8bXt9F9xCD9zroc54/06w/c+Fc2IPzai h7rNtJcGvvO/XEZO+8VlRkYp+ZFumbiUqUvhT7d4+n6N6EH5vup7NHV/RCYOo5yY VWQ4Tg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891798; x=1787496598; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=54GFn1ok6djl80fazqWH76nah0qW2Xxhm2gnp1sqOFg=; b=JQpBwjjpw5lpA6Ibnz9E6/iX3Bxm43xeHS6Q/ZcuYQtBIijcR8R+/tPXtZ15VGMFMu nu3+K6LyYJEd380PD5Wup1GaLaSStbuR6I3TO7Ugi5y5Y+fOoEXeWhC5t1+S+0I2kRyx wGUJT9hM09fijpkH1+fMPJbQxi/g2svCp+iEHZtLwzalZkEm/IOV8pmBn7K77esXtHJX k8CsS44wDiUW+6aM/bIEojKdwMyPovxvqntDfMJVts75HAgFr/djLlkzO1iGPaPcDSJ9 dRiBrdyC7PlEJf2Va85gD+gdqde3pLvoEovXyJ7yDsmy0K59Zr6KAuUdahz09fCbD3FD CYxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891798; x=1787496598; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=54GFn1ok6djl80fazqWH76nah0qW2Xxhm2gnp1sqOFg=; b=Wxg3almHShWFACg9sDrPeM8BUBmgGhG+jZPmW1OpVa/5wveMvQovhA0diCYBeJHkbC KiulZJLFJxT2DyGjVK+28/uxSncnbpocnM/WbmHa7ziwZ8fa93Qg0wC2I6J3CBtEu0SN XCVwZFWUYa+y1CRESFCNIywgG31d6fUA1mAUrAI7eXMrqmW8LoOEwCD8Suue1Vw8GMnS lvUh2h/ENfk/twVZnsqk7D5xEF858c6WGfDNVDSXMh5jX8B0EvkVIoBCxx62VbnT0dku hC0eIC179lyAJru1JgeF3rPF2oJFTJVKZBsP8zNPYD3prSe+HCrONC/8Yd5JTdK29BM0 PuPg== X-Gm-Message-State: AOJu0YzBXpb2Hx8fYCKu3I1iaWQfjTkrhs7sZ61Y42AxIy+5pI/rT4Vb qa1zKWIt1b26ZJ25hyHUYDAfcu6rR58LK2y+RwiozV1kSYudqO78Sv31YiHUweHwQF/0njwy53v 3nIu7tDiZgnpMtIkArDQUnnXNFQ+lIy8Abg5UbZevkxGN3DZLw5D7FbSHgcY1GeHlvg== X-Gm-Gg: AR+sD132gHRXnSeTu9r0K2wi4TYs/r9eMphHNyfe1/Ltg3AsFF9SIOZuZXN5+2IE31E LlJNj6eWp3kmplszcykXq3IpwGaNiJFL413QH9zn08bak5dj8srl6dqV9e3QdeyKY+HREj4HVgL OQKpNyxmGNHgRsm4p/mJPW27BPf0oG98MhMPkQWwMOx8YpufAdnzYCmwMdwfgcXZYu2gLk8uroi 4WP/5xFYLFuZE9PKACUzRFdfociZwjT6nl2ukUlUKksfD9E9B8NEvqVgZGJRG2duprRwYzSdsid Xh1HnvDlzjfB2sTCRtGROM1z1yzOfdYDQYJZ3tNxiq4J6GfAWQLV6SUxCnwc01wFYgGthvzurb1 WGXEk2Hb3qhUS5Ow6qkk8aPPb+Qw8N3UWK365GPrYXw== X-Received: by 2002:a05:622a:e0cf:10b0:52d:8c01:5238 with SMTP id d75a77b69052e-52d8c01530bmr108453141cf.33.1786891797915; Sun, 16 Aug 2026 07:49:57 -0700 (PDT) X-Received: by 2002:a05:622a:e0cf:10b0:52d:8c01:5238 with SMTP id d75a77b69052e-52d8c01530bmr108452971cf.33.1786891797484; Sun, 16 Aug 2026 07:49:57 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 28/56] hw/cpu: Move system-specific cpu_exec_realize() to cpu-system.c Date: Sun, 16 Aug 2026 16:45:27 +0200 Message-ID: <20260816144556.69009-29-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX9a/drgaeRTvv 46Wg4aFDMUGQ8IHv0cN5aIyWlh2TOnZm7xS0s4CKFWnIgfuk6V+88wChEaa7GiXLiJhzqlR0unK jiLRpE7m9YiGElYKU7cryv4pf2+R/DWNBomQYJ1BU6Xq+QOAPlSNPd2zGCVTklJ+9BsZ5UI7v1I Fg4HsKlnBYmfJrtzBeWg+Hy2GMRxRs2+A+Ze8tkl08/X5O2rRlc9Q+lvihuTY/XHmcr+X+ldsjp DD2CKOCsbggLZZz+mE+18ViY6SlKbEEMPpiu7MpGcanhvVZsTA4TpWCuFM0GlQuGylDjcCa2mQ3 fRdYhv6/2bii8Mp1+OrcxPN9T48ZATZi2CwaZ+/R5ShUQqLODr9OOB0XDLvgRJjeVJ1yZuWB+MS smya4wXYIvtthdIB8puiFCxojoQfCkzPz3K//owD69VmHE+PJJQleqDfhqhVQa4JDLnNklmnFbw X0QOa1X4cpPpxlZAt7Q== X-Proofpoint-ORIG-GUID: MVPs-l4QKQ-gr85m2kOjM9TlpBPoUyd2 X-Authority-Analysis: v=2.4 cv=QN5YgALL c=1 sm=1 tr=0 ts=6a81ce16 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=pilchTG5AImVgDdFcq4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfXztvyMclLvz1U CRD8WI74SzB6/dMzxLtC9+NpJO0Z+JyF7ZMlm5/1oYWiWTSv82Y6JjUL8L4JD/i8GmsOvsxfDtv 5z8XafhEzFbDkgvH6kji62LZAR8sBwk= X-Proofpoint-GUID: MVPs-l4QKQ-gr85m2kOjM9TlpBPoUyd2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891832654158500 Current cpu_exec_realize() body only contains system-mode related code. Move that method out of cpu-common.c to cpu-system.c, removing the system / machine mentions in this common file. Add an empty stub for user-mode. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20260811183410.22428-9-philmd@oss.qualcomm.com> --- hw/core/cpu-internal.h | 1 + hw/core/cpu-common.c | 24 ------------------------ hw/core/cpu-system.c | 27 +++++++++++++++++++++++++++ hw/core/cpu-user.c | 5 +++++ 4 files changed, 33 insertions(+), 24 deletions(-) diff --git a/hw/core/cpu-internal.h b/hw/core/cpu-internal.h index ae6a31bca2d..44715b44329 100644 --- a/hw/core/cpu-internal.h +++ b/hw/core/cpu-internal.h @@ -15,6 +15,7 @@ void cpu_class_init_props(DeviceClass *dc); void cpu_exec_class_post_init(CPUClass *cc); =20 void cpu_exec_init(CPUState *cpu); +void cpu_exec_realize(CPUState *cpu, Error **errp); =20 void cpu_vmstate_register(CPUState *cpu); void cpu_vmstate_unregister(CPUState *cpu); diff --git a/hw/core/cpu-common.c b/hw/core/cpu-common.c index cd7c8763cf5..4f4c87f33a0 100644 --- a/hw/core/cpu-common.c +++ b/hw/core/cpu-common.c @@ -33,7 +33,6 @@ #include "exec/log.h" #include "exec/gdbstub.h" #include "system/tcg.h" -#include "hw/core/boards.h" #include "hw/core/qdev-properties.h" #include "trace.h" #ifdef CONFIG_PLUGIN @@ -246,29 +245,6 @@ bool cpu_common_realize(CPUState *cpu, Error **errp) return true; } =20 -static void cpu_exec_realize(CPUState *cpu, Error **errp) -{ - Object *machine =3D qdev_get_machine(); - - /* qdev_get_machine() can return something that's not TYPE_MACHINE - * if this is one of the user-only emulators; in that case there's - * no need to check the ignore_memory_transaction_failures board flag. - */ - if (object_dynamic_cast(machine, TYPE_MACHINE)) { - MachineClass *mc =3D MACHINE_GET_CLASS(machine); - - if (mc) { - cpu->ignore_memory_transaction_failures =3D - mc->ignore_memory_transaction_failures; - } - } - - if (DEVICE(cpu)->hotplugged) { - cpu_synchronize_post_init(cpu); - cpu_resume(cpu); - } -} - static void cpu_common_realizefn(DeviceState *dev, Error **errp) { cpu_exec_realize(CPU(dev), errp); diff --git a/hw/core/cpu-system.c b/hw/core/cpu-system.c index 8a9f2fcea84..a64e8c2b687 100644 --- a/hw/core/cpu-system.c +++ b/hw/core/cpu-system.c @@ -25,10 +25,12 @@ #include "exec/target_page.h" #include "system/memory.h" #include "qemu/target-info.h" +#include "hw/core/boards.h" #include "hw/core/qdev.h" #include "hw/core/qdev-properties.h" #include "hw/core/sysemu-cpu-ops.h" #include "migration/vmstate.h" +#include "system/hw_accel.h" #include "system/tcg.h" #include "cpu-internal.h" =20 @@ -221,6 +223,31 @@ static int cpu_common_pre_load(void *opaque) return 0; } =20 +void cpu_exec_realize(CPUState *cpu, Error **errp) +{ + Object *machine =3D qdev_get_machine(); + + /* + * qdev_get_machine() can return something that's not TYPE_MACHINE + * if this is one of the user-only emulators; in that case there's + * no need to check the ignore_memory_transaction_failures board flag. + */ + if (object_dynamic_cast(machine, TYPE_MACHINE)) { + MachineClass *mc =3D MACHINE_GET_CLASS(machine); + + if (mc) { + cpu->ignore_memory_transaction_failures =3D + mc->ignore_memory_transaction_failures; + } + } + + if (DEVICE(cpu)->hotplugged) { + cpu_synchronize_post_init(cpu); + cpu_resume(cpu); + } + +} + static bool cpu_common_exception_index_needed(void *opaque) { CPUState *cpu =3D opaque; diff --git a/hw/core/cpu-user.c b/hw/core/cpu-user.c index c2cb00a85d3..1e38c88f9bd 100644 --- a/hw/core/cpu-user.c +++ b/hw/core/cpu-user.c @@ -38,6 +38,11 @@ void cpu_exec_init(CPUState *cpu) /* nothing to do */ } =20 +void cpu_exec_realize(CPUState *cpu, Error **errp) +{ + /* nothing to do */ +} + void cpu_vmstate_register(CPUState *cpu) { assert(qdev_get_vmsd(DEVICE(cpu)) =3D=3D NULL || --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891844; cv=none; d=zohomail.com; s=zohoarc; b=PVo1ExI5ThOWP9dPN4xfNTFjKWuRlT2Y0uprDD0eWogAN8QOAyGNHopxMs0/gQ2HA+7v3juxv1TNmw8tzk+iFM0U25GQZdlAdv4e4GAWhPhDU9VN+99vCwKXOt1lK9g0z3A6Siu8Rw3ECQPUas3e8Ww0rjicUIlb19y3QMLB5h8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891844; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=qPBKFiugEaEWe8CctXr0x4TgVEREe8GgPnN8a3uzTRw=; b=AfcPlf33fD9cGyaTnHmXRHKjfLq3/y51cHc5eDj3TjKI3t09+Z8trZzUO45kjD791ASvktUSdujSyTTFyGOOyH9bjBVl0FLa+eqPnxtmZbYrzhklJCb/NG2+3Z/jZc+eof4vYQ63WlEjCClN2cOWTsq26W9Wp1MQFTDwD8C+QYw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891844468173.16129346652804; Sun, 16 Aug 2026 07:50:44 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcBn-0000gi-L9; Sun, 16 Aug 2026 10:50:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcBd-0000A9-US for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:50:12 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcBc-0001aj-AG for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:50:09 -0400 Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDlSLA3162140 for ; Sun, 16 Aug 2026 14:50:06 GMT Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2hd7ug5w-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:50:05 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-9309af14fd7so208585885a.1 for ; Sun, 16 Aug 2026 07:50:05 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f15b946sm25771705f8f.0.2026.08.16.07.50.03 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:50:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qPBKFiugEaEWe8CctXr0x4TgVEREe8GgPnN8a3uzTRw=; b=EmjRgbxu/SzLPu7B iSmk2y152LzrfCamOeqkywOMBTt98O0P4/piE1NwEVYmH5yIsm0l05ZOHOaX3G4A 3Ddq8n96aDHu6S/QqHzzVuqI/V5Sg4TaF2BEl/tkJPWiJWMiK6/xCud24FQlFywP meL5a7nNm44XJ/gJHUOaCQD9bip2/WRZ6zzG9RWDGxhwk25oBcFz53wexd0qw0pb TSyuyobCxMXOgV7qWPjoTxhbAU8k+woduy4p4F4Ss1d2hqbAgKwOpynNRHx6Ely9 JUqH6s1qPls/ErNitnmCM5YFUm1ahafasl0ysV6gUF0B3abiAkJ1nbGAuFSp/zGG bnIGBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891805; x=1787496605; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qPBKFiugEaEWe8CctXr0x4TgVEREe8GgPnN8a3uzTRw=; b=jGPBAWZ8tq3JnplPY4sGUndYCnirGiC98op2T30GTOMBsJMK//39kwXy/Uh4eb7dNW TT7ymaSGTFDcc84zPwCMjIPXbbDYwQt6TtcXpyJsshZBono11ha2YteC/+zZafOeIeK+ cTaayndeJceBSpozdQvbpZ1LuOfjjt36HYep2CbHmjaJlS4efEpYVJd+Oldc7vIIEq0v KhoC8SXwWicSp7jGIqtmdZXuTHY5tCAe4SpLcdAG3qXmwaIR6XAS/BTF8/tYpIXED5Zj xGo5UklWcHF7k4LfF/56SOFDw7bhNCA3AuEmo6vkS8ZVwaGsg2eHl/dBTE4YSrhf1+ss YY5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891805; x=1787496605; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qPBKFiugEaEWe8CctXr0x4TgVEREe8GgPnN8a3uzTRw=; b=GWYFbx3d3yTe5GRQVpp/GhKPNAnXHYuRFdmROh+tBYH56uWUOw55zQTevopMdzBxoI /5Nb0aJYJNzzuJSGV7YMBsocGdmmMJ68hWvooRuhwZIlPCOkl4/Of+5j3Z1lglSZkZJQ 7Zc5rSQB0ygdhWS5qnxhN+1ijlTOIv0r7DVQaLIySeR5Df2YMPQ1R/sQHoxRmrGFgXI4 Jq+s8gZfh7/0UsUVVx1yMuPV3c0ZOGeYFjWiN5GP4ucgXa2EiCgn+GZyPHalbqIm9XI2 pf5FDBHfzNbMMOjN3HXuSalj9MHWJRgyon23KFAJIZaNqztAyv2jbauyZmJnZDG6Y9Ji 86pA== X-Gm-Message-State: AOJu0YwTHvisXFf4RTOy0sNNv7BdqzwQ0fkNN+cLRSIFuft0aE1jCGhX jBzUUHsDwb9Zcqsaf6H6My59CvfFYmfeqvhjaY28iiCCfxrGPTWef5yCw2Z3a3INMo+DlkGR79t KuPFCxtSvAjB9pkzw4EgMMZM0qq9QawwtufTVf0WmNqlfqtMZxV0uTaWDo7IgeS8o8g== X-Gm-Gg: AR+sD10v8dT8F2ZvJ/f1TImQ1f+8GsB+d/R5cFn5L4nMQrwE6zs6xh0Gwol0UHzacLE CFGI5WZ4kBH00XlVw8g73aJ2la99xt/OHhl06afPkZeFTVB3FzaJ+wkin9Ywig6OxsPCSHvAnt/ k+ZscDwRqAOX+QJBwgSMDfWX5OuTmFUswii2Wugp+957xEBB+FQ7OmMWtopt0CXkq45NHdIYWwe 4R1do6QvLZw3aA1U+GSNjN9JF8d5XNdx7IV+S1FuwqQ+HNFyy4KbPiYVvnvfKO4DDm6wP0ia8aX KTRqUJLYuP4AzhlhHJyv6rOFf8t2Nat8eGcGksKltgEMVFecZT6wXypn94vdUjKSXL+LWIO9k9S XwIy1lOHuE/B38P2b9tiqSzsQlEikXRB8KpD8HgN/5Q== X-Received: by 2002:a05:620a:458c:b0:914:bb06:288 with SMTP id af79cd13be357-936d234d878mr2038744385a.22.1786891804932; Sun, 16 Aug 2026 07:50:04 -0700 (PDT) X-Received: by 2002:a05:620a:458c:b0:914:bb06:288 with SMTP id af79cd13be357-936d234d878mr2038739885a.22.1786891804465; Sun, 16 Aug 2026 07:50:04 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 29/56] hw/nmi: Use object_child_foreach_recursive() in nmi_children() Date: Sun, 16 Aug 2026 16:45:28 +0200 Message-ID: <20260816144556.69009-30-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX2nKTeKzdv11/ 9sm1YPN1DrfKajUlTp+c428uScBF9LH25DtEasq/wCLBRofouIwNbKQJfRyLmfqaulcyPvHoVWf yFwFQvBnMy48A6ijkJmS3blmCmkRLcjLTfsSwpNowmDK/juJq62iWP8A5yXhtjXKZiuoYlSCAXL rqTQ9mbd5Ot8wYp86tvFNasKpfvm7A9EDreLSw14UfsDXPDHAUdJhD/RYNVxZkT4GCEqcMovHE7 sByOkdsgMX8oezbiuGtMXHrJuryIHWU4Pii+hajQmIxKaimLjfu86HiannpU7Cz3oc/+rp7OfM8 HPN40OzmjwE7FyjMGDvZZ/lXXZy3VItawAD/CpL9PPJdtlEATklYBLQ3MmaHEe4eGsvOvl4yv0b zCZ0XQPf10PbJtAwAEbw0t/SLJG1jke9fvByzWv66nKhfTqkBbd8htwurFlAP5kl+D0w8ygLtDk 0nDqGCMAb8fGetqghFg== X-Proofpoint-GUID: vk7nj7ZKhYJyYHvTze0gxwqXikbSyuJ6 X-Authority-Analysis: v=2.4 cv=Ja2Ma0KV c=1 sm=1 tr=0 ts=6a81ce1d cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=KKAkSRfTAAAA:8 a=20KFwNOVAAAA:8 a=EUspDBNiAAAA:8 a=jmNSRpmTyL3U9imlh2kA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: vk7nj7ZKhYJyYHvTze0gxwqXikbSyuJ6 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfXy9MHmP9fNBzm XF9L52VCgHV24cSlikXMhnzL5RC3lkyrFEfCawk/AYLMy213EPkNgOYqrh3QSmEfnTcJUOEvYOy Ba0W+4PeSTyK/whBvn26iEKgErqI4t0= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 spamscore=0 suspectscore=0 adultscore=0 bulkscore=0 impostorscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891844654158500 From: Philippe Mathieu-Daud=C3=A9 Replace object_child_foreach() and recursion by a single object_child_foreach_recursive() call. Propagate the returned value so callers can check it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell Reviewed-by: Marc-Andr=C3=A9 Lureau Message-Id: <20260812121232.71958-2-philmd@oss.qualcomm.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/core/nmi.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/hw/core/nmi.c b/hw/core/nmi.c index 4b447e126ba..22724046575 100644 --- a/hw/core/nmi.c +++ b/hw/core/nmi.c @@ -31,8 +31,6 @@ struct do_nmi_s { bool handled; }; =20 -static void nmi_children(Object *o, struct do_nmi_s *ns); - static int do_nmi(Object *o, void *opaque) { struct do_nmi_s *ns =3D opaque; @@ -47,14 +45,13 @@ static int do_nmi(Object *o, void *opaque) return -1; } } - nmi_children(o, ns); =20 return 0; } =20 -static void nmi_children(Object *o, struct do_nmi_s *ns) +static int nmi_children(Object *o, struct do_nmi_s *ns) { - object_child_foreach(o, do_nmi, ns); + return object_child_foreach_recursive(o, do_nmi, ns); } =20 void nmi_monitor_handle(int cpu_index, Error **errp) @@ -65,10 +62,9 @@ void nmi_monitor_handle(int cpu_index, Error **errp) .handled =3D false }; =20 - nmi_children(object_get_root(), &ns); - if (ns.handled) { + if (nmi_children(object_get_root(), &ns)) { error_propagate(errp, ns.err); - } else { + } else if (!ns.handled) { error_setg(errp, "machine does not provide NMIs"); } } --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891824; cv=none; d=zohomail.com; s=zohoarc; b=aLa7UQOkdxcxJXWxEMqBT2iSXIA5wO0iTBmTw0Upm1H5u4w5z9ZFa6XscKRbbBfD0XRA6uwS1SGQWJAWsriNtfvyBbQzqwVuNXn1TV1snOe/toRH410ZbCajVumJ3RIV0zWF8BsCp+X5NFC1PokGj/t5ReRDbP2ZwkmPMDyS27U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891824; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=QqIkE/I0/yFqdHPM6vpD2vvVo379ilSQzNAkLmO2waE=; b=WFxAnY5r79JJCll4yx1so1eP8tlbx4uMsDkzgwgfj9In5YSnHmDj4k6YVzZ3AG4Q0hi8BCyPVTK+xjMPBjf1O1uU2XwT1JUZ/Y6hRMVb+FHhHjIEOPswQ2O9C55QF+4jHxexavwruo0oEACVCZamVnHr1KN8r0l6xYxXBPaMhwA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891824529249.290761105122; Sun, 16 Aug 2026 07:50:24 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcBp-0000uY-0r; Sun, 16 Aug 2026 10:50:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcBm-0000dH-Ri for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:50:18 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcBk-0001ba-Vr for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:50:18 -0400 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDkqSS3448447 for ; Sun, 16 Aug 2026 14:50:15 GMT Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghk3mwg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:50:15 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-936aa34873bso234183285a.3 for ; Sun, 16 Aug 2026 07:50:15 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4999610e381sm72886405e9.9.2026.08.16.07.50.13 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:50:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QqIkE/I0/yFqdHPM6vpD2vvVo379ilSQzNAkLmO2waE=; b=BAzB6Xq/+BhYkwBt zY1Hnk7IR2WPOdn4vRk3+RP+3yD+Us6Q/nelIkiuHxEuuVpUr8YFuugUKN2hUV4s J9fcdvpcyN5Uh/xrR6S/84tMxBJUXp6JxAeqBgHwdHGozOHFjUVxm41C60hhy8d5 lENO/FjM+ASUEdQ6gu7qneN8Wk24pOuka5Ygo5XKTOVqab8Jq2VceEnGf9bHKExt cID5SNkZiAyjkZgwOIWhIHXC2wRLPiftYZSHTws9grbl3HaCwZ0MpIxS5i8Am3Zy 2CQgd8B3XQdcHQAgNjIFtgYPJMqbdSvE311yWqcp4RpKW7DUfvDDYHR7iclnTk1k 1ngPCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891815; x=1787496615; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QqIkE/I0/yFqdHPM6vpD2vvVo379ilSQzNAkLmO2waE=; b=QMyXmHExsCmpIoImUcUtCYSFeBj31nAFOWLYWYVJq3IE5amSxVx/dMyO2UHP0admCG Aza7qZqsNnQdwWJR/5h1S6LehImDgZ4unK1JS2oCgXNsczECINfgwrahIu73jdET1bBk o9pcAW2wRpuddBs9kZiPtsU79fOYvV7c9PtPU9Q4B+JLo1i++ZHN4jqZhaLmhM1r24ME AoACwgmcJLDWq3z/XEslv1zZCBoTGvVhWYxLvOsdTNbn9AaEBmy8jOYFyTfbaGSdAau4 ZR/ioV40wQOzgd7/08UIEwRtHj7t3oSc9NmU1xIWeIufaBtZ8ZGmx57lMjlrmf2WAY+J YbnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891815; x=1787496615; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QqIkE/I0/yFqdHPM6vpD2vvVo379ilSQzNAkLmO2waE=; b=Jptqi5U5NTU7AxBKbN1KMoid/iJAEGC9cK6E/0mpmonhDyfdjtU9ikEQgi7jN9cZWP 6KqCDFWBYkmrq/W9Y5sfSJM9UaG4AzKe4435bEcnFJWCHjmjChZlvKFZPAwE22tSujkl msNPwa2Qt8VTDp1s8ejJXWnJZkkvqb7/M+/9vibyc+m6ZpP3QwoV1+PbbMLxAQAINvCU zbEz/IMSY3yCq5aGlVAdac5bV7N/wMXZ+cbDbd03k0wsDy7iFJCF1Qc8GdGuFOBCxm4F r+zDS+LpjTM6NsL/SX4p3srtIz8gTSmLRAB0zcmjMcEKB9QQyPh4wtG7bIJsYbbG0Lsu MD7g== X-Gm-Message-State: AOJu0YwIczO/t2Su+KvzyM8TmHWtIfdlWYGb/vEF1F/4ekpjfO5F5SOf M7DXRYQ6Py7w12GpLkEcNfmjz/50rPfCe4otD4WOmNQOkNMSpMBWtsAwWZJOa/hvpK0G6CcoNDy 3ThW1j1MsE9imWxU6x+S11xX53AmKp+vVelp+3mbe5EstfLfk1txk8mjtg4Xk05LQ3A== X-Gm-Gg: AR+sD11yPrZUpDy3y/xwKTGzvaMt8p6V8RMQL8jtAjP1JpedY9pA8tswBRvlozNy1Q2 0J5rl0m8oLwDh4BSEQyjk0S5Qcw5zEkvYBvfmEyZl1oJn0MfoEmcCaBoDOZ8OP5TIWyQ+c4A5/G +Nvhm6nWrJTT5NfdNGFmcN8SuEqWetRwtTKmfiKiLnXP0g0d6Qma820o+oHKG9UlAInXwkc0H+P KwNsygE5Z+uQ02a5FlhNmwi0K+jW/Jm88MGqaur4qUYRzZM8HcZOHOA+4zN11hQdB/lmFH+KdEC WyJGKHUqZ9dJKrNEGN9gzpjGfBpyZsuQ16DSiUm8qj7oj7qcYAng5wIVQmFHlfmC82Xac32T/W0 BgpFKalybogI++ACzhCWLeHmlfmabJ/DyRsWn8GCwXA== X-Received: by 2002:a05:620a:6881:b0:931:2:65b6 with SMTP id af79cd13be357-936d238c122mr2345954085a.38.1786891814856; Sun, 16 Aug 2026 07:50:14 -0700 (PDT) X-Received: by 2002:a05:620a:6881:b0:931:2:65b6 with SMTP id af79cd13be357-936d238c122mr2345949185a.38.1786891814353; Sun, 16 Aug 2026 07:50:14 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 30/56] hw/s390x/virtio-ccw: Always inject NMI to first CPU Date: Sun, 16 Aug 2026 16:45:29 +0200 Message-ID: <20260816144556.69009-31-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX1Ir1Vrt3dh7k LcnymkwJF+j13pFmNCytlX1K80+5ElQN1uFqi8l5Rx8T3NAAJpISew7Pzx+64WiTtKy+P53aK35 6dsRupLUZxe/JJZWSiNd5JpvWrRs/r0= X-Proofpoint-GUID: fDCa-W4CmhhBi_LRlKSfMUtHV65MhCSV X-Authority-Analysis: v=2.4 cv=f+14wuyM c=1 sm=1 tr=0 ts=6a81ce27 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=KKAkSRfTAAAA:8 a=20KFwNOVAAAA:8 a=VnNF1IyMAAAA:8 a=EUspDBNiAAAA:8 a=43zqHlSF2DfHiYptYdwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX5RzeQ99M8GvZ 6W2wCqrtG1RkZbpJ0dlS/3XyELithapWNVN1Y3cc6nuTlbXECVsOVRSD8s0FyoEBXeTWSUGzoC3 427kVzu6Dr06s6KxEV5kt7ToBd8Ea2GNStweLwsFRloyKLsW5yPiJ3TDelyWblwMjcGsoSFaXF5 /lO0KW8JQXY/XJgBMXIF8W/K8/V93+JXKjuTxPBQNIR1p6BWLKmqV2WGiQ6EZ+MRwllHptWGNp8 /j2l4EI1D9kA5VuTAfCj5fj/D1+6M++ZY0HozYMtfwUAiR7DWXnxopsZvckMAaqlNUQii78vEBG FLFJapZQ8XG5+Dk9/tzlGrfyYhE/l7X/Kg2SdJ/VCRHPLEZKHpoOPyKwnqSKbpj1wJJ5ipbOBOj IirZUIpL2KlsoaIQonERhBBbbzOWYLl+mEJpy8dZ/5ffXAHCO3aMNbRswlxIEZ73mCXP3vTFw+9 kgIphMYRokE9iitIiNQ== X-Proofpoint-ORIG-GUID: fDCa-W4CmhhBi_LRlKSfMUtHV65MhCSV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 suspectscore=0 bulkscore=0 phishscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891826657158500 From: Philippe Mathieu-Daud=C3=A9 We can trigger NMI from HMP or QMP. QEMU maps the NMI to the s390x per-CPU 'RESTART' interrupt. Linux guests usually setup this interrupt to trigger kdump or crash. Such crashdump can be triggered in QEMU by HMP "nmi" or QMP "inject-nmi" commands. Using QMP, since we can not select a particular CPU, the first CPU is used (CPU#0). See the documentation from commit 795dc6e4 ("watchdog: Add new Virtual Watchdog action INJECT-NMI"): @inject-nmi: a non-maskable interrupt is injected into the first VCPU (all VCPUS on x86) (since 2.4) While we can select a particular CPU on HMP, the guest behavior is expected to be the same if using CPU #N or CPU #0. Since always using CPU#0 simplifies API maintenance , update s390_nmi() to inject NMI to the first CPU. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell Reviewed-by: David Hildenbrand Reviewed-by: Eric Farman Reviewed-by: Marc-Andr=C3=A9 Lureau Message-Id: <20260812121232.71958-3-philmd@oss.qualcomm.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- qapi/machine.json | 7 ++++--- qapi/run-state.json | 6 ++++-- hw/s390x/s390-virtio-ccw.c | 4 +--- hmp-commands.hx | 5 +++-- 4 files changed, 12 insertions(+), 10 deletions(-) diff --git a/qapi/machine.json b/qapi/machine.json index 9b2248038fc..2d63c1bac3b 100644 --- a/qapi/machine.json +++ b/qapi/machine.json @@ -432,9 +432,10 @@ ## # @inject-nmi: # -# Injects a Non-Maskable Interrupt into the default CPU (x86/s390) or -# all CPUs (ppc64). The command fails when the guest doesn't support -# injecting. +# Injects a Non-Maskable Interrupt (machine specific: for example on +# s390x CCW only the first vCPU receives the NMI, but on x86 machines +# all vCPUs receive it). The command fails when the guest doesn't +# support injecting. # # Since: 0.14 # diff --git a/qapi/run-state.json b/qapi/run-state.json index a5771ad4681..e4fdead1e0b 100644 --- a/qapi/run-state.json +++ b/qapi/run-state.json @@ -317,8 +317,10 @@ # # @none: nothing is done # -# @inject-nmi: a non-maskable interrupt is injected into the first -# VCPU (all VCPUS on x86) (since 2.4) +# @inject-nmi: a non-maskable interrupt is injected (machine +# specific: for example on s390x CCW only the first vCPU +# receives the NMI, but on x86 machines all vCPUs receive +# it). (since 2.4) # # Since: 2.1 ## diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index 55131c1a444..a2f373b1190 100644 --- a/hw/s390x/s390-virtio-ccw.c +++ b/hw/s390x/s390-virtio-ccw.c @@ -727,9 +727,7 @@ static HotplugHandler *s390_get_hotplug_handler(Machine= State *machine, =20 static void s390_nmi(NMIState *n, int cpu_index, Error **errp) { - CPUState *cs =3D qemu_get_cpu(cpu_index); - - s390_cpu_restart(S390_CPU(cs)); + s390_cpu_restart(S390_CPU(first_cpu)); } =20 static inline bool machine_get_aes_key_wrap(Object *obj, Error **errp) diff --git a/hmp-commands.hx b/hmp-commands.hx index 7f43cf537fc..a29f02b623e 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -865,12 +865,13 @@ ERST .name =3D "nmi", .args_type =3D "", .params =3D "", - .help =3D "inject an NMI", + .help =3D "Inject an NMI, in a machine-specific way", .cmd =3D hmp_nmi, }, SRST ``nmi`` *cpu* - Inject an NMI on the default CPU (x86/s390) or all CPUs (ppc64). + Inject an NMI, in a machine-specific way. + Not all machines implement NMI handling. ERST =20 { --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891867; cv=none; d=zohomail.com; s=zohoarc; b=TlFcjrA0PHH3PTQskHqSBev5J8S80EQ2KtdEHtEobWzQS2g8Ml/Tjz5irwpUbRABrnF8eUyjVlbP3dS7Jk/w3N9fykAKAdLqoN7T1yQ3bEVNl/k9r3MOFPqsGdoMiBtKPpG9rM/iMl83Rx8lwo5vYZgs2O8WMjMgYwsIvFNTqiY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891867; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=/TI55kTmRszhsBOU9JNOcf2+ospWSGcNv4d1cCzyn9E=; b=FjBC+o1rj30zk3aiOgVVFZh6ADExxvM9/D/rWZY7s6wiDeTK2bMeh+fWVJFi/rBPNt5VfrTG4IxM7tIu+/boaTvsBeWji/bFyWFYv51SYW+wlki+mBLyEhJ3NUpSzcbhE78N7R8w64wa7lCWyItM1Z9f918sqEJzE6LZQj89Vvg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891867070570.3808220760413; Sun, 16 Aug 2026 07:51:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcBy-0001mM-8t; Sun, 16 Aug 2026 10:50:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcBw-0001fb-EZ for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:50:28 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcBu-0001c1-F3 for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:50:28 -0400 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDklB93609386 for ; Sun, 16 Aug 2026 14:50:25 GMT Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghfuk4y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:50:24 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c1c7f135bso45118231cf.0 for ; Sun, 16 Aug 2026 07:50:24 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f219e12sm22753327f8f.10.2026.08.16.07.50.22 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:50:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /TI55kTmRszhsBOU9JNOcf2+ospWSGcNv4d1cCzyn9E=; b=OxxXK8h+smfe+kH8 lSG3fFl9yh4y4+Sc7DC4jzLOcuZNEaYBQRdkzsy0iYaApKX/SHy07hH53ErbEdBg l9H++RlkRlv9LJ/mq42iZ+xHK38Wk/25q6WT2TPkNjJ/aPXP8h4hwTVN0DHzE94d m5a2z84kh0Dm17HDBTW5471rYy6AS9c6HlpSliDoyKRJtoMKFc1xJ5/RvVoNEEh+ lmtel/c7NoI2g2HX49WLYRKJzlNpaXSA3gCiFwQIOLOrtW0g0Io++TeqsOgOSUUf 6MTzrYHZOS9xrI2tfp+pa6FTPetP4Fb6YmQpEXa1BJLBUFTLVYBMZopnumkEfHpB cE1tjQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891824; x=1787496624; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/TI55kTmRszhsBOU9JNOcf2+ospWSGcNv4d1cCzyn9E=; b=HaOiVwia97vt/VSkxBvdtj6V4gqr4g9ClIHGrY/3yy5wUZhNxCZC8LJqYGsFZ933jP sYmr4qabl/ReD+em2Bepx1p5eNo+hdH81okADEGG2nepBLKxCZ1medxJlzB13T3UyEsi DevUR+iRsg0pIORC8ce2ZWLg6uiyY6xGJnzrBstru09+Hj8Wil7vUm4/Z/q5ouAW1Tv+ Orp6LhiK0HIxV+HHjbnVCcRNhR24Y7C18midS675Pcn8Ls4DQTXGaTqzxhIYFhq9RSv/ 1X4Q/zXz7/elEv7Ud+bhVC2gVbYjO0yScMP7KFNF1oogLaGio/2QbUCHOHgl93f48hqR XrhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891824; x=1787496624; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/TI55kTmRszhsBOU9JNOcf2+ospWSGcNv4d1cCzyn9E=; b=V+gyVcvV0CoJDnHQsXpV9xtGatNinwjSZy88Ril0sMtAcjB/wzLCUVZQLVc0BgxJG8 6RhNg/qIBv+8eF/NxY1ssdZ9k+4xCYXzDoqwWBnz96AAz55N7V3HETEN2Izyv372++X9 wCpHFUK0d9G0FFjfwAgwZFt3+Of5aTFJJXZAUC1n1QpuQvrOh+f2ArvORimqrA56S10T 5ytKOXAazO8vueJ7ikxJm05+kExgAexwWNCLa1M1E0GgdUZOIZo2Yb6qMpFV5R4KXxJ3 zeQF8ArBsYilgTNURjNty/A4kfbe3n2Ez3Md8gFubwJvxzNtTlyHJWCgGNLCDvbP27F1 eC5w== X-Gm-Message-State: AOJu0YzCDpidKV320SZuZnFzN/TzU16qI5zwKF5BsjWnFBG6gZJwnqt8 LnlAxkB/NJS3OALJEAwJE8+9CLTJl6/T3NiD/5PXxIRCKko2ZNu3KzGGtB38Nc4xtP+/sDzV1eC K5dk1Y2jMUpbptHrJy9xl70cYXl71ajq1STtcTgvFs/GrEhB1zaMpPIjIieEBu665Sg== X-Gm-Gg: AR+sD11FHp/eV/Djyf4b0lFVCv8uMZJ/p56ggswyBV3p2a98x2zFJBg97Z+Fh//caBz rqKQcBDmKHmbaQgf+ki4bVYri+Sj3f7daoyid+WnLg0fDBKCG5VAMV5tJIyZzsbQ8gHLmhN4VoY 152j1IbPWHBpzdz0+5eRsdlsQoXpC0qiBpcfHvm/hGgPisqUSqmUUwclWY0RRlR4G3Tadlt/pQp zQv670v1byI7wBxSHgesCQvx05gjV8IARo8k7FNhvJEs3MjGjf4nnrdqtFa4khWrUpSbxN3tfkD Knr2vncFO8fTeVar6m4F1e7YLtVSuu1y4z1wdoXeDy/myT2H6fLpc5QsM7fDrGp5NNPxpBRstSK W1ggSzkxdODT8xv3a7Vx5piUfpHxckXvayTpdv84svQ== X-Received: by 2002:ac8:7fc4:0:b0:51c:1fd1:e755 with SMTP id d75a77b69052e-52d854dc9e7mr180565501cf.36.1786891823951; Sun, 16 Aug 2026 07:50:23 -0700 (PDT) X-Received: by 2002:ac8:7fc4:0:b0:51c:1fd1:e755 with SMTP id d75a77b69052e-52d854dc9e7mr180564981cf.36.1786891823487; Sun, 16 Aug 2026 07:50:23 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 31/56] hw/nmi: Remove @cpu_index argument from NMIClass::nmi_monitor_handler() Date: Sun, 16 Aug 2026 16:45:30 +0200 Message-ID: <20260816144556.69009-32-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX/YdiRvbDiYbD WqdhrpvZvfMQcRtOLOdENyKyHRkq96t6A/Imco+d3Fz3SSgXWKb0zfk0DjHKPUpeZ4B6I/Jh8RW gOfyaQOhFeHRY0g8XGDY47Tn1jRuNwY= X-Proofpoint-ORIG-GUID: h_wqT950txo4kMVnj8yPej6nD2nSEWqM X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX/SpHN51nXoSR JjSMG2QHapxKSNCUucKhZgTaJGrEmMu6vEN/Fbsg8TXsUyEQf9Bpy6zNr+Nt9rvSSNAOq9b9c72 6h77o8clGObmRSsi/upGKx/qldrlIgE7PHeKkiURuMU3Zn9CyvLhdK5UoDEzVB30crH1QLdx5xq efuongdoiqKLbMu44Hyui/Kej7aaLg0eYlgDjq+So4GwwRvQ3tDevv7zlSCisC/vCwWz2KKH2u/ l/++T37nXS+GXTDD8enX5ou+vezWM47389secp5HP54x6QbFqJm793ptnPDRnHL7F7ReabGpMQu NxPZR/3VOSmt6Md/95e0wtiUI7OoPDVrLMcPsRdlYLMw3bHvN0jRfaYbZMko9lXs4MHe6x+rE4P QaSpSOcAAnOehDeIBFoOabz6mEKQMlMcsvCuzrAFqSQo3wzrGh2q4z2Ww6VRPJJzoa6INUDZGNY WItRLfULdvo9OrYAZzg== X-Authority-Analysis: v=2.4 cv=TMJ1jVla c=1 sm=1 tr=0 ts=6a81ce31 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=KKAkSRfTAAAA:8 a=20KFwNOVAAAA:8 a=EUspDBNiAAAA:8 a=KpD7k0r93PjNlcRUnYkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: h_wqT950txo4kMVnj8yPej6nD2nSEWqM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 phishscore=0 clxscore=1015 bulkscore=0 spamscore=0 suspectscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891868793158500 From: Philippe Mathieu-Daud=C3=A9 Only s390x was using the 'cpu_index' argument, but since the previous commit it isn't anymore (it use the first cpu). Since this argument is now completely unused, remove it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell Reviewed-by: Marc-Andr=C3=A9 Lureau Message-Id: <20260812121232.71958-4-philmd@oss.qualcomm.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/core/nmi.h | 8 +++++++- hw/core/nmi.c | 2 +- hw/hppa/machine.c | 2 +- hw/i386/x86.c | 2 +- hw/intc/m68k_irqc.c | 2 +- hw/m68k/q800-glue.c | 2 +- hw/misc/macio/gpio.c | 2 +- hw/ppc/pnv.c | 2 +- hw/ppc/spapr.c | 2 +- hw/s390x/s390-virtio-ccw.c | 2 +- 10 files changed, 16 insertions(+), 10 deletions(-) diff --git a/include/hw/core/nmi.h b/include/hw/core/nmi.h index fff41bebc69..4c4ce79071d 100644 --- a/include/hw/core/nmi.h +++ b/include/hw/core/nmi.h @@ -37,7 +37,13 @@ typedef struct NMIState NMIState; struct NMIClass { InterfaceClass parent_class; =20 - void (*nmi_monitor_handler)(NMIState *n, int cpu_index, Error **errp); + /** + * nmi_monitor_handler: Callback to handle NMI notifications. + * + * @ns: Class #NMIState state + * @errp: pointer to error object + */ + void (*nmi_monitor_handler)(NMIState *ns, Error **errp); }; =20 void nmi_monitor_handle(int cpu_index, Error **errp); diff --git a/hw/core/nmi.c b/hw/core/nmi.c index 22724046575..ff6454437c1 100644 --- a/hw/core/nmi.c +++ b/hw/core/nmi.c @@ -40,7 +40,7 @@ static int do_nmi(Object *o, void *opaque) NMIClass *nc =3D NMI_GET_CLASS(n); =20 ns->handled =3D true; - nc->nmi_monitor_handler(n, ns->cpu_index, &ns->err); + nc->nmi_monitor_handler(n, &ns->err); if (ns->err) { return -1; } diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c index d762163ddf5..2b44debc388 100644 --- a/hw/hppa/machine.c +++ b/hw/hppa/machine.c @@ -829,7 +829,7 @@ static void hppa_machine_reset(MachineState *ms, ResetT= ype type) cpu[0]->env.cmdline_or_bootorder =3D 'c'; } =20 -static void hppa_nmi(NMIState *n, int cpu_index, Error **errp) +static void hppa_nmi(NMIState *ns, Error **errp) { CPUState *cs; =20 diff --git a/hw/i386/x86.c b/hw/i386/x86.c index dc7f0d56b01..0ea5453403d 100644 --- a/hw/i386/x86.c +++ b/hw/i386/x86.c @@ -147,7 +147,7 @@ static const CPUArchIdList *x86_possible_cpu_arch_ids(M= achineState *ms) return ms->possible_cpus; } =20 -static void x86_nmi(NMIState *n, int cpu_index, Error **errp) +static void x86_nmi(NMIState *ns, Error **errp) { /* cpu index isn't used */ CPUState *cs; diff --git a/hw/intc/m68k_irqc.c b/hw/intc/m68k_irqc.c index 68ddb5351be..bc41b44d455 100644 --- a/hw/intc/m68k_irqc.c +++ b/hw/intc/m68k_irqc.c @@ -70,7 +70,7 @@ static void m68k_irqc_instance_init(Object *obj) qdev_init_gpio_in(DEVICE(obj), m68k_set_irq, M68K_IRQC_LEVEL_NUM); } =20 -static void m68k_nmi(NMIState *n, int cpu_index, Error **errp) +static void m68k_nmi(NMIState *n, Error **errp) { m68k_set_irq(n, M68K_IRQC_LEVEL_7, 1); } diff --git a/hw/m68k/q800-glue.c b/hw/m68k/q800-glue.c index ac9062c6488..b13e5ef95f1 100644 --- a/hw/m68k/q800-glue.c +++ b/hw/m68k/q800-glue.c @@ -159,7 +159,7 @@ static void glue_auxmode_set_irq(void *opaque, int irq,= int level) s->auxmode =3D level; } =20 -static void glue_nmi(NMIState *n, int cpu_index, Error **errp) +static void glue_nmi(NMIState *n, Error **errp) { GLUEState *s =3D GLUE(n); =20 diff --git a/hw/misc/macio/gpio.c b/hw/misc/macio/gpio.c index 1a7c534d652..1bdca728f97 100644 --- a/hw/misc/macio/gpio.c +++ b/hw/misc/macio/gpio.c @@ -188,7 +188,7 @@ static void macio_gpio_reset(DeviceState *dev) macio_set_gpio(s, 1, true); } =20 -static void macio_gpio_nmi(NMIState *n, int cpu_index, Error **errp) +static void macio_gpio_nmi(NMIState *n, Error **errp) { macio_set_gpio(MACIO_GPIO(n), 9, true); macio_set_gpio(MACIO_GPIO(n), 9, false); diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index c0cb45dbfbc..8676be7bbb1 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -3552,7 +3552,7 @@ static void pnv_cpu_do_nmi(PnvChip *chip, PowerPCCPU = *cpu, void *opaque) async_run_on_cpu(CPU(cpu), pnv_cpu_do_nmi_on_cpu, RUN_ON_CPU_HOST_INT(= 0)); } =20 -static void pnv_nmi(NMIState *n, int cpu_index, Error **errp) +static void pnv_nmi(NMIState *ns, Error **errp) { PnvMachineState *pnv =3D PNV_MACHINE(qdev_get_machine()); int i; diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 7e284edd7d0..c376a588720 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -3550,7 +3550,7 @@ void spapr_do_system_reset_on_cpu(CPUState *cs, run_o= n_cpu_data arg) } } =20 -static void spapr_nmi(NMIState *n, int cpu_index, Error **errp) +static void spapr_nmi(NMIState *ns, Error **errp) { CPUState *cs; =20 diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index a2f373b1190..ac04245d65b 100644 --- a/hw/s390x/s390-virtio-ccw.c +++ b/hw/s390x/s390-virtio-ccw.c @@ -725,7 +725,7 @@ static HotplugHandler *s390_get_hotplug_handler(Machine= State *machine, return NULL; } =20 -static void s390_nmi(NMIState *n, int cpu_index, Error **errp) +static void s390_nmi(NMIState *ns, Error **errp) { s390_cpu_restart(S390_CPU(first_cpu)); } --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891859; cv=none; d=zohomail.com; s=zohoarc; b=RGxNlLzaGEKhcmdtPLwZuqwtFdE2hxvSCmQx7kJGwHQtn5hoiDXzGfYp7a7m/wYcV38hpNBapnw/S3yxyGRT3AXcWZElcGCmz1B4ZdYmCUtRCgwuBT8HHvNUIALHL9g8VU9YHehTI+wdhrAVIXEXcWudis9XZyiF2B/V01HiZdY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891859; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=tLKPs+ARtkciTR4oRVHUxqxK6J0969Mt+2v69gcFJp8=; b=EegXVQWIwKHRWaExrZHty1vU6Sg1GLP1cdVrld+sYfutYJqKCBurQ27w0IkZ2QmF16K0JaAPXpp7BqT0NwLXzmbbuSWgTsxuTQjJLIi11RrxB2DwPewJ+y96gDHJ4k3eHboe/LUJZv0ucCPtH+pgiT+eg9rKMA0muAJmkLDMi8Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891859146229.37542924734316; Sun, 16 Aug 2026 07:50:59 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcCI-0002HZ-0c; Sun, 16 Aug 2026 10:50:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcC3-00023j-SU for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:50:36 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcC1-0001dy-ND for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:50:35 -0400 Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDmBXX4145014 for ; Sun, 16 Aug 2026 14:50:32 GMT Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghwkkfy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:50:32 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-52b4f6ac06aso49087481cf.1 for ; Sun, 16 Aug 2026 07:50:31 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f1ffffdsm25230095f8f.2.2026.08.16.07.50.29 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:50:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tLKPs+ARtkciTR4oRVHUxqxK6J0969Mt+2v69gcFJp8=; b=gPCLZTFXG8Dk/IsY eH0L8mDhHFCdBWjSe1VAI3nS7YboRk1gmsjCzkeJQYE2lv8sOuVAVTyod6wxSjI0 cyJX3QjF1adQaI91WpnBJQz0x7eVQDGVnG8E6575tWaeB/ZaqFmzVgs3xHJIyUYL 4gMw/tLRTt3/DKh6Nz+Nd7ReuPGRz+CxsOrmb8LVou2ySV5R5vr0TVDiOOw3tSqi GtCfEptN/psD4HDtcJEm3lWOBgG33Xxnud+V+50c2e7M8I4/L9fSH3X1LH26ll8h 3vqfnLlCqaPGiw0clhC9+Q1hIi29LIqmEM2oWXULZWxxGOiz0uP8YpeGHCrU/+oQ arzuhg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891831; x=1787496631; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tLKPs+ARtkciTR4oRVHUxqxK6J0969Mt+2v69gcFJp8=; b=ZqSAHxMRDjwfoud5O9CgXfj59QyeI3MvcvZruStMsCnDwHeHkb7k36skeoTcK8muqS goqEOeeBkUJJ7jkYWqaqSoL1jENjxa0CqyF0F1J/PWZEjbU9RqZNtE0uaa99sjgsWc37 5K+dCaFdU91J7PeFVtJS+X6vjCIlEW2uwv0BebgRr9MSTKnlkdkgFNj7rPHgmtLNK1b9 0/5we7vYaNXBqfjh+dC382uy+WXzltcNYS+ModBXUzltMOwn1xjvTXcY+UBLCjODE3sq wlfj3yfzXKO61XkCKiNgQVa9AcxYXaS/qQsxfd0SRCwRt7a5fkQ0DK8ygNyw0Esxm6bC tuWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891831; x=1787496631; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tLKPs+ARtkciTR4oRVHUxqxK6J0969Mt+2v69gcFJp8=; b=FZKmGchYq5kunRgvuCPGf9idFMrARDNxS1ENZ4URrT57b34X8EgD/V9typtyR/CUDZ JBlA5OEGesTbpNLT4rOFpyYIofbZx6DTUo7+IHMoyGuqJ9QSZwNurO0DuMVnp2IhLUHm 9TfNyufgI9p2jPqT84ktRWI96xMFmqsYcq6d/7AXgBMvAOrBbJhOFzepsAxVdi1y7s2K RzKnu0mLNN6BUSqyWCkJ62HzS0/Qr1JJbjNzY/zci5CczQcCLuB/E9K2Ko/xKRAUudaZ KfTZGkjS6kj5Wz7hPgiIhLcb+TEY4RfNEfccOtqu9LPpMh8kOrpQZsdmkswaXsuwNTjH +NEQ== X-Gm-Message-State: AOJu0YyC1U+5aIV/RTVgGUrDNTOCXxiVEWLl3ggVPKgQEdKGtDW00t+I dXhcJh7fLXV/RBay7y6P6KaOLvsFrRPojxZJ+OgZesYAilab8llubSfQMZa33jxHlsYkj7YGA1v nD2Jn02Ms8s3OegEUBowJKeiS8A8zyI/Du1JrxL28EX/ItCOiB+GO3mdLpmSu7h9sZA== X-Gm-Gg: AR+sD13pe6vgMCVrJPKd2GVppkHlAoBYubNh2ibKsk8oUcH3PyI/QC9UqclOP1BFN7/ +FFKYdLLzSFHXY9irNazfnvrSLbPHkMQy8X0tdEQS91lFSHau+G5kFvPlfIzx2V/L/oquXZPJQQ OYst3H/94eln9SkFxs2IS74SnsjJepV4gWztObCn+2TDI2C3PPxJZ8/WJ+fr+2V1Wvlz8rFvPKi GTXMr7/TQaYP056/XUVhDck6clRMb+BhmJffdoMuUZOeda/hQNh7bphZu8GCOEPefRRs55IB89u rRZ3UwRtpSI1VeDOst4qMTILaWMjYl6aZ0AbzvXfQ/8t3kZbKYhepJy0HzAkyJyvyPPMUgROX29 f3HjiEY7e4a7hT7yjRKhg/uIE+IJnMm7jU8w2WfxcaQ== X-Received: by 2002:a05:622a:40c8:b0:527:7842:72cc with SMTP id d75a77b69052e-52d854e5526mr221535301cf.39.1786891831043; Sun, 16 Aug 2026 07:50:31 -0700 (PDT) X-Received: by 2002:a05:622a:40c8:b0:527:7842:72cc with SMTP id d75a77b69052e-52d854e5526mr221534861cf.39.1786891830556; Sun, 16 Aug 2026 07:50:30 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 32/56] hw/nmi: Remove @cpu_index argument from nmi_inject() Date: Sun, 16 Aug 2026 16:45:31 +0200 Message-ID: <20260816144556.69009-33-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: Q7w82qwmnMMBcBM4RpDLZKn0IihVcrYZ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX/0PrQqwvMNzk 7wBPqmDn8cTdn7vAvZRDPCnoXjOhigg7bIs5JACxmJMaHy7GutUT1QvLrBRtlJhY65LkdtGP19V rUlGk7OKElmoL9252fyu8zJQ2l48sYCGzcHk88OAUvMIukqrZ1+i17gG86OfRcKsclrsfCz2SrD uLJJ9EKlhx57YctcUdJOD98oHb8xaFOpITwWx7naWcmyBgEl0gN98n/ufLCbRao47fYIeymZnvf A9qNemRhuC2UBGAFPtFyLxSKtLR5xQu0nqdFvf5ojoHr01xXkNspTDaPC1vw5zVXvSMvxAXY4wz D3dK0JfgJJF8m5vGZ920OpGcf8YAT39SxlRbGz1r8sc4kUTtzMk9AvYdfOKJ9zM7lfgnA9bgINd 21Ah+LidM4E4z/6s6WCJgVjJd5xpO2QQbxv5ROcTRmNbEDZ6UvQj0Xb297Ka0EHcECioAvwg56A F7HgV3YkLtU/Dg7cSSg== X-Proofpoint-GUID: Q7w82qwmnMMBcBM4RpDLZKn0IihVcrYZ X-Authority-Analysis: v=2.4 cv=DdknbPtW c=1 sm=1 tr=0 ts=6a81ce38 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=KKAkSRfTAAAA:8 a=20KFwNOVAAAA:8 a=EUspDBNiAAAA:8 a=BCSMXUZzsmg2-BZsF7kA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX3aMsB0v+9FWC vPCjjKQoSQ1zsrjpcuDz/A1v5L+DdHl5GfDSnxjlPEK/jiWvOmqHjxdk3qqQJYTq1RJgZ3rwJqC G410kN3RIawIaansU6gwxCTmPd9DCDA= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 priorityscore=1501 adultscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 spamscore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891860782158500 From: Philippe Mathieu-Daud=C3=A9 nmi_monitor_handle() is not related to the monitor, rename it as nmi_inject(). Return a boolean value indicating success / failure as recommended by the Error API since commit e3fe3988d7 ("error: Document Error API usage rules"). The 'cpu_index' argument is not used, remove it. This officially drops the current CPU for HMP command. Document nmi_inject() as suggested by Peter Maydell in https://lore.kernel.org/qemu-devel/CAFEAcA-yALySmCJLbitCmYpiZKUXJNOavGJG9RY= eo8fKqz7gcw@mail.gmail.com/. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell Reviewed-by: Marc-Andr=C3=A9 Lureau Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20260812121232.71958-5-philmd@oss.qualcomm.com> --- include/hw/core/nmi.h | 24 +++++++++++++++++++++++- hw/core/nmi.c | 9 ++++----- hw/ipmi/ipmi.c | 3 +-- hw/watchdog/watchdog.c | 2 +- system/cpus.c | 3 +-- hmp-commands.hx | 2 +- 6 files changed, 31 insertions(+), 12 deletions(-) diff --git a/include/hw/core/nmi.h b/include/hw/core/nmi.h index 4c4ce79071d..851be28257e 100644 --- a/include/hw/core/nmi.h +++ b/include/hw/core/nmi.h @@ -46,6 +46,28 @@ struct NMIClass { void (*nmi_monitor_handler)(NMIState *ns, Error **errp); }; =20 -void nmi_monitor_handle(int cpu_index, Error **errp); +/** + * nmi_inject: Inject an NMI, in a machine-specific way + * @errp: pointer to error object + * + * This function injects an NMI, in a machine-specific way. The + * intention is that this should typically trigger a guest kernel + * dump or reboot, and might happen as a result of user request + * from the monitor, watchdog timeouts, and similar events. + * (For example on the x86 PC it triggers an NMI on all CPUs, + * and on s390 it triggers the RESTART interrupt on the first CPU.) + * + * The NMI is injected by looking for a QOM object which implements + * the TYPE_NMI interface, and calling its nmi_monitor_handler method. Usu= ally + * it is the machine model class that implements this interface. + * + * Not all machines implement NMI handling; this function + * will return an error if used on a machine which does not + * implement NMIs. + * + * On success, return %true. + * On failure, store an error through @errp and return %false. + */ +bool nmi_inject(Error **errp); =20 #endif /* NMI_H */ diff --git a/hw/core/nmi.c b/hw/core/nmi.c index ff6454437c1..2d890f2995d 100644 --- a/hw/core/nmi.c +++ b/hw/core/nmi.c @@ -22,11 +22,8 @@ #include "qemu/osdep.h" #include "hw/core/nmi.h" #include "qapi/error.h" -#include "qemu/module.h" -#include "monitor/monitor.h" =20 struct do_nmi_s { - int cpu_index; Error *err; bool handled; }; @@ -54,19 +51,21 @@ static int nmi_children(Object *o, struct do_nmi_s *ns) return object_child_foreach_recursive(o, do_nmi, ns); } =20 -void nmi_monitor_handle(int cpu_index, Error **errp) +bool nmi_inject(Error **errp) { struct do_nmi_s ns =3D { - .cpu_index =3D cpu_index, .err =3D NULL, .handled =3D false }; =20 if (nmi_children(object_get_root(), &ns)) { error_propagate(errp, ns.err); + return false; } else if (!ns.handled) { error_setg(errp, "machine does not provide NMIs"); + return false; } + return true; } =20 static const TypeInfo nmi_info =3D { diff --git a/hw/ipmi/ipmi.c b/hw/ipmi/ipmi.c index 74818ff3cea..dedf23cb997 100644 --- a/hw/ipmi/ipmi.c +++ b/hw/ipmi/ipmi.c @@ -59,8 +59,7 @@ static int ipmi_do_hw_op(IPMIInterface *s, enum ipmi_op o= p, int checkonly) if (checkonly) { return 0; } - /* We don't care what CPU we use. */ - nmi_monitor_handle(0, NULL); + nmi_inject(NULL); return 0; =20 case IPMI_SHUTDOWN_VIA_ACPI_OVERTEMP: diff --git a/hw/watchdog/watchdog.c b/hw/watchdog/watchdog.c index 0842fe373ae..5f764a0c1b8 100644 --- a/hw/watchdog/watchdog.c +++ b/hw/watchdog/watchdog.c @@ -81,7 +81,7 @@ void watchdog_perform_action(void) =20 case WATCHDOG_ACTION_INJECT_NMI: qapi_event_send_watchdog(WATCHDOG_ACTION_INJECT_NMI); - nmi_monitor_handle(0, NULL); + nmi_inject(NULL); break; =20 default: diff --git a/system/cpus.c b/system/cpus.c index 97e5a5edee2..9758cda4636 100644 --- a/system/cpus.c +++ b/system/cpus.c @@ -23,7 +23,6 @@ */ =20 #include "qemu/osdep.h" -#include "monitor/monitor.h" #include "qemu/coroutine-tls.h" #include "qapi/error.h" #include "qapi/qapi-commands-machine.h" @@ -926,6 +925,6 @@ exit: =20 void qmp_inject_nmi(Error **errp) { - nmi_monitor_handle(monitor_get_cpu_index(monitor_cur()), errp); + nmi_inject(errp); } =20 diff --git a/hmp-commands.hx b/hmp-commands.hx index a29f02b623e..43ff220b5fe 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -869,7 +869,7 @@ ERST .cmd =3D hmp_nmi, }, SRST -``nmi`` *cpu* +``nmi`` Inject an NMI, in a machine-specific way. Not all machines implement NMI handling. ERST --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891875; cv=none; d=zohomail.com; s=zohoarc; b=WFUzLZuqN9xQTr4mtkQSjBr2xOSzeMh3DIo6iWOCKkVSOr/zkpqss6F2SXbdc+29e5GkSLuo8gTCj6+hEPyf7YUUOtMsCK8GmOhpONjlLRDW2a42TfX/sCU6CJfrA8ExLtjm3HFcFkIOUKfbROUQM5HevSkMoVgJJU9Qo0h8a1U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891875; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=cyFe2lwd5CJAd/OU8x66v6i2Ml3gSEnyF8C0HHAtKvA=; b=d3BcFbr8HzZlfTgvhHr77B9ddQT/iu3PtCxvMffkvYE684Rv5knw+MSZRh1L1sr28VaXmDY9rDok8ti0Yg9i9fROvqRLkVXGyvLlJqPr0lniPDn2T07rdSdwaCPUeiD14IhDn3HDkXVw88QU86yAs+pqYXlrJZ0WFJ7lmaZxoHc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891875591517.4642582846245; Sun, 16 Aug 2026 07:51:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcCN-0002cK-0X; Sun, 16 Aug 2026 10:50:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcCB-0002HG-Nl for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:50:45 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcC9-0001fL-Mw for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:50:43 -0400 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDkqcE3950246 for ; Sun, 16 Aug 2026 14:50:40 GMT Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghnumem-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:50:40 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-930b571432fso246484785a.0 for ; Sun, 16 Aug 2026 07:50:40 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f219d3dsm25066490f8f.14.2026.08.16.07.50.38 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:50:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= cyFe2lwd5CJAd/OU8x66v6i2Ml3gSEnyF8C0HHAtKvA=; b=GslHwfUv6JshPAWp cOwZ48KdpDGQd5ZY21P6yktg4CmIT62gB24Q52YPVcyGcsF7ScmuJ1dEyGNboAEr XG/Fey6cUE10036jNmRufy50erx1JZ3h1jw6lH+3+4nTTN+DFjv9sPCcYmwDJqTt SRqQwNTG92lIQZFoAuen9tN5jGBhq4he4YMJjvRJ2k29JkInbIEt9vrMDXnIuhAt FvE7yJlvn+KQnPPBR1PikNV7FA9zNgVTI/JZymFYp3xiO3et1VCSfGL76kTpsumO w1MiBhue9zX37sJN4P6rbYyW1WKtdyVKZSBFiE0QaOZ84U9gDRcIppbujZh/r5Pd jIb1Zg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891840; x=1787496640; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cyFe2lwd5CJAd/OU8x66v6i2Ml3gSEnyF8C0HHAtKvA=; b=cBpGePHQbW2o1VxGhUdEOwIXnj7lIUiuSKoiH/cm+L1njIjtfw6G4ojC9fP4VV7oe3 eiz5chXhaN45W+/GXseI4ZdsSsYMePwdFYYlq6vXUJ+Z+8akHpohjBDdJ1ZM/0HZS2jL j0yVNYI9kqfPjYYBRIcycJ+Z/3ca9MSo+2Fq9uwCNz627q6wOsE5JlJ2OZy4TjZpF180 YH9Xr5mSp0nMR0k233fCz7H3jc/yDnCw4kflnbKYeBuH8mJba9WlYlvMqblpxDzS6NL7 5K9ZlL+i7KWl53SHBp9tWfePwzeZI/A7PRVsv/ksM7wi2k+Gri5NaxIGetn2TYTrp3R2 cxSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891840; x=1787496640; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=cyFe2lwd5CJAd/OU8x66v6i2Ml3gSEnyF8C0HHAtKvA=; b=p5w0r0t/HK9Cs4PRfei3PAk0+iJOUo569bR0uJ3qb6fJyDCVDbOXreFAOfT64C5Ak1 lCuJna4LJvV4IzYmgim/5J2DT3mZrvhQkEugShlpWLU7V3qKwKEjl18XyUI/9CcBmGzQ Kkr+W1abxI5AtC9Oqp5nTG8gyn9CXYyOLyTjoFkQX2/X1jJI1Anv00haJzvueU+A+E08 79lLhNZq3220RSMsmsIWk7wFuEWTTqryBdygmvYv2o3pHKz15DUW6ZC39aJwQvsTW3ii O99+CF5Jn8crZeqo2kGKajpmFePv/wWtZDl3+3harW6lrAZ0AM0DGLGcgDuxPJxlsc6J wKYg== X-Gm-Message-State: AOJu0YyGAkf3iBXk8cRA0YRkefy75mD32+WzLjT0CJ/rTjeGadhd197z Fk8Gbc1MbbRLfWWZuKzDKoeXrbULm0hWXbQqjqPJ/b1u9f9bETNGprBM6GR1DDj8O3iEyh4F+tv 2ssZikC+j43tIy1wlPntkQH6JoRfm9ZE5MEgkZQvuSw1RA46A+u46ib9xqeK5j6qqyw== X-Gm-Gg: AR+sD130V+X+9OpfovqjbfhDz5RHur1ObFiNZDfJihj7u7k06Lv6kxzdj/HhVTgtMJX YI4sky5Ct/X0qLY7lFoYFzSeyv9Hy5JDbmW/U9R0tF7rPqRRYE2MdRH5G0LLAJSo4IqJ126FwN8 CAvj5Is1fzQORySVqGNTMlZR2L1yggJQDeNr7UvZT/q8hEtg6H+goizphMkHOUh2DnTFSsR5RkV L6IM5srkrR98mp/vwjZ1z42/HDAUXRj0468oHyHUx8KHY3rSU6o1G/c5s/aL9JA/oQ+7hapAdyQ GIBn8t2o6xdXFiotnoyAsUi+RAHUQ6vNB7pv/jxPNmWpQQBG/vfArlI3Acak1L0g6Ili8uHWisp yu/ObigiCnR/hNT476Mk5rdwWcGbiJvD97WLdXXYgOA== X-Received: by 2002:a05:620a:258a:b0:936:f7bb:9530 with SMTP id af79cd13be357-936f7bb96bbmr99725685a.1.1786891839918; Sun, 16 Aug 2026 07:50:39 -0700 (PDT) X-Received: by 2002:a05:620a:258a:b0:936:f7bb:9530 with SMTP id af79cd13be357-936f7bb96bbmr99723485a.1.1786891839417; Sun, 16 Aug 2026 07:50:39 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 33/56] hw/nmi: Rename nmi_monitor_handler() -> raise_nmi() Date: Sun, 16 Aug 2026 16:45:32 +0200 Message-ID: <20260816144556.69009-34-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfXzifEwapYevNT fPIEvhHdnmjrKFNDgKAKeUnAPDThl5hOY6eHbfuNQjZXvyE9RIACmm4F5+7v8j3PlXYbxoe6cIS GxqIZdfK7Id0Gp73WGsWi/NRGEpDA5F13oHjMb9Ppfbx7fj8m8LpfvtEI9aGy1SCdJ7z7ZL9PmS uPop3vWbms0g373tQJwXIij7rDbS87jyRn9LQ8uZApPVXe50vOPDciJ28baVpn7HBb6fprfUotx 9bwM6OhLJNSiEEoQfKMcVWUHIP+WkxPJchRBLyliQxN6zCDfrT1wPT5CGuT4M8xTzo6qwheqla1 XaAOnDMzJHA3HyO7rA+LdLeTKgCmfHUu7824uf2HxaI/14vGo2QstkmGCBYcb3X+IMO8/vTtIYI /AXXWIgj79JZR9f1vdQ/LYg/iW0SCYviI5eoRmgh/VuXDMz559XbnPXNumt+yQLYLdjrki+d/mX ogZ4e3TmwUsZkGgINkA== X-Proofpoint-ORIG-GUID: qDm4Ec-SO9XmvB8lYXa90yYLrmroQE3_ X-Authority-Analysis: v=2.4 cv=QN5YgALL c=1 sm=1 tr=0 ts=6a81ce40 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=20KFwNOVAAAA:8 a=XQsbmRuMgCUMduHJsesA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX9zMKzJfT8V9W vgVH9I6qt3PgJ0/5qu/1zLp/jmA1CNwLbVVEt8tp0e/RaX7FJzf+l456utMiLhAvN0ybhEdQzhz q2t90jBQWqnW+ggu8hML8WjBiKfLkr8= X-Proofpoint-GUID: qDm4Ec-SO9XmvB8lYXa90yYLrmroQE3_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891876831158500 nmi_monitor_handler() is not related to the monitor, rename it as raise_nmi(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau Message-Id: <20260812121232.71958-6-philmd@oss.qualcomm.com> --- include/hw/core/nmi.h | 10 ++++++---- hw/core/nmi.c | 2 +- hw/hppa/machine.c | 2 +- hw/i386/x86.c | 2 +- hw/intc/m68k_irqc.c | 2 +- hw/m68k/q800-glue.c | 2 +- hw/misc/macio/gpio.c | 2 +- hw/ppc/pnv.c | 2 +- hw/ppc/spapr.c | 2 +- hw/s390x/s390-virtio-ccw.c | 2 +- 10 files changed, 15 insertions(+), 13 deletions(-) diff --git a/include/hw/core/nmi.h b/include/hw/core/nmi.h index 851be28257e..a8feac3b67e 100644 --- a/include/hw/core/nmi.h +++ b/include/hw/core/nmi.h @@ -38,12 +38,14 @@ struct NMIClass { InterfaceClass parent_class; =20 /** - * nmi_monitor_handler: Callback to handle NMI notifications. - * + * raise_nmi: Callback to handle NMI notifications. * @ns: Class #NMIState state * @errp: pointer to error object + * + * Called by nmi_inject() to perform the machine-specific + * action when a NMI is requested. */ - void (*nmi_monitor_handler)(NMIState *ns, Error **errp); + void (*raise_nmi)(NMIState *ns, Error **errp); }; =20 /** @@ -58,7 +60,7 @@ struct NMIClass { * and on s390 it triggers the RESTART interrupt on the first CPU.) * * The NMI is injected by looking for a QOM object which implements - * the TYPE_NMI interface, and calling its nmi_monitor_handler method. Usu= ally + * the TYPE_NMI interface, and calling its raise_nmi method. Usually * it is the machine model class that implements this interface. * * Not all machines implement NMI handling; this function diff --git a/hw/core/nmi.c b/hw/core/nmi.c index 2d890f2995d..a6edf4fbf01 100644 --- a/hw/core/nmi.c +++ b/hw/core/nmi.c @@ -37,7 +37,7 @@ static int do_nmi(Object *o, void *opaque) NMIClass *nc =3D NMI_GET_CLASS(n); =20 ns->handled =3D true; - nc->nmi_monitor_handler(n, &ns->err); + nc->raise_nmi(n, &ns->err); if (ns->err) { return -1; } diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c index 2b44debc388..717cfde61da 100644 --- a/hw/hppa/machine.c +++ b/hw/hppa/machine.c @@ -851,7 +851,7 @@ static void hppa_machine_common_class_init(ObjectClass = *oc, const void *data) mc->default_ram_id =3D "hppa.ram"; mc->default_nic =3D "tulip"; =20 - nc->nmi_monitor_handler =3D hppa_nmi; + nc->raise_nmi =3D hppa_nmi; } =20 static void HP_B160L_machine_init_class_init(ObjectClass *oc, const void *= data) diff --git a/hw/i386/x86.c b/hw/i386/x86.c index 0ea5453403d..d1414ff63db 100644 --- a/hw/i386/x86.c +++ b/hw/i386/x86.c @@ -389,7 +389,7 @@ static void x86_machine_class_init(ObjectClass *oc, con= st void *data) mc->get_default_cpu_node_id =3D x86_get_default_cpu_node_id; mc->possible_cpu_arch_ids =3D x86_possible_cpu_arch_ids; mc->kvm_type =3D x86_kvm_type; - nc->nmi_monitor_handler =3D x86_nmi; + nc->raise_nmi =3D x86_nmi; =20 object_class_property_add(oc, X86_MACHINE_SMM, "OnOffAuto", x86_machine_get_smm, x86_machine_set_smm, diff --git a/hw/intc/m68k_irqc.c b/hw/intc/m68k_irqc.c index bc41b44d455..29f758dafd1 100644 --- a/hw/intc/m68k_irqc.c +++ b/hw/intc/m68k_irqc.c @@ -97,7 +97,7 @@ static void m68k_irqc_class_init(ObjectClass *oc, const v= oid *data) InterruptStatsProviderClass *ic =3D INTERRUPT_STATS_PROVIDER_CLASS(oc); =20 device_class_set_props(dc, m68k_irqc_properties); - nc->nmi_monitor_handler =3D m68k_nmi; + nc->raise_nmi =3D m68k_nmi; device_class_set_legacy_reset(dc, m68k_irqc_reset); dc->vmsd =3D &vmstate_m68k_irqc; ic->get_statistics =3D m68k_irqc_get_statistics; diff --git a/hw/m68k/q800-glue.c b/hw/m68k/q800-glue.c index b13e5ef95f1..265af90a8e6 100644 --- a/hw/m68k/q800-glue.c +++ b/hw/m68k/q800-glue.c @@ -237,7 +237,7 @@ static void glue_class_init(ObjectClass *klass, const v= oid *data) dc->vmsd =3D &vmstate_glue; device_class_set_props(dc, glue_properties); rc->phases.hold =3D glue_reset_hold; - nc->nmi_monitor_handler =3D glue_nmi; + nc->raise_nmi =3D glue_nmi; } =20 static const TypeInfo glue_info_types[] =3D { diff --git a/hw/misc/macio/gpio.c b/hw/misc/macio/gpio.c index 1bdca728f97..db0c4ecb3cf 100644 --- a/hw/misc/macio/gpio.c +++ b/hw/misc/macio/gpio.c @@ -201,7 +201,7 @@ static void macio_gpio_class_init(ObjectClass *oc, cons= t void *data) =20 device_class_set_legacy_reset(dc, macio_gpio_reset); dc->vmsd =3D &vmstate_macio_gpio; - nc->nmi_monitor_handler =3D macio_gpio_nmi; + nc->raise_nmi =3D macio_gpio_nmi; } =20 static const TypeInfo macio_gpio_init_info =3D { diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index 8676be7bbb1..a9f74245866 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -3583,7 +3583,7 @@ static void pnv_machine_class_init(ObjectClass *oc, c= onst void *data) mc->default_ram_size =3D 1 * GiB; mc->default_ram_id =3D "pnv.ram"; ispc->print_info =3D pnv_pic_print_info; - nc->nmi_monitor_handler =3D pnv_nmi; + nc->raise_nmi =3D pnv_nmi; =20 object_class_property_add_bool(oc, "hb-mode", pnv_machine_get_hb, pnv_machine_set_hb); diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index c376a588720..1bc90ceed35 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -4652,7 +4652,7 @@ static void spapr_machine_class_init(ObjectClass *oc,= const void *data) mc->nvdimm_supported =3D true; smc->resize_hpt_default =3D SPAPR_RESIZE_HPT_ENABLED; fwc->get_dev_path =3D spapr_get_fw_dev_path; - nc->nmi_monitor_handler =3D spapr_nmi; + nc->raise_nmi =3D spapr_nmi; vhc->cpu_in_nested =3D spapr_cpu_in_nested; vhc->deliver_hv_excp =3D spapr_exit_nested; vhc->hypercall =3D emulate_spapr_hypercall; diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index ac04245d65b..21d9f51ddcc 100644 --- a/hw/s390x/s390-virtio-ccw.c +++ b/hw/s390x/s390-virtio-ccw.c @@ -830,7 +830,7 @@ static void ccw_machine_class_init(ObjectClass *oc, con= st void *data) hc->plug =3D s390_machine_device_plug; hc->unplug_request =3D s390_machine_device_unplug_request; hc->unplug =3D s390_machine_device_unplug; - nc->nmi_monitor_handler =3D s390_nmi; + nc->raise_nmi =3D s390_nmi; mc->default_ram_id =3D "s390.ram"; mc->default_nic =3D "virtio-net-ccw"; dsi->qmp_dump_skeys =3D s390_qmp_dump_skeys; --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891866; cv=none; d=zohomail.com; s=zohoarc; b=XxYWO3MrjEGDPltlbGsj6Ay1Fvmcv6Nu/8CA6ZsrQjgN4BAOSNdlr8rATb7IUXriT/w60WKjSQpRnWnSA7z8YS/4GYJG+XYj82tCjy2EHAhrax5e3fMOtOyNOvS3hxBW4x09AQffhvmL5ZhWesth1U2kjl3b8llWqh4sRhz534A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891866; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=vBD/qH2HrRdyEfxFb3mpRVBEwoXoeUz72F8VXcHmGwk=; b=ZJmCu1mX+0KNpfjEAVvEzKtYaLwc3LwqCMXhA785/S1J2WA8USIbroqdZ2x8iNWO1hvrQUCCSZ8iwAtCxTXxFdOXpuEbLvftP8lqdKA/KUZ2ihu4Q2JbNmEi8APKxv+pjiVrRmHZ1LgAKauGVj51jjp5zl1StcZfjrA1/4Wf/BA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891866090877.277789228695; Sun, 16 Aug 2026 07:51:06 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcCR-00033r-8z; Sun, 16 Aug 2026 10:50:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcCP-0002ol-1r for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:50:57 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcCL-0001fx-J2 for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:50:56 -0400 Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDkkFM2760249 for ; Sun, 16 Aug 2026 14:50:50 GMT Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2h9gkh7j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:50:49 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-5283df62d68so30333381cf.0 for ; Sun, 16 Aug 2026 07:50:49 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f2c07d2sm24459004f8f.30.2026.08.16.07.50.47 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:50:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vBD/qH2HrRdyEfxFb3mpRVBEwoXoeUz72F8VXcHmGwk=; b=I8kRp0YgdFB6BnEo RriSf4uolTUDSMWKk7ZmRPEToxtErVLrrmVEA+e+6Xe4M9cAwrENxn7B53gQ18/s +/P7uwp40CHyfq3xNKEx9k4CNqdXWLhZ23kOblwr8ZPjGkPS6Eh16HTAG2M4JOVS nJoOiRNcJ1rgnf9SQ2CAAEduuO+Pdr3jUmlNJMGLp6pb5kZqiHpS3SOdr7cTqhG+ qKU90RybF6kB4t30e/q+PuvbWnDv+6bNUbdGDMAWpOrzjQEZDG5MqVo1PIOMOtad aFYTX9yxg47BVnGM/9QGOaK4T0/zpt0ls51gxeeXEDGgZLvk12hTModznIHiY+Rb DSR2zQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891849; x=1787496649; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vBD/qH2HrRdyEfxFb3mpRVBEwoXoeUz72F8VXcHmGwk=; b=BN7h/q3QfNWlQDHnTA73B+fHpn52lIFd7LvycRzdcNh1x/ajZm/jv7yi7IGWHAsCTO eqlKD9r+NnO65PYhsUkuw/oH/lgGaUaxFSN2U2WhRHeqbqXTZEG3Xit/rwy96pjnnDyu sz2OhsQblcB4ez3ia8zRlSzjcDFJYOm900v1DCaE8h/lpOFSbdxQKDv/vj0Fam/wvKJj ykk3ngUZNDPOUO7jWSnl1vlvs9KB2rCSlq133iLWbZAgNTjvjU3wINMw3x2OX9qrb4mD yLg75cNhjqLiggGqvlZ0GkgmAYr/InmZlw+6CjZFXpMAd8VUUcUpz+piYO8lb44DcBYu AveA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891849; x=1787496649; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=vBD/qH2HrRdyEfxFb3mpRVBEwoXoeUz72F8VXcHmGwk=; b=fBrCbs8KE+meWlnU+d3RibBxj56paDLbloxmZfybViqygD8HM7LbvIZGgfgxGlpF1/ ODLf7NHHkcIJv3SXD027w5urWvfklCgSj4hpSL+eGKlPhJy0/TTpjZG/j8B3v6vLKBlW 8gjkYzqcrpOcoy9B172t86dSpcv8SwZIjMx/MeaNvADxVfmNPtrVruUGKMmoWgdXlVWv HlZWiPewIVzwCCVHrYk5gvcBPKdFe73gjjSKem4I3AKVmlc4cc2qHXtd2qw5KlOxazEd yKXzDq5GkDSMEji7PsOWxQwPuFk9TYy6hRg4O4N3ypgdzl+doVi91fp01u0AJ0hxHm7X K6Rw== X-Gm-Message-State: AOJu0YyypZ1TcLF2pYzogFnXuOnMQrpIFPzhNEotjAiiHE42d50vP+EC oTM7QvfZ1tQv84KaMZWD2Idjh+/SJ2AtqdsjKT1IN3qAkSocn0Pdp4KzesbYaxa5b10YLJLNCGu awoWXnoxgBSEYWfcAuWWqfcFPgIp/c2rq3e8Kr6SLIFe2pKX0uCwm/TSB9w5xfJUqJg== X-Gm-Gg: AR+sD123Moaumxr8RZBjwR0IbDxQa7kS+NLRh+gmbcLQEJDcBczfy06npNb4immsk9u oXwZh+eBNvhFc3oRhvsAhabN+UeCcx1UEFsSIZqXvG4ktbITFJL8nPgBsf31QYiJECaVRgRRH3B Dq0565/mz4I0tANYHwH4QA7RvXPYaIh5Etxdrlzw/Rck4gWmJwAPFk6HXRdRShBS3w6vCTlq/YN Yjh7b/Mw4h7nvXpyRiF8G01P4zH3BWLvP83ZvBQf/HSz5c4NEWRsBlohSEzXIJrxpVu3PfQJD4x H0u8Z8r1xItRWSoRJE3/5vTxYREG9xjT7yMX9exxmJwOehv6cWH32u2rYAsQ2/mViiHmnX5ssU6 IG6EHWagaoDMRTCV9wXjiR1ljnK9kJrN7k9sNlgDS7g== X-Received: by 2002:a05:622a:64f:b0:51c:f3:34e3 with SMTP id d75a77b69052e-52d854d42camr198088891cf.28.1786891848778; Sun, 16 Aug 2026 07:50:48 -0700 (PDT) X-Received: by 2002:a05:622a:64f:b0:51c:f3:34e3 with SMTP id d75a77b69052e-52d854d42camr198088411cf.28.1786891848087; Sun, 16 Aug 2026 07:50:48 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 34/56] hw/nmi: Remove unused @errp argument from raise_nmi() Date: Sun, 16 Aug 2026 16:45:33 +0200 Message-ID: <20260816144556.69009-35-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: K-A-LhQjxIoYa8USWLkAfovma-ifzjxQ X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfXwePjKUNhYgFE Gj2aZ3T/JECbcXBFQM5C15aIgrl96f54J5oqCgrCqw8DZUDXJx1Uzncd6gRmJCWBWPdvHdm96gg sxqdWp4ViJJDZjaUyFCHZ4RawWAgzyA= X-Proofpoint-GUID: K-A-LhQjxIoYa8USWLkAfovma-ifzjxQ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX+mlhI+SFXwUQ fsEU6xsosEU3UUrLq+NNy7/o4e22Cx3eAi6py2QjocmC8nHaj4B2NVa6riUa2T0paesogZADyg3 GtKyLK1vZyqXRgrjcowMdmqBHdmpCgilYR+x5A5opnk+EXC2BXUmVmnUvFP08izJkWxddYXzZ6n pdkHI5Qlu4eFXCMS8e8H7VcX+WmZGF8P493/JF1ZK/s6ugzQK3vPxw/KtyQbS9c03Tdz+dKJBfx DoR63PJOFu9E1rMMI7UBlNFKoNLae4VNuNoyJgKYRva/23UaSvnBdznb2yZogSQpP9CM5BmSdVT kR0uP8dokErX1o/LIoHwDN9ZSdgxC8Y8zndbbD8m49lohXOSuRAUzHVl3p9/Da0QjKKTkApEYDQ f8CSGufkA5TalqvoFfOFZUsciXK+C47hXM3RDkK4CVVxOAoX801GChWzqHJrbuI6rCsLDgMaKnh CVzrflrG+4n1wF7juIQ== X-Authority-Analysis: v=2.4 cv=XM4AjwhE c=1 sm=1 tr=0 ts=6a81ce49 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=20KFwNOVAAAA:8 a=so-psXbHftmeYDB8DEMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 phishscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891866933158500 Not a single handler update @errp. The single user is nmi_inject() filling with "machine does not provide NMIs". Remove the unused argument from the raise_nmi() callback, simplifying the methods in hw/core/nmi.c. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau Message-Id: <20260812121232.71958-7-philmd@oss.qualcomm.com> --- include/hw/core/nmi.h | 3 +-- hw/core/nmi.c | 32 ++++++-------------------------- hw/hppa/machine.c | 2 +- hw/i386/x86.c | 2 +- hw/intc/m68k_irqc.c | 2 +- hw/m68k/q800-glue.c | 2 +- hw/misc/macio/gpio.c | 2 +- hw/ppc/pnv.c | 2 +- hw/ppc/spapr.c | 2 +- hw/s390x/s390-virtio-ccw.c | 2 +- 10 files changed, 15 insertions(+), 36 deletions(-) diff --git a/include/hw/core/nmi.h b/include/hw/core/nmi.h index a8feac3b67e..d71d92dfbb9 100644 --- a/include/hw/core/nmi.h +++ b/include/hw/core/nmi.h @@ -40,12 +40,11 @@ struct NMIClass { /** * raise_nmi: Callback to handle NMI notifications. * @ns: Class #NMIState state - * @errp: pointer to error object * * Called by nmi_inject() to perform the machine-specific * action when a NMI is requested. */ - void (*raise_nmi)(NMIState *ns, Error **errp); + void (*raise_nmi)(NMIState *ns); }; =20 /** diff --git a/hw/core/nmi.c b/hw/core/nmi.c index a6edf4fbf01..c44b0cf892d 100644 --- a/hw/core/nmi.c +++ b/hw/core/nmi.c @@ -23,45 +23,25 @@ #include "hw/core/nmi.h" #include "qapi/error.h" =20 -struct do_nmi_s { - Error *err; - bool handled; -}; - static int do_nmi(Object *o, void *opaque) { - struct do_nmi_s *ns =3D opaque; + bool *handled =3D opaque; NMIState *n =3D (NMIState *) object_dynamic_cast(o, TYPE_NMI); =20 if (n) { - NMIClass *nc =3D NMI_GET_CLASS(n); - - ns->handled =3D true; - nc->raise_nmi(n, &ns->err); - if (ns->err) { - return -1; - } + *handled =3D true; + NMI_GET_CLASS(n)->raise_nmi(n); } =20 return 0; } =20 -static int nmi_children(Object *o, struct do_nmi_s *ns) -{ - return object_child_foreach_recursive(o, do_nmi, ns); -} - bool nmi_inject(Error **errp) { - struct do_nmi_s ns =3D { - .err =3D NULL, - .handled =3D false - }; + bool handled =3D false; =20 - if (nmi_children(object_get_root(), &ns)) { - error_propagate(errp, ns.err); - return false; - } else if (!ns.handled) { + object_child_foreach_recursive(object_get_root(), do_nmi, &handled); + if (!handled) { error_setg(errp, "machine does not provide NMIs"); return false; } diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c index 717cfde61da..98931481b20 100644 --- a/hw/hppa/machine.c +++ b/hw/hppa/machine.c @@ -829,7 +829,7 @@ static void hppa_machine_reset(MachineState *ms, ResetT= ype type) cpu[0]->env.cmdline_or_bootorder =3D 'c'; } =20 -static void hppa_nmi(NMIState *ns, Error **errp) +static void hppa_nmi(NMIState *ns) { CPUState *cs; =20 diff --git a/hw/i386/x86.c b/hw/i386/x86.c index d1414ff63db..f8ba3244e22 100644 --- a/hw/i386/x86.c +++ b/hw/i386/x86.c @@ -147,7 +147,7 @@ static const CPUArchIdList *x86_possible_cpu_arch_ids(M= achineState *ms) return ms->possible_cpus; } =20 -static void x86_nmi(NMIState *ns, Error **errp) +static void x86_nmi(NMIState *ns) { /* cpu index isn't used */ CPUState *cs; diff --git a/hw/intc/m68k_irqc.c b/hw/intc/m68k_irqc.c index 29f758dafd1..47f626c0fa0 100644 --- a/hw/intc/m68k_irqc.c +++ b/hw/intc/m68k_irqc.c @@ -70,7 +70,7 @@ static void m68k_irqc_instance_init(Object *obj) qdev_init_gpio_in(DEVICE(obj), m68k_set_irq, M68K_IRQC_LEVEL_NUM); } =20 -static void m68k_nmi(NMIState *n, Error **errp) +static void m68k_nmi(NMIState *n) { m68k_set_irq(n, M68K_IRQC_LEVEL_7, 1); } diff --git a/hw/m68k/q800-glue.c b/hw/m68k/q800-glue.c index 265af90a8e6..223e7d9019c 100644 --- a/hw/m68k/q800-glue.c +++ b/hw/m68k/q800-glue.c @@ -159,7 +159,7 @@ static void glue_auxmode_set_irq(void *opaque, int irq,= int level) s->auxmode =3D level; } =20 -static void glue_nmi(NMIState *n, Error **errp) +static void glue_nmi(NMIState *n) { GLUEState *s =3D GLUE(n); =20 diff --git a/hw/misc/macio/gpio.c b/hw/misc/macio/gpio.c index db0c4ecb3cf..ba001f7b206 100644 --- a/hw/misc/macio/gpio.c +++ b/hw/misc/macio/gpio.c @@ -188,7 +188,7 @@ static void macio_gpio_reset(DeviceState *dev) macio_set_gpio(s, 1, true); } =20 -static void macio_gpio_nmi(NMIState *n, Error **errp) +static void macio_gpio_nmi(NMIState *n) { macio_set_gpio(MACIO_GPIO(n), 9, true); macio_set_gpio(MACIO_GPIO(n), 9, false); diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index a9f74245866..f0413639f98 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -3552,7 +3552,7 @@ static void pnv_cpu_do_nmi(PnvChip *chip, PowerPCCPU = *cpu, void *opaque) async_run_on_cpu(CPU(cpu), pnv_cpu_do_nmi_on_cpu, RUN_ON_CPU_HOST_INT(= 0)); } =20 -static void pnv_nmi(NMIState *ns, Error **errp) +static void pnv_nmi(NMIState *ns) { PnvMachineState *pnv =3D PNV_MACHINE(qdev_get_machine()); int i; diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 1bc90ceed35..20e024907b1 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -3550,7 +3550,7 @@ void spapr_do_system_reset_on_cpu(CPUState *cs, run_o= n_cpu_data arg) } } =20 -static void spapr_nmi(NMIState *ns, Error **errp) +static void spapr_nmi(NMIState *ns) { CPUState *cs; =20 diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index 21d9f51ddcc..06e5def9092 100644 --- a/hw/s390x/s390-virtio-ccw.c +++ b/hw/s390x/s390-virtio-ccw.c @@ -725,7 +725,7 @@ static HotplugHandler *s390_get_hotplug_handler(Machine= State *machine, return NULL; } =20 -static void s390_nmi(NMIState *ns, Error **errp) +static void s390_nmi(NMIState *ns) { s390_cpu_restart(S390_CPU(first_cpu)); } --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891874; cv=none; d=zohomail.com; s=zohoarc; b=e2vJX0slYMM3yyYrL4CtXMk9bOr4xcEuCD7lz1XXfFv4zy3Qhv+gavKD9LiwsiTjNJihShqUyjjlb2mdq9pkUpsySw0ITdkMgKNY9l8lrjI9Zd1m7Bqm6NSGnMVaWoDvr6Btd+JW/EKVSWgXXRRshdNpL2G3PNL5Rq6Pq7piZbY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891874; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=ksRCWie5nZ4NE9GCWQvLL1FUkXlvgO++VzaE3tB9vN0=; b=kEasKXwupU+1Fsa9xJ/HBQxOB8pOhTHSYWrR5jttviaGlgjx/WpgBoOiwQZ+iuF0JDFEDfB1g9aSDUsD4iFycSRN2aNV18pSht7RPUQ36QWYbB42QSLbBvxHTLY0anfyAKBRIIudtp3ckwWkGUX1YAPK+womwvZ+qEjfItl2ff8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891874954653.0282167072386; Sun, 16 Aug 2026 07:51:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcCV-0003fX-Ie; Sun, 16 Aug 2026 10:51:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcCS-0003H8-Kr for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:51:00 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcCQ-0001gw-PN for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:51:00 -0400 Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDl1YD2760682 for ; Sun, 16 Aug 2026 14:50:57 GMT Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2h9gkh7u-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:50:57 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c1a9764f0so29294001cf.1 for ; Sun, 16 Aug 2026 07:50:57 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4999610e381sm72951905e9.9.2026.08.16.07.50.55 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:50:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ksRCWie5nZ4NE9GCWQvLL1FUkXlvgO++VzaE3tB9vN0=; b=QvY3SZdRyQMABYGa A4d9xuHkHArPuo+mXHWUExl7ABDiO0wxxIGc3axGi24466QYTcopJ7LY+3RrTlbi yyLKO7v3Ho3aVxr8B2ARM34LaXddeGGwI6GGwyAySGR6zKk3/LevPWhTlCOSj79V ivTtLXowi71EYeiOiRwaUG2OyeQ4Hs317AoBYcMWXMaugA48V3ngVZHvpW+y2s3N QAv06yR3PAmrQFiADeToRuxm/7MyMiSPx2+uIJn3q8dX37hYRTsdfS/eHL+8eRDd olEnz0/28IG1fpHRC2bU7W2qCwQnTdeqyDePg+kUy8Pl+f5s83dReRHPIreuWCrZ 7c6vAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891856; x=1787496656; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ksRCWie5nZ4NE9GCWQvLL1FUkXlvgO++VzaE3tB9vN0=; b=KxBlSTX4DLqKi+nNzvNp2hUqFC8kgO7I53pJNA2SQPlwy5f9bskV2LXDZd9Cbgjwpa Oc9UscvIohPFwf6sT1gdBAu+fZ7TPE7YhF2iiOadrZ8tdN81mmi7HuIWpHdYBqCe4YqE B7tknXWaQZuzy2aARUKc1SABo55yTGH0eQ1lkc8HK1LKPlndkCPn45GLCEjbJTNODZPK HgkrlfQ0OTfclAkn5ksj5nEi3km/pRE57tKj6p6q2E1ft69+3Tey4oU5f9gd3X7Pqa2x 7uDsM8dzW/oOh/EENVfi5+h7CBFt8zGxj9TWR9/y9wCyZHCPp56c8q0kiTbcgkI5JxUY 41Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891856; x=1787496656; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ksRCWie5nZ4NE9GCWQvLL1FUkXlvgO++VzaE3tB9vN0=; b=a/9xW6Bpqh0KuxNjFUGICI693lGm/uvyLLtfDE0sdaiHqN+oOdDTDtdg2c6nKQpkcn AE4EWlq9KyIex5N83A/BuJXW1ppFPa23zqm4OPl9luL7IL/KjlRsgvIOCz2vCui/GGr6 6f7TnhHIS/7rPhTyUbl6/8vh34T7Ec3s2GwUlhOau26qxvhfIYVCnYy8kA5w8lQijylR HGbSlplCSugJIebe2BhS+uQ/oif2Dp4IKbNy298glq8xSx2CooPe0Zx5Y8q9zHugjOEA eTMYFsXWiBql47XL3pygcXx+pcGye7TA2KAzZLiVbwrnBnQ4FQiidEuobe6cS3JZuNhT cKng== X-Gm-Message-State: AOJu0YyeEd56pbIbse+LcJ8xEjguKM5Q2c+27bnBUR35Spi+3/rWN3Xh abam9SF16xTVYfRJpRxUE2RkiuOce+LUWasBL6KIUrgJoOP4UkqOcN9Vw9032BdkxkSfYXsgqZU m3ipqVzbTQSm4dVGIIstJYR8id+E2tNfYd6az6oQu6l7IBHqXyHCKvhv+6nQnvmEq+Q== X-Gm-Gg: AR+sD11aQXtUmnJvReYgtu1gQHGswqyyiuiD7nTqLDKLBIsMJlUw8zL+UuWolty5Ps8 +g1jpD2y+1+1jTmVL0Jj5IqF4XgFM5jQq2o8DkmOECVxN8zIIb6ZNTGX/2mcTM6tl+/t9P1VPns Vikd7UdeuXv2kSEfX7re0jV9lvSfJs0+Zu+bQIyfKaZt6Zaa9AL+fWTNrlCgqlEgs1nOQH9ifbp xW0xko0c+knIq3RHIWx+CYLziEj7CdP3j3HeIyMPfrfAn5TErYgDWAup9cUYpn5ovz4X7GIHGfA CuGeG7gAw7vNTE03A9SaoA+9VJ9YdzObzor3qwb/rfSJ3h+fzGCwyIoIqUhzvIrt6LeoRoQbyZR aJQ40hhb9ybSnh0vAePevtj+GPFKK3lPrvyCx91JvNg== X-Received: by 2002:a05:622a:190a:b0:528:f72:a986 with SMTP id d75a77b69052e-52d855b455cmr171072321cf.44.1786891856356; Sun, 16 Aug 2026 07:50:56 -0700 (PDT) X-Received: by 2002:a05:622a:190a:b0:528:f72:a986 with SMTP id d75a77b69052e-52d855b455cmr171072091cf.44.1786891855924; Sun, 16 Aug 2026 07:50:55 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 35/56] hw/nmi: Raise NMI line only once Date: Sun, 16 Aug 2026 16:45:34 +0200 Message-ID: <20260816144556.69009-36-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: joM8z3aKvdlPh5_72CLGqlpcKlInkxrb X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX+J5EAo/ZS7T2 mXYlCa2vp1hOJW8c5ay91nT8VsIXp/5QoyYK4RKJ0ChUAH7CF8+9ZVR6pAUkDzyHPTG5MCjlPV4 5fwJmnoZ2IejGb3ef7WBiTYPGduG8aM= X-Proofpoint-GUID: joM8z3aKvdlPh5_72CLGqlpcKlInkxrb X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX0gw1KPtkoO06 8ydAtRR0pbZ5zn2tU3sihTkBUi0ixQoKILtxVMMUh0AswU46XdhdR8QPxPJiUVuIyTOivMqrSeh Ijco2Pm4tZWheKVIURhjoi51XE50NVhsXb6dlqbOeWC614MCPijEJxXmGwwPVc7KCinhPSSsYIs G0pL141v9e3en3m8WGQ4hQHN73jfYksz5Rmb6LKp0gPHno6nASoErzRIzP3Tt3vw3fxYSHuvFM/ 3CEfVt3qxqLKkg4vu00h9lv/VJzBuKYJtJuQzey6KOZlTC7Hbu7D41aQ5v3qCk0XMzWMP0S9Wni J3eLN/cCffQb2iQrhbjuahpGJCpZGMPq7Xvj9IIse9Km1bWr0BCRN0/3PP6t3xSnrHoPjYwG8Mh wSw+jGAmiy+4MGM03FpgXYK9eE9SChWvsvRESQLpweaDzfUDOghJClkHCN7cpG3T1vOXp3EdyfQ KafHvDl6EXbsDKI9Lww== X-Authority-Analysis: v=2.4 cv=XM4AjwhE c=1 sm=1 tr=0 ts=6a81ce51 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=20KFwNOVAAAA:8 a=HZQsDzxzLdBvz1sOA9cA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 phishscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891876768158500 We only expect one device in the system to implement the TYPE_NMI interface (typically the machine, but in a few cases for e.g. m68k and ppc this is an interrupt controller or similar device); so we don't need to keep walking the whole QOM tree once we've found it. As no machine type creates more than one object implementing TYPE_NMI, this is not a behaviour change. Suggested-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell Reviewed-by: Marc-Andr=C3=A9 Lureau Message-Id: <20260812121232.71958-8-philmd@oss.qualcomm.com> --- hw/core/nmi.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/core/nmi.c b/hw/core/nmi.c index c44b0cf892d..84f21665987 100644 --- a/hw/core/nmi.c +++ b/hw/core/nmi.c @@ -31,6 +31,11 @@ static int do_nmi(Object *o, void *opaque) if (n) { *handled =3D true; NMI_GET_CLASS(n)->raise_nmi(n); + /* + * We expect only one object to implement TYPE_NMI, so once + * we've asked it to deliver the NMI we can stop looking. + */ + return 1; } =20 return 0; --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891887; cv=none; d=zohomail.com; s=zohoarc; b=RBY34/nQu1V7tliehCKSgGgfgy8FAR6JfVJp/jmEvOpk/IgHvmUE5H1L4jxPZ+yMW3MRdF67UDn533Uv82ABQ0Sq+HAJn1RwbQjsRy6ZF/aAICMTn3xuarJsX5di2rpi26QT2jSrujbsBfebUkxSBZYCIoGrpgjSPAtYVhEYRv8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891887; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=bDq8Q/JyB3UGBew5OiU+qn7XnjxMvl2xSHvHGXIdZVs=; b=daeYFdZEy9hUtk18GK4y2EileOD3IYslZST0Gr/DvaN+D7rUj+Xm4n9NPsRG6RMI6bCG79cH/TfCwlJ+ij+DB9A8jZ6MFjOPFg/05SSsO0M3qNM/hP0cbfZX9CnNBEeb7Ieni+M0ro/FTLke4EpA+CQ5BVF1bhk2EANnpeso26w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178689188718750.09800374361805; Sun, 16 Aug 2026 07:51:27 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcCh-0005HE-AX; Sun, 16 Aug 2026 10:51:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcCe-00052B-U7 for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:51:13 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcCd-0001o5-7c for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:51:12 -0400 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDmHKi3952772 for ; Sun, 16 Aug 2026 14:51:10 GMT Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghnumfr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:51:10 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-52ce3c7cb2eso46896141cf.3 for ; Sun, 16 Aug 2026 07:51:10 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4999611bf65sm47839845e9.13.2026.08.16.07.51.03 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:51:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bDq8Q/JyB3UGBew5OiU+qn7XnjxMvl2xSHvHGXIdZVs=; b=iwv3ofs9daDkNHcY g1dhNcsEZ4QjABXtMeC5X0+b62ctPB8dDBeU8rPOiYI2xlkFQmin7U69HrGKJHly G0kMRCeOXqxoA2CMtEcDPZlJQpnGD/hou7XaOV8Kw8NB01fTg9c8uL8tfMiEo+L6 SU2C3JhU/71MChVixqU4ejRgFgCUfxLNWgT8cOf4Hsx/zAGlRKl3WNPiHkwUqJ6M X8RQJWnIZIq6yt0BnnJWg80Pohr28cqlZp6/uHMCHqi5GaJSqQZyVD7PtFVDLSPe Vwbfbp7cSFWPNF7kgTj77ZtnEvFTHR0oheYrp97fLxOf7jg4MMVnBFPCIJffuAaI kc7grA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891869; x=1787496669; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=bDq8Q/JyB3UGBew5OiU+qn7XnjxMvl2xSHvHGXIdZVs=; b=U2snB6rFAbgrUcur55csfpEv+lIO2NM+3tO96Pb4dqUjG7PGhryZOtbmlGb6KElnv5 GioKWgJar9dtq13N+LF77DkTMDM7hsyhf9cUn4KjzNrCmdDo+6AdTKGzoKcHyEBnx5h+ Ha1SVmfv8FG8/6+kOXjUW6NRmfBkyQ9eVvNo3LsUYZ8z8mIggusYKgbNZwzPdcMrbuYw +YXdDiWrURbp1Ok40oNu/H7l0kWwJwLy/TDv5v2KdTMWVz+Yr3RbiFi4T/qE9tV/DHBZ J35TESqHhqtYAl6MTezH1/dnZXPCATqtPC1lsNHT4tjVq35k8+wQCgWxVX4JqUjn7aXM y0GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891869; x=1787496669; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=bDq8Q/JyB3UGBew5OiU+qn7XnjxMvl2xSHvHGXIdZVs=; b=en6wyZbrPW/ZQkn7lGyG53r5M/Tyh0sMjyIgTwcxz0ocsC8t43ZGfXSdg8/RcyvwwD /zBgSV/FOdLEZ12aM/gnuGAUWcgHoVaItu0VM5Qu6Ub/BR5ppw3apv0qzAOxrX2nQPQ1 aYXG5F2nRErCfZZr6k1YWBS+zLS3TKSPU2ZonqdlAyD+Ln0JZJOvF/a3SQBeE/4LYvtj R0p6E3ctpw7zW0dagAZvy9ahu+nRVrOaFkSmFDD+puXNUFgZNuvVRgVv7RRgLOHXpaYo ZUNAWcYn3shvFBhaH+yX6HMQB7zUD2YFPhTNccZFRyOf5/0SUyps6be+i1JvuKHz1GNw bA4A== X-Gm-Message-State: AOJu0Yy7IZdQFC1ZoSuKW4kOqW3L6xYRa8F9LJWLnasNXVKfKOnELbef lXyHKKelH+WHC0oX0ob+VkyfWym4LUDGnaxJ8EdVQa4pA35Bln9maIyHn7iGU+nR2GJM0Ht9KVV kBsqAEX8ksPcxaRItOML60DqPkVPF+uihtqXEh1X74mDazOJs2Vr4QtVUJmLYlLvE6A== X-Gm-Gg: AR+sD13kCxq5CBarhGESG1xTKUJJYyPTnhRgMHSBqDS/DL5TSnQZbyyWDsGxYps/cXr RZvCgzpqwRV/HNkauajTxxF8ikg/nWN9lqNPHfvpnvTseHFI2pL2DHfL/IeJlo0xYoMq9Q0691I TnlWeRdx3Gw9Re0Zor0LNiAlSh1xyBh1ulGAYh6uXcFVH5chRE48sEvZOsCwLbckt0nv2pfAsjR YFTPEQmxJ7EKaE7oh6tOekV+LDxiID8Q8Ql1agPT/kLnuBtqlnaert9Mo4B/x+FrRfzXEYD0dGp I2r8YJAVS7pbED6+Zwnej0ykE40L4g+e44vNKQJr/bfPBNnr3DH6q2s2Mb1oh5XXS2Fkfaka9wu AU2EHGX74tk9I6Id6HOBTNSPzMd9tt4WkStMOerXKbg== X-Received: by 2002:a05:622a:58c5:b0:527:7027:cc1b with SMTP id d75a77b69052e-52d854b2a48mr216907421cf.32.1786891869526; Sun, 16 Aug 2026 07:51:09 -0700 (PDT) X-Received: by 2002:a05:622a:58c5:b0:527:7027:cc1b with SMTP id d75a77b69052e-52d854b2a48mr216906921cf.32.1786891868999; Sun, 16 Aug 2026 07:51:08 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 36/56] hexagon: Remove unnecessary 'monitor/monitor.h' header Date: Sun, 16 Aug 2026 16:45:35 +0200 Message-ID: <20260816144556.69009-37-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfXx739x+BtVxAu cMBRSpfPnYVZ85V0PjJoBgF4u75iqRYttqL9ox199x5l49YM+fYPz0qvYRerW9udQZImm1Bco28 ZooOJIK8oGwvZ6sDDXvzNx3kqglns5paPAe/0Jz71+VDA7URB5oT0nWzXYSnEPKkDk9vz+wRlGW mq4E2j80xDDdpFiBbJyoUyIvR35xng5alenDGPHHn6BXsWvxAUnrRpne7R86zyPlZJ8wP5mfqam xxbcMS1iTZ2p+Y25liS+QsQ5GZcB6pRTFx3fCdhxyqRbJJ4ZrZ+R8cxy0woJYbEU9nF7e+NyJ/n tt9YQQFbBPrBhx/ohCW5PnnAsnsThljfMN36Ly24u63pky4VC6zKZ0Q6rzuerlCJiyHAncsoxYI 0mrPJra+9wlDy05x58XV3oLVnO+fWF3OFOca7IwMeQRGVLsPOkdxUoRZCWr6GTL/09dsk6yH1rr tOwGC6a5eczTfkw+NAQ== X-Proofpoint-ORIG-GUID: 0mwTIqW25OK-k3vDigIZWWAXMH4553rH X-Authority-Analysis: v=2.4 cv=QN5YgALL c=1 sm=1 tr=0 ts=6a81ce5e cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=20KFwNOVAAAA:8 a=-f94bmcIBZYFaPXTGXwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOCBTYWx0ZWRfX54QIvtjR0Dw3 NWa3aeLI5EyN/KKvDJxFvay4DqMaV7auWPv3tljx1rrG78VxAyYRXTzJbuooSGHqwXrB2T6Y75G QaNWs8rJbTwWOOkd5JMNaDWtItkfSIg= X-Proofpoint-GUID: 0mwTIqW25OK-k3vDigIZWWAXMH4553rH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160118 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891888821158500 The Monitor type is used in these 2 files, as a pointer. Since the type is forward-declared in "qemu/typedefs.h", which all source files include via "qemu/osdep.h", we do not need to include it. Do however include "exec/hwaddr.h" and "exec/mmu-access-type.h" which declare the types used by hex_tlb_find_match prototype: extern bool hex_tlb_find_match(CPUHexagonState *env, uint32_t VA, MMUAccessType access_type, hwaddr *PA, int= *prot, ^^^^^^^^^^^^^ ^^^^^^ uint64_t *size, int32_t *excp, int mmu_idx= ); Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau Message-Id: <20260812211708.92824-2-philmd@oss.qualcomm.com> --- include/hw/hexagon/hexagon_tlb.h | 2 +- target/hexagon/hex_mmu.h | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/include/hw/hexagon/hexagon_tlb.h b/include/hw/hexagon/hexagon_= tlb.h index 90d9ed84043..760dc1ea811 100644 --- a/include/hw/hexagon/hexagon_tlb.h +++ b/include/hw/hexagon/hexagon_tlb.h @@ -12,7 +12,7 @@ #include "qom/object.h" #include "exec/hwaddr.h" #include "exec/mmu-access-type.h" -#include "monitor/monitor.h" + #define TYPE_HEXAGON_TLB "hexagon-tlb" OBJECT_DECLARE_SIMPLE_TYPE(HexagonTLBState, HEXAGON_TLB) =20 diff --git a/target/hexagon/hex_mmu.h b/target/hexagon/hex_mmu.h index 4f556c715a9..6aa450b9413 100644 --- a/target/hexagon/hex_mmu.h +++ b/target/hexagon/hex_mmu.h @@ -7,8 +7,9 @@ #ifndef HEXAGON_MMU_H #define HEXAGON_MMU_H =20 +#include "exec/hwaddr.h" +#include "exec/mmu-access-type.h" #include "cpu.h" -#include "monitor/monitor.h" =20 extern void hex_tlbw(CPUHexagonState *env, uint32_t index, uint64_t value); extern uint32_t hex_tlb_lookup(CPUHexagonState *env, uint32_t ssr, uint32_= t VA); --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891906; cv=none; d=zohomail.com; s=zohoarc; b=hsU4hAXUQIeOBcq4mDlFYJCvUteyRp3LP9hJ6fb0T4fdhdrsCA3P6kcJT/YOk387V7elsTOLAGB63Y2p1ib/6sQzVBvghLNZ8wL/WBwDk8wmM7jFeyL7774uhyVUe0Mheb2SZ1KY+jlvdLpE/wWwdkbT8rb127I4qlLwWRik7iM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891906; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=6mgJUWFqrEErrhAVCpUHLA6YxEppcaZB/77+pF0u2VE=; b=YduiVo5TosLUtr8Q56fImR/wMuBsRw4yrs7mp64Dk2rfFFra1FOtNLn5lKyzsJeqI3RC8Uuf0duW+RggdYVwSXT5cWF8HE4uTBhjJRUtsoNOz1M4i7+WkfjQ+G6gj72GzBZTUq5pdKOiZ/uilsk63B3GlB4DsHTdBtmpOybmS0U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891906001630.841337452693; Sun, 16 Aug 2026 07:51:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcD4-0006EY-GG; Sun, 16 Aug 2026 10:51:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcCw-0005wq-4J for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:51:31 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcCs-0001qT-2A for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:51:29 -0400 Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDl09s3532565 for ; Sun, 16 Aug 2026 14:51:24 GMT Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghf3mn4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:51:24 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8f113592bf3so48883426d6.2 for ; Sun, 16 Aug 2026 07:51:24 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499960988c6sm61459905e9.0.2026.08.16.07.51.18 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:51:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6mgJUWFqrEErrhAVCpUHLA6YxEppcaZB/77+pF0u2VE=; b=OHAyDwFLY0hf1uUJ v9YViDtddK6UZjRXhsA2DpuKthWuhV3RIclOETb9E+EZ+bQf0w34MXNzh0pYNKv/ 3OK5eF5GdGSdorfsg4fEPcSOuHddv97+S0/PMTxj78uTCySHl9VaWN3whLU4aFDs AhoW17RGtNLpgtgeu490Slz6zy0uyTk7jZtdg8h7hmzYIBoVqilhSqIfGVxQyydD WrdgpykxX9TkZ4E4+vMwQxXYbMXG1kqRHDjxzolUIFUtx6FSdiu4koWU0RDj4a4z XU7Y8exfZ/jEhelBfRI19p0wwqlpxnZWoyIdPa3yv+5QBpN40mPJF36j8WieRKhW 8NmR6Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891884; x=1787496684; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6mgJUWFqrEErrhAVCpUHLA6YxEppcaZB/77+pF0u2VE=; b=FpOYhR8o4YhpYOSZ6XOX6rKZAGB5FEpt9iahFeQ1GlQvtRkjsI9CLmRtjDPoO+ghx0 famMI1vKwfrSBII6jmr02kpdpZSdTRFsjGwc9VOuKpqTuGIQgrtazuf6UK6ZTAv5DRsl Q3m5dN4UH5nKPtUx/ULBV4HT6O9rfeEdlh/D2PEOk5P1C1y8IAKTZLuCAtJ4dlP3zHtT 8CVT4lYynJOEK3g71NnbXzWXoESwfUf6Chu4rHdQukArFrYwHrRn5/OJWY3mp+4zqAmm IxXZDHEhX7BaFQ1G9tiX0UF1ZxS3pw3ZeekK86LwqpiDaSlGecxqPdAAFasyEj1R+lOF 50NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891884; x=1787496684; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6mgJUWFqrEErrhAVCpUHLA6YxEppcaZB/77+pF0u2VE=; b=VhydAayw58tM4Tf9XsFiGl7wPHkbUnMwpwOySZ5WHTPEKZ+VxY/gkcpPfVmg0LRRqc xPkbKsnlfaX7Z/eGUwndifUBo3IVbiosKVyg3zoOa4fsm/q5d6t9RtQC+4fW8SvgwkXU LlKL2+Cva/pc2gVo3ptxlOQoJUPi8cSO5fDfQvhKLWkRTnDwGoMLhEsRuM8K5R4KdvOM 5ggpc0ipAR1iRVcVrN/PeW1fT5zukBkI8PpFMpCdoXxqHkfuFuJsE/gH/3vm93RYUsJV wYQBLr8AVbh1UjbVoR34sFUJWcL9+kr1/ykqaJ/cnDt5apO1xqyatiWMbaDuqLxb6Kgj Y0dg== X-Gm-Message-State: AOJu0YwqbKdISmXTKqzr5bcA1YSkzDzacb20RpCZOD34fYvaReFZSdHj h69ZFerMIswlZgKT/h2NZKbx/AKLWm6dCyzpBhyzz/N+XsfJjT48HJWDrij4C3qO2OPmQ5e5X03 7cvHVgEcVMVBTGoKw4Gpi9w+pkv4Et52jRQaEeKBb2EoRkYgpOkjTfX2KsDXACmHYDw== X-Gm-Gg: AR+sD11FlgakVyjhXESJ0xCV783m8zGa3Gsh7KPGNk/Aj2SYc6ih0K2r6A1klnzxlF5 qhDG7gVg5KOaKoUGor5IG/dpYe6blfWLbM5bIORBnfAN/Iw2uA1i/b5n1o2uLDleQkvjaj2dpRL SlfMzX6rSt8lIfIWosgPKTldJgfS53Dq7AxJsSokPFGvOiFoE3OkYeycwDZ/XC88HEp3vKg0d7g 0fXUttsO6DxKqc3xbuzyDdUV72UgSlrFWmupGW9EpVSL9COiTYOXcYGPLnCKckVZ7PhXNU8AA53 RGtOlk1LyWa0nEdY/MgQCd0zWr6mbbxerhjmUjQGbDdFDoi2i5T3JpDqRqCTJty4DQeYDwfcZUH Ly+KPqJf7LMxnfa2Hb6n4xexKBQ/Sy4TBcQs6wybL/w== X-Received: by 2002:a05:622a:1b92:b0:521:8ef0:b4e1 with SMTP id d75a77b69052e-52d854ad51amr204234811cf.29.1786891883923; Sun, 16 Aug 2026 07:51:23 -0700 (PDT) X-Received: by 2002:a05:622a:1b92:b0:521:8ef0:b4e1 with SMTP id d75a77b69052e-52d854ad51amr204234421cf.29.1786891883468; Sun, 16 Aug 2026 07:51:23 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 37/56] net/vhost-vdpa: Include missing 'qemu/iov.h' header Date: Sun, 16 Aug 2026 16:45:36 +0200 Message-ID: <20260816144556.69009-38-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=QsVuG1yd c=1 sm=1 tr=0 ts=6a81ce6c cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=20KFwNOVAAAA:8 a=yXvzFSThzUGNIxLvb4oA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-GUID: qDppAZ-Fcj57CJ8ckq27n7hJJYaGRuo4 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfX7bt2ICYVBIdM mLFrrEbc2phNuZi6GTIKLcC398wsW/RofgAzT122t+Lfvr2Ixad+MxEcLQVim1GklARRWUsXxK5 YIZG3XCaW0A30KSiBoTVaiD+Kqi6Mrt8A3Nz/96FcCsmMgOjEFFhXf00RpPQaLocX3oWS8Wgr7R bJ9zASE474Urmr5D0B+5CnNDlIo69s4hxgcA7Sh40ewXvYafaTKX7jA9AKBaPj+wKy3IVDK27bs HpWHmaaKDakv5aZLwuzVil4P7lvw8XRy2B9grrReiwOCj1F8Zw8p1EAeRfsfd7G3pm1/dAque1H +drqAdSx56VYv1ReByhUppHMMJ9AbLPQLRbBZtcnhKXxvj4lU21OKohpgFsdTktrw8t8Mm9W2I6 U8cd76spdUS7tXQ/BWCY3Aqcuxwd5IcidtTFp+hpttrfdJGTkwwYVlERK0QqVFe1XhYJv6Z5pTI Qa/phVN43dBl2E3P6Jw== X-Proofpoint-ORIG-GUID: qDppAZ-Fcj57CJ8ckq27n7hJJYaGRuo4 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfXzgm3U2MBFUWE 17xZfSkx+tFk3n20QlN9ajsR09olNMKP0UU3Jlf9kcWt4NfuyBu+V2UgjdL9++P8IuO2scubsGO TBSAE4mATu4Ssjq3M9O9njCCLK6YYNE= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 priorityscore=1501 adultscore=0 bulkscore=0 malwarescore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891906908158500 vhost-vdpa.c uses methods declared in the "qemu/iov." header. Include it otherwise we get when refactoring unrelated headers: ../net/vhost-vdpa.c: In function =E2=80=98vhost_vdpa_net_load_cmd=E2=80= =99: ../net/vhost-vdpa.c:714:24: error: implicit declaration of function =E2= =80=98iov_size=E2=80=99 714 | size_t data_size =3D iov_size(data_sg, data_num), cmd_size; | ^~~~~~~~ ../net/vhost-vdpa.c:714:24: error: nested extern declaration of =E2=80=98= iov_size=E2=80=99 ../net/vhost-vdpa.c:742:5: error: implicit declaration of function =E2=80= =98iov_from_buf=E2=80=99 742 | iov_from_buf(out_cursor, 1, 0, &ctrl, sizeof(ctrl)); | ^~~~~~~~~~~~ ../net/vhost-vdpa.c:742:5: error: nested extern declaration of =E2=80=98i= ov_from_buf=E2=80=99 ../net/vhost-vdpa.c:744:5: error: implicit declaration of function =E2=80= =98iov_to_buf=E2=80=99 744 | iov_to_buf(data_sg, data_num, 0, | ^~~~~~~~~~ ../net/vhost-vdpa.c:744:5: error: nested extern declaration of =E2=80=98i= ov_to_buf=E2=80=99 ../net/vhost-vdpa.c:748:5: error: implicit declaration of function =E2=80= =98iov_copy=E2=80=99 748 | iov_copy(&out, 1, out_cursor, 1, 0, cmd_size); | ^~~~~~~~ Fixes: bd907ae4b00 ("vdpa: manual forward CVQ buffers") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Michael S. Tsirkin Reviewed-by: Marc-Andr=C3=A9 Lureau Message-Id: <20260812211708.92824-3-philmd@oss.qualcomm.com> --- net/vhost-vdpa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index c526c2b2dc0..1052361a4ab 100644 --- a/net/vhost-vdpa.c +++ b/net/vhost-vdpa.c @@ -17,6 +17,7 @@ #include "hw/virtio/vhost-vdpa.h" #include "qemu/config-file.h" #include "qemu/error-report.h" +#include "qemu/iov.h" #include "qemu/log.h" #include "qemu/memalign.h" #include "qemu/option.h" --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891908; cv=none; d=zohomail.com; s=zohoarc; b=fi50HFr42NCQFOZ6SVfQWW8opBfahHZL9ky1mWnLZsKmMDTLmtAZFBcoN0zsct+kx3Oh0QXQ51sqkMFvH7LTpUU2knC9cbfThH88C0Ce/RyIPD2m0KGp8vlxh61wtHW3Vxm9d9zgi1lXAoffpDlNjNpbr4gj+/yNA9MaLmFIBO8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891908; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=gcl6rv59wL2a5Pj2S3JnwebJsocFhTOupkiou2n0Akg=; b=OaNOOL4aj7QvJTI6TUNLe/e0+PjY01IFqc1XkGJyIBC0mswXAaS6YN/SiOsKxMVeogxUj7RN/29io3w19BUPcBp42OWpjbV3RnnkOssDWpUDfWXMREeUFJeVGPK55Q+U1riZAHy67L5bCXLLrLYox56zS2vgPieCdETZuZ1OlFw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891908487782.0159872228826; Sun, 16 Aug 2026 07:51:48 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcD5-0006Kl-Iu; Sun, 16 Aug 2026 10:51:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcD2-00065R-8i for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:51:37 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcCy-0001rw-4N for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:51:35 -0400 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDkru12397994 for ; Sun, 16 Aug 2026 14:51:31 GMT Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghq3nuc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:51:31 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-52d33c89a29so32286121cf.1 for ; Sun, 16 Aug 2026 07:51:31 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4999610ed6dsm79667885e9.8.2026.08.16.07.51.29 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:51:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gcl6rv59wL2a5Pj2S3JnwebJsocFhTOupkiou2n0Akg=; b=Cvwtv2dLtEgs7dd5 Z5d4WCSVMrSEGHNw01PFwjb+s8YIxyQyqMBfU32nxV1oB5z5G1YBMDhcbP2h/NEW fS5xf5K1wMoah+Sxsk7lpO02vfD1Q0u2JLSbDtiY83i9iSTEiTy6fFKgs77FMJAD PCfIlEcywqn/qXh50szn5Mwygg/L5qC62PGSHp0OPjjOuIWpZG1jfJAmG3KxImEw BRH+1JaVON6imdI4rU0+1zH22iuyzidQhir83v/BaFrXT7QTVl8K5OhTSawLTlNe yi+y+48ZRj54QuZVBl5WiPZox/dIn/lSYn8H3v9AynY0ONt12z8GSYVKO+eGJkU9 iAYClw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891890; x=1787496690; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=gcl6rv59wL2a5Pj2S3JnwebJsocFhTOupkiou2n0Akg=; b=UNo57UsHYyUMneQ6QgFkt+5SushH+ArP3kqHT7NpUQaJ7oDMmJMqr7WU57Y2v++492 EM1kLkSbzJ/1QenyF8QgImiBHQpZE7LbIz1NDo2WSaIcC+xfnfRpentOSO4fa2EtbLWn OReapjL8yobNoA1wypF66wdHgDCAadjQwzJZIO+dYXBi+DDZBSB0SkRIiXfYejpm4v9t 7KJlaEmwdVwhGdSBSzlCdszgtCvg8Daexk/nNQPLSllbhcUn47PD9A6kIPulwqRFrruG GIgamABm5r9dWiKsSLAwbgkweqlDWyz7L+SrW8MhvyaJCz273JDAJdDKSQueVKNiD4Vr /8fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891890; x=1787496690; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gcl6rv59wL2a5Pj2S3JnwebJsocFhTOupkiou2n0Akg=; b=KdJ0fz+MxmPpEYR121F9nOcsP5eUurU7mWzk2vh/13AEx3h/HEI+TmmhW99wq3dRxD 8xItNqLP64doh7EF//RWyd+wQolYemTGFrCnSBqwMbXbORvPP5JqG/BvdAWAlZAI1vLW MFWXde9v0r0lphYajXb1wgDDJsI6+RlYYPOZtUi+bLYNMzlgQfLuw4xWVyPeSebQO7oj 2h+RUzutqLP2eZygHqPE23Mr5m2EKCnJvt1Z+8BkwIEZmrwqUkWbkaNYs1sYyfBvod8z 1sQKtRrGcIS4KESftVejMIVrteU3rZn15qqM034Mx8RHzpGl32KwjLHiVnph5avMHsUN cMSQ== X-Gm-Message-State: AOJu0YzhpXNSSAp7+VC8wY0qCrSY7SZrmhGgedkZV+FnUFZ8OZbZK+hN iutd0UGGZjYpgoUt0kD4GGZuaMDFn3L6U5pJsKD2c0bROqOR/gK89sGjx6ozbOFQ5urGs++t7RZ nIOCc+vmyo4N0ZnB1IulynUKZRlp/SoSEl3Pce+0BTS7iPgMwOJ5k5OnbRPSvwtgR4g== X-Gm-Gg: AR+sD13nfjwO+0bjX05OjHfziDqn+iJTt3T1z/JM+pVB3ihSWyka+gOOOYSSMOXsozK TBFrMaxN3BpOIelTu+Yt+43nHDzbrIAiuprow469FSWesC6AkMI0GUj6UkEEqK1ogL4UpIATTYt ZUlkO2gjnvLlLW8+i5faOQSfWjol9OPFIjikJRnQYiweg7OqrD9hOQw2AWbEWt5eh1xCbOC88MP TVPu9LIHvrZPQ5n6A4JjLqzruVldYcXdb9Gd82NvXAlYDD2Z3aR1M7r/pAig/HrhHSfX/7hk6Pe +CqDdASaZzohzyECT+o5a0qDpR0J7PYKwz5wvWfSEYld9p1/37EpzpYoRVA9PmIHdQsIzT12kdf sulFeeAdLnpEmdvrYjUrlmbBz2EDM6fjtr7HlochwVg== X-Received: by 2002:ac8:59cc:0:b0:517:8470:2d2d with SMTP id d75a77b69052e-52d85477a33mr201306441cf.29.1786891890512; Sun, 16 Aug 2026 07:51:30 -0700 (PDT) X-Received: by 2002:ac8:59cc:0:b0:517:8470:2d2d with SMTP id d75a77b69052e-52d85477a33mr201306071cf.29.1786891890105; Sun, 16 Aug 2026 07:51:30 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 38/56] tests/unit: Include 'qemu/main-loop.h' header in test-util-sockets.c Date: Sun, 16 Aug 2026 16:45:37 +0200 Message-ID: <20260816144556.69009-39-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfXxDxEXwjZifLS QugQi6vKWvQc0fEuZfOwN7FuJR9pG8f3UmKlJcZuNYxxSl9ao2sRJ/phJi2gy+2D3HR4vEMwEhl bCnaH2i1VG4Bplp9J6V0UQKqP4YYIvGtig++UlEMvRK5nhb2ewm9s5uon2v6m0BiBrdSLJwG8+A HUVKpQ8GixIi+8Yzln8zK6eXMiBNTFuK6HpifhqTnZTmMWCgSIYsJ71BkPrVoRFX4q5zET92ifH ds/NeEcsgPluEaVHHAztQKauut/uCBkU4pnF/nIpXfu0NEewfVGY0KI1k9Bz9i9OMjCHa4+RNHI 2WkQ5uL7kTZgsImaa8IhYd8TQfwxU4vLCuIFZXKdsN29HRDgX06jJI0tn59YfgW0NBnvQCrH+Mq Ry/B9djWK5yIEy8xF9UL7vIJ16QK4+hO6t3Komx4+DBytK2qKBmQOyu4Kv5BifAhQ7JneZ6O1ub 7MO2gidRpgmKG/epqog== X-Proofpoint-ORIG-GUID: lmBgpHPT7OwyiQ1iZaTgQ8mA9I-yl3al X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfXyJj1ADzutJ1A 0OM41kFspgxRVkRsU17Wht31yRzkZp0/WORqeStt8oFyvq30cR/Dq3HKoEClg8VzVBjM04bwKE/ 8dANNlxisiqJxEteFIxKagrIpu9xZuw= X-Proofpoint-GUID: lmBgpHPT7OwyiQ1iZaTgQ8mA9I-yl3al X-Authority-Analysis: v=2.4 cv=dvHrzVg4 c=1 sm=1 tr=0 ts=6a81ce73 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=20KFwNOVAAAA:8 a=hs6llZlkumWZFO0I0y4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891908877158500 test-util-sockets.c calls qemu_init_main_loop(), itself declared in the "qemu/main-loop.h" header. Include the latter to avoid when refactoring unrelated headers: ../tests/unit/test-util-sockets.c:553:5: error: call to undeclared functi= on 'qemu_init_main_loop' 553 | qemu_init_main_loop(&error_abort); | ^ Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau Message-Id: <20260812211708.92824-4-philmd@oss.qualcomm.com> --- tests/unit/test-util-sockets.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/unit/test-util-sockets.c b/tests/unit/test-util-sockets.c index ee66d727c38..ab3f39c3efb 100644 --- a/tests/unit/test-util-sockets.c +++ b/tests/unit/test-util-sockets.c @@ -19,6 +19,7 @@ */ =20 #include "qemu/osdep.h" +#include "qemu/main-loop.h" #include "qemu/sockets.h" #include "qapi/error.h" #include "socket-helpers.h" --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891909; cv=none; d=zohomail.com; s=zohoarc; b=bvlZLjWELxJ+jFK3dqbzP7awPFb/buFOZ0AFYmMA9tbbsbe8mDOexwrh8h9ITvg0A9KF9AEJvujJUcY+QUTMbgG+UGgw/QeytN5cdgb5/Am//HGsW7mMWiI9N0/JODmojrYL/zGUudgjQY/y4TrH/2itGaiXglbdBbzZivdbBHw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891909; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=BAZpjJELD8Y7PWd7W4pzVBIiRrNQ8Rvfd6NAipLgY14=; b=YIrw/DNkionuZiKRHBUcD+LCYdQM4UVorCRc6baqWSlLcbseXddylu/n1sH66KDj0P0RMMPfaYtxSPtVlXGiAenf5daSd3Dfiwj+GQjCIswRI+QhIBxmWI5Bu1CM4ISOPJX/4MEAdmgAi09zD3hxmGpktN1G3ggTnILVMGHXFtc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17868919099191000.5482720069328; Sun, 16 Aug 2026 07:51:49 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcDA-0006U8-Ar; Sun, 16 Aug 2026 10:51:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcD8-0006S2-2j for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:51:42 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcD6-0001tU-N2 for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:51:41 -0400 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDkuZH3631486 for ; Sun, 16 Aug 2026 14:51:39 GMT Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghekq8c-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:51:39 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-52d7b3adda4so25655491cf.3 for ; Sun, 16 Aug 2026 07:51:39 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49996113beesm50108045e9.11.2026.08.16.07.51.37 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:51:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BAZpjJELD8Y7PWd7W4pzVBIiRrNQ8Rvfd6NAipLgY14=; b=SqZuudpCQpQqqoBN FfMuS9CEb/4+CfOM9VZIFC5KWO8z2BD+0iyEEeIhbu2Mk85qVJGQSSrSv0hQUIjP lARN4dUjUEGwSmEMtE+8Re2R0oEMo+rA7YujfP5KZHrKf7HqSn1TbLXoo45pFQ2f shEGVBdHO8/jiE/Tk/pagdKOYqcQVJI8WSHpueSAsxEfcAPlNhNTQIvKwGRnCUWh /+uOm5P1M51G3BOv9XOPyTUmi45S2/DVnf5FpjsEojKw4TaTdGuaEs+9v2QCB2Rr wu4XQG/HfLalNFcjXbkwhlDouxKZj4bn6lOClt5OnEg09n/mDt36/ZvjZYtO0Imz QVA8kw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891899; x=1787496699; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BAZpjJELD8Y7PWd7W4pzVBIiRrNQ8Rvfd6NAipLgY14=; b=f/tFyzC/AyyNa+tCCrHEX5c7VlixU5wNx0c5Ui/j8+N3jErdb743CPYgkvL0IEg+xK s49SJ7Ge59kVeB/fJaW+IGf7+KzSFl4jWtxOMivqHhv4UBYy6ClF6mbcZOIUoGsTiKCb YgmKziVWTgvBkOGVHu2S725bm9w3i1ZDQ98/QOUA5JqY3sThDnUKWEh9JFh+1lHL3rRk APDBZMGdgZZ9/Jh8VFl319RVvh6WbBm0Zx4vidIWVqzv8duTPeLR0HYQn0QZOYi8GZeD U/xbAZGWsn9NAjd+6ipWnc+4qK36/3q7ulU2VjF1GIkGQjBHZ24NmIBIBxDP6UixEozD ZpLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891899; x=1787496699; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BAZpjJELD8Y7PWd7W4pzVBIiRrNQ8Rvfd6NAipLgY14=; b=mq+iN80q63bYsQEyerSeMJfn2DA8Nbqc7jRHOpBmdjjmDbf3ZEKORX5h2ryzusEhPS qS4ZAqYRhY0qFCFtB3GzfDMARJRb+LUzGRfZBwLCVz7G2+jurMhKgmQMwoYgJulmhjqd lB/kO4qHrctfDGc74NDuu/FypqlyWZx3S1aaef0aNd+L0tB4a/OoBF25TZRZ28DzmzSB 2eeYlaoHaDnZpR2JLbSNdmgc3/lVsdz3+cIFqBYhomhiUbaPEjCtr/rXs5P50w90qIRc Y3JNC2sNdGAn6npGrwqVm6qPAOb7SCw91qT/2Ox6JLJQqsiVAtceI8Z+IbEmEj8w4VqF kgGw== X-Gm-Message-State: AOJu0Yw+PdoZkAHVCEnzvoxb819HFy7Hw/kNQhnhVJCoHR9vfBGRxXZ1 XCwqafegbAGMuTS90H/DSv0FMiqeN3ww2AdGO+0YQ0utjeDuwmHK0gDTeubBuQpVgr7SyZHUCqN G+8rzOmrptqzwwgXz3Z/IEjThx2+38yprb3G/5ngN3U9MxxeSyPZ/8LHLxMofDQIEiQ== X-Gm-Gg: AR+sD13IPf1hrbQPYs2pk1E57hgg9GKZ1ZCJmb79Gyu95J/E1nIQrg9qNOuVqmez4jJ KFelZ5te4wLUTf+e6xU9gWiPUxm6xbmpKJeYmvWYXRUIMhxxYeyiSDfEpUj7tkV5FunzE1emH96 otIt1o+CwfDMfa24upc+jOiXvOc5SW0oT7e3oZkNQT5A1YJHq6rzuysf/JZzmqUJPterDImICec veYScOMkWPyVXlX674K4q7Sx0oFb2DA31CfhVXA5BhM9zy484c1behlSUor75sl7MqpQfH0knj5 x4EmcOPFtQdgOa0z7eTsNHdr5SHLxnJI5m+KU56Fp8/2tDsBoXcnXKl7/MkKwVFFJ3T1eo09zip rQnqtnBkhY9JIGWa1LPBfWSK7s2LuqTWDqxDWB2v5rQ== X-Received: by 2002:ac8:5f51:0:b0:51c:19af:6341 with SMTP id d75a77b69052e-52d854d29bemr195527431cf.36.1786891899087; Sun, 16 Aug 2026 07:51:39 -0700 (PDT) X-Received: by 2002:ac8:5f51:0:b0:51c:19af:6341 with SMTP id d75a77b69052e-52d854d29bemr195527151cf.36.1786891898724; Sun, 16 Aug 2026 07:51:38 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 39/56] qapi/qmp-dispatch: Include 'qemu/aio-wait.h' and 'monitor/monitor.h' Date: Sun, 16 Aug 2026 16:45:38 +0200 Message-ID: <20260816144556.69009-40-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=EKc2FVZC c=1 sm=1 tr=0 ts=6a81ce7b cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=20KFwNOVAAAA:8 a=tlxghdvPRZsVr19qFskA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfX9dmq9PytgrfK 07IUtzzO1MxHfwkj51NsREpY2I7qWEBqixnGBqoh7X88M2aL6+6V8YmwVsoTPTks4l+bf3ycLHz HUoLYIaw+3LTD7vgFNpUmJAWXnX2iaY= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfXwwgVC9YMK8zd fU4QuySP9gpHJt7xWde1H9mQ4haH/nWAvpKvlDYrWFuK4PDKMV1rJzbnLPRVQgWkgSUbZuTrpp9 vcirrvVbZN2IxZbbXOFcnJFPH8rJUfwLY0LAboLfL6Z8yDP/RNXMKnHZOmEaBAw1Gtn9oZ4AGMk lcL6s0MyRKAgvSTvG9X82qf9bnBVkFUvIFVFT6hveow2cgqBfwHoGAd6v2hrwz7v8kyaFy+oKJu VyuvclDPc2eDjPg/vQMO0PIg4B1t2IerhTjtYdOTFdoaN7swafAt9nG8hbeuZruC8BvrKxkzlz1 GxHe3FB5saR6etfe+XuYEsbC+7G8RMxlf1GqeDYgg7qAuWvw+hOFHH8Uqa21rocStRnQm3zXkVM D8H1fRSwugL4AcUEMaYp8aKt8Ai+Qra2lKSDjOTrAjDeA6a2rHXETHR951PAwZfo6a76PA9asj3 nGnBf3fYKk3buH6P4/A== X-Proofpoint-GUID: NhMJ6q6EfYRRovXMRcMafy9W5joUv6Mb X-Proofpoint-ORIG-GUID: NhMJ6q6EfYRRovXMRcMafy9W5joUv6Mb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891911005158500 qmp-dispatch.c calls aio_wait_kick() and monitor_cur(). Include the header declaring them in order to avoid the following build failure when refactoring unrelated headers: ../qapi/qmp-dispatch.c:126:12: error: call to undeclared function 'monito= r_cur' 126 | assert(monitor_cur() =3D=3D NULL); | ^ ../qapi/qmp-dispatch.c:141:5: error: call to undeclared function 'aio_wai= t_kick' 141 | aio_wait_kick(); | ^ Fixes: 41725fa7eda ("qmp: Call monitor_set_cur() only in qmp_dispatch()") Fixes: fc1a2ec7da5 ("monitor: Fix deadlock in monitor_cleanup") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau Message-Id: <20260812211708.92824-5-philmd@oss.qualcomm.com> --- qapi/qmp-dispatch.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c index e3897d51977..965cad64998 100644 --- a/qapi/qmp-dispatch.c +++ b/qapi/qmp-dispatch.c @@ -14,6 +14,7 @@ #include "qemu/osdep.h" =20 #include "qemu/aio.h" +#include "qemu/aio-wait.h" #include "qapi/compat-policy.h" #include "qapi/error.h" #include "qapi/qmp-registry.h" @@ -24,6 +25,7 @@ #include "qobject/qbool.h" #include "qemu/coroutine.h" #include "qemu/main-loop.h" +#include "monitor/monitor.h" =20 Visitor *qobject_input_visitor_new_qmp(QObject *obj) { --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891916; cv=none; d=zohomail.com; s=zohoarc; b=S9P49sUOGTIjXRJpgp/CcF0iy2+wrTGwDZu8ffoB8pYTVDBYS72+wj1EqFH2ntlRt/A9OKCGVH6gRT+K2ZdhJ6ai0Rj5sZ/X3SqcBmJ2PsNnM4kE9rKKjwakKfGdHA5D7oWIBHTZFbqKigd2VY6iCinmT4Lk9uTBC4xEwSHhOq0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891916; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=a9khp9AuqoA/g4bzhUPoCf7nGUm5N3Vn1ZR7Ue779bg=; b=Rooy4MM0ZjDHJQp8X848NfE/zK48OkWeq8sSMpBUe2OfZaFzgN4mgyRgsq+3qSwZTz8yH0EAPgw+NO/jW9D3ljrjECc/1Q8+lLPRYk6M705wZik/G7bxHaZNdv+nqV+HzRYkE6J99jPtPFKjuVsxvJ/tEdbB5NucPn8PrO6dUh4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17868919166971009.0284327279857; Sun, 16 Aug 2026 07:51:56 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcDI-0006i7-TI; Sun, 16 Aug 2026 10:51:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcDH-0006he-3s for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:51:51 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcDF-0001uQ-MQ for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:51:50 -0400 Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDlbUQ3534233 for ; Sun, 16 Aug 2026 14:51:48 GMT Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghf3mnj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:51:48 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c19493ac2so27615911cf.1 for ; Sun, 16 Aug 2026 07:51:48 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f20058fsm27131895f8f.4.2026.08.16.07.51.44 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:51:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= a9khp9AuqoA/g4bzhUPoCf7nGUm5N3Vn1ZR7Ue779bg=; b=cQk1EllVqUGW06kk lkIt/u+s6i+xkP2/DP0M9F6/qN6bxM3j8X2KekfqZT8CR/Ki7FcG/Whm4GXWLZYK V3VJgd5iQOMQcM1qrwmp1dylm+Wl/Gcsxi4X7fhtVvqvbzx+9A/GIhEMaaSulKke 0HN45yVBUF+7YrmUcZXjWtISvK2u6i8zyV3YidDahwMmdsA2GqrLYH2DbWutLHL9 ESdIZlTfxEyxdnzqHyosLYkbxRYtXreuJZD9R/P7SzmyI75T9uxotceXzQL/0Rpe uc+t/zqmXyROqZcxWnGaKR6oOVrdX8n4iNjmyJQP2REKiWAL+RKFrVhOMi1SscK3 dwjNeg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891906; x=1787496706; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=a9khp9AuqoA/g4bzhUPoCf7nGUm5N3Vn1ZR7Ue779bg=; b=CVmJFqi1PqUGWFi4OkfCuXjeoi9w3KpI34WktQTLPWYOlqbZYZ7/63hvk0UAWJjpVn mVX/r50UgHkthsb/N/sRHSH/C9N5ijad8gFQ0OPsCCOcSXv7VwaZgZwGSnhGojmH6kKe 7lMi5DsSh9mdSfqYMy8RZ6uTYn/vUxSlO/pdEVRrGhUVYhQw1KGttIh5ZFAVoxxIBc4c 9OBh33pPqtCN7Tb5A7RofLrhS6zyS0+1Cjrl3/DH+sW5Er/NRtJkPS0hhHqpt+vVQFgN eem6Q+/h7u3Oyvt39t3an6hpYte552eZUqqjef/OqyfLjZkEUG+Jgl9oHOMnWr+FrqH3 5c7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891906; x=1787496706; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=a9khp9AuqoA/g4bzhUPoCf7nGUm5N3Vn1ZR7Ue779bg=; b=s6oXWnYfDW2PKwH6SjqTYDMZ3WHbqYUOQnx/1j6o87TfycZVcZpAHhfiOdg1xns4Fz 65VFAL0nI5D6Zs4jLru+aP9NiQpyLcbs/qvnOq7R7Tslxg/zTR8L1Jue/ilvId0bX+mj 3sXqd5UvvaAHcPYpU3Tmf68YGtCv1frG0mAj4mKqV++3YjmJzxpVBv5IvRScasehmm3g fk508oMLx7gDCR2DYmMukxmTEaomjcFunxIoVqcIjkN1HjMO+Jr3bOljCQzjnYb1exlw nKthm6puUgc87FTcGgnu6krjKGFpPGZJHRN7MfCf7AdH3UDaYBGtlOQI5PZ7OXidzmh4 SR1Q== X-Gm-Message-State: AOJu0YxHZgCaJ1w/zy+QrcXZ4Wvdt1Y2A9/aAia+bmAymMFOZ6VFHehN +KY9OOeYWG07QVahwPP8JetsGPDBUORPTUEAu+4QSWHjtDEv9Ccoy+6GjAlt57zuS9dm5b6DoEe Y1EAyluG3mIjhlbI5BG4SbwPXhMtRt3uTlj2bgJ6KVPFIQ1f1ItHoa6zKvv52v0hbCg== X-Gm-Gg: AR+sD10y/gl9sS8VdLGXmpIkBRpA1w/wEPuqc6JX6C1NtRmJtRyGHxPD+Fsb2oygeMf nSxkXckCVf2KkDuPmXNxbPpJk1Q1KNqoGxFKJMNZ/sI0jrZ3nh9Rmq145Bz7eX9tjTYYyqIH9NO IXgbrD26fbzdRv+TdUx5wiVJTV/2V+SBUM2FUBRrRXtNDOb5PbNzbWiKr0VDNge5wLiDqQAdXBp MbQhGgcVw/yHDoBQcaf5Eo6ydO610L8CepUA5bDuscFe/G+ij/X0JBb1m+p8WEvUc0P8lIVH3jd zNE856o/8ta2bGd0zF0fLHfiHKsx3WBxwAfkJWZjce1ngmr8M7Fa4nume3ek9rM7pWDKKQ+DTo6 92jucOCip+wUTghldMc6knMf60+DUza4T7uZDMLo2Tw== X-Received: by 2002:a05:622a:4118:b0:51c:1a4c:3c9f with SMTP id d75a77b69052e-52d85378db3mr218700111cf.4.1786891905753; Sun, 16 Aug 2026 07:51:45 -0700 (PDT) X-Received: by 2002:a05:622a:4118:b0:51c:1a4c:3c9f with SMTP id d75a77b69052e-52d85378db3mr218699821cf.4.1786891905368; Sun, 16 Aug 2026 07:51:45 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 40/56] qapi/qmp-registry: Remove unnecessary 'monitor/monitor.h' header Date: Sun, 16 Aug 2026 16:45:39 +0200 Message-ID: <20260816144556.69009-41-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=QsVuG1yd c=1 sm=1 tr=0 ts=6a81ce84 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=20KFwNOVAAAA:8 a=hs6llZlkumWZFO0I0y4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: CnZFl0dj2RG5iXpkBPilferETILcszvx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfXxdqMSMQVVXnq FQAb4j9kgZQgXTMYNheu19lRmSHMODWAAVngapma9/UyTFSPH/9t5tkEv4mtgP4wCLYGemId5Dl fKw8t7rRSd26dqKH53FWaf7hiJ3WO/qcSlFl2CVp1ampqb2ZbqG101UAJyCj0Agtrb4Sdl4dM7T Sj1y5gujYzodyjdKb+xme/u+HGj4UF5MetoaD/9Df6Nw2WQ7GVY35xJ8W5fJcFUaX2Gbz1LfHBr RaHGao2YPJeD2rC+FZI5TyjbwaD8jd2QOOEddejjpZr1ceYvqlsqjTMTZmq7wNXm1g8d1Pp9NPs 4/UM2/G3AQdJokGcRAHbu2cJV5dBtNjyfPXuH+VJ+sEFb2IjyirwRuvDQvlF543whyAevNQUJ/c A0+Rmwbj1QaDsh5l0xiwycc7NsPYK1+yl7PHS7H5JGM9txHtBKZn2ciMR3XRJz4/Pg4HPWCTm5X IzWt5bDE4k4BcgkU2cA== X-Proofpoint-ORIG-GUID: CnZFl0dj2RG5iXpkBPilferETILcszvx X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfX9yZoZBrLyyGF tgdychVlt28Jqo3XSiqLj8pW6Ich9fWBK5HFgRoFsmvrNo3z5k+VheMb/bOktR+Sf2+x7CXqcK4 BgtDYiQVvrcVHlgSeeWyhYzrrNxN2XQ= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 priorityscore=1501 adultscore=0 bulkscore=0 malwarescore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891916912158500 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau Message-Id: <20260812211708.92824-6-philmd@oss.qualcomm.com> --- include/qapi/qmp-registry.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/qapi/qmp-registry.h b/include/qapi/qmp-registry.h index e0ee1ad3ac6..6146306a3a1 100644 --- a/include/qapi/qmp-registry.h +++ b/include/qapi/qmp-registry.h @@ -14,7 +14,6 @@ #ifndef QAPI_QMP_DISPATCH_H #define QAPI_QMP_DISPATCH_H =20 -#include "monitor/monitor.h" #include "qemu/queue.h" =20 typedef void (QmpCommandFunc)(QDict *, QObject **, Error **); --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891923; cv=none; d=zohomail.com; s=zohoarc; b=Kd/2TVldLzmGqh/x+uZHxl8wsRWbZZZeBgb6ThnOclsR4vHkgmVkyjMxtJ+kHmPTCeib0L1RLxObrAg0SHviZRwLFVz+KRFs044B83HMvD/iNBa9dZ7YnxWWL6UpBuNNlQA4Ky53gfh0Mdi2z0aipCRb42ZZtLdXOGTIMw0IwQc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891923; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=GVQp0WhfFXU+ygcEhNe5GMz+qhcmsuVKmHyMJwd4KbQ=; b=LC+EFBhpJEgjTtjkAGUx824u26VWVD/9hXrZxgCRkkzK+ix9f6flkeaO02VYUf/CH5xQuWP1bfaF6u7xm9dk1UEU/JMcn6/gpBDAqfhixgNG2OY3GnyHwWukcERPct50TREH/nKrD2AbcqZuKYFV/u8FIlpAbPmPNmSQxH/qo0A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891923099417.38049506295; Sun, 16 Aug 2026 07:52:03 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcDQ-0007T9-Mf; Sun, 16 Aug 2026 10:52:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcDO-0007EX-GF for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:51:58 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcDM-0001ux-NH for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:51:58 -0400 Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDlFg03161996 for ; Sun, 16 Aug 2026 14:51:55 GMT Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2hd7uga6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:51:55 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51ebdfceddcso29900541cf.3 for ; Sun, 16 Aug 2026 07:51:54 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49996176b95sm41106215e9.10.2026.08.16.07.51.52 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:51:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GVQp0WhfFXU+ygcEhNe5GMz+qhcmsuVKmHyMJwd4KbQ=; b=mikLTeMaYJP7/fZY +qKRmHMY+iVyq0nLjRsnzLWoXOS2IeFCbNHMVL/IDHOauI4tvhM/WShLsabTmEDg l/YwyDiXVSb1+7BqT/+V9wbAIQBb6Oz/wnct4RuC/v5CICefyBPrPpQ9YgSEAfff 9WnpSUU6ipWQ1IGq4C07Oe1ik4KOg9kX2gLpwrGqx9A7o7oXqTM+CiHUEgqMtWDb juhrqfbyZIShNuRE9tvomCHnyeXKAAmegMi8j05ZYy5v+oItgioecVcP3KUx8ajd 7Xvi68kzgBDXPgzEsspqHSXaMn0nRbi46JbopPzgV0qL/5EMH3wry7AG98ncWn9A RBCZhw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891914; x=1787496714; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=GVQp0WhfFXU+ygcEhNe5GMz+qhcmsuVKmHyMJwd4KbQ=; b=d8o1eNOLIAhJ6OdXJWAsyvOTTrC/B/FXl60kSiG9gDr8gPENk3U6zMGczJs+ZA+j1l kxFJw9DF5b1y5WUzsjBCz7h7IXiq2rZz0FLgrnFoKhBl6TjSjmId5yZUqxmiEqbhOYBg XE4l9IKxxrw9U0IJj7pgXM6Q//llCSX7Q4UrLNKyLbT5Yv/RhvI76DCiwb0YJn5HxWMr HC59NIdfC1yIH4+SOSHEPMqQMJHT/FjVo7mrE7PaIavAYt9LAiaxAoSL8CfCz8lW4Vlt 5mlUZrtRZ8QM6NpLZV60qvOdP0lIR1PUAK/SIdBDJ7p4axjRq8gChFa0ZJRLScwLtOYT jnWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891914; x=1787496714; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=GVQp0WhfFXU+ygcEhNe5GMz+qhcmsuVKmHyMJwd4KbQ=; b=CLqLGIPY25UXFDvY5xMTbJPGPxm4nQBP2UC4n2Bkfaen8CI+pNo/LtOjfUqS9blwGz yMoTzL8yE1l7PfR1WlFyBzQVO71sBiOedrNyzFghWrwa56Lj8offDxfPakYgUs2nhg3m CUxd4ikuBi7ViUJArGa5aVf2pouFqpf0f31+0Izz+zSXcuyQCMwdecKFeHnrspA/qVRZ LT+KR3Yyvn+bsUxpOfTPR+XCUufxWfOBbFQySRVCJFxX0y6GI33nCfFsHdjg4Gt2C1eE EoLg8UoxelyO9SkmUyo/KP4AVxXNGzqNtKqhxRhAYwyc4JLr+HcfW9XMnhXkYsQTc5iZ ABtQ== X-Gm-Message-State: AOJu0YweHob0osp/gJ2d0NXzh2HfCRwCI8g+57MH5yaUqbJjjfcMflw1 t8ILGMwzxpfSQjQfmnVCtLOEtfS00BgdiTYCSXVj/RFUB7MEJV6DTqu1lW/GVpD5VIHxDuT7oBy DsUK2b5kFXCIq7lc87cyg4WoW+LdTh+np+eiDWplf/4GJkgGLx421r1wnHYOEhTjmfg== X-Gm-Gg: AR+sD10pHvGeO0Pfli3rL1TYAJ1exaF5yON5KQZunn7oTNXeMGpNyTg/RkTFqGnHuRi diSWIFy3RoFgnzZYLgKPsIifjVnH9P6v5ctSt7dhNV/JyC/gyNKzZe1BRKYDOznzF7gOmLX6I7i xvTsDpO5t6ns7mf/Y46/nFrfUvyqw3/qDFNOZdlw3ihFDa9pf3NTT2kxwOo5p9FnCgRpjv1Yn/e GXkKoO60HOX6K7DQl181V2235mggqElXBEbSKmQfJqMKGVjCfa/+mLWXIQTUoiICIVZ3Fxj9U6D BOOIwY25KH/gjN2S7eiCABAEMXlnZYQyr27XUYTHMD7ncAsNVkd5QX3VKy8Vq8b8fXP1TbR2UX1 TzHXGNjKGgAPvLgVKAnl7WhJyKuJLlJE5MDMkuAsx1A== X-Received: by 2002:a05:622a:4d43:b0:528:17d9:2d99 with SMTP id d75a77b69052e-52d85529386mr249299301cf.43.1786891914159; Sun, 16 Aug 2026 07:51:54 -0700 (PDT) X-Received: by 2002:a05:622a:4d43:b0:528:17d9:2d99 with SMTP id d75a77b69052e-52d85529386mr249298951cf.43.1786891913753; Sun, 16 Aug 2026 07:51:53 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 41/56] migration/hmp-cmds: Include 'block/block-global-state.h' header Date: Sun, 16 Aug 2026 16:45:40 +0200 Message-ID: <20260816144556.69009-42-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfXwFB/eK3qOP5Q U3DRtCkd+nvyc0okWw/Cj79SfxG2WvQe7qkGSvsYZGWAvwIiNtMH89d0CvCAFpJP4gjHMKLkSf8 oRTxqwxsgXuoFN0JVl42/HnY0ODERYtNMeK/RozF2w/QDFHb8ilL3LJmgRHqXtAgyUNLpJES+FZ 1bC0JjfQdEG1Xxq8nQaiFGAbj8J4y+zj5qawKMmhvX6IbLpy0ARHbzTkUOPE15MKWd8yjrJowHP 5K3zR7RYr8AUSwk9hlP40x3yeD2kXdo1VE1GoJ5EgYcv8uBbK7HODBjT6jRONijnU/1qvFLD+i4 km5UjyXQtW+vRJcfZ3xUftyaNm+KUgf17tmcQGxS8WXKhW1zWjmtwNlPS6ldXNqJWgPOLYuterQ CRIwMr0OFyVOklZwUVbw655ttdawN+5VwRtv6S19RaelKKWtmK9gvmyay/44VBXrC06VHnLKPz/ tnsyCEr1RxkrdjlNNDA== X-Proofpoint-GUID: 8juRw-wcg413ElrihQJDPBAXAEuXVNyG X-Authority-Analysis: v=2.4 cv=Ja2Ma0KV c=1 sm=1 tr=0 ts=6a81ce8b cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=20KFwNOVAAAA:8 a=3WJfbomfAAAA:8 a=tlxghdvPRZsVr19qFskA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=1cNuO-ABBywtgFSQhe9S:22 X-Proofpoint-ORIG-GUID: 8juRw-wcg413ElrihQJDPBAXAEuXVNyG X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfXx6rlSN3Hag9M yvjbNTRIapNHiB119cwKNUjKebGtEx48KP7Kb7CLwWvPxMrvwlAg4AOWxCUPKiAbKvjE6b+YNkz rHwA//UaLbBLMWffjBIbpyeomRv7iFQ= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 spamscore=0 suspectscore=0 adultscore=0 bulkscore=0 impostorscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891924999158500 migration-hmp-cmds.c uses types / methods declared in "block/block-global-state.h". Include the latter otherwise we get when refactoring unrelated headers: ../migration/migration-hmp-cmds.c:911:5: error: use of undeclared identif= ier 'BdrvNextIterator' 911 | BdrvNextIterator it; | ^ ../migration/migration-hmp-cmds.c:918:15: error: call to undeclared funct= ion 'bdrv_first' 918 | for (bs =3D bdrv_first(&it); bs; bs =3D bdrv_next(&it)) { | ^ Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Dr. David Alan Gilbert Message-Id: <20260812211708.92824-7-philmd@oss.qualcomm.com> --- migration/migration-hmp-cmds.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c index b5eb27467cd..ad68fa23aa4 100644 --- a/migration/migration-hmp-cmds.c +++ b/migration/migration-hmp-cmds.c @@ -15,6 +15,7 @@ =20 #include "qemu/osdep.h" #include "block/qapi.h" +#include "block/block-global-state.h" #include "migration/snapshot.h" #include "monitor/hmp.h" #include "monitor/hmp-completion.h" --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891934; cv=none; d=zohomail.com; s=zohoarc; b=f2Ahuzy//YmjR6dlQCanrKKfNDwlOeKI2BDDd9zdMTye36rO6SU93Uussvwb+OIJLqj5/dQRY4a0KmeqfkIeGceO+EJ723RIAOst+P3qhSGn98KFBBqpctXZ7sgKJUyGkJudVJieQdVXVNG64fNOjtH0jAi2OKVA9Q/D85GPPoI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891934; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=+6kkrKc0NGsJRZ7Uf8rORc1ZAV4QXY8MKZweRgHzMNc=; b=BBDEUb5zbNRIckDHRMANNfj6B6VKkC5V+fyCg4E6R7suszjt//yBmHcqVlOeusXlgNWKOUXuu5HDKbUV3eUUCLcXICYMX4BvYwxLKXGWm9iDJKIRCp8RG2GIV5Q16A2SR97Hh6CQMdn60jOZ0DrHzSO+H6569CmH/0hPRn7MNiE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891934405779.1653790224058; Sun, 16 Aug 2026 07:52:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcDV-0007p9-FU; Sun, 16 Aug 2026 10:52:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcDU-0007mY-FU for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:52:04 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcDS-0001vY-Vl for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:52:04 -0400 Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDlp8j3534411 for ; Sun, 16 Aug 2026 14:52:02 GMT Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghf3mp3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:52:01 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-52cd0374265so55867171cf.1 for ; Sun, 16 Aug 2026 07:52:01 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4999611bf65sm47890055e9.13.2026.08.16.07.51.59 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:51:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +6kkrKc0NGsJRZ7Uf8rORc1ZAV4QXY8MKZweRgHzMNc=; b=noie6PBEskCvDLKO 7V+UCd70P3Ph18stqILyx7NTIzHfwpkkS3lVg4sZBuaq88RE751IDipVloZiu+Zi iMd8qHKadfSYbzd+mfeWTWpve6hWzWf+dWlkyinG8MsYulMqABLuGrNx4NDg81DU EuVF6WoVix8SNrZxmRLAVXSTWBvbfw8UqiOn3qz86eNkqGvctO2BsPP7zv4quSbb FbdZMXzr5GuE4mSfQIO3yW9dtqoZzfqYB9TxdHS90GZt933OJ1lrhWLA7hHqDAGM tEQzmxGc2rSIJrDGehBx2TvsopxhxPoi6W/CmQb0FOM8AEMpKRbPPLAFB8NmiZW5 fuOMeQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891921; x=1787496721; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+6kkrKc0NGsJRZ7Uf8rORc1ZAV4QXY8MKZweRgHzMNc=; b=VuVcEEL6bpw90K+kLhHwad2dhUkhMRFGB8RkYnh/ReaHRfj94xaw4QJwW1+7PVY2LM XEh/q1xCHUuYecYz+3yMoZJScdBFWByKirJ2DfL04bOc9n7cU5zYrMYLmlxG9wb/SYC+ rsxwhT9z4gkNHqYlZTjmssuRXgO64pgBgwfc3+UHoyJ4fhqaq7NB972bDOdmtq4KA2xk QUNYmrlRRRXPLvY7DWwlQdn4c0b0dy+JQLt1y55CNrIWP1+71BdyKeT4Hi3DOjZ1Hj0o OzitzgBFbakrQCY7U+q6IZ0euCUApcMioXVm6KEK+S7Mh9Wr1iDLf9MZ6ekCkLvENQ+O DiYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891921; x=1787496721; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=+6kkrKc0NGsJRZ7Uf8rORc1ZAV4QXY8MKZweRgHzMNc=; b=s4WpzGkVknx3YMeCyIT38STKF1l+RXXAde/FqiieOOaugDh7CxrMI3TIkwdtNPIuYw 3rStoZ9kht1udQC9TN0iE03imPk3t9iDswh3vTMWWki6ZhOwm7pEGHsCA1G/f8XxTik1 zOsv4EvqjVT++QRhJO2gSLHlYR5cBuVFCxkVvLmrli14sf5ml7fGdBwwyNRgf72reYOx w1VjAMg2QSJ3KKNWfTSf+PYl3nGQuVOhX/c1zL08a+vcKL7fd9FZRyTBYsJ5mt3KeRcX PAomY31Him84kUzz6HWBEErDUfxSZr94ECh45fzAPTGTV2udr7XkzpiPhvxt1ImZcdx8 hLMw== X-Gm-Message-State: AOJu0Yxk+BAwBvbdrt3C9QSqc3bcpg6u0s6KTbNXo0g+c+2lncEElTXw QSMEeM1+w2PZWeyudnvfXTfFY2fYWbhrLcXRjGzPcOhtzsT/vD0k/B4NEdN8hDV8ab83UEVSsiD Ixw9grdbKqNU4QFBe0YvvK5T6dKmX494/WGrKgQB9jNQUaCWeB3JU9TcQGlS0TRwSvQ== X-Gm-Gg: AR+sD11/UF7QjtGqLuOcuWd3H1tdiCfzp1eGjbx38afRWnmEGqh6q9Y5yT+hYfZGK42 sI4Vv3FFS7sDofKUGqoZNZfRfWWYuk7e9DDgQIwXPYZjV/7Ce9xKyut3yD5vKliHLhAeHFP/FWN mK9y8nis2saF5p6j9ZDuWTwbywHwN7PJhSDraKcjps7CzNX8VGFwZneUnQP0Whl1LeU91FJYvTV Ba0hjP4Qt9xokX7vQhCQ8n+HAMGLjinVnbDRoQN/2ewmraLG4KodZ0fWOSUkaxEEAzCChy/1REs aRyDHTVa+5mDFFVvCN5Flx7nAgFGwQsoVsvXScSv4Vekd3m8PSn9HArwScAjLzefcrGm+IXZcqh c1s0Wwspw/tPtmczWWxLJa7oqOI+J1jV8ESwEXiWI9A== X-Received: by 2002:a05:622a:ab02:10b0:52d:8841:ef7c with SMTP id d75a77b69052e-52d8841fb96mr122547031cf.31.1786891921505; Sun, 16 Aug 2026 07:52:01 -0700 (PDT) X-Received: by 2002:a05:622a:ab02:10b0:52d:8841:ef7c with SMTP id d75a77b69052e-52d8841fb96mr122546881cf.31.1786891921093; Sun, 16 Aug 2026 07:52:01 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 42/56] monitor: Include missing 'qemu/aio-wait.h' header Date: Sun, 16 Aug 2026 16:45:41 +0200 Message-ID: <20260816144556.69009-43-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=QsVuG1yd c=1 sm=1 tr=0 ts=6a81ce92 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=20KFwNOVAAAA:8 a=tlxghdvPRZsVr19qFskA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: rWOrH8WZSQjW5Uvwx6sGl1WZFjthu0Wn X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfXwostYclwFOYE /BLUJipRoDqyIdsSBrxwnOdcKw8ejMW821wselGNuxdr6+Oz5Uql34S91Z2y8rv/5UFd250v8Br SBUx1jUZ3jZLX4c7Aog/DE0tyfcJJOzZ8TbkBc5ACkWM1/eHUJDk0fnsOr3U1dxLyQr7zvN3ofx diGGjYiOkmmICu/UKBop2CJ6R0bABQ8AgvpWBLK16bZcfiETV7Sc4enXoy6vCVwprN0jWL3VWga KGZEcLepTMzvODdQ7o8NVYiFoOpQM9ZxEGKpMMkKn8WzY6yGgIUcO9eyAEObV8chUvB5ONStxdN Pwge2lPxybr6Pj7NjyxhRk/HzvJIAtQdpwF3J3bJJObL1Ml7izjuJm4FkkAiU+fXXTxm3hz0ZHF VwvKXAN3HxlIDl8dVC/SVyoGgUg66ydxymsVvHO63NkNVS7LO7bo7rM0ArAYE9b7+oQ/p2nCBRH S/z8SIP5Kwof8E+OEyw== X-Proofpoint-ORIG-GUID: rWOrH8WZSQjW5Uvwx6sGl1WZFjthu0Wn X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfX6AV/kIkfcUgn XgcbYHDRKLEKa5dzGHtzNPf40hW1zY0lkmM7WcpIzuMY/0rmGzAAmr84uyodZzx6XzqMvAdQtl2 YQnaS5I/MTNONhPU4a/Ai9BvHThNoww= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 priorityscore=1501 adultscore=0 bulkscore=0 malwarescore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891934993158500 Both monitor.c and qmp.c use types / methods declared in "qemu/aio-wait.h". Include the latter to avoid the following errors when refactoring unrelated headers: ../monitor/monitor.c:648:5: error: call to undeclared function 'AIO_WAIT_= WHILE_UNLOCKED' 648 | AIO_WAIT_WHILE_UNLOCKED(NULL, | ^ ../monitor/qmp.c:792:9: error: call to undeclared function 'aio_wait_bh_o= neshot' 792 | aio_wait_bh_oneshot(iothread_get_aio_context(mon_iothread= ), | ^ Fixes: 9ce44e2ce26 ("qmp: Move dispatcher to a coroutine") Fixes: a5df506e129 ("monitor: implement support for deleting QMP objects") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau Message-Id: <20260812211708.92824-8-philmd@oss.qualcomm.com> --- monitor/monitor.c | 1 + monitor/qmp.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/monitor/monitor.c b/monitor/monitor.c index ed195fd97bb..c75ae815343 100644 --- a/monitor/monitor.c +++ b/monitor/monitor.c @@ -30,6 +30,7 @@ #include "qapi/qapi-visit-control.h" #include "qobject/qdict.h" #include "qom/object_interfaces.h" +#include "qemu/aio-wait.h" #include "qemu/error-report.h" #include "qemu/option.h" #include "system/qtest.h" diff --git a/monitor/qmp.c b/monitor/qmp.c index 338d37cb7e5..6ae1098d39f 100644 --- a/monitor/qmp.c +++ b/monitor/qmp.c @@ -23,7 +23,7 @@ */ =20 #include "qemu/osdep.h" - +#include "qemu/aio-wait.h" #include "chardev/char-io.h" #include "monitor-internal.h" #include "qapi/error.h" --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891942; cv=none; d=zohomail.com; s=zohoarc; b=WsSCZ/sxebUGNUCUumQqt4z3OhOX7/iW/ZFACfxrcvUp31L+mvj1bvRFwdgtykUQ3TsbEi7ihC/evNRo/Rc/VRSp5K9zjdK67cGe1Xw7wUAr+SnPkhJso+gtMkgq3p+5Sxa2Yu4dFuQWzqZCr5NhJRl+Es2+lSqbV9PvNdzer14= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891942; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=drmDyXgEuIO16YDWsy7JkXXCrfr5ReM8l/jxKggouZ8=; b=NRYTNN3GuuTxNKeYgOMTsSSeOZn93s7jTm9sgJMFP5W37WlguFDkPUfdjM4IsTUXpdV9VJhnKqlK8KgXNWXnuZTeK521HOIPtNwdjuZR1KfVK++2689n5ZhvBjsLmyt9epy2Jw/fE9rF4mIzuXikQrlOWwPRKAPQ4A/BZwjwRfw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891942357893.2208122338651; Sun, 16 Aug 2026 07:52:22 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcDe-00083J-08; Sun, 16 Aug 2026 10:52:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcDc-00080w-KS for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:52:12 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcDb-0001xL-0v for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:52:12 -0400 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDlOgN482183 for ; Sun, 16 Aug 2026 14:52:09 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghfbk5v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:52:09 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-9368f2b7b2bso261392185a.0 for ; Sun, 16 Aug 2026 07:52:09 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499961098cdsm66775825e9.6.2026.08.16.07.52.07 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:52:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= drmDyXgEuIO16YDWsy7JkXXCrfr5ReM8l/jxKggouZ8=; b=Zj2W/msQ6JmEodHR 7k2RlcU+6Rlb3b2hwqKHbiGfiVyE6oCY+4iu3Axgw2uoEEbCpjyGI8aPEs8eraxP 9sU/DULAaRTxyhFxsi9hfLILS2QqNvVcsdzl2N2I8EQ2CbvPASsKT5L/SWGTSSY4 CPPuUil2T9tNJAjN/17cBYwS/kdkvBkWJ2ZzKnOpOTtYFLXn26IC56rRTc9TypKC MRxDp7tzXL9n1l4CbkCLNeV5qrNfAyoSE1qDhxGXkeEb6M6L9Iaw2znAPgyYhAjM juEAuCW44ErLtGOu7WWzc/Vu2wZ2TrbNOTQyv6ryK5ynUKEUta+AclQc09svPMIy 3vqOrA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891928; x=1787496728; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=drmDyXgEuIO16YDWsy7JkXXCrfr5ReM8l/jxKggouZ8=; b=YWUt/iwTgw4xm0umyK0ouO8+ezbM1K+0wMRLCiOZESa/MVXB/zppZA4NP1qkdtyw9+ l1Nwz6NlDJu4u5Wjef5Z7EYuMpFLbkQCQdDN/ku3kLN0DI3cpFNaMcpXrXVevrbOmzAY Iq1KNZTemS58YD4pPIrfSClNjDbuP34A5A7Lgy49LdRSGBnIKahnGb5DK7Ru0p7VjlSg u9ggWJFXoTJW42Uz+NWcBn4NLXvkdy0Af45cXBku2AVN/HeffXWx1dfRNYtKjLlWFCsO xFnFHjxfh5sW5NK0jjWKb6s3irg0vODUk+oW/uwpB2eN3p64PfCYUfa44IH3HoRNxbib Id3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891928; x=1787496728; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=drmDyXgEuIO16YDWsy7JkXXCrfr5ReM8l/jxKggouZ8=; b=BpUhqPk29zh6sfYPRSbpb99KavlKZC0WPo/ap7oIFRSlBlBbCiW6+ETGuG7Dr8uUng hiDrG2UEyksJqTUAmgMIrEpOrj7i2o9+YMMorGQrcWK0W4vEDgKFnhM/BZnHQvX5LHaR M3cImAOq+xo0jWUxe3qjDCJK7muA3vTHg+hXA7XTzUyK/52kIwfC50cUlTgRGYkwZllT zAt6Xyux3nlM7UtD4UF7u6+uS75TvYkWoHd7W8nXTcwBUwaZma1fbfB5N3dmi6+cfUOw KBieh3dku0hlHFdTSjKKH5wZ2vUCO3mIW0EoWFqmHW9fCknWCgXtfrviortaryV3xIfp WzFA== X-Gm-Message-State: AOJu0Yyjox23K6SC7szspbiwzHGtEmYL7Hgz/0DfOFq8WPOBlr+BSgxe TCTgUp1bMU+3OtXXK2pabfGeSQGr+9cw9/F3q/i2dNLGF4kM1eyhB67AfRqzXoA4l6HPNjO+aFo a5xZhogBUXehx4UyrfxYSWpEqrdoajo4Ecn+NsDg7Xa2vLQxE1uKa5XtYmK2rGtgjzA== X-Gm-Gg: AR+sD13mPgRR/6PJFXHWgPibblkqYd3fJzGH7wounmG30SuMUSBEmL94RUxBsJWKaEo 5fFrCrEbeECNXzhOyjDBCiHolvde7Ujmc2PXcnpyjOLe7JVyIqzj4QJWWFqSWQHfP0XvTdFGGAI kp2wTiZ7rLzm+zTj82Of3C/PvgfSooiEmpXjcq49n8kzNU+fZb/NsfOJJZL42Skhu1OiaHm7hZN 5oqDu7iQa7tTrajWFygANdSRHAfIZON0XkIlRPs4r+LoxWdKbqhrKylYHyBUN3aFLS1D+rEZOYD xI5blDkAyNk6v1BI+mBfSpnFA9znEBWXFAPCoIUYuY3Sp3j/659xa3DTfI3szG+xiVne3V5bPoG Usip3s9J/f0yrTtHWDGQN4T+zfTprTe/9RBYG1+M/Vw== X-Received: by 2002:a05:620a:4892:b0:936:e938:b07a with SMTP id af79cd13be357-936e938ce06mr841601285a.8.1786891928552; Sun, 16 Aug 2026 07:52:08 -0700 (PDT) X-Received: by 2002:a05:620a:4892:b0:936:e938:b07a with SMTP id af79cd13be357-936e938ce06mr841597985a.8.1786891928097; Sun, 16 Aug 2026 07:52:08 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 43/56] monitor: Include missing 'qemu/lockable.h' header Date: Sun, 16 Aug 2026 16:45:42 +0200 Message-ID: <20260816144556.69009-44-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=OZ6oyBTY c=1 sm=1 tr=0 ts=6a81ce99 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=20KFwNOVAAAA:8 a=_5bDPQybseJbp6lUwYQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: hQahD8l6aR5yT0dTQVhK_UrWCDE2ogW0 X-Proofpoint-ORIG-GUID: hQahD8l6aR5yT0dTQVhK_UrWCDE2ogW0 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfXy79GS6vvRgPL Qi1By4MOw1smYVvAWF63vlAHhi33JcmNaYKwtO9VwYymU3D5SxG4bHIKq0lV7vfO+G12siBWP4Y q8B3Gtzy+byROgbwcvD/0cs2vX2+5iA= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfX2/Q5dY4fVodO RI2QGs8P4Yke0xlcdIxvMlfEoWtEYEieAZpgDlP7Eog2nVrvSGP/+2dpv2ykTANxgH22wqMtiVp l0JIJjxCeZnaRI/78LjSw/lVtNK3MtS/XyQOTr0qZO5bW6uSDU3/dQFYZu5Jhf97YyUaUoQKEV0 oQhcBP3qZCwDGaW+enTsq55XuHODuW9FNyRPNCRiWpKlk7/yaKZqGqLoLCcRwFnxZC84zK8NWJ8 +N2TfaXvi6OAZfPobrrtiuX3ez4mKhafaO7Dj/Vn1eSjtWjCCf6HjJFileZGQzThURVPAXS9Wlv oX1jt5fp/LfZWfx7IZfUF3DXEDRpvoSG67DfhB0ZNxuApB5wq8cJK39c76OdaT38LdDQppJW+3k C3j3JD+ZAfTMldfC3/VUYLO/wHkSQKb/rg+OCLh8lVvdLaTbLW59WNxANGR79XcW8yaB40BRS5H o98rBUnrF9AuGylQvGQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 malwarescore=0 suspectscore=0 spamscore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891943009158500 Files in monitor/ use the QEMU_LOCK_GUARD() macros, which are declared in "qemu/lockable.h". Include the latter to avoid when refactoring unrelated headers: ../monitor/fds.c:146:5: error: call to undeclared function 'QEMU_LOCK_GUA= RD' 146 | QEMU_LOCK_GUARD(&mon->mon_lock); | ^ ../monitor/monitor.c:176:5: error: call to undeclared function 'QEMU_LOCK= _GUARD' 176 | QEMU_LOCK_GUARD(&mon->mon_lock); | ^ ../monitor/qmp.c:164:5: error: call to undeclared function 'WITH_QEMU_LOC= K_GUARD' 164 | WITH_QEMU_LOCK_GUARD(&mon->mon_lock) { | ^ Fixes: 0210c3b39be ("monitor: Use LOCK_GUARD macros") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau Message-Id: <20260812211708.92824-9-philmd@oss.qualcomm.com> --- monitor/fds.c | 1 + monitor/monitor.c | 1 + monitor/qmp.c | 1 + 3 files changed, 3 insertions(+) diff --git a/monitor/fds.c b/monitor/fds.c index cc35d2ec334..abe5f13487d 100644 --- a/monitor/fds.c +++ b/monitor/fds.c @@ -29,6 +29,7 @@ #include "qapi/qmp/qerror.h" #include "qemu/ctype.h" #include "qemu/cutils.h" +#include "qemu/lockable.h" #include "system/runstate.h" =20 /* file descriptors passed via SCM_RIGHTS */ diff --git a/monitor/monitor.c b/monitor/monitor.c index c75ae815343..6af09f2f6ea 100644 --- a/monitor/monitor.c +++ b/monitor/monitor.c @@ -32,6 +32,7 @@ #include "qom/object_interfaces.h" #include "qemu/aio-wait.h" #include "qemu/error-report.h" +#include "qemu/lockable.h" #include "qemu/option.h" #include "system/qtest.h" #include "trace.h" diff --git a/monitor/qmp.c b/monitor/qmp.c index 6ae1098d39f..aec03157750 100644 --- a/monitor/qmp.c +++ b/monitor/qmp.c @@ -24,6 +24,7 @@ =20 #include "qemu/osdep.h" #include "qemu/aio-wait.h" +#include "qemu/lockable.h" #include "chardev/char-io.h" #include "monitor-internal.h" #include "qapi/error.h" --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891965; cv=none; d=zohomail.com; s=zohoarc; b=hcnKKWDJBynjV7UoZWnvkYKsn5ckmNWtE2Qo/DotZgOhW6oshiOY75dRQLrgv4IVAbkrkpt9P5Sef39y4mXcNDRe8BCe5NrNC3naxdoBKLumb0VVzga+XfTyopZXLFkA4/z3ZhrkIBPEdV+E2fAOi0nLh0iBCAPR9HbTwXMWIZQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891965; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=thqyj3sMPrnVALSr8jLtNV2ILSSUcEatI3pY945uaJA=; b=EwNFBpdQYDbs1CbW+B4sA+xTBudWzu1Pxy0v4hRQhdu8w+THwULbrglIHRbBhLg/4GUJwiCIST/IpVsCKfSmu1TwU3+mW6AAXq1AI+xCLKoVVZZ44x5Pu0ES8ZGRTu4KfuSsf3qO5SvR8QuTCoYsfOLNwo9Hr97V4AYtsaVlCfY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891965502732.3560218327513; Sun, 16 Aug 2026 07:52:45 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcDl-0008JN-3m; Sun, 16 Aug 2026 10:52:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcDj-0008DT-Da for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:52:19 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcDh-0001yG-QZ for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:52:19 -0400 Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDkreC2760527 for ; Sun, 16 Aug 2026 14:52:16 GMT Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2h9gkhaw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:52:16 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-52cd0374265so55869211cf.1 for ; Sun, 16 Aug 2026 07:52:16 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4999610966dsm76986135e9.5.2026.08.16.07.52.14 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:52:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= thqyj3sMPrnVALSr8jLtNV2ILSSUcEatI3pY945uaJA=; b=TYr/dmsgZj+1R6Fe EvlouOMZQx4V1XkvAjldmaDYD7hb7CkSIFmJWk+O7LurDTyMK2BLU/Jld+6ikhtG /nVicMeW6Xl/qlS7jnUgjWaybgWYcHye9edz7VGPVapUHzBP3+/sUk+LzCTjsTLo MLyP8H9RoumfOQPajg2bCOjkc+tzCrzFSebYZRQ3UHvpN7sCEPOrPbzS8kb6Qu6v SB30eSkDVSQMLe1D2Zhq3gcINXoAFCgV9kOE8jHwasQS2j7VmLwDkqx7HP+yfQx5 Mf+O1BIjJAo6t8DMO9LniNMpc3/1RZRBFgCqQEz1GJw0YnbfNKXxjbIdYIdKWZYy SL5uRw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891935; x=1787496735; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=thqyj3sMPrnVALSr8jLtNV2ILSSUcEatI3pY945uaJA=; b=A9qKsIGdmDYoxlaF55L6YmTEzpmse7Piw3v2kTifY/AoS8ME7wdYsJBBVoiAL+sJ4R CneWwX5hisdpGcz2wmpP3nqK/bILrj1N1vJHrejfmmdHd12BYZtCnfIXFFLNitLYYXCg 5TIG/LLDQGUMgkIzkzcn02z51ZbTPdifE2M/LBysfLImvSeWVaek3y7LFT7Z/oU73+yt FmN6D1YBC6ARaxrE8NNiRH9+DQdF5kOfJH5UuvYxksitUtWczeuAvwPcsC4kAhTkSTH7 /bFfgmoZ7pRfbI3xZ+JDm2hcvh2y1XFu4G1HNberq+uXke4ytf3sUwYY2AqtFOeuXOVU HxuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891935; x=1787496735; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=thqyj3sMPrnVALSr8jLtNV2ILSSUcEatI3pY945uaJA=; b=EydPuFN7yoySEAj0wsSub8q+1Our/fNdn+aWF2AyqeA5pD9gaVotM3UgitjDcc3LvD fSUDVFhtBnBNA7h9n9BAtDMlfh6Z+l5HD77KshP5dIQAC0oJubm73M0lm7KxsjW5khQE RrKPj6nK4ZnON2/SQN4a1uYQMPxIR5K33kCH2PPWNY+ITnuVsruHDAnQS+0jmU6ISCVI uoJC6Ut9Fd5hoCe2uDFwdaiVtoJsQsSWFYRikgUbHD2nVuFQubXkA5xr7FlwjXnVGSl/ CwTm5AuADyWbHyw7g126TEJqP86gLMTTKfShOzirVOfuG39bgXyt9zVgAPbaCpfXgwyo 1tBg== X-Gm-Message-State: AOJu0YzTgdVFbFABU1m4upKGHkTSOXtMuGdC5cXMI4BuQx0Ube7B6dUh S7bfahLBI2ITyZMhcVPwNuZQr40f+yyyA3mi1FgNFBdvTgB7ztRgBvZIqLejg6qZfAuY4OhHVYr SUo/frxtyf8uG2hHLCYWFI7AP3nDuI7uuH2dvv9pHOC0r6UeTt7CtklE7lh0yqVcYCw== X-Gm-Gg: AR+sD124DQqhL3z42yBNfKS1jDYGeY/JY6EeTOJQv74G5CDJFbN/bFMFc080Z8IHLK0 Jjqe9ySpWFlPUtdi4l1uf2CFL90Cj4inGtybV6h5ht7lKObk9mgMMARGNXRnLB6x1UnoeXollxx Z4DasdTDtXQpC2oGDzZMawvm1wvSYspR81s1Iu1uQ8QNIEHFeI+FyVULfDrSESC/5oGj+eBox7n YxTQf7xcvbjOHSKl2cCaAooFauPPYxd49enSDEqkii9u8CJR6nQw74+RsvFHv5+ZQlVz+b78+aq ubMymWt9SQYeeYVQtZpSt6XsGQaX4gLF6EduCPrvJqPIrC69nYFdjYo2+XgcDlhsRl/rzR4JhEI c53hhSL37eB/phTiAQvKMyJy3sWAh1BGajcTIkA4NyQ== X-Received: by 2002:a05:622a:244d:b0:52d:7b2a:93f with SMTP id d75a77b69052e-52d85374547mr208332681cf.3.1786891935397; Sun, 16 Aug 2026 07:52:15 -0700 (PDT) X-Received: by 2002:a05:622a:244d:b0:52d:7b2a:93f with SMTP id d75a77b69052e-52d85374547mr208332361cf.3.1786891934845; Sun, 16 Aug 2026 07:52:14 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 44/56] monitor: Include missing 'qemu/coroutine-core.h' header Date: Sun, 16 Aug 2026 16:45:43 +0200 Message-ID: <20260816144556.69009-45-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: OlWpu7VpaVE27l3k4NvXhFdoVA9Y8iXx X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfX0x6VBxJFSh80 sc1qMZ1X5nukVSV+pe8rWP6DGHGj12lFisAntd6pqV10c9Gfb2SJwrV9Cbyr0i5chFkx2EFEuX3 ObIBChRGkPH2tfodsb+py/X80autbWM= X-Proofpoint-GUID: OlWpu7VpaVE27l3k4NvXhFdoVA9Y8iXx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfX0GF2dg2wbW/V xzIw4ooV+3/5hPIIn0GR5e1t9iSSixUfdBzMB3qTe+V9I01WntsfXHeWLedF1H126GuK47q3+qB 770DcGKHQzxp3Znaaq/6o54EZLAYxRqDFMNLVCli4aSChjoKzjvmuSHp9AR/8hSI6r8fJShtBXX /vHaVdJe2iPxQR4DaxYfUJEYQHSBZJ94s90zyG2BURo7ej+6BaV/nxyzXquenmzcTJxBuUymGB9 uvKjQyh9Qotlr4v48p2gTfioM4/8RVYt+r9aXhAjKRTUYxlaAWkWzxrC0dTl+FCF73msq/5o6nr J4V77/jSO/mCM/wbrkvjIwtyOh8LWVZ1865D1YKiZIthg1X0ODX9ud72HvoLe8J7lx6eIUSnx6W NWg/zmSOPASZGczYTrQ2YJUgRfHAU34V3njU6PiETAwqJEFQozNH71+Z/s8wimbbMxY51EfUdBs 5g0EWAyRDV81+JKDJsQ== X-Authority-Analysis: v=2.4 cv=XM4AjwhE c=1 sm=1 tr=0 ts=6a81cea0 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=20KFwNOVAAAA:8 a=tlxghdvPRZsVr19qFskA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 phishscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891967257158500 "monitor/monitor.h" declares monitor_set_cur() which use the 'Coroutine' type, itself declared in "qemu/coroutine-core.h". Include the latter to avoid when refactoring unrelated headers: In file included from ../../target/sh4/monitor.c:26: qemu/include/monitor/monitor.h:32:26: error: unknown type name 'Coroutine' 32 | Monitor *monitor_set_cur(Coroutine *co, Monitor *mon); | ^ Fixes: e69ee454b5f ("monitor: Make current monitor a per-coroutine property= ") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau Message-Id: <20260812211708.92824-10-philmd@oss.qualcomm.com> --- include/monitor/monitor.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/monitor/monitor.h b/include/monitor/monitor.h index 890497b0d22..efdd2165aa9 100644 --- a/include/monitor/monitor.h +++ b/include/monitor/monitor.h @@ -4,6 +4,7 @@ #include "block/block.h" #include "qapi/qapi-types-misc.h" #include "qapi/qapi-emit-events.h" +#include "qemu/coroutine-core.h" #include "qemu/readline.h" #include "exec/hwaddr.h" #include "qom/object.h" --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891955; cv=none; d=zohomail.com; s=zohoarc; b=CS2jh9e/bafbJ6L7yplLorlb7HwXq6TiYmCliJ+JWUv5JCMSZyjpbuqhT3WErco7nbpeuRe4//TV+np5WKFX2HcnMXduVm7qcQvdDI3omRYEDcvLovomb6V0WGdHJPL7jXtZ54YVpmlgXt1vHMtjJmCE7nj3+hQFF4kotIHx3N8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891955; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=EVTMZJKsYTIXB0uIpj4jwnCmJ3xCFkAx7TnXI4n4Elg=; b=CmLOKXqC7KZAhhrFYWeSnLQ7eOTQ4w3RlwMqIOFZxVJnYRb24LDzJosHwWIoTCM6Ck22si80HZk0SNR2PY5+JkNbrMFjhtdU5rQDkGfdU5JzWqVORy5LFFGDBePP5vjFub7bPdv/iRYApG9jp/8qaxussNVToQLT/4Yoe8z5xok= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891955247465.29865678914473; Sun, 16 Aug 2026 07:52:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcDw-0000UV-N9; Sun, 16 Aug 2026 10:52:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcDs-0000Ih-CL for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:52:29 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcDp-0001yw-OG for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:52:28 -0400 Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDkmcS2760393 for ; Sun, 16 Aug 2026 14:52:24 GMT Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2h9gkhb4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:52:24 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51c1c7f135bso45131221cf.0 for ; Sun, 16 Aug 2026 07:52:24 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49996183b89sm67527395e9.12.2026.08.16.07.52.22 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:52:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EVTMZJKsYTIXB0uIpj4jwnCmJ3xCFkAx7TnXI4n4Elg=; b=Ge0GTyp5y7ZgSjA0 eJ54km56kKVaMZhsN2YqPzhJ7Wqy7ZGQ09JpjhCwsLxbomk7m4rFEuRGkKOQF51K LfWyhV4IvfCNQZy4K/K++xpzzjSaKRK/Z0m2o0d+jwRgjwR56b2Pv4nam5oiMZiM 6VwuXORZq7JZZ5tLEe5Pd3hUH5QFH4HzfvzfOE/XP2GkK3RgZryeshK5dBs4IVsd oBrhf7aKV85ttHC8vQVl8QKS+MsJVYxnoD23HCpw0srIaL5/NUWsWF6RPsXdF3k+ 1ifikf/L75497/Zm8avxfVBEt8cQZuNAREYaIIkk3lKyvu5e68iJJN7odJeZ5P3v Ia9/Fw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891943; x=1787496743; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=EVTMZJKsYTIXB0uIpj4jwnCmJ3xCFkAx7TnXI4n4Elg=; b=Uw/WOaPfvF5GceVhKttanbRCcT4eS6QKN5CAZ5nQOc26g3AZOGL14egLbMFgevxIv1 wj5bgdSFS2i3Li+jnZ7anD7GsbndKueY30EiQJk1csgPrte8+6XRA3VkhCmZaRRZ9YLh 4iOnd7UVTUnFcooO3GlLcvzjkFRFEm59SepdUrqjUGiNFDjhtQ+dSjaPqyWdaiJUvbiX D7IjdfYBkQn3XxC/pOC4x1gB1gqndiSLISBwybx3jLU78ocDPI4JjPuVefdpQ6mblu50 4rtRmfuwlxdUD3jrMdbsIIVSsgcFRXcgIE/dyIleK8L/3WNIMf1/YcFV5ikjtwRwmT5a rxQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891943; x=1787496743; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=EVTMZJKsYTIXB0uIpj4jwnCmJ3xCFkAx7TnXI4n4Elg=; b=rc5k6MkqYg8B0zAZLGRL7z7EwGt82+nQ29d/vHWURck/XXll72t0LwDBLKk9G7ft2m zd9TlAScmo6OnbtXOgm3BqHTxEqy2HgOu7GsOnY0kIZVZobRG7LkjKXPdX81zN7CIMO9 tcg3mjPFiIkjanZIcJFgo9iy3goN8htaeFZAYkvIYNJKxFHeDjTLA32MtnX1R+cSdG71 FMIMUB7xt/484RjUUPigVX3cLj7JyIXZXcXNOkMpWPetYcj0l8gWIUvQXLG6kS1jsf4L M1DeBbuH4LxPCLfBt+AOXEfPs8hYzQoJn2QShoNv3MBOLHoXTNh2RUwXW4RiD6EGekDZ bqfQ== X-Gm-Message-State: AOJu0Yy2Sz0pNABigrTtstYDj66xRO4AcUh6C7ZVCxTFy1aM35N9D26f VweA/9fXOBCPCw6GlV7jUrsAJuhtbgV/4IfjaMF9Z6rhNg+T81i9ojsgW8OLegEXQXTyW6l6p4x oFwmJo1fz94AOJu4VXZ21uflHQEBuMGazzuDBsoLdkaH+zlqfEW6ABox70ICS79j/Qg== X-Gm-Gg: AR+sD10ksAbpSRsmCThCOdu39DA46zuIFmY0NkS0ILB0pLcT6MNi9vSkIw6OGjBY65M 51CMR1C+Gos5gyQyicNwTzRcvLmZ3tfTB3G37NgJlLEL8zuZ3s6ypPePMwsoaqCqaB2HyYCQap4 nXvWyv3TwhEGLRSe5z9mqdPDWZNeqvQQiVqcTXF+98fPa+PYWDlNwVk0Q06uq/bmvAmOU8Fe56u Dey+C1pJA5CDo5+221GwgVznP41POECILSDFyQnfwePli2eRIHX4i28Iz9QnTeW1ksu6O4pOX1x TZmeEZndREweDn4K1qJwcOaXg6BWqS9t3zYYE+TCgcFk0YT8+j+/Xscurcbw8tthQ4ZMgFu9nzS e6p7QKKBuaelutjjWg+I7SJ5Jlf7e0gH7nhz8HQBl0Q== X-Received: by 2002:a05:622a:1445:b0:528:3471:9390 with SMTP id d75a77b69052e-52d8535dc23mr166721001cf.10.1786891943450; Sun, 16 Aug 2026 07:52:23 -0700 (PDT) X-Received: by 2002:a05:622a:1445:b0:528:3471:9390 with SMTP id d75a77b69052e-52d8535dc23mr166720801cf.10.1786891943006; Sun, 16 Aug 2026 07:52:23 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 45/56] monitor: Reduce inclusion of 'qapi/qapi-emit-events.h' header Date: Sun, 16 Aug 2026 16:45:44 +0200 Message-ID: <20260816144556.69009-46-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: AcdOtkz_MhjbDhlCQwt38F5Q0x9vd16p X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfX/OFicLS63PHO VS1/OFwRZnTshxEIQYZ17CkfhyBK0puOx17sTBAZl0Mk1AlzVRAr8Pd/PlekMY5VuQuNo98vLLs HpXFAITL+mDjM4Z2UOAwE0MDgnw4uMc= X-Proofpoint-GUID: AcdOtkz_MhjbDhlCQwt38F5Q0x9vd16p X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfX2SGkbQ1mIpJQ miJnIEysO5WwS20Mu9w8NbChDXqJMWbL3LT6sTkOgxbAPDsVy7SNDRBN/1EdVe4O0zuvp0Z4Qjp Ea/ni9BffOifeotx/gNZoSr8pVNNYNAJgfyygOVVSwZk+dhuqTD+mrkqlW7lYXpDGXu39PsK/fm 6P5tlgSRyBlUsHOZ+Q1no2P/K4P3Bbvpoie5sxwBGlKBcJFOoLIggNz3lBfreVUJqe+NOMYDqCl f/xOcNFGPnM+ep9499y8qqBfty2l454b//GTrTvDVJjQJ1sDzrv/qqgftIbuEhIPW6IoGmseSqu gYY7LMsV/e8Bwy/33Iz7/6kirIjzVin7hIpl4pWvZNTBKXIlaBrtJwrhknVylthx96AyUhoL6cu Ku9HIiZBZM1DFjHNghW/VkMTstJiFWcQEbEzJ2TDRafpdoJmw0esPDLN1EiY9s2WE07ORBkz6mG ObdKOXemjSuReonVLCw== X-Authority-Analysis: v=2.4 cv=XM4AjwhE c=1 sm=1 tr=0 ts=6a81cea8 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=20KFwNOVAAAA:8 a=tlxghdvPRZsVr19qFskA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 phishscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891957072158500 "monitor/monitor.h" don't use anything declared in the generated "qapi/qapi-emit-events.h" header. However the "monitor/monitor-internal.h" do: 107 struct MonitorClass { ... 116 /* 117 * If non-NULL, the monitor is able to send event 118 * notifications back to the client 119 */ 120 void (*emit_event)(Monitor *mon, QAPIEvent event, QDict *qdict); ^^^^^^^^^ Move the header inclusion to "monitor/monitor-internal.h" to avoid including / re-exposing unnecessary declarations in the global "monitor/monitor.h" header. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau Message-Id: <20260812211708.92824-11-philmd@oss.qualcomm.com> --- include/monitor/monitor.h | 1 - monitor/monitor-internal.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/include/monitor/monitor.h b/include/monitor/monitor.h index efdd2165aa9..fa9f4a8a75a 100644 --- a/include/monitor/monitor.h +++ b/include/monitor/monitor.h @@ -3,7 +3,6 @@ =20 #include "block/block.h" #include "qapi/qapi-types-misc.h" -#include "qapi/qapi-emit-events.h" #include "qemu/coroutine-core.h" #include "qemu/readline.h" #include "exec/hwaddr.h" diff --git a/monitor/monitor-internal.h b/monitor/monitor-internal.h index 23829f32f9a..bc0932c425a 100644 --- a/monitor/monitor-internal.h +++ b/monitor/monitor-internal.h @@ -27,6 +27,7 @@ =20 #include "chardev/char-fe.h" #include "monitor/monitor.h" +#include "qapi/qapi-emit-events.h" #include "qapi/qapi-types-control.h" #include "qapi/qapi-types-qom.h" #include "qapi/qmp-registry.h" --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891968; cv=none; d=zohomail.com; s=zohoarc; b=KTas81rrlBB5RwtcZPZqWdm0esVJ5bs5zJ280FRSZ+nGskd4hQH9kw9MXix/UGbZCFUqpWz4MKuAD3DV3gdOWdL2QZG0HVnXyOuBSSu3KP+lT/ld07uJ0p577lrEXKjxny+f4m+mxK+DQPv/mkWuvZzm81Z/n5Wm/ZIG2YJT3oQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891968; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=9+WqiaNjbQjH52OWtiPMQB3boxmC+X78TDrAgIexTRo=; b=nMoNYvuB8VBK6MxbdnB9NjhG979adwcbA2nmza7OPGiQLHDYk4Vgod7GSqO4PGXW6feJ1yt1+NypNiM6Z3lqSDOn0hqWEfASQTrjc/sRCd1ELMQoWrF2/ObuVDv4h/mEoZc8UWNHblVYat3yzh/Uj9DxCUwo1Hh0xYjHj+Q5FSE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891968738370.3260840051246; Sun, 16 Aug 2026 07:52:48 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcE8-0000kH-7l; Sun, 16 Aug 2026 10:52:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcDy-0000Zq-W7 for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:52:36 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcDw-00020S-Jf for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:52:34 -0400 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDl7vt2398177 for ; Sun, 16 Aug 2026 14:52:31 GMT Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghq3nwm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:52:31 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-52d91cc174aso35868921cf.2 for ; Sun, 16 Aug 2026 07:52:31 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499961098cdsm66810015e9.6.2026.08.16.07.52.29 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:52:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9+WqiaNjbQjH52OWtiPMQB3boxmC+X78TDrAgIexTRo=; b=b6ri+u4GKdYJaTL+ N7dXCa5XmuUxOSXLk6WZM3pjaPYbTGqGBd//7zHiB45swRqRPI+HmoUjSEJYRDa0 r++o6lp75Fkf8EIZUCqbnmr3LEf5p+XQiDCliWMI2my5BGuXNq36UbJUCkN9O4N8 GeHuTzEEh8fWSfJFYb54rPhmnSyqqwZZfQPh66sgIxfcgd9Ragx+BOs3Ak6pgfI1 rL0p9bpXa5zbeRsN1sAroXfuxahC0Wys7d5/+kV6uXzS0ocmVclh4N/REc16hBOu 3ue4rImQTrwGe2gwzFZ68kiavD5avmD36YwRyEzuh6GgZN6X3YvL57gyUoXx0Vfh QutQ3A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891951; x=1787496751; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9+WqiaNjbQjH52OWtiPMQB3boxmC+X78TDrAgIexTRo=; b=AxYKWtRpjYaaauqgSy8hQFoXRcOkht0/bdV6R8cA+13H+prP45HH/SovP++riANa0o 9uwW/8QM9P00jpv3iY0RSnk7KXoov78L3alDZFnrT8xGK8PUXdfzHJflF0jBARh0tCB3 rwJ5v1W3cjtrQdqJOENr208DqfWv6C1Lx0cZUYK3OmgyZiJShCT2+yCqbXJzBJzyoe+i cj89Nnvxx1ldzOHLhySQLwRnFTf0KeJL3jXgwNrPWwrFqqQC3Im8OKdNykl2U3S5y2q5 RibHVDoEyWx9W9hwKEG9TqO12/JBXZUuYGeL1rRoMlSpfP3+U3+uakguh/q7M4+O9VpB u18Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891951; x=1787496751; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=9+WqiaNjbQjH52OWtiPMQB3boxmC+X78TDrAgIexTRo=; b=UKF3MMcW1TKJeHKrRdC1IQZzDatoZIaetm6Ve/StZDWLC4t4+xKfmwJFEx2cbvhIwi HXPC+qiASiJKhGsA606ceSoJea94MtAL8ZEkxpw9ZlvWe0IN2uQqiS/I8kkTIDQ5HL3I 9mOiqvuHAGs4iwv6ZshGG55aGV6/yKhJ8ynHs33u9T9YnJPXfrMOtSgheRlrYcAXf+RW Cx1DU8bqhXGAOrSfaaMtjBXPvtPH2vAD9CVE9bjf4haq6CGnMP+hbNk6SP9DatHV0eeZ cChPGq2uwm5+WYYBgJRq6Y8/NSEDi6oxMqJSCSJSIq/xBjtqmDZfj1BZXo2j6FV9qveB 7xbw== X-Gm-Message-State: AOJu0YypaNxX8d08a7d7EJLDvlVmQhLpEY0qrD5ikYSoNQC+QA+DJZwA NJ0/mXDB4VxjiWAb3LFzPi2RJhnizr6JICVMm06NhqMwL3qtcvugP5L7C4jGPKtbb1slsx6vUQ4 shLawr0O0Ni83S2b+QyZedho7JFm/MruOluHjklN7BWbD2c7OsiQLuWDQ+hIpTojn5g== X-Gm-Gg: AR+sD12KH7/q7/5UOuB+0gsSfx9OucWFbyOW3ajsaos6VpHp6z4ETW6OtonwwdhXu3a BcQQb0TA3i16M6K/GeIiYeH4J1c/cOp7fHFHZdo0wp4yRzK3lXraNmskYQfpo4VZQyBGchMYO7k hFExX+AKwafrjbG3hLAP6pwhmR4IYfo1R19hjn7Jpd1B+bYSdC7yQct1dakD5acWrLfBmMgmDIy q5tju5h6AMMTnbU9QNJO/Po/+Fed9sapPjpCS6Do2XQUS9SihOKBj00krvBWSo03W5HgbYT8oQj g4c+jIfvLo0JDF+m7HwL4n+JlPbwkpALxRdVpXWVc/jAJZZ9e8ne+G5M2HxMb+0Vy5AVD/0cjJs qaJdFqihbfxkyHN8LV7Nf7Te6QJwXANLWzhORu14tiw== X-Received: by 2002:ac8:5cd4:0:b0:51a:6feb:dc8a with SMTP id d75a77b69052e-52d8534fa81mr234300761cf.18.1786891951129; Sun, 16 Aug 2026 07:52:31 -0700 (PDT) X-Received: by 2002:ac8:5cd4:0:b0:51a:6feb:dc8a with SMTP id d75a77b69052e-52d8534fa81mr234300441cf.18.1786891950747; Sun, 16 Aug 2026 07:52:30 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 46/56] monitor: Remove unnecessary 'block/block.h' header Date: Sun, 16 Aug 2026 16:45:45 +0200 Message-ID: <20260816144556.69009-47-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfXwbSq7CB2/QqY WvekK3dEsSBiHINj5ogqrQu5CF0JVsfeI5cbL+gm585Wy4Wwp7fBTvcoqdrTIF/c3DbkYAcp9Za UHz9hA557PQH2cUEkM1fnx6s0DuwFw6aQNcCR9qNaQuLyeUrLKk0bvHZjPtIUzF6hBKgyS1v+wo 0GBeW0rx9qBtFZTpCanlitBvJdSk9f+wf45K0JC4U5LoDApikVvfXiyAc+y0szS92nqstvreM5s ZKjnVGT6h6oWvcVKMdd0N+b3zYGXk7t6OqUK1vHRh5ors69P2DjrK179NNwF7SzsTZhNNqtippv Acaq+nFwUVNI8MQel207zo6ZNFuvjDW6GX1S7GJcj+h8AJa//KyMy04CJN996/okDuzwmiKCW0+ Ty8HrGGqsur8qqqqNjxk+5xoiHsB3+TObNSRT4EcFHuccO00BiclXAk2aDHtyLdtUSVall0qqwt ANXTV2uxC8ogyAb5L5w== X-Proofpoint-ORIG-GUID: ozW30WdICWR16ONzfeMBMOv48daDujV_ X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfX862TfZgwYXyg 3QpIDI7xE/XUg5QTSSTfx+iCKATmw7EzwUst+QoI1MVVj/Cj69vYGjWYF3ILSJFHFSY7a9ia1wo R46A+VrmohesiJ8nWkROqUqUZxEao0I= X-Proofpoint-GUID: ozW30WdICWR16ONzfeMBMOv48daDujV_ X-Authority-Analysis: v=2.4 cv=dvHrzVg4 c=1 sm=1 tr=0 ts=6a81ceaf cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=20KFwNOVAAAA:8 a=hs6llZlkumWZFO0I0y4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891969081158500 Nothing here requires declarations from "block/block.h" anymore. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau Message-Id: <20260812211708.92824-12-philmd@oss.qualcomm.com> --- include/monitor/monitor.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/monitor/monitor.h b/include/monitor/monitor.h index fa9f4a8a75a..fd98ee2c71d 100644 --- a/include/monitor/monitor.h +++ b/include/monitor/monitor.h @@ -1,7 +1,6 @@ #ifndef MONITOR_H #define MONITOR_H =20 -#include "block/block.h" #include "qapi/qapi-types-misc.h" #include "qemu/coroutine-core.h" #include "qemu/readline.h" --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891976; cv=none; d=zohomail.com; s=zohoarc; b=UtpoNsfkmrbDUnvF0ND7bw24u0K5fVgs/+0ROgRKssFvkhWhQVYqJNG1RHS2iRiaHNj6QYXVX7hBi+GYv9PkroQCxk5x/OHRneOfUREe9xwVw/HOxy3xjip60N0gLtoxY/NHuMv6Frl/JMTIKnMd2QEHE/NUvOZ/Y9EwPlpxVT4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891976; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=L3FrBga8j/P06fU/Dp7c6hT2rFtieRXEyRy2ggU8xKg=; b=BeaOPsx0QQRPMGvAqt0aL16ZeyBKXsnk25wOExkJi6IB+pPCiF/jhANbUbsmjwYy8s7o9dT/OqButm9BP6LZP+kOWhi6WOgSa/NLxEDwV/dCmupl9T08y1k09aKqwqo+M84RE7E1KokmOXO8Sw4dbB3DS3IRRZd3+qUltKq8+fs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891976365970.5216724411852; Sun, 16 Aug 2026 07:52:56 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcEA-0000xl-KR; Sun, 16 Aug 2026 10:52:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcE8-0000m1-Cr for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:52:44 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcE6-00021e-0W for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:52:44 -0400 Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDmCcw4145024 for ; Sun, 16 Aug 2026 14:52:40 GMT Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghwkkkh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:52:40 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8ec3314f65fso25873426d6.3 for ; Sun, 16 Aug 2026 07:52:39 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49996113beesm50163865e9.11.2026.08.16.07.52.37 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:52:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= L3FrBga8j/P06fU/Dp7c6hT2rFtieRXEyRy2ggU8xKg=; b=JDqn4sryIedvZ2bd ox1r1uNyjEmu+F/MwhO8wl+U//sLjmoDKeCQGajL4XvFzRXILkUbB6MhACCu3rzX +JfcfNC1EB02mwMwSjlfhLerRJPGWNSbGl2P57GGKp0+GU+OTTYvqgNUpEd9daKu cnNSLzdW65tSrQlAFPg+i8kG3SxrnWclA3KbZz1wGpBbBxXyjPH44B605NWiTq7w RMgvVJs4FgzM/usCd9FxIUUL1X7cZuj1GlzOOa451DK8aiQuzPM6aWw7lNcK4pIi 2FasBD8jUlyOWoPP88/qIThaPOfWCzRjV+MCm1Rh5nHUPGN7HP85FrjRATm1ip++ 8i35Og== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891959; x=1787496759; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=L3FrBga8j/P06fU/Dp7c6hT2rFtieRXEyRy2ggU8xKg=; b=TTYY106Z9I/lQ1qUWclLjsKpGEaP2HYkPUBW66Baap6gZZR3Hf4ISc7vIwkt0uuq3g dyLqJefXtixu5HPuHcSKO8UG1HE4h3KOBK2LgM7An2vXtkD0VL7atoo7pGWBlehn2zys qXsLxFV6xmJG+fN2LfHT+bTR5o1OwI2zhMx0QYRnGnS0xhaX68ko7RfyvqHpj3cZdz/R pM+Wx0Jfyb10wfRf5YupMaB/plF+neNPka74RpFZf1kt4M0bS7B4sEGOZH/UJkqxOYp4 Okb/zjGFoaeRnIN4Zy6fTRac6MAPfsNSBVDeDvYAGSmIgjQ8WX3joIFCX6WLqj7Q4Mfp unvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891959; x=1787496759; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=L3FrBga8j/P06fU/Dp7c6hT2rFtieRXEyRy2ggU8xKg=; b=d4zUevTXAj6tHwI2M6Xn38bOAFrvInD5Jfg5j8wqneMC5AOeIY6YeXnSfLmw59aJKJ kASmRxkCIaWDTvdy6aeifCHG0AMEl84gW3DrjCDYN/OdoQKPmULrwkwNyGcSZIs8ATZ1 L9BzT1A2WVoYICRymcnpaaSMAbBzH9/WAAwI2M+mtaeInAzaZGCAwqSTPN2Shh6WoB8P CY+slSc0xvKlDqDLfdfqL8nOo7SpVYZBtATXzZm1mAsGJehcmcaI29u+i+0E3H/kV7ZF F47yrsIyutfRdrmVKoFLmRtw8mU9WwkaNp6m48STl3LEyov9y707cN7H3vPVfiEHN4uz SUAA== X-Gm-Message-State: AOJu0Yw0Rpg+fmNjocVm3e3wklMKjhmfo+e+sHLhYQpA2hmFgpeYH0/P v2ffti2FJfoniYH2yGJ5R+IC9lYOugQGoJdM/QorG/7ZCCuPHt00x7iDrBI0IAPwf1k5Vig7UAU LG41U4zruqMlRXzCCiQMst9AEkoCdI8Mkjk13i9s2uopVuM5/J3UWdc6E5C3u42u82w== X-Gm-Gg: AR+sD12ih6WSdYG9M3rRgNrZZXMvJi6y90WggmsMW95SKKpMc4HFeYABfKTHKMpHGXw gMdS5RaDSSHx4k/ih53d+7YlS+pfTMOVGi/LpiXRIeX1y8WAZYhsDtTZxIzeebEZn5kdOCog4ou NaoKCy/5+U6krg5HkUQTbhsHF29/rT/tw/xpLPgp8JWxrC7ZX4e92Xsv/vwW/9CMfD6yxhWRyNp LhS4SH+CuoivBX3qw74/93j8ypelGD/p9BFV1yLcTsPOG3EzEPIEijtNnAmme9LNiUHD25H+sTo HRf97d9CW/BYTxRWSbWlQcun0jwcjyxd1Sz541SKR++SmXh1hsriayllcxUF9esvwlMW+FrEIYZ d5sP/VdFsXLXjzVclt1sRG6iUJMBH3D32+ufD47hqQw== X-Received: by 2002:a05:622b:92:20b0:52d:86ed:8394 with SMTP id d75a77b69052e-52d86ed894dmr122054261cf.36.1786891959124; Sun, 16 Aug 2026 07:52:39 -0700 (PDT) X-Received: by 2002:a05:622b:92:20b0:52d:86ed:8394 with SMTP id d75a77b69052e-52d86ed894dmr122054031cf.36.1786891958725; Sun, 16 Aug 2026 07:52:38 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 47/56] system: Remove unnecessary 'monitor/monitor.h' header Date: Sun, 16 Aug 2026 16:45:46 +0200 Message-ID: <20260816144556.69009-48-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: yiCXnzSLmt4cSrQX2Tll8DXXpoPQgj_S X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfX08SZzKPI0pdX Vqg2HHjaqQgoKXBHWLktbry2Zj6DIVoTbYoL3PBfiiaOT91kXlKnmKbVvvYZPF6GFaP1t0a8mME fxMlWJPT0ZcZyB91kJKEXh0EbTfXhJUXzAq4ObV2vohnxz8Euu0SWpIYplHm/4muOtvodHJoT88 vJb2+byE0GVbmvfrtSTlqjGPTqRY2+C8x1AKYmCl3mI5WjwyiuYeL+y36qirxDAPnqfEDJ88TLm 0QuYB1MMAA9WVVjeJyeUJv+4fqXRkKFacq+4/4l1I3i3F/kjQDGXkfHKlY07/ZQ6IyJzNoX3vrS t5l/I9mqXTF6nbE+Tjh2Hxd1oKQqvcrv9VtCs+yVPxSjwHDOJp5ic1Puh8Vc7H++Q4z/tNLsOPg xJySk1odX1JdG+Zyl7clzPU2aQUsduNyKqDe9SJ8fIUZS07Zd8ss/XEezt6ZOW9HROSabT1kIlU 1xTdjv/8WiVmLRH8GWQ== X-Proofpoint-GUID: yiCXnzSLmt4cSrQX2Tll8DXXpoPQgj_S X-Authority-Analysis: v=2.4 cv=DdknbPtW c=1 sm=1 tr=0 ts=6a81ceb8 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=20KFwNOVAAAA:8 a=4VRd78mhg-xsesdjslEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfX7sGm4JBPst1W Rfvhug6hpMmaJkqwxHFDxLZu2/UZ1oDdRtO1iJXPVj3lDSLuhaRcVxO1xfatEotR+UKD5wbtqS9 HhWkPyBWeLybIqcUeyDg+rInCUY+NOQ= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 priorityscore=1501 adultscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 spamscore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891977110158500 No code in device_tree.c or physmem.c require declarations from "monitor/monitor.h". Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau Message-Id: <20260812211708.92824-13-philmd@oss.qualcomm.com> --- system/device_tree.c | 1 - system/physmem.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/system/device_tree.c b/system/device_tree.c index 1ea19629841..48365435ea0 100644 --- a/system/device_tree.c +++ b/system/device_tree.c @@ -29,7 +29,6 @@ #include "qemu/config-file.h" #include "qapi/qapi-commands-machine.h" #include "qobject/qdict.h" -#include "monitor/hmp.h" =20 #include =20 diff --git a/system/physmem.c b/system/physmem.c index 2f37cbeb071..362a00f76c0 100644 --- a/system/physmem.c +++ b/system/physmem.c @@ -84,8 +84,6 @@ #include "qemu/mmap-alloc.h" #endif =20 -#include "monitor/monitor.h" - #ifdef CONFIG_LIBDAXCTL #include #endif --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891975; cv=none; d=zohomail.com; s=zohoarc; b=BuyjM1n8HPHaSOxj/vE+zB6wUhpBTzQW1DboUT/AYmu59oyhhIp+K/BADJvl11d16FMy/6MK/mfBEkappBfHeQrt37TDPOszNzMQTSA/Yzq0sNM00dg0CpTRqXA09XCyxMGsSA3Gw2pWMHWfSq+8kHLfMB1woAGTQJAkCu+361o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891975; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=SL8Lt4C14/DK3lNJomReeRhLYyBT4iIQEopvxRGlAEM=; b=CUfVfABsZos8f0aIzFLdO4ZWLNPjgtWGkwxtxkzZTOjjqxJG6tS/pmrF7X58NbONQJ2Y+ydttsaLN+L1DHwOuZ0NG7wKJb92kJ+Lg/K3KZzckntGOVOHMTrzuKKI/HzkwVy5lWb6CCpUYmDCLsCsGKMmhBgRUUULFzuyRwJ/ACI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891975056670.2580050065627; Sun, 16 Aug 2026 07:52:55 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcEG-0001Rx-S2; Sun, 16 Aug 2026 10:52:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcEF-0001IA-0n for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:52:51 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcED-00022U-3G for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:52:50 -0400 Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDlFg33161996 for ; Sun, 16 Aug 2026 14:52:47 GMT Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2hd7ugbc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:52:47 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-90a91f4c6f1so16361026d6.3 for ; Sun, 16 Aug 2026 07:52:47 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f2005b0sm26436719f8f.8.2026.08.16.07.52.44 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:52:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SL8Lt4C14/DK3lNJomReeRhLYyBT4iIQEopvxRGlAEM=; b=OaQZj39Sj5R1BcJX hV8pZf53PKTKOp0vuyl0Q5hdlNRCqKugCNvFDz4/AnsKe/Kuu2Tm9FpgbfIo5ib2 BzsFs9N45hXXLX7CxOp2bB1FvFB0VfWHII5VC/gFBWPAXyurFrf1lipzr6rxpg2t SxukDphi/sCbx6heQJYdjfWhEThnja3QVf+StLi95wfZAPMSTtCGjJOhGzrb+B/J n0nAbIKX5VMKb9//Mh3Rpn9f1DJ/8hWTyfU+Mql461HnXzMQKCEnPZc76mUl4oXW wkgn9NASM/Uh0vPkYYFsoYUnzCPZgimyK+OLRWi6Zm9bsmHEfM+YPFjavK+KVaXz h9taqA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891966; x=1787496766; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SL8Lt4C14/DK3lNJomReeRhLYyBT4iIQEopvxRGlAEM=; b=Ygq3ZhmABtfyDr5TankuJOSX2v0rGef1S+6KeUnpc+5YbRvJzo1WUQ23ayuWHNPPkh s8/XpLZFgZMhuScTbEg6LVWXDNlLeWk61LljctIdwuzL+BMoUc+Gy3leHhkc0O/emtSz eR4UzzA6Nqmbj/DlMtGcsKd0BRwhucC82REn6O60v5DOJJ2aQQ7Oupvd01M+QSNFGGPW R5ySs587sSHM9dcUXZiUk/acbhPLciw93Z5WkqH5b6I0UVXCpLy+tuH01hpm5aIh3xEd uuGPZvX7KsGLsfZ/4R8J0BG+KHS/GpUk465C1oJZemAOO8ioc9Uaoz5Ef332OXufprVT J+ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891966; x=1787496766; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=SL8Lt4C14/DK3lNJomReeRhLYyBT4iIQEopvxRGlAEM=; b=b23p8ePtieZl1abilbaVY57QsvkZC2niwc1TcWmijfCiZQ3f2qKrg7CIdOYWn5woyf Kfj0NsPZxMaLV97pKHsKzfsuTbSp7aY1d6hOEZQBiE9eU7/Ef0yYJDZZFpfPzmd6KFS5 w/2dhhbdShQU7pUpHGetjKdEfa6a0JXkQfHZTad0I30V780RqNkFP4bJgCMzd3xfh+mX 2AyO32GMh57aFt6RhAspdFqA3rIKXwfrUwUQf3q2Yt5LOgDhxq3ULXzhfAVCgq7HUtmA 72SBxaZ4BT+F1jPBmfoGfNGjx/mX9BAEej1Vvp04x98Je9ip4yxIRDRIP0Pbvo0/f4Lf P+dg== X-Gm-Message-State: AOJu0Yz4ah7iDFhuFXwICTW4EFrdpBcCYtRJnUX+VZQHay1qUlPBYSy2 PKC9DJSAihNWHlHN5NBcWcghXu+9cjAaGSwF00nU7QGKXNV2V7zneXcuJkkWaCLDcVurx8nIBGJ 3Ojthsss6mqNFIsBtaqHxEQJXrwPgOgOe17FWSIrjoo5eektAaD6HjhipbyQAQqHBtg== X-Gm-Gg: AR+sD10BbiI7cE0tP/2B3Id7n+6UG2RZfqa8s7m8YHBl3nvy9P1JtZE3n0EchDfJxfw Y3O8KxIm2PgtxO/sLOW9dYGQ0/oqiiUbxO48DYd4pgRVTfMWe4b0W++vUaNrpxB1vYN7SX8amRC fZDp2F3XIraSmYoPWk///gu9LyEo5MkuLVf8Wx3QnGIlIrap8QgLntMNqE3xlVZPb5cHuVMYKrB 99EFhYiyQsxNp1pEVedsAVLkZTrvuy6bFpmjcs1TB+qB5g8mANDA/jB5IaPXO0y6aOLvBKBZ02T 3GmlfKqAfH11QFAP7StGd+9wc3CSpU2hjcQzgyCZWdWwjTRlydQtqyG9d4nIdHL0k8veyE+Lzv4 qW6b4jb/lU9C0z545p87FVX+JlyhXhcB/o/yUlKKsow== X-Received: by 2002:a05:622a:e60f:20b0:52d:8596:a92d with SMTP id d75a77b69052e-52d8596aaacmr127021181cf.2.1786891966339; Sun, 16 Aug 2026 07:52:46 -0700 (PDT) X-Received: by 2002:a05:622a:e60f:20b0:52d:8596:a92d with SMTP id d75a77b69052e-52d8596aaacmr127021011cf.2.1786891965826; Sun, 16 Aug 2026 07:52:45 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 48/56] system/dirtylimit: Extract HMP code to dirtylimit-hmp-cmds.c Date: Sun, 16 Aug 2026 16:45:47 +0200 Message-ID: <20260816144556.69009-49-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfXwsz7eFx9elQy uXQRoA/Y16pUlDpM8M0e3GLj1IrFnxoIs3R2b3dl8G/XIvmeomH9pd4OD+PxHnf65dG/EurqqcL 0tGLmQGdhq5q209QtsEZBgq5Szwoz8Nm3iWWNDRpELRLAIB/3zAn3gdqc2zZ0qJwltk9cTQxcXV 4StB3LYMN9VgCnKQV/ZmI/hs2+KGuMucBd7q2+EqCHALG6u6qKn8cX23+IdUEvYuN/LpBO9RXTA oh+wYAsxdjivYsjlkvHtq3VMhvKSGZVIOVlVU7fZeCoYzBojj2B+xJrYgVx86c/Q+bWR6338ZzB FPnQgsAsRafyAtNdP69LzCmb+hdTuuh8s0bCa2zGuGgFVAsGgMto/Mew/XrWonnUOkou+etrNat 884+zZ8IbyKvjm1NDfh6ZFybQ+52PQrUA+yYFNM8Wbq3nq9AbDOVATeJbxiv0gySZ/Drn0rJq+N PSnqtYlFinYIeoyyR0Q== X-Proofpoint-GUID: dqdrykshFN9QdL7ITL7KfMO0NQ8pzb53 X-Authority-Analysis: v=2.4 cv=Ja2Ma0KV c=1 sm=1 tr=0 ts=6a81cebf cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=20KFwNOVAAAA:8 a=zCLxbh44AAAA:8 a=WRxKY6twSJXuwc0U0koA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 a=tlNt8cdNSqtyJh_VpUlY:22 X-Proofpoint-ORIG-GUID: dqdrykshFN9QdL7ITL7KfMO0NQ8pzb53 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfX6EIVVBOS+Lzc dahrs6AazYx2DtFv4BCH34WudIlZ7cEjroNb5MeLFk1dGCcM3X23PmAJUjiswzCsK32KfZt9Tjo A3ONi0HubSsjGZG1vkvV9fVtmqBFQG0= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 spamscore=0 suspectscore=0 adultscore=0 bulkscore=0 impostorscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891977191158500 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Hyman Huang Message-Id: <20260812211708.92824-14-philmd@oss.qualcomm.com> --- MAINTAINERS | 1 + system/dirtylimit-hmp-cmds.c | 74 ++++++++++++++++++++++++++++++++++++ system/dirtylimit.c | 60 ----------------------------- system/meson.build | 1 + 4 files changed, 76 insertions(+), 60 deletions(-) create mode 100644 system/dirtylimit-hmp-cmds.c diff --git a/MAINTAINERS b/MAINTAINERS index c296dd5abfd..bad65aeda50 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3875,6 +3875,7 @@ Migration dirty limit and dirty page rate M: Hyman Huang S: Maintained F: system/dirtylimit.c +F: system/dirtylimit-hmp-cmds.c F: include/system/dirtylimit.h F: migration/dirtyrate.c F: migration/dirtyrate.h diff --git a/system/dirtylimit-hmp-cmds.c b/system/dirtylimit-hmp-cmds.c new file mode 100644 index 00000000000..4928d57cc8e --- /dev/null +++ b/system/dirtylimit-hmp-cmds.c @@ -0,0 +1,74 @@ +/* + * HMP commands related to migration dirty page rate limit + * + * Copyright (c) 2022 CHINA TELECOM CO.,LTD. + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include "qemu/osdep.h" +#include "qapi/error.h" +#include "qapi/qapi-commands-migration.h" +#include "qobject/qdict.h" +#include "monitor/hmp.h" +#include "monitor/monitor.h" +#include "system/dirtylimit.h" + +void hmp_cancel_vcpu_dirty_limit(Monitor *mon, const QDict *qdict) +{ + int64_t cpu_index =3D qdict_get_try_int(qdict, "cpu_index", -1); + Error *err =3D NULL; + + qmp_cancel_vcpu_dirty_limit(!!(cpu_index !=3D -1), cpu_index, &err); + if (err) { + hmp_handle_error(mon, err); + return; + } + + monitor_printf(mon, "[Please use 'info vcpu_dirty_limit' to query " + "dirty limit for virtual CPU]\n"); +} + +void hmp_set_vcpu_dirty_limit(Monitor *mon, const QDict *qdict) +{ + int64_t dirty_rate =3D qdict_get_int(qdict, "dirty_rate"); + int64_t cpu_index =3D qdict_get_try_int(qdict, "cpu_index", -1); + Error *err =3D NULL; + + if (dirty_rate < 0) { + error_setg(&err, "invalid dirty page limit %" PRId64, dirty_rate); + goto out; + } + + qmp_set_vcpu_dirty_limit(!!(cpu_index !=3D -1), cpu_index, dirty_rate,= &err); + +out: + hmp_handle_error(mon, err); +} + +void hmp_info_vcpu_dirty_limit(Monitor *mon, const QDict *qdict) +{ + DirtyLimitInfoList *info; + g_autoptr(DirtyLimitInfoList) head =3D NULL; + Error *err =3D NULL; + + if (!dirtylimit_in_service()) { + monitor_printf(mon, "Dirty page limit not enabled!\n"); + return; + } + + head =3D qmp_query_vcpu_dirty_limit(&err); + if (err) { + hmp_handle_error(mon, err); + return; + } + + for (info =3D head; info !=3D NULL; info =3D info->next) { + monitor_printf(mon, "vcpu[%"PRIi64"], limit rate %"PRIi64 " (MB/s)= ," + " current rate %"PRIi64 " (MB/s)\n", + info->value->cpu_index, + info->value->limit_rate, + info->value->current_rate); + } +} diff --git a/system/dirtylimit.c b/system/dirtylimit.c index 50fa67f3d6a..70bb7bac2d0 100644 --- a/system/dirtylimit.c +++ b/system/dirtylimit.c @@ -17,8 +17,6 @@ #include "qapi/error.h" #include "system/dirtyrate.h" #include "system/dirtylimit.h" -#include "monitor/hmp.h" -#include "monitor/monitor.h" #include "system/memory.h" #include "exec/target_page.h" #include "hw/core/boards.h" @@ -491,21 +489,6 @@ void qmp_cancel_vcpu_dirty_limit(bool has_cpu_index, dirtylimit_state_unlock(); } =20 -void hmp_cancel_vcpu_dirty_limit(Monitor *mon, const QDict *qdict) -{ - int64_t cpu_index =3D qdict_get_try_int(qdict, "cpu_index", -1); - Error *err =3D NULL; - - qmp_cancel_vcpu_dirty_limit(!!(cpu_index !=3D -1), cpu_index, &err); - if (err) { - hmp_handle_error(mon, err); - return; - } - - monitor_printf(mon, "[Please use 'info vcpu_dirty_limit' to query " - "dirty limit for virtual CPU]\n"); -} - void qmp_set_vcpu_dirty_limit(bool has_cpu_index, int64_t cpu_index, uint64_t dirty_rate, @@ -548,23 +531,6 @@ void qmp_set_vcpu_dirty_limit(bool has_cpu_index, dirtylimit_state_unlock(); } =20 -void hmp_set_vcpu_dirty_limit(Monitor *mon, const QDict *qdict) -{ - int64_t dirty_rate =3D qdict_get_int(qdict, "dirty_rate"); - int64_t cpu_index =3D qdict_get_try_int(qdict, "cpu_index", -1); - Error *err =3D NULL; - - if (dirty_rate < 0) { - error_setg(&err, "invalid dirty page limit %" PRId64, dirty_rate); - goto out; - } - - qmp_set_vcpu_dirty_limit(!!(cpu_index !=3D -1), cpu_index, dirty_rate,= &err); - -out: - hmp_handle_error(mon, err); -} - /* Return the max throttle time of each virtual CPU */ uint64_t dirtylimit_throttle_time_per_round(void) { @@ -646,29 +612,3 @@ struct DirtyLimitInfoList *qmp_query_vcpu_dirty_limit(= Error **errp) { return dirtylimit_query_all(); } - -void hmp_info_vcpu_dirty_limit(Monitor *mon, const QDict *qdict) -{ - DirtyLimitInfoList *info; - g_autoptr(DirtyLimitInfoList) head =3D NULL; - Error *err =3D NULL; - - if (!dirtylimit_in_service()) { - monitor_printf(mon, "Dirty page limit not enabled!\n"); - return; - } - - head =3D qmp_query_vcpu_dirty_limit(&err); - if (err) { - hmp_handle_error(mon, err); - return; - } - - for (info =3D head; info !=3D NULL; info =3D info->next) { - monitor_printf(mon, "vcpu[%"PRIi64"], limit rate %"PRIi64 " (MB/s)= ," - " current rate %"PRIi64 " (MB/s)\n", - info->value->cpu_index, - info->value->limit_rate, - info->value->current_rate); - } -} diff --git a/system/meson.build b/system/meson.build index cd3193d170b..377adce8035 100644 --- a/system/meson.build +++ b/system/meson.build @@ -9,6 +9,7 @@ system_ss.add(files( 'cpus.c', 'cpu-timers.c', 'dirtylimit.c', + 'dirtylimit-hmp-cmds.c', 'dma-helpers.c', 'exit-with-parent.c', 'globals.c', --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786891985; cv=none; d=zohomail.com; s=zohoarc; b=MKSesz8caNi15laMWdznQNTyvB6JHPflGu3DzCTSWMfWh8+pc0XxQ7d25Zrv3SowvOUa1tqOgawiqZ6KHa7Mp5RsttvppRR+RwMKGXlLpf+dsio3achlqpDsWSCWcSmgFHbEE+TRcysHbQuIHH2atQZDf87qcQdvZsi+4dM2hTE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786891985; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=F6ohuIDbyuIY9Xg1tfojyir1l6XnmoCJoUpT126iL8w=; b=XaMvpagG+6oiITBDXpx9BqCFYoYEDRCPMVnVFr/JyARBaAiGDf3S0/tqZ0i6jgo9Cu91R/PyVk7GsUiRy+KmM91txgkSd6TVEFqn8Ee+X7XX4JabqTVUgYCWAehauRJU5RXOGdckPiu1BYZzw9HwyFHkJwSPrzm+ZaZHVcaTbVE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786891985184712.8908619223456; Sun, 16 Aug 2026 07:53:05 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcEP-0001ql-Lr; Sun, 16 Aug 2026 10:53:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcEO-0001px-4R for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:53:00 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcEM-00028Y-9X for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:52:59 -0400 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDl5m93214690 for ; Sun, 16 Aug 2026 14:52:57 GMT Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghfbngj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:52:57 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-8e9489f62bfso30382206d6.2 for ; Sun, 16 Aug 2026 07:52:57 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49996106c6esm73721345e9.5.2026.08.16.07.52.55 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:52:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= F6ohuIDbyuIY9Xg1tfojyir1l6XnmoCJoUpT126iL8w=; b=asFYYxxxyGH6SMem SoC4pHpYpch2yiInLs9Pp1HF6NaIETq/XRrANZzlIZXQUBQ4BfiR2HSAF9r1Q9yu TTzAbOmsf7CFdqMp+ZqF4DGZbf7CNHExkSiQUh66WqBCGAC2Ys/GPgCC7m0/HZe5 SQAfq1q58/n6VAA6/qryrFYrO2G87C0CNnWkTEQX0XXOBpiBLLgYGQ3UUZe3VfMg aW/DRu5SX0q2Rcc3AIVMqryL+OWeXj1uaI9ebSi1GKI8vUTn+p6cFQHmviLmTGT+ 5ZJga8NOLQEvAiwJhNbGYBx0OzCkZOAZrpuD+l+wjP6kGqrQw0ZyoqOT4/cJh60R kmuKRg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891976; x=1787496776; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=F6ohuIDbyuIY9Xg1tfojyir1l6XnmoCJoUpT126iL8w=; b=gCsvHzVLjxozLDxQ6qjHddScPn5rcn1mvYa+l7YAXKcWA6k9+uZUpFsh1kBcVDNijE yfVZfwo86Np6FCulELWkt+RDjh+UfJlUh7lffaCCg+igk/bLrkD3ETGb7FepqamxW+3u sMgy16NI2Gb66MByY2De8qd415mZRJVL8pez31Q1LX6Ft8884tocNlnc9cV5vvMTVYBK KxSwugnsza12+NhQ4PViehYORYVNg6NbBE8PSDUOKT1f14Fjhja3rEqrEbbT+X9XRPm8 d7BmzCqfrh2E0EV2chf8xUYeBA7EXV5QivqHcwvit9et83R7v7bnqw5FxHyF1lPYZSOS zzQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891976; x=1787496776; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=F6ohuIDbyuIY9Xg1tfojyir1l6XnmoCJoUpT126iL8w=; b=lJgTGobCMN7E/y6n1RLRM6PdIv2ulYV/h+S0Xqxsuh8iTSVDdSGJ0sgJz/AMDlqxpG IAEPZiJj1hfAK7Mu/QY+zJoUxvH/I8XeieEbfr+O8crkHKFXra9ooQLefhraaFiRXL4K HMRsLDwh/3JIJoStVwYwmyoR+0811AS3UOkqq5Yu+smdxoef1RzrZHX917CdeLarVomW o4mpjuZPqcr1QYmLH0eT1scHKqWqUy2mRikTIIS6577MKE997A3WyS+SWf5BsAD9oh5b e6yzUIbfIWUSW6jgH3Etrg53vyZO4yB4UQ6MflcEuOFweOnsDuf8VMBg3hFG8+GNU9E4 +rzg== X-Gm-Message-State: AOJu0Yw9iunHA3uXTszkQ/dCniwFE8a4JrBMaXq/DwwMT/CQdf8wDMnl nZEmIJFmpDGX42D8V3wcPAsqrKCFCfyP/JedUMUy/2QlnEsTNhmKHzqSTUdn1Q9PhlH8Pax7+Yv Cc+GkgvY96F0ow+AyvmJtfVU36eZYH1Kjn42jcf/QFVwZzorZ+kjEsfH1v6kfpR3UPA== X-Gm-Gg: AR+sD12YN3KNF3hD/zXf3uh2RCbTTdVcwqiDFLYVse53f562Jzz8jDUmpJztIQ3EJdI xxK5Ctw6luilPbv5Un1GZaIS5ICO8SDLlGsrzFClknGBvhhkFmq9eiR5zbWpS2kGev5ioTKlw6O 3iHOt8DXSaWJ+0hMO05Hp7IC3gjChfgZiVoPkBTMp3YvgO4KkRhQYhjGhpqM+WXw8YtKVvQ8Ipx +PnDxDW8prvKw2ZnS0lbTC2elo02kF+sQ83Yi3Pg3H5TVrKYI4EkP0N1H06OsZs8tcCrRwaQiSx wcvGsYkTDovP7e41nla7xsgSbrHMo845qkYovmOpBGpDw7Ypyj8oRkt70gtV+3yptdIin4Lnzua ZSTt64CNWTKE9ZyQQoyBVA58GsreujR7XwVP9RRrAqQ== X-Received: by 2002:ac8:580f:0:b0:519:efea:cf41 with SMTP id d75a77b69052e-52d85431a8fmr202423411cf.28.1786891976495; Sun, 16 Aug 2026 07:52:56 -0700 (PDT) X-Received: by 2002:ac8:580f:0:b0:519:efea:cf41 with SMTP id d75a77b69052e-52d85431a8fmr202423171cf.28.1786891976110; Sun, 16 Aug 2026 07:52:56 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 49/56] system: Move qmp_inject_nmi() to hw/core/machine-qmp-cmds.c Date: Sun, 16 Aug 2026 16:45:48 +0200 Message-ID: <20260816144556.69009-50-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfX3JCnhf9a7jtc 4HGCN9rzPaomrhl/sjCuDePr/jAL0Z1esYY9jWBVqSRiBG8BxRwceMkw6WhfsG46hPkOAuwJqMf v2UhFdIJHYFX5PxSurGcFnPvIsKEwZU= X-Proofpoint-ORIG-GUID: 6SGzTjbdGa_R0G1Gi550DIgmqmrO4Vxv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfXzrfYD7fPQ6dJ pdAQJXLEr6M7eqiH6fGUnfstu6rvSBp+8zafWYhmBnfzjxK1hICTIqG3WAe0+qKaJfxR0bKyqqJ /hoNusR9KNnUIKX4Ekp25Qrvb34umhyloIvqM04uQTzn2OccRXcVZhqDV3Pp6PHEdRQaWuW9mHd Jj/vveOSgYlimnotbno8f2K+KLCUWkeebLYqYf/cY31RLfrEn60l0foOSDz+815z2Kub0xeqmJk ehX/k54/38XLVwZUo3ndY1VvXM8DAl3j7vrnTWxorF3eUgs7+nCs5v/nInZRpZIQgpobIn44dIF KVAMg0MiNw05F2BuoDh8AtRF8nmp03OAPSzhEu6xIo8Vm0X/bhb/zQ3A3YnUydNcBp9ZqcdweWo 7FZVUXyVvuIuma0jEmIlPSdCQM6bxO/+yFRJUwaFG6rg2xkiXH6WqjDcH+eemwi5R/D9oEnoYpl Ayd1jnowvKuUxTP1Kzw== X-Proofpoint-GUID: 6SGzTjbdGa_R0G1Gi550DIgmqmrO4Vxv X-Authority-Analysis: v=2.4 cv=I/dVgtgg c=1 sm=1 tr=0 ts=6a81cec9 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=20KFwNOVAAAA:8 a=tlxghdvPRZsVr19qFskA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 malwarescore=0 adultscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786891987222158500 We figured NMI relates to machines (for their machine-specific handling), so move the 'inject-nmi' QMP handler with the rest of machine ones, in hw/core/machine-qmp-cmds.c. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau Message-Id: <20260812211708.92824-15-philmd@oss.qualcomm.com> --- hw/core/machine-qmp-cmds.c | 6 ++++++ system/cpus.c | 8 -------- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/hw/core/machine-qmp-cmds.c b/hw/core/machine-qmp-cmds.c index e62cb4ec888..1aa5f262298 100644 --- a/hw/core/machine-qmp-cmds.c +++ b/hw/core/machine-qmp-cmds.c @@ -10,6 +10,7 @@ #include "qemu/osdep.h" #include "hw/acpi/vmgenid.h" #include "hw/core/boards.h" +#include "hw/core/nmi.h" #include "hw/intc/intc.h" #include "hw/mem/memory-device.h" #include "qapi/error.h" @@ -448,3 +449,8 @@ void qmp_dump_skeys(const char *filename, Error **errp) } DUMP_SKEYS_INTERFACE_CLASS(oc)->qmp_dump_skeys(filename, errp); } + +void qmp_inject_nmi(Error **errp) +{ + nmi_inject(errp); +} diff --git a/system/cpus.c b/system/cpus.c index 9758cda4636..aa2510bf8fc 100644 --- a/system/cpus.c +++ b/system/cpus.c @@ -26,7 +26,6 @@ #include "qemu/coroutine-tls.h" #include "qapi/error.h" #include "qapi/qapi-commands-machine.h" -#include "qapi/qapi-commands-misc.h" #include "qapi/qapi-events-run-state.h" #include "qapi/qmp/qerror.h" #include "exec/gdbstub.h" @@ -38,7 +37,6 @@ #include "qemu/plugin.h" #include "system/cpus.h" #include "qemu/guest-random.h" -#include "hw/core/nmi.h" #include "system/physmem.h" #include "system/replay.h" #include "system/runstate.h" @@ -922,9 +920,3 @@ void qmp_pmemsave(uint64_t addr, uint64_t size, const c= har *filename, exit: fclose(f); } - -void qmp_inject_nmi(Error **errp) -{ - nmi_inject(errp); -} - --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786892005; cv=none; d=zohomail.com; s=zohoarc; b=AJ0oBO4yc9GB3rQj4cXuPQ281fdMraHbDFB1gtM5rgqUCpeAVexhrZ1VtaTe1mDjXDCnhreehCcRTbtK18SfvFS92IwXUNfkvBaG++tUrgHqNujuc4D1GxepV1ACRrqd0sJi/NAGCzWHyon+3RH+wPELsi+hg/Gw8dbkdf8GrEs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786892005; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=ekAhsfwKJ5maIu+35xZAK4X0xH7ZJuguxCqmpYcflHE=; b=GMnUBBh2ZEyL/92Tb26UYmEUhDwTc8UUnf/zj2E8DFGWyGNAc739eifuy0V1VH2Gz8bwzeC3Ezfo/dTPTnGq0SKsnbX7D+ayiBuOLHnD1317rFaZXZuxgKgHko2PcSVBRazSpG2uof+8zKDgayjNhMrU2YAdtAqK/p4r2gWLLJI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786892005654919.974398018435; Sun, 16 Aug 2026 07:53:25 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcEb-0002Mz-MP; Sun, 16 Aug 2026 10:53:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcEU-0002Cy-Ud for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:53:08 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcES-0002Cp-UA for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:53:06 -0400 Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDlA6x3533416 for ; Sun, 16 Aug 2026 14:53:04 GMT Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghf3mqa-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:53:03 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c0e702df8so31797641cf.2 for ; Sun, 16 Aug 2026 07:53:03 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-481626fd0f0sm16539978f8f.28.2026.08.16.07.53.01 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:53:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ekAhsfwKJ5maIu+35xZAK4X0xH7ZJuguxCqmpYcflHE=; b=mqVbaJbQYTGd83DQ cljMRkRd4NlSIa52KAdhzuomNpQNYltVwuImo7OjHTEWn4u1PwqQKYvgfGUT+Zp7 O4UUH3JPc0+iH83hf7I3kD4GjvYDt36mM9QNemx+Fzw4TmzFWH4XlsW6gasII2GH OfeHrDWaNqsLEsUJPndBVQiOI95wmsj4fxQEa4wGThtaL32e3BpEC+H4f8dk+tt6 LtthREDT2fSVMGbqOItH4NskGMr7vNXEyAuSgB0h2xraB7ey6RXqRlF+EXWiFZGT EkEFGdYrnuIZR8VFml5yHpLS1hvs2Gdpvy09Dp0WloG/REA6GITUVxSGf7GOM/WS bcjylw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891983; x=1787496783; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ekAhsfwKJ5maIu+35xZAK4X0xH7ZJuguxCqmpYcflHE=; b=PpxcvbfXEGVYMcs5dQfiHGNqEJ0qc7PXBBga41glGISnXNyL7aIun/Y8m8S0fa1wXP CVpI8w76pu4UD9/SnyTuiFlkJJp5VeNM27oUobSxTstA7fpSXZORmgP2okX2Dm7BqB05 QXIQLTTPGNAnz8vNNM9o1scZjTnFtqo7lk/sYe+3dBQ1Qf7DA83et7jiFxIz3hgc9vUG x9yAzlgUMp8QilJOoLegQheC+UjjgQQ7vNYRn/MsCYVLUVmI2CeHAoVhIp8E+D+UinuJ rQWFTaDT3pkBw+Ab67HltoZOfHsT/nMKSAbGvEcu4PwpPaaFlpxpTSU8P+o5Sf8CM87B NjeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891983; x=1787496783; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ekAhsfwKJ5maIu+35xZAK4X0xH7ZJuguxCqmpYcflHE=; b=qNBss7CNBK2c9V+owCDRpsz+1uoTnH9FTFrtS/KC3nx4LhMKCNhF/eXYz07YtyDE/k 3sZnFF7uWf8pkBuMNmoIB47u0ZFsCt0zdD8tcdbJe59hmBWD4wElRbZNq7Hv8yLsh1Pm KUagAwi7cbUpDVyy2KZPUYy12Fdnh+vNao7cCCvUHCMRvHqLy1CRfdREqADEbOkfTUaa cqe8ebwWrKKyYuI1dOTH3f1SZ/iPdOdbS9zprjVhPK/Hju/9ev7oKuxaDAh4j7UqrN7p 6Lmv6xhJ96lOOJmJhoZUko01zRbhU5OfUkiv4RWIt/C6CgS18ozXrovJvGZsJenzkg5D /EnA== X-Gm-Message-State: AOJu0Yys1l0B3sFZ6KYpNVyitie5H/0yxvzXbf9oz7tMHzFEAlbheFf2 MZhEGvpGWQl4wXehO2s/6Ql80B976U6lPnUsFaNvuKmyVKFxiUmlomPye70kbeiFC0oSZbdNwyG aFZkUfVvWX4oIgxHIbsfe74ELuBAQuPZh05dLDI9xvg10NAaCP9Lf2ASNEyJKqKyINA== X-Gm-Gg: AR+sD12xb2+GKqOelypGF018JzaYbbTfqLfx1hAfCIBUZX+zs3Es70hMuvpbhBVLKrP 6D1lWEobwmXs/8qWS8rSJVHGFPhDOvalIktUw2aiDY01CuAtw9vdcACpge1rOlP1K7Q0WWBegIp ciTSNubKxRHA4V8TrEWR/fpE+JcPLBOAPft0xKC+5rpBA8oH8fmA7PDc4Ycjx0N6Jcv3KKyrCip J3D7K9xJijlEnGJduQHKP7cCKIpvwFihz6Caw4a0e61dlqySJK9XS7/Zd5Z7vafcvjP9og23U++ 3/nVjOVhrEYAnyYYwMfHdbAFW8V6CcIk+H19XQNgP3XVSAn2ZvobyXSgaVLv3P9nUCm3wsLkwdu tx+orDrpxBekulMlwFOsZ+9pdMR20+EEWTXQ5OSXKzQ== X-Received: by 2002:a05:622a:349:b0:52d:8256:ac33 with SMTP id d75a77b69052e-52d8542058cmr193139951cf.28.1786891983320; Sun, 16 Aug 2026 07:53:03 -0700 (PDT) X-Received: by 2002:a05:622a:349:b0:52d:8256:ac33 with SMTP id d75a77b69052e-52d8542058cmr193139571cf.28.1786891982837; Sun, 16 Aug 2026 07:53:02 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 50/56] system: Extract QMP memsave/pmemsave commands to physmem-qmp-cmds.c Date: Sun, 16 Aug 2026 16:45:49 +0200 Message-ID: <20260816144556.69009-51-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=QsVuG1yd c=1 sm=1 tr=0 ts=6a81cecf cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=20KFwNOVAAAA:8 a=7DZkrcYYXL7zIbTVLmcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: zz3cPwpVYNrvhj0cEAoUA1IOo6tpHKzB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfX2QXC7kuBMwt6 Yuw8XL1PhA9/2M7K7j/ifsJy1X2QLLtQNKvFmAojnqVkGLM/KpkW/8jtTWJkFgp+F7MksJQo5vS 5OISuP454085xHhJmrySxHfG/Ei8HuWBOLXE1A7IExZtzTI03cEjZUVGVJOkzt8ijQp1VkJ1TTy ErJcXRy7mSBcQoeCgWZ9haFsMDPDy5Svvgxs4D72Mg+carGZ+orze1Q8W9PWyigCUzvF7ZfBnUP rCdSyP0W1PDsVVTNrFQHEGYtdeOM5D8NSW2+QbDPsCKLOr2LNXGKkfLDxvYlXvJJbpCSz9ezCsm LxsCxT3CmAS/tLtgxpg67Q7dXL027Od0AcEsDTKjDVPjScTRF/V/lSoUE4oW8g8WoAMW57P4DIP W3fwRS5BQnkSGw02oItblT1jbZyQM4N51TBvg0/6ITLOO24JHqIKkoRqcTX8Tg/XV3ooSdr9Qf4 O0/T11CQa6Lnykm0WKQ== X-Proofpoint-ORIG-GUID: zz3cPwpVYNrvhj0cEAoUA1IOo6tpHKzB X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfX/nX4yfdU0E6i S7lgUPn3+17Vj3nl0E69dx7UBtWzl15hlzOhkwVMKD7lx2NOmC0wrpcEbxtfHrYlGzdimKD+izl jzLIAl5gBsAuwwoSAQu1VEapx1fZ8ss= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 priorityscore=1501 adultscore=0 bulkscore=0 malwarescore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786892007309158500 Keep cpus.c related to vCPU scheduling, move the QMP handlers related to dumping physical memory to file to their own unit. Fix a pair of checkpatch.pl errors doing so: ERROR: braces {} are necessary for all arms of this statement #185: FILE: system/physmem-qmp-cmds.c:51: + if (l > size) [...] Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau Message-Id: <20260812211708.92824-16-philmd@oss.qualcomm.com> --- MAINTAINERS | 1 + system/cpus.c | 92 -------------------------------- system/physmem-qmp-cmds.c | 107 ++++++++++++++++++++++++++++++++++++++ system/meson.build | 1 + 4 files changed, 109 insertions(+), 92 deletions(-) create mode 100644 system/physmem-qmp-cmds.c diff --git a/MAINTAINERS b/MAINTAINERS index bad65aeda50..b51f5c3e602 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3436,6 +3436,7 @@ F: system/ioport.c F: system/memory.c F: system/memory_mapping.c F: system/physmem.c +F: system/physmem-qmp-cmds.c F: system/memory_ldst* F: system/memory-internal.h F: system/ram-block-attributes.c diff --git a/system/cpus.c b/system/cpus.c index aa2510bf8fc..43ff10cf008 100644 --- a/system/cpus.c +++ b/system/cpus.c @@ -25,9 +25,7 @@ #include "qemu/osdep.h" #include "qemu/coroutine-tls.h" #include "qapi/error.h" -#include "qapi/qapi-commands-machine.h" #include "qapi/qapi-events-run-state.h" -#include "qapi/qmp/qerror.h" #include "exec/gdbstub.h" #include "accel/accel-cpu-ops.h" #include "system/hw_accel.h" @@ -40,7 +38,6 @@ #include "system/physmem.h" #include "system/replay.h" #include "system/runstate.h" -#include "migration/misc.h" #include "system/cpu-timers.h" #include "system/whpx.h" #include "hw/core/boards.h" @@ -831,92 +828,3 @@ int vm_stop_force_state(RunState state) return ret; } } - -void qmp_memsave(uint64_t addr, uint64_t size, const char *filename, - bool has_cpu, int64_t cpu_index, Error **errp) -{ - FILE *f; - uint64_t l; - CPUState *cpu; - uint8_t buf[1024]; - uint64_t orig_addr =3D addr, orig_size =3D size; - - if (migration_guest_ram_loading()) { - error_setg(errp, "Guest memory access not allowed during migration= "); - return; - } - - if (!has_cpu) { - cpu_index =3D 0; - } - - cpu =3D qemu_get_cpu(cpu_index); - if (cpu =3D=3D NULL) { - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "cpu-index", - "a CPU number"); - return; - } - - f =3D fopen(filename, "wb"); - if (!f) { - error_setg_file_open(errp, errno, filename); - return; - } - - while (size !=3D 0) { - l =3D sizeof(buf); - if (l > size) - l =3D size; - if (cpu_memory_rw_debug(cpu, addr, buf, l, 0) !=3D 0) { - error_setg(errp, "Invalid addr 0x%016" PRIx64 "/size %" PRIu64 - " specified", orig_addr, orig_size); - goto exit; - } - if (fwrite(buf, 1, l, f) !=3D l) { - error_setg(errp, "writing memory to '%s' failed", - filename); - goto exit; - } - addr +=3D l; - size -=3D l; - } - -exit: - fclose(f); -} - -void qmp_pmemsave(uint64_t addr, uint64_t size, const char *filename, - Error **errp) -{ - FILE *f; - uint64_t l; - uint8_t buf[1024]; - - if (migration_guest_ram_loading()) { - error_setg(errp, "Guest memory access not allowed during migration= "); - return; - } - - f =3D fopen(filename, "wb"); - if (!f) { - error_setg_file_open(errp, errno, filename); - return; - } - - while (size !=3D 0) { - l =3D sizeof(buf); - if (l > size) - l =3D size; - physical_memory_read(addr, buf, l); - if (fwrite(buf, 1, l, f) !=3D l) { - error_setg(errp, "writing memory to '%s' failed", - filename); - goto exit; - } - addr +=3D l; - size -=3D l; - } - -exit: - fclose(f); -} diff --git a/system/physmem-qmp-cmds.c b/system/physmem-qmp-cmds.c new file mode 100644 index 00000000000..d85430357d5 --- /dev/null +++ b/system/physmem-qmp-cmds.c @@ -0,0 +1,107 @@ +/* + * QMP commands to dump physical memory + * + * Copyright (c) 2003-2008 Fabrice Bellard + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include "qemu/osdep.h" +#include "qapi/error.h" +#include "qapi/qapi-commands-machine.h" +#include "qapi/qmp/qerror.h" +#include "hw/core/cpu.h" +#include "system/physmem.h" +#include "migration/misc.h" + +void qmp_memsave(uint64_t addr, uint64_t size, const char *filename, + bool has_cpu, int64_t cpu_index, Error **errp) +{ + FILE *f; + uint64_t l; + CPUState *cpu; + uint8_t buf[1024]; + uint64_t orig_addr =3D addr, orig_size =3D size; + + if (migration_guest_ram_loading()) { + error_setg(errp, "Guest memory access not allowed during migration= "); + return; + } + + if (!has_cpu) { + cpu_index =3D 0; + } + + cpu =3D qemu_get_cpu(cpu_index); + if (cpu =3D=3D NULL) { + error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "cpu-index", + "a CPU number"); + return; + } + + f =3D fopen(filename, "wb"); + if (!f) { + error_setg_file_open(errp, errno, filename); + return; + } + + while (size !=3D 0) { + l =3D sizeof(buf); + if (l > size) { + l =3D size; + } + if (cpu_memory_rw_debug(cpu, addr, buf, l, 0) !=3D 0) { + error_setg(errp, "Invalid addr 0x%016" PRIx64 "/size %" PRIu64 + " specified", orig_addr, orig_size); + goto exit; + } + if (fwrite(buf, 1, l, f) !=3D l) { + error_setg(errp, "writing memory to '%s' failed", + filename); + goto exit; + } + addr +=3D l; + size -=3D l; + } + +exit: + fclose(f); +} + +void qmp_pmemsave(uint64_t addr, uint64_t size, const char *filename, + Error **errp) +{ + FILE *f; + uint64_t l; + uint8_t buf[1024]; + + if (migration_guest_ram_loading()) { + error_setg(errp, "Guest memory access not allowed during migration= "); + return; + } + + f =3D fopen(filename, "wb"); + if (!f) { + error_setg_file_open(errp, errno, filename); + return; + } + + while (size !=3D 0) { + l =3D sizeof(buf); + if (l > size) { + l =3D size; + } + physical_memory_read(addr, buf, l); + if (fwrite(buf, 1, l, f) !=3D l) { + error_setg(errp, "writing memory to '%s' failed", + filename); + goto exit; + } + addr +=3D l; + size -=3D l; + } + +exit: + fclose(f); +} diff --git a/system/meson.build b/system/meson.build index 377adce8035..64e06e7abcc 100644 --- a/system/meson.build +++ b/system/meson.build @@ -19,6 +19,7 @@ system_ss.add(files( 'memory_mapping.c', 'memory.c', 'physmem.c', + 'physmem-qmp-cmds.c', 'qdev-monitor.c', 'qtest.c', 'rtc.c', --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786892013; cv=none; d=zohomail.com; s=zohoarc; b=G1rszOwAA5J9gPjbj7Hy5vI9+eYUtZpfH/5VaeTmTYcTcX8n03tG2q/Zu51tRbtfu3mUq0TIvAI3et5YM/WNmDUhKBFIvJYabu69oNMjJRJyThw159eG+6y0PVzMm9FzmJMmNc2a6t6GnHipjrl7OBbimhJuFrm/PHfop5yEOxA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786892013; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=y08fCN7Tzn5n0sn65TpnLdI9L9dwvew7wRgc5Ixvhf4=; b=A2LJpbV14X07jQ4WaP55FZK/nTFVtOAbUoqDjkPYDDsQv+kO7Rln5213KCsIoeShTIniWIltVaZ9K669S+w3dwHtj7QI5H2C09NbwxBwzQzi73pRSBClmeggQ/wTROYbvjWpWp/MoFq/GO9N9hiD5VocKT3NBk3tAkA8knnSk7I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786892013104458.11861911719814; Sun, 16 Aug 2026 07:53:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcEg-0002VU-AU; Sun, 16 Aug 2026 10:53:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcEd-0002OU-KL for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:53:16 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcEb-0002OR-Hk for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:53:15 -0400 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDlfU03215986 for ; Sun, 16 Aug 2026 14:53:12 GMT Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghfbngy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:53:12 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-9087f2fe592so13862506d6.0 for ; Sun, 16 Aug 2026 07:53:12 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49996108141sm47159255e9.6.2026.08.16.07.53.10 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:53:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= y08fCN7Tzn5n0sn65TpnLdI9L9dwvew7wRgc5Ixvhf4=; b=K4Y6015a+g0fPWKO q1m2uw3T1En8cLXqwSHbWsoPSvvJcnGbOjcna0jZEqpUJsujTVpg82C7e/98vloJ YawgBajJQJPzBG6wmljD5tUR9iFBp34Ef4jlOoCI3jdvwFsF6XQJsAdOj/7XOhDU orIM/absvwUb9gjh1ItO/ZDKcSINaBkJ54ZEHwCbtxQ/FzZF5t4G5RX3KWjB/4gk nl5g99n+lUzepikDAUIjKCadEYoqA0vYN94Ohg+p5rOxV0S6ivcIlOtt/L1UyG9U tGB3vInn2vv+mXZxbdx072u6/8q0hW804EG0MvdNUaiJCICow22ah8YnEUr8uC7P jCWuDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786891992; x=1787496792; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=y08fCN7Tzn5n0sn65TpnLdI9L9dwvew7wRgc5Ixvhf4=; b=HFicMqrUT4dPlC0gax03+9MYxjCYJ0Yv4EC8CoiMM3TAYDU7wmS5byAYgugnevQv33 0EUnk98aoOWPjUPsQDUehyOXSREnDmiqcZuHPvE7tJ9Gmd5hniH4yFkiqhtRgSPbe/O3 cjyVH1s0jTMBFdmcqfbwGetmqrihKWeBL6avWNgLMt4TPoRSEuXNYqK9cz70UOHXdGvk V8IM5tzeKaBZuT8nYu+7j2RznnFev58Y6ku9nZttAsoFBkY1etnY3QSprFaJrDaiCSRI CwRnDyQyaNoMGv1T5ttY1mXDoq8ygOkE8CB3TAOUyol49d3SMcKlAHLyZeCdy63+B3q7 qJWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786891992; x=1787496792; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=y08fCN7Tzn5n0sn65TpnLdI9L9dwvew7wRgc5Ixvhf4=; b=dXiOTAN0+nMQqS3rduJpT3K9nV4816TJf3OLYsuICLZO9jTrFKVQEbCMyTsznfUWSh EUr8U18gg4Wr4hVzEc41sRAXlgJI29LhIYZmmt8bD7MsM1+1Wp6BIA3vI2I7vQQyhio3 xsBHZGiuCa0VJuW3XkRiooPce9CsA56FjpPb8vv0gBbech7MzDHvUGeZk//GZYXxoOMH kWx1+YYrrzEhKA6Vwm3zUDOK2IpDTQ1xZvU0kUeMStKeFKrEHRGiSWPqFwRbL/KfKk4E bAW1h/25s/gyfoc5XA3ev3nit6SceAnfHSB3yql09Be+kw2mmQyVltP+17uvQhRcL23R J+2w== X-Gm-Message-State: AOJu0YwIs679Me61Pa0/Hm4Rz13u9j//3nY0ucl4Ha+jwkq7bD/bSG8z rhJYI4bzNrOwwCpQB0HpFj6GWg2qb9FaPArJcxH8Zc2WyVH0nRxVaFVGQbf0Hys+cU0a0qewWGc h+dGd4qPnDywQB0C1jBass7PNCShX/zbSUkcMGcdhH5uCyrRGUBZgxY3XzsQn0NEU3Q== X-Gm-Gg: AR+sD11Q7v9TLEKPt/Kd5YRyO4zq/lIdbbltyyYwssSTMr2cgSex54fcz48JhDi1tIs H8g42QCcP7P5a1g1PzEPbBsahSKPpY5cCA1AM4w/DQTIJl34VrWclhjFyhxYITo54N220MIecMX V3U/VA4NHEsVf+xtO2mQmfp8AJNLX3MlDtigkDJVlehWnye/06eYishldtjheeY+Fts0DPfvPar jzR/Ms1+hd4N9vinD5984BxFr7yUmU3aPeM2fUQwkHnwaw6gUTZEONWqb5959X/HJLO3ry3ukVT IadYVHShyZakuAKLw93nlc48qjWe2/sp9nxVkaKCnpJLYs9g+94D0cZ4EP2eUYOswk8PaYwTN3H d+Lqw/VSrF6dMcj+oZktLvtY4MAzhAYVELiN1cF8bpw== X-Received: by 2002:a05:622a:4c15:b0:51c:805:1be3 with SMTP id d75a77b69052e-52d8556685bmr229490351cf.31.1786891991867; Sun, 16 Aug 2026 07:53:11 -0700 (PDT) X-Received: by 2002:a05:622a:4c15:b0:51c:805:1be3 with SMTP id d75a77b69052e-52d8556685bmr229489681cf.31.1786891991260; Sun, 16 Aug 2026 07:53:11 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 51/56] system: Move runstate-related code from cpus.c to runstate.c Date: Sun, 16 Aug 2026 16:45:50 +0200 Message-ID: <20260816144556.69009-52-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfX0ftN0W+OTr+J NUvMN5XD7/0e3vAk2W2QqNKajeUe4p5Lvaci4BwpGAs+XrIdzYJGCKOR0nyccrL70pHgx41DpGk lRJItOTNK5A257IFZBOnur0SK/UtXcY= X-Proofpoint-ORIG-GUID: 9stavbOdDDbyAGDqydVIq08wECC3CSFD X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfX9Q2P4empzvKt PL/wXz/Qd4QFY7t1x7kSo+CmzQML0Ji86l3QaJKlbXVFJVLvicpbPVVI79YHmwd1qd/6KePu8lZ b3AvLAWLziYtUrfoOjYuuXvG0ViAdKN9juU69DQX1yZB/6gTrdPHnmaDknQI30Ks+W5ABwiMqPo s2u5FKivC0su05BiG7wsXfawF8dxIXe4GmR59YimNA6QBKtPZF1nKqgRgqHQ7/VLSTmJoDpebVb DZXQjuk3jJHr4sbAvpnoS2hI374yuaZwTVHT8oEMgE18ZUH0Yn8zk+lWQB4XjZU4TqpgP0KOxDy DXg2rmt1riJLLWdHHlxi28Kanb4hGL9pVuFsuQyiLKr+XtOEN4gD9re+chskLePBsYo/ABrPiY1 0Jdyrgq5A74K9hRWzShnBeigPBVyzgUG+np8smV0Vj7MgJL4U3FYOXLJ4WWGw486GolVwBoWfyF Qbe+2qT3Y0mnikXJQkw== X-Proofpoint-GUID: 9stavbOdDDbyAGDqydVIq08wECC3CSFD X-Authority-Analysis: v=2.4 cv=I/dVgtgg c=1 sm=1 tr=0 ts=6a81ced8 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=20KFwNOVAAAA:8 a=QK4PlI00PMcCPjLnJOMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 malwarescore=0 adultscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786892013353158501 Keep cpus.c focused on vCPUs handling, move code related to VM state to runstate.c where similar code lives. Fix few checkpatch.pl warnings: WARNING: Block comments use a leading /* on a separate line WARNING: Block comments use * on subsequent lines #327: FILE: system/runstate.c:541: +/* does a state transition even if the VM is already stopped, + current state is forgotten forever */ Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau Message-Id: <20260812211708.92824-17-philmd@oss.qualcomm.com> --- system/cpus.c | 147 ------------------------------------------- system/runstate.c | 154 ++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 154 insertions(+), 147 deletions(-) diff --git a/system/cpus.c b/system/cpus.c index 43ff10cf008..f37e215c586 100644 --- a/system/cpus.c +++ b/system/cpus.c @@ -25,7 +25,6 @@ #include "qemu/osdep.h" #include "qemu/coroutine-tls.h" #include "qapi/error.h" -#include "qapi/qapi-events-run-state.h" #include "exec/gdbstub.h" #include "accel/accel-cpu-ops.h" #include "system/hw_accel.h" @@ -272,58 +271,6 @@ void cpu_interrupt(CPUState *cpu, int mask) cpus_accel->handle_interrupt(cpu, mask); } =20 -/* - * True if the vm was previously suspended, and has not been woken or rese= t. - */ -static int vm_was_suspended; - -void vm_set_suspended(bool suspended) -{ - vm_was_suspended =3D suspended; -} - -bool vm_get_suspended(void) -{ - return vm_was_suspended; -} - -static int do_vm_stop(RunState state, bool send_stop) -{ - int ret =3D 0; - RunState oldstate =3D runstate_get(); - - if (runstate_is_live(oldstate)) { - vm_was_suspended =3D (oldstate =3D=3D RUN_STATE_SUSPENDED); - runstate_set(state); - cpu_disable_ticks(); - if (oldstate =3D=3D RUN_STATE_RUNNING) { - pause_all_vcpus(); - } - ret =3D vm_state_notify(0, state); - if (send_stop) { - qapi_event_send_stop(); - } - } - - bdrv_drain_all(); - /* - * Even if vm_state_notify() return failure, - * it would be better to flush as before. - */ - ret |=3D bdrv_flush_all(); - trace_vm_stop_flush_all(ret); - - return ret; -} - -/* Special vm_stop() variant for terminating the process. Historically cl= ients - * did not expect a QMP STOP event and so we need to retain compatibility. - */ -int vm_shutdown(void) -{ - return do_vm_stop(RUN_STATE_SHUTDOWN, false); -} - bool cpu_can_run(CPUState *cpu) { if (cpu->stop) { @@ -734,97 +681,3 @@ void cpu_stop_current(void) cpu_exit(current_cpu); } } - -int vm_stop(RunState state) -{ - if (qemu_in_vcpu_thread()) { - qemu_system_vmstop_request_prepare(); - qemu_system_vmstop_request(state); - /* - * FIXME: should not return to device code in case - * vm_stop() has been requested. - */ - cpu_stop_current(); - return 0; - } - - return do_vm_stop(state, true); -} - -/** - * Prepare for (re)starting the VM. - * Returns 0 if the vCPUs should be restarted, -1 on an error condition, - * and 1 otherwise. - */ -int vm_prepare_start(bool step_pending) -{ - int ret =3D vm_was_suspended ? 1 : 0; - RunState state =3D vm_was_suspended ? RUN_STATE_SUSPENDED : RUN_STATE_= RUNNING; - RunState requested; - - qemu_vmstop_requested(&requested); - if (runstate_is_running() && requested =3D=3D RUN_STATE__MAX) { - return -1; - } - - /* Ensure that a STOP/RESUME pair of events is emitted if a - * vmstop request was pending. The BLOCK_IO_ERROR event, for - * example, according to documentation is always followed by - * the STOP event. - */ - if (runstate_is_running()) { - qapi_event_send_stop(); - qapi_event_send_resume(); - return -1; - } - - /* - * WHPX accelerator needs to know whether we are going to step - * any CPUs, before starting the first one. - */ - accel_pre_resume(MACHINE(qdev_get_machine()), step_pending); - - /* We are sending this now, but the CPUs will be resumed shortly later= */ - qapi_event_send_resume(); - - cpu_enable_ticks(); - runstate_set(state); - vm_state_notify(1, state); - vm_was_suspended =3D false; - return ret; -} - -void vm_start(void) -{ - if (!vm_prepare_start(false)) { - resume_all_vcpus(); - } -} - -void vm_resume(RunState state) -{ - if (runstate_is_live(state)) { - vm_start(); - } else { - runstate_set(state); - } -} - -/* does a state transition even if the VM is already stopped, - current state is forgotten forever */ -int vm_stop_force_state(RunState state) -{ - if (runstate_is_live(runstate_get())) { - return vm_stop(state); - } else { - int ret; - runstate_set(state); - - bdrv_drain_all(); - /* Make sure to return an error if the flush in a previous vm_stop= () - * failed. */ - ret =3D bdrv_flush_all(); - trace_vm_stop_flush_all(ret); - return ret; - } -} diff --git a/system/runstate.c b/system/runstate.c index 08acf801b0e..d3e64d2b625 100644 --- a/system/runstate.c +++ b/system/runstate.c @@ -52,6 +52,7 @@ #include "qemu/thread.h" #include "qom/object.h" #include "qom/object_interfaces.h" +#include "system/cpu-timers.h" #include "system/cpus.h" #include "system/qtest.h" #include "system/replay.h" @@ -408,6 +409,159 @@ int vm_state_notify(bool running, RunState state) return ret; } =20 +/* + * True if the vm was previously suspended, and has not been woken or rese= t. + */ +static int vm_was_suspended; + +void vm_set_suspended(bool suspended) +{ + vm_was_suspended =3D suspended; +} + +bool vm_get_suspended(void) +{ + return vm_was_suspended; +} + +static int do_vm_stop(RunState state, bool send_stop) +{ + int ret =3D 0; + RunState oldstate =3D runstate_get(); + + if (runstate_is_live(oldstate)) { + vm_was_suspended =3D (oldstate =3D=3D RUN_STATE_SUSPENDED); + runstate_set(state); + cpu_disable_ticks(); + if (oldstate =3D=3D RUN_STATE_RUNNING) { + pause_all_vcpus(); + } + ret =3D vm_state_notify(0, state); + if (send_stop) { + qapi_event_send_stop(); + } + } + + bdrv_drain_all(); + /* + * Even if vm_state_notify() return failure, + * it would be better to flush as before. + */ + ret |=3D bdrv_flush_all(); + trace_vm_stop_flush_all(ret); + + return ret; +} + +/* + * Special vm_stop() variant for terminating the process. Historically cl= ients + * did not expect a QMP STOP event and so we need to retain compatibility. + */ +int vm_shutdown(void) +{ + return do_vm_stop(RUN_STATE_SHUTDOWN, false); +} + + +int vm_stop(RunState state) +{ + if (qemu_in_vcpu_thread()) { + qemu_system_vmstop_request_prepare(); + qemu_system_vmstop_request(state); + /* + * FIXME: should not return to device code in case + * vm_stop() has been requested. + */ + cpu_stop_current(); + return 0; + } + + return do_vm_stop(state, true); +} + +/** + * Prepare for (re)starting the VM. + * Returns 0 if the vCPUs should be restarted, -1 on an error condition, + * and 1 otherwise. + */ +int vm_prepare_start(bool step_pending) +{ + int ret =3D vm_was_suspended ? 1 : 0; + RunState state =3D vm_was_suspended ? RUN_STATE_SUSPENDED : RUN_STATE_= RUNNING; + RunState requested; + + qemu_vmstop_requested(&requested); + if (runstate_is_running() && requested =3D=3D RUN_STATE__MAX) { + return -1; + } + + /* + * Ensure that a STOP/RESUME pair of events is emitted if a + * vmstop request was pending. The BLOCK_IO_ERROR event, for + * example, according to documentation is always followed by + * the STOP event. + */ + if (runstate_is_running()) { + qapi_event_send_stop(); + qapi_event_send_resume(); + return -1; + } + + /* + * WHPX accelerator needs to know whether we are going to step + * any CPUs, before starting the first one. + */ + accel_pre_resume(MACHINE(qdev_get_machine()), step_pending); + + /* We are sending this now, but the CPUs will be resumed shortly later= */ + qapi_event_send_resume(); + + cpu_enable_ticks(); + runstate_set(state); + vm_state_notify(1, state); + vm_was_suspended =3D false; + return ret; +} + +void vm_start(void) +{ + if (!vm_prepare_start(false)) { + resume_all_vcpus(); + } +} + +void vm_resume(RunState state) +{ + if (runstate_is_live(state)) { + vm_start(); + } else { + runstate_set(state); + } +} + +/* + * does a state transition even if the VM is already stopped, + * current state is forgotten forever + */ +int vm_stop_force_state(RunState state) +{ + if (runstate_is_live(runstate_get())) { + return vm_stop(state); + } else { + int ret; + runstate_set(state); + + bdrv_drain_all(); + /* + * Make sure to return an error if the flush in a previous vm_stop= () + * failed. + */ + ret =3D bdrv_flush_all(); + trace_vm_stop_flush_all(ret); + return ret; + } +} + static ShutdownCause reset_requested; static ShutdownCause shutdown_requested; static int shutdown_exit_code =3D EXIT_SUCCESS; --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786892021; cv=none; d=zohomail.com; s=zohoarc; b=L+wqrjiNXfGMKNBlqtGlIPx+JbSi3Y/j3Tj0dBkz3EH7VC/eqwTfx5F3hM/p+lD6bnAjix/m3mIT8Ph8myyvwgtKohukHhMMtwMUrYs8vZQRjkDQI9kwdz2tVumALi0E+ZNlbfRXsVjD9NQ2dYNjMM2vZhloGwVcRxqP2Wlxl/Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786892021; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Wn16rRvE8n9RTiq0RjbJ1LnxMtKnPezXBKOnODR7kFo=; b=JJvRLCKnTRIHj5QDg9hzUMkn2ewXkQPNcGMB45XZ4sU4E2k1j7Pla9x0yGgpqUBIfyjJR6UVn9EgkQSqG0rl2WUcFxj+7moZCtHN/lU7WA0sM/VX56iuzauOcudiAyPV/p4DqOgvZCFVghdmpuBR3Ly5JVqnE423uvzq8utXzTM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786892021660535.4290110581023; Sun, 16 Aug 2026 07:53:41 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcEt-0002vC-8C; Sun, 16 Aug 2026 10:53:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcEr-0002t1-CN for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:53:29 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcEo-0002YO-RT for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:53:29 -0400 Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDkkBu2760247 for ; Sun, 16 Aug 2026 14:53:24 GMT Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2h9gkhd9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:53:24 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-526da7e3c9dso24415281cf.1 for ; Sun, 16 Aug 2026 07:53:24 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4999611bf65sm47974725e9.13.2026.08.16.07.53.20 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:53:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Wn16rRvE8n9RTiq0RjbJ1LnxMtKnPezXBKOnODR7kFo=; b=TMJBOXeYr+ZrcY2C MPPsaZxGeIf0EPvO3/wvMwWbgSMUjwD9PRHpYNmlUvxerOWQxOLEls4M7WQrUiY4 Kw+m+JpuLryo3BM57IQayfqdxbW4udGvYf77pK3ECQJXcv8HwgVsRhcG2ZL5wRb3 EBbfw/0+gh8jz+t82QAYt844jv7GyYQsiNoX+FUR0sqWy4rD/oyzKG6R3gWsi3ZL u0SAwlOVjyIY1Au+47HYO54zyn8YEeaAjJvYNH0QRhQ5mBvHkWJaEfwv55KqJb4V pwvahyEAk9zOFEaSa1Uq/pfKgrgKBRG6vssJh+OCF8comngVi1jJrwdIGBAzP9m3 qDUBZw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786892003; x=1787496803; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Wn16rRvE8n9RTiq0RjbJ1LnxMtKnPezXBKOnODR7kFo=; b=ZNabHEzPqWPjziOkYUtKuX6E5J9sSEdJqgAHUU5b+duJ20qj+7EVCoCuZIo5bD92Cx Mup3yaR7OgMRH6IJw9pehrCdn8YIXCCsm1IJPy4qVWEOK0ygdFquAT1cTdQCVzFMNu7Q +iUQDA0oLOPyng7jWw/9pFP7L+86umDIwChKW/fWnAi28OMjyti1T0lEPojSeXqJ0Upl tfUnDyRgxE7iJi8gDlqyIAkFgBAdeIrStAXP9MmQxVa//iAFazjOhmbrAmiVTX117cM7 3LHAREC3qA2ChZF5XPw4XWNkGZ8Ah5W7K+4CS/Jpy5lyZyQIulbi27p5RJiFOfrZtIAD 04OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786892003; x=1787496803; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Wn16rRvE8n9RTiq0RjbJ1LnxMtKnPezXBKOnODR7kFo=; b=cJ8Gc6sitysFzOh9oRh1jvhACUtJ1ucL27T/00Dc2EnUITrBkUHr8zZ8ugemBumz6E 6WHEiSfkXJyrkDtCPxVAabby0gslLvOafWvQ4MSwE0pyuYXXAXWrZ0qluUd5Rn3gYRYG GN2gbbRIwqsSRBGeplRAYeNsg88/gaPoLeSaUhAIpGGBPXDjumBPywDvztxjumJAhY0I lqZFAFKAkQkCBQlaRABmfrTG7h5MynVT4MJX+vTLliC3mAtTwoVI7beb9oKJ4iW8H/BH mxOny9ngCd1elj7ENwoiaZU4Z9w7OL7A955T3DrnLOI5bVOGvFnhdVcvCCZ039yMgRR4 FDWg== X-Gm-Message-State: AOJu0YwYAAd4stOx7pOptc3U46Aq1xvRH0Lz578gael6OhrILeXXVSXk Pn+mbVeXoJky3/vc12gKc1yiLK9mH/dbnfKSQ0lE8cQgBPSFMkHCgkugSxnbl/DiSoaxsW89/48 JnsrukIbkQemL7cS9ueRxTZC47hlvy/VlupbLtXYWy5ZYM6dIodW2BqSHJ314zzfgmg== X-Gm-Gg: AR+sD11TThMAqkaor4k7QHKb/0x82ejm5Dm/ijeqoss/teny6r9QAhrf8PTvckYMjW5 BIQcyOv/iKxrR/ZJ0BLom7oCl4SH0PKrSu4LUkKO1lBwPRUCdW6Kzm1nk5pZYWnQesGy+D9s0if U+mDGZ3z5IbIh5T/nFA4DARlpu70oohpif3zukO6vroCgt7pw7ZaJgvrHxtdH6Q5RenQJZ3P55U ZwlFLy8XfEzi031tctGUu1sjhMBs+h1iN9qlxFKTAVFuvYOiu6H+MnROSvO0e5h7Q9iNBe9Nlr9 XYBUAXpt33XrvvIedSvQZxndsBxuzZL1kXVsFgzrbJVAj8SvKg8huxsBDqcrKuhkcSslRspfVzL 13E2q4L4rR14x9LL/JHrXsQTgJzdMbu0y4dSjSZ3x0Q== X-Received: by 2002:ac8:7f8b:0:b0:51b:f40b:2fb3 with SMTP id d75a77b69052e-52d8530e04emr200706181cf.9.1786892002847; Sun, 16 Aug 2026 07:53:22 -0700 (PDT) X-Received: by 2002:ac8:7f8b:0:b0:51b:f40b:2fb3 with SMTP id d75a77b69052e-52d8530e04emr200705781cf.9.1786892002093; Sun, 16 Aug 2026 07:53:22 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 52/56] monitor: Rename MonitorHMP @mon -> @hmp Date: Sun, 16 Aug 2026 16:45:51 +0200 Message-ID: <20260816144556.69009-53-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: PvaX7efe37SlZ5nQau9FJfiakXyu7oiB X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfX3qb+iEoP/VrQ 7rA0YDNT0k/rYOzKwXjQYUw5ouL3RXeJuDvm7BqQV9DAiE+11TnXHYQm4bb+9tsLM2n4RDWeSoY ww2XCuZCBFppg7y0Lh5ABwnBg1EjtNU= X-Proofpoint-GUID: PvaX7efe37SlZ5nQau9FJfiakXyu7oiB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfX2H/2YCKBFeI3 vzIvJKatIAlu9JqgwVoFDRR2005Nbdkljzvih/qsM0GrPlsu59LgIr6wcFWuLwofTUoc/W4imeo g/ZeJL4uPuUzoygQ03ReiJhhzANzd9frbaeUUMbe1SvuVYRcG9J+Vit3ypEHV8ZSSunxolcnh9K zz4Dpayxohl0QQbgVHA+KY8gQl1laYTH97lRUAM9ut7v2C45h/D1PSIE1w7LDpQoJC3pb9YTUSi XW58/JCWw6dhTqRETJ87qVScsdUtIpbBu7q19rMV+NW00DC/spJEGiL7y61pxZ2TtaeNTBJbErI tPmnKhmYfDP/Eh2fVFXvqWQ7AdnhQrbXcqLm8on0enzjNcSpN19M8Zlti+4cjfJVUVa+CQldWvT T4Y3tPghYk+bHa/iVIlkjYKFJjPuWD0MuLNVpO2aPSUYirLkYk24cyImZHBW4jSVsR9HQRYAR1A X0gPxNMn/OvuyPRSjzQ== X-Authority-Analysis: v=2.4 cv=XM4AjwhE c=1 sm=1 tr=0 ts=6a81cee4 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=20KFwNOVAAAA:8 a=wEi9R27ph0kDrfoOIwAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 phishscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786892023359158500 Mechanical change to sanitize using the following patterns: MonitorQMP *qmp MonitorHMP *hmp Monitor *mon Rename @mon (and @hmp_mon) as @hmp when the type is MonitorHMP. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20260812211708.92824-19-philmd@oss.qualcomm.com> Acked-by: Marc-Andr=C3=A9 Lureau --- include/monitor/monitor.h | 4 +- monitor/monitor-internal.h | 2 +- monitor/hmp-cmds.c | 6 +- monitor/hmp.c | 135 +++++++++++++++++++------------------ ui/ui-hmp-cmds.c | 4 +- 5 files changed, 76 insertions(+), 75 deletions(-) diff --git a/include/monitor/monitor.h b/include/monitor/monitor.h index fd98ee2c71d..54134f2aa4f 100644 --- a/include/monitor/monitor.h +++ b/include/monitor/monitor.h @@ -55,8 +55,8 @@ void monitor_flush_locked(Monitor *mon); =20 void *gpa2hva(MemoryRegion **p_mr, hwaddr addr, uint64_t size, Error **err= p); =20 -void monitor_read_command(MonitorHMP *mon, int show_prompt); -int monitor_read_password(MonitorHMP *mon, ReadLineFunc *readline_func, +void monitor_read_command(MonitorHMP *hmp, int show_prompt); +int monitor_read_password(MonitorHMP *hmp, ReadLineFunc *readline_func, void *opaque); =20 AddfdInfo *monitor_fdset_add_fd(int fd, bool has_fdset_id, int64_t fdset_i= d, diff --git a/monitor/monitor-internal.h b/monitor/monitor-internal.h index bc0932c425a..e0a124a317a 100644 --- a/monitor/monitor-internal.h +++ b/monitor/monitor-internal.h @@ -221,7 +221,7 @@ void monitor_data_destroy_qmp(MonitorQMP *mon); void coroutine_fn monitor_qmp_dispatcher_co(void *data); void qmp_dispatcher_co_wake(void); =20 -void handle_hmp_command(MonitorHMP *mon, const char *cmdline); +void handle_hmp_command(MonitorHMP *hmp, const char *cmdline); int hmp_compare_cmd(const char *name, const char *list); =20 /* diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index e9fb8d827a0..bcd0a1fc878 100644 --- a/monitor/hmp-cmds.c +++ b/monitor/hmp-cmds.c @@ -290,16 +290,16 @@ void hmp_info_sync_profile(Monitor *mon, const QDict = *qdict) =20 void hmp_info_history(Monitor *mon, const QDict *qdict) { - MonitorHMP *hmp_mon =3D container_of(mon, MonitorHMP, parent_obj); + MonitorHMP *hmp =3D container_of(mon, MonitorHMP, parent_obj); int i; const char *str; =20 - if (!hmp_mon->rs) { + if (!hmp->rs) { return; } i =3D 0; for(;;) { - str =3D readline_get_history(hmp_mon->rs, i); + str =3D readline_get_history(hmp->rs, i); if (!str) { break; } diff --git a/monitor/hmp.c b/monitor/hmp.c index 71a18882491..cbf7a114c0c 100644 --- a/monitor/hmp.c +++ b/monitor/hmp.c @@ -49,24 +49,24 @@ OBJECT_DEFINE_TYPE(MonitorHMP, monitor_hmp, MONITOR_HMP= , MONITOR); =20 static void monitor_hmp_finalize(Object *obj) { - MonitorHMP *mon =3D MONITOR_HMP(obj); - if (mon->rs) { - readline_free(mon->rs); + MonitorHMP *hmp =3D MONITOR_HMP(obj); + if (hmp->rs) { + readline_free(hmp->rs); } } =20 static bool monitor_hmp_get_readline(Object *obj, Error **errp) { - MonitorHMP *mon =3D MONITOR_HMP(obj); + MonitorHMP *hmp =3D MONITOR_HMP(obj); =20 - return mon->use_readline; + return hmp->use_readline; } =20 static void monitor_hmp_set_readline(Object *obj, bool val, Error **errp) { - MonitorHMP *mon =3D MONITOR_HMP(obj); + MonitorHMP *hmp =3D MONITOR_HMP(obj); =20 - mon->use_readline =3D val; + hmp->use_readline =3D val; } =20 int monitor_hmp_vprintf(Monitor *mon, const char *fmt, va_list ap) @@ -128,34 +128,34 @@ static void monitor_hmp_accept_input(Monitor *mon) static void monitor_command_cb(void *opaque, const char *cmdline, void *readline_opaque) { - MonitorHMP *mon =3D opaque; + MonitorHMP *hmp =3D opaque; =20 - monitor_suspend(&mon->parent_obj); - handle_hmp_command(mon, cmdline); - monitor_resume(&mon->parent_obj); + monitor_suspend(&hmp->parent_obj); + handle_hmp_command(hmp, cmdline); + monitor_resume(&hmp->parent_obj); } =20 -void monitor_read_command(MonitorHMP *mon, int show_prompt) +void monitor_read_command(MonitorHMP *hmp, int show_prompt) { - if (!mon->rs) { + if (!hmp->rs) { return; } =20 - readline_start(mon->rs, "(qemu) ", 0, monitor_command_cb, NULL); + readline_start(hmp->rs, "(qemu) ", 0, monitor_command_cb, NULL); if (show_prompt) { - readline_show_prompt(mon->rs); + readline_show_prompt(hmp->rs); } } =20 -int monitor_read_password(MonitorHMP *mon, ReadLineFunc *readline_func, +int monitor_read_password(MonitorHMP *hmp, ReadLineFunc *readline_func, void *opaque) { - if (mon->rs) { - readline_start(mon->rs, "Password: ", 1, readline_func, opaque); + if (hmp->rs) { + readline_start(hmp->rs, "Password: ", 1, readline_func, opaque); /* prompt is printed on return from the command handler */ return 0; } else { - monitor_printf(&mon->parent_obj, + monitor_printf(&hmp->parent_obj, "terminal does not support password prompting\n"); return -ENOTTY; } @@ -772,12 +772,12 @@ static const HMPCommand *search_dispatch_table(const = HMPCommand *disp_table, * Do not assume the return value points into @table! It doesn't when * the command is found in a sub-command table. */ -static const HMPCommand *monitor_parse_command(MonitorHMP *hmp_mon, +static const HMPCommand *monitor_parse_command(MonitorHMP *hmp, const char *cmdp_start, const char **cmdp, HMPCommand *table) { - Monitor *mon =3D &hmp_mon->parent_obj; + Monitor *mon =3D &hmp->parent_obj; const char *p; const HMPCommand *cmd; char cmdname[256]; @@ -809,7 +809,7 @@ static const HMPCommand *monitor_parse_command(MonitorH= MP *hmp_mon, *cmdp =3D p; /* search sub command */ if (cmd->sub_table !=3D NULL && *p !=3D '\0') { - return monitor_parse_command(hmp_mon, cmdp_start, cmdp, cmd->sub_t= able); + return monitor_parse_command(hmp, cmdp_start, cmdp, cmd->sub_table= ); } =20 return cmd; @@ -1254,15 +1254,15 @@ static void handle_hmp_command_co(void *opaque) data->done =3D true; } =20 -void handle_hmp_command(MonitorHMP *mon, const char *cmdline) +void handle_hmp_command(MonitorHMP *hmp, const char *cmdline) { QDict *qdict; const HMPCommand *cmd; const char *cmd_start =3D cmdline; =20 - trace_handle_hmp_command(mon, cmdline); + trace_handle_hmp_command(hmp, cmdline); =20 - cmd =3D monitor_parse_command(mon, cmdline, &cmdline, + cmd =3D monitor_parse_command(hmp, cmdline, &cmdline, hmp_cmds_for_target(false)); if (!cmd) { return; @@ -1270,17 +1270,17 @@ void handle_hmp_command(MonitorHMP *mon, const char= *cmdline) =20 if (!cmd->cmd && !cmd->cmd_info_hrt) { /* FIXME: is it useful to try autoload modules here ??? */ - monitor_printf(&mon->parent_obj, "Command \"%.*s\" is not availabl= e.\n", + monitor_printf(&hmp->parent_obj, "Command \"%.*s\" is not availabl= e.\n", (int)(cmdline - cmd_start), cmd_start); return; } =20 - qdict =3D monitor_parse_arguments(&mon->parent_obj, &cmdline, cmd); + qdict =3D monitor_parse_arguments(&hmp->parent_obj, &cmdline, cmd); if (!qdict) { while (cmdline > cmd_start && qemu_isspace(cmdline[-1])) { cmdline--; } - monitor_printf(&mon->parent_obj, + monitor_printf(&hmp->parent_obj, "Try \"help %.*s\" for more information\n", (int)(cmdline - cmd_start), cmd_start); return; @@ -1289,18 +1289,18 @@ void handle_hmp_command(MonitorHMP *mon, const char= *cmdline) if (!cmd->coroutine) { /* old_mon is non-NULL when called from qmp_human_monitor_command(= ) */ Monitor *old_mon =3D monitor_set_cur(qemu_coroutine_self(), - &mon->parent_obj); - handle_hmp_command_exec(&mon->parent_obj, cmd, qdict); + &hmp->parent_obj); + handle_hmp_command_exec(&hmp->parent_obj, cmd, qdict); monitor_set_cur(qemu_coroutine_self(), old_mon); } else { HandleHmpCommandCo data =3D { - .mon =3D &mon->parent_obj, + .mon =3D &hmp->parent_obj, .cmd =3D cmd, .qdict =3D qdict, .done =3D false, }; Coroutine *co =3D qemu_coroutine_create(handle_hmp_command_co, &da= ta); - monitor_set_cur(co, &mon->parent_obj); + monitor_set_cur(co, &hmp->parent_obj); aio_co_enter(qemu_get_aio_context(), co); AIO_WAIT_WHILE_UNLOCKED(NULL, !data.done); } @@ -1308,7 +1308,8 @@ void handle_hmp_command(MonitorHMP *mon, const char *= cmdline) qobject_unref(qdict); } =20 -static void cmd_completion(MonitorHMP *mon, const char *name, const char *= list) +static void cmd_completion(MonitorHMP *hmp, + const char *name, const char *list) { const char *p, *pstart; char cmd[128]; @@ -1324,7 +1325,7 @@ static void cmd_completion(MonitorHMP *mon, const cha= r *name, const char *list) } memcpy(cmd, pstart, len); cmd[len] =3D '\0'; - readline_add_completion_of(mon->rs, name, cmd); + readline_add_completion_of(hmp->rs, name, cmd); if (*p =3D=3D '\0') { break; } @@ -1332,7 +1333,7 @@ static void cmd_completion(MonitorHMP *mon, const cha= r *name, const char *list) } } =20 -static void file_completion(MonitorHMP *mon, const char *input) +static void file_completion(MonitorHMP *hmp, const char *input) { DIR *ffs; struct dirent *d; @@ -1384,7 +1385,7 @@ static void file_completion(MonitorHMP *mon, const ch= ar *input) if (stat(file, &sb) =3D=3D 0 && S_ISDIR(sb.st_mode)) { pstrcat(file, sizeof(file), "/"); } - readline_add_completion(mon->rs, file); + readline_add_completion(hmp->rs, file); } } closedir(ffs); @@ -1396,7 +1397,7 @@ static const char *next_arg_type(const char *typestr) return (p !=3D NULL ? ++p : typestr); } =20 -static void monitor_find_completion_by_table(MonitorHMP *mon, +static void monitor_find_completion_by_table(MonitorHMP *hmp, const HMPCommand *cmd_table, char **args, int nb_args) @@ -1414,10 +1415,10 @@ static void monitor_find_completion_by_table(Monito= rHMP *mon, } else { cmdname =3D args[0]; } - readline_set_completion_index(mon->rs, strlen(cmdname)); + readline_set_completion_index(hmp->rs, strlen(cmdname)); for (cmd =3D cmd_table; cmd->name !=3D NULL; cmd++) { if (cmd_available(cmd)) { - cmd_completion(mon, cmdname, cmd->name); + cmd_completion(hmp, cmdname, cmd->name); } } } else { @@ -1434,12 +1435,12 @@ static void monitor_find_completion_by_table(Monito= rHMP *mon, =20 if (cmd->sub_table) { /* do the job again */ - monitor_find_completion_by_table(mon, cmd->sub_table, + monitor_find_completion_by_table(hmp, cmd->sub_table, &args[1], nb_args - 1); return; } if (cmd->command_completion) { - cmd->command_completion(mon->rs, nb_args, args[nb_args - 1]); + cmd->command_completion(hmp->rs, nb_args, args[nb_args - 1]); return; } =20 @@ -1461,20 +1462,20 @@ static void monitor_find_completion_by_table(Monito= rHMP *mon, switch (*ptype) { case 'F': /* file completion */ - readline_set_completion_index(mon->rs, strlen(str)); - file_completion(mon, str); + readline_set_completion_index(hmp->rs, strlen(str)); + file_completion(hmp, str); break; case 'B': /* block device name completion */ - readline_set_completion_index(mon->rs, strlen(str)); + readline_set_completion_index(hmp->rs, strlen(str)); while ((blk =3D blk_next(blk)) !=3D NULL) { - readline_add_completion_of(mon->rs, str, blk_name(blk)); + readline_add_completion_of(hmp->rs, str, blk_name(blk)); } break; case 's': case 'S': if (!strcmp(cmd->name, "help|?")) { - monitor_find_completion_by_table(mon, cmd_table, + monitor_find_completion_by_table(hmp, cmd_table, &args[1], nb_args - 1); } break; @@ -1487,7 +1488,7 @@ static void monitor_find_completion_by_table(MonitorH= MP *mon, static void monitor_find_completion(void *opaque, const char *cmdline) { - MonitorHMP *mon =3D opaque; + MonitorHMP *hmp =3D opaque; char *args[MAX_ARGS]; int nb_args, len; =20 @@ -1509,7 +1510,7 @@ static void monitor_find_completion(void *opaque, } =20 /* 2. auto complete according to args */ - monitor_find_completion_by_table(mon, hmp_cmds_for_target(false), + monitor_find_completion_by_table(hmp, hmp_cmds_for_target(false), args, nb_args); =20 cleanup: @@ -1518,18 +1519,18 @@ cleanup: =20 static void monitor_read(void *opaque, const uint8_t *buf, int size) { - MonitorHMP *mon =3D container_of(opaque, MonitorHMP, parent_obj); + MonitorHMP *hmp =3D container_of(opaque, MonitorHMP, parent_obj); int i; =20 - if (mon->rs) { + if (hmp->rs) { for (i =3D 0; i < size; i++) { - readline_handle_byte(mon->rs, buf[i]); + readline_handle_byte(hmp->rs, buf[i]); } } else { if (size =3D=3D 0 || buf[size - 1] !=3D 0) { - monitor_printf(&mon->parent_obj, "corrupted command\n"); + monitor_printf(&hmp->parent_obj, "corrupted command\n"); } else { - handle_hmp_command(mon, (char *)buf); + handle_hmp_command(hmp, (char *)buf); } } } @@ -1598,17 +1599,17 @@ static void monitor_event(void *opaque, QEMUChrEven= t event) static void G_GNUC_PRINTF(2, 3) monitor_readline_printf(void *opaque, const char *fmt, ..= .) { - MonitorHMP *mon =3D opaque; + MonitorHMP *hmp =3D opaque; va_list ap; va_start(ap, fmt); - monitor_vprintf(&mon->parent_obj, fmt, ap); + monitor_vprintf(&hmp->parent_obj, fmt, ap); va_end(ap); } =20 static void monitor_readline_flush(void *opaque) { - MonitorHMP *mon =3D opaque; - monitor_flush(&mon->parent_obj); + MonitorHMP *hmp =3D opaque; + monitor_flush(&hmp->parent_obj); } =20 void monitor_new_hmp(const char *id, const char *chardev_id, @@ -1626,11 +1627,11 @@ void monitor_new_hmp(const char *id, const char *ch= ardev_id, =20 static void monitor_hmp_complete(UserCreatable *uc, Error **errp) { - MonitorHMP *mon =3D MONITOR_HMP(uc); + MonitorHMP *hmp =3D MONITOR_HMP(uc); UserCreatableClass *ucc_parent =3D USER_CREATABLE_CLASS( object_class_get_parent( - OBJECT_CLASS(MONITOR_HMP_GET_CLASS(mon)))); + OBJECT_CLASS(MONITOR_HMP_GET_CLASS(hmp)))); ERRP_GUARD(); =20 ucc_parent->complete(uc, errp); @@ -1638,21 +1639,21 @@ static void monitor_hmp_complete(UserCreatable *uc,= Error **errp) return; } =20 - if (mon->parent_obj.chardev_id) { - if (mon->use_readline) { - mon->rs =3D readline_init(monitor_readline_printf, + if (hmp->parent_obj.chardev_id) { + if (hmp->use_readline) { + hmp->rs =3D readline_init(monitor_readline_printf, monitor_readline_flush, - mon, + hmp, monitor_find_completion); - monitor_read_command(mon, 0); + monitor_read_command(hmp, 0); } =20 - qemu_chr_fe_set_handlers(&mon->parent_obj.chr, + qemu_chr_fe_set_handlers(&hmp->parent_obj.chr, monitor_can_read, monitor_read, monitor_event, NULL, - &mon->parent_obj, NULL, true); - monitor_list_append(&mon->parent_obj); + &hmp->parent_obj, NULL, true); + monitor_list_append(&hmp->parent_obj); } } =20 diff --git a/ui/ui-hmp-cmds.c b/ui/ui-hmp-cmds.c index 06f4030ce4f..24cf3a67104 100644 --- a/ui/ui-hmp-cmds.c +++ b/ui/ui-hmp-cmds.c @@ -343,8 +343,8 @@ void hmp_change_vnc(Monitor *mon, const char *device, c= onst char *target, return; } if (!arg) { - MonitorHMP *hmp_mon =3D container_of(mon, MonitorHMP, parent_obj); - monitor_read_password(hmp_mon, hmp_change_read_arg, NULL); + MonitorHMP *hmp =3D container_of(mon, MonitorHMP, parent_obj); + monitor_read_password(hmp, hmp_change_read_arg, NULL); } else { qmp_change_vnc_password(arg, errp); } --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786892031; cv=none; d=zohomail.com; s=zohoarc; b=lB600tCdLzIEYdLd0Hm5tfA72hpDqjdAJS8qKCB9jJzKEtVzZzsue0JuYopqTQeNATpS6AD9o3PXBGksxkoCAyv40QiCU88ekxQJJsAsA6Mrifj1/QmgmZpMZa32wrTpVS6iedyRonQeIbb4eiUZJ4P9tJ4xuHdj4QFhlseov4Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786892031; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=G6z1n/xvrQOL+ylmbf2cH/3jRtJrUXQKyzDy2Pqxz48=; b=INgnZ+Q5nY1G2PWBKxAPqe2vTr2EUI5KjC8FwdrPiL7VsVCqYIqrxzoqYIlK9tialGh/xss07Z4C2WvXJNM6gfOq4MKCujRKY0aN4HUitvJNLH91MjfGJ2K2MT0/qQuIcyIOF8HBg6jMctO1koLN0EpmKKODsuI++fjHGMDzDCw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786892031339389.40335093830845; Sun, 16 Aug 2026 07:53:51 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcEx-00033I-Mn; Sun, 16 Aug 2026 10:53:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcEv-000309-Uf for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:53:33 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcEt-0002Yo-VR for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:53:33 -0400 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDm7kU3611749 for ; Sun, 16 Aug 2026 14:53:30 GMT Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghfukad-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:53:30 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51bf321d786so37015541cf.1 for ; Sun, 16 Aug 2026 07:53:30 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49981e54b31sm135796695e9.4.2026.08.16.07.53.28 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:53:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= G6z1n/xvrQOL+ylmbf2cH/3jRtJrUXQKyzDy2Pqxz48=; b=n5gJmpm1fB5hc8GE Ex9EV6ckhSbricK/zL25Qtf1dbSzU4T0/1+3kuPhVIqjPvVVt2g45W2tt+jbPodq w/OY1SUJdx/hybVVC6+KeHYREK/iav5G45i0lqpBHn5TLye5ey0vR8mf8ijwGvys kuIhOHtQqancACk7ozPjp9c7K64djfTj3Z2QOU/FGCXwLNlTOKeLo0cwNneek/wx gFUAI30uGl5r8Mu6oIJj3zNaZS+U0k4OtBUSwrBmqnXPKdKq5Yp1MBbwarpjE5UJ 77fte/jZYpYmQPDFxnKJzEFgaZMDe4pEOkfkRyBJqirVEcEYo1wIAN8rJmiZhu5f VDvvXw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786892009; x=1787496809; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=G6z1n/xvrQOL+ylmbf2cH/3jRtJrUXQKyzDy2Pqxz48=; b=PJmJH3uDet+tQ/m3It07+ToPLszKmHuGlX66s3toNYTKjYOw+MoIIsg1p5nJYl1RvD i0rdR4F8LcfsMkolMhkFhokEQtzv1bZAWS97xmZTmd51yHGBnPfCAIO63BuxFGgIZc+N KRIfkczIJXevsUUTts+N4dpyNYMbMzRb3ZKxyV65rdRrI8zU256W105At0LRoud2+uWQ M+wQ4f5CIJJhH/nl5qoWvMQ56Be6IVon0NJgEI2kHfliB3G4xgfL8nnnc9CrriWJg1bZ aes+iwP0QvkOUh/DeorMQriVE2gX2M2Ds5gARf6gJlTwc7/Csu2+nJYTMwHyJ/EtTack tC6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786892009; x=1787496809; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=G6z1n/xvrQOL+ylmbf2cH/3jRtJrUXQKyzDy2Pqxz48=; b=cKlpf+wjZ7V0SJiQUNX0Pf7sUYDkaz7dSKsf1AIqhOWiDNVF61NXToT3lJqm9/QYpC RUxlI1P3eOhOV6Uwzx9PVfAkJpEjR9P79LpwuHRxo97kO1Wtt6VisnOoZ4tzL0AiaWNY QqKi2dobNeM1nZ/Tdjiw9x7Tgs5Bd9IHVLiYAdIIcvgwegDCqsVq80eO6XoBEaoOCGRX FVvqKYI36EOVkn8zaVGnw6GG43R4dn4uwvP5upV6iZ4LA48s5mx+NaXHcnH4P6UdQ38M y9I4SgVRA3TVyE2AqqbwlylKgksycE6bunt7HymGTH365mRC4z1tkgnekQllM/iEouD7 9ifg== X-Gm-Message-State: AOJu0Yxzfl9rsPP5X7B/OVtMPneZ2kLO1r0YGwPvHTWILs47wqV/vpES yuAWefOKyj7sCGjwaVlBxViJe+F7zwh+usHAquoHRgxEXcAUG3a4Uv7EXPLHsjUeAPmwm7JITxA SQ6etD5G8Gmp5HsDpofD8+Hd/v2nYbAAIp3h9/jNhEhVuFNm5QtALoFv6XJN21JzLGw== X-Gm-Gg: AR+sD11OLQdIfpzy7IF03jZ05O8MtDb543AgvmnPjdYrDCbSs9kO1xjuxsQ/vXcuXQ1 41RCR8JwJMLGk6o4ZdYd+hIkBhOnvmM3qi/AE5937MsukX01+qVsH+OB1Iix6mBWS4zCpO9ccpq XT25zEy4c60A6O4YLDSayHz8VKBxBd6eijoN+0Ac1gEb+nMhdoAQXIWvEPLY6JmnhAFi81ykOFj wHkAgHWj8U+ndl1NUkkHpfVMfj1djOlp+YJQp8wJDQ0/LCJeZUMifybpSydt0UVAcv1vQSGOhzC EuNJ/2E/5EY3C//fMohZ5Gm5bbGrloKQa9Im5HmAW7C1O6/98yL+PgQDFTxwVrilO/CuRkW/0+8 SfnGKnEuuFFBwHNurNsf7ngSx/8oE2IPFEFtyWHqcTQ== X-Received: by 2002:ac8:59c3:0:b0:52d:6afd:7d9c with SMTP id d75a77b69052e-52d8547d028mr209403651cf.29.1786892009498; Sun, 16 Aug 2026 07:53:29 -0700 (PDT) X-Received: by 2002:ac8:59c3:0:b0:52d:6afd:7d9c with SMTP id d75a77b69052e-52d8547d028mr209403201cf.29.1786892008980; Sun, 16 Aug 2026 07:53:28 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 53/56] monitor: Better express monitor_read()'s opaque arg is of Monitor type Date: Sun, 16 Aug 2026 16:45:52 +0200 Message-ID: <20260816144556.69009-54-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfXxzTHHIPDOMNo VlLMXqfoUjsStKmDuLRStGOSYIM01XOhNM74/btAIa5rLvAMVuNWodn3akR5eYHqbzLUrR2smmx osViOSIdeaePTGbEisreo2wTsqeN7lw= X-Proofpoint-ORIG-GUID: Qn16w8XnMw2BXVANYix8xgZDkRj4GD82 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfX0hDMN2bphy9J Yup6PGtyJaJfSbkmx8rYk2ajvr/89f5EgbHV4MLtGFx4j+xUyfl6R04V/OxgVyYf1t2mhZx2caG NOal0h4N1UOuQWY8ydfT6no+VpS5oHR7fCxtQcXRANPhHMIBG2oCQaukTCV5+mvkC/eLh4+IduX BiRAXFGODEp1mmYMOxA/xAaWpPvYVahV4BEZkCbFwHWA9aPOm1P9vER8rElV2kzuTucXfuML9AU RY9PTiiRjV6h4eqL2/OKAsmZkGVKj6WuPIIsPYUrZ6Ig/ogn6WiRGtP2rLGrfsgSGtCFfW4pJDv OFQeSo0r8eZBEAMl70qxl5syMTZPidulINWaVo1acJlAVADSY5NgfrNwoNxJzcSaernLx7oEn/P kPFIZVgsPjh+pma3ky7FjYKK4gdAl5RDmaL+bcsJup1jHuJZ+uQaIXIKRITGgRcKeUPpif81gsz dHaAZSGUcVBieoAWhSw== X-Authority-Analysis: v=2.4 cv=TMJ1jVla c=1 sm=1 tr=0 ts=6a81ceea cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=20KFwNOVAAAA:8 a=hs6llZlkumWZFO0I0y4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: Qn16w8XnMw2BXVANYix8xgZDkRj4GD82 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 phishscore=0 clxscore=1015 bulkscore=0 spamscore=0 suspectscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786892033290158500 monitor_read() is a IOReadHandler handler, called by qemu_chr_fe_set_handlers() with a Monitor* opaque argument. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau Message-Id: <20260812211708.92824-20-philmd@oss.qualcomm.com> --- monitor/hmp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/monitor/hmp.c b/monitor/hmp.c index cbf7a114c0c..46f8d4a6ede 100644 --- a/monitor/hmp.c +++ b/monitor/hmp.c @@ -1519,7 +1519,8 @@ cleanup: =20 static void monitor_read(void *opaque, const uint8_t *buf, int size) { - MonitorHMP *hmp =3D container_of(opaque, MonitorHMP, parent_obj); + Monitor *mon =3D opaque; + MonitorHMP *hmp =3D container_of(mon, MonitorHMP, parent_obj); int i; =20 if (hmp->rs) { --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786892026; cv=none; d=zohomail.com; s=zohoarc; b=k7rl+q0B1EyBqWHoQcJYlG82HgFEpJK4xJqWekmfBiM2YEoeV/hFNXHeHcCaf8UOdnIHNQKw3UD0mli/xJL2t7YGi2+l/gaoLe6Jy5828Tv4NA6330TPFknCLXZ/PUL3P+l/TaTXdq4KXx8sCvEUvay4eUHkAFW77IDETI2qZlI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786892026; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=PE/JZHUx/aOfGfcCK0a/H5DxkVxffzTXH8TBVthfIy4=; b=npa3DRmIPsKO0TNSGyp5REN7xbz0YitKE7LJZvunSvrUEz6ZghMQBmsTuzCg/UK2l86Of/sTMPWl3bHHtAIGi0USMi4V3ZZWofcBJx3PwxA83YIxzJe2FmAbSUUyZSHJL7S8SLAII7ofo3wV/g4sVcFaV6FoS1wD0fNDhoDoFas= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786892026810832.2784505587406; Sun, 16 Aug 2026 07:53:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcF2-0003Hg-Tc; Sun, 16 Aug 2026 10:53:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcF1-00039Y-8x for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:53:39 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcEz-0002ZZ-NF for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:53:39 -0400 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDl3fr3951098 for ; Sun, 16 Aug 2026 14:53:36 GMT Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghnumkh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:53:36 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c1b4d961dso23460861cf.1 for ; Sun, 16 Aug 2026 07:53:36 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499961098cdsm66904775e9.6.2026.08.16.07.53.34 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:53:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PE/JZHUx/aOfGfcCK0a/H5DxkVxffzTXH8TBVthfIy4=; b=AKNZQXzuNWcpIR6Q byQbuuAC6Lh4HDB+dahQhUhVxdqNYWR0U26OGWGdtWMkDh1bpASkZ3tgBemBx65w iZ25Rp05fXwlGJl2xm30qBdQ5X7w0wSV9tEvY/reA9nU6tz24INukDpEGPF58Qew rJjC1ltUC0IoEiO+fVzY5XmspIJnI7h8jqaxvAmgEfWr8wnSrGEAmcH4jfyLGgNL rmgEDmtCzTvCoPtTADxGVFj5c19kyWIl0Ywnbdqeo7c2ZtcPTdvpGJ5aMx5fI5qI Lmyc84G5gyVzHoJrY2ilr3IaMaU/940yBlL6uLbKh0Btnu8esTp6MHpPGq8sD+q7 RLKsXA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786892016; x=1787496816; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PE/JZHUx/aOfGfcCK0a/H5DxkVxffzTXH8TBVthfIy4=; b=RypVkLD4EutEnkFCx585AeJ+jfoFNh/E+qazrGcqIG8Xx/lAfMJZtYSzNaDSL16pHR DLcnleLm/A8IKDiUErWgqtKaKvgJKFoW1QTyAvuC1tPHcNhgMm6zprV+aIgusOloCa7j qiUWL0rvtF/fuzGSZhhMnWMpt1UfauOAsKZRwfsovBU4h7/p4Tg1bT6EoC0jJ/Sw1Na+ oVUoTssloBbHcN/iWcgJhjtjSu+GM4Jswed4gLM5VFuNi4VdhZFZU058PxEIooKCICtk pYf9WNQ4sEIOgKbyI8/TDJr4vrpFrlZVFsvgueDhcUe5NarACAqyW0a7Mak7LmrEMeqz wI8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786892016; x=1787496816; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=PE/JZHUx/aOfGfcCK0a/H5DxkVxffzTXH8TBVthfIy4=; b=kx5tAv6hR2Ee62mkAE6cnRI+uznxOWL+j4H599ozDzDaWVOSMK01Fq4aE7bYQKAw8K ZhPvYz0/TJovYuj1KZw3AnEtHeJDQsD3eVljTBUFViyxNEDUSrniF7/utpq6+f+E7XLO pTh0oskafKCTadQOOvIy46iVGmtqzwSPOC56KPxLbQ1RECas+BJAxL8Mxs+7ho6SAGfz WzRAXxtLqSjun3fWYvAlvRM61c7E3HXNlYM1zmADkywIyOGKK578vzS1mYfCGbAwHraO RFJBUo9oHzeOpz2JPOTUHpp1EinS8SuT4q/PKAhfzE4iTZpuAXnrtMl3bItov9S9tk0x odNg== X-Gm-Message-State: AOJu0YygWvU1wCSoQ7BQWI4ONBY5czm2tHvUzzOOqmcuD5l2AE5wNdbg KS+pPdFgDhyinL28rJUrGY1JLV/67eoTmPSWlyZHMbj0INPhjmmOPXOo6FTYJFaLNajEfqxlraQ zIqByuevorS/joFRcq27v3SrxjHtsl7XJUFgOlhqj/In8/EgIH65UjcjnofTZApNbJQ== X-Gm-Gg: AR+sD10Fbphx5SphxCGrW5tfVFD6j0zeMArItyBf6wUuo4kRHCW9P4Gcbg/mGNYBbX+ 5JC1kUvTtm2Jz82XjMp3c7wOramdjrr4I9R+eMAoRvg5qpz94w6OaqakPREq/1a8lCtpBS7ASbl 34WQxORKP/rK/ITgRUYx3akyuWr1kCiVCFPgbPrPkBDrV84RoIiCQCXs5wxKMQlyX+MnO+ZaVKx 6PGYutwJyBAsMcFX8yesqB/z6wIfqwAHnf2eQS2Qtx/EC+TCvVmzrz8nu9KvRZEz9eII9hd1t+h UFPsCK4dDM3teQOCuq+P8tPogRwvyZAt5lVR4lJlvyOWZaKBYgir9Pqp9yW3G3lAVSwqDSY1nMs TJCn78lYAQi+oPhkU+ET88oJoVgcJeyLfNNJZcr8Ywg== X-Received: by 2002:a05:622a:250a:b0:517:c65c:4987 with SMTP id d75a77b69052e-52d74baa1femr319301281cf.22.1786892016182; Sun, 16 Aug 2026 07:53:36 -0700 (PDT) X-Received: by 2002:a05:622a:250a:b0:517:c65c:4987 with SMTP id d75a77b69052e-52d74baa1femr319301021cf.22.1786892015740; Sun, 16 Aug 2026 07:53:35 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 54/56] monitor: Replace container_of(MonitorHMP, parent_obj) -> MONITOR_HMP() Date: Sun, 16 Aug 2026 16:45:53 +0200 Message-ID: <20260816144556.69009-55-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfX6K+Yfb2A1nLh OCTZmn5YuEaEavPdNv8HqJ9BLmVXm1gbe8CEdJGTTdgV9b27Eqc5A/OAiwvdbXTy459K/ZbLynn TLowTDUebGQaCXddkTSpgdqUorM6Pc0VNbmzSsdxQKmwN+KIfyIl93nBrdu+Mmw2xz5mEVErzE6 TRcPEvwGIR+LQ3HCpBonux6fRjPTVy6Y1+L+GsHP+YjrC6f1B/nweMujs1MY9fI2ysjYBfL1ToU rQiNcMo7rWAAsNLSvmjp8G7+RdwSYFWS+/FT5g59es9MlwGf1X1jDrwWKG/p5P0sgVezuPL6ja+ /grdPs2wMI+PSLZyKOjIsWvbFPCRKmOyISGdgWTG5P9TebkbWoVt3ascj96PDEZrHrKIefR3qA/ Rsz7+ZF1eZXuNP6UhMqb75/ivSQ93KOUunJWPDwf/jMhSBOJNZhcqPbq4WdO2cQ29S4K7osNCbs eEywNgia3IO9Ez19Yfw== X-Proofpoint-ORIG-GUID: WJedrZNsXS-P-7EVdxFFAsvsXke7dJnr X-Authority-Analysis: v=2.4 cv=QN5YgALL c=1 sm=1 tr=0 ts=6a81cef0 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=20KFwNOVAAAA:8 a=BI3AvNoh2EkR8V5c1rwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfXyQb0BRZrx8qd NsHYQLRGZQLoJdKEQgxZgyN+HOSvRz85kZZHtfc/rvTX9roHVOfJSGwpvEFInxTyJYkzymSs+5r Fni5sAHXv7F+ejbVAMi329uQUhUczMo= X-Proofpoint-GUID: WJedrZNsXS-P-7EVdxFFAsvsXke7dJnr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786892027287158500 By replacing the container_of(MonitorHMP) use in ui/ui-hmp-cmds.c we can remove its incorrect inclusion of "monitor/monitor-internal.h" header, using the public "monitor/monitor.h" instead. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau Message-Id: <20260812211708.92824-23-philmd@oss.qualcomm.com> --- monitor/hmp-cmds.c | 2 +- monitor/hmp.c | 2 +- ui/ui-hmp-cmds.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index bcd0a1fc878..4e8d996dbb5 100644 --- a/monitor/hmp-cmds.c +++ b/monitor/hmp-cmds.c @@ -290,7 +290,7 @@ void hmp_info_sync_profile(Monitor *mon, const QDict *q= dict) =20 void hmp_info_history(Monitor *mon, const QDict *qdict) { - MonitorHMP *hmp =3D container_of(mon, MonitorHMP, parent_obj); + MonitorHMP *hmp =3D MONITOR_HMP(mon); int i; const char *str; =20 diff --git a/monitor/hmp.c b/monitor/hmp.c index 46f8d4a6ede..22b1972d346 100644 --- a/monitor/hmp.c +++ b/monitor/hmp.c @@ -1520,7 +1520,7 @@ cleanup: static void monitor_read(void *opaque, const uint8_t *buf, int size) { Monitor *mon =3D opaque; - MonitorHMP *hmp =3D container_of(mon, MonitorHMP, parent_obj); + MonitorHMP *hmp =3D MONITOR_HMP(mon); int i; =20 if (hmp->rs) { diff --git a/ui/ui-hmp-cmds.c b/ui/ui-hmp-cmds.c index 24cf3a67104..806a7bece7c 100644 --- a/ui/ui-hmp-cmds.c +++ b/ui/ui-hmp-cmds.c @@ -19,7 +19,7 @@ #endif #include "monitor/hmp.h" #include "monitor/hmp-completion.h" -#include "monitor/monitor-internal.h" +#include "monitor/monitor.h" #include "qapi/error.h" #include "qapi/qapi-commands-ui.h" #include "qobject/qdict.h" @@ -343,7 +343,7 @@ void hmp_change_vnc(Monitor *mon, const char *device, c= onst char *target, return; } if (!arg) { - MonitorHMP *hmp =3D container_of(mon, MonitorHMP, parent_obj); + MonitorHMP *hmp =3D MONITOR_HMP(mon); monitor_read_password(hmp, hmp_change_read_arg, NULL); } else { qmp_change_vnc_password(arg, errp); --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786892048; cv=none; d=zohomail.com; s=zohoarc; b=Wdh++dNiiSaIY34SLukOUG/5XCUz059HmkL+LY9ZqpVwwGliHmeeyOPt/xJvh7BGkC/3NmQINbovXKx5lHd3dAUHF2FryG0knL1MZTZxoEToYAL4XV5Mu/hiO6gWPMEoiJkd8ckndgeIdWH5zJeNUskqHtD7asoyM07T5dKFJGk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786892048; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=s6bPi+RFkQqSYlbr8FSTtHoAF6m9DnNo7b6G/QSiEVU=; b=T5+5W5s+YjCR5eWQWeb9kVL58psvGhpRQtdwQ7aR3/aiPRucqMXDRW7hL99lG9id/45ot3uQdbho9scpgndboNWwN80s3i/IU/bD0SKd4z0PB/Z2QCdVDjf9F/xtWPxF8R6QuBOxLO8/MEihzlLh7sHE9w6dR2FDQBDNCR5Ctvw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786892048930327.63419462673266; Sun, 16 Aug 2026 07:54:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcFB-0003iN-GB; Sun, 16 Aug 2026 10:53:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcFA-0003g2-IU for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:53:48 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcF8-0002Zz-QD for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:53:48 -0400 Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDkn9K2760476 for ; Sun, 16 Aug 2026 14:53:45 GMT Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2h9gkhe5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:53:45 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-526da7e3c9dso24415771cf.1 for ; Sun, 16 Aug 2026 07:53:45 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f2b27bfsm26061411f8f.23.2026.08.16.07.53.42 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:53:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= s6bPi+RFkQqSYlbr8FSTtHoAF6m9DnNo7b6G/QSiEVU=; b=FWBBucZ2/WC5LXau B17b51d48mDzzE6DyjeFFOvez2hX3cLyco8ryBDuWdbnIfxcRarQ2hTqlwkkcRND vswjsJVL7Z2Wz0w02TAh9h5aAZ6S5owqnuAHSwZ2C7QVFVD2Yq3EL93SWWPgVy5V 2sy7uk+tSOtKRCzKleoimxfKf8W93DxfpUfN1xoQwr+1BGaelnHeCJS8MasqQ3KJ FzpgLbEW3QC8W4z+1re8A/5tFScKGjcyNRyfbM3MWmscrJN9TDzXbqAm87GqsS+i YuuvEXE8c4l6UIZ9SizfMCQBOOOwxX3dsu7moZ1ncmgMQJK4RohD09dfe86xuw45 I2FwnA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786892024; x=1787496824; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=s6bPi+RFkQqSYlbr8FSTtHoAF6m9DnNo7b6G/QSiEVU=; b=gVewCSJO7UVU3SMTaCaN8hCS4DYl6CuUkLh7yLh1LVLAHWG9Oq4xULnOIziYOyZ+O4 yeJFgkwOn0jNTu4WFvDBYIsBGCXWZBOMLcmLWmhPVCOhYHNSMuXCmrL+IZqAHXBpX+ir NaapPn2xlmu7LOtEa8kgJUKTUThqVgsrxoKDCuGnIjZaIOxZ/Yixs+xN18y3lhKEeB8p NcOR6hqg0PA18GBHLIIlVXOTvJXjJyfrJM3kRIe9z2YIXYaZQEepoal156GqSy6cCm09 vw8aNTJrmPBvNUdTk6n1678lZY0UhvyUpKpBDlo7nwXqC7pHu7auITS8kEnXIjT02z2g 4JhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786892024; x=1787496824; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=s6bPi+RFkQqSYlbr8FSTtHoAF6m9DnNo7b6G/QSiEVU=; b=brPUf/lDgfux+0g8dJ7HYSO5L2/jsyf3JKJbS8l2y9UbSKzwgemoc5a6Q653Vru43e D3NS16oegohkd1O8zWp6qqkrCbqEwvt1TaNy6IokJr6F8iCCumCp3Ihq/IGjOrVH9wBU +IxXPUTxjjRWaIHZMTVHeaq96OxP3jN8DFrrp6HIF2TjLBY38v+E29rHMqc0VXCJ2INP ij3SzmMx7dwJIm5LRfcMgMCh/2XYPuxPAVO8iXROFFZFfVaDpM0Rww68TZdwApQV1kw7 zcI6kS3EUVAYAD81Xqpd6Qx/+bYE3v8tX/YbrsXPja5hvl5+SFKeI1AGkThwiOwEc2bD 4zNw== X-Gm-Message-State: AOJu0YzkWuVuB05LsEjCJiHginNi0KT8igiHLC/E2+3pP/GfENN+7lr4 dHSjBJ9b6ZAeOyGcTkMrB1gWeNdWKMG9lQvo6nR/bxEyv8CcL/grK47cuoYdFAK3lIs4uGTZOC3 QJRwBJC3AI5xmS1eq2K75SFoTBpfmkHbdHitl4gwTmqG1pOrWoOtd5ht5gDL3dpFKeg== X-Gm-Gg: AR+sD132LogqV2GZ++DKVK3wirKFPUMWIt8qunzl4sbJ/jsBRBfek+mScPdR/CWkwLR sShvNOaFF5pZb70gmBci2AwuacBXHMvw5mGaZjby/LItNFpEA1hkusp+M7+tW6r+uC/rZo4NWCT AXG/AB6IhpoCM79nXNz4go28Yb+I8KEXphlm2U1TmxV4oLZjTNI5TmRX6br7Me/RLoCX1ePj1yw Bvs8mTwuz4vVprhhhHgK6S4dL1uO3Pg7f2YPQ59Zk3jGAlgNuYAXnwJ1WHsDOnbUGjnxe9aKoU5 P9dD63ZyQdRw6ohMYSRkq67FQd+uATjxn1mM+doIKMY5r15aueGOPvFu+wAimlYlPOylf3VCk/9 YDY/LEzMHysNu0rOak2/FigPCZVF0L/1Uj9qTDEd6aQ== X-Received: by 2002:a05:622a:1308:b0:517:6508:e1f4 with SMTP id d75a77b69052e-52d8551f3famr189640341cf.42.1786892024283; Sun, 16 Aug 2026 07:53:44 -0700 (PDT) X-Received: by 2002:a05:622a:1308:b0:517:6508:e1f4 with SMTP id d75a77b69052e-52d8551f3famr189639951cf.42.1786892023672; Sun, 16 Aug 2026 07:53:43 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 55/56] hw/elf_ops: defend against weird elf headers Date: Sun, 16 Aug 2026 16:45:54 +0200 Message-ID: <20260816144556.69009-56-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: B7l9bupwziQz6KQ-qx4iN1C8CmAJzVVe X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfX7BX3j7X8EpyZ Wg+LE2NPWIo/C0OUdNfqQaCV9huqkIK3fRIJneo+lKt1B9RUg1GrvaCx0Zzx+3ljLyXAPbGDa3n HUEChQoLNoM6pjbh77ztPXmsx751itI= X-Proofpoint-GUID: B7l9bupwziQz6KQ-qx4iN1C8CmAJzVVe X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfX5Z0orF+g0KdO w/Mt2HBp0BMJzn/joCbExCznoD7311SBVUab+STq1Dj9Sf9SOtLEUP4irOxuvYFSMEBdHmiQoM0 8auIk6y3SS5n2pAc5Db+s5pmdFHKtLPvWA7GciUA8v0avotnuAGTQECTkUj8UmKPBBNPsBejEup 2UnR9FTDvU+/i/KuRUdxTVJMbe7siqyO7TpkSABXJr09otnBgSkDicX1pD+1wGYXbCsO9lJMo7t ozUEYPIihgI6JjPhmQvaXMOYGlPYobGCG9G+q1ECRM5VlfaNtFLPyFrEMCmiVZMb9WBkqyyLK7o 9Y1FqczXwwJAfV0dgzzj+1C4q7xhr7SKSH5c8YjbzGakcyLi/2+t0ySCbYoGzg2eC/Q3WklAR3B 1Ja2PvVElu0qoBGeqhUanYLFFDqe8bBVGCtnSjUPCf6D9oX/kKxUALhBsdXsJuJDa73knvoA0YO LTTqLN/GHxHUqOjskFg== X-Authority-Analysis: v=2.4 cv=XM4AjwhE c=1 sm=1 tr=0 ts=6a81cef9 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=p0WdMEafAAAA:8 a=KKAkSRfTAAAA:8 a=69wJf7TsAAAA:8 a=EUspDBNiAAAA:8 a=OFwHzJbXOuJeDGjhX8AA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=cvBusfyB2V15izCimMoJ:22 a=Fg1AiH1G6rFz08G2ETeA:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 phishscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786892049425158500 From: Alex Benn=C3=A9e According to the ELF spec: PT_LOAD The array element specifies a loadable segment, described by p_filesz and p_memsz. The bytes from the file are mapped to the beginning of the memory segment. If the segment's memory size (p_memsz) is larger than the file size (p_filesz), the ``extra'' bytes are defined to hold the value 0 and to follow the segment's initialized area. The file size may not be larger than the memory size. Loadable segment entries in the program header table appear in ascending order, sorted on the p_vaddr member. which implies while both p_filesz and p_memsz can be zero we should never see a case where p_filesz is greater than the in memory size. Indeed it has been reported such a hand crafted ELF can blow up, for example during rom_reset(): address_space_set(rom->as, rom->addr + rom->datasize, 0, rom->romsize - rom->datasize, MEMTXATTRS_UNSPECIFIED); which could trigger and underflow leaving QEMU slowly filling a very large buffer. Cc: qemu-stable@nongnu.org Fixes: https://gitlab.com/qemu-project/qemu/-/work_items/4056 Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20260812081405.3811787-1-alex.bennee@linaro.org> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/elf_ops.h.inc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/hw/elf_ops.h.inc b/include/hw/elf_ops.h.inc index 9c35d1b9da6..044e72de2a2 100644 --- a/include/hw/elf_ops.h.inc +++ b/include/hw/elf_ops.h.inc @@ -427,6 +427,11 @@ static ssize_t glue(load_elf, SZ)(const char *name, in= t fd, file_size =3D ph->p_filesz; /* Size of the allocated data */ data_offset =3D ph->p_offset; /* Offset where the data is loca= ted */ =20 + if (file_size > mem_size) { + ret =3D ELF_LOAD_TOO_BIG; + goto fail; + } + if (file_size > 0) { if (g_mapped_file_get_length(mapped_file) < file_size + data_offset) { --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786892050; cv=none; d=zohomail.com; s=zohoarc; b=HAyptaEh7qoOAUl7T6oy3E/haM9gdRaC8g9/OHf7ViAAvVUx93SX+tf4faFUjAWN3/X1OLoQptJAGAGOVBFro80JUR236akvvE+9MP3nmkDskRQglImSvxC1vcHH/27FgcUl3MFx6GDJBU6AxUVuF1giW9FJsT7bz22WGvuWfNA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786892050; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=OPwRUFKMsLE4Q9u2udZy/naPOPsDOQ/vP4GmRlNYAAg=; b=gPLvrYu7TDtzRVa9lYv1emHFaselefioakmGR9DcSUPjL3qF05Qr74lCtFX/SJktczYyTwuXev2kQVXIg7nkivHLcwfP1OmmOSmbwaJ+sWy3KlxDbrsjYa2afQ+m+oJ39L4nL11xZab+/a3ekqfJvMSMcumxu1SyCINrTcL3bfw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786892050696863.2513456352546; Sun, 16 Aug 2026 07:54:10 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wvcFJ-00042g-2y; Sun, 16 Aug 2026 10:53:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcFH-0003og-6B for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:53:55 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wvcFF-0002b3-N2 for qemu-devel@nongnu.org; Sun, 16 Aug 2026 10:53:54 -0400 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67GDlOdo2399229 for ; Sun, 16 Aug 2026 14:53:53 GMT Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g2ghq3p0p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 16 Aug 2026 14:53:52 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51c1c7f135bso45140271cf.0 for ; Sun, 16 Aug 2026 07:53:52 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499960fef95sm63064565e9.1.2026.08.16.07.53.50 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 16 Aug 2026 07:53:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OPwRUFKMsLE4Q9u2udZy/naPOPsDOQ/vP4GmRlNYAAg=; b=OfYkQFiXOILm7bZ4 P8uaVTiigT2yeBBr732xzN5LqjNJHLVE+KNhq+VT3l1ElttCrlZv8VGs5sUp4q5A bGUFkwpnZ0f1Kh4BbEKcWR6DZX5U1VuFFJvgkXk0mZoTqQP/2eK7kKyJLBxRm5hd /kztGp1J+Vl7EJkaeUyRMFTMKahV5SMlYzaf3eyD4nD8gwHec/L4lDmPbaxjzlzc xGIK0vatefS6k66K6FqRl+Q3ju8xJPK5hdidEvpEp9FGjnpLYg6bv5gJSvgW2QHg rToV0HlgjVsPLboy4BmAhEIkYuvLJkSTMI1poygBVf6FfSdcgKnQNCmjj81NBXoS gwlt4w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786892032; x=1787496832; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OPwRUFKMsLE4Q9u2udZy/naPOPsDOQ/vP4GmRlNYAAg=; b=Rd59lLQruDWXEQ5eulgzU4pup+0zG6xVIVz0edaKAbmqi8XetvdvlYOXFMSKZaW4If MwsUlkdQua4cUq1z5EAtdx+wyX4alkKGGn1OECrJvX5sn7vIWmX8T5NJZwGy58LS3Xtv g6kh9/pQoBTYkjZY4jexSYE/RD9c5i+NI1oqLQjjye4NtTSMp3U/N17wTuJHwVLFl+on gPVjRXjO3eJE6b2IyNj2WKRaTk/iy5G5Bx/u6j0xatsUKphib8jAHeSpXy/hlRgDOzYq f1xmc/lg5oSlprLG0NTUrl2VfTtDCh1CS2JycDmfS58UalmGkwBpvyHM19cegSHA5oc0 bYZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786892032; x=1787496832; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OPwRUFKMsLE4Q9u2udZy/naPOPsDOQ/vP4GmRlNYAAg=; b=Z+qYZqbbgEFFOK6m/6PObj+fZ9qBhwpRd8mw1RncMku7Ab1yO8aUbS7CeGUQ2Yi6OX tFU2XJ2+nySKRyTLkgyS9qlesVE6ncnM21jMxX9eqwF3wMw0NuokBYooY+b3p8xZkajg Tu2VuLuJYU41BfP4N+n1wpFwYyQybVVgMQ24KcKmE3zEvwEcXUp3eSUeRigH1YOocAWr MCHsS8sRa32/8axTdVeZLbPdPGiC+ch8X3pI7sT/KoGT2r1OEPjciycEqC/5wm6J8Koi yCLmGWrWw+eBRd2MUoTBfyug6B7qvv3vYp4bdHtKuxfVVkx1wwshfWhv053KQf78yxRS J6Sw== X-Gm-Message-State: AOJu0Ywyd1oH5XVYXmpW+LqppK/5Pea6QM3X+KYiRGaYRSxgBHAF93Qf pcDoLeKTeuhi9BJOFR2KJ+4ZcAoUmm/33bMemi3Hk1zAaRSngYbvZSbkBnpItmBSztYplYqA4jr HXO2zQpLHgrTVMiKNSvdbvJ6CwEdkY5xU2llNQrXkiiWtH62T0xUv/Vu1O26K/RR36Q== X-Gm-Gg: AR+sD12VHGUd1Z6n4GHAMjFfErOtZfAGtFWU+LGMyseuGnyGEM4WyRk21y+5oBxFW6I l7w0F+UVuHdgEWQLhEbWtVQn2a5WkeEGTsuV9d+gV0GrUcPits8p0TfHzDAeH1JF66FKCXPwtRv RxZcUBmgCNbfbkHtTFU2QhNhgD2LBtvTCI8+gLprUEitTr28IvBBsWY77IM2LyANxasfKojWzac fEAx8/xc8D76MLPqvKERTcGl3EazJuoPv2Y5UY+gsGiPHxG5F2PC51iDUwaXqc2TXtTV1FgIMxT McdYYcEogRHWf+gad+G00JByKOJI2cqPzYYhR9zwztWZN5BbCTJdBuGSrOpFflF3yUonYvv97yj x6O70UN922+AGrH+fedMyJwNp8gVog1Hei0nClR91Pw== X-Received: by 2002:a05:622a:588e:b0:52d:2ddd:27c with SMTP id d75a77b69052e-52d854b4aeemr213767141cf.31.1786892032209; Sun, 16 Aug 2026 07:53:52 -0700 (PDT) X-Received: by 2002:a05:622a:588e:b0:52d:2ddd:27c with SMTP id d75a77b69052e-52d854b4aeemr213766791cf.31.1786892031775; Sun, 16 Aug 2026 07:53:51 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 56/56] hw/core/machine: Move EHCI migration compat properties to 11.1 Date: Sun, 16 Aug 2026 16:45:55 +0200 Message-ID: <20260816144556.69009-57-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260816144556.69009-1-philmd@oss.qualcomm.com> References: <20260816144556.69009-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfX9cDri2zsfYif WFiWUHS7I9mw5kT0ni86W0wSTuS6Hypzg/7p0FlRKkqM/lBvjNvfc6eNoVxMCpqwvz5zCUenU3f HROn2DMGGt6ki4buL8aLIKOdK6ZFrMuHrgLhIbKGYxnMG0IhSqltbh5E/74BHKEZufSpq8Ex9OU K2ahQtsFkscXFsbV0UHJoKa65HvOYuwpqnzB77OtwmL7zCFRGe7uYQ37FhNL5SC/dhOb1ibpUNP 7Tw41ezcf1VERCksKNXyl19kHm/NzNlEhG9VUN2MLNZCTvcmOByXh0Hotjjp/uTlqPiS96eJwtw 6XnEj2/YZs91VvuTaXFt0jAbRdDFcCYdTHk8RZF3Dw5amVII/oeiXMb7CkUYlj08Hw+yFFGweTt J7Io/dOo0oj93UEcnSP2cP7CkU7sijhSKaljzWRgkTex5ymm/2EMCAbSuyPJ1AZAs52fSLN4quJ mT3VfCFcG1YOag7YeVw== X-Proofpoint-ORIG-GUID: TsEyXBY5xxyFJI2wuuXMv6A9wgj04zi7 X-Proofpoint-Spam-Info: AW1haW4tMjYwODE2MDExOSBTYWx0ZWRfX+MwYX6Tm18dk CxxebU8tYibEk9RusDKV83+cnx6CmpTNAtCSUZKq0P2BK1bOxx2XyT7fF0ZTzvIBUpJxy9X2BqH AFt8uHt1q6gX4wOzKJJFZb0s/MvNGkg= X-Proofpoint-GUID: TsEyXBY5xxyFJI2wuuXMv6A9wgj04zi7 X-Authority-Analysis: v=2.4 cv=dvHrzVg4 c=1 sm=1 tr=0 ts=6a81cf00 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=V2NxCb60AAAA:8 a=EUspDBNiAAAA:8 a=-BVnA0jUmpH98zYowaUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=3L6qF29SlnrayQqPM2jZ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-16_04,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608160119 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786892051364158500 From: Jamin Lin The x-migrate-fetch-addr-64bit compatibility properties for sysbus-ehci-usb and pci-ehci-usb were reviewed before the QEMU 11.1 release and were therefore initially added to hw_compat_11_0. However, the EHCI migration change was merged after the QEMU 11.1 release. As a result, these compatibility properties belong in hw_compat_11_1 rather than hw_compat_11_0. Move both properties to hw_compat_11_1 so that migration compatibility is associated with the correct machine version. Fixes: 38ed803aebb2 ("usb/hcd-ehci: Change descriptor addresses to 64-bit") Signed-off-by: Jamin Lin Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20260814032559.3381363-1-jamin_lin@aspeedtech.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/core/machine.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/core/machine.c b/hw/core/machine.c index 4e551194465..e617f7804d4 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -40,7 +40,10 @@ #include "qemu/audio.h" #include "hw/arm/smmuv3.h" =20 -GlobalProperty hw_compat_11_1[] =3D {}; +GlobalProperty hw_compat_11_1[] =3D { + { "sysbus-ehci-usb", "x-migrate-fetch-addr-64bit", "off" }, + { "pci-ehci-usb", "x-migrate-fetch-addr-64bit", "off" }, +}; const size_t hw_compat_11_1_len =3D G_N_ELEMENTS(hw_compat_11_1); =20 GlobalProperty hw_compat_11_0[] =3D { @@ -54,8 +57,6 @@ GlobalProperty hw_compat_11_0[] =3D { { TYPE_ARM_SMMUV3, "ssidsize", "0" }, { TYPE_ARM_SMMUV3, "oas", "44" }, { "migration", "switchover-ack-legacy", "on" }, - { "sysbus-ehci-usb", "x-migrate-fetch-addr-64bit", "off" }, - { "pci-ehci-usb", "x-migrate-fetch-addr-64bit", "off" }, }; const size_t hw_compat_11_0_len =3D G_N_ELEMENTS(hw_compat_11_0); =20 --=20 2.53.0