From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786645059; cv=none; d=zohomail.com; s=zohoarc; b=XShjpQH2GeFi219du0Jp99xr7yxkI/s+3pmaEdMCeK4MhOmZbIeDPDtsAcGSK8LrKP2mnZUF8qZ4CN5urU4rLqkNRMtltcAMtdqn5weqJH74zyhHo3EebPXm9Joaa00CJUdplJmd8Gi44t1+MLch8p/a+tazIz3Ncrlq4oluSDA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786645059; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=If9D7G1AX8bwDN7nlcPuG21QsgSh5nNyafUcgJBgDj8=; b=NQ9UcWum0iH/rNZji5Olw9DANjVFz2YDDYPPzbAHI3dpyBom1EZPAaVhZ8ZVyKoQD7iG/j9XPB6gqskq7rZwYkmoUXaxMcWYvhRm5cuFv4LZS8e80KOdVaMCuiEWOjazAuH38wsx6YkNT47oT7LT0bZVe1UWqYL1uyUveuvi4as= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786645059359542.1517172718568; Thu, 13 Aug 2026 11:17:39 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wuZzA-0001rc-LQ; Thu, 13 Aug 2026 14:17:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wuZz6-0001nQ-H2 for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:16:57 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wuZz3-0001z9-7m for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:16:56 -0400 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67DGUt8I2076785 for ; Thu, 13 Aug 2026 18:16:52 GMT Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g1hgy0f2t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 13 Aug 2026 18:16:51 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c083f1818so3030351cf.0 for ; Thu, 13 Aug 2026 11:16:51 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f2c129dsm1038781f8f.26.2026.08.13.11.16.49 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 13 Aug 2026 11:16:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= If9D7G1AX8bwDN7nlcPuG21QsgSh5nNyafUcgJBgDj8=; b=ANdea7Q7Zh4mt7eL 3lMOeJuXOtA0ua3yxADRhT+amAjuVzB+khJGoST9pX7AFfQ7M0PPl6hD02KLNinM 9EyKPhB7tCguxnHp+tGwaoKbnQpikt0jZhsY4T5xCCI7Zs72xA7iqGgB3qB369cs 567L17gyoMj+8NX5/TE6oCIYN8At0e57BpvKm0Nil4pw204xFvcuP+Z8xVfVVIOY iVRIPsR2BmeD4yxczdVaIIVsbBsqIDiYYoKPBpcdqpyPHgKK/UCyswVTRZ36NCpx ibSxr8D6W0/M7O/SBqcuqmYH2lyctnSOmr4wyfm3Lr8IBnKfnENwMc2z1a4NPwd0 0oHmeA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786645011; x=1787249811; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=If9D7G1AX8bwDN7nlcPuG21QsgSh5nNyafUcgJBgDj8=; b=KQa1rRs9W3mJ2DIJuYzOKSup+ACYJC40T/AH/K9wp4CuXUcIDiJOhEqtg6Ucvqf/uK 0WpSGt7C4lLkAHLpVAR4Jy1e57PsWwyQs3yIdkziSUz3z3RIqS3S1/J5BwVGdzNwi+4C X3hUttNZJtSvDyPXDwoiA1SPSy2PkLLfuvxfBWDTcmrgUcC/7HFEP7L9lv7dS1yaNKxd kcddrpimS7doD7oIr16XytF4pzHV/X+gz2CWSJVPRxSpYOZuXsBe8K4137CEa1+ENNpP MEPi7D6fbEEAEjxGmd2E7kgbu5ExneMY7yKBNxKvNH4I6e0EEW+H8GJ8OBA29GuaPpQ7 JBpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786645011; x=1787249811; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=If9D7G1AX8bwDN7nlcPuG21QsgSh5nNyafUcgJBgDj8=; b=NFh/Kr0HLChGEG01bL+RdKfilyn7cmJK63B0bXNYQTye4tQlNey6IykR8QEpT15mO7 qhBeMMDRD44EIRWECSjeHcaocBKYArvO13vNMrEwEclPeOLIoWYilt+h7T+jILofTTG4 qVpIWsjAFDK9+dCw7Q7LsT7XTIImioXZ8q9w4JgYnfK4fq4Le6EUOjV/Xmva0xRRDvF5 80UGKeeNaCnnjLZfFy7bCeSALddbTmuzN/oEc+xOl2/c8pjH/ubyUHRSgA+pjTz8xK1c cVkKUCExNRBez8WDjADLWm1O6HZTU8y4alss4+kToeleRH/WKa5pLwaauHOsaOx/1Z5m E/zQ== X-Gm-Message-State: AOJu0Yyo142zUuPS/rm/WFVfDgVwA4m1qPQMdW5pPOFU2Wlf/UyFo7G8 qHOiXJXuDIQvQS6zjy62GeQgMdJ94mUkdNGT7bTUad44e8cvs+kLm6RH8Kzb2e2k+y15/l6+IXL oTIRfwjMakwkvHjWusn+kYx24EL19DMYpu8/8YpUpTMrJkxsPZAsxtJ3EZO8JgzJJng== X-Gm-Gg: AR+sD112V0VW0bjcQKOBPnkBNrM/XXtNGTDS/yzMMR/H6rVMRUPw/kNmFcPQwE/AVLs gqsGbfUSQQI965X3DGEnW2kp3uI3BjF/VPRm9m/ImAj2tLYwX1Y9xjPF2NgYCZbd+Z1J2n3IyPB EJWsen5K9MUeAYwGZRWXYAgBP4psS6XgtIKnjsuTK/s2U9pcJgqi9qZm+G5lxPypIHVcl/VrYay brVzpqt8a8hC7yAb3lslg7f5d+3lHANy6BHHk35iw65v8BCFt6hNs8gIFoVkOshPFp8N/r2VGZW LLJMqNIC5B27HOlq6sDBcmUiPRtwni3Ku+UWnNIgOU+FZl3AbYEYN4d/ATs9GllGLACCCA0B3W9 YDAqckLHUOdrrgbS0JF5boaHo5++G7InrCCkLtzQepQ== X-Received: by 2002:a05:622a:e0c1:20b0:52d:771a:231f with SMTP id d75a77b69052e-52d771a25e6mr48080711cf.12.1786645011157; Thu, 13 Aug 2026 11:16:51 -0700 (PDT) X-Received: by 2002:a05:622a:e0c1:20b0:52d:771a:231f with SMTP id d75a77b69052e-52d771a25e6mr48079961cf.12.1786645010616; Thu, 13 Aug 2026 11:16:50 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Daniel Henrique Barboza , Paolo Bonzini , Pierrick Bouvier , Mohamed Mediouni , Alexander Graf , qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, kvm@vger.kernel.org, Richard Henderson , qemu-arm@nongnu.org, Magnus Kulke , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Roman Bolshakov , Phil Dennis-Jordan , Wei Liu , =?UTF-8?q?Doru=20Bl=C3=A2nzeanu?= , Pedro Barbuda , Reinoud Zandijk Subject: [PATCH 01/16] accel: Label outer / inner vCPU execution loops Date: Thu, 13 Aug 2026 20:16:24 +0200 Message-ID: <20260813181640.6537-2-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260813181640.6537-1-philmd@oss.qualcomm.com> References: <20260813181640.6537-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfXw+p1mnkWodpr H5Z4KByb/vWKc8vvLiLOtGRAwbokq3LaWfR0kVUn0ACGmvcrqIR09dr7GJAJ5M+uSRUkgwDFPUt NtvkYUJQVa44R5GV1XABsua/dLzukpFMEdDgbONx8GSeU7jqZNvONazoM6nmQ9o4jykCjvny6l3 7lpzY+Dr8uO6S4HEh4P1/b47vzpdN0pHWVyHZy5K1p0eoNOuJ3UaMOcQrJ9G0UThBL4+icW6XL8 XgEcO1QhKn0w81LAJqhs55VkdL5yCEp5QkjP4lEPVn3TSlzQ7SwzepyAdz+A5rjOe/ctdEX6Oyt 5oVXNoxfHKB8KLHqwT14w7705bc9DSv1ERLoJqF2PrqHvD7yjmHZ6/AWr+yC7l12Fx2K8cy2fdV LKtLxEnznEk0UDVj3EXx42dQQWqTIs+Co8b02vqQLoPdd2Eq+A8K6LISK2980MXPw7p6hLmcpl3 8DX0QGM33EfTknngUGw== X-Authority-Analysis: v=2.4 cv=AaSB2XXG c=1 sm=1 tr=0 ts=6a7e0a13 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=IxD3LLwSwie1VK6kbxAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-ORIG-GUID: k_p5eiqytduUijsbwnBXLKe58guo6lg0 X-Proofpoint-GUID: k_p5eiqytduUijsbwnBXLKe58guo6lg0 X-Proofpoint-Spam-Info: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfX6zzM9BMwG3Q9 B08S6E+sf2sk4A8JP1kRRenw5TmmgkzqlG/5+P4gbayC4cwfs2n/RlGuQKN7G6K7q8n5IaAS0UR 8HuGn+L2TOC/Hs4x+VNbj/HApCDbXNM= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-13_05,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 spamscore=0 impostorscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608130132 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786645061725158500 Distinguish between the 2 levels of vCPU execution loops: - "Outer vCPU loop" handles CPU events in vCPU thread - "Inner vCPU loop" handles actual vCPU execution This helps following the same pattern between all our accelerators. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- accel/dummy-cpus.c | 1 + accel/hvf/hvf-accel-ops.c | 1 + accel/kvm/kvm-accel-ops.c | 1 + accel/kvm/kvm-all.c | 1 + accel/mshv/mshv-all.c | 2 ++ accel/tcg/tcg-accel-ops-mttcg.c | 1 + accel/whpx/whpx-accel-ops.c | 1 + target/arm/hvf/hvf.c | 1 + target/arm/whpx/whpx-all.c | 6 +++--- target/i386/hvf/hvf.c | 1 + target/i386/nvmm/nvmm-accel-ops.c | 1 + target/i386/whpx/whpx-all.c | 1 + 12 files changed, 15 insertions(+), 3 deletions(-) diff --git a/accel/dummy-cpus.c b/accel/dummy-cpus.c index 5752f6302c8..f9a8d5fff07 100644 --- a/accel/dummy-cpus.c +++ b/accel/dummy-cpus.c @@ -42,6 +42,7 @@ static void *dummy_cpu_thread_fn(void *arg) cpu_thread_signal_created(cpu); qemu_guest_random_seed_thread_part2(cpu->random_seed); =20 + /* Outer vCPU loop */ do { qemu_process_cpu_events(cpu); bql_unlock(); diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index d2276d8513e..d8fc7be707f 100644 --- a/accel/hvf/hvf-accel-ops.c +++ b/accel/hvf/hvf-accel-ops.c @@ -172,6 +172,7 @@ static void *hvf_cpu_thread_fn(void *arg) cpu_thread_signal_created(cpu); qemu_guest_random_seed_thread_part2(cpu->random_seed); =20 + /* Outer vCPU loop */ do { qemu_process_cpu_events(cpu); if (cpu_can_run(cpu)) { diff --git a/accel/kvm/kvm-accel-ops.c b/accel/kvm/kvm-accel-ops.c index c8e7aa38709..73ff93aab67 100644 --- a/accel/kvm/kvm-accel-ops.c +++ b/accel/kvm/kvm-accel-ops.c @@ -47,6 +47,7 @@ static void *kvm_vcpu_thread_fn(void *arg) cpu_thread_signal_created(cpu); qemu_guest_random_seed_thread_part2(cpu->random_seed); =20 + /* Outer vCPU loop */ do { qemu_process_cpu_events(cpu); =20 diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 83cbd120a84..b74c7f96866 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -3438,6 +3438,7 @@ int kvm_cpu_exec(CPUState *cpu) bql_unlock(); cpu_exec_start(cpu); =20 + /* Inner vCPU loop */ do { MemTxAttrs attrs; =20 diff --git a/accel/mshv/mshv-all.c b/accel/mshv/mshv-all.c index 72721d0f0de..af172a8ee34 100644 --- a/accel/mshv/mshv-all.c +++ b/accel/mshv/mshv-all.c @@ -616,6 +616,7 @@ static int mshv_cpu_exec(CPUState *cpu) bql_unlock(); cpu_exec_start(cpu); =20 + /* Inner vCPU loop */ do { if (cpu->vcpu_dirty) { ret =3D mshv_arch_store_vcpu_state(cpu); @@ -705,6 +706,7 @@ static void *mshv_vcpu_thread(void *arg) cpu_thread_signal_created(cpu); qemu_guest_random_seed_thread_part2(cpu->random_seed); =20 + /* Outer vCPU loop */ do { qemu_process_cpu_events(cpu); if (cpu_can_run(cpu)) { diff --git a/accel/tcg/tcg-accel-ops-mttcg.c b/accel/tcg/tcg-accel-ops-mttc= g.c index 69560fdb9d8..e33e35dab3d 100644 --- a/accel/tcg/tcg-accel-ops-mttcg.c +++ b/accel/tcg/tcg-accel-ops-mttcg.c @@ -86,6 +86,7 @@ static void *mttcg_cpu_thread_fn(void *arg) cpu_thread_signal_created(cpu); qemu_guest_random_seed_thread_part2(cpu->random_seed); =20 + /* Outer vCPU loop */ do { qemu_process_cpu_events(cpu); =20 diff --git a/accel/whpx/whpx-accel-ops.c b/accel/whpx/whpx-accel-ops.c index ca5a119521a..535667061b3 100644 --- a/accel/whpx/whpx-accel-ops.c +++ b/accel/whpx/whpx-accel-ops.c @@ -42,6 +42,7 @@ static void *whpx_cpu_thread_fn(void *arg) cpu_thread_signal_created(cpu); qemu_guest_random_seed_thread_part2(cpu->random_seed); =20 + /* Outer vCPU loop */ do { qemu_process_cpu_events(cpu); =20 diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index da3ec521fc7..3eeb9f70de4 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -2600,6 +2600,7 @@ int hvf_arch_vcpu_exec(CPUState *cpu) =20 flush_cpu_state(cpu); =20 + /* Inner vCPU loop */ do { if (!(cpu->singlestep_flags & SSTEP_NOIRQ) && hvf_inject_interrupts(cpu)) { diff --git a/target/arm/whpx/whpx-all.c b/target/arm/whpx/whpx-all.c index 00a5de8cdc1..5e4c25bb7d5 100644 --- a/target/arm/whpx/whpx-all.c +++ b/target/arm/whpx/whpx-all.c @@ -407,9 +407,9 @@ int whpx_vcpu_run(CPUState *cpu) } =20 bql_unlock(); - - cpu_exec_start(cpu); + + /* Inner vCPU loop */ do { bool advance_pc =3D false; if (cpu->vcpu_dirty) { @@ -495,8 +495,8 @@ int whpx_vcpu_run(CPUState *cpu) } while (!ret); =20 cpu_exec_end(cpu); - bql_lock(); + current_cpu =3D cpu; =20 if (--whpx->running_cpus =3D=3D 0) { diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c index 150598418e2..0ffa3658dc5 100644 --- a/target/i386/hvf/hvf.c +++ b/target/i386/hvf/hvf.c @@ -1009,6 +1009,7 @@ int hvf_arch_vcpu_exec(CPUState *cpu) return EXCP_HLT; } =20 + /* Inner vCPU loop */ do { if (cpu->vcpu_dirty) { hvf_arch_put_registers(cpu); diff --git a/target/i386/nvmm/nvmm-accel-ops.c b/target/i386/nvmm/nvmm-acce= l-ops.c index dd5d5428b1c..da28fbe3de8 100644 --- a/target/i386/nvmm/nvmm-accel-ops.c +++ b/target/i386/nvmm/nvmm-accel-ops.c @@ -41,6 +41,7 @@ static void *qemu_nvmm_cpu_thread_fn(void *arg) cpu_thread_signal_created(cpu); qemu_guest_random_seed_thread_part2(cpu->random_seed); =20 + /* Outer vCPU loop */ do { qemu_process_cpu_events(cpu); =20 diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index 634d5428219..b4f499905a7 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -2251,6 +2251,7 @@ int whpx_vcpu_run(CPUState *cpu) cpu_exec_start(cpu); } =20 + /* Inner vCPU loop */ do { if (cpu->vcpu_dirty) { whpx_set_registers(cpu, WHPX_LEVEL_RUNTIME_STATE); --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786645158; cv=none; d=zohomail.com; s=zohoarc; b=htcmTB13CSKG/w2T0b7akCcFrPXJ3E9y0uc/kJvcXBObLVcPUbWxUcbswO8iyg4JzADcpqT2qOJRQgP7lf5X54nMnJRCazzWMvnilcZwbKrUQYuY3rLafkFpwiPhWNp7PvGXCXXHHfyA/P5PhzM6wN+NUwmFtSilMT/ZAgyLOcw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786645158; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=je+h48SSHuNHSOcK2Vh76kGO2HaV1LztKcGPEWVgCLI=; b=WUZQVuRcGbvrwlnPnOgANrBauPRdBvAY6rualHmzhaf3HHwX+1Wq7xe8Hc191WEXbtklWnrC0PMm6mdln7h1ac+/j8qXhPL1cm+XuBIdaTkEpolSq98F4CKONkZYYfKbtTwOiTt7tb2lrM8pPUFbXc1QIWCgHPXC1eUQv3xGcLk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786645158390469.1072855083488; Thu, 13 Aug 2026 11:19:18 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wuZzE-00023f-6L; Thu, 13 Aug 2026 14:17:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wuZzC-00020m-1D for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:17:02 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wuZzA-00023H-Dk for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:17:01 -0400 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67DGE24K2917072 for ; Thu, 13 Aug 2026 18:16:59 GMT Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g1h90rj3j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 13 Aug 2026 18:16:59 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c1c7f135bso4003171cf.0 for ; Thu, 13 Aug 2026 11:16:59 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4998777a4bdsm4564815e9.0.2026.08.13.11.16.56 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 13 Aug 2026 11:16:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= je+h48SSHuNHSOcK2Vh76kGO2HaV1LztKcGPEWVgCLI=; b=jkdX+5805XeSZ65F zyAqHNN1EEGu0GEpXMbYVx3QNeEPTzKVMg98z9wcqTXSD05Hblpjfqx8B4MIPHBx Ueano/1EY+PeKVNFXQ7H36tK41VWvzN3FhV+34Rxf8OloQOqmP3J9KiuaNLEa1Yn pO2rg7KNryLSUsiPo6BPNaqjT22SHZoQ7Ao047A8Whzn/Lql7MQpU6Qo+iuP+exf fl7859Edx9BtEpteHeNzPS9m3TeuGsPCnABevyj1ly6OQaR73islKYR7GwhhMvaU BTBq4auXdtqJXCaPWi7mDzV9zME2TBzYuQaNpxZBzkFUavyXiUHpJvxO9IebqRY5 eVEWZQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786645019; x=1787249819; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=je+h48SSHuNHSOcK2Vh76kGO2HaV1LztKcGPEWVgCLI=; b=I14YFNBK4lFLqSS6sxPk37Q6tLlv51/tD2kVZ1xrSOA6MK0SoSTJ95S1D+FAEVpEUM tOuNxlPyIE+G7F+eN0mBdugGBFAVgapxm2ADjHN6jwePY+L7GY3zJ6d17k3fOt/aS+Ga MuAEQuaXyBSpSvW1XkNjXezWTW2amaoexoJpExCgQjnb5wf/Bj49Hb3wn7F83n/kSaIv DMqlAHVxZZTOsPVqBKm5kwvIsXpxSOFrXWVzH3vW/EYl6LWl5Falw6bwkXH3iuD4qOLT J6GyPmke+nIwmGUVQWMJG09ZoltvcIL+eMw/4Lztv8Xwmr4XnHGYo42YlU1nwrYCU/dd GuwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786645019; x=1787249819; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=je+h48SSHuNHSOcK2Vh76kGO2HaV1LztKcGPEWVgCLI=; b=nRvMvRuU8aYgc+MXVJKFIR+5YZ3yTm79QQXJoK9r9VG5RQR3ppCdBZGF1sBHMpz4Qj NsEt8AS8DH2UQPblfaIhIYadxOxsDCjiOiIHGPbx5AwWoAG4gEr0tUxFUXd4ayl1g3F1 dBR9qDMmiIKmUTnM6VqfSYfqRWtEVewMVk1cpEYr2dlUio4yxmpZY3RtDM2TngyZdn9I 20JsTHuqAbJ6suFb9lsycE0Uko3UFpL+5AvxJtDC6cBgsQvLArBq1GGLDzRORIFB5YK0 gLgZQcHRND5s7e3W3GQboIYpuuz9SJ8RhxsCa9uvoUZZb/VLGE8GMaZ3dccYJh+Toahp x8hw== X-Gm-Message-State: AOJu0YxlEfPs7Q+NABrGTQY7HRzJtsC3MhowlAFYlN9StJzUz7b9TmcA zVEYf9GXk9JpEigEw7VTWzga/eS70lkSunCTL08HoYftDkwRG8fbUKLJ8pFGTdTIsbLC4u8LBCI mNHLkTqpnoT2r9zdYSeAgppgdH1z0aVCKiqy1ANCus/un6Db3nlsUqSTTib+Zb40iXA== X-Gm-Gg: AR+sD108se2iGpelyBJ6lgTJITEdwf/U39pS7Yc4XB3J3AWVyeerIVLWvtp0NOLr+p/ XR+MV09BqZa+gD44Pbz9WlZ+NAM3y5yVWc+ba0zxWhZmb5e4OoRUPJDroPDsTmWEf99ttPWU6gA C7WU4wdUjMvCuIdmNVHyfxw4TyudhH1VEigN6x+Z7l/eBXFkF5V8WTy2bOuZuwcGj0LtrEMGD5j 26+6XonbNz+JzlcDU21GE9DCOBiUAuYEP2VIpX7Ji/TKi5HIZqHb4M9Qjv/TyqZZ+bd+hmgQi8o oAXwKNBSlOfkEk66J6OuGu/1/E2I1KAd/9rwMANpIoEZ4CdlyzSP7mYAJSPgFnmn340aunZr1m1 g971gpEA8cIWRGoo0hX8ggC4wxjqFray4tF7lOXTV9A== X-Received: by 2002:ac8:5c8a:0:b0:52c:dde9:5cc9 with SMTP id d75a77b69052e-52d73d2abf2mr94409451cf.22.1786645018939; Thu, 13 Aug 2026 11:16:58 -0700 (PDT) X-Received: by 2002:ac8:5c8a:0:b0:52c:dde9:5cc9 with SMTP id d75a77b69052e-52d73d2abf2mr94408651cf.22.1786645018552; Thu, 13 Aug 2026 11:16:58 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Daniel Henrique Barboza , Paolo Bonzini , Pierrick Bouvier , Mohamed Mediouni , Alexander Graf , qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, kvm@vger.kernel.org, Richard Henderson , qemu-arm@nongnu.org, Magnus Kulke , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 02/16] cpus: Improve qemu_cpu_kick_self() docstring Date: Thu, 13 Aug 2026 20:16:25 +0200 Message-ID: <20260813181640.6537-3-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260813181640.6537-1-philmd@oss.qualcomm.com> References: <20260813181640.6537-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=Ovh/DS/t c=1 sm=1 tr=0 ts=6a7e0a1b cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=sTtMEC-yLAECRKQ91SoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfX4a5S36+E86OD A1ymBjvM9L3QrgoLz1rjaKuIwHV9oM3b5qTkZWngf0qXTptWFobXqF3QWnOSy/h7dH6GmNMPgKj BcGobrFPIajEdjQICYiuF/6YHOkMalE= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfX/f7ck08aTIle 7SkfkXdFI5daQpmHxAuxYHt0jLMMr4qtqJfhuzBBT1zdt3FXsT/zXZiLhtrIg9qwQOu8FyjjBjt /0bvX7+rnDhfbxz9krRFzabT2oCvabnum/2aBKMDUiIEW3LpP2rZI0ia6Y3yqaeXacHdMmxScoX e0ziyp/mONFBEFZqTkSWrYQRj8WSxBX4E6Dz3k2j64UHntrxawNi/xN4JWt7Ce1dbNzHdVnIffN oroLb4ekaAFQZzPGMar5jUWlOL6wr/Yxmb0142QBezot+pZYkv5k6CD+BdsnbT2ROVRcWIfn6CR 7t/5lviZ4cYXiFTxqlfOIjDb5mxrTD7KGikpafwtzDrPIKs4c3ftg/byY53kZeGDSPpwRQNVvXg GKhGsN8V+JRAWIAmx1ZcIyKS9+GvT28zAXQGrX4Xn+yYYadh7eZycqLv80IzwJd2TVBBcJjjERR 6nXtt1Zc0XOoKs642vA== X-Proofpoint-ORIG-GUID: Cd0Qqsp2w8qwLXi-D_G5d7pWaaeEO2GQ X-Proofpoint-GUID: Cd0Qqsp2w8qwLXi-D_G5d7pWaaeEO2GQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-13_05,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608130132 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786645159633158501 Be a bit more descriptive than "Unblock cpu" :) Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/system/cpus.h | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/include/system/cpus.h b/include/system/cpus.h index 508444ccf1c..ade13e068eb 100644 --- a/include/system/cpus.h +++ b/include/system/cpus.h @@ -30,7 +30,15 @@ void resume_all_vcpus(void); void pause_all_vcpus(void); void cpu_stop_current(void); =20 -/* Unblock cpu */ +/** + * qemu_cpu_kick_self - Force vCPU to re-enter to its inner main loop + * + * Signal the current vCPU thread to exit any blocking operations and + * re-enter its inner execution loop to process pending requests, + * possibly returning to its outer execution loop. + * + * Must be called from within the vCPU thread itself. + */ void qemu_cpu_kick_self(void); =20 bool cpus_are_resettable(void); --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786645091; cv=none; d=zohomail.com; s=zohoarc; b=XKyOY8mFbTdoZvgqSfVBRvXLRkSzQfUaEeBQ/NmLcHq/i+kXqZ5STjQCJ4vIXZGkQIjyKbopDR171RRiZXeD25x5G9tMHMBD2l0jrV/mDFyc3ROr5wQBlPoVYDF0o/OuQs3lb8zhFsWEFhSVZLGWoUzBRT0vWRL3Ug/P8ZUFtuQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786645091; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ii+NakEKXLwaKt59HrJUbtrSCVrxMYJtk4E5DyQdSG8=; b=PDPQNaAO5mHz+aJQ8NXJPKbXdnYPe7q7pgn2YKq1PI6D6rupzkO8iwQlRv/YhUbPbe19WFPEz8+u2g3WlVBGLECPEvvcjQgSZgIW+rwQboYPhuKGgG1vLbg/czloQ7TwRiUDk7OkJgvnWTbRz+7Mv75Yny/rWeFbKhmDz9MOa2Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178664509156795.35764186099573; Thu, 13 Aug 2026 11:18:11 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wuZzT-000269-Fy; Thu, 13 Aug 2026 14:17:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wuZzL-00024e-DR for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:17:11 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wuZzI-00025S-SB for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:17:10 -0400 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67DH8ExG3052426 for ; Thu, 13 Aug 2026 18:17:07 GMT Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g1j2f09t3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 13 Aug 2026 18:17:07 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c0e702df8so2684751cf.2 for ; Thu, 13 Aug 2026 11:17:07 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f2c6115sm1270516f8f.32.2026.08.13.11.17.04 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 13 Aug 2026 11:17:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ii+NakEKXLwaKt59HrJUbtrSCVrxMYJtk4E5DyQdSG8=; b=cKXJ/dGITmTYU76g QK6H2QsSx0tIKzWS+1UbfDX6ErVmzta/AHyXVk2GTefp6qPAKcukvlXoAaFIGXfz 56W6fpGRKhgWlpm9QXQD//3F6BagJWRX/5fqg30tQNR874qolvR6X4eV3ow0+RZw TG6dj0PEnIZZv3JYew8/2laMYaNPI9bU7Xbsag2+XwzEC088taqtc41ouFFZ0PPU u8N7Ut1KzEnlMgasU/Q+dptng8KYLSFGkTxbdyq9+jWt0ib2oI/lsrmGiwo1VHK6 ryRSHnPeNx9x3jPbB+oHg2amgacWrfD0jvfhfvTO8YTnQoAao3J4YrJMD9eUDeu0 6BJpLw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786645026; x=1787249826; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=ii+NakEKXLwaKt59HrJUbtrSCVrxMYJtk4E5DyQdSG8=; b=Xj0yDf8GEFtQda6+ZVR9kuj5Z3wQP0pEF8hzzwVA5tM8odpCgvLLrhQocmOO5r6ICs JafYkqzPu8Pa7j65uFNsFwllItTiJNu8BnTtomt40lfXX3YNDXprc22nBqnOqXanjvGn csWowzUQCfwsAB2IO6OwZ6rzTNF4I5XI74IP8IPXlG8ju7y/0cS/lUZeTlxk7guiDS14 cj9CTbRdPoyqXkcaCQWTSl2hCdWjsBcORjILRt5UFcJn7zAxtN01M9c2KkntriG2F0m1 f95R45AW9lP91hDfWmvxw6/Ns5JKzUsHZxbQdrtykyXjlBeiDLROW/TjuxzqJBGCNlOW fOIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786645026; x=1787249826; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ii+NakEKXLwaKt59HrJUbtrSCVrxMYJtk4E5DyQdSG8=; b=GLKxUhPSQZ4/UzaUehB6pbHCc9RKNj6AWukXxAkWFH+meLhx2JfokWdil1ZP+nJQyr gg5Jecci6xVMgoD5cvmlBDjTydxb9LJXi/m3+OkV+mYM6JFmmu79pSw9HgqGlJik4d2f xZ/l69VnWkmerSxP2dBZfJvFjkQNd9wkZc7stbEg9XCSPg8UeLvItv7cMZEvHh8fqy6F ZJCErEyS9VPg01mwJVztfcuGNjN7WQFKw9ka3xCU0bTvjOY4tEssZWIdwxsQhhwryKoH WfgZMIVRA1LVpdPQcoNJG9TZLpgfyIHPMGu4wM46wNlOXvI9cgI4DjDmwO8UHBojpNur u/sw== X-Gm-Message-State: AOJu0YwTpOldgfu1s86fR3rRUwMvgjHo7k5XSE1Wy7APW/2PlGDqH5Dp SNZePsIHgtlasEbf+yHZUtvL7RLGHhcIDGn1f2pfmXF1zsHbTuB7D/q34iXjKFzDC7x6HhA7JDH GrZEhVaBxAyWPxzLC2ARHQaOwLR1ybjjhON8ZEOYBng8Tli0YlEHWwfHlbX4vknWjyg== X-Gm-Gg: AR+sD13jNEhnyv/ZdGyMid7EezMwFp4ZtWG1wdmFNctXRPDvvrikBPm22fAahbDyAUX a75dTsUm9YiFg5OyDD5hMGe/xHCpmIbh2Tyvt+magkWM2sN8n5Jc5U8k7kDfukiP6oUw3RIJ1LV EzeeGugzPcxXujuJkIgJVKDK+tqIvvYGd0SIabSewqM4wohgmcqMb6WbufUO2klS8HJgRInEWzA +WBQxLQ5xbf7WfRD6/C3bI+OPL1FMe8870sTAcBXUmrHsNyVW674vRLFwXLx933graf+rQAwkyQ Bm9ppaQ1iUoTXjxSqDEa0ZUQt+3YFv2lCw6tRduQRa6QJuibQ5DFdHTvJjidaf7igKeeugVLN5u vQVPTDSWElso7URpX53vLqKAKs1f57BmGD0s+/g3+lw== X-Received: by 2002:ac8:574a:0:b0:516:d699:a99b with SMTP id d75a77b69052e-52d73da2a13mr76547961cf.40.1786645026286; Thu, 13 Aug 2026 11:17:06 -0700 (PDT) X-Received: by 2002:ac8:574a:0:b0:516:d699:a99b with SMTP id d75a77b69052e-52d73da2a13mr76547071cf.40.1786645025661; Thu, 13 Aug 2026 11:17:05 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Daniel Henrique Barboza , Paolo Bonzini , Pierrick Bouvier , Mohamed Mediouni , Alexander Graf , qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, kvm@vger.kernel.org, Richard Henderson , qemu-arm@nongnu.org, Magnus Kulke , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Nicholas Piggin , Harsh Prateek Bora , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 03/16] cpus: Rename cpu_stop_current() -> qemu_cpu_stop_self() Date: Thu, 13 Aug 2026 20:16:26 +0200 Message-ID: <20260813181640.6537-4-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260813181640.6537-1-philmd@oss.qualcomm.com> References: <20260813181640.6537-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=FeMHAp+6 c=1 sm=1 tr=0 ts=6a7e0a23 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=ao8Q1kDP7eBHT8PKhbAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: PhH_8HN8K9xGnGVsNVeoKe5eV_27MJ9e X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfX3KjOagrCH/c/ sGwCiBIjReqvxVzy355klorWkeCIM4PkQQZWbTszLm9xfXCqdKz7sw81Few6ImxOKbKg6mLJNX7 PoqOa3RkT2RNCF29wJ8QY1DmHOGuhHLnvreviFhy5MVNLk1wdjVfdXZSs0SYk9Ja50Nia//WxKx rYdHnSf2IMywZDkZoxf6sMHHCTNUjMKT8VQx1hhwrTZeDZn19LPLPjs+WLOth/y4fb2OKxXHbb4 Ep6kgxOiEikKQJUnlvQFqZlUG1z9T/RSMcIcbLJ3E2hNN7JZGvE2+7C5+C96c56ITtbCA3vE2dS Fylf4SpXDcO/37OF0me/fTdXqNFZgP1AvB1ZQY1kQdugwsZ/yqRmi/QPxzvJWyaoSwMOFIUYkZB 3PmxeAWJJcukLGyjbY4r0vHMQ13q4eBPkG2pwZ+T+6CQA3i2ezhOqlpuwIBb+WbmN91l1PkKCEF tQTsS1W3Eu8OYcsnE8Q== X-Proofpoint-ORIG-GUID: PhH_8HN8K9xGnGVsNVeoKe5eV_27MJ9e X-Proofpoint-Spam-Info: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfX3mfuHem30TRO Xj7rPXhyBhX8piXF3+f65c3JhOBTF05xuEDupnxtC/v9jHZ/S7njb0WQ8GC2pCMMlkAHLymmLUU dmszj/UXontq8AsMFKWvZOwvaDDQ2j4= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-13_05,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608130132 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786645093177158500 There is a single method with ending with _current() suffix. Align with qemu_cpu_kick_self() and pthread conventions by renaming cpu_stop_current() -> qemu_cpu_stop_self() for consistency. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/system/cpus.h | 8 +++++++- hw/ppc/spapr_rtas.c | 2 +- system/cpus.c | 2 +- system/runstate.c | 6 +++--- 4 files changed, 12 insertions(+), 6 deletions(-) diff --git a/include/system/cpus.h b/include/system/cpus.h index ade13e068eb..2365c7c4597 100644 --- a/include/system/cpus.h +++ b/include/system/cpus.h @@ -28,7 +28,13 @@ bool qemu_in_vcpu_thread(void); void qemu_init_cpu_loop(void); void resume_all_vcpus(void); void pause_all_vcpus(void); -void cpu_stop_current(void); + +/** + * qemu_cpu_stop_self - Stop execution of the current vCPU + * + * Note: No effect if not executing within a vCPU thread. + */ +void qemu_cpu_stop_self(void); =20 /** * qemu_cpu_kick_self - Force vCPU to re-enter to its inner main loop diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c index 328fc27c400..80cd4246af8 100644 --- a/hw/ppc/spapr_rtas.c +++ b/hw/ppc/spapr_rtas.c @@ -93,7 +93,7 @@ static void rtas_power_off(PowerPCCPU *cpu, SpaprMachineS= tate *spapr, return; } qemu_system_shutdown_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN); - cpu_stop_current(); + qemu_cpu_stop_self(); rtas_st(rets, 0, RTAS_OUT_SUCCESS); } =20 diff --git a/system/cpus.c b/system/cpus.c index f37e215c586..1a6fd286a81 100644 --- a/system/cpus.c +++ b/system/cpus.c @@ -674,7 +674,7 @@ void qemu_init_vcpu(CPUState *cpu) } } =20 -void cpu_stop_current(void) +void qemu_cpu_stop_self(void) { if (current_cpu) { current_cpu->stop =3D true; diff --git a/system/runstate.c b/system/runstate.c index d3e64d2b625..1302fea9ccd 100644 --- a/system/runstate.c +++ b/system/runstate.c @@ -472,7 +472,7 @@ int vm_stop(RunState state) * FIXME: should not return to device code in case * vm_stop() has been requested. */ - cpu_stop_current(); + qemu_cpu_stop_self(); return 0; } =20 @@ -900,7 +900,7 @@ void qemu_system_reset_request(ShutdownCause reason) } else { reset_requested =3D reason; } - cpu_stop_current(); + qemu_cpu_stop_self(); qemu_notify_event(); } =20 @@ -918,7 +918,7 @@ void qemu_system_suspend_request(void) return; } suspend_requested =3D 1; - cpu_stop_current(); + qemu_cpu_stop_self(); qemu_notify_event(); } =20 --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786645112; cv=none; d=zohomail.com; s=zohoarc; b=ZJW1xytpEwk+U81NnNDtFRZ5mMLmZaveSHwq2kJ3M8tWpk9w3hpckr9Yk58wbyOlCLQCyjO0eZwECnP1WgE/Qfgx97bG/bSy5bFEEWLsG8dbReaBp8L1TFrTCcZ8I9xmpTu7LzBLAyB/zOkGkBTFNqImizGIBzJb2/BxiIonhvM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786645112; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=KExF4MwbTUUQ/1tzwHuPXSMnN5BfvbjHcIrr3pOpFSs=; b=SGOuIsBiNJROGpHspKn7IKeDlA1gug/9fENk7h3p6RfGIR7s197FqPKtf/xLzWuMp1m2HyGHL3pi7xV14pJoobrVuamEK6t4aP7lxb1rP7E1V+0j+LKky++8XJFHBcCXYUVQXRMuqBziAnKk9ukQpxjXugpLDyuWo1PP1qr/qTk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786645112226821.4927979284502; Thu, 13 Aug 2026 11:18:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wuZze-0002Cn-Gx; Thu, 13 Aug 2026 14:17:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wuZzb-00029I-BW for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:17:27 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wuZzZ-00026x-Q0 for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:17:27 -0400 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67DFUKvh3051346 for ; Thu, 13 Aug 2026 18:17:14 GMT Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g1fg3s6n1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 13 Aug 2026 18:17:14 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-52d8243f1bcso3713581cf.1 for ; Thu, 13 Aug 2026 11:17:14 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499877d20fdsm5607615e9.1.2026.08.13.11.17.11 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 13 Aug 2026 11:17:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KExF4MwbTUUQ/1tzwHuPXSMnN5BfvbjHcIrr3pOpFSs=; b=pnUQhFoVW11HG5T/ +qFN91c4WEKaLfjB5+LNkNFCF6vStDtgEgoh0EU3j8U0k0yi/4Z4IvkaYUhYCGXW ctvpTjdYAFCIO7uL++oSHHC3Ms2k+iB+SVUXxpHjfwaiTk/YGQHl+O+n7/RgBdjJ iGuFiqRlwn3tn6OQ4GT2IFHt82wMNMM53ScXjA0pWA+5pZ3I4z3ou+UMCvYEDw8w HW0Z10PC4LMkzTrHQbs81l3Fj3/M4KW5TjPMmlmH7chIn56rASSlLo3E42fzyVng TW5Q9f59L59gb/2tD5s8enCOZ7eJfR7bqAQhoTt9s3FSGw5JLPd/TyJDR8DlSYxU dS/GNQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786645034; x=1787249834; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=KExF4MwbTUUQ/1tzwHuPXSMnN5BfvbjHcIrr3pOpFSs=; b=IU9dEtjronhpQZy00iwpzCwarz1BeaU+qeeXr4EbeObzAXn3HljG9uJZlatFap1tOb eQyuCCVn7yyq0n06d0Z4P9n9EjUUkuhqUEBWk/kbbOwBzRElMjv7hyUZhYJCGZPy/f3L Z4O3tk5dxlgJsDbaVuWudOkh+Cl6GK7ufU+86gMc84q9kqyJ4N+ByH9qt6hDwvM32Kcz llHnmGmySoQoTTSAmP811z65ggtyehoNk/G+23lW1tAoc1DKSpm6Z6EKR53HcCNAUdhp fd5RTVHNgpHroCfAJVrD4C7AQ6iuDKH0ZOyVCuUUgnxf+2MBv0PuHXvwy/M1wx74+Z6F +Kvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786645034; x=1787249834; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=KExF4MwbTUUQ/1tzwHuPXSMnN5BfvbjHcIrr3pOpFSs=; b=pxqFZGvEAyBzMyXLqK3sVtA4UXW0CnVnSCtZFBsdBK/qixVwp9o3Zm/DzshQajF9sy dPT62aDWrHR/kbiDfQks5ucqwRRjW6YStsvQ0HnlHqg4ydr6Atb/fvRZfxACebwOX9nF 10D58GvDPLPTQ8mgeIvDzcoef8jH9U5ZB2ZOuwzmeKGamZ/c8/iQ6WSzchKHl0DNZB57 ZlL88ZWoHt/fL5lcGnvz1Uu1/mlWprQpjZrelEvdycXOdygiPzotARxP2KNbW2xXtCpU HLr0+v2k/hgA4hlLpUp1TzSjQyPaiZQ9mDz1lOe6JYwBLCJLba95gp9LWrHS9ShUiqPi PB0w== X-Gm-Message-State: AOJu0Yz2njppFEyixJALuc3DRzb3ourEtmkJmrlC20LuI+pluA3XJZRs UMO3uxNEODzrzaVBmHHcFox2bwTIk8Y6yNZpSxdKAey04KUx6vDJmJhAEP/RJoACDKQUKlLSlYY uABoYicTRCfPdu0xqIoADSEZDGHCI/PLkUFhMaovfiXnFi2aHjPfmxwQ0tsTpyxfTGw== X-Gm-Gg: AR+sD11eKuqtMjcYOKAbrybtFesBwtqei/6aSBDz4mzrCtixY3lPZaAOoSisC16qWSN mJH1OVkX0GUOrtz8MrIphZC4AX0xN2JvBaAqImEWkvzIJ+W7SDbUonAi7inAgt7+Xc3s61ze8/O x/uaasBurqIeURXzuZMaRYZ9HjytPNp0Ms9IJc+mXjSvx7ThdZunWknSBmkPfeXWIsA9O5SzFbU 2pc0hbz2E9DAOevGT/0i1JnscXisxeTlcjFk14q6geKw9U+7xUtoR05/Hi/7Iw9NJtrE9CPC5+c VCCarggtU9ezwPZjZeuy9Pk23cklY70zJDOnsGoUG/K3eI9awNXdY0Urma0Q/Ev02ubfQr4OCCz FrgvdDPyKc1607g+NZkXB3a4Dzn9LkOlUx0+Cbsch/g== X-Received: by 2002:a05:622a:1a81:b0:516:35fe:5524 with SMTP id d75a77b69052e-52d74a3546cmr70162321cf.5.1786645033481; Thu, 13 Aug 2026 11:17:13 -0700 (PDT) X-Received: by 2002:a05:622a:1a81:b0:516:35fe:5524 with SMTP id d75a77b69052e-52d74a3546cmr70161411cf.5.1786645032819; Thu, 13 Aug 2026 11:17:12 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Daniel Henrique Barboza , Paolo Bonzini , Pierrick Bouvier , Mohamed Mediouni , Alexander Graf , qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, kvm@vger.kernel.org, Richard Henderson , qemu-arm@nongnu.org, Magnus Kulke , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 04/16] cpus: Rename qemu_cpu_stop() to qemu_cpu_ack_stop_request() Date: Thu, 13 Aug 2026 20:16:27 +0200 Message-ID: <20260813181640.6537-5-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260813181640.6537-1-philmd@oss.qualcomm.com> References: <20260813181640.6537-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=NsfhtcdJ c=1 sm=1 tr=0 ts=6a7e0a2a cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=oALTtu6IgWlc6orpIWcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfX3Gw//Ay4pte/ mjNYKgZR7DImEQxX8JFJOBXYeMRiepMPv8VuMxEEWiDHhxV0KRbUj9TsYkiNlmQzhDz6ScwUjUX hY90PgEbt+mYW2gOcnanv263CPMYyBNrs2k8vtf6x4/dV2bRqhYHrZ6k2Stt9N3gCdnGWz9A5l+ JK6+kb19qte5izfjCY74pZiiPPWmxI5Y4xDOp/Zfo2hvzR4Ay3jAUc9F2EzeucW/Qpr1ST9n7h/ KX+1cuzifMANPoGX0ukP9TLGzjHLuDTtbN4JrLayP2wyLfAnnz4SSSvYWrsOHoWpJWdLdX81aXy HUgUx2ie4mckltqDEa4ME1CMVpTI56j1qQkKLCv8Kmkw1cq0R2I51BrOv7aKRLoQrpSJ75hOMkt jY4alunPVHOcM5E4Zmmx1mpofa50Jb/h8fj4pWWkSw5qyAVXLzGZLDlR22z02rGcTTrNSocUxFD 5e9KJ5OCxlgbuMM7xGQ== X-Proofpoint-ORIG-GUID: G7f4hp2N71jB3duBmuej5QnXVcG3fYza X-Proofpoint-GUID: G7f4hp2N71jB3duBmuej5QnXVcG3fYza X-Proofpoint-Spam-Info: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfX6YHndxvTYFYJ NMArpsSsjZKcKy6Bq6pEDh1fVJDsv6m0baYGDRGEsb7LsolVqgdaNaMa2nMfS2S08lZFivL3Tgg nUnv71ur4N3Rl0n7i8LSZxQoeY7RYVg= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-13_05,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 adultscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608130132 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786645113356158500 Stopping a vCPU is not a simple state transition: an asynchronous request (CPUState::stop flag) is acknowledged (CPUState::stopped flag). Use a better name to clarify. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- system/cpus.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/system/cpus.c b/system/cpus.c index 1a6fd286a81..f69558c760c 100644 --- a/system/cpus.c +++ b/system/cpus.c @@ -382,7 +382,8 @@ void run_on_cpu(CPUState *cpu, run_on_cpu_func func, ru= n_on_cpu_data data) do_run_on_cpu(cpu, func, data, &bql); } =20 -static void qemu_cpu_stop(CPUState *cpu, bool exit) +/* Must be called by the owning thread */ +static void qemu_cpu_ack_stop_request(CPUState *cpu, bool exit) { g_assert(qemu_cpu_is_self(cpu)); cpu->stop =3D false; @@ -397,7 +398,7 @@ void qemu_process_cpu_events_common(CPUState *cpu) { qatomic_set_mb(&cpu->thread_kicked, false); if (cpu->stop) { - qemu_cpu_stop(cpu, false); + qemu_cpu_ack_stop_request(cpu, false); } process_queued_cpu_work(cpu); } @@ -555,7 +556,7 @@ void cpu_thread_signal_destroyed(CPUState *cpu) void cpu_pause(CPUState *cpu) { if (qemu_cpu_is_self(cpu)) { - qemu_cpu_stop(cpu, true); + qemu_cpu_ack_stop_request(cpu, true); } else { cpu->stop =3D true; cpu_exit(cpu); --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786645083; cv=none; d=zohomail.com; s=zohoarc; b=m0ZTHkRyk0s9QYogoGmtqaAOy0XUDiVdE9+m61lSnd+QdFxzfcB+9/R4SOK96KFc8vAX+CPxIbMxjm9aHGMefib/jV4Hekg4WfMBagw72M72R2S4NHBAIbbgBpoDXxXrA3s3WxJtnt0BkrdhMpCWlciaRqL6ibyWTTBDAQ24FvI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786645083; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=pBblWYEu3w/qqK9BTavVOzUlUmt3HTlRxSdIPsShG/4=; b=mDqzHNwwMmy5iw+vAJcdfkdgvzi+iJXbDBAG0UgTuX3a0bUgs0Dp4xqT01vi/pDgXBA5z48CZmIrExMh8XAEl2A38isOfyAGy4EVM/52wnODiKqq8ZXu+xPASg272a+H88BioNkDgS3EDP52HwFJd3kQTK2ASh8E8JmZSYRQRd0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786645083484419.0383625969413; Thu, 13 Aug 2026 11:18:03 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wuZzd-0002BF-BK; Thu, 13 Aug 2026 14:17:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wuZzY-00028m-Km for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:17:25 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wuZzX-00027j-4f for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:17:24 -0400 Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67DFTkDc3707216 for ; Thu, 13 Aug 2026 18:17:21 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g18c5k6f4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 13 Aug 2026 18:17:21 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-91931144870so22902785a.1 for ; Thu, 13 Aug 2026 11:17:21 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49982165351sm77726135e9.10.2026.08.13.11.17.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 13 Aug 2026 11:17:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pBblWYEu3w/qqK9BTavVOzUlUmt3HTlRxSdIPsShG/4=; b=WI1UgVggeB3fo8UY OksCgZXZKBBXCdAFPg+/lf2DY/8samU/TVsE26g52tngSb5+7ZscGo+eHrwLLxtJ zkefDwJCn4cQjALIW1QYwMS0/5sMoGpuOaJkuKl4QR2cqYUI3KAvaDHS3Ch5h6e4 GSQzrVoYcxzSH+xnokvAjjwDqK6HDTTm+hnhCQt0Z8fyv44xRd8/3MnebzUW/4cx 4bAqk87QQWbJUUjZLea1NhxpFzVRKRkrx2rEU5H73gQKC/khXqBWgOiCO05EmlqM l/kF+E9QgdlWmYvfOrd0FOGZ3bB6QxvrI3uno8criy6uKS3eCmrAySarwHx+juxB h4jy5Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786645041; x=1787249841; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=pBblWYEu3w/qqK9BTavVOzUlUmt3HTlRxSdIPsShG/4=; b=icXct97X2VM8KM6h844rdVNPoGnmOXdk7Q/UtHhjQguijxJq2tAy7xSLnxD/7qTCdg gqAnL7+EvbfH/WAxxV6ZOt3p/gCgjbHltrO0xv4PzyxHWR2gm+ESkhr39BndRqSSWYxn A1KfoNXuq/hsf+b05FafVK8VCOGFrf90qtla5K1TdAlygVlU7Kh4KOG8M90VvP+g4+5i kwxL6RJP/0if+4MiITNHfQkl4Ca1o9duSeDPjukbGNqVklolqw2t1CWr1ZSA35c9yD/H 8506Lc/dkHa97nUPs0J89p+Pc4lPSOhZOQjCsiCJ4lh8Dk1tOuI+6OdJyH1q3Od7iLaz veLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786645041; x=1787249841; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=pBblWYEu3w/qqK9BTavVOzUlUmt3HTlRxSdIPsShG/4=; b=C3z+6LeWGmXXZH2O5VFzvvETxH+yDWRHCWCaXcjMJWuHnodQIXiBxu5XzSB/7kfKes 8nROaTm4fpa5qB0GGtkZ3kkx3xkyd+M5iYjqsE1Z2gEIpBlQC0xEBUqaFyhOH+Pi/KK+ XyPwc8l1eoz0K/DSt5mUBOQijUTqx0jXqQM14Tta3cLzgSXiKGpHspZ/P5gtdpBB1pBA pfY0WmStflBPipOSMG8n6CI1fHjZiBdJJ8Y5NiSUNAs9xZB5A1bIz3Jqx7cubzfAqmZp hRDa56XkwduHdI33AtDWUctA7se0JD/8eK7Kib8+hsMkc4jhp8XAwHlgVQMsfxKzNzcI dMGA== X-Gm-Message-State: AOJu0YwbyC9NpZMKUn0oaBprIPARaK8Fu1xy8fybRfmEsGcLEX46Nez0 8tdnvyo33B6HSvNenLZndkXSp7Ulp7PYq7Zt1nC74M1Ajhu2Pe9L7JKRh+vgksINuogy0NPpvH8 UslLUbByEeaVFVKcUeryfVuFE1GIEr1IvYH38HMHQ7edqamQDEWF6tYPH5y2wXzz2hA== X-Gm-Gg: AR+sD12D39p5qhLseaDLAFab2mn645/5My7QgIfcc1pZRaMOPWh7acWNJKKVXhdZm1X uvcovPCXcK+IXvEBniC3lJunqysmvj/yDPhWEpqStPlRzN6Yr14SXB4jvCtFP2k+hNWBtyp8uCm 3RTshfne2UJtXkLjcTitmMSd6xgAn/bPyEbc9dH/+ZAwVHoXIbCT2r4dkx7ib1jkxPnFlJCTp5F oV06WT32DeUCv/JTntNexOjM3HNVtKhw2PMGOkC0S94puqUM9rZSZCjDXg/bjV7wWRrBW6NtHY6 wZpDSZyl4YMosfehhh2qZMz6PzjNKhs36dzSTzZRjabn9mra4TGByGH2r+aWy04YLsCVz3eAt2R aUGckm5WjGdLM9swDjG9uyqoMTLO83NCkPhJo6fZvaQ== X-Received: by 2002:a05:622a:1a82:b0:51a:bec0:1040 with SMTP id d75a77b69052e-52d73c107c8mr83566201cf.12.1786645040767; Thu, 13 Aug 2026 11:17:20 -0700 (PDT) X-Received: by 2002:a05:622a:1a82:b0:51a:bec0:1040 with SMTP id d75a77b69052e-52d73c107c8mr83565161cf.12.1786645039982; Thu, 13 Aug 2026 11:17:19 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Daniel Henrique Barboza , Paolo Bonzini , Pierrick Bouvier , Mohamed Mediouni , Alexander Graf , qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, kvm@vger.kernel.org, Richard Henderson , qemu-arm@nongnu.org, Magnus Kulke , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Zhao Liu Subject: [PATCH 05/16] cpus: Improve cpu_pause() docstring Date: Thu, 13 Aug 2026 20:16:28 +0200 Message-ID: <20260813181640.6537-6-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260813181640.6537-1-philmd@oss.qualcomm.com> References: <20260813181640.6537-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfXzFu2IyizPsiv btLgjZkTYBKaj6up3X2VSa7HC3HRG9JT4/fYqnvPsQABOaRF1+7EUGJa6TvetGxafscQOql1Sg/ HUKczGhCmVLxzW48uQLo1bFw/Zt4wFk= X-Proofpoint-GUID: LDxBX5NJyxfakU2cg6-jRCOX4fEWQSxh X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfX/PMlM+KTalTE oBiV/8e+JZitpa91Bq4Bp1ylwwDP6Rmae+QyU1CC8quSNOgFD7WCXohiaNEpTLHPz2yzLwP5lKK IY7kdv3VjJR4gJ0GbAiaLIUUZlo2FKZrDvZ7+IccR7icigCU7ppAoM2katyhmPdyfzm0DPCUFDI Ev0EVIuoS7zW1u/wESP9uG7zddWTHhVpDhueWBVH+RMZFJmNN5Ov/NMsN7Dn2GdexiOllXbg5Du m10hEcAjX7mZCM37X1IymZYSx1N6BI+qtrH34vIyJEHBGmaLPdd8wMyfLhjTX/6D6WCctC8SbYe BHHqPvbr4YBXQI5ITry6QavuMSHVjAQbzZJbFg0G7FHdSiU+v+FUKJc2daQ31Xssqe61tWN0yNM cZh4YvxNQVDCm0aEbKncUpcF2gYFm+TDrepDrljpZUbcLZHlQFijoSaAWVOffWvyphDsWw+D92y EmLGQAUmY+riRu/KCYA== X-Proofpoint-ORIG-GUID: LDxBX5NJyxfakU2cg6-jRCOX4fEWQSxh X-Authority-Analysis: v=2.4 cv=VebH+lp9 c=1 sm=1 tr=0 ts=6a7e0a31 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=TUGipdnbivDJOOLMS8gA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=ZXulRonScM0A:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-13_05,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 bulkscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 impostorscore=0 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608130132 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786645085773158500 Mention cpu_pause() might not be immediately fullfilled: when the requested vCPU is not the current one, the request is asynchroneous. Mention the method goes in pair with cpu_resume(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/core/cpu.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 81af7b9ee1a..f1ac492714e 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -1045,10 +1045,13 @@ void cpu_reset_interrupt(CPUState *cpu, int mask); void cpu_exit(CPUState *cpu); =20 /** - * cpu_pause: + * cpu_pause - Request the CPU to pause execution * @cpu: The CPU to pause. * - * Pauses CPU, i.e. puts CPU into stopped state. + * If @cpu is the current thread, immediately pause its execution; + * otherwise asynchronously request it to pause. + * + * Note: Use cpu_resume() to restart execution. */ void cpu_pause(CPUState *cpu); =20 --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786645150; cv=none; d=zohomail.com; s=zohoarc; b=HeEEj/UdDyOm9KpyjUgciyB0UL8wSwH6cjKgQBX4Xf7ARdrxna5GJhZTYzJUKvPU/J5p7NutZ/m5hLrwXJBxOz5PMViVGShCXKKkBGEvoAIuFKbLKlsA31M6iu49mA82n2P4fCSOkGxPbG+EqWUHj2RaUDFDfcearCJ6JyHJweg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786645150; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=QUpkBT3vzMLzNP9l26VILjfTLo8RAThxlfT2F7nsTu0=; b=W/b+czRZJq0/layTDKmTFnmRnr/F93qPvqnZI2TMSEz7Y94H2hDp4ETfN4LPrgR2PAqFgiwE4Hl/H6LNDppi0z8H90w8SNbjLr1G2nLdbBPLt55Ohj6qg55EIXzHRLFkaOeUR77h2AseHMP8o9JAMn7gzHLOrNof8xuBIjlZ/aQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17866451508441018.2882509303275; Thu, 13 Aug 2026 11:19:10 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wuZzh-0002Dn-38; Thu, 13 Aug 2026 14:17:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wuZzg-0002DS-3V for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:17:32 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wuZze-00028s-J2 for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:17:31 -0400 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67DH8ecJ304580 for ; Thu, 13 Aug 2026 18:17:29 GMT Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g1j2ng9um-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 13 Aug 2026 18:17:29 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-5276aa86d00so2524031cf.2 for ; Thu, 13 Aug 2026 11:17:29 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f2005bcsm1283256f8f.6.2026.08.13.11.17.25 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 13 Aug 2026 11:17:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QUpkBT3vzMLzNP9l26VILjfTLo8RAThxlfT2F7nsTu0=; b=LiWQEn/GpDtpTz4W PvmQNnbfd3vyKQ4ejomX6bI1pChD74UDsrbe6/CWizDvW/rfn3P25M2G9glx6G3j GevnmALo2UA3A/cK/9AtGW1BnLvYPns32UJP4lTjUSUxEqEGDdIQVHQ0/0mtU97I cQrO5a5MUaC/OOJ6CrkAjZA8OBiVOE/sD0nkyKJV/X6U6zLfgx2nad5hDuAb7tJH oVGoVmfU9MQ4PjFb43K0KjGZPcXah8Wta2f7/xEJHZI6/1fw2nLr99adYj7NFndR 97UvxYAyHT9+K5P993ogOD9jA94/vHAj5kMxL9D1crWgVx3udsm1urUDBXeENoTo ml6dlg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786645048; x=1787249848; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=QUpkBT3vzMLzNP9l26VILjfTLo8RAThxlfT2F7nsTu0=; b=Lm1w0+khSrbGNWVtQ2O4YhLu1EawKxQ1Hj2HSo8efNrcBiXrvDZKwINfZROq2aYKAt yKTgzkxZjXIJ0GH46tHiqsFJ7vXLf6+Gm8ziHA8KWu0sUxsBVfbJfGlc+USI+IxfDNlY FMRc9TI6JSQgVP44WGQLUvDIgsps/fkWq3jSi3eCUk9fvTsOqVgW/tZ1FkFmJF82gDtL MKKBfacCD7YPJw3OcFmMQ6j1BORpvVC95GkaDCsrKX1FcSTCjwiyDxJjLcxbawO/n+7s Sndgq+rqxi8oq3bmsPKmdsAq/8LqGJwwsqXUSfNK6HLyzLr0PVdAcxgmTk0+XoHKAXIh HBIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786645048; x=1787249848; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=QUpkBT3vzMLzNP9l26VILjfTLo8RAThxlfT2F7nsTu0=; b=H7/IYmBCQvl/1fdH5ZrQ9XELL33W0Dbx941XYCe+DEqASxbLzcAhtziSFujT36xvs/ L81pybox3NeBnliAv5xKe+xk2477pA8oQ/0yVx4xQia1X3IizJL0y+NK2z8bmXjxdYwi dBDeeiXP7Mwz/HuKWwfyFygkue5AXl50CVHWftURl1t7JpTx2jrQKMQ/Xs/vNcvooWY9 yV1LrgSlT34+PMjRpz2nA4nQhxAa55Xle9oT36oKHfsARzOqDup3q1r1p0HKmmRc2kEv 8tctDq/AgjBZgHus8krUXs3E3CO0WLNtwwY/BfI2BcjJwpb7dLZfkGS9k0Szp4kk0f9s Zj1A== X-Gm-Message-State: AOJu0YwllCmzi8PRuCLfPHtb9erRdEvbj7RwRhL4V9oTiW1f6jTiFM+v gg2mDhHCqdfTD/7OZrv3DeaCak6EVjyw3UqYMVAzO4k8QnNyyB/CAk8rcwK+PCv9EOEWW+aMcZj l3Yps2Vsy/rrfJUppuHTS0TkLXXIdE2Wj8EiN7Hm2hgvu/+c1Ql7lzZt7rtTFudfh5Q== X-Gm-Gg: AR+sD139bruXiiQZosMF6jtdOp9SNLa/QZtHDJk0pM349/47buR8oNqA6g01YQP79+2 Y13l1+8VQTlYZ9GH8Z0bMDbr75wrFk/zetfFtmq4ylm/x8RxTCSRxIpBj2M5tfk+pyvzeBa2VH9 ZuxvX0orc3Vf+OmqSH9Hh39Dshb55Ha/bY1E7S70ylo5FEqSDk6NstftY3FMyME9EJfYUrhao7c m8qh07Q8B7DMApFS8kn2XwMOkx/QGg2Ppaes3Sl0eVthSUPx5BExtO3ilfcUUwrhVRI9hlsRq4J x3MQzDHZKZsTrNJPu7h06CRfooAWU6O2b1SWX4P5wwmd5rRI4Bafa2F/5j5SJ4srpNok8rpd5qg ueATDWQPQ7bvXPrvO1tW6TVmD3R8HjMJmVoAEJrmkAw== X-Received: by 2002:a05:622a:4c8e:b0:516:dda7:51e0 with SMTP id d75a77b69052e-52d73c8c646mr95095941cf.17.1786645048008; Thu, 13 Aug 2026 11:17:28 -0700 (PDT) X-Received: by 2002:a05:622a:4c8e:b0:516:dda7:51e0 with SMTP id d75a77b69052e-52d73c8c646mr95094951cf.17.1786645047369; Thu, 13 Aug 2026 11:17:27 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Daniel Henrique Barboza , Paolo Bonzini , Pierrick Bouvier , Mohamed Mediouni , Alexander Graf , qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, kvm@vger.kernel.org, Richard Henderson , qemu-arm@nongnu.org, Magnus Kulke , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Zhao Liu Subject: [PATCH 06/16] cpus: Improve cpu_exit() docstring Date: Thu, 13 Aug 2026 20:16:29 +0200 Message-ID: <20260813181640.6537-7-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260813181640.6537-1-philmd@oss.qualcomm.com> References: <20260813181640.6537-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=ApXeGu9P c=1 sm=1 tr=0 ts=6a7e0a39 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=2BIhYVGhW6Jtnc0Cf5gA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-ORIG-GUID: -L3lqzL_4sa6ihG7gbwW9hzhYFxGeX0w X-Proofpoint-Spam-Info: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfXxuxIE6Jh9z6f pJB3SHoHDi6oFQfSY0ezcRMgOdfqCzGmPn7G5dWQVH+WobhwjfN6cJMwZbKH3ebLbkMDSNdE28L +gqGGgadRXB22D2vZb2fpymQsd4/mos= X-Proofpoint-GUID: -L3lqzL_4sa6ihG7gbwW9hzhYFxGeX0w X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfX63aDx5ZhKXzh WMpns9b+HNAcDJojrERsWe1T31I73jsV0V8C46g5e5kS0bfsSGihE8sh33HRc5ILLyH/hlqApu2 NrHyJi0eUgxtzyvFAsuzrrNIa4qosVop1g0b0ckPeIUGPcEheBsmNOwudzFmP+Aukq83JYsJuyu rL5+aUTkVOnQ8eao+k0FVRKBUV1rVyvqwhbFctXQbLE2jJpetvU26WEnxfLLZIOuru2nPGv57pz q4UGlBzXqd1+OZtpvSOZ+UlcWC5sC2JRa5UNcvKYn/kIluz/V/cgkzS/g0bPyas+AIHGALG0NuO X+YIW60YRKDgqmPZnr6wAKKYUOjWjPN45m8xoR7SqljG6zUnsmlPWPqIcSg/D29uy2sU2Aj0A2u 3A6MUfiuqc979D64D9ho654cU6r9wc+Q+af8K325LRoMVIsZwRseTLPtjI6sYg1J7XNizfGAIW3 vZUGRzsES/XKGi0KGzQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-13_05,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 adultscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608130132 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786645151729158500 Mention that what the vCPU exits is the execution loop :) Mention some of the reasons for calling cpu_exit(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/core/cpu.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index f1ac492714e..7da81f3ee85 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -1037,10 +1037,11 @@ static inline void cpu_set_pc(CPUState *cpu, vaddr = addr) void cpu_reset_interrupt(CPUState *cpu, int mask); =20 /** - * cpu_exit: - * @cpu: The CPU to exit. + * cpu_exit - Request the CPU to exit its execution loop + * @cpu: The CPU to interrupt. * - * Requests the CPU @cpu to exit execution. + * Request an immediate exit from the CPU execution loop to process + * pending work such as interrupts, timers, or other async requests. */ void cpu_exit(CPUState *cpu); =20 --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786645094; cv=none; d=zohomail.com; s=zohoarc; b=Kem2yAhF/BYzqtuniUQGmLIpr5WGDAX2zVu5viLKHGeXIbGUYUSF7x9kjf03jTQVo+zy69e6LCitw2t965Aw6KYsHlYsQ2mtBchO84qqxN+g3uM3n06elL2bDrRXrjJcCNqPsZpYoEpfGa608e4GKUFCcR1mZKrlV1QVmJEjJ44= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786645094; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=sfQPhzstlT3wFstnUDQR+/OGDWmf4BOlIE5Yj0Rzf9I=; b=bXxamnd4QZKCa4asByGhkb4nBY7q3/fcmYEkiLB7ELYlE/W7lXppfX643XymLGROYYRPOoCMT8JtwdYFNoQ7lHI6mRFRhlUSnknJBFlpbjdGIFEkmrk3HvRZhhgbOTCMFNe4+dEd6eyPUR9c0X+RYy8LinGwZEZxsgziLFRAkGw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786645094493540.4264376016737; Thu, 13 Aug 2026 11:18:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wua0B-0002WP-VI; Thu, 13 Aug 2026 14:18:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wua01-0002OA-Qp for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:17:55 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wuZzw-00029r-8q for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:17:51 -0400 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67DH8EIj3052423 for ; Thu, 13 Aug 2026 18:17:36 GMT Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g1j2f09w7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 13 Aug 2026 18:17:36 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-5283df62d68so2940881cf.0 for ; Thu, 13 Aug 2026 11:17:36 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49981b0f4afsm97444205e9.5.2026.08.13.11.17.33 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 13 Aug 2026 11:17:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sfQPhzstlT3wFstnUDQR+/OGDWmf4BOlIE5Yj0Rzf9I=; b=LO5+V9GJKwL/u3SB hiqHpTZea6BHhcnTuECZnXdPEBPwkMxXVqE66wlDc63j40rvFePmhDw9iKJPRbOn Z+eo324Sinad8WjGYvFfxTsM50BDrXkiW+hBndrbJVl/IAuVMzivZlWMbeSOAiEP 53Cljg/2GsoWxzwBX/HDmJ0+ZSb5+Vb7HtNQUNSIdpN0sb2nj93KI7Lbq8C4wE8M s3uGYqWqx/g2v4i89w5JZmfWzwHW355aTfA7yGu/SM4ePQ42xf7I93MtUrLzuh4y GhJzU9JKIi/7e/HJSW47KAzi21N6pJLR6TKh0hG5MDWjccNAN++IJhEltP/U+st8 HVm5+A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786645056; x=1787249856; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=sfQPhzstlT3wFstnUDQR+/OGDWmf4BOlIE5Yj0Rzf9I=; b=F3q2a05ESVdKWGydb/Cl/0x1QwoC3lCLW7FlCIlKXjBCgD7o92sr2Hse/AIco5UdVA cVjThgr0zaJpXrTSbXzNabj2iW76gUwNVqNWBVzFjZhzgfbZlj4wRNNYcL+YV3rE8Mi5 ZNCLxIG3J1DTwoXehKivXgSIyuKoeYF24579kvdLdi0hVDTTWucajdOyFuJR2z/7Sy4h FrkWba5Rm0IRASxDc17DwY8gBjkU6GuptEX0HELCTQP5Po345lwI0fGlERabZJb5ZAnl f/zQpTRrhpClUZIvIbfU5458uymBUEj8H389emlv09jC8LmBt/l0j91nlNHSlEhErqmT o7pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786645056; x=1787249856; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=sfQPhzstlT3wFstnUDQR+/OGDWmf4BOlIE5Yj0Rzf9I=; b=eVlEF+h4FcZOStf4luZ85dSruX9gfgV25omZpxPjrOSLRvIixgS/6MCCm4poaJlhLy Ws6a6AMWKg+aShALH8yRhWMJiYTUA7yy1oHlHy80h6R1qeWeHxXfnU7ELHGcBK0G0rnl cjZHkjsxzM4pkSkNOBu5vCgPjscK+Ci/QugKjGtQxpm5NO1oqfoLqOgH0jsNjyGqN6It hVTOZg7y0Pcq+16G6PawbCh065FYZShCJtQVeftl8P/nSJYKXWy/WaEbMPq+WiDKR+1T yatc9WqVkMiHbowE++JenK4aiEJL/KkD+j61UBkYQo1DirT8V402s3Tp8DsEec5r+O0U UjkQ== X-Gm-Message-State: AOJu0YwqdK6YMtmsYYuH+n99rO0cz9nhrKeCLhiUr/HYvAOUUL0WPKNJ 4+uI3Vqg+HrOEzF8teh/oh23f1qS487zaCoEGPsbM/+pYiSMrEtMDesMUMTLLx14q7tN2fxcsjx sKxwcaJsDkMebEkZlugZAkLN9hSldh1klKjRy/WtIRbFCunp8+Y6eV/V7XjKRxOjrQA== X-Gm-Gg: AR+sD12gAkugfVPRSdOk/7RLDpL13kuTkZCSI3r+nPwZOiDLJNS6yLQsbkVN+pK79g4 59sHGNhImhsSCR/bEHYXq8g2ZYj9p5bd0nVH5W7zi/CP+gQ0l6zPkHDueZn90vMcaRpvtUgHTbk g/cGbTbb7oHCbIIE+0swVSFSMVfvZqGxha5FZkX67nJVnCMvDmfk1Z408nhiDdy3o2/JtgUB2Lp 7ilyMb+ax9AgTfs1RL3HuD2DubMW80GNG60WbXxr3Hc0JA8afbUS8nyqkcQoqKeb1qFiu5CzXDA DuhxQLuXD253ug1JugW40lhfLk/Jfw2yv2lxUy1VYNxaZXs3WSpc17u6kM//DsHZJFQhuVlUtMt XTWnIRQjVfJCSX427UughLdCpPr5x6Ll0WXA+czB5PQ== X-Received: by 2002:a05:622a:1a8a:b0:528:3471:937f with SMTP id d75a77b69052e-52d73d3724dmr92389971cf.29.1786645055394; Thu, 13 Aug 2026 11:17:35 -0700 (PDT) X-Received: by 2002:a05:622a:1a8a:b0:528:3471:937f with SMTP id d75a77b69052e-52d73d3724dmr92388851cf.29.1786645054663; Thu, 13 Aug 2026 11:17:34 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Daniel Henrique Barboza , Paolo Bonzini , Pierrick Bouvier , Mohamed Mediouni , Alexander Graf , qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, kvm@vger.kernel.org, Richard Henderson , qemu-arm@nongnu.org, Magnus Kulke , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Zhao Liu Subject: [PATCH 07/16] cpus: Document process_queued_cpu_work*() runs on current vCPU Date: Thu, 13 Aug 2026 20:16:30 +0200 Message-ID: <20260813181640.6537-8-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260813181640.6537-1-philmd@oss.qualcomm.com> References: <20260813181640.6537-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=FeMHAp+6 c=1 sm=1 tr=0 ts=6a7e0a40 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=--_MrfCweEvJdlqdJWAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: sekImEYjzhj44YWfA61NIdtYVucKOlfi X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfX6f4mWy9xp6lm fmY3aJG7liAQU/AxOvbKMPLWs2vHul29byUPYwErycCOK2/wGRy0A4sWMfmYqQ48XQf+XU24Soz dFIkZlxkVpS7MwOnEfD5p2HzH0N8J9a3e1NJQ2oMPeeSpmuD0/18a5+OIqfBG0mhnDgC0WeBYc4 tx9pBfSUCP3pEkRhT5AJBQ/uD3s6DMrTbcOxIQkUiLM/5iONeRm3Ui9rXmd+izXP9eXwoOkZr7D xnR4sRISQR2bNAvAa2it0GbXrwvyHXfBPumNglPxWMEWfrlkmBSvakMIzDbe+YyA8nsUQYKUtre iDfpS9cpbatDaZjI9VlfAj8JUcXm32hf6xQ6qDKMJ4CCksFhJxj5E5xd8uZWVeHzeFblce9FaoY PV3Aw+98+QTTGS5uNcI6YIF0SCAyUM2gOB+8c9PDdT40DlzFttobvyIBk/eaLVpzh6HFQrQ6gH/ s+oYM6TonhUUVIWEy+A== X-Proofpoint-ORIG-GUID: sekImEYjzhj44YWfA61NIdtYVucKOlfi X-Proofpoint-Spam-Info: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfX/hDV0AAu063s 1qlp6XcqqWn5vCLB9CIH4+27hTepRb9Kh3xcVzBu42hRCBDENE3Upeg7ODPrIYeQ7vO8Te0iyUs iAngxtYIFqjnqLKuNe/txg0c1pmG+Yc= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-13_05,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608130132 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786645095280158500 Mention process_queued_cpu_work*() functions must run on a vCPU thread. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/core/cpu.h | 4 ++++ include/system/cpus.h | 1 + 2 files changed, 5 insertions(+) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 7da81f3ee85..183ef9f4ef2 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -1081,6 +1081,8 @@ void free_queued_cpu_work(CPUState *cpu); /** * process_queued_cpu_work() - process all items on CPU work queue * @cpu: The CPU which work queue to process. + * + * Must be called from within the vCPU thread itself. */ void process_queued_cpu_work(CPUState *cpu); =20 @@ -1179,6 +1181,8 @@ G_NORETURN void cpu_abort(CPUState *cpu, const char *= fmt, ...) * * Perform accelerator-independent work after the CPU has left * the inner execution loop. + * + * Must be called from within the vCPU thread itself. */ void qemu_process_cpu_events(CPUState *cpu); =20 diff --git a/include/system/cpus.h b/include/system/cpus.h index 2365c7c4597..0bdb231b996 100644 --- a/include/system/cpus.h +++ b/include/system/cpus.h @@ -17,6 +17,7 @@ bool cpu_work_list_empty(CPUState *cpu); bool cpu_thread_is_idle(CPUState *cpu); bool all_cpu_threads_idle(void); bool cpu_can_run(CPUState *cpu); +/* Must be called from within the vCPU thread itself */ void qemu_process_cpu_events_common(CPUState *cpu); void cpu_thread_signal_created(CPUState *cpu); void cpu_thread_signal_destroyed(CPUState *cpu); --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786645324; cv=none; d=zohomail.com; s=zohoarc; b=jk69rmON/T3LjghFnWwU3FuwRn1QiuXHJUg/DHQtuk9KT6qA+crSEOjYcRq10svI+JmOuYPzKcvFIYWLM9ZYl2ljJtSJOxw0nbzsYWiFs7kDt5m6satd9XGMc+AXJIvmlRI3eaa8GTa2CX7D7cjhK2z9LWtieLepkTyNY1FhCUs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786645324; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=TNlVfOVc1/StZ0tejxF/DIFWBXRWATBfirtcnn7at9k=; b=N87EqyhrY9eLuplCS5rdh8tZvcDbJ1NzURiOUtvVlqK4JKZUMphYy9mwJFPBXL73s697gwX3yEOAXSsQcau5HmvkG+ok4mnVhTT0snsmqTt2n7pyJV/big12RSzh6MnPZ0er4N8z4NVyURg0JE+Jnz+45LF5a0E6S3n7NhhCTAc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786645324390356.4810396357826; Thu, 13 Aug 2026 11:22:04 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wua0y-0003OR-Qe; Thu, 13 Aug 2026 14:18:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wua07-0002RR-4c for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:17:59 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wua03-0002AS-KC for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:17:56 -0400 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67DH8eSu304542 for ; Thu, 13 Aug 2026 18:17:44 GMT Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g1j2ng9vp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 13 Aug 2026 18:17:44 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-52827090cc5so1480821cf.0 for ; Thu, 13 Aug 2026 11:17:43 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4998777ce49sm4934935e9.2.2026.08.13.11.17.40 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 13 Aug 2026 11:17:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TNlVfOVc1/StZ0tejxF/DIFWBXRWATBfirtcnn7at9k=; b=dlySNfuvX1efQkMC 9+3mRkMFFfE6WwzPlKTE6Zno7r/oRsmgukyCB24fkQ7PChBL0iHJTFY26OhOfJf6 ZwHMipMX9OV044H3+Ocb6Zc8GPSOwREE1hNiME+RIPWCFOXsoi2yBhkdffJ+KVur cBbTkOH4KNQcoZ7hTLlDRywUi22ZG3a6fsUKpM3y0kWkZYr5TWR7d2iYkzq01s/y 89lMfoBnw1WXxCpdd/NYZFx+hugi8NgRTsSdMISy5uaAYC3PVqv+6lsILh4N7ZH1 G7K/ZcNnNSxLndzFfJcI2Yqyi467pf/3Q1WYYlaDrDZ8rbRIOTwFOEeoNg0O5cFL /vsbzQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786645063; x=1787249863; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=TNlVfOVc1/StZ0tejxF/DIFWBXRWATBfirtcnn7at9k=; b=PLjW1+jU8Qd3MW/zxCVbd5E5bdmXORMPpkGVIkrXH4OauczZBmuQJ+3AdO3Eo6Z1rD 7wZGpIymsQzAmt22QO7dgFwPF4LpbVwSqbf/MkMWrQT8SeQMpYLz8TFNwrgzhEjV8IMt 4gZ8bnpj7iS+Wg3eF4F6S21A1NVTdd64wgpYNVh3/NOM9rtXPMahibuq3+3BSNK+zoyo joPQN4X9kD/GacsgaIWKXnLTfhFTj4IMwwxeGmGiW71QRfrjNm5Q+XDRmbaKcFPG6Up3 clmmuBAz4jMdXtD+Ag7mg0Uq8j2Hi3TKxRqHXT3lx56bbKIupVISumU+n3PSc+glGZ1H k40Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786645063; x=1787249863; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=TNlVfOVc1/StZ0tejxF/DIFWBXRWATBfirtcnn7at9k=; b=RWu3YytTKsQ9KaMfPT2gzOgX0OfU+m10cr+iKogBUUKdrS4a9MqFTd+NjRsRZw9RYC elU9AaIWTcv8c4wRjIou5ZQ8X19oiPLZXbH1vfpj4laA7CU9w/3Fh42sYfGAv4SWbKbp V1e7ql/eP2+qK/g84ctq1GnCXlY8D7td5kvTrHM3zywgfPRDJnDmO8Qn9fZ+b3yBoAFA o3/xz9Sd7cjZrNLpFEfiVsekhI0oAs7fb2Z5zxTm7WtyU6TcB/4CxgAg+4x2duW9rF1S Erquxo1hfVBmWu8djE20fdJ1FDvylYO68x/jsRqsOr8qCPWsbzD6dq7HoZCh6udX/23M qmjg== X-Gm-Message-State: AOJu0Yz0hiYW0q59ob5wJZxAEBbNNoIaqYgs4k4H05n2bS2kZ3BEXNv6 xIoMjmC2FUAdpBd4d6PqIwhhjSpUBbp8b99NrfjxqKPlV/PEzbEPuhFttpH5yJBxSFEABMlFbUO sC7LhCmTpg1w3bPfYYrtub6CZj9QC/WA6XRSEsRspaI4iMd8LEmxUnHd0rKz6T7ZSlw== X-Gm-Gg: AR+sD118argtCpVrIyVYpx41a3C6iTKvyzwloEhoXqE7deqspcJckn2iUffvG++1FBU BXU4RMtESlnEWNn3oEzPme4EWXJFWgCHDwpNeyZmn1vHRLtl1xokQu891v9HkTPibg1Y8ddTlMD OCKecXP+MSeiyyexbeoiXGyUfuLUyqb2HXz6NpsD7qlxtpyLBlWpbpqkE2jSU73DqoM8v7LDv3k o3+T0jxYzv9MPExQ1GiTD+ayTHCKcw2LrGFAPesczNTruIGA9IOJ7O1ji4L7dpze/3u4V4NciXy iKxBk2GVxCFQXBjzkf/kjfXjhacRf0TOvVg/pvhwfadOPy+tBtIqp/Lo7rpNvxbSx/s7wp80XwD EBRK8Fcr2HEuRkfwqqBc7h82iVBw3a28Q37frcsrEXA== X-Received: by 2002:ac8:5d53:0:b0:517:c582:9161 with SMTP id d75a77b69052e-52d74a6f672mr72352131cf.7.1786645062903; Thu, 13 Aug 2026 11:17:42 -0700 (PDT) X-Received: by 2002:ac8:5d53:0:b0:517:c582:9161 with SMTP id d75a77b69052e-52d74a6f672mr72351051cf.7.1786645062216; Thu, 13 Aug 2026 11:17:42 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Daniel Henrique Barboza , Paolo Bonzini , Pierrick Bouvier , Mohamed Mediouni , Alexander Graf , qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, kvm@vger.kernel.org, Richard Henderson , qemu-arm@nongnu.org, Magnus Kulke , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Zhao Liu Subject: [PATCH 08/16] cpus: Slightly improve *run_on_cpu() docstrings Date: Thu, 13 Aug 2026 20:16:31 +0200 Message-ID: <20260813181640.6537-9-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260813181640.6537-1-philmd@oss.qualcomm.com> References: <20260813181640.6537-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=ApXeGu9P c=1 sm=1 tr=0 ts=6a7e0a48 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=dWi2WT42hRTxaHT5buIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-ORIG-GUID: uHpXgl85M8ZzUP_rU83bnsrrIuH8DNP5 X-Proofpoint-Spam-Info: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfX2zEaXN5bErTd 6YFVuao1Mj4E6pVbiE788AZoIlFkkTlxeOMz0pyhZ2uapIsorbjwkKMXiIXwDrKwr2NSREjxbXy av25lFVCBtMOiAmigM2ohrcIVLPh4W8= X-Proofpoint-GUID: uHpXgl85M8ZzUP_rU83bnsrrIuH8DNP5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfX+Xs9795rkS0M an4k0yFzBISSc/G4LwM8AEmBZ/XTNQZrKts7OzVD6DIZVH7wTJWrYIPACpoo2mHPzhktrDRgiCz SX/8GYV8jYQ3ngaKEBbZ8bhDDzCAMigrHjVz7A79bvZ7wBApc1RjvdTFA9E1EMWBgoxeyI6cSZI El2f679n7vsh1THliLwkan8IR/XaYvpavfOl91DXNzcjhf4HJAd07o/YSgktiHPsWLjL3hXeXxO oz4hFKwew2pX8u1GyKfDeKgNEZUAx5esHABw+36L8PHlyzVwF9jt3NT6T14MHQF3RBh8jX1okPt NfoXwS9axigjHG4fS6mg6DihiW45OUoa3NuXBk/Qpf4/bmh8cQzZrXzFYyJoQuItDbpw5jsvGT8 +g6qqLW7PeoOSTW1w9F7O4cVO4r06jAQ5MU83tNmGN1dBYrDvSU6yKfCQTNTiPRy8/SP9v+nCov GKb5/EHW5UHG0U6M1fA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-13_05,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 adultscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608130132 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786645326468158500 Be a bit more precise mentioning BQL use and blocking calls. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/core/cpu.h | 36 ++++++++++++++++++++---------------- 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 183ef9f4ef2..d610f87abd3 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -908,36 +908,40 @@ void do_run_on_cpu(CPUState *cpu, run_on_cpu_func fun= c, run_on_cpu_data data, QemuMutex *mutex); =20 /** - * run_on_cpu: + * run_on_cpu - Execute a function on a vCPU and wait for completion * @cpu: The vCPU to run on. * @func: The function to be executed. * @data: Data to pass to the function. * - * Schedules the function @func for execution on the vCPU @cpu. + * Schedules the function @func for execution on the vCPU @cpu and + * block until it completes. + * + * Note: The caller must hold the BQL. */ void run_on_cpu(CPUState *cpu, run_on_cpu_func func, run_on_cpu_data data); =20 /** - * async_run_on_cpu: - * @cpu: The vCPU to run on. - * @func: The function to be executed. - * @data: Data to pass to the function. - * - * Schedules the function @func for execution on the vCPU @cpu asynchronou= sly. - */ -void async_run_on_cpu(CPUState *cpu, run_on_cpu_func func, run_on_cpu_data= data); - -/** - * async_safe_run_on_cpu: + * async_run_on_cpu - Queue a function for execution on a vCPU * @cpu: The vCPU to run on. * @func: The function to be executed. * @data: Data to pass to the function. * * Schedules the function @func for execution on the vCPU @cpu asynchronou= sly, - * while all other vCPUs are sleeping. + * then return immediately without waiting. * - * Unlike run_on_cpu and async_run_on_cpu, the function is run outside the - * BQL. + * Note: The vCPU will hold the BQL when executing @func. + */ +void async_run_on_cpu(CPUState *cpu, run_on_cpu_func func, run_on_cpu_data= data); + +/** + * async_safe_run_on_cpu - Queue a function to run with other vCPUs paused + * @cpu: The vCPU to run on. + * @func: The function to be executed. + * @data: Data to pass to the function. + * + * Schedules the function @func for execution on the vCPU @cpu asynchronou= sly. + * Unlike async_run_on_cpu(), all other vCPUs are paused while @func execu= tes, + * ensuring @cpu has exclusive access to shared state. */ void async_safe_run_on_cpu(CPUState *cpu, run_on_cpu_func func, run_on_cpu= _data data); =20 --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786645202; cv=none; d=zohomail.com; s=zohoarc; b=epsMxsxR9UtZVZz7ODgts6vIMMxWSRq3L9q6AKy6jLl4GyHosGjEj763LSd70dYj50orBW1JSn5tvZCebI+2mYi69CL5VbOBD03CdoXkgrLzWLP7rYBKn1FV5bCOfIIaRvMt1nMtO58kTdK59NA68fGXahFR96JPpRvbbXp2Ke0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786645202; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ljSN1UdHSOnwLMjuyKlwazgFwW/6t/xeE/JxhEIwvSM=; b=BdWfaabPoLHyVlHwmmOdLXBFOcJRynb2dCRvYBjaudKNX8mkzQ2zOXSGDTmlKCt10D7jS12jihLgwWOWLDqtQyulVSqm7VHgVyLEWDLOj/ZnlMA4GZN2Rn0qYPHLzfs9f0RNvWaSrXnDONwmCdsHTnC9/TOeIjVtSOKaiBv+wVU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178664520212753.133037600850116; Thu, 13 Aug 2026 11:20:02 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wua0L-0002gn-KI; Thu, 13 Aug 2026 14:18:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wua04-0002OO-29 for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:17:56 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wua01-0002BB-Id for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:17:55 -0400 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67DFTqYE3050661 for ; Thu, 13 Aug 2026 18:17:51 GMT Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g1fg3s6qt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 13 Aug 2026 18:17:50 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c1d137a68so3530351cf.3 for ; Thu, 13 Aug 2026 11:17:50 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f200752sm1249951f8f.1.2026.08.13.11.17.48 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 13 Aug 2026 11:17:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ljSN1UdHSOnwLMjuyKlwazgFwW/6t/xeE/JxhEIwvSM=; b=oF6mDawxwkUKSa1V xcOKuQGaulTHe6MaqdEQt+oUJaarZ/BGKdWkvD5uOrBhWgs38ptGSCSwpt1DNc5J H3TGCA5+VScZp8Y9s2gvHJZEqaaR5rI3TxImWTOqv1Y5tWAGU0nFP8GTWSUtw8DU 7sbP9iGBCxQjm7AJQXAny+4xkNzn7u9TosWRTEOw1sHEcWWm6NYJSvG04Ta4lb9M ANRqLlMxzGdYicqrIIWVMpqg+UHDAnvG3OYf7RJiGBSSWjhtjW0HUlPOflFnyXqJ 2GfjGd3bZDBGsm5hfxz8mZKU2Tcsc8aMFQeL/lxjmAmkzL2lR+UD+onlib6ZjE4i AwEC0w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786645070; x=1787249870; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=ljSN1UdHSOnwLMjuyKlwazgFwW/6t/xeE/JxhEIwvSM=; b=AdG8izOt5kkQFt1RMLpPFVE7qAjkh4tiE5WUyzOoOAMchgnfM1mxkWgbjgfsA3Niwu 48CyLLuVHs8Mm9J/qUDOFQw9ILbI6LLOXHrsZcf5dy+wS72wTISFml7SO1puZQhZjwrr ByuyYIgqCqM7G29tDJclgoH1KUJyHd702ZzqQojUWZtLB0uXlFnkyTIQOGgl5indu4dC 9jcBPBWE3SqsZfiY9sDAAnV4krCCBN64/cAE4ELLlTIXMznpXcgnKRCIngXpHeRgp1u3 9ijTvti8q4QI5d1A1acGF68cIvD6ouNYXCO/7lLeO/bZBhKA3+GrvOsN+tcE6QXW62J2 wxsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786645070; x=1787249870; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ljSN1UdHSOnwLMjuyKlwazgFwW/6t/xeE/JxhEIwvSM=; b=T9ww/EUOqOZaGdFETOKsTL7MAdP0WHDuCyQE5EDpHpS+Ip5csvq1Iy/BWqkoEYy+Mr HAjROdPunpiLsYAM1csuI//VHET4lfdyiqYD45gHye1RLqV8s3DvmLQymZEsjISvqs2G kl4PJCEFoQsR1HqAfWROMEx6f/unNkCqpZWjOyCSdYgt0rTFPXWgdDqgIS0MJGctIvlw 3ZtsUvKx14JeBsvpZQbhV8/nOJI2VXOpb9GcIzXGw2e4zX0wX+U/6XQaHeHGic8dzlyE eVSM6VlJdcawQE76d9QLiSjLGvNeiAQw5RmZ7f5NmQHQ7XR13NCzQiYhGebceibY2dv8 nEgA== X-Gm-Message-State: AOJu0YyCwJd24SuP//rNu+e5FxlXVF2vmko5VTBSV28mp3GA/ekzmAIq 6+2Yu91tT65NymscOEQxMRTwZONGPKGK/GfQJNqdDaLTbPK+WYd9C2iMPKP/T+qx34PN6mdw+YD J3j5UjOKrb6L+l6xdteX59Zc/iE5CWq9PdQEmNLwwa/UqB9tVxAfktfqTZWklk/zqLA== X-Gm-Gg: AR+sD12k2En+OW0eQWvml+RkX3u+A93rleHnwsjTzDhFDqKewbTb0dT5VqY1mDACKMx iCz3WDYQTKexusDypSDfAC3MkDMUPToeAk8QmPx7WAtMtiETId7vvt5E2Z705il6hdNd9CA9f/E fzuzIgRcHgM1ucsDSc6cTKjJ0TtPpwmBt9vk2EDGCx+2JsJayvjnSFQgcaEB0U2DHdmtXg9Scch rgXg7qwVUFIKMeeCN6M55Rwn41N4mQI971JlxOwVusmX5oq+DFFnLr/6PmzQ+Z5NHdmJkYJqQcS 379E/wm/1E1fxrMPmt9npl5H+atSRZ909Z2bRirTUv03c5U24rP2MKfvMzXz5QXNQashAmcOstW ulfj8u6dEXBp+v+TW6EMdW82v3vN+mKWv2GhOXO2hVA== X-Received: by 2002:a05:622a:428d:b0:51c:9e2b:a79b with SMTP id d75a77b69052e-52d73da5717mr100236741cf.30.1786645070023; Thu, 13 Aug 2026 11:17:50 -0700 (PDT) X-Received: by 2002:a05:622a:428d:b0:51c:9e2b:a79b with SMTP id d75a77b69052e-52d73da5717mr100235971cf.30.1786645069462; Thu, 13 Aug 2026 11:17:49 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Daniel Henrique Barboza , Paolo Bonzini , Pierrick Bouvier , Mohamed Mediouni , Alexander Graf , qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, kvm@vger.kernel.org, Richard Henderson , qemu-arm@nongnu.org, Magnus Kulke , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 09/16] accel/tcg: Use RUN_ON_CPU_NULL for tcg_commit() callbacks Date: Thu, 13 Aug 2026 20:16:32 +0200 Message-ID: <20260813181640.6537-10-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260813181640.6537-1-philmd@oss.qualcomm.com> References: <20260813181640.6537-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=NsfhtcdJ c=1 sm=1 tr=0 ts=6a7e0a4e cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=xzjjCr4z5Sshx9Y3hZQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfX6mTT/kdY/yJm iAzntFNPqSk2i0x2WRUY5xWfg5j9H9N1ocWVc08oIoxE+/xsVeISEIGMIERJvtVGtvctdMAhbWm UM4ZmheC/4VU+HgqrphOtoFqcTG7qCzW6dynCqDi+lINp45+44Nxn5/f15yoGxZR9IWbXP5TmzF cx58hM8uJzzrMsFict1SxaErz8fdvEitZWu0V+Y/19+mEjYxOCfD2dmbcjkxbiX2K70xgHHy3Sj MJa00nbk/QfLBhCrVsiU76iIxD28wSbMbBuSWlvFT63sVQTI72oUEbrGMU4D+ilR6apdvtREBRz BMdTYQ/xW82xQwbuE8zU5hadpktNIpGzSB26DRaeedrIiF7Eid3NZ3NcMPCUbEOAZMIhcnPWTah f+nrm34nm6FDHdE8gwGSd5Opr8lUXw/1HkZuq9mDk7qaobMkAcWqoxOa5lkwsiy8Vc7HmZkpvZR 2nCf3vubluzHB3G2kjg== X-Proofpoint-ORIG-GUID: lbEFRT2SCGlBZ6doAchhwpfNTcQhvk7k X-Proofpoint-GUID: lbEFRT2SCGlBZ6doAchhwpfNTcQhvk7k X-Proofpoint-Spam-Info: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfXwxZs3jE6VAP1 WUmFeYPaZQcE6rG3bbr4m2TsILTe3FbcPGet6oxijaPEC6TBYvu5Cxx4GdrMx9Evjy024gf922v 0SMbM9YeptBjiHTM0M46lRQzHqu6NMg= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-13_05,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 adultscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608130132 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786645203796158500 tcg_commit_cpu() does not consume the thread-local parameter. Replace RUN_ON_CPU_HOST_PTR(cpuas) with RUN_ON_CPU_NULL when scheduling the function to avoid any confusion. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- Maybe this AS parameter should be used? --- system/physmem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/system/physmem.c b/system/physmem.c index 362a00f76c0..b97016b1303 100644 --- a/system/physmem.c +++ b/system/physmem.c @@ -3088,9 +3088,9 @@ static void tcg_commit(MemoryListener *listener) * all of the tcg machinery for run-on is initialized: thus halt_cond. */ if (cpu->halt_cond) { - async_run_on_cpu(cpu, tcg_commit_cpu, RUN_ON_CPU_HOST_PTR(cpuas)); + async_run_on_cpu(cpu, tcg_commit_cpu, RUN_ON_CPU_NULL); } else { - tcg_commit_cpu(cpu, RUN_ON_CPU_HOST_PTR(cpuas)); + tcg_commit_cpu(cpu, RUN_ON_CPU_NULL); } } =20 --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786645142; cv=none; d=zohomail.com; s=zohoarc; b=ePEnCZZ2hILot1jwPXgTuUgtiF1lbF/tEPjdQ4C7puc8J6N86gG+ISFpQlKLa/FhHRnkobVGNLQ8fNgjvQfblzk06RJNKQzOAU3Wztqy8btF/ctapQNNHXqbuwFLM+ZTVIfQwDcxYrCzL6qTdohlFo6fomEAcHmCRnpdhlArMg0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786645142; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=8agxJTIsSpKLfDGc1usrfc1YNaxVZOAKA/A8ADkj078=; b=P61Z0d54Xlckq41xp0EJ6f1l/urvj6Z5m0sYr5epQBEhzl10ojCR9STKqUI0Dnwirb8h3nefBsclODxXm9MxCc0KlXcYJfLxKY5i+gKvcQJmULEgzlQnXFqJ6vVKOYfQuGXJzEWp0MecC8k8iy+FXFhQ8YA1dXuGAhlgXPyxYK8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786645142841895.7082008524687; Thu, 13 Aug 2026 11:19:02 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wua0z-0003SR-9q; Thu, 13 Aug 2026 14:18:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wua08-0002Sq-GG for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:18:03 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wua07-0002CG-2p for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:18:00 -0400 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67DFUKvr3051346 for ; Thu, 13 Aug 2026 18:17:58 GMT Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g1fg3s6s5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 13 Aug 2026 18:17:57 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51c26012cd0so2358321cf.0 for ; Thu, 13 Aug 2026 11:17:57 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4998777cd05sm5859245e9.2.2026.08.13.11.17.55 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 13 Aug 2026 11:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8agxJTIsSpKLfDGc1usrfc1YNaxVZOAKA/A8ADkj078=; b=W2IloqFSb1jzcQUA hzNfC++VvnGkvXpFWcFo+lwZ81M2zW0z/z4hTdmgBqJGQu5jf/GqRsdwlDGFMR7c +4+VolF0RCI4s9wW5sgkHeNMpAss6Hd8s5Q4V2enuDqYqblKrhaOUKOaO1hvrmd/ 6PNjhPnQAFo2PnK4qktqYzPx+yYDO9zk6lCum6AdlgwCfEf91ichE7b5tVfEms20 IIKMbzrlnOmofR9RZIS9nseeb4kSBW9B3IRdg5MNTaXfkoIU89TcxWPE9BV5ci2f 8H2a4ftDokNQPm681wb6YJVzPzTWvDKb99oiN+d2fLTaCIdr7zuHQXBckVPe1NeQ znsdDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786645077; x=1787249877; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=8agxJTIsSpKLfDGc1usrfc1YNaxVZOAKA/A8ADkj078=; b=Zr+4pcAcR5L8rs8V+YY2bophBwY5eNgJOZ1sr4YiOntBsu9fXNRLDCPCW20QENun8P O1IIHfjiPWAAEKNY68MYd/zNvrGZ7fbyATP58jl7XhzdXGcO+0pNj38SViT3Zf80RlQU yR7eUJMi4m8CirJub/xwpCmxs0hbvcNOOKp94XZO/y1O29HgOTbtcaiNq64VS76tOVge VO0mFrzhxBE2bs3iD6Q2ubgJfwn1jGeBVShjrJwpRQjzk1HkwXeLU1RcBcPLy6lnkO6m oc7IPuMpWGRmMW9RBjW7csadPbfkC8JS+gBtW3QBo9H0R2C5tfyUwTyrnGg9g4lQL5Gr 91bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786645077; x=1787249877; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=8agxJTIsSpKLfDGc1usrfc1YNaxVZOAKA/A8ADkj078=; b=VBj9lLpEcICvplCBuz3zE8P2PjClSzVijS+fTysPZRsirLn6LdOZVGlhE7+QFRcTZ+ /CmLPvYxfOIIhy59UZnvUWwggkUILM5SHlodd6NIiFyz5BZMTMtZ0cifZLZiX1nalrVx bB+bA7yUWtFadjnR0q7x+d6OUE5mCNz0Rkp6+YpKtVkXIquFtmEaI64i2LwLBKt9OZZ6 f/F3JrNL1P9Ye22sNCJxJURBpH60naUbtMnhUtHoN6uzXR0NT1dplB/GvaXWyHyfpx1/ qcugGfxF0txNPpIWPvS2VPQRtDLBplhKp26ScCb6Vgq2mF888KKY3XZuw42+B5Zh0TQY vIkQ== X-Gm-Message-State: AOJu0YwcqnScf4qR4COdAEOGGA2V0+0TDcV2R7SP1dfPEmZDSiEk+Im2 dtzy1w58nNhQAuDx8/f320/AQ5Y5wOD2qQZePIxWJvAmyluIbYTSU9E1H1FQo4USAa7oRjA84xU PTwZBSOYs3TKoPc8/xONRZ6lP60gzMKfR8p0Ocq8rwC2VY+NFi5S+4Ao8howNxokWHQ== X-Gm-Gg: AR+sD101TSsc2xT5EPT+vV0CNoAzJiTENKWB2LC/BwwJp60zA15dVI5J37Ewvty72UA hiv3pA+72oL4z/sunXAHj27h+nZ0OHuMB9u2IJdNTjIJMoE67V8dCSzaOsWukzkGpSRtPBQlrY0 9PmIb6gV1gsc1ftReLmbXSoh28PBXVDyoiVQQ66tqDzM71nvdraInxaAwu17q6U8b1FZw1X4fGS 4hmyPZ1dlFlzkcV6IQAbzrYw5Zx4nSPA29zpOQBlA8iANqq3uGUB/X/k1dEuyHnEHbBbROJp/AY DnD7+CVjFBz3ZJeukFq0tRQX+7ytdZ2Mpj3f0zEgCH9ugilWsvAh8XC5Y5va200Uj5QiE7d6R5T CcIpTSXeOPq6cComanTz3/Xci/PeTUrs4r85UmmEG3g== X-Received: by 2002:ac8:7f89:0:b0:51b:ecbb:206f with SMTP id d75a77b69052e-52d73de0b68mr77220911cf.32.1786645077095; Thu, 13 Aug 2026 11:17:57 -0700 (PDT) X-Received: by 2002:ac8:7f89:0:b0:51b:ecbb:206f with SMTP id d75a77b69052e-52d73de0b68mr77220031cf.32.1786645076558; Thu, 13 Aug 2026 11:17:56 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Daniel Henrique Barboza , Paolo Bonzini , Pierrick Bouvier , Mohamed Mediouni , Alexander Graf , qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, kvm@vger.kernel.org, Richard Henderson , qemu-arm@nongnu.org, Magnus Kulke , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 10/16] accel/kvm: Clarify use of @r variable in vcpu thread loop Date: Thu, 13 Aug 2026 20:16:33 +0200 Message-ID: <20260813181640.6537-11-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260813181640.6537-1-philmd@oss.qualcomm.com> References: <20260813181640.6537-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=NsfhtcdJ c=1 sm=1 tr=0 ts=6a7e0a55 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=9RVOebA3_GiVrJoGtMwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfXzypU+UzR5yxG o4bEPnFCrzx9m+XF6TlevA7Dn/Gl9MbCp9clWnbjdrteISK1slVxp8t3/Jbr4lntmJ//SUmJnGu TfCuRJFK7dv+w4TLQ9fILttgBToDBuX/LCnT0ytqzGxxdOCb55e4gfpOCGTlORtPU4PwPeW6IvV Jdz3gxJXZC+tWvvh817Ex2sIRAcbAmCQINYPc26zkrLwJ7M4lZ307JQ4G/9FYpZehFRn07LZfOO eKDeJZxclYSWXHHP7ksI1s18Vthue5mxnsdyvgSzy7Km50hYcr4HkaOUJAq8ikFmk4QftRN3QqH BIX0AsnZ9YpvE9kwMMeWE/AUq71POSoOXteteKrPWAPZ3zoUWIiDyIvjhBY30AMAkowF1k+OrGn 8O0o2BDUtdvzL0E/Q+BvUIuNXvyAw7vCzN3UcxMmGGHTwaCatmNiNCH8hqw63M9AdWoGsRfTyh6 NDO/W1ZQ5fBV1XNYSgw== X-Proofpoint-ORIG-GUID: w1RLLzLsZM67CroHivP5HhaU4QBpUw_J X-Proofpoint-GUID: w1RLLzLsZM67CroHivP5HhaU4QBpUw_J X-Proofpoint-Spam-Info: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfX5tVuzxtqLJp0 HGuqui2yGNUZSDASaSNrZcIfNrVde6qQklqIlk2UvvtNQRbiNRzBec7MHKn0ftZ5L+Sb2A+7rz4 7Lvh601QBzqz0HtWJw2p/tw3jQRx9lk= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-13_05,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 adultscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608130132 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786645143587158500 @r is used for 2 distinct concepts: - kvm_init_vcpu() returns an errno. However we don't consume it, besides it is called with &error_fatal. Drop the unused returned value. - kvm_cpu_exec() returns an exception code. Reduce the variable scope and rename @r as @excp to clarify. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- accel/kvm/kvm-accel-ops.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/accel/kvm/kvm-accel-ops.c b/accel/kvm/kvm-accel-ops.c index 73ff93aab67..06f56773324 100644 --- a/accel/kvm/kvm-accel-ops.c +++ b/accel/kvm/kvm-accel-ops.c @@ -31,7 +31,6 @@ static void *kvm_vcpu_thread_fn(void *arg) { CPUState *cpu =3D arg; - int r; =20 rcu_register_thread(); =20 @@ -40,7 +39,7 @@ static void *kvm_vcpu_thread_fn(void *arg) cpu->thread_id =3D qemu_get_thread_id(); current_cpu =3D cpu; =20 - r =3D kvm_init_vcpu(cpu, &error_fatal); + kvm_init_vcpu(cpu, &error_fatal); kvm_init_cpu_signals(cpu); =20 /* signal CPU creation */ @@ -52,8 +51,10 @@ static void *kvm_vcpu_thread_fn(void *arg) qemu_process_cpu_events(cpu); =20 if (cpu_can_run(cpu)) { - r =3D kvm_cpu_exec(cpu); - if (r =3D=3D EXCP_DEBUG) { + int excp; + + excp =3D kvm_cpu_exec(cpu); + if (excp =3D=3D EXCP_DEBUG) { cpu_handle_guest_debug(cpu); } } --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786645290; cv=none; d=zohomail.com; s=zohoarc; b=CCpJaDxVbw7f/sCMdbt6BChA87u2B8ImIdnLIK/lLbkW8wXuJQYNs/pyS/rioNo2b0TpgGP7mSp0OoklKAWbm5F4w8ZKtIySuJ3aJkF8pweXClf+W8EA2V0n/s/XrVSjbYdsQV0Jg4UmGJyrIlkgOrb73BTj3+XixWU0A0Kx/Co= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786645290; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=MsVnRq6tTlLn6rJyDkFaPR9BDkcmhfUBFcym5esfn2o=; b=bTFwIBLXTduRpkp6RgqIvNlXbgI7s3TegHkaxpjZahiHXhBJO9lCLX43iwfqnEp0+GjM77MU7xel8qqeX7w5yxMbKVcoXASNkGWK7DQ9mpqEACgcbhx0Y67veHcr+QS42bQ3vj6Oul7kV/Z4KzVg6zLtYmeU8qqpfW7dc2/Yes4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786645290755169.88609859672601; Thu, 13 Aug 2026 11:21:30 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wua11-0003cg-3R; Thu, 13 Aug 2026 14:18:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wua0F-0002ia-9Z for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:18:11 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wua0D-0002Dx-Rp for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:18:07 -0400 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67DGDvpA2916956 for ; Thu, 13 Aug 2026 18:18:05 GMT Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g1h90rj9a-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 13 Aug 2026 18:18:04 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51c1b4d961dso848441cf.1 for ; Thu, 13 Aug 2026 11:18:04 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f2b1d9bsm1099831f8f.24.2026.08.13.11.18.02 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 13 Aug 2026 11:18:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MsVnRq6tTlLn6rJyDkFaPR9BDkcmhfUBFcym5esfn2o=; b=c97tR2ddpDb5+1FW RxPrsNF3AsjCNIfxMfYWE2Pwq/0+hiX/05ArbaOF1Ahk8675cJspq3vwy04hO+Tp sHYj6jnHEzSGfZLJWwk52EImY6corNunFtH5s33gbvkXovncmGLdHbTzozMLWWKE EJAUGzWAEBOI158QPMv9xejpkJPxVWN8ny/4w5jm4FQ726rVkWwGV8p1A9NVmqi/ Lo8RyntVD8836HcC0Sc7teFsit88wsju9TR+3Iz/sMfJgwBTsr7/7pi6+TydxoXk 2GB5DXcRgVPXvzB7ch18uRhGcNn/0Qg/eVMCRHr0N/fRTQSVlwYiXIxL2U/kRky7 QdN9gg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786645084; x=1787249884; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=MsVnRq6tTlLn6rJyDkFaPR9BDkcmhfUBFcym5esfn2o=; b=ehixXi0JUQtigCh8j8JdVEGRtlHbBCGAVKXYVDmgabL/hdtmpbtqjXqC9aTK4gN2IR sedJkLtrUXQ+yLMa08BTlp7I7eFRHwyFactDUHH5QSguF/YKV9NlSh6DaZj8jIvswM5q NwucXHjMg4xvDOfGVVDD0yPrKG51sfJLH9x5+c2p8Ub0aKyICAM/pORxnCYgGIMailoK Q1ImdSMBwDRXGelPwUfW54q+Oda+WMTRXz8YIthCaAeKmgR1TutgcACIUZbRAR8N33Lh ihRK3gkYPgdTKXqeZ9oZ6lFMje7NnIMExPOv09+BatvXW/I24PVHP7yp1omiEEOnNFtW i/1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786645084; x=1787249884; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MsVnRq6tTlLn6rJyDkFaPR9BDkcmhfUBFcym5esfn2o=; b=UK2v3RoXfZEZ9rj9PeHSw8BbUmZqGuCkP6G6I0dQTsWxszuijsF1Lutg0YXyTveWo1 ZzM87szczcLGsf06WsoamjRbi37ve/g/4COk7yV8NWUQi+Bh8TZTjWUAD7/hizhgr1lK 451oFv+IYnpcPyh1gjHL+6iAeJ05NtxHUAJGiGo2b2FU0dv3p41gT4BUNJW2DK2VdmFQ fLtX6vTzOa0yGcxqYnf2zc/uwyyefkky6SvLZmE/FyGelpTHP3a2+1mwrCqJduBHGny8 c/tA4eWWYCc06kfb+I3Ap9MxAntgrF6Rnq8mUaRITP9zNcbHWCm5coqVY1Nn0g49sM1x r67A== X-Gm-Message-State: AOJu0YxH7hE2q8gr3NaU6GTZfbthvaVqr3KZKXaIA+j/WjHdUKvYkz5x co3Hmrh6tL5Biq3cvz6c4YQLFftUNJWWLOyBkSK4RdTiNKy/wcF7QEABzeGuMSKCJdXruR25JDh cisvPXk0l5V8bKCEI8DC+TTZX45q1EAZmRfgh556+SHOE50VqDsZXU+WUAp0GvC66VQ== X-Gm-Gg: AR+sD10HSdiVJeZbZEV01f0dKb/NCfS6iHptHMEuBgfCnxG6pl6aFzmrQQjJ9MAThR4 U5PXj97BUlIDGYRevfdwAw64w2mF7M4Z5tlfObrJm3r69nR+1tdGJL5VLAp2RSWuzhiiV1qpLuo NfGRVobtALEAMTMm1Xzt9zzYi9TacBk5JkpxOkJzC+xXYPLviuuIYWA86ABJdJtpnJ6wsxCyXuW qes6tHnRfbzkLu+xVw+NCeZofU5VAFHkPn+CYQsofh7GD3gNU51yqOwpGQPXhbNZA0/QgdQQTHz hL4JmnTTfxvBNkYlLNvbRgu+Aa0XyaNFSySgxpaVqgs4h0xyT5cZRqibieYUQkj0C2bB/V2wpba Re8Y+bIXvQsmEqCmzHWvnalopHFrtA4+sGZfstIV6NA== X-Received: by 2002:ac8:594d:0:b0:51c:1f35:4638 with SMTP id d75a77b69052e-52d74ba523bmr65865181cf.21.1786645084340; Thu, 13 Aug 2026 11:18:04 -0700 (PDT) X-Received: by 2002:ac8:594d:0:b0:51c:1f35:4638 with SMTP id d75a77b69052e-52d74ba523bmr65864691cf.21.1786645083884; Thu, 13 Aug 2026 11:18:03 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Daniel Henrique Barboza , Paolo Bonzini , Pierrick Bouvier , Mohamed Mediouni , Alexander Graf , qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, kvm@vger.kernel.org, Richard Henderson , qemu-arm@nongnu.org, Magnus Kulke , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Palmer Dabbelt , Alistair Francis , Weiwei Li , Liu Zhiwei , Chao Liu Subject: [PATCH 11/16] accel/kvm: Consistently return CPU halt state from process_async_events Date: Thu, 13 Aug 2026 20:16:34 +0200 Message-ID: <20260813181640.6537-12-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260813181640.6537-1-philmd@oss.qualcomm.com> References: <20260813181640.6537-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=Ovh/DS/t c=1 sm=1 tr=0 ts=6a7e0a5c cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=GGjvRDhnLmMstqdV9EAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfXzOtSKSFRY7Pc 3a7bni/jKYF6zSbgfJQ9Z6wwaoeCmsYlQoER3ABmXyTydoXpyXL/7GJxWE64GoQGBSQAm8YJrsI WtpyK/QBuRGttYPNEiFc+Cuug1ImYYc= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfX+9chTWW3HtaX uUCM0EINE1GvIELkUCxAosxYqL2+S5TbM2jnA8xCAh8bkQy6eEFg8OK1M1gsI/PSRza8WDRhzk3 IYp9mWD3+gcyOYhPHM+Oskxb1kKWvdD1WLZP7M3wmqmAm560nmHVdSSYCBw7LJ906O2/AcWAeve V8BOYf4+I9hofPjyHE6tYQRHKFhV8IVlCyaYlZNJQmoYSO10A3AFhldMszywDQ4FwERn2nMQLmz YPqgSMg/h3obJB2J2msDQMi/9iT9w4YeKoVVDNkqD/LLSVhTq0nl5wQhrD0nkWJF0sltcAbL7rP HDKMzpQvjUntfMQ31Fzzl8mmoBV+T/NSzlz6foTkS5G0rbCe0y3aFJNp2HvgcyjZjT5vqDGVymM u4OKnht9/z7a9Nt0Nc1xtzuVHzkKbI8Gxh584uewzUp/++wctLao68AkBD47ZFSVh6qB3JI6ut5 qHigLKAxc+Z0K+uUdWg== X-Proofpoint-ORIG-GUID: 7ShquBfEeK0IH38WcHNrmrSPHy4J0f2P X-Proofpoint-GUID: 7ShquBfEeK0IH38WcHNrmrSPHy4J0f2P X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-13_05,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608130132 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786645292279158500 When comparing the KVM implementations, RISCV and ARM differ from S390x / PPC and LoongArch. The caller expects a non-zero value to return pausing execution with the EXCP_HLT exception: 3427 int kvm_cpu_exec(CPUState *cpu) 3428 { ... 3434 if (kvm_arch_process_async_events(cpu)) { 3435 return EXCP_HLT; 3436 } 3437 3438 bql_unlock(); 3439 cpu_exec_start(cpu); 3440 3441 /* Inner vCPU loop */ 3442 do { ... Change ARM and RISC-V to return cs->halted for consistent behavior. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/arm/kvm.c | 2 +- target/riscv/kvm/kvm-cpu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target/arm/kvm.c b/target/arm/kvm.c index d40a6a98591..5caabfab63f 100644 --- a/target/arm/kvm.c +++ b/target/arm/kvm.c @@ -1575,7 +1575,7 @@ bool kvm_arch_stop_on_emulation_error(CPUState *cs) =20 int kvm_arch_process_async_events(CPUState *cs) { - return 0; + return cs->halted; } =20 /** diff --git a/target/riscv/kvm/kvm-cpu.c b/target/riscv/kvm/kvm-cpu.c index 97069bf597a..1a61cd5ef37 100644 --- a/target/riscv/kvm/kvm-cpu.c +++ b/target/riscv/kvm/kvm-cpu.c @@ -1568,7 +1568,7 @@ int kvm_arch_irqchip_create(KVMState *s) =20 int kvm_arch_process_async_events(CPUState *cs) { - return 0; + return cs->halted; } =20 void kvm_arch_pre_run(CPUState *cs, struct kvm_run *run) --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786645158; cv=none; d=zohomail.com; s=zohoarc; b=OTsGFq9FsGitA0jc+7A1J9OF8m6kc3pKEMm3R/sbP1CgypgUM14RW/q86ZgTNFDZSiDYM495fk0Qrdwp0/+oRKH85GKd/eBmmRUnXRObPoD3wlR0wsKlq25n+nvF0iXAMSV0pitmH4TA9omGvtyWAEAl2+zgcrj0GhM80bFo1bc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786645158; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=JzbDkxS3itZNpjD41FPb0w8HQM5ewTacpZ4P5EQ4taQ=; b=faonxC3ihVSFU2qZjrzwhJC5XeQWVUtJHpDLI55hVSayLdHrixHT74iZxu/XrYlwk7V+9bLXGgI6Phi5f9judOcioKUmcRwBonOYywGTW39wAygJzgrTp/abrXp5r+f5ahdjNoCtXv2W9K/qlHoyGSdhD/LduWHVccsY6ONclWM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786645158534807.9090617532368; Thu, 13 Aug 2026 11:19:18 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wua1H-0004Fu-Mg; Thu, 13 Aug 2026 14:19:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wua0d-000309-Iy for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:18:38 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wua0X-0002FE-FS for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:18:28 -0400 Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67DFU1PA2374722 for ; Thu, 13 Aug 2026 18:18:12 GMT Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g14sykxpf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 13 Aug 2026 18:18:12 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-52d8243f1bcso3727731cf.1 for ; Thu, 13 Aug 2026 11:18:12 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f1fff25sm1953402f8f.3.2026.08.13.11.18.09 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 13 Aug 2026 11:18:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JzbDkxS3itZNpjD41FPb0w8HQM5ewTacpZ4P5EQ4taQ=; b=oUWs89iLelCmwkJ/ Mvy/9ND+MihY70Nc6KbUpVGUUH9SZanld6qEdOQpJfUiGQtpvgJXsY97kAahP9U7 T3WWqw1+UizKvIh2yYs2Iws+/BuiD9XBdPi+afda9TrNUZB4e+YkX0oNIgwHNW77 mS7javzGCJevOC5tK8v9B5UrBBHwlYwcWC91pEqAhoxGROveyGYnuXZWuajxpKVv +2HCK70OJSYgWWC/3W9/XpardUkR7hPmgN51vo+Ve24lW2eWHPFSpGdX7x9zHy9W RGQq8tm2/ultltdt5+qNZghqsn4uQq5TjqTqjHaYGC2iE6+yHoavzZYsM7B5p+ME T2CBkw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786645091; x=1787249891; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=JzbDkxS3itZNpjD41FPb0w8HQM5ewTacpZ4P5EQ4taQ=; b=IEpJMRpGWWYeBP4ghDUJKSEJXU57gilw4/EvNhNPeK0+UyXNV1+BrglSTImAIhX26r Is3mguNAyQy7XrsfU62UqQvDMCDYB0ALL4fj54ISFrWdtUHPAapDKMHcPxspoWB9kUhS HkybrQZlEYs874soDUGCZ1pdOz5gJS60HJCtBzkNDIyB7rOcg27eVRZiydjH0NLxRD2G BTjy0o26+FNVdGei+nUZb2YssXu8gqEYh0wbOCa0aY7miSxQ13WoD3fmonfxf26kagLN nil2FfKVqkQ6v+TFsW9krBFpVUPCee9l1MzQF8jOg9WSnuQmmEHR05Aw9Atf1cxzBLFV yFWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786645091; x=1787249891; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=JzbDkxS3itZNpjD41FPb0w8HQM5ewTacpZ4P5EQ4taQ=; b=O5f+eAVqUVxf2l+Kprx4zLf8klOEWBKDFWqI8cfkBhc36mhTlI5pAkwEJzMv5FxZYr 6Li68mvoHULyM2ZA6vpM2IlyBgPrJLAFUd2lkbwQ5iOTgzoUmHd0SlVVSvgJv2o8Eg28 eYXjF2BVEAWpx6ncA0Ni1IdfFTMRkQ0M8r1xbfrOvndR4icqnB49VEmNWI+7dHasso1e b1SbVTpFrXlAG+cxiwBjd9BfhGbcHQSZWFp/iXW3vkBlkVuBv9508TTIijoAB/G7gTpS VZwMT2C3Wb/qAFV5/FO3M/LJTILEfVHEGxS7i+qb/O8Ptu+TXDL+aOniaAWFC0PhqR0A ycdg== X-Gm-Message-State: AOJu0YzN8dSfJk6yAsd1O0UpbWz5c1RYAcUQLf9od7olPUEsdOZafGGH uFEkjPoCJmQI6I6sOBXpFiGas+gpWc/euyezxl/3boJZEKtXjVooaujiZI8Rm/HXps1y3EcQGrE yEbKav3XmhaO7eTvnA7s50Vn0YL1i7InrP0gbU36Apiajyp/Oe6OMrN9tA1DD9OgKwA== X-Gm-Gg: AR+sD10cF9e32DJ3IAd/tofYJr4ieBxn6mPzxv0JmBvaeTIJtusQtN/ItMk0dlwV9b+ /ZN/LlCBGgCplYaYb8+P9g4/AXqN4rei6SsGGzOVnq4ezt3RWjSlwr/R6CuwCewjvLlHtcBzntX qTaZRadA6qYGIV6h36zey1E9kzDQysxPC+PGfeVuCjsO78Sv2Zyd6WFC+Ia6VKLbq0f2vixG2vb 01TM2LK8hmk61t0VRz9ivMoSmqwZ/qj8IUyetsaCR1gPJ6Hdz0nsWIeV0q2lCzn6Iw1/SeqHegZ ulgtaw9XUTzY98boEyfqT2hbgT9FSm+n+vwBfLdk9WzaPmv97HFzLvs2dEv+9X3JjTk6yiZrmYI XAm/j9ngpN41WSui/DeCkTw2OS4Tj/LVTQe86Zy5LIA== X-Received: by 2002:a05:622a:5812:b0:527:7756:3ee9 with SMTP id d75a77b69052e-52d748bf7c0mr76996051cf.0.1786645091516; Thu, 13 Aug 2026 11:18:11 -0700 (PDT) X-Received: by 2002:a05:622a:5812:b0:527:7756:3ee9 with SMTP id d75a77b69052e-52d748bf7c0mr76995381cf.0.1786645091089; Thu, 13 Aug 2026 11:18:11 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Daniel Henrique Barboza , Paolo Bonzini , Pierrick Bouvier , Mohamed Mediouni , Alexander Graf , qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, kvm@vger.kernel.org, Richard Henderson , qemu-arm@nongnu.org, Magnus Kulke , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 12/16] target/arm/hvf: Move flush_cpu_state() into the inner vCPU loop Date: Thu, 13 Aug 2026 20:16:35 +0200 Message-ID: <20260813181640.6537-13-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260813181640.6537-1-philmd@oss.qualcomm.com> References: <20260813181640.6537-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=ZcQt8MVA c=1 sm=1 tr=0 ts=6a7e0a64 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=xMUYw9VpK-qeDZ3ugSsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfX6XaO4ltwPoUe tEMHEoH3y6j4zlQFjsaN4eZw83ZIJ/H2cjQD7C9x4oSSJebjc4FklFsw3RD9XJJnp6VxumnAJk9 cD5JYSt3kmX+2MRWzwjJOOclk8qzolvonY2Zu0X6bBJ75KgW68xO+zh2hEu/h/rT1h5ddkEh9kD 1MwTMLkiVJYLSQQctNVm/LUcBK6cgPmPd7LS1xIwMKDX1wu1QKZiKxuBKiPIWKVCkzYq8oA80d+ J99L08HnyIX9rnetDvmV+PM9Bs9iagkXudrGI8v5huBzwLrbQpPRFsBNq9W9s6K934RHRrTwaHN Lnn8zGS0odBHJIWhcRU27SSvuLczA2oKOczv3MUL5yuER4BEIU3qiuyqDOb21/K4LxjCnheJ+2P ovX2UxYoJaTBaK/TIAlZKR5EHTk+bEObzlEe0RmifNfE4c/9fCUEtrxQLcmGc7aMHkZ1N99YzKl NE8ifxPQnw/RKFGnbsQ== X-Proofpoint-ORIG-GUID: RzyV72WYLeX93ocULCcwcK3LQgx1nDEY X-Proofpoint-Spam-Info: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfX9o6fJHzR8ryb IdZMvU3pdYjec9fdn3segKItkiaUnDeBfAeeo43f41EgI9joHuTDv5qk3UWEvwHdgfaWQmLGAfn 0ZD5+eDA0GzVGBmrm5PQb3YOruw4++0= X-Proofpoint-GUID: RzyV72WYLeX93ocULCcwcK3LQgx1nDEY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-13_05,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 phishscore=0 malwarescore=0 suspectscore=0 adultscore=0 bulkscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608130132 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786645159500158500 To ensure the vCPU state is flushed on each inner loop iteration, move the flush_cpu_state() inside it, right after the interrupt injection check (catching any interrupt changes from previous loop). Since flush_cpu_state() uses CPUState::vcpu_dirty field as a lazy synchronization mechanism, there is no performance penalty if the cache is clean. This got missed while refactoring the inner loop in commit 93ac76507. Fixes: 93ac765076a ("target/arm/hvf: Keep calling hv_vcpu_run() in loop") Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/arm/hvf/hvf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index 3eeb9f70de4..c14ea54a67f 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -2598,8 +2598,6 @@ int hvf_arch_vcpu_exec(CPUState *cpu) } } =20 - flush_cpu_state(cpu); - /* Inner vCPU loop */ do { if (!(cpu->singlestep_flags & SSTEP_NOIRQ) && @@ -2607,6 +2605,8 @@ int hvf_arch_vcpu_exec(CPUState *cpu) return EXCP_INTERRUPT; } =20 + flush_cpu_state(cpu); + bql_unlock(); cpu_exec_start(cpu); r =3D hv_vcpu_run(cpu->accel->fd); --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786645273; cv=none; d=zohomail.com; s=zohoarc; b=QfGAMTrgNLdG2sERzOcwtBYdyicTFaCMwRXazirYLXrQKgOPdIgk+0JIF5NZtZUU64rCkLzAAbO/JF8S7WtvT8S3NgGOheVhWpiG/pua+KyeJFaC4CzqUoSGZqeteh7wfLzupxbjN0Fi423Pr5liSG5LRRcA0cvh2oZ72ntyORg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786645273; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=V1XUkcAOBdCmt+f6LujKVgOfRbrqLf8eqAKYfrk8/gI=; b=RRliSlGngi0lFJJ49jGPZ1/GuPF9b137LmfAcpc2xUY3bABtS65VCurBsmpOugISHgvqWiiN6BesIPehGZuc8rOf5w7HsQkZ+wqXnH5iYsFqRnxGbaKKYhLIS93qDri8mNp0yfsysgfdCSnjfCWbwgzp52G5LGnYmt1OQRjZQfE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786645273072754.7645509776855; Thu, 13 Aug 2026 11:21:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wua13-0003nj-4q; Thu, 13 Aug 2026 14:18:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wua0s-00035A-Fo for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:18:48 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wua0f-0002Ft-G3 for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:18:42 -0400 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67DGUt9G2076781 for ; Thu, 13 Aug 2026 18:18:20 GMT Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g1hgy0fff-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 13 Aug 2026 18:18:20 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c1b4d961dso850881cf.1 for ; Thu, 13 Aug 2026 11:18:20 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f2005bcsm1289151f8f.6.2026.08.13.11.18.16 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 13 Aug 2026 11:18:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= V1XUkcAOBdCmt+f6LujKVgOfRbrqLf8eqAKYfrk8/gI=; b=K4ShfWpvQbhhvufj 8t/5NMf0CpYEEoRHoYloXGQt3OB4BRFdi1CWOEZseiPgULp6nL/HLmP1VgNLeNDA 3Q8Qw3T3K3Ov+oBU+2GmNRI+pYcU+KxxWrV83QEPtw/vxP3dEN44ZsGozWGNeh9u 0G6aG4sOZzqgyAAnzZb2DHLlZk4Twl2kQVJ8QJ3mD+/43iNcXSaEHtfbkPqQp4eN 6kMmMxF6zu3JZUPSt6nTbP2F61n4dTRUFccn4E9RVjqnx1vo4Yomm/cNcp8q1RMy pGud0v+8ArXD5IHSq1LRVwTDa+QrKPg8uOid70ZnUuP9+Gu+bZcs3BUVLdufiNQq 7DnBNw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786645100; x=1787249900; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=V1XUkcAOBdCmt+f6LujKVgOfRbrqLf8eqAKYfrk8/gI=; b=R5UH/uIoCI1VCGsT3VieFJswwnUqZahjK19zZN1yVOX7LMKnZF2P0A1zeL8hXc8MAb znwlm8xJ6u1E7DNTd2K+Nn8rkGpuAwA5XqbQ/I4chywU5jOdyFtkE4FWiNiLeM6/JsnQ /KevBvfd+BK4nnIeGorGrP9Xg3Ax5T1X02kEAaBgfKTl1b1aTfCa3kZwV+C9cIKl8AT7 Ep1qilrSzmWl4Tywu+kxa6mupbmJ6GY0NW4Dim8sRPBpiUuCvc0uzjsIaixImqN5bT87 8rywqSx8PkO5U7Og8BHJ4Ho6cGc/cGoitm+jYumSjV+wwTU6t9d9XCCh1nDAOxIcCA/X g0HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786645100; x=1787249900; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=V1XUkcAOBdCmt+f6LujKVgOfRbrqLf8eqAKYfrk8/gI=; b=sqsbKjj91tcmZdJ8jKj53PFFdTq0cGXYgrvCNtcMiswMnEnHAVpjouI/c3+q2AjCba QDBBcJ17ZNQ0edifE0WjoR894VL7GZqliMZBA/nz5gWMDxBpeRVlJ2HeURoPWsRB/B2b 9VPjPUlz8wXcm1t2LFzPGj0VOYnEezbG5mtLeG2xZGa34dKF3gbItktNeDJdQy+z88xw jQNQc6G4De+WaMU3SoIYysr5Oc2v3wV+5bu69D2eM48EhF+GIQH7livl1L4OWEmTfk9G xizOdM8Rg+V/rW7D5MbqI5Wa+HMOWYDL3NxLxEMUha4bDXYs53JBEx40HPEF+Z9GYjYt 5kNQ== X-Gm-Message-State: AOJu0YwUIHO0U5rybjIWDiHFE/20zjCLjKSyctr8MGpgkMRORfMzs3ZS iz4EnAvrq+q59wDlaXSIyLum/sLtSrSxNNqo6XQn2m+TfavV44NithTrvccfQx4rUTwkvhJhkC1 b3yEjMBzkgN05VIyHs5In4RdN6IrsCskLBtyC2o265UXbynOcAcFccjie6sQNmRQSDA== X-Gm-Gg: AR+sD13qQj3tfIOaZbCVCuxIhRueORti8u55e2miyhjrUF3/0FBIlyagKxMHzqDwg7Z tucbN5OjyyJs7rBica/nrUVScJQ0sBv4WtAGcEGhoPvnb/y6qjGcZnNgUVlCyf+ouEaZnUHyZkC aEN+9FK+tRFG2DWVNU0AvtTK11dPZW8UjkiNdJ+SvJIox1rijr9cxGjLqNQpRE14mMgWKjpNWSG RdtWvrVE4mKY5Ndnu3VPi4yqqg0kjdBzhE3rkQ7+7BsSnu7LDf2AD6HvhZDhD9TCxyh0ZjfnLQK 0ocPaazN3bbNEs/A1ASpSttZCtUcZ4tHWV1HitVM15V+UhJECNjMNlccPoMg67hzosC8NlaGCTC 7QKkmD3oZnvYQTUeylHk5wPAJIs+xr/4XBptK58+kNQ== X-Received: by 2002:ac8:5f95:0:b0:52d:6f91:86e with SMTP id d75a77b69052e-52d74b6c8c2mr77157101cf.15.1786645098747; Thu, 13 Aug 2026 11:18:18 -0700 (PDT) X-Received: by 2002:ac8:5f95:0:b0:52d:6f91:86e with SMTP id d75a77b69052e-52d74b6c8c2mr77156511cf.15.1786645098222; Thu, 13 Aug 2026 11:18:18 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Daniel Henrique Barboza , Paolo Bonzini , Pierrick Bouvier , Mohamed Mediouni , Alexander Graf , qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, kvm@vger.kernel.org, Richard Henderson , qemu-arm@nongnu.org, Magnus Kulke , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 13/16] target/arm/hvf: Lock BQL outside of the vCPU inner execution loop Date: Thu, 13 Aug 2026 20:16:36 +0200 Message-ID: <20260813181640.6537-14-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260813181640.6537-1-philmd@oss.qualcomm.com> References: <20260813181640.6537-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfXxanI7MUHwlKi 7s0t6KU10vEvnVpzisE41czh72rC76Lx73G5eeZFMya/4gwsimFsXhkaaTDF4hB7oX/kvzTn6dg ksCLd3GnM4yitLcRyEl5zj7ZxedVPcDyTlPH73wVODO+tQenTJMpSMlCxpT5ALWYjR3Wzfll79C UccpqrElHYTGvKdNaoqntykRjGN/SzMuL//N/ASvSVzWfdxiP0XczQeN5BVuqljlm31uuReS5eh Y4MJ6pI4SS8GAFsM69G+FSxq9skjEWMLhrEvV3fmabORGk8/brDvGE1JQK712NyZcTCtOU6xkos t360xKg7+z7EXsjILMSULEEuBfbwuE3D76jzkiJjnXuXsqzhrH6Bd1kxgbFP2c8YX6FkRnmMrVU /anpL1Rv55GVUKgSsWj6PAnKEp9nIsjC1IxR61DVoraepNxZnN5nYGl4zUmMe/bqemchDSRJxaY lfvzSuFW5gRFhR2Ov2A== X-Authority-Analysis: v=2.4 cv=AaSB2XXG c=1 sm=1 tr=0 ts=6a7e0a6c cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=WxR_XFPUuro4_54D_dQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-ORIG-GUID: 9ivjYMRW_tVOF5sbsi71ZQaTbxcWqquO X-Proofpoint-GUID: 9ivjYMRW_tVOF5sbsi71ZQaTbxcWqquO X-Proofpoint-Spam-Info: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfXzdZKSbmFR0Gx hvMUxYH2KNChuFKurPm3+Se6H1bmepWUTvIj+PqC+cmuSP/LkV72VvyaYl6dlL9Dcq/FNCfv9z+ dP7NiPEBK6FWoIZPQb/Oh7cUCmZEluw= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-13_05,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 spamscore=0 impostorscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608130132 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786645274289158500 Reduce lock contention by acquiring / releasing the BQL outside of the entire vCPU inner loop. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/arm/hvf/hvf.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index c14ea54a67f..9c6408d2e25 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -2598,20 +2598,20 @@ int hvf_arch_vcpu_exec(CPUState *cpu) } } =20 + bql_unlock(); + cpu_exec_start(cpu); + /* Inner vCPU loop */ do { if (!(cpu->singlestep_flags & SSTEP_NOIRQ) && hvf_inject_interrupts(cpu)) { - return EXCP_INTERRUPT; + ret =3D EXCP_INTERRUPT; + break; } =20 flush_cpu_state(cpu); =20 - bql_unlock(); - cpu_exec_start(cpu); r =3D hv_vcpu_run(cpu->accel->fd); - cpu_exec_end(cpu); - bql_lock(); switch (r) { case HV_SUCCESS: ret =3D hvf_handle_vmexit(cpu, cpu->accel->exit); @@ -2624,6 +2624,9 @@ int hvf_arch_vcpu_exec(CPUState *cpu) } } while (ret =3D=3D 0); =20 + cpu_exec_end(cpu); + bql_lock(); + return ret; } =20 --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786645187; cv=none; d=zohomail.com; s=zohoarc; b=FM79dwfs97ZeJOwA21v9YOcy52SER9fILnfEpuQyY7RDta/8+HqAXb0mbV7zlmDmvUUex+QUgGxTKIC94AIr+EpEQTUY7ZS5PRgglT3tuPTYMNa3yz/LTBaUQS031c5S/fVC1ZCi6Wab/VW2g5jSQ2dtws6W+FCbNbXmdHJp1+Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786645187; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=eCWTqwclBlLHkStMtx+d8TC5Wvr713M4u6l2TBYeh3s=; b=MXtH4McJP9twRywMYcBRPOWtWD2sEhvEgEm4SsU2Z5E6pauUFZMgXVQTOpz9WxC9ngsmpRaKPoUF8/UjsFsqo1v/E60kPriMesT2M4KE3HL8wZhQO0aYBqsfiDwwFXgOxyecQcBMJG158ZffrzCxCnAOTlCOD/Pi6pPgPQpoAXQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786645187758679.5879640033098; Thu, 13 Aug 2026 11:19:47 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wua19-0003wQ-6V; Thu, 13 Aug 2026 14:19:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wua0s-00035D-Gd for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:18:48 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wua0n-0002H8-87 for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:18:45 -0400 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67DH8fUU304653 for ; Thu, 13 Aug 2026 18:18:27 GMT Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g1j2nga0b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 13 Aug 2026 18:18:27 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c1a9764f0so2706021cf.1 for ; Thu, 13 Aug 2026 11:18:27 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f200752sm1254325f8f.1.2026.08.13.11.18.24 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 13 Aug 2026 11:18:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= eCWTqwclBlLHkStMtx+d8TC5Wvr713M4u6l2TBYeh3s=; b=hQBuqPujzsXhPNrS uAWc9ffvY5FWr5MT45GSB+SH5TWqtHiKgCTMt6ZSI4ThqcuefaLdsLMoHYwltHmw cBl+H6mky0H7pf22b72/ipbpsibziJ3AHjAfA3Mbjr0+m3znb6E+57sFnSuAd0AS 5EHRT7nY6aFCiUwHbRRHRUWxfRa8utRK7ChqbLqrCkg92BdtkM3p2uJHUlAPm2r1 tTb3rVNECxDIcg057QwM9Bjxbtsz/o9ZDwsCWIKBMW37aVxaFKYLEhkUew73phCQ 9cCFIJgtVjvMVYAmtJYnyebQUnty87t7SoSIiuKBPGelDhT4DTV+YfeYE+zFpZx9 ljmTCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786645107; x=1787249907; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=eCWTqwclBlLHkStMtx+d8TC5Wvr713M4u6l2TBYeh3s=; b=Dn9SjB9xUYWqiAomnP2k8wBxqK9R0KXs/Sz6gHTPCI005mwOncCFZ268jC1DDY/bLl QLj3365R84h9riJjrOefgfAW4w6GnmuilJ5D7J2Fmzo60RL5Xv9Oi/ebjZREutC3qFVC Cy7Jmkj/rAs+joH4DSYjCO5hTDdezRJVxce93nMX8xKphnmvHyr2wViosgrzept5Ya73 QqNYJn5mnN37sNPXdIRzK6XZ4V8wF4Mv3qKPXkzXnNGwa+ZzPaf2VnVRePvmDwvzk0nw WnbZSaoVkoFdTZa7KPdrdq90l0ovfZf/AXlsyNUb8NsTrQNNIpvmBKdpWHnji8ZRW+/A GKEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786645107; x=1787249907; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=eCWTqwclBlLHkStMtx+d8TC5Wvr713M4u6l2TBYeh3s=; b=LrObne4jyY/XJh/P4pYEugbxNWJUipabwYPU5T98HTzkBK4nDkIeUAGJlRXIYkTE/r P0DmpbVgSqnFtoq88ga3juqlTakrnpJqChlMsGVXWV22iGP98LU0drDjdQ8nJyJhbvw1 1nZbCWre+DCRPjHhrvGWpB9yoBK+j6Cuwzz/OED5bE07lrgbTd5/TQ09EHKT98JsLLwW 6wnJotLJmoWF+AEMKzKcfljsBC2aZI+IqrbBggtCTKe3U6eTkTvrvzXZ/b9WHFlQnFZ+ Xyq0506vKJOgBZ2QTPoiMWJ09jLvNpQdjuuQHfOSo75sBGRsaYRZvGRkDfOv8WlXUnBg xG2A== X-Gm-Message-State: AOJu0YwmbBNJPopXaM3vdrSbbyAl/LNFNmDSD1ZyRo7dLYe7nRJH4Jpr pWhl4SfzRx2cDZmBsIA8MZ2YVN+iPO0mfcmxlS6OgWwnyiM8xfbuxUzIkhzeKZmUT0VNZKJ0GtI d2Y+c7n1oXVu2HK2KCck2HTpbSzjUiWSVx3mT+9yggL7d16vFAgP0b6QZv/J0uBag4Q== X-Gm-Gg: AR+sD11Ktslei7MZ0U3XDuniECTUtxWVgIopr7eKrHOKsswQDWDzdz7h9072dhwFjZY L9uD0SMUpSwDUGghOYhrkNaKDg3uzzGmNs8G2ODBeA74bcSXg5UrRlBX4meDMwMxMARo+D/ntUF cCiey6diV2nBA8pod42ykkjJHqjAhakAOZ2hf/EeqAdLusFtN/gV6C3OUcswjWpaGw4fOCC+0Vd 7Z3+zO9QafzdWtwhdHW7hREhFdK2ZUFg0xvQFCcczV3YSRLPwQy0ppGubH6utLEaSABOQ4EtELf 2N3BkJjZXzP8s8Y8YSeniUMmxClzlBlLv9Hn1Ug+ZzkhIhsC6/LTKPIQPeDezfUxdfwCI/VbIIa lfcZ3jhwWndbI4K0jCAn4YI5gDutQ+AaQZHxyL9CyyQ== X-Received: by 2002:a05:622a:13c9:b0:52b:4f1a:5ff0 with SMTP id d75a77b69052e-52d73c9a46emr78211701cf.19.1786645106148; Thu, 13 Aug 2026 11:18:26 -0700 (PDT) X-Received: by 2002:a05:622a:13c9:b0:52b:4f1a:5ff0 with SMTP id d75a77b69052e-52d73c9a46emr78211021cf.19.1786645105711; Thu, 13 Aug 2026 11:18:25 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Daniel Henrique Barboza , Paolo Bonzini , Pierrick Bouvier , Mohamed Mediouni , Alexander Graf , qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, kvm@vger.kernel.org, Richard Henderson , qemu-arm@nongnu.org, Magnus Kulke , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Roman Bolshakov , Phil Dennis-Jordan Subject: [PATCH 14/16] target/i386/hvf: Lock BQL outside of the vCPU inner execution loop Date: Thu, 13 Aug 2026 20:16:37 +0200 Message-ID: <20260813181640.6537-15-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260813181640.6537-1-philmd@oss.qualcomm.com> References: <20260813181640.6537-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=ApXeGu9P c=1 sm=1 tr=0 ts=6a7e0a73 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=k2pNA5m5VJBtx192dGAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-ORIG-GUID: V3A6b0cJiFRt2PhsUVsRmODqldMVH90v X-Proofpoint-Spam-Info: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfX54y40OgsumCb vzJx9Nk60iidWEbrS0XsJWKc1UGEzorQXN66fYkRxAAglUg7Iz4n8Jm66dwpFAhEPwXkyr7iL72 nL5rCMI00XBdNKuOJi0sKQKbjNfnh4k= X-Proofpoint-GUID: V3A6b0cJiFRt2PhsUVsRmODqldMVH90v X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfX8NhxYCLL9g1j jqpcP3cgeHGqui/Ktc+ZpkFqvwx4k+bVen20UUmXFQKC7n61DE+9ZvwMF05ja/yENzS9PI9BbqJ gqUttgCQi/POP+YC+812rK/E9c+ruFpd+xMSoVvKIrqR0LhaqEv5nQy/2qkjozKAJp8O6Y8VOy3 61We8nz6W//4ig5BaaTI8J2OEVEu3wr/5l5T5aP0ohyuFMEeOeyZqXAIskFpVDIVdADBgfSPgfP OqN9paqeoTmzn40yt52pgh6r6QBUSFoGFrbhp9upWzlf8+CIT0dUmO2xmxnQrNT9do3EzlsV73x Wbe2b5Q+4gvufNRR3GGfrF+hjvqM1oA6cmbCabjzXXCt+pj2x9VlPinhsc1SQuLYPGy52pZdLag 5LjlnZwVXbNlwfac4F+TmKsCm6bAZo2ZwEwtwPtL+6Cx8gN/53nKUntphPJ/be5xD92p5BqCH2m PsTOK9SnLhX/F9sjOyQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-13_05,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 adultscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608130132 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786645189892158500 Reduce lock contention by acquiring / releasing the BQL outside of the entire vCPU inner loop. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/i386/hvf/hvf.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c index 0ffa3658dc5..f8bc01d38d3 100644 --- a/target/i386/hvf/hvf.c +++ b/target/i386/hvf/hvf.c @@ -1009,6 +1009,9 @@ int hvf_arch_vcpu_exec(CPUState *cpu) return EXCP_HLT; } =20 + bql_unlock(); + cpu_exec_start(cpu); + /* Inner vCPU loop */ do { if (cpu->vcpu_dirty) { @@ -1017,26 +1020,26 @@ int hvf_arch_vcpu_exec(CPUState *cpu) } =20 if (hvf_inject_interrupts(cpu)) { - return EXCP_INTERRUPT; + ret =3D EXCP_INTERRUPT; + break; } + vmx_update_tpr(cpu); =20 - bql_unlock(); if (!cpu_is_bsp(X86_CPU(cpu)) && cpu->halted) { - bql_lock(); - return EXCP_HLT; + ret =3D EXCP_HLT; + break; } =20 - cpu_exec_start(cpu); - hv_return_t r =3D hv_vcpu_run_until(cpu->accel->fd, HV_DEADLINE_FO= REVER); assert_hvf_ok(r); =20 - cpu_exec_end(cpu); - ret =3D hvf_handle_vmexit(cpu); } while (ret =3D=3D 0); =20 + cpu_exec_end(cpu); + bql_lock(); + return ret; } =20 --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786645273; cv=none; d=zohomail.com; s=zohoarc; b=fEqs6AlU97F7FECrXGdiJjMbeSrV1WpGHDLe+2LHvOu4Sd33lLNX2QQReL3nt/yTfGKdVdXoEI3J4bw45oFgNVExAfE0rgyLBcEB0tamN/YEbdrqOSDcVw6nIsJDvn/uGd2BIwZMyA/SnoiRZzym9zOPS6IxuCOJHKnmKrW9TXA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786645273; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=WkLF8awV/bRgmolBst9AuOseYgP5YAXlCZ5MmoxHNDQ=; b=dwCCpstYTpz4WlIyWnAoGvVFpjaCUKPkq5Qke6W1m20KQFyjdrVFKe70vAukh7Nlz+KGO99C72SeHFb00+7zI+723WpkYmYPgqcwb3umK4M2VJ4vIcfGdkRs1CiEe5eo61ZLTW56TNlIkSowQFWBd0p63Ox8aB1NKmhtf6xN51w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786645273147517.3417617342136; Thu, 13 Aug 2026 11:21:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wua1L-0004u3-F0; Thu, 13 Aug 2026 14:19:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wua0z-0003Xw-NQ for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:18:54 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wua0w-0002Hl-KG for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:18:53 -0400 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67DH8ecQ304580 for ; Thu, 13 Aug 2026 18:18:34 GMT Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g1j2nga0u-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 13 Aug 2026 18:18:34 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51bf321d786so3554191cf.1 for ; Thu, 13 Aug 2026 11:18:34 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4815f21a068sm1190899f8f.12.2026.08.13.11.18.31 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 13 Aug 2026 11:18:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WkLF8awV/bRgmolBst9AuOseYgP5YAXlCZ5MmoxHNDQ=; b=QNc26D0gQLRHqQAn 38oRtw3lbi0D02btV1plIuqbbRNmhBEOMsT+vr+5lD6EE/OS1nqiGg3v6XG2AZcq oy0RxoqrFL25TP1TpD28jw8KqWQ/bN6EiriQ64EZUOl1LXrpXd+pW+9Yugnb1T58 JNOqxjWP4U5KiBQaYu1sqy1bu/Enl0u9PSz42o0D96OPMzdt0rxNf8ovRGqDZWnB hDOEbMDekOGhHdIVUa/jWqa1zFc4VYWnC0TJ9zZkP6LdcOYFGH3IMuGa/O7i6R9y ZG4dIIbP/aDlBOyTs6544uyh4SVGI1dwDckJNR3LsgnJN4Y8uAUvwuDDORNyU2wX K/fCDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786645113; x=1787249913; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=WkLF8awV/bRgmolBst9AuOseYgP5YAXlCZ5MmoxHNDQ=; b=O2WMWt2kMSDQ4ZCjsxAqv/iGkigmHrGiooxYIAgLDgr6aeQfXF1CpUGKQ3IIm4qb7n 9s38mzAVhlXKwi4/u8XasoRZV2s5TOCzVSyupDAUjGLrSRthSBqrrD4u4PEYWq4uOuJs eVj97V1LGBZgf13G7tEO0Ax/58RZKxV4+63+r8JAhD5WpwJNC4GyT+EwPWJBS/I1yeL4 DC+k04jntuLARI+JTABEMyLERNUuWxbVp3VwBaVzM8l/swM7h9k8Yx7j6ZTtMwgsREKh 8YWNU2j3uX3jtfjTY7WcXNc7vCh17nbfz8kKVt74iC62xj889f5tKk44WApgRGDAzu8A 6v5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786645113; x=1787249913; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WkLF8awV/bRgmolBst9AuOseYgP5YAXlCZ5MmoxHNDQ=; b=TZeO4+Yfyu9FE68Q6usEcfDRn3ki7fNo+pEMdx8vyO0j9Wh6KRYutwIoG2bEcec/bq 1P6iMaFjQJ9bEur3AXtxJKS9RbT9PliYky4BBPMSHnXzN2UT8w+eIKyir0GrMcjubYtR ZEJCcKEtLVVmjx4EC7wdfejXTEkmo2YmH3AA/DxY2rrtPnHoWYXq6CalQjbFPogsudCN uFhyqn2ZWojzG/EMc+p5jgs/QTE2Q72wkJuMAEShVMMP8B1BOx6qBj4Ia16hviamFUmH N1ILYikObg4lweHcjUly80y91t+1pmgTbd7MVTw4UDapP1g1OAXPxZXXDIBrTrP9kHGj NKGQ== X-Gm-Message-State: AOJu0YzF3XqORjdh9eZdDbMV4YHIldrYVtgrJfUPilLXbFqh03I+94Hr cj4Ps1JeWwYoiGI+8JvIW70BkQ4oEzICWaP6CPJZeQJHBaG118XlIn1Q43eqRt+OqCUoCSOtjiZ gUlxmfYxtt3Z4Mk/GQ2pP0FOKfjgGW89PIwIYJeZlTo9wFcF8ApxBANw3ZXgfEhy2EA== X-Gm-Gg: AR+sD10+SlTByJ+rcQhx2SA4LV2QYUnDxhoDpLbp6hYCww5Khh1ZcJa/rIrSMizN+9o GngIKBB+nXtkRRfOAaw93GZQB2nuc7RQt6cRJgViNqN8YG8YyotTWZ+6OWXG0HTP1LYM6Tmr1z4 CIJ9JIgs+a7TJXDL7SWVsDqSkWuDg/Lzboihh7hs2rIg7kPvb1urqZOJXLjKULQD/exy5tEfwhZ j1mYLaNBtDRPZSod1KSnhwcd0vX11e2JOK5Z9IS5JPa7qRj8dYBIiPtcAD+hNSzy74/AYs/Y9BX zApfWIA9m73At18jiJYx+s/eH74aJXGimUmJ372Daj6AhruUSYq4qfttwD1xkLngeaTyGEBTQCN ob/mnIi9gaCdVsgBsMlIbxi3I/CS3yiy52HtCmliP1w== X-Received: by 2002:a05:622a:1355:b0:51c:f3e:7819 with SMTP id d75a77b69052e-52d73df4d17mr78564541cf.39.1786645113606; Thu, 13 Aug 2026 11:18:33 -0700 (PDT) X-Received: by 2002:a05:622a:1355:b0:51c:f3e:7819 with SMTP id d75a77b69052e-52d73df4d17mr78563731cf.39.1786645112979; Thu, 13 Aug 2026 11:18:32 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Daniel Henrique Barboza , Paolo Bonzini , Pierrick Bouvier , Mohamed Mediouni , Alexander Graf , qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, kvm@vger.kernel.org, Richard Henderson , qemu-arm@nongnu.org, Magnus Kulke , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 15/16] target/arm/powerctl: Move BQL assertions to async work context Date: Thu, 13 Aug 2026 20:16:38 +0200 Message-ID: <20260813181640.6537-16-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260813181640.6537-1-philmd@oss.qualcomm.com> References: <20260813181640.6537-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=ApXeGu9P c=1 sm=1 tr=0 ts=6a7e0a7a cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=LLcwgxkfhdatqMbCiJoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: 1XB5_dZ8Ro0lBqNWlgtLmVbDEaifka07 X-Proofpoint-Spam-Info: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfX9SVfQYltvifK zoNMb1b4GP+YU1QvNfT+bF5pFk3RILYeG3KopGlT46msDPE1S6FRUnx+RXLG9DjUi5j9IQGyW56 AOzwgaqxqKSSWgPb0iiREiBfqs4lAxI= X-Proofpoint-GUID: 1XB5_dZ8Ro0lBqNWlgtLmVbDEaifka07 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfX8rULpzp02/3H dVsQi1s67kedzFlaBPeW6bb5aGZOMr9AqXYPc4vNS3i1mYh0n9IJp3hX6JnSVQdhuF4UC9CkJm0 6wfAw1NxJM23kBzMglh9/VhEQkoXGScdok89SM8/L2sJuTwtahXxq0p3uzczUiOKSxtrl/29KJU S6bwv4f/Io7lR3lmkpdKiN4yZDHeXSKJlDfd0TaJChQpwZdrJrsdQvl/4Z+S/Ml3v5vlsRB5gH2 pcPgg4+spBi0TBpt0hzMpNT8979V+CzYAHUDuwC+lpJdLDgi+m7yx987H3JrbvhW9PhXGKLzKcV oRzx0T/rNy/RMcXdFnWwnPr2RfeCTc8DS744mxrvWczzQRUV5Janfq0LVyJ9824LB9b6Jv6S3Cv VMuGb2v7A7U0KfCO4E8BuLu1GYVyVcTTftYIBkK0WP28/Xbs3hnD26sxGBW+kq3LbH9HCLsoCrK 1PTWsG/WH3MglmJjWXA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-13_05,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 adultscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608130132 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786645274289158501 We can not guarantees the callers of the following public API functions hold the BQL: - arm_set_cpu_on() - arm_set_cpu_on_and_reset() - arm_set_cpu_off() Move the assertion to arm_reset_cpu_async_work() where the async context guarantees the BQL is held. Fixes: 062ba099e01 ("target-arm/powerctl: defer cpu reset work to CPU conte= xt") Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/arm/arm-powerctl.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/target/arm/arm-powerctl.c b/target/arm/arm-powerctl.c index a06be5cc997..a938b30943c 100644 --- a/target/arm/arm-powerctl.c +++ b/target/arm/arm-powerctl.c @@ -88,8 +88,6 @@ int arm_set_cpu_on(uint64_t cpuid, uint64_t entry, uint64= _t context_id, ARMCPU *target_cpu; struct CpuOnInfo *info; =20 - assert(bql_locked()); - trace_arm_powerctl_set_cpu_on(cpuid, target_el, target_aa64 ? "aarch64" : "aarch32", entry, context_id); @@ -194,8 +192,6 @@ int arm_set_cpu_on_and_reset(uint64_t cpuid) CPUState *target_cpu_state; ARMCPU *target_cpu; =20 - assert(bql_locked()); - trace_arm_powerctl_set_cpu_on_and_reset(cpuid); =20 /* Retrieve the cpu we are powering up */ @@ -249,8 +245,6 @@ int arm_set_cpu_off(uint64_t cpuid) CPUState *target_cpu_state; ARMCPU *target_cpu; =20 - assert(bql_locked()); - trace_arm_powerctl_set_cpu_off(cpuid); =20 /* change to the cpu we are powering up */ @@ -276,6 +270,7 @@ int arm_set_cpu_off(uint64_t cpuid) static void arm_reset_cpu_async_work(CPUState *target_cpu_state, run_on_cpu_data data) { + assert(bql_locked()); /* Reset the cpu */ cpu_reset(target_cpu_state); } @@ -285,8 +280,6 @@ int arm_reset_cpu(uint64_t cpuid) CPUState *target_cpu_state; ARMCPU *target_cpu; =20 - assert(bql_locked()); - trace_arm_powerctl_set_cpu_off(cpuid); =20 /* change to the cpu we are resetting */ --=20 2.53.0 From nobody Fri Aug 28 00:12:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786645316; cv=none; d=zohomail.com; s=zohoarc; b=LlNbMARLJ6F9uyw9YQ7Le3Rrc1j1ViunJTJfSOdOSVOi4e0EsH4k5BeEa+3BTE2KNM4wirZndBBNBYwvqDSxnDx0VH/Jzbd35US7u2vnyFAR0G/+qGvkFMSU4yuVJm5cS0SIgRGYglpXzcE1VFhsB/u+fmG49kTO4RQrEER3vu4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786645316; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=iZ4CQeHz0iJrXPv/eT7hao6uyv4DFIFygNCZO9k79Qg=; b=XhkaXGgtca7minCvp5IwrQZEowOLcnp+CZpwSXhGQ4LC9BekgQ63Beqbsw3wIkXnQ8F72ni7DpEqhAvD1FYW22hmsjc3BqmFIKoxBpePQ2znINtk2jqBAzepA1yFgc/0+1eMSvAy2dzcaWsYY6Lma7BNQGQrtYFvOB+sy9cj240= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786645316085201.0034280442527; Thu, 13 Aug 2026 11:21:56 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wua1N-0005AL-Ft; Thu, 13 Aug 2026 14:19:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wua14-0003rs-NT for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:18:59 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wua12-0002J0-NQ for qemu-devel@nongnu.org; Thu, 13 Aug 2026 14:18:58 -0400 Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67DFU4192375717 for ; Thu, 13 Aug 2026 18:18:45 GMT Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g14sykxta-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 13 Aug 2026 18:18:44 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8eec6acbe21so2417106d6.3 for ; Thu, 13 Aug 2026 11:18:44 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49982129643sm73839635e9.4.2026.08.13.11.18.39 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 13 Aug 2026 11:18:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= iZ4CQeHz0iJrXPv/eT7hao6uyv4DFIFygNCZO9k79Qg=; b=Zf/LpJWyOil0GNtz GRXsvvUH9b6DPhWH8Su/QEP2fUsUChulGo7bBXRQ9026kAMnrHuvNj6t6MI+Jb1w 21zVNxSX8kjkWRW3IRFRzP4cvXZukRrrWAosh/pYdmlMxbZhc0Zzi3nzkW+zOD9A hG6/U5SXBpzBIT7Y3ibo5Ptz4e1NKViVUTJZ2bKTPE7NLKqXMOTZbnhQXDcfBxXE cbAEdqtFP5o7jecRctFwW08J9etnwAoi3Hz7xSEWJYO813aQPbbmImIb8r7fPRiq mwa7KRf8kumLiH96qsR2ojg9YoehPXV74ib8m/t7kR7YfRXxnn2G+8RfHpQj1EJ0 Ts6P1g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786645124; x=1787249924; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=iZ4CQeHz0iJrXPv/eT7hao6uyv4DFIFygNCZO9k79Qg=; b=TX65oUiGWwsjk7Md6xdqIuAvgQnvKHGShuQ8Eovv+26H0LGjnQRphxpuJy8GHvZc3O PSAIiQ+Oxg6X90FcG7dGKu4X4to52k1QgNbaD3cD1n4ozJxMU/zvsp7iOKPiwu9Rxkh5 y8KAXb47xej10Ly6VM3+L4b3p7tE/fiFrtBaM3Zmz8fKykixXV81shbSQ5ku3Gxwa8e4 Y05lj4yCFTCrWeCfZ9y/Pwj0IY//RWzjkeA6f5PXcDxwd1JTPkIGBjATMlBxAfHRmMj0 oSn0+j87ISi8V/JYHBnJodSb69eZGTTvkY19KnSHWeu4t19yCRUnqjgF9DkCQ8irSiSF TY8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786645124; x=1787249924; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=iZ4CQeHz0iJrXPv/eT7hao6uyv4DFIFygNCZO9k79Qg=; b=cYNOFLGvbA6xQkMawpl7yqTgUc3B1akoL608VlzOykpzHToM5L2iCO+hYKEBPmFvr5 CmS33ZMMBDQEKaNfSKBrKxxXo/6qtp7bCbZx4hYuvRUpRC0CWGbNY9wRHcIGYTKqzgO8 Rt1ad14Mn2e72heQi+hOLT/6MXFgiHM1FuM9bXUkVRjLQ44F8otmSyDAormTm6kOkJhV hV8zV/f7ZvBPwEOAU68rzP1V5O6nNLVQ5CkBAEAxXCbYdWuR/E7yAQ3eoFsrsWbdluMd PPKEDBOStzApafdhHh39PBC4piMAv6pWLu1eOrPzrOLVFGOl2hPpUryMdW9BDj5Q8e2h kjlQ== X-Gm-Message-State: AOJu0Yy1D4BzhJAuUEayLx0DdoUNkdlLiQPSgPPzLfl1zuG4VUZWyXil B+1B++NuZ3pmcc6F3Um0HBdu5ShA77yhIIt6hUf01zcXlSHXEYwVvCAuzQuQ7F2UL3zKnM1eQ5O dqXFP+NkyJ1zi5zpA0LJmD230R4dsA8hLPpBiQ+xJC98Fm9Z5/gPD4Lf92iVMejkb4w== X-Gm-Gg: AR+sD10DftiZPnuG11PzYd2NxJ+69Rw5EPHgxNCy7WTKOqFBIQfj/41JPPWzn+oL8R+ e/M5Bfx81wpJGIgLOLSC14BVqm7kJFVauMPR55WAgd3+MrQeGI9ZyVsw47UNJhNn61RH2AC8Z6o FZH+FuF5nChOvSMfWM+OLGUJB9u/Nb3SK0fytcgRPie165uRwCzHSq3m91KMhpt93bNjOD0t4/Y KSZoAz9irRmS6dJTVgA10XKJTXROjKDkdkhLCGp+5CO7YtoHLBXlac4PVHRcR6u3KKfrRUfpU8a hmoThAWz8AVuAUQrFdPgCj+It6qxg790ZGlRJ/Y96iqM6XmDOmLS0nVs+LPSo2btXIlbrsd/xYr n7ZigXLfWMYDcuK9sxK6rU3U/t6BTlMihvZr4WNKxKQ== X-Received: by 2002:ac8:588d:0:b0:51c:103:fb56 with SMTP id d75a77b69052e-52d73c6fae8mr83158361cf.15.1786645121413; Thu, 13 Aug 2026 11:18:41 -0700 (PDT) X-Received: by 2002:ac8:588d:0:b0:51c:103:fb56 with SMTP id d75a77b69052e-52d73c6fae8mr83156831cf.15.1786645120303; Thu, 13 Aug 2026 11:18:40 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Daniel Henrique Barboza , Paolo Bonzini , Pierrick Bouvier , Mohamed Mediouni , Alexander Graf , qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, kvm@vger.kernel.org, Richard Henderson , qemu-arm@nongnu.org, Magnus Kulke , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pedro Barbuda Subject: [PATCH 16/16] target/arm/whpx: Fix argument order typo in memory access error message Date: Thu, 13 Aug 2026 20:16:39 +0200 Message-ID: <20260813181640.6537-17-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260813181640.6537-1-philmd@oss.qualcomm.com> References: <20260813181640.6537-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=ZcQt8MVA c=1 sm=1 tr=0 ts=6a7e0a85 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=sWKEhP36mHoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=CJsRysG5a4fyhNKOOSkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfX8uV6UPsO8AuV 4JIZ1OaulDo0oaEsper/O0ZrpbYMj+MyhptLX/00IUZSBAIJ8sXL6CROamQyfo5KvdxCY2dT6K9 KIOmGZev8KC675DzZjYlZSliM7jEpJEtFh2rSj+av/hW5Gmz5Qgkc20vjX0xWGlcW4U1o6sXLg8 b0Z6E8a9ORFdPdXUTWck8Il0K2QiC04e3iD+za8EymLp7mJc7r89S+lvpVeZXDTOBftSskME/12 ZwUJTNZRUIRdKt6mJBP9Uq3FfaIqX1PAElE9MHT2SraYwZXy4N5zlPNzUva+Bq4IjptYq8i3u4x TXuNA8LMH39nGRCJOak4Qb4iMqW6HulGRh5fBPA4omr6l/TrDhRvM40meXHN7i6qP8qOXwx2JyG bxe5FZhcS7BRCys+Ay5L4VznuMjmlK0+SZidh5S6W9CMmg7KYX5QPUeAPbRBkLmRc6u6hbF0GOK 6uziVl7W/uvf4sc9JQg== X-Proofpoint-ORIG-GUID: 71EpXrCSr_ATCylegEAfLTW3GYByVIQC X-Proofpoint-Spam-Info: AW1haW4tMjYwODEzMDEzMiBTYWx0ZWRfX9F+JgK9lEzfA eQCrPgVc6CAiDzGR8V0i6AFAF/60Kzt7kCFXxR4D3vzn3ioEOklUcBmjXtPFHBvoAaLO3o+pFq8 tD1s1KoAeu2ZmhF/UxMfzt0MCEqW7yo= X-Proofpoint-GUID: 71EpXrCSr_ATCylegEAfLTW3GYByVIQC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-13_05,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 phishscore=0 malwarescore=0 suspectscore=0 adultscore=0 bulkscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608130132 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786645316386158500 The format string expects "Gva =3D ... Gpa =3D ..." but we provide these addresses swapped, causing confusing misaligned debug output. Re-order by swapping back. Fixes: 59432082cef ("whpx: add arm64 support") Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/arm/whpx/whpx-all.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/arm/whpx/whpx-all.c b/target/arm/whpx/whpx-all.c index 5e4c25bb7d5..e59580d54ee 100644 --- a/target/arm/whpx/whpx-all.c +++ b/target/arm/whpx/whpx-all.c @@ -442,8 +442,8 @@ int whpx_vcpu_run(CPUState *cpu) error_report("WHPX: cached access to unmapped memory" "Pc =3D 0x%llx Gva =3D 0x%llx Gpa =3D 0x%llx", vcpu->exit_ctx.MemoryAccess.Header.Pc, - vcpu->exit_ctx.MemoryAccess.Gpa, - vcpu->exit_ctx.MemoryAccess.Gva); + vcpu->exit_ctx.MemoryAccess.Gva, + vcpu->exit_ctx.MemoryAccess.Gpa); break; } =20 --=20 2.53.0