From nobody Wed Aug 26 07:24:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786541675; cv=none; d=zohomail.com; s=zohoarc; b=LlmZfMl/QqeoF5Lxx4suEjQilNhkD8ZvtG0i1ex7/IYU1ds3VM24pRq8pOaeImHY/sX/DsqEoAHJYIDgdRlRwFpbczghbrghrGYUIz1KZCyvx45E9NCTRizPV7NMidmc/3kxs7WaIc2+Rpct1rtROJ8CsbSKlTIWejPP/CqY88M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786541675; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=bFuDeXoeC1GFIVZCw6cd7z1siQifytuqe3A3UCzq9WM=; b=IUklAhDlW93/i5RcvwOtqCCoqaQTMzWP9lD5lsA5MFCC8MBYQEwVFPXZrdwipSNrhwUVuuqcUUhk8fCCVDhlQVp1VgZrO0o5hcGEV/+T4ubRXNSQ4AKC+zs6CpuJRtXPXFSyPSXqlvGruf8B/sm8FEPhGCvWym896KmM477r7Q4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786541675715515.0516289989754; Wed, 12 Aug 2026 06:34:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wu8oC-0005rU-DH; Wed, 12 Aug 2026 09:15:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8kX-0003Ov-ON for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:12:07 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8kR-0006Mj-HX for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:12:04 -0400 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67CB4SW93963406 for ; Wed, 12 Aug 2026 13:11:58 GMT Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g0nucgwkw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Aug 2026 13:11:58 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-5276aa86d00so10743681cf.2 for ; Wed, 12 Aug 2026 06:11:58 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4997abf8fdcsm151719485e9.12.2026.08.12.06.11.56 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 12 Aug 2026 06:11:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bFuDeXoeC1GFIVZCw6cd7z1siQifytuqe3A3UCzq9WM=; b=IIm1S+Nwd/sm+xvn +Nodqtwklv2IJFtw95984gv4RjHnbm73JwbG6ZlK5VzbmhrNHnvEdqGxg+f0ESHp EUOauC4nB6BP0ffJbOBYvSSboif4+u9RDMrVLCu/PsmpbKPFRWkv/v0lYDfRkyn7 bExNnJGxN9lj9A1KY7czQZjLJ/yPeTqlamDIsencWX7FGxFC02o4x9Dw3WGYtFIw /Q3JVH2sfSlwZw6/miSoAp7wWvVM8OY8b/0O3g7zIyA4YhHLsEoq2y0RKcGIg4De qYvXcy6MtfD52/8iiq8NNxf0ZH57i5OIZgw9sZhJVG211/RlDipOVqQBKZQWJSKU 4MC2Aw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786540318; x=1787145118; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=bFuDeXoeC1GFIVZCw6cd7z1siQifytuqe3A3UCzq9WM=; b=Rve4ha7Gf16006DRHRW5gmEnqHZ+zKrytAANDE9r/YzpgfKcr7odUwdQrswMZWk8tj HArg+BVegpDpxucys2CATo0hiSi5a8VHC3q7b9oIEwSDlauUTp80MLpUZ0wnR/W6ov4J t6wItsNLq55s7Ec0su4CgZKjI7tkOGALRegO5w8Tus9s++2lpJ7J1IkGh1weA01qMGdO Tg02aB64dyKkNohFgbrjOm7U10Ae1BMPkdgxB4495+yi7tiFkKihezpag5/44krh1XAf 5axWM8TWvV8pX8a6Y0U/ByHYxZiWcpcMT15/4s7IENWbXZMwybj7Rrh8rpHlD+CAwd/r xOUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786540318; x=1787145118; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=bFuDeXoeC1GFIVZCw6cd7z1siQifytuqe3A3UCzq9WM=; b=QL8TSST1efSj47Cmj1Bp10aYmkiL61UwnqmAv4wccNxlXVCpCUsgoZ7jD6nG40sj7P RQp1Lk0UghuL6orSXHE8GNSmf3fKho+/ItAtlnlFQXc93qmWrK7PYGx+uIQWyBRjCuaQ eZoXqK43HoYyokwBtryQIH5gnCvy8KHY9Zvsz3pzHfX1pfNiZxir/KIcMMHUd7ekaP9p 6dr5T30lbpZg5O9sJs1OF7+4ogDp60Q6UVRERY9wmhnEXwXJdtSN5vDhfMGANOfN7sn7 SBOkphzoSnOwhC6lUGK0GpWcBxwB5l4IDGwBP/n2U2YCDVFCczgG+tN+LwLlJgLcRT13 slHw== X-Forwarded-Encrypted: i=1; AHgh+Rr5INJfz7Aczp/71CYDS/LMqdbIR//y2bRXtMM1NMRrwB0v2v/Pl1RqUGXlrYJixhCC1RjVvQ+lxRiu@nongnu.org X-Gm-Message-State: AOJu0YwBf8wF7jgFStdIkMHvNRyQeKi5zmes1sNkbyL5b1e6ecBWxJAU 1veSLHjbHMo4ShJJCCvntllH9OlMwYiFJZEriFURz9c3KomvKPSD+suQ9RMAQqKQRS3rp3fIvYH llEqQnBK64xFvH/e8n6GKuIgt3TtxX8rmsVbvA8vzZYdL7GHyLxMUIEPNtA== X-Gm-Gg: AR+sD10TJbtVe3EnWz1l1g+DLk120L8YDiXw0ZMH9mocMDeMImw/BFPwUJwkGEmwSB6 kXpkT5BBqXHCUD9LyChPN0Wag0OkGFVVYhPbGCR7bAJa0HCopgxGI1Oy5GRNAacYoQ16LvN4Umo mR4SMo3hBixItNXS7JRhFFYPtIFLYqeGSU2ahlEHoIZD1MGMUSZx99ErhSOe2LKNf+HedV4ToYs WcTz9JR0Ns5d6b64q0JMNYS+3kfKXGUb6wP5iPUj8MoL6kUV/zhTMlPN8JGkZAmOogFgotGRYsF d5FQPwevSeoFOgIZDRtb0nl6gdyJWEq4KKTbFDooBrlw1eBWo6pp2l9TlSvtZCgI7lTryYqh9qC MT0p1e3yCczqNUboOZVDKcE+xxuSSwIDYaZJtckpOgg== X-Received: by 2002:a05:622a:2b07:b0:51b:f640:2a4f with SMTP id d75a77b69052e-52d646b88f2mr41231191cf.4.1786540317874; Wed, 12 Aug 2026 06:11:57 -0700 (PDT) X-Received: by 2002:a05:622a:2b07:b0:51b:f640:2a4f with SMTP id d75a77b69052e-52d646b88f2mr41230251cf.4.1786540317407; Wed, 12 Aug 2026 06:11:57 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , qemu-devel@nongnu.org Cc: Markus Armbruster , David Gibson , "Dr. David Alan Gilbert" , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Brian Cain , Pierrick Bouvier Subject: [PATCH v2 01/16] hexagon: Remove unnecessary 'monitor/monitor.h' header Date: Wed, 12 Aug 2026 15:11:32 +0200 Message-ID: <20260812131147.83188-2-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260812131147.83188-1-philmd@oss.qualcomm.com> References: <20260812131147.83188-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: wyyZ_egwnHO4vWGu8KzZNjWircu9Lsjz X-Proofpoint-ORIG-GUID: wyyZ_egwnHO4vWGu8KzZNjWircu9Lsjz X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfX7XzXykU2XTnS uHQkJwjTUtSL5BPUMMr0KmxjFRWDE/xaxX3mfS/10HzgtGUuJuTYSu0+DRK1nskTCKVpGXAyxoC sD6D1q/Y5NhYLGbQuX8dpn4tYQdzNssdUBV1jnmfAVE+Jn89/laXBUEpxvn2CJ5MTG3tucGrxN6 5klatFlrw3CWZK3Ey8x1c1uDSU+TayZgAqEBQByBydZ6LIpc7SWsoYI/hP/fzpM+Lz1Riex/g44 EycNX5fvJ1Pjw280YojZkuAAb7FRclGDE3oF76GTt91kRorZQtkp1fXfGoUsegoEdq34kvFwYlu or+E41mKLpHmtO8I6DRPEw9Db2oRzeZTGq6qrRcpO2jjRzW7Dat+JBVLvqmGHgbuRMOOOdo3kGL laYu4RgfB+3exIttyljTLkaezHavw7YYOzkqtuQjkfPRSpK1E2H56pY9IMwDY8TC7Pm+wat9Pgo BAvWP+idGT/v/+lTnYA== X-Authority-Analysis: v=2.4 cv=VcjH+lp9 c=1 sm=1 tr=0 ts=6a7c711e cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=-f94bmcIBZYFaPXTGXwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfX40jFakep7C4x lO6GaITCf4+xOYn5BFYtclD7yyDU4ANcd/gr3zULWg7J/pRV56RMvy1nhIOKG5HBtTRgUTczABS lPWMk7wbTrSI9XXBE/u5D1skCzrWJ+8= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-12_03,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 priorityscore=1501 phishscore=0 suspectscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608120107 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786541676839158500 The Monitor type is used in these 2 files, as a pointer. Since the type is forward-declared in "qemu/typedefs.h", which all source files include via "qemu/osdep.h", we do not need to include it. Do however include "exec/hwaddr.h" and "exec/mmu-access-type.h" which declare the types used by hex_tlb_find_match prototype: extern bool hex_tlb_find_match(CPUHexagonState *env, uint32_t VA, MMUAccessType access_type, hwaddr *PA, int= *prot, ^^^^^^^^^^^^^ ^^^^^^ uint64_t *size, int32_t *excp, int mmu_idx= ); Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- include/hw/hexagon/hexagon_tlb.h | 2 +- target/hexagon/hex_mmu.h | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/include/hw/hexagon/hexagon_tlb.h b/include/hw/hexagon/hexagon_= tlb.h index 90d9ed84043..760dc1ea811 100644 --- a/include/hw/hexagon/hexagon_tlb.h +++ b/include/hw/hexagon/hexagon_tlb.h @@ -12,7 +12,7 @@ #include "qom/object.h" #include "exec/hwaddr.h" #include "exec/mmu-access-type.h" -#include "monitor/monitor.h" + #define TYPE_HEXAGON_TLB "hexagon-tlb" OBJECT_DECLARE_SIMPLE_TYPE(HexagonTLBState, HEXAGON_TLB) =20 diff --git a/target/hexagon/hex_mmu.h b/target/hexagon/hex_mmu.h index 4f556c715a9..6aa450b9413 100644 --- a/target/hexagon/hex_mmu.h +++ b/target/hexagon/hex_mmu.h @@ -7,8 +7,9 @@ #ifndef HEXAGON_MMU_H #define HEXAGON_MMU_H =20 +#include "exec/hwaddr.h" +#include "exec/mmu-access-type.h" #include "cpu.h" -#include "monitor/monitor.h" =20 extern void hex_tlbw(CPUHexagonState *env, uint32_t index, uint64_t value); extern uint32_t hex_tlb_lookup(CPUHexagonState *env, uint32_t ssr, uint32_= t VA); --=20 2.53.0 From nobody Wed Aug 26 07:24:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786540778; cv=none; d=zohomail.com; s=zohoarc; b=FWN2uBzulG/cjzKDPxSVjsx0dQcYBkPYoT1+eOyc+YOc+JMjen2tFOugZq6QrgFr589npaTKbLR59Q7Kf2Z7yrOTyQSdxFGss6xpBwxCX2nUakwWAVXIOoFgW0rezrZpzkcTHet4tHaM53a//zm8DjItqBzXCtGlSHFSfxy0JUo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786540778; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0K59RZPEvdTZnclxJKg+xf1CCEDRT+nQLEi2vTumsU0=; b=lEGjEabWygZMT8gjtdaKXYaiiaht+/P8soK7xn0ZOEBlhOdq8dFZbjlcMxd2raKl3Q/hYYt3EqpmqrcvNHlyg24nt4Pf3BfIURHIV+aZjSTHIQ/YJQ9ei2Sr1gGf6C6535IzYrJkVBje5b1zeOL5salc73h54mIH7i7VFfSSZaI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786540778069950.1142507787183; Wed, 12 Aug 2026 06:19:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wu8oV-0006PR-TG; Wed, 12 Aug 2026 09:16:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8kb-0003TA-It for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:12:10 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8kZ-0006O9-IE for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:12:09 -0400 Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67CB4MkO2860276 for ; Wed, 12 Aug 2026 13:12:06 GMT Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g0mnd977n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Aug 2026 13:12:05 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c1c7f135bso16269811cf.0 for ; Wed, 12 Aug 2026 06:12:05 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4997c998f27sm45775895e9.15.2026.08.12.06.12.03 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 12 Aug 2026 06:12:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0K59RZPEvdTZnclxJKg+xf1CCEDRT+nQLEi2vTumsU0=; b=Us66dijWuM/L8kfx z2pyxl9j2apOaus1yAklZLjd3wkXbZk+z1ZdOFM0V23DbTMY2cSayTcDMwyjD0a/ 5BAMSe4kfzON3qitg1H4/lMGB4hyqrIqEfwWnEfxu20fX7NBqiyxFjbY8hMSVILV wmz80pAyKPOjOmOeZYHrrUykEIaZnec/yCOWfZITeMoiEN+GkD0IOJNA5KQ/hEvO sLzQGAhYJe2ScVQEsbn9z2Q2MbL1r5A8V/sYhQnCQXUGQn+NMtFqBfMPgLHnCucg 9VXhPYe0BMCp+z2e4ZmV4OnvNsJU2gBkSPkg2eP3DuxL8169IxVCUEssaXBD0IqG VOfyhg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786540325; x=1787145125; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=0K59RZPEvdTZnclxJKg+xf1CCEDRT+nQLEi2vTumsU0=; b=AUPQ9x55Gnly5fzazhMT9lFcNz+wUJHSzkv4eg76loKwcjq9/Jg2TpIzKG9BxE8m0z e+EWBQH9fJi1uazHP+IDtjG3qdTSGxDGdxoWoQxcV54D053082UP0hGooiDMeZvgT4Qc hzIqY5b11XMUdMsHpMYEn7doWAVjZOHknMpxFV/HKn9V+kuKnTW/9A6ImukuZUkprU6C 4uK8buAzcoVKPLb/hX4b+zxBKh59m2HQhaB1Rr/AMrbXyU26DhRXe3uG8ItF9X94+/1j 10mGLGEYmy6U1MT2XWOK6x0e0gxMAgGKz9keh54OQjLqlu7/0Iuy+DA6DdGiErZPwz04 Asjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786540325; x=1787145125; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=0K59RZPEvdTZnclxJKg+xf1CCEDRT+nQLEi2vTumsU0=; b=Qekaku8PYxo1KZp/xe6AWdnhMh2gjCd6o5HctvDjEswr62nYGPaqKlPnT1bTCL5IO3 635Mhjmlf21iO1gulDQNP1FQ1JNyH79rq/0PfQUb/y/fxX8EVSASqrL0elsbPW9DpdVF IRNv04yVVH+MF5wZMcN8GBJa9di6Y8FKidxbXbiYVQjrKcAzMs3GGJge+BDrFG811BjD zO5BYSdcTLdJT9O4xQiTtUza3X0DpaywT/3oc6J7j/lLefgyZsyxY0XxWcievRzxivNd G5aJScgFCMMQqvkyu3672SZwDHuyCYSajZS1rKSZC3NQCixUg/RttNU6/GLJ7kNgBNJt R3ew== X-Forwarded-Encrypted: i=1; AHgh+RoOWJWEGQYUvA7eCJp+9eOZq+esQciwN8zVGMzYNrbRq/K3Z6t1iNN86cLxFbRRHEaovmq/GfnXL3nC@nongnu.org X-Gm-Message-State: AOJu0YyYYcAtLLva9QYg/XVuNrYTiO20/S35WXQiLdszUogMc55LAlg5 s32Edgk/YPwlApAuyn20CzUphOoIX6nLwob54EOOOWxuIjlhtQE7rxIwGZU8UtxiGR9sw9RhY/1 8NtrQlAo5n9DAcklRiMN4BcbD5kYSZeT19cn9EBvdZFhSqfXrKOLVoRri2A== X-Gm-Gg: AR+sD10PmPOzGSG8yyVXwQohZVeL7Wx3RGsuhMM/j8g1F1T719r/MmT6ojQcMN/NR+Q lbuGth5Sv5zFFduuqeb8gykO4+ICo5shIinZYLyEog0aOYEDNE4KC2K4RycZwTNgQMOqbQy+CgH 0bLURdA9KyRLyK99bnZKwXHmD1qc134ar/YrhpX19TNbVJg2GI4envT1SvlahULjpYpvy8UaAls i7dmuKC3BfxTcYTsotPRaX2JmDQ9SX+lPMbqsppTLohuaFL0PnHXBBc+n3eFTlDzYsPqX09evU0 IVWgfArIOqsybydqtiScdGbpgDYr/2Z4DDVes+kDCUM0+9d/WHI3XFyCJjx3km2gfrgLH5h7ST1 QLC+sfhWx5/EmRhYoSGubFFbM66wOZTpatulA3wDm1A== X-Received: by 2002:a05:622a:2589:b0:51c:1fd1:e755 with SMTP id d75a77b69052e-52d6484eb9amr40893961cf.36.1786540324876; Wed, 12 Aug 2026 06:12:04 -0700 (PDT) X-Received: by 2002:a05:622a:2589:b0:51c:1fd1:e755 with SMTP id d75a77b69052e-52d6484eb9amr40892951cf.36.1786540324404; Wed, 12 Aug 2026 06:12:04 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , qemu-devel@nongnu.org Cc: Markus Armbruster , David Gibson , "Dr. David Alan Gilbert" , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 02/16] tests/unit: Include 'qemu/main-loop.h' header in test-util-sockets.c Date: Wed, 12 Aug 2026 15:11:33 +0200 Message-ID: <20260812131147.83188-3-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260812131147.83188-1-philmd@oss.qualcomm.com> References: <20260812131147.83188-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfXwRlxhaJ9CZrR QZoGY0WRlphCr6UVCvtFnj9qqaNBXxCppLrOb58jK4oYyTfu5k2HsIm6xRcvrj5aSsEM9dyf7me O8d4519zmOb5pXXZuLvI2W3T8ApktYc= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfX0H7y2GH+UgNw 1pkFXgkrCTCR65Xk5wdSwzfE0ZuYy60481IBg0sMxyWPY90puRmxT8Tbw5BSln9hrqNUP6Nr87t KM0gWJt74w1Z7kgoYnLAUy6PMg0ZERdiRqF/fJAV07/hhCr1srLx2TB24gMnBNZV9xAP/VS0ygj VSLpeUhUBtZcM0EvWS2X7RhAuA/FisRGHpLszoyxHSLHrdKVmPz03bdK2b/ZY7/kD4B/7bCrR3D INQ7KP+iUD2kqhf8i1rFqEoxYAQNjoLO0NN6lRjKeA6De/uRlZoScAWy7uKYiR93qyWVfbImDWY iGXnjlxJ/753EzPBDqKxXPHQRrygvVWLtByyk4BE0RvtUaojDSsRU580RnIidGfUk5r3ldr2WN+ MVjhkQdS4TnJpXhPper4wyF30255Taz8Wd9ekfdXyAlgt9JPEn56rgvoImOofxAEwjv8FURvKJv RzE4oFeZJJgkvWV37vQ== X-Proofpoint-GUID: Xxen5LUM8lTCDry4n-9_FmlHqdQ7n70U X-Authority-Analysis: v=2.4 cv=C87ZDwP+ c=1 sm=1 tr=0 ts=6a7c7125 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=qNk81O5wtt-6jPY9Lu0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-ORIG-GUID: Xxen5LUM8lTCDry4n-9_FmlHqdQ7n70U X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-12_03,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608120107 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786540780353158500 test-util-sockets.c calls qemu_init_main_loop(), itself declared in the "qemu/main-loop.h" header. Include the latter to avoid when refactoring unrelated headers: ../tests/unit/test-util-sockets.c:553:5: error: call to undeclared functi= on 'qemu_init_main_loop' 553 | qemu_init_main_loop(&error_abort); | ^ Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- tests/unit/test-util-sockets.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/unit/test-util-sockets.c b/tests/unit/test-util-sockets.c index ee66d727c38..ab3f39c3efb 100644 --- a/tests/unit/test-util-sockets.c +++ b/tests/unit/test-util-sockets.c @@ -19,6 +19,7 @@ */ =20 #include "qemu/osdep.h" +#include "qemu/main-loop.h" #include "qemu/sockets.h" #include "qapi/error.h" #include "socket-helpers.h" --=20 2.53.0 From nobody Wed Aug 26 07:24:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786541969; cv=none; d=zohomail.com; s=zohoarc; b=hURyDx9S7IU0Q5BWy2s6eFl8Mkf0c4DeYkkCmoe8YezA8gmvGniHLx578U35aecYCgf0J3qdNteh5Zx5cLOR46JT0B11iuN3OwQQDXjfWDWhR+s+aMHcs8WJIekOBJyqaOROg5JFzi5TEW70095zD/jCiRVcGvX8+gqUENNcpow= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786541969; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=sMhnZePIGQRJ1GcAmTkyA85QXWrCwBcN99I8ECvu43Y=; b=HxFV4zTB/QPduN7c4W7a2ZpmVi4VBOA4jvwZ9F2zvn1lZzXsYXoGIXxSmLjlWPAR0uUsWPdE3SECOGRo0uxnjBrnuh8GjVtH6qT1wj+7+VsNGmlyREcM3kzboFvrulUZkIfpJe40KFcTXg4kLleATagaUq2Da4zXlXGbiYn9GIE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786541969983970.7470299188523; Wed, 12 Aug 2026 06:39:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wu8my-0004oe-5q; Wed, 12 Aug 2026 09:14:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8km-0003a7-Tz for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:12:22 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8kg-0006Qd-Hl for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:12:19 -0400 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67CB4IAe3637776 for ; Wed, 12 Aug 2026 13:12:13 GMT Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g0jgrhrrh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Aug 2026 13:12:12 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-5283fa0656dso26657371cf.1 for ; Wed, 12 Aug 2026 06:12:12 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48150d702c9sm7464522f8f.34.2026.08.12.06.12.10 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 12 Aug 2026 06:12:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sMhnZePIGQRJ1GcAmTkyA85QXWrCwBcN99I8ECvu43Y=; b=WC3Sn+cJQxqAmqIT +8dcotlQYPfe2s0abdcqQUj1a8qDg3NFtJ+zi4ifeOA4eNH9jpL71pgZAg+Nd7E2 UMo+JXQ09AlM8ChvNC741GzpHma8Bq/GYUAmM28yKOnSUaqe7tZI4iLdAqfA7IfK CGvsR0mtQ9LzXo3EmGnCAmloDkcJ3/j843JJl2BFHD70k3t0KbcUUfMIqKYZpiY7 y/PzYfIh5BIPXL1pi216cUltirgDojYHOd1ilyxYDnLx83Ps9DVer12L4bVs7tdb 7Wbts/XUpVYWQngCqqpL/NY+72e3J+b4Y8a9ZzpVrEKVvbHcsHC+iz8tKtVpHzBQ UY/hKg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786540332; x=1787145132; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=sMhnZePIGQRJ1GcAmTkyA85QXWrCwBcN99I8ECvu43Y=; b=HPoa6NKqC3/c+dhuvh8D5AOWaZhaCKW/mwaLTxYHZxYMc7iEqe+01nAr7+CMbeShrD ecH18WOCj0hT7FZvFG0BR1QnLJebzb/r7v593/Y89cWFtFAJZfeaT+m9fKahxX+1nKZF MYWd/ayb0s19ef9iLEkMDNrbGtcjAkH7Rp25sJDIf63T4Vvtl54I0cazd3evvb7DjgoE n48V0icL3SqaX8cjDVSxymiyMMpLYR1nFipSRvYccOA5+xm+m7kUvxDLcN6ILx7KuGXS /DNNjZx0BM1Ox7CAx3BVjLLTfVUq/FgeJkfJSX8FqSyK/OCPfAj9eGa6xc90FTi2K11v TVFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786540332; x=1787145132; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=sMhnZePIGQRJ1GcAmTkyA85QXWrCwBcN99I8ECvu43Y=; b=K3cXUEQKb5gL1awKtPLSgS0xNNsrccirqzCgW4w3AIU1HM0knwz7+k17DnVW2hWEn6 ai+wS3empdg390uV/4fAg3Xu/S45Lm7JwJENRlWmii+r1Pw+f1FBMNmamOC9ZkKCepPG QnnuTjWxrGHCXnMOlQ8b+/8su2QyceUH0UuGth8moiy565CAAy882BTsLAmfpxWuI8QU q96mdH929dj1Yw8y73eQcgoXujwgzPWGn3cDENFn18yP1QeZuLqhXof632hophEUQeHN N1MY8b2OIA9NcOJBVxDVKwpl1MocRgATeRF/y3eRZ3NYigPCuSvX6mJiqpVqr2q2UlGl EmYw== X-Forwarded-Encrypted: i=1; AHgh+Rr/p9WYm4loEqTeqOzodWfQdVxcpyfOPWF1+k2GQT//VhqgOZO6MAb/0gCdBlbJeJBAMfz5WVCZK9H5@nongnu.org X-Gm-Message-State: AOJu0YxJWVth9AXvCGdJ2CxyIOk2dB0m/FG3oHiyxjWFtFCkezpFssqQ vMg+AWpx6wRuAaFSnhGFFrYwXT9/ZL4UQQ1EsNndMVRUcqVY41AclXd1JfdIkxn4IF1dO68JCtQ KsNno9Pl20OWGuKHj+LgX6kr5nFMzJPWIOdU/iA5j8vBygaOGqzsMq8Tbig== X-Gm-Gg: AR+sD13W9y6Q7YXUhU6SgqwA7I938IFlE8PytQovdLx9E7+FfvXFFFbx+NoJC4+k3zS f7jzDQx9T5ksjxtS1IUS5Iwclp+xge60TLksqwwHljaYglp7tLMU8kQC5kVWmYC1D12aS6WDAtb FMVWNYoob1yJJbuD31z6fdNO/+VLudfQ4sxIabzcxjyKoWNM84xp1RGQtrKcmsl1HJI0W7ahSo4 nnh3R6VGzLv0zggvqCY4MI1OVsrn4/JvIbXIAo6JBpNUVsKq+nSOU16HWJC1HwC0rKi5L8UI9nv 0jT8i/oecGMDC7LytMTL3uoG0nOUJEKAe3CfwMg/uhkf9YjpHpnCKLdSG+o8TrfuyprcRS4dmqy u3KhCtilIsXVBYQmla4O9DgWsv00nrTfV4olb6YsYDA== X-Received: by 2002:ac8:7dc1:0:b0:52d:3483:ed0a with SMTP id d75a77b69052e-52d6030e1femr60099301cf.18.1786540331965; Wed, 12 Aug 2026 06:12:11 -0700 (PDT) X-Received: by 2002:ac8:7dc1:0:b0:52d:3483:ed0a with SMTP id d75a77b69052e-52d6030e1femr60098421cf.18.1786540331438; Wed, 12 Aug 2026 06:12:11 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , qemu-devel@nongnu.org Cc: Markus Armbruster , David Gibson , "Dr. David Alan Gilbert" , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Michael Roth Subject: [PATCH v2 03/16] qapi/qmp-dispatch: Include 'qemu/aio-wait.h' and 'monitor/monitor.h' Date: Wed, 12 Aug 2026 15:11:34 +0200 Message-ID: <20260812131147.83188-4-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260812131147.83188-1-philmd@oss.qualcomm.com> References: <20260812131147.83188-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfX1Sz+cqCe7VqL 3nCR9hQIY1XLKIQamDgmBetBZDj4C02Qb078mL3qTp23u+eICp4J7jcpvE57ESvditKMyxE9jeR xIVE7xMjcgFJMy0a8B5qcqCxUx5ZgmuoI045bFslCHzXuFwzqCrgjxWqBHikQN1JuzAzbh7TFxC g8a6QrCWc8kbQh1nXFtavHDrWoer7pGSj7moLXheRMC+/Nm0JtAKi+CPZqgJRvDQjX5t9TyW2Oa TcRKO01zbh7waepEsl+wfxOyAwTupQaD0IlNNZimhkDpoHLsyNx7V7pv/YacfqkxWQrVozKjKun lMy1Mcn34BBECyrFoM5M/VIPdTk1HN8anv+jcVtB8HUf6HhEoiLJ6LTK5tji1cSutCI3im2v1/h 1Se24cvW1GgAn+WWk5d2yg/jabYO49TWox+MOu4BDlRW4qoiBVjuNIwO0pz/IpSQmnC0DIJ/f5j EmeyXq9XkTaUM5PR7lw== X-Proofpoint-ORIG-GUID: 3ywty-3SFpfvuCFRUkB9pjyTkCA4UEEl X-Authority-Analysis: v=2.4 cv=TNJ1jVla c=1 sm=1 tr=0 ts=6a7c712c cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=nvPXPl7hlwrUdsg_yu4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: 3ywty-3SFpfvuCFRUkB9pjyTkCA4UEEl X-Proofpoint-Spam-Info: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfXxgNftsEK6lK3 EZ9O5Pi4kC31DfvwPXVJW9/Cg1V0H9vbUSzKBQ49bEyQa25X74DQBpyfjKHEf8S+9K7v+eAVl0g DQKN2JlVRHQAHffq75iKT9y20W9SWok= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-12_03,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 phishscore=0 impostorscore=0 adultscore=0 suspectscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608120107 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786541971033158500 qmp-dispatch.c calls aio_wait_kick() and monitor_cur(). Include the header declaring them in order to avoid the following build failure when refactoring unrelated headers: ../qapi/qmp-dispatch.c:126:12: error: call to undeclared function 'monito= r_cur' 126 | assert(monitor_cur() =3D=3D NULL); | ^ ../qapi/qmp-dispatch.c:141:5: error: call to undeclared function 'aio_wai= t_kick' 141 | aio_wait_kick(); | ^ Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- qapi/qmp-dispatch.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c index e3897d51977..965cad64998 100644 --- a/qapi/qmp-dispatch.c +++ b/qapi/qmp-dispatch.c @@ -14,6 +14,7 @@ #include "qemu/osdep.h" =20 #include "qemu/aio.h" +#include "qemu/aio-wait.h" #include "qapi/compat-policy.h" #include "qapi/error.h" #include "qapi/qmp-registry.h" @@ -24,6 +25,7 @@ #include "qobject/qbool.h" #include "qemu/coroutine.h" #include "qemu/main-loop.h" +#include "monitor/monitor.h" =20 Visitor *qobject_input_visitor_new_qmp(QObject *obj) { --=20 2.53.0 From nobody Wed Aug 26 07:24:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786541949; cv=none; d=zohomail.com; s=zohoarc; b=EZ5uLOBbe42AhvkiPfVkbhZwqf3ShlcCtKnrejuDt9i9bpwIzxxvoieW/o0F7qYDDFOwPPobu0gpZ4rfDliY5Cq9lcREc8WVjIpQrPAEYaYNb1A/WrNNbURyLHdCv5Z9OAuXtHRLCPN81FVXOyjHumAb5HGFsvPrcjLtLjNfQa8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786541949; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Pte7PXi9rfPSck3gExkYCTKXjVhMybGFWn5OGeUoYwo=; b=JMOqujRLv3QQOGVyWhU7kJF+cX9iA7tbScglOobCsm0CV51iYiOoqKVcYCzBCgRN+YMCXO0+p4MZLVtFttUxnb7HyKNHLJisfi6HoAUZLZqb+Ua72TE3YGr+jM07+t6ivnYmVIij9mWmk8aab6vzT+2EyKRNGvCkRD9ePEnt+Q4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786541949538964.7901252105615; Wed, 12 Aug 2026 06:39:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wu8n0-0004sp-OY; Wed, 12 Aug 2026 09:14:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8ks-0003fh-Gl for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:12:33 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8km-0006SO-Jt for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:12:23 -0400 Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67CB4YFo3619709 for ; Wed, 12 Aug 2026 13:12:19 GMT Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g0hj2sy62-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Aug 2026 13:12:19 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51c1d30035dso8782031cf.2 for ; Wed, 12 Aug 2026 06:12:19 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48150d4e675sm7727843f8f.23.2026.08.12.06.12.17 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 12 Aug 2026 06:12:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Pte7PXi9rfPSck3gExkYCTKXjVhMybGFWn5OGeUoYwo=; b=mzaC/IKqwgbyDWsJ ikJYJO0e/v465gCCZoaewlQL201pTeWKSDgCT+5kMxePEIj73ehWZlgZf7wBcIHA 7zzzSTNQIMamVuVXyAjTbZg9/nEz8bB6YXsnQkcb1fKjuDVXMV0i3wofxk5gKAUS z+c5RT6LSqq/AnTDNXqdi9tEq7vzAd2+csrBdjNS4nrGEgSR2TcxwZ7RIwSopFV3 DSDAPZ65y/Nx749OJiYWVt0/c5f3WU+8Ilc1DXM3Xglz08hqni+0VWZCP0AK5W/G 2Ouq6ZVSsYZHUitgYdMKSlea/0lkTa4rPh+YdOxs+0NUj7BnDU5FtxJP47KjfFvA nEtfoA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786540339; x=1787145139; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Pte7PXi9rfPSck3gExkYCTKXjVhMybGFWn5OGeUoYwo=; b=W2wKrVVHne8Wb0D5LaHj9beZomk0Bf3U3qCkEH56GyVRGNZ3nimvdg1jhSF/vJd5sk cUZgMZpsl8HRGzv8CvZJ+XOMpVKxnnsCmgBcv/wpLwQ/L0LQCtFn9AKt4w0IOs66zW0/ shihm2ugrWKUCj4Z6FEKM0jN2mFY0z44vKzs2c4XDdqaRWq3ADZfxsvbT/Ii9C1grXKE 9WpyZXJoAB5CZuK7coecPW/ojdtZJym0sYJZQ2NuqviOKo8CjF5ZKriLtE/WQCO9jw4b zvN7Xq1DpzJ8Z1xtrbiY6SmWm3l3LHLkcTnk3o/57Qp6lapOZC6f4VklfCCbdLQKsgav Qqaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786540339; x=1787145139; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Pte7PXi9rfPSck3gExkYCTKXjVhMybGFWn5OGeUoYwo=; b=mbD0KKE9EFVfNS7WgWb3tpDSvvtlR08CHoaArcS6BxNCpJ0kBAtaygVvP06q1dzUAV zWC2VgIhtqenA5VvUMg4EW/u8UPy0J0jX15usEVIjrjkioKslmauhPB0NBjtyNR0f6MH 8Pm2cSVEyrK4cJWeDb4S/xv695Km7gRzwNZYJLD3S5FPdaEJqphtxR9N/qSeeYJbtrjS TqVZqCkmLJ0YReB7SUyn8i0xYY/VN83hA/dxBAEoq2q6t3HjbhBIIcsGiU2cuGyq7+1t 9slimzn40Da4ZO8mAhRF0DvwMs7qUCJVWEVAn6KGFQXiOChrTfNxpOBFsQBcoubj2kwK 03Xg== X-Forwarded-Encrypted: i=1; AHgh+Rqx3dcxcIv1551u1wRfibo6HH9TLp4O6Lku3si75yOE1mQKf4z3GxFD0JjaHF7gCE54BKGmlcbSmQH3@nongnu.org X-Gm-Message-State: AOJu0Yz/jHVxOkSrdmFzDB1l3svuJ3k+KQgkXfW+6K+/Jaivehv9+Qcx mC5NLUBfJb1rSmWvFsCdC1WwFDGyBUtwoSO6GxAvVmeCbZai0NZjhMGyuskrIhwSRXt1ZdWSFrE hYM8l9Pp3b6RrRaPZGyLoPe7KoumizldETK+MNSdH48EtUdBnGfCssTGELA== X-Gm-Gg: AR+sD11bVnCTuAVtiXHA3j+Re0v8Eys1Uz1g6DJCJhJcbAfwkJD1cMU0Et9FZmBbza7 l4xeLejBEYSSon9zZaRrI6fF5hqYM+QCH4AmNLN2j/43bq/77c71a6GqCer57XKvuub4pbxfcLL reaQWaQowVIiQ1sonD2CZpGn35+SPp99J5jY0RVIIuBnNHkEWrzkyzh5M6OQZlwy5sXlKAoN+Bc sude3Bq6YinAMEkvmAkQxSkHQum3eiGf1xne4nwHUVn5tmec61aUsnHZ97fICQKGzugxl1taqyV 1cH8sj4XnVTmbe7ZxvAUXWp+FtcA9dx9S+H7mfPALIADKD0ordx3hslHHSSodKxo4Us5HO0Pq+U jET7z8+9s/1DRZdauW8DlyzYa1RawWiiypyltLdUUHA== X-Received: by 2002:a05:622a:903:b0:51c:1532:ae84 with SMTP id d75a77b69052e-52d646ba976mr37951431cf.6.1786540338971; Wed, 12 Aug 2026 06:12:18 -0700 (PDT) X-Received: by 2002:a05:622a:903:b0:51c:1532:ae84 with SMTP id d75a77b69052e-52d646ba976mr37950521cf.6.1786540338441; Wed, 12 Aug 2026 06:12:18 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , qemu-devel@nongnu.org Cc: Markus Armbruster , David Gibson , "Dr. David Alan Gilbert" , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Michael Roth Subject: [PATCH v2 04/16] qapi/qmp-registry: Remove unnecessary 'monitor/monitor.h' header Date: Wed, 12 Aug 2026 15:11:35 +0200 Message-ID: <20260812131147.83188-5-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260812131147.83188-1-philmd@oss.qualcomm.com> References: <20260812131147.83188-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=a8EAM0SF c=1 sm=1 tr=0 ts=6a7c7133 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=pyR_pgRpKyPxIfy4wdgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-ORIG-GUID: lLUBpkXDgzXI_QJuHSKeEmMUCOInBLbf X-Proofpoint-GUID: lLUBpkXDgzXI_QJuHSKeEmMUCOInBLbf X-Proofpoint-Spam-Info: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfXxHEHsth/TgjI bkIsGBQfHA0fR8kE2VMkbGmWitgNhjEbeWddnZP4JI69IKwH+Ycs0baRoo650qV362pNSyMnlim 4wttzpVVE33994ka4frsFVe9IKGO4iw= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfX9p7Y0pcTMnTD mAQMbX7M6VJAW7QPKyiEDyf8NVSmXp0WNSh8LlUIvWJN6g2EBXtpgHZ56WdaZi+RI4XSVeY5UAR 1Qnqnx8IFpxrBAIEAYpg69i2X/YEM1abbKBZjH5/+oOjV2PmTTAcyLDvVG2rR+gDpBQVQBjqcCd v7JePgfx/JSBgF5K31Qy0htve9hUdAaiJBlZXCqKo4/4FTEdJuURnehkKESuvm8QznZiqWzRH12 BVNFPcMALiuxnHw65AY1lokqyZ9bP/q/C8rUbl3l2T1GcBy2PQSFRl8aVV9JmUl2ii/6icnnAzG Aqvteg2c5HiJSm99nx4QUZIXuNwXGh6KuMmaqeP6S5uGfGejncPzwb2u2e8dcAliu3lyKk3BVd6 zjOjvXnC5mu1UDVlB5xIusnqJctGR2qiQLyyLUsli0LASZ2Gap/5g+uyNb4sp9qePxoXx3shbSq 3YJ27yRVwfCUtt8UoRw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-12_03,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 adultscore=0 spamscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608120107 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786541950738158500 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- include/qapi/qmp-registry.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/qapi/qmp-registry.h b/include/qapi/qmp-registry.h index e0ee1ad3ac6..6146306a3a1 100644 --- a/include/qapi/qmp-registry.h +++ b/include/qapi/qmp-registry.h @@ -14,7 +14,6 @@ #ifndef QAPI_QMP_DISPATCH_H #define QAPI_QMP_DISPATCH_H =20 -#include "monitor/monitor.h" #include "qemu/queue.h" =20 typedef void (QmpCommandFunc)(QDict *, QObject **, Error **); --=20 2.53.0 From nobody Wed Aug 26 07:24:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786542026; cv=none; d=zohomail.com; s=zohoarc; b=TVw+J323/jTh4XNc9OkKpwbLwFWk7jqGjLj9/ne9YDwZl9jlz4Wb1enymLP3BvV8ShXczibHbtMcngzxwFS5Hk1978MI6i3W0D9RT9E5Ef0ZRiREnYhZ1rb/CPfThQJwvI5B91z4/Dsb9b3bzC3qwagW6oToVkRiEKzmyeWchhU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786542026; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tzSJvizIBg6YtfGtqY4W6z6sjd8EIOyQn4ckmYQI+Ss=; b=jOFUg6WNX/ZA+B3jYHB585J51s83msYi7MILQsStuNuZgj8Xq0xSmUjCBukJaEve/mLaClV9WHCIoTpv/ji0h483FOiPZClRoosNVYDjU24rQh7Zyeeqv4RWyxuTDzQPy1KSDa3BRXhr5FI64Zrx9MeK4mfj09HSM3/lE+HLn4k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786542026328891.0907916117658; Wed, 12 Aug 2026 06:40:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wu8on-0006yz-74; Wed, 12 Aug 2026 09:16:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8l9-0003jb-3C for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:12:46 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8kx-0006UM-Tt for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:12:34 -0400 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67CB4R9x3320726 for ; Wed, 12 Aug 2026 13:12:27 GMT Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g0pmyrpmf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Aug 2026 13:12:27 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-5283df62d68so8113281cf.0 for ; Wed, 12 Aug 2026 06:12:26 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4997c93955bsm48889805e9.2.2026.08.12.06.12.24 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 12 Aug 2026 06:12:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tzSJvizIBg6YtfGtqY4W6z6sjd8EIOyQn4ckmYQI+Ss=; b=fq16mE+/WYVNy7cl N3Jmz1S2VlYO3FhvzevZJamZzlY84eAssjtLfp5cofj+khMpchs0CIH+cNAflI+P B7R2BWMtMCgXsquOhpglKoqWqldwBha4mXRn88X1aRo9/QEuYCo+PI0PidMis5sh ef8yiBd2TEgJAVC7b97QRJoLszzC4c5l1FUTvNxJ7Do3rkUKszHAHZcuFuQoHrul mr7YEAgteFYA8todH9qdWLkFz7S2aI/t6xCUpKgr3dm5n7odFNIwPMAf0J0VgDFq +EWZy7WLLXf0slL1GAqsWyZyxunfzrg19iFjAEYT+CPckxDUAa4sJo9frTi1zQjp ceimBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786540346; x=1787145146; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=tzSJvizIBg6YtfGtqY4W6z6sjd8EIOyQn4ckmYQI+Ss=; b=Y5u2SWTvDguSsBbZCaliesDtUCtysD/iZDjHAnOhlGof09AunCOcb5lMusoI6TJKnp WMVm5IrxrJriUg6TOoEPHhM6vTaGjsNjKVen6VElp+PEnr/t1MNw/kMlKj8kPJZRyAlS Z5gu9gd6TWPuJWPXksFCALrTM2zHraKS1bbkSg8E8fgu/j80FmrMnZZAMBrvRiczUBja 08INtEeH13Z8Q3Uh5FWXtG8TtOD8bWfLzjF104TFph9JbLbG/X6Cx/AH0DB8wSrOvZDr IQYfr7i0VtH1lmvo/dutKLvcE2LnuiptDcxNGJ9v/oVE46OQbwgrBB98JDx+BY7NzElI RnMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786540346; x=1787145146; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tzSJvizIBg6YtfGtqY4W6z6sjd8EIOyQn4ckmYQI+Ss=; b=cVr5YYMgM0TQbMCe0HV0VDgsDa6cPHwqYHS97bHHwCFoIX9liWOD1U4sD1VvnXcP/u jeewzvoHFwSI+m3SyVpSVB/7G9YmeXMl2rdxjSFSM/x7uckxKZ6Q63VndPBQ6Dvv2FjO 0ZSYY+8aPBAyZ4z267riYeDp6sxeN6WV6+xjxMr1FQykXAdalmfbZdhl1heTTd6T4NX+ 7CE2fLjDERJ2ksAunApzLDOeXGXlIdXi6p/nTCDHDEoNLKGKo6sbU5Bqlunt0gGFDzUF BKfuGK306Fnwnh1Gat1qzyEi7xs3fJJic7wW/Xkjffunh4BmuIDDWnIGcpP+Bgr9Ua4h FauA== X-Forwarded-Encrypted: i=1; AHgh+Rr10tZNKS+q+WA2vjSpjO8tH1GyT/pW6LThmTTo/oAeQWl2NNtF4B7TsE356Vi4uZkIT9++YLFpsk6K@nongnu.org X-Gm-Message-State: AOJu0Yy0KWIYP/qLhdoCdRYv+6idnIR083CTbG/faROgQ+UQoL5rPSUH nfxVAyf6wkjtQv2HUfbIkWYqdxNvYJAswosovJZWXXl+6p/5niZ3Du+GgGU9yNAuV+BndzUF2AV eojiWm5pxZ52QTj4Pd2KB7voxCGYUIy7+IDHjG0kzNOWmyjjQIOA06ly9JQ== X-Gm-Gg: AR+sD12xXzvR5GKPoIA6ckS0viOqahdp6MuWesXREiMdUvnrUBEvBw5BfPrmQh93D2k vn+SK/Kh9DQJSvpsiWt4jk+ZYqf7Xfco+i/pWreROCTZfNOnL9afQq74eZcItZdPYpkIfYzPGug er/3hLyr7WfYnMINA3agpV5MJhol0JrFZLRtGm6aSt6/ma9b4/dtP0cnoLc1DT6HHhI+vAIfnuE FA3fxwoGUXTc87deeuHE2PuUb7BVJW/VaP+oGCGyd78S/PLyWsn/vRdS4ddElkjRtKp+Ho0Wnhd FEGiJalto1Vt12EEsNu433xUWPnigseIKghWkBCJP1rdhpjKXG5WCM5TfGt8L/u4GHzfiQm4ZQ/ mxAdYbzaOnA8JL99oMhfJEBapwtqfGYzPB1AAVhVvBA== X-Received: by 2002:a05:622a:106:b0:516:dff5:68c4 with SMTP id d75a77b69052e-52d646a1e00mr35249361cf.7.1786540346120; Wed, 12 Aug 2026 06:12:26 -0700 (PDT) X-Received: by 2002:a05:622a:106:b0:516:dff5:68c4 with SMTP id d75a77b69052e-52d646a1e00mr35248671cf.7.1786540345631; Wed, 12 Aug 2026 06:12:25 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , qemu-devel@nongnu.org Cc: Markus Armbruster , David Gibson , "Dr. David Alan Gilbert" , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Peter Xu , Fabiano Rosas Subject: [PATCH v2 05/16] migration/hmp-cmds: Include 'block/block-global-state.h' header Date: Wed, 12 Aug 2026 15:11:36 +0200 Message-ID: <20260812131147.83188-6-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260812131147.83188-1-philmd@oss.qualcomm.com> References: <20260812131147.83188-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfX/xj6TTMcAzUg vm3n/0KucXbeXtGACV/4GQXrPbGCCtGkNo+/fDNIDUtDA+SJOil0gPSa88UYleSp2IemTFxBpQj HLegoeJXQrv7mvV98QzSYUelHvA89wc= X-Proofpoint-ORIG-GUID: IjRvkp1cnoMvQyB0uzTp1Qsgx_QDZdHE X-Authority-Analysis: v=2.4 cv=C/fZDwP+ c=1 sm=1 tr=0 ts=6a7c713b cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=jqKsQrdABW1tU0UTsM0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: IjRvkp1cnoMvQyB0uzTp1Qsgx_QDZdHE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfXxbbiqG5CMCJS pMla1diMqCj/ISs1mX1B/q85u/c3wKTdSaUzPOoGPheaW6segiyGy/7+SdyYM69gi0YaX4DvtWR Z0KbphWgWy2nBMF1++cWhH1Gcp/s3LKs2APVTMq04g+TMCaylUJbnoNZ9MDghKhOSUCuxtrnqIl q2pLP6qnzC+Df5qKOl0zij4IPDP+eoJpGMlS3EBEehzGEc27hRzY/aOc8IeIVxWukiR6Jd/8kCJ RVvNVK7+ZQjYNgSyjLO+o+0JsyKkmkpYNcCCTi/BO/YndDMVm43bFhbDbbpjS4+wLQECXvT/wKK nhQsLvaOLci3Pji0FOULL0xLpr9NfT/9MXtlq0AdNupLg8c2kFhSu+8Z6Q1f8BR/vZai5ULONgN 49oacmy/EsNTULdPAXf98ioNrgFvanWn0S5cKjgoz7E+9tts+C0I/+KLzR6qFch6FtImfE11n6D j/HJ1XJgMvTjVaxsh7A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-12_03,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 phishscore=0 spamscore=0 malwarescore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608120107 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786542027616158500 migration-hmp-cmds.c uses types / methods declared in "block/block-global-state.h". Include the latter otherwise we get when refactoring unrelated headers: ../migration/migration-hmp-cmds.c:911:5: error: use of undeclared identif= ier 'BdrvNextIterator' 911 | BdrvNextIterator it; | ^ ../migration/migration-hmp-cmds.c:918:15: error: call to undeclared funct= ion 'bdrv_first' 918 | for (bs =3D bdrv_first(&it); bs; bs =3D bdrv_next(&it)) { | ^ Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- migration/migration-hmp-cmds.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c index b04fc4489f4..351512942af 100644 --- a/migration/migration-hmp-cmds.c +++ b/migration/migration-hmp-cmds.c @@ -15,6 +15,7 @@ =20 #include "qemu/osdep.h" #include "block/qapi.h" +#include "block/block-global-state.h" #include "migration/snapshot.h" #include "monitor/hmp.h" #include "monitor/hmp-completion.h" --=20 2.53.0 From nobody Wed Aug 26 07:24:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786541810; cv=none; d=zohomail.com; s=zohoarc; b=LMAsIFiOjaDQqhpLijecEVBvbkkK1WL+ZVvT2Kst4ryqjxRS3JSrl8bV5ho1+TndWTCveMNRM034xaSEFuj1Bf38NrIBbt2DF5KtBbwQWhmFL5JGctAt3/aJZC09GyClDTHxGtJxCQdk6ySGWkLNmOBKE3KuizzoXH8xsTXdBug= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786541810; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=fB3X5i66McZlK+dR+cm0eP6FmuNHMAXpD6GH/8ebx+Q=; b=VNWmLBPS9RXYyejdXjqdXFjCMWFFxxAJz++MYbg4B/tVF9AfE7ODZMcqpDu+I3/CxTlSo7VBEGPU77VewBTG0MLe3PFM/GyrLHL/XKELwVk4kl99nBU+IIA1oEqpLoRnAEMfWPc7Hy9tey++30mBIaDxZHFK/4Lq+pm77PJqfgM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786541810198753.8317778442024; Wed, 12 Aug 2026 06:36:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wu8ot-0007SS-MY; Wed, 12 Aug 2026 09:16:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8lE-0003lG-Kv for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:12:50 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8l7-0006Vb-FK for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:12:45 -0400 Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67CB46jk3265824 for ; Wed, 12 Aug 2026 13:12:34 GMT Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g08jrkxv2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Aug 2026 13:12:34 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-526da7e3c9dso9445281cf.1 for ; Wed, 12 Aug 2026 06:12:34 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48150c08982sm6595158f8f.14.2026.08.12.06.12.31 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 12 Aug 2026 06:12:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fB3X5i66McZlK+dR+cm0eP6FmuNHMAXpD6GH/8ebx+Q=; b=MfZ44QJieVxispJM MRVVglEO9Q68Ya2m9+2TBQdAHfZ/OAD9lzubGsA2xphujiKhGbhHhCCt5KBiPsMa TW0OPiCVkIWgIOXBEOCU8gep/rpotrfmi3DxiefD50dYNJ6uloAdLhk/y1d4GhdN T1DMEYQX5TW46Rd9NU/jqRLrQ2+jEEHQIQnSMgjsOFSk3iLGLexYAA5oq67SIH7g 4akivXEw2e5RTIwEVgfSvvRfTJNPMXCYeR+F4KjchQCI8DmSt6xK80kv5wb0BT4e rULnrgy+J/ZG7hqQSBIQgm25WOVgwh6pHPBU2/sxVrYbIEr27AHcxAxYEDMXbzpD cddfPw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786540353; x=1787145153; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=fB3X5i66McZlK+dR+cm0eP6FmuNHMAXpD6GH/8ebx+Q=; b=WL4+EAR4TODOFiYeTdqvyNyVGGKP5KISjnxPot0Srm6gnin+sBtiMvVZVjeW3l+5we 3w4QLss5WnPRwJCF+HNuYgnRQNVHkk5rq161pvRWVO5aBCuKSayvJpYq9A3HgAw3NvYT bVcfJ8hXFoPRiSj/daz82u9kWGybb0QI3urbxm+jT4GfNxIAkMzlYDqEhtGDTAtYDtfl 2m1YaXE0tAv8fc/4aL7gXPKeRRpJmEGAH3vrJ2yQRtAKMo/tzOsHRM8s8WkqgCFhwFbs 6B+LyiWWDO2YkZd0pqY8I/JHy6xNh5lBdKvola3ZcpMnCgv5vvcgjhL3w20Y6RxanAv7 cFNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786540353; x=1787145153; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=fB3X5i66McZlK+dR+cm0eP6FmuNHMAXpD6GH/8ebx+Q=; b=g7CPZN7oUcZsRI3RQFTFNwIqduLOdnpCAhsw4lyXzVEWdyKMetcLY6+wZnB2ns9oKd NbyIa9MGra1so9HQ913dxNiqPBaflrboX8QckSL9hiApdQeL+TD5R7+BoTURlwlALvww Mf1X5GlDCH0Eq5QhQ0Lc/Q/smVlzORPNG/D7Rlipocp91s9mT3vCXPriAVk0azJHnPsW 3HhUyxbKUz47CPmnmQZzxrFEGQV/syVKuKmCePNyE9V/ReAMTpBpBmfdV0zMKwDwqjne NfZT0imhz8BQxySM8Q21BKXNnwScev6dKMe71dE8nKWWjXt+23yrvp7C6GXnm/R/TERr mFCg== X-Forwarded-Encrypted: i=1; AHgh+RpDGt1UqVMyRq0PF5mNLPJ6J57xG+xztlf8lw3gVAgYK1J6aDtQTnr4fjFrWYrt/zXDvJIFT+eteyhA@nongnu.org X-Gm-Message-State: AOJu0YwciBdY65Nzp2HZuv+Gs+z4u8yYTcDjv1bUgkIJ6QZkdQOMv61d KyPhTFbaM+gIfSEklAuKH6HXdeAq6v+cWe6I2AIMEZKsk71T8iFSgGrPm7oltJrr+XXTrayId6a 7arkbYnkbwnpoF3QeIVK9ZFJ0+y6E3MRPSbIdscmVc1CmJ2p/l6oLojYkHIUk/g6ViA== X-Gm-Gg: AR+sD11iPwwpj8fgtn1L0cWgpoaaUc+3jfwfxoltdhA3VRyjxCx+Zu75ju/ODxuqMMc 85lqJTqzKA1AS4GJVVG5Tmu1hknJahD230L8ZyL8AwbdDFBJGEhYajcZOVC9zH7L2bcwKFUdBhN LA0CgzC3upj8pSspLzNwT0iKp4+asWuDSZaIEhtGpd90nUI/VJUKfuNi434ZS2faa0DH03o/I/a n2sOViZ3DngWllno3AqJ7ZedQ4SUsannIhTGsQWAM9CvS7nT0jKP81wbEsLfff/n7vdIvdCSCcw nhqmG+0dhjGBWXFNl5IMIyaIhz7K7EpB/Z07FbHxM3cia/zXXRVk5iM83VHPGcY/NaoJLRcSjmK vjMbqwGWuJ4MYb9SBKmJGZ+ALjyuTk2blp8Z3nEuAyw== X-Received: by 2002:ac8:7d8d:0:b0:51b:f857:cf82 with SMTP id d75a77b69052e-52d646b9ff2mr35513301cf.8.1786540353234; Wed, 12 Aug 2026 06:12:33 -0700 (PDT) X-Received: by 2002:ac8:7d8d:0:b0:51b:f857:cf82 with SMTP id d75a77b69052e-52d646b9ff2mr35512761cf.8.1786540352710; Wed, 12 Aug 2026 06:12:32 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , qemu-devel@nongnu.org Cc: Markus Armbruster , David Gibson , "Dr. David Alan Gilbert" , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 06/16] monitor: Include missing 'qemu/aio-wait.h' header Date: Wed, 12 Aug 2026 15:11:37 +0200 Message-ID: <20260812131147.83188-7-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260812131147.83188-1-philmd@oss.qualcomm.com> References: <20260812131147.83188-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: N-porOeW8lwEqPeVIZN1B2SJ9h995pdw X-Proofpoint-Spam-Info: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfX0O218636K3K7 wJrd3OzmodFuZTIfR0NUFTo3SSufXeZYQ0fbFGmYdjkTVI4gufQDBv+kxTYhJxz5XdxYzU8nMiU 4zQN3ptKgS51zlZxuDg853Dy1TyOULg= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfX7FgJCQpyjC3h DChuJfuoHgvVCD/9W813QrFjuAwHQY45Z4AFohPJOVQdW4MbwF5vg4r7iAM4ykD2k+goC1NCdFU UXTbS74ulDjhR4EeMWyRJlViOSF6jkopa/DSpdMVGPk3Uvak89VL2KeIWgAiJ+PAzoqO+W3IXfo ybxhYmpwO5brlaLR8/Xmf75X5px1PmQs3fYGUOt5GGPNNwJDVCvelU/NzYxYttQZZ0itsKM99B0 R/fCM3Trrt+Tgc396N2YfqZOxSc69pMKvhj/JLON4twXJXiTjyPbh7Sa7l+LlyGPZnGH4/VX05H MLwFaKZOGPH5xfBdzp/GKF8eBfnQoMQjgqBIWuQt/ro2mjGz8LFRTDoeaBUUHwkKS8PuXsiqD2N qvWNkd9cGhz438R2/Lpa87k/neFKyfCYqoj2UTN3lJ/0AvpZn/+FLLvTlJcbngsLeGo/BnVFcft JRSoPfUlpZuN6IBP5Ww== X-Authority-Analysis: v=2.4 cv=Z7Dc2nRA c=1 sm=1 tr=0 ts=6a7c7142 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=xCX-Xho1F_OFkwux1AsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-ORIG-GUID: N-porOeW8lwEqPeVIZN1B2SJ9h995pdw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-12_03,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 impostorscore=0 spamscore=0 priorityscore=1501 bulkscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608120107 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786541812048158501 Both monitor.c and qmp.c use types / methods declared in "qemu/aio-wait.h". Include the latter to avoid the following errors when refactoring unrelated headers: ../monitor/monitor.c:648:5: error: call to undeclared function 'AIO_WAIT_= WHILE_UNLOCKED' 648 | AIO_WAIT_WHILE_UNLOCKED(NULL, | ^ ../monitor/qmp.c:792:9: error: call to undeclared function 'aio_wait_bh_o= neshot' 792 | aio_wait_bh_oneshot(iothread_get_aio_context(mon_iothread= ), | ^ Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- monitor/monitor.c | 1 + monitor/qmp.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/monitor/monitor.c b/monitor/monitor.c index ed195fd97bb..c75ae815343 100644 --- a/monitor/monitor.c +++ b/monitor/monitor.c @@ -30,6 +30,7 @@ #include "qapi/qapi-visit-control.h" #include "qobject/qdict.h" #include "qom/object_interfaces.h" +#include "qemu/aio-wait.h" #include "qemu/error-report.h" #include "qemu/option.h" #include "system/qtest.h" diff --git a/monitor/qmp.c b/monitor/qmp.c index 338d37cb7e5..6ae1098d39f 100644 --- a/monitor/qmp.c +++ b/monitor/qmp.c @@ -23,7 +23,7 @@ */ =20 #include "qemu/osdep.h" - +#include "qemu/aio-wait.h" #include "chardev/char-io.h" #include "monitor-internal.h" #include "qapi/error.h" --=20 2.53.0 From nobody Wed Aug 26 07:24:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786541675; cv=none; d=zohomail.com; s=zohoarc; b=XNoeF1QYOxP5d0RardS7N9WA7eGfKD5BqS0xbfxreIRXJC6Y8km184FlKk3fimIOOlDuGb/R24hIlUgbYs5co6TfhNoGJ2N3FT+bSAbctb4Bvz3NappLoQDhvP0d8SWP4xj+q5MhxL0v3bOdPFBD3zCzn8jKXEU3TOGLM7/0lyA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786541675; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=DrbbpvJ8PS4d9Wmp3LH1rQVAhWTDBdxV8i64qa6nA5o=; b=nAYmzXg4hdUtIH5bBhwgrQx7ypLY+rqq3f5HqRBFsJM7Xa/5FOhUQAESrOS7RhoQbXm6AQCyTRrbaNY9iEdzdUGcsxPnCeESVsniqYfzN/4lMZeiTq8h62gcqyDoJqT3yWsu2vw381Gn40GNN0BHlu9TJM9HF/GgZTSRRgodlE0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786541675458453.92867625165593; Wed, 12 Aug 2026 06:34:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wu8oC-0005rT-Bk; Wed, 12 Aug 2026 09:15:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8lG-0003lp-0r for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:12:51 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8lA-0006WY-Qj for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:12:48 -0400 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67CB4W0j3637934 for ; Wed, 12 Aug 2026 13:12:41 GMT Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g0jgrhrt6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Aug 2026 13:12:40 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c1eb52e1fso17233261cf.0 for ; Wed, 12 Aug 2026 06:12:40 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48150d4c10asm7363884f8f.20.2026.08.12.06.12.38 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 12 Aug 2026 06:12:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= DrbbpvJ8PS4d9Wmp3LH1rQVAhWTDBdxV8i64qa6nA5o=; b=U1JQ480wDXGjhnnU pc75/axCtaoL/6t8g2Co73qd/tKlNo5OjpARHJ+ZqzQWGm5QK8d+luXHFl0XGE3v ocHDEbptVuJg1WSRWe+z+o2POqm2SKIjzgVHrCYS9YkkBHCd3ULVsRTj410aUiaN iqSxxBQ2srqaI3Jtr3kyxTECj38/TzrVz363gRA1gbXi6LGjY3BqwbuzW/gB2p2u EYgCnUJAQO4p0OiqduP8r1l05QESk1JaIX3EniNTAYnMxuswV9xNv+EEqBGcizIX RiHkElamEYtT1NnkXBeMReRxFddbOvtTQIlDbXkbSO4HdxPPDv6sx92yUUASCPHO BGh58A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786540360; x=1787145160; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=DrbbpvJ8PS4d9Wmp3LH1rQVAhWTDBdxV8i64qa6nA5o=; b=JiQvrMwM0Jc8EkJJaJSHe65RfeA1aLDjSbADdzWQMQawY2LezsBWMGP2dy4SSxjUgM Nq5ECENeDtVuEc+I9tL7KNgnan9YXgTGW44BC8z5EQ7JrIKNI5dqmrDrTYEHtLnZRpAU q8ByYYZB14QlYNZcU05bX/uXlguhzru4Lksz3d3/yQfqK34I6bX7fdv6OYR4ckyRT0ki 3H8hgbpA0IdqrNOBUd96vGHF6ejhuOlsP6P6w+OiNOzuuYh3PllhawUnE8pJUVvQoaNZ MLWq1m37ETTHgKDuwJB3/Cb86l+ulcL0Jmoc5COeTkz1Qj4l6QYdXFIu8/xdItHbLh44 tCQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786540360; x=1787145160; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=DrbbpvJ8PS4d9Wmp3LH1rQVAhWTDBdxV8i64qa6nA5o=; b=R2jdWzScJQXvhu9QiroPjVxG+1PbHUscquttoncW0UTyTpq1wi2+1/02lkuKqIYZPt dkOycN/RV5mqMp+7cmRKcuczkV6tV9tKlbcOnfwZJmW1KbyDgl1U28X+Wl3LlUMXMOQ1 SQdGWhinoxn8SY/dUqlHFVmtFRSGNk/u+83OypkQGC9wAfrZvwM7SJFn2CXnCKolM4hn 5oZrItjQzki+q6bTFaalP31TRos3MnzhsO/lVxuyxgpy479xmALT8Q3pRs5+MVWxMQO7 PDW9732bxbrXU6hYMUTd+kkEzYITvrjRbZXBqc4cU+dDuyRDuV+IE5lALHcmbEaWoF7D ZuNA== X-Forwarded-Encrypted: i=1; AHgh+Rp/Pfpt/KDi5Nb2qvEIaVjzeovO3yZpeO1GDNYh6q2xH7kP0YSydJGMjC+hly1LNVP9ALZ4Fm2GUDOH@nongnu.org X-Gm-Message-State: AOJu0YzECCtXSJARcMGv5sCWvEZ2rbsRmWLpMFOnpJ07nlrv1R7V4dhu Xz+IT/i7k6qfrSTIDhr19CBwj0sah4vm62ca4Tsj1m5c8niKWmyFB6WO4KoOUGid94euBpKrvOc Ycs1yAaNpLvyPTUjN+dZt4Og/8Dxa2uetPOyq0KTIT7tljYbMy83gusg+WQ== X-Gm-Gg: AR+sD11q7vh+b2+UE9Me8gqVUwSiySBGGbmX+C5nNYRZ/eRaVY8rWMgyVamlLTmIII3 0jBrARoW3LPqHc6KeOeel9p/VGb6qQ68gudrqWQysRaZhlj3Lsq8wLJRjRT+fwdJtjYXDBFmrLX HAGRc4pV97YNqhQPyheRWWkRp2mktvMcpuuolqot4BDMcrdoq5/vQ58DL9vbj8p8IlRVFxyOB6i srrajWlqBQcDgG840rT5tR+nx00Dyy6vcd/YqNtL8s/mAMHDHrqPrHNePcXWFbIhkaTBrmYPaSN zUImZAMJIhr+v3CcbAm0xhBITjiOhltP6ykIjPwNihVX/KSMiuuFdbEagvW2r3WStGmykNzXhk9 r5GN/vrmmycZ4L2/duFafY0d6bGeZNVDIPz6r/veY3Q== X-Received: by 2002:a05:622a:341:b0:517:87df:d8ec with SMTP id d75a77b69052e-52d646b85a9mr36207781cf.9.1786540360317; Wed, 12 Aug 2026 06:12:40 -0700 (PDT) X-Received: by 2002:a05:622a:341:b0:517:87df:d8ec with SMTP id d75a77b69052e-52d646b85a9mr36207241cf.9.1786540359885; Wed, 12 Aug 2026 06:12:39 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , qemu-devel@nongnu.org Cc: Markus Armbruster , David Gibson , "Dr. David Alan Gilbert" , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 07/16] monitor: Include missing 'qemu/lockable.h' header Date: Wed, 12 Aug 2026 15:11:38 +0200 Message-ID: <20260812131147.83188-8-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260812131147.83188-1-philmd@oss.qualcomm.com> References: <20260812131147.83188-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfX45smvRU/T2ox GggUfzzx1hlJXf2En7JvbJXtDzNZyTjyo6rex7YxJ+UauxeOmkKnRaT5nDu0atlAbYJj0CFqaXw ATLJVd6qjm/4iwI25lEajiCjAqITiBcwqOiqHlKCi9W2yTh8dEzS4syb8XsYnO0JUfpuFwIrham RPhPK/496CXSeQC6OLNWYT8kKBGlAzw7iUNvOrRm8gpGOglIuxPc78ho9Nvt2oqfSGW9vJd8R/l E7YT0mQ5Bi+ergt6Jfq0ycWBXZRYKblpbhSi3juFsevhbrpReHcwgmWMAdDQBfV/k+Yu7Ip0kMy NHFDOFuu4ffFjI01Adf+toFukXSBZ2deJjnDGXwJTB5qD0Lwaq5+vQrns6Lpm3nSt2WiK32hT1X fBnV4kg+G8gWbFaUPi/4JFywiQAPme1a8qdSEt767yqArkDEirJb4N1XD4jIaSyIDLMG7KyL4wN 9IkhJL+hYKxY91RQjDQ== X-Proofpoint-ORIG-GUID: hVYVJ5Agq3N_GJBTaY3neqWBa1ij1euN X-Authority-Analysis: v=2.4 cv=TNJ1jVla c=1 sm=1 tr=0 ts=6a7c7148 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=_5bDPQybseJbp6lUwYQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: hVYVJ5Agq3N_GJBTaY3neqWBa1ij1euN X-Proofpoint-Spam-Info: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfX8ejfSB8foX0q JeeLEyzd2SseT/44MdZiitWDaHT4WMX03OR1RxS+i+TQEMtxSss3mDcxhEnTXbH8xbGhODaUrXa rcc39NS8ERA74YN95Zk9pJpg47ZveHs= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-12_03,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 phishscore=0 impostorscore=0 adultscore=0 suspectscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608120107 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786541676972158500 Files in monitor/ use the QEMU_LOCK_GUARD() macros, which are declared in "qemu/lockable.h". Include the latter to avoid when refactoring unrelated headers: ../monitor/fds.c:146:5: error: call to undeclared function 'QEMU_LOCK_GUA= RD' 146 | QEMU_LOCK_GUARD(&mon->mon_lock); | ^ ../monitor/monitor.c:176:5: error: call to undeclared function 'QEMU_LOCK= _GUARD' 176 | QEMU_LOCK_GUARD(&mon->mon_lock); | ^ ../monitor/qmp.c:164:5: error: call to undeclared function 'WITH_QEMU_LOC= K_GUARD' 164 | WITH_QEMU_LOCK_GUARD(&mon->mon_lock) { | ^ Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- monitor/fds.c | 1 + monitor/monitor.c | 1 + monitor/qmp.c | 1 + 3 files changed, 3 insertions(+) diff --git a/monitor/fds.c b/monitor/fds.c index cc35d2ec334..abe5f13487d 100644 --- a/monitor/fds.c +++ b/monitor/fds.c @@ -29,6 +29,7 @@ #include "qapi/qmp/qerror.h" #include "qemu/ctype.h" #include "qemu/cutils.h" +#include "qemu/lockable.h" #include "system/runstate.h" =20 /* file descriptors passed via SCM_RIGHTS */ diff --git a/monitor/monitor.c b/monitor/monitor.c index c75ae815343..6af09f2f6ea 100644 --- a/monitor/monitor.c +++ b/monitor/monitor.c @@ -32,6 +32,7 @@ #include "qom/object_interfaces.h" #include "qemu/aio-wait.h" #include "qemu/error-report.h" +#include "qemu/lockable.h" #include "qemu/option.h" #include "system/qtest.h" #include "trace.h" diff --git a/monitor/qmp.c b/monitor/qmp.c index 6ae1098d39f..aec03157750 100644 --- a/monitor/qmp.c +++ b/monitor/qmp.c @@ -24,6 +24,7 @@ =20 #include "qemu/osdep.h" #include "qemu/aio-wait.h" +#include "qemu/lockable.h" #include "chardev/char-io.h" #include "monitor-internal.h" #include "qapi/error.h" --=20 2.53.0 From nobody Wed Aug 26 07:24:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786541608; cv=none; d=zohomail.com; s=zohoarc; b=I93XXakCrTLz64V/SZJXlL1y/TNjdd1piimSlo42xMdvcZ+4WwE6NDvdqMYs4cvpanE/HnuV38OMi6SvL68brmhFdjlao2etzEfHD5l0F/m6DIFgVKiPkCgxFk12kz1R9OfRROk6Hm9oZap2lO+UoiP45Af9snQByjSxQ87q/Ko= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786541608; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=bJNJ71owOHpg6avfvSNvEMJvaX22jFH3qikkicdMvEc=; b=YflbjIVEr6yV75nvZgqFdj7v7UAkywROIAZSsbuPxRBxkOvHBKVxAaX6fKKq9lAxe6/zoFhtByQgA+xwwes0hSZV6TEBkzBP2qz6XaqpluXJLn4cOuwdRq8+5oAdRp8sb/jbflbOq0LWP0P5P3AeTR9ViWhK/Ml3LKq8q4UCrY4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786541608950464.8324257383242; Wed, 12 Aug 2026 06:33:28 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wu8oI-00069E-Bh; Wed, 12 Aug 2026 09:15:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8lI-0003nY-Un for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:12:54 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8lG-0006Z9-LB for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:12:52 -0400 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67CB489a3319901 for ; Wed, 12 Aug 2026 13:12:49 GMT Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g0pmyrpnw-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Aug 2026 13:12:48 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-52d28f8737eso18265331cf.2 for ; Wed, 12 Aug 2026 06:12:48 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48150d709dfsm7268835f8f.35.2026.08.12.06.12.45 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 12 Aug 2026 06:12:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bJNJ71owOHpg6avfvSNvEMJvaX22jFH3qikkicdMvEc=; b=ltYxvqVFwHI26o/g 1fp9ZEhoNEGLRxXeHqXwEesNiLqOjeOX7ON560nH1Gg3TqkyGMKwacznn6zkhJw8 u9+zpdvt4qHLz0wU3v6jIl2gv0zSMvrFkKu6uWowlR9ovsAhIZ/T94ShF/yLruC7 06n0m1iZTUus3hjp7K1ExJhT8IfNjs4a85Hj4Wkn3HmcUsuoP4BwkbN7xHA5xgI9 UF6GSXuchXuHzRMl0gbHiyrkfkCg/4Su8LvTdmMNpOX1kBpE9K04wouYW2Y7AB6j stvU9fmfEn9rdZcDmD3MRCB1368alk9N4SvobcWn6RUfz6t65kPJ8Ts02yfbsjVD IdTzUw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786540367; x=1787145167; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=bJNJ71owOHpg6avfvSNvEMJvaX22jFH3qikkicdMvEc=; b=QFPUfwBtR3l3Cbb6U9s1eEkCyo+KH2VgLpPDS9Q4nqiD+ZBEkUChmqqwC86v9UDpAg DWeXajicdXWaub6lCjN5njQR8uyqtMOXIY23yDfO/zChKM4RGqMsq2O6D3JbXTlQ9fxs aesQqEAAHVX8WBPZ9NbsKbRmymthWiB8+3vkzr4zo27JTLVzrqQOXI+vzGjsZpSDtnl9 Dygc4KV46UOAJUjI/OwZsQSJqPGHa71JCQ2YMl/0bpBMv6yaoPV7nMyl3w3dM74DjOeb 41FhGQ4sOz7k3r0EwygjpffyBDjntQheZrvr8NXFcQnnqpockZ3sTvGmtX+KKAX9wFdR Kh5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786540367; x=1787145167; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=bJNJ71owOHpg6avfvSNvEMJvaX22jFH3qikkicdMvEc=; b=cOCV0C8R8wh+f1+gOe6Dx+ZHx1OJM7dXWIgNvZCQWDzu+D0syTwkuvtzzvEa9zbtUZ /IJ/5SW4QTlZsimnOKICDyy0QFv+bAicbYqy8jhu5+w5rAVHyZIGZ46JRkk6vzFCixSe IHBlHR+eSfGmA4vnqg71XVtDG5JK7JBz6xzarX0q5LyFHYNHwQkWKwKKoWKnYbJRYeRk GZ8hg7D8jSCrIaeNNhTHlFUOFwOVZ9J01qUExvnjfJXB5YgBGvWwSz1BlBt0LqIxK0Kb zy3uYUd72OfEAfuAgHdUAysTJQhmrQrsK898DdTJiLdu0iKgt9mCW77VgvZyI5ao+ue0 wSYw== X-Forwarded-Encrypted: i=1; AHgh+Rr8JnGXZaJvKj7A98E7V4H5cADFSZVFpSMquhoHD/k2KIcdy1pWNl4mrOa+NcOk+K8XY2C/h73SZC27@nongnu.org X-Gm-Message-State: AOJu0YxEKL4VQRMK+RVeVebmPdfbET2835nm7tn/cFfu1sjYs2Rbrp6Z ef55ewKx3+hRedSVljClMgOMmAJi0TEB28ESKF8fonBAhXGvwrAmY5tK8iTlU8yK69TGCKoU6AP yLB/UJ7WhL9n5PqLukhlsMIV3RuZGUgClBRRMuE16vemHPb/tDl1bTfCQkA== X-Gm-Gg: AR+sD11SfEOcKRN52HKZTj5EqmoSozQDm6EiwFOkeWIJ6wtzqasr7gKFIW2ZRY7Tpar nT2KR6xGmu2tVwGDK4RsJm1k1rgWvUWiWWcS75fDRfdkm03Pnb0ZCFb4nvuOy9G8FjrCVZm42tE W6QLFlzPk4cciitiGWpi1bb/fNBQ8nyelI2qmysOMgzyR96x6OTP4JdvAfmHB7o0qjjLbK8J0i+ y/PQgJl7NRamjCfEGgncMgmnVcs7KQ3UisSD9ZWr3tU2m3+L0iBMQAc5fziDcxnoo+rOgo1N/oI 03OgVy6RoLXctCmHAmFjNObgQdvivzx2oRTP31Xb3NbK+Ay8a5sHBjNJ24gT6xua4NeaXVQ9dPo taragGO5Soq4Rx+VaR2F2x+OeLQSRbYlIcoQqrknOiA== X-Received: by 2002:a05:622a:558a:b0:51c:775:c175 with SMTP id d75a77b69052e-52d64875bf2mr40966011cf.40.1786540367430; Wed, 12 Aug 2026 06:12:47 -0700 (PDT) X-Received: by 2002:a05:622a:558a:b0:51c:775:c175 with SMTP id d75a77b69052e-52d64875bf2mr40965171cf.40.1786540366894; Wed, 12 Aug 2026 06:12:46 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , qemu-devel@nongnu.org Cc: Markus Armbruster , David Gibson , "Dr. David Alan Gilbert" , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 08/16] monitor: Include missing 'qemu/coroutine-core.h' header Date: Wed, 12 Aug 2026 15:11:39 +0200 Message-ID: <20260812131147.83188-9-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260812131147.83188-1-philmd@oss.qualcomm.com> References: <20260812131147.83188-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfX7M9ICXG1rYXS myzVnkAG+dAGVqEnjWPArffd9tj/ct1GejEhGQKMKOt4Nn8dhn6/L8pYcx71s6aBdLd8W2Eq0VE I/Q70kbOJl4bDMqZZVjkiLw0oJ3Uxlc= X-Proofpoint-ORIG-GUID: AainjCKa4WWjhfegtgEYEpc2zughJiGa X-Authority-Analysis: v=2.4 cv=C/fZDwP+ c=1 sm=1 tr=0 ts=6a7c7151 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=neFa9O3qn1L-Jj73aAYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: AainjCKa4WWjhfegtgEYEpc2zughJiGa X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfX/1Zd1kA/PE+Z /3DePM8BwrnNvvSpRCn0brUt/JqK1QiCJbWsz2PseeI9JftIQ3RBwLxfUHMlrDND4R8XQOkfvUt Ci4SKqTyZH9zSeyd0VjkZX7MoTRSMoC0ioFIPRP+39I9I2ByJnJcYllrqzqkf80cJBgqmlCs10s 1ias3xF5d5Ul+WXretmxib80I+3kXXDQsjMx7KG76KmwiRV0oll7+XGEei5DNbUVdhenotvSerQ oqnNgtKzfZbMg/xuCPQwlyumDtnnDOaUsPnErs1SY1tH3Bojf77E+5LMjAQ/EKNaCtHLOV5OKbb 9FjKy0Jg0nCp4AfC2yC5RYwIwO3yNF2N/iR+LzY/YY1AQG0IPb52cw8yFCKo5BWKWFQmLTMkb2z 6kAxTwXEg22Wd1VlQBQS9jZeK3y2cniD1tU49qP9ZTRlcDsDlYhzJ2Vmq0uihjb0Obpz9RWukBv +k/1jjZJWzzTk53R+NA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-12_03,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 phishscore=0 spamscore=0 malwarescore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608120107 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786541610537158500 "monitor/monitor.h" declares monitor_set_cur() which use the 'Coroutine' type, itself declared in "qemu/coroutine-core.h". Include the latter to avoid when refactoring unrelated headers: In file included from ../../target/sh4/monitor.c:26: qemu/include/monitor/monitor.h:32:26: error: unknown type name 'Coroutine' 32 | Monitor *monitor_set_cur(Coroutine *co, Monitor *mon); | ^ Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- include/monitor/monitor.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/monitor/monitor.h b/include/monitor/monitor.h index 890497b0d22..efdd2165aa9 100644 --- a/include/monitor/monitor.h +++ b/include/monitor/monitor.h @@ -4,6 +4,7 @@ #include "block/block.h" #include "qapi/qapi-types-misc.h" #include "qapi/qapi-emit-events.h" +#include "qemu/coroutine-core.h" #include "qemu/readline.h" #include "exec/hwaddr.h" #include "qom/object.h" --=20 2.53.0 From nobody Wed Aug 26 07:24:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786542103; cv=none; d=zohomail.com; s=zohoarc; b=Z3b1f/N4qXWJckltovJ/9mapBw/GLf9qJOfpT7QyjVHy2FBPm8hKjJLB1kQe4zCykTWUey9GkxPoSbY7JPAg7BcTWrnLQYRqZC+JKYLjhr8wADlUGCKOGOKlER9+DMZfiygWEPblOM1ABkxEMUdBRpzjC14MoGxMBOp63BmxR5I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786542103; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=H8bOmNlfoHQ6vnwoT3iYJ95B0zPjZH+NKe19ERFlx38=; b=XlHnlG/VITQMTeuCxc89A636k3CjSeqVbZSN7bnj4SsHJZKxCxAG7nNnotxrlSIy2Op8WJEhJGq0CGuSSN9L13/ETEu8SkKxOkbY12vLwRVFgbDRWDjV0ZjbVGoo1J9m00vrLQWGKvOzCIZXKTXhUs8qgja4w2JoTOwxUw3D3K8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786542103671480.5593791862633; Wed, 12 Aug 2026 06:41:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wu8pp-00089O-4D; Wed, 12 Aug 2026 09:17:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8lO-0003sN-RH for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:13:02 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8lN-0006cJ-1G for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:12:58 -0400 Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67CB4KJG2860166 for ; Wed, 12 Aug 2026 13:12:55 GMT Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g0mnd97bj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Aug 2026 13:12:55 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-52769fc3f2eso8005351cf.0 for ; Wed, 12 Aug 2026 06:12:55 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4997ad79e5csm38784225e9.3.2026.08.12.06.12.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 12 Aug 2026 06:12:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= H8bOmNlfoHQ6vnwoT3iYJ95B0zPjZH+NKe19ERFlx38=; b=J+NLMaFunxRNE5wY 46n/YRi07i62ZrtNiogcTZm5YRRzoRb1Bk2ijz4+1/Q5al+91e7q52kEFV65bP1C PZwCVkWmObc2UFxbRoMczl1DItrHF+gJWf4ESgJAVFzsLMO7RBQPIAQjafzxB5e+ lU6Beu0busUodXZtgiJHGgWZ5VQ9xKO+aDxfnkrUa1wycJR/QlCY9afBEkPmO7zY lauyc+4iTAFlfwu7W9D0iapj/QdApxCDc6AMKR5Bi/M8Md2mdHT0eOnX5Dv+m6Aq 3h0bXDhWrl5TITv4iNRDuTphw6FYNx6j0r1jgIKDcl2n0XchuPlo4m/KT6pkwx1t P4WFEQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786540374; x=1787145174; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=H8bOmNlfoHQ6vnwoT3iYJ95B0zPjZH+NKe19ERFlx38=; b=aUW+eW10hJn36D9D+l+DsdPpafCIqm2TrfE79K8bi0/LEaZR5R7yNqyJ2wwFQA4vZa 3IpKAN/K4iazVrhwxyA2zFs5WTvL6zN591mAv4pYv24EiQ7HVBzPf811wjbVHf2DyGfa yfOteZa2DdjsNsUuNxm/zAJW76W1g60IObMVfZsBkv5RT0wa0tdFiYMe1OWaUZx4BJ/t Ha0ECgtYhKl9zLD+fvcZqwWCZ8s3k8KY4CuN7YNGgUN7acJPDaJnA5zh5X9Hld3jEF0B OeKwzlzwm1mLULLo7LSBrPfLQI8JleTDNjMucC8fL587+FsZHrG/XQnY7qE7jXTd866Y bSng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786540374; x=1787145174; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=H8bOmNlfoHQ6vnwoT3iYJ95B0zPjZH+NKe19ERFlx38=; b=WPkYxc4fX70iBxMphmg1o5ovU6PJUV9QsU/tN2OUsCyW4D0ebkhrqr8Q0P8gwYs/Gr jNJ4Ia6tXBaoVlns3+YIqowkHdWBmlUwt5fA6h25YluPcDrr432dBRPFhI5WoDCnLG39 HSEFwGaEZvdpswrLuDtGGfMYCw5atUFxJDI0nbbO3ZRvccI0IYSWPUsc/PbD23eTqtkm Knij9NS5DbxjH5msrpPg8d0DKinE2C+QQkQrJOEe0cQuHaxAsECgY8FR4EC39nWyGzCm Ru8kk81BfaTYxI1d/Xx1IPaYTjNbKSjmCEnI6XIhrD4Z/JHlLPexjH0h9+eMrkL8QQDL woUA== X-Forwarded-Encrypted: i=1; AHgh+RpqqgZR2fDihuzYcdp1PETtivqYknIxy7B5XoLW99NDgwTNroOnIgQ602cTH92bpKLLXDgPtGo95cGi@nongnu.org X-Gm-Message-State: AOJu0YyfdzIrA2vLAE3+6TKW10EiA6xZnmY2G2q9Gz28zqDuDTHp1cno bcL6ulattohZYSxuGilD60akrpsqZaAN+xIHQXgevs2G080ZuE05CDmEVD8GyozlQD8SbM9t8d3 GpC2PGmYrQDiqrL8yIaBO4Whh7yaZaIo96lvk8EUldHumNBzXeHLwPRNL+g== X-Gm-Gg: AR+sD10zkxQ8Z3oIYQ+BWNc754k81DUUpoaVXEnxlqBfGiotLxvQ8a1ErAVDBZoytgZ KC74SEifMoibncomZQ73MWlyI3EMuPs2W6E5BW1UImLppp6XOrmCvWAm+93RghvyKmSQ77+JpQx I9kigm80ZB/2telUtGJ1VhNcXlzIRWwyyVGiYdJMZON4CkZ8FZiYwsql6Ug03P+OPIV+cdfD1nb POurylvKDp4yZDlzsXHPhgraJsQZ8hcjO11IyYBRWNtK2ixDV6EeQ3NoxqkMiCDR/AXvW5r6Kvf iRFA/rsKK5vswu/Djfb3iDSjcgzpAG2l0x3oATP54hGIBa3eI2Mb7OUqwngf5jR6Din70XbUGCA NYOSInrxHEYdNEPx5MsFfSOup1wK5DhcsqhMHsrmMaQ== X-Received: by 2002:a05:622a:1e0d:b0:529:e058:d185 with SMTP id d75a77b69052e-52d6486a608mr41100151cf.24.1786540374442; Wed, 12 Aug 2026 06:12:54 -0700 (PDT) X-Received: by 2002:a05:622a:1e0d:b0:529:e058:d185 with SMTP id d75a77b69052e-52d6486a608mr41099361cf.24.1786540374066; Wed, 12 Aug 2026 06:12:54 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , qemu-devel@nongnu.org Cc: Markus Armbruster , David Gibson , "Dr. David Alan Gilbert" , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 09/16] monitor: Reduce inclusion of 'qapi/qapi-emit-events.h' header Date: Wed, 12 Aug 2026 15:11:40 +0200 Message-ID: <20260812131147.83188-10-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260812131147.83188-1-philmd@oss.qualcomm.com> References: <20260812131147.83188-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfX7zFKARxjfMTE 6pz74uUFyoUwJresHe1vLqbJ58VlztOqavMPvgJrK30EeTL/9oQSJX+VNRp7y7FHl958bUDOozM omvzNSqMjijzzEF/3C1f652bGSpSXIY= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfXy5F2KhJrRta1 oVRTLYOUGHFdBNIQWiWhd1XWV8yLpEm2ZWIj58yDRWzo3NM6nQG3lMt/ThpMHVwHIRepkladaWU /62lTd1fSD1z6++8hBOOUUZjZ4Xj8+aqQGoP4VwrMZqefqx3Q3LZt3MYzHq7SoGvVCODay5IkLc bXDD+4lvkOTIbDIswaaGZxEBOOUC3Gkq7C/2x3VNN95/DeYbB/zSwxMs0RGsrzpHkBllkPcyn65 2nqpBB7EvkXfcwgRUgYL7RoYMwB+IRHfRY4oUV8SCYne+VXH67y8RnIKWQaeYV+FdOmFZpHPqgn 7jfnTAcMISAL5xx7CAovRza4eYmaQZ35zZiN5Z43spcRIkLHEuJ7UaDh+0BgDTCdcSMmQPDG9Z3 Dym9CZnVxkv6xxEGCkXleFEgS2kk0F5qGc1hmvJ05EzMxYpZXYRVzxEabyU4E4C6wqCTzBs+oOw 04OO67ewQjKlIl96ORQ== X-Proofpoint-GUID: ccRgh24-ao8qHh84g08QSRwIiDjKssQs X-Authority-Analysis: v=2.4 cv=C87ZDwP+ c=1 sm=1 tr=0 ts=6a7c7157 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=M5_NfMGrd9FO49X1DvkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-ORIG-GUID: ccRgh24-ao8qHh84g08QSRwIiDjKssQs X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-12_03,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608120107 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786542105764158500 "monitor/monitor.h" don't use anything declared in the generated "qapi/qapi-emit-events.h" header. However the "monitor/monitor-internal.h" do: 107 struct MonitorClass { ... 116 /* 117 * If non-NULL, the monitor is able to send event 118 * notifications back to the client 119 */ 120 void (*emit_event)(Monitor *mon, QAPIEvent event, QDict *qdict); ^^^^^^^^^ Move the header inclusion to "monitor/monitor-internal.h" to avoid including / re-exposing unnecessary declarations in the global "monitor/monitor.h" header. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- include/monitor/monitor.h | 1 - monitor/monitor-internal.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/include/monitor/monitor.h b/include/monitor/monitor.h index efdd2165aa9..fa9f4a8a75a 100644 --- a/include/monitor/monitor.h +++ b/include/monitor/monitor.h @@ -3,7 +3,6 @@ =20 #include "block/block.h" #include "qapi/qapi-types-misc.h" -#include "qapi/qapi-emit-events.h" #include "qemu/coroutine-core.h" #include "qemu/readline.h" #include "exec/hwaddr.h" diff --git a/monitor/monitor-internal.h b/monitor/monitor-internal.h index 23829f32f9a..bc0932c425a 100644 --- a/monitor/monitor-internal.h +++ b/monitor/monitor-internal.h @@ -27,6 +27,7 @@ =20 #include "chardev/char-fe.h" #include "monitor/monitor.h" +#include "qapi/qapi-emit-events.h" #include "qapi/qapi-types-control.h" #include "qapi/qapi-types-qom.h" #include "qapi/qmp-registry.h" --=20 2.53.0 From nobody Wed Aug 26 07:24:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786542164; cv=none; d=zohomail.com; s=zohoarc; b=SR3m7WktUqINL4T57D/+eb4+UwifheRO/3D5aafDQrJHDIAEb4BNsVzmuyL0Wi4MInsKLNrUA9KvASuQW76AWccOukel53LlM9JAMjGbM5EGc/6seQL71fP3BX9lSmCDhMZIOIVOO7dc0ZwjnQQa0nw4YErZHfeRV+5L8tDsGgc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786542164; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tSP3oFOhSSJwH2wpIPExnupwUl69LTj1EeNGfJfr8IU=; b=SA6Dh2K8GfJIx/FsZbrlIro7rKvjgAbaDjLnoLjlrLR7U8V7pa/uAlK3xJ2YUxIh7dn0TRDBIp+CbkfYBQSPZdSx6PtOjBFJDBINa4Zw3DRWoJMsnueY0SxvSnUrPd6c2r+xlmMJaYuXTZ0dQU2xwlvTxbt/IA3uoV7tPyYsZX4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17865421640331007.81676314786; Wed, 12 Aug 2026 06:42:44 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wu8op-0007CH-LT; Wed, 12 Aug 2026 09:16:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8lV-0003vQ-9j for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:13:06 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8lT-0006fM-Kn for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:13:04 -0400 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67CB4wdK3543539 for ; Wed, 12 Aug 2026 13:13:02 GMT Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g0hj1hymr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Aug 2026 13:13:02 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51bf321d786so15457061cf.1 for ; Wed, 12 Aug 2026 06:13:02 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4997c98d205sm40961565e9.10.2026.08.12.06.12.59 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 12 Aug 2026 06:13:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tSP3oFOhSSJwH2wpIPExnupwUl69LTj1EeNGfJfr8IU=; b=DZk9B13ddz3BWAl5 StOBz1GY+pJxsN6SBMVYQJc6jcteCwl9yIyluGusvKeQDCm37hZvYhncHC1NbZ/g dfPOn5TpJ4I90omxWJJdgSlefiCzTuCV0Wd1HZjBSH8TXxqAieNvHfFO5S4Oelvz EjUM8Lk6mCLEkGTL2yIbEuatGJbOJzjsz0D1hJHxpiMgaYED//A22tCVEJg1Me8n AlkSgM1geXGDbP0WTGPYEHTjPhVXiIAeE5yINUpEB3+0NbcTdbxNhR+9WvS7ZsVz 4ZLywHd7wuXbBiI1i1f2XzkwnsL5MW2wn0t2WTRXDYKH2TXicep9wXsgIhh8+FnX tiVkIw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786540381; x=1787145181; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=tSP3oFOhSSJwH2wpIPExnupwUl69LTj1EeNGfJfr8IU=; b=PDJk+PdM4xvATmO48DPWVFevP2W5KbeQOl1UhqiJBI70yphLFYdbOEFfbivbIZEYHK +AM8AwTpc3XuGQ/zYoSfqTBqgzw0PsnnoHY/QdCCUdQ0+0oAsfOboqEoAwCnKEjpizz0 bXRjMHesXMCFW4FBsEmMEsOItX6HjNmWAUung9Wtmeq3+Nwe2vOfZ6xELNQGNnewivFZ mz4auAGsDhHEilclBfPz9x/JMcnzz1p14gmglxwuhofw345ROgY7GUBOMzxGbMNSY5Hz 4UU0tBajPapWrdncy4udpJ88xwAvi/Uhy2kD/Yn8PR6TdDZm/wEtQwmMBVTBoqpkTV2e UDIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786540381; x=1787145181; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tSP3oFOhSSJwH2wpIPExnupwUl69LTj1EeNGfJfr8IU=; b=JkUleZpiFrHJs+ngjio8H0faSSMQAfY0DTGwaUowNyh/W8GivPW8wTTyobXgy9JpQP w/OgtK2eeIGL6xfsly3O4OQM7cvsvaa3PP8nScJu8QVqKHbRgsOpVdanYR5f30ZVeqYh SO0JjHoXvYJHVnzzsrvNSKpWO1KN81VN1qt86qEswEGLGOCy5ZMrl8N9UyVwSkeGPR34 XQ92iBncgHGGwFp0RezRUjXzBU/HE8KeA6sOfodLYcnS0Kyl2BmsjzVob79ya+aEqsxc kTL4sg0zHRp++uKVwEXKbCJIFIMt1HgQmbBF0FJZ1ClRSZEkLh226RN0Ab7nZzfLQ36+ C5sg== X-Forwarded-Encrypted: i=1; AHgh+RplneY2fygxcEfppHSVDGXLGOqOwf2N7iJKfAdkll5XUOSGKZVObWm3SLz01ivGu2SRZ75qcgBHc3km@nongnu.org X-Gm-Message-State: AOJu0Yzjs2Fj4LgcD0mfWBQfZ9MIq7VGoVFiS3gtJ7jJv2KqJcXCKcgT CwHAxsvGN9bNk32in68/rTcNKhX3a5xejc/gfGuu2X7d/fkglX2skECP+3oMz+vIxZNR/M5fLS9 QSXzfk9zBLj+tBCXq5b+woYAktbA8W3P4szuNiQWh9pVrIDfp0tgMAH+Sog== X-Gm-Gg: AR+sD11o3frKt56UeLJwfOoY5FSA0lw3vErT6L9E06FdqiiSc/aQYMyMuWkqOOlLgDG XPPLj03SuGThGiYtg3OmJQyNyoHX/fF8JhyExzLjqGFiPYPTtVGHx+TYeMjr53AkktsvmqGE6+s YROKWeBBRvO4oKFri4yQN5HgjILsfKfRF2MMiNb0JEDMJZ1tGWroWlRr9j5KQd41yQgK4Zq3Xs7 DKecGN+aExhO741P7aInxg5PjMe3cWMvL12RwdxUaw+hzirZZ922gVNRDIAPmYVO9W3DlRDEdj7 bXq8q3Si7wQFi9EG1BRCEaPtZ/sfa3LH2SqFykA9By1+Nb7v9/6e0tqx97o86J32/9pEFzuxW+a Eq++u4eCmJdDFNVYAv01DGoupbCrKTX41T+gLzFBFnw== X-Received: by 2002:a05:622a:950:20b0:52d:6c37:6853 with SMTP id d75a77b69052e-52d6c376b2emr8901511cf.16.1786540381504; Wed, 12 Aug 2026 06:13:01 -0700 (PDT) X-Received: by 2002:a05:622a:950:20b0:52d:6c37:6853 with SMTP id d75a77b69052e-52d6c376b2emr8901061cf.16.1786540381067; Wed, 12 Aug 2026 06:13:01 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , qemu-devel@nongnu.org Cc: Markus Armbruster , David Gibson , "Dr. David Alan Gilbert" , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 10/16] monitor: Remove unnecessary 'block/block.h' header Date: Wed, 12 Aug 2026 15:11:41 +0200 Message-ID: <20260812131147.83188-11-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260812131147.83188-1-philmd@oss.qualcomm.com> References: <20260812131147.83188-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: Q7so_dMUE9mpKiLRUvdXKNPchB8P2OCT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfX47Pr9RXZZ8UO 6Y8EaxVRzFAfUp7ZHV5VaxPOPdFzXS6oI0ONGW71fO+s9KmGCKpSOKaFrVcpLWxtFFg/T12tmVZ Tazxg0U6Mm2BOCB17dCPduvIk91TDsT9qeCo3z8G9PIxLr0s1+l4xsFdtlWt3LVCSmMOidUES2A UgR6KDUrljibW3czv22VTSTjr9TBSWjYVsq3GmFfFC+XRbCw4ykLccr0vJrxJlozWaeUUKdGwJi l7+yL6TmWr8w/1UTyTeOyL7XoBsx3lpQsnJxwRyWq4ujGHjbGDs/3sD6uqmsF6++Z3r7BACAds/ aLZ+cZRwYWA0veUHwnp38RQREfr/qvEDq/PahfkwWJ2kmu097HoQzAwxm3dIY6q2cgCI2W5PUB+ QjzQfB0zhCsv6MIA3V84yZW4Xv16YRGmvpsqgHH4WO1RFX3jfyVS25r+CGQM7ykhKlP2nLTNGa+ bLMOTmhgKduBF5zgQPA== X-Authority-Analysis: v=2.4 cv=K6ES2SWI c=1 sm=1 tr=0 ts=6a7c715e cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=neFa9O3qn1L-Jj73aAYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: Q7so_dMUE9mpKiLRUvdXKNPchB8P2OCT X-Proofpoint-Spam-Info: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfXyFEWhADFYdl1 BeemuAFE0SCG83HbhaYJX7whMC8sGFdggHw6cePInJFDw48dDvcVBh3KGNs9eUzn6sJfBuEAQ0N IMdZBQMXc9X6ddCssJ1rS3qoW25Feq4= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-12_03,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 adultscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608120107 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786542166039158500 Nothing here requires declarations from "block/block.h". Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/monitor/monitor.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/monitor/monitor.h b/include/monitor/monitor.h index fa9f4a8a75a..fd98ee2c71d 100644 --- a/include/monitor/monitor.h +++ b/include/monitor/monitor.h @@ -1,7 +1,6 @@ #ifndef MONITOR_H #define MONITOR_H =20 -#include "block/block.h" #include "qapi/qapi-types-misc.h" #include "qemu/coroutine-core.h" #include "qemu/readline.h" --=20 2.53.0 From nobody Wed Aug 26 07:24:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786541491; cv=none; d=zohomail.com; s=zohoarc; b=O9gTrn3RxaYZ2EQoUXoOH4HNq3i3X78IiJ0rIu9pWFYxIP2TeZwT3KrrCHSeZRDxg/Mt6Un5V8M5eTNdqILkccnL5ENLErb4bGvrslXugqc5dpNQAqBGOgmh6A8M0lylSnBBkVUUlnCWJREmA+tRz2lW1TMPgRzfwwGzg7Q/2Ug= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786541491; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=09Cz3K5Hfu2RAtmfX/9+Mk8nsbjxtr/nJzshMm746yo=; b=VIvqyACaKmz2l4XZ6erN5pg7TGSG/jJ+zJKLtUVzjWUjquIQXkw6Qu5JWNwAc9YOr36eAEvKBGuhFokeTUVhZT2XJ03xfLOcirqPktAVgjG6KavcH9SIhx8saFHYu51CNtOGWY6ReYeqV2vDQUzvMk4KwBT1TT8M9wcJv8HYq8Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786541491281640.1069723434521; Wed, 12 Aug 2026 06:31:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wu8os-0007Qo-Rx; Wed, 12 Aug 2026 09:16:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8lb-0003ww-Ky for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:13:17 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8la-0006ku-5X for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:13:11 -0400 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67CB4LEW3963393 for ; Wed, 12 Aug 2026 13:13:09 GMT Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g0nucgwrs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Aug 2026 13:13:09 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-92e5e38fbc5so81656185a.2 for ; Wed, 12 Aug 2026 06:13:09 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4997c9944ecsm49617005e9.14.2026.08.12.06.13.07 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 12 Aug 2026 06:13:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 09Cz3K5Hfu2RAtmfX/9+Mk8nsbjxtr/nJzshMm746yo=; b=Kq0/NGRebtY8ENTJ XkxahlkjeM027cNA5Ee28l+CiVwZ9jPDPkCt9jvLzBqdnSjIBImdZpjFSIeYoZaF HK8PCysUF9xSfJqzxthat2rC/UUVjrGjTdVJ5e9RDCh8tmDp9AaXgtROncrhNRGi h1rImnQe7S2SrvMysqkEWOqg7Dvr/bzjaGWjvHXq9J1Y4sG7d2htGJSq54BnVjd7 VNAGFDTmPN/BriKLlkSEHX2D7wx845loSnEBfWzlC7fgSd6otHP/SUFY3+uu8Q3k 38rF17Q7gj5Sph2s7Gs51mzShUGFE4ghBmWX1t/YnwTP+dcIvMyS86uSdXx+J+0v gPs9CQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786540388; x=1787145188; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=09Cz3K5Hfu2RAtmfX/9+Mk8nsbjxtr/nJzshMm746yo=; b=EXSbvG4plkjRfEzsNPAIwsQEUQmePMb5beCx7WeavNGCubr++9vKDod/B6sIYg2Yqi uIIM4SwmcwOT15fjDL4lGaamdJnfaeqaI14w83Z8F7/VuKc06R7FgKkE1FvIG5TpOHrs Y80mhOWu4pvCIhSD8jZ3apG4njEazQJdbWSu1oaVHfZm8k/238HoejeBwxII9wRFu7/M Q6gDS+cEWQmPc03UZxoFb+pWeEEfwPkm+Jz7T9iZ44BzERVLsfgt7mYVR3LpXJlHzXIo CLOIXzpah1NcS37CM6hdLzfno/nRO9Z7vc7xHROvU2AEsyrdxAIDKXt6C3s1SXUt52Gy 4kWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786540388; x=1787145188; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=09Cz3K5Hfu2RAtmfX/9+Mk8nsbjxtr/nJzshMm746yo=; b=bQO3kUg4lx1idTz0lhRHEANllXZwqwWtyZxXqS+H1lMEU1JLdJOB96OMSF6+5UpJ6M d0w9odU0N0nZi1HOq4oXo4T1R5/GH0cZ+qaS1Nf0dlc/FnJXZEM0o3XM3MF9TLu9UMJk 7SX2IdH5yf1eDdXcRHd6WvrLsWsV+N6CCCwkhXsvBkV7vkAP5cry7PsZ2TxO2RoJ5rF/ DwaBjx3aohGrchC2T273h9aOVyEKIF/2kM9eGTn93fXu+9PIESRM08jKAhZd/BBzpDfI 7xF6pG+6i2Wveym8/3EseGiXOX05ndsVoihgaj9lHy0XEZk33J3zrBpoO54HSMFqgOTQ bQ6w== X-Forwarded-Encrypted: i=1; AHgh+RrbESm/mQEUQ0bV5TsfomhSGqkGTu1KZLVDRFFRAiehmRwqRfeuoqOTCOz7KKGvAh45JeQcLIJ3jDgs@nongnu.org X-Gm-Message-State: AOJu0Yzf/30Mr3Iz3DoIPPWMO8k+zVe52P3Qgxowc9C6zkGse/qEIflm uv8hO03mAa+2yu1sCWA3t+XGhadjnTMoSklutFK8YGXhra2AR16PnpltA8GMy1vzdTYd0lP8YC4 0vPqYIxUy3iKNjs/4TcpnNp7tgeuyt3hN6+sgWX7TFDViVdzLKhjjYTCDNA== X-Gm-Gg: AR+sD11G1ZyMlyJwtbjJHf81Pzo1QnARc+9aznGe7y2KOdafb/rnT82tfcC4rqXggPI xuAaNO0Lb/RWTIPA4YwvTjhqOkH8lyurI7Tkvj5twMR1JabhC7vyNpwMQJH78IoQMN6A1zpv22w L2eGrxSpnsVNQQqMf0u007TVkgWpwthEMJIALe8bP8Yu/yboQbGN+Bkepl3XrIcRGYlaHycbV+H k6lhR05+Y42H12xLAs3AzG9g3Wdo7oSWt0QveCRbWwbyr0cfsHTSnn7pLP2FSTWo7EntMHTRPFb JVPkUWEvV9JFjf9GJvvb8rEzMERuXHNC6vKfoUAjKWIrfHnRKhr6YMTRpF6XwgviAME9q9xSP2q n54mh2hpw997vnH4aJb30Zb0TWBF3nJVDn+R21jStWA== X-Received: by 2002:a05:622a:58f:b0:527:631:8d6 with SMTP id d75a77b69052e-52d647d7a18mr37861871cf.25.1786540388473; Wed, 12 Aug 2026 06:13:08 -0700 (PDT) X-Received: by 2002:a05:622a:58f:b0:527:631:8d6 with SMTP id d75a77b69052e-52d647d7a18mr37861351cf.25.1786540388089; Wed, 12 Aug 2026 06:13:08 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , qemu-devel@nongnu.org Cc: Markus Armbruster , David Gibson , "Dr. David Alan Gilbert" , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 11/16] monitor/hmp: Remove unnecessary 'monitor/monitor.h' header Date: Wed, 12 Aug 2026 15:11:42 +0200 Message-ID: <20260812131147.83188-12-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260812131147.83188-1-philmd@oss.qualcomm.com> References: <20260812131147.83188-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: DoQiGmc3CoFd-C3XHkvlYPQqwIudZVvJ X-Proofpoint-ORIG-GUID: DoQiGmc3CoFd-C3XHkvlYPQqwIudZVvJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfX/53tsVc44PNs IUOfrzJnfGROetZIikzUI192Mw5NXHm1UBzPjMO9OnckBMbebGjnjP84huWOWk7cpUuVe7tT8V9 DsQaxIJ17O8e0TqcinUgVL6Dv0Q+F6pnCLbZgK7pdhi5VC5urynKaU4M5wQq3wtm5SMFzBNgymU W9+aVLukRMhgzhjEAtRJmOyJPnb8ThiZNZ1p/5sMPZXK1umXwfCkMw5hCjtJpll7FmUG5Lf89YU dVAX2C6I83juwwuTYRUaomSpLAmWwaEhUpUgQrhV7zFLXm42jsfWmnhVFGSdfvLA0Hr+MimneV3 FMl2tAx7EQYyvLs5a8AvdlqbngeOHSTCwPunx4s/YokpNXYiG3AaWJ87G2uo0l90xQE4aVdaRlg qP36Hm1H6zYOig9PCJ1VLXy5nMS3pmW3s7erWMq0oUzL8x4ZOOvSr39LuMqaiW+M59gY+b2My4U IUUXQ6ozC/CmWM/NO5w== X-Authority-Analysis: v=2.4 cv=VcjH+lp9 c=1 sm=1 tr=0 ts=6a7c7165 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=-VyI5JErSVUQEuwvVSgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfX169R2NwtJETe QBlbHyHdEVXDGDlbzEtyiEE2CvAZ0qQ66YRg7v/jwHFKk4UGEIFkwFj7H3k/bVl7SvR3FZo9XWt Y/crYIxqCnNOISOvMTY6S16E7BVnbmY= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-12_03,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 priorityscore=1501 phishscore=0 suspectscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608120107 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786541493869158500 Nothing here requires declarations from "monitor/monitor.h". Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/monitor/hmp.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/monitor/hmp.h b/include/monitor/hmp.h index 9258a049bff..9be7fe28988 100644 --- a/include/monitor/hmp.h +++ b/include/monitor/hmp.h @@ -16,7 +16,6 @@ =20 #include "qemu/readline.h" #include "qapi/qapi-types-common.h" -#include "monitor/monitor.h" =20 #define HMP_STUB(cmd) \ void hmp_##cmd(Monitor *mon, const QDict *qdict) \ --=20 2.53.0 From nobody Wed Aug 26 07:24:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786542079; cv=none; d=zohomail.com; s=zohoarc; b=GMoWmt8jpfYCuhcnTPrUxh87UP06f3WIVfhzpMt1vb9Bo8i9XTMXdDEK4kS7FIQLaH93LIjNKKnfAii8V8pneZL+C0qIOorIaag56gWZ5My24pU4+mITNzXkb+92t3dUCOHHfWZmLnGqkF7qLGU8iYqMujqvdlXpyKLXIpSuEZk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786542079; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=N5e4sGM+19Le7UZ5VaYP7mK0N0s/J9cqU0ktXhLcyIg=; b=AS4QVzOCvSHUHsC+kItkXyyGhqkcvX6yevpjaIXy1ykNBje9TvJDE6ehkOus4I0kuGU/mmM1OE6FleurzTkbPGVLew4goratFv63MeMejYgh+cEsZrbf6SQ03xSt94iuWumkEjnovHvVIk/A6mhv403IU93us3m+pxpInD9dsyk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786542079260622.5177848200414; Wed, 12 Aug 2026 06:41:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wu8o6-0005o0-IH; Wed, 12 Aug 2026 09:15:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8lj-0003yq-Im for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:13:21 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8lh-0006nj-9r for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:13:18 -0400 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67CB4ZfY3637957 for ; Wed, 12 Aug 2026 13:13:16 GMT Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g0jgrhrvq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Aug 2026 13:13:16 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-52cd0374265so18527201cf.1 for ; Wed, 12 Aug 2026 06:13:16 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4997c98d205sm40973345e9.10.2026.08.12.06.13.14 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 12 Aug 2026 06:13:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= N5e4sGM+19Le7UZ5VaYP7mK0N0s/J9cqU0ktXhLcyIg=; b=lFObz5xEjsuqEQLO 4nwn8r87b9YbVpHOcJUw7/QOEQZ4mgvunrWPsXdM3i8uwAKjxS5mIkDHjbn6R3Fx P33u2lENxX17fnYGLHt/4Kdxw1/SpHIAXv4Xcg9elWtkDG4R2LpmmTKwy4+3fbdc 1AkwD5H3n018pdalzQQ6QgdF5EBekEbw/49+8gu6bhf545akykOZE3i5e1OO1Sal ECT8vPKdyqqq0f0QKcPG4EzdrHCbvdgUndjCSfYg6gyKEhhwabWO0L9+nKawqpG4 gXcallnhuu9yWV3hqBmiu417Smvvha2XXdl0do4fpWMLXMgGFrEBA25JeYb+4ggo zJE3SQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786540396; x=1787145196; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=N5e4sGM+19Le7UZ5VaYP7mK0N0s/J9cqU0ktXhLcyIg=; b=gD0QsUty9H60f9kawzT34PtCpTN58NiAApNy29k1yq/x9mY4iX1uk39tj1ynepLKJU E7t9771rd/45d/E6oWfZzc6+Vmlba5HDxZlS9yk4C4Y/IUySnO63f5JF6/2LGPHQgikZ LnaLhi2IWwwedyFHpB71zWSIt3Fqqr8unroP+RThwFdJBbLJj+y/FerOnfhOoaQOZOxv f6kFIis6N+0sQTMgYAXqN1vO1IhgSBhgbUbNmIsst8oscwqi+tCgZkHv7GLbibPc+Jfs 2gALicf4pEosSPTBfkGg7b/f6NsVLruqhA55vu0p5tWw7lOd2TqqytsFM5kq4gz7ZT// ndtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786540396; x=1787145196; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=N5e4sGM+19Le7UZ5VaYP7mK0N0s/J9cqU0ktXhLcyIg=; b=aKRghZ66ao+SoAPlni0uiZYUNNWL0tF5UCrGP9C3yOaGYrt5kGwk7RZluoVta/uvBn iYlFtbHQBOnvreOcbVuRv2wiZq/g2lJ9Jfo/pSfm/t5toQO3+dfq0HdiZrY3zNX1dUhA bAjN8t8sKx8rd7Kx0hfPmIHWBuM9USUAQWyWr9FOVZ/4uwqlqnUoPzcoblg4zsBdljAN /gS5D33nyRgeTh0nOg16s0RD7r9hUK16Gm1VoNNXZL14PxhD5Q8wE98l2+9VmPhyxfaR 7QBFMfzk3CB5JFDpNUrFGhknlqjXzONs52Hy+RPFUgnzvmVvL/+Xavgzu9bjoKudP1Ta FFuA== X-Forwarded-Encrypted: i=1; AHgh+Rq1cBWfEtpNzcHDn0lFzvF1AXOTFYn7XIdw2YrwgaTw9N+FY8o0vHwTe77LFgy1SOqAa480KgoJneWK@nongnu.org X-Gm-Message-State: AOJu0Yzll/1ScFa3dydjQrMAV+IQJDrE7i1PN+wASCJZta2DrUV3A3wV pyvhIWbXHIisMq3P3gxneOpX+3pv/yMIrMb7NldFwlft7IfPMNwxbvV8Y3OINHD4uvws2fxcXDR fBaCpeKPODSdKJkeET7JevdWxpy98mfxc3LiS+nDEp6i7E5TSl9/QaNI8nQ== X-Gm-Gg: AR+sD13y8IogkldsJ4/1l7lJV2jOn66mleolxcITpg7eIdL4zB4YyvG3DBeDY7nZDVq 6bJl93YbyB2N6XpvxBwmIdsUOr+NmU8WllAUYgev8Vip6oJplnqwhFYRdAzDP25Zb5Cq5CJZ2uA fbtfM2F69euqfuolj46tst2uhREoujESzvugFoyp2XOw/rX0l53qBYEUMswMcVrft7ia4wh8M4q gRmMXH2D4+UEggsXlcrc75hFnLO6TLbD/Zutbn/QTzJ5dy/H3RW69+/MygsASUog9JCHHozK4Qb oBbDzPtEDXE+kkBGYecL4Yj1yFhRamuZ6gRXV3Rjl7xUIQ+SLF5jD08JwOfakpiyqs3nH1KStv6 0FkWkgowyopeE2B4hJh6miPjHrJi1AVCK5YCOw9ZtMA== X-Received: by 2002:ac8:5fc6:0:b0:52d:2b8b:a138 with SMTP id d75a77b69052e-52d647ec53cmr36346861cf.26.1786540395821; Wed, 12 Aug 2026 06:13:15 -0700 (PDT) X-Received: by 2002:ac8:5fc6:0:b0:52d:2b8b:a138 with SMTP id d75a77b69052e-52d647ec53cmr36346191cf.26.1786540395315; Wed, 12 Aug 2026 06:13:15 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , qemu-devel@nongnu.org Cc: Markus Armbruster , David Gibson , "Dr. David Alan Gilbert" , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis , Paolo Bonzini , Peter Xu , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 12/16] system: Remove unnecessary 'monitor/monitor.h' header Date: Wed, 12 Aug 2026 15:11:43 +0200 Message-ID: <20260812131147.83188-13-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260812131147.83188-1-philmd@oss.qualcomm.com> References: <20260812131147.83188-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfXxgJTGLjwse9D lpyMBz3HA/jczyWhx3t9kx4aMSYd5cQ30bBph9k9VuYF/xJnWOIJ5uwsTtTm6La2D99XRpfT6Q/ YCW3tzw+HVW/iwaTaSPeRUw8r683JgElkUURmxV7Bg3N9G1bdMDBVcT33Gu0BRWHNytJhLX8Uhu HEKpW4DVFEKBefeKeo30QQK89PathX4TRm96tU+tzKXR1ikzUs/b4NWnt/k7eROAAAxorKXNXmN D1g8JmR//QLB4bzLMInAq9T9bRT4ooJojblBEbc+HnqECFsj8z9A3oj5esUXnZetpwsbLvcffAH Pt1eOMQbicE2DMQuj99zr1JrzQFxrF2ulYyxbQuanzfhUzYBkp8h1xyEhJEjXpkc6XRAJHl4U3g bbZu+a7KmIdE4RpDiwHxkWrVVuTNupKoXXzm3L67fKKE/0jwVkScufeI6ZOuOyPcQ7E2LYjZXRm d/IWfWlspM5BWHVgqZQ== X-Proofpoint-ORIG-GUID: H163EutTAM6NAe1boxozKpBiiC6Nf8oF X-Authority-Analysis: v=2.4 cv=TNJ1jVla c=1 sm=1 tr=0 ts=6a7c716c cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=4VRd78mhg-xsesdjslEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: H163EutTAM6NAe1boxozKpBiiC6Nf8oF X-Proofpoint-Spam-Info: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfX8BFaJI6Ybuk0 psoNcMWCAEmnVhoIa1ZXIRKC1dONLftriMC5O1kqDkW0UPluY3yF8VjjSr8cAgfzJwNiKPG4vi8 BieZXGgW5zYJHXoq6+g551M6Cfuf1ZE= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-12_03,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 phishscore=0 impostorscore=0 adultscore=0 suspectscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608120107 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786542081735158500 No code in device_tree.c or physmem.c require declarations from "monitor/monitor.h". Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- system/device_tree.c | 1 - system/physmem.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/system/device_tree.c b/system/device_tree.c index 1ea19629841..48365435ea0 100644 --- a/system/device_tree.c +++ b/system/device_tree.c @@ -29,7 +29,6 @@ #include "qemu/config-file.h" #include "qapi/qapi-commands-machine.h" #include "qobject/qdict.h" -#include "monitor/hmp.h" =20 #include =20 diff --git a/system/physmem.c b/system/physmem.c index c21ea929153..21614e1c4d0 100644 --- a/system/physmem.c +++ b/system/physmem.c @@ -84,8 +84,6 @@ #include "qemu/mmap-alloc.h" #endif =20 -#include "monitor/monitor.h" - #ifdef CONFIG_LIBDAXCTL #include #endif --=20 2.53.0 From nobody Wed Aug 26 07:24:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786541829; cv=none; d=zohomail.com; s=zohoarc; b=iF5wg2d6xRfnw+ZTcoXWZBdFePu+zU6RYEVFbVCNk5bpBHQg1lK/cH3K0T0iNLgOoIbaozxNZxXm1c0211jaX3bskIqLX0wobv8UqmzibRSZMh4BeezcgyLaXPkMcVozMByJ6iWprZNgFmtyOKzMgeKecpKuI7t+9ELz3l+tXkU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786541829; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=iTsdtC7baAuSEzhZYry+TRKvtm+XXIUHPe/4MsSmoVU=; b=kNZivuTfmvPPi47Mt/9xRQyBG4vi2stOFlQp4Dz1W2QgTnLk2yBZ8X2JkU0vh8yuIyBBauepXIvcnypGxvWOlzVKTDql9AVozfi1p2y0DqO1CY8QZPcLapAkRzXMVrrZxJVaYe8bOx1xKm/UvGQ+9+4v9kCoyDc/NXfOVEtptM0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786541829524969.6289982741595; Wed, 12 Aug 2026 06:37:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wu8qE-0000Sh-HC; Wed, 12 Aug 2026 09:18:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8ls-00041W-N7 for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:13:31 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8lq-0006pk-Gy for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:13:28 -0400 Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67CB4B623265902 for ; Wed, 12 Aug 2026 13:13:24 GMT Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g08jrkxxs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Aug 2026 13:13:24 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-5283fa0656dso26673091cf.1 for ; Wed, 12 Aug 2026 06:13:24 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48150d4e29bsm7059485f8f.24.2026.08.12.06.13.21 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 12 Aug 2026 06:13:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= iTsdtC7baAuSEzhZYry+TRKvtm+XXIUHPe/4MsSmoVU=; b=dsqFDOpRaAVnI0iE Pk/0nBiR6q+srCzy7mfuhOdemj0GGOaJXPwkF0kJv0LbFL6KEFTsNJw92vDG5z30 CvIZmlAvBxB0QfiCy52HdAmo01mEVNJHgoNoZyd+5Phtk4n8fx/H+63z/3cxj60v GgVDL+b2u/wUrgSMQ2DHngZLGvQbXRdqD8EStWAWsjySALXlheMvGbuHZh92jPIY t3WQ8qZFWWwUid2iJTvuWgKCKFgnENxC6Njx/2oAFIqWJyzH+9eK5Rg5uFXA8y3r he1QkjfDtnK2j/cY39Ki2K+a/BW2tfRcFOlRhtGqPjc9qtRt4445bAZwg5pLp7Q5 NSaP4w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786540403; x=1787145203; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=iTsdtC7baAuSEzhZYry+TRKvtm+XXIUHPe/4MsSmoVU=; b=EizAhptWV9oO5rLbhdFOhHy87dI0kaJ7NFeMTBa3XGSPcrYccFLajzsbwLD1Ky70ef nvdFrduo3gxO4AsFhFOi3U8GmMR651wIZwnKNUuDh8RGxyUqWIqE8PkmcpwB2QnyjVja 4vsatMo0CwKwVFx86MIZjlUe+m7cl5TwPoZdFdkwsOrLqKuXxffQM+N9S6342AZ4XZPG MPaJcljpjGpsiYyGRYbWVjLC1alBFki3vXm151rirC0kckTuvbjRfPcAMng89F/6ppo9 wY+5eQfXE9yn2wP/r6c7EKYGqkHj87+YcfVJiohZZuiVYGoF+RpQvxkA9KwN4qAejtEl Gdyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786540403; x=1787145203; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=iTsdtC7baAuSEzhZYry+TRKvtm+XXIUHPe/4MsSmoVU=; b=X50DZe7C28398Woy9JoHuv1tdYhwZlf9xWu7Q2/700LL5bzlWKfkhOcvKZbQI4zc3n SXqPCg0Df0nt6HP5h/H5eRUg/gPowL5uhFN7MbSjx0MlkKNcpf4XgRHMELrdQwJpptLb AXihfqCoLLGIvqBmThAMxD5SBKJFm9AxH/3CXUFTj6aVhcUK5APx9mrLkYRT62BZQzoT LB1NzYcjwsSnQvYGAz8iwZHb0KWx2KCCAmMgR82Ejw0bBo7C8jO847PhSvJXW8e/6nkh G1XSsFojhIHp1Th1QujhF7QfZLoZ+2QzE29bP0+AIQnvdTttl+RJJzu1fBjGYnHQWuIC SudQ== X-Forwarded-Encrypted: i=1; AHgh+Rr0tbk41vn4pag6H5Jz1UTvUgXjoNqg4S7ttyReB4KquwwKnMzujxhrIAMv3gB2wHm/PVfF3VtAUsaP@nongnu.org X-Gm-Message-State: AOJu0YzXTSpx1wI4kJ74AUUbv1VVqfiNgJJLByOpr8etBDKAZBfTrLep TX3b0AsfVl8cCuYaiC27BYRCdfuqO5ZsHr+4WQqOEMtaB2ffeldejpsI59gOOiBQ2Rnp85AsVDg Nv9ZSmaKE+ivfLyY2CxP4EJLv2ZahgENox7K4lQjIeZfXXBIjD3iEHr7B2Q== X-Gm-Gg: AR+sD10ToIPVFZTr38ZJagHyOJ5UGE2paEvtsvF65Uux58FxjY0AUC1deOr3IhbnIa6 R1ppPmtkD5Ap3AnN47MWICUGCbOzkFCqp9I4uCDuQsMgJUi6tNPiVNh5hE7MF2whDzNklA1NOkZ r2DHBSz5HKNe7m4YuCs/pSAGSRAQiw75xmWs4VgOtjP5gUUhAhiENQAEh8JfnDfgXWEGL+jRA36 ZHz01yl+DkeoL3z7cUuyPceVZNugtFAOsPnEslHBfodLTm8m3m3gpj7+nN3jZMj/iYsIa63dCrH K0T8ayDvsuIJRmz++Iy17avjDM/Rdb6P8eRhCyx9REBIp6WTN1gQJtxw3o8zXdtZNu+UHFyCtXT 1/jW1Ocgp24ywp86VzJjzqJeszKlRhP6ACPPK1P+kZg== X-Received: by 2002:a05:622a:48a:b0:51c:1f35:4638 with SMTP id d75a77b69052e-52d60365125mr67842591cf.21.1786540403092; Wed, 12 Aug 2026 06:13:23 -0700 (PDT) X-Received: by 2002:a05:622a:48a:b0:51c:1f35:4638 with SMTP id d75a77b69052e-52d60365125mr67842081cf.21.1786540402670; Wed, 12 Aug 2026 06:13:22 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , qemu-devel@nongnu.org Cc: Markus Armbruster , David Gibson , "Dr. David Alan Gilbert" , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Hyman Huang Subject: [PATCH v2 13/16] system/dirtylimit: Extract HMP code to dirtylimit-hmp-cmds.c Date: Wed, 12 Aug 2026 15:11:44 +0200 Message-ID: <20260812131147.83188-14-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260812131147.83188-1-philmd@oss.qualcomm.com> References: <20260812131147.83188-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: gDDD-drcFKNNejXQyFpHzNYLR9HRFpQ4 X-Proofpoint-Spam-Info: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfXxhw7Ej8wodOZ OKyFXupGAAzajhvIgM1kffHZmEh5aeHZYsIChM7xCRE7iLReWF1BmFwpTZp2L+6QJvFqt4NB4XW FyCnf5lVO+2vYA9FvbyccqAhIcBQN/Q= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfX4EvQNgztTGrh HdnMemzHdxofeLLttZgo/SlueV/U+sUnQD2ZOUym67YB2muSN7tJeRT4ZJfruCyOHDrT+4VoPfx L9WUJp8iGxt/zyRigosga92wXNEpJ2t/YEIta5oAXu1LICg0lXBw0D6Oi4GOo1glE2+7QlRz5Jo rao0xiMOPWMxwRqyT47Fgj3QyGB8+yQoJ3a2SaUS08oI5d3wAncaebxCRH3VxgJ0lD28+6M6gTF TaiGMKsBYrhSxniAe/hgss/nStSdlwP0d+WFn0UPBEEuFuKakSMeJOEZXuzin/GTaOMLr3fu2Bm ozuz+0U8p7F0uVIMw1YY4O4P3jF8DPmuNfVeMYf4JEknnJSmO1alEy+5aCX/OWJ86X9jC4Q2ZVA pXeWOcPHRywumtSY6omOrgitFIhGhBVu4lRL4WmdyqbP7gTn2d8UT+DwKcrId0xQDWKe+d/RPfn zaOeRb8WR6YY6pN8vYA== X-Authority-Analysis: v=2.4 cv=Z7Dc2nRA c=1 sm=1 tr=0 ts=6a7c7174 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=O7a0paeZM6m8OBaPhdkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-ORIG-GUID: gDDD-drcFKNNejXQyFpHzNYLR9HRFpQ4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-12_03,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 impostorscore=0 spamscore=0 priorityscore=1501 bulkscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608120107 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786541830359158500 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- system/dirtylimit-hmp-cmds.c | 74 ++++++++++++++++++++++++++++++++++++ system/dirtylimit.c | 60 ----------------------------- system/meson.build | 1 + 3 files changed, 75 insertions(+), 60 deletions(-) create mode 100644 system/dirtylimit-hmp-cmds.c diff --git a/system/dirtylimit-hmp-cmds.c b/system/dirtylimit-hmp-cmds.c new file mode 100644 index 00000000000..4928d57cc8e --- /dev/null +++ b/system/dirtylimit-hmp-cmds.c @@ -0,0 +1,74 @@ +/* + * HMP commands related to migration dirty page rate limit + * + * Copyright (c) 2022 CHINA TELECOM CO.,LTD. + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include "qemu/osdep.h" +#include "qapi/error.h" +#include "qapi/qapi-commands-migration.h" +#include "qobject/qdict.h" +#include "monitor/hmp.h" +#include "monitor/monitor.h" +#include "system/dirtylimit.h" + +void hmp_cancel_vcpu_dirty_limit(Monitor *mon, const QDict *qdict) +{ + int64_t cpu_index =3D qdict_get_try_int(qdict, "cpu_index", -1); + Error *err =3D NULL; + + qmp_cancel_vcpu_dirty_limit(!!(cpu_index !=3D -1), cpu_index, &err); + if (err) { + hmp_handle_error(mon, err); + return; + } + + monitor_printf(mon, "[Please use 'info vcpu_dirty_limit' to query " + "dirty limit for virtual CPU]\n"); +} + +void hmp_set_vcpu_dirty_limit(Monitor *mon, const QDict *qdict) +{ + int64_t dirty_rate =3D qdict_get_int(qdict, "dirty_rate"); + int64_t cpu_index =3D qdict_get_try_int(qdict, "cpu_index", -1); + Error *err =3D NULL; + + if (dirty_rate < 0) { + error_setg(&err, "invalid dirty page limit %" PRId64, dirty_rate); + goto out; + } + + qmp_set_vcpu_dirty_limit(!!(cpu_index !=3D -1), cpu_index, dirty_rate,= &err); + +out: + hmp_handle_error(mon, err); +} + +void hmp_info_vcpu_dirty_limit(Monitor *mon, const QDict *qdict) +{ + DirtyLimitInfoList *info; + g_autoptr(DirtyLimitInfoList) head =3D NULL; + Error *err =3D NULL; + + if (!dirtylimit_in_service()) { + monitor_printf(mon, "Dirty page limit not enabled!\n"); + return; + } + + head =3D qmp_query_vcpu_dirty_limit(&err); + if (err) { + hmp_handle_error(mon, err); + return; + } + + for (info =3D head; info !=3D NULL; info =3D info->next) { + monitor_printf(mon, "vcpu[%"PRIi64"], limit rate %"PRIi64 " (MB/s)= ," + " current rate %"PRIi64 " (MB/s)\n", + info->value->cpu_index, + info->value->limit_rate, + info->value->current_rate); + } +} diff --git a/system/dirtylimit.c b/system/dirtylimit.c index 50fa67f3d6a..70bb7bac2d0 100644 --- a/system/dirtylimit.c +++ b/system/dirtylimit.c @@ -17,8 +17,6 @@ #include "qapi/error.h" #include "system/dirtyrate.h" #include "system/dirtylimit.h" -#include "monitor/hmp.h" -#include "monitor/monitor.h" #include "system/memory.h" #include "exec/target_page.h" #include "hw/core/boards.h" @@ -491,21 +489,6 @@ void qmp_cancel_vcpu_dirty_limit(bool has_cpu_index, dirtylimit_state_unlock(); } =20 -void hmp_cancel_vcpu_dirty_limit(Monitor *mon, const QDict *qdict) -{ - int64_t cpu_index =3D qdict_get_try_int(qdict, "cpu_index", -1); - Error *err =3D NULL; - - qmp_cancel_vcpu_dirty_limit(!!(cpu_index !=3D -1), cpu_index, &err); - if (err) { - hmp_handle_error(mon, err); - return; - } - - monitor_printf(mon, "[Please use 'info vcpu_dirty_limit' to query " - "dirty limit for virtual CPU]\n"); -} - void qmp_set_vcpu_dirty_limit(bool has_cpu_index, int64_t cpu_index, uint64_t dirty_rate, @@ -548,23 +531,6 @@ void qmp_set_vcpu_dirty_limit(bool has_cpu_index, dirtylimit_state_unlock(); } =20 -void hmp_set_vcpu_dirty_limit(Monitor *mon, const QDict *qdict) -{ - int64_t dirty_rate =3D qdict_get_int(qdict, "dirty_rate"); - int64_t cpu_index =3D qdict_get_try_int(qdict, "cpu_index", -1); - Error *err =3D NULL; - - if (dirty_rate < 0) { - error_setg(&err, "invalid dirty page limit %" PRId64, dirty_rate); - goto out; - } - - qmp_set_vcpu_dirty_limit(!!(cpu_index !=3D -1), cpu_index, dirty_rate,= &err); - -out: - hmp_handle_error(mon, err); -} - /* Return the max throttle time of each virtual CPU */ uint64_t dirtylimit_throttle_time_per_round(void) { @@ -646,29 +612,3 @@ struct DirtyLimitInfoList *qmp_query_vcpu_dirty_limit(= Error **errp) { return dirtylimit_query_all(); } - -void hmp_info_vcpu_dirty_limit(Monitor *mon, const QDict *qdict) -{ - DirtyLimitInfoList *info; - g_autoptr(DirtyLimitInfoList) head =3D NULL; - Error *err =3D NULL; - - if (!dirtylimit_in_service()) { - monitor_printf(mon, "Dirty page limit not enabled!\n"); - return; - } - - head =3D qmp_query_vcpu_dirty_limit(&err); - if (err) { - hmp_handle_error(mon, err); - return; - } - - for (info =3D head; info !=3D NULL; info =3D info->next) { - monitor_printf(mon, "vcpu[%"PRIi64"], limit rate %"PRIi64 " (MB/s)= ," - " current rate %"PRIi64 " (MB/s)\n", - info->value->cpu_index, - info->value->limit_rate, - info->value->current_rate); - } -} diff --git a/system/meson.build b/system/meson.build index cd3193d170b..377adce8035 100644 --- a/system/meson.build +++ b/system/meson.build @@ -9,6 +9,7 @@ system_ss.add(files( 'cpus.c', 'cpu-timers.c', 'dirtylimit.c', + 'dirtylimit-hmp-cmds.c', 'dma-helpers.c', 'exit-with-parent.c', 'globals.c', --=20 2.53.0 From nobody Wed Aug 26 07:24:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786542198; cv=none; d=zohomail.com; s=zohoarc; b=NFm47IJW2G+OWs3jSfN1om40qQ+xkYS2S7M9Nj7NZEnYn6E1vTZ/M1gNHbmy34oJ5v5ZsAh8Y0QnxmmwcPwJzyodA0KED0yhB4UYE+ta/ECNhC7hT5n2x22Sj2QTaV4+8QcIRIBRMbRhimZgRMnicFXGu8/34Iw6ysuB1sg12ks= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786542198; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xQgaB14R7ESk7abgkLPNHUg9U3cWnv504LpqQp2HHEA=; b=n51ILU+Cv/ag1s/OeZDQroOqmc/tOOPDNBSpb8LVsPYrj8dD58iUONx01SbOq5FRGYw1imjUBaQkWp4OMFAa9DcOjSW2pJf2OFvIKs6CoQPySqa1YewL4mFWbGr9vd+1czkdne+tF5sVQgee+qqBKho4yF0kn8tu8HGRkZZe9Zw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786542198179283.68178881694564; Wed, 12 Aug 2026 06:43:18 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wu8op-0007Ca-Me; Wed, 12 Aug 2026 09:16:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8ly-00042s-3V for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:13:35 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8lw-0006rA-F7 for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:13:33 -0400 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67CB4a9j3311438 for ; Wed, 12 Aug 2026 13:13:31 GMT Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g0p3d0uc5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Aug 2026 13:13:31 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-5283fa0656dso26674421cf.1 for ; Wed, 12 Aug 2026 06:13:30 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48150d709dfsm7273883f8f.35.2026.08.12.06.13.28 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 12 Aug 2026 06:13:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xQgaB14R7ESk7abgkLPNHUg9U3cWnv504LpqQp2HHEA=; b=O2gJemLO2LnoG1oa 2a5KLhOxRY5gRTatpBUOLDL33dI0JR8zXE392hFzGeJW9ylNBkAVUSmdkkgRUnMr XZ7TSenOT4bxgzrZijP8VmxLjlhziyGXGK9lDjvowPAvhtslwvWWHsTOudBs3Z7i CEOLLz0hGAykwnY0FUfSzMTSmbEnZBfbKTEibaq9ERsPveodL0Ryj6ehD6Wsl7lc hjD6AqyxPUsNMNuBYF8fM8bT+W2u/wQX759IxHPadBOGehiAm0oCVYgNqkWrr7cK Ys7tUMtmGJQwdSNgUCcCI7jesCGAx2IsvryteNOFdtrw4q+zyswjiO6VBVEqxWbB 0Kl3xQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786540410; x=1787145210; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=xQgaB14R7ESk7abgkLPNHUg9U3cWnv504LpqQp2HHEA=; b=EzfStdESs4CgQAJNuoCTGmu6ne+ZfsVTPuRem7sdhBPL8JDkqi3cYsQg88Z7+L2Wr4 XvoSSh3se6qMmZFd+evHr2I988u+uv2wgN5a5lavcKuxPgPhd7DDw2gEWrBNQH4n/nIv MGZ14PljC4ee4mdDaiMzZsDN2qRqSQMAXdIOmrI35sUeaLEw4xPMcqaV1H+Wf7FWehY2 JehaBgmLqV1JfvhSCSleHiQdp6Iy1kivjwvYN4Q6PsjIMViJQKln/r2LoQFwkX8nN1ka Eg+PfCXi1bfAyA35msjee2uDaUVXCrD1buRXWWj+1+E9yVQ1ckX1zLwqQb+pJnXYGOEk vAig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786540410; x=1787145210; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=xQgaB14R7ESk7abgkLPNHUg9U3cWnv504LpqQp2HHEA=; b=B3ORAH+4/1FYM29QMJcuQ3hoDFbrox7RGg6ZvJkm7mFukK9AgAcdhHgbTGXmhdy0MX qEing+whSClmjWusnNwCcafVYTs03TA21FJmIH2hU5qhnSIEU9/itBal7WbOYAe5QeIE AYy15CWq6T9abEVoSJh1fjlAz6Hjzhj9ELb0W1yryjHswyHCtHcmoRJBSE07wL7qpLki h7NmQgbguaad7ZdJx0awWAItWqYbfijNWPH+L1PsUCENmW6DXdXLzwjGS0nuYnqskG9s 0dgbKNKondSyKcI8Iu00bZUJ2qi073RbjyCw3KCvdYx6jQ+p93JW1zWwBNrwMgEH5fnI mSTw== X-Forwarded-Encrypted: i=1; AHgh+Ro9Ju8TgOycIr4Iu2MioEm4RjNP2c5PNijcp8ThyHDmsnq+DRQDEwrhea1AEdzy+pqZQ/WvQGEPx1rk@nongnu.org X-Gm-Message-State: AOJu0YxiDZ7GkvgPI3pB/31ariZjOmv1xPL7gepT9X7zo4JBvpc7FaRd blb4xlhiEr5DZGcGL/MQg1M02kGc3SyVmPN28A/fJxcaIWmhK0OCwnQBf54dgZr3OGPo+YAIG87 LOnplEH/Ee0ixQ79U0ogd7GmitRzNjxhJcvCxUl1/aXKV48LaDu64j+5huQ== X-Gm-Gg: AR+sD13wzQxiDEs+2sKnqaIJN/0tqmqN8xzcnIOASUwQ/hsYJSQJa8s7KqhNUgRBrSZ lpa2wigUIQmk4suQy0VjAGO8rL4T5lZLgRzJa3c+kmdNO8N8DlEMs8WKwo05PQuANGs5VM0es0L W0Aow7bPaWqqqgJP96IQwIHtjYVKDC13lhm7D6ztIiq0xv4WUn6Ela6dHTGWJu+5wLMFrq4/0nY wpmgUXmWd32yc50G0erM1inQgM6b25N69UhZFd2ba89fHKsnia0RzZGGN+pklldzjTYHU+9HK8a X/elecl1FmQVgM4Oeax0KZy6UtgIQKRxudL/Fxg+TlHAABe86/6g7edheFye8onI9m1PiRdX7ci G4E93MV+GZfBqo5eOcZPm87yBUlCgTUyH3vjrV4HNJg== X-Received: by 2002:a05:622a:48a:b0:51c:1f35:4638 with SMTP id d75a77b69052e-52d60365125mr67853741cf.21.1786540410361; Wed, 12 Aug 2026 06:13:30 -0700 (PDT) X-Received: by 2002:a05:622a:48a:b0:51c:1f35:4638 with SMTP id d75a77b69052e-52d60365125mr67853141cf.21.1786540409830; Wed, 12 Aug 2026 06:13:29 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , qemu-devel@nongnu.org Cc: Markus Armbruster , David Gibson , "Dr. David Alan Gilbert" , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Zhao Liu , Paolo Bonzini Subject: [PATCH v2 14/16] system: Move qmp_inject_nmi() to hw/core/machine-qmp-cmds.c Date: Wed, 12 Aug 2026 15:11:45 +0200 Message-ID: <20260812131147.83188-15-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260812131147.83188-1-philmd@oss.qualcomm.com> References: <20260812131147.83188-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: WGbJnEL3MGLYEXWk5IgRoULTqaYIRMQI X-Proofpoint-GUID: WGbJnEL3MGLYEXWk5IgRoULTqaYIRMQI X-Authority-Analysis: v=2.4 cv=UfNhjqSN c=1 sm=1 tr=0 ts=6a7c717b cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=rxed6eZ7nxedQE1Oj_YA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfXxpZjf6U++Dyo r05WRlDkUj9EjJCo8kDfgpqP/TSviZLCa3RQuFP8UjjHwP5d5viAJU7KdvM6VVonjKDp91SguNh /ryO6w8W8RFwqcNcFpQmBarcqnbJKdJ5qYLmtwuhZKW+J1auxCz/IRnPopwgik2j2KScoHOZ9HQ wTphPVWzb0RahYPGff2K/Nq6S3MU55lVcOAxBh9bTTiss6n1wa67fGG+TCvrO9xxTVesJ9Cy8Yn PPaKltuPglipNR9vmNia1D9p8H/8fPc9DzCkQ06o5GeqNOY0zcEWUUWQndYeAwfd96PTgzrIhDX PcGyo3BbyG8n3lLoUco23W9Vw5mfDiQWZG2Oesq3nNa1JflPfd0uFsMb50i1wR+yDjcIFaBHqrO TN1BLI8LIVAjpCBBvk82ibpdx1hnYOmazzEJeIwj9KAf04c73Rn7ey0/NCtYN5XtmGYJMx2LWXH 4ZrxSgEBKHUI0aTH98g== X-Proofpoint-Spam-Info: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfXw1U+QgEN3zLD le+2CXsC5QGe82MEnQUJKCUp0fkovfCqI9acdDU7Q4uFtNIKjX7PrZ9HO6WLrB6mFawqy4Vl//p i2CNDmTV6vrqX8rAv659IACtzuXVT1E= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-12_03,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 phishscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608120107 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786542200544158500 We figured NMI relates to machines (for their machine-specific handling), so move the 'inject-nmi' QMP handler with the rest of machine ones, in hw/core/machine-qmp-cmds.c. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- hw/core/machine-qmp-cmds.c | 6 ++++++ system/cpus.c | 8 -------- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/hw/core/machine-qmp-cmds.c b/hw/core/machine-qmp-cmds.c index e62cb4ec888..1aa5f262298 100644 --- a/hw/core/machine-qmp-cmds.c +++ b/hw/core/machine-qmp-cmds.c @@ -10,6 +10,7 @@ #include "qemu/osdep.h" #include "hw/acpi/vmgenid.h" #include "hw/core/boards.h" +#include "hw/core/nmi.h" #include "hw/intc/intc.h" #include "hw/mem/memory-device.h" #include "qapi/error.h" @@ -448,3 +449,8 @@ void qmp_dump_skeys(const char *filename, Error **errp) } DUMP_SKEYS_INTERFACE_CLASS(oc)->qmp_dump_skeys(filename, errp); } + +void qmp_inject_nmi(Error **errp) +{ + nmi_inject(errp); +} diff --git a/system/cpus.c b/system/cpus.c index 9758cda4636..aa2510bf8fc 100644 --- a/system/cpus.c +++ b/system/cpus.c @@ -26,7 +26,6 @@ #include "qemu/coroutine-tls.h" #include "qapi/error.h" #include "qapi/qapi-commands-machine.h" -#include "qapi/qapi-commands-misc.h" #include "qapi/qapi-events-run-state.h" #include "qapi/qmp/qerror.h" #include "exec/gdbstub.h" @@ -38,7 +37,6 @@ #include "qemu/plugin.h" #include "system/cpus.h" #include "qemu/guest-random.h" -#include "hw/core/nmi.h" #include "system/physmem.h" #include "system/replay.h" #include "system/runstate.h" @@ -922,9 +920,3 @@ void qmp_pmemsave(uint64_t addr, uint64_t size, const c= har *filename, exit: fclose(f); } - -void qmp_inject_nmi(Error **errp) -{ - nmi_inject(errp); -} - --=20 2.53.0 From nobody Wed Aug 26 07:24:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786542008; cv=none; d=zohomail.com; s=zohoarc; b=Rh9jEVNGAldd8KmWcuUZrAlXJOAmBGYh3tpzx6wb24braLQODVOK/jOgg870+mQ8fLKh+2aXapeoDZJM3B0xE/UwLzw0CGrsKDgRoOhmu7N6LkKnPsoyVUrK4hr410XYE+itHJW4oezAdkyVUMkc3Wh9/OMIwqxgLzEbweh6sd4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786542008; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=aFyJnJW9gX2KVvO370AmDZhKgBUk1x36zwxEEGt8Rnw=; b=PPl/ULXz2yCy5eiBtbDj+Mj2zi6js985XG5nRnoMuZWhl5kvLaL75CSIpOOU8UWo+nqXSEBQGBRm9Or1eN+ZKKRH1soSm1TavUre+OW0bIhJd4LJyRKOZDoRDLWT16qBSw8L6w4xXjqDcpzg94IYahISuwny9y3a/wleWhgE7/g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178654200879351.47315206413782; Wed, 12 Aug 2026 06:40:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wu8od-0006bm-Bc; Wed, 12 Aug 2026 09:16:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8m7-0004Ab-PC for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:13:48 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8m4-0006sS-Gj for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:13:43 -0400 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67CB4mmG3311926 for ; Wed, 12 Aug 2026 13:13:39 GMT Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g0p3d0ucr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Aug 2026 13:13:38 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8eac2620cb0so10798926d6.3 for ; Wed, 12 Aug 2026 06:13:38 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4997c98ce0bsm49276855e9.11.2026.08.12.06.13.35 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 12 Aug 2026 06:13:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= aFyJnJW9gX2KVvO370AmDZhKgBUk1x36zwxEEGt8Rnw=; b=UYVWm/uegc3trRjg NDND8XsfqlEFpyvK//dpHnC2xfAaRlFgu0nS/D+qHt6GcGLn/AzUBo15utG9rrRO v88/H9mnyN9juJkUCIB3cI11/e6SnCVojUrJ6p+bOIomYP+z8qZqb2hcZ71ehFvE BRzNoeAZdXp3mRQquqKQ8AO6Rk+UPNUF/wcweDCXFBPLS0y8Y8n0RXb32lRN+cw+ NWtd5BjgpJ7XjFNXnHiak5VtNLT00ZyQFd9pKDmdSKzTV+63umyPzti2+TudaW49 UjIsqOudNmfhd22MnvniTBoeznu5dWhIczPLwhd5N5t8C5Dl8NZbBeel9gG2lO6i mgNlHA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786540418; x=1787145218; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=aFyJnJW9gX2KVvO370AmDZhKgBUk1x36zwxEEGt8Rnw=; b=A5oIwiU0R7PcaSY7Oh3ZXfqrYE6bpDlvkc8ysMVKhf5pfIFPKY5mg12QqBVCpQbfvO lTUB9sL2UO89BJe1StyRFMEOXHd4Xf57BbocdUstAkg6HiHg8sJ+jrKOyE8ygu0Rzx+2 TWQ+Xb3iPfiTS6eOdKeyBefXQEtjUPCm6YVfnF1Frt3JIl2Vj6j+PqWixGgVtCPn4d8e eXoeAirPWk+75JBcUgVF7yzKoNrgS+f626iNhCtTPy/7lfwge1PtmpUnSNjhcwzQ06qm vkaEDTrx5kFq7egXokagvqjD/OErGTiMgJDFpMd8ycnDZxCBKYKV0fezyHxdaZSTAWVT fEFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786540418; x=1787145218; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aFyJnJW9gX2KVvO370AmDZhKgBUk1x36zwxEEGt8Rnw=; b=Snzag4Jsc/AiLgPVbw6N5rCTYJur5nrjtJ3icw8LugpLWxJY4qQRvLk1vR9qcagteL tKFW044K8blUDq3z9Usb+7FPdMARxKaede/jfhaWNWpFQlO1026tpcd+WOMlpvnG0Z/A IBumKP8aOtRw/cUuNEA56VRyN5Fpc3ozLD+Rz7UNhXC7F7NyC6QnsdQi1CP0Kz3PJ+2j ZaU7Xu5ziv0OAq7exEaqisNPzf3YCT243aZmEm6g4y8POgdKP+wgMBDiiquh2UbFwI4B tvGUg6HuONJU9cXEGD2mfbfNkcM5l9GgdbzCAnb0PpsGa6hIlgNKJC4MvAMRK48BFhZ1 lnDw== X-Forwarded-Encrypted: i=1; AHgh+RoiR+jO7E5IBaD6hA/871T/x36plj10K7ZLcU4JwAlGl7K0xnp87qYiL/IfJ7gIZzdUh9ifd+KOs+iy@nongnu.org X-Gm-Message-State: AOJu0YynZWiEUb3DCLLaWzPZupIvoyaF5VicoQ7HDV+2b5wKIxG58L7B biRqok/UnMbH3l8YcLBohXBvi0HeCkSe+dFgHuX1vF4wjWs6GbPAEvFIP5r2w9gb+NXz7ua1/Es 36GqPY4jgCtwQMDadjsa71ZiKVwue26Xku9spjyXMlSOeiV9x88FUwIWi1Q== X-Gm-Gg: AR+sD117l4xdPR6m0XYSwNOpBFGfGJtgIhYD5tYH+Yrn02eJ9CLFjU7gb3z72xsdWaa N5YZjR9esRpnfyEICEXt1cAiJqdzDYVKreh9HRiB6cGJojI5zJiPXJPIAljucI17xJKRbPMkptU 8KlCwe5RFXpsv26mVhlT5L8WVwejyhTB6gX7AfZ+dc63Xp2kjApqk8k0+2AunlDyV10AlRdbVjx uWkj8DtvgbjTTTVuglNaA0Bn9O+5Og0uIoS90euXnRVBRj0RO+TtA8QU5d6pe9iZJ+IIkRbZZKA SIUNVuWDVO8z8p8gaXtSD48XMbKipc90NPqu81lJFZdU55vS0f4BhOGbNy1zNk4W7D1tuJXfVa8 a09fb60GGT7uc27DRGtIWaOf8HXi4s+XVOg7l3KQ7zg== X-Received: by 2002:a05:622a:e183:20b0:52d:6c36:db32 with SMTP id d75a77b69052e-52d6c36eb66mr9420701cf.41.1786540417573; Wed, 12 Aug 2026 06:13:37 -0700 (PDT) X-Received: by 2002:a05:622a:e183:20b0:52d:6c36:db32 with SMTP id d75a77b69052e-52d6c36eb66mr9420311cf.41.1786540417103; Wed, 12 Aug 2026 06:13:37 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , qemu-devel@nongnu.org Cc: Markus Armbruster , David Gibson , "Dr. David Alan Gilbert" , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 15/16] system: Extract QMP memsave/pmemsave commands to physmem-qmp-cmds.c Date: Wed, 12 Aug 2026 15:11:46 +0200 Message-ID: <20260812131147.83188-16-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260812131147.83188-1-philmd@oss.qualcomm.com> References: <20260812131147.83188-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: SraqIY8GLjemKTo9F4iafCriWSTdXvnC X-Proofpoint-GUID: SraqIY8GLjemKTo9F4iafCriWSTdXvnC X-Authority-Analysis: v=2.4 cv=UfNhjqSN c=1 sm=1 tr=0 ts=6a7c7182 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=r45cMcW8mIPJ2GNrZIoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfXxx+6RrC/3D+U NvPHql53Pg8LUGS6t4bMuCFDKC3TUHumQSoqsGM8/FPYqSFxKMImI+Mj6IgOGOHUn+fkNhOBZ5s 29WWh3qVdmiayQvvTuSsWvvXocQ/Tb5ajt7x1oHkvlIeIgN8xHdARyr5dTToG2ErTPOGUPvZl4v FQ6t7mjw2RqMInkarAvLI96nj03mY60FCbY+e1XEIx0LiABglelJm1owjYn5LrTG6X7c7DuXi0S 5eTV3dNG6trvJ4R7VfadMmAT4UxkKJnBdmQnI2+hlIZKVyNJ020wbeMibV+KyB6zYCAsREnNgEc DuTewlWMoxeAcAcjsxI9027NWlAH3L0r+kAHzBM36bXTM2sbQ5LNjwAPz0xmFDAeZp1Z58YAU06 ZCkUHNN/+wDnPNHz/hEdZW7lkq0Oo+ZilbOR08WFNDWp79+tktnl18cBGALnIbdigVuA/+hk6r9 Ppmb7l69Ka8wo1+0W/g== X-Proofpoint-Spam-Info: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfX9VDqlEIrm2+u Z1AuoB99RaJvtiB/ip41p7UmwtLoURSlQHDp5t35gWDL44J9vdyQZKsW3h+u6iuo9raGmdCsDGK x0g7QNenNVVaI5NXcZCUTeIaH9hrNuY= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-12_03,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 phishscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608120107 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786542010084158500 Keep cpus.c related to vCPU scheduling, move the QMP handlers related to dumping physical memory to file to their own unit. Fix a pair of checkpatch.pl errors doing so: ERROR: braces {} are necessary for all arms of this statement #185: FILE: system/physmem-qmp-cmds.c:51: + if (l > size) [...] Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- system/cpus.c | 92 -------------------------------- system/physmem-qmp-cmds.c | 107 ++++++++++++++++++++++++++++++++++++++ system/meson.build | 1 + 3 files changed, 108 insertions(+), 92 deletions(-) create mode 100644 system/physmem-qmp-cmds.c diff --git a/system/cpus.c b/system/cpus.c index aa2510bf8fc..43ff10cf008 100644 --- a/system/cpus.c +++ b/system/cpus.c @@ -25,9 +25,7 @@ #include "qemu/osdep.h" #include "qemu/coroutine-tls.h" #include "qapi/error.h" -#include "qapi/qapi-commands-machine.h" #include "qapi/qapi-events-run-state.h" -#include "qapi/qmp/qerror.h" #include "exec/gdbstub.h" #include "accel/accel-cpu-ops.h" #include "system/hw_accel.h" @@ -40,7 +38,6 @@ #include "system/physmem.h" #include "system/replay.h" #include "system/runstate.h" -#include "migration/misc.h" #include "system/cpu-timers.h" #include "system/whpx.h" #include "hw/core/boards.h" @@ -831,92 +828,3 @@ int vm_stop_force_state(RunState state) return ret; } } - -void qmp_memsave(uint64_t addr, uint64_t size, const char *filename, - bool has_cpu, int64_t cpu_index, Error **errp) -{ - FILE *f; - uint64_t l; - CPUState *cpu; - uint8_t buf[1024]; - uint64_t orig_addr =3D addr, orig_size =3D size; - - if (migration_guest_ram_loading()) { - error_setg(errp, "Guest memory access not allowed during migration= "); - return; - } - - if (!has_cpu) { - cpu_index =3D 0; - } - - cpu =3D qemu_get_cpu(cpu_index); - if (cpu =3D=3D NULL) { - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "cpu-index", - "a CPU number"); - return; - } - - f =3D fopen(filename, "wb"); - if (!f) { - error_setg_file_open(errp, errno, filename); - return; - } - - while (size !=3D 0) { - l =3D sizeof(buf); - if (l > size) - l =3D size; - if (cpu_memory_rw_debug(cpu, addr, buf, l, 0) !=3D 0) { - error_setg(errp, "Invalid addr 0x%016" PRIx64 "/size %" PRIu64 - " specified", orig_addr, orig_size); - goto exit; - } - if (fwrite(buf, 1, l, f) !=3D l) { - error_setg(errp, "writing memory to '%s' failed", - filename); - goto exit; - } - addr +=3D l; - size -=3D l; - } - -exit: - fclose(f); -} - -void qmp_pmemsave(uint64_t addr, uint64_t size, const char *filename, - Error **errp) -{ - FILE *f; - uint64_t l; - uint8_t buf[1024]; - - if (migration_guest_ram_loading()) { - error_setg(errp, "Guest memory access not allowed during migration= "); - return; - } - - f =3D fopen(filename, "wb"); - if (!f) { - error_setg_file_open(errp, errno, filename); - return; - } - - while (size !=3D 0) { - l =3D sizeof(buf); - if (l > size) - l =3D size; - physical_memory_read(addr, buf, l); - if (fwrite(buf, 1, l, f) !=3D l) { - error_setg(errp, "writing memory to '%s' failed", - filename); - goto exit; - } - addr +=3D l; - size -=3D l; - } - -exit: - fclose(f); -} diff --git a/system/physmem-qmp-cmds.c b/system/physmem-qmp-cmds.c new file mode 100644 index 00000000000..d85430357d5 --- /dev/null +++ b/system/physmem-qmp-cmds.c @@ -0,0 +1,107 @@ +/* + * QMP commands to dump physical memory + * + * Copyright (c) 2003-2008 Fabrice Bellard + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include "qemu/osdep.h" +#include "qapi/error.h" +#include "qapi/qapi-commands-machine.h" +#include "qapi/qmp/qerror.h" +#include "hw/core/cpu.h" +#include "system/physmem.h" +#include "migration/misc.h" + +void qmp_memsave(uint64_t addr, uint64_t size, const char *filename, + bool has_cpu, int64_t cpu_index, Error **errp) +{ + FILE *f; + uint64_t l; + CPUState *cpu; + uint8_t buf[1024]; + uint64_t orig_addr =3D addr, orig_size =3D size; + + if (migration_guest_ram_loading()) { + error_setg(errp, "Guest memory access not allowed during migration= "); + return; + } + + if (!has_cpu) { + cpu_index =3D 0; + } + + cpu =3D qemu_get_cpu(cpu_index); + if (cpu =3D=3D NULL) { + error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "cpu-index", + "a CPU number"); + return; + } + + f =3D fopen(filename, "wb"); + if (!f) { + error_setg_file_open(errp, errno, filename); + return; + } + + while (size !=3D 0) { + l =3D sizeof(buf); + if (l > size) { + l =3D size; + } + if (cpu_memory_rw_debug(cpu, addr, buf, l, 0) !=3D 0) { + error_setg(errp, "Invalid addr 0x%016" PRIx64 "/size %" PRIu64 + " specified", orig_addr, orig_size); + goto exit; + } + if (fwrite(buf, 1, l, f) !=3D l) { + error_setg(errp, "writing memory to '%s' failed", + filename); + goto exit; + } + addr +=3D l; + size -=3D l; + } + +exit: + fclose(f); +} + +void qmp_pmemsave(uint64_t addr, uint64_t size, const char *filename, + Error **errp) +{ + FILE *f; + uint64_t l; + uint8_t buf[1024]; + + if (migration_guest_ram_loading()) { + error_setg(errp, "Guest memory access not allowed during migration= "); + return; + } + + f =3D fopen(filename, "wb"); + if (!f) { + error_setg_file_open(errp, errno, filename); + return; + } + + while (size !=3D 0) { + l =3D sizeof(buf); + if (l > size) { + l =3D size; + } + physical_memory_read(addr, buf, l); + if (fwrite(buf, 1, l, f) !=3D l) { + error_setg(errp, "writing memory to '%s' failed", + filename); + goto exit; + } + addr +=3D l; + size -=3D l; + } + +exit: + fclose(f); +} diff --git a/system/meson.build b/system/meson.build index 377adce8035..64e06e7abcc 100644 --- a/system/meson.build +++ b/system/meson.build @@ -19,6 +19,7 @@ system_ss.add(files( 'memory_mapping.c', 'memory.c', 'physmem.c', + 'physmem-qmp-cmds.c', 'qdev-monitor.c', 'qtest.c', 'rtc.c', --=20 2.53.0 From nobody Wed Aug 26 07:24:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1786541039; cv=none; d=zohomail.com; s=zohoarc; b=E8UMMI4wwN8NVx2vLPPvQ0R4hVbnzid4x9wpCD6O/dsfCAhCzcxFHUxH7FbjZdp70Kzz/gLRrbNf3IlTkJT31J7/DYM3e8wd3f3+EnOhU3vG2wTZfPs/7Pu8zn6Z6wT6JZD0/ItbIN0l9/xCjt84bOk/5P+AkLjK5BGfLkrKbH0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786541039; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lnwwQTsj4uykQtQK5I2PSMwd23zuzWxOWZdTcugtZPU=; b=M4qYXglQoJHX+16WVyM0cFSTBIAASkdi/O/wDeSnMwBmb9Rg3UkVHPbR0MvefZtmuSnoDaFvxV0c5D7POefYblmy7GJVen4ZzxgZgDLcp7HLRr7jC5suDoetIdVifMmy4/m9e+gRJcUtUkfhHIlq7gO8DjZteyUoyyBHwC4np/8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1786541039591278.761789198271; Wed, 12 Aug 2026 06:23:59 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wu8qU-00016Q-T5; Wed, 12 Aug 2026 09:18:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8mF-0004EZ-ID for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:13:54 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wu8mB-0006u8-EJ for qemu-devel@nongnu.org; Wed, 12 Aug 2026 09:13:50 -0400 Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67CB46Lu3265804 for ; Wed, 12 Aug 2026 13:13:46 GMT Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g08jrky00-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 12 Aug 2026 13:13:45 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51c0408254aso28878191cf.0 for ; Wed, 12 Aug 2026 06:13:45 -0700 (PDT) Received: from localhost.localdomain (pmd666.hd.free.fr. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4997c94d159sm43959605e9.7.2026.08.12.06.13.43 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 12 Aug 2026 06:13:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= lnwwQTsj4uykQtQK5I2PSMwd23zuzWxOWZdTcugtZPU=; b=UHqJtlJs/9/p8o3A RmB7KUjSt2dU0pO6lbpSIOBUa1sVkZa5QGHsmbe5YrmOk4pMSNHk6CR7jnv7ZG3e 3VNCpfJXPlwyhvA7bpXYwSq2gSW/GgDs5G50w7vNBdfwoX1mGVG3CVP5l/BuSNIt v/GzlCzds4gXsml6CznKbyU/Z6gXYzehXYgn879nznFhDihQCHUq3XjQXrLWImnQ hWn+bIr/PlcMKJP10bcfqfNfAamOghm5BMZ6DNAYiIgvSB4HTVVOdVWxSYOHxnkE WYFIFfr70IYJi4RUVMqHQbhDInZjz2oaQ7iMvye0nSn1/RZBbh3HypaBmCQSx142 NCjnow== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786540425; x=1787145225; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=lnwwQTsj4uykQtQK5I2PSMwd23zuzWxOWZdTcugtZPU=; b=dKvYTu8XKxj7bcezFylO44nVO30DOPZaC7GY+aOmJkIksxe5aLMnYupu7no2uWN7es 02i3rSHuMXHEgwI8Viz+7TOKnZt6sfWeyJc8+lKaplA/xR40Za1ylK3xaEFaavqZ/tkk Em1JkHAOPqjS4/tGG7iL4FTFP/iIyqNR+/3w9KrTfgSzOmL822sj1n02F8HNTqpHK4xH L0BhcZrJG2xLQ4OnXQTOjEk5Dqopf9LQ3lvqOu1RIag6a99rZG/OtkC1FzZ7g1yHPmqF J+JAkqUh9ZU0Xy2FxrWL7ajBOPZ7+cgN2Gz36UgKnS+bd/qSaGLBR7h8xv/E+S7eNz9m Qy7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786540425; x=1787145225; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=lnwwQTsj4uykQtQK5I2PSMwd23zuzWxOWZdTcugtZPU=; b=KrjDFGlHdpJn2Osq/kAqNr6p/uxWLX92nQqulb43+Mz/r202ac99UD1Qo5JHOZKBvM 7ugXsj9bcWop00/c1ow0d1QZ2iD0BYeVDGC8BMeYKzZGfvecCzhd7TXVvy44SfFhU7LS dFEZMenLJ6lSJ8cIRS35e+mdCdS+kOSEjs6dnIpa1dFaF8JlXanviGs7yDjUBwf4ZC0i L8tY7aHOAB7yFxrF/adRxYaV9wLJOpob+qe361gEvs579U4gYpap2biUHh6en3TSfcsO F0O6bCEsx6ZddqXS52VDBpt7QH5Vbd7TUckNzY5CFQFG6C0xuAEQvn99oLgGui1YCOJi F7DQ== X-Forwarded-Encrypted: i=1; AHgh+Rr5fbc5mCsd7o91rqbH4N/kmmebK7RjCNIN1TjSHefMIFy0hVaORNxDaXGkUDHLyxML+DCOeIOcOJql@nongnu.org X-Gm-Message-State: AOJu0YyNnt4JG8CUH5rQL3cCLwzCTbM5zJ6yCr209tABuTr++Me0SqhF Ba0Up0Ey0PjOMTEZwKRLVkXcqRp63/sVPHDOFqnZJlcxmiJcRuY8MZX/JreDkvp6+XbwVHqaevv /dGRG1ts88Cme6f4YGbF4fbuSuCHCzPb8x/cZP2ZCI1TdGgHyJ/ixbUAqvg== X-Gm-Gg: AR+sD13y9bob2Boll8FPH05qKV7TVgdLgrkRr477KDD6eW1r5O6cLnjbVFlKJek9TMR Pnao6cooCM/nulAMrblDrZy5uA0r3jKn6B49VpeWHIz82f9dE11gD/iTNlUNCqUELlqY2cNsTEw OOO/Br17qomdQVeJqoFv0ABX5e/5hB2PC6XANypgwx5EZDisg9mH6ykC4qWSz8d691lWNGNnyTE mJ+MHm6cQHFfeVhZkBKQcCv9kgwGhwS8JDTo/l6hsqguUqtsib6WtzBoBOnaMiPdJxiKY6DmfEg 3LkU9NnrBFfWyKPb4HtuHX5H02k2zLWoQYkG6F1AdR9edZRmnplKeVGpggDPNAs/zIgv7v3j4rG tYsDa4Ed4egzYzMW8JvDYV6IsaDfCNN9MjJvZ1ALiKA== X-Received: by 2002:a05:622a:48a:b0:51c:1f35:4638 with SMTP id d75a77b69052e-52d60365125mr67869891cf.21.1786540424849; Wed, 12 Aug 2026 06:13:44 -0700 (PDT) X-Received: by 2002:a05:622a:48a:b0:51c:1f35:4638 with SMTP id d75a77b69052e-52d60365125mr67869071cf.21.1786540424176; Wed, 12 Aug 2026 06:13:44 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , qemu-devel@nongnu.org Cc: Markus Armbruster , David Gibson , "Dr. David Alan Gilbert" , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 16/16] system: Move runstate-related code from cpus.c to runstate.c Date: Wed, 12 Aug 2026 15:11:47 +0200 Message-ID: <20260812131147.83188-17-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260812131147.83188-1-philmd@oss.qualcomm.com> References: <20260812131147.83188-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: Az5OlNe2pBrmnKg_KIhh8kD7-XR4TiHr X-Proofpoint-Spam-Info: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfX5sDzsm8gSljs ugBO8b86sFWKq8YExVSNJ/RVktq9UN8FgCZWh7TfFQWn0d0KJkiBKkscvTBod7oSzmSLihZ8V7z NR6cDrFYdlmmN31lTqKGDJ2Fe7cvyys= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEyMDEwNyBTYWx0ZWRfX979nDfQvyGXu pGgtUWG8R6JXwyff8MOchhaOni0Xro4eIKpKuZwYjkXV4a0GEesRzivBuWIlWc24VX4ymr751Im SUZjc/J5Ftd+lhOFkeJClgHYbAPfehB/gZlk/f5oTSRKlufEjfufcR0zKLDewL7RVCu30ANoan+ c9rBC3j71po9CaOpwLRd8yCtlsseB7fKX2Qp27w19LYkNZFpz/CDEzVyYPz7AxntI2fWiQ2eUlz 8AYQsKxMaspXGPmhCfcniS2KtxyxXcgip4spgY0yOXlTRuhI2ttAjFWoI60WOuwzCKDK+v2FBzw q2adz8K8uA/jjpdPrBmenVGFDAzpJAXgFy2Doklx2uLbXfY294xhGW9GpF9dRgmcNZKwWqkz5t3 6hgCLXbCZIWBF+ww8kD3iehwu6PTQVzCmRv6aiZTqHTq0JpYBXcsPURUiTr48Gty5k1ERdq1tKN 5qm4Sia4oNlENkGdhbQ== X-Authority-Analysis: v=2.4 cv=Z7Dc2nRA c=1 sm=1 tr=0 ts=6a7c718a cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=QK4PlI00PMcCPjLnJOMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-ORIG-GUID: Az5OlNe2pBrmnKg_KIhh8kD7-XR4TiHr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-12_03,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 impostorscore=0 spamscore=0 priorityscore=1501 bulkscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608120107 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1786541042095158500 Keep cpus.c focused on vCPUs handling, move code related to VM state to runstate.c where similar code lives. Fix few checkpatch.pl warnings: WARNING: Block comments use a leading /* on a separate line WARNING: Block comments use * on subsequent lines #327: FILE: system/runstate.c:541: +/* does a state transition even if the VM is already stopped, + current state is forgotten forever */ Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- system/cpus.c | 147 ------------------------------------------- system/runstate.c | 154 ++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 154 insertions(+), 147 deletions(-) diff --git a/system/cpus.c b/system/cpus.c index 43ff10cf008..f37e215c586 100644 --- a/system/cpus.c +++ b/system/cpus.c @@ -25,7 +25,6 @@ #include "qemu/osdep.h" #include "qemu/coroutine-tls.h" #include "qapi/error.h" -#include "qapi/qapi-events-run-state.h" #include "exec/gdbstub.h" #include "accel/accel-cpu-ops.h" #include "system/hw_accel.h" @@ -272,58 +271,6 @@ void cpu_interrupt(CPUState *cpu, int mask) cpus_accel->handle_interrupt(cpu, mask); } =20 -/* - * True if the vm was previously suspended, and has not been woken or rese= t. - */ -static int vm_was_suspended; - -void vm_set_suspended(bool suspended) -{ - vm_was_suspended =3D suspended; -} - -bool vm_get_suspended(void) -{ - return vm_was_suspended; -} - -static int do_vm_stop(RunState state, bool send_stop) -{ - int ret =3D 0; - RunState oldstate =3D runstate_get(); - - if (runstate_is_live(oldstate)) { - vm_was_suspended =3D (oldstate =3D=3D RUN_STATE_SUSPENDED); - runstate_set(state); - cpu_disable_ticks(); - if (oldstate =3D=3D RUN_STATE_RUNNING) { - pause_all_vcpus(); - } - ret =3D vm_state_notify(0, state); - if (send_stop) { - qapi_event_send_stop(); - } - } - - bdrv_drain_all(); - /* - * Even if vm_state_notify() return failure, - * it would be better to flush as before. - */ - ret |=3D bdrv_flush_all(); - trace_vm_stop_flush_all(ret); - - return ret; -} - -/* Special vm_stop() variant for terminating the process. Historically cl= ients - * did not expect a QMP STOP event and so we need to retain compatibility. - */ -int vm_shutdown(void) -{ - return do_vm_stop(RUN_STATE_SHUTDOWN, false); -} - bool cpu_can_run(CPUState *cpu) { if (cpu->stop) { @@ -734,97 +681,3 @@ void cpu_stop_current(void) cpu_exit(current_cpu); } } - -int vm_stop(RunState state) -{ - if (qemu_in_vcpu_thread()) { - qemu_system_vmstop_request_prepare(); - qemu_system_vmstop_request(state); - /* - * FIXME: should not return to device code in case - * vm_stop() has been requested. - */ - cpu_stop_current(); - return 0; - } - - return do_vm_stop(state, true); -} - -/** - * Prepare for (re)starting the VM. - * Returns 0 if the vCPUs should be restarted, -1 on an error condition, - * and 1 otherwise. - */ -int vm_prepare_start(bool step_pending) -{ - int ret =3D vm_was_suspended ? 1 : 0; - RunState state =3D vm_was_suspended ? RUN_STATE_SUSPENDED : RUN_STATE_= RUNNING; - RunState requested; - - qemu_vmstop_requested(&requested); - if (runstate_is_running() && requested =3D=3D RUN_STATE__MAX) { - return -1; - } - - /* Ensure that a STOP/RESUME pair of events is emitted if a - * vmstop request was pending. The BLOCK_IO_ERROR event, for - * example, according to documentation is always followed by - * the STOP event. - */ - if (runstate_is_running()) { - qapi_event_send_stop(); - qapi_event_send_resume(); - return -1; - } - - /* - * WHPX accelerator needs to know whether we are going to step - * any CPUs, before starting the first one. - */ - accel_pre_resume(MACHINE(qdev_get_machine()), step_pending); - - /* We are sending this now, but the CPUs will be resumed shortly later= */ - qapi_event_send_resume(); - - cpu_enable_ticks(); - runstate_set(state); - vm_state_notify(1, state); - vm_was_suspended =3D false; - return ret; -} - -void vm_start(void) -{ - if (!vm_prepare_start(false)) { - resume_all_vcpus(); - } -} - -void vm_resume(RunState state) -{ - if (runstate_is_live(state)) { - vm_start(); - } else { - runstate_set(state); - } -} - -/* does a state transition even if the VM is already stopped, - current state is forgotten forever */ -int vm_stop_force_state(RunState state) -{ - if (runstate_is_live(runstate_get())) { - return vm_stop(state); - } else { - int ret; - runstate_set(state); - - bdrv_drain_all(); - /* Make sure to return an error if the flush in a previous vm_stop= () - * failed. */ - ret =3D bdrv_flush_all(); - trace_vm_stop_flush_all(ret); - return ret; - } -} diff --git a/system/runstate.c b/system/runstate.c index 08acf801b0e..d3e64d2b625 100644 --- a/system/runstate.c +++ b/system/runstate.c @@ -52,6 +52,7 @@ #include "qemu/thread.h" #include "qom/object.h" #include "qom/object_interfaces.h" +#include "system/cpu-timers.h" #include "system/cpus.h" #include "system/qtest.h" #include "system/replay.h" @@ -408,6 +409,159 @@ int vm_state_notify(bool running, RunState state) return ret; } =20 +/* + * True if the vm was previously suspended, and has not been woken or rese= t. + */ +static int vm_was_suspended; + +void vm_set_suspended(bool suspended) +{ + vm_was_suspended =3D suspended; +} + +bool vm_get_suspended(void) +{ + return vm_was_suspended; +} + +static int do_vm_stop(RunState state, bool send_stop) +{ + int ret =3D 0; + RunState oldstate =3D runstate_get(); + + if (runstate_is_live(oldstate)) { + vm_was_suspended =3D (oldstate =3D=3D RUN_STATE_SUSPENDED); + runstate_set(state); + cpu_disable_ticks(); + if (oldstate =3D=3D RUN_STATE_RUNNING) { + pause_all_vcpus(); + } + ret =3D vm_state_notify(0, state); + if (send_stop) { + qapi_event_send_stop(); + } + } + + bdrv_drain_all(); + /* + * Even if vm_state_notify() return failure, + * it would be better to flush as before. + */ + ret |=3D bdrv_flush_all(); + trace_vm_stop_flush_all(ret); + + return ret; +} + +/* + * Special vm_stop() variant for terminating the process. Historically cl= ients + * did not expect a QMP STOP event and so we need to retain compatibility. + */ +int vm_shutdown(void) +{ + return do_vm_stop(RUN_STATE_SHUTDOWN, false); +} + + +int vm_stop(RunState state) +{ + if (qemu_in_vcpu_thread()) { + qemu_system_vmstop_request_prepare(); + qemu_system_vmstop_request(state); + /* + * FIXME: should not return to device code in case + * vm_stop() has been requested. + */ + cpu_stop_current(); + return 0; + } + + return do_vm_stop(state, true); +} + +/** + * Prepare for (re)starting the VM. + * Returns 0 if the vCPUs should be restarted, -1 on an error condition, + * and 1 otherwise. + */ +int vm_prepare_start(bool step_pending) +{ + int ret =3D vm_was_suspended ? 1 : 0; + RunState state =3D vm_was_suspended ? RUN_STATE_SUSPENDED : RUN_STATE_= RUNNING; + RunState requested; + + qemu_vmstop_requested(&requested); + if (runstate_is_running() && requested =3D=3D RUN_STATE__MAX) { + return -1; + } + + /* + * Ensure that a STOP/RESUME pair of events is emitted if a + * vmstop request was pending. The BLOCK_IO_ERROR event, for + * example, according to documentation is always followed by + * the STOP event. + */ + if (runstate_is_running()) { + qapi_event_send_stop(); + qapi_event_send_resume(); + return -1; + } + + /* + * WHPX accelerator needs to know whether we are going to step + * any CPUs, before starting the first one. + */ + accel_pre_resume(MACHINE(qdev_get_machine()), step_pending); + + /* We are sending this now, but the CPUs will be resumed shortly later= */ + qapi_event_send_resume(); + + cpu_enable_ticks(); + runstate_set(state); + vm_state_notify(1, state); + vm_was_suspended =3D false; + return ret; +} + +void vm_start(void) +{ + if (!vm_prepare_start(false)) { + resume_all_vcpus(); + } +} + +void vm_resume(RunState state) +{ + if (runstate_is_live(state)) { + vm_start(); + } else { + runstate_set(state); + } +} + +/* + * does a state transition even if the VM is already stopped, + * current state is forgotten forever + */ +int vm_stop_force_state(RunState state) +{ + if (runstate_is_live(runstate_get())) { + return vm_stop(state); + } else { + int ret; + runstate_set(state); + + bdrv_drain_all(); + /* + * Make sure to return an error if the flush in a previous vm_stop= () + * failed. + */ + ret =3D bdrv_flush_all(); + trace_vm_stop_flush_all(ret); + return ret; + } +} + static ShutdownCause reset_requested; static ShutdownCause shutdown_requested; static int shutdown_exit_code =3D EXIT_SUCCESS; --=20 2.53.0