From nobody Mon Sep 28 01:11:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1789498919; cv=none; d=zohomail.com; s=zohoarc; b=gnYm/PGyLCIqYE/9cngPUi3PBzRc137oJL5RBB6hze3vQTKPJh88znA4oEnJFCV4QWY+4o6QWYR78L/W/URk/NXc7qhPh4ab35BymeRRe7G3RdL/8eQE2dWJnx+clt/LBObEm3Fv4uiELbNmDronALTSQvAo+6OzsnN7z+yjvNs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789498919; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=EWL3kxFD9QCrsASLleNHgZqna8RbaCOY2TACJZ1GAQA=; b=iMY5mn0IKekaOVr4y7fD4cPIcb/a1ASq60jT3nNrfzhgDfkZAg7SbLcEmOb6a+z4RFV69piV3w9lgtlSzy0OxYkoEK9sQYdJcXVK5JTdVvZoC0+6keG3aURyDoGySZw1gF4A+MTsaXPvLurv913WROhaqkA9EimUjAaCou35HBA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1789498919304680.6958605173498; Tue, 15 Sep 2026 12:01:59 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x6YPG-0003jM-Jz; Tue, 15 Sep 2026 15:01:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x6YPD-0003iv-9v for qemu-devel@nongnu.org; Tue, 15 Sep 2026 15:01:23 -0400 Received: from mgamail.intel.com ([192.198.163.10]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x6YPB-0004nc-L1 for qemu-devel@nongnu.org; Tue, 15 Sep 2026 15:01:23 -0400 Received: from fmviesa013.fm.intel.com ([10.60.135.153]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2026 12:01:16 -0700 Received: from dongwonk-z390-aorus-ultra.fm.intel.com ([10.80.113.172]) by fmviesa013.fm.intel.com with ESMTP; 15 Sep 2026 12:01:17 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1789498881; x=1821034881; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=C2ImfHXc1cCDoaIooD4FMsR99sdcyPabx8Z8ennz8CI=; b=cJ07p8V22mcoQwvcAYdBWD6l+oomIUsZw7mJcRlVhxIjinuAvFSEY7kE 7YdMuwNPxY6pfjhc8iB+OcvymdggxbeVlR1fUfxrUfe7jC8AKNRFvFmr8 AP1B+MSHmPVt5DAhWazvBFY+WkVjL/Vn8maxRsOCRkXyaSJ4dQKNv2xlm 7y1R0eRxwI0/GgdhE09D+2VVHh/TUPy/P689qi7yrB4OYh6sGKReW9CNV nPtJVt+747iSyTM5n7KJOguHGhLPSK6pdTTstT93RPMWhYdn0odzr8i6B lXhQ0ngHej/Vk4s0zvsjLwAo7qYSPhogRWEPFp50IZx8iaTu/wVPPj/bB Q==; X-CSE-ConnectionGUID: UObBttX9TEeb/VeDaCRovw== X-CSE-MsgGUID: ArCAfpfWS7yGIbx5xOpwhw== X-IronPort-AV: E=McAfee;i="6800,10657,11905"; a="101222064" X-IronPort-AV: E=Sophos;i="6.27,103,1787036400"; d="scan'208";a="101222064" X-CSE-ConnectionGUID: gfNTTm33TzKJVjM5SeFuJQ== X-CSE-MsgGUID: PpzMbrwrS/OxUc70ZsHqdw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,103,1787036400"; d="scan'208";a="1506443" From: dongwon.kim@intel.com To: qemu-devel@nongnu.org Subject: [PATCH v2] ui/gtk: Register "Grab Input" shortcut to accel_group Date: Wed, 5 Aug 2026 02:20:17 -0700 Message-Id: <20260805092017.21028-2-dongwon.kim@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260805092017.21028-1-dongwon.kim@intel.com> References: <20260805092017.21028-1-dongwon.kim@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=192.198.163.10; envelope-from=dongwon.kim@intel.com; helo=mgamail.intel.com X-Spam_score_int: -9 X-Spam_score: -1.0 X-Spam_bar: - X-Spam_report: (-1.0 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_96_XX=3.405, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1789498920140158500 From: Dongwon Kim The "Grab Input" shortcut key currently fails to trigger when the window is in fullscreen mode because the menubar is hidden, which disables GtkAccelMap-based shortcuts associated with it. To ensure the accelerator remains active in fullscreen, connect it directly to s->accel_group and explicitly set the hotkey display on the menu item label. v2: gd_accel_grab_input returns TRUE Cc: Marc-Andr=C3=A9 Lureau Signed-off-by: Dongwon Kim --- ui/gtk.c | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 632e302ed7..c07f275537 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -1932,6 +1932,14 @@ static void gd_menu_grab_input(GtkMenuItem *item, vo= id *opaque) gd_update_cursor(vc); } =20 +static gboolean gd_accel_grab_input(void *opaque) +{ + GtkDisplayState *s =3D opaque; + + gtk_menu_item_activate(GTK_MENU_ITEM(s->grab_item)); + return TRUE; +} + static void gd_change_page(GtkNotebook *nb, gpointer arg1, guint arg2, gpointer data) { @@ -2611,6 +2619,7 @@ static void gd_create_menu_view(GtkDisplayState *s, D= isplayOptions *opts) { GtkWidget *view_menu; GtkWidget *separator; + GtkWidget *child; QemuConsole *con; bool zoom_to_fit =3D false; int vc, i; @@ -2669,12 +2678,15 @@ static void gd_create_menu_view(GtkDisplayState *s,= DisplayOptions *opts) gtk_menu_shell_append(GTK_MENU_SHELL(view_menu), s->grab_on_hover_item= ); =20 s->grab_item =3D gtk_check_menu_item_new_with_mnemonic(_("_Grab Input"= )); - gtk_menu_item_set_accel_path(GTK_MENU_ITEM(s->grab_item), - "/View/Grab Input"); - gtk_accel_map_add_entry("/View/Grab Input", GDK_KEY_g, - HOTKEY_MODIFIERS); gtk_menu_shell_append(GTK_MENU_SHELL(view_menu), s->grab_item); - + gtk_accel_group_connect(s->accel_group, GDK_KEY_g, HOTKEY_MODIFIERS, 0, + g_cclosure_new_swap(G_CALLBACK(gd_accel_grab_i= nput), + s, NULL)); + child =3D gtk_bin_get_child(GTK_BIN(s->grab_item)); + if (GTK_IS_ACCEL_LABEL(child)) { + gtk_accel_label_set_accel(GTK_ACCEL_LABEL(child), + GDK_KEY_g, HOTKEY_MODIFIERS); + } separator =3D gtk_separator_menu_item_new(); gtk_menu_shell_append(GTK_MENU_SHELL(view_menu), separator); =20 --=20 2.43.0