From nobody Tue Aug 25 09:50:53 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=quarantine dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1785856741; cv=pass; d=zohomail.com; s=zohoarc; b=D45Ri2qkQyF4QnyO/Hi49CA9oqZcezS+NzpVAOztzwwn1CpsjVAEOhGPSjpLCcrmBl8+7wKjX1EVIsr0bJmq659TG5lLWsCEYBlI1hfNkc3fk9fLkqdqnIzbmRKbxQbVhzCo7S3+sR7GD381rfjH6k11zmhthqrCQ7d/yyiWgtQ= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785856741; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=8XCSWAGKsaxlEe8xd6WIhc02r3cmsLbUTexZDW7dqLQ=; b=fUM94A1G7hHBHgapTFVBUQXN84wIOK59R46cWE9u/pPZjc+dASen4eVX1YLEfAEI+BmwOTzHyGFLjvfwkDDrO/qMHugiikIcbZnjjAYjxbnNCub2LVsiPg5+nWpbdkp85hrfRkbuqjCoE4A3CCHp9WuaSkNwy2sM9PRFUW/Qx8M= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1785856741626128.94794266855286; Tue, 4 Aug 2026 08:19:01 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wrGuV-0006h0-SR; Tue, 04 Aug 2026 11:18:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wrGuU-0006go-QY for qemu-devel@nongnu.org; Tue, 04 Aug 2026 11:18:30 -0400 Received: from mail-northeuropeazlp170110003.outbound.protection.outlook.com ([2a01:111:f403:c200::3] helo=DU2PR03CU002.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wrGuT-0004oi-B4 for qemu-devel@nongnu.org; Tue, 04 Aug 2026 11:18:30 -0400 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by GVXPR08MB11713.eurprd08.prod.outlook.com (2603:10a6:150:2be::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.18; Tue, 4 Aug 2026 15:17:53 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%7]) with mapi id 15.21.0270.016; Tue, 4 Aug 2026 15:17:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GQmPZE2toQ0Xmf4aOhXQx9lHf6VBKUdonnsnYn5OoqmnpNksCODJb6pD12342mxGUraV0LZbUJkwH63OjwEStCO0p7ifxX0P7uvycMMe83eZBnd29BClwLPtYy5NURneKDHdls3iBB6GM6AVpE0s4j/zjsXWO2IYLx+ge8rmaY0pEXq5HJEU1QiZgWItwO/ah2UbQe+JLT/WL3Vv7YzO/pbey0vg/mr+xaCmDzONpKK4RmXyDyBOc14eQC/qgy3dzgqJQzhEqCPt6Sxg7HZVwPrmYtVjcmu9E6A2AM3nG7C61lba9z4CWNYGmbGSpLo4yOlep2q6qUal+2Em8AYAhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8XCSWAGKsaxlEe8xd6WIhc02r3cmsLbUTexZDW7dqLQ=; b=OpRuGA2mt+I9CqXDvAOsrjR8IXURzj6LYnyF672tu8q8GKVUOmoxZtXLVHPNfpKTYBc8DYAZReZ+DFW8WlNGPymORBaulFMpHMoBAItcnXu+/EmHtg+LoXomN8n2WvNzxohZHJad5knPtS/xMNfXtlIRVWDRzjMMNMumM+tl0hDEX0E+vqxKt0wjO6zlS0I8AMegPBdlGg9slZgyxC7SQL8NFJsXs0inYp0QREMwYIfy1DrYgO1AmSjo0TklW01cBwtcLagLFuaPy/OXaQ+eM+vKof8dcVVxYj9+WbX7Tn01MHPZMR2yubhdlmF3Kt7U3gTx9G8UiCzpkJwNIQGQeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8XCSWAGKsaxlEe8xd6WIhc02r3cmsLbUTexZDW7dqLQ=; b=hm90Ie7Nm2PrEnilvPUTsySgtmLkXQR6aG3vWu3g9CeFg58Q7SmtBAHjurrjNdn5YBxlcg1sU+qtwA0XZ11bhoCESuVZL0+y8SedDoXM+Zo6ztpW+xoJ9jor/Nz4iX9+49TqxDl2wFtsGICTNgxt5D+ggEXkJAq2yIJA7TWwk236BtreNaU63Ye3RV/+ud5Q3xX2DX0N/iojyvnPBIhl7Bo9kY75NxMLQzemUX7zu7icVVfujwYxfjfZLuJ2zifAA1KI6d/F1sISlhfnuMaiN7WknOMrVhKz6AAZC+oENFZUQ1sO73Puv9clUKJR/Yw3xqeZ3rNSnzJA/mlsrBOHLQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; From: Andrey Drobyshev To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, kwolf@redhat.com, peterx@redhat.com, andrey.drobyshev@virtuozzo.com Subject: [PATCH 1/9] scripts/qemugdb: coroutine: Fix selected frame leak on error path Date: Tue, 4 Aug 2026 18:17:35 +0300 Message-ID: <20260804151743.937694-2-andrey.drobyshev@virtuozzo.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260804151743.937694-1-andrey.drobyshev@virtuozzo.com> References: <20260804151743.937694-1-andrey.drobyshev@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: VI1PR09CA0148.eurprd09.prod.outlook.com (2603:10a6:803:12c::32) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|GVXPR08MB11713:EE_ X-MS-Office365-Filtering-Correlation-Id: a3b6fc6e-1fe6-4135-4f88-08def23b8dd9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|23010399003|376014|52116014|1800799024|38350700014|6133799003|56012099006|10067099003|3023799007|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: pBns4caygOloFCmZBIFXR4Gv4nhhMgIjWi542WQQALBodX2wDEFkXzq0GrAF9a1v1dDR+U1TfeYn/7EivdThXhAdLsTG8Fla+AfhMslKSTW1tDLlRkmB+HaCPV+rAgLWNAZt+foC+g6hLYRu2kKBCnBEQi29nsVrGN7XWf6A3Nxx7k8yj+C5LRhCBREREoE/UnABM9bKN4AFYPtErCoPj7U+5+fDKfJoVxgWVBq2FHBNH1xdINKnLkr+RduhbdahEA9u9SmilYnB88N6EqEO7J6JDjGtURCMNag4fHPCOl5bogMh8+7C6J1Yh4AMRYCWEgObn5ZaR8yYfZIfKQFnCjF2KJR+VRoPgs75rO1tIn823dytqx/rDeeqaj8HHj+2xk3CrOLU3Twaoqd80tmt02vQ9OnR7vWMYFO+zYAzZbgPwLrQiPGLGPXeCLGMhsSCEC4qreEu+057aWcBLRH7KKizuKAg82jrL3CxlJmfOmc5tHyRGKrKegTBu1N2bS7P29h/5tudQu2GLT/hJaW8NcTsaOPX+VSuxWu5tlM/m+QTzDhUveyx0fnhPeHZ+XPyxnppcrSpd77cwUkgBtwsKQu1TwEdb0mL2uyAr17A484RU22obWr/TzyowCRKvZtpg1oHSFWoDMBYarI/4sp2FQhVnYj/7YTABZGhzTFn/0/H0y1ueNAVZHcZFWeK8rhDEGXef6r+/aMVE3BY9Yys5LqBSGQFREW1YqQ8MRWGOTU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI0PR08MB10656.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(23010399003)(376014)(52116014)(1800799024)(38350700014)(6133799003)(56012099006)(10067099003)(3023799007)(22082099003)(18002099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QqIKsOKp55/+ohQ13entcLbOm6ZPHj09699/ZKGocECeNltIgyKc5NBGOuT9?= =?us-ascii?Q?LI49yjWUAYs+Yt986KVY0eNKlSqm8436itAEBHxgOIK7+r30F4jsfz2zrCWj?= =?us-ascii?Q?/cRreXSOlkknKvMrux8/HHbRxTmULFvwfSs9cxQcdV2gSIY2AYRb71kEefk3?= =?us-ascii?Q?Y9mriM7RYW0QAzpt9PTX7CTBVs+vCuKMF7lK7UOOzUw7dqiLJPuNpJ8G7Zcl?= =?us-ascii?Q?CGKvXv4CWT+HDpHQ2kT1CYA+QAP+hbpGbV3CNoYxa2e86z3Ibyic3aK/gLLf?= =?us-ascii?Q?+7MhgbUAOPdXS0an7Axr1Adit6jlCiel/WCEHSG0NQNWPGCA0T7mZ53DfWgO?= =?us-ascii?Q?1qaYVObxmMPBNoMnYZ/2EYPgxWV22Akw1kqLhrX/jwd5qGMc8/eB26QLjeE3?= =?us-ascii?Q?nkGd0Gr72lREsFS441d2EclTmYnzfbmKOCaYXcfJwfmXdo42VtZ5daBrvjKh?= =?us-ascii?Q?ErKVXmP2VX5oaMIg2r1TlfauPJQyzL8lRcgEtP4XX6A+iUcniJqDIAittuqs?= =?us-ascii?Q?+1VOpGeW0AlNO92mO0nehrM2bn0noJ2b+XwPthuxserDk9i4wP6Vq+pjXFnC?= =?us-ascii?Q?bUPstuLzs8MA/BpJBFysBdpbVdT6IrLEszUWFwoJ/922HpeXjh6vyah6d/XO?= =?us-ascii?Q?htxBYTKNVbiaimdqXBh1+6YwzOXrBtTLdtbBjz0J8gzgTW9mZr+sktCaRwJ6?= =?us-ascii?Q?+gJ+pV0yJx4qxGQXh87uWbVPrczXnHzw7/SvDHCRK3OgYkhsXCsQAR8BwXB7?= =?us-ascii?Q?0YxJWQO2HNyviWvk/efSxXQuEAKbupCLRD6vPBXi3IWNYTs5pSpPgh9xzQwf?= =?us-ascii?Q?FeNd2T0z0M7f/6xDNyAROW2e+PPnTuEvy2iVP2kxiOosj6d0veaaXRVBgsXF?= =?us-ascii?Q?vXRVYUwAe9t9r7mjTPI2ADToHMjQ3zMOO4o8+uRS6vLHFMca/bzn8sOGeSY9?= =?us-ascii?Q?7sdFMremz/r9O1oRM2s4MqWU1DhNenvjsZ5osnYt1kw1gBbJCJPF3ZPFlVgh?= =?us-ascii?Q?9wlJKi5+3pAJSLBhFnQrndt/yfegp80mJTIrX46Q1SsoDDzkcdqEbu1lUVZt?= =?us-ascii?Q?Fvo1fX2vgN5Ai4oSvqizjWk4cHgqjp+h0pvnqPE3WmKdy6aRfzBemplnCkGp?= =?us-ascii?Q?6QIARW3r/l2wVxoxHI5WpkWExv0xgsaRQq79A89rmg7gJ0DFusS2kxwEZJBV?= =?us-ascii?Q?f3LUWifpnDj/FenFhFmLLT1kDW7vxhqdzO0hISP9GqfjAsmM+++hpoLz8Sxg?= =?us-ascii?Q?QYpa0un0LCZZQMR6TNwJ6veBDd5F3Wp9ohxpFqMAovtW+8t341IcbUNZAGpU?= =?us-ascii?Q?iD5N1v2mQ+RJ9xAnSPglcgH2s+n2w6FFF44GPQ5arkI+kxrcWP1hUpv4kf8m?= =?us-ascii?Q?uEGgKSro/yh2AC+hcBPdaCBIfq/e6iwlyQUoaEqh9bEsxY4Ncl5rTkMokRvC?= =?us-ascii?Q?I/+zywbnRctkk8L2uedcHBvoblxLlqJtQskK7GvZiB5vVKDynHgNNMwfVvZT?= =?us-ascii?Q?Ym27W/Nwycvs7nFnaNm2mUF5wEo9S4npZo/70w2JvOw2tpoEdv5t9y9rZZnL?= =?us-ascii?Q?TzUUhULBncwfjXrlKifoKUSFJexkMz24xb6W6JFfkt6H4TDuhvA+MWGbR1BM?= =?us-ascii?Q?Zo3BtcPw6vSb4RxiAV4GTa9O2R8DiVYmkw6WrMmWCcfTcJojBwUuH6wlzEAw?= =?us-ascii?Q?Ky/T50hvHCLOOR8rAx8OXG7g9ASDmRRNnCa5+eUUiRNAq+KajGLba67jatih?= =?us-ascii?Q?MILWEyEYirDY2Lbnef7nwcXxDshkoqY=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: a3b6fc6e-1fe6-4135-4f88-08def23b8dd9 X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2026 15:17:53.2286 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ljuLDnwrOf67VdqRuToqfL174fsY4zHq+w7n0BdAvj3SXfRgOyeNgAqOmpt/U9rPHef2ZuLMnkCirydWp5WWQ4Vx0iwN7MDTqExzLoecvpg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB11713 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c200::3; envelope-from=andrey.drobyshev@virtuozzo.com; helo=DU2PR03CU002.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @virtuozzo.com) X-ZM-MESSAGEID: 1785856741974158500 Content-Type: text/plain; charset="utf-8" Currently, whenever gdb.execute() fails and throws an exception, previously selected frame gets leaked. I.e.: (gdb) frame N (gdb) qemu bt # throws exception (gdb) frame # shows 0, not N As a fix, wrap gdb.execute() commands in try/finally, so that selected frame gets restored no matter what. Fixes: 4cbf8efc5b89 ("scripts/gdb: fix 'qemu coroutine' when users selects = a non topmost stack frame") Signed-off-by: Andrey Drobyshev --- scripts/qemugdb/coroutine.py | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/scripts/qemugdb/coroutine.py b/scripts/qemugdb/coroutine.py index 29f57ae84ed..d1e6722d14d 100644 --- a/scripts/qemugdb/coroutine.py +++ b/scripts/qemugdb/coroutine.py @@ -265,18 +265,21 @@ def dump_backtrace_live(regs): selected_frame =3D gdb.selected_frame() gdb.newest_frame().select() =20 - for i in regs: - old[i] =3D gdb.parse_and_eval('(uint64_t)$%s' % i) - - for i in regs: - gdb.execute('set $%s =3D %s' % (i, regs[i])) - - gdb.execute('bt') + try: + for i in regs: + old[i] =3D gdb.parse_and_eval('(uint64_t)$%s' % i) =20 - for i in regs: - gdb.execute('set $%s =3D %s' % (i, old[i])) + for i in regs: + gdb.execute('set $%s =3D %s' % (i, regs[i])) =20 - selected_frame.select() + gdb.execute('bt') + finally: + try: + for i in old: + gdb.execute('set $%s =3D %s' % (i, old[i])) + finally: + # restore previously selected frame in any case + selected_frame.select() =20 def bt_jmpbuf(jmpbuf, detailed=3DFalse): '''Backtrace a jmpbuf''' --=20 2.47.1 From nobody Tue Aug 25 09:50:53 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=quarantine dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1785857034; cv=pass; d=zohomail.com; s=zohoarc; b=PVS49c6KYXs3mL+7o1hc6Oq2M2+rnrW5wmo7VM2Eq00QKyWiTViK3cCyV3iW3MEEkm0baBmBDBm7DGLZwEc2ZOo9Gkv4fysAOjcxjYhN6Gs7Kn54YTVldasKY1JBQZoHAPEfkDl4OBo/9yO0OycWDltFgRGrhEO5kApVXj8Lsuk= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785857034; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Xhm+DC9Bnesz0E11hOU1Zettghsj+W9WuLmdOiaFuZ8=; b=CL+vaVzP3FagAnbuPFPFMb0CQ+5CHj2eSwfsGN8xV8/fc9rHeiYPaoz0IstXxWZM+KvcpRcchn/PrpFQec6geRamd6AhGx/J3ycHWurgl7V0XZuJlbpRDAX9BcGs6K8s/9GNRdjudK+LM5gEXdldhwCYXgFZbL7Lo0OxBlrj6Ls= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1785857034353979.8395688322606; Tue, 4 Aug 2026 08:23:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wrGyr-0001a3-A8; Tue, 04 Aug 2026 11:23:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wrGyq-0001Zu-Ds for qemu-devel@nongnu.org; Tue, 04 Aug 2026 11:23:00 -0400 Received: from mail-westeuropeazon11021090.outbound.protection.outlook.com ([52.101.70.90] helo=AS8PR04CU009.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wrGyo-0005LE-Q2 for qemu-devel@nongnu.org; Tue, 04 Aug 2026 11:23:00 -0400 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by GVXPR08MB11713.eurprd08.prod.outlook.com (2603:10a6:150:2be::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.18; Tue, 4 Aug 2026 15:17:54 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%7]) with mapi id 15.21.0270.016; Tue, 4 Aug 2026 15:17:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IjwmTUGUhgNXFgn2hlIdu7/g3NYbSHh1ymiZSUvEvcBGmyIq+HJhc1fe/tIIACxoHfiJRX4SLBdEq1yWUcO9zDY5oYH7kWbJixW5gzWuiZtBcluJviJAoa/K+kLxMabQjG8XwcDYXiaRoZaofEsnFW4FrtFaiiqKmfQNnKhXWgvtjPpHzADcxyS2iv8B7Tv0gdRrwRv+2r2UmUTejDLJTyl9qA+QfRLxz4ksGjpriPKrTI5vnjCfSP4hCc7iZ79Rwui4dvoRBQnB6h/CPrm789AkT44IAveV7JYi3EzQhWGYOJS21AZvb5xqHFDsa7wJ3pkMoOsn6raeGGtcJsDIIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xhm+DC9Bnesz0E11hOU1Zettghsj+W9WuLmdOiaFuZ8=; b=c7VclPBBByFDKVyAx0WGoZQwMIotMmMl2FSWZ0qKuzG+vRyv/oLUiNRkRq5BXjfKvOGNckjTG2s8aScjdNWDN1RIjgYC/B9ws8Mhgo/pohQqMe+P4xH7xtFvmDU4b791jRaxR9GeQwAThESHemG3HkiE4U+bFJEMjOlBuG5GW7m4oyOZYi7U/jX5ve5UfUSOyY5AGYWc5pY19UOvrOKJ4mN+X/+mqrtD6+Te9XDC9ORKC+3e6tmUIQOmj2SNyYCEZ9oYIqlIkgJUZr0Msjh9TyV1zTq8Oe/AlIFmLoabr0Pe7Iy21WmOaXYRC2M4VdPBxfyXe5TKwNEkH2Jy/n6MHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xhm+DC9Bnesz0E11hOU1Zettghsj+W9WuLmdOiaFuZ8=; b=xgDaEXNE9/bcynzPJvYPkbQ7UXmXsiFEGSKlK+qoiqu4j932ELU6/8/Dtje5ygz4a1Xq7x1DXQmSUm5vfeU3PijRpeeUh13Q6+mQi3vmupkjaMeChYZoynmhiiqfla3di8cyCpgO1Kee8LS2HhMBehTHjmnx266k/ecdG8rdxkQVMTiYftueaJ3Mn+TPKCCPoCgUnDlnsqkoDrZaRogtLY4QhKHKWKv559+5T6KN3iwymJ3gkrGOoq9gK1DCrcGQ+5O83kp+muQLqD+LfTee9x6FU9dGuklydHETGJkGOB/KhQE69o0LOc3+lRAqudSF+KabGHeKEceNzivCxA08vw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; From: Andrey Drobyshev To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, kwolf@redhat.com, peterx@redhat.com, andrey.drobyshev@virtuozzo.com Subject: [PATCH 2/9] scripts/qemugdb: coroutine: Get rid of fallback pattern when dumping backtrace Date: Tue, 4 Aug 2026 18:17:36 +0300 Message-ID: <20260804151743.937694-3-andrey.drobyshev@virtuozzo.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260804151743.937694-1-andrey.drobyshev@virtuozzo.com> References: <20260804151743.937694-1-andrey.drobyshev@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: VI1PR09CA0148.eurprd09.prod.outlook.com (2603:10a6:803:12c::32) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|GVXPR08MB11713:EE_ X-MS-Office365-Filtering-Correlation-Id: 43921ee0-479b-4d00-e41c-08def23b8e46 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|23010399003|376014|52116014|1800799024|38350700014|6133799003|56012099006|5023799004|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: dx4UQN/7SU3QOkEYQXpMbRjHHQotDFyI7GmNXnrc2+NgPCFxy/Ae54c4+AvDsuy3Bn+uA3ccJbOb12zBIV8+foBdy9OLKwQFTV9F86N4K6WArZjDHkCRSFnAqn2P2FLgXtsw1mwqTFPCC8y/zo9v4klUyal0xmg9Dn+L8KyFzrHIYLh194/HbIFK/yTSLvxOxNxqY2hDUy3GJus+qtG24CBWP6gZypVKDyu7e12ElzjtZONgIfkkO9Lev6ecQ08cMwhQ9xIkLN9no6WVhPr/cCWaCDsBMAYcf3qvsSWth8U/pHTLJE6EYyGMPLhsr9/siD68GAqp2QHCvtfMzqrWUdOVTT+1k4I7sWU2+VNztF9k+Z7uFwafUr4Ab1jJcQAwe0b0Zk+QBCrmrw7xSwteOBMQE3ODZMddr2kia6cjyQ7IcbKa7T/+WO1idQiJxCGBjtfCsL74tcGtfl///rSQ+DeLDm5lU7fZX0+gg6BQoROer+HRRWcKyBy+7uV1b3cbqgycQNdmpHnM7h1WV6K/eaVhQZ7TAtYcnAWhqQIAxMgZtSchNeTPkM8AEc5yl7qDLbWmWwzNL1P6BtbuBXw5P4eGv2kmes8z9AT2XTP8nC3TcS8DxgNR1LePB+cgHxencI0HdhN89HIt4qZheBFu4Fxi1NzGOxJxTv5Vi449deLX8SjwGv6xMzc8MTQCONtzJgQiGr6/qcl0beyxbBKNXatnV7/FUpHuo2NdakLiLG4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI0PR08MB10656.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(23010399003)(376014)(52116014)(1800799024)(38350700014)(6133799003)(56012099006)(5023799004)(10067099003)(22082099003)(18002099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bHg5AF4DiPG6F/5mFfcHy9P6PP6nIYgHzvYkTvmXU7GDSr5GbguVbmV84Mhi?= =?us-ascii?Q?9UdCC3geT4Ki/UsOU0t3+1wxYfplOKG5qOZs79chLwcWNRowtBHMq1WOo68P?= =?us-ascii?Q?wOYXPCBZbRk7G9+28+Z4ZtfBmUQZSbiETVMEWgFJemkNWjdWYhuyiRtp0EnB?= =?us-ascii?Q?ip2UqrxsUT1yfXbGoTFhPw5LjkYEi87Si+fBQj6L+sqb4CCnKeOzX2zzaSdF?= =?us-ascii?Q?gdIge2fVPlhqosbKUFphnVEXaEkZXIBbMkMXwv2KXxWFQ34gEuRxHpaCem8z?= =?us-ascii?Q?3HywjO/4crt77krURq42VbQVzM4giL2lTSM4ca2EPpTBMZKkBD11cE61eRmU?= =?us-ascii?Q?f8E7N/Qkv9bj+1OERAeYpZD0l6IyrpoPNEzdM6HDFc1z7N0qb0t25lTOAHSm?= =?us-ascii?Q?J9iuahT1Jsg10aWPtWPzIAQUGoq0rmUPkDR2+B+Xactr25wTn4Efuretd9ln?= =?us-ascii?Q?pObXh/2k6VWH6muFD6PoQKn/0v877ghXLS7ElZzNfs+RH2yb74bDpc2R5Nlq?= =?us-ascii?Q?svLGFJ9WcfZOz0P9rdlBnvYKO0E4fChotvLdT6WOMCq69lKR50Nk7XgD7RYx?= =?us-ascii?Q?7n+e0Bu11HAgw8ny07Wf8zJ/vtF3t1mwFuj2u6f+Mqhn6PTSluVMtydvkvd8?= =?us-ascii?Q?qxbZ/tknI/4ixrgx3BQNievKRSirCyMRmDRGqyL7ZklA9fao8RykEsIjpxah?= =?us-ascii?Q?Ai329yVXD2IGchux9+AAg7gIYxFzjwMELdK6lxt7qMP8zUcIihu0CTVml3Am?= =?us-ascii?Q?gR9dYdCR4SFvHKGxlu3rr0MZHniQc+WzBluMjn56UDP8u8y4rL2Aim/JyjpY?= =?us-ascii?Q?J1M6IBRf8QPlarF0eddg2j/qfHkMr/afTmsPtp2VFxSLqHu7SYkJx8n6iiAA?= =?us-ascii?Q?dKPYq+f85r1uyExGMIbK+XKq40C9mneosdGW0nu6rmgotAKNPsoxocOoMdzj?= =?us-ascii?Q?ALsk8Uus8xbQhkaYvXxFiBBa8grpZgibl2ubTkaJNCyR+XQEC/80qT2Arv0A?= =?us-ascii?Q?3Qv6MEqeyuKO3FxpDLkiO6Y1S136mH1pm7ukDLtu2fiMUAblphT77LbpyWXC?= =?us-ascii?Q?mTwpqNhHZZUTuei9ZZmG+GD1PgBHjcf9BiV638bj0EXl3MQNRnV+pAEpg6Yx?= =?us-ascii?Q?MbBgxyxzRXQfJxUIrvD3U4+FHwBqP7CbvrO1HIVuV3fN0dBm0xykfnvQHygj?= =?us-ascii?Q?jcBwGxZ+2XWy2jTw+hVDMGgc08num6qPJFPMl5VcMXzNWoLCOmkmeqm0ZO7b?= =?us-ascii?Q?HrEDk3MUyZutlc/CRn1cFDcZJE6Qw+mun6LDkdaY7KrkxJ2Emqi4zKQOorYS?= =?us-ascii?Q?RiSe+1tgQZfjH8dDcyYIIujxfr0z30Doi31mglr3DJdS77KNImrtVAQJ+Ntb?= =?us-ascii?Q?aQM1v7eR6mfWcPpFhRPtVZ1zuJw/q4WS/V+FSpgvvWFKlp6BNZdO9uNjMmKU?= =?us-ascii?Q?B0pFwkMLaBDHi5rKmmD4qKZVGqq8LJnPmZ4t//MA8MUmBnrQwzZUKySWrAWg?= =?us-ascii?Q?WZucwxBmW2/C13CyXDfXHqmdcoPIiN2fLeJJEBtbAsdHOCRyeWPHMHy4AE/+?= =?us-ascii?Q?3Nq84pgAsH17xUlBbmXTQVvq4kq3jDw1ZSrHJMp6RpGQvSxoTt9csALwBrrm?= =?us-ascii?Q?qa5ME0LFIoLEQxn7h/f3K3goUnjXFSsUYA+GtgxVKsV5YW9RVwD6wTjgMm9U?= =?us-ascii?Q?KkHMIDIO2B36uZcxN1fDuj7LGtoJOS28ktLafLCO62LOrTaXJVPhLvgi4Gx8?= =?us-ascii?Q?iEVn/2QZuwQ0r5UQDRyBeyn8FZgVdes=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43921ee0-479b-4d00-e41c-08def23b8e46 X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2026 15:17:54.0427 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Zaao9xsTYmR/pc4idGpQW2h5RnGiMLVw4Ci7Hg+I0Fcw94z7KVWnmaOj3s0Gx2bL/pWOXj7OoizRIV1bPyQBp8ctzLSHyjb1IjtFyjUhTd8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB11713 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=52.101.70.90; envelope-from=andrey.drobyshev@virtuozzo.com; helo=AS8PR04CU009.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @virtuozzo.com) X-ZM-MESSAGEID: 1785857036005158500 Content-Type: text/plain; charset="utf-8" Currently upon invocation of 'qemu bt' / 'qemu coroutine' we try live process backtrace dump first, and if it fails - fallback to coredump. That causes us needless work and catching an exception. In my previous commit 42f3c143c3a0 ("scripts/qemugdb: coroutine: Add option for obtaining detailed trace in coredump") class Coredump was introduced, and each invocation already calls init_coredump(). Let's just pass the result of this call further as a bool param and make a decision based upon it. Apply the same pattern to obtaining coroutine pointer. Note that we deliberately lose a safety net here: the bare except used to swallow any failure of the live dump, not just the absence of a live process, and silently fall back to the raw unwind. Such a failure is now reported to the user instead. Signed-off-by: Andrey Drobyshev --- scripts/qemugdb/coroutine.py | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/scripts/qemugdb/coroutine.py b/scripts/qemugdb/coroutine.py index d1e6722d14d..d3f31bab9fe 100644 --- a/scripts/qemugdb/coroutine.py +++ b/scripts/qemugdb/coroutine.py @@ -281,20 +281,19 @@ def dump_backtrace_live(regs): # restore previously selected frame in any case selected_frame.select() =20 -def bt_jmpbuf(jmpbuf, detailed=3DFalse): +def bt_jmpbuf(jmpbuf, is_coredump, detailed=3DFalse): '''Backtrace a jmpbuf''' regs =3D get_jmpbuf_regs(jmpbuf) - try: + if not is_coredump: # This reuses gdb's "bt" command, which can be slightly prettier # but only works with live sessions. dump_backtrace_live(regs) - except: - if detailed: - # Obtain detailed trace by patching regs in copied coredump - dump_backtrace_patched(regs) - else: - # If above doesn't work, fallback to poor man's unwind - dump_backtrace(regs) + elif detailed: + # Obtain detailed trace by patching regs in copied coredump + dump_backtrace_patched(regs) + else: + # Obtain a non-detailed trace by poor man's unwind + dump_backtrace(regs) =20 def co_cast(co): return co.cast(gdb.lookup_type('CoroutineUContext').pointer()) @@ -353,7 +352,7 @@ def invoke(self, arg, from_tty): =20 try: bt_jmpbuf(coroutine_to_jmpbuf(gdb.parse_and_eval(argv[0])), - detailed=3Ddetailed) + is_coredump, detailed=3Ddetailed) finally: coredump.restore_regs() =20 @@ -390,10 +389,10 @@ def invoke(self, arg, from_tty): =20 gdb.execute("bt") =20 - try: + if not is_coredump: # This only works with a live session co_ptr =3D gdb.parse_and_eval("qemu_coroutine_self()") - except: + else: # Fallback to use hard-coded ucontext vars if it's coredump co_ptr =3D gdb.parse_and_eval("co_tls_current") =20 @@ -407,7 +406,8 @@ def invoke(self, arg, from_tty): if co_ptr =3D=3D 0: break gdb.write("\nCoroutine at " + str(co_ptr) + ":\n") - bt_jmpbuf(coroutine_to_jmpbuf(co_ptr), detailed=3Ddetailed) + bt_jmpbuf(coroutine_to_jmpbuf(co_ptr), is_coredump, + detailed=3Ddetailed) finally: coredump.restore_regs() =20 --=20 2.47.1 From nobody Tue Aug 25 09:50:53 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=quarantine dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1785856990; cv=pass; d=zohomail.com; s=zohoarc; b=OrodWVyzFwPDlNWxZXq3kneChPhrtzQXmfHswzcNoboCQgJSV9ul90RX1gxqgJcNg3gJYwA3SNvJgYLvisBXYF99iaem9tlsMNpgKB2jI1u3gFiHIipm7iWQB6WvKo3STGZ1RO5KoKbRbcNKIrBnZoSQrHdIk992x6uQR1ldf14= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785856990; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0JKt7Fv6D8ktmtyfDf8FIxaMiq78r4n0C8q3HHoz7ag=; b=GCR3zmXN2K5saKDespAJ3OyLLAtCb46Vx8OOI+V0N3OOll7d6fh2iyoFRqi6m1THl8X5QEHU26/lERurBEWa/tp80Xwt9zS3v842UObABC+FjpdS3GmGJQvv6CamqSZUIJe19CcwgYoWVr019p7oJelKyNHvFEFQbIca+Da+omA= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1785856990132260.6023963542001; Tue, 4 Aug 2026 08:23:10 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wrGyt-0001b7-DU; Tue, 04 Aug 2026 11:23:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wrGyr-0001aY-U4 for qemu-devel@nongnu.org; Tue, 04 Aug 2026 11:23:01 -0400 Received: from mail-swedencentralazon11023103.outbound.protection.outlook.com ([52.101.83.103] helo=GVXPR05CU001.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wrGyq-0005Lb-Di for qemu-devel@nongnu.org; Tue, 04 Aug 2026 11:23:01 -0400 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by PAWPR08MB10317.eurprd08.prod.outlook.com (2603:10a6:102:330::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.15; Tue, 4 Aug 2026 15:17:55 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%7]) with mapi id 15.21.0270.016; Tue, 4 Aug 2026 15:17:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=P0eccT6+YUbX731RUBWob2siz1hu7BLjqKtAVlzH9eiJG8PbhEJvl9oJCwa8y33MA8BX3oDLYWizgarihKmaGrvNyf1fAOXB3gnzv5+SoJW+XyWqm2G81POhzrPN0bHoep0v1udukyM7/2krQ6o8rw+yf7arNTmKYZF2DTSQCmUO2u5U/U+821BDbrO73VTh/zd2lCSqyO1d+WILjlYSznjwFLZSLqe7UUpEaRjBLX0gbcnXD4qTsN9xpm0rld6TpNX2ozVncNKH4TAhURkWFt3X+Y8qxGXqWV7mn7tQfJtSIFwuQguqX61mMXpNbPpEiIbtaWbuMtRSH8QZCY+WEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0JKt7Fv6D8ktmtyfDf8FIxaMiq78r4n0C8q3HHoz7ag=; b=CQChImUMtEO+LQJ9m1A8SM1IJRMWzB47pE22dM13w5m+pPCcAXZbb2uvgfKItduyPGbsfhfMIKJbd74CaNIiympejYs+vNTryej+bZHGNLYvc5noAfnCq47PZhroTjFvfY0CC8Bf28qWVv8a63whMTYd8BouNThW833AJQpBQlXFNKVjRwEP126iEkTvfAOrKZ6187O2B6K4OGOMS36W0wG/AP57cbZKG8jajUQNlr0fVXiDXJRJ5wB43iyaUq6/PA5gX4C7TVEg7TQ0NJk9clv6mKHR4MrOz1U+y2YfjjYLSYepihFX+9AfY8Kpb1GYsoJvWfCBhJfq7EksX/+llw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0JKt7Fv6D8ktmtyfDf8FIxaMiq78r4n0C8q3HHoz7ag=; b=l20DJOujEb1jhi2cQYaokIWH9V5l6OO08onqcrkc6Q2UHVn1i42xw/UCbOhTvilCTFnFxvqzC3D3XqybOj+5B6w54L6FeoJyanzqbQxIKm50DkBxoWD+yH78xD2l8x206GWJlQqkJ/meLK9ONsTmFQ5gLRuTiHOCvb1lAJNjv/S4rnAq2ciOnJYrnJyIl2dsIsU8IGhi4hiHHOkl3p5ZbFA2jr/cjFIK5NY0K6h6tX8vUTbLZ57KS0wgh7eZm0jUBCm4EkecmsuEUmsj7AQDp2GfAX31cZrYX/Khkx/ODRdnnZQDgH++his94kSwm0hkeP07gjKS+uf/gjLtOvWGLw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; From: Andrey Drobyshev To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, kwolf@redhat.com, peterx@redhat.com, andrey.drobyshev@virtuozzo.com Subject: [PATCH 3/9] scripts/qemugdb: coroutine: Only attempt to restore regs in coredump Date: Tue, 4 Aug 2026 18:17:37 +0300 Message-ID: <20260804151743.937694-4-andrey.drobyshev@virtuozzo.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260804151743.937694-1-andrey.drobyshev@virtuozzo.com> References: <20260804151743.937694-1-andrey.drobyshev@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: VI1PR09CA0148.eurprd09.prod.outlook.com (2603:10a6:803:12c::32) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|PAWPR08MB10317:EE_ X-MS-Office365-Filtering-Correlation-Id: ea9980d7-64ce-4a82-b7c6-08def23b8ec1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|1800799024|376014|23010399003|366016|38350700014|6133799003|5023799004|10067099003|56012099006|3023799007|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: KmGXX9sTFCoLkaEpGpannaMugpSiKQdnOroiE05191K0jBa07quLgf8LoWL8b+67XSraqiFjOcRYFzcy5yi7XoJeS1lmdREbVBmdeBEGApATzUs3aarYot2NQHyZRtK7WE1h81cjHQGpTwmTpcnTuxMfpY787JLbtOrrhlUtFtqa4/cSj9u/oQiTBmKBbD9KBo5vcpvl4AsrnOadheD0gXcDtaY9UUDinYtLoAW+WrL9/d3aoLv0sGjPrdlzxixwffiSJd5nAm0APThqlQ8Nevb+P1wPk4IoOTRnWVZ5P5zDzAvCOEE4j0eFHqgDQC+PCtDWRC5i333gbO+pEb7QcNIem3eFUnQqh6CuW4Aw2ttwQkFcBZc68I5NI3V8paenuCQ/UC8OMTHVu96xoEizY4mhkHhnQmnHHZm9ge7YGHkZ5/cuLsRJDOuhW1ZPTm5z7j863u81ARCDtjw1uwu+K56UM+BgsB+LF2qi4W240l5LxAuddXGP+8Iz2cnMahN3Q9BOB6I0eo3wkRNGvdAJ3eIu0pNQxCzEUDSBH7itdkG07kKd9esIqqG6/65t26qCEgkC1qmpOhkJjMwQ9CrCPuhKnX6e7uEb1WK4JERDMW0JZnOk/nQkKHRWea/Z4FSjIPZT+L/Annr6IgM3GafCTzOCKPlts5/uXRzAtrVa5VKdXV8Jjw5QfqYoqEa8ahVnbFrnKxA1lrcZHRfZ1NQGrBhNG/3gqaFJN61OA0X+fnI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI0PR08MB10656.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(1800799024)(376014)(23010399003)(366016)(38350700014)(6133799003)(5023799004)(10067099003)(56012099006)(3023799007)(18002099003)(22082099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?F68RnJZwS6ndnCgjt6pFJ2CDfNhZpdPb89Y+zu5zyFY74OfRfpn9YAwJL9BJ?= =?us-ascii?Q?Ea2JybqAqDRyhmRZoisTfRJxGfBwjIf/0MBpgk2f5o72IM9Y7uw9VsUbvXho?= =?us-ascii?Q?0V27+g9Qu2Rb12QFaamUyvVchS4V9h+VOW/akRy+Pt6jbiwo3SfTkeR1hJnG?= =?us-ascii?Q?47ptktziL4TAmRC2zfSLy0DWUpE/hGDtaLFgqmonBlIXL31qfxqG+p+N4t+c?= =?us-ascii?Q?gfdHQvhvYOEGr2qV8YrUUWrrOf+/WFN3iv/PsWsS1E0iePNNsiHasPJva5y7?= =?us-ascii?Q?XOaoLZj63nMRxdpTM6/acPWTgz9K4g0O4QvvkJ2HObojcInVvbpKgMqYxi4F?= =?us-ascii?Q?YFyk0u9M8AWOC3Gf+PA+qWAuuRCw9XU+62ChbjmRUyXu/AdHVEBKawhWa3Gj?= =?us-ascii?Q?rkSF4AjxEGcES9Tz618u9aQOq0C41SLQVkOFkP75qXvDw5APDll3O8CHt6mv?= =?us-ascii?Q?UN59ucCfmpBTt1/O2sahQ7L0j0IeSN6ptioQ86yDBJ4naa/bBfJxLOqlFIIB?= =?us-ascii?Q?En9KiR6EP5x6ZBhEYYZHCuG2fBCu/f7VDHZ3gmfEIHy0/f32GFZh417OoL0S?= =?us-ascii?Q?tGXC6MlCO41fr99Uz3KNwvJm++Hg9dxRQtn+RqSLY+D/5LyeS3y2ky8KLTgl?= =?us-ascii?Q?hSic839eFNDuFF0h0Smd6D5MdSNtyFD+xE78zt8fO3levT4/6BHOTZEgcLvK?= =?us-ascii?Q?HGFpsHpPl48WtHwlZONLRvBbypKlf9nGOY+8K32TUnzTCKc8GBwNzt7TT5ng?= =?us-ascii?Q?7UrPOrXcj5/uM1fWSlmCHEprHBmXXWV83xr3GzUY6MDqjcoIit/EHjWVL7/3?= =?us-ascii?Q?J4N+KfTH1F3+fJIKuDD0qHVNqSzKMoEx5vCY2xf8uxMPbgt5I1S9PyCud0Jy?= =?us-ascii?Q?TriAjffuyHcEtzP3hDIy1yNyCFr+6cuecj/lz5jWiT2nsggG8465vp0+rEA0?= =?us-ascii?Q?tuLErPuyJQ75bziji9nLceWKsQVZ1VG0023DoVm8pPSskqg7FN1/dYECCt+O?= =?us-ascii?Q?4QDjtBv9AHN45tz0Qn6wbEg4tq3fY7bnpaVibiC/4+I/uwoVEDiNzVSR3iGI?= =?us-ascii?Q?9f/piBdJGoDQL/nwDcv+p96vfUTydNVfD2IYp1TAMmBcPmWUYH/Vk+dcKlpP?= =?us-ascii?Q?2dLzyLfyZmvAaICz8Ult11yY47fyK6oNjR2abi94dKilY451/HmNWu8LotdY?= =?us-ascii?Q?wceNBwBFOZ7tKPhRFDhaBrprKOm9sem+/t7KORTmq8/jBL8OG2DN4VfievF4?= =?us-ascii?Q?PzXfy55RpbqIjR81gueTDPV8ldttETQaQ2YTJqzE/cDr+eaARmb5pSK0nbwo?= =?us-ascii?Q?zw9dcK1E4qwK3Cfea5w+z5Ud54xzskhQ+F0uxFXJMkHEtzlkcgccaSOm/FS5?= =?us-ascii?Q?xPgwyWKBriUZ2E+xaZXHOq15CJN/60YeaoWEOVytiu4sTKAz8R5KImRrIUn3?= =?us-ascii?Q?kdm/gnrHD+MBzfi/MnlRih8s1WPYda8q9mnEd3bvZNLbSyErzkoxyVgbQEpL?= =?us-ascii?Q?ewxXZIFcxhqhSXciaB1yUCQX/tEfoLBTsmh7vEeqURVVoqDQrmJ0TEoaEhWa?= =?us-ascii?Q?MCWfrPfJKHIBsYayNwJYKE+a/z/b/c1Jepm3hLL5o4CoYrVf2BX7A/XVldFk?= =?us-ascii?Q?88Ngq8sud13ksJ9S4tXBjhTOvYSSrHE+hs9XOBR8NCjFSGYBHocSU+C+xI8Y?= =?us-ascii?Q?vVw7g/F7ZsB78bb8bgiIIMvjSH7mhJVHAkAgyOPTgiqAaPstLoo7gfQkIO/6?= =?us-ascii?Q?9GFRuBoMVT2mwLZBes4p4arzyhO251U=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea9980d7-64ce-4a82-b7c6-08def23b8ec1 X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2026 15:17:54.7386 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Gw+8ycRuYaf5QHLd+eYS4ZttRr9WMG2Aj63aGvOXK2DW7lQ2+tnwZb5xrk8u1pd+ubvbUKBB8/jAbyweQu/oMrnEn2ntBIQdlBVs8dJjqZI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB10317 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=52.101.83.103; envelope-from=andrey.drobyshev@virtuozzo.com; helo=GVXPR05CU001.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @virtuozzo.com) X-ZM-MESSAGEID: 1785856991690158500 Content-Type: text/plain; charset="utf-8" When calling 'qemu bt' / 'qemu coroutine' in a live process, we get: AttributeError: 'NoneType' object has no attribute 'restore_regs' That's because for both commands finally: blocks attempt to restore patched regs unconditionally. Fix this by guarding regs restoration by 'if is_coredump'. Fixes: 42f3c143c3a0 ("scripts/qemugdb: coroutine: Add option for obtaining = detailed trace in coredump") Signed-off-by: Andrey Drobyshev --- scripts/qemugdb/coroutine.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/scripts/qemugdb/coroutine.py b/scripts/qemugdb/coroutine.py index d3f31bab9fe..649579378db 100644 --- a/scripts/qemugdb/coroutine.py +++ b/scripts/qemugdb/coroutine.py @@ -354,7 +354,8 @@ def invoke(self, arg, from_tty): bt_jmpbuf(coroutine_to_jmpbuf(gdb.parse_and_eval(argv[0])), is_coredump, detailed=3Ddetailed) finally: - coredump.restore_regs() + if is_coredump: + coredump.restore_regs() =20 class CoroutineBt(gdb.Command): __doc__ =3D textwrap.dedent("""\ @@ -409,7 +410,8 @@ def invoke(self, arg, from_tty): bt_jmpbuf(coroutine_to_jmpbuf(co_ptr), is_coredump, detailed=3Ddetailed) finally: - coredump.restore_regs() + if is_coredump: + coredump.restore_regs() =20 class CoroutineSPFunction(gdb.Function): def __init__(self): --=20 2.47.1 From nobody Tue Aug 25 09:50:53 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=quarantine dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1785856720; cv=pass; d=zohomail.com; s=zohoarc; b=D78O0yLTN3GqkeTq/GvFA4Gnf8xQuOMhBp21Wo7Fj+XKkOpPybQEOC6PuEqXNjOTb0lP1mq3QOeC46gp+7u6b1F3kjRA0abx0Ed5WbcXC51dZp+TjeuQvaEYCCqqFstbCgzNA/Lor0cg5ocaxe/xTseHlpPy/uPEEkqUtnCCTaM= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785856720; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=jQaH81j/itw4J82adWdJOy7FUmgW5xs1AypzYSFJlkY=; b=WH4dzn8S1rFFZft3EWu4co2qbyluy1UjiVNXbPBukmM3hM52lqH7Nb8bvJ1mknmBRLUrNraIbO/66RsIrx9OqmB94Ye9rqVan41YXxbQiSNDUGhprg1lyyQR3/n0uIHuUlTAvU2nnGUiPMYIAMAaxVawBwhs1fknfYGYaFvAu68= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1785856720160395.84193309747354; Tue, 4 Aug 2026 08:18:40 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wrGuB-0006cz-LW; Tue, 04 Aug 2026 11:18:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wrGu7-0006cG-MB for qemu-devel@nongnu.org; Tue, 04 Aug 2026 11:18:07 -0400 Received: from mail-northeuropeazlp170100001.outbound.protection.outlook.com ([2a01:111:f403:c200::1] helo=DB3PR0202CU003.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wrGu6-0004md-2c for qemu-devel@nongnu.org; Tue, 04 Aug 2026 11:18:07 -0400 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by PAWPR08MB10317.eurprd08.prod.outlook.com (2603:10a6:102:330::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.15; Tue, 4 Aug 2026 15:17:55 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%7]) with mapi id 15.21.0270.016; Tue, 4 Aug 2026 15:17:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NJ23IG0qC26oTDhUqdHOhHEwVOxcpla/e3Hvvf5vm1hIazFjd0MPa8SimvmSMZi0YFxpw30/Oyxs+lXfBsXOtbZE+DSZ6W6WOoi3WIFUFjgM6Sc9VtukrYWuqqVk+tIqGKNQSWVwBkfMDurAucWN/12CDsPhQySM6KekDKvAP0KPqfxevLQpBt+JwXru16zjt/N4pBVM9qB1TEpMv0gSEfH6IZedrjyTi49GW6K4paH7iP5yuJAeefN6JKFhIYyJuxsi9HkFkDIbMdKlnLkb+yxIk00jhXYyMSyBFCYx9xXpDP1j5dc3Gbwc5HbYcto1qAYJgn2PXXuK2KGsKWHktQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jQaH81j/itw4J82adWdJOy7FUmgW5xs1AypzYSFJlkY=; b=dIWoKNok/eaTtXxukhqSbxlTvhKEXf5kO4EuIE7uiIk6JDva0C6+vjQqz3Vk4Q9bxc32OFhlzpa8pegB6mQcvXzGEcXSdvPHJuw0hubwhL5RAYC0W+wNwQsi2S5RlxRQnd8KfNco5yY9BW7WARe5ENnfWRXuj1gZlxMXON3vACJrofjpWIsiR2/dogeI/5JUeAlj6Of0KeZRJ2Rl4qImglQgdp08h5EZ+42L5T32FxkzPqdIYDHdvTn3yU5vm5yVyuFN1tvAjAbAqZSIcET2njIUmhYfKJMgz4iIsQ5z1L+e2KmUONXYM6g0oEycXUTK+2SgkoBr/OFvUhyrdawSoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jQaH81j/itw4J82adWdJOy7FUmgW5xs1AypzYSFJlkY=; b=r4wdYWfLKqx79hUnKuJ04fa+4LAY8nq93swDGPszNqPQ/v1phk2kRhYtWaEgqj7EvHiuCqJPlk1nUokWkd6Vs9TxFzh3k3WQ/ibhFzu59Jyo0FV74MFpl3cNOmJvM1ACaMotGug3zuQEuuP4UQ1CrTwIBGkNmSV/NLnVtAlVTVz++OGdfpzz/PyNAakkFa+35zGQs4i7/rVzBYfwYWQt3aCvJtAaX6yqeBYnGB5BW2NFWMWfrx2cKtdlwmkV8Woo9GD91Vs7zj4CAdg/nlZeK8Q8dDWEVt7wiTbFIPk8nT4bfbO6PoMmD6G3S+ztvmROODsfHcg+jbcZakQzhEK0dg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; From: Andrey Drobyshev To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, kwolf@redhat.com, peterx@redhat.com, andrey.drobyshev@virtuozzo.com Subject: [PATCH 4/9] scripts/qemugdb: coroutine: Don't unwind past the outermost frame Date: Tue, 4 Aug 2026 18:17:38 +0300 Message-ID: <20260804151743.937694-5-andrey.drobyshev@virtuozzo.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260804151743.937694-1-andrey.drobyshev@virtuozzo.com> References: <20260804151743.937694-1-andrey.drobyshev@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: VI1PR09CA0148.eurprd09.prod.outlook.com (2603:10a6:803:12c::32) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|PAWPR08MB10317:EE_ X-MS-Office365-Filtering-Correlation-Id: c7adb232-c9b3-4ebc-5752-08def23b8f1d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|1800799024|376014|23010399003|366016|38350700014|6133799003|5023799004|10067099003|56012099006|3023799007|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: 1YIp92tKBmVZZPvRWXF3rtoDzgpO7Xz4uVC7TkAz8KLD3DxQ+S5i5RUMPA45xduXPcsrt0UlElUjPs3JiacPhjvArvhPBvBm8eIp5xWiO2r7mjJgDkFviTPWLWZo6njenHxrx3qOOOO0I+oTiB9hspEyjg4cr5v+JBiIm4MBX/C7f0kfkZWSScLHFzOQeCu+Kb1m/Bp8ifXj8VHw8oTdDh/QxOJOijOto+kyeppa55/HixCoSwaoyw9OEVaA9ZZKG3K1O0dzHuNz35+rJdpOGcuUtdkyDyFPi6LzvQIlaltd3yPRxFfiXWK3bpTnZDcVdr0c3KMzMDESEIi2qzrOtawfpZqyoipYuWHW4RFVfJyC/ZxEJUYoG5heFkoW1s6J7lqYE09Z9W8LgdLWf2rvppmriS2EH64x5XELrY41PB6owx9PIW2iTOlJnxpidnJdtLE7wq+1oHfIzn1dWs2gMN7G4TjW8UQAjV8xVmVJpkh7E8JxZyI+T5HstBB9dGBJsGkqAgjtzF/SRja08nAbLILr0xPrtMSzRhYEjnUqv/mskOnFihV9FYbj4qKFw8yWju2MiwgjTDAyL7ea4qUD/HRiprtAE8+UQazzL7gtDuDe0KZTAFq9VYwFTsPuXTbTW/FIPCfxHlN5XK3ze2+OGe+JJj8MVUJzcjJlGzlCRKs8SQ4ixdTxewOVwJu2BXIu0faf5e/IfjX7C4QmrlttVkVj3TZPsFRXTcQBztlViEw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI0PR08MB10656.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(1800799024)(376014)(23010399003)(366016)(38350700014)(6133799003)(5023799004)(10067099003)(56012099006)(3023799007)(18002099003)(22082099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Wy7BCS4ZBqCo9GvocqYK2gQxU0w+Ex7PPWO5naEnX9Emz0vIIKh3N8QfkXM+?= =?us-ascii?Q?gxggEJglWVcrcNF1b9M501s44owS59Jfq/o4IwFJuC08E1arUoZqE7TNzC/8?= =?us-ascii?Q?0fKe65j2u/SmKStn5o4EiOMZY54v4SFm1aa4430rBhn+NmNHbzXZo1/mQZch?= =?us-ascii?Q?GvQtpoxBjNNDLj39H+7O/OLAcKF1Jhp3EN9+Ze3HTKPDKF2YgsRtEI9rIIgn?= =?us-ascii?Q?hthGxJwpDEI6SAfWQqRl0crkNfpstiAIhLc/S0rlmwwV4XH9vaJnSaf5ZV63?= =?us-ascii?Q?eSxkVKalCHc9l2rzZBMeiuKjS/8Ch0xFVWDpbSioszNrI5eNvmFknxhDbWKz?= =?us-ascii?Q?7mPUSIjgQsUYVAtsHxRn2lPyWjJdlmAoNO6Gw7B0wyMW/C5uc73jNRaM8vod?= =?us-ascii?Q?FmjIYYmMQl6Dp7TDtWcc7dlHgA6OyCiIZhjFKElJSLPKGk84hyDpisbh2wlA?= =?us-ascii?Q?NofHmI8b0ZJid+Vs12eq3wo929Aycpmi1hRcjvi1/Q5LDu+6IVx/GplmBvos?= =?us-ascii?Q?Xst20NFZ5qhkjiciX/izbJxtX4VdVSlIRKLxvg/tK5puUC55a0bTIAvTzcc4?= =?us-ascii?Q?xAIEAoPXlly8irvHPG5n8I5/WkN7wP3VcAAeAumUnCgO9ZD0wW4dzBdQQ4vK?= =?us-ascii?Q?Ej3UQcsvMlUTFNjFkvFl/AKl26rugHIHjyaVzSQ7VGrx+N0hjwCpDCCOqKYZ?= =?us-ascii?Q?icT9tIMHqoa7P04C7BRVG0LDJCmO+vy7lMp6kLczUNT4eUk/ff53M4wowXI1?= =?us-ascii?Q?hFLS3LZuFFTV1WXtrEAOISDTqnF3lC6EaGaerqzne5DSAaJrrBRG+gr12j9p?= =?us-ascii?Q?KqAzcFxjVWDJXWnxG7/abUFSC7UTSIXJWh9lSfAcYGQz96EDmIi3eH9W9hhF?= =?us-ascii?Q?5ju8f1ACk/KSL/SkZUujvZ2IgJdG9h2OUiqvw0kxJhdBWgeNqmxPrETnRSG6?= =?us-ascii?Q?e6MO35SxIj2XC10kKYpNi/57SYsUUEfsWQGfM3UUD/4kWXiQy8Gh7VILKiTe?= =?us-ascii?Q?epTqnEj+wEsAbw4tEWtOuxThmpjpnj1WEwXT/5kqcx5Z7loDhhSGgNuCVvvM?= =?us-ascii?Q?2GdAZWWmZ1pBVrxFKaIVLu9rEHZeUJWXkamNiwLplGJ1nXg9DynbsejEz2UT?= =?us-ascii?Q?somtBzv1abnCVAznHlHbVM8mg/WRyuVI1hvOXrL7mb1FwRiJQWJ+56AZLHG3?= =?us-ascii?Q?WwgHRu9hXByeJ7/A0GPctvpwXP4hZWFAW1XCRdzr+QNjVc7C+qAd27HLsSdy?= =?us-ascii?Q?3WIBN2ZsqqHUqsu9vBPOe5C7zbumizyHao2reqWX4Eb34gOuILlqaCLKV46q?= =?us-ascii?Q?CR1g614FrKI4+gUt62Cqn+YvmpXIftG7kxVVGmB5b/emE+87Xy/I3WcYlkR7?= =?us-ascii?Q?n+Ssp7RqtMHR8QtrR+ky8dlG7Qaj4/pFlipp9KNlDO/eNZUWQEj7exFWh9Ov?= =?us-ascii?Q?JIYbCeczv5furVXQW+rQz2rM4u+ftaiZCmwC9HhSumnbTvKV0wmZJzBNAOhf?= =?us-ascii?Q?Sz6ZNy66XbjjMfpJzdRkN1b8aTgTlSwIIJMC94FelKSwtdosibKEedCriabb?= =?us-ascii?Q?pIcRSsa5uSRC275HhYwWCkvYuyDiG/8PoSgtn7qeqPOg7gXFt7++My8T9o+B?= =?us-ascii?Q?+uHqwTd3JxT1UbDw2nbMDMs1uKPQamEr2tH808O7BwhfXmi0rQPK86/CJesX?= =?us-ascii?Q?7jsdbAn2QFX8PxLEPpuVRVLTPU3YEvOZP7iU5Oai92ZG9/JiU5RLF2JSTLMh?= =?us-ascii?Q?KXnkh3iHQLgqf4NVbZv56jf4k1b5M6s=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: c7adb232-c9b3-4ebc-5752-08def23b8f1d X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2026 15:17:55.4435 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TLq63KLDobpsbZqRWVapmBCkHqaU676THJZ+/wEQywT+CS+EDZZalT2azBFLYhLHaZQyxe6NXc7CapuJUNJNufTNzMtsx+bX2ugpx73PvIg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB10317 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c200::1; envelope-from=andrey.drobyshev@virtuozzo.com; helo=DB3PR0202CU003.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @virtuozzo.com) X-ZM-MESSAGEID: 1785856722595158500 Content-Type: text/plain; charset="utf-8" dump_backtrace() walks the frame pointer chain until rbp is NULL. However, when glibc is built with no frame pointers, rbp is never NULL during unwind. Instead, we see garbage in the outermost frame. This results into: #17 0x5610b6e9f2d9 in main<+1720> () at ../qemu-io.c:674 #18 0x7f26cc10230e in __libc_start_call_main<+125> () at ../sysdeps/nptl/libc_start_call_main.h:58 Traceback (most recent call last): File "/.../scripts/qemugdb/coroutine.py", line 409, in invoke bt_jmpbuf(coroutine_to_jmpbuf(co_ptr), is_coredump, File "/.../scripts/qemugdb/coroutine.py", line 296, in bt_jmpbuf dump_backtrace(regs) File "/.../scripts/qemugdb/coroutine.py", line 247, in dump_backtrace while rbp: ^^^ gdb.MemoryError: Cannot access memory at address 0x4 Error occurred in Python: Cannot access memory at address 0x4 As a fix, stop on the first link that can't be read. Since gdb.parse_and_eval() returns a lazy value, force the actual memory read by wrapping it in int() and immediately catching potential gdb.MemoryError. Fixes: 772f86839f77 ("scripts/qemu-gdb: Support coroutine dumps in coredump= s") Signed-off-by: Andrey Drobyshev --- scripts/qemugdb/coroutine.py | 25 +++++++++++++++++++++---- 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/scripts/qemugdb/coroutine.py b/scripts/qemugdb/coroutine.py index 649579378db..da395a1a13e 100644 --- a/scripts/qemugdb/coroutine.py +++ b/scripts/qemugdb/coroutine.py @@ -235,13 +235,24 @@ def dump_backtrace_patched(regs): out =3D run_with_pty(cmd).split('----split----')[1] gdb.write(out) =20 +def read_word(addr): + ''' + Read a 64-bit word, None if that memory isn't accessible. + ''' + try: + # gdb.parse_and_eval() returns lazy values. Force memory access + # by wrapping in int() + return int(gdb.parse_and_eval(f"*(uint64_t *){hex(addr)}")) + except gdb.MemoryError: + return None + def dump_backtrace(regs): ''' Backtrace dump with raw registers, mimic GDB command 'bt'. ''' # Here only rbp and rip that matter.. - rbp =3D regs['rbp'] - rip =3D regs['rip'] + rbp =3D int(regs['rbp']) + rip =3D int(regs['rip']) i =3D 0 =20 while rbp: @@ -250,8 +261,14 @@ def dump_backtrace(regs): # instruction instead of the CALL. Here -1 would work for any # sized CALL instruction. print(f"#{i} {hex(rip)} in {symbol_lookup(rip if i =3D=3D 0 else = rip-1)}") - rip =3D gdb.parse_and_eval(f"*(uint64_t *)(uint64_t)({hex(rbp)} + = 8)") - rbp =3D gdb.parse_and_eval(f"*(uint64_t *)(uint64_t)({hex(rbp)})") + + # The 'rbp !=3D NULL' condition is insufficient: the outermost gli= bc + # frames might leave garbage in rbp if built without frame pointer= s. + # Break the loop on the frame that leads nowhere. + rip, rbp =3D read_word(rbp + 8), read_word(rbp) + if rip is None or rbp is None: + break + i +=3D 1 =20 def dump_backtrace_live(regs): --=20 2.47.1 From nobody Tue Aug 25 09:50:53 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=quarantine dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1785856720; cv=pass; d=zohomail.com; s=zohoarc; b=NfunHWQCfJGh5TV5qxptqa/sDNvdor2F2URuq2Fw0r5SMji9rhN5a4tkMisksKip64IVhZMN/jr0KSrYkRHtWhw+m+PlQ4QLc9bIoYNO6drkkc0O7rWYOw94rHtvEU0ivCkNB5V0pbAogScw8fDCw1iakY9ftqhkQcxp26yENeY= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785856720; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=CiAN3eQVDCWQIdw6pFyfdRCYPPaxB1lVTRx0fAnTrjo=; b=AXyMH30sIeAdp5Ao1CPacue72CskLq2mrgeW5ycrDOpbs+qmzvWNe8wZ0i3cghpxTQAM7xS4iSKBl3zJ/f7CSqReK4bBaQDrTT3z5zblQ1EHju77DPyyP3V0+8CgViVlvZx4dKLppZgYin+qSZHJuj0mujsEtyBzH3KT2sT4rl0= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1785856720161454.94568125777005; Tue, 4 Aug 2026 08:18:40 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wrGuF-0006e7-Ct; Tue, 04 Aug 2026 11:18:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wrGu9-0006cU-Cv for qemu-devel@nongnu.org; Tue, 04 Aug 2026 11:18:09 -0400 Received: from mail-northeuropeazlp170100001.outbound.protection.outlook.com ([2a01:111:f403:c200::1] helo=DB3PR0202CU003.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wrGu7-0004md-Ug for qemu-devel@nongnu.org; Tue, 04 Aug 2026 11:18:09 -0400 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by PAWPR08MB10317.eurprd08.prod.outlook.com (2603:10a6:102:330::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.15; Tue, 4 Aug 2026 15:17:56 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%7]) with mapi id 15.21.0270.016; Tue, 4 Aug 2026 15:17:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WKRz9fOa58NceBiN1R8WTb3to2KrBqjZnSzUxs0aNu4oBL3/qDnW4GydeK7zImmJaWHWaUJYP3Dy1aB/ZF0Q7EugiWnXb6wf+0LCJGO2Ojgx3H5DFyW/ROUhEfdEpZzv9uQe/NqlttJOlZbmHmq2yWyZbPxnuxgDZhUULY3TXEkE5U90oIUxL84G9WBYN9kjw46HecpQMwuUFLsH+ux9J+2HNnDUMISBldEpn1nzT9sc/JOWNloavaKQ+VZlHR5up47XFGeuPcto29pabQD9akuZarq8rVGdC/XPoBvX41bSORj7sgI7H0jIjzBnqH6kjNf1rQb1K5Neo5JmBBTc4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CiAN3eQVDCWQIdw6pFyfdRCYPPaxB1lVTRx0fAnTrjo=; b=L4T+rd0zzeWgQFNEt+yiVsvzAu9WaFykbaZRsf4fb3HtVmSBJsP+O1mPWXJWyc7yCO/n0Dag/+C4WbS2stxkqYhIM0bRtnMpqQPN9PYte0P55wGjyAgCYtZIsF0FjqsgtU85yrT3Oxl+7AYss+VjK0nPqWvNtQrlkWZ7XKOwhcsQD6vqr7JLyJJFH1BppXr90JecR41um7DM+SqlWPK4JvZBEv4F0I1frY9Wo7H2etvsUdcT7Ga5K9B5jGmqbtZLBnj8yGXMnfQE+T6NL7nqZm/bgXBSt6p7NlQDdmA61jUcsx7MrfglPGcMrcO/a4i02zdwgVBlP7NqTZhrRHsQyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CiAN3eQVDCWQIdw6pFyfdRCYPPaxB1lVTRx0fAnTrjo=; b=TzYJbJnuBVHG7TmFVv8FWwdg0diA5PGXWCFL64DCpOEN9cycJhWxHgwB7Gpp/YJkEkpkIv9tqDmNSLrEhKau6SIUOA5D9k6pU2tfmwPM/IaJmkECUK1tUBHZgBXPdEbp+w9wruPcU+x8Jf7p4JfCRj8jZIgep/Pzv6MahdjA6RvfBxR42dteJx/XfSReeDwUUdhmDUdiiPcR3NzlIOc2fABxi86BdE8Ym8TI4qNuR5+FSO36Tq0+OX/cMLXv/sv2gRWPM2Omt9Km09XAnW1/B1FjgxGAklyQaMMLUJCNc8wNJphDR66uLbgxwGy3qOQl8u9n6Il/xR3Q/beFsBk8uQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; From: Andrey Drobyshev To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, kwolf@redhat.com, peterx@redhat.com, andrey.drobyshev@virtuozzo.com Subject: [PATCH 5/9] scripts/qemugdb: coroutine: Fix patching pt_regs in the coredump Date: Tue, 4 Aug 2026 18:17:39 +0300 Message-ID: <20260804151743.937694-6-andrey.drobyshev@virtuozzo.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260804151743.937694-1-andrey.drobyshev@virtuozzo.com> References: <20260804151743.937694-1-andrey.drobyshev@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: VI1PR09CA0148.eurprd09.prod.outlook.com (2603:10a6:803:12c::32) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|PAWPR08MB10317:EE_ X-MS-Office365-Filtering-Correlation-Id: e0d8a4ab-2595-434b-3ecd-08def23b8f8b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|1800799024|376014|23010399003|366016|38350700014|6133799003|5023799004|10067099003|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: orM92GHzF+24SCZ+z4Uys4mocHEgUCFm4lJShQA0ks8J+uD6h0SbAKt1SghyMHLEZQZMnQETp6O4SARFYlfP2xKWdRgng6AnkqilWiJlrxVQns/2KvkFDtusNU54njK9cA0pgX7wntUdzpE06ioQnFgE0T5RIdZS8rYINh2YBaFNB/qtkAzf2Edi3uoNgnqJfPn1GG1ORTrnHm3vfCRCx4GMRv3iMNnNOoWOOGUwtuGRVGZckSrOjVFzH2ZglnjiJxd3Pl7OR32BG4Nz1SZ5j7ppe6al1vQ9s8wafARoL6HbI1NKQTJEFt7Gal2s2Sqqau/TaQIVipr/llKUMgTYF7IkcLWeamWFKDaJ3wu0Ypy8mdNqbZba8Emyb279pK2hlKz9TbnSyhD4p26VOKh2vBrmcQqjnK8zDobC0B/6fovwQ2FMhVyAPBXS4tqmMXMGLsqERrE5ly1FiGgqKOV8i+8L3zgbOCymL6v9OV67QUT0b8hLhim3VwSt1WAQjSNWQpRBlcRmIM9ys4yupTsN2Q6J+0aRlQ/8ccRZsbiJupokqYgBUcibLSTc/CF/OFV7BlzfS3JCIMrrIYSOQYyTDZCHi07ogw7DHkrttHpiJy0stifELqprlKQGrDBsZ76G6YbbyN1/C6ayJ2YmFfEM+c9m5d56gPLSua2sOrVfXzLDGxs1pD2qdDm1wae+4ZmQbC5pG0gu3kIcG8HnfcI2EUYNQ18dKbCjQVX4i0KxYpc= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI0PR08MB10656.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(1800799024)(376014)(23010399003)(366016)(38350700014)(6133799003)(5023799004)(10067099003)(56012099006)(18002099003)(22082099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YcxhYKnTx494yVBNM5w82F8ONgRrNMP6PehCq6Et80pFtuWaPH9dnsdK2BNc?= =?us-ascii?Q?b3gN7yI+Acs1YlJ5/F0EfFZ0SxACS78w18aCqwWABXNveNkGkWY9/Mo5wQOi?= =?us-ascii?Q?1V84sxgnqXkxTmiMoJQzHl7PBgUvPUeXQcIxpDRlzuSiYz5Hxi97GWkiNYPg?= =?us-ascii?Q?AnR0uqvxlz9XuPrpncH2S8VUtuI19D5V/hgOZmjrobfYCpsLO1qSytbvdaNj?= =?us-ascii?Q?ct/arRzwNHe5aAhQp97ABE3QTZv6Y5jpe9Dou3R8eLbsJHhCedr8ypDkBsqZ?= =?us-ascii?Q?9yh+6YR9QQ478BiuQxIMnAom/ZS3g7lLw7BOF4Pjt0iheUPZNMyy/F+3wLFq?= =?us-ascii?Q?gzvsMjwh8t58j60byEGHLEseVvxupypU3SfTawlOf2hvdIX5tVqSh1kBb0aH?= =?us-ascii?Q?o65njCJmatDYTFXoUVByxLT6LmjS/UqXHIS1RB7Wpx0ib4PG/tJ8yP4dY2uw?= =?us-ascii?Q?XcaG5fYE8Tt5WU0u4hz15UlmvGEmPRK4aqlgYRLFLq1TbDKIpsLlw2ccirlq?= =?us-ascii?Q?6nyCkHwTAuE9a3pWHgjXCpbHEHUHJJXXrdG6KW8kfUjUcRFmmRconhY/9cEW?= =?us-ascii?Q?HyU+a3nBDAyPrs450HpdVRl8arw5JtFIxXNUE24PlmBOj8NOAIkkXX3q2rS7?= =?us-ascii?Q?FNakZkpGKtfJX5qSz7xDW7HrQa4E+nLdH/Mo2AehZX4L935sHoNl33YndI+g?= =?us-ascii?Q?E7jUHavaa95uoPstoUd+dsCE403Zapo1jNjyB4+xoSJfr50hFpZdgCzB5KWJ?= =?us-ascii?Q?xdZ7QOXdv6OnYI3cVvufwbYHIjvD3lqnvjc5Jx5frhdMWFnw6C6xuaWiyy2K?= =?us-ascii?Q?NmI40GY0nPDCMiu6FzJbiGXq+qc/6DHItF13Uq+/kV82x4YQ/CdEHChzLWcG?= =?us-ascii?Q?X+bcF8qJH+/r6k6z+5fv3p4xEyLcCyaaNIoLsNz++LtS1hzpLlHDvsFaXzMh?= =?us-ascii?Q?vUgK6ThregadKnjlYDhv9s+2iJckpJJIYoiyI3XDAwPF++7a1xitsEghdlfm?= =?us-ascii?Q?c8ygnSr0ScOVY1J/T9BODd+SR4NB9K9wdmHroOsxsqobhciohcQtye7cePq/?= =?us-ascii?Q?cSA3ZqkNEkGSpBho8Kl8U/e7GTDzk2fbeyOkZyLwrtZi/oEKdAzfSbS7S8Gw?= =?us-ascii?Q?TsT0Xs2yaK3+D/3aAogoXSgWGkAMy3VBDznvmY252VpMIhtc0e/C7Gu81g4l?= =?us-ascii?Q?IpQQc9twhuFr61Y3ycnAxzXZjenyx/F8OK+YCg+vgNuhPOqlqauYsjCYFvMC?= =?us-ascii?Q?LUoA8E08HM5nfxxhCv37NsoPlgvIVSAZIZ66TxErUH87YCOlYQpyCMnkjnMG?= =?us-ascii?Q?WXs0Z8knsN4zhOPrmA2PHL9SR7vGLXdF8EGvR5xQXU2WOZ7ofrk95wS5YFzC?= =?us-ascii?Q?rBQ96JtmZI1AbdYKZLz5QaWJiSVRQ7TLxPsAJQkkjNLmgdUNQ8d7oRMTYRL/?= =?us-ascii?Q?Me4b6OE60PyfOX+/STx0Y0amDP7paG2CSSxImXHXuybz9TVYblDMmlYs3dT1?= =?us-ascii?Q?JeSAEATnCXjiR5iZWr90hrbl/3gT/NlGHY1S5pGt9ALtnOH8kms07Z9nyaRY?= =?us-ascii?Q?KcFXGprDyu4KHbBHJABfViVyaqRC1tiyVp4CDlx4ypsjh/D8206aOLWZ6Dbv?= =?us-ascii?Q?24nNmF4wqfT0eU7Qhyw9V5ndZlLYviXK3fqtdDiixmZqQI/70XFWtKNjb7tj?= =?us-ascii?Q?sARBNgmKmf1OdqWpWe5m4z4Lb92CxDdmDKIyOLZhTYsSQ06n4ROlQ5VoXXzc?= =?us-ascii?Q?dKztKqujEpaSx/2T68K4XjsboYGfeX8=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0d8a4ab-2595-434b-3ecd-08def23b8f8b X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2026 15:17:56.0450 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oCEtIPW/6DI6MWNEQyTn+56TwQDPpHJ7TQqmDTQshqk7+TA0OyW0VyL6O/jwerQT+GEDDwHoIom5c5HpttPK4NWN8x2eRNzX+Q893ZnaGFE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB10317 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c200::1; envelope-from=andrey.drobyshev@virtuozzo.com; helo=DB3PR0202CU003.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @virtuozzo.com) X-ZM-MESSAGEID: 1785856722584158500 Content-Type: text/plain; charset="utf-8" patch_regs() and restore_regs() open the coredump with 'ab', i.e. with O_APPEND. This repositions the file offset to the end of the file before every write. The seek() to pt_regs therefore has no effect: instead of patching the saved registers, we just append the binary blob with patched regs at the end of the file. Nothing fails, and the gdb subprocess still prints a plausible backtrace. However it's a backtrace of the crashed thread rather than of the requested coroutine. The .ptregs blob kept for recovery is dead for the same reason as there's never anything to restore. Open the file with 'r+b' so that the writes actually land where seek() points. Fixes: 42f3c143c3a0 ("scripts/qemugdb: coroutine: Add option for obtaining = detailed trace in coredump") Signed-off-by: Andrey Drobyshev --- scripts/qemugdb/coroutine.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/qemugdb/coroutine.py b/scripts/qemugdb/coroutine.py index da395a1a13e..4803914dde0 100644 --- a/scripts/qemugdb/coroutine.py +++ b/scripts/qemugdb/coroutine.py @@ -90,7 +90,7 @@ def patch_regs(self, regs): int_regs =3D {k: int(v) for k, v in regs.items()} patched_ptregs.update(int_regs) =20 - with open(self.coredump, 'ab') as f: + with open(self.coredump, 'r+b') as f: gdb.write(f'assume pt_regs at 0x{self._ptregs_offset:x}\n') f.seek(self._ptregs_offset, 0) gdb.write('writing regs:\n') @@ -106,7 +106,7 @@ def restore_regs(self): return =20 gdb.write(f'\nrestoring original regs in core file {self.coredump}= \n') - with open(self.coredump, 'ab') as f: + with open(self.coredump, 'r+b') as f: gdb.write(f'assume pt_regs at 0x{self._ptregs_offset:x}\n') f.seek(self._ptregs_offset, 0) f.write(struct.pack(f"=3D{len(PT_REGS)}q", --=20 2.47.1 From nobody Tue Aug 25 09:50:53 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=quarantine dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1785856725; cv=pass; d=zohomail.com; s=zohoarc; b=SARz2vDws1+L3pwc2FWXbUU6fpFOvxsm/uyFq3bZx6JVbLiktxb/3//yhp55aRBRUFwsfzCV93IyjZOchJHwhjyFzix/Gq6QNPn/STAp/VEGNKzPi12E6KopCg88MKS2nMfIVbDTFp2umuUcvnjlNuYBlPUHv7PxTgY1p/vjob0= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785856725; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7IXc8O+7U43tmvdXZuySHd5lH9bG7bf9u0h410ImcB4=; b=ciWMcK1yBpPL1FfBwuhFE+zWmZDccJy0s/ke6JKjVN7zdrmy6l+tM4ZJZ3E7ViFYp9Tsvxx//1jbrsl3dP5Q/jAlCoZodcTqufb2sl0K62nIWMmh4K8rOGeBjw843w+kOX1udlEuR7/HBXcRpSvRCfkSgx+nBccHqC2WnXGpUW0= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1785856725619885.6546030075715; Tue, 4 Aug 2026 08:18:45 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wrGuJ-0006er-Aa; Tue, 04 Aug 2026 11:18:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wrGuB-0006d9-A8 for qemu-devel@nongnu.org; Tue, 04 Aug 2026 11:18:11 -0400 Received: from mail-northeuropeazlp170100001.outbound.protection.outlook.com ([2a01:111:f403:c200::1] helo=DB3PR0202CU003.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wrGu9-0004md-Ob for qemu-devel@nongnu.org; Tue, 04 Aug 2026 11:18:11 -0400 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by PAWPR08MB10317.eurprd08.prod.outlook.com (2603:10a6:102:330::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.15; Tue, 4 Aug 2026 15:17:57 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%7]) with mapi id 15.21.0270.016; Tue, 4 Aug 2026 15:17:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jOX7sSRyn+vwGE54mfraUMQrlyYMJUpWCCyc5/IO9Ff4GYojJ3TKgJzJ1aoC0xK7gHMzL0wuGC4G/ArD5HYfslymVKqEjha91vzpy6i5bcjegNetfDha5GuIk8ETMPy7Cy3KwvxL6tLPyTxnheXamPGtqWSeKQ/Bymj5ucw2zYKOQJxKj1Qd9T6SKCfR9NJMKTyjRtfuOAozEbw8h2HeBFRmwO5WlZeYyTxsUdTmbG2ijZWIbPuktqyzOnQIGlIWxvuujGOMCY1KgrB1XNw8RDT9si0LJ4QV8z/okBGLtAVD776fKPZB7h1y1fE4koRwjkEoEv9kGXhOpKS2/8wb8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7IXc8O+7U43tmvdXZuySHd5lH9bG7bf9u0h410ImcB4=; b=BH+nSv3cOzIQvRFMBATNUEcjN6lLnzS17Ntdw7vfrQGAwBi/95rgO5nshImjHZw69U+x6eU/YUUjVPVWsaoagHJrPqTwq3fr7M267F0xob0jBTs2u3sjTQ2rnjTRT0jdfTcbznc9i0aDwzbhpa3MfM4XuX/QmBs1g6zK8Vq4R3pX6RNQl3Zh/coq/NNtdka6qdXqoJuwVoBBL1zGPq9K74dlZL/ewUZQ+IOrwB8tnVxvLtwmdoNgIYOPZA0DfKm79FI70STX9APFAC7a7e9lgubbL8Wpz4F58KQZj+/e+w6hJisbSUzuL2SIidhI9s+yoUpO5027wMgoDzxGeZTWIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7IXc8O+7U43tmvdXZuySHd5lH9bG7bf9u0h410ImcB4=; b=yqPXK7nkBXbAssad2qhy0BQLWXTc4FzzP7FMx5zQ81hjTuaNp60LkaRJPJfAd3NKITQ01dEQHDj+S3svQTh+B+/sQZy6S+01IUcf0sTI5XXYYqsg2HzY4QDSbkQ2x49q+KiLhtihmS+rhapn2qVIlqY4jOrGFKWkvq+D3ADbAwhQaKu+lJcVKF5X+izWoYq6uIpuWazaAN71XXDWsfnEZ56s6khuk39B3vFh1IxlbXRKJ8h0JSDOBG9cCAg3kTwcnmQ5w28ADUm6/dtpIhk21cyd9ZF8d2Ua4HqrOhtLeWyiY+QWLPzKB2lg+CNFoTkpXbZiW+ER2i3tXkkQrL7ADw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; From: Andrey Drobyshev To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, kwolf@redhat.com, peterx@redhat.com, andrey.drobyshev@virtuozzo.com Subject: [PATCH 6/9] scripts/qemugdb: coroutine: Fix '--detailed' description Date: Tue, 4 Aug 2026 18:17:40 +0300 Message-ID: <20260804151743.937694-7-andrey.drobyshev@virtuozzo.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260804151743.937694-1-andrey.drobyshev@virtuozzo.com> References: <20260804151743.937694-1-andrey.drobyshev@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: VI1PR09CA0148.eurprd09.prod.outlook.com (2603:10a6:803:12c::32) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|PAWPR08MB10317:EE_ X-MS-Office365-Filtering-Correlation-Id: bac95ce2-0af5-4146-4d62-08def23b8fe5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|1800799024|376014|23010399003|366016|38350700014|6133799003|10067099003|56012099006|3023799007|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: bwwck3YJIV670yfXfxrsvwLDmjVsC5f8/1R4LJBeJiekOIoek+bRucsOHcOcdfwI3qjeyMc80fie1prxHgQGIDNkJFavLK6fnvIittF93fqJY1FEqVBjQmTlbmRgR2wM8ydUxx6qNf0lC57yj9LkDtGuDZlokszojkPPnmtgXlD8RzfwVT4+fjlZk1Z+X4HB33FNfaWHOB60arKPa7ickoBjG8p1Z1Gevtz4LDNHSYHBPllmZ4EXMF+8Rqh57XY42q0UQSa3G0TqTlP/QNx+WqJAz+dJifhI4CVw30FgePxJA9hWbp3dgTUqZRl1o3QJzkRFvqDyZ+38NJsWhJ+T9OzxrAg/6RkA6K4wDd6TBm50zEUvui4dGhg+4dIXE7n5D+8UumHS0Rxqq0taVoHd2YSKW4nhkK3X3esIyeYfVJp6wMYnRnCnyCXBaCVgNI3fe52ZWXuO1c08q9LUvxM06EIDYbygcCHSzTOviALzIKZdZmxSzFW0Gk+9wOe4aEVHSD/CViThZC6PDSYXCrXq51yP5/TbQoucWvV+6qR8ybHml9Ff0biVCLUhwvSJgfT9JwZeHXPBs+gLZbtO/W1C2EQFzBb1Z8qXZbM7h206erUmBlYqydEBwMlqzy4sFPSuybmKI+AfVcxKQoSuGnL00LdVoJVQfH5JM4532xltmeOwWQfG+1hbL6g7Ead8TsJbmIBNixVtHxwvn8MyI7GtJA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI0PR08MB10656.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(1800799024)(376014)(23010399003)(366016)(38350700014)(6133799003)(10067099003)(56012099006)(3023799007)(18002099003)(22082099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FDb4FpOtHoag3pLSemiQ1H6hfIbYgVXi3Sag2SIQYvTpw1ah+w7wb2lhhKZz?= =?us-ascii?Q?okoLLNKGdHvr4B+xcAEE2aiYJuvYalprP2U4zTOVk04akdWq08+OW0VNRj6H?= =?us-ascii?Q?WVaZ1/EEpsTE0XBNIDSvGNJ0tcyPZd8MVLHBTCsK3U5RhA24D8ITS+Z0TNEM?= =?us-ascii?Q?hQFPM0R+aCiSCVYnLILr+IiFrATASScjPy+GhkaWSw4nkICtT7PzCaO8muwN?= =?us-ascii?Q?xF7yJX9ll60QYHCPObNblijrvm0rO2WUZ2YtsW1Bi7qh/EhwovrFgB8CvK9j?= =?us-ascii?Q?2amwbIlctG0w4i8MCAoHpjJSKcgYQ29COnGSq84Gbq9zFK1ljliRKi8NuRJZ?= =?us-ascii?Q?PuDmuzvJrty6rKoKz2Dhff/qDgDjEIC9DcW5TNtb4p2Nv8tNmHaGBRc+CIaT?= =?us-ascii?Q?SlGO0HecS613EyghfSvcy2NRkO1rPGPXg7qhOj8EudVyP9DvtiHaRpEH2mZ9?= =?us-ascii?Q?t3UsNq28LUTLL2PiBsSZPxQmb3e8JwNP6NAdhxs9wl+/cety1vDPiAQDS3gl?= =?us-ascii?Q?ZXMTgku5M38ZR0iHVRkDQ+sq0EQOhQueVq6hHySDpaDHJRonKA1kjs3LU8V6?= =?us-ascii?Q?zQ+zOjZvvY+3s6gyvrL1t4WXqLFLtyVS9+Pfv3UXRi1ZRig+j2zBAck+ziop?= =?us-ascii?Q?C+y/UsezCgVIaobLqfRpnVevyaxe4o7EdQXH6lq81z47s86jXC7DnUBYk+Sh?= =?us-ascii?Q?6SGHH1DiU9B1tau02TA1qPn+0BoORWIdCaf5RR4+U46mteO4szPx36ygq0FT?= =?us-ascii?Q?wVSsWbNxiuay6FfiS12L0rkJsazt+k+mh0BbHbXy+DpFrPJ8DPYs2AT0Dd5t?= =?us-ascii?Q?b2QPJnu+1i/Sequy8lbPCItVw5c+mcuWRb41GYMrM2dICC96GUPVPNBP5KvD?= =?us-ascii?Q?4PvJWnK9Pkck2y0QcyqsYf2vY6pSVjtHgOhi1p6SexNAr6dopmt73vm5kAru?= =?us-ascii?Q?N8WtbUYfdS3VCIurwjs553zGjcetKziV6xRWb/VxLrOujnpYHyFFniNbIDdq?= =?us-ascii?Q?P9NRMSJWryNJcPN34SWOJUwIUfJ06E861Qcz/H0gwDx0Ap89ZG8JuMihFiei?= =?us-ascii?Q?tldYazIho8ypGaXYHcgZWeGuiygiXDX27cQRWnctfypysDB05LlQoC1Xy9v6?= =?us-ascii?Q?xU2YelhMTd97scXHYX8y/WHKrfm5YslCrzJuzzwMoOZlgHGX3VSK3jo9cjWA?= =?us-ascii?Q?ddKW47pyGZrCd7pNzlnxq7InZp5GDufAmFXF9mU1HNhk7iu2eOOup9YQzd0J?= =?us-ascii?Q?k1Cv9i1RMooE50oOIIvdBuiZWdAj6/obCOZBzv0EPgZF9bwGMDKw+N4M1cJx?= =?us-ascii?Q?wl1i4XbkJvRQfnrVJV2Otfpou0/sB9damuP/c93rFD/6OH2Vt6s/nv9rNhcb?= =?us-ascii?Q?1aOXgBneXh+54/Bwln6zg/HhBxoI7lYuC5/WaGFdg9aB7ubLYedj1zjLyj1u?= =?us-ascii?Q?M+IyheLBrkczHo+y+epj8ZdOmKLsKzCoDLvMffoJG2FCk+a0BDFvGX0684Kc?= =?us-ascii?Q?1xxRbme2VPmmWruWjsi1ndSI/lJ/BZweIS8bkjLQVXsbjVG3h6sPeY9FSzcS?= =?us-ascii?Q?u8wPDiW73/viHIFdvuotmAyFR9iYwnIjbYQ6W6/h+E3QVxCF8o3OjLMoovzG?= =?us-ascii?Q?gAY3gObpWx9REQy6luTKWeIHW2qNSuYd9VvHXc7Wh5vKXM1G0Wy+2YvnHnM1?= =?us-ascii?Q?k5pC1gKGw57uPKmUybUiMyRGvQ/K5Csy5mhFwMK3qu+0PIo83eKi+U2tJM1Z?= =?us-ascii?Q?3QPEfp5RpJPSTmRAwjnMivtwUMHt85E=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: bac95ce2-0af5-4146-4d62-08def23b8fe5 X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2026 15:17:56.8421 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: J5TvwdhThjQCP+CtrdYDCh51d5PVVnje8hfe7UAILlsOcnCnNFfFT/ZsGpiSXXza6Ggk4JDEZURmy0oJlq3o3XV9lIroI5Jkk5T906qdNKQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB10317 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c200::1; envelope-from=andrey.drobyshev@virtuozzo.com; helo=DB3PR0202CU003.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @virtuozzo.com) X-ZM-MESSAGEID: 1785856727862158500 Content-Type: text/plain; charset="utf-8" Both commands claim the coredump is copied before its registers get patched, but patch_regs() writes to the coredump itself. Describe what actually happens, so that nobody expects their coredump to be left alone. Fix a typo in "runing" while at it. Fixes: 42f3c143c3a0 ("scripts/qemugdb: coroutine: Add option for obtaining = detailed trace in coredump") Signed-off-by: Andrey Drobyshev --- scripts/qemugdb/coroutine.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/scripts/qemugdb/coroutine.py b/scripts/qemugdb/coroutine.py index 4803914dde0..9148264de3c 100644 --- a/scripts/qemugdb/coroutine.py +++ b/scripts/qemugdb/coroutine.py @@ -306,7 +306,7 @@ def bt_jmpbuf(jmpbuf, is_coredump, detailed=3DFalse): # but only works with live sessions. dump_backtrace_live(regs) elif detailed: - # Obtain detailed trace by patching regs in copied coredump + # Obtain detailed trace by patching regs in the coredump in place dump_backtrace_patched(regs) else: # Obtain a non-detailed trace by poor man's unwind @@ -342,9 +342,9 @@ class CoroutineCommand(gdb.Command): Usage: qemu coroutine COROPTR [--detailed] Show backtrace for a coroutine specified by COROPTR =20 - --detailed obtain detailed trace by copying coredump, patc= hing - regs in it, and runing gdb subprocess to get - backtrace from the patched coredump + --detailed obtain detailed trace by patching regs in the + coredump in place, and running gdb subprocess to + get backtrace from the patched coredump """) =20 def __init__(self): @@ -380,9 +380,9 @@ class CoroutineBt(gdb.Command): =20 Usage: qemu bt [--detailed] =20 - --detailed obtain detailed trace by copying coredump, patc= hing - regs in it, and runing gdb subprocess to get - backtrace from the patched coredump + --detailed obtain detailed trace by patching regs in the + coredump in place, and running gdb subprocess to + get backtrace from the patched coredump """) =20 def __init__(self): --=20 2.47.1 From nobody Tue Aug 25 09:50:53 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=quarantine dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1785856792; cv=pass; d=zohomail.com; s=zohoarc; b=GcxiZlqyE9wxNFh6ru6Mt8G72RISw07/12Lf0txTS8uHXPYWf5mKUAuk4cRxO9hpapZxJgFjYlYHbK2I2C7mvFPxjbZLDtzjSYii9Yun2gvNbw50m86wINV2AezoV9q8pG2SNlyyLidqlQoe1SiyEGut8wBJ45jvBiXZooNJmAg= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785856792; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=kpjDBV7Cz0re1cZiaLvg8YGfeD5P98KQfzvF2HLGiCE=; b=Bzyv4o/VXjHiwS3c5fKTVgDKgbAP5mVXfAqSRk/5CgetQE5CeZOropY4UgCFPzYgmCMR6dVafCpxfvKjqkGUSIr4Ua/UuRz4y7d5d8mfgmD2/CmZ6Gl/Tfm01IuIEzAr5WIDhKuPkSyyHKo66iCJgMnc3YNGCNfz7TrnwOd1gfo= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1785856792667636.446974791825; Tue, 4 Aug 2026 08:19:52 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wrGuI-0006ef-T1; Tue, 04 Aug 2026 11:18:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wrGuD-0006ds-9f for qemu-devel@nongnu.org; Tue, 04 Aug 2026 11:18:13 -0400 Received: from mail-northeuropeazlp170100001.outbound.protection.outlook.com ([2a01:111:f403:c200::1] helo=DB3PR0202CU003.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wrGuB-0004md-Pw for qemu-devel@nongnu.org; Tue, 04 Aug 2026 11:18:13 -0400 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by PAWPR08MB10317.eurprd08.prod.outlook.com (2603:10a6:102:330::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.15; Tue, 4 Aug 2026 15:17:57 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%7]) with mapi id 15.21.0270.016; Tue, 4 Aug 2026 15:17:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pX/kfOmgAhYSuaWQkoVPrJPjb0bTkWlXheXzkkRstxQ6dvwqQ81Oiw/vF8BehADIgbtl5ZvHh+LHNU9GzOGprdCQz5J6JXcCFszDUYZ81cxGLFUvxW2JRSAfBS6V0G+Ar2fxG93ZYNjDUP0ugJqolQM1anCJFUOGfYY//crulV/YMwH1dfm4uCnqY7z3hljuuvC6eOcj0s8kPmnNNHDUBAVA6zOPlkvBiyzGF5YRRGxXhKX5XGTjhKG5CqX0ZFukk8KSTEljMaYv8KlSpW7zhc++Y0JW5iHQFKQimDKXy9Mr93SrkV1ejftHzfdvErI3jdE/vhfLxkzDVZwm0xX3IA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kpjDBV7Cz0re1cZiaLvg8YGfeD5P98KQfzvF2HLGiCE=; b=xfJaumBih13qkSOCKLINPZcONesuq7N2S2AhI2xpe7PXVS/azcaRyQMZ6l+Slco2WdTfz/ogoxPg84kY/CX7ZBTp+UvI/LW9OCuTOKxBG4szvBuS23ND43HvIEpg842NQaxap8QbVjl+BgUIpW9s0JZRJGrmhhruraZbu4TOLPVvxt+Z0INsvZGWbrbZ1opGWGXPjiGbczqe9H50qwKwhkw32veDbaPAw7hXTfDap+mI5h2yzrZ3OMumOaiwOXiBE5UGoPNwYLXW1CysHsYXgV8RVihrHfjjmcPp+4L/xGTCEhqju4d1hl6eEv9dypRReGj3bD0igoJckgiyxQjNFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kpjDBV7Cz0re1cZiaLvg8YGfeD5P98KQfzvF2HLGiCE=; b=PRNUdeVz/01caLAsu1YnPktuhcBXyDhzxxVBckgVYo/1lUcdZmQIwIf+om8JhS82azv/ouK+kCLwzCqQ4x69acLuSb37V9FOIXNMlsZKH5T10vbGUZtUQ9zP7v9iAxQELfbZl5wpxw2hj++GHUp3Amc6Z70m6BmbkcF8vO+vW/nveAOzqrDjQ2OdUuMAX8rCUcBl/L5ESIioknM27t6S9NN2+3zUlgen2u7bu1n942SWCjmXRUWHpHTkSY/BX2vGgu+EiVP0LbtpAUJ+d+8OFt0N5vDomaeqel7OvAq3Y/2p2bN3a//TcWJJ90PcUeEXCMLxrDw+r8gmEdSxbu//2w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; From: Andrey Drobyshev To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, kwolf@redhat.com, peterx@redhat.com, andrey.drobyshev@virtuozzo.com Subject: [PATCH 7/9] scripts/qemugdb: coroutine: Handle target absence gracefully Date: Tue, 4 Aug 2026 18:17:41 +0300 Message-ID: <20260804151743.937694-8-andrey.drobyshev@virtuozzo.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260804151743.937694-1-andrey.drobyshev@virtuozzo.com> References: <20260804151743.937694-1-andrey.drobyshev@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: VI1PR09CA0148.eurprd09.prod.outlook.com (2603:10a6:803:12c::32) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|PAWPR08MB10317:EE_ X-MS-Office365-Filtering-Correlation-Id: 7f25e7fb-701d-49ea-2883-08def23b9061 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|1800799024|376014|23010399003|366016|38350700014|6133799003|5023799004|10067099003|56012099006|3023799007|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: 4Qz4O1pWrMU6QA1tEsn6+2if7nu9TSb5oOmcEVX7MBdzPENyK+uWGhiSk5Ut0p/Zc8Tij3cKu27pcKKwHcqeXJQHQbfqBJ0gAKCeW5Bn+oEXJxeCV4PUHY6IoZmrwN4iyDD84B6mzWxtQ+fQP3mIC0n3F2HkM7ie1JFMDOqZ2Uhwx8GAq4xjrUUjJik8CWXG3aQekooUPr5QFIhJ1wCD0H/crZ1b2feA/zKEWvHc0uYkdhH+sNfh5FLS3idTd6Pl2Ph8l461Sjozjzj+EFmASgXat95uhVsU1AuFowhruAcXmPjp0ddoUvvV2jLurXszCsIHoWKRE9CU4hoM0tTT4s4gRQtQzB+y4UycAp+jTVmoXjKzex4RSGbtXIPY5H8i9rVgQu0IcjtxNABQ9EA/kbV4d8MWzneD6yeoeS7cS/bLSKBfjHl97mfduXvmaib7czpEY/Bpfkp3vBWzCXaTJPrfH1oJIs1JwDK8RxFAHSuGdMmQJyknvYs3A9ZfvfxZ9TIGkGfguc0LJya8JigFVuxgiYqe7FGiZwK+fCemfIJ4OuN+jJ/l8Sp8CURyXT3BBnWy93CXB1Tn8OPfZIpUVmf9JuEVzfLsExral+3DM37T7nD+f/2YcIsisAz8FidYPxk0C0vNWzMlJq5PLXUkLUZy613AXAqBjTF2K0sjmBbzoUTW36NOlE3o66OTp95zikek3uvGgUT5f370Qj53UzCbXXweV09W4PQhzTcQD8o= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI0PR08MB10656.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(1800799024)(376014)(23010399003)(366016)(38350700014)(6133799003)(5023799004)(10067099003)(56012099006)(3023799007)(18002099003)(22082099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OtLqh+hNcELeHp+cPlKOe0UI88SwMpQsj0zdh5iKwEAeoTi5NkAL9Ic6/lMv?= =?us-ascii?Q?HVIoixqHL44R/WD5jyNTEdOZc3NKoR85lPveQecC568tg4/uIu3KznARvlD6?= =?us-ascii?Q?uCNKG52igUT1R4B9odfUAom2hzuTS/g4Z5bXIc6YZyx33ef0Qm1zwfzMn171?= =?us-ascii?Q?Ngtz9/c8adA1ZquqO7iYCe3kE0+JmuBxdhkmGLOfLbkPzK9Ah/8bqdJ1Lvj7?= =?us-ascii?Q?vja9Ekb95y6u7lHPMkI9/sCNELZo3LQl9U1JltU1VpQdVLzQT4hL7Bq4h0f5?= =?us-ascii?Q?1RvZwTv3jmWTqk6Gyk5dp2Qlwt64OwJ2ngCzatnmxUBGxD83X+P6U7PSkLWN?= =?us-ascii?Q?20Xc+1zm2s9KWfpy8l17sUZHASITtT5tuFVoPaE7ElkJUGNhHZu8C4svfCcb?= =?us-ascii?Q?IXwA6c8/ZikCgA1JFWDt2Ewd8Bj+iDrYNsHgd+dUFR/9JKYFPNuir8hNhLCA?= =?us-ascii?Q?/2z2kYwZ/f5n0GxiM64L1vRKnlJkX1SuR0umOIB1mh6pP7YvmUArs9htLxvD?= =?us-ascii?Q?Uvyy/Zz9GjQy6nW/OuXqvDhJ1pv1tbOqDdF63SyvrVb6WT/WLxwHEM770DY7?= =?us-ascii?Q?/rSCbkV3OeIp9/rTin5keD5r+CHHUAOY8ft/vFJ+k1H6+NuzuruFtxQ99x7k?= =?us-ascii?Q?2yYe+YrZdmSFpoNIMhlb2P1jg8rsXM3/Fg6O/W5rCCwcPFgPGyOt2nJ+KZua?= =?us-ascii?Q?5Ece0dAhaWdiaQRWNFSodnU13EPL8I1QqRT0l4JNxn/ePS2ztClrim/6qNet?= =?us-ascii?Q?SwxKfos7blrUt46hoVue20wDtORtuDhVY/EIWW0O1inLaxHPufKJ+dKlHIzM?= =?us-ascii?Q?yopeGuvXDjHUMHTk1N9rw1ePykNIb9JPt0DsWwUvGjd+dsd1rJi8lso5KBd9?= =?us-ascii?Q?9t6HYPNMnNQGHTGfg+P29NFMU3vvy2yIJs650eGtA0mSKklGXOpC3uIrZOuK?= =?us-ascii?Q?uXNdu8DL8EE0wvi9JoXpr23ofMbSZY5WasxJH2Ug8c84JJzh7HBTQu+39UnM?= =?us-ascii?Q?DMyXwTQ4P7k0Fuzuwvp/IFVd5dNe5Y6aKxA0kmAIE6snkpVeKPzKToI2Ond5?= =?us-ascii?Q?fu7CrkoeeaMzheATGlgpjh1SaxHTk/b3ZNxthBbiUOww8+ROU7OwQ548DD1O?= =?us-ascii?Q?WsWpVauDYc6ZMmDaLxQoB0He3BUtCKxgFR3ZcKH8WNeSnr/YLgZ3nAYmIKkP?= =?us-ascii?Q?yLw0sQD5TbWoqZiWLQvhenTnGagjEYLC7xEnvBSYlUK3avQrHLqpFyMLM3jj?= =?us-ascii?Q?y38Pl7pLSIM6rtzCL+jsOhvoii/UXPSxZUM3haPW4fpGAc8lZ5uHCqCNamUS?= =?us-ascii?Q?y63KaFpUn+LVE+V3g3C1msQaJVPdcx1qy06P1kEsNxPOODp0CO18bwulQa0+?= =?us-ascii?Q?x7H3iLXYhxPKIIShvz7Q1eUqufLmSbYAY2bfT0zZqEjpbCYsW7CC0Xj/HhMQ?= =?us-ascii?Q?AiFZI2E/MJYj2OKYKmE2tztbBvs9hNhvS9i0LoCv5sDCmWFDqBkDAdOfiK4i?= =?us-ascii?Q?cddxfe1hG/6b85mj46oEOhlbNuvIw/MvsYGm3OHNIe/AMQ9i9DzY0X3GisM3?= =?us-ascii?Q?m3iGTY+IMzGNYQpO6uXylJIcOU7LhawhrCUdQmU2B96irYZWmKqi1dzmJdmC?= =?us-ascii?Q?HYBZjs1ZqnClPcLGNl4n1RPvY3/vD6WaCy7tIrmTlPcNBznZKHtv5hpR8EqO?= =?us-ascii?Q?ify/Nkd4fFinV/wp0wMKRTOqUIqcH4GaFeKuKdcvHCIWmNGkF4X+0hjgYTjo?= =?us-ascii?Q?Jwt43zWEkqXchPLrZ2WtlE21nHWGZ7Q=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f25e7fb-701d-49ea-2883-08def23b9061 X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2026 15:17:57.6376 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VWIb3pXNZ/QjDwpGesBlibp7BB296p3zhZRICrX6xHwK45JpFy0w9BXvfbcKNAJ8z4lLm8xJdvhW/KBTy+5N36X+9aiL2GYB/3Wcu1Wjhf0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB10317 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c200::1; envelope-from=andrey.drobyshev@virtuozzo.com; helo=DB3PR0202CU003.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @virtuozzo.com) X-ZM-MESSAGEID: 1785856794329158500 Content-Type: text/plain; charset="utf-8" init_coredump() picks the core dump and the executable out of fixed lines of 'info files' output. With no target loaded that output is empty, and 'qemu bt' dies with: IndexError: list index out of range Search the whole output for the core dump file instead, and take the executable from gdb.current_progspace(), which doesn't need parsing at all. Neither can raise if the pattern isn't there, so an unexpected output format now just means "not a coredump" rather than a traceback. That alone only moves the problem to gdb.execute("bt"), whose gdb.error escapes invoke() and still gets reported as a python traceback. At the same time plain 'bt' just prints 'No stack.'. Let's mimick this behaviour and simply report an error if there's no selected thread. Fixes: 42f3c143c3a0 ("scripts/qemugdb: coroutine: Add option for obtaining = detailed trace in coredump") Signed-off-by: Andrey Drobyshev --- scripts/qemugdb/coroutine.py | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/scripts/qemugdb/coroutine.py b/scripts/qemugdb/coroutine.py index 9148264de3c..3e0b37b73ea 100644 --- a/scripts/qemugdb/coroutine.py +++ b/scripts/qemugdb/coroutine.py @@ -322,16 +322,14 @@ def coroutine_to_jmpbuf(co): def init_coredump(): global coredump =20 - files =3D gdb.execute('info files', False, True).split('\n') + files =3D gdb.execute('info files', False, True) =20 - if not 'core dump' in files[1]: + match =3D re.search(r"core dump file:\s*`([^']+)'", files) + if match is None: return False =20 - core_path =3D re.search("`(.*)'", files[2]).group(1) - exec_path =3D re.match('^Symbols from "(.*)".$', files[0]).group(1) - if coredump is None: - coredump =3D Coredump(core_path, exec_path) + coredump =3D Coredump(match.group(1), gdb.current_progspace().file= name) =20 return True =20 @@ -362,6 +360,9 @@ def invoke(self, arg, from_tty): return self._usage() detailed =3D True if argc =3D=3D 2 else False =20 + if gdb.selected_thread() is None: + raise gdb.GdbError('No stack.') + is_coredump =3D init_coredump() if detailed and not is_coredump: gdb.write('--detailed is only valid when debugging core dumps\= n') @@ -400,6 +401,9 @@ def invoke(self, arg, from_tty): return self._usage() detailed =3D True if argc =3D=3D 1 else False =20 + if gdb.selected_thread() is None: + raise gdb.GdbError('No stack.') + is_coredump =3D init_coredump() if detailed and not is_coredump: gdb.write('--detailed is only valid when debugging core dumps\= n') --=20 2.47.1 From nobody Tue Aug 25 09:50:53 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=quarantine dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1785856769; cv=pass; d=zohomail.com; s=zohoarc; b=eGKd1Fk5GbGCe4uXljGHSJ8koLj2NH5v5IcaR+QAAkRT1HOPqcrDOhTdLgs9/4FcQAfOcAaXpKmjimdjDRS0kjJfQ2vKcBNvwHRE2JFPqDhduLHBA6APOtY3Xk42MTfQGGLI/8KQpyHUbROTXnv3vrqfRxq2I6y4ks2CbbgdO2Q= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785856769; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=AKo5yPpDHi8R1HQqiYlwipcvXSS1RvgcoYohPZOp04U=; b=YEWzSL7v3M49t0KF04P1hKLY7dt9nHL0FlcC4QfDO/15ckyk4tw26tC38AoT/OTVIeCAfg3lwulFV/6nd8CGbSIUnFq1SCuyWRtF/P3Pn2jIDvEVKo3/9lsabiyPaidfgAFmtSkXRHeTnzC/ddVqPBZwMIPsbxt3QP5VNR/3RhA= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1785856769534499.04173664680377; Tue, 4 Aug 2026 08:19:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wrGuP-0006fm-7p; Tue, 04 Aug 2026 11:18:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wrGuI-0006eb-CE for qemu-devel@nongnu.org; Tue, 04 Aug 2026 11:18:18 -0400 Received: from mail-northeuropeazlp170100001.outbound.protection.outlook.com ([2a01:111:f403:c200::1] helo=DB3PR0202CU003.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wrGuG-0004md-TN for qemu-devel@nongnu.org; Tue, 04 Aug 2026 11:18:18 -0400 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by PAWPR08MB10317.eurprd08.prod.outlook.com (2603:10a6:102:330::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.15; Tue, 4 Aug 2026 15:17:58 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%7]) with mapi id 15.21.0270.016; Tue, 4 Aug 2026 15:17:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hXdEVZ8TupaoY+Jo7adyvBuwGy8oGWNllIwnrJltOpd13FIL/kCzc0ZMMUDZjNhgsuN/o0ARp1KuiWk29gRZft2Qwv1+nC1Dvs4fkqnhcHvO10sFPqayHcmT5OTX1guGXy43XQoIDL+GUz5iCcZGg2iFCunG7Lc3Gy8Xdf6xgTG3QdauaKx/Xi8NV5gy1uqD4M6jAh6KiKwMByrPw3/83ZG46T9Sgw4mj+QC2nwCFv9SQrvvoP1WtRbZNp7u5CDmO2xKUA55vyMxIMUj1P1Xd1ExkkbKo8j4RDCfsjYzUYbziaFvvbUjvCnnv9eRGWhwRmutGDPRxusVazwElpgB3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AKo5yPpDHi8R1HQqiYlwipcvXSS1RvgcoYohPZOp04U=; b=VdKHds0W2/aumi5su4VfH0xqSMdEAvFfOpwXmJ0MesksTnET6AeHb+XY4B6sPl+/TQDlkif/eEwdJ32wDRfcmzZ4CfkQYNIUfeQ9zJ0G/MlEbwmzxcp/uQ3j/B8WruGgch0f7TvUzlE1zNZ0l1IhGiPgvILtQ0aburHXiz2+z8gW+RQKp4JM4BLhBEeRRgv4CcNp/9m85BXyv/wwjWmOPsV/U8ALys0ZTjV2BXvUfVQzE2A3vIlGiVQorktin1eMKAkwyN0w55ZMFIvMwHeqPXJakMDZIDLjZtlEu8+vLUZpVHunlRDKvJVeqiBX/6ZDJeQeceAwT8nQ9PtPumj3tA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AKo5yPpDHi8R1HQqiYlwipcvXSS1RvgcoYohPZOp04U=; b=r2u8CtfvRNFxoQz9QU4qehffwMm7uQMmKJAuceVdY7KIZhp1qUKlmDUJSfP9AVWU+xofpkRV6Hos8MFpXxpfwXz2mFGH0lu8ppFQRdnlrV9tbsXBublAQEFVNI2zuj91+DIt3gcPEo/mMG/A8sMakFAd+FzXRWplixm5I5DSGOE8jAv+YHpb2UToctCBHHW6Pv6omXZTKjrdjAd+6mT4Y3gxrxUQF6dzPguhTpsOM3IG5G1kqdkGup3u28R/FLiKDCPAe2flODIFzu4fTF+hXzsr/kaHhs8G88o5zml/bjk8HLLbTcWpEbmqYk6JTqqvh6Uaf25HrbjPnSppR7+d1w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; From: Andrey Drobyshev To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, kwolf@redhat.com, peterx@redhat.com, andrey.drobyshev@virtuozzo.com Subject: [PATCH 8/9] scripts/qemugdb: coroutine: Speed up coroutine lookup in a coredump Date: Tue, 4 Aug 2026 18:17:42 +0300 Message-ID: <20260804151743.937694-9-andrey.drobyshev@virtuozzo.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260804151743.937694-1-andrey.drobyshev@virtuozzo.com> References: <20260804151743.937694-1-andrey.drobyshev@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: VI1PR09CA0148.eurprd09.prod.outlook.com (2603:10a6:803:12c::32) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|PAWPR08MB10317:EE_ X-MS-Office365-Filtering-Correlation-Id: 04aaf308-f678-4f23-cbc0-08def23b90dd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|1800799024|376014|23010399003|366016|38350700014|6133799003|5023799004|10067099003|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: AJQuKKxC+KOzp5YNBzvfyt6C/Y/seB32ltzVpCnV3aMPGlogHjbNl0O0BQ0ZfLcTCve37EBKclsFsP1R/L5x+iq1brNUtIi8op1IeNwu5W32BvNs4toLQVITzw5157J6Ba48KQSiv+7bbM1ub+YckIEj95tzyUJP9Ztc3tV3lEJLbH5fgMTrHWKMaY/+8AK02cC7ixBMHTzEIsWWzTjoTcAO9HO6dx+HP7T5kDqUnVDKIlYEanuAr7vOH7M8AVN0F9bHJO/OQah6Ezjt0q5YYOu20/Yj5JmyvqA8CB73N69W22jpSvDV7gntfbnxa7JLNW7G28+JjLDjahXKvsaDT2SRn/EdOwTNu6pZVq3i4TU7BMikT5zGVastQwPsAV6vepUTqeW9szZGIhovbyJQOA5owj2bLC8xbq7Tm3nKzpxq5b4a64AeyR3dKicYqte8fpsVYMocqECvvXmcLA1bDT0+vgtECp6M+e7ojPqPQbo/ecjIOPV/VB953zKV6VWcmZBcnc91XkZnbcUp1Yv92lMTKYi/pkgIsiT3N/LhxWRh+SdHJyOkkafl7BbYaCFTj+ThhB+7dQydvtUqHj9VTpCvL6JaiDEOndomJtc4AzTEQgpyszUE9FGjwVWflc9YqAUp6HhRumYshp0gkW86GSSTqkKlMmCZUQtXfxVfBOO83nA+uIWIUPQ9aI5KpdrqmqwIPbPp+5K4DOs7OZEr1CYYGUCI+LQbO44Y8r3jIu0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI0PR08MB10656.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(1800799024)(376014)(23010399003)(366016)(38350700014)(6133799003)(5023799004)(10067099003)(56012099006)(18002099003)(22082099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4sxX3Z+DUP6K6s0cLpkV9MRtOAnghbnVHAgN8n/OgZ2YQutZh9mRNPP74cQz?= =?us-ascii?Q?nResDIBHcEUUcurFkj7UkU0BWoRCB+YdO0gX/EFFMhYuVX7ZFdM2tSuSiIal?= =?us-ascii?Q?fH191u1fUX+2vIYn5Bk8sl8uFP+jJnE6j1g5lW84gHNeLOQrfW3sGwvUtZ0f?= =?us-ascii?Q?bXYul1ziUxr+Ukyjz63CgPspI4Sm5f/aUzyPRiMRQl5zVND+yNwNTE2PWr6X?= =?us-ascii?Q?BTnjgCkmX1bgR/FC/6EqiMECFgbRcVZDxRxHgA7hOkiFvcxrkMO0+9Db29rC?= =?us-ascii?Q?ZYJ9gvnXG0KqBKkdQYyTgxiwa9iSV2yNUrfyRiXWmtYGJoG7bFUQYIPe24KI?= =?us-ascii?Q?iIAHUcScKn2BTu7N+efpv7d3HSeRfVBrA3K1SAqYedPFe/pWwP7LdJZdU8Pm?= =?us-ascii?Q?2RrT2/pOkn4v2EFimOYPBVQoyZGO5bNv9W7M6r2F7EA+cb4QBURFyKvYrKOE?= =?us-ascii?Q?N0YulFfGOUQNKsX8k4wt1vg3PZx5gUbLs5zG+eTpy25Ki/1thuzdbwGrd8Jd?= =?us-ascii?Q?zZg/7ReQ0DChKskYth+kNnWZt0G5ujdjARea3/DPMjKe6USuI8f93FRUzDZh?= =?us-ascii?Q?UzTyBBkc41do99gWFuoNLHrg8Io1pWvOcpCHTllXLm1OOSaOUamJvgbBVnnv?= =?us-ascii?Q?XtTG0KJVjtAEy6G1QlJmwSdm15u2jDBswTsWBQEhXJFOzpBp7IyVmUw2+2KH?= =?us-ascii?Q?J13GvMwEUk6AlwALZVypziN+CA5fB1sN9klkMtuvbZ2/tKqe+/0bHuoPA+vI?= =?us-ascii?Q?yqywiS3jGG6QdkxJdTNg9cK4KaNSYc2EbeeYMhtrSgsNWe5K4JNv5z77VHa3?= =?us-ascii?Q?sQCYv23W+hdZksNjTcjOJJARP82qHswpJ4DGLTPuLQ7aq3ma33OJosrY6+B0?= =?us-ascii?Q?5gqWPII0ZWWmqRrqddFfzj9sTrcHF8/+n0BlvZTqGQD6tRUilHBhti0lOKYr?= =?us-ascii?Q?Uah3K4P/NxiBup4ySEmFVxY8cFJkqB5Sby6mDKCiKqHj+fS2y0YFGFnnIwaA?= =?us-ascii?Q?fqjKVIUWHsbM93zhCmf4/or8Vs9hM21NMZ5J4t/YmEeBD5ofWUUeeMZ4s3co?= =?us-ascii?Q?lbzUlNgF18cMZ+5vkHxvOExRczG3CBGOZyLnYvjAls8yaQaCbQw4UfI+y2XD?= =?us-ascii?Q?nE2GexZgKuU1WakaWIv1dW8gq9Ql0V/3zr14vce8BQnRAfNtg6d2+iacFHVj?= =?us-ascii?Q?hFSkT8905c2mTPwLYoqjtoRZFKZ8YX/XHq2eWDOWIM9zNHdSkRxijSx39lDi?= =?us-ascii?Q?yEUTj5+uMTqkNpbAdnuNpf2j2jjribzLQ2lKbZpDP2o5CCH/LJ2emotU1dxf?= =?us-ascii?Q?ZMwQ0BX/FH/G8Mbh+MRiGsO7n4oYHJx+ArxsdPQZ8TY5cDLDR1CMi8p1b5am?= =?us-ascii?Q?TLMMeexc/6GpWfncnv8xyXOAUXBuLxL4+LUGABo6gCPcymrcqLPjy3HWyYqn?= =?us-ascii?Q?OrUOFayMviQYSyGRDcY29aV60oyGFSHH955a2MN8r6BQkybNIfKumhavB8Ze?= =?us-ascii?Q?mKe/KRf0LsfVgIQ9jbWqNg1kz7mvHDqEdLdXNA7pQYevaKB9xuCEmPDBoXo2?= =?us-ascii?Q?5iMirbMvTChi8HmwX+ImN5amDJ+jk//hQcXMhULIWkMu7/R8hxS9YNGbt2o/?= =?us-ascii?Q?D4zFgP8JTl2mEJbVMQNWO3To0HBXuUb7pvYvCzvkK+jnk7V1wf5+br3qoLDC?= =?us-ascii?Q?SUpX5tBfVuW2QzcYHbjE2u6luh/8Z/VsHBbaiip4qM1JFNGhQbHB5WXCKAeP?= =?us-ascii?Q?cTkZOmN4LA816w+QvMBW/nDIH9Iyi8Q=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 04aaf308-f678-4f23-cbc0-08def23b90dd X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2026 15:17:58.2820 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jx1TzKoDyouzp+i3bCLvrMJfik5ZZv3KnvDQHt3OzhEs6sA4ZZbSqWcl+dH1C77qirYFB/jFbMdqrgKzk85yN6X9FkVmjrc0wPXHlckmx/g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB10317 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c200::1; envelope-from=andrey.drobyshev@virtuozzo.com; helo=DB3PR0202CU003.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @virtuozzo.com) X-ZM-MESSAGEID: 1785856770163158500 Content-Type: text/plain; charset="utf-8" 'qemu bt' on a coredump takes significant time before the first coroutine frame is even printed. The bulk of the delay is resolving a name. co_tls_current is a file static variable, and CoroutineUContext is defined in the same compilation unit, so resolving either of them by name makes gdb expand every symtab in the binary. Look the static up with gdb.lookup_static_symbol(), which is served from the gdb's in-memory index, and scope the type lookup to the symtab that comes with it. This significantly speeds up 'qemu bt' processing. Signed-off-by: Andrey Drobyshev --- scripts/qemugdb/coroutine.py | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/scripts/qemugdb/coroutine.py b/scripts/qemugdb/coroutine.py index 3e0b37b73ea..21ed7cbaab8 100644 --- a/scripts/qemugdb/coroutine.py +++ b/scripts/qemugdb/coroutine.py @@ -313,7 +313,16 @@ def bt_jmpbuf(jmpbuf, is_coredump, detailed=3DFalse): dump_backtrace(regs) =20 def co_cast(co): - return co.cast(gdb.lookup_type('CoroutineUContext').pointer()) + # Unscoped type lookup expands every symtab in the binary. + # Better scope it to the symtab of the ucontext backend + sym =3D gdb.lookup_static_symbol('co_tls_current') + if sym is not None: + co_type =3D gdb.lookup_type('CoroutineUContext', + sym.symtab.static_block()) + else: + co_type =3D gdb.lookup_type('CoroutineUContext') + + return co.cast(co_type.pointer()) =20 def coroutine_to_jmpbuf(co): coroutine_pointer =3D co_cast(co) @@ -416,7 +425,8 @@ def invoke(self, arg, from_tty): co_ptr =3D gdb.parse_and_eval("qemu_coroutine_self()") else: # Fallback to use hard-coded ucontext vars if it's coredump - co_ptr =3D gdb.parse_and_eval("co_tls_current") + sym =3D gdb.lookup_static_symbol("co_tls_current") + co_ptr =3D sym.value() if sym else gdb.parse_and_eval("co_tls_= current") =20 if co_ptr =3D=3D False: return --=20 2.47.1 From nobody Tue Aug 25 09:50:53 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass(p=quarantine dis=none) header.from=virtuozzo.com ARC-Seal: i=2; a=rsa-sha256; t=1785856775; cv=pass; d=zohomail.com; s=zohoarc; b=YVavPFFAY8RVmAMk7wqbnEjb956iAr/aAQeqZuGpUuhGrcE93Ntot/6yI4M0dOA2oGJ/lfMkdLlk7A0UYqX5/NuqaDVd3Ou2TVJzKyysKVDLd0y7zyFQjVGo0QzGaiEssZJEDRCtSovRqQqrv2U4z5Ex5p8QIdpVfAg2yv+Li64= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785856775; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=llIjZRimUjn75xGNJcp5N0ySW/EWYaWzILlqXl18SmU=; b=gbDMIl4NU/DjPaI7f4RAe1ARrZ+hrf7ZjRpdz3utJyc2RUnAeuroZni4ZfKJYviGJXd7rD2nJBfWtLmw9mR5xvhieSZK+vjJE/LhqLf9BOhTSw6Zk9b0cg6WHgd1AsWFNTyv/unGSlw51dtsfQrHRjWmfEAZZx9eyGtjy4gsFuo= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=virtuozzo.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1785856775190825.5867554493923; Tue, 4 Aug 2026 08:19:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wrGuP-0006fy-Po; Tue, 04 Aug 2026 11:18:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wrGuL-0006f5-R1 for qemu-devel@nongnu.org; Tue, 04 Aug 2026 11:18:23 -0400 Received: from mail-northeuropeazlp170100001.outbound.protection.outlook.com ([2a01:111:f403:c200::1] helo=DB3PR0202CU003.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wrGuI-0004md-LF for qemu-devel@nongnu.org; Tue, 04 Aug 2026 11:18:20 -0400 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) by PAWPR08MB10317.eurprd08.prod.outlook.com (2603:10a6:102:330::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.15; Tue, 4 Aug 2026 15:17:59 +0000 Received: from VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8]) by VI0PR08MB10656.eurprd08.prod.outlook.com ([fe80::4e37:b189:ddcd:3dd8%7]) with mapi id 15.21.0270.016; Tue, 4 Aug 2026 15:17:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bOSan/rIzhg+SoQ95FA+J7AV63vJxiwuThaT50z7jVk46kEAByNXut5mcGxXb9rF9jB3cfDS94bM9PnZGUGrxKTZj4zUkmYwZ47mlvAOxF+1MzJ0p+C89poK71lBAsm7hUCl/XDm1wBRSDy5XJ+wBvSyDmH8lvL2iS513laZVmyXr1KJ4Y4NKueppqnitl0efwYAL1H/tKW5cViYd68S6FwI1hLFwOKigl6R92/0iwxpIW33m+W8dLBAiekprOhSy0BJ65YCqK1ZOyyUAH3qwRz4HSD95IIBjbM8kYlKxBJ6xQHeudy+kVB7WlI7aWqPxtkzCFCrarN8cEKesQfI5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=llIjZRimUjn75xGNJcp5N0ySW/EWYaWzILlqXl18SmU=; b=S0zzE1l79VaARqRHEQoyzOPitNl1fRLQRqkiclswY4vYp6If0dCskB/3Bc8EG2fLuikfMXX42wgUBEAvGGLH982nuDXfsD+Nz1Rw5V3kvFFKetVKDXskaelOENQV3RlxDpP+WsYgB+O2yWAx5puPiXNnxnmrR4mO0Zkqlcvgzdx7H2cBt49WJPhrnBYAFlmCSA1qQgXA3a7778PBuyZNtBfLDt/cSAvOeTaWnssexYPMC6u4t6leo33r87XIBPcyaT9pEMO+VCsHCgXoCX5S7YEa364CjmESmcmePH7XA0PefhO9oFJd9IVwqrsTwCkkcKAmyHKM+zy3Egh4tamYEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=virtuozzo.com; dmarc=pass action=none header.from=virtuozzo.com; dkim=pass header.d=virtuozzo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=virtuozzo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=llIjZRimUjn75xGNJcp5N0ySW/EWYaWzILlqXl18SmU=; b=SA+yrhWS11GQdhhQycqXGq0p9EinazYoY+wIjVYFlaZ6ofIZTfo/GnV/VuSIG9Oe9T1vmn6T5JEjJcQJ8RCvBgoimFNc7tW7M4iwzAGv+wl1MvfL+jImfbI0eyPBFWkhwVdfWbjDjgY0+eimVoAhd2fMzTFTJhXiXRrbLHvURaHJvPKN5HZYbptcYLU7yhY5GJCsdeXVAJNFYSz3zgQw9aGscDi0bDA7f4ocIWJLNbrqnY8Vy25DSqMlbp6612trrY7tjtUQ0ZVt8gZSLryM4ajFdgkkUbdAua7wah77iB+cBc60S9LdJH5uEGKiot4zhk6ygPjVb4d7/gdnOT4xzg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=virtuozzo.com; From: Andrey Drobyshev To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, kwolf@redhat.com, peterx@redhat.com, andrey.drobyshev@virtuozzo.com Subject: [PATCH 9/9] scripts/qemugdb: coroutine: Don't touch the coredump for a plain backtrace Date: Tue, 4 Aug 2026 18:17:43 +0300 Message-ID: <20260804151743.937694-10-andrey.drobyshev@virtuozzo.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260804151743.937694-1-andrey.drobyshev@virtuozzo.com> References: <20260804151743.937694-1-andrey.drobyshev@virtuozzo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: VI1PR09CA0148.eurprd09.prod.outlook.com (2603:10a6:803:12c::32) To VI0PR08MB10656.eurprd08.prod.outlook.com (2603:10a6:800:20a::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI0PR08MB10656:EE_|PAWPR08MB10317:EE_ X-MS-Office365-Filtering-Correlation-Id: fa30f3c0-b036-4499-d3be-08def23b913d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|1800799024|376014|23010399003|366016|38350700014|6133799003|5023799004|10067099003|56012099006|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: xrfgjym89CMphXABJ8AMfoKGEpGsdb2dFTgXKSSEAZTCYJ4Zv6BpO80PKDcMJ/kzsuIrYuoenwixKnraEbj2Lh4uR68KKOVAQT0gSk8pTVsgMGa4zBkKyWja6e6HZ+0xYBFuFt0sT+NO9f4cb8GJyqjcBeFnrPOshhsl4T58kPHszfok5V4UX69YQ4OHACUBnyiB8O91/viQdceK3rDECUCN5OS+kVcV9Bqy6qFzgB7kVlUCICe3/79oA0XVCQgU6Y+eU4vM76Sbb/7KAR5SYBGE+5o+0SSHoLSNSpL77WbYCr+XdJEnRh9/UwdcDK76IZCjfm8jRaSSK3o+vQWuV/eUwBcmwSoskEHhjs9qB1CvY21q9tOM50qkYDhf/Kf/3P8a8zUtDxp9W+CAfr+ksg0habKkNvI//sJhXpBXlMdu9X2F0Mx9kFwRsuoFZzJzJCEQZbgDqU0hTMZq63swcdb11S837F+W0OV9oh/nrt1Y0UCoEXbCNKXkToun2iK2dNM7valuk6nkXtk4NhlLqgSZWGOA4d/pHQgziD0qbxZ7NjQGYMuzpo1THUtZPN1F3vlfogdKW61XaYqy3tkJTNRjWQvwmRRGedYpRwlZ87kfhm+RS0hl3eATjfG2BvrE43KaRV1K7nYUtOav846RriYO2iYq9vMwO3TJL5ArWitdem3VqwQasppbtYh+MZ4F5IHglPB9ICBhLwL4mnkLPszzWH895e61fIkP66a46HQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI0PR08MB10656.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(1800799024)(376014)(23010399003)(366016)(38350700014)(6133799003)(5023799004)(10067099003)(56012099006)(18002099003)(22082099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gbc1zDKgBoWDN6O7MPCpwCSM1J2MiapbRsWp59/45eNEIZScwRh30/D+bNjD?= =?us-ascii?Q?3k+jDwGtzyQzV2zogWQ7MdeavmyP1RE6naAnKA/+VDXIx+WWQsLItwLkjMlt?= =?us-ascii?Q?RGuOFVlIue5A3RkNtpKtnvUEvEK+3rIkPPcWQK2FbXZ183ff9K/RnWBhS4ch?= =?us-ascii?Q?jv7OorFaV7NHOT3m6PsKCt+DS3YYiMjmRh/eJdKMHR0FjqAGHU80KCCLu+5+?= =?us-ascii?Q?DONxM5z9rDNB0IW/fs5aKoeSHB7bYO4iXcskymaE32ECvCBzI5rrjXrHy7IE?= =?us-ascii?Q?vYtQ64WpOVfbawcpc0CUSSYraJjDc9ef3BOUziDfk3FnCmvKTpQrxm2NFQHv?= =?us-ascii?Q?RnBbG5J3g79BxhlPKzLRBXt91dNyhD7lbpOCFowIwoxh0C+lBqSAdxJ9OwBy?= =?us-ascii?Q?HIw94cjVZhYK9wYZ0Qr/J305vlvLTb9/+EUlX87/G0CFSx9utRVHnZNxOlum?= =?us-ascii?Q?ZOBtT4HGNfY/xPmh1Vcis4QrXiGUoXSMKD7uedGhExgnE0VZFrjin/YM5wzJ?= =?us-ascii?Q?7mlcudZyzZexTTItoxTuNrRAvEXNuBZkh6o9wdyW0ca7lT0+ifOZ4I9n3B8F?= =?us-ascii?Q?KCP9/G8K2l55k249NC+YDXvsOAIubu3OtmBlCYV6BC8YSZ2aTQfIRW2jbrlM?= =?us-ascii?Q?bVjlXYAbwicazPValQoe+sgkZyR5XL0LzYaZkKaQN6PVZ/GFXpyNbjbuwh7S?= =?us-ascii?Q?BlUr4oetYsBKESMT3W5iOG3Vm2t4ZLMm47Nj+AU3l2pmqVddsF70FYtqkuyJ?= =?us-ascii?Q?GDZEW83OSjAHe9yPpEvdiYVD/7vDiaR7+9kAyQ1Lot8WinX+Xl3uDxAyrZhZ?= =?us-ascii?Q?QDbVoAW1rLmJ/kTCn4ejHQ47CuDGoYvb/EL2eZJW88bR3OTOLn2eO1V4waQO?= =?us-ascii?Q?rjfzb3hPiLb9jFPpPYTjLXthaEUoo9VCG5pgsYRb9d+TDLrFhfTiWtA2QsXk?= =?us-ascii?Q?MMLUmguTK4P4+EkMLTYgFsI691VeAYQT+j2sTKjGI+kynKEFVIQBxYHFs23P?= =?us-ascii?Q?MRC59bRzDtNlV6p57sFBGud01J5D9V8Impyl4MvzlDh9zob59Eon6ynU+Vwt?= =?us-ascii?Q?YM7qTKTBSC00Wl/ekuMCk2N3KPCJNH2wEKtjRMf6CG0mS83St5K4d5Cak2T5?= =?us-ascii?Q?cTF+zl/mg0kfqu4FRXokypLsCWtV+7v3mT8p8a9vTcmuXWA1zmnFOryp03Vg?= =?us-ascii?Q?BptOP9mgvrcv27e6nhF/YOw8vqP1QhDz9tzBc0sZe7RW+ZYinXkxXZ/MR6vO?= =?us-ascii?Q?hfTvCjCv9dpqDqSa3B1k7yKrG18kOPF6pnfGcUJbrS9RI+1PDXi3HTshh0XA?= =?us-ascii?Q?8an1htO5RYCbBjngJPSKEGSKrLiBwPOvMD1rXR7SCM+FV2ZC8IHB34tDAm1y?= =?us-ascii?Q?VuYYTLoGQfljNkbesdLkJ/4MZ1A50FzUKhvlEzRhBbFTy4hoCXVNi9JM81cf?= =?us-ascii?Q?qHN3r/Rtsi2J36wDFH3Bde7Lw4tLb0Nt5UEhevGHjhORX6bjdAi2w7R3Afus?= =?us-ascii?Q?hMkJ9hvXv2MuJUvYIKsSyZ2CGAzyEQLX0N3sYk1fZ9UCBGVqLG4mOmBleiDq?= =?us-ascii?Q?fDGjKI1PRWYdJpOCMN9KDoJunPTR39nI6fyZg7wNALnXG9cO1jPZ0b+z3W+y?= =?us-ascii?Q?Pd5wWcPYXatzpCBl22rndIuxN7GWWVuPFNGSswedOXZfSTL9PNMpCFfD6bzJ?= =?us-ascii?Q?NvLAtm7FW2VQYfz4gIcXGwJJ2Kn9rcPvHpDe9VRyUlHnHX9TeTgAD+sP1xSe?= =?us-ascii?Q?4sw3hUY4OXKVU0jSS0/oL/oigcwjlj8=3D?= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa30f3c0-b036-4499-d3be-08def23b913d X-MS-Exchange-CrossTenant-AuthSource: VI0PR08MB10656.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2026 15:17:58.8597 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B06VveUPodAGV0DiXBlF7q3tvoYDYgCN8bm3+u0qpYeOo4Ht3XOUDJ8REg5isjayCq1zhTD0Od3wBrZU8BQIN4AEzOwmRslDTGcgbLTsPS8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB10317 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c200::1; envelope-from=andrey.drobyshev@virtuozzo.com; helo=DB3PR0202CU003.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @virtuozzo.com) X-ZM-MESSAGEID: 1785856776206158500 Content-Type: text/plain; charset="utf-8" init_coredump() creates a Coredump object for every coredump session. That implies opening and scanning the actual coredump file. For non-detailed 'qemu bt' invocation we don't really need it. Les't only create the object when the core is about to be patched, i.e. for '--detailed'. Fixes: 42f3c143c3a0 ("scripts/qemugdb: coroutine: Add option for obtaining = detailed trace in coredump") Signed-off-by: Andrey Drobyshev --- scripts/qemugdb/coroutine.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/scripts/qemugdb/coroutine.py b/scripts/qemugdb/coroutine.py index 21ed7cbaab8..edc1f3cc69f 100644 --- a/scripts/qemugdb/coroutine.py +++ b/scripts/qemugdb/coroutine.py @@ -328,7 +328,7 @@ def coroutine_to_jmpbuf(co): coroutine_pointer =3D co_cast(co) return coroutine_pointer['env']['__jmpbuf'] =20 -def init_coredump(): +def init_coredump(detailed=3DFalse): global coredump =20 files =3D gdb.execute('info files', False, True) @@ -337,7 +337,8 @@ def init_coredump(): if match is None: return False =20 - if coredump is None: + # The object is only needed to patch the coredump + if detailed and coredump is None: coredump =3D Coredump(match.group(1), gdb.current_progspace().file= name) =20 return True @@ -372,7 +373,7 @@ def invoke(self, arg, from_tty): if gdb.selected_thread() is None: raise gdb.GdbError('No stack.') =20 - is_coredump =3D init_coredump() + is_coredump =3D init_coredump(detailed) if detailed and not is_coredump: gdb.write('--detailed is only valid when debugging core dumps\= n') return @@ -381,7 +382,7 @@ def invoke(self, arg, from_tty): bt_jmpbuf(coroutine_to_jmpbuf(gdb.parse_and_eval(argv[0])), is_coredump, detailed=3Ddetailed) finally: - if is_coredump: + if coredump is not None: coredump.restore_regs() =20 class CoroutineBt(gdb.Command): @@ -413,7 +414,7 @@ def invoke(self, arg, from_tty): if gdb.selected_thread() is None: raise gdb.GdbError('No stack.') =20 - is_coredump =3D init_coredump() + is_coredump =3D init_coredump(detailed) if detailed and not is_coredump: gdb.write('--detailed is only valid when debugging core dumps\= n') return @@ -441,7 +442,7 @@ def invoke(self, arg, from_tty): bt_jmpbuf(coroutine_to_jmpbuf(co_ptr), is_coredump, detailed=3Ddetailed) finally: - if is_coredump: + if coredump is not None: coredump.restore_regs() =20 class CoroutineSPFunction(gdb.Function): --=20 2.47.1