From nobody Mon Sep 28 02:07:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1785514886; cv=none; d=zohomail.com; s=zohoarc; b=IxP2PB1nda+xj3d4yLkDjN6qhmqcDJgNpsGIqZtQftFuycxPoevxlfCcn99t3aRpFPlgPi9gCD61kSODN/tM3WQ4rKHovSKmgba+R2mw+2KvAQpBt4E+SB6ifce/0fXeFpFrcmYhH8g9g+Ajv5rWcjvyjt1Nh89NSVghja44zAg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785514886; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=BHKzpHIUye2WTFtFvbffFyBvvLiRS1+zoQg46eAos8Q=; b=f589TRM+Th4v1kF6JsDisqnVXJaLOJsz33eBU4ILeSyqISAMWQoBmQJX1aTLwJSnwS2+kDyOlPV4J6KUfcaRnc4eeXEppbaMlB+VpZ9oZJxUfMdOUE55xPrt9ZzQ8sBueNQdaWd8ihBthF29l0QZY9TUhGdHbwjRLkDn+disJgk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1785514886490288.5388042042408; Fri, 31 Jul 2026 09:21:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wppyM-0004nM-9P; Fri, 31 Jul 2026 12:20:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wppyK-0004kd-LH for qemu-devel@nongnu.org; Fri, 31 Jul 2026 12:20:32 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wppyJ-0000Rs-0C for qemu-devel@nongnu.org; Fri, 31 Jul 2026 12:20:32 -0400 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-47de008b020so839921f8f.1 for ; Fri, 31 Jul 2026 09:20:30 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd45a0c8bsm6328593f8f.34.2026.07.31.09.20.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 09:20:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1785514829; x=1786119629; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=BHKzpHIUye2WTFtFvbffFyBvvLiRS1+zoQg46eAos8Q=; b=m3w9Z9XyRhpR+k0npkOsoX1pAjdGVndhYlOeCXidyhWsd8IpiYCvLUYFh5+9AwSvJ2 bdWOkxeGr8ckdM5d+EiAh1s3K5rY+8gQE/vtor834BCCoJyBudjaOmaf+Fw7ih3s3bOr w7s661T6KZnpVADVNwOLdxGBf4R+G9bFtvhfGJlnR8LTqligtZvcXencnCKVBaEPYd6Z S8Gz2WyC7V0VLkgsgFA9mkTLYEuu4uKnwW+mv1IdA5sA2AOk+gZF07TOP/w4F7HyQNc9 B6HPie+oroXGU9UsthM70BcZNV5eAzaKCeYaDj3izVDL8wd9SYPZN9IL4Dp9YOfH4Ic7 +bVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785514829; x=1786119629; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=BHKzpHIUye2WTFtFvbffFyBvvLiRS1+zoQg46eAos8Q=; b=BTkY/MIHuZh/ZMwMG3r8V7TbnjI9UCxrgwDocMgNWlEk3jsDewscoQqMqCTMvWIVPA 2hPY73sb+ptT04BTq/GkQR55G85DSvnG1Y7SeZsJKuO5mMP94wypFEeaqbQGm/EloTN/ CQDzL06XAgKr3tiRabscg/UpMZpnyhDvV5doHwAykMoaINr84C0Ens7bEmM2IedlbHce yNcbwLLwuGGqBuO0qnV7980fZ4RjSwfbXdOVSSlXgF3TGyYnoA66vmmBsn4GtXJ4qHFh gtUM0Eqn5UZlRtFsyBXWjhPUERPu4bKZVcW3FK1lGcCzXZvxdioP7J2THoT7KOHX5xLK YxXg== X-Gm-Message-State: AOJu0YwqGVTTlixxgpo9YrZoBOmeraHeJyrIj0d79qkvcid/715pSR4C ke5h7yrnBRi8qM5wd2gFCcNsiwNDTLJ0x6J6GXrnMF2w2YtUDdl23ezDmierSwTvVMndmfnHm3a ptf/x X-Gm-Gg: AR+sD12+utTgNFM3jIa5EZFsjxFzKExnvGXxHT6zkY1qM2c5sdEoxYg9PxkndnEfUzj eVy4kMgCgykNfZf/eaIysU4DNSVHeaURL3N7Xt6lnjXRz2jaNW6tnAXBMr5UMuKOvD/3Uj7hKBB 2el9sHRHEq1jV06tE89rFXO4rG4GUOOxphwWmckOffFsoYElHCZ7jwGOjKc4HLp81lzdP/wXOkO z0UOOOvUpauGKT3JJRoHDR4mjvraCTaRVk0sTNwQecJgLJSNpir5RT3DQDzMIN3VV9wimEk5EOo 0X5iCer571TK7+WBx+OBp1JojDDcYUGHWq54SKoPYht5AAksHO75TMTlrFQ+LPeDeqbmmhm4sot ahms3q3Y2uM40HfDxVXTNEKkRXCZOThu0LXtPLyzEkdDRkQeVFfhAWGh5IDMOnRZI+4gOSdphnN +BgDu/oIsYmIKVHjPzb6xZw4Xv8ezvkp3wPuxVUWpGn2Jp2igTZyRldCiF75S2z3n9vmE/EDdlK yVeowO58upYZhqNQeMUkLq0+IyVT9QN8FzxMx+bpwgW7P98reXz9u/FdjyuIxuF4o6r7g== X-Received: by 2002:a05:6000:4698:b0:47f:96e3:5322 with SMTP id ffacd0b85a97d-47fd7264c9amr486451f8f.7.1785514828873; Fri, 31 Jul 2026 09:20:28 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 1/4] target/arm: Fix b16b16 feature test for SME2 BFCLAMP, BFMAX, BFMIN Date: Fri, 31 Jul 2026 17:20:21 +0100 Message-ID: <20260731162024.3097467-2-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260731162024.3097467-1-peter.maydell@linaro.org> References: <20260731162024.3097467-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1785514888634158500 Content-Type: text/plain; charset="utf-8" From: Richard Henderson These are controlled by FEAT_SVE_B16B16 not FEAT_SME_B16B16. Cc: qemu-stable@nongnu.org Fixes: bc65d2bd1cb ("target/arm: Implement SME2 Multiple and Single SVE Des= tructive") Fixes: 930760eb753 ("target/arm: Implement SME2 Multiple Vectors SVE Destru= ctive") Fixes: 8b61eff8e72 ("target/arm: Implement SME2 FCLAMP, SCLAMP, UCLAMP") Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- target/arm/tcg/translate-sme.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/arm/tcg/translate-sme.c b/target/arm/tcg/translate-sme.c index dcc4690fba..0794794e3d 100644 --- a/target/arm/tcg/translate-sme.c +++ b/target/arm/tcg/translate-sme.c @@ -756,7 +756,7 @@ static bool do_z2z_n1_fpst(DisasContext *s, arg_z2z_en = *a, return false; } /* These insns use MO_8 to encode BFloat16. */ - if (esz =3D=3D MO_8 && !dc_isar_feature(aa64_sme_b16b16, s)) { + if (esz =3D=3D MO_8 && !dc_isar_feature(aa64_sve_b16b16, s)) { return false; } if (!sme_sm_enabled_check(s)) { @@ -793,7 +793,7 @@ static bool do_z2z_nn_fpst(DisasContext *s, arg_z2z_en = *a, if (fn =3D=3D NULL) { return false; } - if (esz =3D=3D MO_8 && !dc_isar_feature(aa64_sme_b16b16, s)) { + if (esz =3D=3D MO_8 && !dc_isar_feature(aa64_sve_b16b16, s)) { return false; } if (!sme_sm_enabled_check(s)) { @@ -1850,7 +1850,7 @@ static bool trans_FCLAMP(DisasContext *s, arg_zzz_en = *a) return false; } /* This insn uses MO_8 to encode BFloat16. */ - if (a->esz =3D=3D MO_8 && !dc_isar_feature(aa64_sme_b16b16, s)) { + if (a->esz =3D=3D MO_8 && !dc_isar_feature(aa64_sve_b16b16, s)) { return false; } if (!sme_sm_enabled_check(s)) { --=20 2.43.0 From nobody Mon Sep 28 02:07:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1785514853; cv=none; d=zohomail.com; s=zohoarc; b=elmBbgi81dFjajb6c4tTGDTWD3abVX7NyyNhDGwoRt3ACb50ylb+uzWloQ8r85VsuWOpLryplIF/xbDssAJp+bgx7ZKH6Axdp4pwNkjrcSNQ6XgrsLY9CESE+MMcow8O2M7EmRDdf8btKf5xuzTltttNyTcwozWxcOwd4wQ+cv4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785514853; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Dmffb3ULkb7vIrdJ/QxkfBW61OXPmSDopnqZevPnXk4=; b=DHSBxXSMSuJ5glCRnku6V+4sy+SrHG1ajZyJsTdJ4avXAt7FGPEX1hpyVtByTH0sYiLTL5mQ7JLrFU1809LlvY+LHJjrokBjllKwczTGEmckFTGdio+WCkUORCGzUQ2O9jJhE0pywq9ohCCoPPaXJicLrt2E4Usr9Oy3B0U0gao= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1785514853544182.46896076039968; Fri, 31 Jul 2026 09:20:53 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wppyN-0004nv-RS; Fri, 31 Jul 2026 12:20:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wppyM-0004nO-AN for qemu-devel@nongnu.org; Fri, 31 Jul 2026 12:20:34 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wppyK-0000ST-DT for qemu-devel@nongnu.org; Fri, 31 Jul 2026 12:20:34 -0400 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-47f707e5d75so923784f8f.1 for ; Fri, 31 Jul 2026 09:20:32 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd45a0c8bsm6328593f8f.34.2026.07.31.09.20.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 09:20:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1785514831; x=1786119631; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=Dmffb3ULkb7vIrdJ/QxkfBW61OXPmSDopnqZevPnXk4=; b=eMCZ5CVBUTwOnQPpUfi6L1rlMMCdj6iERgDiRzpxoJN4vLJAQyJQM73ohITK7ooO2M BY74u9UsEnU3T1fyWH1+sCMsTEP0dzZ6Vs1ulo0EpjwmcZkN3DHDZt3N+ohrjJHUpGhE +hDP+3CHnEyAaAe2IpNzeLCvLVGJ5XbKZfTaQpnrsLHKqRDkwrl/e4IYNl42QQ79vBfr vNkmB3TnJU+K7wJv8+GHXouVrzl38zuk39aY3VINx7bW5shxdVITsMrzSuVy4ZnBvm/Q Uq1YzxYVzEAKAWgJQ9Fr8MVPVihbjXB0PxHxpz6zpMVq9Hgozee17BtdKBHL1+VwtzDP G1FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785514831; x=1786119631; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=Dmffb3ULkb7vIrdJ/QxkfBW61OXPmSDopnqZevPnXk4=; b=Al2WH2zz1sSfoC1goAWHxKpuv5yUEa75TwKRMIr27GhHqbzB4Th7AoVATXnWPr6z+E 5RvUO9N0jyzIOTwUxcWDp2sUIj2NMlJde/aI43hxSGIuPP1OeGm8AXnQtxxAbfBkyAZY 7qz8HhvR33Sx++IQkzyTSIvw+5lvnqc52ZQbyaCBgUjwu1aBivFVs+R/tQUTLLurCiFm 6uZDrcxwMBfZniaf+U2xUG4bmvny+QqqCm+h+lhvGkqOHcKRKLWcc3YzWSzBolvfoQkT vN2u7CWubuFSQ3hIFWPbwdMqWB/pB1b1pKwW/cnuOAYidqO52wyIPPSVj/wpJFuZ7KHn xx2Q== X-Gm-Message-State: AOJu0YzuTPBrBr7XUVgslECGANZfG17K1jk4cquDTObT9k2xanSIaIeZ EKsp0hgJCDiXt8Fixl+nq8CvmWLnSaS8FBWaJgHaHif05TxcZr9OydjF+gk5k7dUImCgV7Gaw50 1JgbU X-Gm-Gg: AR+sD10z49ybMjcDpqyZZTMUtvierK1CoYPuK7RubSoY6ZxJiMKLQvyi9pmMC7VJoNF IHzTUpnQIrJkduq/c8RMZWjNQM459u9Jsk/G0//jwiTdQBl2fcVFOm9L71vaVY/Mif3vQEshpzE Aet20B+XuakvprX385v3OyyL+RW3UTNH9/E1mC6ZZnLXRw8kF5kPiUvC4BbZmxq61Z62VXat41l gCD/UR05rfMTwPYy5MnN0dg+FmHdBds243Ofrz938XefEI0lw3walJFZVTALUBKnaoC7XH4oA// ISQ8pdy7lP4LS1xILVlUBQXo02wVULsKaZ687uLxZ/4tGXkbR8iINmjzoVFfhOAOxJhF2YDktQ4 hpRz2l4fDVdm53n9+rrpw1dV2XspRdgQOXontxmVB4+7UZJGM8kNNdvgLOZ72cUaBhX/Q9Vn50c kNveH/60fW+pNKWxIaA+ZZ6AawZsYLuhzQBJQwBLnTpHENZvqdidTWao6HC432t3VkExY1kyx29 +nxebSZqBDdzAKfYO1xv87Y1/v9nRaAUMWeySX3zH1nu9FcnEW2gWSuAMpXbaxd/0r8AthoTNHG u8ec X-Received: by 2002:a05:6000:24c7:b0:47f:8b23:195f with SMTP id ffacd0b85a97d-47fd731f513mr514057f8f.46.1785514830411; Fri, 31 Jul 2026 09:20:30 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 2/4] target/arm: Don't NOP the SEV insn on v6K CPUs Date: Fri, 31 Jul 2026 17:20:22 +0100 Message-ID: <20260731162024.3097467-3-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260731162024.3097467-1-peter.maydell@linaro.org> References: <20260731162024.3097467-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1785514854623158500 Content-Type: text/plain; charset="utf-8" When we implememented SEV to do something on A-profile rather than being a nop, we got the condition slightly wrong, and made it only effective from v7. In fact the instruction's Arm encoding has non-NOP behaviour from ARMv6K. The effect is that a kernel boot may hang on a v6K CPU like the ARM11MPCore. (This wouldn't have been so noticeable if we feature checked the WFE instruction, and had made the same mistake for the condition on both instructions. But we never have done the feature checks that we ought on WFE, so the mistake on SEV meant that we showed the 11mpcore guest a WFE that did something and a SEV that was a NOP.) The v7A Arm ARM is not entirely clear about whether v6K has the Thumb SEV encoding or not: it says "ARMv7 (executes as NOP in ARMv6T2)", leaving v6K not stated. The 11MPCore TRM says it has at least WFI in both Arm and Thumb, and the v7A Arm ARM uses the same condition text for WFI, so I make the assumption that WFI, WFE, and SEV all get their functionality for both Thumb and Arm in v6K. It's possible that this differed between v6K CPUs -- the 1176 TRM says it has the v6K STREXD/STREXH/STREXB etc, but the WFI is the old-style cp15 one. Keeping the condition check the same for both Thumb and Arm encodings is the conservative choice: if guests try to execute the Thumb SEV insn it will be because they want SEV, not because they want a NOP. Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/4044 Fixes: 60e7ee5bb7cd ("target/arm: implements SEV/SEVL for all modes") Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20260728111629.1705308-2-peter.maydell@linaro.org --- target/arm/tcg/translate.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/target/arm/tcg/translate.c b/target/arm/tcg/translate.c index a1fc050618..6e52ad082e 100644 --- a/target/arm/tcg/translate.c +++ b/target/arm/tcg/translate.c @@ -3246,12 +3246,19 @@ static bool trans_YIELD(DisasContext *s, arg_YIELD = *a) static bool trans_SEV(DisasContext *s, arg_SEV *a) { /* - * SEV is a NOP for user-mode emulation. For v6T2 and earlier - * non-M-profile cores this encoding is a NOP hint. + * SEV is a NOP for user-mode emulation. The instruction is + * also a NOP hint on cores that pre-date the architectural + * feature that adds it: + * - M-profile always has SEV + * - for A/R profile, it exists from v6K onward + * The v7A Arm ARM is not entirely clear about whether v6K has the + * Thumb SEV or not; we make the condition the same, to be + * conservative. (If guests try to execute the Thumb SEV insn it + * will be because they want SEV, not because they want a NOP.) */ #ifndef CONFIG_USER_ONLY if (arm_dc_feature(s, ARM_FEATURE_M) || - arm_dc_feature(s, ARM_FEATURE_V7)) { + arm_dc_feature(s, ARM_FEATURE_V6K)) { gen_helper_sev(tcg_env); } #endif --=20 2.43.0 From nobody Mon Sep 28 02:07:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1785514852; cv=none; d=zohomail.com; s=zohoarc; b=i+hTM6Jv1tc1JH2Fe8a4fvyocjPxi5RbI094YZGG6XyQraqZtu2NbaFPv3JMXp5sMHWbcnTik2plAL+rReuxSxz85rkmWENiC0q0rh+awKhzT/yPTuVqEVoBIZiuXm52LFrGTCxgVjqxJMsSQTWEtMucpYbUSLW1DwkLjCj6/WU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785514852; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=P8y7FwywKZm7mMFJi3dJ5HYMr1USdH7jbbn4Vnp7ANs=; b=MM54s+4i2mgp0fEHG0V+MYDIbWfHDyynsWErtrOJT/DkMLKyuNfpLNdNBllMtMCwd3RYrwB+KsFtmLOvmq7Rw8HuO2NJClgL4wD1yi+oqaGrnqfYimOJS34tEz7F+HpAlqZOA+N7WrwHclOrAbBPGeh1W0JoAFhvT5MlGqk4DiU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1785514852208428.87406144741976; Fri, 31 Jul 2026 09:20:52 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wppyP-0004qI-Bt; Fri, 31 Jul 2026 12:20:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wppyN-0004nu-Oc for qemu-devel@nongnu.org; Fri, 31 Jul 2026 12:20:35 -0400 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wppyL-0000Sp-S5 for qemu-devel@nongnu.org; Fri, 31 Jul 2026 12:20:35 -0400 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-472326ca506so867869f8f.2 for ; Fri, 31 Jul 2026 09:20:33 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd45a0c8bsm6328593f8f.34.2026.07.31.09.20.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 09:20:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1785514832; x=1786119632; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=P8y7FwywKZm7mMFJi3dJ5HYMr1USdH7jbbn4Vnp7ANs=; b=oMAF8NtEtKox2jVOH8wA3GkScgR+5bemYYkGAQBd1hqm682dURBW7iOnB/aeKnfA54 KqOXDpFDNxgX7yV3T9SxMqoLdq2IK5r2B5hJ4nyezCuCJJFrZmSIqZW+/iv5V8x6xT0M evVLgfkfq6UqTmqRzPqsayawJyxT4l0O70Mivf5eeOKegob50rePgchlR7tWk2T8fLl2 GcWj62ItxUI71iuSskIyhICZAC+FN8QJuEb9vW+UFX1Kc8LR0LbChgpj0TCTfLzg7wON JP5HtfxCjm05NCmnV6PS6uQxGmTnHwdIkV1PTaLTaxPASs1XKiwxbC/f4cJraepoAYwH gUSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785514832; x=1786119632; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=P8y7FwywKZm7mMFJi3dJ5HYMr1USdH7jbbn4Vnp7ANs=; b=IZbBWGgDA90qz/ePHKLrbwz6EWeCcD55/zg8G0lCsiE2zACQpG3jB8vKos4N+eMvaH iFcjUndUsCvbFRYDrPolIuFwKqL9v3T444emlQ7DQaaq7ps51fRJjueLrT2fPs+AsVNX nACny+dClufO1VrzG8ErxexwWrq9tR5TKFgqxvLc2eQJE5vv0GnZD4A5e44opMAoEnAM /MgqYd8kTBHp0VpFoBjyi8nvglCEygvKYdAGh5iFKJ1gUwS3vgvg2rM2twMuXZGcYoPz Qki4xqLWaWNun3iMSQjxbycz1Nh8GKV5MZjUofUE6eVx2a3r2mEAtX7X4Q7yyQhKPWoU CNHA== X-Gm-Message-State: AOJu0YzKkP42c7n6ho9Q1qUczpCgUglCJhdI5XA36SKa1IVw5MhCAbla HX4wXUhxl4u/ZkzBRwdITp1qOkOVObR8dgBEQWKGh81+Ti1F93K2vChGZUU/Eq1DM3U1L05eKvH 8DApn X-Gm-Gg: AR+sD12fEP2TYX58g5eAKG8i294dhXfq5knn2lREwAaNOvEln5VqtMIz1ZvzbUgQB6a s/t2OWSltq7JeIOeu6fSbm/K4biEF7Fap0qjHr+WveKvjo2zAce4Yj0fTtQXuDF54E4HPgh3k8S 6g1Yq6iPuRoFL0ZNcxa2Qy/EGz3vRtYvVJFoWODVCps129d5mgiePJ0NkcVQEmzJrRkBY5dQBaW Nqx9RvUDWT9DVaHeCxB8pFUdw82RL+Rlp+cPEXvgXFVQjIYaBErpJXLpPsfhaN2T/DVrMKARU+K 30cFrsHOPfZIzpNjw7IiqQdBqGdaG3C7l79sxjBNjxrfjNGea2mLJkhFAEg0w3w9O4hNu7lZwBT owEMzbf7l7p6GuKh2aJTbsQzLemEynn1kqVdoH7CcFyCLuxipP0+DGuvPSBuFdy5mpyJYUimSLH 24jjLk2xO/Kbc94pg8EKPHv9MvDWG7WFNjnBKAKyeqgwrZEc8KrWctjnKkNT/rsIScXcHigpfoz NNQ3GWpkrlUzIe3QdGPYqQFrfFbCenykaJaUWhijPPi6sCkFFxONwlZTpbRmP1pCJvVOg== X-Received: by 2002:a05:6000:25fa:b0:47f:8f8f:e493 with SMTP id ffacd0b85a97d-47fd72ba69cmr583651f8f.3.1785514832237; Fri, 31 Jul 2026 09:20:32 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 3/4] target/arm: Make YIELD, WFI and WFE be NOPs on pre-v6K Date: Fri, 31 Jul 2026 17:20:23 +0100 Message-ID: <20260731162024.3097467-4-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260731162024.3097467-1-peter.maydell@linaro.org> References: <20260731162024.3097467-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1785514854634158500 Content-Type: text/plain; charset="utf-8" The YIELD, WFI and WFE instructions are in the NOP hint space, and were only defined to actual non-NOP instructions starting in the v6K architecture; they are also present for all M-profile architecture versions. We never did check the architecture version before making these instructions have their special behaviour. Mostly this has not been a problem because a guest won't execute one of these insns unless it is prepared for it to have its usual effect, and because we implemented SEV and WFE as NOPs anyway. Now we have implemented SEV and WFE to be more than just NOPs, it's important that we have the same condition on the SEV as the WFE, so that we either NOP both or else implement both. A guest probably won't try to use SEV/WFE on CPUs that don't implement them, but it is valid for it to do that and rely on them both being NOPs (and so a WFE-loop falls back to a pure busy-wait loop). Add the "only if M profile or v6K or better" check to YIELD, WFE and WFI. This means that all the insns in the NOP-hint space for A32, T32 and T16 have a correct feature check. Fixes: 60e7ee5bb7cd ("target/arm: implements SEV/SEVL for all modes") Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20260728111629.1705308-3-peter.maydell@linaro.org --- target/arm/tcg/translate.c | 35 ++++++++++++++++++++++++++--------- 1 file changed, 26 insertions(+), 9 deletions(-) diff --git a/target/arm/tcg/translate.c b/target/arm/tcg/translate.c index 6e52ad082e..055f3c5b40 100644 --- a/target/arm/tcg/translate.c +++ b/target/arm/tcg/translate.c @@ -3235,10 +3235,14 @@ static bool trans_YIELD(DisasContext *s, arg_YIELD = *a) * the next round-robin scheduled vCPU gets a crack. When running in * MTTCG we don't generate jumps to the helper as it won't affect the * scheduling of other vCPUs. + * This is a NOP hint on older architectures. */ - if (!(tb_cflags(s->base.tb) & CF_PARALLEL)) { - gen_update_pc(s, curr_insn_len(s)); - s->base.is_jmp =3D DISAS_YIELD; + if (arm_dc_feature(s, ARM_FEATURE_M) || + arm_dc_feature(s, ARM_FEATURE_V6K)) { + if (!(tb_cflags(s->base.tb) & CF_PARALLEL)) { + gen_update_pc(s, curr_insn_len(s)); + s->base.is_jmp =3D DISAS_YIELD; + } } return true; } @@ -3280,17 +3284,30 @@ static bool trans_SEVL(DisasContext *s, arg_SEV *a) =20 static bool trans_WFE(DisasContext *s, arg_WFE *a) { - /* For WFE, halt the vCPU until an event. */ - gen_update_pc(s, curr_insn_len(s)); - s->base.is_jmp =3D DISAS_WFE; + /* + * For WFE, halt the vCPU until an event. This is a NOP + * hint on older architectures, with the same conditions + * as SEV. + */ + if (arm_dc_feature(s, ARM_FEATURE_M) || + arm_dc_feature(s, ARM_FEATURE_V6K)) { + gen_update_pc(s, curr_insn_len(s)); + s->base.is_jmp =3D DISAS_WFE; + } return true; } =20 static bool trans_WFI(DisasContext *s, arg_WFI *a) { - /* For WFI, halt the vCPU until an IRQ. */ - gen_update_pc(s, curr_insn_len(s)); - s->base.is_jmp =3D DISAS_WFI; + /* + * For WFI, halt the vCPU until an IRQ. This is a NOP + * hint on older architectures. + */ + if (arm_dc_feature(s, ARM_FEATURE_M) || + arm_dc_feature(s, ARM_FEATURE_V6K)) { + gen_update_pc(s, curr_insn_len(s)); + s->base.is_jmp =3D DISAS_WFI; + } return true; } =20 --=20 2.43.0 From nobody Mon Sep 28 02:07:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1785514911; cv=none; d=zohomail.com; s=zohoarc; b=Qw+al/CgRTQAsfUw3x88EJBEyk6Sch8nDaGyqkmDerMdhJUFdRi/4FHuAW6GCULKkWXaNjAa7SPNOsBlTToczjHx93xzrFUVWSE1+JRyA1uv2ClFqkmT0aXeCSTLG92nxbAWIMlAHBDS4+osIwXXHpITuAWTS+3MoBVkD4GMy0Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785514911; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=FzYn4ydpkQH/vA7lgT61nvjD89r5G2v3Ua1oapSYA24=; b=Tsy17pglxEZwHgcIc+fylhRMUbARNzBD0J+/1c66qb1NE9A2ShSRw/5HcV8X50euvXFH836jh/XqEYrzovBnF2JyMoRTNFKRCFThm++wtRgIW3rrUQh3o8xeLA/HXjMA0tR/QFP3Eb/gyWvHBE9GzopWrdnb2Q7maVHkMW+jhks= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1785514911516149.3389600774659; Fri, 31 Jul 2026 09:21:51 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wppzI-0005Cm-VJ; Fri, 31 Jul 2026 12:21:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wppyg-0004wk-Sk for qemu-devel@nongnu.org; Fri, 31 Jul 2026 12:21:02 -0400 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wppyd-0000U9-7Q for qemu-devel@nongnu.org; Fri, 31 Jul 2026 12:20:53 -0400 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-6a0a4aa99bdso616670a12.1 for ; Fri, 31 Jul 2026 09:20:49 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd45a0c8bsm6328593f8f.34.2026.07.31.09.20.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 09:20:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1785514848; x=1786119648; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=FzYn4ydpkQH/vA7lgT61nvjD89r5G2v3Ua1oapSYA24=; b=G+KfNdJmjH0nqw3uK7WO+PSqvu8EgW2cx+dA2q4e/C/s+cwi7sQjHS0a9nmp/riynC om18VA5fyWbjeMdJ2wmqYxUjxJMPNrpgCuQ/q/WqNs0elbKrEMzxvApUUitMUpHheunu EOPYUOZWhYesmOaYWHcXN0BCvLusbqi/+/PovT1WCF8ddTuo89O/TN40byBipPG00zhj 92WtU98Ze22wp7J2nMIYDpDmY8Nl7bXGhp++Yh8lQwTLvVWPFNjkhKPPUUFRzUA/kS0K QLxXHU5BM+2Z5nGctxWZSoT9kH/3LOGyjtQ4hA0PxoT4N1ppkQg8t1P5493imWI+v45V j/2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785514848; x=1786119648; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=FzYn4ydpkQH/vA7lgT61nvjD89r5G2v3Ua1oapSYA24=; b=TWuUtx3ONvX1YAHf9O+Tzx/HP5mAQSImkxABYwfgZRRcOgiN+S4jwTtiXdSHzoVVuE XEzJ8yfNOF2EibR8BDgC9CJN06nlIRXF1WPA+a0WfzxHWm5goOaSstD6LXwTbQkjx4xw g9cR5DAYufLWbLE94YWwLb18egpZBKkGZuseJmyHARBuP1PmRi7jwG3jusOjDEUCbxAx Bme9b9M+DcwYG9MlAGvdKjFHQA4HXPV7vbviZmy2z5/iJOv+6mObRJUtOHeeIGK1xZDD KtSeGiWV4DFKRP0D2vbbP/g1Kg27PrVJoAFX6rh4/HxIdVBmY7/mQN2zn8R2R3nUDY3V 701A== X-Gm-Message-State: AOJu0YzK194XEI15XxIZ2zeAI6CIiqBucBVD/JUeLjwRYvtYaYm8peJi B04zLa6XIbab7QIonK6ztAsaO3d+Dnc/EA3T0m9SVrrUQ+s9JfMvvBSCMy9cx9UZ35/K5IjBu+e SyI6I X-Gm-Gg: AR+sD10mT2rvMiVxqf6uiXdIP0Q2KBz17pgxc3eFG1uy+Y2R4f9Tw09HbtSEGgDHyi8 i2XHSRA/103+7M7tL7DEKfH0LSunNIT++BUJmtIbr8GoHvD5AYC1rLVpWaXmPF3ggF56TFuBax6 4YFiCixJJikdc9utPkSWrCBjbq03C14pAV9N5h3SqRG5evvGNAJhPVyxdBwLgtsaeXkV81Br+Pn OpzgBXrAWBEgUn/07W69QWKmmtOigzgnkzBgFzgW0KY3NnNoZ1Hp2Xx0pRogjHb4BEbjd9PBlWJ TRlDgXyNoF162h31mIOor1bO7eio2Gw9a3G0Ex7qdbAoTMMZ8iu9DGrA2RJWvCsz831gChhiT5f 29CtgFd4J3iy309KUQmCqCwbkKCtTv2OtPVyephiUZqA9A1Z6VZEteN7x3YzddU9GAdHgyboBPW ot2FcSKZlF1kl4Jc1721GQJxqZmfc988sLwtOE40tb9B3XdkzvqS3z+9jOQCuB+vuUy7U/DxERi eONLmQr2o6J1ufMsNvMUa+V9li0DpVDjbxOYPuK3KM4nzRU+V67imb/M8Jvyvku82G1SDxyPOFU vwth X-Received: by 2002:a17:906:882:b0:c0e:e136:5dc9 with SMTP id a640c23a62f3a-c1fe8250f26mr15638166b.37.1785514833103; Fri, 31 Jul 2026 09:20:33 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 4/4] target/arm: Remove stale comment about WFE/SEV implementation Date: Fri, 31 Jul 2026 17:20:24 +0100 Message-ID: <20260731162024.3097467-5-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260731162024.3097467-1-peter.maydell@linaro.org> References: <20260731162024.3097467-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::535; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x535.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1785514912683158500 Content-Type: text/plain; charset="utf-8" We forgot to remove a comment about WFE/SEV only being implemented for M-profile when we added the A-profile support for this; delete the stale text. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20260728111629.1705308-4-peter.maydell@linaro.org --- target/arm/cpu.h | 1 - 1 file changed, 1 deletion(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 03a30afcbe..c0492c8dfb 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -766,7 +766,6 @@ typedef struct CPUArchState { /* * The event register is shared by all ARM profiles (A/R/M), * so it is stored in the top-level CPU state. - * WFE/SEV handling is currently implemented only for M-profile. */ bool event_register; =20 --=20 2.43.0